Update the patch and the plan files of the graphics benchmark with the latest revision
[WebKit-https.git] / Tools / ChangeLog
1 2015-11-20  Said Abou-Hallawa  <sabouhallawa@apple.com>
2
3         Update the patch and the plan files of the graphics benchmark with the latest revision
4         https://bugs.webkit.org/show_bug.cgi?id=151503
5
6         Reviewed by Ryosuke Niwa.
7         
8         The time for each graphics test has been shortened from 30 seconds to 10
9         seconds. We need to update the graphics benchmark patch and plan files so
10         we can get the results faster. Also this will allow running the benchmark
11         also on the iOS performance bots.
12
13         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:
14         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan:
15
16 2015-11-20  Michael Catanzaro  <mcatanzaro@igalia.com>
17
18         Unreviewed, fix installation of ninja-build after the previous commit
19
20         * gtk/install-dependencies:
21
22 2015-11-20  Michael Catanzaro  <mcatanzaro@igalia.com>
23
24         [GTK] install-dependencies should run installer exactly once
25         https://bugs.webkit.org/show_bug.cgi?id=151477
26
27         Reviewed by Carlos Garcia Campos.
28
29         * gtk/install-dependencies:
30
31 2015-11-20  Csaba Osztrogonác  <ossy@webkit.org>
32
33         [EFL] Enable FTL JIT by default on X86_64
34         https://bugs.webkit.org/show_bug.cgi?id=143822
35
36         Reviewed by Carlos Garcia Campos.
37
38         * Scripts/build-jsc:
39         * Scripts/run-javascriptcore-tests:
40         * Scripts/webkitperl/FeatureList.pm:
41         * efl/jhbuild.modules:
42         * gtk/jhbuildrc:
43         * jhbuild/jhbuildrc_common.py:
44         (init):
45
46 2015-11-19  Michael Catanzaro  <mcatanzaro@igalia.com>
47
48         Unreviewed, install llvm-static on Fedora to fix build now FTL is enabled
49
50         * gtk/install-dependencies:
51
52 2015-11-19  Commit Queue  <commit-queue@webkit.org>
53
54         Unreviewed, rolling out r192667 and r192668.
55         https://bugs.webkit.org/show_bug.cgi?id=151476
56
57         broke api tests (Requested by alexchristensen on #webkit).
58
59         Reverted changesets:
60
61         "Remove the non-NetworkProcess configurations"
62         https://bugs.webkit.org/show_bug.cgi?id=151418
63         http://trac.webkit.org/changeset/192667
64
65         "Fix GTK Build after r192667."
66         http://trac.webkit.org/changeset/192668
67
68 2015-11-19  Alex Christensen  <achristensen@webkit.org>
69
70         Remove the non-NetworkProcess configurations
71         https://bugs.webkit.org/show_bug.cgi?id=151418
72
73         Reviewed by Geoffrey Garen.
74
75         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
76         (TestWebKitAPI::TEST):
77         * WebKitTestRunner/TestController.cpp:
78         (WTR::TestController::generatePageConfiguration):
79
80 2015-11-19  Alexey Proskuryakov  <ap@apple.com>
81
82         LayoutTestRelay processes leak on iOS testers
83         https://bugs.webkit.org/show_bug.cgi?id=151447
84
85         Reviewed by Tim Horton.
86
87         * BuildSlaveSupport/kill-old-processes: Added LayoutTestRelay.
88
89 2015-11-19  Brent Fulgham  <bfulgham@apple.com>
90
91         [Win] webkitpy is applying abspath to DOS paths, yielding invalid paths
92         https://bugs.webkit.org/show_bug.cgi?id=151156
93
94         Unreviewed test fix.
95         
96         I tracked down the cause of the test regression on the Windows builders. Once I fixed that,
97         I realized that the new 'abs_results_directory' value was not needed, so this change reverts
98         that code.
99
100         * Scripts/webkitpy/port/base.py:
101         (Port.to.start_websocket_server): We don't need a special directory variable on Cygwin anymore.
102         (Port.abs_results_directory): Deleted.
103         * Scripts/webkitpy/port/win.py:
104         (WinPort.__init__): Deleted.
105         (WinPort.abs_results_directory): Deleted.
106         (WinPort.results_directory): Deleted.
107
108 2015-11-19  Alexey Proskuryakov  <ap@apple.com>
109
110         build.webkit.org/dashboard: Move layoutTestResultsDirectoryURLForIteration implementation to base class
111         https://bugs.webkit.org/show_bug.cgi?id=151425
112
113         Reviewed by Tim Horton.
114
115         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
116         (Buildbot.prototype.layoutTestResultsDirectoryURLForIteration):
117         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
118         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Deleted.
119
120 2015-11-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
121
122         WPT server should use its own testharness.js file and generate a warning when it does not match WebKit version
123         https://bugs.webkit.org/show_bug.cgi?id=150332
124
125         Reviewed by Darin Adler and Ryosuke Niwa.
126
127         Removing testharness.js overwriting from LayoutTests/resources to LayoutTests/imported/w3c/web-platform-tests/resources.
128         Adding support for file comparison in python filesystem.
129         #NousSommesUnis.
130
131         * Scripts/webkitpy/common/system/filesystem.py:
132         (FileSystem.compare): Adding compare as a wrapper around filecmp.cmp.
133         * Scripts/webkitpy/common/system/filesystem_mock.py:
134         (MockFileSystem.compare): Adding a mock compare.
135         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
136         (WebPlatformTestServer.__init__): Removed testharness.js as file to copy from WK to WPT.
137         (WebPlatformTestServer._copy_webkit_test_files): Added warning generation when WK testharness.js is not matching WPT version.
138         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
139         (TestWebPlatformTestServer.test_previously_spawned_instance): Updated tests to add testharness.js to mock filesystem.
140         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
141
142 2015-11-18  Jiewen Tan  <jiewen_tan@apple.com>
143
144         [WK1] Crash loading Blink layout test fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
145         https://bugs.webkit.org/show_bug.cgi?id=150198
146         <rdar://problem/23136026>
147
148         Reviewed by Brent Fulgham.
149
150         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
151         (WTR::TestRunner::inspectorTestStubURL):
152         Since WebInspectorUI.framework is not available for iOS, the framework
153         and corresponding functions are disabled in iOS.
154
155 2015-11-18  Alexey Proskuryakov  <ap@apple.com>
156
157         [Mac] Swipe tests depend on user preferences
158         https://bugs.webkit.org/show_bug.cgi?id=151403
159
160         Reviewed by Tim Horton.
161
162         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
163         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
164         Override these preferences to match the default for a new OS X installation.
165
166         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
167         Swipe tests are not enabled in WK1, but let's override the default anyway.
168
169 2015-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
170
171         [GTK] Update xserver version in jhbuild
172         https://bugs.webkit.org/show_bug.cgi?id=151383
173
174         Reviewed by Alejandro G. Castro.
175
176         In r192568 I assumed the bots would have a recent enough Xvfb
177         to use the -displayfd option, but I forgot we build our own
178         xserver just for Xvfb. The version we build is too old, so
179         we could just use an updated version (the same bots have
180         installed, for example) to use the -displayfd option.
181
182         * gtk/jhbuild.modules: Update xserver to 1.16.4.
183         * gtk/patches/xserver-fix-glx-init.patch: Deleted.
184         * gtk/patches/xserver-remove-bogus-dependencies.patch: Updated to
185         apply on 1.16.4.
186
187 2015-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
188
189         Unreviewed. Fix webkitpy tests after r192568.
190
191         Instead of ignoring exception when closing mock fds, use a helper
192         function that the unit test can override to do nothing.
193
194         * Scripts/webkitpy/port/xvfbdriver.py:
195         (XvfbDriver._xvfb_close_pipe):
196         (XvfbDriver._xvfb_run):
197         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
198         (XvfbDriverTest.make_driver):
199
200 2015-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
201
202         [XvfbDriver] Fail to run all layout tests when X server started with -displayfd option
203         https://bugs.webkit.org/show_bug.cgi?id=151135
204
205         Reviewed by Darin Adler.
206
207         The XvfbDriver uses the x server command line to check the
208         displays that are currently in use. This doesn't work when X
209         server was started with -displayfd option. This option is used to let
210         the server find the display id available that is written to the
211         given file descriptor. With this option xorg doesn't need to
212         create the lock files in tmp either. The -displayfd option is also
213         available in Xvfb, so we could use it too. That would simplify the
214         code, fixing also race conditions between the check for available
215         displays and Xvfb opening the connection, we wouldn't need to wait
216         for 4 seconds after launching Xvfb, and all lock files we are
217         using won't be needed either.
218
219         * Scripts/webkitpy/port/xvfbdriver.py:
220         (XvfbDriver._xvfb_pipe): Helper function to create the pipe, only
221         needed to be overriden by unit tests.
222         (XvfbDriver._xvfb_read_display_id): Helper function to read from
223         the pipe, only needed to be overriden by unit tests.
224         (XvfbDriver._xvfb_run): Run Xvfb with -displayfd option, using a
225         pipe to read the display id.
226         (XvfbDriver._start): Call _xvfb_run() and remove the code to run
227         Xvfb for a given display.
228         (XvfbDriver.stop): Remove code to release and delete file locks.
229         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
230         (XvfbDriverTest.make_driver):
231         (XvfbDriverTest.test_start):
232         (XvfbDriverTest.test_start_arbitrary_worker_number):
233         (XvfbDriverTest.test_stop):
234         (XvfbDriverTest.assertDriverStartSuccessful): Deleted.
235         (XvfbDriverTest): Deleted.
236         (XvfbDriverTest.test_stop.FakeXvfbProcess): Deleted.
237
238 2015-11-17  Alexey Proskuryakov  <ap@apple.com>
239
240         run-webkit-tests should not truncate persistent lines
241         https://bugs.webkit.org/show_bug.cgi?id=151376
242         rdar://problem/23162775
243
244         Reviewed by Antti Koivisto.
245
246         It is OK to truncate progress lines, but it's not OK to truncate error (or otherwise
247         unexpected result) messages that remain on the screen to be read. In practice, this
248         almost always truncates the test path, which is important to see.
249
250         * Scripts/webkitpy/layout_tests/views/printing.py:
251         (Printer._test_status_line):
252         (Printer.print_finished_test):
253         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
254         (Testprinter.test_test_status_line):
255
256 2015-11-16  Carlos Garcia Campos  <cgarcia@igalia.com>
257
258         Unreviewed. Fix GTK+ unit tests after r192469.
259
260         In r192469 jhbuild version was updated and coinfig lcas API changed.
261
262         * jhbuild/jhbuildutils.py:
263         (enter_jhbuild_environment_if_available): Pass an empty list for
264         conditions to the Config constructor.
265
266 2015-11-16  Carlos Garcia Campos  <cgarcia@igalia.com>
267
268         Unreviewed. Use commit id instead of tag name for jhbuild revision.
269
270         In r192469 I updated the jhbuild version to 3.12.0, and used the
271         tag instead of the commit id to make it easier to read and
272         remember. But we use the commit id to check if the current
273         revision is up to date, and when compared to the tag id it always
274         fails and jhbuild is always updated.
275
276         * jhbuild/jhbuild-wrapper: Use commit id and add a comment to
277         remember this is the id of 3.12.0.
278
279 2015-11-16  Carlos Garcia Campos  <cgarcia@igalia.com>
280
281         Unreviewed. Fix GTK+ layout tests running after r192469.
282
283         We fail to find the Gallium llvmpipe driver because of the build
284         directory change in r192469.
285
286         * gtk/jhbuildrc: Use buildroot instead of checkoutdir to build
287         the LLVMPIPE_LIBGL_PATH.
288
289 2015-11-16  Carlos Garcia Campos  <cgarcia@igalia.com>
290
291         [GTK] Use FTL by default when LLVM 3.7 is available
292         https://bugs.webkit.org/show_bug.cgi?id=142128
293
294         Reviewed by Csaba Osztrogonác.
295
296         * Scripts/run-javascriptcore-tests: Enable FTL for GTK+ port when
297         architecture is x86_64.
298         * Scripts/update-webkit-libs-jhbuild:
299         (cleanJhbuild): Remove also the separate Build directory used by
300         GTK+ port now.
301         * Scripts/webkitdirs.pm:
302         (isX86_64):
303         * Scripts/webkitperl/FeatureList.pm: Enable FTL by default for
304         GTK+ port when architecture is x86_64.
305         * gtk/jhbuild-optional.modules: Remove llvm.
306         * gtk/jhbuild.modules: Add llvm 3.7 and include it as dependecy
307         only when architecture is x86_64.
308         * gtk/jhbuildrc: Set a buildroot to use a separate build
309         directory. LLVM 3.7 fails to build if configure script is run from
310         source dir. Since it's not possible to use a separate build dir
311         only for llvm, we do it now globally. Modules not supporting non
312         source build dirs are marked in the moduleset. Also set x86_64
313         condition when the architecture is x86_64.
314         * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
315         * gtk/patches/llvm-elf-add-stackmaps.patch: Removed.
316         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
317         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed.
318         * jhbuild/jhbuild-wrapper: Use a newer jhbuild version to be able
319         to use conditions.
320
321 2015-11-15  Commit Queue  <commit-queue@webkit.org>
322
323         Unreviewed, rolling out r192462.
324         https://bugs.webkit.org/show_bug.cgi?id=151295
325
326         failing python tests (Requested by youenn on #webkit).
327
328         Reverted changeset:
329
330         "WPT server should use its own testharness.js file and
331         generate a warning when it does not match WebKit version"
332         https://bugs.webkit.org/show_bug.cgi?id=150332
333         http://trac.webkit.org/changeset/192462
334
335 2015-11-15  Youenn Fablet  <youenn.fablet@crf.canon.fr>
336
337         WPT server should use its own testharness.js file and generate a warning when it does not match WebKit version
338         https://bugs.webkit.org/show_bug.cgi?id=150332
339
340         Reviewed by Darin Adler.
341
342         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
343         (WebPlatformTestServer.__init__): Removed testharness.js as file to copy from WK to WPT.
344         (WebPlatformTestServer._copy_webkit_test_files): Added warning generation when WK testharness.js is not matching WPT version.
345
346 2015-11-14  Nan Wang  <n_wang@apple.com>
347
348         AX: add a new trait for elements in fieldset on iOS
349         https://bugs.webkit.org/show_bug.cgi?id=151281
350
351         Reviewed by Chris Fleizach.
352
353         * DumpRenderTree/AccessibilityUIElement.cpp:
354         (assistiveTechnologySimulatedFocusCallback):
355         (fieldsetAncestorElementCallback):
356         (childAtIndexCallback):
357         (getElementTextLengthCallback):
358         (hasContainedByFieldsetTraitCallback):
359         (AccessibilityUIElement::getJSClass):
360         * DumpRenderTree/AccessibilityUIElement.h:
361         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
362         (AccessibilityUIElement::elementTextLength):
363         (AccessibilityUIElement::hasContainedByFieldsetTrait):
364         (AccessibilityUIElement::fieldsetAncestorElement):
365         (AccessibilityUIElement::url):
366         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
367         (WTR::AccessibilityUIElement::scrollPageDown):
368         (WTR::AccessibilityUIElement::scrollPageLeft):
369         (WTR::AccessibilityUIElement::scrollPageRight):
370         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
371         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
372         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
373         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
374         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
375         (WTR::AccessibilityUIElement::identifier):
376         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
377         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
378         (WTR::AccessibilityUIElement::rowCount):
379
380 2015-11-13  Keith Miller  <keith_miller@apple.com>
381
382         Unreviewed, change JavaScriptCore watchlist to exclude inspector things.
383
384         * Scripts/webkitpy/common/config/watchlist:
385
386 2015-11-13  Tim Horton  <timothy_horton@apple.com>
387
388         Support printing in WKWebView
389         https://bugs.webkit.org/show_bug.cgi?id=151276
390         <rdar://problem/23525715>
391
392         Reviewed by Beth Dakin.
393
394         * MiniBrowser/mac/MainMenu.xib:
395         * MiniBrowser/mac/WK1BrowserWindowController.m:
396         (-[WK1BrowserWindowController printWebView:]):
397         * MiniBrowser/mac/WK2BrowserWindowController.m:
398         (-[WK2BrowserWindowController printWebView:]):
399         Hook up printing to Minibrowser!
400
401 2015-11-13  Tim Horton  <timothy_horton@apple.com>
402
403         Hardware keyboard spacebar scrolls too far on iOS
404         https://bugs.webkit.org/show_bug.cgi?id=151227
405         <rdar://problem/23500681>
406
407         Reviewed by Simon Fraser.
408
409         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
410         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
411         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
412         (WTR::UIScriptController::setDidEndScrollingCallback):
413         (WTR::UIScriptController::didEndScrollingCallback):
414         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
415         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
416         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
417         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
418         (-[TestRunnerWKWebView dealloc]):
419         (-[TestRunnerWKWebView _didFinishScrolling]):
420         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
421         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
422         (WTR::UIScriptController::platformClearAllCallbacks):
423         Expose _didFinishScrolling on WKWebView to the UIScriptController.
424
425 2015-11-13  Brent Fulgham  <bfulgham@apple.com>
426
427         [Win] Unreviewed test fix.
428
429         * Scripts/webkitpy/port/win.py:
430         (WinPort.results_directory): Our 'results_directory' should be an absolute path (even when not
431         using Cygwin), but should be in DOS format for non-Cygwin clients.
432
433 2015-11-12  Daniel Bates  <dabates@apple.com>
434
435         Add my apple.com email address to contributors.json
436
437         * Scripts/webkitpy/common/config/contributors.json:
438
439 2015-11-12  Daniel Bates  <dabates@apple.com>
440
441         webkitpy: Remove extraneous word "the" from the description of command attach-to-bug
442
443         * Scripts/webkitpy/tool/commands/upload.py:
444         (AttachToBug):
445
446 2015-11-12  Brent Fulgham  <bfulgham@apple.com>
447
448         [Win] webkitpy is applying abspath to DOS paths, yielding invalid paths
449         https://bugs.webkit.org/show_bug.cgi?id=151156
450
451         Reviewed by Anders Carlsson.
452
453         My earlier patch was incomplete. There are some Python libraries that want
454         to receive UNIX style paths, even though all of our applications and tools
455         use DOS paths. To handle this special case, we need to track a UNIX-style
456         absolute path that can be given to things like the Python socket server.
457         
458         When we cut over to all-native Windows Python we can get rid of this
459         special case code.
460         
461         * Scripts/webkitpy/common/system/filesystem.py:
462         (FileSystem.abspath): Add special code for Cygwin to convert a DOS-style
463         path into something Cygwin can use internally.
464         * Scripts/webkitpy/port/base.py:
465         (Port.results_directory): Remove custom Windows code. Instead, override
466         the method in the windows port object.
467         (Port.abs_results_directory): Add stub.
468         (Port.to.start_websocket_server): For Cygwin, use special cygwin absolute
469         path.
470         * Scripts/webkitpy/port/win.py:
471         (WinPort.__init__): Added to initialze new _abs_results_directory value.
472         (WinPort.abs_results_directory): Added,
473         (WinPort.results_directory): Modified to also create a value for
474         _abs_results_directory
475
476 2015-11-12  Keith Miller  <keith_miller@apple.com>
477
478         Unreviewed, add Michael Saboff to the JavaScriptCore watchlist, per request.
479
480         * Scripts/webkitpy/common/config/watchlist:
481
482 2015-11-12  Keith Miller  <keith_miller@apple.com>
483
484         Unreviewed, add watchlist for Source/JavaScriptCore and add myself, Saam, and Mark.
485
486         * Scripts/webkitpy/common/config/watchlist:
487
488 2015-11-12  Daniel Bates  <dabates@apple.com>
489
490         Support building configuration Production of DumpRenderTree and WebKitTestRunner for iOS
491         https://bugs.webkit.org/show_bug.cgi?id=151191
492
493         Reviewed by Andy Estes.
494
495         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove hardcoded SKIP_INTALL.
496         Will override this setting in DumpRenderTree.xcconfig.
497         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: When building for iOS we now
498         compile source file DumpRenderTreeMain.mm to produce a built product and make the Apple
499         Internal build system happy. Do not waste time coping OpenType font files (*.otf files)
500         and skip installation when building for iOS since we are not interested in the build product
501         and are only building this target to make the Apple Internal build system happy.
502         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
503         (main): Added dummy implementation for iOS so that we build an actual command line tool to
504         make the Apple Internal build system happy.
505         * WebKitTestRunner/Configurations/Base.xcconfig: Add iOS-specific definition for WEBKIT_UMBRELLA_FRAMEWORKS_DIR.
506         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Remove variable WEBKIT_UMBRELLA_FRAMEWORKS_DIR.
507         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Build file WebKitTestRunner/mac/main.mm
508         on iOS Only to produce a built product and make the Apple Internal build system happy. No need
509         to define OTHER_LDFLAGS when building this target for iOS as the default linker flags are sufficient.
510         * WebKitTestRunner/mac/main.mm:
511         (main): Added dummy implementation for iOS so that we build an actual command line tool to
512         make the Apple Internal build system happy.
513
514 2015-11-12  Chris Dumez  <cdumez@apple.com>
515
516         Unreviewed, add watchlist for history/ and add myself.
517
518         * Scripts/webkitpy/common/config/watchlist:
519
520 2015-11-12  Chris Dumez  <cdumez@apple.com>
521
522         Unreviewed, update my watchlists.
523
524         * Scripts/webkitpy/common/config/watchlist:
525
526 2015-11-12  Daniel Bates  <dabates@apple.com>
527
528         Rename webkitdirs::willUseIOS{Device, Simulator}SDKWhenBuilding() to willUseIOS{Device, Simulator}SDK()
529         https://bugs.webkit.org/show_bug.cgi?id=151207
530
531         Rubber-stamped by Alexey Proskuryakov.
532
533         The functions webkitdirs::willUseIOS{Device, Simulator}SDKWhenBuilding() are not specific to building
534         iOS software. We should rename these functions to webkitdirs::willUseIOS{Device, Simulator}SDK() to
535         convey their general-purpose nature of determining whether we are using the iphoneos or iphonesimulator SDK.
536
537         * Scripts/build-jsc:
538         * Scripts/build-layouttestrelay:
539         * Scripts/build-webkit:
540         * Scripts/copy-webkitlibraries-to-product-directory:
541         * Scripts/run-api-tests:
542         (runTest):
543         (prepareEnvironmentForRunningTestTool):
544         * Scripts/run-javascriptcore-tests:
545         * Scripts/webkitdirs.pm:
546         (XcodeOptions):
547         (willUseIOSDeviceSDK): Formerly named willUseIOSDeviceSDKWhenBuilding.
548         (willUseIOSSimulatorSDK): Formerly name willUseIOSSimulatorSDKWhenBuilding.
549         (isIOSWebKit):
550         (runIOSWebKitApp):
551         (willUseIOSDeviceSDKWhenBuilding): Deleted.
552         (willUseIOSSimulatorSDKWhenBuilding): Deleted.
553
554 2015-11-12  Daniel Bates  <dabates@apple.com>
555
556         run-api-tests fails to run with public iOS SDK
557         https://bugs.webkit.org/show_bug.cgi?id=151076
558
559         Reviewed by Alexey Proskuryakov.
560
561         Use the command line tool simctl as the sim tool was removed from the public iOS 9 SDK.
562
563         A side benefit of this change it is sufficient to run the tests without launching Simulator.app
564         to boot the simulator device beforehand because simctl will boot the device for us.
565
566         Additionally, use Perl pragma sigtrap to install signal handlers to catch SIG{HUP, INT, PIPE, TERM}
567         signals and ultimately run our END block so that we shutdown the simulator device (if applicable).
568         This makes Control-C terminate the app gracefully.
569
570         * Scripts/run-api-tests:
571         (runTest):
572         (listAllTests):
573         (prepareEnvironmentForRunningTestTool): When running for iOS Simulator use setupIOSWebKitEnvironment()
574         to setup the environment variables for iOS instead of using setupMacWebKitEnvironment(). We also
575         prefix the name of these environment variables with "SIMCTL_CHILD_" so that simctl sets these environment
576         variables in the simulator environment.
577         * Scripts/webkitdirs.pm:
578         (shutDownIOSSimulatorDevice): Added.
579         (restartIOSSimulatorDevice): Added.
580
581 2015-11-12  KwangHyuk Kim  <hyuki.kim@samsung.com>
582
583         [EFL] fix EvasGL configuration error
584         https://bugs.webkit.org/show_bug.cgi?id=151180
585
586         Reviewed by Csaba Osztrogonác.
587
588         EvasGL backend and depth, stencil buffer size should be specified before elm_win_add to let EvasGL keep quiet.
589         Additionally, duplicated elm_config_accel_preference_set() call is eleminated.  
590
591         * MiniBrowser/efl/main.c:
592         (window_create):
593         (elm_main):
594
595 2015-11-12  Csaba Osztrogonác  <ossy@webkit.org>
596
597         [EFL] Fix EFL 1.16 with enabled NEON support
598         https://bugs.webkit.org/show_bug.cgi?id=151188
599
600         Unreviewed buildfix, disable NEON temporarily after r192358.
601
602         * efl/jhbuild.modules:
603
604 2015-11-12  Csaba Osztrogonác  <ossy@webkit.org>
605
606         [EFL] Bump EFL version to 1.16.0
607         https://bugs.webkit.org/show_bug.cgi?id=150228
608
609         Reviewed by Gyuyoung Kim.
610
611         * efl/jhbuild.modules:
612         * efl/patches/efl-remove-XPrint.patch: Removed.
613
614 2015-11-12  Csaba Osztrogonác  <ossy@webkit.org>
615
616         Remove ENABLE(SATURATED_LAYOUT_ARITHMETIC) guards
617         https://bugs.webkit.org/show_bug.cgi?id=150972
618
619         Reviewed by Darin Adler.
620
621         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
622
623 2015-11-12  KwangHyuk Kim  <hyuki.kim@samsung.com>
624
625         [EFL] fix EvasGL configuration error
626         https://bugs.webkit.org/show_bug.cgi?id=151180
627
628         Reviewed by Gyuyoung Kim.
629
630         EvasGL backend and depth, stencil buffer size should be specified before elm_win_add to let EvasGL keep quiet
631
632         * MiniBrowser/efl/main.c:
633         (window_create):
634
635 2015-11-11  Brent Fulgham  <bfulgham@apple.com>
636
637         [Win] webkitpy is applying abspath to DOS paths, yielding invalid paths
638         https://bugs.webkit.org/show_bug.cgi?id=151156
639
640         Reviewed by Anders Carlsson.
641
642         * Scripts/webkitpy/port/base.py:
643         (Port.results_directory): Don't pass paths through 'abspath'
644         (Port._build_path): Ditto.
645         * Scripts/webkitpy/port/win.py:
646         (WinPort._build_path): Ditto.
647
648 2015-11-11  Akos Kiss  <akiss@inf.u-szeged.hu>
649
650         Unreviewed, add myself to the committers list.
651
652         * Scripts/webkitpy/common/config/contributors.json:
653
654 2015-11-11  Anders Carlsson  <andersca@apple.com>
655
656         _WKRemoteObjectInterface should handle specifying allowed classes for reply block arguments
657         https://bugs.webkit.org/show_bug.cgi?id=151144
658
659         Reviewed by Tim Horton.
660
661         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
662         (remoteObjectInterface):
663         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
664         (TEST):
665         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
666         (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
667         (-[RemoteObjectRegistryPlugIn selectionAndClickInformationForClickAtPoint:completionHandler:]):
668
669 2015-11-10  Wenson Hsieh  <wenson_hsieh@apple.com>
670
671         UI-side scripts in WebKitTestRunner should wait until event handling completes before finishing
672         https://bugs.webkit.org/show_bug.cgi?id=151101
673         <rdar://problem/23428601>
674
675         Reviewed by Simon Fraser.
676
677         WebKitTestRunner may still crash in the scenario where a marker event is dequeued and handled
678         after uiScriptComplete has been called. This patch teaches the UI script execution context to
679         defer script completion until all non-persistent tasks (currently tap, double tap and hardware
680         keyboard) have been handled, so marker events will no longer bleed through tests.
681
682         We accomplish this by changing the behavior of uiScriptComplete. When calling uiScriptComplete,
683         we store that a request to complete the UI-side script for the current parent callback has been
684         made. Subsequently, when a callback (either persistent or non-persistent) finishes invoking and
685         a request has been made to complete the UI script (this request may have been made when running
686         a previous callback) we check if all the non-persistent callbacks that have the same parent
687         callback as the current one have finished. If so, we complete the callback immediately;
688         otherwise, we wait until the in-flight non-persistent callbacks finish execution to complete the
689         UI script.
690
691         This patch also refactors some logic in UIScriptContext. It introduces a new convention for
692         assigning IDs to callbacks: IDs 1000 and above are treated as non-persistent callbacks, whereas
693         IDs between 0 and 999 are persistent task callbacks. This is similar to the existing convention
694         for assigning IDs in the 100s range to parent callbacks, and allows us to easily differentiate
695         between callbacks that are persistent and non-persistent, as well as determine when an existing
696         persistent callback must be unregistered before a new callback function can be set.
697
698         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
699         (isPersistentCallbackID):
700         (UIScriptContext::runUIScript):
701         (UIScriptContext::nextTaskCallbackID):
702         (UIScriptContext::prepareForAsyncTask):
703         (UIScriptContext::asyncTaskComplete):
704         (UIScriptContext::registerCallback):
705         (UIScriptContext::fireCallback):
706         (UIScriptContext::requestUIScriptCompletion):
707         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
708         (UIScriptContext::currentParentCallbackHasOutstandingAsyncTasks):
709         (UIScriptContext::uiScriptComplete): Deleted.
710         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
711         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
712         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
713         (WTR::UIScriptController::setWillBeginZoomingCallback):
714         (WTR::UIScriptController::willBeginZoomingCallback):
715         (WTR::UIScriptController::setDidEndZoomingCallback):
716         (WTR::UIScriptController::didEndZoomingCallback):
717         (WTR::UIScriptController::setDidShowKeyboardCallback):
718         (WTR::UIScriptController::didShowKeyboardCallback):
719         (WTR::UIScriptController::setDidHideKeyboardCallback):
720         (WTR::UIScriptController::didHideKeyboardCallback):
721         (WTR::UIScriptController::uiScriptComplete):
722         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
723         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
724         (WTR::UIScriptController::doAsyncTask):
725         (WTR::UIScriptController::zoomToScale):
726         (WTR::UIScriptController::singleTapAtPoint):
727         (WTR::UIScriptController::doubleTapAtPoint):
728         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
729         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
730         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
731         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
732         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
733         (WTR::UIScriptController::platformClearAllCallbacks): Deleted.
734         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
735         (WTR::UIScriptController::doAsyncTask):
736
737 2015-11-10  Daniel Bates  <dabates@apple.com>
738
739         Teach Makefile to build LayoutTestRelay when building for iOS Simulator
740         https://bugs.webkit.org/show_bug.cgi?id=150849
741
742         Reviewed by Alexey Proskuryakov.
743
744         Unless variable DO_NOT_BUILD_LAYOUT_TEST_RELAY is non-empty, build LayoutTestRelay when
745         building WebKit tools.
746
747         * Makefile:
748
749 2015-11-10  David Kilzer  <ddkilzer@apple.com>
750
751         [check-webkit-style] False positive (readability/enum_casing) on CF-styled enum members
752         <http://webkit.org/b/104417>
753
754         Reviewed by Brent Fulgham.
755
756         * Scripts/webkitpy/style/checkers/cpp.py:
757         (_EnumState.process_clean_line): Allow 'k' to start enums.
758         (check_enum_casing): Update error message to discuss 'k'.
759         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
760         (NoNonVirtualDestructorsTest.test_enum_casing): Update error
761         messages, and add new tests for enums that start with lowercase
762         letters.
763
764 2015-11-10  Geoffrey Garen  <ggaren@apple.com>
765
766         run-jsc-benchmarks doesn't work with internal benchmarks
767         https://bugs.webkit.org/show_bug.cgi?id=151047
768
769         Reviewed by Filip Pizlo.
770
771         * Scripts/run-jsc-benchmarks: Use Pathname so we get a "/" inserted when
772         we concatenate.
773
774 2015-11-10  Carlos Garcia Campos  <cgarcia@igalia.com>
775
776         [GTK] Use CROSS_PLATFORM_CONTEXT_MENUS
777         https://bugs.webkit.org/show_bug.cgi?id=150642
778
779         Reviewed by Martin Robinson.
780
781         Remove test for input methods submenu.
782
783         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
784
785 2015-11-09  Joonghun Park  <jh718.park@samsung.com>
786
787         Unreviewed, add myself to the committers list.
788
789         * Scripts/webkitpy/common/config/contributors.json:
790
791 2015-11-09  Ryuan Choi  <ryuan.choi@navercorp.com>
792
793         [EFL] Crash while opening child webview with EWK_PROCESS_MODEL_MULTIPLE_SECONDARY
794         https://bugs.webkit.org/show_bug.cgi?id=145924
795
796         Reviewed by Gyuyoung Kim.
797
798         * MiniBrowser/efl/main.c:
799         (on_window_create):
800         (window_create):
801         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
802         (TestWebKitAPI::TEST):
803         * TestWebKitAPI/efl/PlatformWebView.cpp:
804         (TestWebKitAPI::PlatformWebView::PlatformWebView):
805         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
806         (WTR::PlatformWebView::PlatformWebView):
807
808 2015-11-09  Anders Carlsson  <andersca@apple.com>
809
810         Add reply blocks to _WKRemoteObjectInterface similar to NSXPCConnection
811         https://bugs.webkit.org/show_bug.cgi?id=151056
812         rdar://problem/23222609
813
814         Reviewed by Tim Horton.
815
816         Update test.
817
818         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
819         (TEST):
820         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
821         (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
822
823 2015-11-09  Tim Horton  <timothy_horton@apple.com>
824
825         Add drawsBackground SPI to WKWebView, and get rid of drawsTransparentBackground from WebKit2
826         https://bugs.webkit.org/show_bug.cgi?id=151054
827         <rdar://problem/22907994>
828
829         Reviewed by Simon Fraser.
830
831         * MiniBrowser/mac/WK1BrowserWindowController.m:
832         (-[WK1BrowserWindowController didChangeSettings]):
833         * MiniBrowser/mac/WK2BrowserWindowController.m:
834         (-[WK2BrowserWindowController didChangeSettings]):
835         Use drawsBackground instead, and make sure to set the window background color,
836         otherwise it might end up being gray anyway!
837
838         WebKit1 still doesn't work unless you turn off toolbar blurring, but at least
839         WebKit2 is working now!
840
841 2015-11-09  Isaac Devine  <isaac@devinesystems.co.nz>
842
843         Fresh checkout fails to build on windows, DumpRenderTree can't find cairo_win.h
844         https://bugs.webkit.org/show_bug.cgi?id=151013
845
846         Use the variable defined in the CMake scripts to determine the cairo include location, rather
847         than relying on a environment variable to be set correctly. Otherwise the DumpRenderTreeLib.vcxproj will
848         contain "\include\cairo" rather than the fully qualified path to the cairo include location.
849
850         Reviewed by Darin Adler.
851
852         * DumpRenderTree/PlatformWin.cmake:
853
854 2015-11-09  Csaba Osztrogonác  <ossy@webkit.org>
855
856         [EFL] Fix the gst-plugins-bad jhbuild module build on Ubuntu 15.10
857         https://bugs.webkit.org/show_bug.cgi?id=150928
858
859         Reviewed by Gyuyoung Kim.
860
861         * efl/jhbuild.modules:
862
863 2015-11-07  Daniel Bates  <dabates@apple.com>
864
865         Attempt to fix the Windows EWS bot after r192087
866         (https://bugs.webkit.org/show_bug.cgi?id=150859)
867
868         Following r192087 Port._build_path() stores the computed root directory path in option
869         _cached_root instead of overwriting option root. We need to teach the Windows-specific
870         logic to make use of option _cached_root instead of option root when computing its adjusted
871         path and to cache its adjusted in _cached_root instead of root.
872
873         * Scripts/webkitpy/port/win.py:
874         (WinPort._build_path):
875
876 2015-11-06  Daniel Bates  <dabates@apple.com>
877
878         Do not build LayoutTestRelay when --root is specified to run-webkit-tests
879         https://bugs.webkit.org/show_bug.cgi?id=150989
880
881         Reviewed by Alexey Proskuryakov.
882
883         The script run-webkit-tests should only check if LayoutTestRelay exists when invoked with
884         --root and exit with an error if it does not exist. That is, we should not build LayoutTestRelay
885         when it does not exist and an explicit directory of built executables was specified via --root.
886         This will make the criterion for building LayoutTestRelay match the criterion for building
887         DumpRenderTree/WebKitTestRunner.
888
889         * Scripts/webkitpy/port/ios.py:
890         (IOSSimulatorPort._check_port_build): Moved logic from IOSSimulatorPort.{_check_build_relay, check_build} to here.
891         (IOSSimulatorPort._check_build_relay): Deleted.
892         (IOSSimulatorPort.check_build): Deleted.
893
894 2015-11-06  Tim Horton  <timothy_horton@apple.com>
895
896         Add preliminary (SPI) support for NSTextFinder on WKWebView
897         https://bugs.webkit.org/show_bug.cgi?id=150907
898         <rdar://problem/19171624>
899
900         Reviewed by Darin Adler.
901
902         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
903         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm: Added.
904         (-[FindInPageNavigationDelegate webView:didFinishNavigation:]):
905         (TEST):
906         Add an API test.
907
908         * WebEditingTester/WK1WebDocumentController.m:
909         * WebEditingTester/WK2WebDocumentController.m:
910         (-[WK2WebDocumentController awakeFromNib]):
911         (-[WK2WebDocumentController contentView]):
912         Use incremental find, and show the overlay/indicator.
913
914 2015-11-06  Alexey Proskuryakov  <ap@apple.com>
915
916         iOS test results are not visible on the flakiness dashboard
917         https://bugs.webkit.org/show_bug.cgi?id=150884
918
919         Reviewed by Darin Adler.
920
921         One more change was needed for the minimal fix.
922
923         * TestResultServer/static-dashboards/flakiness_dashboard.js:
924
925 2015-11-06  Daniel Bates  <dabates@apple.com>
926
927         Teach Makefile to build LayoutTestRelay when building for iOS Simulator
928         https://bugs.webkit.org/show_bug.cgi?id=150849
929
930         Reviewed by Alexey Proskuryakov.
931
932         Override the user-specified arguments SDKROOT and ARCHS to use the default SDK
933         and default ARCHS since LayoutTestRelay is a Mac command line tool.
934
935         * LayoutTestRelay/Makefile: Define OVERRIDE_SDKROOT and OVERRIDE_ARCHS.
936
937 2015-11-05  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
938
939         Add runtime and compile time flags for enabling Web Animations API and model.
940         https://bugs.webkit.org/show_bug.cgi?id=150914
941
942         Reviewed by Benjamin Poulain.
943
944         Add ENABLE_WEB_ANIMATIONS compile time flag, runtime flag webAnimationsEnabled and Expose WK2 preference for runtime flag.
945
946         * Scripts/webkitperl/FeatureList.pm:
947
948 2015-11-05  Ryuan Choi  <ryuan.choi@navercorp.com>
949
950         [EFL] Separate beforeunload confirm callback from confirm callback
951         https://bugs.webkit.org/show_bug.cgi?id=150964
952
953         Reviewed by Gyuyoung Kim.
954
955         * MiniBrowser/efl/main.c:
956         (on_javascript_before_unload_confirm):
957         (window_create):
958
959 2015-11-05  Jason Marcell  <jmarcell@apple.com>
960
961         run-webkit-test should look in --root directory for LayoutTestRelay
962         https://bugs.webkit.org/show_bug.cgi?id=150859
963
964         Reviewed by Daniel Bates.
965
966         For iOS run-webkit-tests, use LayoutTestRelay specified by --root; otherwise find
967         LayoutTestRelay in the Mac build directory when --root is unspecified.
968
969         * Scripts/webkitpy/port/base.py:
970         (Port._build_path): Use '_cached_root' instead of 'root' so that we don't overwrite the
971         argument that was passed in via the --root argument.
972         * Scripts/webkitpy/port/ios.py:
973         (IOSSimulatorPort.relay_path):
974
975 2015-11-05  David Kilzer  <ddkilzer@apple.com>
976
977         TestWebKitAPI crashed in TestWebKitAPI: TestWebKitAPI::SharedBufferTest_copyBufferCreatedWithContentsOfExistingFile_Test::TestBody
978         <http://webkit.org/b/150931>
979         <rdar://problem/23409384>
980
981         Reviewed by Youenn Fablet.
982
983         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
984         (TestWebKitAPI::TEST_F(SharedBufferTest, copyBufferCreatedWithContentsOfExistingFile)):
985         - Switch from strnstr() to memcmp() since strings are
986           not guaranteed to be NULL-terminated.
987         - Add another expectation that the size is greater than
988           zero since memcmp() returns 0 (matching) if the length
989           argument is zero.
990         (TestWebKitAPI::TEST_F(SharedBufferTest, appendBufferCreatedWithContentsOfExistingFile)):
991         - Same change to keep tests consistent, although the
992           second string is NULL-terminated in this case.
993
994 2015-11-05  Commit Queue  <commit-queue@webkit.org>
995
996         Unreviewed, rolling out r192073.
997         https://bugs.webkit.org/show_bug.cgi?id=150962
998
999         "Broke the internal iOS build; will investigate offline"
1000         (Requested by dydz on #webkit).
1001
1002         Reverted changeset:
1003
1004         "Teach Makefile to build LayoutTestRelay when building for iOS
1005         Simulator"
1006         https://bugs.webkit.org/show_bug.cgi?id=150849
1007         http://trac.webkit.org/changeset/192073
1008
1009 2015-11-05  Daniel Bates  <dabates@apple.com>
1010
1011         Teach Makefile to build LayoutTestRelay when building for iOS Simulator
1012         https://bugs.webkit.org/show_bug.cgi?id=150849
1013
1014         Reviewed by Alexey Proskuryakov.
1015
1016         * LayoutTestRelay/Makefile: Temporarily override SDKROOT when it is iphonesimulator so
1017         that we build with the default SDK. We assume that the default SDK is the OS X SDK.
1018         * Makefile: Append LayoutTestRelay to the list of modules to build when building with
1019         SDK iphonesimulator.
1020
1021 2015-11-05  Ryuan Choi  <ryuan.choi@navercorp.com>
1022
1023         [EFL] Add try_close API to handle beforeunload event
1024         https://bugs.webkit.org/show_bug.cgi?id=150705
1025
1026         Reviewed by Gyuyoung Kim.
1027
1028         * MiniBrowser/efl/main.c:
1029         (on_window_deletion):
1030         Call ewk_view_try_close instead of removing object directly.
1031         (window_create): Fixed that passes wrong data.
1032
1033 2015-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1034
1035         Fix crashing and flaky UIScriptController-based tests in fast/events/ios
1036         https://bugs.webkit.org/show_bug.cgi?id=150901
1037         <rdar://problem/23261499>
1038
1039         Reviewed by Simon Fraser.
1040
1041         Clear out zooming and keyboard-related callbacks after uiScriptComplete has been invoked. This prevents
1042         later tests from calling into code which previous tests attached to these callbacks and causing
1043         WebKitTestRunner to crash due to accessing a deallocated UIScriptController.
1044
1045         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1046         (WTR::UIScriptController::platformClearAllCallbacks):
1047         (WTR::UIScriptController::uiScriptComplete):
1048         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1049         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1050         (WTR::UIScriptController::platformClearAllCallbacks):
1051
1052 2015-11-04  Jer Noble  <jer.noble@apple.com>
1053
1054         [iOS] <video> elements without audio tracks should not interrupt music
1055         https://bugs.webkit.org/show_bug.cgi?id=149888
1056
1057         Reviewed by Eric Carlson.
1058
1059         Add tests to ensure that the AVAudioSession category is correctly set when playing
1060         back media both with and without audio tracks.
1061
1062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1063         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm: Added.
1064         (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
1065         (TestWebKitAPI::TEST):
1066         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: Added.
1067         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.mp4: Added.
1068         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: Added.
1069         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.mp4: Added.
1070
1071 2015-11-04  Alexey Proskuryakov  <ap@apple.com>
1072
1073         iOS test results are not visible on the flakiness dashboard
1074         https://bugs.webkit.org/show_bug.cgi?id=150884
1075
1076         Reviewed by Darin Adler.
1077
1078         Re-generated builders.jsonp using generate_builders_json.py.
1079
1080         I think that this is all that's needed for basic support. There is more work needed
1081         to display test expectations, but that's already mostly broken even for Mac.
1082
1083         * TestResultServer/static-dashboards/builders.jsonp:
1084
1085 2015-11-03  Commit Queue  <commit-queue@webkit.org>
1086
1087         Unreviewed, rolling out r191995.
1088         https://bugs.webkit.org/show_bug.cgi?id=150880
1089
1090         Broke iOS tests (Requested by ap on #webkit).
1091
1092         Reverted changeset:
1093
1094         "run-webkit-test should look in --root directory for
1095         LayoutTestRelay"
1096         https://bugs.webkit.org/show_bug.cgi?id=150859
1097         http://trac.webkit.org/changeset/191995
1098
1099 2015-11-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
1100
1101         Add graphics benchmark to performance bot
1102         https://bugs.webkit.org/show_bug.cgi?id=150450
1103
1104         Reviewed by Chris Dumez.
1105
1106         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Added.
1107         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Added.
1108         Add a patch and a plan to set the defaults of the benchmark, run it,
1109         collect the result and report it to the benchmark runner.
1110
1111 2015-11-03  Jason Marcell  <jmarcell@apple.com>
1112
1113         run-webkit-test should look in --root directory for LayoutTestRelay
1114         https://bugs.webkit.org/show_bug.cgi?id=150859
1115
1116         Reviewed by Daniel Bates.
1117
1118         For iOS run-webkit-tests, use LayoutTestRelay specified by --root; otherwise find
1119         LayoutTestRelay in the Mac build directory when --root is unspecified.
1120
1121         * Scripts/webkitpy/port/ios.py:
1122         (IOSSimulatorPort.relay_path):
1123
1124 2015-11-03  Alexey Proskuryakov  <ap@apple.com>
1125
1126         build.webkit.org/dashboard should use ISO dates in Trac URLs
1127         https://bugs.webkit.org/show_bug.cgi?id=150855
1128
1129         Reviewed by Darin Adler.
1130
1131         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1132         (Trac.prototype._xmlTimelineURL):
1133
1134 2015-11-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
1135
1136         Unreviewed, add myself to the SVG watchlist.
1137         
1138         * Scripts/webkitpy/common/config/watchlist:
1139
1140 2015-11-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1141
1142         Fix touch event sending crash in WebKitTestRunner
1143         https://bugs.webkit.org/show_bug.cgi?id=150848
1144         <rdar://problem/23360841>
1145
1146         Reviewed by Simon Fraser.
1147
1148         Fixes a redundant force event generated by HIDEventGenerator. See the Radar diagnosis for more details.
1149
1150         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1151         (-[HIDEventGenerator _createIOHIDEventType:]): Deleted.
1152
1153 2015-11-03  Brent Fulgham  <bfulgham@apple.com>
1154
1155         [Win] Unreviewed build fix after r191958.
1156
1157         * MiniBrowser/win/MiniBrowser.h: Add missing include.
1158         * MiniBrowser/win/MiniBrowserWebHost.h: Ditto.
1159
1160 2015-11-02  Jiewen Tan  <jiewen_tan@apple.com>
1161
1162         Add Jiewen Tan (jiewen_tan@apple.com) to committer list.
1163
1164         * Scripts/webkitpy/common/config/contributors.json:
1165
1166 2015-11-03  Csaba Osztrogonác  <ossy@webkit.org>
1167
1168         Unreviewed, add unittest after r191827.
1169
1170         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1171
1172 2015-11-02  Andy Estes  <aestes@apple.com>
1173
1174         [Cocoa] Add tvOS and watchOS to SUPPORTED_PLATFORMS
1175         https://bugs.webkit.org/show_bug.cgi?id=150819
1176
1177         Reviewed by Dan Bernstein.
1178
1179         This tells Xcode to include these platforms in its Devices dropdown, making it possible to build in the IDE.
1180
1181         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1182         * MiniBrowser/Configurations/Base.xcconfig:
1183         * TestWebKitAPI/Configurations/Base.xcconfig:
1184         * WebKitTestRunner/Configurations/Base.xcconfig:
1185
1186 2015-11-02  Anders Carlsson  <andersca@apple.com>
1187
1188         Begin work on supporting reply blocks in _WKRemoteObjectRegistry
1189         https://bugs.webkit.org/show_bug.cgi?id=150739
1190
1191         Reviewed by Tim Horton.
1192
1193         Add a test. We only test the encoding right now.
1194
1195         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1196         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1197         (TEST):
1198         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1199         (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
1200
1201 2015-11-02  Tim Horton  <timothy_horton@apple.com>
1202
1203         Get rid of WKWebView's inner WKView (WKView being inside WKWebView leads to weird API issues)
1204         https://bugs.webkit.org/show_bug.cgi?id=150174
1205
1206         Reviewed by Anders Carlsson.
1207
1208         * WebKitTestRunner/mac/EventSenderProxy.mm:
1209         (WTR::EventSenderProxy::mouseUp):
1210         (WTR::EventSenderProxy::mouseMoveTo):
1211         Revert some parts of r188828 which no longer apply.
1212
1213 2015-10-30  Dana Burkart  <dburkart@apple.com>
1214
1215         svn-apply should handle unified diffs
1216         https://bugs.webkit.org/show_bug.cgi?id=150650
1217
1218         Reviewed by Darin Adler.
1219
1220         * Scripts/VCSUtils.pm:
1221         (parseUnifiedDiffHeader):
1222         This method parses a unified diff header, and returns a information in the
1223         style of parseGitDiffHeader and parseSvnDiffHeader.
1224
1225         (parseDiffHeader):
1226         Teach parseDiffHeader to recognize unified diff headers.
1227
1228         (parseDiff):
1229         Teach parseDiff to recognize unified diffs.
1230
1231         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1232         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl: Added.
1233
1234 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
1235
1236         Fix the FTL JIT build with system LLVM on Linux
1237         https://bugs.webkit.org/show_bug.cgi?id=150795
1238
1239         Reviewed by Filip Pizlo.
1240
1241         * efl/install-dependencies:
1242         * gtk/install-dependencies:
1243
1244 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
1245
1246         [EFL] Bump harfbuzz versions to 0.9.35
1247         https://bugs.webkit.org/show_bug.cgi?id=150448
1248
1249         Reviewed by Gyuyoung Kim.
1250
1251         * efl/jhbuild.modules:
1252
1253 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
1254
1255         [EFL] gnutls-3.3.0 jhbuild module build fails on Ubuntu 15.10
1256         https://bugs.webkit.org/show_bug.cgi?id=150622
1257
1258         Reviewed by Gyuyoung Kim.
1259
1260         * efl/install-dependencies:
1261         * efl/jhbuild.modules:
1262
1263 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
1264
1265         Fix EFL jhbuild module build on Ubuntu 15.10
1266         https://bugs.webkit.org/show_bug.cgi?id=150621
1267
1268         Reviewed by Gyuyoung Kim.
1269
1270         * efl/jhbuild.modules:
1271         * efl/patches/efl-remove-XPrint.patch: Added.
1272
1273 2015-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1274
1275         [GLIB] Remove delete on destroy GMainLoopSources
1276         https://bugs.webkit.org/show_bug.cgi?id=150771
1277
1278         Reviewed by Žan Doberšek.
1279
1280         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:
1281         (TestWebKitAPI::TEST): Remove DeleteOnDestroy unit tests.
1282         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1283         (WebViewTest::wait): Use g_timeout_add instead of GMainLoopSource.
1284
1285 2015-11-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1286
1287         [ES6] Support Generator Syntax
1288         https://bugs.webkit.org/show_bug.cgi?id=150769
1289
1290         Reviewed by Geoffrey Garen.
1291
1292         Added ENABLE_ES6_GENERATORS flag.
1293
1294         * Scripts/webkitperl/FeatureList.pm:
1295
1296 2015-11-01  Alexey Proskuryakov  <ap@apple.com>
1297
1298         Sort EWS bots in popovers
1299         https://bugs.webkit.org/show_bug.cgi?id=150782
1300
1301         Reviewed by Darin Adler.
1302
1303         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
1304         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
1305
1306 2015-10-31  Filip Pizlo  <fpizlo@apple.com>
1307
1308         B3::reduceStrength's DCE should be more agro and less wrong
1309         https://bugs.webkit.org/show_bug.cgi?id=150748
1310
1311         Reviewed by Geoffrey Garen.
1312
1313         Add an LLVM version of testb3's "testComplex".
1314
1315         * ReducedFTL/ComplexTest.cpp: Added.
1316
1317 2015-11-01  Commit Queue  <commit-queue@webkit.org>
1318
1319         Unreviewed, rolling out r191831.
1320         https://bugs.webkit.org/show_bug.cgi?id=150774
1321
1322         The new test fails (Requested by ap on #webkit).
1323
1324         Reverted changeset:
1325
1326         "Begin work on supporting reply blocks in
1327         _WKRemoteObjectRegistry"
1328         https://bugs.webkit.org/show_bug.cgi?id=150739
1329         http://trac.webkit.org/changeset/191831
1330
1331 2015-10-31  Andreas Kling  <akling@apple.com>
1332
1333         Add a debug overlay with information about web process resource usage.
1334         <https://webkit.org/b/150599>
1335
1336         Reviewed by Darin Adler.
1337
1338         Add a menu item to the MiniBrowser so we can toggle the resource usage overlay on/off.
1339
1340         * MiniBrowser/mac/SettingsController.h:
1341         * MiniBrowser/mac/SettingsController.m:
1342         (-[SettingsController _populateMenu]):
1343         (-[SettingsController validateMenuItem:]):
1344         (-[SettingsController toggleShowResourceUsageOverlay:]):
1345         (-[SettingsController resourceUsageOverlayVisible]):
1346         * MiniBrowser/mac/WK2BrowserWindowController.m:
1347         (-[WK2BrowserWindowController didChangeSettings]):
1348
1349 2015-10-31  Lucas Forschler  <lforschler@apple.com>
1350
1351         Teach the CompileWebKit step to look for additional arguments.
1352         
1353         Unreviewed config change.
1354
1355         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1356         (CompileWebKit.start):
1357
1358 2015-10-30  Anders Carlsson  <andersca@apple.com>
1359
1360         Begin work on supporting reply blocks in _WKRemoteObjectRegistry
1361         https://bugs.webkit.org/show_bug.cgi?id=150739
1362
1363         Reviewed by Tim Horton.
1364
1365         Add a test. We only test the encoding right now.
1366
1367         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1368         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1369         (TEST):
1370         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1371         (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
1372
1373 2015-10-30  Lucas Forschler  <lforschler@apple.com>
1374
1375         Add CMAke builder to build.webkit.org
1376         https://bugs.webkit.org/show_bug.cgi?id=150738
1377         
1378         Reviewed by Alex Christensen.
1379
1380         * BuildSlaveSupport/build.webkit.org-config/config.json:
1381
1382 2015-10-30  Brent Fulgham  <bfulgham@apple.com>
1383
1384         [Win] build-jsc and run-javascriptcore-tests do not work
1385         https://bugs.webkit.org/show_bug.cgi?id=150700
1386
1387         Reviewed by Mark Lam.
1388         
1389         Correct our build system so that it expects Windows to be using CMake,
1390         and to build the correct sub-projects for our JSC helper scripts.
1391
1392         * Scripts/build-jsc: Make sure to build the testapi harness when
1393           building for Windows.
1394         * Scripts/build-webkit:
1395           (1) Use the existing 'cmakeBasedPortName()'
1396           (2) Use File::Spec rather than hard-coding path delimeters.
1397           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
1398         method rather than hard-coding the name based on conditional.
1399         * Scripts/copy-webkitlibraries-to-product-directory: Don't try to grab
1400           LLVM libraries on Apple Windows build.
1401         * Scripts/run-javascriptcore-tests:
1402         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
1403         * Scripts/run-jsc: Ditto.
1404         * Scripts/webkitdirs.pm:
1405         (cmakeBasedPortName): Update to return the right value for the Apple
1406         Windows port and the WinCairo port.
1407         (isCMakeBuild): Expect CMake build for all Windows ports.
1408
1409 2015-10-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1410
1411         [JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
1412         https://bugs.webkit.org/show_bug.cgi?id=150665
1413
1414         Reviewed by Csaba Osztrogonác.
1415
1416         We check it only to wipe the directory or not, but we are still
1417         tryihng to update every module even when the configuration hasn't
1418         changed. This is problematic because it makes the whole build fail
1419         when any repository fails to checkout an already checked out
1420         revision, because the server is down for example. This is even
1421         more problematic for the bots that skip perfectly valid revisions.
1422         It's still possible to force an update passing --force command
1423         line argument.
1424
1425         * Scripts/update-webkit-libs-jhbuild:
1426         (deleteJhbuildMd5): Delete the md5sum files if exist.
1427         (runJhbuild): Return early if the md5sum files haven't
1428         changed. Only write them after a successful build and delete them
1429         if the build fails to ensure we don't skip next run.
1430
1431 2015-10-30  Philippe Normand  <pnormand@igalia.com>
1432
1433         [GTK] Fix MacCLang build errors in Tools
1434         https://bugs.webkit.org/show_bug.cgi?id=150031
1435
1436         Reviewed by Carlos Garcia Campos.
1437
1438         * TestWebKitAPI/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
1439         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
1440         * WebKitTestRunner/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
1441         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
1442
1443 2015-10-29  Hunseop Jeong  <hs85.jeong@samsung.com>
1444
1445         [EFL] MiniBrowser didn't work after r191749.
1446         https://bugs.webkit.org/show_bug.cgi?id=150706
1447
1448         Reviewed by Alex Christensen.
1449
1450         Renamed jhbuildWrapperPrefixIfNeeded to wrapperPrefixIfNeeded in r191749.
1451
1452         * Scripts/run-minibrowser:
1453
1454 2015-10-29  Commit Queue  <commit-queue@webkit.org>
1455
1456         Unreviewed, rolling out r191766.
1457         https://bugs.webkit.org/show_bug.cgi?id=150707
1458
1459         Problem with Cygwin build (Requested by bfulgham_ on #webkit).
1460
1461         Reverted changeset:
1462
1463         "[Win] build-jsc and run-javascriptcore-tests do not work"
1464         https://bugs.webkit.org/show_bug.cgi?id=150700
1465         http://trac.webkit.org/changeset/191766
1466
1467 2015-10-29  Brent Fulgham  <bfulgham@apple.com>
1468
1469         [Win] build-jsc and run-javascriptcore-tests do not work
1470         https://bugs.webkit.org/show_bug.cgi?id=150700
1471
1472         Reviewed by Mark Lam.
1473         
1474         Correct our build system so that it expects Windows to be using CMake,
1475         and to build the correct sub-projects for our JSC helper scripts.
1476
1477         * Scripts/build-jsc: Make sure to build the testapi harness when
1478           building for Windows.
1479         * Scripts/build-webkit:
1480           (1) Use the existing 'cmakeBasedPortName()'
1481           (2) Use File::Spec rather than hard-coding path delimeters.
1482           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
1483         method rather than hard-coding the name based on conditional.
1484         * Scripts/run-javascriptcore-tests:
1485         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
1486         * Scripts/run-jsc: Ditto.
1487         * Scripts/webkitdirs.pm:
1488         (cmakeBasedPortName): Update to return the right value for the Apple
1489         Windows port and the WinCairo port.
1490         (isCMakeBuild): Expect CMake build for all Windows ports.
1491
1492 2015-10-29  Alex Christensen  <achristensen@webkit.org>
1493
1494         Fix build-jsc on Mac after r191749.
1495
1496         * Scripts/build-jsc:
1497         Use isCMakeBuild to determine if we are building with CMake instead of cmakeBasedPortName.
1498
1499 2015-10-29  Alex Christensen  <achristensen@webkit.org>
1500
1501         Fix Mac CMake build
1502         https://bugs.webkit.org/show_bug.cgi?id=150686
1503
1504         Reviewed by Filip Pizlo.
1505
1506         * Scripts/build-webkit:
1507         * Scripts/webkitdirs.pm:
1508         (isCachedArgumentfileOutOfDate):
1509         (wrapperPrefixIfNeeded):
1510         (generateBuildSystemFromCMakeProject):
1511         (buildCMakeGeneratedProject):
1512         (cmakeBasedPortName):
1513         (determineIsCMakeBuild):
1514         (isCMakeBuild):
1515         (promptUser):
1516         (jhbuildWrapperPrefixIfNeeded): Deleted.
1517
1518 2015-10-29  Lucas Forschler  <lforschler@apple.com>
1519
1520         Teach JSC bots to build 32bit instead of x86_64
1521         
1522         Reviewed by Mark Lam.
1523
1524         * BuildSlaveSupport/build.webkit.org-config/config.json:
1525
1526 2015-10-29  Per Arne Vollan  <peavo@outlook.com>
1527
1528         [WinCairo] Fall back to AppleWin results in layout tests.
1529         https://bugs.webkit.org/show_bug.cgi?id=150672
1530
1531         Reviewed by Alex Christensen.
1532
1533         * Scripts/webkitpy/port/win.py:
1534         (WinCairoPort):
1535         (WinCairoPort.default_baseline_search_path):
1536
1537 2015-10-28  Keith Rollin  <krollin@apple.com>
1538
1539         Do not sanitize user input for input[type=url]
1540         https://bugs.webkit.org/show_bug.cgi?id=150346
1541         <rdar://problem/23243240>
1542
1543         Reviewed by Brent Fulgham.
1544
1545         The Windows version of DumpRenderTree's eventSender.keyDown handler
1546         simulates user-entry by decomposing the given character into a virtual
1547         key code and a set of modifier keys. The code that determines if the
1548         shift key should be simulated only worked if the character was an
1549         upper case character. Extend this support to also include symbols that
1550         (on the U.S. keyboard) require holding down the shift key.
1551
1552         This change allows fast/forms/input-user-input-sanitization.html
1553         to succeed, which requires us to simulate the entering of '@' and ':'.
1554
1555         * DumpRenderTree/win/EventSender.cpp:
1556         (keyDownCallback):
1557
1558 2015-10-28  Alex Christensen  <achristensen@webkit.org>
1559
1560         Compile and link with CMake on Mac
1561         https://bugs.webkit.org/show_bug.cgi?id=150632
1562
1563         Reviewed by Tim Horton.
1564
1565         * TestWebKitAPI/PlatformMac.cmake:
1566
1567 2015-10-28  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1568
1569         Unreviewed.
1570
1571         * Scripts/webkitpy/common/config/watchlist: Removed dead files from Streams API watchlist.
1572
1573 2015-10-28  Per Arne Vollan  <peavo@outlook.com>
1574
1575         Add WinCairo to list of ports in run-webkit-tests.
1576         https://bugs.webkit.org/show_bug.cgi?id=150625
1577
1578         Reviewed by Brent Fulgham.
1579
1580         * Scripts/webkitpy/common/config/ports.py:
1581         (DeprecatedPort.port):
1582         (WinPort.run_webkit_tests_command):
1583         (WinCairoPort):
1584         (GtkWK2Port):
1585         * Scripts/webkitpy/port/factory.py:
1586         (PortFactory):
1587         * Scripts/webkitpy/port/win.py:
1588         (WinPort.find_system_pid):
1589         (WinCairoPort):
1590
1591 2015-10-27  Alexey Proskuryakov  <ap@apple.com>
1592
1593         WebKitTestRunner leaks in generateWhitelist()
1594         https://bugs.webkit.org/show_bug.cgi?id=150563
1595
1596         Reviewed by Andreas Kling.
1597
1598         * WebKitTestRunner/mac/TestControllerMac.mm:
1599         (WTR::generateWhitelist):
1600
1601 2015-10-27  Anders Carlsson  <andersca@apple.com>
1602
1603         Add an API test for _WKRemoteObjectRegistry
1604         https://bugs.webkit.org/show_bug.cgi?id=150597
1605
1606         Reviewed by Andreas Kling.
1607
1608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1609         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
1610         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
1611         (TEST):
1612         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
1613         (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1614         (-[RemoteObjectRegistryPlugIn sayHello:]):
1615
1616 2015-10-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1617
1618         Add myself to the reviewers list
1619         https://bugs.webkit.org/show_bug.cgi?id=150581
1620
1621         Unreviewed.
1622
1623         * Scripts/webkitpy/common/config/contributors.json:
1624
1625 2015-10-26  Ryan Haddad  <ryanhaddad@apple.com>
1626
1627         Adding myself to contributors.json
1628
1629         * Scripts/webkitpy/common/config/contributors.json:
1630
1631 2015-10-26  Tim Horton  <timothy_horton@apple.com>
1632
1633         Don't expose the whitelist/blacklist in _WKUserStyleSheet
1634         https://bugs.webkit.org/show_bug.cgi?id=150566
1635
1636         Reviewed by Anders Carlsson.
1637
1638         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1639         (TEST):
1640
1641 2015-10-26  Philippe Normand  <pnormand@igalia.com>
1642
1643         Unreviewed, rolling out r191576.
1644
1645         broke
1646
1647         Reverted changeset:
1648
1649         "[GStreamer] Bump internal jhbuild versions to 1.6.0"
1650         https://bugs.webkit.org/show_bug.cgi?id=149594
1651         http://trac.webkit.org/changeset/191576
1652
1653 2015-10-26  ChangSeok Oh  <changseok.oh@collabora.com>
1654
1655         [GStreamer] Bump internal jhbuild versions to 1.6.0
1656         https://bugs.webkit.org/show_bug.cgi?id=149594
1657
1658         Reviewed by Philippe Normand.
1659
1660         Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
1661         useful so they are removed accordingly.
1662
1663         * gtk/jhbuild.modules:
1664         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
1665         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
1666         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
1667
1668 2015-10-25  Alexey Proskuryakov  <ap@apple.com>
1669
1670         API tests fail on El Capitan after r191543
1671         https://bugs.webkit.org/show_bug.cgi?id=150547
1672
1673         Reviewed by Dan Bernstein.
1674
1675         * Scripts/run-api-tests: (listAllTests): Add appropriate arch arguments in one more place.
1676
1677 2015-10-24  Tim Horton  <timothy_horton@apple.com>
1678
1679         Add a way to add user style sheets to WKUserContentController
1680         https://bugs.webkit.org/show_bug.cgi?id=150531
1681         <rdar://problem/23191691>
1682
1683         Reviewed by Darin Adler.
1684
1685         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1686         (TEST):
1687
1688 2015-10-24  Tim Horton  <timothy_horton@apple.com>
1689
1690         Expose more information about the exception in WKErrorJavaScriptExceptionOccurred errors
1691         https://bugs.webkit.org/show_bug.cgi?id=150525
1692
1693         Reviewed by Darin Adler.
1694
1695         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
1696         (TEST):
1697         Test the various new keys.
1698
1699 2015-10-24  Frederic Wang  <fred.wang@free.fr>
1700
1701         check-webkit-style complains about missing operator whitespace inside character literal
1702         https://bugs.webkit.org/show_bug.cgi?id=150396
1703
1704         Reviewed by Darin Adler.
1705
1706         * Scripts/webkitpy/style/checkers/cpp.py: Improve matching of C++ character literal.
1707         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1708         (WebKitStyleTest.test_spacing): Add a test to verify that the spacing for the character literal 'OS/2' is not tested.
1709
1710 2015-10-23  Michael Saboff  <msaboff@apple.com>
1711
1712         REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
1713         https://bugs.webkit.org/show_bug.cgi?id=150513
1714
1715         Reviewed by Saam Barati.
1716
1717         Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
1718
1719         * DumpRenderTree/TestRunner.cpp:
1720         (simulateWebNotificationClickCallback):
1721         (failNextCodeBlock):
1722         (numberOfDFGCompiles):
1723         (TestRunner::staticFunctions):
1724         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1725         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1726         (WTR::TestRunner::setBlockAllPlugins):
1727         (WTR::TestRunner::failNextCodeBlock):
1728         (WTR::TestRunner::numberOfDFGCompiles):
1729         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1730
1731 2015-10-23  Anders Carlsson  <andersca@apple.com>
1732
1733         Simplify the WebKitLegacy menu conversion code
1734         https://bugs.webkit.org/show_bug.cgi?id=150509
1735
1736         Reviewed by Andreas Kling.
1737
1738         Implement the context menu delegate method so we'll test that code path.
1739
1740         * MiniBrowser/mac/WK1BrowserWindowController.m:
1741         (-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
1742
1743 2015-10-23  Per Arne Vollan  <peavo@outlook.com>
1744
1745         [WinCairo] Improve test results for fast layouttests.
1746         https://bugs.webkit.org/show_bug.cgi?id=150464
1747
1748         Reviewed by Alex Christensen.
1749
1750         Set custom device scale factor to 1.0.
1751
1752         * DumpRenderTree/win/DumpRenderTree.cpp:
1753         (createWebViewAndOffscreenWindow):
1754
1755 2015-10-23  Mark Salisbury  <mark.salisbury@hp.com>
1756
1757         [GTK] update-webkitgtk-libs should use mesa tarball
1758
1759         https://bugs.webkit.org/show_bug.cgi?id=150470
1760
1761         update-webkitgtk-libs downloads all build dependencies; in fixing
1762         bug 148941 mesa was switched from ftp to git access.  Now an http
1763         tarball is available, which is preferred over accessing via git.
1764
1765         Reviewed by Philippe Normand
1766
1767         * gtk/jhbuild.modules:
1768         Mesa access changed to http tarball.
1769
1770 2015-10-22  Sam Weinig  <sam@webkit.org>
1771
1772         Navigations on the same host (but with different schemes and ports) should not trigger universal links
1773         <rdar://problem/22811325>
1774         https://bugs.webkit.org/show_bug.cgi?id=150481
1775
1776         Reviewed by Dan Bernstein.
1777
1778         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1779         Update test to test that navigations on the same host but with different schemes does not
1780         trigger universal links, but that changes in the host do.
1781
1782 2015-10-22  Ryosuke Niwa  <rniwa@webkit.org>
1783
1784         REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
1785         https://bugs.webkit.org/show_bug.cgi?id=150428
1786
1787         Reviewed by Antti Koivisto.
1788
1789         Added a regression test using WebKit API test.
1790
1791         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1792         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
1793         (TestWebKitAPI::didFinishLoadForFrame):
1794         (TestWebKitAPI::TEST):
1795
1796 2015-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1797
1798         Unreviewed. Fix GTK+ build after r191423.
1799
1800         Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
1801
1802         * gtk/webkitdom.py:
1803         (WebKitDOMDocGenerator):
1804
1805 2015-10-22  Aakash Jain  <aakash_jain@apple.com>
1806
1807         [Win][EFL][GTK] webkitpy test failed after r191374.
1808         https://bugs.webkit.org/show_bug.cgi?id=150433
1809
1810         Reviewed by Alexey Proskuryakov.
1811
1812         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1813         (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
1814         (CrashLogsTest.test_find_log_darwin): Same.
1815
1816 2015-10-21  Brian Burg  <bburg@apple.com>
1817
1818         Unreviewed, update watchlist for JS builtins.
1819
1820         Add a category for JS builtins code generator, similar to other generators.
1821
1822         Add a nag message to rebaseline builtins generator tests when touching
1823         code generator files in Source/JavaScriptCore/Scripts/builtins/.
1824
1825         * Scripts/webkitpy/common/config/watchlist:
1826
1827 2015-10-21  Brian Burg  <bburg@apple.com>
1828
1829         Restructure generate-js-bindings script to be modular and testable
1830         https://bugs.webkit.org/show_bug.cgi?id=149929
1831
1832         Reviewed by Alex Christensen.
1833
1834         Add a stub shell script and basic webkitpy support for running builtins
1835         generator tests.
1836
1837         * Scripts/run-builtins-generator-tests: Added.
1838         (main):
1839         * Scripts/webkitpy/codegen/__init__.py: Added.
1840         * Scripts/webkitpy/codegen/main.py: Added.
1841
1842             The only interesting difference here from the inspector protocol
1843             generator equivalent is that this implementation decodes the target
1844             framework and output mode (combined or separate) from the test's file name.
1845
1846         (BuiltinsGeneratorTests):
1847         (BuiltinsGeneratorTests.__init__):
1848         (BuiltinsGeneratorTests.generate_from_js_builtins):
1849         (BuiltinsGeneratorTests.write_error_file):
1850         (BuiltinsGeneratorTests.detect_changes):
1851         (BuiltinsGeneratorTests.run_tests):
1852         (BuiltinsGeneratorTests.main):
1853
1854 2015-10-21  Aakash Jain  <aakash_jain@apple.com>
1855
1856         run-webkit-tests does not copy all crash logs for layout test failures on Mac
1857         https://bugs.webkit.org/show_bug.cgi?id=150407
1858         <rdar://problem/22239750>
1859
1860         Reviewed by Alexey Proskuryakov.
1861
1862         * Scripts/webkitpy/port/mac.py:
1863         (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
1864         (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
1865         the log directory.
1866         (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
1867         from log directory and merge them with the list of already crashed tests.
1868
1869 2015-10-21  Filip Pizlo  <fpizlo@apple.com>
1870
1871         Failures in PutStackSinkingPhase should be less severe
1872         https://bugs.webkit.org/show_bug.cgi?id=150400
1873
1874         Reviewed by Geoffrey Garen.
1875
1876         Add a test mode for no PutStackSinkingPhase.
1877
1878         * Scripts/run-jsc-stress-tests:
1879
1880 2015-10-21  Nan Wang  <n_wang@apple.com>
1881
1882         AX: Expose table size and cell indexes on iOS
1883         https://bugs.webkit.org/show_bug.cgi?id=150366
1884
1885         Reviewed by Chris Fleizach.
1886
1887         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1888         (AccessibilityUIElement::rowCount):
1889         (AccessibilityUIElement::columnCount):
1890         (AccessibilityUIElement::indexInTable):
1891         (AccessibilityUIElement::numberAttributeValue):
1892         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1893         (WTR::AccessibilityUIElement::numberAttributeValue):
1894         (WTR::AccessibilityUIElement::rowCount):
1895         (WTR::AccessibilityUIElement::columnCount):
1896         (WTR::AccessibilityUIElement::indexInTable):
1897
1898 2015-10-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1899
1900         W3C test importer should not import reference files as regular tests
1901         https://bugs.webkit.org/show_bug.cgi?id=150331
1902
1903         Reviewed by Darin Adler.
1904
1905         Updated test_parser to return information that a file can be a referencefile or a manual test.
1906         Updated test importer to skip those files.
1907         Updated/Added test parser unit tests accordingly.
1908
1909         Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
1910         Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
1911         to mark these files as Skip, since they are not direct tests. 
1912
1913         * Scripts/webkitpy/w3c/test_importer.py:
1914         (TestImporter.__init__):
1915         (TestImporter.find_importable_tests):
1916         (TestImporter.import_tests):
1917         * Scripts/webkitpy/w3c/test_parser.py:
1918         (TestParser.analyze_test):
1919         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1920         (test_analyze_non_html_file):
1921         (test_reference_test):
1922
1923 2015-10-20  Aakash Jain  <aakash_jain@apple.com>
1924
1925         run-webkit-tests does not copy all crash logs for layout test failures on iOS
1926         https://bugs.webkit.org/show_bug.cgi?id=150056
1927         <rdar://problem/9280656>
1928
1929         Reviewed by Alexey Proskuryakov.
1930
1931         * Scripts/webkitpy/common/system/crashlogs.py:
1932         (CrashLogs.find_all_logs): Generic method to find all crash logs.
1933         (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
1934         It iterates through log directory and returns all the logs based on timestamp.
1935         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1936         (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
1937         (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
1938         (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
1939         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1940         (Manager.run): Modified start_time to start counting before simulator launch
1941         so that we can capture crashes during simualator launch.
1942         (Manager._look_for_new_crash_logs): Browse through list of crashes and append
1943         any test which is not already marked as CRASH to the run_results.
1944         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1945         (TestExpectationsModel.get_expectations_string): return PASS in case there
1946         are no expectations defined for this test.
1947         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1948         (summarize_results): Add other_crashes in a separte category in full_results.json.
1949         * Scripts/webkitpy/port/ios.py:
1950         (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
1951         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
1952         from the log directory.
1953         (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
1954         logs from log directory and merge them with the list of already crashed tests.
1955
1956 2015-10-20  Dana Burkart  <dburkart@apple.com>
1957
1958         Fix the build
1959
1960         Unreviewed.
1961
1962         My previous patch was missing a necessary space character.
1963
1964         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1965
1966 2015-10-20  Dana Burkart  <dburkart@apple.com>
1967
1968         svn-apply fails to apply binary diffs in some cases
1969         https://bugs.webkit.org/show_bug.cgi?id=64647
1970
1971         Reviewed by Daniel Bates.
1972
1973         * Scripts/VCSUtils.pm:
1974         (decodeGitBinaryPatchDeltaSize): Modified.
1975         We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
1976         * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
1977
1978 2015-10-20  Alexey Proskuryakov  <ap@apple.com>
1979
1980         Mac Debug EWS never finishes when there are failures
1981         https://bugs.webkit.org/show_bug.cgi?id=150334
1982
1983         Reviewed by Daniel Bates.
1984
1985         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1986         * Scripts/webkitpy/tool/commands/queues.py:
1987
1988 2015-10-20  Philippe Normand  <pnormand@igalia.com>
1989
1990         [GTK] Enable OpenWebRTC test video/audio sources in tests
1991
1992         This is needed because we can't expect the buildbots to have
1993         webcam/mic devices plugged in.
1994
1995         Rubber-stamped by Carlos Garcia Campos.
1996
1997         * Scripts/run-gtk-tests:
1998         (TestRunner._setup_testing_environment):
1999         * Scripts/webkitpy/port/gtk.py:
2000         (GtkPort.setup_environ_for_server):
2001
2002 2015-10-20  Yoav Weiss  <yoav@yoav.ws>
2003
2004         Rename the PICTURE_SIZES flag to CURRENTSRC
2005         https://bugs.webkit.org/show_bug.cgi?id=150275
2006
2007         Reviewed by Dean Jackson.
2008
2009         * Scripts/webkitperl/FeatureList.pm:
2010
2011 2015-10-19  Hunseop Jeong  <hs85.jeong@samsung.com>
2012
2013         Unreviewed, add myself to the committers list.
2014
2015         * Scripts/webkitpy/common/config/contributors.json:
2016
2017 2015-10-19  Alexey Proskuryakov  <ap@apple.com>
2018
2019         Add new EWS queues to bot watcher's dashboard
2020         https://bugs.webkit.org/show_bug.cgi?id=150297
2021
2022         Reviewed by Darin Adler.
2023
2024         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2025         (BubbleQueueServer):
2026
2027 2015-10-19  ChangSeok Oh  <changseok.oh@collabora.com>
2028
2029         REGRESSION(r190262): User media unit test failures after r190262
2030         https://bugs.webkit.org/show_bug.cgi?id=149580
2031
2032         Reviewed by Carlos Garcia Campos.
2033
2034         The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
2035         So we do not need to skip them anymore.
2036
2037         * Scripts/run-gtk-tests:
2038         (TestRunner): Deleted.
2039
2040 2015-10-19  Csaba Osztrogonác  <ossy@webkit.org>
2041
2042         Add historical addresses to contributors.json
2043         https://bugs.webkit.org/show_bug.cgi?id=150227
2044
2045         Reviewed by Darin Adler.
2046
2047         * Scripts/webkitpy/common/config/contributors.json:
2048
2049 2015-10-18  Sungmann Cho  <sungmann.cho@navercorp.com>
2050
2051         [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
2052         https://bugs.webkit.org/show_bug.cgi?id=150307
2053
2054         Reviewed by Brent Fulgham.
2055
2056         The DLL build rules have been changed to generate "{Name}Lib.DLL",
2057         but these changes have not yet been applied to the Visual Studio builds.
2058
2059         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
2060
2061 2015-10-16  Andreas Kling  <akling@apple.com>
2062
2063         [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
2064         <https://webkit.org/b/150153>
2065
2066         Unreviewed.
2067
2068         Just use simple arrays of LChar and UChar for this test instead of creating String
2069         objects and then getting the characters8()/characters16() from them, since that
2070         doesn't guarantee null-termination (the bug.)
2071
2072         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2073         (TestWebKitAPI::TEST):
2074         (TestWebKitAPI::build): Deleted.
2075
2076 2015-10-16  Tim Horton  <timothy_horton@apple.com>
2077
2078         WebKit2.AutoLayoutIntegration API test is failing on some of the bots
2079         https://bugs.webkit.org/show_bug.cgi?id=150255
2080
2081         Reviewed by Simon Fraser.
2082
2083         * Scripts/run-api-tests:
2084         (runTest):
2085         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2086         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
2087         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
2088         (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
2089         (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
2090         Don't set the layout size until after the load finishes and we're waiting
2091         for the reply, so that there is no race between the new size coming in
2092         and us waiting for it.
2093
2094 2015-10-16  Anders Carlsson  <andersca@apple.com>
2095
2096         WebEditingDelegate should be a formal protocol
2097         https://bugs.webkit.org/show_bug.cgi?id=150254
2098         <rdar://problem/23149847>
2099
2100         Reviewed by Dan Bernstein.
2101
2102         * DumpRenderTree/mac/EditingDelegate.h:
2103         Conform to the WebEditingDelegate protocol.
2104
2105 2015-10-16  Tim Horton  <timothy_horton@apple.com>
2106
2107         Hook up autolayout intrinsic sizing for WKWebView
2108         https://bugs.webkit.org/show_bug.cgi?id=150219
2109         <rdar://problem/20016905>
2110
2111         Reviewed by Simon Fraser.
2112
2113         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2114         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
2115         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
2116         (-[AutoLayoutWKWebView load:expectingContentSize:]):
2117         (-[AutoLayoutWKWebView expectContentSizeChange:]):
2118         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
2119         (TEST):
2120         Add a variety of tests, including one which catches the bug that
2121         the WebCore part of this patch fixes.
2122
2123 2015-10-15  Csaba Osztrogonác  <ossy@webkit.org>
2124
2125         Update the help message of --system-malloc
2126         https://bugs.webkit.org/show_bug.cgi?id=150169
2127
2128         Reviewed by Geoffrey Garen.
2129
2130         * Scripts/webkitperl/FeatureList.pm:
2131
2132 2015-10-15  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2133
2134         Update ImportExpectations according currently imported wpt tests
2135         https://bugs.webkit.org/show_bug.cgi?id=150158
2136
2137         Reviewed by Chris Dumez.
2138
2139         * Scripts/webkitpy/w3c/test_downloader.py:
2140         (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
2141
2142 2015-10-15  Eunmi Lee  <eunmi15.lee@samsung.com>
2143
2144         Unreviewed, Update my email address.
2145
2146         * Scripts/webkitpy/common/config/contributors.json:
2147
2148 2015-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2149
2150         [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
2151         https://bugs.webkit.org/show_bug.cgi?id=84960
2152
2153         Reviewed by Žan Doberšek.
2154
2155         * Scripts/run-gtk-tests:
2156         (TestRunner): Unskip tests using SessionState.
2157         * TestWebKitAPI/PlatformGTK.cmake: Add
2158         WKPageCopySessionStateWithFiltering test.
2159
2160 2015-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2161
2162         [GTK] Missing return value on TestWebExtensions.cpp:193
2163         https://bugs.webkit.org/show_bug.cgi?id=149755
2164
2165         Unreviewed. Add missing return value.
2166
2167         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2168         (permissionRequestCallback):
2169
2170 2015-10-14  Andy Estes  <aestes@apple.com>
2171
2172         [iOS] build-dumprendertree does not build ImageDiff
2173         https://bugs.webkit.org/show_bug.cgi?id=150152
2174
2175         Reviewed by Tim Horton.
2176
2177         run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
2178         On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
2179         as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
2180         WebKit.xcworkspace), tests that rely on image diffing won't work properly.
2181
2182         There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
2183         fine on that platform, and results in ImageDiff being built.
2184
2185         * Scripts/build-dumprendertree:
2186
2187 2015-10-14  Brent Fulgham  <bfulgham@apple.com>
2188
2189         [Win] Enforce launcher/library naming scheme
2190         https://bugs.webkit.org/show_bug.cgi?id=150124
2191
2192         Reviewed by Alex Christensen.
2193
2194         * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
2195         * MiniBrowser/win/CMakeLists.txt: Ditto.
2196         * TestWebKitAPI/PlatformWin.cmake: Ditto.
2197         * win/DLLLauncher/DLLLauncherMain.cpp:
2198         (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
2199         original {name}.dll.
2200
2201 2015-10-14  Andreas Kling  <akling@apple.com>
2202
2203         REGRESSION(r190882): Concatenating a character array and an empty string is broken.
2204         <https://webkit.org/b/150135>
2205
2206         Reviewed by Geoffrey Garen.
2207
2208         Add a new WTF API test that covers this issue.
2209
2210         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2211         (TestWebKitAPI::build):
2212         (TestWebKitAPI::TEST):
2213
2214 2015-10-14  Alex Christensen  <achristensen@webkit.org>
2215
2216         Add SPI for reloading without content blockers
2217         https://bugs.webkit.org/show_bug.cgi?id=150058
2218         rdar://problem/22742222
2219
2220         Reviewed by Sam Weinig.
2221
2222         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2223         (WTR::TestController::cocoaResetStateToConsistentValues):
2224         * WebKitTestRunner/mac/TestControllerMac.mm:
2225         (WTR::TestController::platformConfigureViewForTest):
2226
2227 2015-10-14  Mark Lam  <mark.lam@apple.com>
2228
2229         Rename some JSC option names to be more uniform.
2230         https://bugs.webkit.org/show_bug.cgi?id=150127
2231
2232         Reviewed by Geoffrey Garen.
2233
2234         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
2235         * Scripts/run-jsc-stress-tests:
2236
2237 2015-10-14  Anders Carlsson  <andersca@apple.com>
2238
2239         Change the bundle app cache APIs to take a page
2240         https://bugs.webkit.org/show_bug.cgi?id=150123
2241
2242         Reviewed by Sam Weinig.
2243
2244         Update APIs.
2245
2246         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2247         (WTR::InjectedBundle::beginTesting):
2248         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2249         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2250         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2251         (WTR::TestRunner::clearAllApplicationCaches):
2252         (WTR::TestRunner::clearApplicationCacheForOrigin):
2253         (WTR::TestRunner::setAppCacheMaximumSize):
2254         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2255         (WTR::TestRunner::originsWithApplicationCache):
2256
2257 2015-10-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2258
2259         Update web-platform-tests tools to the latest revision
2260         https://bugs.webkit.org/show_bug.cgi?id=149645
2261
2262         Reviewed by Darin Adler.
2263
2264         Disabling git submodules information conversion to json install file for web-platform-tests.
2265         Disabling related python unit tests.
2266         The tools submodules contain submodules and the conversion tool does not support that yet.
2267
2268         Updating wpt launcher script to aling it with web-platform-test main script.
2269
2270         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2271         (main):
2272         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2273         (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
2274         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2275         (TestImporterTest.test_submodules_generation):
2276
2277 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
2278
2279         More debug queue build fixing.
2280
2281         Preserve the build style in one more place. Changed mock build_style from "both"
2282         to "release", as we don't support testing both debug and release.
2283
2284         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2285         (MockCommitQueue.archive_last_test_results):
2286         (MockCommitQueue):
2287         (MockCommitQueue.build_style):
2288         (MockCommitQueue.did_pass_testing_ews):
2289         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2290         (PatchAnalysisTask._test):
2291         (PatchAnalysisTask._build_and_test_without_patch):
2292         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2293         (EarlyWarningSystemTest._default_expected_logs):
2294         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2295
2296 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
2297
2298         More debug queue build fixing.
2299
2300         Add build_style argument to derived classes as well.
2301
2302         * Scripts/webkitpy/common/config/ports.py:
2303         (MacPort):
2304         (MacPort.run_webkit_tests_command):
2305         (WinPort.run_bindings_tests_command):
2306         (WinPort):
2307         (WinPort.run_webkit_tests_command):
2308         (GtkWK2Port.build_webkit_command):
2309         (GtkWK2Port):
2310         (GtkWK2Port.run_webkit_tests_command):
2311
2312 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
2313
2314         [iOS] Build fix
2315
2316         Unreviewed.
2317
2318         Mach-O section names are limited to 16 characters.
2319
2320         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2321         * DumpRenderTree/mac/DumpRenderTree.mm:
2322         (activateFontsIOS):
2323
2324 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
2325
2326         Build fix for mac-debug EWS queue.
2327
2328         Unreviewed.
2329
2330         Pass --debug to run-webkit-tests.
2331
2332         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
2333         will need to be substantially modified to work in EWS, so the dummy implementation
2334         was not helpful.
2335
2336         * Scripts/webkitpy/common/config/ports.py:
2337         (DeprecatedPort.run_javascriptcore_tests_command):
2338         (DeprecatedPort):
2339         (DeprecatedPort.run_webkit_tests_command):
2340         (DeprecatedPort.run_python_unittests_command):
2341         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
2342         * Scripts/webkitpy/common/config/ports_mock.py:
2343         (MockPort.run_javascriptcore_tests_command):
2344         (MockPort):
2345         (MockPort.run_webkit_tests_command):
2346         (MockPort.run_bindings_tests_command):
2347         (MockPort.run_webkit_unit_tests_command): Deleted.
2348         * Scripts/webkitpy/tool/commands/download_unittest.py:
2349         * Scripts/webkitpy/tool/steps/runtests.py:
2350         (RunTests.run):
2351         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2352         (RunTestsTest.test_webkit_run_unit_tests):
2353         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2354         (StepsTest.test_runtests_args):
2355
2356 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
2357
2358         [Win] Generate Crash Traces
2359         https://bugs.webkit.org/show_bug.cgi?id=150103
2360
2361         Reviewed by Daniel Bates.
2362
2363         We were using an exception filter to try to emit "#CRASHED" to stderr
2364         when a test program crashed. However, the modern Python implementation
2365         seems capable of recognizing crashes on its own. Furthermore, registering
2366         the exception handler was preventing the JIT debugger (NTSD) from
2367         automatically attaching to the crashing program, so we were not getting
2368         crash traces.
2369         
2370         * DumpRenderTree/win/DumpRenderTree.cpp:
2371         (main): Don't register an exception filter.
2372         (exceptionFilter): Deleted.
2373         * Scripts/webkitpy/common/system/crashlogs.py:
2374         (CrashLogs): Add another regular expression to handle a second crash trace
2375         syntax I encountered during testing.
2376         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
2377         try the new one. The PID found by the new expression is in hexadecimal, so
2378         convert it to an integer before returning it.
2379         * Scripts/webkitpy/port/driver.py:
2380         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
2381         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
2382         check for "#CRASHED" after stripping off the EOL characters.
2383         * Scripts/webkitpy/port/win.py:
2384         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
2385         invocation. This is apparently used to signal an event when the debugger is finished.
2386
2387 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
2388
2389         Mac Debug and 32-bit queues should be separate
2390         https://bugs.webkit.org/show_bug.cgi?id=150092
2391
2392         Reviewed by Lucas Forschler.
2393
2394         * QueueStatusServer/config/queues.py:
2395         * QueueStatusServer/model/queues.py:
2396         (Queue._capitalize_after_dash):
2397         (Queue._caplitalize_after_dash): Deleted.
2398         * Scripts/webkitpy/common/config/ews.json:
2399
2400 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
2401
2402         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
2403         https://bugs.webkit.org/show_bug.cgi?id=150085
2404
2405         Reviewed by Carlos Garcia Campos.
2406
2407         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2408
2409 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
2410
2411         Unreviewed, add myself to the committers list.
2412
2413         * Scripts/webkitpy/common/config/contributors.json:
2414
2415 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
2416
2417         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
2418         https://bugs.webkit.org/show_bug.cgi?id=149983
2419
2420         Reviewed by Dan Bates.
2421
2422         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2423         (BubbleQueueServer):
2424         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2425
2426 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
2427
2428         Fix webkitpy tests after r190922.
2429
2430         * Scripts/webkitpy/common/config/ews.json:
2431         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2432         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2433
2434 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
2435
2436         Add a Mac debug EWS queue
2437         https://bugs.webkit.org/show_bug.cgi?id=150069
2438
2439         Reviewed by Geoffrey Garen.
2440
2441         * QueueStatusServer/config/queues.py:
2442         * Scripts/webkitpy/common/config/ews.json:
2443         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2444         (AbstractEarlyWarningSystem):
2445         (AbstractEarlyWarningSystem.archive_last_test_results):
2446         (AbstractEarlyWarningSystem.build_style):
2447         (AbstractEarlyWarningSystem.refetch_patch):
2448         (AbstractEarlyWarningSystem.load_ews_classes):
2449
2450 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
2451
2452         [GTK] Update jhbuild's version of harfbuzz
2453         https://bugs.webkit.org/show_bug.cgi?id=149749
2454
2455         Reviewed by Martin Robinson.
2456
2457         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
2458
2459         * gtk/jhbuild.modules: Updated details for harfbuzz.
2460
2461 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
2462
2463         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
2464         https://bugs.webkit.org/show_bug.cgi?id=150026
2465
2466         Reviewed by Philippe Normand.
2467
2468         Backport upstream patch from gst-plugins-bad so that the right version
2469         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
2470         gets compiled properly, avoiding crashes on runtime while running tests.
2471
2472         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
2473         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
2474
2475 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
2476
2477         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
2478         https://bugs.webkit.org/show_bug.cgi?id=149777
2479
2480         Reviewed by Simon Fraser.
2481
2482         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
2483         to the list of tests to preinstall at startup time.
2484
2485         Also, update the generation of the 'name' table in the FontWithFeatures font.
2486
2487         * DumpRenderTree/mac/DumpRenderTree.mm:
2488         (allowedFontFamilySet):
2489         (activateTestingFonts):
2490         (activateFontsIOS):
2491         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2492         (Generator::generate):
2493         (Generator::appendCFFTable):
2494         (Generator::appendNameSubtable):
2495         (Generator::appendNAMETable):
2496         * FontWithFeatures/FontWithFeatures/main.cpp:
2497         (main):
2498         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2499         (WTR::allowedFontFamilySet):
2500         (WTR::activateFonts):
2501         * WebKitTestRunner/mac/TestControllerMac.mm:
2502         (WTR::allowedFontFamilySet):
2503
2504 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
2505
2506         Unreviewed. Add Jinyoung Hur as a committer. 
2507
2508         * Scripts/webkitpy/common/config/contributors.json:
2509
2510 2015-10-10  Dan Bernstein  <mitz@apple.com>
2511
2512         [iOS] Remove unnecessary iOS version checks
2513         https://bugs.webkit.org/show_bug.cgi?id=150002
2514
2515         Reviewed by Alexey Proskuryakov.
2516
2517         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2518         (-[HIDEventGenerator _createIOHIDEventType:]):
2519         (-[HIDEventGenerator _sendHIDEvent:]):
2520         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2521         * WebKitTestRunner/ios/UIKitSPI.h:
2522
2523 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
2524
2525         Unreviewed, rolling out r190689
2526         https://bugs.webkit.org/show_bug.cgi?id=149992
2527
2528         Fixed in other repository.
2529
2530         Reverted changesets:
2531
2532         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
2533         https://bugs.webkit.org/show_bug.cgi?id=149897
2534
2535 2015-10-09  Brian Burg  <bburg@apple.com>
2536
2537         Teach webkitperl how to figure out IOS versions from the SDK
2538         https://bugs.webkit.org/show_bug.cgi?id=149963
2539
2540         Reviewed by Daniel Bates.
2541
2542         It should be easier to check the major and minor version of IOS SDKs.
2543
2544         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
2545         * Scripts/webkitdirs.pm:
2546         (splitVersionString): Added.
2547         (determineOSXVersion): Use splitVersionString.
2548         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
2549         (iosVersion): Added.
2550
2551 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
2552
2553         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
2554         https://bugs.webkit.org/show_bug.cgi?id=149960
2555
2556         Reviewed by Tim Horton.
2557         
2558         Use adoptWK(), and null out some members (file is not using ARC).
2559
2560         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
2561         (UIScriptContext::uiScriptComplete):
2562         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2563         (-[TestRunnerWKWebView dealloc]):
2564
2565 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
2566
2567         Remove ENABLE_SUID_SANDBOX_LINUX cruft
2568         https://bugs.webkit.org/show_bug.cgi?id=149954
2569
2570         Reviewed by Darin Adler.
2571
2572         * Scripts/webkitperl/FeatureList.pm:
2573
2574 2015-10-09  Daniel Bates  <dabates@apple.com>
2575
2576         Make iOS builders generate debug information in a separate dSYM file
2577         https://bugs.webkit.org/show_bug.cgi?id=149696
2578
2579         Reviewed by Darin Adler.
2580
2581         Similar to the Mac builders, the iOS builders should write debug information
2582         into a separate dSYM file instead of including such information in the binary
2583         itself (default Xcode behavior)
2584
2585         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2586         (CompileWebKit.start):
2587
2588 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
2589
2590         Fix webkitpy tests after r190779
2591         https://bugs.webkit.org/show_bug.cgi?id=149949
2592
2593         Reviewed by Ryosuke Niwa.
2594
2595         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2596         (BenchmarkResults.format):
2597         (BenchmarkResults._format_values):
2598
2599 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
2600
2601         Extend run-benchmark script to support human-readable results conversion.
2602         https://bugs.webkit.org/show_bug.cgi?id=149944
2603
2604         Reviewed by Ryosuke Niwa.
2605
2606         Add '--read-results-json' and '--no-adjust-unit' options.
2607         '--read-results-json' option converts result file to human readable format.
2608         '--no-adjust-unit' option skips scientific notation convertion.
2609         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
2610
2611         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2612         (BenchmarkResults.format):
2613         (BenchmarkResults._format_tests):
2614         (BenchmarkResults._format_values):
2615         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2616         (BenchmarkRunner.__init__):
2617         (BenchmarkRunner._run_benchmark):
2618         (BenchmarkRunner._dump):
2619         (BenchmarkRunner.show_results):
2620         (BenchmarkRunner._show_results): Deleted.
2621         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2622         (parse_args):
2623         (start):
2624
2625 2015-10-08  Daniel Bates  <dabates@apple.com>
2626
2627         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
2628         https://bugs.webkit.org/show_bug.cgi?id=149945
2629
2630         Reviewed by Dan Bernstein.
2631
2632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
2633         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
2634         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2635         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2636         (WebKitBuildbot):
2637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2638         (table.queue-grid tr.platform.ios-9 img.logo):
2639
2640 2015-10-08  Daniel Bates  <dabates@apple.com>
2641
2642         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
2643         https://bugs.webkit.org/show_bug.cgi?id=149943
2644
2645         Reviewed by Dan Bernstein.
2646
2647         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
2648         teach build-webkit to install them when building for iOS device using the public iOS SDK. 
2649
2650         * Scripts/build-webkit:
2651
2652 2015-10-08  Daniel Bates  <dabates@apple.com>
2653
2654         Add LLVM binaries for iOS 9 device
2655         https://bugs.webkit.org/show_bug.cgi?id=149913
2656
2657         Reviewed by Filip Pizlo.
2658
2659         Implement support for building LLVM for ARM64-based iOS devices.
2660
2661         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
2662         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
2663         an existing build earlier in the file such that remove previously built
2664         libraries before building/copying new ones (if applicable).
2665         (fileContains): Moved function outside of if-block.
2666         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
2667         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
2668         added logic to build LLVM for ARM64-based iOS devices.
2669         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
2670         LLVM into the WebKitBuild directory.
2671
2672 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
2673
2674         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
2675         https://bugs.webkit.org/show_bug.cgi?id=149848
2676
2677         Reviewed by Darin Adler.
2678
2679         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2680
2681 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
2682
2683         [Win] Support 64-bit Build and Testing
2684         https://bugs.webkit.org/show_bug.cgi?id=149904
2685
2686         Reviewed by Daniel Bates.
2687
2688         Extend our existing scripts to support 64-bit build and test operations on
2689         Windows.
2690
2691         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
2692         Windows always builds the whole stack.
2693         * Scripts/webkit-build-directory: Add an option to return the location of
2694         the executable files produced by a specific configuration. This change is
2695         actually useful for Gtk and EFL, too.
2696         * Scripts/webkitdirs.pm:
2697         (executableProductDir): Added. This function appends the proper binary
2698         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
2699         (jscProductDir): Use the new 'executableProductDir' method.
2700         (setPathForRunningWebKitApp): Ditto.
2701         (runSafari): Ditto.
2702         (runMiniBrowser): Ditto.
2703         * Scripts/webkitpy/port/factory.py:
2704         (configuration_options): Add a 64-bit option, used on Windows to specify
2705         which binary target should be used for testing.
2706         * Scripts/webkitpy/port/win.py:
2707         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
2708         processes when needed.
2709         (WinPort._build_path): Add the correct binary target path to _build_path.
2710         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
2711         64-bit paths for 64-bit tests.
2712         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
2713         NTSD debugger does not understand this argument.
2714
2715 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
2716
2717         Test font-variant-* and font-feature-settings with TrueType fonts
2718         https://bugs.webkit.org/show_bug.cgi?id=149776
2719
2720         Reviewed by Simon Fraser.
2721
2722         This test extends our existing FontWithFeatures project to be able to generate a
2723         TrueType font. This font is conceptually similar as the existing OpenType font,
2724         except the feature -> character mapping is different.
2725
2726         The font itself only supports the following characters:
2727         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
2728         However, the shape of these letters are either an X or a check mark.
2729         The letter "A" always is a check mark.
2730         The letter "B" always is an X.
2731         Each font feature has an letter associated with it. When the font feature is enabled,
2732         that letter is shown as a check mark. For example, when
2733         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
2734         mark.
2735
2736         Here are the mappings of font features to letters:
2737         kLigaturesType / kCommonLigaturesOnSelector: C
2738         kLigaturesType / kContextualLigaturesOnSelector: D
2739         kLigaturesType / kRareLigaturesOnSelector: G
2740         kLigaturesType / kHistoricalLigaturesOnSelector: I
2741         kContextualAlternatesType / kContextualAlternatesOnSelector: L
2742         kVerticalPositionType / kInferiorsSelector: O
2743         kVerticalPositionType / kSuperiorsSelector: P
2744         kLowerCaseType / kLowerCaseSmallCapsSelector: S
2745         kUpperCaseType / kUpperCaseSmallCapsSelector: V
2746         kLowerCaseType / kLowerCasePetiteCapsSelector: T
2747         kUpperCaseType / kUpperCasePetiteCapsSelector: W
2748         kLetterCaseType / 14: Y
2749         kStyleOptionsType / kTitlingCapsSelector: a
2750         kNumberCaseType / kUpperCaseNumbersSelector: c
2751         kNumberCaseType / kLowerCaseNumbersSelector: d
2752         kNumberSpacingType / kProportionalNumbersSelector: f
2753         kNumberSpacingType / kMonospacedNumbersSelector: g
2754         kFractionsType / kDiagonalFractionsSelector: i
2755         kFractionsType / kVerticalFractionsSelector: j
2756         kVerticalPositionType / kOrdinalsSelector: Q
2757         kTypographicExtrasType / kSlashedZeroOnSelector: k
2758         kLigaturesType / kHistoricalLigaturesOnSelector: K
2759         kCharacterShapeType / kJIS1978CharactersSelector: m
2760         kCharacterShapeType / kJIS1983CharactersSelector: n
2761         kCharacterShapeType / kJIS1990CharactersSelector: o
2762         kCharacterShapeType / kJIS2004CharactersSelector: p
2763         kCharacterShapeType / kSimplifiedCharactersSelector: q
2764         kCharacterShapeType / kTraditionalCharactersSelector: r
2765         kTextSpacingType / kMonospacedTextSelector: t
2766         kTextSpacingType / kProportionalTextSelector: u
2767         kRubyKanaType / kRubyKanaOnSelector: v
2768
2769         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
2770         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2771         (CFFBuilder::moveTo):
2772         (CFFBuilder::lineTo):
2773         (GLYFBuilder::GLYFBuilder):
2774         (GLYFBuilder::takeResult):
2775         (GLYFBuilder::moveTo):
2776         (GLYFBuilder::lineTo):
2777         (GLYFBuilder::closePath):
2778         (GLYFBuilder::writePoint):
2779         (GLYFBuilder::append16):
2780         (generateBoxCharString):
2781         (generateCheckCharString):
2782         (generateXCharString):
2783         (itemForGlyph):
2784         (Generator::generate):
2785         (Generator::insertSelector):
2786         (Generator::insertFeature):
2787         (Generator::generateFeatureDescription):
2788         (Generator::appendCFFTable):
2789         (Generator::appendGLYFTable):
2790         (Generator::appendLOCATable):
2791         (Generator::appendFEATTable):
2792         (Generator::appendMetamorphosisChain):
2793         (Generator::appendMORXTable):
2794         (Generator::appendHEADTable):
2795         (Generator::appendHMTXTable):
2796         (Generator::appendNameSubtable):
2797         (Generator::append2ByteASCIIString):
2798         (Generator::appendNAMETable):
2799         (generateFont):
2800         (CFFBuilder::curveToCubic): Deleted.
2801         (charStringForGlyph): Deleted.
2802         * FontWithFeatures/FontWithFeatures/FontCreator.h:
2803         * FontWithFeatures/FontWithFeatures/main.cpp:
2804         (constructFontWithTrueTypeFeature):
2805         (constructFontWithOpenTypeFeature):
2806         (drawText):
2807         (main):
2808         (drawTextWithFeature): Deleted.
2809
2810 2015-10-07  Commit Queue  <commit-queue@webkit.org>
2811
2812         Unreviewed, rolling out r190572, r190593, r190594, and
2813         r190639.
2814         https://bugs.webkit.org/show_bug.cgi?id=149897
2815
2816         Breaks Mavericks build (Requested by litherum on #webkit).
2817
2818         Reverted changesets:
2819
2820         "Allow WKRetainPtrs to be used as keys in hashing data
2821         structures"
2822         https://bugs.webkit.org/show_bug.cgi?id=149762
2823         http://trac.webkit.org/changeset/190572
2824
2825         "REGRESSION(189668?): http/tests/notifications/events.html
2826         flakily asserts or times out"
2827         https://bugs.webkit.org/show_bug.cgi?id=149218
2828         http://trac.webkit.org/changeset/190593
2829
2830         "Prospective Mavericks build fix."
2831         http://trac.webkit.org/changeset/190594
2832
2833         "Post-review cleanup after r190572."
2834         http://trac.webkit.org/changeset/190639
2835
2836 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2837
2838         [GTK] Add autocleanups
2839         https://bugs.webkit.org/show_bug.cgi?id=149588
2840
2841         Reviewed by Darin Adler.
2842
2843         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
2844         (AutocleanupsTest::create):
2845         (AutocleanupsTest::testWebProcessAutocleanups):
2846         (registerTests):
2847         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2848         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
2849         (testUIProcessAutocleanups):
2850         (testWebProcessAutocleanups):
2851         (beforeAll):
2852         (afterAll):
2853
2854 2015-10-06  Brian Burg  <bburg@apple.com>
2855
2856         Unreviewed, try to fix the iOS 8 build after r190368.
2857
2858         On older versions, IOHIDEventCreateForceEvent is not available.
2859
2860         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2861         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
2862
2863 2015-10-06  Keith Miller  <keith_miller@apple.com>
2864
2865         Add gmalloc option to run-javascriptcore-tests.
2866         https://bugs.webkit.org/show_bug.cgi?id=149858
2867
2868         Reviewed by Geoffrey Garen.
2869
2870         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
2871         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
2872
2873         * Scripts/run-javascriptcore-tests:
2874
2875 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
2876
2877         Post-review cleanup after r190572.
2878
2879         Unreviewed.
2880
2881         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
2882
2883 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
2884
2885         [Win] Unreviewed build correction.
2886
2887         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
2888         are soft-linked at runtime.
2889
2890 2015-10-06  Keith Miller  <keith_miller@apple.com>
2891
2892         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
2893         https://bugs.webkit.org/show_bug.cgi?id=149815
2894
2895         Reviewed by Filip Pizlo.
2896
2897         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
2898         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
2899         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
2900         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
2901         so should just use one test runner.
2902
2903         * Scripts/run-javascriptcore-tests:
2904         (runJSCStressTests):
2905         (runMozillaTests): Deleted.
2906         (defaultJsDriverArgsForMozillaTests): Deleted.
2907         * Scripts/run-jsc-stress-tests:
2908
2909 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
2910
2911         [GTK] Make update-webkitgtk-libs work behind firewall
2912
2913         update-webkitgtk-libs can work behind a firewall with changes to
2914         a few packages.  Where outbound git and active FTP connections
2915         fail, using http protocol succeeds.  Most packages are
2916         already accessed using http.
2917
2918         https://bugs.webkit.org/show_bug.cgi?id=148941
2919
2920         Reviewed by Martin Robinson.
2921
2922         Tools
2923         * gtk/jhbuild.modules:
2924             Replace git URLs with http.  Remove no longer used ftp repositories.
2925             Update argument for libxml2's autogen.sh script (--without-python
2926             is ignored; --with-python=no is correct).
2927         * jhbuild/jhbuild-wrapper:
2928             Instead of connecting to git://git.gnome.org/jhbuild, connect to
2929             http://git.gnome.org/browse/jhbuild.
2930
2931 2015-10-06  Daniel Bates  <dbates@webkit.org>
2932
2933         Enable XSLT when building WebKit for iOS using the public iOS SDK
2934         https://bugs.webkit.org/show_bug.cgi?id=149827
2935
2936         Reviewed by Alexey Proskuryakov.
2937
2938         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
2939         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
2940         run this script before building WebKit for iOS or the build will fail because one or more XSLT
2941         headers cannot be found.
2942
2943         * Scripts/configure-xcode-for-ios-development:
2944         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
2945
2946 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
2947
2948         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
2949         https://bugs.webkit.org/show_bug.cgi?id=149218
2950
2951         Reviewed by Alexey Proskuryakov.
2952
2953         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
2954         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
2955         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
2956         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
2957         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
2958         WebNotificationProvider must be updated to appropriately handle multiple
2959         WKNotificationManagerRefs in flight at the same time.
2960
2961         * WebKitTestRunner/WebNotificationProvider.cpp:
2962         (WTR::WebNotificationProvider::~WebNotificationProvider):
2963         (WTR::WebNotificationProvider::showWebNotification):
2964         (WTR::WebNotificationProvider::closeWebNotification):
2965         (WTR::WebNotificationProvider::addNotificationManager):
2966         (WTR::WebNotificationProvider::removeNotificationManager):
2967         (WTR::WebNotificationProvider::simulateWebNotificationClick):
2968         (WTR::WebNotificationProvider::reset):
2969         * WebKitTestRunner/WebNotificationProvider.h:
2970
2971 2015-10-05  Daniel Bates  <dabates@apple.com>
2972
2973         Disable Bitcode when building for iOS device
2974         https://bugs.webkit.org/show_bug.cgi?id=149818
2975
2976         Reviewed by Alexey Proskuryakov.
2977
2978         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
2979         when building for iOS device.
2980
2981         * Scripts/webkitdirs.pm:
2982         (XcodeOptions):
2983
2984 2015-10-05  Daniel Bates  <dabates@apple.com>
2985
2986         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
2987         https://bugs.webkit.org/show_bug.cgi?id=140828
2988         <rdar://problem/19520599>
2989
2990         Reviewed by Alexey Proskuryakov.
2991
2992         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
2993         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
2994         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
2995         to build-webkit.
2996
2997         * Scripts/webkitdirs.pm:
2998         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
2999         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
3000         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
3001         (hasIOSDevelopmentCertificate): Added.
3002
3003 2015-10-05  Daniel Bates  <dabates@apple.com>
3004
3005         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
3006         https://bugs.webkit.org/show_bug.cgi?id=149766
3007
3008         Reviewed by Alexey Proskuryakov.
3009
3010         Create network storage testing session on iOS.
3011
3012         Currently we do not create a network storage testing session on iOS. A network storage testing session always
3013         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
3014         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
3015         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
3016         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
3017         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
3018         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
3019         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
3020         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
3021
3022         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
3023         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
3024         returns a non-null pointer to a cookie store.
3025
3026         * DumpRenderTree/mac/DumpRenderTree.mm:
3027         (prepareConsistentTestingEnvironment):
3028
3029 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
3030
3031         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
3032         available.
3033
3034         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3035         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
3036
3037 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
3038
3039         Allow WKRetainPtrs to be used as keys in hashing data structures
3040         https://bugs.webkit.org/show_bug.cgi?id=149762
3041
3042         Reviewed by Anders Carlsson.
3043
3044         * TestWebKitAPI/PlatformGTK.cmake:
3045         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3046         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
3047         (TestWebKitAPI::TEST):
3048
3049 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
3050
3051         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
3052         available, and tidy up the #ifdefs in the UIKitSPI header.
3053
3054         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3055         (-[HIDEventGenerator _sendHIDEvent:]):
3056         * WebKitTestRunner/ios/UIKitSPI.h:
3057
3058 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
3059
3060         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
3061         https://bugs.webkit.org/show_bug.cgi?id=149792
3062
3063         Reviewed by Martin Robinson.
3064
3065         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
3066         for WebKitTestRunner multiple times.
3067
3068 2015-10-04  Daniel Bates  <dabates@apple.com>
3069
3070         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
3071         (https://bugs.webkit.org/show_bug.cgi?id=149753)
3072
3073         For now, support calling build-layouttestrelay without --ios-simulator so long
3074         as we are building on a Mac.
3075
3076         * Scripts/build-layouttestrelay:
3077
3078 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
3079
3080         Support Trac 1.0.x XML timeline link format
3081         https://bugs.webkit.org/show_bug.cgi?id=149786
3082
3083         Reviewed by Lucas Forschler.
3084
3085         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3086         (Trac.prototype._convertCommitInfoElementToObject):
3087
3088 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
3089
3090         Fix some errors on bot watcher's dashboard
3091         https://bugs.webkit.org/show_bug.cgi?id=149789
3092
3093         Reviewed by Lucas Forschler.
3094
3095         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3096         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
3097         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
3098
3099 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
3100
3101         Bot watcher's dashboard builders should turn yellow when svn fails
3102         https://bugs.webkit.org/show_bug.cgi?id=149791
3103
3104         Reviewed by Lucas Forschler.
3105
3106         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3107         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
3108         (BuildbotBuilderQueueView.prototype.update):
3109
3110 2015-10-02  Daniel Bates  <dabates@apple.com>
3111
3112         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
3113         https://bugs.webkit.org/show_bug.cgi?id=149769
3114
3115         Reviewed by Alexey Proskuryakov.
3116
3117         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
3118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
3119         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3120         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3121         (WebKitBuildbot):
3122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3123         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
3124
3125 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
3126
3127         REGRESSION(r190370): Speedometer spits out an extra console message
3128         https://bugs.webkit.org/show_bug.cgi?id=149720
3129
3130         Unreviewed. Temporarily ignore the console error message.
3131
3132         * Scripts/webkitpy/performance_tests/perftest.py:
3133         (PerfTest._filter_output):
3134
3135 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
3136
3137         Provide "--no-ninja" option to avoid using Ninja
3138         https://bugs.webkit.org/show_bug.cgi?id=149757
3139
3140         Reviewed by Alex Christensen.
3141
3142         Add a new command line argument understood by webkitdirs.pm so
3143         that we can conditionally avoid using Ninja. This is an
3144         'opt-out' argument, so no existing Ninja users should be affected.
3145         
3146         * Scripts/webkitdirs.pm:
3147         (canUseNinja): Check for option and block ninja if present.
3148
3149 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
3150
3151         Flakiness dashboard should support OS X El Capitan
3152         https://bugs.webkit.org/show_bug.cgi?id=149648
3153
3154         Reviewed by Alexey Proskuryakov.
3155
3156         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
3157
3158 2015-10-02  Daniel Bates  <dabates@apple.com>
3159
3160         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
3161         (https://bugs.webkit.org/show_bug.cgi?id=149753)
3162
3163         For now, pass --ios-simulator.
3164
3165         * Scripts/webkitpy/port/ios.py:
3166         (IOSSimulatorPort._build_relay):
3167
3168 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
3169
3170         Remove a "nullable" that breaks the iOS 8 build.
3171
3172         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3173         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
3174
3175 2015-10-02  Daniel Bates  <dabates@apple.com>
3176
3177         LayoutTestRelay is not built and archived when building for iOS Simulator
3178         https://bugs.webkit.org/show_bug.cgi?id=149753
3179
3180         Reviewed by Alexey Proskuryakov and Andy Estes.
3181
3182         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
3183         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
3184         product archive when building for iOS Simulator, respectively.
3185
3186         * BuildSlaveSupport/built-product-archive:
3187         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
3188         differentiate between iOS device and iOS Simulator platforms.
3189         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
3190         from determineWebKitBuildDirectories() into this function so that it can be used by both
3191         determineWebKitBuildDirectories() and archiveBuiltProduct().
3192         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
3193         webkitBuildDirectoryForConfigurationAndPlatform().
3194         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
3195         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
3196         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
3197         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
3198         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
3199         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
3200         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
3201         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
3202         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
3203         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
3204         * Scripts/build-layouttestrelay:
3205             - Remove unnecessary include of Perl module POSIX.
3206             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
3207         * Scripts/build-webkit:
3208             - Invoke script build-layouttestrelay when building for iOS Simulator.
3209
3210 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
3211
3212         [Win] Unreviewed test fix.
3213
3214         You cannot run 'run-webkit-tests' from the command line because it does not know
3215         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
3216         because they explicitly set use the 'root' argument to provide the full path to
3217         the test binaries.
3218
3219         * Scripts/webkitpy/port/win.py:
3220         (WinPort._build_path): Added.
3221
3222 2015-10-02  Alex Christensen  <achristensen@webkit.org>
3223
3224         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
3225         https://bugs.webkit.org/show_bug.cgi?id=149430
3226         rdar://problem/22742222
3227
3228         Reviewed by Geoffrey Garen.
3229
3230         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3231         (WTR::TestController::cocoaResetStateToConsistentValues):
3232         * WebKitTestRunner/mac/TestControllerMac.mm:
3233         (WTR::TestController::platformConfigureViewForTest):
3234         Test what happens when you disable content blockers from the SPI.
3235
3236 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
3237
3238         [Win] Unreviewed build fix for run-api-tests
3239
3240         * Scripts/run-api-tests:
3241         (testToolPaths): Windows run needs to specify the binary path.
3242
3243 2015-10-01  Daniel Bates  <dabates@apple.com>
3244
3245         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
3246         (https://bugs.webkit.org/show_bug.cgi?id=149695)
3247
3248         Following r190424 we can now rely on webkit-build-directory to return the path to
3249         the correct configuration-specific build directory on Windows.
3250
3251         * BuildSlaveSupport/built-product-archive:
3252         (archiveBuiltProduct):
3253
3254 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
3255
3256         [Win] Unreviewed build fix.
3257
3258         * Scripts/webkitdirs.pm:
3259         (setupAppleWinEnv): Use 64-bit build tools if available
3260
3261 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
3262
3263         [Win] Fix TestWebKitAPI build under CMake.
3264
3265         Reviewed by Alex Christensen.
3266
3267         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
3268         for Psapi.lib.
3269
3270 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
3271
3272         [Win] Fix behavior of webkit-build-directory script
3273         https://bugs.webkit.org/show_bug.cgi?id=149718
3274
3275         Reviewed by Alex Christensen.
3276
3277         * Scripts/webkitdirs.pm:
3278         (determineConfigurationProductDir): Do not include the binary
3279         sub-directory in the configuration product directory output.
3280         (jscProductDir): Append correct binary path for Windows build.
3281         (setPathForRunningWebKitApp): Include properly binary subdirectories.
3282         (runSafari): Update for revised productDir behavior.
3283         (runMiniBrowser): Ditto.
3284
3285 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
3286
3287         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
3288         use iOS SDK, like with all the others.
3289
3290         * Scripts/build-webkit:
3291
3292 2015-10-01  Daniel Bates  <dabates@apple.com>
3293
3294         Attempt to fix the iOS 9 Simulator testers
3295
3296         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
3297         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
3298         LayoutTestRelay when building for iOS Simulator.
3299
3300         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3301         * Scripts/build-webkit:
3302
3303 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3304
3305         [GTK] Websites with invalid auth header keep loading forever
3306         https://bugs.webkit.org/show_bug.cgi?id=149710
3307
3308         Reviewed by Martin Robinson.
3309
3310         Add test case to check that we can authenticate sites with an
3311         empty realm.
3312
3313         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
3314         (testWebViewAuthenticationEmptyRealm):
3315         (serverCallback):
3316         (beforeAll):
3317
3318 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
3319
3320         [Mac] Make run-api-tests work with System Integrity Protection
3321         https://bugs.webkit.org/show_bug.cgi?id=149711
3322         rdar://problem/22928202
3323
3324         Reviewed by Dan Bernstein.
3325
3326         * Scripts/run-api-tests:
3327         (runTest):
3328         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
3329
3330 2015-10-01  Daniel Bates  <dabates@apple.com>
3331
3332         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
3333         (https://bugs.webkit.org/show_bug.cgi?id=149695)
3334
3335         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
3336         For now, use the path to the top-level WebKit build directory instead of using the configuration-
3337         specific build directory.
3338
3339         * BuildSlaveSupport/built-product-archive:
3340         (archiveBuiltProduct):
3341
3342 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
3343
3344         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
3345         https://bugs.webkit.org/show_bug.cgi?id=145837
3346
3347         Reviewed by Philippe Normand.
3348
3349         * efl/jhbuild.modules:
3350         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
3351         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
3352
3353 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3354
3355         Unreviewed. Fix the iOS build after r190407.
3356
3357         * WebKitTestRunner/ios/IOKitSPI.h:
3358
3359 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3360
3361         Implement keyboard event sending for iOS in WebKitTestRunner
3362         https://bugs.webkit.org/show_bug.cgi?id=149676
3363
3364         Reviewed by Simon Fraser.
3365
3366         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
3367         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
3368         allows us to run code when the keyboard is shown or hidden.
3369
3370         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
3371         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3372         (WTR::UIScriptController::setDidShowKeyboardCallback):
3373         (WTR::UIScriptController::didShowKeyboardCallback):
3374         (WTR::UIScriptController::setDidHideKeyboardCallback):
3375         (WTR::UIScriptController::didHideKeyboardCallback):
3376         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
3377         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
3378         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
3379         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3380         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3381         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3382         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
3383                 the notifications that the keyboard has been raised or lowered.
3384         (-[TestRunnerWKWebView _keyboardDidShow:]):
3385         (-[TestRunnerWKWebView _keyboardDidHide:]):
3386         * WebKitTestRunner/ios/HIDEventGenerator.h:
3387         * WebKitTestRunner/ios/HIDEventGenerator.m:
3388         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
3389         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
3390         (hidUsageCodeForCharacter): Ditto.
3391         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
3392                 a keyDown event in WebKit.
3393         * WebKitTestRunner/ios/IOKitSPI.h:
3394         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3395
3396 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3397
3398         Unreviewed, rolling out r190399.
3399
3400         Tests are still failing even after r190362
3401
3402         Reverted changeset:
3403
3404         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
3405         http://trac.webkit.org/changeset/190399
3406
3407 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
3408
3409         [jhbuild] switch to new upstream usrsctp library
3410         https://bugs.webkit.org/show_bug.cgi?id=149494
3411
3412         Reviewed by Philippe Normand.
3413
3414         * efl/jhbuild.modules:
3415         * gtk/jhbuild.modules:
3416
3417 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3418
3419         Unreviewed. Unskip GTK+ user media unit tests after r190362.
3420
3421         They should pass now.
3422
3423         * Scripts/run-gtk-tests:
3424         (TestRunner):
3425
3426 2015-09-30  Daniel Bates  <dabates@apple.com>
3427
3428         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
3429         (https://bugs.webkit.org/show_bug.cgi?id=149695)
3430
3431         * BuildSlaveSupport/built-product-archive:
3432         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
3433         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
3434
3435 2015-09-30  Daniel Bates  <dabates@apple.com>
3436
3437         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
3438         (https://bugs.webkit.org/show_bug.cgi?id=149695)
3439
3440         Actually, we need to pass --configuration to script webkit-build-directory to have
3441         it return the path to the configuration-specific build directory.
3442
3443         * BuildSlaveSupport/built-product-archive:
3444         (determineWebKitBuildDirectories):
3445
3446 2015-09-30  Daniel Bates  <dabates@apple.com>
3447
3448         built-product-archive archives incorrect build directory for iOS port
3449         https://bugs.webkit.org/show_bug.cgi?id=149695
3450
3451         Reviewed by Darin Adler.
3452
3453         Fixes an issue where the script built-product-archive archives a non-existent
3454         build directory for the iOS port. Without loss of generality, the script assumes
3455         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
3456         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
3457
3458         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
3459         to determine the top-level build directory and computes the configuration-specific
3460         build directory to be the concatenation of the the top-level build directory and
3461         the configuration (e.g. Release). This is incorrect. Instead we should call
3462         webkit-build-directory omitting the flag --top-level to compute the path to the
3463         configuration-specific build directory.
3464
3465         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
3466         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
3467         its purpose and added global variable _configurationBuildDirectory to store the path
3468         to the configuration-specific build directory. Ensure that we have a non-empty string
3469         for both the top-level and configuration-specific build directories.
3470         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
3471         Compute the configuration-specific build directory and store it in the global variable
3472         _configurationBuildDirectory.
3473         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
3474         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
3475         as needed.
3476         (determineWebKitBuildDirectory): Deleted.
3477
3478 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
3479
3480         [EFL] css3/device-adapt/* tests failed after r190335.
3481         https://bugs.webkit.org/show_bug.cgi?id=149655
3482
3483         Reviewed by Simon Fraser.
3484
3485         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
3486         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
3487
3488         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3489         (WTR::shouldUseFixedLayout):
3490
3491 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
3492
3493         Extend JetStream timeout for slow devices.
3494
3495         Reviewed by Chris Dumez.
3496
3497         Extend JetStream timeout to 20 minutes.
3498
3499         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
3500
3501 2015-09-30  Daniel Bates  <dabates@apple.com>
3502
3503         Rename iOS builders/testers to include version
3504         https://bugs.webkit.org/show_bug.cgi?id=149685
3505
3506         Reviewed by Simon Fraser.
3507
3508         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
3509         make it clear to a reader the version of iOS these builders/testers are using.
3510
3511         * BuildSlaveSupport/build.webkit.org-config/config.json:
3512         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3513
3514 2015-09-30  Daniel Bates  <dabates@apple.com>
3515
3516         Add iOS criterion for triggering a build
3517         https://bugs.webkit.org/show_bug.cgi?id=149679
3518
3519         Rubber-stamped by Alexey Proskuryakov.
3520
3521         First pass at defining criterion for triggering an iOS build.
3522
3523         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3524         (_should_file_trigger_build):
3525         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3526         (ShouldBuildTest):
3527         (ShouldBuildTest.test_should_build):
3528
3529 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
3530
3531         [iOS] Allow tests to generate user gestures for UI testing
3532         https://bugs.webkit.org/show_bug.cgi?id=149653
3533
3534         Reviewed by Tim Horton.
3535
3536         Expose functionality in UIScriptController to allow for testing single- and double-tap,
3537         and to listen for completion of scrolling and zooming in the WKWebView.
3538         
3539         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
3540         which hides the complexity of creating these events. Event dispatch is asynchronous.
3541         We detect when the last event has been handled by dispatching a vendor-specific event,
3542         which is detected via -_handleHIDEvent: in our UIApplication subclass.
3543         
3544         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
3545         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
3546         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
3547         single and double taps.
3548         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
3549         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
3550         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
3551         (UIScriptContext::unregisterCallback):
3552         (UIScriptContext::callbackWithID):
3553         (UIScriptContext::fireCallback):
3554         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
3555         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3556         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
3557         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
3558         (WTR::UIScriptController::setDidEndZoomingCallback):
3559         (WTR::UIScriptController::didEndZoomingCallback):
3560         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
3561         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
3562         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
3563         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
3564         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3565         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3566         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
3567         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3568         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
3569         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
3570         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
3571         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
3572         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
3573         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
3574         (simpleDragCurve):
3575         (calculateNextLocation):
3576         (delayBetweenMove):
3577         (+[HIDEventGenerator sharedHIDEventGenerator]):
3578         (+[HIDEventGenerator nextEventCallbackID]):
3579         (-[HIDEventGenerator init]):
3580         (-[HIDEventGenerator _createIOHIDEventType:]):
3581         (-[HIDEventGenerator _sendHIDEvent:]):
3582         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
3583         (-[HIDEventGenerator _updateTouchPoints:count:]):
3584         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
3585         (-[HIDEventGenerator touchDown:touchCount:]):
3586         (-[HIDEventGenerator touchDown:]):
3587         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
3588         (-[HIDEventGenerator liftUp:touchCount:]):
3589         (-[HIDEventGenerator liftUp:]):
3590         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
3591         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3592         (-[HIDEventGenerator tap:completionBlock:]):
3593         (-[HIDEventGenerator doubleTap:completionBlock:]):
3594         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
3595         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3596         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
3597         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
3598         (-[HIDEventGenerator markerEventReceived:]):
3599         * WebKitTestRunner/ios/IOKitSPI.h: Added.
3600         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
3601         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3602         (WTR::globalToContentCoordinates):
3603         (WTR::UIScriptController::singleTapAtPoint):
3604         (WTR::UIScriptController::doubleTapAtPoint):
3605         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
3606         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
3607         * WebKitTestRunner/ios/mainIOS.mm:
3608         (-[WebKitTestRunnerApp _handleHIDEvent:]):
3609
3610 2015-09-30  Dana Burkart  <dburkart@apple.com>
3611
3612         git-add-reviewer should trim trailing spaces/newlines
3613         https://bugs.webkit.org/show_bug.cgi?id=149513
3614
3615         Reviewed by Darin Adler.
3616
3617         * Scripts/git-add-reviewer:
3618         (nonInteractive):
3619
3620 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
3621
3622         REGRESSION(r190262): User media unit test failures after r190262
3623         https://bugs.webkit.org/show_bug.cgi?id=149580
3624
3625         Reviewed by Darin Adler.
3626
3627         * WebKitTestRunner/TestController.cpp:
3628         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
3629           order to WKUserMediaPermissionRequestAllow.
3630
3631 2015-09-30  Daniel Bates  <dabates@apple.com>
3632
3633         Add iOS builders and testers
3634         https://bugs.webkit.org/show_bug.cgi?id=149549
3635
3636         Reviewed by Alexey Proskuryakov.