Make update-webkit-localizable-strings put WebKit/win strings in WebCore
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-18  Timothy Hatcher  <timothy@apple.com>
2
3         Make update-webkit-localizable-strings put WebKit/win strings in WebCore
4         now that all localized strings in WebKit/win use WEB_UI_STRING.
5
6         https://webkit.org/b/58747
7
8         Reviewed by Dan Bernstein.
9
10         * Scripts/update-webkit-localizable-strings: Remove the code that updated WebKit/win differently.
11
12 2011-04-18  Patrick Gansterer  <paroga@webkit.org>
13
14         Reviewed by Adam Roben.
15
16         [WIN] Use WCHAR instead of TCHAR
17         https://bugs.webkit.org/show_bug.cgi?id=58755
18
19         We always use the UNICODE versions of windows functions, so
20         the usage of TCHAR makes no sense and mixing them is bad style.
21
22         * WinLauncher/PrintWebUIDelegate.cpp:
23           Also fix various style issues (including indentation and removal of ugly C-casts).
24         * WinLauncher/WinLauncher.cpp:
25
26 2011-04-18  Dominic Cooney  <dominicc@chromium.org>
27
28         Reviewed by Andreas Kling.
29
30         Add layoutTestController.shadowRoot to Qt DRT.
31         https://bugs.webkit.org/show_bug.cgi?id=58759
32
33         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
34         (LayoutTestController::shadowRoot): Added.
35         * DumpRenderTree/qt/LayoutTestControllerQt.h:
36
37 2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
38
39         Unreviewed, rolling out r84111.
40         http://trac.webkit.org/changeset/84111
41         https://bugs.webkit.org/show_bug.cgi?id=58771
42
43         Chromium linux layout tests are broken. (Requested by loislo2
44         on #webkit).
45
46         * Scripts/webkitpy/layout_tests/port/chromium.py:
47         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
48         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
49
50 2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
51
52         Unreviewed, rolling out r84112.
53         http://trac.webkit.org/changeset/84112
54         https://bugs.webkit.org/show_bug.cgi?id=58770
55
56         Chromium linux layout tests are broken. (Requested by loislo2
57         on #webkit).
58
59         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
60         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
61
62 2011-04-17  Daniel Bates  <dbates@webkit.org>
63
64         Reviewed by Eric Seidel and Adam Barth.
65
66         webkit-patch land hangs if svn prompts for credentials
67         https://bugs.webkit.org/show_bug.cgi?id=31500
68
69         Prompt for username and password when using git-svn and there aren't cached SVN credentials.
70
71         * Scripts/webkitpy/common/checkout/scm.py:
72           - Added mixin class SVNRepository and made both class SVN and Git inherit from it.
73           - Moved SVN.has_authorization_for_realm() to class SVNRepository and removed default value
74             for argument realm; modified call sites as needed.
75           - Modified AuthenticationError constructor to take optional prompt_for_password argument.
76           - Modified {SCM, SVN, Git}.commit_with_message() to take optional password argument.
77           - Modified Git._commit_on_branch() to take optional username and password argument.
78           - Modified Git.push_local_commits_to_server() to take optional username and password
79             argument and to call has_authorization_for_realm().
80         * Scripts/webkitpy/common/checkout/scm_unittest.py:
81           - Modified SVNTest.test_commit_without_authorization() to take dummy realm argument.
82           - Modified SVNTest.test_not_have_authorization_for_realm() to pass realm argument to
83             SVN.has_authorization_for_realm().
84         * Scripts/webkitpy/common/net/credentials.py:
85           - Modified Credentials.read_credentials() to call User.prompt_password() instead
86             of using getpass.getpass() directly.
87         * Scripts/webkitpy/common/system/user.py:
88           - Added User.prompt_password().
89         * Scripts/webkitpy/tool/steps/commit.py:
90           - Modified Commit.run() to prompt for a password if needed.
91
92 2011-04-17  Dirk Pranke  <dpranke@chromium.org>
93
94         Reviewed by Ojan Vafai.
95
96         new-run-webkit-tests: save stderr into the layout-test-results dir
97         https://bugs.webkit.org/show_bug.cgi?id=58690
98
99         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
100         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
101
102 2011-04-17  Dirk Pranke  <dpranke@chromium.org>
103
104         Reviewed by Ojan Vafai.
105
106         new-run-webkit-tests: read stderr from chromium DRT separately
107         https://bugs.webkit.org/show_bug.cgi?id=58708
108
109         * Scripts/webkitpy/layout_tests/port/chromium.py:
110         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
111         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
112
113 2011-04-17  Patrick Gansterer  <paroga@webkit.org>
114
115         Reviewed by Adam Barth.
116
117         Rename PLATFORM(CA) to USE(CA)
118         https://bugs.webkit.org/show_bug.cgi?id=58742
119
120         * DumpRenderTree/mac/DumpRenderTree.mm:
121         (resetDefaultsToConsistentValues):
122
123 2011-04-17  Patrick Gansterer  <paroga@webkit.org>
124
125         Reviewed by Adam Barth.
126
127         Rename PLATFORM(CG) to USE(CG)
128         https://bugs.webkit.org/show_bug.cgi?id=58729
129
130         * DumpRenderTree/PixelDumpSupport.cpp:
131         * DumpRenderTree/chromium/WebViewHost.cpp:
132         (WebViewHost::paintRect):
133         * DumpRenderTree/config.h:
134         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
135         (createBitmapContextFromWebView):
136         * TestWebKitAPI/PlatformWebView.h:
137         * WebKitTestRunner/config.h:
138         * WebKitTestRunner/win/TestInvocationWin.cpp:
139
140 2011-04-16  Patrick Gansterer  <paroga@webkit.org>
141
142         Reviewed by Eric Seidel.
143
144         Rename PLATFORM(CAIRO) to USE(CAIRO)
145         https://bugs.webkit.org/show_bug.cgi?id=55192
146
147         * DumpRenderTree/PixelDumpSupport.cpp:
148         * DumpRenderTree/config.h:
149         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
150         (createBitmapContextFromWebView):
151         * WebKitTestRunner/config.h:
152
153 2011-04-16  Ojan Vafai  <ojan@chromium.org>
154
155         Reviewed by Eric Seidel.
156
157         show diffs+test inline in the results page
158         https://bugs.webkit.org/show_bug.cgi?id=58723
159         
160         Put each row in it's own tbody and sort based on tbodies. That way
161         we can append the results to the tbody inline as another table row.
162
163         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
164
165 2011-04-16  Ojan Vafai  <ojan@chromium.org>
166
167         Reviewed by Eric Seidel.
168
169         handle new tests in the new results html file
170         https://bugs.webkit.org/show_bug.cgi?id=58715
171
172         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
173
174 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
175
176         Reviewed by Ojan Vafai.
177
178         old-run-webkit-tests: save the list of tests actually run to a file
179         https://bugs.webkit.org/show_bug.cgi?id=58692
180
181         * Scripts/old-run-webkit-tests:
182
183 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
184
185         Reviewed by Ojan Vafai.
186
187         fix MockFileSystem.abspath() on windows
188         https://bugs.webkit.org/show_bug.cgi?id=58713
189
190         The existing code was borked on Windows if a path was passed
191         in using a drive letter (e.g., "d:\foo.txt"), and would go
192         into an infinite recursive loop. While win paths shouldn't
193         normally be passed into the mock filesystem, this just
194         bulletproofs things a bit (note that "/foo.txt" is considered
195         an absolute path on windows python as well.
196
197         * Scripts/webkitpy/common/system/filesystem_mock.py:
198
199 2011-04-15  Ojan Vafai  <ojan@chromium.org>
200
201         Reviewed by Eric Seidel.
202
203         show stderr files and httpd log files
204         https://bugs.webkit.org/show_bug.cgi?id=58714
205
206         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
207         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
208
209 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
210
211         Reviewed by James Robinson.
212
213         Add a flag to guard Page Visibility API changes.
214         https://bugs.webkit.org/show_bug.cgi?id=58464
215
216         * Scripts/build-webkit:
217
218 2011-04-15  Chang Shu  <cshu@webkit.org>
219
220         Reviewed by Alexey Proskuryakov.
221
222         When a message with url embedded is added to console, the "file:" scheme
223         and path should be stripped.
224         https://bugs.webkit.org/show_bug.cgi?id=58665
225
226         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
227         (WTR::lastFileURLPathComponent):
228         (WTR::InjectedBundlePage::willAddMessageToConsole):
229
230 2011-04-15  Jeff Miller  <jeffm@apple.com>
231
232         Reviewed by Sam Weinig.
233
234         Add takeFocus callback to WKPageUIClient
235         https://bugs.webkit.org/show_bug.cgi?id=58686
236
237         Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner.
238
239         * MiniBrowser/mac/BrowserWindowController.m:
240         (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry.
241         * MiniBrowser/win/BrowserView.cpp:
242         (BrowserView::create): Added empty takeFocus entry.
243         * WebKitTestRunner/TestController.cpp:
244         (WTR::TestController::createOtherPage): Added empty takeFocus entry.
245         (WTR::TestController::initialize): Added empty takeFocus entry.
246
247 2011-04-15  Ojan Vafai  <ojan@chromium.org>
248
249         Reviewed by Eric Seidel.
250
251         only show pretty-diff/wdiff if they were generated
252         https://bugs.webkit.org/show_bug.cgi?id=58682
253
254         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
255         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
256         * Scripts/webkitpy/layout_tests/port/base.py:
257
258 2011-04-15  Andreas Kling  <kling@webkit.org>
259
260         Reviewed by Antonio Gomes.
261
262         [Qt] DRT: Default custom policy delegate decision should be Ignore.
263
264         If layoutTestController.setCustomPolicyDelegate() is called with only
265         one argument, the second ("permissive") should default to false.
266
267         * DumpRenderTree/qt/LayoutTestControllerQt.h:
268
269 2011-04-15  Ojan Vafai  <ojan@chromium.org>
270
271         Reviewed by Eric Seidel.
272
273         fix path to layout test in new results file
274         https://bugs.webkit.org/show_bug.cgi?id=58618
275
276         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
277         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
278
279 2011-04-15  Ojan Vafai  <ojan@chromium.org>
280
281         Reviewed by Eric Seidel.
282
283         fix sorting in new results file
284         https://bugs.webkit.org/show_bug.cgi?id=58616
285
286         -Fix the custom sort to return -1, 0, 1 instead of true/false.
287         -Secondary sort by test name when sort values are equal.
288         -Sort by test name by default.
289
290         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
291
292 2011-04-15  Dmitry Lomov  <dslomov@google.com>
293
294         Reviewed by David Levin.
295
296         check-webkit-style shouldn't complain about not including a primary header file 
297         if none exists
298         https://bugs.webkit.org/show_bug.cgi?id=39514
299
300         * Scripts/webkitpy/style/checkers/cpp.py:
301         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
302
303 2011-04-15  Eric Seidel  <eric@webkit.org>
304
305         Reviewed by Mihai Parparita.
306
307         queues.webkit.org should display when a bot last rebooted
308         https://bugs.webkit.org/show_bug.cgi?id=58562
309
310         There is more repeated code here than I would like.  I fear
311         my django-fu isn't quite up to snuff.
312
313         * QueueStatusServer/handlers/queuestatus.py:
314         * QueueStatusServer/templates/queuestatus.html:
315
316 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
317
318         Reviewed by Adam Barth.
319
320         Remove dependency on chromium skia::PlatformCanvas
321         https://bugs.webkit.org/show_bug.cgi?id=57563
322         
323         Fixed compile error on Mac when using Core Graphics.
324
325         * DumpRenderTree/chromium/WebViewHost.cpp:
326         (WebViewHost::paintRect):
327
328 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
329
330         Reviewed by James Robinson.
331
332         Remove dependency on chromium skia::PlatformCanvas
333         https://bugs.webkit.org/show_bug.cgi?id=57563
334
335         * DumpRenderTree/chromium/TestShell.cpp:
336         (makeCanvasOpaque):
337         (TestShell::dumpImage):
338         * DumpRenderTree/chromium/TestShell.h:
339         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
340         (WebThemeControlDRTWin::WebThemeControlDRTWin):
341         (WebThemeControlDRTWin::draw):
342         (WebThemeControlDRTWin::drawTextField):
343         (WebThemeControlDRTWin::drawProgressBar):
344         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
345         * DumpRenderTree/chromium/WebViewHost.cpp:
346         (WebViewHost::canvas):
347         * DumpRenderTree/chromium/WebViewHost.h:
348
349 2011-04-14  Keith Kyzivat  <keith.kyzivat@nokia.com>
350
351         Reviewed by Laszlo Gombos.
352
353         [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser
354         https://bugs.webkit.org/show_bug.cgi?id=58007
355
356         Adds flag to start the test browsers maximized.
357         Symbian started maximized on QtTestBrowser - made MiniBrowser follow
358         suit.
359         Also fixes some ToggleFullScreen issues so that prior window state is
360         restored.
361
362         * MiniBrowser/qt/BrowserWindow.cpp:
363         (BrowserWindow::BrowserWindow):
364         (BrowserWindow::toggleFullScreenMode):
365         * MiniBrowser/qt/MiniBrowserApplication.cpp:
366         (MiniBrowserApplication::handleUserOptions):
367         * MiniBrowser/qt/MiniBrowserApplication.h:
368         (WindowOptions::WindowOptions):
369         * QtTestBrowser/launcherwindow.cpp:
370         (LauncherWindow::init):
371         (LauncherWindow::toggleFullScreenMode):
372         * QtTestBrowser/launcherwindow.h:
373         (WindowOptions::WindowOptions):
374         * QtTestBrowser/main.cpp:
375         (LauncherApplication::handleUserOptions):
376
377 2011-04-14  Ojan Vafai  <ojan@chromium.org>
378
379         Reviewed by Eric Seidel.
380
381         add checkbox to only show unexpected results to new results file
382         https://bugs.webkit.org/show_bug.cgi?id=58606
383
384         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
385
386 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
387
388         Reviewed by Martin Robinson.
389
390         [WinCairo] Implement ImageDiff Logic.
391         http://bugs.webkit.org/show_bug.cgi?id=58486
392
393         * DumpRenderTree/win/ImageDiffCairo.cpp: Added.
394         (strtof):
395         (readFromData):
396         (createImageFromStdin):
397         (releaseMallocBuffer):
398         (createDifferenceImage):
399         (imageHasAlpha):
400         (writeToData):
401         (main):
402         * DumpRenderTree/win/ImageDiff.vcproj: Updated for new
403           ImageDiffCairo.cpp (excluding from Apple builds).
404         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Use
405           new ImageDiffWinCairoCommon.vsprops file.
406         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Use
407           new ImageDiffWinCairoCommon.vsprops file.
408         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added.
409         * Scripts/old-run-webkit-tests: Make sure proper executable
410           is built and executed for WinCairo port.
411
412 2011-04-14  Ojan Vafai  <ojan@chromium.org>
413
414         Reviewed by Eric Seidel.
415
416         only show expected failure type for ports that use an expectations file
417         https://bugs.webkit.org/show_bug.cgi?id=58588
418
419         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
420         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
421
422 2011-04-14  Eric Seidel  <eric@webkit.org>
423
424         Reviewed by Adam Barth.
425
426         commit-queue fails to catch IOError when results.html is missing
427         https://bugs.webkit.org/show_bug.cgi?id=58589
428
429         * Scripts/webkitpy/tool/commands/queues.py:
430         * Scripts/webkitpy/tool/commands/queues_unittest.py:
431
432 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
433
434         [wx] Unreviewed build fix for Mac installation script.
435
436         * wx/packaging/build-mac-installer.py:
437
438 2011-04-14  Ojan Vafai  <ojan@chromium.org>
439
440         Reviewed by Tony Chang.
441
442         sort columns in the new json_results.html file
443         https://bugs.webkit.org/show_bug.cgi?id=58581
444
445         Also fix padding on TDs and the path to layout tests.
446
447         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
448
449 2011-04-14  Eric Seidel  <eric@webkit.org>
450
451         Reviewed by Dimitri Glazkov.
452
453         queues.webkit.org should display when a bot last passed a patch
454         https://bugs.webkit.org/show_bug.cgi?id=58546
455
456         I am suspicious that some of our commit-queue instances are never
457         actually passing anything.
458
459         This will let us know if those bots are never passing patches.
460
461         * QueueStatusServer/handlers/queuestatus.py:
462         * QueueStatusServer/index.yaml:
463         * QueueStatusServer/templates/queuestatus.html:
464
465 2011-04-14  Dirk Pranke  <dpranke@chromium.org>
466
467         Reviewed by Adam Roben.
468
469         REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
470         https://bugs.webkit.org/show_bug.cgi?id=58545
471
472         Remove platform-specific overrides; the default behavior should
473         be working everywhere now, I think.
474
475         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
476         * Scripts/webkitpy/layout_tests/port/mac.py:
477
478 2011-04-14  Eric Seidel  <eric@webkit.org>
479
480         Reviewed by Adam Barth.
481
482         commit-queues are hitting an exception trying to land when the tree is red
483         https://bugs.webkit.org/show_bug.cgi?id=58558
484
485         Just an un-tested (and thus broken) code path from yesterday's changes.
486
487         * Scripts/webkitpy/common/net/layouttestresults.py:
488         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
489         * Scripts/webkitpy/tool/commands/queues.py:
490         * Scripts/webkitpy/tool/commands/queues_unittest.py:
491
492 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
493
494         [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
495
496         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
497         (LayoutTestController::shadowRoot):
498         * wx/build/wxpresets.py:
499
500 2011-04-14  Victoria Kirst  <vrk@google.com>
501
502         Reviewed by James Robinson.
503
504         [chromium] Failing GPU video tests
505         https://bugs.webkit.org/show_bug.cgi?id=57926
506
507         Added/updated GPU directory names for rebaseline tool.
508
509         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
510
511 2011-04-13  Daniel Bates  <dbates@rim.com>
512
513         Reviewed by Adam Barth.
514
515         Perl unit test removeEOL.pl should print test case name on failure
516         https://bugs.webkit.org/show_bug.cgi?id=58513
517
518         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as
519           second argument of Test::Simple::ok().
520
521 2011-04-13  Kent Tamura  <tkent@chromium.org>
522
523         Reviewed by Eric Seidel.
524
525         gdb-safari should pass arguments to safari.
526         https://bugs.webkit.org/show_bug.cgi?id=58439
527
528         We can do:
529           gdb-safari --debug LayoutTests/.../foo.html
530
531         * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
532
533 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
534
535         Unreviewed, build fix.
536         https://bugs.webkit.org/show_bug.cgi?id=52763
537
538         r83799 broke test-webkitpy because it assumed we always have
539         access to a real filesystem (we don't during the unit tests).
540         Stubbing out the copy for now but we might need a better
541         solution at some point.
542
543         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
544
545 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
546
547         Reviewed by Tony Chang.
548
549         new-run-webkit-tests --run-singly option is busted
550         https://bugs.webkit.org/show_bug.cgi?id=55909
551
552         Python's broken lexical scoping strikes again :(.
553
554         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
555         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
556
557 2011-04-13  Ojan Vafai  <ojan@chromium.org>
558
559         Reviewed by Eric Seidel.
560
561         generated unexpected_results.html from unexpected_results.json
562         https://bugs.webkit.org/show_bug.cgi?id=52763
563
564         Eventually, we'll merge this with results.html and have a single richer results page.
565         For now, I just want to get something checked in that we can iterate on.
566
567         * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
568         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
569
570 2011-04-13  Eric Seidel  <eric@webkit.org>
571
572         Reviewed by Adam Barth.
573
574         Up the failure limit to allow the commit-queue to actually land when the tree is red
575         https://bugs.webkit.org/show_bug.cgi?id=58499
576
577         This change increases the --exit-after-N-failures limit used by the commit-queue
578         from 1 to 10.  This will cause the code added in bug 58494 to actually get
579         exercised and the queues should start being able to land when the trees are red.
580
581         When testing I found that test_runtests_leopard_commit_queue_hack_command was the
582         only unit test to actually detect this change!  Since we don't actually
583         run on leopard anymore, I removed the hack code and repurposed the test.
584
585         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
586         * Scripts/webkitpy/tool/steps/runtests.py:
587         * Scripts/webkitpy/tool/steps/steps_unittest.py:
588
589 2011-04-13  Eric Seidel  <eric@webkit.org>
590
591         Reviewed by Adam Barth.
592
593         commit-queue should be able to land when tree is red
594         https://bugs.webkit.org/show_bug.cgi?id=58494
595
596         There is some yak hair on my hands, I will admit.
597
598         This change is mostly about adding an ExpectedFailures
599         class to track when the bots are red and we should be
600         ignoring failures when landing from the commit-queue.
601
602         However, to make intelligent decisions about patches we
603         need to know whether the run hit the --exit-after-N-failures limit
604         or not.  Right now that information is not saved off in results.html
605         so we have to pull the information from RunTests.
606
607         I've plumbed the --exit-after-N-failures information into
608         LayoutTestResults for now to make the ExpectedFailures code cleaner.
609
610         As a result of adding all these additional calls to delegate.layout_test_results()
611         I broke some of our flaky test detection tests and had to re-write them
612         to not depend on the number of layout_test_results code.
613
614         At the same time I updated the commit-queue to use the newer filesystem
615         API (to allow us to use MockFileSystem) which required further changes
616         to the layout tests.  Changes were required in either case, since
617         we're now calling layout_test_results() in more cases, which previously
618         would try and hit the disk (until I moved it to use tool.filesystem).
619
620         I should note that *all* of this code is disabled for now, since our
621         --exit-after-N-failures limit is currently 1!  (Thus were always in the
622         case where we can't actually tell if the layout test results are legit.)
623         I will up that limit in a second patch (which may require a couple more unit test tweaks).
624
625         * Scripts/webkitpy/common/net/layouttestresults.py:
626         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
627         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
628         * Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
629         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
630         * Scripts/webkitpy/tool/commands/queues.py:
631         * Scripts/webkitpy/tool/commands/queues_unittest.py:
632         * Scripts/webkitpy/tool/commands/queuestest.py:
633         * Scripts/webkitpy/tool/steps/runtests.py:
634
635 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
636
637         Unreviewed build correction.
638
639         * TestWebKitAPI/PlatformWebView.h: Limit include of
640           <CoreGraphics/CGGeometry> to PLATFORM(CG) users.
641
642 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
643
644         Reviewed by Eric Seidel.
645
646         [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
647         https://bugs.webkit.org/show_bug.cgi?id=58489
648         
649         r83743 added --additional-platform-directory to old-run-webkit-tests,
650         rename the equivalent flag in new-run-webkit-tests to be consistent.
651
652         * Scripts/webkitpy/layout_tests/port/base.py:
653         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
654         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
655         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
656
657 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
658
659         Reviewed by Eric Seidel.
660
661         Rebaseline queue server
662         https://bugs.webkit.org/show_bug.cgi?id=57891
663
664         Adds a simple rebaseline queue server (meant to run at
665         http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
666         builders and their failing tests, and allows those tests to be added to
667         a per-builer rebaseline queue.
668
669         A subsequent change will add a mode to NRWT (and/or a wrapper script)
670         for pulling the tests to be rebaselined from the server and running them
671         with --reset-results (the initial use-case is for the GPU hardware bots,
672         which do not have checked-in baselines, therefore there is no need for a
673         check-in step yet).
674
675         * RebaselineQueueServer/app.yaml: Added.
676         * RebaselineQueueServer/handlers/__init__.py: Added.
677         * RebaselineQueueServer/handlers/builderqueue.py: Added.
678         * RebaselineQueueServer/handlers/pages.py: Added.
679         * RebaselineQueueServer/index.yaml: Added.
680         * RebaselineQueueServer/main.py: Added.
681         * RebaselineQueueServer/model/__init__.py: Added.
682         * RebaselineQueueServer/model/queueentry.py: Added.
683         * RebaselineQueueServer/static/builder-frame-empty.html: Added.
684         * RebaselineQueueServer/static/styles.css: Added.
685         * RebaselineQueueServer/templates/builder-picker.html: Added.
686         * RebaselineQueueServer/templates/builder-queue-edit.html: Added.
687         * RebaselineQueueServer/templates/builder-queue-list.html: Added.
688         * RebaselineQueueServer/templates/home.html: Added.
689
690 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
691
692         Reviewed by Mihai Parparita.
693
694         nrwt: enable multiple processes by default on Chromium Win.
695         https://bugs.webkit.org/show_bug.cgi?id=55163
696
697         Re-land r79268; it should be more stable now and will hopefully
698         work.
699
700         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
701         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
702
703 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
704
705         Reviewed by Ojan Vafai.
706
707         new-run-webkit-tests: configure logging in child processes properly
708         https://bugs.webkit.org/show_bug.cgi?id=58296
709
710         Logging propagated properly from manager to worker processes on
711         Unix but not on Windows; this fixes that.
712
713         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
714         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
715
716 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
717
718         Reviewed by Ojan Vafai.
719
720         new-run-webkit-tests: suppress extraneous pretty patch warnings
721         https://bugs.webkit.org/show_bug.cgi?id=58295
722
723         NRWT wasn't being careful about when it logged messages from
724         PrettyPatch not being available; it should only log during
725         check_build(), and be silent otherwise. This was causing us to
726         get multiple errors at runtime, which was confusing.
727
728         * Scripts/webkitpy/layout_tests/port/base.py:
729         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
730         * Scripts/webkitpy/layout_tests/port/chromium.py:
731
732 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
733
734         Reviewed by Jian Li.
735
736         add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
737         https://bugs.webkit.org/show_bug.cgi?id=58461
738
739         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
740
741 2011-04-13  Tony Chang  <tony@chromium.org>
742
743         Unreviewed, fix NRWT.  Stack:
744
745             return super(ChromiumPort, self).results_directory(self)
746         TypeError: results_directory() takes exactly 1 argument (2 given)
747
748         * Scripts/webkitpy/layout_tests/port/chromium.py:
749
750 2011-04-13  Adam Roben  <aroben@apple.com>
751
752         Teach ORWT about extra platform-specific directories to be searched before the default ones
753
754         Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
755         platform-specific results
756
757         Reviewed by Anders Carlsson.
758
759         * Scripts/old-run-webkit-tests:
760         (top-level): Added @additionalPlatformDirectories and hooked up
761         --additional-platform-directories to populate it.
762         (buildPlatformResultHierarchy): Prepend the additional platform directories to the default
763         list (after filtering out any of the additional directories that don't exist).
764
765 2011-04-13  Lucas Forschler  <lforschler@apple.com>
766
767         Reviewed by Adam Roben.
768
769         Add the /T command to taskkill.exe.
770         This will kill spawned child processes.
771         
772         * BuildSlaveSupport/win/kill-old-processes:
773
774 2011-04-13  Lucas Forschler  <lforschler@apple.com>
775
776         Reviewed by Adam Roben.
777
778         Sort kill list alphabeticaly.
779         Fixed capitalization on VcBuildHelper.  
780
781         * BuildSlaveSupport/win/kill-old-processes:
782
783 2011-04-13  Lucas Forschler  <lforschler@apple.com>
784
785         Reviewed by Adam Roben.
786
787         https://bugs.webkit.org/show_bug.cgi?id=58384
788         Update kill-old-processes to include a few new ones.
789         
790         * BuildSlaveSupport/win/kill-old-processes:
791
792 2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>
793
794         Reviewed by Martin Robinson.
795
796         [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
797         https://bugs.webkit.org/show_bug.cgi?id=58297
798
799         Do not disable flash specifically when built with GTK+ 3 -
800         PluginPackage should do the right thing while loading plugins.
801
802         * GtkLauncher/main.c:
803         (main):
804
805 2011-04-12  Kent Tamura  <tkent@chromium.org>
806
807         Reviewed by Dimitri Glazkov.
808
809         [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
810         https://bugs.webkit.org/show_bug.cgi?id=57426
811
812         * DumpRenderTree/chromium/WebPreferences.cpp:
813         (WebPreferences::applyTo): Disable the validation message timer.
814
815 2011-04-12  James Kozianski  <koz@chromium.org>
816
817         Unreviewed.
818
819         Adding myself to committers.py.
820
821         * Scripts/webkitpy/common/config/committers.py:
822
823 2011-04-12  Brent Fulgham  <bfulgham@webkit.org>
824
825         Unreviewed build correction for WinCairo bot after r83639.
826         https://bugs.webkit.org/show_bug.cgi?id=51790
827
828         Correct typo for the new "update-webkit-wincairo-libs" script.
829
830         * Scripts/build-webkit: Incorrectly calling the
831           update-webkit-cairo-libs which does not exist.
832
833 2011-04-12  Alice Liu  <alice.liu@apple.com>
834
835         Reviewed by Jon Honeycutt.
836
837         A change that should have been part of http://trac.webkit.org/changeset/83628
838
839         * DumpRenderTree/win/DumpRenderTree.cpp:
840         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
841
842 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
843
844         Reviewed by Tony Chang.
845
846         new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
847         https://bugs.webkit.org/show_bug.cgi?id=58272
848
849         NRWT was interpreting the --results-directory cmd line arg as
850         relative to the build directory, not the current working
851         directory (ORWT uses the latter, which is much more intuitive).
852         
853         This patch fixes the base case, but includes an override for
854         Chromium that is needed until the bots can be updated.
855
856         * Scripts/webkitpy/layout_tests/port/base.py:
857         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
858         * Scripts/webkitpy/layout_tests/port/chromium.py:
859         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
860         * Scripts/webkitpy/layout_tests/port/test.py:
861         * Scripts/webkitpy/layout_tests/port/webkit.py:
862         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
863         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
864
865 2011-04-12  Philippe Normand  <pnormand@igalia.com>
866
867         Unreviewed, roll out r83621 as it broke the GTK build.
868
869         [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
870         https://bugs.webkit.org/show_bug.cgi?id=58333
871
872         * Scripts/build-jsc:
873         * Scripts/build-webkit:
874
875 2011-04-12  Carl Lobo  <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
876
877         Reviewed by Adam Roben.
878
879         Patch to download the WinCairo dependancies as part of build-webkit.
880         https://bugs.webkit.org/show_bug.cgi?id=51790
881
882         This patch downloads the dependancies from 
883             http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip 
884         checking the modification timestamp etc. 
885
886         * Tools/Scripts/build-webkit
887         * Tools/Scripts/update-webkit: Modified to understand the --wincairo
888           flag, and to update WinCairo dependencies when used.
889         * Tools/Scripts/update-webkit-cairo-libs: added
890         * Tools/Scripts/update-webkit-dependency: added
891         * Tools/Scripts/update-webkit-auxiliary-libs
892
893 2011-04-12  Jeff Miller  <jeffm@apple.com>
894
895         Reviewed by Adam Roben.
896
897         WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
898         https://bugs.webkit.org/show_bug.cgi?id=56020
899
900         Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
901         since WebKit will do this for us.  If we didn't do this, TranslateMessage() would be called twice,
902         which would generate two characters for every keypress (for example).  I didn't bother doing this for
903         WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
904         
905         Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
906
907         * MiniBrowser/win/main.cpp:
908         (shouldTranslateMessage): Added.
909         (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
910         * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
911         * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
912         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
913         (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
914         (TestWebKitAPI::runAndWatchForWMChar): Added.
915         (TestWebKitAPI::TEST): Added.
916         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
917         (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
918         (TestWebKitAPI::Util::shouldTranslateMessage): Added.
919         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
920         (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
921         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
922
923 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
924
925         Reviewed by Tony Chang.
926
927         new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
928         https://bugs.webkit.org/show_bug.cgi?id=58290
929
930         This is some preliminary refactoring for bug 58272.
931
932         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
933         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
934         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
935         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
936         * Scripts/webkitpy/layout_tests/port/test.py:
937         * Scripts/webkitpy/layout_tests/port/chromium.py:
938         * Scripts/webkitpy/layout_tests/port/base.py:
939         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
940
941 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
942
943         Reviewed by Eric Seidel.
944
945         webkitpy: fix mock_filesystem abspath to handle relative paths
946         and add filesystem.chdir() and filesystem.getcwd() to be able
947         to test this and mock it out.
948
949         https://bugs.webkit.org/show_bug.cgi?id=58288
950
951         * Scripts/webkitpy/common/system/filesystem.py:
952         * Scripts/webkitpy/common/system/filesystem_mock.py:
953         * Scripts/webkitpy/common/system/filesystem_unittest.py:
954
955 2011-04-12  Alice Liu  <alice.liu@apple.com>
956
957         Reviewed by Sam Weinig.
958
959         https://bugs.webkit.org/show_bug.cgi?id=58292
960         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
961
962         * DumpRenderTree/mac/DumpRenderTree.mm:
963         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
964
965 2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
966
967         Reviewed by Eric Seidel.
968
969         [Qt] Enable JIT build for SH4 platforms.
970         https://bugs.webkit.org/show_bug.cgi?id=58317
971
972
973         * DumpRenderTree/qt/DumpRenderTree.pro:
974         * QtTestBrowser/QtTestBrowser.pro:
975         * Scripts/webkitdirs.pm:
976
977 2011-04-12  Tony Chang  <tony@chromium.org>
978
979         Reviewed by Andreas Kling.
980
981         [Qt] embed checksums in PNGs written by Qt-DRT
982         https://bugs.webkit.org/show_bug.cgi?id=58173
983
984         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
985         (WebCore::DumpRenderTree::dump):
986
987 2011-04-12  Eric Seidel  <eric@webkit.org>
988
989         Reviewed by Adam Barth.
990
991         commit-queue should upload failure diffs when tests fail
992         https://bugs.webkit.org/show_bug.cgi?id=58348
993
994         This change was mostly just plumbing.  We were already saving
995         this information for flaky test reporting.  I just made it possible
996         for normal failures to report archives as well.
997
998         I did a little abstraction work to try and share some code between
999         flakytestreporter.py and this new code.  There is still more we could do.
1000
1001         In making this change I also went through and updated the various
1002         places we have urls hard-coded in our python and pointed them at
1003         common.config.urls.
1004
1005         * Scripts/webkitpy/common/checkout/scm.py:
1006         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1007         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1008         * Scripts/webkitpy/common/net/statusserver.py:
1009         * Scripts/webkitpy/layout_tests/port/base.py:
1010         * Scripts/webkitpy/tool/bot/botinfo.py: Added.
1011         * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
1012         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1013         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1014         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1015         * Scripts/webkitpy/tool/commands/queues.py:
1016
1017 2011-04-12  Daniel Bates  <dbates@rim.com>
1018
1019         Rubber-stamped by Eric Seidel.
1020
1021         svn-apply and/or patch(1) has trouble applying patches that makes changes to files
1022         with Windows line endings
1023         https://bugs.webkit.org/show_bug.cgi?id=53625
1024
1025         Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
1026         applied to an SCM checkout on a Windows file system and vice-versa.
1027
1028         This issue manifests itself due to custom SCM settings as well as differences in
1029         gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
1030         into svn-apply/unapply to compensate for differences in line endings by converting
1031         the line endings in a patch to match the line endings in the target file (if it exists).
1032
1033         * Scripts/VCSUtils.pm:
1034           - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
1035             content read from the specified file handle. Obviously, this heuristic will not work
1036             for files with mixed line endings, but I don't envision such files to be the norm. If
1037             this turns out to be an issue then we can improve the heuristic.
1038           - Added firstEOLInFile().
1039           - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
1040             In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
1041             endings in the diff instead of the line endings in the target file.
1042           - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
1043             re-used in parseDiff().
1044         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
1045           to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
1046           mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
1047         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
1048         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
1049
1050 2011-04-12  Sam Weinig  <sam@webkit.org>
1051
1052         Reviewed by Adam Roben.
1053
1054         REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
1055         https://bugs.webkit.org/show_bug.cgi?id=58336
1056
1057         * WebKitTestRunner/TestController.cpp:
1058         (WTR::TestController::resetStateToConsistentValues):
1059         Remove cache clearing as that is causing tests to crash on Windows 7.
1060
1061 2011-04-11  Sam Weinig  <sam@webkit.org>
1062
1063         Reviewed by Anders Carlsson.
1064
1065         REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
1066         <rdar://problem/8981346>
1067         https://bugs.webkit.org/show_bug.cgi?id=54159
1068
1069         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1070         (WTR::InjectedBundlePage::InjectedBundlePage):
1071         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1072         (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
1073         (WTR::InjectedBundlePage::decidePolicyForResponse):
1074         (WTR::InjectedBundlePage::unableToImplementPolicy):
1075         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1076         Add short-circuited policy client which matches WebKit1.
1077
1078         * WebKitTestRunner/TestController.cpp:
1079         (WTR::TestController::resetStateToConsistentValues):
1080         Clear the cache between tests to ensure consistent results.
1081
1082 2011-04-11  George Guo  <George.Guo@nokia.com>
1083
1084         Reviewed by Eric Seidel.
1085
1086         prepare-ChangeLog support email input but -h did not show the option
1087         https://bugs.webkit.org/show_bug.cgi?id=58164
1088
1089         Add email option to -h to improve the usability
1090
1091         * Scripts/prepare-ChangeLog:
1092
1093 2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
1094
1095         Reviewed by Eric Carlson.
1096
1097         Rename MediaControls to MediaControlRootElement.
1098         https://bugs.webkit.org/show_bug.cgi?id=58250
1099
1100         * Scripts/do-webcore-rename: Documented the renaming.
1101
1102 2011-04-11  Sam Weinig  <sam@webkit.org>
1103
1104         Fix Windows build.
1105
1106         * MiniBrowser/win/BrowserView.cpp:
1107         (BrowserView::create):
1108
1109 2011-04-11  Sam Weinig  <sam@webkit.org>
1110
1111         Reviewed by Anders Carlsson.
1112
1113         Move focus management out of WebKit via  the UIClient
1114         <rdar://problem/8784068>
1115         https://bugs.webkit.org/show_bug.cgi?id=58278
1116
1117         * MiniBrowser/mac/BrowserWindowController.m:
1118         (-[BrowserWindowController awakeFromNib]):
1119         * WebKitTestRunner/TestController.cpp:
1120         (WTR::TestController::createOtherPage):
1121         (WTR::TestController::initialize):
1122         Add stubs for new UIClient functions.
1123
1124 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
1125
1126         Reviewed by Eric Seidel.
1127
1128         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
1129         https://bugs.webkit.org/show_bug.cgi?id=53605
1130
1131         Add an implementation of the PlainTextController for the GTK+ DRT.
1132
1133         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1134         (addControllerToWindow): Added this helper method.
1135         (webViewWindowObjectCleared): Use the new helper to add EventSender
1136         and the PlainTextController to the window object.
1137         * GNUmakefile.am: Added PlainTextController source files.
1138         * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
1139         on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
1140         until that functionality exists somewhere in the WebKitGTK+ stack.
1141         * DumpRenderTree/gtk/PlainTextController.h: Added.
1142
1143 2011-04-11  Yael Aharon  <yael.aharon@nokia.com>
1144
1145         Unreviewed.
1146
1147         Adding my IRC nick.
1148
1149         * Scripts/webkitpy/common/config/committers.py:
1150
1151 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
1152
1153         Reviewed by Adam Roben.
1154
1155         new-run-webkit-tests: fix crash when running under windows cmd.exe
1156         https://bugs.webkit.org/show_bug.cgi?id=58197
1157
1158         We would intermittently crash when running NRWT directly under
1159         cmd.exe on windows because we were sharing the stdin file
1160         descriptor between the python process and the http server.
1161         cmd.exe really didn't like that, and there was no reason to
1162         share the descriptor, so we now use a PIPE instead.
1163
1164         * Scripts/webkitpy/layout_tests/port/http_server.py:
1165
1166 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
1167
1168         Reviewed by Ojan Vafai.
1169
1170         new-run-webkit-tests: add unit tests for Port.diff_image()
1171         https://bugs.webkit.org/show_bug.cgi?id=58196
1172
1173         Add the unit tests for the fix in bug 58195.
1174
1175         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1176         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1177         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1178
1179 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
1180
1181         Reviewed by Tony Chang.
1182
1183         new-run-webkit-tests: implement support for audio, take two
1184         https://bugs.webkit.org/show_bug.cgi?id=58195
1185
1186         Attempt to re-land the fix for bug 58101 (which was initially
1187         landed in r83330, but rolled out). This is the same patch but
1188         fixes crashes in Port.diff_image() caused by the change for
1189         empty image files being None instead of ''.
1190
1191         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1192         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1193         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1194         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1195         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1196         * Scripts/webkitpy/layout_tests/port/base.py:
1197         * Scripts/webkitpy/layout_tests/port/chromium.py:
1198         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1199         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1200         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1201         * Scripts/webkitpy/layout_tests/port/test.py:
1202         * Scripts/webkitpy/layout_tests/port/webkit.py:
1203
1204 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
1205
1206         Reviewed by Xan Lopez.
1207
1208         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
1209         https://bugs.webkit.org/show_bug.cgi?id=57854
1210
1211         Implement missing features in GTK's DRT.
1212
1213         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1214         (indexRangeInTable): New helper function to get the range string
1215         for the current cell inside the parent table, either from the
1216         point of view of rows or columns.
1217         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
1218         the new helper function indexRangeInTable().
1219         (AccessibilityUIElement::columnIndexRange): Ditto.
1220
1221 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
1222
1223         Reviewed by Chris Fleizach.
1224
1225         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
1226         https://bugs.webkit.org/show_bug.cgi?id=57826
1227
1228         Implement missing feature in GTK's DRT.
1229
1230         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1231         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
1232         relying on the analogous function from the AtkTable interface.
1233
1234 2011-04-05  Timothy Hatcher  <timothy@apple.com>
1235
1236         Fix the extract-localizable-strings script errors that started after
1237         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
1238
1239         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
1240
1241 2011-04-11  Tony Chang  <tony@chromium.org>
1242
1243         Reviewed by Eric Seidel.
1244
1245         fix crc computation on 64 bit machines
1246         https://bugs.webkit.org/show_bug.cgi?id=58243
1247
1248         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
1249
1250         * DumpRenderTree/CyclicRedundancyCheck.cpp:
1251         (makeCrcTable):
1252         (computeCrc):
1253         * DumpRenderTree/CyclicRedundancyCheck.h:
1254         * DumpRenderTree/PixelDumpSupport.cpp:
1255         (appendIntToVector):
1256         (convertChecksumToPNGComment):
1257
1258 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
1259
1260         Reviewed by Eric Seidel.
1261
1262         Require no undefined symbols during compilation.
1263
1264         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
1265         https://bugs.webkit.org/show_bug.cgi?id=54896
1266
1267         Add -Wl,--no-undefined to catch missing symbols early.
1268
1269         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1270         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1271
1272 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
1273
1274         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
1275
1276         * wx/build/settings.py:
1277
1278 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
1279
1280         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
1281
1282         * wx/build/settings.py:
1283
1284 2011-04-10  David Levin  <levin@chromium.org>
1285
1286         Reviewed by Dimitri Glazkov.
1287
1288         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
1289         https://bugs.webkit.org/show_bug.cgi?id=58201
1290
1291         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
1292         and filed bug 58202.
1293
1294 2011-04-09  David Levin  <levin@chromium.org>
1295
1296         Unreviewed, rolling out r83394.
1297         http://trac.webkit.org/changeset/83394
1298         https://bugs.webkit.org/show_bug.cgi?id=53625
1299
1300         Patch was incorrect as noted in the bug.
1301
1302         * Scripts/svn-apply:
1303
1304 2011-04-09  David Levin  <levin@chromium.org>
1305
1306         Reviewed by Adam Barth.
1307
1308         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
1309         https://bugs.webkit.org/show_bug.cgi?id=53625
1310
1311         * Scripts/svn-apply: Ensure that the portions of patches
1312         which are for vcproj/vsprops files has DOS line endings.
1313
1314 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
1315
1316         Reviewed by Tony Chang.
1317
1318         It looks like NRWT has not been stopping DRT/TestShell
1319         instances properly on windows, probably for a long time.
1320         This would go a long way to explaining why we often have
1321         processes lying around :)
1322
1323         https://bugs.webkit.org/show_bug.cgi?id=57807
1324
1325         * Scripts/webkitpy/layout_tests/port/chromium.py:
1326         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1327
1328 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
1329
1330         Reviewed by Laszlo Gombos.
1331
1332         [Qt] Don't link against fontconfig or X11 if embedded
1333         https://bugs.webkit.org/show_bug.cgi?id=58104
1334
1335         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
1336         * QtTestBrowser/QtTestBrowser.pro: ditto
1337         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
1338         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
1339
1340 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
1341
1342         http/tests/loading/preload-append-scan.php is failing on Windows
1343         https://bugs.webkit.org/show_bug.cgi?id=58178
1344
1345         Reviewed by Brian Weinstein.
1346
1347         * DumpRenderTree/win/DumpRenderTree.cpp:
1348         (lastPathComponent):
1349         Use CFURL API to find the last path component, rather than
1350         PathFindFileName(), because the latter will include the query string.
1351
1352 2011-04-08  Jian Li  <jianli@chromium.org>
1353
1354         Unreviewed, rolling out r83327, r83330 since these patches are very
1355         likely to break chromium webkit mac10.6 builders.
1356
1357         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1358         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1359         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1360         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1361         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1362         * Scripts/webkitpy/layout_tests/port/base.py:
1363         * Scripts/webkitpy/layout_tests/port/chromium.py:
1364         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1365         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1366         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1367         * Scripts/webkitpy/layout_tests/port/test.py:
1368         * Scripts/webkitpy/layout_tests/port/webkit.py:
1369
1370 2011-04-08  Vincent Scheib  <scheib@chromium.org>
1371
1372         Reviewed by Eric Seidel.
1373
1374         add chromium-gpu-linux-x86_64 to the recognized list of ports
1375         https://bugs.webkit.org/show_bug.cgi?id=58099
1376
1377         Add chromium-gpu-linux-x86_64 to fix assert.
1378
1379         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1380
1381 2011-04-08  Alpha Lam  <hclam@chromium.org>
1382
1383         Unreviewed, rolling out r83335.
1384         http://trac.webkit.org/changeset/83335
1385         https://bugs.webkit.org/show_bug.cgi?id=53556
1386
1387         GTK and QT bots are broken
1388
1389         * Scripts/build-webkit:
1390
1391 2011-04-07  Anna Cavender  <annacc@chromium.org>
1392
1393         Reviewed by Eric Carlson.
1394
1395         Setup ENABLE(TRACK) feature define
1396         https://bugs.webkit.org/show_bug.cgi?id=53556
1397
1398         * Scripts/build-webkit:
1399
1400 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
1401
1402         Reviewed by Adam Roben.
1403
1404         new-run-webkit-tests: configure a NRWT test bot for Mac SL
1405         https://bugs.webkit.org/show_bug.cgi?id=58114
1406
1407         This change removes the old new-run-webkit-tests entry and
1408         updates it for a new test-only bot.
1409
1410         * BuildSlaveSupport/build.webkit.org-config/config.json:
1411
1412 2011-04-08  Dominic Cooney  <dominicc@google.com>
1413
1414         Reviewed by Adam Roben.
1415
1416         Make layoutTestController.shadowRoot return null, not undefined,
1417         when its argument is invalid.
1418         https://bugs.webkit.org/show_bug.cgi?id=58121
1419
1420         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1421         (LayoutTestController::shadowRoot):
1422         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1423         (WTR::LayoutTestController::shadowRoot):
1424
1425 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
1426
1427         Reviewed by Adam Roben.
1428
1429         Locate NSTD.EXE in 64-bit Windows
1430         https://bugs.webkit.org/show_bug.cgi?id=57847
1431
1432         * Scripts/old-run-webkit-tests:
1433
1434 2011-04-08  Adam Roben  <aroben@apple.com>
1435
1436         Qt build fix
1437
1438         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
1439
1440 2011-04-07  Adam Roben  <aroben@apple.com>
1441
1442         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
1443
1444         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
1445         plugin
1446
1447         Reviewed by Anders Carlsson.
1448
1449         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1450         (pluginLogWithArguments): Moved code to format and log the message here...
1451         (pluginLog): ...from here.
1452
1453         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
1454
1455         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1456         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
1457
1458         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
1459
1460         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
1461         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
1462         to begin.
1463         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
1464         constructor.
1465         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
1466         can be used to invoke our setWillBeDestroyed function.
1467         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
1468         anything unexpected happens).
1469         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
1470         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
1471         NPP_SetWindow was *not* called during destruction.
1472         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
1473         method, setWillBeDestroyed.
1474         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
1475         object.
1476
1477         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1478         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1479         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1480         * GNUmakefile.am:
1481         Added new test.
1482
1483         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
1484         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
1485
1486 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
1487
1488         Reviewed by Martin Robinson.
1489
1490         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
1491         https://bugs.webkit.org/show_bug.cgi?id=58039
1492
1493         Implement missing functions in GTK's DRT.
1494
1495         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1496         (AccessibilityUIElement::increment): Implemented.
1497         (AccessibilityUIElement::decrement): Implemented.
1498
1499 2011-04-08  Dominic Cooney  <dominicc@google.com>
1500
1501         Reviewed by Kent Tamura.
1502
1503         Make WK2 layoutTestController.shadowRoot return undefined, not
1504         null, when its argument is not an element.
1505         https://bugs.webkit.org/show_bug.cgi?id=58121
1506
1507         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1508         (WTR::LayoutTestController::shadowRoot):
1509
1510 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
1511
1512         Reviewed by Mihai Parparita.
1513
1514         Change reference port for Mac GPU baselines from
1515         Leopard to SnowLeopard, XP to Win7, and Linux-x86
1516         to Linux x86-64.
1517
1518         https://bugs.webkit.org/show_bug.cgi?id=58099
1519
1520         * Scripts/webkitpy/layout_tests/port/chromium.py:
1521
1522 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
1523
1524         Revert ENABLE_TRACK patch due to compile failures.
1525
1526         * Scripts/build-webkit:
1527
1528 2011-04-07  Tony Chang  <tony@chromium.org>
1529
1530         Reviewed by Eric Seidel.
1531
1532         update DRT to embed checksums in png files
1533         https://bugs.webkit.org/show_bug.cgi?id=57871
1534
1535         We insert the bytes for the comment in printPNG rather than at encode
1536         time because each platform does its own PNG encoding (either using CG
1537         or cairo).  Putting this in pringPNG avoids having to duplicate this
1538         code, although it's not as clean as doing it at encoding time.
1539
1540         We insert the comment right after the IHDR chunk of the PNG.
1541
1542         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1543         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
1544         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
1545         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
1546         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
1547         * DumpRenderTree/PixelDumpSupport.cpp:
1548         (dumpWebViewAsPixelsAndCompareWithExpected):
1549         (convertChecksumToPNGComment): Generate the bytes to insert.
1550         (printPNG): Insert the png comment before the first IDAT section.
1551         * DumpRenderTree/PixelDumpSupport.h:
1552         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
1553         (printPNG):
1554         (dumpBitmap):
1555         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1556         (printPNG):
1557         (dumpBitmap):
1558         * DumpRenderTree/win/DumpRenderTree.vcproj:
1559         * GNUmakefile.am:
1560
1561 2011-04-07  Jeff Miller  <jeffm@apple.com>
1562
1563         Reviewed by Adam Roben.
1564
1565         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
1566         https://bugs.webkit.org/show_bug.cgi?id=58058
1567
1568         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1569         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
1570
1571 2011-04-07  Chang Shu  <cshu@webkit.org>
1572
1573         Reviewed by Darin Adler.
1574
1575         WebKitTestRunner needs layoutTestController.isPageBoxVisible
1576         https://bugs.webkit.org/show_bug.cgi?id=42695
1577
1578         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1579         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1580         (WTR::LayoutTestController::isPageBoxVisible):
1581         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1582
1583 2011-04-07  Adam Roben  <aroben@apple.com>
1584
1585         Build fix
1586
1587         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
1588
1589 2011-04-07  Adam Roben  <aroben@apple.com>
1590
1591         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
1592
1593         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
1594         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
1595         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
1596         be overridden by subclasses to provide extra URLs before we call up to the base class (after
1597         which adding more URLs is no longer possible).
1598
1599         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
1600         bot results page
1601
1602         Reviewed by John Sullivan.
1603
1604         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1605         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
1606         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
1607         method is never called for MasterShellCommands.
1608         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
1609         with this method (which is).
1610
1611 2011-04-07  Adam Roben  <aroben@apple.com>
1612
1613         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
1614
1615         This matches how most of our other build steps work, so is good just for improving
1616         consistency between build steps. It should also make it possible for
1617         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
1618         trying to do this in finished() after we had called up to the base class, but that was
1619         apparently too late to add more URLs.)
1620
1621         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
1622         results page
1623
1624         Reviewed by John Sullivan.
1625
1626         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1627         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
1628         call setText to get the right text to show up for this step. This matches how most of our
1629         other build steps work.
1630         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
1631         This is how most of our other build steps work.
1632         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
1633         function, to match the base class.
1634
1635 2011-04-07  Adam Barth  <abarth@webkit.org>
1636
1637         Reviewed by Maciej Stachowiak.
1638
1639         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
1640         https://bugs.webkit.org/show_bug.cgi?id=58022
1641
1642         Previously, we were ignoring the args variable!  This patch fixes the
1643         regression introduced in http://trac.webkit.org/changeset/82771.
1644
1645         * Scripts/webkitpy/tool/commands/download_unittest.py:
1646         * Scripts/webkitpy/tool/mocktool.py:
1647         * Scripts/webkitpy/tool/steps/checkstyle.py:
1648
1649 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
1650
1651         Reviewed by Adam Barth.
1652
1653         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
1654         https://bugs.webkit.org/show_bug.cgi?id=58017
1655
1656         * Scripts/webkitpy/common/checkout/scm.py:
1657         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1658
1659 2011-04-06  Chang Shu  <cshu@webkit.org>
1660
1661         Reviewed by Darin Adler.
1662
1663         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
1664         https://bugs.webkit.org/show_bug.cgi?id=57984
1665
1666         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1667         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1668         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
1669         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1670
1671 2011-04-06  Chris Rogers  <crogers@google.com>
1672
1673         Reviewed by Tony Chang.
1674
1675         Add web audio support to DumpRenderTree (mac port)
1676         https://bugs.webkit.org/show_bug.cgi?id=57969
1677
1678         * DumpRenderTree/LayoutTestController.cpp:
1679         (LayoutTestController::LayoutTestController):
1680         (setEncodedAudioDataCallback):
1681         (LayoutTestController::staticFunctions):
1682         * DumpRenderTree/LayoutTestController.h:
1683         (LayoutTestController::dumpAsAudio):
1684         (LayoutTestController::setDumpAsAudio):
1685         (LayoutTestController::encodedAudioData):
1686         (LayoutTestController::setEncodedAudioData):
1687         * DumpRenderTree/mac/DumpRenderTree.mm:
1688         (dumpAudio):
1689         (dump):
1690
1691 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
1692
1693         Reviewed by Kenneth Rohde Christiansen.
1694
1695         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
1696         https://bugs.webkit.org/show_bug.cgi?id=56086
1697
1698         Add the missing method.
1699
1700         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1701         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
1702         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1703         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1704         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1705
1706 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
1707
1708         Reviewed by David Levin.
1709
1710         Add QUOTA build flag for unified quota API
1711         https://bugs.webkit.org/show_bug.cgi?id=57918
1712
1713         * Scripts/build-webkit: Added QUOTA build flag
1714
1715 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
1716
1717         Reviewed by Tony Chang.
1718
1719         Adjust the apple webkit port's default timeout to match
1720         old-run-webkit-tests at 35 seconds.
1721
1722         https://bugs.webkit.org/show_bug.cgi?id=37738
1723
1724         * Scripts/webkitpy/layout_tests/port/mac.py:
1725
1726 2011-04-06  Scott Cameron  <sccameron@rim.com>
1727
1728         Reviewed by Eric Seidel.
1729
1730         Remove global variable $httpdPath and replace with the return value of
1731         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
1732         https://bugs.webkit.org/show_bug.cgi?id=53499
1733
1734         * Scripts/run-iexploder-tests:
1735         * Scripts/webkitperl/httpd.pm:
1736
1737 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
1738
1739         Reviewed by Darin Adler.
1740
1741         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
1742         
1743         https://bugs.webkit.org/show_bug.cgi?id=27551
1744         
1745         * DumpRenderTree/config.h:
1746         * WebKitAPITest/config.h:
1747         * WebKitTestRunner/config.h:
1748
1749 2011-04-06  Tony Chang  <tony@chromium.org>
1750
1751         Reviewed by Darin Adler.
1752
1753         teach run-webkit-tests to read checksums from png files
1754         https://bugs.webkit.org/show_bug.cgi?id=57993
1755
1756         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
1757           no .checksum and look for the checksum in there.
1758
1759 2011-04-06  David Dorwin  <ddorwin@chromium.org>
1760
1761         Reviewed by David Levin.
1762
1763         Enable fullscreen layout tests for Chromium
1764         https://bugs.webkit.org/show_bug.cgi?id=55726
1765
1766         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
1767
1768         * DumpRenderTree/chromium/WebPreferences.cpp:
1769         (WebPreferences::applyTo):
1770
1771 2011-04-06  Adam Roben  <aroben@apple.com>
1772
1773         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
1774
1775         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
1776
1777         Reviewed by David Kilzer.
1778
1779         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1780         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
1781         build's results directory here...
1782         (ExtractTestResults.finished): ...from here.
1783         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
1784         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
1785         leaks" link to point to Leaks Viewer for this build.
1786         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
1787         but it seemed good to add for consistency with BuildAndTestFactory.
1788         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
1789         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
1790         that we'll get a "view leaks" link.
1791
1792 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
1793
1794         Reviewed by Eric Seidel.
1795
1796         [Gtk] plugins/set-status.html fails
1797         https://bugs.webkit.org/show_bug.cgi?id=57844
1798
1799         Allow an empty status text to be dumped.
1800
1801         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1802         (webViewStatusBarTextChanged):
1803
1804 2011-04-06  Chang Shu  <cshu@webkit.org>
1805
1806         Reviewed by Darin Adler.
1807
1808         WebKitTestRunner needs layoutTestController.pageNumberForElementById
1809         https://bugs.webkit.org/show_bug.cgi?id=42329
1810
1811         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1812         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1813         (WTR::LayoutTestController::pageNumberForElementById):
1814         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1815
1816 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
1817
1818         Reviewed by Martin Robinson.
1819
1820         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
1821         https://bugs.webkit.org/show_bug.cgi?id=57932
1822
1823         Some Layout tests have invalid URIs that do not generate valid
1824         SoupURI instances. Do not try to free those NULL SoupURIs.
1825
1826         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1827         (willSendRequestCallback):
1828
1829 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
1830
1831         Reviewed by Andreas Kling.
1832
1833         ORWT shouldn't generate diff files for tests without expected files
1834         https://bugs.webkit.org/show_bug.cgi?id=57846
1835
1836         * Scripts/old-run-webkit-tests:
1837
1838 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
1839
1840         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
1841         to deps.
1842
1843         * wx/install-unix-extras:
1844
1845 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1846
1847         Unreviewed, rolling out r82978, r82999, and r83001.
1848         http://trac.webkit.org/changeset/82978
1849         http://trac.webkit.org/changeset/82999
1850         http://trac.webkit.org/changeset/83001
1851         https://bugs.webkit.org/show_bug.cgi?id=57913
1852
1853         Does not work in Python 2.5 (Requested by abarth on #webkit).
1854
1855         * Scripts/webkitpy/common/system/executive.py:
1856         * Scripts/webkitpy/common/system/executive_unittest.py:
1857
1858 2011-04-05  Chang Shu  <cshu@webkit.org>
1859
1860         Reviewed by Darin Adler.
1861
1862         WebKitTestRunner needs layoutTestController.numberOfPages
1863         https://bugs.webkit.org/show_bug.cgi?id=42694
1864
1865         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1866         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1867         (WTR::LayoutTestController::numberOfPages):
1868         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1869
1870 2011-04-05  Tony Chang  <tony@chromium.org>
1871
1872         Reviewed by Mihai Parparita.
1873
1874         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
1875         https://bugs.webkit.org/show_bug.cgi?id=57889
1876
1877         * Scripts/webkitpy/layout_tests/port/chromium.py:
1878         * Scripts/webkitpy/layout_tests/port/test.py:
1879         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1880
1881 2011-04-05  Adam Barth  <abarth@webkit.org>
1882
1883         Silly with statement, from the future!
1884
1885         * Scripts/webkitpy/common/system/executive.py:
1886
1887 2011-04-05  Adam Barth  <abarth@webkit.org>
1888
1889         Reviewed by Tony Chang.
1890
1891         Don't use Exception.message because it's deprecated
1892         https://bugs.webkit.org/show_bug.cgi?id=57892
1893
1894         Suppress the warning for now.  When we move to Python 3, we might need
1895         to something more dramatic.
1896
1897         * Scripts/webkitpy/common/system/executive.py:
1898
1899 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
1900
1901         Reviewed by Ojan Vafai.
1902
1903         Add builders.js to dashboard file list
1904         https://bugs.webkit.org/show_bug.cgi?id=57899
1905
1906         Add file added by http://crrev.com/80538 to dashboard file list.
1907
1908         * TestResultServer/handlers/dashboardhandler.py:
1909
1910 2011-04-05  MORITA Hajime  <morrita@google.com>
1911
1912         Reviewed by Adam Barth.
1913
1914         webkit-patch should print git's stderr when git svn dcommit fail
1915         http://webkit.org/b/57861
1916
1917         * Scripts/webkitpy/common/checkout/scm.py:
1918
1919 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
1920
1921         Reviewed by Tony Chang.
1922
1923         Add --baseline-search-path to NRWT
1924         https://bugs.webkit.org/show_bug.cgi?id=56233
1925         
1926         Add NRWT option to specify additional directories to look for baselines
1927         (will be used by hardware GPU bots which will have local per-bot
1928         expectations for some tests)
1929
1930         * Scripts/webkitpy/common/system/filesystem_mock.py:
1931         * Scripts/webkitpy/layout_tests/port/base.py:
1932         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1933         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1934
1935 2011-04-05  Adam Roben  <aroben@apple.com>
1936
1937         Strip off /results.html from results URLs before trying to load leaks files from them
1938
1939         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
1940         files, rather than pointing to the directory that contains them. This is more convenient for
1941         people browsing build.webkit.org, but confused Leaks Viewer.
1942
1943         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
1944         list don't work
1945
1946         Reviewed by Joseph Pecoraro.
1947
1948         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1949         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
1950
1951 2011-04-05  Carol Szabo  <carol@webkit.org>
1952
1953         Unreviewed.
1954
1955         Updated my info in committers.py
1956
1957         Scripts\webkitpy\common\config\committers.py 
1958
1959 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
1960
1961         Reviewed by Laszlo Gombos.
1962
1963         [Qt] Make WebKitLibraries optional for building QtWebKit
1964         https://bugs.webkit.org/show_bug.cgi?id=57542
1965
1966         * Scripts/build-webkit:
1967
1968 2011-04-05  Chang Shu  <cshu@webkit.org>
1969
1970         Reviewed by Laszlo Gombos.
1971
1972         [Qt] MiniBrowser defaultUrl does not work
1973         https://bugs.webkit.org/show_bug.cgi?id=57021
1974
1975         Match the behavior and coding of MiniBrowser to QtTestBrowser.
1976         * MiniBrowser/qt/main.cpp:
1977         (main):
1978
1979 2011-04-05  Jade Han  <jade.han@nokia.com>
1980
1981         Reviewed by Laszlo Gombos.
1982
1983         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
1984         https://bugs.webkit.org/show_bug.cgi?id=54977
1985
1986         This change is a preparation to enable building webkit2 for Symbian.
1987         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
1988
1989         * Tools.pro:
1990
1991 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1992
1993         Reviewed by Andreas Kling.
1994
1995         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
1996         https://bugs.webkit.org/show_bug.cgi?id=57832
1997
1998         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
1999
2000         * MiniBrowser/qt/UrlLoader.cpp:
2001         (UrlLoader::UrlLoader):
2002
2003 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
2004
2005         [Qt] Linux Release minimal build fix after r82919.
2006
2007         * MiniBrowser/qt/BrowserWindow.cpp:
2008         (BrowserWindow::loadURLListFromFile):
2009         * QtTestBrowser/launcherwindow.cpp:
2010         (LauncherWindow::loadURLListFromFile):
2011
2012 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
2013
2014         Reviewed by Andreas Kling.
2015
2016         [Qt] Make URL loader accessible from testbrowser's menus
2017         https://bugs.webkit.org/show_bug.cgi?id=57823
2018
2019         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
2020
2021         * MiniBrowser/qt/BrowserWindow.cpp:
2022         (BrowserWindow::BrowserWindow):
2023         (BrowserWindow::loadURLListFromFile):
2024         (BrowserWindow::~BrowserWindow):
2025         * MiniBrowser/qt/BrowserWindow.h:
2026         * QtTestBrowser/launcherwindow.cpp:
2027         (LauncherWindow::LauncherWindow):
2028         (LauncherWindow::~LauncherWindow):
2029         (LauncherWindow::createChrome):
2030         (LauncherWindow::loadURLListFromFile):
2031         * QtTestBrowser/launcherwindow.h:
2032
2033 2011-04-04  Sam Weinig  <sam@webkit.org>
2034
2035         Reviewed by Brian Weinstein.
2036
2037         Remove duplicate API from WKContext
2038         <rdar://problem/8727879>
2039         https://bugs.webkit.org/show_bug.cgi?id=57815
2040
2041         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2042         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
2043         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2044         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
2045
2046 2011-04-04  Tony Chang  <tony@chromium.org>
2047
2048         Reviewed by Ojan Vafai.
2049
2050         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
2051         https://bugs.webkit.org/show_bug.cgi?id=57783
2052
2053         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2054         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2055
2056 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
2057
2058         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
2059         from WebKitBuild.
2060
2061         * Scripts/webkitdirs.pm:
2062
2063 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
2064
2065         Reviewed by Gustavo Noronha Silva.
2066
2067         [GTK] WebGL support
2068         https://bugs.webkit.org/show_bug.cgi?id=31517
2069
2070         Add support to the DRT for turning on WebGL when a layout tests requests it.
2071
2072         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2073         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
2074
2075 2011-04-04  Chang Shu  <cshu@webkit.org>
2076
2077         Reviewed by Darin Adler.
2078
2079         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
2080         https://bugs.webkit.org/show_bug.cgi?id=57572
2081
2082         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2083         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2084         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
2085         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2086
2087 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
2088
2089         Reviewed by Csaba Osztrogonác.
2090
2091         [Qt] DumpRenderTree breaks compilation in some uClibc environments
2092         https://bugs.webkit.org/show_bug.cgi?id=57602
2093
2094         * DumpRenderTree/qt/main.cpp:
2095         (get_backtrace):
2096
2097 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
2098
2099         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
2100
2101         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2102         (LayoutTestController::shadowRoot):
2103
2104 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
2105
2106         Unreviewed, fix exception in rebaseline tool.
2107
2108         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2109
2110 2011-04-02  Beth Dakin  <bdakin@apple.com>
2111
2112         Rubber-stamped by Geoff Garen.
2113
2114         For Dan!
2115         * DumpRenderTree/mac/DumpRenderTree.mm:
2116         (resetWebViewToConsistentStateBeforeTesting):
2117
2118 2011-04-02  Beth Dakin  <bdakin@apple.com>
2119
2120         Rubber-stamped by Geoff Garen.
2121
2122         Need to reset the scale, much like zoom.
2123         * DumpRenderTree/mac/DumpRenderTree.mm:
2124         (resetWebViewToConsistentStateBeforeTesting):
2125
2126 2011-04-02  Sam Weinig  <sam@webkit.org>
2127
2128         Reviewed by Beth Dakin.
2129
2130         https://bugs.webkit.org/show_bug.cgi?id=57605
2131         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
2132         getClientRects()
2133         -and corresponding-
2134         <rdar://problem/9194541>
2135
2136         Add DRT support for the scaleWebView SPI.
2137         * DumpRenderTree/mac/EventSendingController.mm:
2138         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2139         (+[EventSendingController webScriptNameForSelector:]):
2140         (-[EventSendingController scalePageBy:atX:andY:]):
2141         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2142         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2143         (WTR::EventSendingController::scalePageBy):
2144         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2145         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2146         (WTR::InjectedBundlePage::reset):
2147
2148 2011-04-02  Dominic Cooney  <dominicc@google.com>
2149
2150         Reviewed by Martin Robinson.
2151
2152         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
2153         https://bugs.webkit.org/show_bug.cgi?id=57551
2154
2155         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2156         (LayoutTestController::shadowRoot):
2157
2158 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
2159
2160         Reviewed by Eric Seidel.
2161
2162         Remove AbstractStep._run_script and move script names to ports.py
2163         https://bugs.webkit.org/show_bug.cgi?id=57704
2164
2165         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
2166
2167         * Scripts/webkitpy/common/config/ports.py:
2168         * Scripts/webkitpy/tool/commands/download_unittest.py:
2169         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2170         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2171         * Scripts/webkitpy/tool/steps/abstractstep.py:
2172         * Scripts/webkitpy/tool/steps/checkstyle.py:
2173         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2174         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2175         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2176
2177 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
2178
2179         Reviewed by Eric Seidel.
2180
2181         Emulate shebang on Win32
2182         https://bugs.webkit.org/show_bug.cgi?id=55927
2183
2184         Scripts on Windows work only if they are called with the explicit interpreter.
2185         Read the first line of scripts to detect the correct executable.
2186
2187         * Scripts/webkitpy/common/config/ports.py:
2188         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
2189         * Scripts/webkitpy/common/system/executive_unittest.py:
2190
2191 2011-04-01  Adam Barth  <abarth@webkit.org>
2192
2193         Reviewed by Eric Seidel.
2194
2195         apos entities shouldn't show up in ChangeLogs when using webkit-patch
2196         https://bugs.webkit.org/show_bug.cgi?id=57692
2197
2198         Previously, we were using BeautifulSoup to process XML from
2199         bugs.webkit.org, but that's incorrect.  We should be using
2200         BeautifulStoneSoup to process the XML.  We were getting the &apos;
2201         entity wrong because &apos; is an XML entity but not an HTML entity.
2202
2203         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2204         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2205
2206 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2207
2208         Unreviewed, rolling out r82721.
2209         http://trac.webkit.org/changeset/82721
2210         https://bugs.webkit.org/show_bug.cgi?id=57687
2211
2212         This patch introduced assertion failures on the GTK+ bots.
2213         (Requested by mrobinson on #webkit).
2214
2215         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2216         (LayoutTestController::shadowRoot):
2217
2218 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
2219
2220         Unreviewed buildfix.
2221
2222         [Qt][WK2] Build Webkit2 using "-2" option on Qt
2223         https://bugs.webkit.org/show_bug.cgi?id=55074
2224
2225         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
2226         (The isWK2() function removes it from @ARGV, but not from @options.)
2227
2228 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
2229
2230         Reviewed by Csaba Osztrogonác.
2231
2232         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
2233         https://bugs.webkit.org/show_bug.cgi?id=57666
2234
2235         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
2236
2237 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2238
2239         Reviewed by Adam Barth.
2240
2241         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
2242
2243         We apparently never implemented the code to skip tests based on
2244         what was compiled into DRT. Also, change the logic used to skip
2245         platform directories to match what old-run-webkit-tests does: 
2246         skip every test not in a directory in the baseline search path.
2247
2248         https://bugs.webkit.org/show_bug.cgi?id=57662
2249
2250         * Scripts/webkitpy/layout_tests/port/mac.py:
2251         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2252         * Scripts/webkitpy/layout_tests/port/webkit.py:
2253
2254 2011-03-29  Mark Rowe  <mrowe@apple.com>
2255
2256         Reviewed by Jon Honeycutt.
2257
2258         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
2259
2260         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
2261
2262         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2263         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2264         * Scripts/webkitpy/layout_tests/port/mac.py:
2265         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2266
2267 2011-04-01  Chang Shu  <cshu@webkit.org>
2268
2269         Reviewed by Csaba Osztrogonác.
2270
2271         [Qt][WK2] Build Webkit2 using "-2" option on Qt
2272         https://bugs.webkit.org/show_bug.cgi?id=55074
2273
2274         * Scripts/build-webkit:
2275
2276 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2277
2278         Reviewed by Tony Chang.
2279
2280         new-run-webkit-tests: remove spurious port version override in webkit.py
2281         base.py provides a default implementation so this is just
2282         breaking things.
2283
2284         https://bugs.webkit.org/show_bug.cgi?id=57667
2285
2286         * Scripts/webkitpy/layout_tests/port/webkit.py:
2287         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2288
2289 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
2290
2291         Reviewed by Adam Roben.
2292
2293         Make view results on waterfall direct link to results.html
2294         https://bugs.webkit.org/show_bug.cgi?id=57671
2295
2296         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
2297         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
2298
2299 2011-04-01  Sam Weinig  <sam@webkit.org>
2300
2301         Fix windows build.
2302
2303         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2304         (TestWebKitAPI::TEST):
2305         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2306         (TestWebKitAPI::flushMessages):
2307
2308 2011-04-01  Sam Weinig  <sam@webkit.org>
2309
2310         Reviewed by Adam Roben.
2311
2312         Add adoptWK to WKRetainPtr.h
2313         https://bugs.webkit.org/show_bug.cgi?id=57670
2314
2315         * TestWebKitAPI/PlatformUtilities.h:
2316         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2317         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2318         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2319         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2320         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2321         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2322         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2323         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2324         (TestWebKitAPI::createSessionStateContainingFormData):
2325         * WebKitTestRunner/StringFunctions.h:
2326         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
2327
2328 2011-04-01  Sam Weinig  <sam@webkit.org>
2329
2330         Reviewed by Adam Roben.
2331
2332         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
2333
2334         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2335         (WTR::LayoutTestController::shadowRoot):
2336         Make judicious use of adoptWK().
2337
2338 2011-04-01  Sam Weinig  <sam@webkit.org>
2339
2340         Reviewed by Timothy Hatcher.
2341
2342         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
2343
2344         * Scripts/extract-localizable-strings:
2345
2346 2011-04-01  Anders Carlsson  <andersca@apple.com>
2347
2348         Reviewed by Sam Weinig.
2349
2350         Shockwave plug-in doesn't accept mouse events
2351         https://bugs.webkit.org/show_bug.cgi?id=57653
2352         <rdar://problem/8483273>
2353
2354         Add a plug-in test.
2355
2356         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2357         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2358         (PluginTest::indicateTestFailure):
2359         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
2360
2361         (PluginTest::NPN_ConvertPoint):
2362         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2363         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
2364         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
2365         Call indicateTestFailure.
2366
2367         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
2368         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
2369         (ConvertPoint::ConvertPoint):
2370         (ConvertPoint::testConvert):
2371         (ConvertPoint::NPP_New):
2372
2373 2011-04-01  Dominic Cooney  <dominicc@google.com>
2374
2375         Reviewed by Martin Robinson.
2376
2377         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
2378         https://bugs.webkit.org/show_bug.cgi?id=57551
2379
2380         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2381         (LayoutTestController::shadowRoot):
2382
2383 2011-04-01  Sam Weinig  <sam@webkit.org>
2384
2385         Reviewed by Anders Carlsson.
2386
2387         WebKitTestRunner needs layoutTestController.shadowRoot
2388         https://bugs.webkit.org/show_bug.cgi?id=57661
2389
2390         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2391         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2392         (WTR::LayoutTestController::shadowRoot):
2393         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2394         Implement layoutTestController.shadowRoot for WebKit2.
2395
2396 2011-04-01  Chang Shu  <cshu@webkit.org>
2397
2398         Reviewed by Darin Adler.
2399
2400         WebKitTestRunner needs layoutTestController.setDatabaseQuota
2401         https://bugs.webkit.org/show_bug.cgi?id=57568
2402
2403         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2404         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2405         (WTR::LayoutTestController::setDatabaseQuota):
2406         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2407
2408 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2409
2410         Reviewed by Tony Chang.
2411
2412         This patch completes the cleanup of
2413         rebaseline-chromium-webkit-tests to work with all of the
2414         variants of a platform (we can now rebaseline gpu- and non-gpu
2415         files at the same time).
2416
2417         When the rebaselining is complete, any lines declared as
2418         REBASELINE in the expectations file that matches a test that was
2419         actually rebaselined will be deleted, even if only one of the
2420         variants was actually rebaselined. This may cause odd problems,
2421         but is better than where we're at today.
2422
2423         This change removes the -g flag and deprecates -w. The -g flag is gone
2424         because GPU baselines are handled just like any other variant.
2425         The -w flag is deprecated because this tool now only works
2426         against the canaries, since that's the only place we have a full
2427         set of bots. It will be trivial to change this to
2428         build.webkit.org if we decide that's where we want them to be.
2429
2430         Also, this patch deletes a lot of cruft that is no longer needed
2431         in the test_expectations code and the port-specific code.
2432
2433         https://bugs.webkit.org/show_bug.cgi?id=55191
2434
2435         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2436         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2437         * Scripts/webkitpy/layout_tests/port/base.py:
2438         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2439         * Scripts/webkitpy/layout_tests/port/chromium.py:
2440         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2441         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2442         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2443         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2444         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2445         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2446         * Scripts/webkitpy/layout_tests/port/mac.py:
2447         * Scripts/webkitpy/layout_tests/port/test.py:
2448         * Scripts/webkitpy/layout_tests/port/webkit.py:
2449         * Scripts/webkitpy/layout_tests/port/win.py:
2450         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2451         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2452
2453 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2454
2455         Reviewed by Adam Barth.
2456
2457         rebaseline-chromium-webkit-tests does not work correctly with
2458         version-specific baselines. This patch updates the tool to use
2459         all of the version-specific bots on the canaries, and will now
2460         attempt to rebaseline all of the versions by default, although
2461         it will not update both GPU and CPU versions.
2462         
2463         Also, it will no longer modify the test_expectations.txt file
2464         *at all*. You will have to manually delete the REBASELINE lines
2465         after running the tool and determining that it did what you
2466         wanted it to do. This should be fixed in a separate bug - see
2467         webkit bug #55191.
2468
2469         https://bugs.webkit.org/show_bug.cgi?id=55608
2470
2471         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2472         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2473         * Scripts/webkitpy/layout_tests/port/chromium.py:
2474         * Scripts/webkitpy/layout_tests/port/test.py:
2475         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2476         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2477
2478 2011-03-31  Tony Chang  <tony@chromium.org>
2479
2480         Reviewed by Ojan Vafai.
2481
2482         [chromium] update the rebaseline tool to know about pngs with checksums
2483         https://bugs.webkit.org/show_bug.cgi?id=57481
2484
2485         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
2486         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2487
2488 2011-04-01  Adam Roben  <aroben@apple.com>
2489
2490         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
2491
2492         Previously, we were getting the revision of the first revision that triggered a build.
2493         Choosing the last revision would have been more accurate. But got_revision is what is used
2494         everywhere else on build.webkit.org, and should work even when there were no changes that
2495         triggered a build (e.g., if someone clicked the Force Build button).
2496
2497         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
2498         recent builds list
2499
2500         Reviewed by Anders Carlsson.
2501
2502         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2503         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
2504         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
2505
2506         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
2507         (Array.prototype.first): Added this helper function to return the first element in an array
2508         that matches the given predicate, or null if no such element exists.
2509
2510 2011-03-31  Adam Roben  <aroben@apple.com>
2511
2512         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
2513
2514         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
2515
2516         Reviewed by Darin Adler.
2517
2518         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2519         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
2520         URL on its own line.
2521
2522         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2523         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
2524         progression, and added a new test that uses a short bug URL while I was at it.
2525
2526 2011-04-01  Adam Roben  <aroben@apple.com>
2527
2528         Mark .vcproj/.vsprops/.sln files as being Windows-only
2529
2530         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
2531
2532         Reviewed by Anders Carlsson.
2533
2534         * Scripts/webkitpy/common/config/build.py:
2535         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
2536         directories as Windows-only.
2537
2538         * Scripts/webkitpy/common/config/build_unittest.py:
2539         (ShoulBuildTest): Added test cases for the above.
2540
2541 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
2542
2543         Reviewed by Laszlo Gombos.
2544
2545         [Qt] Build MiniBrowser for Symbian
2546         https://bugs.webkit.org/show_bug.cgi?id=56319
2547
2548         Have MiniBrowser reference it's own copy of useragentlist.txt instead
2549         of copying QtTestBrowser's.
2550         Remove Tools/MiniBrowser/DerivedSources.pro
2551         This reduces complexity in the Tools scripts due to Symbian limitations.
2552
2553         * DerivedSources.pro:
2554         * MiniBrowser/DerivedSources.pro: Removed.
2555         * MiniBrowser/MiniBrowser.qrc:
2556         * MiniBrowser/qt/MiniBrowser.pro:
2557         * Scripts/webkitdirs.pm:
2558
2559 2011-03-31  Chang Shu  <cshu@webkit.org>
2560
2561         Reviewed by Darin Adler.
2562
2563         WebKitTestRunner needs layoutTestController.clearAllDatabases
2564         https://bugs.webkit.org/show_bug.cgi?id=42540
2565
2566         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2567         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2568         (WTR::InjectedBundle::beginTesting):
2569         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2570         (WTR::LayoutTestController::clearAllDatabases):
2571         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2572
2573 2011-03-31  Chang Shu  <cshu@webkit.org>
2574
2575         Reviewed by Darin Adler.
2576
2577         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
2578         https://bugs.webkit.org/show_bug.cgi?id=42692
2579
2580         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2581
2582 2011-03-31  Darin Adler  <darin@apple.com>
2583
2584         Reviewed by Sam Weinig.
2585
2586         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
2587         https://bugs.webkit.org/show_bug.cgi?id=57573
2588
2589         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2590         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
2591         Removed fake definitions of keyDown and contextClick.
2592
2593         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2594         (WTR::operator==): Added. So we can compare two WKPoint structs.
2595         (WTR::parseModifier): Added.
2596         (WTR::parseModifierArray): Added.
2597         (WTR::EventSendingController::EventSendingController): Initialize the
2598         new data members.
2599         (WTR::EventSendingController::mouseDown): Added. Calls
2600         WKBundlePageSimulateMouseDown.
2601         (WTR::EventSendingController::mouseUp): Added. Calls
2602         WKBundlePageSimulateMouseUp.
2603         (WTR::EventSendingController::mouseMoveTo): Added. Calls
2604         WKBundlePageSimulateMouseMotion.
2605         (WTR::EventSendingController::leapForward): Added.
2606         (WTR::EventSendingController::updateClickCount): Added. Used by the
2607         mouseDown/Up functions to create a click count.
2608
2609         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
2610         for the changes above.
2611
2612 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
2613
2614         Reviewed by Martin Robinson.
2615
2616         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
2617         https://bugs.webkit.org/show_bug.cgi?id=57362
2618
2619         Do not generate DRT output if willSendRequestReturnsNull is set.
2620
2621         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2622         (willSendRequestCallback):
2623
2624 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
2625
2626         Reviewed by Martin Robinson.
2627
2628         Implement MiniBrowser for Gtk port.
2629         https://bugs.webkit.org/show_bug.cgi?id=48512
2630
2631         Initial implementation of the Gtk MiniBrowser.
2632
2633         * MiniBrowser/gtk/GNUmakefile.am: Added.
2634         * MiniBrowser/gtk/main.c: Added.
2635         (activateUriEntryCallback):
2636         (destroyCallback):
2637         (goBackCallback):
2638         (goForwardCallback):
2639         (createToolbar):
2640         (createWebView):
2641         (createWindow):
2642         (argumentToURL):
2643         (main):
2644
2645 2011-03-30  Dominic Cooney  <dominicc@google.com>
2646
2647         Reviewed by Dimitri Glazkov.
2648
2649         Adds layoutTestController.shadowRoot accessor to Mac DRT.
2650         https://bugs.webkit.org/show_bug.cgi?id=57415
2651
2652         * DumpRenderTree/LayoutTestController.cpp:
2653         (shadowRootCallback):
2654         (LayoutTestController::staticFunctions):
2655         * DumpRenderTree/LayoutTestController.h:
2656         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2657         (LayoutTestController::shadowRoot):
2658         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2659         (LayoutTestController::shadowRoot):
2660
2661 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
2662
2663         Reviewed by Chris Marrin.
2664
2665         Update fast/canvas tests to avoid dumping the render tree when possible
2666         https://bugs.webkit.org/show_bug.cgi?id=57493
2667
2668         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
2669           accelerated drawing and accelerated drawing for canvas
2670
2671 2011-03-30  Adam Roben  <aroben@apple.com>
2672
2673         Stop ignoring leaks in CGGradientCreateWithColorStops
2674
2675         Fixes <rdar://problem/7888547>.
2676
2677         Rubber-stamped by John Sullivan.
2678
2679         * Scripts/old-run-webkit-tests:
2680         (countAndPrintLeaks): Removed some code to ignore those leaks.
2681
2682 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
2683
2684         Reviewed by Alexey Proskuryakov.
2685
2686         Add some dynamic annotations to JavaScriptCore/wtf
2687         https://bugs.webkit.org/show_bug.cgi?id=53747
2688
2689         By using these annotations we can improve the precision of finding
2690         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
2691         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
2692
2693         These files don't add new functionality, so don't need extra tests.
2694
2695         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
2696
2697 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2698
2699         Reviewed by Adam Roben.
2700
2701         Share most vsprops between Release and Production builds in releaseproduction.vsprops
2702         https://bugs.webkit.org/show_bug.cgi?id=57508
2703
2704         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
2705         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
2706         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
2707         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
2708         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
2709         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
2710         * DumpRenderTree/win/ImageDiffProduction.vsprops:
2711         * DumpRenderTree/win/ImageDiffRelease.vsprops:
2712         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
2713         * FindSafari/FindSafariProduction.vsprops:
2714         * FindSafari/FindSafariRelease.vsprops:
2715         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
2716         * FindSafari/FindSafariReleasePGO.vsprops:
2717         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
2718         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
2719         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
2720         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
2721         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
2722         * WebKitAPITest/WebKitAPITestProduction.vsprops:
2723         * WebKitAPITest/WebKitAPITestRelease.vsprops:
2724         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
2725         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
2726         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
2727         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
2728         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
2729         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
2730         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
2731         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
2732         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
2733         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
2734         * WinLauncher/WinLauncherProduction.vsprops:
2735         * WinLauncher/WinLauncherRelease.vsprops:
2736         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
2737         * record-memory-win/record-memory-winProduction.vsprops:
2738         * record-memory-win/record-memory-winRelease.vsprops:
2739         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
2740
2741 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2742
2743         Reviewed by Adam Roben.
2744
2745         Update Windows production build logic for new production configurations
2746         https://bugs.webkit.org/show_bug.cgi?id=57494
2747
2748         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
2749         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
2750         * DumpRenderTree/win/ImageDiffProduction.vsprops:
2751         * FindSafari/FindSafariProduction.vsprops:
2752         * FindSafari/FindSafariReleasePGO.vsprops:
2753         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
2754         * WebKitAPITest/WebKitAPITestProduction.vsprops:
2755         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
2756         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
2757         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
2758         * WinLauncher/WinLauncherProduction.vsprops:
2759         * record-memory-win/record-memory-winProduction.vsprops:
2760
2761 2011-03-30  Robert Hogan  <robert@webkit.org>
2762
2763         Reviewed by Antonio Gomes.
2764
2765         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
2766         Unskip http/tests/navigation/go-back-to-error-page.html
2767
2768         Also add the location of DumpRenderTreeSupportQt.h
2769         to DRT's include paths.
2770
2771         https://bugs.webkit.org/show_bug.cgi?id=52614
2772
2773         * DumpRenderTree/qt/DumpRenderTree.pro:
2774         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2775         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2776         * DumpRenderTree/qt/GCControllerQt.cpp:
2777         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2778         (LayoutTestController::queueLoadHTMLString):
2779         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2780         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2781         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2782         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2783         (LoadAlternateHTMLStringItem::invoke):
2784         * DumpRenderTree/qt/WorkQueueItemQt.h:
2785         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2786         * QtTestBrowser/QtTestBrowser.pro:
2787         * QtTestBrowser/launcherwindow.h:
2788
2789 2011-03-30  Adam Barth  <abarth@webkit.org>
2790
2791         Reviewed by Adam Roben.
2792
2793         SheriffBot rollouts take too long
2794         https://bugs.webkit.org/show_bug.cgi?id=57498
2795
2796         We used to build before landing rollouts via the commit-queue to
2797         prevent further breakage, but now that our individual commit-queue
2798         machines are slower, building takes too long.  I can't remember the
2799         last time a rollout broke compile.  It seems like just landing the
2800         patch is the better trade-off.
2801
2802         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2803         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2804
2805 2011-03-30  Adam Barth  <abarth@webkit.org>
2806
2807         Remove platform/chromium-mac-snowleopard
2808         https://bugs.webkit.org/show_bug.cgi?id=57486
2809
2810         This directory no longer exists, so we can remove it from the fallback
2811         chain.
2812
2813         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2814
2815 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2816
2817         Reviewed by Adam Roben.
2818
2819         Rename Windows configuration Release_LTCG to Production for clarity
2820         https://bugs.webkit.org/show_bug.cgi?id=57465
2821
2822         * DumpRenderTree/DumpRenderTree.sln:
2823         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2824         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
2825         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
2826         * DumpRenderTree/win/DumpRenderTree.vcproj:
2827         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
2828         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
2829         * DumpRenderTree/win/ImageDiff.vcproj:
2830         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
2831         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
2832         * FindSafari/FindSafari.vcproj:
2833         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
2834         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
2835         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
2836         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
2837         * MiniBrowser/MiniBrowser.vcproj:
2838         * Scripts/webkitdirs.pm:
2839         * TestWebKitAPI/win/TestWebKitAPI.sln:
2840         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2841         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
2842         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2843         * WebKitAPITest/WebKitAPITest.vcproj:
2844         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
2845         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
2846         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2847         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
2848         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
2849         * WebKitTestRunner/WebKitTestRunner.sln:
2850         * WebKitTestRunner/win/InjectedBundle.vcproj:
2851         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
2852         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
2853         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
2854         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2855         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
2856         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
2857         * WinLauncher/WinLauncher.vcproj:
2858         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
2859         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
2860         * record-memory-win/record-memory-win.vcproj:
2861         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
2862         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
2863
2864 2011-03-30  MORITA Hajime  <morrita@google.com>
2865
2866         Reviewed by Dimitri Glazkov.
2867
2868         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
2869         https://bugs.webkit.org/show_bug.cgi?id=56573
2870
2871         Added LayoutTestController.shadowRoot() to Chromium DRT.
2872
2873         * DumpRenderTree/chromium/LayoutTestController.cpp:
2874         (LayoutTestController::LayoutTestController):
2875         (LayoutTestController::shadowRoot):
2876         * DumpRenderTree/chromium/LayoutTestController.h:
2877
2878 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
2879
2880         Reviewed by Kent Tamura.
2881
2882         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
2883         https://bugs.webkit.org/show_bug.cgi?id=57430
2884
2885         * DumpRenderTree/chromium/LayoutTestController.cpp:
2886         (LayoutTestController::LayoutTestController):
2887         (LayoutTestController::setPluginsEnabled):
2888         * DumpRenderTree/chromium/LayoutTestController.h:
2889
2890 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2891
2892         Reviewed by Adam Barth.
2893
2894         make webkit-patch upload respect -d
2895         https://bugs.webkit.org/show_bug.cgi?id=57425
2896
2897         * Scripts/webkitpy/common/checkout/scm.py:
2898         * Scripts/webkitpy/tool/steps/commit.py:
2899
2900 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2901
2902         Reviewed by Adam Barth.
2903
2904         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
2905         https://bugs.webkit.org/show_bug.cgi?id=57429
2906
2907         * Scripts/webkitpy/common/checkout/scm.py:
2908
2909 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2910
2911         Unreviewed, rolling out r82383.
2912         http://trac.webkit.org/changeset/82383
2913         https://bugs.webkit.org/show_bug.cgi?id=57417
2914
2915         "nrwt isn't shutting down cleanly" (Requested by dpranke on
2916         #webkit).
2917
2918         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2919         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2920         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2921
2922 2011-03-29  Kent Tamura  <tkent@chromium.org>
2923
2924         Reviewed by Dimitri Glazkov.
2925
2926         Make validation message bubble testable
2927         https://bugs.webkit.org/show_bug.cgi?id=57290
2928
2929         * DumpRenderTree/mac/DumpRenderTree.mm:
2930         (createWebViewAndOffscreenWindow): Change a setting so that validation
2931           bubbles isn't hidden automatically.
2932
2933 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
2934
2935         Reviewed by Ojan Vafai.
2936
2937         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
2938
2939         It's a bit unclear whether multiple threads or multiple
2940         processes will be a better model on windows. This change will
2941         test threads for now while we're still working out the bugs in
2942         multiple-processes.
2943
2944         https://bugs.webkit.org/show_bug.cgi?id=57410
2945
2946         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2947         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2948         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2949
2950 2011-03-29  David Levin  <levin@chromium.org>
2951
2952         Reviewed by Shinichiro Hamaji.
2953
2954         check-webkit-style confused by two ChangeLog entries in a row from same user
2955         https://bugs.webkit.org/show_bug.cgi?id=57250
2956
2957         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
2958         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
2959         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
2960           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
2961           checking more than that would be very messey.
2962         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
2963         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
2964
2965 2011-03-29  Kent Tamura  <tkent@chromium.org>
2966
2967         Reviewed by Dimitri Glazkov.
2968
2969         [Mac] Enable interactive-validation tests on Mac DRT
2970         https://bugs.webkit.org/show_bug.cgi?id=57308
2971
2972         * DumpRenderTree/mac/DumpRenderTree.mm:
2973         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
2974
2975 2011-03-29  Chang Shu  <cshu@webkit.org>
2976
2977         Reviewed by Kenneth Rohde Christiansen.
2978
2979         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
2980         https://bugs.webkit.org/show_bug.cgi?id=42692
2981
2982         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2983         (WTR::InjectedBundle::beginTesting):
2984         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2985         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
2986         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2987
2988 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
2989
2990         Reviewed by Xan Lopez.
2991
2992         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
2993         https://bugs.webkit.org/show_bug.cgi?id=57067
2994
2995         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
2996         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
2997         update DRT and pixel results as hundreds of results will need to be updated.
2998
2999         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3000         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
3001         by overriding the theme RC/CSS files.
3002
3003 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
3004
3005         Reviewed by Adam Roben.
3006
3007         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
3008         https://bugs.webkit.org/show_bug.cgi?id=57394
3009
3010         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
3011         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
3012         the IDE. To avoid this, add a separate vsprops file for each project configuration that
3013         contains the required inherited property sheets.
3014
3015         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3016         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
3017         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
3018         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
3019         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
3020         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
3021         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
3022         * DumpRenderTree/win/DumpRenderTree.vcproj:
3023         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
3024         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
3025         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
3026         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
3027         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
3028         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
3029         * DumpRenderTree/win/ImageDiff.vcproj:
3030         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
3031         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
3032         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
3033         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
3034         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
3035         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
3036         * FindSafari/FindSafari.vcproj:
3037         * FindSafari/FindSafariDebug.vsprops: Added.
3038         * FindSafari/FindSafariDebugAll.vsprops: Added.
3039         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
3040         * FindSafari/FindSafariRelease.vsprops: Added.
3041         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
3042         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
3043         * FindSafari/FindSafariReleasePGO.vsprops: Added.
3044         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
3045         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
3046         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
3047         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
3048         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
3049         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
3050         * MiniBrowser/MiniBrowser.vcproj:
3051         * WebKitAPITest/WebKitAPITest.vcproj:
3052         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
3053         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
3054         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
3055         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
3056         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
3057         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
3058         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3059         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
3060         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
3061         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
3062         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
3063         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
3064         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
3065         * WebKitTestRunner/win/InjectedBundle.vcproj:
3066         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
3067         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
3068         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
3069         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
3070         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
3071         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
3072         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3073         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
3074         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
3075         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
3076         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
3077         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
3078         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
3079         * WinLauncher/WinLauncher.vcproj:
3080         * WinLauncher/WinLauncherDebug.vsprops: Added.
3081         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
3082         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
3083         * WinLauncher/WinLauncherRelease.vsprops: Added.
3084         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
3085         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
3086         * record-memory-win/record-memory-win.vcproj:
3087         * record-memory-win/record-memory-winDebug.vsprops: Added.
3088         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
3089         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
3090         * record-memory-win/record-memory-winRelease.vsprops: Added.
3091         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
3092         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
3093
3094 2011-03-29  Adam Barth  <abarth@webkit.org>
3095
3096         Reviewed by Darin Adler.
3097
3098         test_runner2.py can crash due to undefined variable
3099         https://bugs.webkit.org/show_bug.cgi?id=57356
3100
3101         Replace reference to undefined variable with a variable that's actually
3102         defined.  AFAICT, there's no way to test this code.
3103
3104         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
3105
3106 2011-03-29  Tony Chang  <tony@chromium.org>
3107
3108         Reviewed by Eric Seidel.
3109
3110         cleanup rebaseline-chromium-webkit-tests
3111         https://bugs.webkit.org/show_bug.cgi?id=57375
3112
3113         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3114             - Split _extract_and_add_new_baselines into 3 functions
3115             - Reduce the amount of line wrapping (the file already has lines
3116               over 80 col, so may as well try to make the file consistent)
3117             - Remove unnecessary ()s
3118
3119 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
3120
3121         Reviewed by Adam Roben.
3122
3123         Make WinCairo a core builder.
3124         https://bugs.webkit.org/show_bug.cgi?id=57373
3125
3126         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
3127         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
3128
3129 2011-03-29  Timothy Hatcher  <timothy@apple.com>
3130
3131         Update update-webkit-localizable-strings to understand that WebKit and
3132         WebKit2 strings go in WebCore.
3133
3134         Also make extract-localizable-strings optionally use an exclude file. No individual
3135         warnings are produced about unlocalized strings when there is no exclude file. This
3136         is needed for WebCore, since there are too many bare strings.
3137
3138         https://webkit.org/b/57354
3139
3140         Reviewed by Sam Weinig.
3141
3142         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
3143         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
3144
3145 2011-03-29  Darin Adler  <darin@apple.com>
3146
3147         Reviewed by Adam Roben.
3148
3149         WebKit2 bundle page needs to offer generated file hooks
3150         https://bugs.webkit.org/show_bug.cgi?id=57279
3151
3152         (Land missing part of the original patch after r82289.)
3153
3154         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3155         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
3156
3157 2011-03-29  Tony Chang  <tony@chromium.org>
3158
3159         Reviewed by Ojan Vafai.
3160
3161         [chromium] NRWT should be able to read checksums from png comments
3162         https://bugs.webkit.org/show_bug.cgi?id=57280
3163
3164         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
3165             from a file.
3166         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
3167         * Scripts/webkitpy/common/system/filesystem_mock.py:
3168         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
3169             if the -checksum.txt file doesn't exist, try looking in the png.
3170         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3171         * Scripts/webkitpy/layout_tests/port/test.py:
3172         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
3173             2k for a png comment with the checksum
3174         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
3175
3176 2011-03-29  Philippe Normand  <pnormand@igalia.com>
3177
3178         Rubber-stamped by Gustavo Noronha Silva.
3179
3180         [GTK] http/tests/uri/username-with-no-hostname.html fails
3181         https://bugs.webkit.org/show_bug.cgi?id=57325
3182
3183         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3184         (willSendRequestCallback): URI host value check done case-insensitively.
3185
3186 2011-03-29  Philippe Normand  <pnormand@igalia.com>
3187
3188         Reviewed by Martin Robinson.
3189
3190         [GTK] http/tests/uri/username-with-no-hostname.html fails
3191         https://bugs.webkit.org/show_bug.cgi?id=57325
3192
3193         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3194         (willSendRequestCallback): Check URI before submitting the request
3195         to WebCore.
3196
3197 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
3198
3199         Reviewed by Ojan Vafai.
3200
3201         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
3202         https://bugs.webkit.org/show_bug.cgi?id=57303
3203
3204         * DumpRenderTree/chromium/EventSender.cpp:
3205         (EventSender::doDragDrop):
3206         (EventSender::beginDragWithFiles):
3207
3208 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
3209
3210         Reviewed by Andreas Kling.
3211
3212         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
3213         https://bugs.webkit.org/show_bug.cgi?id=57314
3214
3215         Provide possibility to print loaded urls to the standard output.
3216
3217         * MiniBrowser/qt/BrowserWindow.cpp:
3218         (BrowserWindow::BrowserWindow):
3219         (BrowserWindow::printURL):
3220         * MiniBrowser/qt/BrowserWindow.h:
3221         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3222         (MiniBrowserApplication::handleUserOptions):
3223         * MiniBrowser/qt/MiniBrowserApplication.h:
3224         (WindowOptions::WindowOptions):
3225         * QtTestBrowser/launcherwindow.cpp:
3226         (LauncherWindow::initializeView):
3227         (LauncherWindow::printURL):
3228         (LauncherWindow::cloneWindow):
3229         * QtTestBrowser/launcherwindow.h:
3230         (WindowOptions::WindowOptions):
3231         * QtTestBrowser/main.cpp:
3232         (LauncherApplication::handleUserOptions):
3233
3234 2011-03-29  Gabor Loki  <loki@webkit.org>
3235
3236         Rubber-stamped by Csaba Osztrogonác.
3237
3238         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
3239         https://bugs.webkit.org/show_bug.cgi?id=56918
3240
3241         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
3242
3243 2011-03-28  Gabor Loki  <loki@webkit.org>
3244
3245         Reviewed by Csaba Osztrogonác.
3246
3247         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
3248         https://bugs.webkit.org/show_bug.cgi?id=56918
3249
3250         * Scripts/build-jsc:
3251         * Scripts/webkitdirs.pm:
3252
3253 2011-03-28  Andrew Foster  <andrewf@chromium.org>
3254
3255         Reviewed by Ojan Vafai.
3256
3257         webkit-patch should be more intelligent about whether a bug applies to a patch
3258         Create a new function, parse_bug_id_from_changelog() which determines
3259         that a bug is related to a patch by parsing the output generated from
3260         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
3261         the description of a patch.
3262         https://bugs.webkit.org/show_bug.cgi?id=56989
3263
3264         * Scripts/webkitpy/common/checkout/api.py:
3265         * Scripts/webkitpy/common/checkout/changelog.py:
3266         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
3267         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3268         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3269         * Scripts/webkitpy/style/checkers/changelog.py:
3270         * Scripts/webkitpy/tool/commands/upload.py:
3271
3272 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
3273
3274         Revert accidentally commited change.
3275
3276         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3277         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3278
3279 2011-03-28  Tony Chang  <tony@chromium.org>
3280
3281         Reviewed by Adam Barth.
3282
3283         [chromium] have DRT write the png checksum into a png comment
3284         https://bugs.webkit.org/show_bug.cgi?id=57255
3285
3286         * DumpRenderTree/chromium/TestShell.cpp:
3287         (TestShell::dumpImage):
3288
3289 2011-03-28  Adele Peterson  <adele@apple.com>
3290
3291         Removing Qt stub, since it doesn't use the same header as the others.
3292
3293         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3294
3295 2011-03-28  Adele Peterson  <adele@apple.com>
3296
3297         Added a few more stubs.
3298
3299         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3300         (LayoutTestController::hasGrammarMarker):
3301         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3302         (LayoutTestController::hasGrammarMarker):
3303         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3304         (LayoutTestController::hasGrammarMarker):
3305
3306 2011-03-28  Adele Peterson  <adele@apple.com>
3307
3308         Build fix.
3309
3310         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3311         (LayoutTestController::hasGrammarMarker):
3312
3313 2011-03-28  Adele Peterson  <adele@apple.com>
3314
3315         Reviewed by Eric Seidel.
3316
3317         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
3318         https://bugs.webkit.org/show_bug.cgi?id=57173
3319
3320         * DumpRenderTree/LayoutTestController.cpp:
3321         (hasGrammarMarkerCallback): Added.
3322         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
3323         * DumpRenderTree/LayoutTestController.h:
3324         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
3325         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
3326
3327 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3328
3329         Reviewed by Benjamin Poulain.
3330
3331         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
3332         https://bugs.webkit.org/show_bug.cgi?id=57087
3333
3334         Trivial typo fix after r82082.
3335
3336         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3337         (WTR::activateFonts):
3338
3339 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
3340
3341         Reviewed by Andreas Kling.
3342
3343         Add myself to the committers list.
3344
3345         * Scripts/webkitpy/common/config/committers.py:
3346
3347 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
3348
3349         Reviewed by Sam Weinig.
3350
3351         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
3352         to link against WebKit.framework for now.
3353
3354         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3355
3356 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
3357
3358         Reviewed by Andreas Kling.
3359
3360         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
3361         https://bugs.webkit.org/show_bug.cgi?id=57087
3362
3363         Disable QT_ASCII_CAST_WARNINGS for applications.
3364
3365         * DumpRenderTree/qt/DumpRenderTree.pro:
3366         * DumpRenderTree/qt/ImageDiff.pro:
3367         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3368         * MiniBrowser/qt/MiniBrowser.pro:
3369         * QtTestBrowser/QtTestBrowser.pro:
3370         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3371
3372 2011-03-28  Andreas Kling  <kling@webkit.org>
3373
3374         Reviewed by Kenneth Rohde Christiansen.
3375
3376         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
3377         https://bugs.webkit.org/show_bug.cgi?id=57224
3378
3379         * QtTestBrowser/mainwindow.cpp:
3380         (MainWindow::buildUI):
3381         (MainWindow::onTitleChanged):
3382         * QtTestBrowser/mainwindow.h:
3383
3384 2011-03-27  Jer Noble  <jer.noble@apple.com>
3385
3386         Reviewed by Maciej Stachowiak.
3387
3388         Full Screen: disable keyboard access by default
3389         https://bugs.webkit.org/show_bug.cgi?id=56684
3390
3391         Accept the withKeyboard parameter to supportsFullScreenForElement.
3392
3393         * DumpRenderTree/mac/UIDelegate.mm:
3394         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
3395
3396 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
3397
3398         Reviewed by David Levin.
3399
3400         check-webkit-style should check ChangeLog for a valid bug number
3401         https://bugs.webkit.org/show_bug.cgi?id=57184
3402
3403         * Scripts/webkitpy/style/checker.py:
3404         * Scripts/webkitpy/style/checker_unittest.py:
3405         * Scripts/webkitpy/style/checkers/changelog.py: Added.
3406         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
3407
3408 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
3409
3410         Reviewed by Andreas Kling.
3411
3412         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
3413         https://bugs.webkit.org/show_bug.cgi?id=57087
3414
3415         Use explicit conversion for string to avoid depending on the default codec
3416         installed by the user code.
3417
3418         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3419         (WTR::activateFonts):
3420
3421 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
3422
3423         Revert inadvertantly committed changes.
3424
3425         * Scripts/old-run-webkit-tests:
3426         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3427
3428 2011-03-26  Andreas Kling  <kling@webkit.org>
3429
3430         Reviewed by Kenneth Rohde Christiansen.
3431
3432         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
3433         https://bugs.webkit.org/show_bug.cgi?id=57162
3434
3435         * QtTestBrowser/QtTestBrowser.qrc:
3436         * QtTestBrowser/favicon.png: Added.
3437         * QtTestBrowser/locationedit.cpp:
3438         (defaultPageIcon):
3439         (LocationEdit::LocationEdit):
3440         (LocationEdit::setPageIcon):
3441         (LocationEdit::resizeEvent):
3442         (LocationEdit::updateInternalGeometry):
3443         * QtTestBrowser/locationedit.h:
3444         * QtTestBrowser/mainwindow.cpp:
3445         (MainWindow::buildUI):
3446         (MainWindow::onIconChanged):
3447         (MainWindow::onLoadStarted):
3448         * QtTestBrowser/mainwindow.h:
3449
3450 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
3451
3452         Reviewed by Xan Lopez.
3453
3454         [GTK] Force DumpRenderTree to use 96 DPI
3455         https://bugs.webkit.org/show_bug.cgi?id=56866
3456
3457         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
3458         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
3459
3460         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3461         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
3462         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
3463         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
3464
3465 2011-03-25  Andy Estes  <aestes@apple.com>
3466
3467         Reviewed by Adele Peterson.
3468
3469         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
3470         https://bugs.webkit.org/show_bug.cgi?id=49016
3471
3472         TestNetscapePlugIn needs to register support for an image MIME type so
3473         we can test that the embed tag prefers plug-ins to render image MIME
3474         types.
3475
3476         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
3477         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3478         (NP_GetMIMEDescription): Ditto.
3479         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
3480
3481 2011-03-25  Jessie Berlin  <jberlin@apple.com>
3482
3483         Reviewed by Sam Weinig.
3484
3485         WebKit2: Need to be able to set and get the Cookie Storage Policy.
3486         https://bugs.webkit.org/show_bug.cgi?id=50780
3487
3488         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
3489
3490         The test is named "CookieManager" so that we can eventually exercise more of the
3491         CookieManager functionality in the test.
3492
3493         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
3494         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
3495         Assert that the policy returned is equal to the policy set in
3496         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
3497         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
3498         Set the policy to something different than the user's policy and get the policy again.
3499         (TestWebKitAPI::didFinishLoadForFrame):
3500         Get the user's policy so that it can be restored at the end of the test.
3501         (TestWebKitAPI::TEST):
3502         Load about:blank so that the Web Process gets instatiated (needed to get the
3503         CookieManager).
3504
3505         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3506         Add CookieManager.cpp.
3507
3508 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
3509
3510         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
3511
3512         * wx/build/settings.py:
3513
3514 2011-03-24  Ilya Sherman  <isherman@chromium.org>
3515
3516         Reviewed by Adam Roben.
3517
3518         Implement layoutTestController.setAutoFilled in DRT on Windows
3519         https://bugs.webkit.org/show_bug.cgi?id=56828
3520
3521         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3522         (LayoutTestController::setAutofilled): Implemented.
3523
3524 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
3525
3526         Unreviewed build correction.
3527
3528         Correct vsprops file for Debug variant of the CFLite build.
3529         Disable a CFNETWORK-specific test when building for CFLite.
3530
3531         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
3532         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3533
3534 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
3535
3536         Reviewed by Adam Barth.
3537
3538         fix regressions introduced in 81908 - there were a couple of
3539         code paths that only fired under python 2.5 that I missed.
3540
3541         Also change a couple of 'python' references to sys.executable
3542         in order to handle runing test-webkitpy with a binary other than
3543         something called 'python'.
3544
3545         https://bugs.webkit.org/show_bug.cgi?id=57063
3546
3547         * Scripts/webkitpy/layout_tests/port/mac.py:
3548         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3549         * Scripts/webkitpy/test/cat.py:
3550         * Scripts/webkitpy/test/echo.py:
3551
3552 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
3553
3554         Unreviewed build correction.
3555
3556         Add a stub implementation of the TestInvocation dumping logic.
3557         Update project files to reflect new file.
3558
3559         * WebKitTestRunner/cairo: Added.
3560         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
3561         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3562         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3563
3564 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
3565
3566         Reviewed by Tony Chang.
3567
3568         new-run-webkit-tests: clean up worker model defaults. This
3569         changes the default behavior to 'threads' instead of
3570         'old-threads', and clarifies that chromium-win-* and
3571         chromium-mac-leopard are exceptions.
3572
3573         https://bugs.webkit.org/show_bug.cgi?id=56971
3574
3575         * Scripts/webkitpy/layout_tests/port/base.py:
3576         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3577         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3578         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3579         * Scripts/webkitpy/layout_tests/port/test.py:
3580         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3581
3582 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
3583
3584         Reviewed by Darin Adler.
3585
3586         Media Stream API: fix the order of the options in build-webkit.
3587         https://bugs.webkit.org/show_bug.cgi?id=56949
3588
3589         Fix the order of the options in build-webkit.
3590
3591         * Scripts/build-webkit:
3592
3593 2011-03-23  Adam Klein  <adamk@chromium.org>
3594
3595         Reviewed by Mihai Parparita.
3596
3597         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
3598         https://bugs.webkit.org/show_bug.cgi?id=56884
3599
3600         This option will be utilized by Chromium's ui_tests to allow
3601         referencing js-test-resources from a layout test over HTTP.
3602
3603         * Scripts/new-run-webkit-httpd:
3604         Added --layout_tests_dir option.
3605         * Scripts/webkitpy/layout_tests/port/http_server.py:
3606         Plumbed through as layout_tests_dir param.
3607
3608 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
3609
3610         Reviewed by Mihai Parparita.
3611
3612         new-run-webkit-tests: run tests in ascending alphabetical order per
3613         dir. This is a second attempt at the fix; the first attempt, in 
3614         r81597, broke the behavior on the old-inline and old-threads
3615         worker models.
3616
3617         https://bugs.webkit.org/show_bug.cgi?id=56760
3618
3619         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3620         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3621         * Scripts/webkitpy/layout_tests/port/test.py:
3622         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3623
3624 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
3625
3626         Reviewed by Martin Robinson.
3627
3628         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
3629         https://bugs.webkit.org/show_bug.cgi?id=56953
3630
3631         Print the string for the detail of 'property-change' signal.
3632
3633         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
3634         (axObjectEventListener): Print the detail string.
3635
3636 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
3637
3638         Reviewed by Pavel Feldman.
3639
3640         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
3641         https://bugs.webkit.org/show_bug.cgi?id=56843
3642
3643         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3644         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3645
3646 2011-03-22  Eric Seidel  <eric@webkit.org>
3647
3648         Reviewed by Adam Barth.
3649
3650         Teach update-webkit about gyp
3651         https://bugs.webkit.org/show_bug.cgi?id=56881
3652
3653         This makes it possible for someone who builds from Xcode
3654         to just run update-webkit --gyp and have the project files
3655         generated after update automatically.
3656
3657         I also added a stand-alone "generate-project-files" script
3658         wrapping Source/gyp/configure.  This makes running gyp simpler
3659         since most people will not have gyp or Source/gyp in their path.
3660
3661         * Scripts/build-webkit:
3662         * Scripts/generate-project-files: Added.
3663         * Scripts/update-webkit:
3664
3665 2011-03-22  Anton D'Auria  <adauria@apple.com>
3666
3667         Reviewed by Alexey Proskuryakov.
3668
3669         Add +[WebApplicationCache getOriginsWithCache]
3670         https://bugs.webkit.org/show_bug.cgi?id=56722
3671
3672         * DumpRenderTree/LayoutTestController.cpp:
3673         (originsWithApplicationCacheCallback):
3674         (LayoutTestController::staticFunctions):
3675         * DumpRenderTree/LayoutTestController.h:
3676         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
3677         (LayoutTestController::originsWithApplicationCache):
3678         * DumpRenderTree/chromium/LayoutTestController.h:
3679         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.