3aa7a8271f97b696fdea26df6f2837b2b3f23fc9
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Add a build flag for custom element
4         https://bugs.webkit.org/show_bug.cgi?id=153005
5
6         Reviewed by Alex Christensen.
7
8         Added --custom-elements option to enable custom elements support.
9
10         * Scripts/webkitperl/FeatureList.pm:
11
12 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
13
14         [JSC] Add a help message when run-jsc-stress-tests fails
15         https://bugs.webkit.org/show_bug.cgi?id=153014
16
17         Reviewed by Csaba Osztrogonác.
18
19         * Scripts/run-jsc-stress-tests:
20
21 2016-01-11  Saam barati  <sbarati@apple.com>
22
23         run-jsc-stress-tests should try to figure out a JSC path
24         https://bugs.webkit.org/show_bug.cgi?id=152971
25
26         Reviewed by Yusuke Suzuki.
27
28         This patch now allows run-jsc-stress-tests to be run
29         without a "--jsc <jsc-path>" argument. It tries
30         to take its best guess at a <jsc-path> automagically.
31         
32         This makes it much easier to just run run-jsc-stress-tests
33         with a directory or a yaml file as an argument.
34         You now just do this:
35         `run-jsc-stress-tests <path-to-yaml>`
36         or
37         `run-jsc-stress-tests <path-to-directory-of-js-files>`
38         
39         I wrote this patch because I'd often find myself hacking the 
40         run-javascriptcore-tests file just to run a particular subset of tests.
41         Because I always forget the arguments to run-jsc-stress-tests (which means
42         I always forgot to provide a --jsc argument), I always found it easier to 
43         just hack on that file instead of calling run-jsc-stress-tests directly.
44         No longer is this true!
45
46         * Scripts/run-jsc-stress-tests:
47
48 2016-01-09  Andy Estes  <aestes@apple.com>
49
50         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
51         https://bugs.webkit.org/show_bug.cgi?id=152950
52         rdar://problem/24066652
53
54         Reviewed by Tim Horton.
55
56         Added an API test.
57
58         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
59         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
60         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
61         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
62         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
63         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
64         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
65         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
66         (TEST):
67
68 2016-01-11  Commit Queue  <commit-queue@webkit.org>
69
70         Unreviewed, rolling out r194866.
71         https://bugs.webkit.org/show_bug.cgi?id=152986
72
73         This change broke the mac build (Requested by ryanhaddad on
74         #webkit).
75
76         Reverted changeset:
77
78         "[Cocoa] Add SPI to opt out a URL scheme from the memory
79         cache"
80         https://bugs.webkit.org/show_bug.cgi?id=152950
81         http://trac.webkit.org/changeset/194866
82
83 2016-01-11  Andy Estes  <aestes@apple.com>
84
85         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
86         https://bugs.webkit.org/show_bug.cgi?id=152950
87         rdar://problem/24066652
88
89         Reviewed by Tim Horton.
90
91         Added an API test.
92
93         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
94         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
95         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
96         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
97         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
98         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
99         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
100         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
101         (TEST):
102
103 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
104
105         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
106         https://bugs.webkit.org/show_bug.cgi?id=152959
107
108         Reviewed by Brent Fulgham.
109
110         * Scripts/webkitdirs.pm:
111         (determineArchitecture):
112
113 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
114
115         [GTK] W3C CSS2.1 anonymous table tests are failing
116         https://bugs.webkit.org/show_bug.cgi?id=152455
117
118         Reviewed by Mario Sanchez Prada.
119
120         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
121         tests. Add upstream patches to fix detection of XHTML files.
122
123         * gtk/jhbuild.modules:
124         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
125         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
126
127 2016-01-10  Saam barati  <sbarati@apple.com>
128
129         Implement a sampling profiler
130         https://bugs.webkit.org/show_bug.cgi?id=151713
131
132         Reviewed by Filip Pizlo.
133
134         * Scripts/run-jsc-stress-tests:
135
136 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
137
138         [webkitdirs] Try arch and uname commands on non-windows OS
139         https://bugs.webkit.org/show_bug.cgi?id=152958
140
141         Reviewed by Michael Catanzaro.
142
143         Right now, determineArchitecture()  uses `arch` and `uname -m`
144         commands to determine architecture in case of condition (isGtk() ||
145         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
146         instead, because this code is applicable to any non-windows OS WebKit
147         supports (even Haiku which once was supported is moderately
148         POSIX-compliant and has uname command).
149
150         * Scripts/webkitdirs.pm:
151         (determineArchitecture):
152
153 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
154
155         run-webkit-tests mis-counts totals when there are other crashes
156         https://bugs.webkit.org/show_bug.cgi?id=152894
157         <rdar://problem/24098697>
158
159         Reviewed by Alexey Proskuryakov.
160
161         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
162         (TestRunResults.add): Do not update result counters for other crashes.
163
164 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
165
166         webkit-patch build-and-test should have an option to iterate over new tests
167         https://bugs.webkit.org/show_bug.cgi?id=143093
168
169         Reviewed by Michael Catanzaro.
170
171         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
172         It allows running run-webkit-tests on modified or new paths in LayoutTests.
173         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
174         It implements the translation of -expected.* paths to their related tests.
175         It also implements the removal of skipped tests.
176
177         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
178         (LayoutTestFinder.find_touched_tests):
179         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
180         (MockPort):
181         (MockPort.__init__):
182         (MockPort.tests):
183         (LayoutTestFinderTests):
184         (LayoutTestFinderTests.touched_files):
185         (LayoutTestFinderTests.test_touched_test):
186         (LayoutTestFinderTests.test_expected_touched_test):
187         (LayoutTestFinderTests.test_platform_expected_touched_test):
188         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
189         (LayoutTestFinderTests.test_touched_but_skipped_test):
190         * Scripts/webkitpy/port/base.py:
191         (Port.potential_test_names_from_expected_file):
192         * Scripts/webkitpy/tool/commands/download_unittest.py:
193         (DownloadCommandsTest._default_options):
194         * Scripts/webkitpy/tool/steps/options.py:
195         (Options):
196         * Scripts/webkitpy/tool/steps/runtests.py:
197         (RunTests.options):
198         (RunTests.run):
199         (RunTests):
200         (RunTests._new_or_modified_tests):
201         (RunTests._run_webkit_tests):
202         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
203         (RunTestsTest.test_webkit_run_unit_tests):
204         * Scripts/webkitpy/tool/steps/steps_unittest.py:
205         (StepsTest._step_options):
206
207 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
208
209         prepare-ChangeLog should include radar number
210         https://bugs.webkit.org/show_bug.cgi?id=152839
211         <rdar://problem/24093563>
212
213         Reviewed by Daniel Bates.
214
215         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
216         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
217         in the ChangeLog description after the bug URL.
218
219         * Scripts/prepare-ChangeLog:
220         (main): Update signatures.
221         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
222         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
223         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
224         (generateNewChangeLogs): Include radar URL if we found one.
225
226         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
227         Tests for the radar URL extraction.
228
229 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
230
231         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
232         https://bugs.webkit.org/show_bug.cgi?id=152390
233         <rdar://problem/23948321>
234
235         Reviewed by Simon Fraser.
236
237         Fix two use-after-frees.
238
239         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
240         but we may have already progressed to another test by the time the callback fires,
241         having destroyed the TestInvocation.
242         2. UIScriptController is a RefCounted object, but it has a raw pointer to
243         UIScriptContext which has the same lifetime as a TestInvocation.
244         As a result, completion blocks of UIScriptController actions would use a destroyed
245         TestInvocation.
246
247         * WebKitTestRunner/TestInvocation.cpp:
248         (WTR::TestInvocation::~TestInvocation):
249         (WTR::TestInvocation::url):
250         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
251         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
252         (WTR::TestInvocation::runUISideScript):
253         * WebKitTestRunner/TestInvocation.h:
254         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
255         (UIScriptContext::UIScriptContext):
256         (UIScriptContext::~UIScriptContext):
257         (UIScriptContext::runUIScript):
258         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
259         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
260         (WTR::UIScriptController::UIScriptController):
261         (WTR::UIScriptController::contextDestroyed):
262         (WTR::UIScriptController::makeWindowObject):
263         (WTR::UIScriptController::setWillBeginZoomingCallback):
264         (WTR::UIScriptController::willBeginZoomingCallback):
265         (WTR::UIScriptController::setDidEndZoomingCallback):
266         (WTR::UIScriptController::didEndZoomingCallback):
267         (WTR::UIScriptController::setDidEndScrollingCallback):
268         (WTR::UIScriptController::didEndScrollingCallback):
269         (WTR::UIScriptController::setDidShowKeyboardCallback):
270         (WTR::UIScriptController::didShowKeyboardCallback):
271         (WTR::UIScriptController::setDidHideKeyboardCallback):
272         (WTR::UIScriptController::didHideKeyboardCallback):
273         (WTR::UIScriptController::uiScriptComplete):
274         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
275         (WTR::UIScriptController::create):
276         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
277         (WTR::UIScriptController::doAsyncTask):
278         (WTR::UIScriptController::zoomToScale):
279         (WTR::UIScriptController::singleTapAtPoint):
280         (WTR::UIScriptController::doubleTapAtPoint):
281         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
282         (WTR::UIScriptController::contentVisibleRect):
283         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
284         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
285         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
286         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
287         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
288         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
289         (WTR::UIScriptController::doAsyncTask):
290
291 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
292
293         [buildbot] clean-build script should remove untracked files and revert local changes too
294         https://bugs.webkit.org/show_bug.cgi?id=142400
295
296         Reviewed by Ryosuke Niwa.
297
298         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
299         A helper routine SCM.discard_untracked_files is added for that purpose.
300
301         * BuildSlaveSupport/clean-build:
302         (main): Making call to Scripts/clean-webkit
303         * Scripts/clean-webkit: Added.
304         (main): Revert changes and delete untracked files.
305         * Scripts/webkitpy/common/checkout/scm/scm.py:
306         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
307         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
308         (SCMTest._shared_test_discard_untracked_files):
309         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
310
311 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
312
313         Add a setting and preferences to enable display-list drawing. Does nothing yet.
314         https://bugs.webkit.org/show_bug.cgi?id=152807
315
316         Reviewed by Zalan Bujtas.
317         
318         Add an item to the Settings menu to toggle display-list drawing.
319
320         * MiniBrowser/mac/SettingsController.h:
321         * MiniBrowser/mac/SettingsController.m:
322         (-[SettingsController _populateMenu]):
323         (-[SettingsController validateMenuItem:]):
324         (-[SettingsController toggleDisplayListDrawingEnabled:]):
325         (-[SettingsController displayListDrawingEnabled]):
326         * MiniBrowser/mac/WK2BrowserWindowController.m:
327         (-[WK2BrowserWindowController didChangeSettings]):
328
329 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
330
331         Python SCM should be able to retrieve untracked files - Add GIT support
332         https://bugs.webkit.org/show_bug.cgi?id=143135
333
334         Reviewed by Michael Catanzaro.
335
336         * Scripts/webkitpy/common/checkout/scm/git.py:
337         (Git.untracked_files): Adding support for git.
338         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
339         (GitTest.setUp):
340         (GitTest.test_untracked_files): Adding test.
341
342 2016-01-05  Mark Lam  <mark.lam@apple.com>
343
344         Rename badly named JSC_timeout env var to JSCTEST_timeout.
345         https://bugs.webkit.org/show_bug.cgi?id=152748
346
347         Reviewed by Geoffrey Garen.
348
349         Now that we validate JSC options, the badly named JSC_timeout env var causes the
350         bots to have a bad time.
351
352         * Scripts/run-javascriptcore-tests:
353         * Scripts/run-jsc-stress-tests:
354
355 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
356
357         [GTK] Allow to save and restore session
358         https://bugs.webkit.org/show_bug.cgi?id=115600
359
360         Reviewed by Michael Catanzaro.
361
362         Add test case to check the new session API.
363
364         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
365         (testWebKitWebViewSessionState):
366         (testWebKitWebViewSessionStateWithFormData):
367         (beforeAll):
368
369 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
370
371         [EFL] Bump EFL version to 1.16.1
372         https://bugs.webkit.org/show_bug.cgi?id=152688
373
374         Reviewed by Gyuyoung Kim.
375
376         * efl/jhbuild.modules:
377
378 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
379
380         error running layout tests on iOS simulator on latest build
381         https://bugs.webkit.org/show_bug.cgi?id=152719
382         <rdar://problem/24009549>
383
384         Reviewed by Alexey Proskuryakov.
385
386         * Scripts/webkitpy/xcode/simulator.py:
387         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
388           before running simctl spawn command.
389
390 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
391
392         Unreviewed, move Frédéric Wang to committers list
393
394         He seems to be on the contributors list by accident. He has been landing his own commits for
395         about two years now.
396
397         * Scripts/webkitpy/common/config/contributors.json:
398
399 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
400
401         Unreviewed, move Sebastian Dröge to committers list harder
402
403         He accidentally added himself to the reviewers list because the file is confusing. Then I
404         accidentially moved him to the contributors list because the file is confusing, even though
405         I knew the contributors list existed in this file and was attempting to add him to the
406         committers list. Really move him to the committers list now.
407
408         * Scripts/webkitpy/common/config/contributors.json:
409
410 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
411
412         Python SCM should be able to retrieve untracked files - Add SVN support
413         https://bugs.webkit.org/show_bug.cgi?id=152546
414
415         Reviewed by Michael Catanzaro.
416
417         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
418         (test_untracked_files): Activating test for SVN.
419         * Scripts/webkitpy/common/checkout/scm/svn.py:
420         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
421
422 2015-12-31  Andy Estes  <aestes@apple.com>
423
424         Replace WTF::move with WTFMove
425         https://bugs.webkit.org/show_bug.cgi?id=152601
426
427         Reviewed by Brady Eidson.
428
429         * DumpRenderTree/TestRunner.h:
430         (TestRunner::setAllowedHosts):
431         * DumpRenderTree/win/DRTDataObject.cpp:
432         (DRTDataObject::SetData):
433         * TestWebKitAPI/Tests/WTF/Deque.cpp:
434         (TestWebKitAPI::TEST):
435         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
436         (TestWebKitAPI::TEST):
437         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
438         (TestWebKitAPI::TEST):
439         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
440         (TestWebKitAPI::TEST):
441         * TestWebKitAPI/Tests/WTF/Ref.cpp:
442         (TestWebKitAPI::passWithRef):
443         (TestWebKitAPI::TEST):
444         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
445         (TestWebKitAPI::TEST):
446         * TestWebKitAPI/Tests/WTF/Vector.cpp:
447         (TestWebKitAPI::TEST):
448         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
449         (TestWebKitAPI::TEST):
450         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
451         (TestWebKitAPI::TEST):
452         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
453         (TestWebKitAPI::createTestValue):
454         (TestWebKitAPI::TEST):
455         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
456         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
457         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
458         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
459         (TestWebKitAPI::createNFAs):
460         (TestWebKitAPI::TEST_F):
461         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
462         (TestWebKitAPI::combine):
463         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
464         (TestWebKitAPI::createNFAs):
465         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
466         (TEST):
467         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
468         (WebProcessTest::add):
469
470 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
471
472         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
473         https://bugs.webkit.org/show_bug.cgi?id=152634
474
475         Reviewed by Carlos Garcia Campos.
476
477         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
478         (testLoadFromGResource): Added test.
479         (beforeAll):
480         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
481         (registerGResource): Added.
482         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
483         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
484         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
485
486 2015-12-31  David Kilzer  <ddkilzer@apple.com>
487
488         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
489         <https://bugs.webkit.org/show_bug.cgi?id=152601>
490
491         Ignore unknown pragmas on older clangs.  Fixes the following
492         build failure:
493
494             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
495             #pragma clang diagnostic ignored "-Wself-move"
496                                              ^
497             1 error generated.
498
499         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
500         (TestWebKitAPI::TEST):
501         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
502         (TestWebKitAPI::TEST):
503
504 2015-12-31  Andy Estes  <aestes@apple.com>
505
506         Update the style checker to advise using WTFMove() instead of WTF::move()
507         https://bugs.webkit.org/show_bug.cgi?id=152601
508
509         Reviewed by Daniel Bates.
510
511         * Scripts/webkitpy/style/checkers/cpp.py:
512         (check_wtf_move):
513         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
514         (WebKitStyleTest.test_wtf_move):
515
516 2015-12-31  Andy Estes  <aestes@apple.com>
517
518         Fix warnings uncovered by migrating to WTF_MOVE
519         https://bugs.webkit.org/show_bug.cgi?id=152601
520
521         Reviewed by Daniel Bates.
522
523         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
524         self-move, even if doing so would trigger a warning.
525
526         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
527         (TestWebKitAPI::TEST):
528         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
529         (TestWebKitAPI::TEST):
530
531 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
532
533         [GTK] The install-dependencies script has a syntax error
534         https://bugs.webkit.org/show_bug.cgi?id=152613
535
536         Reviewed by Michael Catanzaro.
537
538         * gtk/install-dependencies: Add the missing 'then.'
539
540 2015-12-30  Philippe Normand  <pnormand@igalia.com>
541
542         [Mac][GTK] Jhbuild support for OSX
543         https://bugs.webkit.org/show_bug.cgi?id=150799
544
545         Reviewed by Michael Catanzaro.
546
547         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
548         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
549         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
550         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
551
552 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
553
554         Unreviewed, move Sebastian Dröge to committers list
555
556         He accidentally added himself to the reviewers list because the file is confusing.
557
558         * Scripts/webkitpy/common/config/contributors.json:
559
560 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
561
562         Remove the unused #define _USE_MATH_DEFINES
563         https://bugs.webkit.org/show_bug.cgi?id=152034
564
565         Reviewed by Tim Horton.
566         
567         Update this test to use piDouble from MathExtras.h, and
568         std::numeric_limits<>.
569
570         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
571
572 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
573
574         Python SCM should be able to retrieve untracked files - Generic changes
575         https://bugs.webkit.org/show_bug.cgi?id=152536
576
577         Reviewed by Brent Fulgham.
578
579         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
580         No support is yet added to GIT and SVN specific implementations.
581
582         * Scripts/webkitpy/common/checkout/scm/scm.py:
583         (SCM.untracked_files):
584         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
585         (SCMTest._shared_test_untracked_files):
586
587 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
588
589         SVN checkout used by RunBenchmark should be non-interactive
590         https://bugs.webkit.org/show_bug.cgi?id=152542
591
592         Reviewed by Ryosuke Niwa.
593
594         RunBenchmark should not require user interaction while running.
595
596         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
597         (BenchmarkBuilder._checkout_with_subversion):
598
599 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
600
601         Web Inspector: add support for running protocol-test.js tests on Windows
602         https://bugs.webkit.org/show_bug.cgi?id=148037
603         <rdar://problem/22292237>
604
605         Reviewed by Simon Fraser.
606
607         * DumpRenderTree/win/TestRunnerWin.cpp:
608         (TestRunner::inspectorTestStubURL): Provide implementation.
609
610 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
611
612         [MediaStream] MediaDeviceInfo.label must be empty in some situations
613         https://bugs.webkit.org/show_bug.cgi?id=152000
614
615         Reviewed by Brent Fulgham.
616
617         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
618         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
619         (WTR::InjectedBundle::setUserMediaPermission):
620         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
621         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
622
623         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
624         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
625         * WebKitTestRunner/InjectedBundle/TestRunner.h:
626
627         * WebKitTestRunner/TestController.cpp:
628         (WTR::TestController::setUserMediaPermissionForOrigin):
629         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
630         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
631           persistent permission for origin, that can be done from script now.
632         * WebKitTestRunner/TestController.h:
633
634         * WebKitTestRunner/TestInvocation.cpp:
635         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
636           SetUserMediaPermissionForOrigin.
637
638 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
639
640         [Win] Unreviewed build fix: Recognize Windows 10 variants.
641
642         * Scripts/webkitpy/common/system/platforminfo.py:
643         (PlatformInfo._determine_win_version):
644
645 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
646
647         Content blockers should be able to promote http to https
648         https://bugs.webkit.org/show_bug.cgi?id=148966
649
650         Reviewed by Benjamin Poulain.
651
652         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
653         (WebCore::ContentExtensions::operator<<):
654         (TestWebKitAPI::TEST_F):
655
656 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
657
658         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
659         https://bugs.webkit.org/show_bug.cgi?id=152516
660
661         Reviewed by Gyuyoung Kim.
662
663         * MiniBrowser/efl/main.c:
664
665 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
666
667         Unreviewed: Add John Wilander as a contributor.
668
669         * Scripts/webkitpy/common/config/contributors.json:
670
671 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
672
673         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
674         https://bugs.webkit.org/show_bug.cgi?id=152482
675
676         Reviewed by Brent Fulgham.
677
678         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
679         for the same property. On WK2, the element returned will not be valid, but is still present and
680         that can lead to looping.
681
682         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
683         (AccessibilityUIElement::horizontalScrollbar):
684         (AccessibilityUIElement::verticalScrollbar):
685         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
686         (WTR::AccessibilityUIElement::horizontalScrollbar):
687         (WTR::AccessibilityUIElement::verticalScrollbar):
688
689 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
690
691         Unreviewed.
692
693         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
694
695 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
696
697         [EFL] test_ewk2_context failed after r192808
698         https://bugs.webkit.org/show_bug.cgi?id=151846
699
700         Reviewed by Gyuyoung Kim.
701
702         Used the added ewk_context_web_process_count_limit_set api
703         instead of the deprecated ewk_context_process_model_set.
704
705         * MiniBrowser/efl/main.c:
706         (elm_main):
707
708 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
709
710         Unreviewed, move myself to reviewer list.
711
712         * Scripts/webkitpy/common/config/contributors.json:
713
714 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
715
716         Unreviewed, add myself to the committers list.
717
718         * Scripts/webkitpy/common/config/contributors.json:
719
720 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
721
722         [GTK] jquery.min.js violates DFSG
723         https://bugs.webkit.org/show_bug.cgi?id=152428
724
725         Reviewed by Joseph Pecoraro.
726
727         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
728         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
729
730         * gtk/manifest.txt.in:
731
732 2015-12-19  Dan Bernstein  <mitz@apple.com>
733
734         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
735         https://bugs.webkit.org/show_bug.cgi?id=152462
736
737         Reviewed by Alexey Proskuryakov.
738
739         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
740           OS X 10.9:
741
742         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
743         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
744         * MiniBrowser/Configurations/DebugRelease.xcconfig:
745         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
746         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
747
748         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
749           never getting compiled:
750
751         * DumpRenderTree/mac/TextInputController.m:
752         * MiniBrowser/mac/BrowserWindowController.m:
753         * TestWebKitAPI/Tests/mac/AttributedString.mm:
754         * WebKitTestRunner/mac/EventSenderProxy.mm:
755
756 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
757
758         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
759
760         This is to make it easy to CC it on Bugzilla.
761
762         * Scripts/webkitpy/common/config/contributors.json:
763
764 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
765
766         Pasteboard get messed up after running kill-old-processes
767         https://bugs.webkit.org/show_bug.cgi?id=152426
768
769         Reviewed by Alexey Proskuryakov.
770
771         * BuildSlaveSupport/kill-old-processes:
772         (main): Do not kill pasteboard anymore.
773
774 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
775
776         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
777         https://bugs.webkit.org/show_bug.cgi?id=152157
778         <rdar://problem/23851817>
779
780         Reviewed by Alexey Proskuryakov.
781
782         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
783         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
784         * Scripts/webkitpy/layout_tests/controllers/manager.py:
785         (Manager._get_test_inputs): Common method to calculate test_inputs.
786         (Manager._update_worker_count): Calculate and update required number of workers.
787
788 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
789
790         run-webkit-tests fails to delete Simulator device during cleanup
791         https://bugs.webkit.org/show_bug.cgi?id=152363
792
793         Reviewed by Alexey Proskuryakov.
794
795         * Scripts/webkitpy/xcode/simulator.py:
796         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
797
798 2015-12-16  Tim Horton  <timothy_horton@apple.com>
799
800         [mac-wk2] fast/events force click tests crashing
801         https://bugs.webkit.org/show_bug.cgi?id=152339
802
803         Reviewed by Beth Dakin.
804
805         * WebKitTestRunner/mac/EventSenderProxy.mm:
806         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
807         Set the NSEvent's _type member in addition to overriding -type,
808         because there are assertions in touch event handling code that depend on it.
809
810 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
811
812         Enforce temporarily bots to sync WebKit and WPT testharness.js
813         https://bugs.webkit.org/show_bug.cgi?id=152334
814
815         Reviewed by Darin Adler.
816
817         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
818         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
819
820 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
821
822         [Fetch API] Add fetch API compile time flag
823         https://bugs.webkit.org/show_bug.cgi?id=152254
824
825         Reviewed by Darin Adler.
826
827         * Scripts/webkitperl/FeatureList.pm:
828
829 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
830
831         Unreviewed.
832
833         Added files that have impact in building Streams API to the watchlist.
834
835         * Scripts/webkitpy/common/config/watchlist:
836
837 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
838
839         Unreviewed.
840
841         Added imported tests to Streams API watchlist.
842
843         * Scripts/webkitpy/common/config/watchlist:
844
845 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
846
847         Remove default copy of wpt testharness.js when launching wpt server
848         https://bugs.webkit.org/show_bug.cgi?id=152298
849
850         Reviewed by Darin Adler.
851
852         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
853         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
854
855 2015-12-15  David Kilzer  <ddkilzer@apple.com>
856
857         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
858         <http://webkit.org/b/152314>
859
860         Reviewed by Daniel Bates.
861
862         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
863         code path to exit immediately when calling main().
864         Unfortunately, DumpRenderTreeMain.mm was used for both
865         DumpRenderTree command-line binary and DumpRenderTree.app, which
866         meant that the app would exit immediately with no error code
867         when run!
868
869         The workaround is to introduce a separate source file called
870         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
871         already does.
872
873         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
874         DumpRenderTreeAppMain.mm to the project.  Make it the only
875         compiled source for the DumpRenderTree.app target.
876         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
877         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
878         case someone tries mistakenly to use the app.
879         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
880         Link to JavaScriptCore.framework on iOS for the assert.
881         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
882         Link to JavaScriptCore.framework on OS X for the assert.  Remove
883         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
884         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
885         (main): Add assert for iOS so that a crash occurs if someone
886         tries to run the wrong command.
887
888 2015-12-14  Tim Horton  <timothy_horton@apple.com>
889
890         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
891         https://bugs.webkit.org/show_bug.cgi?id=152266
892         <rdar://problem/22092676>
893
894         Reviewed by Simon Fraser.
895
896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
897         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
898         Add a test that crashed before this change, and doesn't crash after.
899
900 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
901
902         AX: iOS: Text field variations do not have the correct traits
903         https://bugs.webkit.org/show_bug.cgi?id=152237
904
905         Reviewed by Mario Sanchez Prada.
906
907         Add iOS calls for determing if an object is a search field or a text area.
908
909         * DumpRenderTree/AccessibilityUIElement.cpp:
910         (getIsSearchFieldCallback):
911         (getIsTextAreaCallback):
912         (stringForSelectionCallback):
913         (AccessibilityUIElement::getJSClass):
914         * DumpRenderTree/AccessibilityUIElement.h:
915         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
916         (AccessibilityUIElement::identifier):
917         (AccessibilityUIElement::isTextArea):
918         (AccessibilityUIElement::isSearchField):
919         (AccessibilityUIElement::traits):
920         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
921         (WTR::AccessibilityUIElement::scrollPageRight):
922         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
923         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
924         (WTR::AccessibilityUIElement::isSearchField):
925         (WTR::AccessibilityUIElement::isTextArea):
926         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
927         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
928         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
929         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
930         (WTR::AccessibilityUIElement::isTextArea):
931         (WTR::AccessibilityUIElement::isSearchField):
932         (WTR::AccessibilityUIElement::rowCount):
933
934 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
935
936         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
937         https://bugs.webkit.org/show_bug.cgi?id=152252
938
939         Reviewed by Sergio Villar Senin.
940
941         * gtk/install-dependencies: Add libtool-bin to the list of packages required
942         for building the JHBuild on Debian systems.
943
944 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
945
946         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
947         https://bugs.webkit.org/show_bug.cgi?id=152156
948
949         Reviewed by Dan Bernstein.
950
951         Our frameworks should appropriately prefix all ObjC classes,
952         not just external symbols.
953
954         * Scripts/check-for-inappropriate-objc-class-names:
955         Remove the -g switch to check all ObjC class names.
956
957 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
958
959         [MediaStream] Expose media capture devices persistent permissions to WebCore
960         https://bugs.webkit.org/show_bug.cgi?id=152087
961
962         Add support for the new user media permission checker page UI client method.
963
964         Reviewed by Chris Dumez.
965
966         * WebKitTestRunner/TestController.cpp:
967         (WTR::decidePolicyForUserMediaPermissionRequest):
968         (WTR::checkUserMediaPermissionForOrigin):
969         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
970         (WTR::TestController::createWebViewWithOptions): Ditto.
971         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
972         (WTR::originUserVisibleName): New, create a string for the origin.
973         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
974           according to the state of the origin permission map.
975         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
976           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
977         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
978           origin permission map.
979         * WebKitTestRunner/TestController.h:
980
981 2015-12-10  Alex Christensen  <achristensen@webkit.org>
982
983         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
984         https://bugs.webkit.org/show_bug.cgi?id=152022
985         rdar://problem/23763584
986
987         Reviewed by Darin Adler.
988
989         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
990         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
991         (WTR::InjectedBundlePage::willSendRequestForFrame):
992         * WebKitTestRunner/InjectedBundle/TestRunner.h:
993         (WTR::TestRunner::setWillSendRequestReturnsNull):
994         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
995         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
996         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
997         (WTR::TestRunner::willSendRequestHTTPBody):
998         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
999
1000 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1001
1002         Remove additional simulator checks before running layout-tests
1003         https://bugs.webkit.org/show_bug.cgi?id=152146
1004
1005         Reviewed by Darin Adler.
1006
1007         * Scripts/webkitpy/port/ios.py:
1008         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1009         * Scripts/webkitpy/xcode/simulator.py:
1010         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1011         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1012
1013 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1014
1015         Run atleast one simulator even if max process limit is low
1016         https://bugs.webkit.org/show_bug.cgi?id=152081
1017         <rdar://problem/23819694>
1018
1019         Reviewed by Alexey Proskuryakov.
1020
1021 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1022
1023         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1024         https://bugs.webkit.org/show_bug.cgi?id=144262
1025
1026         Reviewed by Carlos Garcia Campos.
1027
1028         Added new unit test to check the additional scenarios we now
1029         handle for custom URI schemes.
1030
1031         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1032         (generateHTMLContent): New helper function to generate big enough content.
1033         (testWebContextURIScheme): New unit test.
1034
1035 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1036
1037         [EFL] Fix unhandled web process message when launching MiniBrowser
1038         https://bugs.webkit.org/show_bug.cgi?id=152048
1039
1040         Reviewed by Gyuyoung Kim.
1041
1042         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1043         (TestWebKitAPI::TEST):
1044
1045 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1046
1047         [GTK] Add API to handle beforeunload events
1048         https://bugs.webkit.org/show_bug.cgi?id=139090
1049
1050         Reviewed by Gustavo Noronha Silva.
1051
1052         * MiniBrowser/gtk/BrowserWindow.c:
1053         (browserWindowConstructed):
1054         (browserWindowDeleteEvent):
1055         (browser_window_class_init):
1056         Handle delete-event to prevent the window from being closed when
1057         the page has beforeunload handlers. Use
1058         webkit_web_view_try_close() when the window is requested to be
1059         closed.
1060         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1061         (testWebViewJavaScriptDialogs):
1062         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1063         script dialog type.
1064
1065 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1066
1067         Refactored initialization code in LoadTrackingTest.
1068
1069         Rubber-stamped by Carlos Garcia Campos.
1070
1071         Small refactoring to make sure that the state of a LoadTrackingTest
1072         gets properly reset before loading new web content.
1073
1074         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1075         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1076         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1077         functions and reset the remaining local variables.
1078         (LoadTrackingTest::loadURI): Call reset();
1079         (LoadTrackingTest::loadHtml): Ditto.
1080         (LoadTrackingTest::loadPlainText): Ditto.
1081         (LoadTrackingTest::loadBytes): Ditto.
1082         (LoadTrackingTest::loadRequest): Ditto.
1083         (LoadTrackingTest::reload): Ditto.
1084         (LoadTrackingTest::goBack): Ditto.
1085         (LoadTrackingTest::goForward): Ditto.
1086
1087 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1088
1089         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1090         https://bugs.webkit.org/show_bug.cgi?id=151942
1091
1092         Reviewed by Darin Adler.
1093
1094         * MiniBrowser/efl/main.c:
1095         (window_create): Enable offline web application cache feature on MiniBrowser.
1096         (elm_main):
1097
1098 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1099
1100         https://bugs.webkit.org/show_bug.cgi?id=151243
1101         <rdar://problem/22955197>
1102
1103         Reviewed by Alexey Proskuryakov.
1104
1105         * LayoutTestRelay/LayoutTestRelay/main.m:
1106         (getTestingSimDevice): Use separate testing device for each worker.
1107         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1108         (Manager.run): Perform cleanup even if setup fails.
1109         * Scripts/webkitpy/port/ios.py:
1110         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1111         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1112         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1113         (IOSSimulatorPort._quit_ios_simulator): Same
1114         (IOSSimulatorPort.clean_up_test_run): Same
1115         (IOSSimulatorPort.check_sys_deps): Same
1116         (IOSSimulatorPort.testing_device): Same
1117         (IOSSimulatorPort.reset_preferences): Same
1118         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1119         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1120         * Scripts/webkitpy/xcode/simulator.py:
1121         (Device.delete): Delete the simulator device.
1122         (Simulator.delete_device): Same
1123         (Simulator.wait_until_device_is_booted): Wait for device booting.
1124
1125 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1126
1127         [EFL] Add API to provide preferences before creating ewk_view
1128         https://bugs.webkit.org/show_bug.cgi?id=151587
1129
1130         Reviewed by Gyuyoung Kim.
1131
1132         * MiniBrowser/efl/main.c:
1133         (on_key_down):
1134         (quit):
1135         (window_create):
1136         Moved settings related code to configuration() not to update settings
1137         whenever ewk_view is created.
1138         (configuration):
1139         (elm_main):
1140
1141 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1142
1143         Unreviewed. Fix GTK+ API tests after r193639.
1144
1145         The new jhbuild version needs some more variables ot be present in
1146         the builtin dict, even if they are set to None.
1147
1148         * jhbuild/jhbuildutils.py:
1149         (enter_jhbuild_environment_if_available):
1150
1151 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1152
1153         [GTK] Notify WebCore when notification is clicked
1154         https://bugs.webkit.org/show_bug.cgi?id=151951
1155
1156         Reviewed by Carlos Garcia Campos.
1157
1158         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1159         (testWebViewNotification): test the new API.
1160
1161 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1162
1163         'jhbuild build' should fail immediately when building any module fails
1164         https://bugs.webkit.org/show_bug.cgi?id=145697
1165
1166         Reviewed by Carlos Garcia Campos.
1167
1168         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1169         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1170         Everything is placed under lib instead of lib64 now.
1171         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1172         --exit-on-error when running 'jhbuild build'.
1173         * jhbuild/jhbuildrc_common.py:
1174         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1175         jhbuild should be able to handle these for us without breaking things....
1176
1177 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1178
1179         Add support to import w3c tests from a repository with a different root that the main repo dir
1180         https://bugs.webkit.org/show_bug.cgi?id=151751
1181
1182         Reviewed by Ryosuke Niwa and Youenn Fablet.
1183
1184         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1185         in a different directory than the repository root.
1186
1187         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1188         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1189         requires having the copy_path lists including tuples of origin and destination directories.
1190
1191         * Scripts/webkitpy/w3c/test_downloader.py:
1192         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1193         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1194         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1195         (TestImporterTest.test_tests_directory): Test.
1196
1197 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1198
1199         Mock TestRepositories in W3C importer tests
1200         https://bugs.webkit.org/show_bug.cgi?id=151938
1201
1202         Reviewed by Youenn Fablet.
1203
1204         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1205         is because the test repository method reading the file was using the filesystem directly instead of taking the
1206         host one. This patch changes that.
1207
1208         * Scripts/webkitpy/w3c/test_downloader.py:
1209         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1210         default one.
1211         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1212         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1213         (TestImporterTest.test_harnesslinks_conversion):
1214         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1215
1216 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1217
1218         TestNetscapePlugIn: Address review comment on 193607
1219         <http://webkit.org/b/151881>
1220
1221         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1222         (testSetStatus): Initializing std::unique_ptr<char[]> with
1223         nullptr is redundant.
1224
1225 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1226
1227         [GTK] Add webkit_uri_request_get_http_method
1228         https://bugs.webkit.org/show_bug.cgi?id=151601
1229
1230         Reviewed by Martin Robinson.
1231
1232         Add test case to check HTTP method of WebKitURIRequest.
1233
1234         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1235         (testURIRequestHTTPMethod):
1236         (serverCallback):
1237         (beforeAll):
1238         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1239         (sendRequestCallback):
1240
1241 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1242
1243         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1244         https://bugs.webkit.org/show_bug.cgi?id=79918
1245
1246         Reviewed by Gustavo Noronha Silva.
1247
1248         Add unit tests to check the different console messages.
1249
1250         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1251         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1252         (ConsoleMessageTest::ConsoleMessage::operator==):
1253         (ConsoleMessageTest::consoleMessageReceivedCallback):
1254         (ConsoleMessageTest::ConsoleMessageTest):
1255         (ConsoleMessageTest::~ConsoleMessageTest):
1256         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1257         (testWebKitConsoleMessageConsoleAPI):
1258         (testWebKitConsoleMessageJavaScriptException):
1259         (testWebKitConsoleMessageNetworkError):
1260         (testWebKitConsoleMessageSecurityError):
1261         (beforeAll):
1262         (afterAll):
1263         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1264         (consoleMessageSentCallback):
1265         (pageCreatedCallback):
1266
1267 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1268
1269         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1270         https://bugs.webkit.org/show_bug.cgi?id=151934
1271
1272         Reviewed by Csaba Osztrogonác.
1273
1274         * MiniBrowser/efl/main.c:
1275         (on_window_deletion): Revert the changes of r192767.
1276
1277 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1278
1279         [GTK] update-webkitgtk-libs cannot build mesa
1280         https://bugs.webkit.org/show_bug.cgi?id=151535
1281
1282         Reviewed by Martin Robinson.
1283
1284         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1285         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1286         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1287         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1288         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1289         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1290
1291         * gtk/jhbuild.modules:
1292
1293 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1294
1295         [GTK][Mac] libWebExtensionTest link error
1296         https://bugs.webkit.org/show_bug.cgi?id=150802
1297
1298         Reviewed by Carlos Garcia Campos.
1299
1300         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1301
1302 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1303
1304         TestNetscapePlugIn: Fix leaks found by static analyzer
1305         <http://webkit.org/b/151881>
1306
1307         Reviewed by Darin Adler.
1308
1309         Fixes the following leaks found by the static analyzer:
1310             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1311                     return false;
1312                            ^~~~~
1313             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1314                     return false;
1315                            ^~~~~
1316             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1317                     return false;
1318                            ^~~~~
1319
1320         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1321         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1322         early return if allocation fails.
1323         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1324         Make sure to call fclose() on filehandle, even for an early
1325         return.
1326         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1327
1328 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1329
1330         prepare-ChangeLog: Fix some warning messages when using svn
1331         <http://webkit.org/b/151914>
1332
1333         Reviewed by Daniel Bates.
1334
1335         * Scripts/prepare-ChangeLog:
1336         (generateFunctionLists): Simplify logic so that we never call
1337         normalizePath() with an undefined value.
1338         (attributeCommand): Quote $subPath for the shell so that we
1339         don't try to run "svn propget" on invalid paths.
1340
1341 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1342
1343         TestNetscapePlugIn: Fix remaining static analyzer warnings
1344         <http://webkit.org/b/151888>
1345
1346         Reviewed by Alexey Proskuryakov.
1347
1348         Fixes the following static analyzer warnings:
1349             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1350                     CRASH();
1351                     ^~~~~~~
1352             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1353                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1354                 ^~~~~~~~~~~~~~~~
1355             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1356                 return obj->pluginTest->NPP_SetWindow(window);
1357                        ^~~~~~~~~~~~~~~
1358             2 warnings generated.
1359
1360         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1361         (CRASH): Use __builtin_trap() for gcc/clang.
1362         (NPP_SetWindow): Add early return if obj is nullptr.
1363
1364 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1365
1366         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1367         https://bugs.webkit.org/show_bug.cgi?id=151797
1368
1369         Reviewed by Martin Robinson.
1370
1371         Since we switched to use the network process to run the unit tests
1372         the test /webkit2/WebKitWebResource/get-data sometimes fails and
1373         sometimes passes. We are now also getting the notification for the
1374         css image. Since we wait for 3 resources, sometimes the css image
1375         is loaded before and then checkResourceData is called for it, but
1376         not handled. When the css image is the last one loaded the test
1377         passes. So, we just need to wait for the 4 resources.
1378
1379         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1380         (testWebResourceGetData):
1381
1382 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1383
1384         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1385         <http://webkit.org/b/151845>
1386
1387         Reviewed by Simon Fraser.
1388
1389         Fixes the following static analyzer warning:
1390             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1391                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1392                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1393
1394         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1395         (createBitmapContext): Free 'buffer' after using it in logging
1396         to fix the use-after-free.  Assign a value of nullptr to buffer
1397         so we don't return with it set to a freed address.
1398
1399 2015-12-03  Jer Noble  <jer.noble@apple.com>
1400
1401         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1402         https://bugs.webkit.org/show_bug.cgi?id=151830
1403
1404         Reviewed by Anders Carlsson.
1405
1406         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1407
1408         * DumpRenderTree/mac/DumpRenderTree.mm:
1409         (resetWebPreferencesToConsistentValues):
1410         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1411         (WTR::initializeWebViewConfiguration):
1412
1413 2015-12-03  Anders Carlsson  <andersca@apple.com>
1414
1415         Remove Objective-C GC support
1416         https://bugs.webkit.org/show_bug.cgi?id=151819
1417         rdar://problem/23746991
1418
1419         Reviewed by Dan Bernstein.
1420
1421         * asan/asan.xcconfig:
1422
1423 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1424
1425         Allow nil for unspecified benchmark pathes
1426         https://bugs.webkit.org/show_bug.cgi?id=151784
1427
1428         Reviewed by Filip Pizlo.
1429
1430         `Pathname.new(nil)` will raise an error.
1431         Only generate Pathname if the benchmark path is specified.
1432
1433         * Scripts/run-jsc-benchmarks:
1434
1435 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1436
1437         [Win] Run non-http tests without Cygwin
1438         https://bugs.webkit.org/show_bug.cgi?id=151721
1439
1440         Reviewed by Andy Estes.
1441
1442         Support native 32-bit and 64-bit Python (and Perl) builds
1443         for running tests:
1444
1445         1. Use "startswith('win')", rather than "== 'win32'" to support
1446         various Windows build types.
1447         2. Supply full path for some native Windows utilities, since the
1448         path environment does not always have the specified, and they are
1449         guaranteed to exist in those specific locations.
1450         3. Make sure native Windows Python test runs pass proper environment
1451         variables to run programs.
1452         4. Append 'exe' suffix when running Windows executables.
1453         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1454         command doesn't exist.
1455         
1456         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1457         the current Perl executable, rather than requiring a new path search.
1458         * Scripts/webkitpy/common/find_files_unittest.py:
1459         (TestWinNormalize.test_win): Use startswith('win').
1460         * Scripts/webkitpy/common/prettypatch_unittest.py:
1461         (test_pretty_diff_encodings): Ditto.
1462         * Scripts/webkitpy/common/system/executive.py:
1463         (Executive._should_close_fds): Ditto.
1464         (Executive.shell_command_for_script): Use startswith('win').
1465         (Executive.kill_process): Use full path to killall executable.
1466         (Executive.check_running_pid): Use startswith('win').
1467         (Executive.running_pids): Ditto.
1468         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1469         running under native Windows Python.
1470         (Executive._child_process_encoding): Use startswith('win').
1471         (Executive._should_encode_child_process_arguments): Ditto.
1472         (Executive.popen): Recognize proper script engine on Windows, since it
1473         does not support the shebang syntax.
1474         (Executive.run_in_parallel): Use startswith('win').
1475         * Scripts/webkitpy/common/system/executive_unittest.py:
1476         (never_ending_command): Ditto.
1477         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1478         (ExecutiveTest.serial_test_kill_process): Ditto.
1479         (ExecutiveTest.serial_test_kill_all): Ditto.
1480         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1481         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1482         (main): Ditto.
1483         * Scripts/webkitpy/common/system/file_lock.py:
1484         (FileLock._create_lock): Ditto.
1485         (FileLock._remove_lock): Ditto.
1486         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1487         (RealFileSystemTest.test_chdir): Ditto.
1488         (RealFileSystemTest.test_chdir__notexists): Ditto.
1489         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1490         * Scripts/webkitpy/common/system/path_unittest.py:
1491         (AbspathTest.test_abspath_to_uri_win): Ditto.
1492         * Scripts/webkitpy/common/system/platforminfo.py:
1493         (PlatformInfo._determine_os_name): Ditto.
1494         * Scripts/webkitpy/common/system/user.py: Ditto.
1495         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1496         (ManagerTest.integration_test_needs_servers): Ditto.
1497         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1498         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1499         driver letters.
1500         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1501         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1502         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1503         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1504         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1505         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1506         (TestHttpServer.test_start_cmd): Ditto.
1507         * Scripts/webkitpy/port/base.py:
1508         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1509         and 'SYSTEMROOT' in environment passed to test runners.
1510         (Port._apache_config_file_name_for_platform): Use startswith('win').
1511         (Port._build_path): Ditto.
1512         (Port._path_to_driver): Include 'exe' suffix when running under native
1513         Windows.
1514         * Scripts/webkitpy/port/driver.py:
1515         (Driver._setup_environ_for_driver): Explicitly make some environment
1516         variables strings.
1517         * Scripts/webkitpy/port/server_process.py:
1518         (ServerProcess.__init__): Use startswith('win').
1519         * Scripts/webkitpy/port/win.py:
1520         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1521         registry key formats.
1522         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1523         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1524         and regtool on Cygwin.
1525         (WinPort.write_registry_value): Ditto.
1526         (WinPort.setup_crash_log_saving): Ditto.
1527         (WinPort.restore_crash_log_saving): Ditto.
1528         (WinPort.prevent_error_dialogs): Ditto.
1529         (WinPort.allow_error_dialogs): Ditto.
1530         (WinPort.find_system_pid): Revise to use Windows management
1531         infrastructure on native Windows, continue using 'ps' on Cygwin.
1532         (WinPort.read_registry_string): Deleted.
1533         (WinPort.write_registry_string): Deleted.
1534         * Scripts/webkitpy/test/main.py:
1535         (main): Use startswith('win').
1536         (Tester._parse_args): Ditto.
1537
1538 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1539
1540         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1541         https://bugs.webkit.org/show_bug.cgi?id=150792
1542
1543         Reviewed by Saam Barati.
1544
1545         * Scripts/webkitperl/FeatureList.pm:
1546
1547 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1548
1549         Unreviewed, rolling out r192914.
1550         https://bugs.webkit.org/show_bug.cgi?id=151734
1551
1552         JSC tests for this change are failing on 32 and 64-bit bots
1553         (Requested by ryanhaddad on #webkit).
1554
1555         Reverted changeset:
1556
1557         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1558         enable this feature"
1559         https://bugs.webkit.org/show_bug.cgi?id=150792
1560         http://trac.webkit.org/changeset/192914
1561
1562 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1563
1564         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1565         <http://webkit.org/b/151726>
1566
1567         Reviewed by Simon Fraser.
1568
1569         * WebKitTestRunner/mac/EventSenderProxy.mm:
1570         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1571         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1572
1573 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1574
1575         Give String and AtomicString an existingHash() function
1576         https://bugs.webkit.org/show_bug.cgi?id=151717
1577
1578         Reviewed by Andreas Kling.
1579
1580         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1581         (TestWebKitAPI::TEST):
1582         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1583         (TestWebKitAPI::TEST):
1584
1585 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1586
1587         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1588         https://bugs.webkit.org/show_bug.cgi?id=150792
1589
1590         Reviewed by Saam Barati.
1591
1592         * Scripts/webkitperl/FeatureList.pm:
1593
1594 2015-12-01  Sam Weinig  <sam@webkit.org>
1595
1596         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1597         <rdar://problem/23320863>
1598         https://bugs.webkit.org/show_bug.cgi?id=151708
1599
1600         Reviewed by Anders Carlsson.
1601
1602         * WebKitTestRunner/TestController.cpp:
1603         (WTR::TestController::createOtherPage):
1604         (WTR::TestController::createWebViewWithOptions):
1605         Update for new WKPageUIClient.
1606
1607 2015-12-01  Anders Carlsson  <andersca@apple.com>
1608
1609         Remove WebKit2.framework
1610         https://bugs.webkit.org/show_bug.cgi?id=151715
1611
1612         Reviewed by Dan Bernstein.
1613
1614         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1615         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1616         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1617         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1618         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1619         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1620         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1621
1622 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
1623
1624         Unreviewed common typo fix "occurance" => "occurrence".
1625
1626         * Scripts/webkitpy/tool/commands/queries.py:
1627         (FindFlakyTests._print_statistics):
1628
1629 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1630
1631         Make ProcessModel always MultipleSecondaryProcesses
1632         https://bugs.webkit.org/show_bug.cgi?id=151662
1633
1634         Reviewed by Antti Koivisto.
1635
1636         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1637         (TestWebKitAPI::TEST):
1638         * WebKitTestRunner/TestController.cpp:
1639         (WTR::TestController::generatePageConfiguration):
1640
1641 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1642
1643         Make usesNetworkProcess always true
1644         https://bugs.webkit.org/show_bug.cgi?id=151580
1645
1646         Reviewed by Darin Adler.
1647
1648         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1649         (TestWebKitAPI::TEST):
1650         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1651         (TestWebKitAPI::TEST):
1652         * WebKitTestRunner/TestController.cpp:
1653         (WTR::TestController::generatePageConfiguration):
1654
1655 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1656
1657         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1658
1659         Add a way to skip unit tests only for Debug or Release builds and
1660         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1661
1662         * Scripts/run-gtk-tests:
1663         (SkippedTest):
1664         (SkippedTest.__init__):
1665         (SkippedTest.__str__):
1666         (SkippedTest.skip_entire_suite):
1667         (SkippedTest.skip_for_build_type):
1668         (TestRunner):
1669         (TestRunner.__init__):
1670
1671 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1672
1673         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
1674
1675         It's an assert hit because we are reloading a view loaded with
1676         HTML data which is not supported. Use loadURI instead.
1677
1678         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1679         (testWebViewCustomCharset):
1680
1681 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1682
1683         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
1684         https://bugs.webkit.org/show_bug.cgi?id=151633
1685
1686         Reviewed by Csaba Osztrogonác.
1687
1688         * TestWebKitAPI/PlatformGTK.cmake:
1689         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
1690
1691 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1692
1693         [GTK] Remove the remaining uses of GMainLoopSource
1694         https://bugs.webkit.org/show_bug.cgi?id=151632
1695
1696         Reviewed by Žan Doberšek.
1697
1698         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1699         (testWebViewSyncRequestOnMaxConns):
1700         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1701         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1702         (WTR::TestRunner::TestRunner):
1703         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1704         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1705         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1706         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1707         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1708         (WTR::timeoutSource):
1709         (WTR::TestController::notifyDone):
1710         (WTR::TestController::platformRunUntil):
1711
1712 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1713
1714         [cmake] Add testb3 to the build system
1715         https://bugs.webkit.org/show_bug.cgi?id=151619
1716
1717         Reviewed by Gyuyoung Kim.
1718
1719         * Scripts/build-jsc:
1720
1721 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1722
1723         [jhbuild] Fix pixman build with clang
1724         https://bugs.webkit.org/show_bug.cgi?id=151441
1725
1726         Reviewed by Carlos Garcia Campos.
1727
1728         * efl/jhbuild.modules:
1729         * gtk/jhbuild.modules:
1730
1731 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1732
1733         Extract prependToEnvironmentVariableList
1734         <http://webkit.org/b/151536>
1735
1736         Reviewed by Daniel Bates.
1737
1738         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1739                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1740
1741         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1742         and prependToEnvironmentVariableList.
1743         (appendToEnvironmentVariableList): Simplify variable name.
1744         Switch to use $Config{path_sep}.
1745         (prependToEnvironmentVariableList): Add new method.
1746         (setupMacWebKitEnvironment): Switch to use
1747         prependToEnvironmentVariableList().
1748         (setupIOSWebKitEnvironment): Ditto.
1749
1750         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1751         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1752
1753 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1754
1755         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1756         https://bugs.webkit.org/show_bug.cgi?id=151567
1757
1758         Reviewed by Darin Adler.
1759
1760         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1761         (on_window_deletion):
1762
1763 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1764
1765         [GTK] Use the network process unconditionally
1766         https://bugs.webkit.org/show_bug.cgi?id=151541
1767
1768         Reviewed by Alex Christensen.
1769
1770         Fix TestInspectorServer test. Do not assume we already have the
1771         title we want when the page has been loaded, since the title is
1772         changed afterwards. So, check if the title has already been set,
1773         and if not wait for it.
1774
1775         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1776         (openRemoteDebuggingSession):
1777
1778 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1779
1780         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1781         https://bugs.webkit.org/show_bug.cgi?id=151532
1782
1783         Reviewed by Benjamin Poulain.
1784
1785         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1786         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1787         (TestWebKitAPI::TEST):
1788         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1789         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
1790         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
1791         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
1792         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
1793         so it was calling a function on a test object that had gone out of scope.
1794         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
1795         but that will become the default soon and that call will be removed.
1796
1797 2015-11-22  David Kilzer  <ddkilzer@apple.com>
1798
1799         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
1800         <http://webkit.org/b/151542>
1801
1802         Reviewed by Daniel Bates.
1803
1804         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1805         (base_url): Use the Port object (already passed in) to give us
1806         the path to the LayoutTests directory, which already checks for a
1807         --layout-tests-directory command-line switch.
1808         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
1809         argument since we can get this from the Port object already
1810         passed in via Port.results_directory().  Also switch to use
1811         Port.layout_tests_dir() to get the LayoutTests directory.
1812
1813         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1814         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
1815         Add test case for custom LayoutTests directory.
1816         (TestWebPlatformTestServer.test_previously_spawned_instance):
1817         Update Port object to set mock results directory as if it was
1818         set on the command-line.  Remove unneeded argument from
1819         WebPlatformTestServer constructor.
1820         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
1821
1822         * Scripts/webkitpy/port/base.py:
1823         (Port.to.start_web_platform_test_server): Remove unneeded
1824         argument from WebPlatformTestServer constuctor.
1825
1826 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1827
1828         [GTK] Some unit tests fail when using the network process
1829         https://bugs.webkit.org/show_bug.cgi?id=151490
1830
1831         Reviewed by Martin Robinson.
1832
1833         Run the soup server in a separate thread in TestResources test to
1834         avoid deadlocks.
1835
1836         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1837         /webkit2/WebKitWebResource/get-data when using the network process.
1838
1839         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1840         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1841         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1842         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1843         present, create a WorkQueue to run the server.
1844         (WebKitTestServer::run): Run the server in the work queue if it
1845         has been created.
1846         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1847         type into server options as flags.
1848
1849 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1850
1851         [GTK] ImageDiff should normalize the diff image
1852         https://bugs.webkit.org/show_bug.cgi?id=151261
1853
1854         Reviewed by Sergio Villar Senin.
1855
1856         * ImageDiff/gtk/ImageDiff.cpp:
1857         (readPixbufFromStdin): Fix memory leak.
1858         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1859         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1860
1861 == Rolled over to ChangeLog-2015-11-21 ==