1 2017-08-04 Carlos Alberto Lopez Perez <clopez@igalia.com>
3 REGRESSION(r219857): run-benchmark --allplans broken
4 https://bugs.webkit.org/show_bug.cgi?id=175186
6 Reviewed by Saam Barati.
8 r219857 forgot to update also the calls to BenchmarkRunner() that
9 is done when the script is run with --allplans.
11 To fix this (and avoid future issues like this), let's factorize
12 the calls to the benchhmark runner in a run_benchmark_plan()
15 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
19 2017-08-04 Aakash Jain <aakash_jain@apple.com>
21 Dashboard bubbles sometimes show failure count instead of crash count
22 https://bugs.webkit.org/show_bug.cgi?id=175157
23 <rdar://problem/33709009>
25 Reviewed by Alexey Proskuryakov.
27 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
28 (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
30 2017-08-04 Joseph Pecoraro <pecoraro@apple.com>
32 Add tests for NeverDestroyed
33 https://bugs.webkit.org/show_bug.cgi?id=175146
35 Reviewed by Darin Adler.
38 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
41 * TestWebKitAPI/Tests/WTF/Logger.h:
42 * TestWebKitAPI/Tests/WTF/Logger.cpp:
44 (TestWebKitAPI::takeLogStr):
45 * TestWebKitAPI/Tests/WTF/RefLogger.h:
46 * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
47 (TestWebKitAPI::log): Deleted.
48 (TestWebKitAPI::takeLogStr): Deleted.
49 Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
51 * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
52 * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
53 (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
54 (TestWebKitAPI::LifecycleLogger::operator=):
55 (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
56 (TestWebKitAPI::LifecycleLogger::setName):
57 (TestWebKitAPI::TEST):
58 Add a class that logs construction / assignment / modifications.
60 * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
61 (TestWebKitAPI::TEST):
62 (TestWebKitAPI::list):
63 Test construction behavior is as expected both directly and using makeNeverDestroyed.
65 2017-08-04 Lucas Forschler <lforschler@apple.com>
67 minification logic is not implemented for ios builds
68 <rdar://problem/33726561>
70 Reviewed by Dean Johnson
72 * BuildSlaveSupport/built-product-archive:
73 (minifyDirectory): refactor minifySource -> minifyDirectory
74 (archiveBuiltProduct): add ios minification logic
75 (minifySource): Deleted.
77 2017-08-04 Matt Lewis <jlewis3@apple.com>
79 Unreviewed, rolling out r220271.
81 Rolling out due to Layout Test failing on iOS Simulator.
85 "Remove STREAMS_API compilation guard"
86 https://bugs.webkit.org/show_bug.cgi?id=175165
87 http://trac.webkit.org/changeset/220271
89 2017-08-04 Ryan Haddad <ryanhaddad@apple.com>
91 Unreviewed, rolling out r220268.
93 This change caused assertion failures on macOS and iOS Debug
98 "Resource Load Statistics: Report user interaction
99 immediately, but only when needed"
100 https://bugs.webkit.org/show_bug.cgi?id=175090
101 http://trac.webkit.org/changeset/220268
103 2017-08-04 Youenn Fablet <youenn@apple.com>
105 Remove STREAMS_API compilation guard
106 https://bugs.webkit.org/show_bug.cgi?id=175165
108 Reviewed by Darin Adler.
110 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
112 2017-08-04 John Wilander <wilander@apple.com>
114 Resource Load Statistics: Report user interaction immediately, but only when needed
115 https://bugs.webkit.org/show_bug.cgi?id=175090
116 <rdar://problem/33685546>
118 Reviewed by Chris Dumez.
120 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
121 (WTR::InjectedBundle::beginTesting):
122 Now calls WebCore::ResourceLoadObserver::clearState().
124 2017-08-03 Brian Burg <bburg@apple.com>
126 Remove ENABLE(WEB_SOCKET) guards
127 https://bugs.webkit.org/show_bug.cgi?id=167044
129 Reviewed by Joseph Pecoraro.
131 * Scripts/webkitperl/FeatureList.pm:
132 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
134 2017-08-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
136 REGRESSION(r219850): run-benchmark script broken on Linux
137 https://bugs.webkit.org/show_bug.cgi?id=175126
139 Reviewed by Stephanie Lewis.
141 The run-benchmark script dynamically generates the list of supported
142 browsers and platforms (currently Linux and OSX) by loading all
143 python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
144 and getting the browser_name and platform variables from the
145 classes defined there.
147 This means that this classes should not raise an exception when
148 loaded on other platforms or otherwise they will broke the whole
149 script. Its fine if they raise an exception when executing any of
150 the methods they implement, but not when just loading/importing
153 Move the argument variable definitions that call on the platform
154 specific OSXBrowserDriver._screen_size() function from beeing
155 variables that are evaluated when loading the file, to be functions
156 that are only evaluated when the actual functionality needs to be
159 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
160 (OSXChromeDriver.launch_url):
161 (OSXChromeCanaryDriver.launch_url):
163 (create_chrome_options):
164 (create_window_size_arg):
165 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
166 (OSXFirefoxDriver.launch_url):
167 (OSXFirefoxNightlyDriver.launch_url):
168 (OSXFirefoxNightlyDriver.launch_driver):
171 2017-08-03 Yoshiaki Jitsukawa <jitsu@rd.scei.sony.co.jp>
173 [PAL] Move spi/cf directory into PAL
174 https://bugs.webkit.org/show_bug.cgi?id=175057
176 Reviewed by Antti Koivisto.
178 * Scripts/webkitpy/style/checker.py:
179 * Scripts/webkitpy/style/checker_unittest.py:
180 (GlobalVariablesTest.test_path_rules_specifier):
182 Ignore "readability/naming/underscores" style errors for sources
183 under the WebCore/PAL/pal/spi directory.
185 * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
187 2017-08-03 Youenn Fablet <youenn@apple.com>
189 Remove FETCH_API compilation guard
190 https://bugs.webkit.org/show_bug.cgi?id=175154
192 Reviewed by Chris Dumez.
194 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
196 2017-08-03 Lucas Forschler <lforschler@apple.com>
198 Enable archive minification on iOS builds
199 https://bugs.webkit.org/show_bug.cgi?id=174718
201 Reviewed by Aakash Jain.
203 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
204 (BuildFactory.__init__):
206 2017-08-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
208 [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
209 https://bugs.webkit.org/show_bug.cgi?id=175140
211 Reviewed by Alexey Proskuryakov.
213 We are having lately issues with JSC tests causing problems on
214 the GTK+ and WPE bots due to the high amount of memory some tests
217 The best thing we can do now is to workaround this by disabling
218 all the tests marked as memoryLimited on the GTK and WPE bots.
219 We may revise this on the future.
221 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
222 (RunJavaScriptCoreTests.start):
224 2017-08-03 Brady Eidson <beidson@apple.com>
226 Add SW IDLs and stub out basic functionality.
227 https://bugs.webkit.org/show_bug.cgi?id=175115
229 Reviewed by Chris Dumez.
231 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
233 * Scripts/webkitpy/bindings/main.py:
235 2017-08-03 Per Arne Vollan <pvollan@apple.com>
237 [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
238 https://bugs.webkit.org/show_bug.cgi?id=159510
240 Reviewed by Daniel Bates.
242 Allow any https certificate when running tests.
244 * DumpRenderTree/win/DumpRenderTree.cpp:
247 2017-08-02 Youenn Fablet <youenn@apple.com>
249 HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
250 https://bugs.webkit.org/show_bug.cgi?id=175089
252 Reviewed by Chris Dumez.
254 * DumpRenderTree/TestOptions.mm:
255 (TestOptions::TestOptions): Using absolutePath if available.
256 * DumpRenderTree/mac/DumpRenderTree.mm:
257 (computeTestURL): Removing http/tests/ specific URL computation.
258 * Scripts/webkitpy/port/driver.py:
259 (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
261 2017-08-02 Lucas Forschler <lforschler@apple.com>
263 download-built-product should allow for a proxy option
264 https://bugs.webkit.org/show_bug.cgi?id=174875
266 Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
268 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
269 (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
272 2017-08-02 Jonathan Bedard <jbedard@apple.com>
274 check-webkit-style: deleting lines in a file runs the linter on the whole file
275 https://bugs.webkit.org/show_bug.cgi?id=175078
277 Reviewed by David Kilzer.
279 Deleting lines in a file should not cause linter errors to be blamed on the patch.
280 <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
282 * Scripts/webkitpy/style/checkers/test_expectations.py:
283 (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
284 * Scripts/webkitpy/style/main_unittest.py:
285 (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
286 (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
287 (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
289 2017-08-02 Jonathan Bedard <jbedard@apple.com>
291 webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
292 https://bugs.webkit.org/show_bug.cgi?id=175075
294 Reviewed by David Kilzer.
296 We have no way of handling text files with illegal unicode characters. Allow the callers of
297 filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
298 'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
300 * Scripts/webkitpy/common/system/filesystem.py:
301 (FileSystem.read_text_file): Allow caller to specify unicode error handling.
302 (FileSystem.write_text_file): Ditto.
303 * Scripts/webkitpy/common/system/filesystem_mock.py:
304 (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
305 (MockFileSystem.write_text_file): Ditto.
306 * Scripts/webkitpy/common/system/filesystem_unittest.py:
307 (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
308 (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
310 2017-08-02 Aakash Jain <aakash_jain@apple.com>
312 Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
313 https://bugs.webkit.org/show_bug.cgi?id=175072
315 Reviewed by Alexey Proskuryakov.
317 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
318 (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
320 2017-08-02 Michael Catanzaro <mcatanzaro@igalia.com>
322 [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
323 https://bugs.webkit.org/show_bug.cgi?id=175019
325 Reviewed by Darin Adler.
327 * TestWebKitAPI/CMakeLists.txt:
329 2017-08-01 Csaba Osztrogonác <ossy@webkit.org>
331 Enabling uploading archives to S3
332 https://bugs.webkit.org/show_bug.cgi?id=174198
334 Unreviewed unit test fix after r219235.
336 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
338 2017-08-01 Csaba Osztrogonác <ossy@webkit.org>
340 Fix JSCOnly ARM buildbots after r220047
341 https://bugs.webkit.org/show_bug.cgi?id=174993
343 Unreviewed fix after r220087.
345 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
346 (BuildAndRemoteJSCTestsFactory.__init__):
348 2017-08-01 Chris Dumez <cdumez@apple.com>
350 Add initial support for navigator.sendBeacon
351 https://bugs.webkit.org/show_bug.cgi?id=175007
352 <rdar://problem/33547728>
354 Reviewed by Sam Weinig.
356 Enable the Beacon API at runtime in the context of layout tests since the
357 feature is currently disabled by default.
359 * DumpRenderTree/mac/DumpRenderTree.mm:
360 (enableExperimentalFeatures):
361 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
362 (WTR::InjectedBundle::beginTesting):
363 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
364 (WTR::TestRunner::setModernMediaControlsEnabled):
365 (WTR::TestRunner::setBeaconAPIEnabled):
366 * WebKitTestRunner/InjectedBundle/TestRunner.h:
368 2017-08-01 Aakash Jain <aakash_jain@apple.com>
370 Update Bot Watcher's Dashboard for Buildbot 0.9
371 https://bugs.webkit.org/show_bug.cgi?id=174777
373 Reviewed by Daniel Bates.
375 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
376 (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
377 (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
379 (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
380 builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
381 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
382 (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
383 (parseRevisionProperty): Ditto.
384 (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
385 Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
386 (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
387 have changed in Buildbot 0.9.
388 (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
389 (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls,
390 one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
391 (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
392 (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
393 (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
394 (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
395 (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
396 (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
397 (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
398 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
399 (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
400 (BuildbotQueue.prototype.get allIterationsURL): Ditto.
401 (BuildbotQueue.prototype.get overviewURL): Ditto.
402 (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
403 (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
405 (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
406 fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
407 (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
408 (BuildbotQueue.prototype.getIterationID): Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
409 (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds.
410 Therefore we are fetching information for fixed number of build.
411 Also iterating the loop incrementally since the build data is already reverse sorted.
412 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
413 (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
414 need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
415 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
416 (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
418 2017-08-01 Devin Rousso <drousso@apple.com>
420 Web Inspector: simplify WebInspector with WI
421 https://bugs.webkit.org/show_bug.cgi?id=175058
423 Reviewed by Joseph Pecoraro.
425 * Scripts/check-inspector-strings:
426 (extract_ui_strings):
427 * Scripts/extract-localizable-js-strings:
429 2017-08-01 Youenn Fablet <youenn@apple.com>
431 Layout tests with 'https' suffix should be run over HTTPS
432 https://bugs.webkit.org/show_bug.cgi?id=174992
434 Reviewed by Chris Dumez.
436 Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
437 This covers WPT tests, WPT WebKit tests and HTTP layout tests.
438 Covered by corresponding unit tests.
440 * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
442 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
446 * Scripts/webkitpy/port/base.py:
447 (Port.to.web_platform_test_server_base_http_url):
449 (Port.to.web_platform_test_server_base_https_url):
450 (Port.to.web_platform_test_server_base_url): Deleted.
451 * Scripts/webkitpy/port/driver.py:
453 (Driver.wpt_test_path_to_uri):
455 (Driver.http_test_path_to_uri):
456 (Driver.test_to_uri):
457 (Driver.uri_to_test):
458 * Scripts/webkitpy/port/driver_unittest.py:
459 (DriverTest.test_test_to_uri):
460 (DriverTest.test_uri_to_test):
462 2017-07-26 Jiewen Tan <jiewen_tan@apple.com>
464 Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
465 https://bugs.webkit.org/show_bug.cgi?id=173998
467 Reviewed by Darin Adler.
469 Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
470 detect mistakes in backward compatibility in the future when we change it.
472 The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
473 Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
474 ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
475 SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
476 DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
477 internal key data slot.
479 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
480 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
481 (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
484 Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
485 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
486 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
487 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
488 These are the pre-baked databases.
489 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
490 This is the actual test that do all the reads and comparisons.
491 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
492 This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
493 IndexedDB new stuffs. Then it can be used to bake the database again.
495 2017-08-01 Brady Eidson <beidson@apple.com>
497 API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
498 https://bugs.webkit.org/show_bug.cgi?id=175030
500 Reviewed by Andy Estes.
502 * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
503 (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
505 2017-08-01 Brady Eidson <beidson@apple.com>
507 Part 2 of: Rename DatabaseProcess to StorageProcess.
508 https://bugs.webkit.org/show_bug.cgi?id=174880
510 Reviewed by Andy Estes.
512 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
513 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
514 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
515 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
516 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
517 * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
518 * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
519 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
521 2017-07-31 Csaba Osztrogonác <ossy@webkit.org>
523 Fix JSCOnly ARM buildbots after r220047
524 https://bugs.webkit.org/show_bug.cgi?id=174993
526 Reviewed by Saam Barati.
528 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
529 (BuildAndRemoteJSCTestsFactory.__init__):
531 2017-07-30 Yusuke Suzuki <utatane.tea@gmail.com>
533 [WTF] Introduce Private Symbols
534 https://bugs.webkit.org/show_bug.cgi?id=174935
536 Reviewed by Darin Adler.
538 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
539 (TestWebKitAPI::TEST):
541 2017-07-30 Darin Adler <darin@apple.com>
543 Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
544 https://bugs.webkit.org/show_bug.cgi?id=130653
546 Reviewed by Antti Koivisto.
548 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
549 (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
550 when calling frameDidChangeLocation.
551 (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
552 causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
553 thus causing mysterious failures of a couple of tests. There are two remaining issues:
554 1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
555 consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
556 same logic flaw that causes "top loading frame" to get set to one of the subframes in
557 tests where the following sequence occurs: test calls waitUntilDone, main frame finishes
558 loading, subframe starts loading. It would be good to clean that up some day, but for now
559 this patch makes the two work identically rather than changing both.
560 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
562 2017-07-30 Wenson Hsieh <wenson_hsieh@apple.com>
564 [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
565 https://bugs.webkit.org/show_bug.cgi?id=174963
567 Reviewed by Darin Adler.
569 Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
570 RetainPtr<>. This patch changes them to all use auto.
572 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
573 (TestWebKitAPI::TEST):
575 2017-07-30 Brady Eidson <beidson@apple.com>
577 Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
578 https://bugs.webkit.org/show_bug.cgi?id=174958
580 Reviewed by Darin Adler.
582 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
583 * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
584 (-[LeakSchemeHandler webView:startURLSchemeTask:]):
585 (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
586 (runUntilTasksInFlight):
589 2017-07-28 Commit Queue <commit-queue@webkit.org>
591 Unreviewed, rolling out r219990.
592 https://bugs.webkit.org/show_bug.cgi?id=174961
594 "broke PLT on iOS (rdar://problem/33602751)" (Requested by
599 "Part 2 of: Rename DatabaseProcess to StorageProcess."
600 https://bugs.webkit.org/show_bug.cgi?id=174880
601 http://trac.webkit.org/changeset/219990
603 2017-07-28 Brady Eidson <beidson@apple.com>
605 API tests that use URLSchemeHandler are failing.
606 https://bugs.webkit.org/show_bug.cgi?id=174950
608 Reviewed by Alex Christensen.
610 Fix the NoMIMEType test to be correct.
612 * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
613 (-[SchemeHandler initWithData:mimeType:]):
614 (-[SchemeHandler webView:startURLSchemeTask:]):
617 2017-07-28 Daniel Bates <dabates@apple.com>
619 prepare-ChangeLog should not list added layout tests in PAL ChangeLog
620 https://bugs.webkit.org/show_bug.cgi?id=174876
622 Reviewed by Alex Christensen.
624 Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
625 to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
626 they provide a more direct way to test the platform abstraction.
628 As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
630 * Scripts/prepare-ChangeLog:
631 (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
632 of the current working directory.
634 2017-07-28 Jonathan Bedard <jbedard@apple.com>
636 Using "auto <function()> -> returnType" breaks prepare-ChangeLog
637 https://bugs.webkit.org/show_bug.cgi?id=174930
641 We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog.
643 * Scripts/prepare-ChangeLog:
644 (get_function_line_ranges_for_cpp):
646 2017-07-28 JF Bastien <jfbastien@apple.com>
648 Using "auto <function()> -> returnType" breaks prepare-ChangeLog
649 https://bugs.webkit.org/show_bug.cgi?id=174930
651 Reviewed by Daniel Bates.
653 Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
654 here also teach it about const and volatile overloads. I didn't do
655 reference and rvalue reference overloads because we don't really
656 use them, and the current parser throws away those characters and
657 it doesn't seem worth making it more complex.
659 * Scripts/prepare-ChangeLog:
660 (get_function_line_ranges_for_cpp):
661 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
662 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
664 (Foo::Arrow::otherArrow):
665 (Foo::Arrow::otherArrow const):
666 (Foo::Arrow::otherArrow volatile):
667 (Foo::Arrow::otherArrow const volatile):
669 2017-07-28 Adrian Perez de Castro <aperez@igalia.com>
671 [GTK] Building with ENABLE_VIDEO=OFF fails
672 https://bugs.webkit.org/show_bug.cgi?id=174940
674 Reviewed by Alex Christensen.
676 When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
677 This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
679 * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
680 (methodCallCallback): Add missing USE(GSTREAMER) guard.
682 2017-07-28 Claudio Saavedra <csaavedra@igalia.com>
684 [WPE] Implement EventSenderProxy in WTR
685 https://bugs.webkit.org/show_bug.cgi?id=173419
687 Reviewed by Žan Doberšek.
689 Add the implementation of EventSenderProxy to the WTR. This
690 allows us to extend the coverage of the test suite in WKWPE.
692 * WebKitTestRunner/EventSenderProxy.h:
693 * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
694 libxkbcommon needed to deal with key events.
695 * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
696 (WTR::EventSenderProxy::EventSenderProxy):
697 (WTR::senderButtonToWPEButton):
698 (WTR::EventSenderProxy::mouseDown):
699 (WTR::EventSenderProxy::mouseUp):
700 (WTR::EventSenderProxy::mouseMoveTo):
701 (WTR::EventSenderProxy::mouseScrollBy):
702 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
703 (WTR::EventSenderProxy::leapForward):
704 (WTR::wkEventModifiersToWPE):
705 (WTR::getXKBKeySymForKeyRef):
706 (WTR::EventSenderProxy::keyDown):
707 (WTR::EventSenderProxy::addTouchPoint):
708 (WTR::EventSenderProxy::updateTouchPoint):
709 (WTR::EventSenderProxy::setTouchModifier):
710 (WTR::EventSenderProxy::setTouchPointRadius):
711 (WTR::EventSenderProxy::getUpdatedTouchEvents):
712 (WTR::EventSenderProxy::removeUpdatedTouchEvents):
713 (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
714 (WTR::EventSenderProxy::touchStart):
715 (WTR::EventSenderProxy::touchMove):
716 (WTR::EventSenderProxy::touchEnd):
717 (WTR::EventSenderProxy::touchCancel):
718 (WTR::EventSenderProxy::clearTouchPoints):
719 (WTR::EventSenderProxy::releaseTouchPoint):
720 (WTR::EventSenderProxy::cancelTouchPoint):
722 2017-07-27 Brady Eidson <beidson@apple.com>
724 Part 2 of: Rename DatabaseProcess to StorageProcess.
725 https://bugs.webkit.org/show_bug.cgi?id=174880
727 Reviewed by Andy Estes.
729 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
730 * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
731 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
732 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
733 * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
734 * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
735 * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
736 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
738 2017-07-26 Mark Lam <mark.lam@apple.com>
740 Add ability to only run specific tests in run-javascriptcore-tests.
741 https://bugs.webkit.org/show_bug.cgi?id=174884
743 Reviewed by Saam Barati.
745 For example, if we only want to run testapi, we can do so as follows:
746 $ run-javascriptcore-tests --testapi
748 Previously, specifying --testapi effectively does nothing because we run all tests
749 by default. Only --no-testapi had the effect of disabling the test set. This
750 old behavior for --testapi is not very useful or meaningful. We're now changing
751 it to mean that we will only run that test.
753 With this change, we can also run more than one set of tests. For example, if we
754 only want to run testmasm and testair, we can do so as follows:
755 $ run-javascriptcore-tests --testmasm --testair
757 By default, if no specific test option is specified, run-javascriptcore-tests will
760 Note that the jsc stress tests (--jsc-stress) are a different set of tests than
761 the mozilla tests (--mozilla-tests) even though both are run via the lower level
762 run-jsc-stress-tests test harness. Hence, if you only specify one of the tests,
763 the other set will not run. For example, the following only runs the mozilla tests:
764 $ run-javascriptcore-tests --mozilla-tests
766 Note also that --jit-stress-tests is not for choosing a different set of tests.
767 Instead, it is used for determining whether we run JIT'ed test configurations
768 on the jsc stress tests and mozilla tests. As a result, specifying
769 --jit-stress-tests will not omit other tests. For example, the following still
771 $ run-javascriptcore-tests --jit-stress-tests
773 * Scripts/run-javascriptcore-tests:
774 (defaultStringForTestState):
778 2017-07-26 Mark Lam <mark.lam@apple.com>
780 Make run-javascriptcore-test run testair, testb3, and testmasm.
781 https://bugs.webkit.org/show_bug.cgi?id=174837
782 <rdar://problem/33522927>
784 Reviewed by Saam Barati and Filip Pizlo.
786 1. Refactors code for running testapi so that we can use it to run other tests.
787 2. Added running of testmasm, testair, testb3.
789 Note: the existing testapi invocation code does not support remote invocation of
790 the tests (e.g. on a ARM device). Hence, the new additions of testmasm, testair,
791 and testb3 also do not support remote invocation. If we wish to add remote
792 invocation support, we should do that in a separate patch.
794 * Scripts/run-javascriptcore-tests:
797 (testapiPath): Deleted.
799 2017-07-26 Aakash Jain <aakash_jain@apple.com>
801 Remove duplicate code from Buildbot.js in dashboard
802 https://bugs.webkit.org/show_bug.cgi?id=174870
804 Reviewed by Daniel Bates.
806 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
807 (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
808 (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
809 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
810 (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
812 2017-07-26 Brady Eidson <beidson@apple.com>
814 Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
815 https://bugs.webkit.org/show_bug.cgi?id=174851
817 Reviewed by Chris Dumez.
819 * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
822 2017-07-26 Brian Burg <bburg@apple.com>
824 Remove WEB_TIMING feature flag
825 https://bugs.webkit.org/show_bug.cgi?id=174795
827 Reviewed by Alex Christensen.
829 * Scripts/webkitperl/FeatureList.pm:
830 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
832 2017-07-26 Chris Dumez <cdumez@apple.com>
834 Pressing the Escape key should not be a valid user gesture to enter fullscreen
835 https://bugs.webkit.org/show_bug.cgi?id=174864
836 <rdar://problem/33009088>
838 Reviewed by Geoffrey Garen.
840 Add support for eventSender.keyDown('escape') in DRT to match the behavior of
843 * DumpRenderTree/mac/EventSendingController.mm:
844 (-[EventSendingController keyDown:withModifiers:withLocation:]):
846 2017-07-26 Romain Bellessort <romain.bellessort@crf.canon.fr>
848 Unreviewed, added Romain Bellessort to contributors.json.
850 * Scripts/webkitpy/common/config/contributors.json:
852 2017-07-26 Zan Dobersek <zdobersek@igalia.com>
855 https://bugs.webkit.org/show_bug.cgi?id=174249
857 Reviewed by Alex Christensen.
859 * Scripts/webkitperl/FeatureList.pm:
860 Enable WebGL2 for WPE when building through build-webkit.
862 2017-07-26 Carlos Garcia Campos <cgarcia@igalia.com>
864 Unreviewed. Fix GTK distcheck.
867 (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
869 2017-07-25 Brady Eidson <beidson@apple.com>
871 ResourceLoadStatistics grandfathering happens much too often.
872 <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
874 Reviewed by Chris Dumez.
876 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
877 * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
878 * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
881 2017-07-25 Matthew Stewart <matthew_r_stewart@apple.com>
883 Fix autoinstaller failing on autoinstall_everything
884 https://bugs.webkit.org/show_bug.cgi?id=174830
886 Reviewed by Joseph Pecoraro.
888 * Scripts/webkitpy/thirdparty/__init__.py:
889 (AutoinstallImportHook.find_module):
890 (AutoinstallImportHook.install_chromedriver):
891 (AutoinstallImportHook.install_geckodriver):
892 (AutoinstallImportHook._install_chromedriver): Deleted.
893 (AutoinstallImportHook._install_geckodriver): Deleted.
895 2017-07-25 Jonathan Bedard <jbedard@apple.com>
897 Replace --runtime with something for both ios-simulator and ios-device
898 https://bugs.webkit.org/show_bug.cgi?id=173775
899 <rdar://problem/32952164>
901 Reviewed by Aakash Jain.
903 Add --version flag for both iOS simulator and iOS device.
905 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
906 (parse_args): Add --version flag and move --no-install.
907 * Scripts/webkitpy/port/factory.py:
908 (platform_options): Move --no-intall to run_webkit_tests.py.
909 * Scripts/webkitpy/port/ios.py:
911 (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
912 (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
913 * Scripts/webkitpy/port/ios_device.py:
914 (IOSDevicePort.ios_version): Consult --version flag before checking connected
915 devices for iOS version.
916 * Scripts/webkitpy/port/ios_device_unittest.py:
917 (IOSDeviceTest.make_port): Set --version option so that we can generate test
918 expectation paths without devices connected.
919 (IOSDeviceTest.test_additional_platform_directory): Deleted.
920 (IOSDeviceTest.test_baseline_searchpath): Deleted.
921 (IOSDeviceTest.test_expectations_ordering): Deleted.
922 * Scripts/webkitpy/port/ios_simulator.py:
923 (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
924 flag to specify a runtime.
925 (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
926 flag and then use the default runtime.
928 2017-07-25 Carlos Garcia Campos <cgarcia@igalia.com>
930 [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
931 https://bugs.webkit.org/show_bug.cgi?id=174815
933 Reviewed by Carlos Alberto Lopez Perez.
935 Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
936 ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
937 use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
938 TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
939 think), probably because of a newer CMake version.
942 * TestWebKitAPI/CMakeLists.txt:
943 * TestWebKitAPI/PlatformGTK.cmake:
945 2017-07-24 Matthew Stewart <matthew_r_stewart@apple.com>
947 Fix BenchmarkRunner to only import selenium when needed
948 https://bugs.webkit.org/show_bug.cgi?id=174808
950 Reviewed by Stephanie Lewis.
952 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
953 (LinuxChromeDriver.launch_driver):
954 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
955 (LinuxFirefoxDriver.launch_driver):
956 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
957 (OSXChromeDriver.launch_driver):
958 (OSXChromeCanaryDriver.launch_driver):
959 (create_chrome_options):
960 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
961 (OSXFirefoxDriver.launch_driver):
962 (OSXFirefoxNightlyDriver.launch_driver):
963 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
964 (OSXSafariDriver.launch_driver):
965 * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
966 (WebDriverBenchmarkRunner._run_one_test):
968 2017-07-23 Darin Adler <darin@apple.com>
970 More NeverDestroyed and related cleanup
971 https://bugs.webkit.org/show_bug.cgi?id=174745
973 Reviewed by Alex Christensen.
975 * DumpRenderTree/JavaScriptThreading.cpp:
976 (javaScriptThreadsMutex): Use NeverDestroyed instead of
977 DEPRECATED_DEFINE_STATIC_LOCAL.
978 (javaScriptThreads): Ditto.
980 2017-07-24 Matthew Stewart <matthew_r_stewart@apple.com>
982 Subclass Benchmark Runner script for WebDriver support
983 https://bugs.webkit.org/show_bug.cgi?id=174390
985 Reviewed by Dewei Zhu, Stephanie Lewis.
987 Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
989 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
990 (BenchmarkBuilder.__init__):
991 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
992 (BenchmarkRunner.__init__):
993 (BenchmarkRunner._find_plan_file):
994 (BenchmarkRunner._run_one_test.and):
995 (BenchmarkRunner.execute):
996 (BenchmarkRunner._get_result): Deleted.
997 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1000 * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
1001 (WebDriverBenchmarkRunner):
1002 (WebDriverBenchmarkRunner._get_result):
1003 (WebDriverBenchmarkRunner._run_one_test):
1004 * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
1005 (WebServerBenchmarkRunner):
1006 (WebServerBenchmarkRunner.__init__):
1007 (WebServerBenchmarkRunner._get_result):
1008 (WebServerBenchmarkRunner._run_one_test):
1010 2017-07-24 Matthew Stewart <matthew_r_stewart@apple.com>
1012 Add BenchmarkRunner patches with WebDriver support for each testing plan
1013 https://bugs.webkit.org/show_bug.cgi?id=174443
1015 Reviewed by Dewei Zhu, Stephanie Lewis.
1017 * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1018 (BenchmarkBuilder.__enter__):
1019 * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
1020 * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
1021 * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
1022 * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
1023 * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
1024 * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
1025 * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
1026 * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
1027 * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
1028 * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
1029 * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
1030 * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
1031 * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
1032 * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
1033 * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
1034 * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
1035 * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
1036 * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
1037 * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
1038 * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
1039 * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
1040 * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
1041 * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1042 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
1043 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
1044 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
1045 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1046 * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
1047 * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
1048 * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1049 * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
1050 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
1051 * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1053 2017-07-24 Matthew Stewart <matthew_r_stewart@apple.com>
1055 Add functions to autoinstaller needed for Benchmark Runner script
1056 https://bugs.webkit.org/show_bug.cgi?id=174331
1058 Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
1060 Adds autoinstaller functions to install selenium and webdriver binaries
1061 which will be used by the browser driver part of Benchmark Runner.
1063 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1064 (BrowserDriver.restore_env):
1066 (BrowserDriver.get_webdriver_binary_path):
1067 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1068 (LinuxChromeDriver.launch_driver):
1069 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1070 (LinuxFirefoxDriver.launch_driver):
1071 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1072 (OSXChromeDriver.launch_driver):
1073 (OSXChromeCanaryDriver.launch_driver):
1074 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1075 (OSXFirefoxDriver.launch_driver):
1076 (OSXFirefoxNightlyDriver.launch_driver):
1077 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1078 * Scripts/webkitpy/benchmark_runner/utils.py:
1079 (get_driver_binary_path):
1080 * Scripts/webkitpy/common/system/autoinstall.py:
1081 (AutoInstaller._unzip):
1082 * Scripts/webkitpy/thirdparty/__init__.py:
1083 (AutoinstallImportHook.find_module):
1084 (AutoinstallImportHook._install_selenium):
1085 (AutoinstallImportHook):
1086 (AutoinstallImportHook._install_chromedriver):
1087 (AutoinstallImportHook._install_geckodriver):
1088 (AutoinstallImportHook.get_latest_pypi_url):
1089 (AutoinstallImportHook.install_binary):
1090 (autoinstall_everything):
1091 (get_driver_filename):
1094 2017-07-24 Matthew Stewart <matthew_r_stewart@apple.com>
1096 Add WebDriver support in browser driver part of BenchmarkRunner
1097 https://bugs.webkit.org/show_bug.cgi?id=174445
1099 Reviewed by Stephanie Lewis.
1101 Adds a launch_driver function to each BrowserDriver subclass. This
1102 function sets up the arguments for the webdriver and launches the
1103 webdriver specific to that browser.
1105 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1106 (BrowserDriver.launch_webdriver):
1108 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1109 (LinuxBrowserDriver.launch_webdriver):
1110 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1111 (LinuxChromeDriver.launch_url):
1112 (LinuxChromeDriver):
1113 (LinuxChromeDriver.launch_driver):
1114 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
1115 (EpiphanyBrowserDriver.launch_url):
1116 (EpiphanyBrowserDriver):
1117 (EpiphanyBrowserDriver.launch_driver):
1118 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1119 (LinuxFirefoxDriver):
1120 (LinuxFirefoxDriver.launch_url):
1121 (LinuxFirefoxDriver.launch_driver):
1122 * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
1123 (GTKMiniBrowserDriver.launch_url):
1124 (GTKMiniBrowserDriver):
1125 (GTKMiniBrowserDriver.launch_driver):
1126 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1127 (OSXBrowserDriver._launch_webdriver):
1129 (OSXBrowserDriver._screen_size):
1130 (OSXBrowserDriver._insert_url):
1131 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1133 (OSXChromeDriver.launch_url):
1134 (OSXChromeDriver.launch_driver):
1135 (OSXChromeCanaryDriver):
1136 (OSXChromeCanaryDriver.launch_url):
1137 (OSXChromeCanaryDriver.launch_driver):
1138 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1140 (OSXFirefoxDriver.launch_url):
1141 (OSXFirefoxDriver.launch_driver):
1142 (OSXFirefoxNightlyDriver):
1143 (OSXFirefoxNightlyDriver.launch_url):
1144 (OSXFirefoxNightlyDriver.launch_driver):
1145 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1146 (OSXSafariDriver.launch_driver):
1148 2017-07-24 Wenson Hsieh <wenson_hsieh@apple.com>
1150 [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
1151 https://bugs.webkit.org/show_bug.cgi?id=174793
1153 Reviewed by Tim Horton.
1155 Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
1156 down. Without r219765, this test will dereference null and crash.
1158 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1159 * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
1160 * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
1163 2017-07-24 Basuke Suzuki <Basuke.Suzuki@sony.com>
1165 [Win] Implement Authentication dialog in MiniBrowser
1166 https://bugs.webkit.org/show_bug.cgi?id=174662
1168 Reviewed by Alex Christensen.
1170 * MiniBrowser/win/Common.cpp:
1172 (DisplayAuthDialog):
1174 * MiniBrowser/win/MiniBrowserLib.rc:
1175 * MiniBrowser/win/MiniBrowserLibResource.h:
1176 * MiniBrowser/win/ResourceLoadDelegate.cpp:
1177 (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1179 2017-07-24 Jonathan Bedard <jbedard@apple.com>
1181 Handle case where line_numbers is None instead of an array of line numbers
1182 https://bugs.webkit.org/show_bug.cgi?id=174775
1184 Reviewed by Aakash Jain.
1186 Added files set line_numbers to None in process_file.
1188 * Scripts/webkitpy/style/filereader.py:
1189 (TextFileReader.process_file): Handle case where line_number is set to None.
1190 * Scripts/webkitpy/style/main_unittest.py:
1191 (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
1193 2017-07-24 Zan Dobersek <zdobersek@igalia.com>
1195 [WPE] Add libepoxy to the Jhbuild moduleset
1196 https://bugs.webkit.org/show_bug.cgi?id=174711
1198 Reviewed by Carlos Alberto Lopez Perez.
1200 * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
1202 2017-07-24 Zan Dobersek <zdobersek@igalia.com>
1204 [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
1205 https://bugs.webkit.org/show_bug.cgi?id=174780
1207 Reviewed by Carlos Garcia Campos.
1209 * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1210 Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
1211 in case the eglplatform.h header doesn't provide that macro. This replicates
1212 the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
1214 2017-07-22 Wenson Hsieh <wenson_hsieh@apple.com>
1216 [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
1217 https://bugs.webkit.org/show_bug.cgi?id=174758
1219 Reviewed by Dan Bernstein.
1221 Migrate position-information-related unit tests from the PositionInformationTests suite to
1222 WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
1224 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1225 * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
1226 (TestWebKitAPI::checkElementTypeAndBoundingRect):
1227 (TestWebKitAPI::TEST):
1228 * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
1229 * TestWebKitAPI/cocoa/TestWKWebView.h:
1230 * TestWebKitAPI/cocoa/TestWKWebView.mm:
1231 (-[TestWKWebView activatedElementAtPosition:]):
1233 2017-07-22 Chris Dumez <cdumez@apple.com>
1235 REGRESSION(r204565): WKObject is broken
1236 https://bugs.webkit.org/show_bug.cgi?id=174736
1237 <rdar://problem/33246169>
1239 Reviewed by Dan Bernstein.
1241 Add API test that used to crash.
1243 * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1244 (TestWebKitAPI::TEST):
1246 2017-07-22 Yusuke Suzuki <utatane.tea@gmail.com>
1248 [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
1249 https://bugs.webkit.org/show_bug.cgi?id=174705
1251 Reviewed by Mark Lam.
1253 * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1254 (TestWebKitAPI::testThreadGroup):
1255 (TestWebKitAPI::TEST):
1257 2017-07-21 Jonathan Bedard <jbedard@apple.com>
1259 Fail gracefully when xcrun fails in IOSSimulatorPort constructor
1260 https://bugs.webkit.org/show_bug.cgi?id=174724
1262 Reviewed by Aakash Jain.
1264 * Scripts/webkitpy/port/ios_simulator.py:
1265 (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
1266 simulator. Errors here should be treated the same as no simulators found.
1268 2017-07-21 Yousuke Kimoto <Yousuke.Kimoto@sony.com>
1270 [CMake] Add an option to stop build after generating project files
1271 https://bugs.webkit.org/show_bug.cgi?id=174664
1273 Reviewed by Konstantin Tokarev.
1275 Add "--generate-project-only" to stop build after generating project files.
1277 * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
1278 * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
1279 (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
1280 (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
1281 (isGenerateProjectOnly): ditto
1283 2017-07-21 Yusuke Suzuki <utatane.tea@gmail.com>
1285 [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1286 https://bugs.webkit.org/show_bug.cgi?id=174501
1288 Reviewed by Darin Adler.
1290 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1291 (TestWebKitAPI::TEST):
1293 2017-07-20 David Quesada <david_quesada@apple.com>
1295 Add SPI to notify WKNavigationDelegate about client redirects
1296 https://bugs.webkit.org/show_bug.cgi?id=174680
1297 rdar://problem/33184886
1299 Reviewed by Brady Eidson.
1301 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1302 (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
1304 Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
1306 2017-07-20 Brady Eidson <beidson@apple.com>
1308 Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
1309 https://bugs.webkit.org/show_bug.cgi?id=174685
1311 Reviewed by Andy Estes.
1313 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1314 (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
1316 2017-07-20 Brady Eidson <beidson@apple.com>
1318 Deprecate WebIconDatabase in WebKitLegacy/mac.
1319 https://bugs.webkit.org/show_bug.cgi?id=174607
1321 Reviewed by Alex Christensen.
1323 * DumpRenderTree/mac/TestRunnerMac.mm:
1325 2017-07-20 Jonathan Bedard <jbedard@apple.com>
1327 lint-test-expectations should be run during style checking
1328 https://bugs.webkit.org/show_bug.cgi?id=173559
1329 <rdar://problem/32854941>
1331 Reviewed by Aakash Jain.
1333 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1334 (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
1335 prevents identifying errors on specific lines in a file.
1336 * Scripts/webkitpy/style/main_unittest.py:
1337 (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
1338 case where a linter error is in the file modified, but the line modified is not related to
1341 2017-07-20 Brady Eidson <beidson@apple.com>
1343 Remove WebIconDatabase from WebKitLegacy/win.
1344 https://bugs.webkit.org/show_bug.cgi?id=174608
1346 Reviewed by Alex Christensen.
1348 * DumpRenderTree/win/DumpRenderTree.cpp:
1350 * DumpRenderTree/win/TestRunnerWin.cpp:
1351 (TestRunner::setIconDatabaseEnabled):
1353 2017-07-20 Zan Dobersek <zdobersek@igalia.com>
1355 [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
1356 https://bugs.webkit.org/show_bug.cgi?id=174671
1358 Reviewed by Carlos Garcia Campos.
1360 * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1361 (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
1362 priority for this source in order to have it dispatched on the same
1363 priority as the other WebKit-controlled GSource objects.
1365 2017-07-19 Jonathan Bedard <jbedard@apple.com>
1367 lint-test-expectations should be run during style checking
1368 https://bugs.webkit.org/show_bug.cgi?id=173559
1369 <rdar://problem/32854941>
1371 Reviewed by Daniel Bates.
1373 Follow up fix addressing style and a few minor bugs.
1375 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1376 (TestExpectationParser.__init__): Use lambda x: x instead of str
1377 (TestExpectationsModel.__init__): Make lambda x: x the default argument.
1378 (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
1379 reduce the calls of _shorten_filename, fix minor bug in appending the current
1380 expectation's line number instead of the previous ones, clarify treatment of None
1381 in file-to-line-number mapping.
1382 (TestExpectations._report_warnings): Collapse call.
1383 * Scripts/webkitpy/style/checkers/test_expectations.py:
1384 (TestExpectationsChecker.lint_test_expectations):
1385 * Scripts/webkitpy/style/filereader.py: Re-write comment.
1386 (TextFileReader.process_file): Add comment explaining treatment of None in
1387 file-to-line-number mapping.
1388 (TextFileReader.delete_file): Collapse call.
1390 2017-07-19 Chris Dumez <cdumez@apple.com>
1392 Unreviewed attempt to fix API test failure after r219663.
1394 The test was hard-coding an exception string and the string has changed slightly
1397 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1400 2017-07-19 Megan Gardner <megan_gardner@apple.com>
1402 Don't write file URLs to iOS Pasteboard
1403 https://bugs.webkit.org/show_bug.cgi?id=174647
1404 <rdar://problem/33199730>
1406 Reviewed by Wenson Hsieh.
1408 Updating tests to reflect the lack of file URLs for images.
1410 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1411 (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
1412 (checkEstimatedSize):
1413 (TestWebKitAPI::TEST):
1415 2017-07-19 Brady Eidson <beidson@apple.com>
1417 iBooks sometimes crashes when closing a book.
1418 <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
1420 Reviewed by Oliver Hunt.
1422 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1423 (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
1424 (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
1425 (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
1426 (TestWebKitAPI::TEST):
1428 Add a "spin the runloop X number of times" utility:
1429 * TestWebKitAPI/Utilities.h:
1430 * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1431 (TestWebKitAPI::Util::spinRunLoop):
1433 2017-07-19 Jonathan Bedard <jbedard@apple.com>
1435 lint-test-expectations should be run during style checking
1436 https://bugs.webkit.org/show_bug.cgi?id=173559
1437 <rdar://problem/32854941>
1439 Reviewed by David Kilzer.
1441 Running the test expectation linter requires reading both files and lines not in the
1442 patch because, for example, deletion of a test can cause a lint failure even though
1443 no test expectations where modified. This means that the linter will occasionally warn
1444 about lines which were not changed in a given patch but whose error is related to a
1445 change made in that patch.
1447 * Scripts/webkitpy/common/system/filesystem_mock.py:
1448 (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
1449 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1450 (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
1451 (TestExpectationWarning.__init__): Construct warning with file name, line number, line
1452 content, description of the error and the name of the associated test.
1453 (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
1454 (TestExpectationParser.__init__): Pass shorten_filename function to
1455 TestExpectationsParser to add a deleted file to the related_files dictionary.
1456 (TestExpectationParser._check_test_exists): If the test does not exist, add the
1457 missing path to the related_files dictionary.
1458 (TestExpectationLine.__init__): Add related_files dictionary, which tracks
1459 files and line numbers related to this test expectation line. This will allow
1460 tracking linter errors in the style checker occurring across multiple files.
1461 (TestExpectationsModel._already_seen_better_match): Add redundant expectation
1462 lines to related_files dictionary.
1463 (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
1464 (TestExpectations._report_warnings): Construct warning object instead of string
1465 when adding to warnings list.
1466 * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
1468 * Scripts/webkitpy/style/checker.py:
1469 (ProcessorBase.do_association_check): Add required function for processor classes.
1471 (StyleProcessor.do_association_check): Run the TestExpectations linter when
1472 checking for errors between associated files.
1473 * Scripts/webkitpy/style/checkers/test_expectations.py:
1474 (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
1475 (TestExpectationsChecker):
1476 (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
1477 of modified files, the current working directory and the host, determine if the linter
1478 warning is associated with the changes.
1479 (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
1481 * Scripts/webkitpy/style/filereader.py:
1483 (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
1484 (TextFileReader.file_count): Use dictionary to determine the number of modified files.
1485 (TextFileReader.process_file): Track both the number of files changed and which lines
1486 in those files were changed.
1487 (TextFileReader.do_association_check): Run the processor's association check on all
1488 modified or deleted files processed by TextFileReader.
1489 (TextFileReader.delete_file): Track deleted files in _files dictionary.
1490 (TextFileReader.count_delete_only_file): Deleted.
1491 * Scripts/webkitpy/style/filereader_unittest.py:
1492 (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
1493 (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
1494 * Scripts/webkitpy/style/main.py:
1495 (CheckWebKitStyle.main): When running the style checker on a specific list of files,
1496 explicitly run the association check on the file reader.
1497 * Scripts/webkitpy/style/main_unittest.py:
1498 (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
1499 embedded in the style checker.
1500 (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
1501 (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
1502 construct the TextFileReader object with a StyleProcessor used to run style checks on
1504 (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
1505 testing the test expectation linter inside the style checker. This host must contain a
1506 mock file system with the basic structure of test expectations.
1507 (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
1508 (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
1509 (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
1510 (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
1511 (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
1512 * Scripts/webkitpy/style/patchreader.py:
1513 (PatchReader.check): Specify which file was deleted, run the association check.
1514 * Scripts/webkitpy/style/patchreader_unittest.py:
1515 (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
1516 (PatchReaderTest.MockTextFileReader.do_association_check): Added.
1517 (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
1519 2017-07-19 Yusuke Suzuki <utatane.tea@gmail.com>
1521 [WTF] Implement WTF::ThreadGroup
1522 https://bugs.webkit.org/show_bug.cgi?id=174081
1524 Reviewed by Mark Lam.
1526 Add WTF::ThreadGroup tests.
1528 * TestWebKitAPI/CMakeLists.txt:
1529 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1530 * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1531 (TestWebKitAPI::testThreadGroup):
1532 (TestWebKitAPI::TEST):
1534 2017-07-18 Andy Estes <aestes@apple.com>
1536 [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1537 https://bugs.webkit.org/show_bug.cgi?id=174631
1539 Reviewed by Tim Horton.
1541 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1542 * MiniBrowser/Configurations/Base.xcconfig:
1543 * MobileMiniBrowser/Configurations/Base.xcconfig:
1544 * TestWebKitAPI/Configurations/Base.xcconfig:
1545 * WebKitTestRunner/Configurations/Base.xcconfig:
1547 2017-07-18 Andy Estes <aestes@apple.com>
1549 [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1550 https://bugs.webkit.org/show_bug.cgi?id=174631
1552 Reviewed by Sam Weinig.
1554 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1555 * MiniBrowser/Configurations/Base.xcconfig:
1556 * MobileMiniBrowser/Configurations/Base.xcconfig:
1557 * TestWebKitAPI/Configurations/Base.xcconfig:
1558 * WebKitTestRunner/Configurations/Base.xcconfig:
1560 2017-07-18 Daniel Bates <dabates@apple.com>
1562 lldb: Add type summary for StringView
1563 https://bugs.webkit.org/show_bug.cgi?id=174637
1565 Reviewed by Sam Weinig.
1567 For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
1568 StringView object will print output that has the form:
1570 (WTF::StringView) $4 = { length = 2, contents = 'li' } {
1571 m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
1574 m_underlyingString = 0x0000614000000a90
1577 * lldb/lldb_webkit.py:
1578 (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
1579 (WTFStringView_SummaryProvider):
1580 (WTFStringViewProvider):
1581 (WTFStringViewProvider.__init__):
1582 (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
1583 (WTFStringViewProvider.get_length): Access field StringView.m_length.
1584 (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
1585 (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
1587 2017-07-18 Andy Estes <aestes@apple.com>
1589 [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
1590 https://bugs.webkit.org/show_bug.cgi?id=174631
1592 Reviewed by Dan Bernstein.
1594 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1595 * MiniBrowser/Configurations/Base.xcconfig:
1596 * MobileMiniBrowser/Configurations/Base.xcconfig:
1597 * TestWebKitAPI/Configurations/Base.xcconfig:
1598 * WebKitTestRunner/Configurations/Base.xcconfig:
1600 2017-07-18 Devin Rousso <drousso@apple.com>
1602 Web Inspector: Add memoryCost to Inspector Protocol objects
1603 https://bugs.webkit.org/show_bug.cgi?id=174478
1605 Reviewed by Joseph Pecoraro.
1607 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1608 * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
1609 (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
1610 (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
1611 (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
1612 (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
1613 (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
1614 (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
1615 (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
1616 (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
1617 (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
1618 (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
1619 (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
1620 (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
1621 (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
1622 (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
1623 (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
1625 2017-07-18 Andy Estes <aestes@apple.com>
1627 [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
1628 https://bugs.webkit.org/show_bug.cgi?id=174631
1630 Reviewed by Darin Adler.
1632 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1633 * MiniBrowser/Configurations/Base.xcconfig:
1634 * MobileMiniBrowser/Configurations/Base.xcconfig:
1635 * TestWebKitAPI/Configurations/Base.xcconfig:
1636 * WebKitTestRunner/Configurations/Base.xcconfig:
1638 2017-07-17 Wenson Hsieh <wenson_hsieh@apple.com>
1640 Unreviewed, fix the iOS build.
1642 I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
1644 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1645 (TestWebKitAPI::TEST):
1647 2017-07-17 Wenson Hsieh <wenson_hsieh@apple.com>
1649 [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
1650 https://bugs.webkit.org/show_bug.cgi?id=174585
1651 <rdar://problem/33302541>
1653 Reviewed by Tim Horton.
1655 Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
1656 being dragged when initiating a drag.
1658 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1659 * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
1660 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1661 (TestWebKitAPI::TEST):
1662 * TestWebKitAPI/cocoa/TestWKWebView.h:
1664 Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
1666 * TestWebKitAPI/cocoa/TestWKWebView.mm:
1667 (-[TestWKWebView synchronouslyLoadHTMLString:]):
1669 2017-07-17 Michael Catanzaro <mcatanzaro@igalia.com>
1671 [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
1672 https://bugs.webkit.org/show_bug.cgi?id=174547
1674 Reviewed by Alex Christensen.
1676 * DumpRenderTree/PlatformWin.cmake:
1677 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1679 2017-07-17 Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com>
1681 Update style checker to deal with "final"
1682 https://bugs.webkit.org/show_bug.cgi?id=174528
1684 Reviewed by Alex Christensen.
1686 check-webkit-style shouldn't complain about an open brace to start a
1687 line after a function definition with "final" or "const final".
1689 * Scripts/webkitpy/style/checkers/cpp.py:
1691 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1692 (CppStyleTest.test_brace_at_begin_of_line):
1694 2017-07-17 Alex Christensen <achristensen@webkit.org>
1696 Modernize content extension code
1697 https://bugs.webkit.org/show_bug.cgi?id=174588
1699 Reviewed by Sam Weinig.
1701 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1702 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1703 (TestWebKitAPI::testRequest):
1704 (TestWebKitAPI::makeBackend):
1705 (TestWebKitAPI::TEST_F):
1707 2017-07-17 Brady Eidson <beidson@apple.com>
1709 WKHTTPCookieStore observing only works on the default cookie store.
1710 <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
1712 Reviewed by Sam Weinig.
1714 * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1715 (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
1716 called for the default store, a non-persistent store, and a custom store.
1719 2017-07-16 Sam Weinig <sam@webkit.org>
1721 [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
1722 https://bugs.webkit.org/show_bug.cgi?id=174575
1724 Reviewed by Brady Eidson.
1726 * Scripts/svn-create-patch:
1727 (findModificationType):
1728 Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
1729 default value of "unknown".
1732 Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
1733 for untracked, which matches our old behavior.
1735 2017-07-17 Charlie Turner <cturner@igalia.com>
1737 Add some missing build dependencies on Fedora
1738 https://bugs.webkit.org/show_bug.cgi?id=174578
1740 Unreviewed dependency update.
1742 * gtk/install-dependencies:
1744 2017-07-16 Brady Eidson <beidson@apple.com>
1746 Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
1747 <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
1749 Reviewed by Tim Horton.
1751 * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1752 (-[CookieNavigationDelegate webView:didFinishNavigation:]):
1755 2017-07-16 Bernhard M. Wiedemann <bwiedemann@suse.de>
1757 [GTK] Sort inspector GResource manifest to ensure reproducible builds
1758 https://bugs.webkit.org/show_bug.cgi?id=174540
1760 Reviewed by Michael Catanzaro.
1762 * gtk/generate-inspector-gresource-manifest.py:
1763 (get_filenames): sort list of input files
1765 2017-07-15 Brady Eidson <beidson@apple.com>
1767 Make sure all CFHTTPCookieStorageRefs we create are scheduled.
1768 <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
1770 Reviewed by Tim Horton.
1772 * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1773 (TEST): Make this test more reliable by clearing everything beforehand.
1775 2017-07-15 David Kilzer <ddkilzer@apple.com>
1777 Make it possible to extend check-webkit-style with Apple-internal checkers
1778 <https://webkit.org/b/174464>
1779 <rdar://problem/25564402>
1781 Reviewed by Darin Adler.
1783 * Scripts/webkitpy/style/checker.py: Import apple_additions.
1784 (_all_categories): Add categories from apple_additions() if it
1786 (CheckerDispatcher._create_checker): Create python checker
1787 from apple_additions() if it exists.
1789 2017-07-15 Wenson Hsieh <wenson_hsieh@apple.com>
1791 [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
1792 https://bugs.webkit.org/show_bug.cgi?id=174539
1793 <rdar://problem/33307395>
1795 Reviewed by Darin Adler.
1797 Adds a new unit test suite to cover action sheet popover presentation.
1799 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1800 * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
1801 * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
1802 (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
1804 Runs the given block and waits until the UI process has indicated that it will present an action sheet.
1806 (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
1807 (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1809 Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
1811 (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1812 (TestWebKitAPI::TEST):
1814 2017-07-15 Sam Weinig <sam@webkit.org>
1816 [Scripts] Make svn-create-patch work better when called in sub directories
1817 https://bugs.webkit.org/show_bug.cgi?id=174551
1819 Reviewed by Darin Adler.
1821 - Fixes manufacturePatchForAdditionWithHistory to use the correct path
1822 by ensuring that the prefix is applied as is done in generateDiff.
1823 - Silence output of explanatory lines from svn stat (" > move to ...")
1824 that show up in STDERR when running svn-create-patch.
1825 - Add verbose logging that I found useful while debugging this issue.
1827 * Scripts/svn-create-patch:
1830 (findSourceFileAndRevision):
1833 (manufacturePatchForAdditionWithHistory):
1835 2017-07-15 Jonathan Bedard <jbedard@apple.com>
1837 Unreviewed build fix after r219537.
1839 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1841 2017-07-14 Jonathan Bedard <jbedard@apple.com>
1844 https://bugs.webkit.org/show_bug.cgi?id=174430
1845 <rdar://problem/33269288>
1847 Reviewed by Tim Horton.
1849 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
1850 * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
1851 * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
1853 2017-07-14 Jonathan Bedard <jbedard@apple.com>
1855 Failing to install on iPad simulators
1856 https://bugs.webkit.org/show_bug.cgi?id=174532
1857 <rdar://problem/33328347>
1859 Reviewed by Stephanie Lewis.
1861 * Scripts/webkitpy/xcode/simulated_device.py:
1862 (SimulatedDevice.install_app): Place install command in retry try-except block.
1864 2017-07-14 Jeff Miller <jeffm@apple.com>
1866 Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1867 https://bugs.webkit.org/show_bug.cgi?id=174524
1869 Reviewed by Sam Weinig.
1871 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1873 Renamed TestParameter to TestParameter1.
1874 Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1876 * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1877 (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1878 Observe changes for two bundle parameters.
1880 (-[BundleParametersPlugIn dealloc]):
1881 Remove observers for two bundle parameters.
1883 2017-07-14 Commit Queue <commit-queue@webkit.org>
1885 Unreviewed, rolling out r219510.
1886 https://bugs.webkit.org/show_bug.cgi?id=174525
1888 Need to revert length() == 0 check for null string (Requested
1889 by yusukesuzuki on #webkit).
1893 "[WTF] Newly added AtomicStringImpl should use BufferInternal
1894 static string if StringImpl is static"
1895 https://bugs.webkit.org/show_bug.cgi?id=174501
1896 http://trac.webkit.org/changeset/219510
1898 2017-07-14 Jer Noble <jer.noble@apple.com>
1900 [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
1901 https://bugs.webkit.org/show_bug.cgi?id=174514
1903 Reviewed by Sam Weinig.
1905 * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
1906 (TestWebKitAPI::TEST_F):
1908 2017-07-14 Yusuke Suzuki <utatane.tea@gmail.com>
1910 [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1911 https://bugs.webkit.org/show_bug.cgi?id=174501
1913 Reviewed by Darin Adler.
1915 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1916 (TestWebKitAPI::TEST):
1918 2017-07-14 Jonathan Bedard <jbedard@apple.com>
1920 Bring mac expectations in-line with other platforms
1921 https://bugs.webkit.org/show_bug.cgi?id=174472
1922 <rdar://problem/33297388>
1924 Reviewed by David Kilzer.
1926 The override order for Mac test expectations does not conform to the pattern used by iOS,
1927 GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
1931 platform/mac-elcapitan
1935 After this change, El Capitan's baseline search path looks like this:
1937 platform/mac-sierra-wk2
1943 * Scripts/webkitpy/port/mac.py:
1944 (MacPort.__init__): If a specific version is specified in the port name, use that
1946 (MacPort.default_baseline_search_path): Expectation search paths should work the
1947 same way they do on other ports. Port + version overrides port, port overrides generic
1948 and wk1/wk2 should override expectations for the two combined.
1949 * Scripts/webkitpy/port/mac_unittest.py:
1950 (MacTest.test_tests_for_other_platforms): Deleted.
1951 (MacTest._assert_search_path): Deleted.
1952 (MacTest.test_baseline_search_path): Deleted.
1953 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1954 (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1955 (test_rebaseline_test_and_print_scm_changes): Ditto.
1956 (test_rebaseline_and_copy_test): Ditto.
1957 (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1958 (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1959 (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1961 2017-07-13 Michael Catanzaro <mcatanzaro@igalia.com>
1963 Fix style checker unit test
1965 Unreviewed WebKit2 => WebKit fixup.
1967 * Scripts/webkitpy/style/checker_unittest.py:
1968 (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1970 2017-07-13 Matthew Hanson <matthew_hanson@apple.com>
1972 Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1974 Unreviewed build fix.
1976 r219492 missed one hunk from its partial revert of r219489.
1977 This patch reverts that hunk.
1979 * TestWebKitAPI/CMakeLists.txt:
1981 2017-07-13 Matthew Hanson <matthew_hanson@apple.com>
1983 Use the old WebKit/WebKit2 targets for CMake builds.
1985 Unreviewed build fix.
1987 We can update the target names to match the Framework names in a future patch.
1988 This is a partial revert of r219489.
1990 * TestWebKitAPI/CMakeLists.txt:
1991 WebKitLegacy => WebKit
1994 2017-07-13 Matthew Hanson <matthew_hanson@apple.com>
1997 https://bugs.webkit.org/show_bug.cgi?id=174164
1998 rdar://problem/33137595
2000 Reviewed by Dan Bernstein.
2002 * TestWebKitAPI/CMakeLists.txt:
2003 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2004 * TestWebKitAPI/PlatformGTK.cmake:
2006 2017-07-13 Matthew Hanson <matthew_hanson@apple.com>
2008 Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
2009 https://bugs.webkit.org/show_bug.cgi?id=174164
2010 rdar://problem/33137595
2012 Reviewed by Dan Bernstein.
2014 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2016 * DumpRenderTree/mac/Configurations/Base.xcconfig:
2017 * Scripts/build-webkit:
2018 * Scripts/do-file-rename:
2019 * Scripts/do-webcore-rename:
2020 * Scripts/update-webkit-localizable-strings:
2021 * Scripts/webkitpy/common/config/watchlist:
2022 * Scripts/webkitpy/style/checker.py:
2023 * Scripts/webkitpy/style/checkers/featuredefines.py:
2025 (ensure_version_if_possible):
2026 * gtk/manifest.txt.in:
2028 2017-07-05 Matthew Hanson <matthew_hanson@apple.com>
2030 Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
2031 https://bugs.webkit.org/show_bug.cgi?id=174162
2032 rdar://problem/33137594
2034 Reviewed by Dan Bernstein.
2036 Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
2038 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2039 * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2040 * EWSTools/configure-clang-linux.sh:
2041 * Scripts/build-webkit:
2042 * Scripts/do-file-rename:
2043 * Scripts/do-webcore-rename:
2044 * Scripts/update-webkit-localizable-strings:
2045 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2046 * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2047 * Scripts/webkitpy/style/checkers/featuredefines.py:
2048 * gtk/manifest.txt.in:
2050 2017-07-13 Jonathan Bedard <jbedard@apple.com>
2052 Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
2053 https://bugs.webkit.org/show_bug.cgi?id=174438
2054 <rdar://problem/33277112>
2056 Reviewed by Aakash Jain.
2058 Given a patch, this will convert the changes from the path to the new directory structure.
2060 * Scripts/rebase-patch-after-webkit-move: Added.
2061 (append_source): Append 'Source' to the provided path.
2062 (is_editable_line): Return true if a line the script expects to modify.
2063 (needs_rebase): Return if a line needs to be rebased based on it's content.
2064 (rebase_line): Rebase the provided line.
2065 (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
2066 (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
2069 2017-07-12 Nan Wang <n_wang@apple.com>
2071 AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2072 https://bugs.webkit.org/show_bug.cgi?id=174393
2073 <rdar://problem/33248006>
2075 Reviewed by Chris Fleizach.
2077 * DumpRenderTree/AccessibilityUIElement.cpp:
2078 (textMarkerRangeMatchesTextNearMarkersCallback):
2079 (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2080 (AccessibilityUIElement::getJSClass):
2081 * DumpRenderTree/AccessibilityUIElement.h:
2082 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2083 (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2084 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2085 (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2086 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2087 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2088 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2089 (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2091 2017-07-12 Matt Lewis <jlewis3@apple.com>
2093 Unreviewed, rolling out r219409.
2095 The revision caused the Windows builds to fail.
2099 "AX: [iOS] Implement a way to retrieve a text marker range
2100 with desired text that is closest to a position"
2101 https://bugs.webkit.org/show_bug.cgi?id=174393
2102 http://trac.webkit.org/changeset/219409
2104 2017-07-12 Nan Wang <n_wang@apple.com>
2106 AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2107 https://bugs.webkit.org/show_bug.cgi?id=174393
2108 <rdar://problem/33248006>
2110 Reviewed by Chris Fleizach.
2112 * DumpRenderTree/AccessibilityUIElement.cpp:
2113 (textMarkerRangeMatchesTextNearMarkersCallback):
2114 (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2115 (AccessibilityUIElement::getJSClass):
2116 * DumpRenderTree/AccessibilityUIElement.h:
2117 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2118 (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2119 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2120 (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2121 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2122 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2123 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2124 (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2126 2017-07-12 Emilio Cobos Álvarez <ecobos@igalia.com>
2128 Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
2129 https://bugs.webkit.org/show_bug.cgi?id=174197
2131 Reviewed by Darin Adler.
2133 This bit me the first time I tried to submit a patch to WebKit, and still I have
2134 to manually edit the ChangeLog every time I use the script.
2136 This generates a more convenient and standard ChangeLog entry.
2138 * Scripts/prepare-ChangeLog:
2139 (generateNewChangeLogs):
2141 2017-07-12 Matt Lewis <jlewis3@apple.com>
2143 Unreviewed, rolling out r219401.
2145 This revision rolled out the previous patch, but after talking
2146 with reviewer, a rebaseline is what was needed.Rolling back in
2151 "Unreviewed, rolling out r219379."
2152 https://bugs.webkit.org/show_bug.cgi?id=174400
2153 http://trac.webkit.org/changeset/219401
2155 2017-07-12 Matt Lewis <jlewis3@apple.com>
2157 Unreviewed, rolling out r219379.
2159 This revision caused a consistent failure in the test
2160 fast/dom/Window/property-access-on-cached-window-after-frame-
2165 "Remove NAVIGATOR_HWCONCURRENCY"
2166 https://bugs.webkit.org/show_bug.cgi?id=174400
2167 http://trac.webkit.org/changeset/219379
2169 2017-07-12 Zan Dobersek <zdobersek@igalia.com>
2172 https://bugs.webkit.org/show_bug.cgi?id=172104
2174 Reviewed by Michael Catanzaro.
2176 * WebKitTestRunner/wpe/HeadlessViewBackend.h:
2177 Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
2179 2017-07-12 Zan Dobersek <zdobersek@igalia.com>
2181 [GTK][WPE] Align Jhbuild patches for GStreamer packages
2182 https://bugs.webkit.org/show_bug.cgi?id=174363
2184 Reviewed by Michael Catanzaro.
2186 Align the patches we apply over Jhbuild-managed GStreamer dependency packages
2187 between the GTK+ and WPE port. There's no reason for the two ports to apply
2188 different patches over same versions of GStreamer releases.
2190 This aligns the two ports on this specific issue. Next we'll look into
2191 creating a single GStreamer-specific Jhbuild moduleset that will allow us
2192 to keep these patches in a single place, avoiding duplicate files.
2194 * gtk/jhbuild.modules:
2195 * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2196 * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
2197 * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2198 * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
2200 2017-07-11 Dean Jackson <dino@apple.com>
2202 Remove NAVIGATOR_HWCONCURRENCY
2203 https://bugs.webkit.org/show_bug.cgi?id=174400
2205 Reviewed by Sam Weinig.
2207 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2209 2017-07-11 Ansh Shukla <ansh_shukla@apple.com>
2211 WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
2212 https://bugs.webkit.org/show_bug.cgi?id=174239
2214 Reviewed by Brady Eidson.
2216 Create windows with specific features set and make sure those are properly reflected in the
2217 WKWindowFeatures object.
2219 * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2220 (resetToConsistentState):
2221 (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2224 2017-07-11 Jonathan Bedard <jbedard@apple.com>
2226 Do not duplicate files when deleting directories with svn 1.9
2227 https://bugs.webkit.org/show_bug.cgi?id=174339
2228 <rdar://problem/33226781>
2230 Reviewed by David Kilzer.
2232 * Scripts/svn-create-patch:
2233 (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
2234 (generateFileList): Determine which files are deleted because they are part of a
2235 directory being deleted.
2237 2017-07-11 Dean Jackson <dino@apple.com>
2239 Rolling out r219372.
2241 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2243 2017-07-11 Dean Jackson <dino@apple.com>
2245 Remove NAVIGATOR_HWCONCURRENCY
2246 https://bugs.webkit.org/show_bug.cgi?id=174400
2248 Reviewed by Sam Weinig.
2250 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2252 2017-07-11 Lucas Forschler <lforschler@apple.com>
2254 Teach build workers to fetch archives from S3.
2255 https://bugs.webkit.org/show_bug.cgi?id=174384
2257 Reviewed by Aakash Jain.
2259 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2260 (DownloadBuiltProduct):
2262 2017-07-11 Lucas Forschler <lforschler@apple.com>
2264 Configure buildbot to transfer all archives to S3.
2265 Previously this was Mac only, but it's time to expand!
2266 https://bugs.webkit.org/show_bug.cgi?id=174378
2268 Reviewed by Aakash Jain.
2270 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2271 (BuildFactory.__init__):
2273 2017-07-11 Zan Dobersek <zdobersek@igalia.com>
2275 [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
2276 https://bugs.webkit.org/show_bug.cgi?id=174350
2278 Reviewed by Xabier Rodriguez-Calvar.
2280 Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
2281 to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
2282 patches are removed. The patches for gst-plugins-good are updated, removing
2283 the stale ones and adding the additional changes to qtdemux, souphttpsrc and
2284 rtpbin elements that will help with the EMEv3 development.
2286 * wpe/jhbuild.modules:
2287 * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
2288 * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
2289 * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
2290 * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2291 * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2292 * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2293 * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2294 * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2295 * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2297 2017-07-10 John Wilander <wilander@apple.com>
2299 Resource Load Statistics: Prune statistics in orders of importance
2300 https://bugs.webkit.org/show_bug.cgi?id=174215
2301 <rdar://problem/33164403>
2303 Reviewed by Chris Dumez.
2305 Nest infrastructure. Adds these functions:
2306 1. testRunner.setStatisticsLastSeen()
2307 2. setStatisticsMaxStatisticsEntries()
2308 3. setStatisticsPruneEntriesDownTo()
2310 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2311 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2312 (WTR::TestRunner::setStatisticsLastSeen):
2313 (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2314 (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2315 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2316 * WebKitTestRunner/TestController.cpp:
2317 (WTR::TestController::setStatisticsLastSeen):
2318 (WTR::TestController::setMaxStatisticsEntries):
2319 (WTR::TestController::setPruneEntriesDownTo):
2320 * WebKitTestRunner/TestController.h:
2321 * WebKitTestRunner/TestInvocation.cpp:
2322 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2323 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2324 (WTR::TestController::setStatisticsLastSeen):
2325 (WTR::TestController::setStatisticsMaxStatisticsEntries):
2326 (WTR::TestController::setStatisticsPruneEntriesDownTo):
2328 2017-07-03 Brian Burg <bburg@apple.com>
2330 Web Replay: remove some unused code
2331 https://bugs.webkit.org/show_bug.cgi?id=173903
2333 Rubber-stamped by Joseph Pecoraro.
2335 * Scripts/run-input-generator-tests: Removed.
2336 * Scripts/webkitpy/replay/__init__.py: Removed.
2337 * Scripts/webkitpy/replay/main.py: Removed.
2339 2017-07-10 Zan Dobersek <zdobersek@igalia.com>
2341 [WPE] Fix layout test baseline and TestExpectations hierarchy
2342 https://bugs.webkit.org/show_bug.cgi?id=174092
2344 Reviewed by Michael Catanzaro.
2346 Like for the GTK+ port, override the default_baseline_search_path() and
2347 _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
2348 Both methods operate on a short list of search paths that defaults to 'wpe' and
2349 'wk2', along with any other user-specified platform directory.
2351 The test_expectations_file_position() method is overridden for testing purposes,
2352 and relevant unit tests are added.
2354 * Scripts/webkitpy/port/wpe.py:
2355 (WPEPort._search_paths):
2357 (WPEPort.default_baseline_search_path):
2358 (WPEPort._port_specific_expectations_files):
2359 (WPEPort.test_expectations_file_position):
2360 * Scripts/webkitpy/port/wpe_unittest.py:
2361 (WPEPortTest.test_default_baseline_search_path):
2363 (WPEPortTest.test_port_specific_expectations_files):
2365 2017-07-10 Chris Dumez <cdumez@apple.com>
2367 Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
2368 https://bugs.webkit.org/show_bug.cgi?id=174301
2370 Reviewed by Brent Fulgham.
2372 Rename some of the testRunner API for clarity and to better match what it calls
2375 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2376 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2377 (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2378 (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2379 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2380 * WebKitTestRunner/TestController.cpp:
2381 (WTR::TestController::statisticsUpdateCookiePartitioning):
2382 (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2383 * WebKitTestRunner/TestController.h:
2384 * WebKitTestRunner/TestInvocation.cpp:
2385 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2386 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2387 (WTR::TestController::statisticsUpdateCookiePartitioning):
2388 (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2390 2017-07-10 Charlie Turner <cturner@igalia.com>
2392 [GStreamer] Live twitch.tv videos do not play
2393 https://bugs.webkit.org/show_bug.cgi?id=174222
2395 Reviewed by Michael Catanzaro.
2397 Upgrade GStreamer to 1.10.5. It contains a change to typefind that
2398 fixes videos not playing on twitch.tv.
2400 * gtk/jhbuild.modules:
2402 2017-07-09 Zan Dobersek <zdobersek@igalia.com>
2404 Add WebGL2 configuration option to build-webkit
2405 https://bugs.webkit.org/show_bug.cgi?id=174251
2407 Reviewed by Michael Catanzaro.
2409 * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
2410 to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
2411 is marked as enabled for the Apple Cocoa ports.
2413 2017-07-08 Chris Dumez <cdumez@apple.com>
2415 Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
2416 https://bugs.webkit.org/show_bug.cgi?id=174290
2418 Reviewed by Brent Fulgham.
2420 Rename testRunner API to match the new internal API names.
2422 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2423 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2424 (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2425 (WTR::TestRunner::statisticsSubmitTelemetry):
2426 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2427 * WebKitTestRunner/TestController.cpp:
2428 (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2429 (WTR::TestController::statisticsSubmitTelemetry):
2430 * WebKitTestRunner/TestController.h:
2431 * WebKitTestRunner/TestInvocation.cpp:
2432 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2433 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2434 (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2435 (WTR::TestController::statisticsSubmitTelemetry):
2437 2017-07-08 Yusuke Suzuki <utatane.tea@gmail.com>
2439 Drop NOSNIFF compile flag
2440 https://bugs.webkit.org/show_bug.cgi?id=174289
2442 Reviewed by Michael Catanzaro.
2444 * Scripts/webkitperl/FeatureList.pm:
2445 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2447 2017-07-07 Wenson Hsieh <wenson_hsieh@apple.com>
2449 [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
2450 https://bugs.webkit.org/show_bug.cgi?id=174219
2451 <rdar://problem/32083177>
2453 Reviewed by Ryosuke Niwa.
2455 Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
2456 Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
2457 in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
2460 Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
2461 different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
2462 no action is taken when dropping.
2464 * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
2465 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2466 (TestWebKitAPI::TEST):
2467 * TestWebKitAPI/ios/DataInteractionSimulator.h:
2468 * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2469 (-[MockDragDropSession initWithItems:location:window:allowMove:]):
2470 (-[MockDragDropSession allowsMoveOperation]):
2471 (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
2472 (-[MockDataInteractionSession initWithWindow:allowMove:]):
2473 (-[DataInteractionSimulator initWithWebView:]):
2474 (-[DataInteractionSimulator runFrom:to:]):
2475 (-[DataInteractionSimulator _advanceProgress]):
2476 (-[MockDragDropSession initWithItems:location:window:]): Deleted.
2477 (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
2478 (-[MockDataInteractionSession initWithWindow:]): Deleted.
2480 2017-07-07 Commit Queue <commit-queue@webkit.org>
2482 Unreviewed, rolling out r219238, r219239, and r219241.
2483 https://bugs.webkit.org/show_bug.cgi?id=174265
2485 "fast/workers/dedicated-worker-lifecycle.html is flaky"
2486 (Requested by yusukesuzuki on #webkit).
2488 Reverted changesets:
2490 "[WTF] Implement WTF::ThreadGroup"
2491 https://bugs.webkit.org/show_bug.cgi?id=174081
2492 http://trac.webkit.org/changeset/219238
2494 "Unreviewed, build fix after r219238"
2495 https://bugs.webkit.org/show_bug.cgi?id=174081
2496 http://trac.webkit.org/changeset/219239
2498 "Unreviewed, CLoop build fix after r219238"
2499 https://bugs.webkit.org/show_bug.cgi?id=174081
2500 http://trac.webkit.org/changeset/219241
2502 2017-07-07 Yusuke Suzuki <utatane.tea@gmail.com>
2504 [GTK][WPE] Enable X-Content-Type-Options: nosniff
2505 https://bugs.webkit.org/show_bug.cgi?id=174250
2507 Reviewed by Carlos Alberto Lopez Perez.
2509 * Scripts/webkitperl/FeatureList.pm:
2511 2017-07-07 Charlie Turner <cturner@igalia.com>
2512 [GStreamer] vid.me videos do not play
2513 https://bugs.webkit.org/show_bug.cgi?id=172240
2515 Reviewed by Xabier Rodriguez-Calvar.
2517 Build httpsoupsrc again for use in adaptive streaming pipelines, and
2518 have the existing libsoup build against GNOME to avoid header drift
2519 against GStreamer's linked Soup library.
2521 * gtk/jhbuild.modules:
2523 2017-07-06 Lucas Forschler <lforschler@apple.com>
2525 Write a support script to enable buildbot to upload to S3
2526 https://bugs.webkit.org/show_bug.cgi?id=174196
2528 Reviewed by Stephanie Lewis.
2530 * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
2534 2017-07-06 Lucas Forschler <lforschler@apple.com>
2536 Enabling uploading archives to S3.
2537 https://bugs.webkit.org/show_bug.cgi?id=174198
2539 Reviewed by Stephanie Lewis.
2541 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2542 (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2543 (UploadMinifiedBuiltProduct): Upload minified archive to build master
2544 (TransferToS3): Transfer full and minified archives to S3
2546 2017-07-05 Yusuke Suzuki <utatane.tea@gmail.com>
2548 [WTF] Implement WTF::ThreadGroup
2549 https://bugs.webkit.org/show_bug.cgi?id=174081
2551 Reviewed by Mark Lam.
2553 Add WTF::ThreadGroup tests.
2555 * TestWebKitAPI/CMakeLists.txt:
2556 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2557 * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2558 (TestWebKitAPI::TEST):
2560 2017-07-06 Yusuke Suzuki <utatane.tea@gmail.com>
2562 [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2563 https://bugs.webkit.org/show_bug.cgi?id=174150
2565 Reviewed by Mark Lam.
2567 * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2568 (TestWebKitAPI::TEST):
2569 * TestWebKitAPI/TestsController.cpp:
2570 (TestWebKitAPI::TestsController::TestsController):
2572 2017-07-06 Lucas Forschler <lforschler@apple.com>
2574 Enabling uploading archives to S3.
2575 https://bugs.webkit.org/show_bug.cgi?id=174198
2577 Reviewed by Lucas Forschler.
2579 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2580 (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2581 (UploadMinifiedBuiltProduct): Upload minified archive to build master
2582 (TransferToS3): Transfer full and minified archives to S3
2584 2017-07-06 Carlos Alberto Lopez Perez <clopez@igalia.com>
2586 [GTK][WPE] kill-old-process should kill more webkit related process
2587 https://bugs.webkit.org/show_bug.cgi?id=174220
2589 Reviewed by Michael Catanzaro.
2591 Generate list of possible webkit-related process names and add
2592 them to the list of process to kill.
2593 Also update the possible system related process for GTK+/WPE.
2595 * BuildSlaveSupport/kill-old-processes:
2596 (listAllWebKitPrograms):
2599 2017-07-06 Chris Dumez <cdumez@apple.com>
2601 FileMonitor should not be ref counted
2602 https://bugs.webkit.org/show_bug.cgi?id=174166
2604 Reviewed by Brent Fulgham.
2606 Update the API tests to reflect the API change.
2608 * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2609 (TestWebKitAPI::TEST_F):
2611 2017-07-06 Commit Queue <commit-queue@webkit.org>
2613 Unreviewed, rolling out r219194.
2614 https://bugs.webkit.org/show_bug.cgi?id=174207
2616 it broke some layout tests (Requested by clopez on #webkit).
2620 "[GStreamer] vid.me videos do not play"
2621 https://bugs.webkit.org/show_bug.cgi?id=172240
2622 http://trac.webkit.org/changeset/219194
2624 2017-07-06 Matt Lewis <jlewis3@apple.com>
2626 Unreviewed, rolling out r219178.
2628 This caused a consistent failure with the API test
2629 StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2633 "[WTF] Clean up StringStatics.cpp by using
2634 LazyNeverDestroyed<> for Atoms"
2635 https://bugs.webkit.org/show_bug.cgi?id=174150
2636 http://trac.webkit.org/changeset/219178
2638 2017-07-06 Alicia Boya García <aboya@igalia.com>
2640 Add CWD to Perl library path (no longer the default since 5.26.0)
2641 https://bugs.webkit.org/show_bug.cgi?id=174200
2643 Reviewed by Michael Catanzaro.
2645 * Scripts/webkitpy/tool/commands/setupgitclone.py:
2646 (SetupGitClone._get_username_and_email):
2648 2017-07-06 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2650 Unreviewed, update my email address.
2652 * Scripts/webkitpy/common/config/contributors.json:
2654 2017-07-06 Charlie Turner <cturner@igalia.com>
2655 [GStreamer] vid.me videos do not play
2656 https://bugs.webkit.org/show_bug.cgi?id=172240
2658 Reviewed by Xabier Rodriguez-Calvar.
2660 Build httpsoupsrc again for use in adaptive streaming pipelines, and
2661 have the existing libsoup build against GNOME to avoid header drift
2662 against GStreamer's linked Soup library.
2664 * gtk/jhbuild.modules:
2666 2017-07-05 Don Olmstead <don.olmstead@sony.com>
2668 [WTF] Move SoftLinking.h into WTF
2669 https://bugs.webkit.org/show_bug.cgi?id=174000
2671 Reviewed by Alex Christensen.
2673 * DumpRenderTree/mac/TestRunnerMac.mm:
2674 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2675 (test_primary_header):
2676 (ErrorCollector.__init__): Deleted.
2677 (ErrorCollector.__call__): Deleted.
2678 (ErrorCollector.results): Deleted.
2679 (ErrorCollector.result_list): Deleted.
2680 (ErrorCollector.verify_all_categories_are_seen): Deleted.
2681 (MockIo.open): Deleted.
2682 (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
2683 (CppFunctionsTest.test_create_acronym): Deleted.
2684 (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
2685 (CppFunctionsTest.test_parameter): Deleted.
2686 (CppFunctionsTest.test_single_line_view): Deleted.
2687 (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
2688 (CppFunctionsTest.test_find_parameter_name_index): Deleted.
2689 (CppFunctionsTest.test_parameter_list): Deleted.
2690 (CppFunctionsTest.test_check_parameter_against_text): Deleted.
2691 (CppStyleTestBase.process_file_data): Deleted.
2692 (CppStyleTestBase.perform_lint): Deleted.
2693 (CppStyleTestBase.perform_single_line_lint): Deleted.
2694 (CppStyleTestBase.perform_multi_line_lint): Deleted.
2695 (CppStyleTestBase.perform_language_rules_check): Deleted.
2696 (CppStyleTestBase.perform_function_lengths_check): Deleted.
2697 (CppStyleTestBase.perform_pass_ptr_check): Deleted.
2698 (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
2699 (CppStyleTestBase.perform_include_what_you_use): Deleted.
2700 (CppStyleTestBase.perform_header_guard_check): Deleted.
2701 (CppStyleTestBase.assert_lint): Deleted.
2702 (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
2703 (CppStyleTestBase.assert_multi_line_lint): Deleted.
2704 (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
2705 (CppStyleTestBase.assert_language_rules_check): Deleted.
2706 (CppStyleTestBase.assert_include_what_you_use): Deleted.
2707 (CppStyleTestBase.assert_header_guard): Deleted.
2708 (CppStyleTestBase.assert_blank_lines_check): Deleted.
2709 (CppStyleTestBase.assert_positions_equal): Deleted.
2710 (FunctionDetectionTest.test_basic_function_detection): Deleted.
2711 (FunctionDetectionTest.test_function_declaration_detection): Deleted.
2712 (FunctionDetectionTest.test_pure_function_detection): Deleted.
2713 (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
2714 (FunctionDetectionTest.test_ignore_macros): Deleted.
2715 (FunctionDetectionTest.test_non_functions): Deleted.
2716 (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
2717 (FunctionDetectionTest.test_parameter_list): Deleted.
2718 (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
2719 (CppStyleTest.test_asm_lines_ignored): Deleted.
2720 (CppStyleTest.test_get_line_width): Deleted.
2721 (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
2722 (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
2723 (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
2724 (CppStyleTest.test_position): Deleted.
2725 (CppStyleTest.test_rfind_in_lines): Deleted.
2726 (CppStyleTest.test_close_expression): Deleted.
2727 (CppStyleTest.test_spaces_at_end_of_line): Deleted.
2728 (CppStyleTest.test_cstyle_cast): Deleted.
2729 (CppStyleTest.test_runtime_casting): Deleted.
2730 (CppStyleTest.test_runtime_selfinit): Deleted.
2731 (CppStyleTest.test_runtime_rtti): Deleted.
2732 (CppStyleTest.test_static_cast_readability): Deleted.
2733 (CppStyleTest.test_check_for_unnamed_params): Deleted.
2734 (CppStyleTest.void): Deleted.
2735 (CppStyleTest.test_deprecated_cast): Deleted.
2736 (CppStyleTest.test_mock_method): Deleted.
2737 (CppStyleTest.test_sizeof_type): Deleted.
2738 (CppStyleTest.cases): Deleted.
2739 (CppStyleTest.for): Deleted.
2740 (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
2741 (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
2742 (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
2743 (CppStyleTest.test_include_what_you_use): Deleted.
2744 (CppStyleTest.test_files_belong_to_same_module): Deleted.
2745 (CppStyleTest.test_cleanse_line): Deleted.
2746 (CppStyleTest.test_multi_line_comments): Deleted.
2747 (CppStyleTest.test_multi_line_comments.Foo): Deleted.
2748 (CppStyleTest.test_multiline_strings): Deleted.
2749 (CppStyleTest.test_platformh_comments): Deleted.
2750 (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
2751 (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
2752 (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
2753 (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
2754 (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
2755 (CppStyleTest.test_suspicious_usage_of_if): Deleted.
2756 (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
2757 (CppStyleTest.test_check_posix_threading): Deleted.
2758 (CppStyleTest.test_insecure_string_operations): Deleted.
2759 (CppStyleTest.test_format_strings): Deleted.
2760 (CppStyleTest.test_insecure_temp_file): Deleted.
2761 (CppStyleTest.test_variable_length_array_detection): Deleted.
2762 (CppStyleTest.test_braces): Deleted.
2763 (CppStyleTest.test_check_check): Deleted.
2764 (CppStyleTest.test_brace_at_begin_of_line): Deleted.
2765 (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
2766 (CppStyleTest.test_spacing_for_fncall): Deleted.
2767 (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
2768 (CppStyleTest.test_spacing_before_braces): Deleted.
2769 (CppStyleTest.test_spacing_between_braces): Deleted.
2770 (CppStyleTest.test_spacing_before_brackets): Deleted.
2771 (CppStyleTest.test_cpp_lambda_functions): Deleted.
2772 (CppStyleTest.test_objective_c_block): Deleted.
2773 (CppStyleTest.test_objective_c_block_as_argument): Deleted.
2774 (CppStyleTest.test_spacing_around_else): Deleted.
2775 (CppStyleTest.test_spacing_for_binary_ops): Deleted.
2776 (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
2777 (CppStyleTest.test_operator_methods): Deleted.
2778 (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
2779 (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
2780 (CppStyleTest.test_static_or_global_stlstrings): Deleted.
2781 (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
2782 (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
2783 (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
2784 (CppStyleTest.test_space_after_comment_marker): Deleted.
2785 (CppStyleTest.test_newline_at_eof): Deleted.
2786 (CppStyleTest.test_newline_at_eof.do_test): Deleted.
2787 (CppStyleTest.test_extra_newlines_at_eof): Deleted.
2788 (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
2789 (CppStyleTest.test_invalid_utf8): Deleted.
2790 (CppStyleTest.test_invalid_utf8.do_test): Deleted.
2791 (CppStyleTest.test_is_blank_line): Deleted.
2792 (CppStyleTest.test_blank_lines_check): Deleted.
2793 (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
2794 (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
2795 (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
2796 (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
2797 (CppStyleTest.test_comma): Deleted.
2798 (CppStyleTest.test_declaration): Deleted.
2799 (CppStyleTest.test_pointer_reference_marker_location): Deleted.
2800 (CppStyleTest.test_indent): Deleted.
2801 (CppStyleTest.test_indent.Foo): Deleted.
2802 (CppStyleTest.test_not_alabel): Deleted.
2803 (CppStyleTest.test_tab): Deleted.
2804 (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
2805 (CppStyleTest.test_build_class): Deleted.
2806 (CppStyleTest.test_build_class.definitions): Deleted.
2807 (CppStyleTest.test_build_class.Foo): Deleted.
2808 (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
2809 (CppStyleTest.test_build_end_comment): Deleted.
2810 (CppStyleTest.test_build_forward_decl): Deleted.
2811 (CppStyleTest.test_build_forward_decl.Foo): Deleted.
2812 (CppStyleTest.test_build_header_guard): Deleted.
2813 (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
2814 (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
2815 (CppStyleTest.test_build_printf_format): Deleted.
2816 (CppStyleTest.test_runtime_printf_format): Deleted.
2817 (CppStyleTest.assert_lintLogCodeOnError): Deleted.
2818 (CppStyleTest.test_build_storage_class): Deleted.
2819 (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
2820 (CppStyleTest.test_build_storage_class.declaration): Deleted.
2821 (CppStyleTest.test_build_storage_class.after): Deleted.
2822 (CppStyleTest.test_build_storage_class.is): Deleted.
2823 (CppStyleTest.test_legal_copyright): Deleted.
2824 (CppStyleTest.test_invalid_increment): Deleted.
2825 (CppStyleTest.test_enum_bitfields): Deleted.
2826 (CppStyleTest.test_plain_integral_bitfields): Deleted.
2827 (CleansedLinesTest.test_init_empty): Deleted.
2828 (CleansedLinesTest.test_collapse_strings): Deleted.
2829 (OrderOfIncludesTest.tearDown): Deleted.
2830 (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
2831 (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
2832 (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
2833 (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
2834 (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
2835 (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
2836 (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
2837 (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
2838 (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
2839 (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
2840 (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
2841 (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
2842 (OrderOfIncludesTest.test_primary_header): Deleted.
2843 (OrderOfIncludesTest.test_public_primary_header): Deleted.
2844 (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
2845 (OrderOfIncludesTest.test_classify_include): Deleted.
2846 (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
2847 (CheckForFunctionLengthsTest.tearDown): Deleted.
2848 (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
2849 (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
2850 (CheckForFunctionLengthsTest.trigger_lines): Deleted.
2851 (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
2852 (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
2853 (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
2854 (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
2855 (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
2856 (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
2857 (CheckForFunctionLengthsTest.function_body): Deleted.
2858 (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
2859 (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
2860 (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
2861 (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
2862 (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
2863 (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
2864 (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
2865 (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
2866 (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
2867 (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
2868 (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
2869 (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
2870 (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
2871 (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
2872 (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
2873 (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
2874 (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
2875 (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
2876 (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
2877 (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
2878 (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
2879 (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
2880 (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
2881 (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
2882 (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
2883 (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
2884 (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
2885 (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
2886 (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
2887 (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
2888 (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
2889 (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
2890 (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
2891 (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
2892 (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
2893 (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
2894 (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
2895 (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
2896 (NoNonVirtualDestructorsTest.test_no_error): Deleted.
2897 (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
2898 (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
2899 (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
2900 (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
2901 (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
2902 (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
2903 (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
2904 (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
2905 (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
2906 (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
2907 (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
2908 (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
2909 (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
2910 (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
2911 (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
2912 (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
2913 (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
2914 (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
2915 (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
2916 (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
2917 (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
2918 (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
2919 (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
2920 (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
2921 (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
2922 (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
2923 (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
2924 (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
2925 (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
2926 (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
2927 (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
2928 (LeakyPatternTest.test_get_dc): Deleted.
2929 (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
2930 (LeakyPatternTest.test_own_get_dc): Deleted.
2931 (LeakyPatternTest.test_create_dc): Deleted.
2932 (LeakyPatternTest.test_create_compatible_dc): Deleted.
2933 (WebKitStyleTest.test_indentation): Deleted.
2934 (WebKitStyleTest.test_indentation.Foo): Deleted.
2935 (WebKitStyleTest.test_indentation.Document): Deleted.
2936 (WebKitStyleTest.test_spacing): Deleted.
2937 (WebKitStyleTest.test_line_breaking): Deleted.
2938 (WebKitStyleTest.test_braces): Deleted.
2939 (WebKitStyleTest.test_braces.MyClass): Deleted.
2940 (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
2941 (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
2942 (WebKitStyleTest.test_braces.SOMETHING): Deleted.
2943 (WebKitStyleTest.test_null_false_zero): Deleted.
2944 (WebKitStyleTest.test_directive_indentation): Deleted.
2945 (WebKitStyleTest.test_using_std): Deleted.
2946 (WebKitStyleTest.test_using_namespace): Deleted.
2947 (WebKitStyleTest.test_max_macro): Deleted.
2948 (WebKitStyleTest.test_min_macro): Deleted.
2949 (WebKitStyleTest.test_wtf_move): Deleted.
2950 (WebKitStyleTest.test_ctype_fucntion): Deleted.
2951 (WebKitStyleTest.test_names): Deleted.
2952 (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2953 (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2954 (WebKitStyleTest.test_names.declarations): Deleted.
2955 (WebKitStyleTest.test_names.struct): Deleted.
2956 (WebKitStyleTest.test_names.VectorType): Deleted.
2957 (WebKitStyleTest.test_parameter_names): Deleted.
2958 (WebKitStyleTest.test_comments): Deleted.
2959 (WebKitStyleTest.test_webkit_export_check): Deleted.
2960 (WebKitStyleTest.test_member_initialization_list): Deleted.
2961 (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2962 (WebKitStyleTest.test_other): Deleted.
2963 (CppCheckerTest.mock_handle_style_error): Deleted.
2964 (CppCheckerTest._checker): Deleted.
2965 (CppCheckerTest.test_init): Deleted.
2966 (CppCheckerTest.test_eq): Deleted.
2967 (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2968 (CppCheckerTest.test_ne): Deleted.
2969 * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2970 * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2971 * TestWebKitAPI/cocoa/TestWKWebView.mm:
2972 * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2973 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2974 * WebKitTestRunner/ios/HIDEventGenerator.mm:
2976 2017-07-05 Saam Barati <sbarati@apple.com>
2978 NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2979 https://bugs.webkit.org/show_bug.cgi?id=174188
2980 <rdar://problem/30581423>
2982 Reviewed by Mark Lam.
2984 * Scripts/run-jsc-stress-tests:
2986 2017-07-05 Yusuke Suzuki <utatane.tea@gmail.com>
2988 [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2989 https://bugs.webkit.org/show_bug.cgi?id=174150
2991 Reviewed by Mark Lam.
2993 * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2994 (TestWebKitAPI::TEST):
2996 2017-07-03 Myles C. Maxfield <mmaxfield@apple.com>
2998 Remove copy of ICU headers from WebKit
2999 https://bugs.webkit.org/show_bug.cgi?id=116407
3001 Reviewed by Alex Christensen.
3003 * DumpRenderTree/mac/Configurations/Base.xcconfig:
3004 * TestWebKitAPI/Configurations/Base.xcconfig:
3005 * WebKitTestRunner/Configurations/Base.xcconfig:
3007 2017-07-05 Chris Dumez <cdumez@apple.com>
3009 Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
3010 https://bugs.webkit.org/show_bug.cgi?id=174163
3011 <rdar://problem/33067518>
3013 Reviewed by Alex Christensen.
3015 Add API test coverage.
3017 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3018 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
3021 2017-07-05 Wenson Hsieh <wenson_hsieh@apple.com>
3023 When dragging a selection, clearing the selection in dragstart should not crash the web process
3024 https://bugs.webkit.org/show_bug.cgi?id=174142
3025 <rdar://problem/33067501>
3027 Reviewed by Tim Horton.
3029 Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
3030 drag is starting up.
3032 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3033 * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
3034 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3035 (TestWebKitAPI::TEST):
3037 2017-07-05 Daniel Bates <dabates@apple.com>
3039 Do not pass API::FrameInfo for source frame or clear out page of target frame on
3041 https://bugs.webkit.org/show_bug.cgi?id=174170
3042 <rdar://problem/33140328>
3044 Reviewed by Brady Eidson.
3046 Update tests as needed for the behavior change.
3048 * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
3051 2017-07-05 Jonathan Bedard <jbedard@apple.com>
3053 Add WebKitPrivateFrameworkStubs for iOS 11
3054 https://bugs.webkit.org/show_bug.cgi?id=173988
3056 Reviewed by David Kilzer.
3058 * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
3059 should use the same directory for private framework stubs.
3060 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3062 2017-07-05 Eric Carlson <eric.carlson@apple.com>
3064 [MediaStream] Protect request and web view during gUM client callback
3065 https://bugs.webkit.org/show_bug.cgi?id=174096
3066 <rdar://problem/32833102>
3068 Reviewed by Youenn Fablet.
3070 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3071 * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3073 2017-07-05 Wenson Hsieh <wenson_hsieh@apple.com>
3075 Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
3077 * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3079 2017-07-05 Matt Lewis <jlewis3@apple.com>
3081 Unreviewed, rolling out r219128.
3083 Spoke with engineer who originally submitted, Patch for APi
3088 "Unreviewed, rolling out r219070."
3089 https://bugs.webkit.org/show_bug.cgi?id=174082
3090 http://trac.webkit.org/changeset/219128
3092 2017-07-05 Matt Lewis <jlewis3@apple.com>
3094 Unreviewed, rolling out r219070.
3096 This revision caused consistent failures of the API test
3097 UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
3101 "Pasting single words copied to UIPasteboard inserts URLs in
3103 https://bugs.webkit.org/show_bug.cgi?id=174082
3104 http://trac.webkit.org/changeset/219070
3106 2017-07-04 Michael Catanzaro <mcatanzaro@igalia.com>
3108 Remove unused EFL logo from bot watcher dashboard
3109 https://bugs.webkit.org/show_bug.cgi?id=174136
3111 Reviewed by Alexey Proskuryakov.
3113 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
3114 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
3116 2017-07-04 Michael Catanzaro <mcatanzaro@igalia.com>
3118 [GTK] Add more GTK bots to dashboard
3119 https://bugs.webkit.org/show_bug.cgi?id=174129
3121 Reviewed by Carlos Alberto Lopez Perez.
3123 We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
3126 This also changes the sort order to put WPE above GTK so that it's not buried under all the
3127 less-essential GTK bots.
3129 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3130 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3133 2017-07-04 Michael Catanzaro <mcatanzaro@igalia.com>
3135 [WPE] Add WPE to bot watcher dashboard
3136 https://bugs.webkit.org/show_bug.cgi?id=174119
3138 Reviewed by Alexey Proskuryakov.
3140 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
3141 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
3142 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
3143 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3144 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3146 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3147 (table.queue-grid tr.platform.linux-wpe img.logo):
3149 2017-07-03 Lucas Forschler <lforschler@apple.com>
3151 https://bugs.webkit.org/show_bug.cgi?id=174105
3153 Reviewed by Stephanie Lewis.
3155 * BuildSlaveSupport/built-product-archive:
3156 (main): Add a -minify parser option
3157 (createZip): Pass along the optional Minify argument if requested
3158 (minifySource): This will trim down archives, logic limited to Mac platform.
3160 2017-07-03 Matt Rajca <mrajca@apple.com>
3162 Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
3163 https://bugs.webkit.org/show_bug.cgi?id=174103
3165 Reviewed by Alex Christensen.
3169 * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
3170 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3172 * TestWebKitAPI/cocoa/TestWKWebView.h:
3173 * TestWebKitAPI/cocoa/TestWKWebView.mm:
3174 (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
3176 2017-07-03 Matt Lewis <jlewis3@apple.com>
3178 Unreviewed, rolling out r219103.
3180 Caused multiple build failures.
3184 "Remove copy of ICU headers from WebKit"
3185 https://bugs.webkit.org/show_bug.cgi?id=116407
3186 http://trac.webkit.org/changeset/219103
3188 2017-07-03 Myles C. Maxfield <mmaxfield@apple.com>
3190 Remove copy of ICU headers from WebKit
3191 https://bugs.webkit.org/show_bug.cgi?id=116407
3193 Reviewed by Alex Christensen.
3195 Use WTF's copy of ICU headers.
3197 * DumpRenderTree/mac/Configurations/Base.xcconfig:
3198 * TestWebKitAPI/Configurations/Base.xcconfig:
3199 * WebKitTestRunner/Configurations/Base.xcconfig:
3201 2017-07-03 Brady Eidson <beidson@apple.com>
3203 Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3204 https://bugs.webkit.org/show_bug.cgi?id=174073
3206 Reviewed by Andy Estes.
3208 * DumpRenderTree/mac/TestRunnerMac.mm:
3209 (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
3211 * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
3212 (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3214 2017-07-03 Matt Lewis <jlewis3@apple.com>
3216 Unreviewed, rolling out r219083.
3218 The revision caused an API failure on all testing platforms.
3222 "[MediaStream] Protect request and web view during gUM client
3224 https://bugs.webkit.org/show_bug.cgi?id=174096
3225 http://trac.webkit.org/changeset/219083
3227 2017-07-03 Jonathan Bedard <jbedard@apple.com>
3229 webkitpy: Properly number duplicated crashlogs
3230 https://bugs.webkit.org/show_bug.cgi?id=172002
3232 Reviewed by Aakash Jain.
3234 * Scripts/webkitpy/common/system/crashlogs.py:
3235 (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
3236 an increasing integer.
3237 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3238 (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
3239 (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
3240 (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
3242 2017-07-03 Ryosuke Niwa <rniwa@webkit.org>
3244 WebContent processes crash when the network process crashes with pending connection requests
3245 https://bugs.webkit.org/show_bug.cgi?id=174065
3246 <rdar://problem/30359835>
3248 Reviewed by Tim Horton.
3250 Add a API to ensure UI process tries to relaunch a new network process when the network process
3251 crashes with pending network connection requests.
3253 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3254 * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
3255 * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3256 * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3257 (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
3259 2017-07-03 Eric Carlson <eric.carlson@apple.com>
3261 [MediaStream] Protect request and web view during gUM client callback
3262 https://bugs.webkit.org/show_bug.cgi?id=174096
3263 <rdar://problem/32833102>
3265 Reviewed by Youenn Fablet.
3267 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3268 * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3270 2017-07-03 Andy Estes <aestes@apple.com>
3272 [Xcode] Add an experimental setting to build with ccache
3273 https://bugs.webkit.org/show_bug.cgi?id=173875
3275 Reviewed by Tim Horton.
3277 On systems that already have ccache(1) installed, this patch adds experimental support for
3278 it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
3280 When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
3281 finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
3282 find the toolchain from which to run clang, and then invokes ccache with the required
3285 ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
3286 precompiled headers to work properly [1].
3288 LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
3289 ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
3292 [1] https://ccache.samba.org/manual.html#_precompiled_headers
3294 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3295 * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3296 * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3297 * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
3298 * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
3299 * ccache/README.md: Added.
3300 * ccache/ccache-clang: Added.
3301 * ccache/ccache-clang++: Added.
3302 * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
3304 2017-07-03 Alex Christensen <achristensen@webkit.org>
3306 REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3307 https://bugs.webkit.org/show_bug.cgi?id=174051
3309 Reviewed by Tim Horton.
3311 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3312 (TestWebKitAPI::TEST_F):
3314 2017-07-03 Matt Lewis <jlewis3@apple.com>
3316 Unreviewed, rolling out r219024.
3318 This patch cause 3 didferent test to fail.
3322 "REGRESSION(r215096) Queries of URLs with non-special schemes
3323 should not percent-encode single quotes"
3324 https://bugs.webkit.org/show_bug.cgi?id=174051
3325 http://trac.webkit.org/changeset/219024
3327 2017-07-03 Chris Dumez <cdumez@apple.com>
3329 Drop ResourceLoadStatisticsStore's statisticsLock
3330 https://bugs.webkit.org/show_bug.cgi?id=174080
3332 Reviewed by Brent Fulgham.
3334 Port WebKitTestRunner to new Asynchronous Cocoa SPI.
3336 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3337 (WTR::TestController::isStatisticsPrevalentResource):
3338 (WTR::TestController::isStatisticsHasHadUserInteraction):
3339 (WTR::TestController::isStatisticsGrandfathered):
3341 2017-07-03 Wenson Hsieh <wenson_hsieh@apple.com>
3343 Pasting single words copied to UIPasteboard inserts URLs in editable areas
3344 https://bugs.webkit.org/show_bug.cgi?id=174082
3345 <rdar://problem/33046992>
3347 Reviewed by Tim Horton.
3349 Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
3351 * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3352 (TestWebKitAPI::setUpWebViewForPasteboardTests):
3353 (TestWebKitAPI::TEST):
3355 2017-07-02 Brady Eidson <beidson@apple.com>
3357 Add API test for all parts of WebKit1 API related to favicons.
3358 https://bugs.webkit.org/show_bug.cgi?id=174069
3360 Reviewed by Andy Estes.
3362 These two API tests cover all WebKit1 API related to icons.
3364 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3365 * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
3367 (defaultFaviconData):
3368 (customFaviconData):
3370 (+[IconLoadingProtocol canInitWithRequest:]):
3371 (+[IconLoadingProtocol canonicalRequestForRequest:]):
3372 (-[IconLoadingProtocol startLoading]):
3373 (-[IconLoadingProtocol stopLoading]):
3374 (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3375 (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3376 (TestWebKitAPI::TEST):
3378 2017-07-01 Dan Bernstein <mitz@apple.com>
3380 [iOS] Remove code only needed when building for iOS 9.x
3381 https://bugs.webkit.org/show_bug.cgi?id=174068
3383 Reviewed by Tim Horton.
3385 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3386 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3387 (WTR::initializeWebViewConfiguration):
3388 * WebKitTestRunner/ios/HIDEventGenerator.mm:
3389 (-[HIDEventGenerator _createIOHIDEventType:]):
3391 2017-07-01 Brady Eidson <beidson@apple.com>
3393 When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
3394 <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
3396 Reviewed by Alex Christensen.
3398 * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3400 2017-07-01 Dan Bernstein <mitz@apple.com>
3402 [macOS] Remove code only needed when building for OS X Yosemite
3403 https://bugs.webkit.org/show_bug.cgi?id=174067
3405 Reviewed by Tim Horton.
3407 * DumpRenderTree/mac/Configurations/Base.xcconfig:
3408 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3409 * DumpRenderTree/mac/DumpRenderTree.mm:
3410 (setDefaultsToConsistentValuesForTesting):
3411 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3412 (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3413 * MiniBrowser/Configurations/Base.xcconfig:
3414 * MiniBrowser/Configurations/DebugRelease.xcconfig:
3415 * TestWebKitAPI/Configurations/Base.xcconfig:
3416 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3417 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3418 * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
3419 (TestWebKitAPI::TEST_F):
3420 * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
3421 * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3422 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3423 (TestWebKitAPI::TEST_F):
3424 * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3425 (TestWebKitAPI::TEST):
3426 * WebKitTestRunner/Configurations/Base.xcconfig:
3427 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3428 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3429 (WTR::InjectedBundle::platformInitialize):
3430 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3431 (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3433 2017-07-01 Chris Dumez <cdumez@apple.com>
3435 Replace ResourceLoadStatisticsStore C API with Cocoa SPI
3436 https://bugs.webkit.org/show_bug.cgi?id=174060
3438 Reviewed by Brent Fulgham.
3440 Port WebKitTestRunner over to the new Cocoa SPI.
3442 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3443 (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3444 (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3445 Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
3446 no-ops since this code runs in the WebContent process, not the
3449 * WebKitTestRunner/TestController.cpp:
3450 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3452 2017-06-30 Megan Gardner <megan_gardner@apple.com>
3454 Unreviewed mac build fix.
3456 * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
3457 (TestWebKitAPI::TEST):
3459 2017-06-30 Megan Gardner <megan_gardner@apple.com>
3461 Add API to get WKActivatedElementInfo
3462 https://bugs.webkit.org/show_bug.cgi?id=174001
3463 <rdar://problem/29165518>
3465 Tests for now SPI to get activatedElementInfo.
3467 Reviewed by Tim Horton.
3469 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3470 * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
3471 (TestWebKitAPI::TEST):
3473 2017-06-30 Chris Dumez <cdumez@apple.com>
3475 Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
3476 https://bugs.webkit.org/show_bug.cgi?id=174038
3478 Reviewed by Brent Fulgham.
3480 Fix typo in API name.
3482 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3483 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3484 (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3485 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3486 * WebKitTestRunner/TestController.cpp:
3487 (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3488 * WebKitTestRunner/TestController.h:
3489 * WebKitTestRunner/TestInvocation.cpp:
3490 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3492 2017-06-30 Alex Christensen <achristensen@webkit.org>
3494 REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3495 https://bugs.webkit.org/show_bug.cgi?id=174051
3496 <rdar://problem/33002846>
3498 Reviewed by Tim Horton.
3500 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3501 (TestWebKitAPI::TEST_F):
3503 2017-06-30 Daniel Bates <dabates@apple.com>
3505 API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3506 https://bugs.webkit.org/show_bug.cgi?id=165160
3507 <rdar://problem/29451999>
3509 Reviewed by Brady Eidson.
3511 Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
3512 for navigations and window creation.
3514 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3515 * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
3516 (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3517 (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
3518 (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3521 2017-06-29 Jer Noble <jer.noble@apple.com>
3523 Make Legacy EME API controlled by RuntimeEnabled setting.
3524 https://bugs.webkit.org/show_bug.cgi?id=173994
3526 Reviewed by Sam Weinig.
3528 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3530 2017-06-30 Jonathan Bedard <jbedard@apple.com>
3532 Follow-up fix for r218996
3534 Unreviewed infrastructure fix.
3536 Repeated calls to 'ios_version' make the log noisy, memoize the function.
3538 * Scripts/webkitpy/port/ios_simulator.py:
3539 (IOSSimulatorPort): Memoize ios_version().
3541 2017-06-30 Wenson Hsieh <wenson_hsieh@apple.com>
3543 [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3544 https://bugs.webkit.org/show_bug.cgi?id=174017
3545 <rdar://problem/32959782>
3547 Reviewed by Simon Fraser.
3549 Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
3550 changes, the caret would appear outside of the iframe.
3552 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3553 * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
3554 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3555 (checkDragCaretRectIsContainedInRect):
3556 (TestWebKitAPI::TEST):
3557 * TestWebKitAPI/ios/DataInteractionSimulator.h:
3558 * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3559 (-[DataInteractionSimulator _resetSimulatedState]):
3560 (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3561 (-[DataInteractionSimulator _advanceProgress]):
3562 (-[DataInteractionSimulator lastKnownDragCaretRect]):
3564 2017-06-30 Jonathan Bedard <jbedard@apple.com>
3566 Add support for different versions of iOS when loading test expectations
3567 https://bugs.webkit.org/show_bug.cgi?id=173774
3568 <rdar://problem/32951132>
3570 Rubber-stamped by Aakash Jain.
3572 When running layout tests, we should support multiple version of iOS the same way we do Mac.
3574 * Scripts/webkitpy/port/ios.py:
3575 (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
3576 (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
3577 (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
3578 * Scripts/webkitpy/port/ios_device.py:
3579 (IOSDevicePort.ios_version): Ask connected devices for implementation.
3580 * Scripts/webkitpy/port/ios_device_unittest.py:
3581 (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
3582 (IOSDeviceTest.test_baseline_searchpath): Ditto.
3583 (IOSDeviceTest.test_expectations_ordering): Ditto.
3584 * Scripts/webkitpy/port/ios_simulator.py:
3585 (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
3588 2017-06-30 Jacobo Aragunde Pérez <jaragunde@igalia.com>
3590 Fontconfig build breaks with glibc 2.15+
3591 https://bugs.webkit.org/show_bug.cgi?id=174019
3593 Reviewed by Carlos Alberto Lopez Perez.
3595 Apply patch by Khem Raj adapted to fontconfig 2.11.1.
3597 * wpe/jhbuild.modules:
3598 * wpe/patches/fontconfig-avoi