3a353ca3a3d7f201f5e9f7a30e33fa4d42c3eb4b
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         REGRESSION(r219857): run-benchmark --allplans broken
4         https://bugs.webkit.org/show_bug.cgi?id=175186
5
6         Reviewed by Saam Barati.
7
8         r219857 forgot to update also the calls to BenchmarkRunner() that
9         is done when the script is run with --allplans.
10
11         To fix this (and avoid future issues like this), let's factorize
12         the calls to the benchhmark runner in a run_benchmark_plan()
13         function.
14
15         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
16         (run_benchmark_plan):
17         (start):
18
19 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
20
21         Dashboard bubbles sometimes show failure count instead of crash count
22         https://bugs.webkit.org/show_bug.cgi?id=175157
23         <rdar://problem/33709009>
24
25         Reviewed by Alexey Proskuryakov.
26
27         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
28         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
29
30 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
31
32         Add tests for NeverDestroyed
33         https://bugs.webkit.org/show_bug.cgi?id=175146
34
35         Reviewed by Darin Adler.
36
37         * CMakeLists.txt:
38         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
39         New files and sort.
40
41         * TestWebKitAPI/Tests/WTF/Logger.h:
42         * TestWebKitAPI/Tests/WTF/Logger.cpp:
43         (TestWebKitAPI::log):
44         (TestWebKitAPI::takeLogStr):
45         * TestWebKitAPI/Tests/WTF/RefLogger.h:
46         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
47         (TestWebKitAPI::log): Deleted.
48         (TestWebKitAPI::takeLogStr): Deleted.
49         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
50
51         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
52         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
53         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
54         (TestWebKitAPI::LifecycleLogger::operator=):
55         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
56         (TestWebKitAPI::LifecycleLogger::setName):
57         (TestWebKitAPI::TEST):
58         Add a class that logs construction / assignment / modifications.
59
60         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
61         (TestWebKitAPI::TEST):
62         (TestWebKitAPI::list):
63         Test construction behavior is as expected both directly and using makeNeverDestroyed.
64
65 2017-08-04  Lucas Forschler  <lforschler@apple.com>
66
67         minification logic is not implemented for ios builds
68         <rdar://problem/33726561>
69
70         Reviewed by Dean Johnson
71
72         * BuildSlaveSupport/built-product-archive:
73         (minifyDirectory): refactor minifySource -> minifyDirectory
74         (archiveBuiltProduct): add ios minification logic
75         (minifySource): Deleted.
76
77 2017-08-04  Matt Lewis  <jlewis3@apple.com>
78
79         Unreviewed, rolling out r220271.
80
81         Rolling out due to Layout Test failing on iOS Simulator.
82
83         Reverted changeset:
84
85         "Remove STREAMS_API compilation guard"
86         https://bugs.webkit.org/show_bug.cgi?id=175165
87         http://trac.webkit.org/changeset/220271
88
89 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
90
91         Unreviewed, rolling out r220268.
92
93         This change caused assertion failures on macOS and iOS Debug
94         WK2.
95
96         Reverted changeset:
97
98         "Resource Load Statistics: Report user interaction
99         immediately, but only when needed"
100         https://bugs.webkit.org/show_bug.cgi?id=175090
101         http://trac.webkit.org/changeset/220268
102
103 2017-08-04  Youenn Fablet  <youenn@apple.com>
104
105         Remove STREAMS_API compilation guard
106         https://bugs.webkit.org/show_bug.cgi?id=175165
107
108         Reviewed by Darin Adler.
109
110         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
111
112 2017-08-04  John Wilander  <wilander@apple.com>
113
114         Resource Load Statistics: Report user interaction immediately, but only when needed
115         https://bugs.webkit.org/show_bug.cgi?id=175090
116         <rdar://problem/33685546>
117
118         Reviewed by Chris Dumez.
119
120         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
121         (WTR::InjectedBundle::beginTesting):
122             Now calls WebCore::ResourceLoadObserver::clearState().
123
124 2017-08-03  Brian Burg  <bburg@apple.com>
125
126         Remove ENABLE(WEB_SOCKET) guards
127         https://bugs.webkit.org/show_bug.cgi?id=167044
128
129         Reviewed by Joseph Pecoraro.
130
131         * Scripts/webkitperl/FeatureList.pm:
132         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
133
134 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
135
136         REGRESSION(r219850): run-benchmark script broken on Linux
137         https://bugs.webkit.org/show_bug.cgi?id=175126
138
139         Reviewed by Stephanie Lewis.
140
141         The run-benchmark script dynamically generates the list of supported
142         browsers and platforms (currently Linux and OSX) by loading all
143         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
144         and getting the browser_name and platform variables from the
145         classes defined there.
146
147         This means that this classes should not raise an exception when
148         loaded on other platforms or otherwise they will broke the whole
149         script. Its fine if they raise an exception when executing any of
150         the methods they implement, but not when just loading/importing
151         the class.
152
153         Move the argument variable definitions that call on the platform
154         specific OSXBrowserDriver._screen_size() function from beeing
155         variables that are evaluated when loading the file, to be functions
156         that are only evaluated when the actual functionality needs to be
157         executed.
158
159         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
160         (OSXChromeDriver.launch_url):
161         (OSXChromeCanaryDriver.launch_url):
162         (create_args):
163         (create_chrome_options):
164         (create_window_size_arg):
165         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
166         (OSXFirefoxDriver.launch_url):
167         (OSXFirefoxNightlyDriver.launch_url):
168         (OSXFirefoxNightlyDriver.launch_driver):
169         (create_args):
170
171 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
172
173         [PAL] Move spi/cf directory into PAL
174         https://bugs.webkit.org/show_bug.cgi?id=175057
175
176         Reviewed by Antti Koivisto.
177
178         * Scripts/webkitpy/style/checker.py:
179         * Scripts/webkitpy/style/checker_unittest.py:
180         (GlobalVariablesTest.test_path_rules_specifier):
181
182         Ignore "readability/naming/underscores" style errors for sources
183         under the WebCore/PAL/pal/spi directory.
184
185         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
186
187 2017-08-03  Youenn Fablet  <youenn@apple.com>
188
189         Remove FETCH_API compilation guard
190         https://bugs.webkit.org/show_bug.cgi?id=175154
191
192         Reviewed by Chris Dumez.
193
194         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
195
196 2017-08-03  Lucas Forschler  <lforschler@apple.com>
197
198         Enable archive minification on iOS builds
199         https://bugs.webkit.org/show_bug.cgi?id=174718
200         
201         Reviewed by Aakash Jain.
202
203         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
204         (BuildFactory.__init__):
205
206 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
207
208         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
209         https://bugs.webkit.org/show_bug.cgi?id=175140
210
211         Reviewed by Alexey Proskuryakov.
212
213         We are having lately issues with JSC tests causing problems on
214         the GTK+ and WPE bots due to the high amount of memory some tests
215         need to run.
216
217         The best thing we can do now is to workaround this by disabling
218         all the tests marked as memoryLimited on the GTK and WPE bots.
219         We may revise this on the future.
220
221         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
222         (RunJavaScriptCoreTests.start):
223
224 2017-08-03  Brady Eidson  <beidson@apple.com>
225
226         Add SW IDLs and stub out basic functionality.
227         https://bugs.webkit.org/show_bug.cgi?id=175115
228
229         Reviewed by Chris Dumez.
230
231         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
232
233         * Scripts/webkitpy/bindings/main.py:
234
235 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
236
237         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
238         https://bugs.webkit.org/show_bug.cgi?id=159510
239
240         Reviewed by Daniel Bates.
241
242         Allow any https certificate when running tests.
243
244         * DumpRenderTree/win/DumpRenderTree.cpp:
245         (runTest):
246
247 2017-08-02  Youenn Fablet  <youenn@apple.com>
248
249         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
250         https://bugs.webkit.org/show_bug.cgi?id=175089
251
252         Reviewed by Chris Dumez.
253
254         * DumpRenderTree/TestOptions.mm:
255         (TestOptions::TestOptions): Using absolutePath if available.
256         * DumpRenderTree/mac/DumpRenderTree.mm:
257         (computeTestURL): Removing http/tests/ specific URL computation.
258         * Scripts/webkitpy/port/driver.py:
259         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
260
261 2017-08-02  Lucas Forschler  <lforschler@apple.com>
262
263         download-built-product should allow for a proxy option
264         https://bugs.webkit.org/show_bug.cgi?id=174875
265
266         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
267
268         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
269         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
270         
271
272 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
273
274         check-webkit-style: deleting lines in a file runs the linter on the whole file
275         https://bugs.webkit.org/show_bug.cgi?id=175078
276
277         Reviewed by David Kilzer.
278
279         Deleting lines in a file should not cause linter errors to be blamed on the patch.
280         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
281
282         * Scripts/webkitpy/style/checkers/test_expectations.py:
283         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
284         * Scripts/webkitpy/style/main_unittest.py:
285         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
286         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
287         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
288
289 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
290
291         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
292         https://bugs.webkit.org/show_bug.cgi?id=175075
293
294         Reviewed by David Kilzer.
295
296         We have no way of handling text files with illegal unicode characters. Allow the callers of
297         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
298         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
299
300         * Scripts/webkitpy/common/system/filesystem.py:
301         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
302         (FileSystem.write_text_file): Ditto.
303         * Scripts/webkitpy/common/system/filesystem_mock.py:
304         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
305         (MockFileSystem.write_text_file): Ditto.
306         * Scripts/webkitpy/common/system/filesystem_unittest.py:
307         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
308         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
309
310 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
311
312         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
313         https://bugs.webkit.org/show_bug.cgi?id=175072
314
315         Reviewed by Alexey Proskuryakov.
316
317         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
318         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
319
320 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
321
322         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
323         https://bugs.webkit.org/show_bug.cgi?id=175019
324
325         Reviewed by Darin Adler.
326
327         * TestWebKitAPI/CMakeLists.txt:
328
329 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
330
331         Enabling uploading archives to S3
332         https://bugs.webkit.org/show_bug.cgi?id=174198
333
334         Unreviewed unit test fix after r219235.
335
336         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
337
338 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
339
340         Fix JSCOnly ARM buildbots after r220047
341         https://bugs.webkit.org/show_bug.cgi?id=174993
342
343         Unreviewed fix after r220087.
344
345         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
346         (BuildAndRemoteJSCTestsFactory.__init__):
347
348 2017-08-01  Chris Dumez  <cdumez@apple.com>
349
350         Add initial support for navigator.sendBeacon
351         https://bugs.webkit.org/show_bug.cgi?id=175007
352         <rdar://problem/33547728>
353
354         Reviewed by Sam Weinig.
355
356         Enable the Beacon API at runtime in the context of layout tests since the
357         feature is currently disabled by default.
358
359         * DumpRenderTree/mac/DumpRenderTree.mm:
360         (enableExperimentalFeatures):
361         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
362         (WTR::InjectedBundle::beginTesting):
363         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
364         (WTR::TestRunner::setModernMediaControlsEnabled):
365         (WTR::TestRunner::setBeaconAPIEnabled):
366         * WebKitTestRunner/InjectedBundle/TestRunner.h:
367
368 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
369
370         Update Bot Watcher's Dashboard for Buildbot 0.9
371         https://bugs.webkit.org/show_bug.cgi?id=174777
372
373         Reviewed by Daniel Bates.
374
375         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
376         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
377         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
378         in a dictionary.
379         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
380         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
381         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
382         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
383         (parseRevisionProperty): Ditto.
384         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
385         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
386         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
387         have changed in Buildbot 0.9.
388         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
389         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
390         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
391         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
392         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
393         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
394         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
395         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
396         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
397         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
399         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
400         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
401         (BuildbotQueue.prototype.get overviewURL): Ditto.
402         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
403         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
404         Buildbot 0.8 or 0.9.
405         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
406         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
407         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
408         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
409         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
410         Therefore we are fetching information for fixed number of build. 
411         Also iterating the loop incrementally since the build data is already reverse sorted.
412         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
413         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
414         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
416         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
417
418 2017-08-01  Devin Rousso  <drousso@apple.com>
419
420         Web Inspector: simplify WebInspector with WI
421         https://bugs.webkit.org/show_bug.cgi?id=175058
422
423         Reviewed by Joseph Pecoraro.
424
425         * Scripts/check-inspector-strings:
426         (extract_ui_strings):
427         * Scripts/extract-localizable-js-strings:
428
429 2017-08-01  Youenn Fablet  <youenn@apple.com>
430
431         Layout tests with 'https' suffix should be run over HTTPS
432         https://bugs.webkit.org/show_bug.cgi?id=174992
433
434         Reviewed by Chris Dumez.
435
436         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
437         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
438         Covered by corresponding unit tests.
439
440         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
441         (run_server):
442         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
443         (base_http_url):
444         (base_https_url):
445         (base_url): Deleted.
446         * Scripts/webkitpy/port/base.py:
447         (Port.to.web_platform_test_server_base_http_url):
448         (Port.to):
449         (Port.to.web_platform_test_server_base_https_url):
450         (Port.to.web_platform_test_server_base_url): Deleted.
451         * Scripts/webkitpy/port/driver.py:
452         (Driver.__init__):
453         (Driver.wpt_test_path_to_uri):
454         (Driver):
455         (Driver.http_test_path_to_uri):
456         (Driver.test_to_uri):
457         (Driver.uri_to_test):
458         * Scripts/webkitpy/port/driver_unittest.py:
459         (DriverTest.test_test_to_uri):
460         (DriverTest.test_uri_to_test):
461
462 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
463
464         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
465         https://bugs.webkit.org/show_bug.cgi?id=173998
466
467         Reviewed by Darin Adler.
468
469         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
470         detect mistakes in backward compatibility in the future when we change it.
471
472         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
473         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
474         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
475         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
476         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
477         internal key data slot.
478
479         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
480         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
481         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
482         (getNextMessage):
483         (TEST):
484         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
485         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
486         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
487         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
488         These are the pre-baked databases.
489         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
490         This is the actual test that do all the reads and comparisons.
491         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
492         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
493         IndexedDB new stuffs. Then it can be used to bake the database again.
494
495 2017-08-01  Brady Eidson  <beidson@apple.com>
496
497         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
498         https://bugs.webkit.org/show_bug.cgi?id=175030
499
500         Reviewed by Andy Estes.
501
502         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
503         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
504
505 2017-08-01  Brady Eidson  <beidson@apple.com>
506
507         Part 2 of: Rename DatabaseProcess to StorageProcess.
508         https://bugs.webkit.org/show_bug.cgi?id=174880
509
510         Reviewed by Andy Estes.
511
512         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
513         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
514         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
515         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
516         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
517         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
518         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
519         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
520
521 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
522
523         Fix JSCOnly ARM buildbots after r220047
524         https://bugs.webkit.org/show_bug.cgi?id=174993
525
526         Reviewed by Saam Barati.
527
528         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
529         (BuildAndRemoteJSCTestsFactory.__init__):
530
531 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
532
533         [WTF] Introduce Private Symbols
534         https://bugs.webkit.org/show_bug.cgi?id=174935
535
536         Reviewed by Darin Adler.
537
538         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
539         (TestWebKitAPI::TEST):
540
541 2017-07-30  Darin Adler  <darin@apple.com>
542
543         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
544         https://bugs.webkit.org/show_bug.cgi?id=130653
545
546         Reviewed by Antti Koivisto.
547
548         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
549         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
550         when calling frameDidChangeLocation.
551         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
552         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
553         thus causing mysterious failures of a couple of tests. There are two remaining issues:
554         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
555         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
556         same logic flaw that causes "top loading frame" to get set to one of the subframes in
557         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
558         loading, subframe starts loading. It would be good to clean that up some day, but for now
559         this patch makes the two work identically rather than changing both.
560         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
561
562 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
563
564         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
565         https://bugs.webkit.org/show_bug.cgi?id=174963
566
567         Reviewed by Darin Adler.
568
569         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
570         RetainPtr<>. This patch changes them to all use auto.
571
572         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
573         (TestWebKitAPI::TEST):
574
575 2017-07-30  Brady Eidson  <beidson@apple.com>
576
577         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
578         https://bugs.webkit.org/show_bug.cgi?id=174958
579
580         Reviewed by Darin Adler.
581
582         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
583         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
584         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
585         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
586         (runUntilTasksInFlight):
587         (TEST):
588
589 2017-07-28  Commit Queue  <commit-queue@webkit.org>
590
591         Unreviewed, rolling out r219990.
592         https://bugs.webkit.org/show_bug.cgi?id=174961
593
594         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
595         estes on #webkit).
596
597         Reverted changeset:
598
599         "Part 2 of: Rename DatabaseProcess to StorageProcess."
600         https://bugs.webkit.org/show_bug.cgi?id=174880
601         http://trac.webkit.org/changeset/219990
602
603 2017-07-28  Brady Eidson  <beidson@apple.com>
604
605         API tests that use URLSchemeHandler are failing.
606         https://bugs.webkit.org/show_bug.cgi?id=174950
607
608         Reviewed by Alex Christensen.
609
610         Fix the NoMIMEType test to be correct.
611
612         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
613         (-[SchemeHandler initWithData:mimeType:]):
614         (-[SchemeHandler webView:startURLSchemeTask:]):
615         (TEST):
616
617 2017-07-28  Daniel Bates  <dabates@apple.com>
618
619         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
620         https://bugs.webkit.org/show_bug.cgi?id=174876
621
622         Reviewed by Alex Christensen.
623
624         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
625         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
626         they provide a more direct way to test the platform abstraction.
627
628         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
629
630         * Scripts/prepare-ChangeLog:
631         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
632         of the current working directory.
633
634 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
635
636         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
637         https://bugs.webkit.org/show_bug.cgi?id=174930
638
639         Unreviewed test fix.
640
641         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
642
643         * Scripts/prepare-ChangeLog:
644         (get_function_line_ranges_for_cpp):
645
646 2017-07-28  JF Bastien  <jfbastien@apple.com>
647
648         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
649         https://bugs.webkit.org/show_bug.cgi?id=174930
650
651         Reviewed by Daniel Bates.
652
653         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
654         here also teach it about const and volatile overloads. I didn't do
655         reference and rvalue reference overloads because we don't really
656         use them, and the current parser throws away those characters and
657         it doesn't seem worth making it more complex.
658
659         * Scripts/prepare-ChangeLog:
660         (get_function_line_ranges_for_cpp):
661         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
662         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
663         (Foo::Arrow::arrow):
664         (Foo::Arrow::otherArrow):
665         (Foo::Arrow::otherArrow const):
666         (Foo::Arrow::otherArrow volatile):
667         (Foo::Arrow::otherArrow const volatile):
668
669 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
670
671         [GTK] Building with ENABLE_VIDEO=OFF fails
672         https://bugs.webkit.org/show_bug.cgi?id=174940
673
674         Reviewed by Alex Christensen.
675
676         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
677         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
678
679         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
680         (methodCallCallback): Add missing USE(GSTREAMER) guard.
681
682 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
683
684         [WPE] Implement EventSenderProxy in WTR
685         https://bugs.webkit.org/show_bug.cgi?id=173419
686
687         Reviewed by Žan Doberšek.
688
689         Add the implementation of EventSenderProxy to the WTR. This
690         allows us to extend the coverage of the test suite in WKWPE.
691
692         * WebKitTestRunner/EventSenderProxy.h:
693         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
694         libxkbcommon needed to deal with key events.
695         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
696         (WTR::EventSenderProxy::EventSenderProxy):
697         (WTR::senderButtonToWPEButton):
698         (WTR::EventSenderProxy::mouseDown):
699         (WTR::EventSenderProxy::mouseUp):
700         (WTR::EventSenderProxy::mouseMoveTo):
701         (WTR::EventSenderProxy::mouseScrollBy):
702         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
703         (WTR::EventSenderProxy::leapForward):
704         (WTR::wkEventModifiersToWPE):
705         (WTR::getXKBKeySymForKeyRef):
706         (WTR::EventSenderProxy::keyDown):
707         (WTR::EventSenderProxy::addTouchPoint):
708         (WTR::EventSenderProxy::updateTouchPoint):
709         (WTR::EventSenderProxy::setTouchModifier):
710         (WTR::EventSenderProxy::setTouchPointRadius):
711         (WTR::EventSenderProxy::getUpdatedTouchEvents):
712         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
713         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
714         (WTR::EventSenderProxy::touchStart):
715         (WTR::EventSenderProxy::touchMove):
716         (WTR::EventSenderProxy::touchEnd):
717         (WTR::EventSenderProxy::touchCancel):
718         (WTR::EventSenderProxy::clearTouchPoints):
719         (WTR::EventSenderProxy::releaseTouchPoint):
720         (WTR::EventSenderProxy::cancelTouchPoint):
721
722 2017-07-27  Brady Eidson  <beidson@apple.com>
723
724         Part 2 of: Rename DatabaseProcess to StorageProcess.
725         https://bugs.webkit.org/show_bug.cgi?id=174880
726
727         Reviewed by Andy Estes.
728
729         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
730         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
731         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
732         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
733         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
734         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
735         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
736         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
737
738 2017-07-26  Mark Lam  <mark.lam@apple.com>
739
740         Add ability to only run specific tests in run-javascriptcore-tests.
741         https://bugs.webkit.org/show_bug.cgi?id=174884
742
743         Reviewed by Saam Barati.
744
745         For example, if we only want to run testapi, we can do so as follows:
746             $ run-javascriptcore-tests --testapi
747
748         Previously, specifying --testapi effectively does nothing because we run all tests
749         by default.  Only --no-testapi had the effect of disabling the test set.  This
750         old behavior for --testapi is not very useful or meaningful.  We're now changing
751         it to mean that we will only run that test.
752
753         With this change, we can also run more than one set of tests.  For example, if we
754         only want to run testmasm and testair, we can do so as follows:
755             $ run-javascriptcore-tests --testmasm --testair
756
757         By default, if no specific test option is specified, run-javascriptcore-tests will
758         run all tests.
759
760         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
761         the mozilla tests (--mozilla-tests) even though both are run via the lower level
762         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
763         the other set will not run.  For example, the following only runs the mozilla tests:
764             $ run-javascriptcore-tests --mozilla-tests
765
766         Note also that --jit-stress-tests is not for choosing a different set of tests.
767         Instead, it is used for determining whether we run JIT'ed test configurations
768         on the jsc stress tests and mozilla tests.  As a result, specifying
769         --jit-stress-tests will not omit other tests.  For example, the following still
770         runs all tests:
771             $ run-javascriptcore-tests --jit-stress-tests
772
773         * Scripts/run-javascriptcore-tests:
774         (defaultStringForTestState):
775         (enableTestOrNot):
776         (runJSCStressTests):
777
778 2017-07-26  Mark Lam  <mark.lam@apple.com>
779
780         Make run-javascriptcore-test run testair, testb3, and testmasm.
781         https://bugs.webkit.org/show_bug.cgi?id=174837
782         <rdar://problem/33522927>
783
784         Reviewed by Saam Barati and Filip Pizlo.
785
786         1. Refactors code for running testapi so that we can use it to run other tests.
787         2. Added running of testmasm, testair, testb3.
788
789         Note: the existing testapi invocation code does not support remote invocation of
790         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
791         and testb3 also do not support remote invocation.  If we wish to add remote
792         invocation support, we should do that in a separate patch.
793
794         * Scripts/run-javascriptcore-tests:
795         (testPath):
796         (runTest):
797         (testapiPath): Deleted.
798
799 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
800
801         Remove duplicate code from Buildbot.js in dashboard
802         https://bugs.webkit.org/show_bug.cgi?id=174870
803
804         Reviewed by Daniel Bates.
805
806         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
807         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
808         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
810         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
811
812 2017-07-26  Brady Eidson  <beidson@apple.com>
813
814         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
815         https://bugs.webkit.org/show_bug.cgi?id=174851
816
817         Reviewed by Chris Dumez.
818
819         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
820         (TEST):
821
822 2017-07-26  Brian Burg  <bburg@apple.com>
823
824         Remove WEB_TIMING feature flag
825         https://bugs.webkit.org/show_bug.cgi?id=174795
826
827         Reviewed by Alex Christensen.
828
829         * Scripts/webkitperl/FeatureList.pm:
830         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
831
832 2017-07-26  Chris Dumez  <cdumez@apple.com>
833
834         Pressing the Escape key should not be a valid user gesture to enter fullscreen
835         https://bugs.webkit.org/show_bug.cgi?id=174864
836         <rdar://problem/33009088>
837
838         Reviewed by Geoffrey Garen.
839
840         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
841         WKTR.
842
843         * DumpRenderTree/mac/EventSendingController.mm:
844         (-[EventSendingController keyDown:withModifiers:withLocation:]):
845
846 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
847
848         Unreviewed, added Romain Bellessort to contributors.json.
849
850         * Scripts/webkitpy/common/config/contributors.json:
851
852 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
853
854         [WPE] WebGL2 support
855         https://bugs.webkit.org/show_bug.cgi?id=174249
856
857         Reviewed by Alex Christensen.
858
859         * Scripts/webkitperl/FeatureList.pm:
860         Enable WebGL2 for WPE when building through build-webkit.
861
862 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
863
864         Unreviewed. Fix GTK distcheck.
865
866         * gtk/make-dist.py:
867         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
868
869 2017-07-25  Brady Eidson  <beidson@apple.com>
870
871         ResourceLoadStatistics grandfathering happens much too often.
872         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
873
874         Reviewed by Chris Dumez.
875
876         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
877         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
878         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
879         (TEST):
880
881 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
882
883         Fix autoinstaller failing on autoinstall_everything
884         https://bugs.webkit.org/show_bug.cgi?id=174830
885
886         Reviewed by Joseph Pecoraro.
887
888         * Scripts/webkitpy/thirdparty/__init__.py:
889         (AutoinstallImportHook.find_module):
890         (AutoinstallImportHook.install_chromedriver):
891         (AutoinstallImportHook.install_geckodriver):
892         (AutoinstallImportHook._install_chromedriver): Deleted.
893         (AutoinstallImportHook._install_geckodriver): Deleted.
894
895 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
896
897         Replace --runtime with something for both ios-simulator and ios-device
898         https://bugs.webkit.org/show_bug.cgi?id=173775
899         <rdar://problem/32952164>
900
901         Reviewed by Aakash Jain.
902
903         Add --version flag for both iOS simulator and iOS device.
904
905         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
906         (parse_args): Add --version flag and move --no-install.
907         * Scripts/webkitpy/port/factory.py:
908         (platform_options): Move --no-intall to run_webkit_tests.py.
909         * Scripts/webkitpy/port/ios.py:
910         (IOSPort):
911         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
912         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
913         * Scripts/webkitpy/port/ios_device.py:
914         (IOSDevicePort.ios_version): Consult --version flag before checking connected
915         devices for iOS version.
916         * Scripts/webkitpy/port/ios_device_unittest.py:
917         (IOSDeviceTest.make_port): Set --version option so that we can generate test
918         expectation paths without devices connected.
919         (IOSDeviceTest.test_additional_platform_directory): Deleted.
920         (IOSDeviceTest.test_baseline_searchpath): Deleted.
921         (IOSDeviceTest.test_expectations_ordering): Deleted.
922         * Scripts/webkitpy/port/ios_simulator.py:
923         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
924         flag to specify a runtime.
925         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
926         flag and then use the default runtime.
927
928 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
929
930         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
931         https://bugs.webkit.org/show_bug.cgi?id=174815
932
933         Reviewed by Carlos Alberto Lopez Perez.
934
935         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
936         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
937         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
938         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
939         think), probably because of a newer CMake version.
940
941         * CMakeLists.txt:
942         * TestWebKitAPI/CMakeLists.txt:
943         * TestWebKitAPI/PlatformGTK.cmake:
944
945 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
946
947         Fix BenchmarkRunner to only import selenium when needed
948         https://bugs.webkit.org/show_bug.cgi?id=174808
949
950         Reviewed by Stephanie Lewis.
951
952         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
953         (LinuxChromeDriver.launch_driver):
954         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
955         (LinuxFirefoxDriver.launch_driver):
956         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
957         (OSXChromeDriver.launch_driver):
958         (OSXChromeCanaryDriver.launch_driver):
959         (create_chrome_options):
960         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
961         (OSXFirefoxDriver.launch_driver):
962         (OSXFirefoxNightlyDriver.launch_driver):
963         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
964         (OSXSafariDriver.launch_driver):
965         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
966         (WebDriverBenchmarkRunner._run_one_test):
967
968 2017-07-23  Darin Adler  <darin@apple.com>
969
970         More NeverDestroyed and related cleanup
971         https://bugs.webkit.org/show_bug.cgi?id=174745
972
973         Reviewed by Alex Christensen.
974
975         * DumpRenderTree/JavaScriptThreading.cpp:
976         (javaScriptThreadsMutex): Use NeverDestroyed instead of
977         DEPRECATED_DEFINE_STATIC_LOCAL.
978         (javaScriptThreads): Ditto.
979
980 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
981
982         Subclass Benchmark Runner script for WebDriver support
983         https://bugs.webkit.org/show_bug.cgi?id=174390
984
985         Reviewed by Dewei Zhu, Stephanie Lewis.
986
987         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
988
989         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
990         (BenchmarkBuilder.__init__):
991         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
992         (BenchmarkRunner.__init__):
993         (BenchmarkRunner._find_plan_file):
994         (BenchmarkRunner._run_one_test.and):
995         (BenchmarkRunner.execute):
996         (BenchmarkRunner._get_result): Deleted.
997         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
998         (parse_args):
999         (start):
1000         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
1001         (WebDriverBenchmarkRunner):
1002         (WebDriverBenchmarkRunner._get_result):
1003         (WebDriverBenchmarkRunner._run_one_test):
1004         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
1005         (WebServerBenchmarkRunner):
1006         (WebServerBenchmarkRunner.__init__):
1007         (WebServerBenchmarkRunner._get_result):
1008         (WebServerBenchmarkRunner._run_one_test):
1009
1010 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1011
1012         Add BenchmarkRunner patches with WebDriver support for each testing plan
1013         https://bugs.webkit.org/show_bug.cgi?id=174443
1014
1015         Reviewed by Dewei Zhu, Stephanie Lewis.
1016
1017         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1018         (BenchmarkBuilder.__enter__):
1019         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
1020         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
1021         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
1022         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
1023         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
1024         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
1025         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
1026         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
1027         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
1028         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
1029         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
1030         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
1031         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
1032         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
1033         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
1034         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
1035         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
1036         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
1037         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
1038         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
1039         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
1040         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
1041         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1042         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
1043         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
1044         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
1045         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1046         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
1047         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
1048         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1049         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
1050         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
1051         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1052
1053 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1054
1055         Add functions to autoinstaller needed for Benchmark Runner script
1056         https://bugs.webkit.org/show_bug.cgi?id=174331
1057
1058         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
1059
1060         Adds autoinstaller functions to install selenium and webdriver binaries
1061         which will be used by the browser driver part of Benchmark Runner.
1062
1063         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1064         (BrowserDriver.restore_env):
1065         (BrowserDriver):
1066         (BrowserDriver.get_webdriver_binary_path):
1067         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1068         (LinuxChromeDriver.launch_driver):
1069         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1070         (LinuxFirefoxDriver.launch_driver):
1071         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1072         (OSXChromeDriver.launch_driver):
1073         (OSXChromeCanaryDriver.launch_driver):
1074         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1075         (OSXFirefoxDriver.launch_driver):
1076         (OSXFirefoxNightlyDriver.launch_driver):
1077         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1078         * Scripts/webkitpy/benchmark_runner/utils.py:
1079         (get_driver_binary_path):
1080         * Scripts/webkitpy/common/system/autoinstall.py:
1081         (AutoInstaller._unzip):
1082         * Scripts/webkitpy/thirdparty/__init__.py:
1083         (AutoinstallImportHook.find_module):
1084         (AutoinstallImportHook._install_selenium):
1085         (AutoinstallImportHook):
1086         (AutoinstallImportHook._install_chromedriver):
1087         (AutoinstallImportHook._install_geckodriver):
1088         (AutoinstallImportHook.get_latest_pypi_url):
1089         (AutoinstallImportHook.install_binary):
1090         (autoinstall_everything):
1091         (get_driver_filename):
1092         (get_os_info):
1093
1094 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
1095
1096         Add WebDriver support in browser driver part of BenchmarkRunner
1097         https://bugs.webkit.org/show_bug.cgi?id=174445
1098
1099         Reviewed by Stephanie Lewis.
1100
1101         Adds a launch_driver function to each BrowserDriver subclass. This
1102         function sets up the arguments for the webdriver and launches the
1103         webdriver specific to that browser.
1104
1105         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1106         (BrowserDriver.launch_webdriver):
1107         (BrowserDriver):
1108         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1109         (LinuxBrowserDriver.launch_webdriver):
1110         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
1111         (LinuxChromeDriver.launch_url):
1112         (LinuxChromeDriver):
1113         (LinuxChromeDriver.launch_driver):
1114         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
1115         (EpiphanyBrowserDriver.launch_url):
1116         (EpiphanyBrowserDriver):
1117         (EpiphanyBrowserDriver.launch_driver):
1118         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
1119         (LinuxFirefoxDriver):
1120         (LinuxFirefoxDriver.launch_url):
1121         (LinuxFirefoxDriver.launch_driver):
1122         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
1123         (GTKMiniBrowserDriver.launch_url):
1124         (GTKMiniBrowserDriver):
1125         (GTKMiniBrowserDriver.launch_driver):
1126         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1127         (OSXBrowserDriver._launch_webdriver):
1128         (OSXBrowserDriver):
1129         (OSXBrowserDriver._screen_size):
1130         (OSXBrowserDriver._insert_url):
1131         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1132         (OSXChromeDriver):
1133         (OSXChromeDriver.launch_url):
1134         (OSXChromeDriver.launch_driver):
1135         (OSXChromeCanaryDriver):
1136         (OSXChromeCanaryDriver.launch_url):
1137         (OSXChromeCanaryDriver.launch_driver):
1138         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1139         (OSXFirefoxDriver):
1140         (OSXFirefoxDriver.launch_url):
1141         (OSXFirefoxDriver.launch_driver):
1142         (OSXFirefoxNightlyDriver):
1143         (OSXFirefoxNightlyDriver.launch_url):
1144         (OSXFirefoxNightlyDriver.launch_driver):
1145         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1146         (OSXSafariDriver.launch_driver):
1147
1148 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1149
1150         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
1151         https://bugs.webkit.org/show_bug.cgi?id=174793
1152
1153         Reviewed by Tim Horton.
1154
1155         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
1156         down. Without r219765, this test will dereference null and crash.
1157
1158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1159         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
1160         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
1161         (TEST):
1162
1163 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1164
1165         [Win] Implement Authentication dialog in MiniBrowser
1166         https://bugs.webkit.org/show_bug.cgi?id=174662
1167
1168         Reviewed by Alex Christensen.
1169
1170         * MiniBrowser/win/Common.cpp:
1171         (CustomUserAgent):
1172         (DisplayAuthDialog):
1173         (AuthDialogProc):
1174         * MiniBrowser/win/MiniBrowserLib.rc:
1175         * MiniBrowser/win/MiniBrowserLibResource.h:
1176         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1177         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1178
1179 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
1180
1181         Handle case where line_numbers is None instead of an array of line numbers
1182         https://bugs.webkit.org/show_bug.cgi?id=174775
1183
1184         Reviewed by Aakash Jain.
1185
1186         Added files set line_numbers to None in process_file.
1187
1188         * Scripts/webkitpy/style/filereader.py:
1189         (TextFileReader.process_file): Handle case where line_number is set to None.
1190         * Scripts/webkitpy/style/main_unittest.py:
1191         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
1192
1193 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1194
1195         [WPE] Add libepoxy to the Jhbuild moduleset
1196         https://bugs.webkit.org/show_bug.cgi?id=174711
1197
1198         Reviewed by Carlos Alberto Lopez Perez.
1199
1200         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
1201
1202 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1203
1204         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
1205         https://bugs.webkit.org/show_bug.cgi?id=174780
1206
1207         Reviewed by Carlos Garcia Campos.
1208
1209         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1210         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
1211         in case the eglplatform.h header doesn't provide that macro. This replicates
1212         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
1213
1214 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1215
1216         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
1217         https://bugs.webkit.org/show_bug.cgi?id=174758
1218
1219         Reviewed by Dan Bernstein.
1220
1221         Migrate position-information-related unit tests from the PositionInformationTests suite to
1222         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
1223
1224         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1225         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
1226         (TestWebKitAPI::checkElementTypeAndBoundingRect):
1227         (TestWebKitAPI::TEST):
1228         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
1229         * TestWebKitAPI/cocoa/TestWKWebView.h:
1230         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1231         (-[TestWKWebView activatedElementAtPosition:]):
1232
1233 2017-07-22  Chris Dumez  <cdumez@apple.com>
1234
1235         REGRESSION(r204565): WKObject is broken
1236         https://bugs.webkit.org/show_bug.cgi?id=174736
1237         <rdar://problem/33246169>
1238
1239         Reviewed by Dan Bernstein.
1240
1241         Add API test that used to crash.
1242
1243         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1244         (TestWebKitAPI::TEST):
1245
1246 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1247
1248         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
1249         https://bugs.webkit.org/show_bug.cgi?id=174705
1250
1251         Reviewed by Mark Lam.
1252
1253         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1254         (TestWebKitAPI::testThreadGroup):
1255         (TestWebKitAPI::TEST):
1256
1257 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
1258
1259         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
1260         https://bugs.webkit.org/show_bug.cgi?id=174724
1261
1262         Reviewed by Aakash Jain.
1263
1264         * Scripts/webkitpy/port/ios_simulator.py:
1265         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
1266         simulator. Errors here should be treated the same as no simulators found.
1267
1268 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
1269
1270         [CMake] Add an option to stop build after generating project files
1271         https://bugs.webkit.org/show_bug.cgi?id=174664
1272
1273         Reviewed by Konstantin Tokarev.
1274
1275         Add "--generate-project-only" to stop build after generating project files.
1276
1277         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
1278         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
1279         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
1280         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
1281         (isGenerateProjectOnly): ditto
1282
1283 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1284
1285         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1286         https://bugs.webkit.org/show_bug.cgi?id=174501
1287
1288         Reviewed by Darin Adler.
1289
1290         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1291         (TestWebKitAPI::TEST):
1292
1293 2017-07-20  David Quesada  <david_quesada@apple.com>
1294
1295         Add SPI to notify WKNavigationDelegate about client redirects
1296         https://bugs.webkit.org/show_bug.cgi?id=174680
1297         rdar://problem/33184886
1298
1299         Reviewed by Brady Eidson.
1300
1301         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1302         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
1303         (TEST):
1304         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
1305
1306 2017-07-20  Brady Eidson  <beidson@apple.com>
1307
1308         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
1309         https://bugs.webkit.org/show_bug.cgi?id=174685
1310
1311         Reviewed by Andy Estes.
1312
1313         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1314         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
1315
1316 2017-07-20  Brady Eidson  <beidson@apple.com>
1317
1318         Deprecate WebIconDatabase in WebKitLegacy/mac.
1319         https://bugs.webkit.org/show_bug.cgi?id=174607
1320
1321         Reviewed by Alex Christensen.
1322
1323         * DumpRenderTree/mac/TestRunnerMac.mm:
1324
1325 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
1326
1327         lint-test-expectations should be run during style checking
1328         https://bugs.webkit.org/show_bug.cgi?id=173559
1329         <rdar://problem/32854941>
1330
1331         Reviewed by Aakash Jain.
1332
1333         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1334         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
1335         prevents identifying errors on specific lines in a file.
1336         * Scripts/webkitpy/style/main_unittest.py:
1337         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
1338         case where a linter error is in the file modified, but the line modified is not related to
1339         the linter error.
1340
1341 2017-07-20  Brady Eidson  <beidson@apple.com>
1342
1343         Remove WebIconDatabase from WebKitLegacy/win.
1344         https://bugs.webkit.org/show_bug.cgi?id=174608
1345
1346         Reviewed by Alex Christensen.
1347
1348         * DumpRenderTree/win/DumpRenderTree.cpp:
1349         (main):
1350         * DumpRenderTree/win/TestRunnerWin.cpp:
1351         (TestRunner::setIconDatabaseEnabled):
1352
1353 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
1354
1355         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
1356         https://bugs.webkit.org/show_bug.cgi?id=174671
1357
1358         Reviewed by Carlos Garcia Campos.
1359
1360         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1361         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
1362         priority for this source in order to have it dispatched on the same
1363         priority as the other WebKit-controlled GSource objects.
1364
1365 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1366
1367         lint-test-expectations should be run during style checking
1368         https://bugs.webkit.org/show_bug.cgi?id=173559
1369         <rdar://problem/32854941>
1370
1371         Reviewed by Daniel Bates.
1372
1373         Follow up fix addressing style and a few minor bugs.
1374
1375         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1376         (TestExpectationParser.__init__): Use lambda x: x instead of str
1377         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
1378         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
1379         reduce the calls of _shorten_filename, fix minor bug in appending the current
1380         expectation's line number instead of the previous ones, clarify treatment of None
1381         in file-to-line-number mapping.
1382         (TestExpectations._report_warnings): Collapse call.
1383         * Scripts/webkitpy/style/checkers/test_expectations.py:
1384         (TestExpectationsChecker.lint_test_expectations):
1385         * Scripts/webkitpy/style/filereader.py: Re-write comment.
1386         (TextFileReader.process_file): Add comment explaining treatment of None in
1387         file-to-line-number mapping.
1388         (TextFileReader.delete_file): Collapse call.
1389
1390 2017-07-19  Chris Dumez  <cdumez@apple.com>
1391
1392         Unreviewed attempt to fix API test failure after r219663.
1393
1394         The test was hard-coding an exception string and the string has changed slightly
1395         in r219663.
1396
1397         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1398         (TEST):
1399
1400 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
1401
1402         Don't write file URLs to iOS Pasteboard
1403         https://bugs.webkit.org/show_bug.cgi?id=174647
1404         <rdar://problem/33199730>
1405
1406         Reviewed by Wenson Hsieh.
1407
1408         Updating tests to reflect the lack of file URLs for images.
1409
1410         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1411         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
1412         (checkEstimatedSize):
1413         (TestWebKitAPI::TEST):
1414
1415 2017-07-19  Brady Eidson  <beidson@apple.com>
1416
1417         iBooks sometimes crashes when closing a book.
1418         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
1419
1420         Reviewed by Oliver Hunt.
1421
1422         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1423         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
1424         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
1425         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
1426         (TestWebKitAPI::TEST):
1427
1428         Add a "spin the runloop X number of times" utility:
1429         * TestWebKitAPI/Utilities.h:
1430         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1431         (TestWebKitAPI::Util::spinRunLoop):
1432
1433 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1434
1435         lint-test-expectations should be run during style checking
1436         https://bugs.webkit.org/show_bug.cgi?id=173559
1437         <rdar://problem/32854941>
1438
1439         Reviewed by David Kilzer.
1440
1441         Running the test expectation linter requires reading both files and lines not in the
1442         patch because, for example, deletion of a test can cause a lint failure even though
1443         no test expectations where modified. This means that the linter will occasionally warn
1444         about lines which were not changed in a given patch but whose error is related to a
1445         change made in that patch.
1446
1447         * Scripts/webkitpy/common/system/filesystem_mock.py:
1448         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
1449         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1450         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
1451         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
1452         content, description of the error and the name of the associated test.
1453         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
1454         (TestExpectationParser.__init__): Pass shorten_filename function to
1455         TestExpectationsParser to add a deleted file to the related_files dictionary.
1456         (TestExpectationParser._check_test_exists): If the test does not exist, add the
1457         missing path to the related_files dictionary.
1458         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
1459         files and line numbers related to this test expectation line. This will allow
1460         tracking linter errors in the style checker occurring across multiple files.
1461         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
1462         lines to related_files dictionary.
1463         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
1464         (TestExpectations._report_warnings): Construct warning object instead of string
1465         when adding to warnings list.
1466         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
1467         clean-up log.
1468         * Scripts/webkitpy/style/checker.py:
1469         (ProcessorBase.do_association_check): Add required function for processor classes.
1470         (StyleProcessor):
1471         (StyleProcessor.do_association_check): Run the TestExpectations linter when
1472         checking for errors between associated files.
1473         * Scripts/webkitpy/style/checkers/test_expectations.py:
1474         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
1475         (TestExpectationsChecker):
1476         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
1477         of modified files, the current working directory and the host, determine if the linter
1478         warning is associated with the changes.
1479         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
1480         style checker.
1481         * Scripts/webkitpy/style/filereader.py:
1482         (TextFileReader):
1483         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
1484         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
1485         (TextFileReader.process_file): Track both the number of files changed and which lines
1486         in those files were changed.
1487         (TextFileReader.do_association_check): Run the processor's association check on all
1488         modified or deleted files processed by TextFileReader.
1489         (TextFileReader.delete_file): Track deleted files in _files dictionary.
1490         (TextFileReader.count_delete_only_file): Deleted.
1491         * Scripts/webkitpy/style/filereader_unittest.py:
1492         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
1493         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
1494         * Scripts/webkitpy/style/main.py:
1495         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
1496         explicitly run the association check on the file reader.
1497         * Scripts/webkitpy/style/main_unittest.py:
1498         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
1499         embedded in the style checker.
1500         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
1501         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
1502         construct the TextFileReader object with a StyleProcessor used to run style checks on
1503         specific files.
1504         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
1505         testing the test expectation linter inside the style checker. This host must contain a
1506         mock file system with the basic structure of test expectations.
1507         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
1508         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
1509         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
1510         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
1511         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
1512         * Scripts/webkitpy/style/patchreader.py:
1513         (PatchReader.check): Specify which file was deleted, run the association check.
1514         * Scripts/webkitpy/style/patchreader_unittest.py:
1515         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
1516         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
1517         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
1518
1519 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1520
1521         [WTF] Implement WTF::ThreadGroup
1522         https://bugs.webkit.org/show_bug.cgi?id=174081
1523
1524         Reviewed by Mark Lam.
1525
1526         Add WTF::ThreadGroup tests.
1527
1528         * TestWebKitAPI/CMakeLists.txt:
1529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1530         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1531         (TestWebKitAPI::testThreadGroup):
1532         (TestWebKitAPI::TEST):
1533
1534 2017-07-18  Andy Estes  <aestes@apple.com>
1535
1536         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1537         https://bugs.webkit.org/show_bug.cgi?id=174631
1538
1539         Reviewed by Tim Horton.
1540
1541         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1542         * MiniBrowser/Configurations/Base.xcconfig:
1543         * MobileMiniBrowser/Configurations/Base.xcconfig:
1544         * TestWebKitAPI/Configurations/Base.xcconfig:
1545         * WebKitTestRunner/Configurations/Base.xcconfig:
1546
1547 2017-07-18  Andy Estes  <aestes@apple.com>
1548
1549         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1550         https://bugs.webkit.org/show_bug.cgi?id=174631
1551
1552         Reviewed by Sam Weinig.
1553
1554         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1555         * MiniBrowser/Configurations/Base.xcconfig:
1556         * MobileMiniBrowser/Configurations/Base.xcconfig:
1557         * TestWebKitAPI/Configurations/Base.xcconfig:
1558         * WebKitTestRunner/Configurations/Base.xcconfig:
1559
1560 2017-07-18  Daniel Bates  <dabates@apple.com>
1561
1562         lldb: Add type summary for StringView
1563         https://bugs.webkit.org/show_bug.cgi?id=174637
1564
1565         Reviewed by Sam Weinig.
1566
1567         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
1568         StringView object will print output that has the form:
1569
1570             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
1571               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
1572               m_length = 2
1573               m_is8Bit = true
1574               m_underlyingString = 0x0000614000000a90
1575             }
1576
1577         * lldb/lldb_webkit.py:
1578         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
1579         (WTFStringView_SummaryProvider):
1580         (WTFStringViewProvider):
1581         (WTFStringViewProvider.__init__):
1582         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
1583         (WTFStringViewProvider.get_length): Access field StringView.m_length.
1584         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
1585         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
1586
1587 2017-07-18  Andy Estes  <aestes@apple.com>
1588
1589         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
1590         https://bugs.webkit.org/show_bug.cgi?id=174631
1591
1592         Reviewed by Dan Bernstein.
1593
1594         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1595         * MiniBrowser/Configurations/Base.xcconfig:
1596         * MobileMiniBrowser/Configurations/Base.xcconfig:
1597         * TestWebKitAPI/Configurations/Base.xcconfig:
1598         * WebKitTestRunner/Configurations/Base.xcconfig:
1599
1600 2017-07-18  Devin Rousso  <drousso@apple.com>
1601
1602         Web Inspector: Add memoryCost to Inspector Protocol objects
1603         https://bugs.webkit.org/show_bug.cgi?id=174478
1604
1605         Reviewed by Joseph Pecoraro.
1606
1607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1608         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
1609         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
1610         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
1611         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
1612         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
1613         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
1614         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
1615         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
1616         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
1617         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
1618         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
1619         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
1620         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
1621         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
1622         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
1623         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
1624
1625 2017-07-18  Andy Estes  <aestes@apple.com>
1626
1627         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
1628         https://bugs.webkit.org/show_bug.cgi?id=174631
1629
1630         Reviewed by Darin Adler.
1631
1632         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1633         * MiniBrowser/Configurations/Base.xcconfig:
1634         * MobileMiniBrowser/Configurations/Base.xcconfig:
1635         * TestWebKitAPI/Configurations/Base.xcconfig:
1636         * WebKitTestRunner/Configurations/Base.xcconfig:
1637
1638 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1639
1640         Unreviewed, fix the iOS build.
1641
1642         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
1643
1644         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1645         (TestWebKitAPI::TEST):
1646
1647 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1648
1649         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
1650         https://bugs.webkit.org/show_bug.cgi?id=174585
1651         <rdar://problem/33302541>
1652
1653         Reviewed by Tim Horton.
1654
1655         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
1656         being dragged when initiating a drag.
1657
1658         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1659         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
1660         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1661         (TestWebKitAPI::TEST):
1662         * TestWebKitAPI/cocoa/TestWKWebView.h:
1663
1664         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
1665
1666         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1667         (-[TestWKWebView synchronouslyLoadHTMLString:]):
1668
1669 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1670
1671         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
1672         https://bugs.webkit.org/show_bug.cgi?id=174547
1673
1674         Reviewed by Alex Christensen.
1675
1676         * DumpRenderTree/PlatformWin.cmake:
1677         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1678
1679 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1680
1681         Update style checker to deal with "final"
1682         https://bugs.webkit.org/show_bug.cgi?id=174528
1683
1684         Reviewed by Alex Christensen.
1685         
1686         check-webkit-style shouldn't complain about an open brace to start a
1687         line after a function definition with "final" or "const final".
1688
1689         * Scripts/webkitpy/style/checkers/cpp.py:
1690         (check_braces):
1691         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1692         (CppStyleTest.test_brace_at_begin_of_line):
1693
1694 2017-07-17  Alex Christensen  <achristensen@webkit.org>
1695
1696         Modernize content extension code
1697         https://bugs.webkit.org/show_bug.cgi?id=174588
1698
1699         Reviewed by Sam Weinig.
1700
1701         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1702         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1703         (TestWebKitAPI::testRequest):
1704         (TestWebKitAPI::makeBackend):
1705         (TestWebKitAPI::TEST_F):
1706
1707 2017-07-17  Brady Eidson  <beidson@apple.com>
1708
1709         WKHTTPCookieStore observing only works on the default cookie store.
1710         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
1711
1712         Reviewed by Sam Weinig.
1713
1714         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1715         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
1716           called for the default store, a non-persistent store, and a custom store.
1717         (TEST):
1718
1719 2017-07-16  Sam Weinig  <sam@webkit.org>
1720
1721         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
1722         https://bugs.webkit.org/show_bug.cgi?id=174575
1723
1724         Reviewed by Brady Eidson.
1725
1726         * Scripts/svn-create-patch:
1727         (findModificationType):
1728         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
1729         default value of "unknown".
1730
1731         (generateFileList):
1732         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
1733         for untracked, which matches our old behavior.
1734
1735 2017-07-17  Charlie Turner  <cturner@igalia.com>
1736
1737         Add some missing build dependencies on Fedora
1738         https://bugs.webkit.org/show_bug.cgi?id=174578
1739
1740         Unreviewed dependency update.
1741
1742         * gtk/install-dependencies:
1743
1744 2017-07-16  Brady Eidson  <beidson@apple.com>
1745
1746         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
1747         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
1748
1749         Reviewed by Tim Horton.
1750
1751         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1752         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
1753         (TEST):
1754
1755 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
1756
1757         [GTK] Sort inspector GResource manifest to ensure reproducible builds
1758         https://bugs.webkit.org/show_bug.cgi?id=174540
1759
1760         Reviewed by Michael Catanzaro.
1761
1762         * gtk/generate-inspector-gresource-manifest.py:
1763         (get_filenames): sort list of input files
1764
1765 2017-07-15  Brady Eidson  <beidson@apple.com>
1766
1767         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
1768         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
1769
1770         Reviewed by Tim Horton.
1771
1772         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1773         (TEST): Make this test more reliable by clearing everything beforehand.
1774
1775 2017-07-15  David Kilzer  <ddkilzer@apple.com>
1776
1777         Make it possible to extend check-webkit-style with Apple-internal checkers
1778         <https://webkit.org/b/174464>
1779         <rdar://problem/25564402>
1780
1781         Reviewed by Darin Adler.
1782
1783         * Scripts/webkitpy/style/checker.py: Import apple_additions.
1784         (_all_categories): Add categories from apple_additions() if it
1785         exists.
1786         (CheckerDispatcher._create_checker): Create python checker
1787         from apple_additions() if it exists.
1788
1789 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1790
1791         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
1792         https://bugs.webkit.org/show_bug.cgi?id=174539
1793         <rdar://problem/33307395>
1794
1795         Reviewed by Darin Adler.
1796
1797         Adds a new unit test suite to cover action sheet popover presentation.
1798
1799         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1800         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
1801         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
1802         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
1803
1804         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
1805
1806         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
1807         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1808
1809         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
1810
1811         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1812         (TestWebKitAPI::TEST):
1813
1814 2017-07-15  Sam Weinig  <sam@webkit.org>
1815
1816         [Scripts] Make svn-create-patch work better when called in sub directories
1817         https://bugs.webkit.org/show_bug.cgi?id=174551
1818
1819         Reviewed by Darin Adler.
1820
1821         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
1822           by ensuring that the prefix is applied as is done in generateDiff.
1823         - Silence output of explanatory lines from svn stat (" > move to ...")
1824           that show up in STDERR when running svn-create-patch.
1825         - Add verbose logging that I found useful while debugging this issue.
1826
1827         * Scripts/svn-create-patch:
1828         (findBaseUrl):
1829         (findMimeType):
1830         (findSourceFileAndRevision):
1831         (generateDiff):
1832         (generateFileList):
1833         (manufacturePatchForAdditionWithHistory):
1834
1835 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
1836
1837         Unreviewed build fix after r219537.
1838
1839         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1840
1841 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1842
1843         Add iOS 11 SPI
1844         https://bugs.webkit.org/show_bug.cgi?id=174430
1845         <rdar://problem/33269288>
1846
1847         Reviewed by Tim Horton.
1848
1849         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
1850         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
1851         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
1852
1853 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1854
1855         Failing to install on iPad simulators
1856         https://bugs.webkit.org/show_bug.cgi?id=174532
1857         <rdar://problem/33328347>
1858
1859         Reviewed by Stephanie Lewis.
1860
1861         * Scripts/webkitpy/xcode/simulated_device.py:
1862         (SimulatedDevice.install_app): Place install command in retry try-except block.
1863
1864 2017-07-14  Jeff Miller  <jeffm@apple.com>
1865
1866         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1867         https://bugs.webkit.org/show_bug.cgi?id=174524
1868
1869         Reviewed by Sam Weinig.
1870
1871         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1872         (TEST):
1873         Renamed TestParameter to TestParameter1.
1874         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1875
1876         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1877         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1878         Observe changes for two bundle parameters.
1879
1880         (-[BundleParametersPlugIn dealloc]):
1881         Remove observers for two bundle parameters.
1882
1883 2017-07-14  Commit Queue  <commit-queue@webkit.org>
1884
1885         Unreviewed, rolling out r219510.
1886         https://bugs.webkit.org/show_bug.cgi?id=174525
1887
1888         Need to revert length() == 0 check for null string (Requested
1889         by yusukesuzuki on #webkit).
1890
1891         Reverted changeset:
1892
1893         "[WTF] Newly added AtomicStringImpl should use BufferInternal
1894         static string if StringImpl is static"
1895         https://bugs.webkit.org/show_bug.cgi?id=174501
1896         http://trac.webkit.org/changeset/219510
1897
1898 2017-07-14  Jer Noble  <jer.noble@apple.com>
1899
1900         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
1901         https://bugs.webkit.org/show_bug.cgi?id=174514
1902
1903         Reviewed by Sam Weinig.
1904
1905         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
1906         (TestWebKitAPI::TEST_F):
1907
1908 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1909
1910         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1911         https://bugs.webkit.org/show_bug.cgi?id=174501
1912
1913         Reviewed by Darin Adler.
1914
1915         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1916         (TestWebKitAPI::TEST):
1917
1918 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1919
1920         Bring mac expectations in-line with other platforms
1921         https://bugs.webkit.org/show_bug.cgi?id=174472
1922         <rdar://problem/33297388>
1923
1924         Reviewed by David Kilzer.
1925
1926         The override order for Mac test expectations does not conform to the pattern used by iOS,
1927         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
1928
1929             platform/mac-wk2
1930             platform/wk2
1931             platform/mac-elcapitan
1932             platform/mac-sierra
1933             generic
1934
1935         After this change, El Capitan's baseline search path looks like this:
1936
1937             platform/mac-sierra-wk2
1938             platform/mac-sierra
1939             platform/mac-wk2
1940             platform/wk2
1941             generic
1942
1943         * Scripts/webkitpy/port/mac.py:
1944         (MacPort.__init__): If a specific version is specified in the port name, use that
1945         as the os version.
1946         (MacPort.default_baseline_search_path): Expectation search paths should work the
1947         same way they do on other ports. Port + version overrides port, port overrides generic
1948         and wk1/wk2 should override expectations for the two combined.
1949         * Scripts/webkitpy/port/mac_unittest.py:
1950         (MacTest.test_tests_for_other_platforms): Deleted.
1951         (MacTest._assert_search_path): Deleted.
1952         (MacTest.test_baseline_search_path): Deleted.
1953         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1954         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1955         (test_rebaseline_test_and_print_scm_changes): Ditto.
1956         (test_rebaseline_and_copy_test): Ditto.
1957         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1958         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1959         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1960
1961 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1962
1963         Fix style checker unit test
1964
1965         Unreviewed WebKit2 => WebKit fixup.
1966
1967         * Scripts/webkitpy/style/checker_unittest.py:
1968         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1969
1970 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1971
1972         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1973
1974         Unreviewed build fix.
1975
1976         r219492 missed one hunk from its partial revert of r219489.
1977         This patch reverts that hunk.
1978
1979         * TestWebKitAPI/CMakeLists.txt:
1980
1981 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1982
1983         Use the old WebKit/WebKit2 targets for CMake builds.
1984
1985         Unreviewed build fix.
1986
1987         We can update the target names to match the Framework names in a future patch.
1988         This is a partial revert of r219489.
1989
1990         * TestWebKitAPI/CMakeLists.txt:
1991         WebKitLegacy => WebKit
1992         WebKit => WebKit2
1993
1994 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1995
1996         Fix TestWebKit API.
1997         https://bugs.webkit.org/show_bug.cgi?id=174164
1998         rdar://problem/33137595
1999
2000         Reviewed by Dan Bernstein.
2001
2002         * TestWebKitAPI/CMakeLists.txt:
2003         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2004         * TestWebKitAPI/PlatformGTK.cmake:
2005
2006 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
2007
2008         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
2009         https://bugs.webkit.org/show_bug.cgi?id=174164
2010         rdar://problem/33137595
2011
2012         Reviewed by Dan Bernstein.
2013
2014         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2015         (ShouldBuildTest):
2016         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2017         * Scripts/build-webkit:
2018         * Scripts/do-file-rename:
2019         * Scripts/do-webcore-rename:
2020         * Scripts/update-webkit-localizable-strings:
2021         * Scripts/webkitpy/common/config/watchlist:
2022         * Scripts/webkitpy/style/checker.py:
2023         * Scripts/webkitpy/style/checkers/featuredefines.py:
2024         * gtk/make-dist.py:
2025         (ensure_version_if_possible):
2026         * gtk/manifest.txt.in:
2027
2028 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
2029
2030         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
2031         https://bugs.webkit.org/show_bug.cgi?id=174162
2032         rdar://problem/33137594
2033
2034         Reviewed by Dan Bernstein.
2035
2036         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
2037
2038         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2039         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2040         * EWSTools/configure-clang-linux.sh:
2041         * Scripts/build-webkit:
2042         * Scripts/do-file-rename:
2043         * Scripts/do-webcore-rename:
2044         * Scripts/update-webkit-localizable-strings:
2045         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2046         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2047         * Scripts/webkitpy/style/checkers/featuredefines.py:
2048         * gtk/manifest.txt.in:
2049
2050 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
2051
2052         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
2053         https://bugs.webkit.org/show_bug.cgi?id=174438
2054         <rdar://problem/33277112>
2055
2056         Reviewed by Aakash Jain.
2057
2058         Given a patch, this will convert the changes from the path to the new directory structure.
2059
2060         * Scripts/rebase-patch-after-webkit-move: Added.
2061         (append_source): Append 'Source' to the provided path.
2062         (is_editable_line): Return true if a line the script expects to modify.
2063         (needs_rebase): Return if a line needs to be rebased based on it's content.
2064         (rebase_line): Rebase the provided line.
2065         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
2066         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
2067         were provided.
2068
2069 2017-07-12  Nan Wang  <n_wang@apple.com>
2070
2071         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2072         https://bugs.webkit.org/show_bug.cgi?id=174393
2073         <rdar://problem/33248006>
2074
2075         Reviewed by Chris Fleizach.
2076
2077         * DumpRenderTree/AccessibilityUIElement.cpp:
2078         (textMarkerRangeMatchesTextNearMarkersCallback):
2079         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2080         (AccessibilityUIElement::getJSClass):
2081         * DumpRenderTree/AccessibilityUIElement.h:
2082         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2083         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2084         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2085         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2086         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2087         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2088         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2089         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2090
2091 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2092
2093         Unreviewed, rolling out r219409.
2094
2095         The revision caused the Windows builds to fail.
2096
2097         Reverted changeset:
2098
2099         "AX: [iOS] Implement a way to retrieve a text marker range
2100         with desired text that is closest to a position"
2101         https://bugs.webkit.org/show_bug.cgi?id=174393
2102         http://trac.webkit.org/changeset/219409
2103
2104 2017-07-12  Nan Wang  <n_wang@apple.com>
2105
2106         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
2107         https://bugs.webkit.org/show_bug.cgi?id=174393
2108         <rdar://problem/33248006>
2109
2110         Reviewed by Chris Fleizach.
2111
2112         * DumpRenderTree/AccessibilityUIElement.cpp:
2113         (textMarkerRangeMatchesTextNearMarkersCallback):
2114         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2115         (AccessibilityUIElement::getJSClass):
2116         * DumpRenderTree/AccessibilityUIElement.h:
2117         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2118         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2119         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2120         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2121         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2122         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2123         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2124         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
2125
2126 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
2127
2128         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
2129         https://bugs.webkit.org/show_bug.cgi?id=174197
2130
2131         Reviewed by Darin Adler.
2132
2133         This bit me the first time I tried to submit a patch to WebKit, and still I have
2134         to manually edit the ChangeLog every time I use the script.
2135
2136         This generates a more convenient and standard ChangeLog entry.
2137
2138         * Scripts/prepare-ChangeLog:
2139         (generateNewChangeLogs):
2140
2141 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2142
2143         Unreviewed, rolling out r219401.
2144
2145         This revision rolled out the previous patch, but after talking
2146         with reviewer, a rebaseline is what was needed.Rolling back in
2147         before rebaseline.
2148
2149         Reverted changeset:
2150
2151         "Unreviewed, rolling out r219379."
2152         https://bugs.webkit.org/show_bug.cgi?id=174400
2153         http://trac.webkit.org/changeset/219401
2154
2155 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2156
2157         Unreviewed, rolling out r219379.
2158
2159         This revision caused a consistent failure in the test
2160         fast/dom/Window/property-access-on-cached-window-after-frame-
2161         removed.html.
2162
2163         Reverted changeset:
2164
2165         "Remove NAVIGATOR_HWCONCURRENCY"
2166         https://bugs.webkit.org/show_bug.cgi?id=174400
2167         http://trac.webkit.org/changeset/219379
2168
2169 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2170
2171         [WPE] Use libepoxy
2172         https://bugs.webkit.org/show_bug.cgi?id=172104
2173
2174         Reviewed by Michael Catanzaro.
2175
2176         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
2177         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
2178
2179 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2180
2181         [GTK][WPE] Align Jhbuild patches for GStreamer packages
2182         https://bugs.webkit.org/show_bug.cgi?id=174363
2183
2184         Reviewed by Michael Catanzaro.
2185
2186         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
2187         between the GTK+ and WPE port. There's no reason for the two ports to apply
2188         different patches over same versions of GStreamer releases.
2189
2190         This aligns the two ports on this specific issue. Next we'll look into
2191         creating a single GStreamer-specific Jhbuild moduleset that will allow us
2192         to keep these patches in a single place, avoiding duplicate files.
2193
2194         * gtk/jhbuild.modules:
2195         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2196         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
2197         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2198         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
2199
2200 2017-07-11  Dean Jackson  <dino@apple.com>
2201
2202         Remove NAVIGATOR_HWCONCURRENCY
2203         https://bugs.webkit.org/show_bug.cgi?id=174400
2204
2205         Reviewed by Sam Weinig.
2206
2207         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2208
2209 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
2210
2211         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
2212         https://bugs.webkit.org/show_bug.cgi?id=174239
2213
2214         Reviewed by Brady Eidson.
2215
2216         Create windows with specific features set and make sure those are properly reflected in the
2217         WKWindowFeatures object.
2218
2219         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2220         (resetToConsistentState):
2221         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2222         (TEST):
2223
2224 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
2225
2226         Do not duplicate files when deleting directories with svn 1.9
2227         https://bugs.webkit.org/show_bug.cgi?id=174339
2228         <rdar://problem/33226781>
2229
2230         Reviewed by David Kilzer.
2231
2232         * Scripts/svn-create-patch:
2233         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
2234         (generateFileList): Determine which files are deleted because they are part of a
2235         directory being deleted.
2236
2237 2017-07-11  Dean Jackson  <dino@apple.com>
2238
2239         Rolling out r219372.
2240
2241         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2242
2243 2017-07-11  Dean Jackson  <dino@apple.com>
2244
2245         Remove NAVIGATOR_HWCONCURRENCY
2246         https://bugs.webkit.org/show_bug.cgi?id=174400
2247
2248         Reviewed by Sam Weinig.
2249
2250         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2251
2252 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2253
2254         Teach build workers to fetch archives from S3.
2255         https://bugs.webkit.org/show_bug.cgi?id=174384
2256
2257         Reviewed by Aakash Jain.
2258
2259         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2260         (DownloadBuiltProduct):
2261
2262 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2263
2264         Configure buildbot to transfer all archives to S3.
2265         Previously this was Mac only, but it's time to expand!
2266         https://bugs.webkit.org/show_bug.cgi?id=174378
2267         
2268         Reviewed by Aakash Jain.
2269
2270         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2271         (BuildFactory.__init__):
2272
2273 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
2274
2275         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
2276         https://bugs.webkit.org/show_bug.cgi?id=174350
2277
2278         Reviewed by Xabier Rodriguez-Calvar.
2279
2280         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
2281         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
2282         patches are removed. The patches for gst-plugins-good are updated, removing
2283         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
2284         rtpbin elements that will help with the EMEv3 development.
2285
2286         * wpe/jhbuild.modules:
2287         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
2288         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
2289         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
2290         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2291         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2292         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2293         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2294         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2295         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2296
2297 2017-07-10  John Wilander  <wilander@apple.com>
2298
2299         Resource Load Statistics: Prune statistics in orders of importance
2300         https://bugs.webkit.org/show_bug.cgi?id=174215
2301         <rdar://problem/33164403>
2302
2303         Reviewed by Chris Dumez.
2304
2305         Nest infrastructure. Adds these functions:
2306         1. testRunner.setStatisticsLastSeen()
2307         2. setStatisticsMaxStatisticsEntries()
2308         3. setStatisticsPruneEntriesDownTo()
2309
2310         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2311         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2312         (WTR::TestRunner::setStatisticsLastSeen):
2313         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2314         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2315         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2316         * WebKitTestRunner/TestController.cpp:
2317         (WTR::TestController::setStatisticsLastSeen):
2318         (WTR::TestController::setMaxStatisticsEntries):
2319         (WTR::TestController::setPruneEntriesDownTo):
2320         * WebKitTestRunner/TestController.h:
2321         * WebKitTestRunner/TestInvocation.cpp:
2322         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2323         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2324         (WTR::TestController::setStatisticsLastSeen):
2325         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2326         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2327
2328 2017-07-03  Brian Burg  <bburg@apple.com>
2329
2330         Web Replay: remove some unused code
2331         https://bugs.webkit.org/show_bug.cgi?id=173903
2332
2333         Rubber-stamped by Joseph Pecoraro.
2334
2335         * Scripts/run-input-generator-tests: Removed.
2336         * Scripts/webkitpy/replay/__init__.py: Removed.
2337         * Scripts/webkitpy/replay/main.py: Removed.
2338
2339 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
2340
2341         [WPE] Fix layout test baseline and TestExpectations hierarchy
2342         https://bugs.webkit.org/show_bug.cgi?id=174092
2343
2344         Reviewed by Michael Catanzaro.
2345
2346         Like for the GTK+ port, override the default_baseline_search_path() and
2347         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
2348         Both methods operate on a short list of search paths that defaults to 'wpe' and
2349         'wk2', along with any other user-specified platform directory.
2350
2351         The test_expectations_file_position() method is overridden for testing purposes,
2352         and relevant unit tests are added.
2353
2354         * Scripts/webkitpy/port/wpe.py:
2355         (WPEPort._search_paths):
2356         (WPEPort):
2357         (WPEPort.default_baseline_search_path):
2358         (WPEPort._port_specific_expectations_files):
2359         (WPEPort.test_expectations_file_position):
2360         * Scripts/webkitpy/port/wpe_unittest.py:
2361         (WPEPortTest.test_default_baseline_search_path):
2362         (WPEPortTest):
2363         (WPEPortTest.test_port_specific_expectations_files):
2364
2365 2017-07-10  Chris Dumez  <cdumez@apple.com>
2366
2367         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
2368         https://bugs.webkit.org/show_bug.cgi?id=174301
2369
2370         Reviewed by Brent Fulgham.
2371
2372         Rename some of the testRunner API for clarity and to better match what it calls
2373         internally.
2374
2375         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2376         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2377         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2378         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2379         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2380         * WebKitTestRunner/TestController.cpp:
2381         (WTR::TestController::statisticsUpdateCookiePartitioning):
2382         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2383         * WebKitTestRunner/TestController.h:
2384         * WebKitTestRunner/TestInvocation.cpp:
2385         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2386         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2387         (WTR::TestController::statisticsUpdateCookiePartitioning):
2388         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2389
2390 2017-07-10  Charlie Turner  <cturner@igalia.com>
2391
2392         [GStreamer] Live twitch.tv videos do not play
2393         https://bugs.webkit.org/show_bug.cgi?id=174222
2394
2395         Reviewed by Michael Catanzaro.
2396
2397         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
2398         fixes videos not playing on twitch.tv.
2399
2400         * gtk/jhbuild.modules:
2401
2402 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
2403
2404         Add WebGL2 configuration option to build-webkit
2405         https://bugs.webkit.org/show_bug.cgi?id=174251
2406
2407         Reviewed by Michael Catanzaro.
2408
2409         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
2410         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
2411         is marked as enabled for the Apple Cocoa ports.
2412
2413 2017-07-08  Chris Dumez  <cdumez@apple.com>
2414
2415         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
2416         https://bugs.webkit.org/show_bug.cgi?id=174290
2417
2418         Reviewed by Brent Fulgham.
2419
2420         Rename testRunner API to match the new internal API names.
2421
2422         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2423         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2424         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2425         (WTR::TestRunner::statisticsSubmitTelemetry):
2426         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2427         * WebKitTestRunner/TestController.cpp:
2428         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2429         (WTR::TestController::statisticsSubmitTelemetry):
2430         * WebKitTestRunner/TestController.h:
2431         * WebKitTestRunner/TestInvocation.cpp:
2432         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2433         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2434         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2435         (WTR::TestController::statisticsSubmitTelemetry):
2436
2437 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2438
2439         Drop NOSNIFF compile flag
2440         https://bugs.webkit.org/show_bug.cgi?id=174289
2441
2442         Reviewed by Michael Catanzaro.
2443
2444         * Scripts/webkitperl/FeatureList.pm:
2445         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2446
2447 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2448
2449         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
2450         https://bugs.webkit.org/show_bug.cgi?id=174219
2451         <rdar://problem/32083177>
2452
2453         Reviewed by Ryosuke Niwa.
2454
2455         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
2456         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
2457         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
2458         place.
2459
2460         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
2461         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
2462         no action is taken when dropping.
2463
2464         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
2465         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2466         (TestWebKitAPI::TEST):
2467         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2468         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2469         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
2470         (-[MockDragDropSession allowsMoveOperation]):
2471         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
2472         (-[MockDataInteractionSession initWithWindow:allowMove:]):
2473         (-[DataInteractionSimulator initWithWebView:]):
2474         (-[DataInteractionSimulator runFrom:to:]):
2475         (-[DataInteractionSimulator _advanceProgress]):
2476         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
2477         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
2478         (-[MockDataInteractionSession initWithWindow:]): Deleted.
2479
2480 2017-07-07  Commit Queue  <commit-queue@webkit.org>
2481
2482         Unreviewed, rolling out r219238, r219239, and r219241.
2483         https://bugs.webkit.org/show_bug.cgi?id=174265
2484
2485         "fast/workers/dedicated-worker-lifecycle.html is flaky"
2486         (Requested by yusukesuzuki on #webkit).
2487
2488         Reverted changesets:
2489
2490         "[WTF] Implement WTF::ThreadGroup"
2491         https://bugs.webkit.org/show_bug.cgi?id=174081
2492         http://trac.webkit.org/changeset/219238
2493
2494         "Unreviewed, build fix after r219238"
2495         https://bugs.webkit.org/show_bug.cgi?id=174081
2496         http://trac.webkit.org/changeset/219239
2497
2498         "Unreviewed, CLoop build fix after r219238"
2499         https://bugs.webkit.org/show_bug.cgi?id=174081
2500         http://trac.webkit.org/changeset/219241
2501
2502 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2503
2504         [GTK][WPE] Enable X-Content-Type-Options: nosniff
2505         https://bugs.webkit.org/show_bug.cgi?id=174250
2506
2507         Reviewed by Carlos Alberto Lopez Perez.
2508
2509         * Scripts/webkitperl/FeatureList.pm:
2510
2511 2017-07-07  Charlie Turner  <cturner@igalia.com>
2512         [GStreamer] vid.me videos do not play
2513         https://bugs.webkit.org/show_bug.cgi?id=172240
2514
2515         Reviewed by Xabier Rodriguez-Calvar.
2516
2517         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2518         have the existing libsoup build against GNOME to avoid header drift
2519         against GStreamer's linked Soup library.
2520
2521         * gtk/jhbuild.modules:
2522
2523 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2524
2525         Write a support script to enable buildbot to upload to S3
2526         https://bugs.webkit.org/show_bug.cgi?id=174196
2527         
2528         Reviewed by Stephanie Lewis.
2529
2530         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
2531         (uploadToS3):
2532         (archiveExists):
2533
2534 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2535
2536         Enabling uploading archives to S3.
2537         https://bugs.webkit.org/show_bug.cgi?id=174198
2538         
2539         Reviewed by Stephanie Lewis.
2540
2541         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2542         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2543         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2544         (TransferToS3): Transfer full and minified archives to S3
2545
2546 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2547
2548         [WTF] Implement WTF::ThreadGroup
2549         https://bugs.webkit.org/show_bug.cgi?id=174081
2550
2551         Reviewed by Mark Lam.
2552
2553         Add WTF::ThreadGroup tests.
2554
2555         * TestWebKitAPI/CMakeLists.txt:
2556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2557         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2558         (TestWebKitAPI::TEST):
2559
2560 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2561
2562         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2563         https://bugs.webkit.org/show_bug.cgi?id=174150
2564
2565         Reviewed by Mark Lam.
2566
2567         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2568         (TestWebKitAPI::TEST):
2569         * TestWebKitAPI/TestsController.cpp:
2570         (TestWebKitAPI::TestsController::TestsController):
2571
2572 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2573
2574         Enabling uploading archives to S3.
2575         https://bugs.webkit.org/show_bug.cgi?id=174198
2576         
2577         Reviewed by Lucas Forschler.
2578
2579         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2580         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2581         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2582         (TransferToS3): Transfer full and minified archives to S3
2583
2584 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2585
2586         [GTK][WPE] kill-old-process should kill more webkit related process
2587         https://bugs.webkit.org/show_bug.cgi?id=174220
2588
2589         Reviewed by Michael Catanzaro.
2590
2591         Generate list of possible webkit-related process names and add
2592         them to the list of process to kill.
2593         Also update the possible system related process for GTK+/WPE.
2594
2595         * BuildSlaveSupport/kill-old-processes:
2596         (listAllWebKitPrograms):
2597         (main):
2598
2599 2017-07-06  Chris Dumez  <cdumez@apple.com>
2600
2601         FileMonitor should not be ref counted
2602         https://bugs.webkit.org/show_bug.cgi?id=174166
2603
2604         Reviewed by Brent Fulgham.
2605
2606         Update the API tests to reflect the API change.
2607
2608         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2609         (TestWebKitAPI::TEST_F):
2610
2611 2017-07-06  Commit Queue  <commit-queue@webkit.org>
2612
2613         Unreviewed, rolling out r219194.
2614         https://bugs.webkit.org/show_bug.cgi?id=174207
2615
2616         it broke some layout tests (Requested by clopez on #webkit).
2617
2618         Reverted changeset:
2619
2620         "[GStreamer] vid.me videos do not play"
2621         https://bugs.webkit.org/show_bug.cgi?id=172240
2622         http://trac.webkit.org/changeset/219194
2623
2624 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2625
2626         Unreviewed, rolling out r219178.
2627
2628         This caused a consistent failure with the API test
2629         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2630
2631         Reverted changeset:
2632
2633         "[WTF] Clean up StringStatics.cpp by using
2634         LazyNeverDestroyed<> for Atoms"
2635         https://bugs.webkit.org/show_bug.cgi?id=174150
2636         http://trac.webkit.org/changeset/219178
2637
2638 2017-07-06  Alicia Boya García  <aboya@igalia.com>
2639
2640         Add CWD to Perl library path (no longer the default since 5.26.0)
2641         https://bugs.webkit.org/show_bug.cgi?id=174200
2642
2643         Reviewed by Michael Catanzaro.
2644
2645         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2646         (SetupGitClone._get_username_and_email):
2647
2648 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2649
2650         Unreviewed, update my email address.
2651
2652         * Scripts/webkitpy/common/config/contributors.json:
2653
2654 2017-07-06  Charlie Turner  <cturner@igalia.com>
2655         [GStreamer] vid.me videos do not play
2656         https://bugs.webkit.org/show_bug.cgi?id=172240
2657
2658         Reviewed by Xabier Rodriguez-Calvar.
2659
2660         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2661         have the existing libsoup build against GNOME to avoid header drift
2662         against GStreamer's linked Soup library.
2663
2664         * gtk/jhbuild.modules:
2665
2666 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2667
2668         [WTF] Move SoftLinking.h into WTF
2669         https://bugs.webkit.org/show_bug.cgi?id=174000
2670
2671         Reviewed by Alex Christensen.
2672
2673         * DumpRenderTree/mac/TestRunnerMac.mm:
2674         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2675         (test_primary_header):
2676         (ErrorCollector.__init__): Deleted.
2677         (ErrorCollector.__call__): Deleted.
2678         (ErrorCollector.results): Deleted.
2679         (ErrorCollector.result_list): Deleted.
2680         (ErrorCollector.verify_all_categories_are_seen): Deleted.
2681         (MockIo.open): Deleted.
2682         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
2683         (CppFunctionsTest.test_create_acronym): Deleted.
2684         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
2685         (CppFunctionsTest.test_parameter): Deleted.
2686         (CppFunctionsTest.test_single_line_view): Deleted.
2687         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
2688         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
2689         (CppFunctionsTest.test_parameter_list): Deleted.
2690         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
2691         (CppStyleTestBase.process_file_data): Deleted.
2692         (CppStyleTestBase.perform_lint): Deleted.
2693         (CppStyleTestBase.perform_single_line_lint): Deleted.
2694         (CppStyleTestBase.perform_multi_line_lint): Deleted.
2695         (CppStyleTestBase.perform_language_rules_check): Deleted.
2696         (CppStyleTestBase.perform_function_lengths_check): Deleted.
2697         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
2698         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
2699         (CppStyleTestBase.perform_include_what_you_use): Deleted.
2700         (CppStyleTestBase.perform_header_guard_check): Deleted.
2701         (CppStyleTestBase.assert_lint): Deleted.
2702         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
2703         (CppStyleTestBase.assert_multi_line_lint): Deleted.
2704         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
2705         (CppStyleTestBase.assert_language_rules_check): Deleted.
2706         (CppStyleTestBase.assert_include_what_you_use): Deleted.
2707         (CppStyleTestBase.assert_header_guard): Deleted.
2708         (CppStyleTestBase.assert_blank_lines_check): Deleted.
2709         (CppStyleTestBase.assert_positions_equal): Deleted.
2710         (FunctionDetectionTest.test_basic_function_detection): Deleted.
2711         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
2712         (FunctionDetectionTest.test_pure_function_detection): Deleted.
2713         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
2714         (FunctionDetectionTest.test_ignore_macros): Deleted.
2715         (FunctionDetectionTest.test_non_functions): Deleted.
2716         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
2717         (FunctionDetectionTest.test_parameter_list): Deleted.
2718         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
2719         (CppStyleTest.test_asm_lines_ignored): Deleted.
2720         (CppStyleTest.test_get_line_width): Deleted.
2721         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
2722         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
2723         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
2724         (CppStyleTest.test_position): Deleted.
2725         (CppStyleTest.test_rfind_in_lines): Deleted.
2726         (CppStyleTest.test_close_expression): Deleted.
2727         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
2728         (CppStyleTest.test_cstyle_cast): Deleted.
2729         (CppStyleTest.test_runtime_casting): Deleted.
2730         (CppStyleTest.test_runtime_selfinit): Deleted.
2731         (CppStyleTest.test_runtime_rtti): Deleted.
2732         (CppStyleTest.test_static_cast_readability): Deleted.
2733         (CppStyleTest.test_check_for_unnamed_params): Deleted.
2734         (CppStyleTest.void): Deleted.
2735         (CppStyleTest.test_deprecated_cast): Deleted.
2736         (CppStyleTest.test_mock_method): Deleted.
2737         (CppStyleTest.test_sizeof_type): Deleted.
2738         (CppStyleTest.cases): Deleted.
2739         (CppStyleTest.for): Deleted.
2740         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
2741         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
2742         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
2743         (CppStyleTest.test_include_what_you_use): Deleted.
2744         (CppStyleTest.test_files_belong_to_same_module): Deleted.
2745         (CppStyleTest.test_cleanse_line): Deleted.
2746         (CppStyleTest.test_multi_line_comments): Deleted.
2747         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
2748         (CppStyleTest.test_multiline_strings): Deleted.
2749         (CppStyleTest.test_platformh_comments): Deleted.
2750         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
2751         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
2752         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
2753         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
2754         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
2755         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
2756         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
2757         (CppStyleTest.test_check_posix_threading): Deleted.
2758         (CppStyleTest.test_insecure_string_operations): Deleted.
2759         (CppStyleTest.test_format_strings): Deleted.
2760         (CppStyleTest.test_insecure_temp_file): Deleted.
2761         (CppStyleTest.test_variable_length_array_detection): Deleted.
2762         (CppStyleTest.test_braces): Deleted.
2763         (CppStyleTest.test_check_check): Deleted.
2764         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
2765         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
2766         (CppStyleTest.test_spacing_for_fncall): Deleted.
2767         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
2768         (CppStyleTest.test_spacing_before_braces): Deleted.
2769         (CppStyleTest.test_spacing_between_braces): Deleted.
2770         (CppStyleTest.test_spacing_before_brackets): Deleted.
2771         (CppStyleTest.test_cpp_lambda_functions): Deleted.
2772         (CppStyleTest.test_objective_c_block): Deleted.
2773         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
2774         (CppStyleTest.test_spacing_around_else): Deleted.
2775         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
2776         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
2777         (CppStyleTest.test_operator_methods): Deleted.
2778         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
2779         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
2780         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
2781         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
2782         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
2783         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
2784         (CppStyleTest.test_space_after_comment_marker): Deleted.
2785         (CppStyleTest.test_newline_at_eof): Deleted.
2786         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
2787         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
2788         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
2789         (CppStyleTest.test_invalid_utf8): Deleted.
2790         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
2791         (CppStyleTest.test_is_blank_line): Deleted.
2792         (CppStyleTest.test_blank_lines_check): Deleted.
2793         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
2794         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
2795         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
2796         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
2797         (CppStyleTest.test_comma): Deleted.
2798         (CppStyleTest.test_declaration): Deleted.
2799         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
2800         (CppStyleTest.test_indent): Deleted.
2801         (CppStyleTest.test_indent.Foo): Deleted.
2802         (CppStyleTest.test_not_alabel): Deleted.
2803         (CppStyleTest.test_tab): Deleted.
2804         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
2805         (CppStyleTest.test_build_class): Deleted.
2806         (CppStyleTest.test_build_class.definitions): Deleted.
2807         (CppStyleTest.test_build_class.Foo): Deleted.
2808         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
2809         (CppStyleTest.test_build_end_comment): Deleted.
2810         (CppStyleTest.test_build_forward_decl): Deleted.
2811         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
2812         (CppStyleTest.test_build_header_guard): Deleted.
2813         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
2814         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
2815         (CppStyleTest.test_build_printf_format): Deleted.
2816         (CppStyleTest.test_runtime_printf_format): Deleted.
2817         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
2818         (CppStyleTest.test_build_storage_class): Deleted.
2819         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
2820         (CppStyleTest.test_build_storage_class.declaration): Deleted.
2821         (CppStyleTest.test_build_storage_class.after): Deleted.
2822         (CppStyleTest.test_build_storage_class.is): Deleted.
2823         (CppStyleTest.test_legal_copyright): Deleted.
2824         (CppStyleTest.test_invalid_increment): Deleted.
2825         (CppStyleTest.test_enum_bitfields): Deleted.
2826         (CppStyleTest.test_plain_integral_bitfields): Deleted.
2827         (CleansedLinesTest.test_init_empty): Deleted.
2828         (CleansedLinesTest.test_collapse_strings): Deleted.
2829         (OrderOfIncludesTest.tearDown): Deleted.
2830         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
2831         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
2832         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
2833         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
2834         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
2835         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
2836         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
2837         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
2838         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
2839         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
2840         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
2841         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
2842         (OrderOfIncludesTest.test_primary_header): Deleted.
2843         (OrderOfIncludesTest.test_public_primary_header): Deleted.
2844         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
2845         (OrderOfIncludesTest.test_classify_include): Deleted.
2846         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
2847         (CheckForFunctionLengthsTest.tearDown): Deleted.
2848         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
2849         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
2850         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
2851         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
2852         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
2853         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
2854         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
2855         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
2856         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
2857         (CheckForFunctionLengthsTest.function_body): Deleted.
2858         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
2859         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
2860         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
2861         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
2862         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
2863         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
2864         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
2865         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
2866         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
2867         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
2868         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
2869         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
2870         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
2871         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
2872         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
2873         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
2874         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
2875         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
2876         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
2877         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
2878         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
2879         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
2880         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
2881         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
2882         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
2883         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
2884         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
2885         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
2886         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
2887         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
2888         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
2889         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
2890         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
2891         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
2892         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
2893         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
2894         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
2895         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
2896         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
2897         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
2898         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
2899         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
2900         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
2901         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
2902         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
2903         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
2904         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
2905         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
2906         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
2907         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
2908         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
2909         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
2910         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
2911         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
2912         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
2913         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
2914         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
2915         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
2916         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
2917         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
2918         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
2919         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
2920         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
2921         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
2922         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
2923         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
2924         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
2925         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
2926         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
2927         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
2928         (LeakyPatternTest.test_get_dc): Deleted.
2929         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
2930         (LeakyPatternTest.test_own_get_dc): Deleted.
2931         (LeakyPatternTest.test_create_dc): Deleted.
2932         (LeakyPatternTest.test_create_compatible_dc): Deleted.
2933         (WebKitStyleTest.test_indentation): Deleted.
2934         (WebKitStyleTest.test_indentation.Foo): Deleted.
2935         (WebKitStyleTest.test_indentation.Document): Deleted.
2936         (WebKitStyleTest.test_spacing): Deleted.
2937         (WebKitStyleTest.test_line_breaking): Deleted.
2938         (WebKitStyleTest.test_braces): Deleted.
2939         (WebKitStyleTest.test_braces.MyClass): Deleted.
2940         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
2941         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
2942         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
2943         (WebKitStyleTest.test_null_false_zero): Deleted.
2944         (WebKitStyleTest.test_directive_indentation): Deleted.
2945         (WebKitStyleTest.test_using_std): Deleted.
2946         (WebKitStyleTest.test_using_namespace): Deleted.
2947         (WebKitStyleTest.test_max_macro): Deleted.
2948         (WebKitStyleTest.test_min_macro): Deleted.
2949         (WebKitStyleTest.test_wtf_move): Deleted.
2950         (WebKitStyleTest.test_ctype_fucntion): Deleted.
2951         (WebKitStyleTest.test_names): Deleted.
2952         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2953         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2954         (WebKitStyleTest.test_names.declarations): Deleted.
2955         (WebKitStyleTest.test_names.struct): Deleted.
2956         (WebKitStyleTest.test_names.VectorType): Deleted.
2957         (WebKitStyleTest.test_parameter_names): Deleted.
2958         (WebKitStyleTest.test_comments): Deleted.
2959         (WebKitStyleTest.test_webkit_export_check): Deleted.
2960         (WebKitStyleTest.test_member_initialization_list): Deleted.
2961         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2962         (WebKitStyleTest.test_other): Deleted.
2963         (CppCheckerTest.mock_handle_style_error): Deleted.
2964         (CppCheckerTest._checker): Deleted.
2965         (CppCheckerTest.test_init): Deleted.
2966         (CppCheckerTest.test_eq): Deleted.
2967         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2968         (CppCheckerTest.test_ne): Deleted.
2969         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2970         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2971         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2972         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2973         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2974         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2975
2976 2017-07-05  Saam Barati  <sbarati@apple.com>
2977
2978         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2979         https://bugs.webkit.org/show_bug.cgi?id=174188
2980         <rdar://problem/30581423>
2981
2982         Reviewed by Mark Lam.
2983
2984         * Scripts/run-jsc-stress-tests:
2985
2986 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2987
2988         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2989         https://bugs.webkit.org/show_bug.cgi?id=174150
2990
2991         Reviewed by Mark Lam.
2992
2993         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2994         (TestWebKitAPI::TEST):
2995
2996 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2997
2998         Remove copy of ICU headers from WebKit
2999         https://bugs.webkit.org/show_bug.cgi?id=116407
3000
3001         Reviewed by Alex Christensen.
3002
3003         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3004         * TestWebKitAPI/Configurations/Base.xcconfig:
3005         * WebKitTestRunner/Configurations/Base.xcconfig:
3006
3007 2017-07-05  Chris Dumez  <cdumez@apple.com>
3008
3009         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
3010         https://bugs.webkit.org/show_bug.cgi?id=174163
3011         <rdar://problem/33067518>
3012
3013         Reviewed by Alex Christensen.
3014
3015         Add API test coverage.
3016
3017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3018         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
3019         (TEST):
3020
3021 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3022
3023         When dragging a selection, clearing the selection in dragstart should not crash the web process
3024         https://bugs.webkit.org/show_bug.cgi?id=174142
3025         <rdar://problem/33067501>
3026
3027         Reviewed by Tim Horton.
3028
3029         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
3030         drag is starting up.
3031
3032         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3033         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
3034         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3035         (TestWebKitAPI::TEST):
3036
3037 2017-07-05  Daniel Bates  <dabates@apple.com>
3038
3039         Do not pass API::FrameInfo for source frame or clear out page of target frame on
3040         API navigation
3041         https://bugs.webkit.org/show_bug.cgi?id=174170
3042         <rdar://problem/33140328>
3043
3044         Reviewed by Brady Eidson.
3045
3046         Update tests as needed for the behavior change.
3047
3048         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
3049         (TEST):
3050
3051 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3052
3053         Add WebKitPrivateFrameworkStubs for iOS 11
3054         https://bugs.webkit.org/show_bug.cgi?id=173988
3055
3056         Reviewed by David Kilzer.
3057
3058         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
3059         should use the same directory for private framework stubs.
3060         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3061
3062 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
3063
3064         [MediaStream] Protect request and web view during gUM client callback
3065         https://bugs.webkit.org/show_bug.cgi?id=174096
3066         <rdar://problem/32833102>
3067
3068         Reviewed by Youenn Fablet.
3069
3070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3071         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3072
3073 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3074
3075         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
3076
3077         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3078
3079 2017-07-05  Matt Lewis  <jlewis3@apple.com>
3080
3081         Unreviewed, rolling out r219128.
3082
3083         Spoke with engineer who originally submitted, Patch for APi
3084         test to follow.
3085
3086         Reverted changeset:
3087
3088         "Unreviewed, rolling out r219070."
3089         https://bugs.webkit.org/show_bug.cgi?id=174082
3090         http://trac.webkit.org/changeset/219128
3091
3092 2017-07-05  Matt Lewis  <jlewis3@apple.com>
3093
3094         Unreviewed, rolling out r219070.
3095
3096         This revision caused consistent failures of the API test
3097         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
3098
3099         Reverted changeset:
3100
3101         "Pasting single words copied to UIPasteboard inserts URLs in
3102         editable areas"
3103         https://bugs.webkit.org/show_bug.cgi?id=174082
3104         http://trac.webkit.org/changeset/219070
3105
3106 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3107
3108         Remove unused EFL logo from bot watcher dashboard
3109         https://bugs.webkit.org/show_bug.cgi?id=174136
3110
3111         Reviewed by Alexey Proskuryakov.
3112
3113         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
3114         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
3115
3116 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3117
3118         [GTK] Add more GTK bots to dashboard
3119         https://bugs.webkit.org/show_bug.cgi?id=174129
3120
3121         Reviewed by Carlos Alberto Lopez Perez.
3122
3123         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
3124         them.
3125
3126         This also changes the sort order to put WPE above GTK so that it's not buried under all the
3127         less-essential GTK bots.
3128
3129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3130         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3131         (WebKitBuildbot):
3132
3133 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3134
3135         [WPE] Add WPE to bot watcher dashboard
3136         https://bugs.webkit.org/show_bug.cgi?id=174119
3137
3138         Reviewed by Alexey Proskuryakov.
3139
3140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
3141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
3142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
3143         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3145         (WebKitBuildbot):
3146         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3147         (table.queue-grid tr.platform.linux-wpe img.logo):
3148
3149 2017-07-03  Lucas Forschler  <lforschler@apple.com>
3150
3151         https://bugs.webkit.org/show_bug.cgi?id=174105
3152         
3153         Reviewed by Stephanie Lewis.
3154
3155         * BuildSlaveSupport/built-product-archive:
3156         (main): Add a -minify parser option
3157         (createZip): Pass along the optional Minify argument if requested
3158         (minifySource): This will trim down archives, logic limited to Mac platform.
3159
3160 2017-07-03  Matt Rajca  <mrajca@apple.com>
3161
3162         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
3163         https://bugs.webkit.org/show_bug.cgi?id=174103
3164
3165         Reviewed by Alex Christensen.
3166
3167         Added an API test.
3168
3169         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
3170         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3171         (TEST): Added test.
3172         * TestWebKitAPI/cocoa/TestWKWebView.h:
3173         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3174         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
3175
3176 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3177
3178         Unreviewed, rolling out r219103.
3179
3180         Caused multiple build failures.
3181
3182         Reverted changeset:
3183
3184         "Remove copy of ICU headers from WebKit"
3185         https://bugs.webkit.org/show_bug.cgi?id=116407
3186         http://trac.webkit.org/changeset/219103
3187
3188 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3189
3190         Remove copy of ICU headers from WebKit
3191         https://bugs.webkit.org/show_bug.cgi?id=116407
3192
3193         Reviewed by Alex Christensen.
3194
3195         Use WTF's copy of ICU headers.
3196
3197         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3198         * TestWebKitAPI/Configurations/Base.xcconfig:
3199         * WebKitTestRunner/Configurations/Base.xcconfig:
3200
3201 2017-07-03  Brady Eidson  <beidson@apple.com>
3202
3203         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3204         https://bugs.webkit.org/show_bug.cgi?id=174073
3205
3206         Reviewed by Andy Estes.
3207
3208         * DumpRenderTree/mac/TestRunnerMac.mm:
3209         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
3210
3211         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
3212         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3213
3214 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3215
3216         Unreviewed, rolling out r219083.
3217
3218         The revision caused an API failure on all testing platforms.
3219
3220         Reverted changeset:
3221
3222         "[MediaStream] Protect request and web view during gUM client
3223         callback"
3224         https://bugs.webkit.org/show_bug.cgi?id=174096
3225         http://trac.webkit.org/changeset/219083
3226
3227 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
3228
3229         webkitpy: Properly number duplicated crashlogs
3230         https://bugs.webkit.org/show_bug.cgi?id=172002
3231
3232         Reviewed by Aakash Jain.
3233
3234         * Scripts/webkitpy/common/system/crashlogs.py:
3235         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
3236         an increasing integer.
3237         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3238         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
3239         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
3240         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
3241
3242 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
3243
3244         WebContent processes crash when the network process crashes with pending connection requests
3245         https://bugs.webkit.org/show_bug.cgi?id=174065
3246         <rdar://problem/30359835>
3247
3248         Reviewed by Tim Horton.
3249
3250         Add a API to ensure UI process tries to relaunch a new network process when the network process
3251         crashes with pending network connection requests.
3252
3253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3254         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
3255         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3256         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3257         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
3258
3259 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
3260
3261         [MediaStream] Protect request and web view during gUM client callback
3262         https://bugs.webkit.org/show_bug.cgi?id=174096
3263         <rdar://problem/32833102>
3264
3265         Reviewed by Youenn Fablet.
3266
3267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3268         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3269
3270 2017-07-03  Andy Estes  <aestes@apple.com>
3271
3272         [Xcode] Add an experimental setting to build with ccache
3273         https://bugs.webkit.org/show_bug.cgi?id=173875
3274
3275         Reviewed by Tim Horton.
3276
3277         On systems that already have ccache(1) installed, this patch adds experimental support for
3278         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
3279
3280         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
3281         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
3282         find the toolchain from which to run clang, and then invokes ccache with the required
3283         arguments.
3284
3285         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
3286         precompiled headers to work properly [1].
3287
3288         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
3289         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
3290         during linking.
3291         
3292         [1] https://ccache.samba.org/manual.html#_precompiled_headers
3293
3294         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3295         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3296         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3297         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
3298         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
3299         * ccache/README.md: Added.
3300         * ccache/ccache-clang: Added.
3301         * ccache/ccache-clang++: Added.
3302         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
3303
3304 2017-07-03  Alex Christensen  <achristensen@webkit.org>
3305
3306         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3307         https://bugs.webkit.org/show_bug.cgi?id=174051
3308
3309         Reviewed by Tim Horton.
3310
3311         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3312         (TestWebKitAPI::TEST_F):
3313
3314 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3315
3316         Unreviewed, rolling out r219024.
3317
3318         This patch cause 3 didferent test to fail.
3319
3320         Reverted changeset:
3321
3322         "REGRESSION(r215096) Queries of URLs with non-special schemes
3323         should not percent-encode single quotes"
3324         https://bugs.webkit.org/show_bug.cgi?id=174051
3325         http://trac.webkit.org/changeset/219024
3326
3327 2017-07-03  Chris Dumez  <cdumez@apple.com>
3328
3329         Drop ResourceLoadStatisticsStore's statisticsLock
3330         https://bugs.webkit.org/show_bug.cgi?id=174080
3331
3332         Reviewed by Brent Fulgham.
3333
3334         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
3335
3336         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3337         (WTR::TestController::isStatisticsPrevalentResource):
3338         (WTR::TestController::isStatisticsHasHadUserInteraction):
3339         (WTR::TestController::isStatisticsGrandfathered):
3340
3341 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3342
3343         Pasting single words copied to UIPasteboard inserts URLs in editable areas
3344         https://bugs.webkit.org/show_bug.cgi?id=174082
3345         <rdar://problem/33046992>
3346
3347         Reviewed by Tim Horton.
3348
3349         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
3350
3351         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3352         (TestWebKitAPI::setUpWebViewForPasteboardTests):
3353         (TestWebKitAPI::TEST):
3354
3355 2017-07-02  Brady Eidson  <beidson@apple.com>
3356
3357         Add API test for all parts of WebKit1 API related to favicons.
3358         https://bugs.webkit.org/show_bug.cgi?id=174069
3359
3360         Reviewed by Andy Estes.
3361
3362         These two API tests cover all WebKit1 API related to icons.
3363         
3364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3365         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
3366         (mainResourceData):
3367         (defaultFaviconData):
3368         (customFaviconData):
3369         (imageFromData):
3370         (+[IconLoadingProtocol canInitWithRequest:]):
3371         (+[IconLoadingProtocol canonicalRequestForRequest:]):
3372         (-[IconLoadingProtocol startLoading]):
3373         (-[IconLoadingProtocol stopLoading]):
3374         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3375         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3376         (TestWebKitAPI::TEST):
3377
3378 2017-07-01  Dan Bernstein  <mitz@apple.com>
3379
3380         [iOS] Remove code only needed when building for iOS 9.x
3381         https://bugs.webkit.org/show_bug.cgi?id=174068
3382
3383         Reviewed by Tim Horton.
3384
3385         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3386         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3387         (WTR::initializeWebViewConfiguration):
3388         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3389         (-[HIDEventGenerator _createIOHIDEventType:]):
3390
3391 2017-07-01  Brady Eidson  <beidson@apple.com>
3392
3393         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
3394         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
3395
3396         Reviewed by Alex Christensen.
3397
3398         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3399
3400 2017-07-01  Dan Bernstein  <mitz@apple.com>
3401
3402         [macOS] Remove code only needed when building for OS X Yosemite
3403         https://bugs.webkit.org/show_bug.cgi?id=174067
3404
3405         Reviewed by Tim Horton.
3406
3407         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3408         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3409         * DumpRenderTree/mac/DumpRenderTree.mm:
3410         (setDefaultsToConsistentValuesForTesting):
3411         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3412         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3413         * MiniBrowser/Configurations/Base.xcconfig:
3414         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3415         * TestWebKitAPI/Configurations/Base.xcconfig:
3416         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3417         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3418         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
3419         (TestWebKitAPI::TEST_F):
3420         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
3421         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3422         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3423         (TestWebKitAPI::TEST_F):
3424         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3425         (TestWebKitAPI::TEST):
3426         * WebKitTestRunner/Configurations/Base.xcconfig:
3427         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3428         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3429         (WTR::InjectedBundle::platformInitialize):
3430         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3431         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3432
3433 2017-07-01  Chris Dumez  <cdumez@apple.com>
3434
3435         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
3436         https://bugs.webkit.org/show_bug.cgi?id=174060
3437
3438         Reviewed by Brent Fulgham.
3439
3440         Port WebKitTestRunner over to the new Cocoa SPI.
3441
3442         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3443         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3444         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3445         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
3446         no-ops since this code runs in the WebContent process, not the
3447         UIProcess.
3448
3449         * WebKitTestRunner/TestController.cpp:
3450         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3451
3452 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3453
3454         Unreviewed mac build fix.
3455
3456         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
3457         (TestWebKitAPI::TEST):
3458
3459 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3460
3461         Add API to get WKActivatedElementInfo
3462         https://bugs.webkit.org/show_bug.cgi?id=174001
3463         <rdar://problem/29165518>
3464         
3465         Tests for now SPI to get activatedElementInfo.
3466
3467         Reviewed by Tim Horton.
3468
3469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3470         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
3471         (TestWebKitAPI::TEST):
3472
3473 2017-06-30  Chris Dumez  <cdumez@apple.com>
3474
3475         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
3476         https://bugs.webkit.org/show_bug.cgi?id=174038
3477
3478         Reviewed by Brent Fulgham.
3479
3480         Fix typo in API name.
3481
3482         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3483         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3484         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3485         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3486         * WebKitTestRunner/TestController.cpp:
3487         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3488         * WebKitTestRunner/TestController.h:
3489         * WebKitTestRunner/TestInvocation.cpp:
3490         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3491
3492 2017-06-30  Alex Christensen  <achristensen@webkit.org>
3493
3494         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3495         https://bugs.webkit.org/show_bug.cgi?id=174051
3496         <rdar://problem/33002846>
3497
3498         Reviewed by Tim Horton.
3499
3500         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3501         (TestWebKitAPI::TEST_F):
3502
3503 2017-06-30  Daniel Bates  <dabates@apple.com>
3504
3505         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3506         https://bugs.webkit.org/show_bug.cgi?id=165160
3507         <rdar://problem/29451999>
3508
3509         Reviewed by Brady Eidson.
3510
3511         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
3512         for navigations and window creation.
3513
3514         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3515         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
3516         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3517         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
3518         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3519         (TEST):
3520
3521 2017-06-29  Jer Noble  <jer.noble@apple.com>
3522
3523         Make Legacy EME API controlled by RuntimeEnabled setting.
3524         https://bugs.webkit.org/show_bug.cgi?id=173994
3525
3526         Reviewed by Sam Weinig.
3527
3528         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3529
3530 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3531
3532         Follow-up fix for r218996
3533
3534         Unreviewed infrastructure fix.
3535
3536         Repeated calls to 'ios_version' make the log noisy, memoize the function.
3537
3538         * Scripts/webkitpy/port/ios_simulator.py:
3539         (IOSSimulatorPort): Memoize ios_version().
3540
3541 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3542
3543         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3544         https://bugs.webkit.org/show_bug.cgi?id=174017
3545         <rdar://problem/32959782>
3546
3547         Reviewed by Simon Fraser.
3548
3549         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
3550         changes, the caret would appear outside of the iframe.
3551
3552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3553         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
3554         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3555         (checkDragCaretRectIsContainedInRect):
3556         (TestWebKitAPI::TEST):
3557         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3558         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3559         (-[DataInteractionSimulator _resetSimulatedState]):
3560         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3561         (-[DataInteractionSimulator _advanceProgress]):
3562         (-[DataInteractionSimulator lastKnownDragCaretRect]):
3563
3564 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3565
3566         Add support for different versions of iOS when loading test expectations
3567         https://bugs.webkit.org/show_bug.cgi?id=173774
3568         <rdar://problem/32951132>
3569
3570         Rubber-stamped by Aakash Jain.
3571
3572         When running layout tests, we should support multiple version of iOS the same way we do Mac.
3573
3574         * Scripts/webkitpy/port/ios.py:
3575         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
3576         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
3577         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
3578         * Scripts/webkitpy/port/ios_device.py:
3579         (IOSDevicePort.ios_version): Ask connected devices for implementation.
3580         * Scripts/webkitpy/port/ios_device_unittest.py:
3581         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
3582         (IOSDeviceTest.test_baseline_searchpath): Ditto.
3583         (IOSDeviceTest.test_expectations_ordering): Ditto.
3584         * Scripts/webkitpy/port/ios_simulator.py:
3585         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
3586         ask the platform.
3587
3588 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
3589
3590         Fontconfig build breaks with glibc 2.15+
3591         https://bugs.webkit.org/show_bug.cgi?id=174019
3592
3593         Reviewed by Carlos Alberto Lopez Perez.
3594
3595         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
3596
3597         * wpe/jhbuild.modules:
3598         * wpe/patches/fontconfig-avoi