39b34bf3d07a7dcdc4981eedbbcbce0556aa83b0
[WebKit-https.git] / Tools / ChangeLog
1 2013-02-04  Jochen Eisinger  <jochen@chromium.org>
2
3         [chromium] Remove WebEventSender and WebAccessibilityController from public TestRunner API
4         https://bugs.webkit.org/show_bug.cgi?id=108467
5
6         Reviewed by Adam Barth.
7
8         * DumpRenderTree/DumpRenderTree.gypi:
9         * DumpRenderTree/chromium/TestRunner/public/WebAccessibilityController.h: Removed.
10         * DumpRenderTree/chromium/TestRunner/public/WebEventSender.h: Removed.
11         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
12         (WebTestRunner):
13         (WebTestInterfaces):
14         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
15         (WebTestRunner):
16         (WebTestProxyBase):
17         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
18         (WebTestRunner):
19         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
20         (WebTestRunner):
21         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
22         (WebTestRunner::TestInterfaces::TestInterfaces):
23         (WebTestRunner::TestInterfaces::setWebView):
24         (WebTestRunner::TestInterfaces::webView):
25         (WebTestRunner):
26         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
27         (TestInterfaces):
28         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
29         (TestRunner):
30         * DumpRenderTree/chromium/TestRunner/src/WebAccessibilityController.cpp: Removed.
31         * DumpRenderTree/chromium/TestRunner/src/WebEventSender.cpp: Removed.
32         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
33         (WebTestRunner::WebTestInterfaces::WebTestInterfaces):
34         (WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
35         (WebTestRunner::WebTestInterfaces::setWebView):
36         (WebTestRunner::WebTestInterfaces::setDelegate):
37         (WebTestRunner::WebTestInterfaces::bindTo):
38         (WebTestRunner::WebTestInterfaces::resetAll):
39         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
40         (WebTestRunner::WebTestInterfaces::webView):
41         (WebTestRunner::WebTestInterfaces::testRunner):
42         (WebTestRunner::WebTestInterfaces::testInterfaces):
43         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
44         (WebTestRunner::WebTestProxyBase::setInterfaces):
45         * DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Removed.
46         * DumpRenderTree/chromium/TestShell.h:
47         * DumpRenderTree/chromium/WebViewHost.cpp:
48         * DumpRenderTree/chromium/WebViewHost.h:
49
50 2013-02-04  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
51
52         [EFL] Add "full screen" parameter to MiniBrowser
53         https://bugs.webkit.org/show_bug.cgi?id=108850
54
55         Reviewed by Antonio Gomes.
56
57         Implements the {-F,--full-screen}={true,false} parameter to WebKit EFL's
58         MiniBrowser.
59
60         * MiniBrowser/efl/main.c:
61         (window_create):
62         (elm_main):
63         Added '-F/--full-screen' parameter functionality.
64
65 2013-02-04  Jochen Eisinger  <jochen@chromium.org>
66
67         [chromium] remove WebTestPlugin from the public TestRunner API
68         https://bugs.webkit.org/show_bug.cgi?id=108467
69
70         Reviewed by Adam Barth.
71
72         * DumpRenderTree/DumpRenderTree.gypi:
73         * DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h: Removed.
74         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
75         (WebKit):
76         (WebTestProxyBase):
77         (WebTestRunner::WebTestProxy::createPlugin):
78         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp.
79         (WebTestRunner::TestPlugin::TestPlugin):
80         (WebTestRunner):
81         (WebTestRunner::TestPlugin::~TestPlugin):
82         (WebTestRunner::TestPlugin::initialize):
83         (WebTestRunner::TestPlugin::destroy):
84         (WebTestRunner::TestPlugin::updateGeometry):
85         (WebTestRunner::TestPlugin::parsePrimitive):
86         (WebTestRunner::TestPlugin::parseColor):
87         (WebTestRunner::TestPlugin::parseOpacity):
88         (WebTestRunner::TestPlugin::parseBoolean):
89         (WebTestRunner::TestPlugin::initScene):
90         (WebTestRunner::TestPlugin::drawScene):
91         (WebTestRunner::TestPlugin::destroyScene):
92         (WebTestRunner::TestPlugin::initProgram):
93         (WebTestRunner::TestPlugin::initPrimitive):
94         (WebTestRunner::TestPlugin::drawPrimitive):
95         (WebTestRunner::TestPlugin::loadShader):
96         (WebTestRunner::TestPlugin::loadProgram):
97         (WebTestRunner::TestPlugin::handleInputEvent):
98         (WebTestRunner::TestPlugin::handleDragStatusUpdate):
99         (WebTestRunner::TestPlugin::create):
100         (WebTestRunner::TestPlugin::mimeType):
101         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Added.
102         (WebTestRunner):
103         (TestPlugin):
104         (WebTestRunner::TestPlugin::scriptableObject):
105         (WebTestRunner::TestPlugin::canProcessDrag):
106         (WebTestRunner::TestPlugin::paint):
107         (WebTestRunner::TestPlugin::updateFocus):
108         (WebTestRunner::TestPlugin::updateVisibility):
109         (WebTestRunner::TestPlugin::acceptsInputEvents):
110         (WebTestRunner::TestPlugin::didReceiveResponse):
111         (WebTestRunner::TestPlugin::didReceiveData):
112         (WebTestRunner::TestPlugin::didFinishLoading):
113         (WebTestRunner::TestPlugin::didFailLoading):
114         (WebTestRunner::TestPlugin::didFinishLoadingFrameRequest):
115         (WebTestRunner::TestPlugin::didFailLoadingFrameRequest):
116         (WebTestRunner::TestPlugin::isPlaceholder):
117         (WebTestRunner::TestPlugin::prepareTexture):
118         (WebTestRunner::TestPlugin::context):
119         (Scene):
120         (WebTestRunner::TestPlugin::Scene::Scene):
121         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
122         (WebTestRunner::WebTestProxyBase::createPlugin):
123         (WebTestRunner):
124         * DumpRenderTree/chromium/WebViewHost.cpp:
125         (WebViewHost::createPlugin):
126
127 2013-02-04  Gustavo Noronha Silva  <gns@gnome.org>
128
129         Add a new method for obtaining a build-type-dependent path,
130         instead of modifying all call sites to pass it in.
131
132         Reviewed by Martin Robinson.
133
134         * Scripts/run-gtk-tests:
135         (TestRunner.__init__): use the new method, which takes a tuple.
136         (TestRunner._setup_testing_environment): ditto.
137         * gtk/common.py:
138         (get_build_path): accept a tuple that may include Release and
139         Debug as build types, for searching.
140         (build_path_for_build_types): new method that finds the path when
141         it is dependent on the build type.
142         (build_path): restore its original behaviour.
143
144 2013-02-04  David Kilzer  <ddkilzer@apple.com>
145
146         Remove duplicate entry from DumpRenderTree Xcode project
147
148             $ uniq Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj | diff -u - Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj | patch -p0 -R
149             patching file Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
150
151         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
152         Remove duplicate.
153
154 2013-02-04  David Kilzer  <ddkilzer@apple.com>
155
156         Sort TestWebKitAPI Xcode project file
157
158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
159
160 2013-02-03  Alan Cutter  <alancutter@chromium.org>
161
162         PatchLogs are not getting created on QueueStatusServer
163         https://bugs.webkit.org/show_bug.cgi?id=108593
164
165         Reviewed by Eric Seidel.
166
167         Added missing "added" patch event to submit-to-ews handler.
168
169         * QueueStatusServer/app.yaml:
170         * QueueStatusServer/handlers/submittoews.py:
171         (SubmitToEWS._add_attachment_to_ews_queues):
172
173 2013-02-03  Douglas Stockwell  <dstockwell@chromium.org>
174
175         Unreviewed. Add dstockwell as a contributor in comitters.py and to the watchlist for animation
176         https://bugs.webkit.org/show_bug.cgi?id=108777
177
178         * Scripts/webkitpy/common/config/committers.py:
179         * Scripts/webkitpy/common/config/watchlist:
180
181 2013-02-03  Sam Weinig  <sam@webkit.org>
182
183         Fix failing test.
184
185         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
186         (TestWebKitAPI::didFinishLoadForFrame):
187
188 2013-02-03  Timothy Loh  <timloh@chromium.com>
189
190         Make ChangeLogEntry detect annotations by prepare-ChangeLog (Added/Removed/Copied from/Renamed from) as clean.
191         https://bugs.webkit.org/show_bug.cgi?id=108433
192
193         Reviewed by Eric Seidel.
194
195         PrepareChangeLog is supposed to update the file/function list if we
196         haven't touched it, but the existing regex doesn't handle the
197         annotations prepare-ChangeLog adds (e.g. "Added.")
198
199         * Scripts/webkitpy/common/checkout/changelog.py:
200         (ChangeLogEntry.is_touched_files_text_clean):
201         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
202         (test_is_touched_files_text_clean):
203
204 2013-02-02  Dean Jackson  <dino@apple.com>
205
206         Add Antoine Quint to the list of committers
207         https://bugs.webkit.org/show_bug.cgi?id=108750
208
209         No review necessary.
210
211         * Scripts/webkitpy/common/config/committers.py:
212
213 2013-02-02  Patrick Gansterer  <paroga@webkit.org>
214
215         [CMake] Adopt the WinCE port to new CMake
216         https://bugs.webkit.org/show_bug.cgi?id=108754
217
218         Reviewed by Laszlo Gombos.
219
220         * WinCELauncher/CMakeLists.txt: Mark WinCELauncher
221         as WIN32 target to use the correct entry point.
222
223 2013-02-02  Alexey Proskuryakov  <ap@apple.com>
224
225         One is not allowed to use commit-queue to make oneself a committer.
226
227         * Scripts/webkitpy/common/config/committers.py: Rolled out r141693.
228         Also, changed e-mail order for Yongjun Zhang, so that Bugzilla autocomplete works.
229
230 2013-02-02  Antoine Quint  <graouts@apple.com>
231
232         Add Antoine Quint to the list of committers
233         https://bugs.webkit.org/show_bug.cgi?id=108750
234
235         Reviewed by Dean Jackson.
236
237         * Scripts/webkitpy/common/config/committers.py:
238
239 2013-02-01  Adrian Perez de Castro  <aperez@igalia.com>
240
241         [GTK] Building fails in an armv5tel board
242         https://bugs.webkit.org/show_bug.cgi?id=108083
243
244         Reviewed by Martin Robinson.
245
246         In some systems in which $architecture is filled-in from "uname -m"
247         the value may not start with "arm-", but with "armvN", where "N" is
248         an architecture version number. The regexp in isARM() is modified
249         so it covers these kind of cases.
250
251         * Scripts/webkitdirs.pm:
252         (isARM):
253
254 2013-02-01  Gregg Tavares  <gman@google.com>
255
256         Update LayoutTests scripts to skip webgl folder on ports
257         https://bugs.webkit.org/show_bug.cgi?id=108705
258
259         Reviewed by Dirk Pranke.
260
261         I'm working on checking in the WebGL Conformance Tests
262         as layout tests into LayoutTests/webgl. For ports
263         that do not have WebGL enabled this changes will
264         skip tests in the "webgl" folder.
265
266         * Scripts/webkitpy/layout_tests/port/base.py:
267         (Port._missing_symbol_to_skipped_tests):
268         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
269         (PortTestCase.test_skipped_directories_for_symbols):
270
271 2013-02-01  Roger Fong  <roger_fong@apple.com>
272
273         Unreviewed. Fix for webkitpy tests.
274
275         * Scripts/webkitpy/tool/steps/runtests.py:
276         (RunTests.run):
277         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
278
279 2013-02-01  Jer Noble  <jer.noble@apple.com>
280
281         LLDB: add synthetic provider for WTF::HashTable
282         https://bugs.webkit.org/show_bug.cgi?id=108718
283
284         Reviewed by Darin Adler.
285
286         Add a synthetic provider which will emit the contents of a given
287         WTF::HashTable. This allows clients using Xcode/lldb to enumerate
288         the hash contents.
289
290         * lldb/lldb_webkit.py:
291         (__lldb_init_module):
292         (__lldb_init_module.lldb_webkit):
293         (WTFHashTable_SummaryProvider):
294         (WTFVectorProvider.has_children):
295         (WTFHashTableProvider):
296         (WTFHashTableProvider.__init__):
297         (WTFHashTableProvider.num_children):
298         (WTFHashTableProvider.get_child_index):
299         (WTFHashTableProvider.get_child_at_index):
300         (WTFHashTableProvider.tableSize):
301         (WTFHashTableProvider.keyCount):
302         (WTFHashTableProvider.update):
303         (WTFHashTableProvider.has_children):
304
305 2013-02-01  Roger Fong  <roger_fong@apple.com>
306
307         Unreviewed. Fix webkitpy tests since a build_style is not specified in some cases.
308
309         * Scripts/webkitpy/tool/steps/runtests.py:
310         (RunTests.run):
311
312 2013-02-01  Roger Fong  <roger_fong@apple.com>
313
314         Unreviewed. Re-try enabling Win-EWS tests for the third time. 
315         https://bugs.webkit.org/show_bug.cgi?id=107968
316
317         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
318         (WinEWS):
319
320 2013-01-31  Roger Fong  <roger_fong@apple.com>
321
322         Fix test scripts for EWS bots to get them running once and for all.
323         https://bugs.webkit.org/show_bug.cgi?id=108422
324
325         Reviewed by Timothy Horton.
326
327         Disabling --quiet option on Windows for now because that fails when we try to use /dev/null.
328         runtests.py was not passing in a configuration to run-webkit-tests which causes DRT to build in release by default.
329         However, we build in Debug only on the EWS Windows bots, which caused the build to fail.
330
331         * Scripts/webkitpy/tool/steps/runtests.py:
332         (RunTests.options):
333         (RunTests.run):
334
335 2013-02-01  Nico Weber  <thakis@chromium.org>
336
337         [chromium] Build webkit with enable_web_intents set to 0.
338         https://bugs.webkit.org/show_bug.cgi?id=108408
339
340         Reviewed by Tony Chang.
341
342         I'll then make chromium build fine with that, then switch
343         enable_web_intents to 0, roll that into webkit, and then
344         actually remove the code hidden behind this flag.
345
346         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
347         (WebTestRunner::TestRunner::TestRunner):
348         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
349         (WebTestRunner::WebTestProxyBase::registerIntentService):
350         (WebTestRunner::WebTestProxyBase::dispatchIntent):
351         * DumpRenderTree/chromium/WebViewHost.cpp:
352         * DumpRenderTree/chromium/WebViewHost.h:
353         (WebViewHost):
354
355 2013-02-01  Zan Dobersek  <zdobersek@igalia.com>
356
357         Set the GTK 64-bit Debug builder to build and test only WebKit1
358         https://bugs.webkit.org/show_bug.cgi?id=108648
359
360         Reviewed by Philippe Normand.
361
362         * BuildSlaveSupport/build.webkit.org-config/config.json: Change the builder name, type and
363         build directory to note that the builder builds and tests only the WebKit1 port on the GTK platform.
364         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
365         (CompileWebKit1Only): Add the new build class that builds only the WebKit1 port of the builder's platform.
366         (BuildAndTestWebKit1OnlyFactory): Add the new factory that uses the CompileWebKit1Only build class
367         for building and testing only WebKit1 on the builder's platform.
368
369 2013-02-01  Jochen Eisinger  <jochen@chromium.org>
370
371         [chromium] move ownership of TestRunner object to TestInterfaces
372         https://bugs.webkit.org/show_bug.cgi?id=108464
373
374         Reviewed by Adam Barth.
375
376         Before, TestShell owned the class. This also removes the last include
377         from DumpRenderTree to TestRunner/src.
378
379         This also deletes TestDelegate and uses WebTestDelegate everywhere
380         instead.
381
382         * DumpRenderTree/DumpRenderTree.gypi:
383         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
384         (WebTestInterfaces):
385         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
386         (WebKit):
387         (WebTestRunner):
388         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
389         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
390         (WebTestRunner):
391         (WebTestRunner::AccessibilityController::setDelegate):
392         (AccessibilityController):
393         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
394         (WebTestRunner):
395         (WebTestRunner::makeMenuItemStringsFor):
396         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
397         (WebTestRunner):
398         (WebTestRunner::EventSender::setDelegate):
399         (EventSender):
400         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:
401         (WebTestRunner::GamepadController::setDelegate):
402         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
403         (WebTestRunner):
404         (GamepadController):
405         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: Removed.
406         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
407         (WebTestRunner::TestInterfaces::TestInterfaces):
408         (WebTestRunner::TestInterfaces::~TestInterfaces):
409         (WebTestRunner::TestInterfaces::setWebView):
410         (WebTestRunner::TestInterfaces::setDelegate):
411         (WebTestRunner::TestInterfaces::bindTo):
412         (WebTestRunner::TestInterfaces::resetAll):
413         (WebTestRunner):
414         (WebTestRunner::TestInterfaces::setTestIsRunning):
415         (WebTestRunner::TestInterfaces::testRunner):
416         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
417         (WebTestRunner):
418         (TestInterfaces):
419         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
420         (WebTestRunner::TestRunner::TestRunner):
421         (WebTestRunner::TestRunner::reset):
422         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
423         (WebKit):
424         (TestRunner):
425         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
426         (WebTestRunner::WebTestInterfaces::Internal::testRunner):
427         (WebTestInterfaces::Internal):
428         (WebTestRunner::WebTestInterfaces::Internal::Internal):
429         (WebTestRunner::WebTestInterfaces::Internal::setDelegate):
430         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
431         * DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Added.
432         (WebTestRunner):
433         (WebTestRunner::WebTestRunner::WebTestRunner):
434         (WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
435         (WebTestRunner::WebTestRunner::shouldDumpAsText):
436         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
437         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
438         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
439         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
440         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
441         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
442         (WebTestRunner::WebTestRunner::audioData):
443         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
444         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
445         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
446         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
447         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
448         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
449         (WebTestRunner::WebTestRunner::canOpenWindows):
450         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
451         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
452         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
453         (WebTestRunner::WebTestRunner::webPermissions):
454         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
455         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
456         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
457         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
458         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
459         (WebTestRunner::WebTestRunner::testRepaint):
460         (WebTestRunner::WebTestRunner::sweepHorizontally):
461         (WebTestRunner::WebTestRunner::isPrinting):
462         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
463         (WebTestRunner::WebTestRunner::setTitleTextDirection):
464         (WebTestRunner::WebTestRunner::httpHeadersToClear):
465         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
466         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
467         (WebTestRunner::WebTestRunner::setTopLoadingFrame):
468         (WebTestRunner::WebTestRunner::topLoadingFrame):
469         (WebTestRunner::WebTestRunner::policyDelegateDone):
470         (WebTestRunner::WebTestRunner::policyDelegateEnabled):
471         (WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
472         (WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
473         (WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
474         (WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
475         (WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):
476         * DumpRenderTree/chromium/TestShell.cpp:
477         (TestShell::initialize):
478         (TestShell::createMainWindow):
479         (TestShell::~TestShell):
480         (TestShell::runFileTest):
481         (TestShell::resetTestController):
482         (TestShell::dump):
483         (TestShell::bindJSObjectsToWindow):
484         * DumpRenderTree/chromium/TestShell.h:
485         (TestShell::testRunner):
486         (TestShell):
487
488 2013-02-01  Alan Cutter  <alancutter@chromium.org>
489
490         PatchLog process durations are increasing linearly with time (faulty data logging)
491         https://bugs.webkit.org/show_bug.cgi?id=108621
492
493         Reviewed by Eric Seidel.
494
495         Added a check to prevent a stop event from happening to the same patch multiple times.
496
497         * QueueStatusServer/loggers/recordpatchevent.py:
498         (RecordPatchEvent.stopped):
499
500 2013-02-01  Manuel Rego Casasnovas  <rego@igalia.com>
501
502         [GTK][WK2] MiniBrowser fullscreen signals support
503         https://bugs.webkit.org/show_bug.cgi?id=108005
504
505         Reviewed by Carlos Garcia Campos.
506
507         Shows a label for 2 seconds using overlay (if GTK >= 3.2.0) and hides
508         the toolbar when entering fullscreen. When leaving fullscreen the
509         label is hidden (if it's not hidden yet) and the toolbar is shown again.
510
511         * MiniBrowser/gtk/BrowserWindow.c:
512         (_BrowserWindow):
513         (fullScreenMessageTimeoutCallback):
514         (webViewEnterFullScreen):
515         (webViewLeaveFullScreen):
516         (browserWindowFinalize):
517         (browserWindowConstructed):
518
519 2013-02-01  Alexis Menard  <alexis@webkit.org>
520
521         Enable unprefixed CSS transitions by default.
522         https://bugs.webkit.org/show_bug.cgi?id=108216
523
524         Reviewed by Dean Jackson.
525
526         Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
527         to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to 
528         guard the unprefixing work for CSS Transforms and animations.
529
530         * Scripts/webkitperl/FeatureList.pm:
531         * qmake/mkspecs/features/features.pri:
532
533 2013-01-31  David Farler  <dfarler@apple.com>
534
535         Provide a sensible default architecture when building on iOS SDKs
536         https://bugs.webkit.org/show_bug.cgi?id=108395
537
538         Reviewed by Anders Carlsson.
539
540         * Scripts/webkitdirs.pm:
541         (determineArchitecture): Anchor SDK regex matches at the beginning.
542
543 2013-01-31  Ryosuke Niwa  <rniwa@webkit.org>
544
545         buildbot should not rely on webkitpy
546         https://bugs.webkit.org/show_bug.cgi?id=107379
547
548         Reviewed by Eric Seidel.
549
550         Move all Python files used in buildbot configuration into BuildSlaveSupport directory.
551         Once this patch is landed, we can stop restarting the master on webkitpy changes.
552
553         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
554         * BuildSlaveSupport/build.webkit.org-config/htdigestparser.py: Copied from Tools/Scripts/webkitpy/common/net/htdigestparser.py.
555         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py: Copied from Tools/Scripts/webkitpy/common/net/htdigestparser_unittest.py.
556         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
557         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: Copied from Tools/Scripts/webkitpy/common/config/build.py.
558         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/build_unittest.py.
559         (ShouldBuildTest.test_should_build):
560         * Scripts/webkitpy/common/config/build.py: Removed.
561         * Scripts/webkitpy/common/config/build_unittest.py: Removed.
562         * Scripts/webkitpy/common/net/htdigestparser.py: Removed.
563         * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Removed.
564
565 2013-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
566
567         Unreviewed, rolling out r141349.
568         http://trac.webkit.org/changeset/141349
569         https://bugs.webkit.org/show_bug.cgi?id=108422
570
571         "yet another windows ews fix needed" (Requested by lforschler
572         on #webkit).
573
574         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
575         (WinEWS):
576
577 2013-01-31  Rouslan Solomakhin  <rouslan@chromium.org>
578
579         [Chromium] Suggest 'uppercase' for multi-word misspelling 'upper case'
580         https://bugs.webkit.org/show_bug.cgi?id=108509
581
582         Reviewed by Tony Chang.
583
584         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
585         (append): Added utility function to append WebString to WebVector.
586         (MockSpellCheck::fillSuggestionList): Suggest 'uppercase' for misspelling 'upper case'.
587
588 2013-01-31  David Farler  <dfarler@apple.com>
589
590         Provide a sensible default architecture when building on iOS SDKs
591         https://bugs.webkit.org/show_bug.cgi?id=108395
592
593         Reviewed by Joseph Pecoraro.
594
595         * Scripts/webkitdirs.pm:
596         (determineArchitecture):
597         Check for iphoneos and iphonesimulator SDKs for a default arch.
598         (determineXcodeSDK): Added.
599         (xcodeSDK): Added.
600         (XcodeOptions): Add ARCHS= if defined.
601
602 2013-01-31  Christopher Cameron  <ccameron@chromium.org>
603
604         Fix rubber-band effect on non-scrollable pages
605         https://bugs.webkit.org/show_bug.cgi?id=107611
606
607         Add mouseWheelBegin function to EventSender to allow
608         event-based rubber-banding tests.
609
610         Reviewed by Antonio Gomes.
611
612         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
613         (WebTestRunner):
614         (WebTestRunner::EventSender::EventSender):
615         (WebTestRunner::EventSender::mouseDragBegin):
616         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
617         (EventSender):
618
619 2013-01-31  James Robinson  <jamesr@chromium.org>
620
621         [chromium] Notify the WebWidget when the WebViewHost is about to tear down compositing support
622         https://bugs.webkit.org/show_bug.cgi?id=108518
623
624         Reviewed by Adrienne Walker.
625
626         * DumpRenderTree/chromium/WebViewHost.cpp:
627         (WebViewHost::shutdown):
628
629 2013-01-31  Pratik Solanki  <psolanki@apple.com>
630
631         DumpRenderTree should put NSSound calls inside USE(APPKIT)
632         https://bugs.webkit.org/show_bug.cgi?id=108499
633
634         Reviewed by Andy Estes.
635
636         * DumpRenderTree/mac/DumpRenderTree.mm:
637         (dumpRenderTree):
638
639 2013-01-30  Brian Weinstein  <bweinstein@apple.com>
640
641         Add a call to the page UI client to determine if a plug-in should load
642         https://bugs.webkit.org/show_bug.cgi?id=108407
643         <rdar://problem/13066332>
644
645         Add entries for the new function in the necessary structs.
646
647         Reviewed by Anders Carlsson.
648
649         * MiniBrowser/mac/WK2BrowserWindowController.m:
650         (-[WK2BrowserWindowController awakeFromNib]):
651         * WebKitTestRunner/TestController.cpp:
652         (WTR::TestController::createOtherPage):
653         (WTR::TestController::createWebViewWithOptions):
654
655 2013-01-31  Florin Malita  <fmalita@chromium.org>
656
657         [Chromium] Unreviewed gardening.
658
659         Win build fix after http://trac.webkit.org/changeset/141471.
660
661         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
662         (MockSpellCheck::spellCheckWord):
663
664 2013-01-31  Enrica Casucci  <enrica@apple.com>
665
666         WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
667         https://bugs.webkit.org/show_bug.cgi?id=108396.
668         <rdar://problem/12920461>
669
670         Reviewed by Alexey Proskuryakov.
671         
672         Adding new WebKit2 test with relevant bundle, to test the new APIs.
673
674         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
675         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm: Added.
676         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
677         (TestWebKitAPI::setInjectedBundleClient):
678         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp: Added.
679         (PasteboardNotificationsTest):
680         (TestWebKitAPI::willWriteToPasteboard):
681         (TestWebKitAPI::getPasteboardDataForRange):
682         (TestWebKitAPI::didWriteToPasteboard):
683         (TestWebKitAPI::PasteboardNotificationsTest::PasteboardNotificationsTest):
684         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
685         * TestWebKitAPI/Tests/WebKit2/execCopy.html: Added.
686         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Updated to reflect
687         changes in InjectedBundleEditorClient.
688         (WTR::InjectedBundlePage::InjectedBundlePage):
689
690 2013-01-31  Rouslan Solomakhin  <rouslan@chromium.org>
691
692         [Chromium] Add two-word misspelling to mock spellchecker
693         https://bugs.webkit.org/show_bug.cgi?id=108498
694
695         Reviewed by Tony Chang.
696
697         Some layout tests verify spellcheck behavior when multiple words are
698         marked as a single misspelling. This change adds a two-word misspelling
699         'upper case' to the mock spellchecker used by layout tests.
700
701         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
702         (MockSpellCheck::spellCheckWord): Modified to handle spaces in misspellings.
703         (MockSpellCheck::initializeIfNeeded):  Modified to use a vector instead of a hash table.
704         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
705         (MockSpellCheck): Changed misspellings container from hash table to vector.
706
707 2013-01-31  Simon Hausmann  <simon.hausmann@digia.com>
708
709         [Qt] Prospective build fix.
710
711         Reviewed by Jocelyn Turcotte.
712
713         Don't create .prl files for intermediate libs as their contents get
714         injected within -Wl,-whole-archive -lFoo -wl,-no-whole-archive.
715
716         * qmake/mkspecs/features/default_post.prf:
717
718 2013-01-31  Alan Cutter  <alancutter@chromium.org>
719
720         EWS graphs have unusual data for patch waiting times
721         https://bugs.webkit.org/show_bug.cgi?id=108427
722
723         Reviewed by Eric Seidel.
724
725         The max_patches_waiting QueueLog property may have missed recording patches waiting in idle times when no events are fired to update it. I added a cron job to take care of this issue.
726         The patch wait duration in PatchLogs was being incorrectly updated after a patch expired and was picked up again from the queue. That period should really count towards the processing time instead.
727         Added a WarningLog to record if any erroneous situations occur due to invalid contents in the datastore. These basically highlight if any "impossible" execution paths get executed.
728
729         * QueueStatusServer/app.yaml:
730         * QueueStatusServer/cron.yaml:
731         * QueueStatusServer/handlers/syncqueuelogs.py: Copied from Tools/QueueStatusServer/model/patchlog.py.
732         (SyncQueueLogs):
733         (SyncQueueLogs.get):
734         * QueueStatusServer/loggers/recordpatchevent.py:
735         (RecordPatchEvent.added):
736         (RecordPatchEvent.retrying):
737         (RecordPatchEvent.started):
738         (RecordPatchEvent.stopped):
739         (RecordPatchEvent.updated):
740         * QueueStatusServer/main.py:
741         * QueueStatusServer/model/patchlog.py:
742         (PatchLog.lookup):
743         (PatchLog):
744         (PatchLog.lookup_if_exists):
745         (PatchLog.calculate_process_duration):
746         (PatchLog._generate_key):
747         * QueueStatusServer/model/queuelog.py:
748         (QueueLog.update_max_patches_waiting):
749         (QueueLog._get_or_create_txn):
750         (QueueLog):
751         (QueueLog._get_patches_waiting):
752         * QueueStatusServer/model/warninglog.py: Copied from Tools/QueueStatusServer/model/patchlog.py.
753         (WarningLog):
754         (WarningLog.record):
755
756 2013-01-31  Anders Carlsson  <andersca@apple.com>
757
758         Remove Web Intents code from WebKit2
759         https://bugs.webkit.org/show_bug.cgi?id=108506
760
761         Reviewed by Simon Fraser.
762
763         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
764         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
765         (WTR::InjectedBundlePage::InjectedBundlePage):
766         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
767         (InjectedBundlePage):
768         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
769         * WebKitTestRunner/InjectedBundle/TestRunner.h:
770         (TestRunner):
771
772 2013-01-31  Tommy Widenflycht  <tommyw@google.com>
773
774         [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
775         https://bugs.webkit.org/show_bug.cgi?id=108458
776
777         Reviewed by Adam Barth.
778
779         Only renames, no other code changes.
780
781         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
782         (MockWebMediaStreamCenter::didEnableMediaStreamTrack):
783         (MockWebMediaStreamCenter::didDisableMediaStreamTrack):
784         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
785         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
786         (MockWebMediaStreamCenter::didStopLocalMediaStream):
787         (MockWebMediaStreamCenter::didCreateMediaStream):
788         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
789         (MockWebMediaStreamCenter):
790         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
791         (MockWebRTCPeerConnectionHandler::addStream):
792         (MockWebRTCPeerConnectionHandler::removeStream):
793         (MockWebRTCPeerConnectionHandler::getStats):
794         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
795         (MockWebRTCPeerConnectionHandler):
796         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
797         (UserMediaRequestTask::UserMediaRequestTask):
798         (WebUserMediaClientMock::requestUserMedia):
799
800 2013-01-31  Zan Dobersek  <zdobersek@igalia.com>
801
802         REGRESSION (r141402): incorrectly set injected bundle path when running GTK unit tests
803         https://bugs.webkit.org/show_bug.cgi?id=108496
804
805         Reviewed by Philippe Normand.
806
807         * Scripts/run-gtk-tests:
808         (TestRunner.__init__): Add the build type as a member on the TestRunner interface.
809         (TestRunner._setup_testing_environment): Use the build type member to determine correct path
810         to the injected bundle.
811
812 2013-01-31  Christophe Dumez  <dchris@gmail.com>
813
814         [EFL] Disable Web Intents
815         https://bugs.webkit.org/show_bug.cgi?id=108457
816
817         Reviewed by Alexey Proskuryakov.
818
819         Remove EFL DRT code related to Web intents.
820
821         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
822         (DumpRenderTreeChrome::createView):
823         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
824         (DumpRenderTreeChrome::onFrameCreated):
825         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
826         (DumpRenderTreeChrome):
827         * DumpRenderTree/efl/TestRunnerEfl.cpp:
828         (TestRunner::sendWebIntentResponse):
829         (TestRunner::deliverWebIntent):
830         * Scripts/webkitperl/FeatureList.pm: Turn off WEB_INTENTS flag
831         for EFL port.
832
833 2013-01-31  Simon Hausmann  <simon.hausmann@digia.com>
834
835         [Qt] Disable force_static_libs_as_shared in developer builds if wk2 is enabled
836
837         Reviewed by Jocelyn Turcotte.
838
839         This is a temporary workaround during the development of #108471, where we move files around
840         but some link time dependencies might remain.
841
842         * qmake/mkspecs/features/default_post.prf:
843
844 2013-01-31  Simon Hausmann  <simon.hausmann@digia.com>
845
846         [Qt] Make it possible to compile WebKit2 Qt related files without access to internal WK2 C++ API
847         https://bugs.webkit.org/show_bug.cgi?id=108472
848
849         Reviewed by Andreas Kling.
850
851         Add a new module to the qmake build system that represents the part of the WebKit2 Qt integration
852         that doesn't depend on WebKit2 internals.
853
854         * qmake/mkspecs/features/webkit_modules.prf:
855         * qmake/mkspecs/modules/webkit2qml.prf: Copied from Source/WebKit2/WebKit2.pro.
856
857 2013-01-31  James Robinson  <jamesr@chromium.org>
858
859         [chromium] Remove dead transitional code from WebViewImpl
860         https://bugs.webkit.org/show_bug.cgi?id=107889
861
862         Reviewed by Adam Barth.
863
864         ScrollingCoordinatorChromiumTests need to initialize compositing, so its implementation of
865         WebWidgetClient has to support the new compositor initialization path.
866
867         * DumpRenderTree/chromium/WebViewHost.cpp:
868         (WebViewHost::initializeLayerTreeView):
869         (WebViewHost::setWebWidget):
870
871 2013-01-31  Gustavo Noronha Silva  <gns@gnome.org>
872
873         [GTK] run-gtk-tests does not respect the -d argument
874         https://bugs.webkit.org/show_bug.cgi?id=107822
875
876         Reviewed by Philippe Normand.
877
878         * Scripts/run-gtk-tests:
879         (TestRunner.__init__): use the value for the debug option to decide what
880         build_type to request a path for.
881         * gtk/common.py:
882         (get_build_path): now accepts a build_type argument instead of trying both
883         Release and Debug in order, defaults to release.
884         (build_path): takes and passes a build_type argument, no default value.
885
886 2013-01-31  Christophe Dumez  <dchris@gmail.com>
887
888         Update Christophe Dumez's email address
889         https://bugs.webkit.org/show_bug.cgi?id=108453
890
891         Reviewed by Kenneth Rohde Christiansen.
892
893         Update my email address in committers.py.
894
895         * Scripts/webkitpy/common/config/committers.py:
896
897 2013-01-31  Jochen Eisinger  <jochen@chromium.org>
898
899         [chromium] move runModalBeforeUnloadDialog to TestRunner library
900         https://bugs.webkit.org/show_bug.cgi?id=108442
901
902         Reviewed by Adam Barth.
903
904         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
905         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
906         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
907         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
908         * DumpRenderTree/chromium/WebViewHost.cpp:
909         * DumpRenderTree/chromium/WebViewHost.h:
910
911 2013-01-31  Jochen Eisinger  <jochen@chromium.org>
912
913         [chromium] move postMessage related methods to TestRunner library
914         https://bugs.webkit.org/show_bug.cgi?id=108343
915
916         Reviewed by Adam Barth.
917
918         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
919         (WebKit):
920         (WebTestProxyBase):
921         (WebTestRunner::WebTestProxy::willCheckAndDispatchMessageEvent):
922         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
923         (WebTestRunner::WebTestProxyBase::willCheckAndDispatchMessageEvent):
924         (WebTestRunner):
925         * DumpRenderTree/chromium/WebViewHost.cpp:
926         (WebViewHost::willCheckAndDispatchMessageEvent):
927
928 2013-01-30  Jochen Eisinger  <jochen@chromium.org>
929
930         [chromium] move remaining resource load related methods to TestRunner library
931         https://bugs.webkit.org/show_bug.cgi?id=108334
932
933         Reviewed by Adam Barth.
934
935         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
936         (WebTestRunner::WebTestDelegate::allowExternalPages):
937         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
938         (WebKit):
939         (WebTestProxyBase):
940         (WebTestRunner::WebTestProxy::canHandleRequest):
941         (WebTestRunner::WebTestProxy::cannotHandleRequestError):
942         (WebTestRunner::WebTestProxy::didCreateDataSource):
943         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
944         (WebTestRunner::WebTestProxyBase::canHandleRequest):
945         (WebTestRunner):
946         (WebTestRunner::WebTestProxyBase::cannotHandleRequestError):
947         (WebTestRunner::WebTestProxyBase::didCreateDataSource):
948         (WebTestRunner::WebTestProxyBase::willSendRequest):
949         * DumpRenderTree/chromium/WebViewHost.cpp:
950         (WebViewHost::canHandleRequest):
951         (WebViewHost::didCreateDataSource):
952         (WebViewHost::willSendRequest):
953         (WebViewHost::allowExternalPages):
954         * DumpRenderTree/chromium/WebViewHost.h:
955
956 2013-01-30  Hajime Morrita  <morrita@google.com>
957
958         Unreviewed test failure fix for r141341.
959
960         * Scripts/webkitpy/tool/steps/runtests.py:
961         (RunTests.run):
962         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
963
964 2013-01-30  Levi Weintraub  <leviw@chromium.org>
965
966         [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
967         https://bugs.webkit.org/show_bug.cgi?id=108381
968
969         Reviewed by James Robinson.
970
971         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Adding an attribute that
972         tickles the case in WebPluginContainerImpl that imbalanced touch handler refs in Document.
973
974 2013-01-30  Julie Parent  <jparent@chromium.org>
975
976         Add a concept of dashboard parameters that invalidate others
977         https://bugs.webkit.org/show_bug.cgi?id=108362
978
979         Reviewed by Dirk Pranke.
980
981         There are certain parameters to the dashboards, that when selected,
982         invalidate others, such as selecting the test type invalidates the
983         builder group. Add this concept to dashboard_base and allow specifc
984         dashboard to add their own invalidating parameters.
985         
986         The result is that when the user takes a specific action, like changing
987         the test type, the builder would get reset to the default for the new
988         test type, rather than erroring or not matching the query param, as is
989         the current behavior.
990         
991         Also deletes some unused code (selectBuilder).
992         
993         * TestResultServer/static-dashboards/dashboard_base.js:
994         (invalidateQueryParameters):
995         (setQueryParameter):
996         * TestResultServer/static-dashboards/flakiness_dashboard.js:
997         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
998         * TestResultServer/static-dashboards/timeline_explorer.html:
999         * TestResultServer/static-dashboards/treemap.html:
1000
1001 2013-01-30  Kiran Muppala  <cmuppala@apple.com>
1002
1003         Disable process suppression of DumpRenderTree on Mac
1004         https://bugs.webkit.org/show_bug.cgi?id=108400
1005
1006         Reviewed by Jessie Berlin.
1007
1008         * DumpRenderTree/mac/DumpRenderTree.mm:
1009         (prepareConsistentTestingEnvironment): Take assertion to prevent
1010         process suppression.
1011
1012 2013-01-30  Roger Fong  <roger_fong@apple.com>
1013
1014         Enable tests for Windows EWS!
1015         https://bugs.webkit.org/show_bug.cgi?id=107968.
1016         Patch by Lucas Forschler.
1017
1018         Reviewed by Adam Barth.
1019
1020         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1021         (WinEWS):
1022
1023 2013-01-30  Christophe Dumez  <christophe.dumez@intel.com>
1024
1025         Add a StringTypeAdapter for ASCIILiteral
1026         https://bugs.webkit.org/show_bug.cgi?id=108338
1027
1028         Reviewed by Benjamin Poulain.
1029
1030         Add API tests for operator+() taking an ASCIILiteral.
1031
1032         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1033         (TestWebKitAPI::TEST):
1034
1035 2013-01-30  Roger Fong  <roger_fong@apple.com>
1036
1037         Modify runtests.py script so that --skip-failing-tests option is not added when platform is cygwin.
1038
1039         Rubberstamped by Timothy Horton.
1040
1041         * Scripts/webkitpy/tool/steps/runtests.py:
1042         (RunTests.run):
1043
1044 2013-01-30  Sheriff Bot  <webkit.review.bot@gmail.com>
1045
1046         Unreviewed, rolling out r141205.
1047         http://trac.webkit.org/changeset/141205
1048         https://bugs.webkit.org/show_bug.cgi?id=108353
1049
1050         Command for running tests on windows needs to be investigated.
1051         (Requested by lforschler on #webkit).
1052
1053         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1054         (WinEWS):
1055
1056 2013-01-30  Tony Chang  <tony@chromium.org>
1057
1058         [Chromium] Enable textarea resize corner for tests
1059         https://bugs.webkit.org/show_bug.cgi?id=108385
1060
1061         Reviewed by Ojan Vafai.
1062
1063         We should test what we ship. Also, this makes us pass more tests in content_shell.
1064
1065         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1066         (WebTestRunner::WebPreferences::reset): Turn on resize corner.
1067
1068 2013-01-30  Jochen Eisinger  <jochen@chromium.org>
1069
1070         [chromium] move custom policy delegate to TestRunner library
1071         https://bugs.webkit.org/show_bug.cgi?id=108328
1072
1073         Reviewed by Adam Barth.
1074
1075         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1076         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1077         (WebTestProxyBase):
1078         (WebTestRunner::WebTestProxy::decidePolicyForNavigation):
1079         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1080         (WebTestRunner::WebTestRunner::policyDelegateEnabled):
1081         (WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
1082         (WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
1083         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1084         (WebTestRunner::TestRunner::reset):
1085         (WebTestRunner::TestRunner::policyDelegateEnabled):
1086         (WebTestRunner):
1087         (WebTestRunner::TestRunner::policyDelegateIsPermissive):
1088         (WebTestRunner::TestRunner::policyDelegateShouldNotifyDone):
1089         (WebTestRunner::TestRunner::setCustomPolicyDelegate):
1090         (WebTestRunner::TestRunner::waitForPolicyDelegate):
1091         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1092         (TestRunner):
1093         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1094         (WebTestRunner::WebTestProxyBase::decidePolicyForNavigation):
1095         (WebTestRunner):
1096         * DumpRenderTree/chromium/WebViewHost.cpp:
1097         (WebViewHost::decidePolicyForNavigation):
1098         (WebViewHost::reset):
1099         * DumpRenderTree/chromium/WebViewHost.h:
1100         (WebViewHost):
1101
1102 2013-01-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1103
1104         [Qt][WK1] Support better testing of Web Notifications
1105         https://bugs.webkit.org/show_bug.cgi?id=107696
1106
1107         Reviewed by Jocelyn Turcotte.
1108
1109         Do not dump notification output to the console by default, instead allow the 
1110         tests that need this feature to enable it.
1111
1112         Implement denyWebNotificationPermission and removeAllWebNotificationPermissions.
1113         Remove unused m_desktopNotificationAllowedOrigins variable.
1114
1115         * DumpRenderTree/qt/TestRunnerQt.cpp:
1116         (TestRunner::TestRunner):
1117         (TestRunner::reset):
1118         (TestRunner::dumpNotifications):
1119         (TestRunner::grantWebNotificationPermission):
1120         (TestRunner::denyWebNotificationPermission):
1121         (TestRunner::removeAllWebNotificationPermissions):
1122         * DumpRenderTree/qt/TestRunnerQt.h:
1123         (TestRunner):
1124
1125 2013-01-30  Jochen Eisinger  <jochen@chromium.org>
1126
1127         [chromium] move methods from WebTestDelegate to WebTestRunner
1128         https://bugs.webkit.org/show_bug.cgi?id=108309
1129
1130         Reviewed by Adam Barth.
1131
1132         By moving more logic to the TestRunner library, we can share more
1133         code with content shell.
1134
1135         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1136         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1137         (WebTestProxyBase):
1138         (WebTestRunner::WebTestProxy::createView):
1139         (WebTestRunner::WebTestProxy::isSmartInsertDeleteEnabled):
1140         (WebTestRunner::WebTestProxy::isSelectTrailingWhitespaceEnabled):
1141         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1142         (WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
1143         (WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):
1144         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1145         (WebTestRunner::TestRunner::reset):
1146         (WebTestRunner::TestRunner::isSmartInsertDeleteEnabled):
1147         (WebTestRunner):
1148         (WebTestRunner::TestRunner::isSelectTrailingWhitespaceEnabled):
1149         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
1150         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
1151         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1152         (TestRunner):
1153         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1154         (WebTestRunner::WebTestProxyBase::createView):
1155         (WebTestRunner::WebTestProxyBase::isSmartInsertDeleteEnabled):
1156         (WebTestRunner):
1157         (WebTestRunner::WebTestProxyBase::isSelectTrailingWhitespaceEnabled):
1158         * DumpRenderTree/chromium/TestShell.h:
1159         (TestShell):
1160         * DumpRenderTree/chromium/WebViewHost.cpp:
1161         (WebViewHost::createView):
1162         (WebViewHost::didStartLoading):
1163         (WebViewHost::didStopLoading):
1164         (WebViewHost::isSmartInsertDeleteEnabled):
1165         (WebViewHost::isSelectTrailingWhitespaceEnabled):
1166         (WebViewHost::reset):
1167         * DumpRenderTree/chromium/WebViewHost.h:
1168         (WebViewHost):
1169
1170 2013-01-30  Kwang Yul Seo  <skyul@company100.net>
1171
1172         Unreviewed. Add Jae Hyun Park to contributor list.
1173
1174         * Scripts/webkitpy/common/config/committers.py:
1175
1176 2013-01-29  Alan Cutter  <alancutter@chromium.org>
1177
1178         Need a cr-linux debug EWS bot
1179         https://bugs.webkit.org/show_bug.cgi?id=98957
1180
1181         Reviewed by Eric Seidel.
1182
1183         Added cr-linux-debug-ews bot to webkit-patch, QueueStatusServer and GCE build scripts.
1184
1185         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Added.
1186         * QueueStatusServer/app.yaml:
1187         * QueueStatusServer/config/queues.py: Added.
1188         * QueueStatusServer/model/queues.py:
1189         (Queue.__init__):
1190         (Queue.queue_with_name):
1191         (Queue.all):
1192         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1193         (ChromiumLinuxDebugEWS):
1194
1195 2013-01-29  Alan Cutter  <alancutter@chromium.org>
1196
1197         Tidy up Sheriffbot's Sheriffs command's unit tests
1198         https://bugs.webkit.org/show_bug.cgi?id=108262
1199
1200         Reviewed by Eric Seidel.
1201
1202         Added the use of MockWeb instead of the filesystem to test the sheriffs command.
1203
1204         * Scripts/webkitpy/tool/bot/irc_command.py:
1205         (Sheriffs._retrieve_webkit_sheriffs):
1206         (Sheriffs.execute):
1207         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1208         (IRCCommandTest.test_sheriffs):
1209         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Removed.
1210         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Removed.
1211         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Removed.
1212         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Removed.
1213         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Removed.
1214
1215 2013-01-29  Lucas Forschler  <lforschler@apple.com>
1216
1217         Enable tests for Windows EWS!
1218         https://bugs.webkit.org/show_bug.cgi?id=107968
1219         
1220         Reviewed by Adam Barth.
1221
1222         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1223         (WinEWS):
1224
1225 2013-01-29  Alan Cutter  <alancutter@chromium.org>
1226
1227         MockWeb should be able to serve mock web content
1228         https://bugs.webkit.org/show_bug.cgi?id=108240
1229
1230         Reviewed by Dirk Pranke.
1231
1232         Added the ability to have MockWeb serve mock web data.
1233
1234         * Scripts/webkitpy/common/host_mock.py:
1235         (MockHost.__init__):
1236         * Scripts/webkitpy/common/net/web_mock.py:
1237         (MockWeb.__init__):
1238         (MockWeb.get_binary):
1239
1240 2013-01-29  Jessie Berlin  <jberlin@apple.com>
1241
1242         run-api-tests should have an option to specify root
1243         https://bugs.webkit.org/show_bug.cgi?id=108210
1244
1245         Reviewed by Ryosuke Niwa.
1246
1247         * Scripts/run-api-tests:
1248         Add the option and use it to set the configuration product directory. Since it is supposed
1249         to point to the built products, do not build the products if root is specified (this mimics
1250         the behavior of run-javascriptcore-tests).
1251
1252 2013-01-29  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
1253
1254         [EFL] Add Toggle fullscreen (F11) to MiniBrowser
1255         https://bugs.webkit.org/show_bug.cgi?id=108122
1256
1257         Reviewed by Antonio Gomes.
1258
1259         Adds fullscreen mode toggle (F11) option to MiniBrowser using native API.
1260
1261         * MiniBrowser/efl/main.c:
1262         (on_key_down): Add 'F11' key handler.
1263
1264 2013-01-29  Patrick Gansterer  <paroga@webkit.org>
1265
1266         [CMake] Use offical Windows CE support
1267         https://bugs.webkit.org/show_bug.cgi?id=108061
1268
1269         Reviewed by Laszlo Gombos.
1270
1271         Recent version of CMake has added Windows CE support, but uses a
1272         slightly different interface than the patched version used before.
1273         Change the command line parameters to use the offical CMake binaries.
1274
1275         * Scripts/webkitdirs.pm:
1276         (cmakeBasedPortArguments):
1277
1278 2013-01-29  Alan Cutter  <alancutter@chromium.org>
1279
1280         QueueStatusServer needs pages to display historical queue data
1281         https://bugs.webkit.org/show_bug.cgi?id=107659
1282
1283         Reviewed by Eric Seidel.
1284
1285         Created a /queue-charts/<queue-name> handler to present queue and patch data using Google Chart Tools.
1286
1287         * QueueStatusServer/app.yaml:
1288         * QueueStatusServer/config/charts.py: Copied from Tools/QueueStatusServer/model/queuelog.py.
1289         (get_time_unit):
1290         * QueueStatusServer/filters/webkit_extras.py:
1291         (webkit_linkify):
1292         (webkit_bug_id):
1293         (webkit_attachment_id):
1294         (results_link):
1295         (queue_status_link):
1296         (queue_charts_link):
1297         * QueueStatusServer/handlers/queuecharts.py: Added.
1298         (QueueCharts):
1299         (QueueCharts.get):
1300         (QueueCharts._get_min_med_max):
1301         (QueueCharts._get_patch_data):
1302         (QueueCharts._get_patch_logs):
1303         (QueueCharts._get_queue_data):
1304         (QueueCharts._get_queue_logs):
1305         (QueueCharts._get_time_unit):
1306         (QueueCharts._get_timestamp):
1307         (QueueCharts._get_view_range):
1308         * QueueStatusServer/handlers/queuestatus.py:
1309         (QueueStatus.get):
1310         * QueueStatusServer/index.yaml:
1311         * QueueStatusServer/main.py:
1312         * QueueStatusServer/model/queuelog.py:
1313         (QueueLog):
1314         (QueueLog.create_key):
1315         (QueueLog.get_at):
1316         (QueueLog.get_current):
1317         (QueueLog.get_or_create):
1318         (QueueLog._get_or_create_txn):
1319         * QueueStatusServer/stylesheets/charts.css: Added.
1320         (.chart):
1321         (.choices):
1322         * QueueStatusServer/templates/queuecharts.html: Added.
1323         * QueueStatusServer/templates/queuestatus.html:
1324
1325 2013-01-29  Mario Sanchez Prada  <mario.prada@samsung.com>
1326
1327         [GTK] Missing build flags when building with Harfbuzz
1328         https://bugs.webkit.org/show_bug.cgi?id=108174
1329
1330         Reviewed by Martin Robinson.
1331
1332         Add FREETYPE_CFLAGS and FREETYPE_LIBS to makefiles so -lharfbuzz
1333         parameter will be added to linking lines when needed.
1334
1335         * GNUmakefile.am: Added FREETYPE_CFLAGS and FREETYPE_LIBS.
1336         * MiniBrowser/gtk/GNUmakefile.am: Ditto.
1337         * TestWebKitAPI/GNUmakefile.am: Ditto.
1338
1339 2013-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1340
1341         [GTK] Implement resources API using injected bundle
1342         https://bugs.webkit.org/show_bug.cgi?id=107457
1343
1344         Reviewed by Sam Weinig.
1345
1346         * Scripts/run-gtk-tests:
1347         (TestRunner): Unksip resources unit tests.
1348
1349 2013-01-29  Michael Brüning  <michael.bruning@digia.com>
1350
1351         Unreviewed, updated my email information.
1352
1353         * Scripts/webkitpy/common/config/committers.py:
1354
1355 2013-01-29  Jochen Eisinger  <jochen@chromium.org>
1356
1357         [chromium] delete DRTTestRunner
1358         https://bugs.webkit.org/show_bug.cgi?id=108082
1359
1360         Reviewed by Adam Barth.
1361
1362         * DumpRenderTree/DumpRenderTree.gypi:
1363         * DumpRenderTree/chromium/DRTTestRunner.cpp: Removed.
1364         * DumpRenderTree/chromium/DRTTestRunner.h: Removed.
1365         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1366         (WebTestRunner::WebTestDelegate::testFinished):
1367         (WebTestRunner::WebTestDelegate::testTimedOut):
1368         (WebTestRunner::WebTestDelegate::isBeingDebugged):
1369         (WebTestRunner::WebTestDelegate::layoutTestTimeout):
1370         (WebTestRunner::WebTestDelegate::closeRemainingWindows):
1371         (WebTestRunner::WebTestDelegate::navigationEntryCount):
1372         (WebTestRunner::WebTestDelegate::windowCount):
1373         (WebTestRunner::WebTestDelegate::setCustomPolicyDelegate):
1374         (WebTestRunner::WebTestDelegate::waitForPolicyDelegate):
1375         (WebTestRunner::WebTestDelegate::goToOffset):
1376         (WebTestRunner::WebTestDelegate::reload):
1377         (WebTestRunner::WebTestDelegate::loadURLForFrame):
1378         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1379         (WebTestRunner::WebTestRunner::policyDelegateDone):
1380         (WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
1381         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1382         (WebTestRunner::TestRunner::WorkQueue::~WorkQueue):
1383         (WebTestRunner):
1384         (WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
1385         (WebTestRunner::TestRunner::WorkQueue::processWork):
1386         (WebTestRunner::TestRunner::WorkQueue::reset):
1387         (WebTestRunner::TestRunner::WorkQueue::addWork):
1388         (WebTestRunner::TestRunner::TestRunner):
1389         (WebTestRunner::TestRunner::reset):
1390         (WebTestRunner::TestRunner::policyDelegateDone):
1391         (WebTestRunner::TestRunner::shouldInterceptPostMessage):
1392         (WebTestRunner::TestRunner::waitUntilDone):
1393         (WebTestRunner::TestRunner::notifyDone):
1394         (WebTestRunner::TestRunner::completeNotifyDone):
1395         (WorkItemBackForward):
1396         (WebTestRunner::WorkItemBackForward::WorkItemBackForward):
1397         (WebTestRunner::WorkItemBackForward::run):
1398         (WebTestRunner::TestRunner::queueBackNavigation):
1399         (WebTestRunner::TestRunner::queueForwardNavigation):
1400         (WorkItemReload):
1401         (WebTestRunner::WorkItemReload::run):
1402         (WebTestRunner::TestRunner::queueReload):
1403         (WorkItemLoadingScript):
1404         (WebTestRunner::WorkItemLoadingScript::WorkItemLoadingScript):
1405         (WebTestRunner::WorkItemLoadingScript::run):
1406         (WorkItemNonLoadingScript):
1407         (WebTestRunner::WorkItemNonLoadingScript::WorkItemNonLoadingScript):
1408         (WebTestRunner::WorkItemNonLoadingScript::run):
1409         (WebTestRunner::TestRunner::queueLoadingScript):
1410         (WebTestRunner::TestRunner::queueNonLoadingScript):
1411         (WorkItemLoad):
1412         (WebTestRunner::WorkItemLoad::WorkItemLoad):
1413         (WebTestRunner::WorkItemLoad::run):
1414         (WebTestRunner::TestRunner::queueLoad):
1415         (WorkItemLoadHTMLString):
1416         (WebTestRunner::WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1417         (WebTestRunner::WorkItemLoadHTMLString::run):
1418         (WebTestRunner::TestRunner::queueLoadHTMLString):
1419         (WebTestRunner::TestRunner::locationChangeDone):
1420         (WebTestRunner::TestRunner::windowCount):
1421         (WebTestRunner::TestRunner::setCloseRemainingWindowsWhenComplete):
1422         (WebTestRunner::TestRunner::setCustomPolicyDelegate):
1423         (WebTestRunner::TestRunner::waitForPolicyDelegate):
1424         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1425         (TestRunner):
1426         (WorkItem):
1427         (WebTestRunner::TestRunner::WorkItem::~WorkItem):
1428         (WorkQueue):
1429         (WebTestRunner::TestRunner::WorkQueue::WorkQueue):
1430         (WebTestRunner::TestRunner::WorkQueue::setFrozen):
1431         (WebTestRunner::TestRunner::WorkQueue::isEmpty):
1432         (WebTestRunner::TestRunner::WorkQueue::taskList):
1433         * DumpRenderTree/chromium/TestShell.cpp:
1434         (TestShell::initialize):
1435         (TestShell::runFileTest):
1436         (TestShell::loadURL):
1437         (TestShell::createNewWindow):
1438         * DumpRenderTree/chromium/TestShell.h:
1439         (TestShell::testRunner):
1440         (TestShell):
1441         * DumpRenderTree/chromium/WebViewHost.cpp:
1442         (WebViewHost::testFinished):
1443         (WebViewHost::testTimedOut):
1444         (WebViewHost::isBeingDebugged):
1445         (WebViewHost::layoutTestTimeout):
1446         (WebViewHost::closeRemainingWindows):
1447         (WebViewHost::navigationEntryCount):
1448         (WebViewHost::windowCount):
1449         (WebViewHost::setCustomPolicyDelegate):
1450         (WebViewHost::waitForPolicyDelegate):
1451         (WebViewHost::goToOffset):
1452         (WebViewHost::reload):
1453         (WebViewHost::loadURLForFrame):
1454         (WebViewHost::shutdown):
1455         (WebViewHost::testRunner):
1456         * DumpRenderTree/chromium/WebViewHost.h:
1457         (WebTestRunner):
1458         (WebViewHost):
1459
1460 2013-01-28  Timothy Loh  <timloh@chromium.com>
1461
1462         Refactor ChangeLog and PrepareChangeLog to use FileSystem objects
1463         https://bugs.webkit.org/show_bug.cgi?id=107903
1464
1465         Reviewed by Eric Seidel.
1466
1467         To make ChangeLog and PrepareChangeLog easier to test, we can use
1468         FileSystem objects instead of just passing around paths.
1469
1470         * Scripts/webkitpy/common/checkout/changelog.py:
1471         (ChangeLog.__init__):
1472         (ChangeLog.parse_latest_entry_from_file):
1473         (ChangeLog.parse_entries_from_file):
1474         (ChangeLog.latest_entry):
1475         (ChangeLog.update_with_unreviewed_message):
1476         (ChangeLog.set_reviewer):
1477         (ChangeLog.set_short_description_and_bug_url):
1478         (ChangeLog.delete_entries):
1479         (ChangeLog.prepend_text):
1480         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1481         (ChangeLogTest):
1482         (test_parse_log_entries_from_changelog):
1483         (test_latest_entry_parse_single_entry):
1484         (test_set_reviewer):
1485         (test_set_short_description_and_bug_url):
1486         (test_delete_entries):
1487         (test_prepend_text):
1488         * Scripts/webkitpy/common/system/filesystem_mock.py:
1489         (ReadableTextFileObject.__init__):
1490         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1491         (PrepareChangeLog._ensure_bug_url):
1492         (PrepareChangeLog._resolve_existing_entry):
1493         (PrepareChangeLog.run):
1494         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1495         (test_ensure_bug_url):
1496         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1497         (_assert_message_for_revert_output):
1498
1499 2013-01-28  Raymond Toy  <rtoy@google.com>
1500
1501         Add myself to committers.py
1502         https://bugs.webkit.org/show_bug.cgi?id=107992
1503
1504         Reviewed by kbr@google.com.
1505
1506         * Scripts/webkitpy/common/config/committers.py:
1507
1508 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1509
1510         [Mac] Update PageVisibilityState when WebView is hidden / visible
1511         https://bugs.webkit.org/show_bug.cgi?id=107509
1512
1513         Reviewed by Sam Weinig.
1514
1515         Add a test that PageVisibility of WK1 WebViews and WK2 WKViews
1516         automatically changes between hidden and visible as the view is added
1517         and removed from window, or when it is in a window that changes
1518         visibility, for instance by minimizing / deminimizing.
1519
1520         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1521         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html: Added.
1522         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Added.
1523         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1524         (runJavaScriptAlert):
1525         (PageVisibilityStateWithWindowChanges):
1526         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
1527         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
1528         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1529         (TestWebKitAPI::TEST_F):
1530         Test visibility state of a page in a WebView/WKView with different window states.
1531
1532         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
1533         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1534         (TestWebKitAPI::WebKitAgnosticTest::teardownView):
1535         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
1536         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1537         Add a WK1 and WK2 teardownView to balance initializeView.
1538
1539 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1540
1541         Improve PageVisibility API with enums
1542         https://bugs.webkit.org/show_bug.cgi?id=107364
1543
1544         Reviewed by Sam Weinig.
1545
1546         * DumpRenderTree/mac/TestRunnerMac.mm:
1547         (TestRunner::resetPageVisibility):
1548         (TestRunner::setPageVisibility):
1549         Update the WK1 test code to use the new WK1 enums.
1550
1551         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1552         (WTR::InjectedBundle::setVisibilityState):
1553         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1554         (InjectedBundle):
1555         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1556         (WTR::TestRunner::setPageVisibility):
1557         (WTR::TestRunner::resetPageVisibility):
1558         * WebKitTestRunner/TestController.cpp:
1559         (WTR::TestController::setVisibilityState):
1560         * WebKitTestRunner/TestController.h:
1561         (TestController):
1562         * WebKitTestRunner/TestInvocation.cpp:
1563         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1564         Update the WK2 test code to use the new WK2 API and enums.
1565
1566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1567         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Added.
1568         (TestWebKitAPI):
1569         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
1570         (TestWebKitAPI::assertSerializedScriptValueIsStringValue):
1571         (TestWebKitAPI::didRunStep1StateChangeVisibleToHidden):
1572         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
1573         (TestWebKitAPI::didRunStep3StateChangePrerenderToPreview):
1574         (TestWebKitAPI::didRunStep4InStatePreview):
1575         (TestWebKitAPI::TEST):
1576         Test the new WK2 API with all enum types.
1577
1578 2013-01-28  Jochen Eisinger  <jochen@chromium.org>
1579
1580         [chromium] remove temporary define used for updating TestRunner API
1581
1582         Unreviewed. Clean-up change.
1583
1584         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1585
1586 2013-01-28  James Craig  <james@cookiecrook.com>
1587
1588         HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
1589         https://bugs.webkit.org/show_bug.cgi?id=107650
1590
1591         Reviewed by Chris Fleizach.
1592
1593         Updating accessibility strings and accessors for DL/DT/DD.
1594
1595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js:
1596         (createDescriptionList):
1597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1598         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1599
1600 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
1601
1602         [GTK][WTR] Update layoutTestController.pathToLocalResource
1603         https://bugs.webkit.org/show_bug.cgi?id=107538
1604
1605         Reviewed by Martin Robinson.
1606
1607         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1608         (WTR::TestRunner::pathToLocalResource): Update implementation based on
1609         DRT code.
1610
1611 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
1612
1613         [GTK][WTR] Move getTopLevelPath() to utilities file
1614         https://bugs.webkit.org/show_bug.cgi?id=107541
1615
1616         Reviewed by Martin Robinson.
1617
1618         * WebKitTestRunner/GNUmakefile.am: Add new files.
1619         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1620         (WTR::getOutputDir): Uses the moved method from InjectedBundleUtilities.
1621         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp: Added.
1622         (WTR):
1623         (WTR::topLevelPath): Implementation moved from ActivateFontsGtk.
1624         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h: Added.
1625         (WTR): Add new method header and documentation.
1626
1627 2013-01-28  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1628
1629         [EFL] Include Ecore_Getopt.h in MiniBrowser.
1630         https://bugs.webkit.org/show_bug.cgi?id=108067
1631
1632         Reviewed by Kenneth Rohde Christiansen.
1633
1634         Be explicit and include Ecore_Getopt.h since we use it for parsing
1635         command line options. It is safer than relying on other headers
1636         including it for us.
1637
1638         * MiniBrowser/efl/main.c:
1639
1640 2013-01-28  Renata Hodovan  <reni@webkit.org>
1641
1642         [WK2] Putting QtWebProcess into a chrooted sandbox
1643         https://bugs.webkit.org/show_bug.cgi?id=90005
1644
1645         Reviewed by Anders Carlsson and  Zoltan Herczeg.
1646
1647         Add feature flag for suid sandbox in linux.
1648
1649         * Scripts/webkitperl/FeatureList.pm:
1650
1651 2013-01-27  David Farler  <dfarler@apple.com>
1652
1653         REGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / build-webkit
1654         https://bugs.webkit.org/show_bug.cgi?id=108028
1655
1656         Reviewed by Dan Bernstein.
1657
1658         * DumpRenderTree/Makefile: Reverted.
1659         * Makefile: Reverted.
1660         * Scripts/webkitdirs.pm: Reverted.
1661
1662 2013-01-27  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
1663
1664         Fixing atomicIncrement implementation for Windows by dropping support before XP SP2.
1665         https://bugs.webkit.org/show_bug.cgi?id=106740
1666
1667         Reviewed by Benjamin Poulain.
1668
1669         * DumpRenderTree/config.h:
1670         * WinLauncher/stdafx.h:
1671
1672 2013-01-26  David Farler  <dfarler@apple.com>
1673
1674         Makefiles should work for arbitrary SDKs and architectures on Apple ports
1675         https://bugs.webkit.org/show_bug.cgi?id=107863
1676
1677         Reviewed by David Kilzer.
1678
1679         * Makefile:
1680         Added temporary filters for projects not yet building on iOS.
1681         * DumpRenderTree/Makefile:
1682         Building with iOS SDKs -> -target All-iOS
1683         * Scripts/webkitdirs.pm:
1684         (determineConfiguration):
1685         Added --configuration switch detection.
1686         (determineArchitecture):
1687         Added --architecture and ARCH=(.*) switch detection.
1688         (argumentsForConfiguration):
1689         (determineXcodeSDK):
1690         Look for --device, --simulator, and --sdk switches.
1691         (xcodeSDK):
1692         Added.
1693         (XcodeOptions):
1694         Determine Xcode SDK and generate -arch switches.
1695
1696 2013-01-25  Jochen Eisinger  <jochen@chromium.org>
1697
1698         [chromium] move tracking of the top loading frame to TestRunner library
1699         https://bugs.webkit.org/show_bug.cgi?id=107948
1700
1701         Reviewed by Adam Barth.
1702
1703         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1704         (DRTTestRunner::WorkQueue::processWorkSoon):
1705         (DRTTestRunner::WorkQueue::processWork):
1706         (DRTTestRunner::completeNotifyDone):
1707         * DumpRenderTree/chromium/DRTTestRunner.h:
1708         (DRTTestRunner):
1709         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1710         (WebTestProxyBase):
1711         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1712         (WebTestRunner::WebTestRunner::setTopLoadingFrame):
1713         (WebTestRunner::WebTestRunner::topLoadingFrame):
1714         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1715         (WebTestRunner::TestRunner::TestRunner):
1716         (WebTestRunner::TestRunner::reset):
1717         (WebTestRunner::TestRunner::setTopLoadingFrame):
1718         (WebTestRunner):
1719         (WebTestRunner::TestRunner::topLoadingFrame):
1720         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1721         (TestRunner):
1722         (WebTestRunner::TestRunner::locationChangeDone):
1723         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1724         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
1725         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
1726         (WebTestRunner::WebTestProxyBase::didFailLoad):
1727         (WebTestRunner::WebTestProxyBase::didFinishLoad):
1728         (WebTestRunner::WebTestProxyBase::locationChangeDone):
1729         (WebTestRunner):
1730         * DumpRenderTree/chromium/WebViewHost.cpp:
1731         (WebViewHost::reset):
1732         (WebViewHost::updateURL):
1733         * DumpRenderTree/chromium/WebViewHost.h:
1734         (WebViewHost):
1735
1736 2013-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1737
1738         Unreviewed, rolling out r140774.
1739         http://trac.webkit.org/changeset/140774
1740         https://bugs.webkit.org/show_bug.cgi?id=107932
1741
1742          Tests ScrollingCoordinatorChromiumTest.fastScrollingByDefault
1743         and fastScrollingForFixedPosition are failing (Requested by
1744         keishi on #webkit).
1745
1746         * DumpRenderTree/chromium/WebViewHost.cpp:
1747         (WebViewHost::initializeLayerTreeView):
1748         (WebViewHost::setWebWidget):
1749
1750 2013-01-25  Alan Cutter  <alancutter@chromium.org>
1751
1752         Quick fix for Chromium EWS bots running out of space due to a tmp file leak
1753         https://bugs.webkit.org/show_bug.cgi?id=107905
1754
1755         Reviewed by Eric Seidel.
1756
1757         Added line to EWS loop to clear /tmp of known Chromium test leak.
1758         Directories named ".org.chromium.Chromium.XXXXXX" not getting cleaned up.
1759
1760         * EWSTools/start-queue.sh:
1761
1762 2013-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1763
1764         Update Anne's email address
1765         https://bugs.webkit.org/show_bug.cgi?id=107866
1766
1767         Reviewed by Adam Barth.
1768
1769         * Scripts/webkitpy/common/config/committers.py:
1770
1771 2013-01-24  Alan Cutter  <alancutter@chromium.org>
1772
1773         HTTP 500 error between QueueStatusServer and bot(s)
1774         https://bugs.webkit.org/show_bug.cgi?id=107184
1775
1776         Reviewed by Adam Barth.
1777
1778         Removed the use of memcache which was the source of the exception.
1779
1780         * QueueStatusServer/handlers/updatestatus.py:
1781         (UpdateStatus.post):
1782         * QueueStatusServer/model/attachment.py:
1783         (Attachment):
1784         (Attachment.summary):
1785
1786 2013-01-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1787
1788         Unreviewed, rolling out r140653.
1789         http://trac.webkit.org/changeset/140653
1790         https://bugs.webkit.org/show_bug.cgi?id=107916
1791
1792         Causes a temp file leak on the bots (Requested by abarth on
1793         #webkit).
1794
1795         * DumpRenderTree/chromium/TestShell.cpp:
1796         (TestShell::resetTestController):
1797
1798 2013-01-24  Eric Seidel  <eric@webkit.org>
1799
1800         Skip haslanded_unittest.py on systems which do not have interdiff installed
1801         https://bugs.webkit.org/show_bug.cgi?id=106402
1802
1803         Unreviewed.
1804
1805         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
1806         (HasLandedTest):
1807
1808 2013-01-24  Ryosuke Niwa  <rniwa@webkit.org>
1809
1810         Disable the failing webkitpy test for now.
1811
1812         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
1813
1814 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
1815
1816         Fixing the diff_parser to correctly identify git diffs even with leading comments.
1817         https://bugs.webkit.org/show_bug.cgi?id=107871
1818
1819         Reviewed by Eric Seidel.
1820
1821         * Scripts/webkitpy/common/checkout/diff_parser.py:
1822         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1823         * Scripts/webkitpy/tool/steps/haslanded.py:
1824
1825 2013-01-24  James Robinson  <jamesr@chromium.org>
1826
1827         [chromium] Remove dead transitional code from WebViewImpl
1828         https://bugs.webkit.org/show_bug.cgi?id=107889
1829
1830         Reviewed by Adrienne Walker.
1831
1832         * DumpRenderTree/chromium/WebViewHost.cpp:
1833         (WebViewHost::initializeLayerTreeView):
1834         (WebViewHost::setWebWidget):
1835
1836 2013-01-24  Joshua Bell  <jsbell@chromium.org>
1837
1838         Add watchlist for IndexedDB development, and add myself and others.
1839
1840         Unreviewed.
1841
1842         * Scripts/webkitpy/common/config/watchlist:
1843
1844 2013-01-24  Martin Robinson  <mrobinson@igalia.com>
1845
1846         Abstract the logic for appending a UChar32 onto StringBuilder
1847         https://bugs.webkit.org/show_bug.cgi?id=107505
1848
1849         Reviewed by Darin Adler.
1850
1851         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1852         (TestWebKitAPI::TEST): Added a simple test for appending UChar32.
1853
1854 2013-01-24  Erik Arvidsson  <arv@chromium.org>
1855
1856         Unreviewed, rolling out r140703.
1857         http://trac.webkit.org/changeset/140703
1858         https://bugs.webkit.org/show_bug.cgi?id=107556
1859
1860         r140561 was not the reason for the Android breakage
1861
1862         * DumpRenderTree/chromium/TestShell.cpp:
1863         (TestShell::~TestShell):
1864         (TestShell::closeWindow):
1865         * DumpRenderTree/chromium/WebViewHost.cpp:
1866         (WebViewHost::WebViewHost):
1867         (WebViewHost::~WebViewHost):
1868         (WebViewHost::shutdown):
1869         * DumpRenderTree/chromium/WebViewHost.h:
1870         (WebViewHost):
1871
1872 2013-01-24  Dean Jackson  <dino@apple.com>
1873
1874         Allow some plugin snapshot UI content to come from Injected Bundle
1875         https://bugs.webkit.org/show_bug.cgi?id=107852
1876
1877         Reviewed by Anders Carlsson.
1878
1879         Null implementations of plugInStartLabelTitle, plugInStartLabelSubtitle and
1880         plugInExtraStyleSheet.
1881
1882         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1883         (WTR::InjectedBundlePage::InjectedBundlePage):
1884
1885 2013-01-24  Erik Arvidsson  <arv@chromium.org>
1886
1887         Unreviewed, rolling out r140561.
1888         http://trac.webkit.org/changeset/140561
1889         https://bugs.webkit.org/show_bug.cgi?id=107556
1890
1891         Suspected to break Android which prevens WebKit roll
1892
1893         * DumpRenderTree/chromium/TestShell.cpp:
1894         (TestShell::~TestShell):
1895         (TestShell::closeWindow):
1896         * DumpRenderTree/chromium/WebViewHost.cpp:
1897         (WebViewHost::WebViewHost):
1898         (WebViewHost::~WebViewHost):
1899         * DumpRenderTree/chromium/WebViewHost.h:
1900         (WebViewHost):
1901
1902 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
1903
1904         Adding "has-landed" command to webkit-patch which compares a
1905         committed patch to the changes which exist locally (ignoring the
1906         ChangeLog file).
1907
1908         https://bugs.webkit.org/show_bug.cgi?id=106402
1909
1910         Reviewed by Eric Seidel.
1911
1912         * Scripts/webkitpy/common/checkout/diff_parser.py:
1913         (git_diff_to_svn_diff):
1914         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1915         (Bug.commit_revision):
1916         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
1917         (BugTest.test_is_in_comments):
1918         (BugTest):
1919         (BugTest.test_commit_revision):
1920         * Scripts/webkitpy/tool/commands/upload.py:
1921         (HasLanded):
1922         * Scripts/webkitpy/tool/steps/__init__.py:
1923         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
1924         (HasLanded):
1925         (HasLanded.convert_to_svn):
1926         (HasLanded.strip_change_log):
1927         (run):
1928
1929         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1930         (Bug.commit_revision):
1931         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
1932         (BugTest.test_is_in_comments):
1933         (BugTest):
1934         (BugTest.test_commit_revision):
1935         * Scripts/webkitpy/tool/commands/upload.py:
1936         (HasLanded):
1937         * Scripts/webkitpy/tool/steps/__init__.py:
1938         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
1939         (HasLanded):
1940         (HasLanded.convert_to_svn):
1941         (HasLanded.strip_change_log):
1942         (HasLanded.diff_diff):
1943         (HasLanded.run):
1944         * Scripts/webkitpy/tool/steps/haslanded_unittest.py: Added.
1945         (HasLandedTest):
1946         (HasLandedTest.test_run):
1947         (test_convert_to_svn_and_strip_change_log):
1948
1949 2013-01-24  Dan Carney  <dcarney@google.com>
1950
1951         [chromium] move most WebViewHost printf calls to WebTestProxy
1952         https://bugs.webkit.org/show_bug.cgi?id=107553
1953
1954         Reviewed by Jochen Eisinger.
1955
1956         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1957         (WebKit):
1958         (WebTestProxyBase):
1959         (WebTestRunner::WebTestProxy::unableToImplementPolicyWithError):
1960         (WebTestRunner::WebTestProxy::didAddMessageToConsole):
1961         (WebTestRunner::WebTestProxy::runModalAlertDialog):
1962         (WebTestRunner::WebTestProxy::runModalConfirmDialog):
1963         (WebTestRunner::WebTestProxy::runModalPromptDialog):
1964         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
1965         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1966         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
1967         (WebTestRunner::WebTestProxyBase::reset):
1968         (WebTestRunner::WebTestProxyBase::setLogConsoleOutput):
1969         (WebTestRunner):
1970         (WebTestRunner::WebTestProxyBase::unableToImplementPolicyWithError):
1971         (WebTestRunner::WebTestProxyBase::didAddMessageToConsole):
1972         (WebTestRunner::WebTestProxyBase::runModalAlertDialog):
1973         (WebTestRunner::WebTestProxyBase::runModalConfirmDialog):
1974         (WebTestRunner::WebTestProxyBase::runModalPromptDialog):
1975         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
1976         * DumpRenderTree/chromium/TestShell.cpp:
1977         (TestShell::showDevTools):
1978         * DumpRenderTree/chromium/WebViewHost.cpp:
1979         (WebViewHost::didAddMessageToConsole):
1980         (WebViewHost::runModalAlertDialog):
1981         (WebViewHost::runModalConfirmDialog):
1982         (WebViewHost::runModalPromptDialog):
1983         (WebViewHost::runModalBeforeUnloadDialog):
1984         (WebViewHost::unableToImplementPolicyWithError):
1985         (WebViewHost::reset):
1986         * DumpRenderTree/chromium/WebViewHost.h:
1987         (WebViewHost):
1988
1989 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
1990
1991         [Chromium] Give webkit_support a chance to reset state between layout test runs
1992         https://bugs.webkit.org/show_bug.cgi?id=107132
1993
1994         Reviewed by Adam Barth.
1995
1996         We currently only have need for this on OS(ANDROID), but now it
1997         would be useful to have a hook for resetting state on all
1998         platforms. Will soon be using this for IDBFactory initialization.
1999
2000         * DumpRenderTree/chromium/TestShell.cpp:
2001         (TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()
2002
2003 2013-01-23  Alan Cutter  <alancutter@chromium.org>
2004
2005         QueueStatusServer crashes in production on next-patch
2006         https://bugs.webkit.org/show_bug.cgi?id=107775
2007
2008         Reviewed by Adam Barth.
2009
2010         Replaced Python 2.5 incompatible call to timedelta.total_seconds().
2011
2012         * QueueStatusServer/app.yaml:
2013         * QueueStatusServer/model/patchlog.py:
2014         (PatchLog.calculate_wait_duration):
2015         (PatchLog.calculate_process_duration):
2016         (PatchLog):
2017         (PatchLog._time_delta_to_seconds):
2018
2019 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2020
2021         The previous patch wasn't complete. Finish reverting r139998 for real.
2022
2023         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2024         (ProfilerAgent.getProfile):
2025
2026 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2027
2028         Revert r139998 for now since the Leaks Viewer pulls in a specific version of Inspector code.
2029
2030         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2031         (ProfilerAgent.getProfile):
2032
2033 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
2034
2035         [Chromium] Remove unused header files in chromium/public/platform/
2036         https://bugs.webkit.org/show_bug.cgi?id=107741
2037
2038         Reviewed by James Robinson.
2039
2040         These header files have migrated to the new Platform directory.
2041         This patch updates the remaining #include references and removes
2042         the old files that did nothing but redirect to the new ones.
2043
2044         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
2045         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
2046
2047 2013-01-23  Martin Robinson  <mrobinson@igalia.com>
2048
2049         [GTK] Bump webkitgtk-test-fonts dependency to cover fallbacks for Tamil, Bengali, and others
2050         https://bugs.webkit.org/show_bug.cgi?id=107727
2051
2052         Reviewed by Gustavo Noronha Silva.
2053
2054         * gtk/jhbuild.modules: Update the JHBuild moduleset to point to the new webkitgtk-test-fonts.
2055         We are using the git repository now that github has deprecated the downloads feature.
2056
2057 2013-01-23  Tony Chang  <tony@chromium.org>
2058
2059         Unreviewed, set svn:eol-style to CRLF on Windows .sln files.
2060
2061         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2062         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2063         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2064         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
2065
2066 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
2067
2068         [Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
2069         https://bugs.webkit.org/show_bug.cgi?id=107145
2070
2071         Reviewed by Adam Barth.
2072
2073         Part of a larger refactoring series; see tracking bug 82948.
2074         
2075         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2076         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2077         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2078         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2079         * DumpRenderTree/chromium/DRTTestRunner.h:
2080         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h:
2081         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2082         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
2083         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2084         * DumpRenderTree/chromium/TestNavigationController.h:
2085         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
2086         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2087         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
2088         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2089         (WebTestRunner):
2090         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
2091         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
2092         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2093         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2094         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2095         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2096         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
2097         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
2098         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
2099         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2100         * DumpRenderTree/chromium/TestShell.cpp:
2101         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2102         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2103         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2104         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2105         * DumpRenderTree/chromium/WebViewHost.cpp:
2106
2107 2013-01-23  Jochen Eisinger  <jochen@chromium.org>
2108
2109         [chromium] Use after free in plugins/geturlnotify-during-document-teardown.html
2110         https://bugs.webkit.org/show_bug.cgi?id=107556
2111
2112         Reviewed by Tony Chang.
2113
2114         WebViewHost initiates a navigation to about:blank in its destructor.
2115         However, since WebTestProxy inherits from WebViewHost, at this point
2116         the WebViewClient and WebFrameClient interfaces are already partially
2117         destructed resulting in the use after free.
2118
2119         This does not affect the chromium implementation since it doesn't
2120         invoke WebKit API methods in its destructor.
2121
2122         * DumpRenderTree/chromium/TestShell.cpp:
2123         (TestShell::~TestShell):
2124         (TestShell::closeWindow):
2125         * DumpRenderTree/chromium/WebViewHost.cpp:
2126         (WebViewHost::WebViewHost):
2127         (WebViewHost::~WebViewHost):
2128         (WebViewHost::shutdown):
2129         * DumpRenderTree/chromium/WebViewHost.h:
2130         (WebViewHost):
2131
2132 2013-01-23  Andrei Bucur  <abucur@adobe.com>
2133
2134         [CSS Regions] Create Regions watchlist
2135         https://bugs.webkit.org/show_bug.cgi?id=107281
2136
2137         Reviewed by Adam Barth.
2138
2139         This patch adds 4 new definitions:
2140         - RegionsDevelopment - used to track the development progress for regions
2141         - RegionsExpectationsMore and RegionsExpectationsLess - used to track expectations changes for the regions tests
2142         - RegionsUsage - used to track changes that make use of regions in all the code base
2143
2144         For now, the Adobe internal tracker is the only email address listening for these patterns.
2145
2146         * Scripts/webkitpy/common/config/watchlist:
2147
2148 2013-01-22  Pavel Feldman  <pfeldman@chromium.org>
2149
2150         Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
2151         https://bugs.webkit.org/show_bug.cgi?id=107523
2152
2153         Reviewed by Yury Semikhatsky.
2154
2155         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2156         (DRTDevToolsClient::isUnderTest):
2157         (DRTDevToolsClient::call):
2158         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2159         (DRTDevToolsClient):
2160
2161 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
2162
2163         Removing command line shortening as it makes it difficult to see the command during errors.
2164         https://bugs.webkit.org/show_bug.cgi?id=107643
2165
2166         Reviewed by Eric Seidel.
2167
2168         * Scripts/webkitpy/common/system/executive.py:
2169         (ScriptError):
2170         (ScriptError.__init__):
2171         * Scripts/webkitpy/common/system/executive_unittest.py:
2172
2173 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
2174
2175         Adding myself as contributor in committers.py (as requested by eseidel).
2176         https://bugs.webkit.org/show_bug.cgi?id=107647
2177
2178         Reviewed by Eric Seidel.
2179
2180         * Scripts/webkitpy/common/config/committers.py:
2181
2182 2013-01-22  Alan Cutter  <alancutter@chromium.org>
2183
2184         Add monitoring of patches and queues to the QueueStatusServer
2185         https://bugs.webkit.org/show_bug.cgi?id=107612
2186
2187         Reviewed by Adam Barth.
2188
2189         Created classes for recording events into the datastore and integrated them into the existing handlers.
2190         Code for presenting the recorded data will come in a separate patch.
2191
2192         * QueueStatusServer/app.yaml:
2193         * QueueStatusServer/config/__init__.py: Added.
2194         * QueueStatusServer/config/logging.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
2195         * QueueStatusServer/config/messages.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
2196         * QueueStatusServer/handlers/nextpatch.py:
2197         (NextPatch.get):
2198         (NextPatch._assign_patch):
2199         * QueueStatusServer/handlers/releasepatch.py:
2200         (ReleasePatch.post):
2201         * QueueStatusServer/handlers/updatestatus.py:
2202         (UpdateStatus.post):
2203         * QueueStatusServer/handlers/updateworkitems.py:
2204         (UpdateWorkItems._parse_work_items_string):
2205         (UpdateWorkItems):
2206         (UpdateWorkItems._update_work_items_from_request):
2207         (UpdateWorkItems._queue_from_request):
2208         (UpdateWorkItems.post):
2209         * QueueStatusServer/loggers/__init__.py: Added.
2210         * QueueStatusServer/loggers/recordbotevent.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
2211         (RecordBotEvent):
2212         (RecordBotEvent.activity):
2213         * QueueStatusServer/loggers/recordpatchevent.py: Added.
2214         (RecordPatchEvent):
2215         (RecordPatchEvent.added):
2216         (RecordPatchEvent.retrying):
2217         (RecordPatchEvent.started):
2218         (RecordPatchEvent.stopped):
2219         (RecordPatchEvent.updated):
2220         (RecordPatchEvent._get_patches_waiting):
2221         * QueueStatusServer/model/patchlog.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
2222         (PatchLog):
2223         (PatchLog.lookup):
2224         (PatchLog.calculate_wait_duration):
2225         (PatchLog.calculate_process_duration):
2226         * QueueStatusServer/model/queuelog.py: Copied from Tools/QueueStatusServer/handlers/nextpatch.py.
2227         (QueueLog):
2228         (QueueLog.get_current):
2229         (QueueLog.create_key):
2230         * QueueStatusServer/model/queuestatus.py:
2231         (QueueStatus.is_retry_request):
2232
2233 2013-01-22  Timothy Loh  <timloh@chromium.com>
2234
2235         prepare-Changelog should support updating the list of changed files
2236         https://bugs.webkit.org/show_bug.cgi?id=74358
2237
2238         Reviewed by Eric Seidel.
2239
2240         Needing to re-make ChangeLog entries when the list of files/functions
2241         changes is a bit annoying, it'd be nice to have this more automated.
2242         This patch makes `webkit-patch update' update the date line and bug
2243         description if needed, and if the list of changed files/functions has
2244         changed, either updates the list (if there are no annotations), or
2245         otherwise appends the new list below.
2246
2247         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2248         (PrepareChangeLog._resolve_existing_entry):
2249         (PrepareChangeLog):
2250         (PrepareChangeLog._merge_entries):
2251         (PrepareChangeLog.run):
2252         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2253         (PrepareChangeLogTest.test_resolve_existing_entry):
2254         (make_entry):
2255         (test_ensure_bug_url):
2256
2257 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
2258
2259         Use Python 2.7 unittest syntax in our unittests
2260         https://bugs.webkit.org/show_bug.cgi?id=105607
2261
2262         Reviewed by Eric Seidel.
2263
2264         * Scripts/webkitpy/**/*_unittest.py:
2265
2266 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
2267
2268         Convert disable-msg to disable for new pylint.
2269         https://bugs.webkit.org/show_bug.cgi?id=107627
2270
2271         Reviewed by Eric Seidel.
2272
2273         * Scripts/webkitpy/common/checkout/scm/svn.py:
2274         (SVNRepository.has_authorization_for_realm):
2275         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2276         (Builder.force_build):
2277         * Scripts/webkitpy/common/system/executive_mock.py:
2278         (MockExecutive2.run_command):
2279         * Scripts/webkitpy/layout_tests/port/base.py:
2280         (Port.reference_files):
2281         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
2282         (ChromiumPortTestCase.test_default_configuration):
2283         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2284         (PortTestCase.test_expectations_ordering):
2285         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2286         (HttpServerBase._check_that_all_ports_are_available):
2287         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
2288         (AbstractLocalServerCommand.execute):
2289         * Scripts/webkitpy/tool/commands/download.py:
2290         (AbstractPatchProcessingCommand):
2291         * Scripts/webkitpy/tool/commands/rebaseline.py:
2292         (AbstractRebaseliningCommand):
2293         (AbstractParallelRebaselineCommand):
2294         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2295         (_BaseTestCase.setUp):
2296         (TestAnalyzeBaselines.setUp):
2297
2298 2013-01-22  Frank Farzan  <frankf@chromium.org>
2299
2300         Flakiness dashboard: update builders.jsonp
2301         https://bugs.webkit.org/show_bug.cgi?id=107610
2302
2303         Reviewed by Ojan Vafai.
2304
2305         * TestResultServer/static-dashboards/builders.jsonp:
2306
2307 2013-01-22  Frank Farzan  <frankf@chromium.org>
2308
2309         Add Android instrumentation tests from ChromiumLinux waterfall
2310         https://bugs.webkit.org/show_bug.cgi?id=107597
2311
2312         Reviewed by Ojan Vafai.
2313
2314         * TestResultServer/static-dashboards/builders.js:
2315         (loadBuildersList):
2316
2317 2013-01-21  Kentaro Hara  <haraken@chromium.org>
2318
2319         Implement UIEvent constructor
2320         https://bugs.webkit.org/show_bug.cgi?id=107430
2321
2322         Reviewed by Adam Barth.
2323
2324         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
2325
2326         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
2327         which is enabled on Safari and Chromium for now.
2328
2329         * Scripts/webkitperl/FeatureList.pm:
2330
2331 2013-01-22  Timothy Loh  <timloh@chromium.com>
2332
2333         Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries
2334         https://bugs.webkit.org/show_bug.cgi?id=107478
2335
2336         Reviewed by Eric Seidel.
2337
2338         On the road to resolving Bug 74358, we need a few more functions in
2339         changelog.py.
2340         To make things easier to mock, change @staticmethods to @classmethods.
2341
2342         * Scripts/webkitpy/common/checkout/changelog.py:
2343         (ChangeLogEntry):
2344         (ChangeLogEntry._parse_reviewer_text):
2345         (ChangeLogEntry._split_contributor_names):
2346         (ChangeLogEntry._parse_author_name_and_email):
2347         (ChangeLogEntry._parse_author_text):
2348         (ChangeLogEntry._parse_touched_functions):
2349         (ChangeLogEntry._parse_bug_description):
2350         (ChangeLogEntry._parse_entry):
2351         (ChangeLogEntry.date_line):
2352         (ChangeLogEntry.bug_description):
2353         (ChangeLogEntry.touched_functions):
2354         (ChangeLogEntry.touched_files_text):
2355         (ChangeLogEntry.is_touched_files_text_clean):
2356         (ChangeLog):
2357         (ChangeLog.parse_latest_entry_from_file):
2358         (ChangeLog._separate_revision_and_line):
2359         (ChangeLog.parse_entries_from_file):
2360         (ChangeLog.set_short_description_and_bug_url):
2361         (ChangeLog.delete_entries):
2362         (ChangeLog.prepend_text):
2363         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2364         (test_parse_log_entries_from_changelog):
2365         (test_latest_entry_parse):
2366         (test_set_short_description_and_bug_url):
2367         (test_delete_entries):
2368         (test_prepend_text):
2369
2370 2013-01-22  Lucas Forschler  <lforschler@apple.com>
2371
2372         Create a MAC EWS startup shell script.
2373
2374         Reviewed by Ryosuke Niwa.
2375
2376         * EWSTools/start-queue-mac.sh: Added.
2377
2378 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
2379
2380         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
2381         https://bugs.webkit.org/show_bug.cgi?id=107230
2382
2383         Reviewed by David Kilzer.
2384
2385         * DumpRenderTree/mac/TestRunnerMac.mm:
2386         (TestRunner::resetPageVisibility):
2387         Fix a typo in the original implementation. resetPageVisibility should
2388         pass initialState YES so an event is not dispatched, which causes
2389         issues in multiple tests. This now matches other ports.
2390
2391 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
2392
2393         [GTK] Enable CSS Image Orientation feature
2394         https://bugs.webkit.org/show_bug.cgi?id=99040
2395
2396         Reviewed by Martin Robinson.
2397
2398         Enable the CSS Image Orientation feature in the development
2399         builds of the GTK port. The feature is still disabled in the release
2400         builds.
2401
2402         * Scripts/webkitperl/FeatureList.pm:
2403
2404 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
2405
2406         [GTK] Enable the <template> element support in development builds
2407         https://bugs.webkit.org/show_bug.cgi?id=106575
2408
2409         Reviewed by Martin Robinson.
2410
2411         Enable the <template> element support in the development builds of the GTK port.
2412
2413         * Scripts/webkitperl/FeatureList.pm:
2414
2415 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
2416
2417         Prettify the output of the override-feature-defines script
2418         https://bugs.webkit.org/show_bug.cgi?id=106542
2419
2420         Reviewed by Martin Robinson.
2421
2422         The output now clearly lists the feature defines being overridden
2423         along with the default and overriding values for each feature define.
2424
2425         * gtk/override-feature-defines:
2426         (adjust_feature_defines_makefile):
2427         (adjust_feature_defines_makefile.override_feature_define):
2428
2429 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
2430
2431         Remove uses of deprecated unittest.TestCase aliases
2432         https://bugs.webkit.org/show_bug.cgi?id=102252
2433
2434         Reviewed by Adam Barth.
2435
2436         Replace the deprecated assertEquals method of the TestCase interface
2437         used in some webkitpy unittests with the assertEqual method.
2438
2439         * Scripts/webkitpy/common/system/profiler_unittest.py:
2440         (ProfilerFactoryTest._assert_default_profiler_name):
2441         (ProfilerFactoryTest.test_default_profiler_output):
2442         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2443         (GtkPortTest.test_expectations_files):
2444         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2445         (TestHttpServer.test_win32_start_and_stop):
2446
2447 2013-01-22  Jer Noble  <jer.noble@apple.com>
2448
2449         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
2450         https://bugs.webkit.org/show_bug.cgi?id=107562
2451
2452         Rubber-stamped by Alexy Proskuryakov.
2453
2454         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
2455
2456         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2457         (WTR::PlatformWebView::PlatformWebView):
2458         (WTR::PlatformWebView::viewSupportsOptions):
2459
2460 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
2461
2462         One is not allowed to use commit-queue to make oneself a committer.
2463
2464         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
2465
2466 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
2467
2468         Add myself to commiters.py
2469         https://bugs.webkit.org/show_bug.cgi?id=107546
2470
2471         Reviewed by Kentaro Hara.
2472
2473         * Scripts/webkitpy/common/config/committers.py:
2474
2475 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
2476
2477         [GTK] Implement TestRunner::setTextDirection
2478         https://bugs.webkit.org/show_bug.cgi?id=107131
2479
2480         Reviewed by Philippe Normand.
2481
2482         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2483         (resetDefaultsToConsistentValues): Reset direction to default value.
2484         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2485         (TestRunner::setTextDirection): Implement method using
2486         gtk_widget_set_direction.
2487
2488 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
2489
2490         [chromium] move spell checking mocks to TestRunner library
2491         https://bugs.webkit.org/show_bug.cgi?id=107455
2492
2493         Reviewed by Kent Tamura.
2494
2495         The content module doesn't provide its own WebSpellCheckClient.
2496
2497         * DumpRenderTree/DumpRenderTree.gypi:
2498         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2499         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
2500         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2501         (WebKit):
2502         (WebTestRunner):
2503         (WebTestProxyBase):
2504         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2505         (WebTestRunner):
2506         (WebTestRunner::makeMenuItemStringsFor):
2507         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
2508         (MockGrammarCheck::checkGrammarOfString):
2509         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
2510         (WebKit):
2511         (MockGrammarCheck):
2512         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
2513         (MockSpellCheck::MockSpellCheck):
2514         (MockSpellCheck::~MockSpellCheck):
2515         (isNotASCIIAlpha):
2516         (MockSpellCheck::spellCheckWord):
2517         (MockSpellCheck::fillSuggestionList):
2518         (MockSpellCheck::initializeIfNeeded):
2519         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
2520         (MockSpellCheck):
2521         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
2522         (WebTestRunner::SpellCheckClient::SpellCheckClient):
2523         (WebTestRunner):
2524         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
2525         (WebTestRunner::SpellCheckClient::setDelegate):
2526         (WebTestRunner::SpellCheckClient::spellCheck):
2527         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
2528         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
2529         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
2530         (WebTestRunner::SpellCheckClient::autoCorrectWord):
2531         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
2532         (WebTestRunner):
2533         (SpellCheckClient):
2534         (WebTestRunner::SpellCheckClient::taskList):
2535         (WebTestRunner::SpellCheckClient::mockSpellCheck):
2536         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2537         (TestDelegate):
2538         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2539         (WebTestInterfaces::Internal):
2540         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2541         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
2542         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
2543         (WebTestRunner::WebTestProxyBase::setDelegate):
2544         (WebTestRunner::WebTestProxyBase::spellCheckClient):
2545         (WebTestRunner):
2546         * DumpRenderTree/chromium/WebViewHost.cpp:
2547         (WebViewHost::WebViewHost):
2548         (WebViewHost::setWebWidget):
2549         * DumpRenderTree/chromium/WebViewHost.h:
2550         (WebViewHost):
2551
2552 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
2553
2554         [EFL] Adds Accessibility support to wk1
2555         https://bugs.webkit.org/show_bug.cgi?id=107440
2556
2557         Reviewed by Gyuyoung Kim.
2558
2559         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
2560
2561 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
2562
2563         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
2564         https://bugs.webkit.org/show_bug.cgi?id=107506
2565
2566         Reviewed by Dan Bernstein.
2567
2568         * MiniBrowser/mac/WK1BrowserWindowController.m:
2569         (-[WK1BrowserWindowController dealloc]):
2570
2571 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
2572
2573         Add build flag for Canvas's Path object (disabled by default)
2574         https://bugs.webkit.org/show_bug.cgi?id=107473
2575
2576         Reviewed by Dean Jackson.
2577
2578         Add CANVAS_PATH build flag to build systems.
2579
2580         * Scripts/webkitperl/FeatureList.pm:
2581
2582 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
2583
2584         [EFL][WK2] Add APIs to set/get view source mode
2585         https://bugs.webkit.org/show_bug.cgi?id=106633
2586
2587         Reviewed by Gyuyoung Kim.
2588
2589         Added a shotcut 'F8' in Minibrowser to display a source code
2590         of the web page in a new window.
2591
2592        * MiniBrowser/efl/main.c:
2593         (on_key_down):
2594         (on_window_create):
2595         (window_create):
2596         (elm_main):
2597
2598 2013-01-21  Nico Weber  <thakis@chromium.org>
2599
2600         [chromium] Don't archive generated source files.
2601         https://bugs.webkit.org/show_bug.cgi?id=106736
2602
2603         Reviewed by Eric Seidel.
2604
2605         They shouldn't be needed to run tests. They don't need a lot of space,
2606         but add many lines to the "extracting" stdout. This attempts to reduce
2607         that noise a bit.
2608
2609         * BuildSlaveSupport/built-product-archive:
2610         (archiveBuiltProduct):
2611
2612 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
2613
2614         Mac DumpRenderTree's installSignalHandlers() is unreachable code
2615         https://bugs.webkit.org/show_bug.cgi?id=107383
2616
2617         Reviewed by Sam Weinig.
2618
2619         The CrashHandler of DumpRenderTree were originally used for restoring
2620         the color profile of the main display even if DRT crashes.
2621
2622         That feature was later limited to pixel tests only in r29999.
2623
2624         In r104351, the DRT was changed to use device color space. Making the crash
2625         handlers useless, but they were left in the code since the error reporting
2626         code was still reachable.
2627
2628         Later, r124581 refactored the code and dumpPixelsForCurrentTest
2629         is being used before being assigned its value.
2630         This did cause any regression because the code had become useless with the previous change.
2631
2632         * DumpRenderTree/mac/DumpRenderTree.mm:
2633         Remove crashHandler() and installSignalHandlers() as they have become useless and
2634         have been unreachable code for 6 months.
2635         (dumpRenderTree):
2636         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
2637         at those points.
2638
2639 2013-01-21  Nico Weber  <thakis@chromium.org>
2640
2641         Make ninja the default build system for build-webkit --chromium on mac
2642         https://bugs.webkit.org/show_bug.cgi?id=106737
2643
2644         Reviewed by Eric Seidel.
2645
2646         * Scripts/update-webkit-chromium:
2647
2648 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
2649
2650         Regression(r140262): Causes a lot of flakiness
2651         https://bugs.webkit.org/show_bug.cgi?id=107454
2652
2653         Reviewed by Alexey Proskuryakov.
2654
2655         r140262 introduced a lot of flakiness due to fixed layout mode
2656         not getting disabled on the view after being enabled for
2657         specific test cases. This patch makes sure fixed layout mode
2658         properly gets reset in WebKitTestRunner to avoid flakiness.
2659
2660         * WebKitTestRunner/TestInvocation.cpp:
2661         (WTR::updateLayoutType):
2662
2663 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
2664
2665         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
2666         https://bugs.webkit.org/show_bug.cgi?id=107421
2667
2668         Unreviewed build fix.
2669
2670         * Scripts/run-gtk-tests:
2671         (TestRunner): skip Resource tests.
2672
2673 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
2674
2675         [EFL][WKTR] platformRunUntil() should keep the main loop running
2676         https://bugs.webkit.org/show_bug.cgi?id=107442
2677
2678         Reviewed by Noam Rosenthal.
2679
2680         EFL's implementation of platformRunUntil() should keep the main loop
2681         running and avoid calling sleep() between calls to
2682         ecore_main_loop_iterate(). This call to sleep seems to be a source
2683         of deadlocks (see Bug 106884).
2684
2685         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2686         (WTR::TestController::platformRunUntil):
2687
2688 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
2689
2690         QtTestBrowser should provide way to clear selected elements
2691         https://bugs.webkit.org/show_bug.cgi?id=107437
2692
2693         Reviewed by Simon Hausmann.
2694
2695         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
2696         Invoke the clearSelection prior to highlighting new elements.
2697
2698         * QtTestBrowser/launcherwindow.cpp:
2699         (ElementHighlight):
2700         (LauncherWindow::createChrome):
2701         (LauncherWindow::selectElements):
2702         (LauncherWindow::clearSelection):
2703         * QtTestBrowser/launcherwindow.h:
2704         (LauncherWindow):
2705
2706 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
2707
2708         [chromium] move methods interacting with willSendRequest to TestRunner
2709         https://bugs.webkit.org/show_bug.cgi?id=107270
2710
2711         Reviewed by Kent Tamura.
2712
2713         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2714         (DRTTestRunner::DRTTestRunner):
2715         (DRTTestRunner::waitForPolicyDelegate):
2716         * DumpRenderTree/chromium/DRTTestRunner.h:
2717         (DRTTestRunner):
2718         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2719         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2720         (WebTestRunner::WebTestRunner::httpHeadersToClear):
2721         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
2722         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
2723         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2724         (WebTestRunner::TestRunner::TestRunner):
2725         (WebTestRunner::TestRunner::reset):
2726         (WebTestRunner::TestRunner::httpHeadersToClear):
2727         (WebTestRunner):
2728         (WebTestRunner::TestRunner::shouldBlockRedirects):
2729         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
2730         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
2731         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
2732         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
2733         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2734         (TestRunner):
2735         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2736         (WebTestRunner::WebTestProxyBase::willSendRequest):
2737         * DumpRenderTree/chromium/WebViewHost.cpp:
2738         (WebViewHost::willSendRequest):
2739         (WebViewHost::reset):
2740         * DumpRenderTree/chromium/WebViewHost.h:
2741         (WebViewHost):
2742
2743 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
2744
2745         [GTK] Stop building WebKit2 on GTK EWSs
2746         https://bugs.webkit.org/show_bug.cgi?id=107435
2747
2748         Reviewed by Philippe Normand.
2749
2750         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
2751         so stop building it on GTK EWSs.
2752
2753         * Scripts/webkitpy/common/config/ports.py:
2754         (GtkPort.build_webkit_command):
2755         * Scripts/webkitpy/common/config/ports_unittest.py:
2756         (DeprecatedPortTest.test_gtk_port):
2757
2758 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
2759
2760         MediaStream API: Update the RTCPeerConnection states to match the latest specification
2761         https://bugs.webkit.org/show_bug.cgi?id=107120
2762
2763         Reviewed by Adam Barth.
2764
2765         Updating mock to use the new states.
2766
2767         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2768         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
2769         (MockWebRTCPeerConnectionHandler::initialize):
2770         (MockWebRTCPeerConnectionHandler::updateICE):
2771
2772 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
2773
2774         Extend diff_parser to support the --full-index output.
2775         https://bugs.webkit.org/show_bug.cgi?id=107408
2776
2777         Reviewed by Maciej Stachowiak.
2778
2779         * Scripts/webkitpy/common/checkout/diff_parser.py:
2780         (git_diff_to_svn_diff):
2781         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
2782         (DiffParserTest):
2783         (DiffParserTest.test_git_diff_to_svn_diff):
2784         (git_diff_to_svn_diff):
2785
2786 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
2787
2788         Dragging over an element with scrollbars should scroll the element when dragging near edges
2789         https://bugs.webkit.org/show_bug.cgi?id=39725
2790
2791         Reviewed by Hajime Morita.
2792
2793         This patch introduces canceling drag-and-drop by escape key for testing
2794         behavior after cancellation drag-and-drop.
2795
2796         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2797         (WebTestRunner):
2798         (WebTestRunner::EventSender::doMouseUp):
2799         (WebTestRunner::EventSender::finishDragAndDrop):
2800         (WebTestRunner::EventSender::keyDown):
2801         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
2802         (EventSender):
2803         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
2804
2805 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
2806
2807         [chromium] move frame generation related methods to TestRunner
2808         https://bugs.webkit.org/show_bug.cgi?id=107268
2809
2810         Reviewed by Adam Barth.
2811
2812         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2813         (DRTTestRunner::DRTTestRunner):
2814         (DRTTestRunner::setWillSendRequestReturnsNull):
2815         * DumpRenderTree/chromium/DRTTestRunner.h:
2816         (DRTTestRunner):
2817         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2818         (WebTestRunner::WebTestDelegate::display):
2819         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
2820         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2821         (WebTestRunner::TestRunner::TestRunner):
2822         (WebTestRunner::TestRunner::display):
2823         (WebTestRunner):
2824         (WebTestRunner::TestRunner::displayInvalidatedRegion):
2825         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2826         (TestRunner):
2827         * DumpRenderTree/chromium/WebViewHost.cpp:
2828         (WebViewHost::display):
2829         (WebViewHost::displayInvalidatedRegion):
2830         * DumpRenderTree/chromium/WebViewHost.h:
2831
2832 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
2833
2834         [chromium] move speech related methods to TestRunner library
2835         https://bugs.webkit.org/show_bug.cgi?id=107266
2836
2837         Reviewed by Adam Barth.
2838
2839         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2840         (DRTTestRunner::DRTTestRunner):
2841         (DRTTestRunner::displayInvalidatedRegion):
2842         * DumpRenderTree/chromium/DRTTestRunner.h:
2843         (DRTTestRunner):
2844         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2845         (WebTestDelegate):
2846         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
2847         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
2848         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
2849         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
2850         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
2851         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2852         (WebTestRunner::TestRunner::TestRunner):
2853         (WebTestRunner):
2854         (WebTestRunner::TestRunner::addMockSpeechInputResult):
2855         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
2856         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
2857         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
2858         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
2859         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2860         (TestRunner):
2861         * DumpRenderTree/chromium/WebViewHost.cpp:
2862         (WebViewHost::addMockSpeechInputResult):
2863         (WebViewHost::setMockSpeechInputDumpRect):
2864         (WebViewHost::addMockSpeechRecognitionResult):
2865         (WebViewHost::setMockSpeechRecognitionError):
2866         (WebViewHost::wasMockSpeechRecognitionAborted):
2867         * DumpRenderTree/chromium/WebViewHost.h:
2868
2869 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
2870
2871         [chromium] move notification related methods to TestRunner
2872         https://bugs.webkit.org/show_bug.cgi?id=107269
2873
2874         Reviewed by Adam Barth.
2875
2876         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2877         (DRTTestRunner::DRTTestRunner):
2878         * DumpRenderTree/chromium/DRTTestRunner.h:
2879         (DRTTestRunner):
2880         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2881         (WebTestDelegate):
2882         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
2883         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
2884         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2885         (WebTestRunner::TestRunner::TestRunner):
2886         (WebTestRunner):
2887         (WebTestRunner::TestRunner::grantWebNotificationPermission):
2888         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
2889         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2890         (TestRunner):
2891         * DumpRenderTree/chromium/WebViewHost.cpp:
2892         (WebViewHost::grantWebNotificationPermission):
2893         (WebViewHost::simulateLegacyWebNotificationClick):
2894         * DumpRenderTree/chromium/WebViewHost.h:
2895
2896 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
2897
2898         [chromium] move geolocation related methods to TestRunner
2899         https://bugs.webkit.org/show_bug.cgi?id=107267
2900
2901         Reviewed by Adam Barth.
2902
2903         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2904         (DRTTestRunner::DRTTestRunner):
2905         * DumpRenderTree/chromium/DRTTestRunner.h:
2906         (DRTTestRunner):
2907         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2908         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
2909         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
2910         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
2911         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
2912         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2913         (WebTestRunner::TestRunner::TestRunner):
2914         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
2915         (WebTestRunner):
2916         (WebTestRunner::TestRunner::setGeolocationPermission):
2917         (WebTestRunner::TestRunner::setMockGeolocationPosition):
2918         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
2919         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2920         (TestRunner):
2921         * DumpRenderTree/chromium/WebViewHost.cpp:
2922         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
2923         (WebViewHost::setGeolocationPermission):
2924         (WebViewHost::setMockGeolocationPosition):
2925         (WebViewHost::setMockGeolocationPositionUnavailableError):
2926         * DumpRenderTree/chromium/WebViewHost.h:
2927
2928 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
2929
2930         Unreviewed build fix for Qt WK2 after r140258.
2931         Use the size_t type instead of unsigned for the variable
2932         which holds the position of the first null character in the
2933         console message.
2934
2935         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2936         (WTR::InjectedBundlePage::willAddMessageToConsole):
2937
2938 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2939
2940         Unreviewed, rolling out r140260.
2941         http://trac.webkit.org/changeset/140260
2942         https://bugs.webkit.org/show_bug.cgi?id=107387
2943
2944         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
2945         nothing else) (Requested by thakis__ on #webkit).
2946
2947         * Scripts/update-webkit-chromium:
2948
2949 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2950
2951         Delegated scrolling: Assertion on attempt to show a CSS sticky element
2952         https://bugs.webkit.org/show_bug.cgi?id=106890
2953
2954         Reviewed by Kenneth Rohde Christiansen.
2955
2956         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
2957
2958         * WebKitTestRunner/TestInvocation.cpp:
2959         (WTR::shouldUseFixedLayout):
2960         (WTR):
2961         (WTR::updateLayoutType):
2962
2963 2013-01-19  Nico Weber  <thakis@chromium.org>
2964
2965         Make ninja the default build system for build-webkit --chromium on mac
2966         https://bugs.webkit.org/show_bug.cgi?id=106737
2967
2968         Reviewed by Eric Seidel.
2969
2970         * Scripts/update-webkit-chromium:
2971
2972 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
2973
2974         [WK2] svg/dom/fuzz-path-parser.html is failing
2975         https://bugs.webkit.org/show_bug.cgi?id=107133
2976
2977         Reviewed by Alexey Proskuryakov.
2978
2979         Console messages can contain null characters before the end of string.
2980         Appending such message to the StringBuilder as a WTFString appends the
2981         complete string, including the null character. This later cuts off everything
2982         after the null character when the string is being printed out to the test
2983         output.
2984
2985         To avoid this, truncate the string up to the first null character. This
2986         preserves the newline character appended immediately after this and
2987         stops giving incorrect output.
2988
2989         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2990         (WTR::InjectedBundlePage::willAddMessageToConsole):
2991
2992 2013-01-19  Eric Seidel  <eric@webkit.org>
2993
2994         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
2995         https://bugs.webkit.org/show_bug.cgi?id=107367
2996
2997         Reviewed by Ryosuke Niwa.
2998
2999         Using srcdoc instead of document.write changes the error output
3000         ever so slightly.  Clearly we were already trying to ignore these
3001         messages, just not succeeding.  This change makes this new test "pass" correctly.
3002
3003         * Scripts/webkitpy/performance_tests/perftest.py:
3004         (PerfTest):
3005
3006 2013-01-18  Dan Winship  <danw@gnome.org>
3007
3008         REGRESSION (r139071): run-webkit-httpd complains at launch
3009         https://bugs.webkit.org/show_bug.cgi?id=107310
3010
3011         Reviewed by Alexey Proskuryakov.
3012
3013         * Scripts/webkitperl/httpd.pm:
3014         (getApacheVersion): use preferred perl syntax
3015
3016 2013-01-18  Julie Parent  <jparent@chromium.org>
3017
3018         Add back 'group' as a default cross dashboard parameter, but with null as its value.
3019         https://bugs.webkit.org/show_bug.cgi?id=107336
3020
3021         We need to have 'group' listed as a parameter, else we never parse it,
3022         as we only parse parameters with defaults.
3023         
3024         Reviewed by Ojan Vafai.
3025
3026         * TestResultServer/static-dashboards/dashboard_base.js:
3027
3028 2013-01-18  Emil A Eklund  <eae@chromium.org>
3029
3030         Update LayoutUnit rounding unit test
3031         https://bugs.webkit.org/show_bug.cgi?id=107322
3032
3033         Reviewed by Levi Weintraub.
3034         
3035         Update the LayoutUnitRounding test to use fromFloatRound for
3036         values that cannot accurately be represented as a LayoutUnit
3037         (the default behavior is to floor the value to the nearest
3038         LayoutUnit).
3039
3040         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3041         (TestWebKitAPI::TEST):
3042
3043 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3044
3045         VCSUtils.pm: Stop calling git repo-config.
3046         https://bugs.webkit.org/show_bug.cgi?id=107294
3047
3048         Reviewed by Dirk Pranke.
3049
3050         The `repo-config' git command has been deprecated since early
3051         2008, and recent versions have started warning it is deprecated.
3052
3053         Basically revert r27870 and use the `config' command all the time.
3054
3055         * Scripts/VCSUtils.pm:
3056         (gitConfig):
3057
3058 2013-01-18  Levi Weintraub  <leviw@chromium.org>
3059
3060         LayoutUnit should round half consistently, not away from zero
3061         https://bugs.webkit.org/show_bug.cgi?id=107208
3062
3063         Reviewed by Eric Seidel.
3064
3065         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
3066         cover this change in rounding behavior.
3067
3068 2013-01-18  Tim Horton  <timothy_horton@apple.com>
3069
3070         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
3071         https://bugs.webkit.org/show_bug.cgi?id=107234
3072
3073         Reviewed by Simon Fraser.
3074
3075         * DumpRenderTree/mac/DumpRenderTree.mm:
3076         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
3077         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3078         (WTR::PlatformWebView::PlatformWebView): Ditto.
3079
3080 2013-01-18  Tim Horton  <timothy_horton@apple.com>
3081
3082         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
3083         https://bugs.webkit.org/show_bug.cgi?id=107251
3084
3085         Reviewed by Simon Fraser.
3086
3087         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
3088
3089         * DumpRenderTree/mac/DumpRenderTree.mm:
3090         (dumpRenderTree):
3091         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3092         (WTR::InjectedBundle::platformInitialize):
3093
3094 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
3095
3096         [GTK] Enable indexed database for development builds
3097         https://bugs.webkit.org/show_bug.cgi?id=107299
3098
3099         Reviewed by Gustavo Noronha Silva.
3100
3101         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
3102         for GTK+ development builds.
3103
3104 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
3105
3106         AX: Improve table-guessing heuristics
3107         https://bugs.webkit.org/show_bug.cgi?id=107042
3108
3109         Reviewed by Chris Fleizach.
3110
3111         Implement parentElementCallback on Chromium to make testing easier.
3112
3113         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3114         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
3115
3116 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
3117
3118         [GTK] Add property for IndexedDB database path to WebKitGTK+
3119         https://bugs.webkit.org/show_bug.cgi?id=106136
3120
3121         Reviewed by Gustavo Noronha Silva.
3122
3123         During testing, set the web database directory to DUMPRENDERTREE_TEMP
3124         before falling back to the old default. This is necessary because
3125         indexed database tests require that each DRT shard is using a different
3126         IDB database location.
3127
3128         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3129         (temporaryDatabaseDirectory): Added this helper for getting the
3130         database directory.
3131         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
3132
3133 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3134
3135         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
3136         https://bugs.webkit.org/show_bug.cgi?id=107264
3137
3138         Reviewed by Laszlo Gombos.
3139
3140         Enable API test InjectedBundleFrameHitTest for hit-testing,
3141         since it is now passing on both Debug and Release builds.
3142
3143         * TestWebKitAPI/CMakeLists.txt:
3144         * TestWebKitAPI/PlatformEfl.cmake:
3145
3146 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
3147
3148         [GTK] Implement TestRunner::addUserScript
3149         https://bugs.webkit.org/show_bug.cgi?id=107275
3150
3151         Reviewed by Philippe Normand.
3152
3153         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3154         (TestRunner::addUserScript): Implement method using
3155         DumpRenderTreeSupportGtk::addUserScript.
3156
3157 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3158
3159         Unreviewed, add my secondary email address to the list.
3160
3161         * Scripts/webkitpy/common/config/committers.py:
3162
3163 2013-01-18  Dan Carney  <dcarney@google.com>
3164
3165         [chromium] move pointerlock functions to TestRunner library
3166         https://bugs.webkit.org/show_bug.cgi?id=107241
3167
3168         Reviewed by Jochen Eisinger.
3169
3170         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3171         (DRTTestRunner::DRTTestRunner):
3172         * DumpRenderTree/chromium/DRTTestRunner.h:
3173         (DRTTestRunner):
3174         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3175         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
3176         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
3177         (WebTestRunner::WebTestDelegate::didLosePointerLock):
3178         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
3179         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
3180         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3181         (WebTestRunner::TestRunner::TestRunner):
3182         (WebTestRunner):
3183         (WebTestRunner::TestRunner::didAcquirePointerLock):
3184         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
3185         (WebTestRunner::TestRunner::didLosePointerLock):
3186         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
3187         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
3188         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3189         (TestRunner):
3190         * DumpRenderTree/chromium/WebViewHost.h:
3191         (WebViewHost):
3192
3193 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
3194
3195         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
3196         https://bugs.webkit.org/show_bug.cgi?id=106774
3197
3198         Reviewed by Martin Robinson.
3199
3200         In order to fix a long standing linespacing/font ascent & descent issue
3201         we found that FreeType commit b0962ac34e660 solves that problem.
3202         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
3203         maintainer recommending several security updates after that said commit.
3204
3205         Also, in order to avoid extra rebaselining, let's activate subpixel
3206         layout at the same time.
3207
3208         * efl/jhbuild.modules: New freetype 2.4.11
3209
3210 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
3211
3212         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
3213         https://bugs.webkit.org/show_bug.cgi?id=107107
3214         PR 282192
3215
3216         Reviewed by Rob Buis.
3217
3218         The DRT application will convert relative/absolute file path to
3219         file://<real-file-path> format, so we only check for http/file prefix.
3220
3221         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3222         (BlackBerry::WebKit::isFullUrl):
3223         (WebKit):
3224         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
3225
3226 2013-01-17  Frank Farzan  <frankf@chromium.org>
3227
3228         Flakiness dashboard: Add ChromiumFYI master
3229         https://bugs.webkit.org/show_bug.cgi?id=107180
3230
3231         Reviewed by Ojan Vafai.
3232
3233         This is needed to enable Chrome Android bots
3234         to upload results for instrumentation tests.
3235
3236         * TestResultServer/generate_builders_json.py:
3237         (main):
3238         * TestResultServer/static-dashboards/builders.jsonp:
3239
3240 2013-01-17  Frank Farzan  <frankf@chromium.org>
3241
3242         Add Chrome on Android instrumentation test types to flakiness dashboard
3243         https://bugs.webkit.org/show_bug.cgi?id=106964
3244
3245         Reviewed by Ojan Vafai.
3246
3247         Specifically, add these test types:
3248         
3249          androidwebview_instrumentation_tests
3250          chromiumtestshell_instrumentation_tests
3251          contentshell_instrumentation_tests
3252         
3253         Also, add ChromiumFYI to the list of masters.
3254
3255         * TestResultServer/static-dashboards/builders.js:
3256         (loadBuildersList):
3257         * TestResultServer/static-dashboards/dashboard_base.js:
3258         (currentBuilderGroupCategory):
3259
3260 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
3261
3262         Fixing webkitpy's SCM unit tests.
3263         https://bugs.webkit.org/show_bug.cgi?id=106429
3264
3265         Reviewed by Eric Seidel.
3266
3267         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3268         (SCMDetectorTest.test_detect_scm_system):
3269         * Scripts/webkitpy/common/checkout/scm/git.py:
3270         (Git.in_working_directory):
3271         (Git.read_git_config):
3272         (Git._assert_can_squash):
3273         (Git.remote_branch_ref):
3274         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3275         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
3276         (GitTestWithMock):
3277         (GitTestWithMock.make_scm):
3278         (GitTestWithMock.test_create_patch):
3279         * Scripts/webkitpy/common/system/outputcapture.py:
3280         (OutputCapture.assert_outputs):
3281         (OutputCaptureTestCaseBase):
3282         * Scripts/webkitpy/test/printer.py:
3283         (Printer.configure):
3284
3285 2013-01-17  Julie Parent  <jparent@chromium.org>
3286
3287         Flakiness dashboard assumes there must be ToT tests
3288         https://bugs.webkit.org/show_bug.cgi?id=107155
3289
3290         Remove group as a default parameter, since we can't actually know
3291         the name of a group initially.  Instead, introduces 
3292         currentBuilderGroupName which returns the current builder group
3293         if it has been explicitly set, or picks the first one available
3294         as a default. Allows us to remove some extra code tracking this
3295         stuff as well.
3296         
3297         Reviewed by Ojan Vafai.
3298
3299         * TestResultServer/static-dashboards/dashboard_base.js:
3300         (parseCrossDashboardParameters):
3301         (currentBuilderGroupName):
3302         (currentBuilderGroup):
3303         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3304         (platformAndBuildType):
3305         * TestResultServer/static-dashboards/loader.js:
3306         (.):
3307
3308 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
3309
3310         Remove NodeListsNodeData when it's no longer needed
3311         https://bugs.webkit.org/show_bug.cgi?id=107074
3312
3313         Reviewed by Darin Adler.
3314
3315         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
3316
3317         * Scripts/webkitpy/performance_tests/perftest.py:
3318         (PerfTest):
3319
3320 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
3321
3322         Ref test images are upside-down in WebKit2
3323         https://bugs.webkit.org/show_bug.cgi?id=105457
3324
3325         Reviewed by Sam "Speedy" Weinig.
3326         
3327         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
3328         from the window snapshot contained a flipped copy of the image, causing all ref
3329         and pixel images to be upside-down.
3330
3331         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3332         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3333
3334 2013-01-17  Timothy Loh  <timloh@google.com>
3335
3336         Replaced specifiers variable with is_debug in builders.py
3337         https://bugs.webkit.org/show_bug.cgi?id=107057
3338
3339         Reviewed by Dirk Pranke.
3340
3341         Replaced specifiers variable with is_debug in builders.py to simplify
3342         Bug 106259. The other specifiers are not used elsewhere in the code.
3343         Fixed builder_name_for_port_name to return a debug builder if we don't
3344         have a release builder.
3345
3346         * Scripts/webkitpy/layout_tests/port/builders.py:
3347         (all_port_names):
3348         (builder_name_for_port_name):
3349         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3350         (TestRebaselineExpectations.test_rebaseline_expectations):
3351
3352 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
3353
3354         [GTK] Build with LevelDB when IndexedDB is enabled
3355         https://bugs.webkit.org/show_bug.cgi?id=103220
3356
3357         Reviewed by Gustavo Noronha Silva.
3358
3359         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
3360         as it does not conform to WebKit style.
3361
3362 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3363
3364         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
3365         https://bugs.webkit.org/show_bug.cgi?id=107119
3366
3367         Reviewed by Laszlo Gombos.
3368
3369         Do not use ASSERT on ecore_evas_init(), since the expression inside
3370         the macro compiles out of release builds.
3371
3372         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
3373         * TestWebKitAPI/efl/PlatformWebView.cpp:
3374         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
3375
3376 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
3377
3378         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
3379         https://bugs.webkit.org/show_bug.cgi?id=104545
3380
3381         Reviewed by Yury Semikhatsky.
3382
3383         Adopt signature changes.
3384
3385         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3386         (ProfilerAgent.getCPUProfile): Renamed.
3387         (ProfilerAgent.getHeapSnapshot): Added.
3388
3389 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
3390
3391         [GTK][EFL] NWRT should check that Xvfb is installed
3392         https://bugs.webkit.org/show_bug.cgi?id=71767
3393
3394         Reviewed by Dirk Pranke.
3395
3396         EFL and GTK ports now check that Xvfb is installed before running
3397         layout tests. The command line used to check whether Xvfb is present
3398         is a simple `which Xvfb` that should return 0 as the exit code upon
3399         success.
3400
3401         * Scripts/webkitpy/layout_tests/port/efl.py:
3402         (EflPort.show_results_html_file):
3403         (EflPort):
3404         (EflPort.check_sys_deps):
3405         * Scripts/webkitpy/layout_tests/port/gtk.py:
3406         (GtkPort.check_sys_deps):
3407         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3408         (XvfbDriver):
3409         (XvfbDriver.check_xvfb):
3410
3411 2013-01-16  Alan Cutter  <alancutter@chromium.org>
3412
3413         sheriffbot can't tell me who "kov" is
3414         https://bugs.webkit.org/show_bug.cgi?id=106184
3415
3416         Reviewed by Eric Seidel.
3417
3418         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
3419
3420         * Scripts/webkitpy/common/config/committers.py:
3421         (Account.matches_glob):
3422         (CommitterList.contributors_by_search_string):
3423         * Scripts/webkitpy/common/config/committers_unittest.py:
3424         (CommittersTest.test_committer_lookup):
3425         * Scripts/webkitpy/tool/bot/irc_command.py:
3426         (Whois):
3427
3428 2013-01-16  David Kilzer  <ddkilzer@apple.com>
3429
3430         Use xcrun to find path to make for Mac port
3431         <http://webkit.org/b/107091>
3432
3433         Reviewed by Dan Bernstein.
3434
3435         * Scripts/webkitpy/layout_tests/port/mac.py:
3436         (MacPort._build_java_test_support): Call self.make_command().
3437         (MacPort.make_command): Add.  Call xcrun_find().
3438         (MacPort.nm_command): Use self.xcrun_find().
3439         (MacPort.xcrun_find): Add.  Extract from nm_command().
3440
3441 2013-01-16  Sam Weinig  <sam@webkit.org>
3442
3443         Make debug-safari --target-web-process work again
3444         https://bugs.webkit.org/show_bug.cgi?id=107088
3445
3446         Reviewed by Anders Carlsson.
3447
3448         * Scripts/webkitdirs.pm:
3449         (execMacWebKitAppForDebugging):
3450         The shim is now called SecItemShim.
3451
3452 2013-01-16  Alan Cutter  <alancutter@chromium.org>
3453
3454         GCE build scripts don't take working directory into account when calling findzone.sh
3455         https://bugs.webkit.org/show_bug.cgi?id=106962
3456
3457         Reviewed by Adam Barth.
3458
3459         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3460         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3461         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3462
3463 2013-01-16  Alan Cutter  <alancutter@chromium.org>
3464
3465         start-queue.sh does not pass remaining parameters correctly
3466         https://bugs.webkit.org/show_bug.cgi?id=107054
3467
3468         Reviewed by Adam Barth.
3469
3470         start-queue.sh now passes all remaining params to the webkit-patch command.
3471         Previously only one additional queue parameter could be sent.
3472
3473         * EWSTools/start-queue.sh:
3474
3475 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
3476
3477         check-webkit-style script cannot running in Chinese windows.
3478         https://bugs.webkit.org/show_bug.cgi?id=87548
3479
3480         Reviewed by Darin Adler.
3481
3482         * Scripts/webkitpy/common/system/platforminfo.py:
3483         (PlatformInfo._win_version_tuple_from_cmd):
3484
3485 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
3486
3487         Delete an extraneous print statement.
3488         https://bugs.webkit.org/show_bug.cgi?id=106562
3489
3490         Delete the extraneous print statement introduced in r139841.
3491
3492         * Scripts/webkitpy/layout_tests/views/printing.py:
3493         (Printer.print_found):
3494
3495 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
3496
3497         Please reinstate --pixel
3498         https://bugs.webkit.org/show_bug.cgi?id=101995
3499
3500         Reviewed by Dirk Pranke.
3501
3502         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
3503         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
3504         Some developers are still used to these options that were available in the ORWT.
3505
3506         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3507         (parse_args):
3508
3509 2013-01-16  Eric Seidel  <eric@webkit.org>
3510
3511         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
3512         https://bugs.webkit.org/show_bug.cgi?id=99512
3513
3514         Reviewed by Darin Adler.
3515
3516         * Scripts/run-sunspider:
3517
3518 2013-01-16  Eric Seidel  <eric@webkit.org>
3519
3520         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
3521         https://bugs.webkit.org/show_bug.cgi?id=106036
3522
3523         Reviewed by Darin Adler.
3524
3525         * Scripts/webkitpy/webkitpy.pyproj: Removed.
3526         * Scripts/webkitpy/webkitpy.sln: Removed.
3527
3528 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
3529
3530         [Chromium] Remove hardcoded chromium_*.jar in gyp files
3531         https://bugs.webkit.org/show_bug.cgi?id=104049
3532
3533         Reviewed by Eric Seidel.
3534
3535         Targets with dependencies (direct/indirect) on a java target receive
3536         the chromium_*.jar paths in the variable input_jars_paths. Targets
3537         should use that rather than hardcoding where they think the jar will
3538         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
3539         than as --jars to generate_native_test.py.
3540
3541         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3542         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3543
3544 2013-01-16  Dan Carney  <dcarney@google.com>
3545
3546         [chromium] move setMockDeviceOrientation to TestRunner library
3547         https://bugs.webkit.org/show_bug.cgi?id=106895
3548
3549         Reviewed by Jochen Eisinger.
3550
3551         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3552         (DRTTestRunner::DRTTestRunner):
3553         * DumpRenderTree/chromium/DRTTestRunner.h:
3554         (DRTTestRunner):
3555         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3556         (WebKit):
3557         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
3558         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3559         (WebTestRunner::TestRunner::TestRunner):
3560         (WebTestRunner::TestRunner::setMockDeviceOrientation):
3561         (WebTestRunner):
3562         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3563         (TestRunner):
3564         * DumpRenderTree/chromium/WebViewHost.cpp:
3565         (WebViewHost::setDeviceOrientation):
3566         * DumpRenderTree/chromium/WebViewHost.h:
3567         (WebViewHost):
3568
3569 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
3570
3571         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
3572         https://bugs.webkit.org/show_bug.cgi?id=106904
3573
3574         Reviewed by Adam Barth.
3575
3576         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3577         (DRTTestRunner::DRTTestRunner):
3578         (DRTTestRunner::notifyDone):
3579         (DRTTestRunner::reset):
3580         * DumpRenderTree/chromium/DRTTestRunner.h:
3581         (DRTTestRunner):
3582         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3583         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
3584         (WebTestRunner::WebTestDelegate::setFocus):
3585         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
3586         (WebTestRunner::WebTestDelegate::pathToLocalResource):
3587         (WebTestRunner::WebTestDelegate::setLocale):
3588         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3589         (WebTestRunner::TestRunner::TestRunner):
3590         (WebTestRunner::TestRunner::reset):
3591         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
3592         (WebTestRunner):
3593         (WebTestRunner::TestRunner::setWindowIsKey):
3594         (WebTestRunner::TestRunner::pathToLocalResource):
3595         (WebTestRunner::TestRunner::setBackingScaleFactor):
3596         (WebTestRunner::TestRunner::setPOSIXLocale):
3597         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3598         (WebTestRunner::TestRunner::taskList):
3599         (TestRunner):
3600         * DumpRenderTree/chromium/WebViewHost.cpp:
3601         (WebViewHost::setDeviceScaleFactor):
3602         (WebViewHost::setFocus):
3603         (WebViewHost::setAcceptAllCookies):
3604         (WebViewHost::pathToLocalResource):
3605         (WebViewHost::setLocale):
3606         * DumpRenderTree/chromium/WebViewHost.h:
3607         (WebViewHost):
3608
3609 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
3610
3611         [GTK] build-webkit fails if the jhbuild wrapper is not used
3612         https://bugs.webkit.org/show_bug.cgi?id=106769
3613
3614         Reviewed by Martin Robinson.
3615
3616         Return an empty array instead of "" in
3617         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
3618         will not be recognized as a valid command when the returned array
3619         is directly passed to perl's system() call.
3620
3621         * Scripts/webkitdirs.pm:
3622         (jhbuildWrapperPrefixIfNeeded):
3623
3624 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
3625
3626         [chromium] add title text direction attribute to TestRunner
3627         https://bugs.webkit.org/show_bug.cgi?id=106907
3628
3629         Reviewed by Adam Barth.
3630
3631         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3632         (DRTTestRunner::DRTTestRunner):
3633         (DRTTestRunner::reset):
3634         * DumpRenderTree/chromium/DRTTestRunner.h:
3635         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3636         (WebTestRunner::WebTestRunner::setTitleTextDirection):
3637         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3638         (WebTestRunner::TestRunner::TestRunner):
3639         (WebTestRunner::TestRunner::reset):
3640         (WebTestRunner::TestRunner::setTitleTextDirection):
3641         (WebTestRunner):
3642         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3643         (TestRunner):
3644         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3645         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3646         * DumpRenderTree/chromium/WebViewHost.cpp:
3647         (WebViewHost::didReceiveTitle):
3648
3649 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
3650
3651         NRWT still confused about test count with --repeat-each and --iterations
3652         https://bugs.webkit.org/show_bug.cgi?id=106562
3653
3654         Reviewed by Dirk Pranke.
3655
3656         Fix the printed unique test count and skipped count. This
3657         seems to have broken in r127688 ("NRWT lies about the number
3658         of tests that it's skipping when used with --repeat-each").
3659
3660         Also add a test for print_found()
3661
3662         * Scripts/webkitpy/layout_tests/views/printing.py:
3663         (Printer.print_found):
3664         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3665         (Testprinter.test_details):
3666         (Testprinter):
3667         (Testprinter.test_found):
3668
3669 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
3670
3671         Unreviewed follow-up to r139769.
3672
3673         Note that omitting the WebKit1 code from the build now
3674         works for GTK as well.
3675
3676         * Scripts/build-webkit:
3677
3678 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
3679
3680         test-webkitpy: truncate output to the terminal width when necessary
3681         https://bugs.webkit.org/show_bug.cgi?id=106973
3682
3683         Reviewed by Ojan Vafai.
3684
3685         this implements the same logic for test-webkitpy that we have
3686         for run-webkit-tests (and ninja).
3687
3688         No tests written as this is exercised by running test-webkitpy itself.
3689
3690         * Scripts/webkitpy/test/printer.py:
3691         (Printer.configure):
3692         (Printer._test_line):
3693
3694 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
3695
3696         remove extraneous output in test-webkitpy
3697         https://bugs.webkit.org/show_bug.cgi?id=106971
3698
3699         Reviewed by Ojan Vafai.
3700
3701         We weren't ignoring or capturing the echoed output from
3702         these two tests, and getting noise in the logs as a result.
3703
3704         * Scripts/webkitpy/common/system/executive_unittest.py:
3705         (ExecutiveTest.test_auto_stringify_args):
3706         (ExecutiveTest.test_popen_args):
3707
3708 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
3709
3710         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
3711         https://bugs.webkit.org/show_bug.cgi?id=106974
3712
3713         Reviewed by Ryosuke Niwa.
3714
3715         I forgot to stub out the call to check to ensure that the ports were
3716         available, so this test could fail if something was listening on 8000 or
3717         8443 on the machine.
3718
3719         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3720         (TestHttpServer.test_win32_start_and_stop):
3721
3722 2013-01-15  Levi Weintraub  <leviw@chromium.org>
3723
3724         Unreviewed, rolling out r139792.
3725         http://trac.webkit.org/changeset/139792
3726         https://bugs.webkit.org/show_bug.cgi?id=106970
3727
3728         Broke the windows build.
3729
3730         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3731         (DRTTestRunner::DRTTestRunner):
3732         (DRTTestRunner::notifyDone):
3733         (DRTTestRunner::reset):
3734         (DRTTestRunner::setAlwaysAcceptCookies):
3735         (DRTTestRunner::setWindowIsKey):
3736         (DRTTestRunner::pathToLocalResource):
3737         (DRTTestRunner::setPOSIXLocale):
3738         (InvokeCallbackTask):
3739         (InvokeCallbackTask::InvokeCallbackTask):
3740         (InvokeCallbackTask::runIfValid):
3741         (DRTTestRunner::setBackingScaleFactor):
3742         * DumpRenderTree/chromium/DRTTestRunner.h:
3743         (DRTTestRunner):
3744         (DRTTestRunner::taskList):
3745         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3746         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
3747         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3748         (WebTestRunner::TestRunner::TestRunner):
3749         (WebTestRunner::TestRunner::reset):
3750         (WebTestRunner::TestRunner::setDatabaseQuota):
3751         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3752         (TestRunner):
3753         * DumpRenderTree/chromium/WebViewHost.cpp:
3754         (WebViewHost::setPendingExtraData):
3755         (WebViewHost::setDeviceScaleFactor):
3756         * DumpRenderTree/chromium/WebViewHost.h:
3757         (WebViewHost):
3758
3759 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
3760
3761         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
3762
3763         * Scripts/webkitpy/common/config/ports.py:
3764         (MacWK2Port):
3765
3766 2013-01-15  Alan Cutter  <alancutter@chromium.org>
3767
3768         Extend sheriffbot's "help" command to be able to get help on individual commands
3769         https://bugs.webkit.org/show_bug.cgi?id=106629
3770
3771         Reviewed by Eric Seidel.
3772
3773         Added a help command to sheriffbot.
3774         Fixed some style issues and ordered the commands alphabetically.
3775
3776         * Scripts/webkitpy/tool/bot/irc_command.py:
3777         (IRCCommand):
3778         (IRCCommand.execute):
3779         (IRCCommand.usage):
3780         (IRCCommand.help):
3781         (CreateBug):
3782         (CreateBug.execute):
3783         (Help):
3784         (Help.execute):
3785         (Help._post_command_help):
3786         (Hi):
3787         (Hi.execute):
3788         (Restart):
3789         (RollChromiumDEPS):
3790         (RollChromiumDEPS._parse_args):
3791         (RollChromiumDEPS._expand_irc_nickname):
3792         (RollChromiumDEPS.execute):
3793         (Rollout):
3794         (Rollout._extract_revisions):
3795         (Rollout.execute):
3796         (Sheriffs):
3797         (Sheriffs.execute):
3798         (Whois):
3799         (Whois.execute):
3800         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3801         (IRCBotTest.test_help):
3802
3803 2013-01-15  Enrica Casucci  <enrica@apple.com>
3804
3805         Add a new set of WebKit2 APIs for text search and
3806         search results management.
3807         https://bugs.webkit.org/show_bug.cgi?id=106834.
3808         <rdar://problem/12597159>
3809
3810         Added new test for the new WebKit2 API for
3811         text search.
3812         
3813         Reviewed by Simon Fraser.
3814
3815         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3816         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
3817
3818 2013-01-15  Levi Weintraub  <leviw@chromium.org>
3819
3820         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
3821         https://bugs.webkit.org/show_bug.cgi?id=106904
3822
3823         Reverting 139794. It broke the build. It appears that a header file,
3824         WebTextDirection.h, was left out.
3825
3826         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3827         (DRTTestRunner::DRTTestRunner):
3828         (DRTTestRunner::reset):
3829         * DumpRenderTree/chromium/DRTTestRunner.h:
3830         (DRTTestRunner::setTitleTextDirection):
3831         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3832         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
3833         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3834         (WebTestRunner::TestRunner::TestRunner):
3835         (WebTestRunner::TestRunner::reset):
3836         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
3837         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3838         (TestRunner):
3839         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3840         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3841         * DumpRenderTree/chromium/WebViewHost.cpp:
3842         (WebViewHost::didReceiveTitle):
3843
3844 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
3845
3846         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
3847         https://bugs.webkit.org/show_bug.cgi?id=106904
3848
3849         Reviewed by Adam Barth.
3850
3851         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3852         (DRTTestRunner::DRTTestRunner):
3853         (DRTTestRunner::notifyDone):
3854         (DRTTestRunner::reset):
3855         * DumpRenderTree/chromium/DRTTestRunner.h:
3856         (DRTTestRunner):
3857         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3858         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
3859         (WebTestRunner::WebTestDelegate::setFocus):
3860         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
3861         (WebTestRunner::WebTestDelegate::pathToLocalResource):
3862         (WebTestRunner::WebTestDelegate::setLocale):
3863         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3864         (WebTestRunner::TestRunner::TestRunner):
3865         (WebTestRunner::TestRunner::reset):
3866         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
3867         (WebTestRunner):
3868         (WebTestRunner::TestRunner::setWindowIsKey):
3869         (WebTestRunner::TestRunner::pathToLocalResource):
3870         (WebTestRunner::TestRunner::setBackingScaleFactor):
3871         (WebTestRunner::TestRunner::setPOSIXLocale):
3872         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3873         (WebTestRunner::TestRunner::taskList):
3874         (TestRunner):
3875         * DumpRenderTree/chromium/WebViewHost.cpp:
3876         (WebViewHost::setDeviceScaleFactor):
3877         (WebViewHost::setFocus):
3878         (WebViewHost::setAcceptAllCookies):
3879         (WebViewHost::pathToLocalResource):
3880         (WebViewHost::setLocale):
3881         * DumpRenderTree/chromium/WebViewHost.h:
3882         (WebViewHost):
3883
3884 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
3885
3886         Tests with WontFix expectation are (indirectly) skipped
3887         https://bugs.webkit.org/show_bug.cgi?id=105860
3888
3889         Reviewed by Dirk Pranke.
3890
3891         Only skip the WontFix expectation if there are no other layout test
3892         expectations (like Failure, ImageOnlyFailure) listed for the test.
3893         This makes it possible to run an expected failure for which there
3894         is no reason or interest to fix. There are some ports that would like
3895         to exercise this behavior as well as specific test cases that should use
3896         such expectations.
3897
3898         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3899         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
3900         WONTFIX test if there are no expectations listed. The warning is adjusted
3901         to reflect the new behavior.
3902         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
3903         and adjust test cases for these changes.
3904         (ExpectationSyntaxTests.test_wontfix):
3905         (SemanticTests.test_skip_and_wontfix):
3906
3907 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
3908
3909         [chromium] add title text direction attribute to TestRunner
3910         https://bugs.webkit.org/show_bug.cgi?id=106907
3911
3912         Reviewed by Adam Barth.
3913
3914         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3915         (DRTTestRunner::DRTTestRunner):
3916         (DRTTestRunner::reset):
3917         * DumpRenderTree/chromium/DRTTestRunner.h:
3918         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3919         (WebTestRunner::WebTestRunner::setTitleTextDirection):
3920         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3921         (WebTestRunner::TestRunner::TestRunner):
3922         (WebTestRunner::TestRunner::reset):
3923         (WebTestRunner::TestRunner::setTitleTextDirection):
3924         (WebTestRunner):
3925         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3926         (TestRunner):
3927         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3928         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3929         * DumpRenderTree/chromium/WebViewHost.cpp:
3930         (WebViewHost::didReceiveTitle):
3931
3932 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
3933
3934         nrwt: change the default # of locked shards on chromium_win to 1
3935         https://bugs.webkit.org/show_bug.cgi?id=106938
3936
3937         Reviewed by Eric Seidel.
3938
3939         It looks like LigHTTPd might be buggy or unstable if we are
3940         running multiple http tests in parallel; see
3941         http://code.google.com/p/chromium/issues/detail?id=169530 for more
3942         context as well. This change will stop running http tests in parallel
3943         and we can see if this fixes things.
3944
3945         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3946         (ChromiumWinPort.default_max_locked_shards):
3947         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3948         (ChromiumWinTest.test_path_to_image_diff):
3949         (ChromiumWinTest):
3950         (ChromiumWinTest.test_default_max_locked_shards):
3951
3952 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
3953
3954         [chromium] move WebDatabase related methods to TestRunner library
3955         https://bugs.webkit.org/show_bug.cgi?id=106905
3956
3957         Reviewed by Adam Barth.
3958
3959         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3960         (DRTTestRunner::DRTTestRunner):
3961         (DRTTestRunner::reset):
3962         * DumpRenderTree/chromium/DRTTestRunner.h:
3963         (DRTTestRunner):
3964         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3965         (WebTestRunner::WebTestDelegate::clearAllDatabases):
3966         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
3967         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3968         (WebTestRunner::TestRunner::TestRunner):
3969         (WebTestRunner::TestRunner::reset):
3970         (WebTestRunner::TestRunner::clearAllDatabases):
3971         (WebTestRunner):
3972         (WebTestRunner::TestRunner::setDatabaseQuota):
3973         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3974         (TestRunner):
3975         * DumpRenderTree/chromium/WebViewHost.cpp:
3976         (WebViewHost::clearAllDatabases):
3977         (WebViewHost::setDatabaseQuota):
3978         * DumpRenderTree/chromium/WebViewHost.h:
3979         (WebViewHost):
3980
3981 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
3982
3983         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
3984         functionality match the name.
3985         https://bugs.webkit.org/show_bug.cgi?id=106870
3986
3987         Reviewed by Adam Barth.
3988
3989         * Scripts/webkitpy/tool/commands/download.py:
3990         (Clean):
3991         (Update):
3992         (Build):
3993         (BuildAndTest):
3994         (CheckStyle):
3995         (BuildAttachment):
3996         (BuildAndTestAttachment):
3997         (AbstractPatchApplyingCommand):
3998         (ApplyWatchList):
3999         (AbstractPatchLandingCommand):
4000         (CreateRollout):
4001         * Scripts/webkitpy/tool/steps/__init__.py:
4002         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4003         (CleanWorkingDirectory.options):
4004         (CleanWorkingDirectory.run):
4005         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
4006         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
4007         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
4008
4009 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
4010
4011         [Autotools] Add support for WebKit2-only builds
4012         https://bugs.webkit.org/show_bug.cgi?id=106889
4013
4014         Reviewed by Gustavo Noronha Silva.
4015
4016         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
4017         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
4018         building the GTK port through build-webkit.
4019         * Scripts/webkitdirs.pm:
4020         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
4021         arguments when not building WebKit1.
4022         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
4023         through the Autotools build system.
4024
4025 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
4026
4027         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
4028         https://bugs.webkit.org/show_bug.cgi?id=106197
4029
4030         Reviewed by Martin Robinson.
4031
4032         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
4033         features. Enable them on GTK, meaning they will be enabled in development builds
4034         (i.e. when building with build-webkit).
4035
4036 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
4037
4038         [GTK] Enable CSS Image Resolution feature
4039         https://bugs.webkit.org/show_bug.cgi?id=99038
4040
4041         Reviewed by Gustavo Noronha Silva.
4042
4043         Enable the CSS Image Resolution feature for the development
4044         builds of the GTK port.
4045
4046         * Scripts/webkitperl/FeatureList.pm:
4047
4048 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
4049
4050         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
4051         https://bugs.webkit.org/show_bug.cgi?id=106579
4052
4053         Reviewed by Gustavo Noronha Silva.
4054
4055         The --enable-unstable-features flag is not required to be passed anymore
4056         to the configure script as it was removed in r138252.
4057
4058         * Scripts/webkitdirs.pm:
4059         (buildAutotoolsProject):
4060
4061 2013-01-15  Tony Chang  <tony@chromium.org>
4062
4063         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
4064
4065         * Scripts/webkitpy/layout_tests/servers/http_server.py:
4066         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
4067         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
4068         (TestHttpServer.test_win32_start_and_stop):
4069
4070 2013-01-15  Joshua Bell  <jsbell@chromium.org>
4071
4072         Unreviewed. Adding Michael Pruett as contributor.
4073
4074         * Scripts/webkitpy/common/config/committers.py:
4075
4076 2013-01-15  Victor Carbune  <victor@rosedu.org>
4077
4078         Unreviewed. Update my email addresses.
4079
4080         * Scripts/webkitpy/common/config/committers.py:
4081
4082 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
4083
4084         [GTK] Waiting on the gdb process will lead to deadlock
4085         https://bugs.webkit.org/show_bug.cgi?id=106906
4086
4087         Reviewed by Philippe Normand.
4088
4089         Use communicate() rather than wait() on the Popen object that's running the gdb
4090         command. This avoids the deadlock that occurs on the GTK builders.
4091
4092         * Scripts/webkitpy/layout_tests/port/gtk.py:
4093         (GtkPort._get_gdb_output):
4094
4095 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
4096
4097         [GTK] Limit the number of frames printed out when backtracing with gdb
4098         https://bugs.webkit.org/show_bug.cgi?id=106901
4099
4100         Reviewed by Philippe Normand.
4101
4102         Printing an unlimited number of frames when dumping the gdb backtracing
4103         output can cause timeouts in the builders. This patch limits the number
4104         of frames that are printed out to 1024.
4105
4106         * Scripts/webkitpy/layout_tests/port/gtk.py:
4107         (GtkPort._get_gdb_output):
4108
4109 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
4110
4111         [Qt] Fix ImageDiff's image format conversion
4112         https://bugs.webkit.org/show_bug.cgi?id=106880
4113
4114         Reviewed by Csaba Osztrogonác.
4115
4116         Besides actually doing the conversion this also silences the suspicious warning:
4117         "ignoring return value of function declared with warn_unused_result attribute".
4118
4119         * ImageDiff/qt/ImageDiff.cpp:
4120         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
4121         copy of the image in the given format and does not alter the image itself.
4122
4123 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
4124
4125         [chromium] move remaining methods that just set a boolean flag to TestRunner library
4126         https://bugs.webkit.org/show_bug.cgi?id=106823
4127
4128         Reviewed by Darin Fisher.
4129
4130         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4131         (DRTTestRunner::DRTTestRunner):
4132         (DRTTestRunner::reset):
4133         * DumpRenderTree/chromium/DRTTestRunner.h:
4134         (DRTTestRunner):
4135         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
4136         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
4137         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
4138         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
4139         (WebTestRunner::WebTestRunner::testRepaint):
4140         (WebTestRunner::WebTestRunner::sweepHorizontally):
4141         (WebTestRunner::WebTestRunner::isPrinting):
4142         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
4143         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4144         (WebTestRunner::TestRunner::TestRunner):
4145         (WebTestRunner::TestRunner::reset):
4146         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
4147         (WebTestRunner):
4148         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
4149         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
4150         (WebTestRunner::TestRunner::testRepaint):
4151         (WebTestRunner::TestRunner::sweepHorizontally):
4152         (WebTestRunner::TestRunner::isPrinting):
4153         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
4154         (WebTestRunner::TestRunner::dumpBackForwardList):
4155         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
4156         (WebTestRunner::TestRunner::dumpSelectionRect):
4157         (WebTestRunner::TestRunner::repaintSweepHorizontally):
4158         (WebTestRunner::TestRunner::setPrinting):
4159         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
4160         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4161         (TestRunner):
4162
4163 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
4164
4165         nrwt: stub out show_results_html for mock ports
4166         https://bugs.webkit.org/show_bug.cgi?id=106848
4167
4168         Reviewed by Ojan Vafai.
4169
4170         We were accidentally using the underlying ports'
4171         show_results_html_file() implementation, which would, unsurprisingly,
4172         fail in many cases (e.g., running mock-efl on the mac).
4173
4174         No test added since we don't generally add tests for the mock
4175         implementation.
4176
4177         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
4178         (MockDRTPort.show_results_html_file):
4179
4180 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
4181
4182         Changing clean_working_directory/clean_local_commits and related
4183         functions to have consistent naming.
4184
4185         https://bugs.webkit.org/show_bug.cgi?id=104198
4186
4187         Reviewed by Adam Barth.
4188
4189         * Scripts/webkitpy/common/checkout/scm/git.py:
4190         * Scripts/webkitpy/common/checkout/scm/scm.py:
4191         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
4192         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4193         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4194         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
4195
4196 2013-01-14  Alan Cutter  <alancutter@chromium.org>
4197
4198         Fix EWS GCE build scripts to detect which zone is available
4199         https://bugs.webkit.org/show_bug.cgi?id=106524
4200
4201         Reviewed by Adam Barth.
4202
4203         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
4204         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
4205         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
4206         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
4207
4208 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
4209
4210         Adding an error string to AmbiguousCommitError.
4211         https://bugs.webkit.org/show_bug.cgi?id=106846
4212
4213         Reviewed by Adam Barth.
4214
4215         * Scripts/webkitpy/common/checkout/scm/git.py:
4216         (AmbiguousCommitError.__init__):
4217
4218 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
4219
4220         kill whole lighttpd process tree for chromium win
4221         https://bugs.webkit.org/show_bug.cgi?id=106838
4222
4223         Reviewed by Tony Chang.
4224
4225         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
4226         I think a test is causing a httpd server child process to wedge and
4227         killing the parent httpd server process isn't sufficient to ensure
4228         that the children are also killed.
4229
4230         * Scripts/webkitpy/layout_tests/servers/http_server.py:
4231         (Lighttpd._check_and_kill):
4232         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
4233         (TestHttpServer.test_start_cmd):
4234         (TestHttpServer):
4235         (TestHttpServer.test_win32_start_and_stop):
4236         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
4237         (TestHttpServer.test_win32_start_and_stop.mock_returns):
4238         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
4239
4240 2013-01-14  Nico Weber  <thakis@chromium.org>
4241
4242         [chromium] Enable `update-webkit --chromium --ninja` on windows
4243         https://bugs.webkit.org/show_bug.cgi?id=106836
4244
4245         Reviewed by Eric Seidel.
4246
4247         After running this, build-webkit --chromium will use ninja to build.
4248         Apparently there are some minor issues with that still, so it's
4249         not quite ready for use yet.
4250
4251         * Scripts/webkitdirs.pm:
4252         (determineIsChromiumNinja):
4253         (buildChromium):
4254
4255 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
4256
4257         nrwt: use the same search path for baselines and TestExpectations on apple mac
4258         https://bugs.webkit.org/show_bug.cgi?id=105599
4259
4260         Reviewed by Ryosuke Niwa.
4261
4262         Bug 105583 revealed some confusion due to the fact that the Apple
4263         Mac port used a different list of directories to search for baselines
4264         and TestExpectations files (actually, pretty much every port does).
4265
4266         It seems like a good idea to use the same list for both by default, but
4267         making this happen will affect every port in slightly different ways, so
4268         we'll try this on the Apple Mac port first.
4269
4270         Note that the effective changes for this are that:
4271         1) The apple mac port will look in platform/wk2 for baselines where
4272         it didn't before (it will look after looking in mac-wk2 but before
4273         the non-wk2 dirs)
4274         2) The apple mac-snowleopard port will use the expectations in
4275         mac-lion as well as the expectations in mac-snowleopard, although
4276         I'm not even sure if mac-snowleopard is still supported ...
4277
4278         * Scripts/webkitpy/layout_tests/port/mac.py:
4279         (MacPort.default_baseline_search_path):
4280         (MacPort.expectations_files):
4281         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4282         (test_baseline_search_path):
4283
4284 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
4285
4286         AX: Need to implement ColorWellRole
4287         https://bugs.webkit.org/show_bug.cgi?id=106756
4288
4289         Reviewed by Chris Fleizach.
4290
4291         Returns a string representation of the value of a color
4292         when the role is Color Well, to make it easy to write layout
4293         tests for color controls.
4294
4295         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
4296
4297 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
4298
4299         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
4300         https://bugs.webkit.org/show_bug.cgi?id=106682
4301
4302         Reviewed by Chris Fleizach.
4303
4304         Modify Chromium's DRT implementation of intValue to return a
4305         different value depending on the role.
4306
4307         There are actually platform-specific differences in what should
4308         be returned in the "value" of an object, so Chromium normally keeps
4309         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
4310         but this is a fine simplification to make cross-platform tests easier.
4311
4312         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
4313         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
4314
4315 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
4316
4317         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
4318         https://bugs.webkit.org/show_bug.cgi?id=106785
4319
4320         Reviewed by Adam Barth.
4321
4322         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4323         (DRTTestRunner::DRTTestRunner):
4324         (DRTTestRunner::reset):
4325         * DumpRenderTree/chromium/DRTTestRunner.h:
4326         (DRTTestRunner):
4327         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4328         (WebTestProxyBase):
4329         (WebTestRunner::WebTestProxy::setStatusText):
4330         (WebTestRunner::WebTestProxy::didStopLoading):
4331         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
4332         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
4333         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
4334         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4335         (WebTestRunner::TestRunner::TestRunner):
4336         (WebTestRunner::TestRunner::reset):
4337         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
4338         (WebTestRunner):
4339         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
4340         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
4341         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
4342         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4343         (TestRunner):
4344         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4345         (WebTestRunner::WebTestProxyBase::setStatusText):
4346         (WebTestRunner):
4347         (WebTestRunner::WebTestProxyBase::didStopLoading):
4348         * DumpRenderTree/chromium/WebViewHost.cpp:
4349         (WebViewHost::didStopLoading):
4350         * DumpRenderTree/chromium/WebViewHost.h:
4351         (WebViewHost):
4352
4353 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
4354
4355         Web Inspector: devtools front-end doesn't have focus in TestShell