39acac8c36976758899a67ee21dcf14304519039
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
2
3         Unreviewed, mac DumpRenderTree fix.
4
5         * DumpRenderTree/mac/UIDelegate.mm:
6         (-[UIDelegate webView:addMessageToConsole:withSource:]):
7
8 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
9
10         WebKitTestRunner should not print console message line number when it is equal to zero.
11         https://bugs.webkit.org/show_bug.cgi?id=76167
12
13         Reviewed by Csaba Osztrogonác.
14
15         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
16         (WTR::InjectedBundlePage::willAddMessageToConsole):
17
18 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
19
20         Make default console messages line numbers consistent.
21         https://bugs.webkit.org/show_bug.cgi?id=74075
22
23         Reviewed by Pavel Feldman.
24
25         Unset line numbers are not printed to console now.
26         Added Source/WebCore/inspector to efl DumpRenderTree include path.
27
28         * DumpRenderTree/chromium/WebViewHost.cpp:
29         (WebViewHost::didAddMessageToConsole):
30         * DumpRenderTree/efl/CMakeLists.txt:
31         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
32         (onConsoleMessage):
33         * DumpRenderTree/gtk/DumpRenderTree.cpp:
34         (webViewConsoleMessage):
35         * DumpRenderTree/mac/UIDelegate.mm:
36         (-[UIDelegate webView:addMessageToConsole:withSource:]):
37         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
38         (WebCore::WebPage::javaScriptConsoleMessage):
39         * DumpRenderTree/win/UIDelegate.cpp:
40         (UIDelegate::webViewAddMessageToConsole):
41         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
42         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
43
44 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
45
46         test-webkitpy: push more logic into webkitpy.test.main, clean up code
47         https://bugs.webkit.org/show_bug.cgi?id=76021
48
49         Reviewed by Eric Seidel.
50
51         I plan to add more functionality to test-webkitpy, but it is
52         difficult to hack on now; this patch is the first of two that
53         brings test-webkitpy more inline with current coding style by
54         pushing more logic into the webkitpy.test.main.Tester class (so
55         that it will be testable itself).
56         
57         There should be no functional changes in this patch.
58
59         * Scripts/test-webkitpy:
60         (_path_from_webkit_root):
61         * Scripts/webkitpy/test/main.py:
62         (Tester):
63         (Tester.init):
64         (Tester.configure_logging):
65         (Tester.configure_logging.filter):
66         (Tester.clean_packages):
67         (Tester.run_tests):
68
69 2012-01-11  Wei Jia  <wjia@chromium.org>
70
71         implement layout tests for <video> with media stream
72         https://bugs.webkit.org/show_bug.cgi?id=74882
73
74         Reviewed by Kent Tamura.
75
76         * DumpRenderTree/DumpRenderTree.gypi:
77         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
78         (WebKit::WebUserMediaClientMock::create):
79         (WebKit::WebUserMediaClientMock::IsMockStream):
80         (WebKit::WebUserMediaClientMock::requestUserMedia):
81         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
82         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
83         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
84         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
85         * DumpRenderTree/chromium/WebViewHost.cpp:
86         (WebViewHost::userMediaClient):
87         (WebViewHost::userMediaClientMock):
88         (WebViewHost::createMediaPlayer):
89         (WebViewHost::mediaStreamUtil):
90         (WebViewHost::testMediaStreamClient):
91         * DumpRenderTree/chromium/WebViewHost.h:
92
93 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
94
95         Unreviewed, build fix.
96
97         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
98
99         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
100         (ChromiumWinPort.__init__):
101
102 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
103
104         Sheriffbot build fix. Don't emit empty lines on IRC.
105
106         * Scripts/webkitpy/tool/bot/irc_command.py:
107         (LastGreenRevision.execute):
108
109 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
110
111         last-green-revision should report the revision that succeeded on all bots
112         https://bugs.webkit.org/show_bug.cgi?id=76109
113
114         Reviewed by Adam Barth.
115
116         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
117         considered green by this algorithm, all matching builders must have a successful run at the revision
118         or two consecutive successful runs before and after the revision.
119
120         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
121         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
122
123         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
124         (BuildBot._revisions_for_builder):
125         (BuildBot):
126         (BuildBot._find_green_revision):
127         (BuildBot.last_green_revision):
128         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
129         (MockBuildBot.last_green_revision):
130         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
131         (test_revisions_for_builder):
132         (test_find_green_revision):
133         (test_last_green_revision):
134         * Scripts/webkitpy/tool/bot/irc_command.py:
135         (LastGreenRevision.execute):
136         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
137         (SheriffIRCBotTest.test_lgr):
138         * Scripts/webkitpy/tool/commands/queries.py:
139         (LastGreenRevision):
140
141 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
142
143         Unreviewed, fix build bustage on win32 introduced by r104725.
144
145         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
146         (MockDRTPortTest.make_port):
147         (MockChromiumDRTTest.test_pixeltest__fails):
148
149 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
150
151         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
152         https://bugs.webkit.org/show_bug.cgi?id=75618
153
154         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
155
156         Reviewed by Tony Chang.
157
158         * DumpRenderTree/chromium/LayoutTestHelper.mm:
159         (installLayoutTestColorProfile):
160         (restoreUserColorProfile):
161         (main):
162
163 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
164
165         test-webkitpy: fix -v and eliminate some spurious warnings
166         https://bugs.webkit.org/show_bug.cgi?id=76099
167
168         Reviewed by Adam Barth.
169
170         when we added support for --xml output, we broke the -v flag.
171
172         Also, fix the code to swallow a harmless warning from
173         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
174
175         test-webkitpy is now silent again except for the one known
176         logging issue.
177
178         * Scripts/webkitpy/common/checkout/checkout.py:
179         (Checkout.commit_message_for_this_commit):
180         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
181         (test_commit_message_for_this_commit):
182         * Scripts/webkitpy/style/checkers/jsonchecker.py:
183         (JSONChecker.check):
184         (JSONChecker.line_number_from_json_exception):
185         * Scripts/webkitpy/test/main.py:
186         (Tester.run_tests):
187
188 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
189
190         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
191         https://bugs.webkit.org/show_bug.cgi?id=76084
192
193         Reviewed by Adam Barth.
194
195         This will help make it easier to catch layering violations. This
196         change just refactors test code; there are no changes to
197         production code.
198
199         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
200         (PortTest.make_port):
201         (PortTest.test_find_no_paths_specified):
202         (PortTest.test_find_one_test):
203         (PortTest.test_find_glob):
204         (PortTest.test_find_with_skipped_directories):
205         (PortTest.test_find_with_skipped_directories_2):
206         (PortTest.test_parse_reftest_list):
207         (PortTest.test_httpd_returns_error_code):
208         (PortTest.test_virtual_methods):
209         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
210         (ChromiumGpuTest.assert_port_works):
211         (ChromiumGpuTest._assert_baseline_path):
212         (ChromiumGpuTest.test_graphics_type):
213         (ChromiumGpuTest.test_default_tests_paths.test_paths):
214         (ChromiumGpuTest.test_test_files):
215         (ChromiumGpuTest.test_test_files.test_paths):
216         (ChromiumGpuTest):
217         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
218         (ChromiumLinuxPortTest.assert_architecture):
219         (ChromiumLinuxPortTest.test_check_illegal_port_names):
220         (ChromiumLinuxPortTest.test_determine_architecture_fails):
221         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
222         (DriverTest.make_port):
223         (DriverTest):
224         (DriverTest.assertVirtual):
225         (DriverTest._assert_wrapper):
226         (DriverTest.test_virtual_driver_methods):
227         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
228         (MockDRTPortTest.make_port):
229         (MockDRTPortTest.test_port_name_in_constructor):
230         (MockDRTTest.assertTest):
231         (MockDRTTest.test_main):
232         (MockChromiumDRTTest.test_pixeltest__fails):
233         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
234         (QtPortTest._assert_search_path):
235         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
236         (TestWebKitPort.__init__):
237         (WebKitPortUnitTests.test_default_options):
238         (test_runtime_feature_list):
239         (test_test_expectations):
240
241 2012-01-11  Ojan Vafai  <ojan@chromium.org>
242
243         Style skipped tests in the flakiness dashboard
244         https://bugs.webkit.org/show_bug.cgi?id=76091
245
246         Reviewed by Tony Chang.
247
248         * TestResultServer/static-dashboards/dashboard_base.js:
249         Removed "FLAKY" from this list since we don't ever mark individual runs
250         as flaky. Also deleted an outdated line.
251         * TestResultServer/static-dashboards/flakiness_dashboard.html:
252
253 2012-01-11  Ojan Vafai  <ojan@chromium.org>
254
255         Remove gtest normalization code from the test results server
256         https://bugs.webkit.org/show_bug.cgi?id=76089
257
258         Reviewed by Tony Chang.
259
260         The normalization now happens on the gtest side.
261
262         * TestResultServer/model/jsonresults.py:
263         (JsonResults.merge):
264         * TestResultServer/model/jsonresults_unittest.py:
265         (JsonResultsTest.test_gtest):
266
267 2012-01-11  Ojan Vafai  <ojan@chromium.org>
268
269         Be more aggressive about deleting unnecessary results from the test-results-server json files
270         https://bugs.webkit.org/show_bug.cgi?id=76086
271
272         Reviewed by Tony Chang.
273
274         Remove any tests that only contain skip/pass/nodata values whose runtime
275         is less than 5 seconds.
276
277         * TestResultServer/model/jsonresults.py:
278         (JsonResults._normalize_results_json):
279         * TestResultServer/model/jsonresults_unittest.py:
280         (JsonResultsTest.test_merge_remove_test):
281         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
282
283 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
284
285         last-green-revision should give us per-bot information
286         https://bugs.webkit.org/show_bug.cgi?id=76011
287
288         Reviewed by Adam Barth.
289
290         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
291         we report the latest green run on each bot from the last 100 runs.
292
293         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
294         (BuildBot._fetch_builder_page):
295         (BuildBot):
296         (BuildBot._green_revision_for_builder):
297         (BuildBot.last_green_revision):
298         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
299         (test_green_revision_for_builder):
300         (test_last_green_revision):
301         * Scripts/webkitpy/tool/bot/irc_command.py:
302         (LastGreenRevision.execute):
303         * Scripts/webkitpy/tool/commands/queries.py:
304         (LastGreenRevision.execute):
305
306 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
307
308         webkitpy: clean up version detection in webkitpy.layout_tests.port
309         https://bugs.webkit.org/show_bug.cgi?id=76016
310
311         Reviewed by Adam Barth.
312
313         This change updates the code in webkitpy.layout_tests.port to
314         use the new os_name and os_version fields on host.platform. This
315         gets layout_tests.port out of the version parsing business. Most
316         of the diffs are just cleaning up test code to accomodate the
317         changes.
318
319         * Scripts/webkitpy/common/system/executive_mock.py:
320         (MockExecutive):
321         (MockExecutive.ignore_error):
322         (MockExecutive2):
323         (MockExecutive2.ignore_error):
324         * Scripts/webkitpy/common/system/platforminfo_mock.py:
325         (MockPlatformInfo.is_mac):
326         (MockPlatformInfo.is_linux):
327         (MockPlatformInfo.is_win):
328         * Scripts/webkitpy/common/system/systemhost_mock.py:
329         (MockSystemHost.__init__):
330         * Scripts/webkitpy/layout_tests/port/apple.py:
331         (ApplePort.__init__):
332         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
333         (ChromiumMacPort.__init__):
334         (ChromiumMacPort.check_wdiff):
335         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
336         (ChromiumMacPortTest):
337         (ChromiumMacPortTest.assert_name):
338         (ChromiumMacPortTest.test_versions):
339         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
340         (ChromiumPortTest.test_all_test_configurations):
341         (ChromiumPortTest.TestMacPort.__init__):
342         (ChromiumPortTest.TestLinuxPort.__init__):
343         (ChromiumPortTest.TestWinPort.__init__):
344         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
345         (ChromiumWinPort.__init__):
346         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
347         (ChromiumWinTest):
348         (ChromiumWinTest.assert_name):
349         (ChromiumWinTest.test_versions):
350         (ChromiumWinTest.test_baseline_path):
351         (ChromiumWinTest.test_build_path):
352         * Scripts/webkitpy/layout_tests/port/factory.py:
353         (PortFactory._port_name_from_arguments_and_options):
354         (PortFactory.get):
355         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
356         (FactoryTest):
357         (FactoryTest.setUp):
358         (FactoryTest.assert_port):
359         (FactoryTest.test_mac):
360         (FactoryTest.test_win):
361         (FactoryTest.test_google_chrome):
362         (FactoryTest.test_gtk):
363         (FactoryTest.test_qt):
364         (FactoryTest.test_chromium_gpu):
365         (FactoryTest.test_chromium_gpu_linux):
366         (FactoryTest.test_chromium_gpu_mac):
367         (FactoryTest.test_chromium_gpu_win):
368         (FactoryTest.test_chromium_mac):
369         (FactoryTest.test_chromium_linux):
370         (FactoryTest.test_chromium_win):
371         (FactoryTest.test_unknown_specified):
372         (FactoryTest.test_unknown_default):
373         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
374         (TestGoogleChromePort):
375         (TestGoogleChromePort._verify_baseline_path):
376         (TestGoogleChromePort._verify_expectations_overrides):
377         (TestGoogleChromePort.test_get_google_chrome_port):
378         * Scripts/webkitpy/layout_tests/port/mac.py:
379         (MacPort):
380         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
381         (MacTest):
382         (assert_name):
383         (test_tests_for_other_platforms):
384         (test_version):
385         (test_versions):
386         (test_is_version_methods):
387         (test_setup_environ_for_server):
388         (_assert_search_path):
389         (test_show_results_html_file):
390         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
391         (PortTestCase):
392         (PortTestCase.make_port):
393         * Scripts/webkitpy/layout_tests/port/win.py:
394         (WinPort):
395         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
396         (WinPortTest):
397         (WinPortTest.test_show_results_html_file):
398         (WinPortTest._assert_search_path):
399         (WinPortTest._assert_version):
400
401 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
402
403         [Qt][WK2] Remove workaround introduced into bug 75470
404         https://bugs.webkit.org/show_bug.cgi?id=75889
405
406         Reviewed by Tor Arne Vestbø.
407
408         * MiniBrowser/qt/qml/BrowserWindow.qml:
409
410 2012-01-10  Dmitry Lomov  <dslomov@google.com>
411
412         [Chromium] Remove obsolete references to WebWorker class.
413         https://bugs.webkit.org/show_bug.cgi?id=76020
414
415         Reviewed by David Levin.
416
417         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
418         * DumpRenderTree/chromium/WebViewHost.cpp:
419         * DumpRenderTree/chromium/WebViewHost.h:
420
421 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
422
423         [Qt] Some css3 filter tests are failing after r104698
424         https://bugs.webkit.org/show_bug.cgi?id=76055
425
426         Reviewed by Simon Hausmann.
427
428         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
429         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
430
431 2012-01-11  Tony Chang  <tony@chromium.org>
432
433         Don't remove 0 byte files when running build-webkit --chromium
434         https://bugs.webkit.org/show_bug.cgi?id=75997
435
436         Reviewed by Csaba Osztrogonác.
437
438         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
439
440         * Scripts/webkitdirs.pm:
441         (determineIsQt):
442
443 2012-01-10  David Kilzer  <ddkilzer@apple.com>
444
445         Add TestWebKitAPI tests for KURL
446         <http://webkit.org/b/75774>
447
448         Reviewed by Adam Barth.
449
450         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
451         WebCore folder and KURL.cpp source file to the project.
452         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
453         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
454         during setup since this test doesn't go through WebKit or
455         WebKit2.
456         (TestWebKitAPI::TEST_F): Add two basic tests.
457
458 2012-01-10  David Kilzer  <ddkilzer@apple.com>
459
460         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
461
462         Reviewed by Adam Barth.
463
464         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
465
466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
467         WTFStringUtilities.h to the project.
468         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
469         WTFStringUtilities.h.
470         * TestWebKitAPI/WTFStringUtilities.h: Added.
471         (WTF::operator<<):
472
473 2012-01-10  Vincent Scheib  <scheib@chromium.org>
474
475         Clarify run-webkit-tests options reset-results and new-baseline
476         https://bugs.webkit.org/show_bug.cgi?id=75993
477
478         Reviewed by Dirk Pranke.
479
480         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
481         (parse_args):
482
483 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
484
485         Disabled mock scrollbars should draw differently
486         https://bugs.webkit.org/show_bug.cgi?id=75995
487
488         Reviewed by James Robinson.
489
490         When the scrollbar is disabled, paint the entire track of
491         mock scrollbars with a lighter gray, and hide the thumb.
492
493         * DumpRenderTree/mac/DumpRenderTree.mm:
494         (-[DRTMockScroller drawKnob]):
495         (-[DRTMockScroller drawRect:]):
496
497 2012-01-10  James Robinson  <jamesr@chromium.org>
498
499         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
500         https://bugs.webkit.org/show_bug.cgi?id=75988
501
502         Reviewed by Adam Barth.
503
504         * Scripts/webkitpy/common/config/ports.py:
505         (WebKitPort.run_webkit_unit_tests_command):
506         (WebKitPort):
507         (ChromiumPort.run_webkit_unit_tests_command):
508         (ChromiumPort):
509         * Scripts/webkitpy/common/config/ports_mock.py:
510         (MockPort.run_webkit_unit_tests_command):
511         * Scripts/webkitpy/tool/commands/download_unittest.py:
512         (DownloadCommandsTest.test_build_and_test):
513         (test_land):
514         (test_land_red_builders):
515         * Scripts/webkitpy/tool/steps/runtests.py:
516         (RunTests.run):
517         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
518
519 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
520
521         webkitpy: add os_name, os_version to platforminfo
522         https://bugs.webkit.org/show_bug.cgi?id=75931
523
524         Reviewed by Eric Siedel.
525
526         As a first step in cleaning up the version parsing logic in
527         webkitpy.layout_tests.port, this adds common routines for
528         getting the os_name and os_version fields to the PlatformInfo
529         class. Nothing uses them yet but I've added FIXME's to some of
530         the code that needs to be deleted in the port files.
531
532         * Scripts/webkitpy/common/system/platforminfo.py:
533         (PlatformInfo.__init__):
534         (PlatformInfo):
535         (PlatformInfo._determine_os_name):
536         (PlatformInfo._determine_mac_version):
537         (PlatformInfo._determine_linux_version):
538         (PlatformInfo._determine_win_version):
539         (PlatformInfo.display_name):
540         (PlatformInfo.total_bytes_memory):
541         (PlatformInfo._compute_bytes_from_vm_stat_output):
542         (PlatformInfo.free_bytes_memory):
543         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
544         (TestPlatformInfo):
545         (TestPlatformInfo.make_info):
546         (TestPlatformInfo.make_info.mock_run_command):
547         (TestPlatformInfo.setUp):
548         (TestPlatformInfo.tearDown):
549         (TestPlatformInfo.test_basic):
550         (TestPlatformInfo.integration_test_basic):
551         (TestPlatformInfo.test_display_name_mac):
552         (TestPlatformInfo.test_display_name_win32):
553         (TestPlatformInfo.test_memory_mac):
554         (TestPlatformInfo.test_memory_win32):
555         (TestPlatformInfo.test_determine_os_name):
556         (TestPlatformInfo.test_determine_mac_version):
557         (TestPlatformInfo.test_determine_linux_version):
558         (TestPlatformInfo.test_determine_win_version_from_tuple):
559         (TestPlatformInfo.test_determine_win_version_from_cmd):
560         * Scripts/webkitpy/layout_tests/port/apple.py:
561         (ApplePort.__init__):
562         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
563         (ChromiumMacPort.__init__):
564         * Scripts/webkitpy/layout_tests/port/mac.py:
565         (MacPort):
566         * Scripts/webkitpy/layout_tests/port/win.py:
567         (WinPort):
568
569 2012-01-10  Adam Roben  <aroben@apple.com>
570
571         Make it possible to type data: URLs into MiniBrowser on Windows
572
573         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
574         MiniBrowser on Windows
575
576         Reviewed by Darin Adler.
577
578         * MiniBrowser/win/BrowserWindow.cpp:
579         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
580         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
581         does, we assume it already has a scheme and don't modify it.
582
583 2012-01-10  Adam Roben  <aroben@apple.com>
584
585         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
586
587         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
588         MiniBrowser on Windows
589
590         Reviewed by Darin Adler.
591
592         * MiniBrowser/win/BrowserView.cpp:
593         (BrowserView::goToURL): Pass the typed string through
594         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
595
596 2012-01-10  Ben Wells  <benwells@chromium.org>
597
598         Adding myself (benwells) to committers.py
599         https://bugs.webkit.org/show_bug.cgi?id=75971
600
601         Reviewed by Ojan Vafai.
602
603         * Scripts/webkitpy/common/config/committers.py:
604
605 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
606
607         AX: support helpText() in DumpRenderTree
608         https://bugs.webkit.org/show_bug.cgi?id=40193
609
610         Reviewed by Chris Fleizach.
611
612         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
613         (AccessibilityUIElement::helpText): Implemented.
614
615 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
616
617         Unreviewed, rolling out r104572.
618         http://trac.webkit.org/changeset/104572
619         https://bugs.webkit.org/show_bug.cgi?id=75967
620
621         It broke zillion tests (Requested by Ossy on #webkit).
622
623         * DumpRenderTree/qt/EventSenderQt.cpp:
624         (EventSender::EventSender):
625         (EventSender::sendOrQueueEvent):
626         (EventSender::replaySavedEvents):
627         (EventSender::eventFilter):
628         * DumpRenderTree/qt/EventSenderQt.h:
629
630 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
631
632         [Qt] fast/events/dont-loose-last-event test fails on WK1
633         https://bugs.webkit.org/show_bug.cgi?id=73894
634
635         Reviewed by Simon Hausmann.
636
637         Empty the entire event queue when requested besides using
638         sendEvent instead of postEvent to make sure all events were
639         delivered.
640         This commit also removes not working DRT code to handle drag and drop,
641         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
642
643         * DumpRenderTree/qt/EventSenderQt.cpp:
644         (EventSender::EventSender):
645         (EventSender::sendOrQueueEvent):
646         (EventSender::replaySavedEvents):
647         * DumpRenderTree/qt/EventSenderQt.h:
648
649 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
650
651         [Qt] Enable CSS_FILTERS in Qt build
652         https://bugs.webkit.org/show_bug.cgi?id=75777
653
654         Add the CSS_FILTERS feature flag to Qt.
655
656         Reviewed by Kenneth Rohde Christiansen.
657
658         * qmake/mkspecs/features/features.prf:
659
660 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
661
662         [Qt] Unreviewed -Werror build fix.
663
664         * MiniBrowser/qt/MiniBrowserApplication.cpp:
665         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
666         declaration.
667
668 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
669
670         [Qt] Remove dependency to uitools
671         https://bugs.webkit.org/show_bug.cgi?id=75952
672
673         Reviewed by Tor Arne Vestbø.
674
675         QUiLoader is used for creating QLabel/QProgressBar widgets for
676         a layout test, to verify some widget embedding feature. Unfortunately
677         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
678         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
679         let's break the circular dependency.
680
681         * DumpRenderTree/qt/DumpRenderTree.pro:
682         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
683         (WebCore::WebPage::createPlugin):
684         * QtTestBrowser/QtTestBrowser.pro:
685         * QtTestBrowser/launcherwindow.h:
686         * QtTestBrowser/webpage.cpp:
687         (WebPage::createPlugin):
688         * qmake/mkspecs/features/minimal_qt.prf:
689         * qmake/mkspecs/features/uitools.prf: Removed.
690
691 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
692
693         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
694         https://bugs.webkit.org/show_bug.cgi?id=75894
695
696         Reviewed by Tor Arne Vestbø.
697
698         * MiniBrowser/qt/MiniBrowserApplication.h:
699         (MiniBrowserApplication::windowOptions):
700         * MiniBrowser/qt/main.cpp:
701         (main):
702
703 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
704
705         [Qt] DRT crashes with Qt 5
706         https://bugs.webkit.org/show_bug.cgi?id=75951
707
708         Reviewed by Ossy.
709
710         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
711         Qt relies on font-config to define the default font family.
712
713 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
714
715         [Qt] REGRESSION(r100130): Clean build feature is broken.
716         https://bugs.webkit.org/show_bug.cgi?id=75863
717
718         Reviewed by Tor Arne Vestbø.
719
720         * Scripts/webkitdirs.pm:
721         (buildQMakeProject):
722
723 2012-01-10  Zeno Albisser  <zeno@webkit.org>
724
725         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
726         https://bugs.webkit.org/show_bug.cgi?id=75885
727
728         In QML events are propagated through parents. But since the
729         WebView may consume key events, a shortcut might never reach
730         the top QtQuickItem.
731         Therefore an application wide event handling function in C++
732         needs to take care of shortcuts for MiniBrowser.
733
734         Reviewed by Kenneth Rohde Christiansen.
735
736         * MiniBrowser/qt/BrowserWindow.cpp:
737         (BrowserWindow::reload):
738         (BrowserWindow::focusAddressBar):
739         * MiniBrowser/qt/BrowserWindow.h:
740         * MiniBrowser/qt/MiniBrowserApplication.cpp:
741         (MiniBrowserApplication::notify):
742         * MiniBrowser/qt/qml/BrowserWindow.qml:
743
744 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
745
746         Add --efl alias for --platform=efl to run-webkit-test
747         https://bugs.webkit.org/show_bug.cgi?id=75937
748
749         Reviewed by Andreas Kling.
750         
751         * Scripts/run-webkit-tests: Add --efl alias.
752         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
753         (parse_args):
754
755 2012-01-09  Dan Bernstein  <mitz@apple.com>
756
757         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
758         https://bugs.webkit.org/show_bug.cgi?id=75920
759
760         Reviewed by Darin Adler.
761
762         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
763         (TestWebKitAPI::TEST): Added a test for a range in a
764         -webkit-user-select: none; block.
765
766 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
767
768         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
769         https://bugs.webkit.org/show_bug.cgi?id=75884
770
771         Reviewed by Ryosuke Niwa.
772
773         Fix regression introduced (revealed?) in r104340. Chromium file         
774         url syntax is different on win32 and the test results weren't           
775         expecting that.                                                         
776
777         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
778         (TestExpectations._report_errors):
779         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
780         (test_parse_error_nonfatal):
781         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
782         (MockDRTTest.input_line):
783         (MockChromiumDRTTest.test_pixeltest__fails):
784         * Scripts/webkitpy/layout_tests/port/test.py:
785         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
786         (TestRebaseliner.make_rebaseliner):
787         (TestRebaseliner.test_one_platform):
788         (TestRebaseliner.test_all_platforms):
789         (TestRebaseliner.test_png_file_with_comment):
790         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
791         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
792         (TestRealMain.test_all_platforms):
793
794 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
795
796         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
797
798         Unreviewed, build fix.
799
800         test-webkitpy had a built-in self-test routine to verify that
801         deleting the .pyc files worked correctly. When I removed the
802         python24 directory in r104482, I broke the self-test.
803
804         I have deleted the self-test for now. Since I am reworking
805         test-webkitpy I will make sure the new version is adequately
806         tested.
807
808         * Scripts/test-webkitpy:
809         (configure_logging):
810         (_clean_pyc_files):
811         (_clean_packages):
812         (init):
813
814 2012-01-09  Justin Novosad  <junov@chromium.org>
815
816         [Chromium] remove all references to the legacy accelerated 2d Canvas
817         implementation
818         https://bugs.webkit.org/show_bug.cgi?id=75108
819
820         Purging an old settings flag that is no longer referenced
821
822         Reviewed by Darin Fisher.
823
824         * DumpRenderTree/chromium/DumpRenderTree.cpp:
825         (main):
826         * DumpRenderTree/chromium/TestShell.cpp:
827         (TestShell::TestShell):
828         (TestShell::resetWebSettings):
829         * DumpRenderTree/chromium/TestShell.h:
830         (TestShell::setAccelerated2dCanvasEnabled):
831         * DumpRenderTree/chromium/WebPreferences.cpp:
832         (WebPreferences::reset):
833         (WebPreferences::applyTo):
834         * DumpRenderTree/chromium/WebPreferences.h:
835
836 2012-01-09  Adam Roben  <aroben@apple.com>
837
838         Convert Cygwin paths to Windows paths before passing them to DRT
839
840         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
841         NRWT
842
843         I couldn't find a way to test this because I couldn't figure out how to override the
844         cygpath function as it is used by WebKitDriver.
845
846         Reviewed by Dirk Pranke.
847
848         * Scripts/webkitpy/layout_tests/port/webkit.py:
849         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
850         Windows-style path before passing it to DRT.
851
852 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
853
854         webkitpy: revamp version checking
855         https://bugs.webkit.org/show_bug.cgi?id=75765
856
857         Reviewed by Adam Barth.
858
859         The version-checking code in webkitpy/python24/versioning seems really
860         awkward and overdesigned, especially since we don't support python 2.4
861         any more.
862
863         In addition, I am tired of getting warnings about Python 2.6 being "a
864         newer release than what is supported" :).
865
866         I'm taking a page from the depot_tools python code and just creating a
867         new webkitpy.common.version_check module that will print a message on
868         stderr and call sys.exit() if we're running an unsupported version.
869
870         * Scripts/check-webkit-style:
871         * Scripts/new-run-webkit-httpd:
872         * Scripts/new-run-webkit-tests:
873         * Scripts/rebaseline-chromium-webkit-tests:
874         * Scripts/test-webkitpy:
875         (configure_logging):
876         (init):
877         * Scripts/webkit-patch:
878         (main):
879         * Scripts/webkitpy/common/system/executive.py:
880         (Executive._child_process_encoding):
881         (Executive._should_encode_child_process_arguments):
882         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
883         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
884         * Scripts/webkitpy/python24/__init__.py: Removed.
885         * Scripts/webkitpy/python24/versioning.py: Removed.
886         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
887
888 2012-01-09  Adam Barth  <abarth@webkit.org>
889
890         Remove Chromium Mac CG from the flakiness dashboard
891         https://bugs.webkit.org/show_bug.cgi?id=75873
892
893         Reviewed by Ojan Vafai.
894
895         This configuration no longer exists.
896
897         * TestResultServer/static-dashboards/builders.js:
898         * TestResultServer/static-dashboards/flakiness_dashboard.html:
899         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
900         (testOverrideJustBuildType):
901         (testPlatformAndBuildType):
902
903 2012-01-06  Adam Roben  <aroben@apple.com>
904
905         Print an error message when NRWT can't run Apache
906
907         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
908
909         Reviewed by Dirk Pranke.
910
911         * Scripts/webkitpy/layout_tests/port/base.py:
912         (Port.check_httpd): Print an error message when Apache returns an error code instead of
913         failing silently.
914
915         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
916         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
917         run Apache.
918         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
919         fails.
920
921 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
922
923         [Gtk][ARM] Cross compiler buildbot is failing after r103040
924         https://bugs.webkit.org/show_bug.cgi?id=75846
925
926         Reviewed by Philippe Normand.
927
928         * Scripts/webkitdirs.pm:
929         (runAutogenForAutotoolsProjectIfNecessary):
930
931 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
932
933         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
934         https://bugs.webkit.org/show_bug.cgi?id=75807
935
936         This patch adds a new icon to navigationbar of the Qt MiniBrowser
937         which allows you to dynamically toggle whether touch mocking is
938         enabled or disabled.
939
940         Reviewed by Tor Arne Vestbø.
941
942         * MiniBrowser/qt/MiniBrowser.qrc:
943         * MiniBrowser/qt/MiniBrowserApplication.cpp:
944         (MiniBrowserApplication::notify):
945         * MiniBrowser/qt/MiniBrowserApplication.h:
946         (WindowOptions::WindowOptions):
947         (WindowOptions::touchMockingEnabled):
948         (WindowOptions::setTouchMockingEnabled):
949         * MiniBrowser/qt/icons/touch.png: Added.
950         * MiniBrowser/qt/qml/BrowserWindow.qml:
951
952 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
953
954         Unreviewed. Fix make distcheck issues.
955
956         * MiniBrowser/gtk/GNUmakefile.am:
957
958 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
959
960         Unreviewed, rolling out r104421.
961         http://trac.webkit.org/changeset/104421
962         https://bugs.webkit.org/show_bug.cgi?id=75816
963
964         Need to rebaseline some tests on Linux (Requested by noamr on
965         #webkit).
966
967         * qmake/mkspecs/features/features.prf:
968
969 2012-01-08  Adam Barth  <abarth@webkit.org>
970
971         Remove support for Chromium Mac CG from garden-o-matic
972         https://bugs.webkit.org/show_bug.cgi?id=75814
973
974         Reviewed by Eric Seidel.
975
976         This configuration no longer exists.  This patch is mostly a matter of
977         updating config.js and removing the examples from the unit tests.
978
979         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
980         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
982         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
983         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
984
985 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
986
987         [Qt] Enable CSS_FILTERS in Qt build
988         https://bugs.webkit.org/show_bug.cgi?id=75777
989
990         Add the CSS_FILTERS feature flag to Qt.
991
992         Reviewed by Kenneth Rohde Christiansen.
993
994         * qmake/mkspecs/features/features.prf:
995
996 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
997
998         Categorize bots by ports instead of core/non-core separation
999         https://bugs.webkit.org/show_bug.cgi?id=75766
1000
1001         Reviewed by Eric Seidel.
1002
1003         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
1004         (Chromium still comes before GTK and Qt).
1005
1006         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1007         (loadBuilderConfig):
1008         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1009
1010 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1011
1012         Remove the concept of core builders from webkitpy
1013         https://bugs.webkit.org/show_bug.cgi?id=75809
1014
1015         Reviewed by Ryosuke Niwa.
1016
1017         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
1018         and remove the relevant code.
1019
1020         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1021         (BuildBot.__init__):
1022         (BuildBot._matches_regexps):
1023         (BuildBot._builder_statuses_with_names_matching_regexps):
1024         (BuildBot.builder_statuses):
1025         (BuildBot.failure_map):
1026         (BuildBot._latest_builds_from_builders):
1027         (BuildBot.last_green_revision):
1028         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1029         (MockBuildBot.builder_statuses):
1030         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1031         (test_status_parsing):
1032         (test_last_green_revision):
1033         (test_last_green_revision.mock_builds_from_builders):
1034
1035 2012-01-08  Adam Barth  <abarth@webkit.org>
1036
1037         Remove Chromium Mac CG concept from webkitpy
1038         https://bugs.webkit.org/show_bug.cgi?id=75810
1039
1040         Reviewed by Ryosuke Niwa.
1041
1042         This configuration no longer exists.  We can remove all the supporting
1043         code from webkitpy.
1044
1045         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1046         (BaselineOptimizerTest.test_move_baselines):
1047         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
1048         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
1049         (BaselineOptimizerTest.test_common_directory_includes_root):
1050         (BaselineOptimizerTest.test_complex_shadowing):
1051         * Scripts/webkitpy/common/config/build.py:
1052         (_should_file_trigger_build):
1053         * Scripts/webkitpy/common/config/build_unittest.py:
1054         (ShouldBuildTest):
1055         * Scripts/webkitpy/layout_tests/port/builders.py:
1056         * Scripts/webkitpy/layout_tests/port/chromium.py:
1057         (ChromiumPort):
1058         (ChromiumPort._generate_all_test_configurations):
1059         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1060         (_default_tests_paths):
1061         (ChromiumGpuLinuxPort.tests):
1062         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1063         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
1064         (ChromiumGpuTest.assert_port_works):
1065         (ChromiumGpuTest.test_baseline_paths):
1066         (ChromiumGpuTest.test_graphics_type):
1067         (ChromiumGpuTest.test_default_tests_paths):
1068         (ChromiumGpuTest.test_test_files):
1069         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1070         (ChromiumMacPort):
1071         (ChromiumMacPort.__init__):
1072         (ChromiumMacPort.baseline_search_path):
1073         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1074         (ChromiumMacPortTest.test_graphics_type):
1075         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1076         (ChromiumPortTest.test_all_test_configurations):
1077         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1078         * Scripts/webkitpy/layout_tests/port/factory.py:
1079         (PortFactory._port_name_from_arguments_and_options):
1080         (PortFactory.get):
1081         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1082         (FactoryTest.test_chromium_gpu_mac):
1083         (FactoryTest.test_chromium_mac):
1084         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1085         (GetGoogleChromePortTest._verify_expectations_overrides):
1086         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1087         (MockChromiumDRTTest.test_chromium_parse_options):
1088         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1089         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1090         (test_url_fetcher):
1091         (test_zip_factory):
1092         (test_archive):
1093         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1094         (TestRebaseline.test_rebaseline_expectations):
1095
1096 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1097
1098         Categorize bots by ports instead of core/non-core separation
1099         https://bugs.webkit.org/show_bug.cgi?id=75766
1100
1101         Reviewed by Adam Barth.
1102
1103         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
1104
1105         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1106         (loadBuilderConfig):
1107         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1108
1109 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1110
1111         Unreviewed, rolling out r104403.
1112         http://trac.webkit.org/changeset/104403
1113         https://bugs.webkit.org/show_bug.cgi?id=75803
1114
1115         It broke all tests on Qt5 (Requested by Ossy_weekend on
1116         #webkit).
1117
1118         * qmake/mkspecs/features/features.prf:
1119
1120 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
1121
1122         [Qt] Enable CSS_FILTERS in Qt build
1123         https://bugs.webkit.org/show_bug.cgi?id=75777
1124
1125         Add the CSS_FILTERS feature flag to Qt.
1126
1127         Reviewed by Kenneth Rohde Christiansen.
1128
1129         * qmake/mkspecs/features/features.prf:
1130
1131 2012-01-04  Kentaro Hara  <haraken@chromium.org>
1132
1133         Rewrite the CSS parser of prepare-ChangeLog with unittests.
1134         https://bugs.webkit.org/show_bug.cgi?id=75202
1135
1136         Reviewed by David Kilzer.
1137
1138         The current CSS parser can just parse simple CSSes like
1139
1140             foo bar baz {
1141                 property1: value;
1142                 property2: value;
1143             }
1144
1145         , and cannot parse comments nor a CSS in which a selector and {
1146         appears in different lines. This patch rewrites the CSS parser
1147         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
1148         shown in css_unittests.css.
1149
1150         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
1151
1152         * Scripts/prepare-ChangeLog:
1153         (get_selector_line_ranges_for_css):
1154         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1155         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
1156         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
1157         (element1):
1158         (element2):
1159         (element3):
1160         (element4.p):
1161         (element5.p.q.r.s):
1162         (element6#p):
1163         (element7 element8):
1164         (element9.p element10.q):
1165         (element11#p element12#q):
1166         (element13, element14):
1167         (.p):
1168         (#p):
1169         (.p element15 #q element16.r element17#s):
1170         (element18:target):
1171         (element19):
1172         (element20):
1173         (element21):
1174         (element22):
1175
1176 2012-01-04  Kentaro Hara  <haraken@chromium.org>
1177
1178         The Perl parser of prepare-ChangeLog can parse here-documents
1179         https://bugs.webkit.org/show_bug.cgi?id=73208
1180
1181         Reviewed by David Kilzer.
1182
1183         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
1184         which results in wrong subroutine names in ChangeLogs.
1185         With this patch, prepare-ChangeLog can judge whether the line of "}"
1186         is the end of a subroutine or a line inside a here-document.
1187
1188         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
1189
1190         * Scripts/prepare-ChangeLog:
1191         (get_function_line_ranges_for_perl):
1192         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1193         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1194         Added test cases for here-documents.
1195         (func7):
1196         (func8):
1197         (func9):
1198         (func10):
1199         (func11):
1200         (func12):
1201         (func13):
1202         (func14):
1203         (func15):
1204         (func16):
1205
1206 2012-01-08  Kentaro Hara  <haraken@chromium.org>
1207
1208         Add unittests for the JavaScript parser of prepare-ChangeLog
1209         https://bugs.webkit.org/show_bug.cgi?id=75201
1210
1211         Reviewed by David Kilzer.
1212
1213         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
1214         of prepare-ChangeLog.
1215
1216         * Scripts/prepare-ChangeLog:
1217         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
1218         omitted from parsing. Thus,
1219
1220             str = "foo"
1221             function func() {
1222             }
1223
1224         was recognized as equivalent to
1225
1226             str = function func() {
1227             }
1228
1229         This patch replaces a string with a dummy identifier 'string_appeared_here'
1230         to tell the parser that a string appeared there.
1231
1232         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1233         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
1234         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
1235         (func1):
1236         (func2):
1237         (func3):
1238         (func4):
1239         (func5):
1240         (func6):
1241         (func7):
1242         (func8):
1243         (func9):
1244         (func10):
1245         (func11):
1246         (func12):
1247         (funcOverloaded):
1248         (Func1.prototype.get x1):
1249         (Func1.prototype.get x2):
1250         (Func1.prototype.set x1):
1251         (Func1.prototype.set x3):
1252         (Func2.prototype.func13):
1253         (Func2.prototype.func14):
1254         (Func2.prototype.func15):
1255         (func16.func17):
1256         (func16.func18):
1257         (func16.func19):
1258         (func16):
1259
1260 2012-01-08  David Levin  <levin@chromium.org>
1261
1262         [chromium] Add layout test support for autosize code in FrameView.
1263         https://bugs.webkit.org/show_bug.cgi?id=73631
1264
1265         Reviewed by Dmitry Titov.
1266
1267         * DumpRenderTree/chromium/LayoutTestController.cpp:
1268         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
1269         (LayoutTestController::reset): Set the autoresize mode back to false.
1270         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
1271         * DumpRenderTree/chromium/LayoutTestController.h:
1272         * DumpRenderTree/chromium/WebViewHost.cpp:
1273         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
1274         * DumpRenderTree/chromium/WebViewHost.h:
1275
1276 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
1277
1278         [WK2][GTK] Each test takes roughly half a second to load
1279         https://bugs.webkit.org/show_bug.cgi?id=70699
1280
1281         Reviewed by Martin Robinson.
1282
1283         Set the XDG_CACHE_HOME environment variable when testing with
1284         WebKitTestRunner. This way the testing is started with a non-existing
1285         application cache. If the cache exists and is not empty, the emptying
1286         and vacuuming that is performed before every test can consume a lot of
1287         time.
1288
1289         This is just a temporary workaround until it becomes possible to set
1290         a desired directory to be used as the application cache location through
1291         WebKitWebContext.
1292
1293         * Scripts/webkitpy/layout_tests/port/gtk.py:
1294         (GtkPort.setup_environ_for_server):
1295
1296 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
1297
1298         [GTK] Enable requestAnimationFrame in build-webkit
1299         https://bugs.webkit.org/show_bug.cgi?id=75773
1300
1301         Reviewed by Martin Robinson.
1302
1303         Enable requestAnimationFrame for the Gtk port.
1304
1305         * Scripts/build-webkit:
1306
1307 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
1308
1309         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
1310
1311         * Scripts/webkitdirs.pm:
1312         (buildChromium):
1313         Missing parentheses.
1314
1315 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1316
1317         Fix DRT build on case-sensitive file systems.
1318
1319         Fix case of include of WebDynamicScrollBarsView.h
1320         
1321         * DumpRenderTree/mac/DumpRenderTree.mm:
1322
1323 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1324
1325         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
1326         https://bugs.webkit.org/show_bug.cgi?id=75662
1327
1328         Reviewed by Dan Bernstein.
1329         
1330         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
1331         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
1332         test window uses the main display's color space, so that the pixel values in the bitmap
1333         that gets checksummed are identical to the CSS colors.
1334         
1335         Removed the code that switches the display profile in DRT, since that is no longer required.
1336
1337         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
1338         * DumpRenderTree/mac/DumpRenderTree.mm:
1339         (crashHandler): Remove code that switches display profiles.
1340         (prepareConsistentTestingEnvironment): Ditto.
1341         (dumpRenderTree): Ditto.
1342         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
1343         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
1344         (createBitmapContextFromWebView): Add comment about the colorspace handling.
1345         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1346         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
1347         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
1348         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1349         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
1350         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
1351
1352 2012-01-06  David Kilzer  <ddkilzer@apple.com>
1353
1354         run-api-tests: specify individual suites and tests on the command-line
1355
1356         Reviewed by Adam Roben.
1357
1358         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
1359
1360         The run-api-tests script will now accept a list of arguments on
1361         the command-line that are used as prefix filters.  To run all
1362         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
1363         use:
1364
1365             $ run-api-tests WTF
1366
1367         To run only the tests in the "WTF" suite, not the "WTF_Vector"
1368         suite, use:
1369
1370             $ run-api-tests WTF.
1371
1372         * Scripts/run-api-tests: Filter tests if any prefix arguments
1373         are passed on the command-line.
1374
1375 2012-01-06  David Kilzer  <ddkilzer@apple.com>
1376
1377         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
1378
1379         Reviewed by Adam Roben.
1380
1381         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
1382
1383         * Scripts/run-api-tests:
1384         (dumpTestsBySuite): Update to accept array of tests instead of
1385         hash data structure.
1386         (runTestsBySuite): Ditto.
1387         (listAllTests): Rename from populateTests().  Update to return
1388         an array of tests instad of the hash data structure.
1389
1390 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1391
1392         webkitpy: clean up test/uri conversion routines
1393         https://bugs.webkit.org/show_bug.cgi?id=75648
1394
1395         Reviewed by Eric Seidel.
1396
1397         This change moves test_to_uri and uri_to_test from the Port
1398         class to the Driver class (the routines were only being
1399         called by the drivers), and removes a bunch of stale and/or
1400         busted logic.
1401
1402         * Scripts/webkitpy/layout_tests/port/base.py:
1403         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1404         * Scripts/webkitpy/layout_tests/port/chromium.py:
1405         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1406         * Scripts/webkitpy/layout_tests/port/driver.py:
1407         (is_http_test):
1408         (test_to_uri):
1409         (uri_to_test):
1410         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1411         (run_one_test):
1412         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1413         (MockDRTTest.input_line):
1414         (input_line):
1415         (expected_output):
1416         * Scripts/webkitpy/layout_tests/port/test.py:
1417         * Scripts/webkitpy/layout_tests/port/webkit.py:
1418         (_command_from_driver_input):
1419
1420 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1421
1422         Mitigate scrollbar differences when running pixel tests
1423         https://bugs.webkit.org/show_bug.cgi?id=67217
1424
1425         Reviewed by Dan Bernstein.
1426         
1427         Add an NSScroller subclass that draws mock scrollbars identically
1428         to the WebCore mock scrollbar theme, and register it with the
1429         WebDynamicScrollbarsView.
1430
1431         * DumpRenderTree/mac/DumpRenderTree.mm:
1432         (-[DRTMockScroller rectForPart:]):
1433         (-[DRTMockScroller drawKnob]):
1434         (-[DRTMockScroller drawRect:]):
1435         (registerMockScrollbars):
1436         (prepareConsistentTestingEnvironment):
1437
1438 2012-01-05  Jon Lee  <jonlee@apple.com>
1439
1440         Update DRT on Mac to draw resize handles on text areas.
1441
1442         Reviewed by John Sullivan.
1443
1444         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
1445         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
1446
1447         * DumpRenderTree/mac/DumpRenderTree.mm:
1448         (resetDefaultsToConsistentValues):
1449
1450 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1451
1452         [Qt] Move listing of include paths and libs to pri files in sources
1453
1454         Includepaths are sometimes modified by non-Qt contributors so keeping
1455         them in files inside Sources makes it more likely that they are updated
1456         along with project files for the other ports.
1457
1458         Using pri files instead of prf files for this also has the benefit that
1459         the include() from the main target file can be parsed and followed by
1460         Qt Creator -- something that does not work with load().
1461
1462         Dependency from a target to a library through the WEBKIT variable are
1463         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
1464         set the source root of the module and include the right pri file.
1465
1466         Ideally we'd use the variant of include() that takes an optional
1467         namespace to read the variables into, or the fromfile() function,
1468         but both of these add an overhead of about 40% on the total qmake
1469         runtime, due to making a deep copy of all the variables in the
1470         project or re-reading all the prf files from scratch.
1471
1472         Reviewed by Simon Hausmann.
1473         Reviewed by Ossy.
1474
1475         * qmake/mkspecs/features/default_post.prf:
1476         * qmake/mkspecs/modules/javascriptcore.prf: Added.
1477         * qmake/mkspecs/modules/webcore.prf: Added.
1478         * qmake/mkspecs/modules/webkit2.prf: Added.
1479         * qmake/mkspecs/modules/wtf.prf: Added.
1480
1481 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
1482
1483         [EFL] Add pre-render handling code in EWebLauncher.
1484         https://bugs.webkit.org/show_bug.cgi?id=73430
1485
1486         Reviewed by Zoltan Herczeg.
1487
1488         Add pre-render handling code by pressing Insert key.
1489
1490         * EWebLauncher/main.c:
1491         (on_key_down):
1492
1493 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
1494
1495         NRWT should use test_expectation.txt on wk2 platforms
1496         https://bugs.webkit.org/show_bug.cgi?id=75417
1497
1498         Reviewed by Dirk Pranke.
1499
1500         * Scripts/webkitpy/layout_tests/port/webkit.py:
1501         (path_to_test_expectations_file):
1502         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1503         (test_path_to_test_expectations_file):
1504
1505 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
1506
1507         Don't hardcode expected file URIs in as they depend on the platform
1508         https://bugs.webkit.org/show_bug.cgi?id=75666
1509
1510         Reviewed by Dirk Pranke.
1511
1512         * Scripts/webkitpy/layout_tests/port/win.py:
1513         (WinPort.show_results_html_file):
1514         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1515         (MainTest.test_unexpected_failures):
1516         (MainTest.test_results_directory_default):
1517         (MainTest.test_results_directory_relative):
1518
1519 2012-01-05  Anders Carlsson  <andersca@apple.com>
1520
1521         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
1522         https://bugs.webkit.org/show_bug.cgi?id=75667
1523         <rdar://problem/10389454>
1524
1525         Reviewed by Kevin Decker.
1526
1527         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
1528
1529         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1530         (PluginTest::executeScript):
1531         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1532         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
1533         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
1534         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
1535         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
1536
1537 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1538
1539         webkitpy: clean up port factory methods
1540         https://bugs.webkit.org/show_bug.cgi?id=75590
1541
1542         Reviewed by Eric Seidel.
1543
1544         This change consolidates much of the "factory method" logic
1545         of determining which port objects to create for a given set
1546         of configurations by merging the separate factory methods in
1547         chromium_gpu and google_chrome into PortFactory so that at least
1548         all of the logic is in one place.
1549
1550         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1551         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1552         * Scripts/webkitpy/layout_tests/port/factory.py:
1553         (_port_name_from_arguments_and_options):
1554         (get):
1555         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1556         (test_google_chrome):
1557         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1558         (GoogleChromeLinux32Port):
1559         (GoogleChromeLinux32Port.baseline_search_path):
1560         (test_expectations_overrides):
1561         (architecture):
1562         (GoogleChromeLinux64Port):
1563         (GoogleChromeLinux64Port.baseline_search_path):
1564         (GoogleChromeMacPort):
1565         (GoogleChromeMacPort.baseline_search_path):
1566         (GoogleChromeWinPort):
1567         (GoogleChromeWinPort.baseline_search_path):
1568         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1569         (_verify_baseline_path):
1570
1571 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
1572
1573         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
1574         https://bugs.webkit.org/show_bug.cgi?id=75617
1575
1576         Reviewed by Dirk Pranke.
1577
1578         * Scripts/webkitpy/common/system/filesystem.py:
1579         (FileSystem.exists):
1580         * Scripts/webkitpy/common/system/filesystem_mock.py:
1581         (MockFileSystem.exists):
1582         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1583         (GenericFileSystemTests.teardown_generic_test_dir):
1584         * Scripts/webkitpy/layout_tests/port/base.py:
1585         (Port.to.show_results_html_file):
1586         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1587         (MainTest.test_results_directory_absolute):
1588
1589 2012-01-05  Adam Roben  <aroben@apple.com>
1590
1591         Remove some unnecessary code from old-run-webkit-tests
1592
1593         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
1594         WebKitTestRunner.
1595
1596         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
1597         Windows
1598
1599         Reviewed by Eric Seidel.
1600
1601         * Scripts/old-run-webkit-tests:
1602         (top level):
1603         (openDumpTool):
1604         Removed calls to setPathForRunningWebKitApp.
1605
1606 2012-01-05  Adam Roben  <aroben@apple.com>
1607
1608         Teach NRWT to use run-safari to open results.html on Apple's Windows port
1609
1610         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
1611         better, since we always want to open results.html using the user's build of WebKit, not
1612         whatever their default browser is.
1613
1614         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
1615         for Apple's Windows port
1616
1617         Reviewed by Eric Seidel.
1618
1619         * Scripts/webkitpy/layout_tests/port/win.py:
1620         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
1621         an obsolete comment.
1622
1623         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1624         (WinPortTest.test_show_results_html_file): Updated expected results.
1625
1626 2012-01-05  Adam Roben  <aroben@apple.com>
1627
1628         Prepend Safari.exe's path to the command-line passed to CreateProcess
1629
1630         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
1631         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
1632         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
1633         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
1634         first argument that WebKitLauncherWin was trying to pass to it.
1635
1636         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
1637
1638         Reviewed by Steve Falkenburg.
1639
1640         * WebKitLauncherWin/WebKitLauncherWin.cpp:
1641         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
1642         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
1643
1644 2012-01-05  Adam Roben  <aroben@apple.com>
1645
1646         Stop using explicit memory management in WebKitLauncherWin
1647
1648         We now use stack-allocated STL objects instead.
1649
1650         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
1651         Safari
1652
1653         Reviewed by Steve Falkenburg.
1654
1655         * WebKitLauncherWin/WebKitLauncherWin.cpp:
1656         (getStringValue):
1657         (applePathFromRegistry):
1658         (safariInstallDir):
1659         (safariBrowserExe):
1660         (_tWinMain):
1661         Changed to use stack-allocated STL objects instead of malloc/free.
1662
1663 2012-01-05  Adam Roben  <aroben@apple.com>
1664
1665         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
1666
1667         This allows us to add the Safari and Apple Application Support directories to PATH before
1668         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
1669
1670         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
1671         Windows port of DumpRenderTree/WebKitTestRunner
1672
1673         Reviewed by Steve Falkenburg.
1674
1675         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
1676         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
1677
1678         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1679         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1680         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
1681
1682         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
1683         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
1684         the stub launcher.
1685
1686         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
1687         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
1688         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
1689         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
1690         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
1691         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
1692         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
1693
1694         * WebKitTestRunner/win/main.cpp:
1695         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
1696
1697 2012-01-05  Adam Roben  <aroben@apple.com>
1698
1699         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
1700
1701         This allows us to add the Safari and Apple Application Support directories to PATH before
1702         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
1703
1704         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
1705         Windows port of DumpRenderTree/WebKitTestRunner
1706
1707         Reviewed by Steve Falkenburg.
1708
1709         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
1710         which I forgot to add to this .sln when that project was created.
1711
1712         * DumpRenderTree/win/DumpRenderTree.cpp:
1713         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
1714
1715         * DumpRenderTree/win/DumpRenderTree.vcproj:
1716         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1717         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
1718
1719         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
1720         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
1721         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
1722         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
1723         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
1724         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
1725         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
1726         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
1727
1728         * win/DLLLauncher/DLLLauncherMain.cpp:
1729         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
1730         Safari's directory to PATH so that SafariTheme.dll can be found.
1731
1732         (main):
1733         (wWinMain):
1734         Changed to use the new modifyPath function.
1735
1736 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
1737
1738         [Qt] Never enable FontConfig on Mac OS X
1739         https://bugs.webkit.org/show_bug.cgi?id=75616
1740
1741         Reviewed by Tor Arne Vestbø.
1742
1743         * qmake/mkspecs/features/features.prf:
1744
1745 2012-01-05  Alpha Lam  <hclam@chromium.org>
1746
1747         Unreviewed, rolling out r104159.
1748         http://trac.webkit.org/changeset/104159
1749         https://bugs.webkit.org/show_bug.cgi?id=75590
1750
1751         Chromium port GPU tests cannot be executed.
1752
1753         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1754         (get):
1755         (_default_tests_paths):
1756         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1757         (ChromiumGpuTest.assert_port_works):
1758         * Scripts/webkitpy/layout_tests/port/factory.py:
1759         (PortFactory._port_name_from_arguments_and_options):
1760         (PortFactory):
1761         (PortFactory._get_kwargs):
1762         (PortFactory.get):
1763         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1764         (FactoryTest.test_google_chrome.names):
1765         (FactoryTest.test_google_chrome):
1766         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1767         (GetGoogleChromePort):
1768         (GetGoogleChromePort.GoogleChromeLinux32Port):
1769         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
1770         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
1771         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
1772         (GetGoogleChromePort.GoogleChromeLinux64Port):
1773         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
1774         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
1775         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
1776         (GetGoogleChromePort.GoogleChromeMacPort):
1777         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
1778         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
1779         (GetGoogleChromePort.GoogleChromeWinPort):
1780         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
1781         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
1782         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1783         (GetGoogleChromePortTest._verify_baseline_path):
1784         (GetGoogleChromePortTest._verify_expectations_overrides):
1785
1786 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1787
1788         webkitpy: clean up port factory methods
1789         https://bugs.webkit.org/show_bug.cgi?id=75590
1790
1791         Reviewed by Eric Seidel.
1792
1793         This change consolidates much of the "factory method" logic
1794         of determining which port objects to create for a given set
1795         of configurations by merging the separate factory methods in
1796         chromium_gpu and google_chrome into PortFactory so that at least
1797         all of the logic is in one place.
1798
1799         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1800         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1801         * Scripts/webkitpy/layout_tests/port/factory.py:
1802         (_port_name_from_arguments_and_options):
1803         (get):
1804         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1805         (test_google_chrome):
1806         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1807         (GoogleChromeLinux32Port):
1808         (GoogleChromeLinux32Port.baseline_search_path):
1809         (test_expectations_overrides):
1810         (architecture):
1811         (GoogleChromeLinux64Port):
1812         (GoogleChromeLinux64Port.baseline_search_path):
1813         (GoogleChromeMacPort):
1814         (GoogleChromeMacPort.baseline_search_path):
1815         (GoogleChromeWinPort):
1816         (GoogleChromeWinPort.baseline_search_path):
1817         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1818         (_verify_baseline_path):
1819
1820 2012-01-04  Adam Roben  <aroben@apple.com>
1821
1822         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
1823
1824         This allows us to add the Apple Application Support directory to PATH before trying to load
1825         WebKit so that CoreGraphics.dll and friends can be found.
1826
1827         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
1828
1829         Reviewed by Anders Carlsson.
1830
1831         * DumpRenderTree/win/ImageDiff.vcproj:
1832         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1833         Changed to build ImageDiff.dll instead of ImageDiff.exe.
1834
1835         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
1836         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
1837
1838         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
1839         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
1840         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
1841         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
1842         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
1843         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
1844         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
1845
1846         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
1847         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
1848         to main.
1849
1850         * win/DLLLauncher/DLLLauncherMain.cpp:
1851         (main):
1852         (wWinMain):
1853         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
1854         stub launcher acts as a console program and calls a console version of
1855         dllLauncherEntryPoint.
1856
1857 2012-01-04  Adam Roben  <aroben@apple.com>
1858
1859         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
1860
1861         This allows us to add the Apple Application Support directory to PATH before trying to load
1862         WebKit so that CoreGraphics.dll and friends can be found.
1863
1864         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
1865         double-clicked
1866
1867         Reviewed by Anders Carlsson.
1868
1869         * MiniBrowser/MiniBrowser.vcproj:
1870         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1871         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
1872
1873         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
1874         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
1875         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
1876         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
1877         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
1878         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
1879         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
1880
1881         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
1882         but changed to build the stub launcher.
1883
1884         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
1885         it needs to be compiled into the .exe instead of the .dll.
1886         (DllMain): Added. We use this to store the DLL's HINSTANCE.
1887         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
1888         DLLLauncherMain code.
1889
1890         * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
1891         to here.
1892
1893 2012-01-04  Adam Roben  <aroben@apple.com>
1894
1895         Make WinLauncher's window frame respond to clicks/drags again
1896
1897         Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
1898         bar when Aero is disabled
1899
1900         Reviewed by Brent Fulgham.
1901
1902         * WinLauncher/WinLauncher.cpp:
1903         (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
1904         Also removed an unnecessary "break" keyword.
1905
1906 2012-01-04  Adam Roben  <aroben@apple.com>
1907
1908         Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
1909
1910         This allows us to add the Apple Application Support directory to PATH before trying to load
1911         WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
1912         should use this mechanism.
1913
1914         Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
1915         double-clicked
1916
1917         Reviewed by Anders Carlsson.
1918
1919         * WinLauncher/WinLauncher.cpp: Removed InitInstance.
1920         (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
1921         done by the now-removed InitInstance function.
1922         (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
1923         calls. Merged code from InitInstance into this function, and change to use the global hInst
1924         variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
1925         function, which corresponds to WinLauncher.exe.
1926
1927         * WinLauncher/WinLauncher.vcproj:
1928         * WinLauncher/WinLauncherCommon.vsprops:
1929         Changed to build WinLauncher.dll instead of WinLauncher.exe.
1930
1931         * WinLauncher/WinLauncherLauncher.rc: Added.
1932         * WinLauncher/WinLauncherLauncherResource.h: Added.
1933         This just references the WinLauncher.ico file to set the application icon (though it looks
1934         like that's a default icon).
1935
1936         * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
1937         but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
1938
1939         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
1940         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
1941         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
1942         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
1943         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
1944         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
1945         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
1946
1947         * win/DLLLauncher/DLLLauncherMain.cpp: Added.
1948         (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
1949         program if it detects heap corruption.
1950         (getStringValue): Helper function to read a string value from the registry.
1951         (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
1952         application from the registry.
1953         (appleApplicationSupportDirectory): Helper function to return the path to the Apple
1954         Application Support directory.
1955         (copyEnvironmentVariable): Helper function to copy an environment variable's value.
1956         (prependPath): Helper function to prepend a directory to the PATH.
1957         (fatalError): Helper function to display an error to the user.
1958         (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
1959         dllLauncherEntryPoint function.
1960
1961 2012-01-05  Kentaro Hara  <haraken@chromium.org>
1962
1963         prepare-ChangeLog cannot parse python code that nests classes and defs
1964         https://bugs.webkit.org/show_bug.cgi?id=75524
1965
1966         Reviewed by Ryosuke Niwa.
1967
1968         This patch fixes the python parser of prepare-ChangeLog so that it can parse
1969         python code that nests classes and defs, like this:
1970
1971         class C:
1972             pass
1973             def f():
1974                 pass
1975             pass
1976
1977         Also, this patch fixes the python parser so that it inserts a dummy line
1978         at the end of the file to pop out all popped scopes.
1979
1980         * Scripts/prepare-ChangeLog:
1981         (get_function_line_ranges_for_python):
1982
1983         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
1984         Added test cases that nest classes and defs.
1985         (func7):
1986         (func7.func8):
1987         (func7.func8.func9):
1988         (Class2):
1989         (Class2.Class3):
1990         (Class2.Class3.Class4):
1991         (Class5):
1992         (Class5.func10):
1993         (Class5.func11):
1994         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
1995
1996 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1997
1998         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
1999         https://bugs.webkit.org/show_bug.cgi?id=75433
2000
2001         Reviewed by Martin Robinson.
2002
2003         * MiniBrowser/gtk/BrowserWindow.c:
2004         (webViewLoadFailed): Reset the progress bar when load fails.
2005         (browserWindowConstructed): Connect to load-failed signal.
2006
2007 2012-01-04  Dan Bernstein  <mitz@apple.com>
2008
2009         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
2010         start WebProcess under gdb and WebProcess will then run the client executable.
2011
2012         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
2013
2014         Reviewed by Anders Carlsson.
2015
2016         * Scripts/webkitdirs.pm:
2017         (shouldTargetWebProcess): Added.
2018         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
2019         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
2020         app using the -client-executable option if targeting the web process.
2021
2022 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2023
2024         Adding myself to committers list.
2025
2026         Unreviewed.
2027
2028         * Scripts/webkitpy/common/config/committers.py:
2029
2030 2012-01-04  David Kilzer  <ddkilzer@apple.com>
2031
2032         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
2033
2034         This reverts commit r103546.
2035
2036         * TestWebKitAPI/TestsController.cpp:
2037         (TestWebKitAPI::TestsController::TestsController):
2038
2039 2012-01-04  James Robinson  <jamesr@chromium.org>
2040
2041         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
2042         https://bugs.webkit.org/show_bug.cgi?id=74583
2043
2044         Reviewed by Darin Fisher.
2045
2046         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
2047
2048         * Scripts/webkitpy/style/checkers/cpp.py:
2049         (check_function_definition):
2050
2051 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2052
2053         [Qt] Fix link order of static libraries and unbreak QtWin32
2054
2055         We were keeping the correct static link order between the intermediate
2056         WebKit libraries, but not the internal dependencies for each of those
2057         libraries. The load() will in some instances mess with LIBS, so we need
2058         to ensure that the dependent libraries are added after the library we
2059         are linking against.
2060
2061         Reviewed by Simon Hausmann.
2062
2063         * qmake/mkspecs/features/default_post.prf:
2064
2065 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2066
2067         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
2068
2069         The custom qmake variable 'WEBKIT' is used for signaling that a
2070         target depends in some way on other subproject of the WebKit
2071         project. For now this is limited to the set of intermediate
2072         libraries: wtf, javascriptcore, webcore, and webkit2.
2073
2074         This replaces the previous convension of using load(foo) for
2075         just include paths, and CONFIG += foo to also link against foo.
2076
2077         Adding a dependency results in additional include paths being
2078         available, and potentially linking to the library. This is
2079         decided by the build system based on conditions such as what
2080         kind of target is being built and the general build config.
2081
2082         An advantage to his approach is that it simplifies the individual
2083         foo.prf files, for example by allowing us to use INCLUDEPATH +=
2084         and LIBS += as normal instead of prepending.
2085
2086         Reviewed by Simon Hausmann.
2087
2088         * DumpRenderTree/qt/DumpRenderTree.pro:
2089         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2090         * QtTestBrowser/QtTestBrowser.pro:
2091         * WebKitTestRunner/InjectedBundle/Target.pri:
2092         * WebKitTestRunner/Target.pri:
2093         * qmake/README:
2094         * qmake/mkspecs/features/default_post.prf:
2095         * qmake/mkspecs/features/functions.prf:
2096         * qmake/mkspecs/features/javascriptcore.prf:
2097         * qmake/mkspecs/features/qtwebkit.prf:
2098         * qmake/mkspecs/features/webcore.prf:
2099         * qmake/mkspecs/features/webkit2.prf:
2100         * qmake/mkspecs/features/wtf.prf:
2101
2102 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
2103
2104         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
2105         https://bugs.webkit.org/show_bug.cgi?id=75488
2106
2107         Reviewed by Tor Arne Vestbø.
2108
2109         * MiniBrowser/qt/MiniBrowser.qrc:
2110         * MiniBrowser/qt/qml/BrowserWindow.qml:
2111         * MiniBrowser/qt/qml/Dialog.qml:
2112         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
2113         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
2114
2115 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2116
2117         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
2118
2119         It wasn't really a problem at runtime since the right QtWebKit was
2120         already loaded as a dependency of the web process, but the ldd output
2121         would still be busted.
2122
2123         Reviewed by Simon Hausmann.
2124
2125         * WebKitTestRunner/InjectedBundle/Target.pri:
2126
2127 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2128
2129         [Qt] Move use of $$qtLibraryTarget() to a single place
2130
2131         Reviewed by Kenneth Rohde Christiansen.
2132
2133         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2134         * WebKitTestRunner/InjectedBundle/Target.pri:
2135         * qmake/mkspecs/features/default_post.prf:
2136         * qmake/mkspecs/features/webcore.prf:
2137
2138 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
2139
2140         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
2141         https://bugs.webkit.org/show_bug.cgi?id=75238
2142
2143         Reviewed by Antonio Gomes.
2144
2145         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
2146         it could initiate download directly if it has the download attribute in the link 
2147         and doesn't need to open new blank page for the target="_blank". Enabling this 
2148         feature in the BlackBerry porting also prepares for later blob feature implementation.
2149
2150         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
2151         for the BlackBerry porting.
2152
2153 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2154
2155         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
2156         https://bugs.webkit.org/show_bug.cgi?id=75475
2157
2158         Reviewed by Martin Robinson.
2159
2160         The problem is that the property blurb contains <a ping> and tree
2161         view uses gtk_tooltip_set_markup() internally, so we need to
2162         escape the text.
2163
2164         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2165         (browserSettingsDialogConstructed): Escape property blurb before
2166         storing it in the GtkTreeModel.
2167
2168 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
2169
2170         When showing results.html pass a correct URL to webbrowser.open
2171         https://bugs.webkit.org/show_bug.cgi?id=75438
2172
2173         Reviewed by Adam Barth.
2174
2175         * Scripts/webkitpy/common/system/filesystem.py:
2176         (file_path_as_url):
2177         * Scripts/webkitpy/common/system/filesystem_mock.py:
2178         (file_path_as_url):
2179         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2180         (test_file_path_as_url):
2181         * Scripts/webkitpy/layout_tests/port/base.py:
2182         (show_results_html_file):
2183         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2184         (test_show_results_html_file):
2185         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2186         (test_results_directory_relative):
2187
2188 2012-01-03  Ojan Vafai  <ojan@chromium.org>
2189
2190         shrink the header on the flakiness dashboard
2191         https://bugs.webkit.org/show_bug.cgi?id=65153
2192
2193         Reviewed by Adam Roben.
2194
2195         Move some of the "show" links to be to the right of the header
2196         instead of below the header when they content they're showing
2197         is hidden. That way we don't waste vertical space on them.
2198
2199         No new tests. This code is covered by existing tests.
2200
2201         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2202
2203 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2204
2205         Add a tool to analyze change logs
2206         https://bugs.webkit.org/show_bug.cgi?id=72243
2207
2208         Reviewed by Eric Seidel.
2209
2210         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
2211         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
2212         for visualizing json files.
2213
2214         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
2215         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
2216         generates json files, and N is the number of changelogs to parse.
2217
2218         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
2219         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
2220         * Scripts/webkitpy/tool/commands/__init__.py:
2221         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
2222         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
2223         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
2224         * Scripts/webkitpy/tool/steps/options.py:
2225
2226 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2227
2228         Add a tool to analyze change logs
2229         https://bugs.webkit.org/show_bug.cgi?id=72243
2230
2231         Reviewed by Eric Seidel.
2232
2233         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
2234         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
2235         for visualizing json files.
2236
2237         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
2238         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
2239         generates json files, and N is the number of changelogs to parse.
2240
2241         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
2242         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
2243         * Scripts/webkitpy/tool/commands/__init__.py:
2244         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
2245         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
2246         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
2247         * Scripts/webkitpy/tool/steps/options.py:
2248
2249 2012-01-03  Adam Roben  <aroben@apple.com>
2250
2251         Make Port subclasses override the operating_system method rather than setting an attribute
2252
2253         Without this patch, any use of Port.operating_system() within a port's __init__ method would
2254         return the default value ("mac"). This was confusing the version-checking logic inside
2255         ApplePort.__init__ on Windows.
2256
2257         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
2258         crashes on launch on Windows 7 SP1
2259
2260         Reviewed by Eric Seidel.
2261
2262         * Scripts/webkitpy/layout_tests/port/apple.py:
2263         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
2264
2265         * Scripts/webkitpy/layout_tests/port/base.py:
2266         (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
2267         should now override the operating_system method instead.
2268         (Port.operating_system): Changed to always return "mac". Subclasses should override to
2269         return something else.
2270
2271         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2272         (ChromiumLinuxPort.__init__):
2273         (ChromiumLinuxPort.operating_system):
2274         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2275         (ChromiumMacPort.__init__):
2276         (ChromiumMacPort.operating_system):
2277         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2278         (ChromiumWinPort.__init__):
2279         (ChromiumWinPort.operating_system):
2280         * Scripts/webkitpy/layout_tests/port/mac.py:
2281         (MacPort.__init__):
2282         (MacPort.operating_system):
2283         * Scripts/webkitpy/layout_tests/port/win.py:
2284         (WinPort.__init__):
2285         (WinPort.operating_system):
2286         Changed to override the operating_system method rather than setting the _operating_system
2287         attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
2288
2289         * Scripts/webkitpy/layout_tests/port/qt.py:
2290         (QtPort.__init__):
2291         (QtPort._path_to_webcore_library):
2292         Changed to use self.operating_system() instead of self._operating_system, for consistency
2293         with other Port-related code.
2294
2295         (QtPort.operating_system): Added this override of Port.operating_system that returns the
2296         value we determined in our __init__ method.
2297
2298         * Scripts/webkitpy/layout_tests/port/test.py:
2299         (TestPort.operating_system): Added this override of Port.operating_system that returns the
2300         value we determined in our __init__ method.
2301
2302         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2303         (PortTest.test_operating_system):
2304         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2305         (ChromiumLinuxPortTest.test_operating_system):
2306         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2307         (ChromiumMacPortTest.test_operating_system):
2308         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2309         (ChromiumWinPortTest.test_operating_system):
2310         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2311         (MacPortTest.test_operating_system):
2312         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2313         (QtPortTest.test_operating_system):
2314         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2315         (WinPortTest.test_operating_system):
2316         Test that all ports return the expected operating system string.
2317
2318 2012-01-03  Mario Sanchez Prada  <msanchez@igalia.com>
2319
2320         [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
2321         https://bugs.webkit.org/show_bug.cgi?id=75474
2322
2323         Reviewed by Philippe Normand.
2324
2325         * Scripts/run-gtk-tests: Ignore files whose name does not start
2326         with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
2327
2328 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
2329
2330         [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
2331         https://bugs.webkit.org/show_bug.cgi?id=75472
2332
2333         Reviewed by Tor Arne Vestbø.
2334
2335         * MiniBrowser/qt/MiniBrowser.pro:
2336         * MiniBrowser/qt/MiniBrowser.qrc:
2337         * MiniBrowser/qt/qml/BrowserWindow.qml:
2338         * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
2339
2340 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
2341
2342         [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
2343         https://bugs.webkit.org/show_bug.cgi?id=75471
2344
2345         Reviewed by Tor Arne Vestbø.
2346
2347         Add simple UI for JavaScript Alert dialogs. This patch also adds a
2348         simple DialogButton QML type and a Dialog QML type which will be
2349         reusable for other JavaScript dialogs.
2350
2351         * MiniBrowser/qt/MiniBrowser.qrc:
2352         * MiniBrowser/qt/qml/AlertDialog.qml: Added.
2353         * MiniBrowser/qt/qml/BrowserWindow.qml:
2354         * MiniBrowser/qt/qml/Dialog.qml: Added.
2355         * MiniBrowser/qt/qml/DialogButton.qml: Added.
2356
2357 2012-01-03  Rafael Brandao  <rafael.lobo@openbossa.org>
2358
2359         [Qt][WK2] MiniBrowser doesn't show url bar
2360         https://bugs.webkit.org/show_bug.cgi?id=75470
2361
2362         Reviewed by Tor Arne Vestbø.
2363
2364         * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
2365         on QtDeclarative (QTBUG-23422).
2366
2367 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2368
2369         [GTK] Simplify loader client WebKit2 GTK+ API
2370         https://bugs.webkit.org/show_bug.cgi?id=74605
2371
2372         Reviewed by Gustavo Noronha Silva.
2373
2374         * gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now
2375         private API.
2376
2377 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2378
2379         [Qt] Clean up detection of fontconfig
2380
2381         We decide in features.prf whether or not fontconfig is available, and
2382         set the HAVE_FONTCONFIG define accordingly. All leaf project files
2383         should use this define to decide whether or not to link against
2384         fontconfig, not do their own detection.
2385
2386         We don't need to add link_pkgconfig to CONFIG in each project file,
2387         as we selectivly enable that configuration in defaults_post when
2388         needed.
2389
2390         Reviewed by Ossy.
2391
2392         * DumpRenderTree/qt/DumpRenderTree.pro:
2393         * QtTestBrowser/QtTestBrowser.pro:
2394         * WebKitTestRunner/InjectedBundle/Target.pri:
2395         * qmake/mkspecs/features/unix/default_post.prf:
2396         * qmake/mkspecs/features/unix/default_pre.prf:
2397
2398 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2399
2400         [Qt] Introduce qmake replace function for the active build config
2401
2402         Reviewed by Ossy.
2403
2404         * qmake/mkspecs/features/default_post.prf:
2405         * qmake/mkspecs/features/functions.prf:
2406
2407 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2408
2409         [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()
2410         https://bugs.webkit.org/show_bug.cgi?id=75435
2411
2412         Reviewed by Martin Robinson.
2413
2414         * GNUmakefile.am: Make sure DRT links to X11.
2415         * WebKitTestRunner/GNUmakefile.am: Make sure WTR links to X11.
2416
2417 2011-12-04  Philippe Normand  <pnormand@igalia.com>
2418
2419         [WK2][GTK] WebSettings support in MiniBrowser
2420         https://bugs.webkit.org/show_bug.cgi?id=73773
2421
2422         Reviewed by Martin Robinson.
2423
2424         Patch heavily inspired from the WebKit GtkLauncher to support
2425         command-line WebSettings. Example: --enable-fullscreen=TRUE.
2426         The full list of options can be consulted with --help-websettings.
2427
2428         * MiniBrowser/gtk/main.c:
2429         (loadURI):
2430         (parseOptionEntryCallback):
2431         (isValidParameterType):
2432         (getOptionEntriesFromWebKitSettings):
2433         (addSettingsGroupToContext):
2434         (main):
2435
2436 2012-01-02  Philippe Normand  <pnormand@igalia.com>
2437
2438         [GTK] GtkLauncher settings improvements
2439         https://bugs.webkit.org/show_bug.cgi?id=75439
2440
2441         Reviewed by Martin Robinson.
2442
2443         * GtkLauncher/main.c:
2444         (filenameToURL): We can use NULL in C.
2445         (isValidParameterType): Utility function to filter GParamTypes
2446         that can be edited.
2447         (getOptionEntriesFromWebKitWebSettings): Avoid handling
2448         construct-only properties and use the isValidParameterType
2449         function. Makes the code a bit cleaner.
2450
2451 2012-01-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2452
2453         [EFL] Remove whitespace/declaration style exception
2454         https://bugs.webkit.org/show_bug.cgi?id=75424
2455
2456         Reviewed by David Levin.
2457
2458         Remove *whitespace/eclaration* style rule. However, EWebLauncher and MiniBrowser are EFL simple
2459         application. So, they still need to use EFL coding style.
2460
2461         * Scripts/webkitpy/style/checker.py:
2462
2463 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2464
2465         [GTK] Add a way to change web view settings in MiniBrowser
2466         https://bugs.webkit.org/show_bug.cgi?id=71568
2467
2468         Reviewed by Philippe Normand.
2469
2470         Add a preferences button to the toolbar that shows a dialog to
2471         change settings of the current web view. It uses a GtkTreeView
2472         with a custom cell renderer to support multiple types of values.
2473
2474         * MiniBrowser/gtk/BrowserCellRendererVariant.c: Added.
2475         (browserCellRendererVariantFinalize):
2476         (browserCellRendererVariantGetProperty):
2477         (browserCellRendererVariantSetModeForValue):
2478         (browserCellRendererVariantSetProperty):
2479         (browserCellRendererVariantGetRendererForValue):
2480         (browserCellRendererVariantCellRendererTextEdited):
2481         (browserCellRendererVariantCellRendererSpinEdited):
2482         (browserCellRendererVariantCellRendererActivate):
2483         (browserCellRendererVariantCellRendererRender):
2484         (browserCellRendererVariantCellRendererStartEditing):
2485         (browserCellRendererVariantCellRendererGetPreferredWidth):
2486         (browserCellRendererVariantCellRendererGetPreferredHeight):
2487         (browserCellRendererVariantCellRendererGetPreferredWidthForHeight):
2488         (browserCellRendererVariantCellRendererGetPreferredHeightForWidth):
2489         (browserCellRendererVariantCellRendererGetAlignedArea):
2490         (browser_cell_renderer_variant_init):
2491         (browser_cell_renderer_variant_class_init):
2492         (browser_cell_renderer_variant_new):
2493         * MiniBrowser/gtk/BrowserCellRendererVariant.h: Added.
2494         * MiniBrowser/gtk/BrowserSettingsDialog.c: Added.
2495         (cellRendererChanged):
2496         (browserSettingsDialogSetProperty):
2497         (browser_settings_dialog_init):
2498         (browserSettingsDialogConstructed):
2499         (browser_settings_dialog_class_init):
2500         (browser_settings_dialog_new):
2501         * MiniBrowser/gtk/BrowserSettingsDialog.h: Added.
2502         * MiniBrowser/gtk/BrowserWindow.c:
2503         (settingsCallback):
2504         (browser_window_init):
2505         * MiniBrowser/gtk/GNUmakefile.am:
2506         * MiniBrowser/gtk/browser-marshal.list: Added.
2507
2508 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2509
2510         [GTK] Implement create/ready-to-show/close signals in MiniBrowser
2511         https://bugs.webkit.org/show_bug.cgi?id=74711
2512
2513         Reviewed by Philippe Normand.
2514
2515         * MiniBrowser/gtk/BrowserWindow.c:
2516         (webViewClose): Destroy the window.
2517         (webViewReadyToShow): Use WindowProperties of the new view to
2518         setup and show the window.
2519         (webViewCreate): Create a new view and add it to a browser window.
2520         (browser_window_init):
2521         (browserWindowConstructed): Connect to WebKitWebView::create signal.
2522
2523 2011-12-31  Dan Bernstein  <mitz@apple.com>
2524
2525         MiniBrowser sets the WKView’s frame incorrectly
2526         https://bugs.webkit.org/show_bug.cgi?id=75393
2527
2528         Reviewed by Anders Carlsson.
2529
2530         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed Make Launchable build phase,
2531         which is not needed since the binray is linked with the frameworks search path set to the
2532         built products directory.
2533         * MiniBrowser/mac/BrowserWindowController.m:
2534         (-[BrowserWindowController awakeFromNib]): Changed to set the WKView’s frame to its
2535         container’s bounds rather than its frame.
2536         * MiniBrowser/mac/make-launchable.sh: Removed.
2537
2538 2011-12-29  Dan Bernstein  <mitz@apple.com>
2539
2540         debug-safari --no-saved-state fails to start the debugger
2541         https://bugs.webkit.org/show_bug.cgi?id=75374
2542
2543         Reviewed by Sam Weinig.
2544
2545         * Scripts/webkitdirs.pm:
2546         (execMacWebKitAppForDebugging): Pass the --args option to gdb so that it passes arguments to
2547         the executable being debugged.
2548
2549 2011-12-29  Sam Weinig  <sam@webkit.org>
2550
2551         It should be easier to iterate a Vector backwards
2552         https://bugs.webkit.org/show_bug.cgi?id=75359
2553
2554         Reviewed by Anders Carlsson.
2555
2556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2557         * TestWebKitAPI/TestWebKitAPI.gypi:
2558         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2559         Add new Vector test.
2560
2561         * TestWebKitAPI/Tests/Vector.cpp: Added.
2562         (TestWebKitAPI::TEST):
2563         Test Vector iterators, reverse_iterators and new reversed proxy.
2564
2565 2011-12-28  Dmitry Lomov  <dslomov@google.com>
2566
2567         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2568         https://bugs.webkit.org/show_bug.cgi?id=66509
2569         Just renames, merges and removal of dead code. Here are the list of renames:
2570           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2571           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2572           - WebWorkerBase merged into WebSharedWorkerImpl
2573           - NewWebWorkerBase renamed into WebWorkerBase
2574  
2575         Reviewed by David Levin.
2576
2577         * DumpRenderTree/chromium/TestWebWorker.h:
2578         (TestWebWorker::createWorker):
2579         * DumpRenderTree/chromium/WebViewHost.cpp:
2580         (WebViewHost::createWorker):
2581         * DumpRenderTree/chromium/WebViewHost.h:
2582
2583 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2584
2585         Unreviewed, rolling out r103785.
2586         http://trac.webkit.org/changeset/103785
2587         https://bugs.webkit.org/show_bug.cgi?id=75332
2588
2589         Broke builders; looks like clobbering didnt help (Requested by
2590         dslomov on #webkit).
2591
2592         * DumpRenderTree/chromium/TestWebWorker.h:
2593         (TestWebWorker::createWorker):
2594         * DumpRenderTree/chromium/WebViewHost.cpp:
2595         (WebViewHost::createWorker):
2596         * DumpRenderTree/chromium/WebViewHost.h:
2597
2598 2011-12-28  Dmitry Lomov  <dslomov@google.com>
2599
2600
2601         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2602         https://bugs.webkit.org/show_bug.cgi?id=66509
2603         Just renames, merges and removal of dead code. Here are the list of renames:
2604           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2605           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2606           - WebWorkerBase merged into WebSharedWorkerImpl
2607           - NewWebWorkerBase renamed into WebWorkerBase
2608  
2609         Reviewed by David Levin.
2610
2611         * DumpRenderTree/chromium/TestWebWorker.h:
2612         (TestWebWorker::createWorker):
2613         * DumpRenderTree/chromium/WebViewHost.cpp:
2614         (WebViewHost::createWorker):
2615         * DumpRenderTree/chromium/WebViewHost.h:
2616
2617 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2618
2619         Unreviewed, rolling out r103620.
2620         http://trac.webkit.org/changeset/103620
2621         https://bugs.webkit.org/show_bug.cgi?id=75316
2622
2623         Causes many crashes (Requested by abarth on #webkit).
2624
2625         * DumpRenderTree/chromium/LayoutTestController.cpp:
2626         (LayoutTestController::LayoutTestController):
2627         (LayoutTestController::reset):
2628         * DumpRenderTree/chromium/LayoutTestController.h:
2629         * DumpRenderTree/chromium/WebViewHost.cpp:
2630         * DumpRenderTree/chromium/WebViewHost.h:
2631
2632 2011-12-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2633
2634         Unreviewed, rolling out r103734.
2635         http://trac.webkit.org/changeset/103734
2636         https://bugs.webkit.org/show_bug.cgi?id=75278
2637
2638         Broke cr-mac (Requested by dslomov on #webkit).
2639
2640         * DumpRenderTree/chromium/TestWebWorker.h:
2641         (TestWebWorker::createWorker):
2642         * DumpRenderTree/chromium/WebViewHost.cpp:
2643         (WebViewHost::createWorker):
2644         * DumpRenderTree/chromium/WebViewHost.h:
2645
2646 2011-12-27  Dmitry Lomov  <dslomov@google.com>
2647
2648
2649         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2650         https://bugs.webkit.org/show_bug.cgi?id=66509
2651         Just renames, merges and removal of dead code. Here are the list of renames:
2652           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2653           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2654           - WebWorkerBase merged into WebSharedWorkerImpl
2655           - NewWebWorkerBase renamed into WebWorkerBase
2656  
2657         Reviewed by David Levin.
2658
2659         * DumpRenderTree/chromium/TestWebWorker.h:
2660         (TestWebWorker::createWorker):
2661         * DumpRenderTree/chromium/WebViewHost.cpp:
2662         (WebViewHost::createWorker):
2663         * DumpRenderTree/chromium/WebViewHost.h:
2664
2665 2011-12-27  Anders Carlsson  <andersca@apple.com>
2666
2667         Function should handle wrapping/unwrapping RefPtr and PassRefPtr
2668         https://bugs.webkit.org/show_bug.cgi?id=75266
2669
2670         Reviewed by Sam Weinig.
2671
2672         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2673         (TestWebKitAPI::Number::create):
2674         (TestWebKitAPI::Number::~Number):
2675         (TestWebKitAPI::Number::value):
2676         (TestWebKitAPI::Number::Number):
2677         (TestWebKitAPI::multiplyNumberByTwo):
2678         (TestWebKitAPI::TEST):
2679
2680 2011-12-24  Kentaro Hara  <haraken@chromium.org>
2681
2682         Add unittests for the C++ parser of prepare-ChangeLog
2683         https://bugs.webkit.org/show_bug.cgi?id=75191
2684
2685         Reviewed by Ryosuke Niwa.
2686
2687         cpp_unittests.cpp is the unittests for get_function_line_ranges_for_cpp()
2688         of prepare-ChangeLog.
2689
2690         * Scripts/prepare-ChangeLog:
2691         (get_function_line_ranges): Renames get_function_line_ranges_for_c()
2692         to get_function_line_ranges_for_cpp().
2693         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2694         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Added.
2695         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added.
2696         (func1):
2697         (func2):
2698         (func3):
2699         (func4):
2700         (func5):
2701         (func6):
2702         (func7):
2703         (func8):
2704         (func9):
2705         (func10):
2706         (func11):
2707         (func12):
2708         (func13):
2709         (func14):
2710         (func15):
2711         (funcOverloaded):
2712         (Class::func16):
2713         (Class1::Class2::func17):
2714         (Class2::func18):
2715         (Class2::func19):
2716         (Class2::func20):
2717         (Class2::func21):
2718         (Class2::func22):
2719         (func23):
2720         (func24):
2721         (Class2::func25):
2722         (Class1::func26):
2723         (Class2::func27):
2724         (Class3::func28):
2725         (Class7::operator+):
2726         (Class100::Class100):
2727         (Class101::~Class101):
2728         (Class102::Class102):
2729         (Class103::Class103):
2730         (Struct1::func29):
2731         (Struct2::func30):
2732         (NameSpace1::func30):
2733         (NameSpace1::NameSpace2::func31):
2734
2735 2011-12-24  Kentaro Hara  <haraken@chromium.org>
2736
2737         Add unittests for the Java parser of prepare-ChangeLog
2738         https://bugs.webkit.org/show_bug.cgi?id=75195
2739
2740         Reviewed by Ryosuke Niwa.
2741
2742         java_unittests.java is unittest cases for get_function_line_ranges_for_java()
2743         of prepare-ChangeLog.
2744
2745         * Scripts/prepare-ChangeLog:
2746         (get_function_line_ranges_for_java): Fixed a parser bug.
2747
2748             interface I
2749             {
2750                 void f()
2751                 {
2752                 }
2753             }
2754
2755         should be recognized as "I.f", and
2756
2757             class C interface I
2758             {
2759                 void f()
2760                 {
2761                 }
2762             }
2763
2764         should be recognized as "C.f".
2765         Without this patch, both are recognized as "I.f".
2766
2767         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2768         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Added.
2769         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests.java: Added.
2770         (Simple):
2771         (Simple.func1):
2772         (Simple.func2):
2773         (Simple.func3):
2774         (Simple.func4):
2775         (Simple.func5):
2776         (Simple.func6):
2777         (Simple.func7):
2778         (Simple.func8):
2779         (Simple.func9):
2780         (Simple.func10):
2781         (Simple.funcOverloaded):
2782         (Simple.func11):
2783         (Simple.func12):
2784         (Simple.func13):
2785         (Simple.func14):
2786         (Simple.func15):
2787         (Simple.func16):
2788         (Simple.func17):
2789         (Simple.func18):
2790         (Simple.func19):
2791         (Simple.func20):
2792         (Simple.func21):
2793         (Derived1):
2794         (Derived1.Derived1):
2795         (Derived1.func22):
2796         (Interface1):
2797         (Interface2):
2798         (Interface2.func23):
2799         (Derived2):
2800         (Derived2.Derived2):
2801         (Derived2.func23):
2802
2803 2011-12-24  Kentaro Hara  <haraken@chromium.org>
2804
2805         Add unittests for the Python parser of prepare-ChangeLog
2806         https://bugs.webkit.org/show_bug.cgi?id=75197
2807
2808         Reviewed by Ryosuke Niwa.
2809
2810         python_unittests.py is the unittest for get_function_line_ranges_for_python()
2811         of prepare-ChangeLog. The unittest just contains classes and defs that are not nested.
2812         This is because the current python parser is wrong, and it cannot correctly parse nested
2813         classes and defs (even one def in a class), nor class inheritance.
2814         We will fix it in another patch.
2815
2816         * Scripts/prepare-ChangeLog:
2817         (get_function_line_ranges_for_python): Ignores comment lines that starts from #.
2818         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2819         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Added.
2820         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py: Added.
2821         (func1):
2822         (func2):
2823         (func3):
2824         (funcInsideComment):
2825         (func4):
2826         (func5):
2827         (func6):
2828         (funcOverloaded):
2829         (Class1):
2830
2831 2011-12-24  Dan Bernstein  <mitz@apple.com>
2832
2833         Set SHARED_PRECOMPS_DIR when Xcode is set to use a custom build product path.
2834
2835         Reviewed by Anders Carlsson.
2836
2837         * Scripts/webkitdirs.pm:
2838         (determineBaseProductDir):
2839
2840 2011-12-24  Dan Bernstein  <mitz@apple.com>
2841
2842         Make build-webkit aware of additional Xcode build location defaults.
2843
2844         Reviewed by Anders Carlsson.
2845
2846         * Scripts/webkitdirs.pm:
2847         (determineXcodeVersion): Added. This was previously in determineBaseProductDir().
2848         (readXcodeUserDefault): Added. Factored out from determineBaseProductDir().
2849         (determineBaseProductDir): Changed to check for a custom build location
2850         style specified as an absolute location.
2851
2852 2011-12-24  Ryosuke Niwa  <rniwa@webkit.org>
2853
2854         Unreviewed, rolling out r103619.
2855         http://trac.webkit.org/changeset/103619
2856         https://bugs.webkit.org/show_bug.cgi?id=66509
2857
2858         Broke chromium clang build
2859
2860         * DumpRenderTree/chromium/TestWebWorker.h:
2861         (TestWebWorker::createWorker):
2862         * DumpRenderTree/chromium/WebViewHost.cpp:
2863         (WebViewHost::createWorker):
2864         * DumpRenderTree/chromium/WebViewHost.h:
2865
2866 2011-12-23  Daniel Bates  <dbates@webkit.org>
2867
2868         Provide option to disable Mac OS 10.7 application resume when using
2869         {debug, run}-{safari, minibrowser, test-runner, test-webkit-api}, and run-webkit-app
2870         https://bugs.webkit.org/show_bug.cgi?id=66902
2871
2872         Reviewed by David Kilzer.
2873
2874         Add an optional command line argument --no-saved-state to disable
2875         application resume (state restoration) for the session on Mac OS 10.7.
2876
2877         For instance, when debugging an issue in Safari it is useful to be able
2878         to temporarily disable application resume. Currently you can disable
2879         application resume when launching Safari from within Xcode. We should
2880         expose a similar option in our command line tools.
2881
2882         * Scripts/debug-minibrowser: Call printHelpAndExitForRunAndDebugWebKitAppIfNeeded()
2883         to print a help message and exit() if the command line argument --help was given.
2884         * Scripts/debug-safari: Ditto.
2885         * Scripts/debug-test-runner: Ditto.
2886         * Scripts/run-minibrowser: Ditto.
2887         * Scripts/run-safari: Ditto.
2888         * Scripts/run-test-runner: Ditto.
2889         * Scripts/run-test-webkit-api: Ditto.
2890         * Scripts/run-webkit-app: Ditto.
2891         * Scripts/webkitdirs.pm:
2892         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Added.
2893         (argumentsForRunAndDebugMacWebKitApp): Added.
2894         (runMacWebKitApp): If the --no-saved-state command line argument was given then
2895         disable application resume for the session.
2896         (execMacWebKitAppForDebugging): Ditto.
2897
2898 2011-12-23  Dmitry Lomov  <dslomov@google.com>
2899
2900         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2901         https://bugs.webkit.org/show_bug.cgi?id=66509
2902         Just renames, merges and removal of dead code. Here are the list of renames:
2903           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2904           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2905           - WebWorkerBase merged into WebSharedWorkerImpl
2906           - NewWebWorkerBase renamed into WebWorkerBase
2907  
2908         Reviewed by David Levin.
2909
2910         * DumpRenderTree/chromium/TestWebWorker.h:
2911         (TestWebWorker::createWorker):
2912         * DumpRenderTree/chromium/WebViewHost.cpp:
2913         (WebViewHost::createWorker):
2914         * DumpRenderTree/chromium/WebViewHost.h:
2915
2916 2011-12-23  Kentaro Hara  <haraken@chromium.org>
2917
2918         Let parser_unittests.pl call different language parsers
2919         https://bugs.webkit.org/show_bug.cgi?id=75081
2920
2921         Reviewed by David Kilzer.
2922
2923         We introduced parser_unittests.pl in bug 74994 , but it is implemented
2924         to always call get_function_line_ranges_for_perl(). In order to enable unittests
2925         for other languages, this patch lets parser_unittests.pl call different language
2926         parsers depending on the languages.
2927
2928         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
2929
2930         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2931
2932 2011-12-22  Adam Roben  <aroben@apple.com>
2933
2934         Snow Leopard test fix
2935
2936         * Scripts/webkitpy/test/main.py:
2937         (Tester.run_tests): Python 2.6.1 doesn't seem to like specifying testRunner=None to
2938         unittest.main, even though that's the default. So now we explicitly specify a
2939         TextTestRunner.
2940
2941 2011-12-22  Chris Fleizach  <cfleizach@apple.com>
2942
2943         AX: attributed strings do not include AXHeading information when a link is contained within the heading
2944         https://bugs.webkit.org/show_bug.cgi?id=75059
2945
2946         Reviewed by Darin Adler.
2947
2948         Support the ability to check if an arbitrary attribute is present within an
2949         attributed string that can be retrieved through an AccessibilityTextMarkerRange.
2950
2951         * DumpRenderTree/AccessibilityUIElement.cpp:
2952         (attributedStringForTextMarkerRangeContainsAttributeCallback):
2953         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2954         (AccessibilityUIElement::getJSClass):
2955         * DumpRenderTree/AccessibilityUIElement.h:
2956         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2957         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2958         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2959         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2960         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2961         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2962         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2963         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2964
2965 2011-12-22  David Kilzer  <ddkilzer@apple.com>
2966
2967         run-api-tests: runAllTests() and runTest() should not use global variables
2968
2969         Reviewed by Adam Roben.
2970
2971         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2972
2973         * Scripts/run-api-tests:
2974         (runTestsBySuite): Rename from runAllTests().  Add arguments for
2975         list of tests and $verbose.
2976         (runTest): Add $verbose argument.
2977
2978 2011-12-22  David Kilzer  <ddkilzer@apple.com>
2979
2980         run-api-tests: inline runAllTestsInSuite() into runAllTests()
2981
2982         Reviewed by Adam Roben.
2983
2984         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2985
2986         In order to make it easy to run one or more individual suites,
2987         or one more individual tests, it's easier to call a single
2988         method with different data structures than individual methods.
2989
2990         * Scripts/run-api-tests:
2991         (runAllTests): Inline runAllTestsInSuite().
2992
2993 2011-12-22  Adam Roben  <aroben@apple.com>
2994
2995         Add a --xml flag to test-webkitpy
2996
2997         test-webkitpy --xml will, in addition to providing the standard text output on stdout, write
2998         JUnit-style XML files to a test-webkitpy-xml-reports subdirectory in the working directory.
2999         This is useful for working with tools that consume JUnit-style XML files.
3000
3001         Fixes <http://webkit.org/b/75090> Would like a way to generate JUnit-style XML files when
3002         running test-webkitpy
3003
3004         Reviewed by Darin Adler.
3005
3006         * Scripts/webkitpy/test/main.py:
3007         (Tester.run_tests): If the --xml flag is passed, create an XMLTestRunner and pass it to
3008         unittest.main(). Otherwise pass no test runner so that unittest will choose its own default.
3009
3010         * Scripts/webkitpy/thirdparty/__init__.py:
3011         (AutoinstallImportHook.find_module):
3012         (AutoinstallImportHook._install_xmlrunner):
3013         Added code to install unittest-xml-reporting as webkitpy.thirdparty.autoinstalled.xmlrunner.
3014         This change is untested because it's basically impossible to get a test to pass when --xml
3015         is passed to test-webkitpy (because xmlrunner will already have been imported by the time
3016         the test runs).
3017
3018 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3019
3020         TestWebKitAPI: initialize the main thread before running tests
3021         <http://webkit.org/b/75064>
3022
3023         Reviewed by Adam Roben.
3024
3025         * TestWebKitAPI/TestsController.cpp:
3026         (TestWebKitAPI::TestsController::TestsController): Call
3027         WTF::initializeMainThread() to prevent assertions in Debug
3028         builds.
3029
3030 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3031
3032         run-api-tests: dumpAllTests() should not use global variables
3033
3034         Reviewed by Adam Roben.
3035
3036         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3037
3038         * Scripts/run-api-tests: Renamed $dump to $dumpTests.
3039         (dumpTestsBySuite): Rename from dumpAllTests() and pass in
3040         global data as an argument.  Sort suite names and test names
3041         alphabetically to match output when running tests.
3042
3043 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
3044
3045         [BlackBerry] Enable blob for the BlackBerry porting
3046         https://bugs.webkit.org/show_bug.cgi?id=75074
3047
3048         Reviewed by George Staikos.
3049
3050         * Scripts/build-webkit:
3051
3052 2011-12-22  Kentaro Hara  <haraken@chromium.org>
3053
3054         Add unittests for the Perl parser of prepare-ChangeLog
3055         https://bugs.webkit.org/show_bug.cgi?id=74994
3056
3057         Reviewed by David Kilzer.
3058
3059         This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
3060
3061         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
3062
3063         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
3064         Runs unittests specified in @testFiles.
3065         You can reset expected results by specifying a --reset-results option.
3066         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
3067         Contains simple methods.
3068         (func1):
3069         (func2):
3070         (func3):
3071         (func4):
3072         (func5):
3073         (func6):
3074         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
3075         This test result is generated by the --reset-results option.
3076
3077 2011-12-21  Eric Seidel  <eric@webkit.org>
3078
3079         Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
3080         so that they appear in the bugzilla autocomplete CC list.
3081         I also removed the "radar" irc nick (which I believe does not exist)
3082         and removed the uneeded [] around the radar bugzilla email.
3083
3084         Unreviewed.
3085
3086         * Scripts/webkitpy/common/config/committers.py:
3087
3088 2011-12-21  Daniel Bates  <dbates@rim.com>
3089
3090         Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
3091         https://bugs.webkit.org/show_bug.cgi?id=74985
3092
3093         Reviewed by Eric Seidel.
3094
3095         * Scripts/build-jsc:
3096         * Scripts/webkitdirs.pm:
3097         (cmakeBasedPortName): Added.
3098
3099 2011-12-21  Daniel Bates  <dbates@rim.com>
3100
3101         Extract BlackBerry CMake arguments from build-webkit into separate function
3102         https://bugs.webkit.org/show_bug.cgi?id=74981
3103
3104         Reviewed by Rob Buis.
3105
3106         Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
3107         the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
3108         and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
3109         This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
3110         that we can pass them to the CMake build system when building JavaScriptCore.
3111
3112         * Scripts/build-webkit: Move construction of CMake argument list from here to
3113         webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
3114         since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
3115         call it from build-webkit.
3116         * Scripts/webkitdirs.pm:
3117         (blackberryCMakeArguments): Added.
3118         (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
3119         BlackBerry port.
3120
3121 2011-12-21  Daniel Bates  <dbates@webkit.org>
3122
3123         Extract WinCE CMake arguments from build-webkit into separate function
3124         https://bugs.webkit.org/show_bug.cgi?id=74983
3125
3126         Reviewed by Rob Buis.
3127
3128         Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
3129         WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
3130         This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
3131         that we can pass it to the CMake build system when building JavaScriptCore.
3132
3133         * Scripts/build-webkit:
3134         * Scripts/webkitdirs.pm:
3135         (cmakeBasedPortArguments): Added.
3136
3137 2011-12-21  Kentaro Hara  <haraken@chromium.org>
3138
3139         In prepare-ChangeLog, replace constant global variables with "use constant"
3140         https://bugs.webkit.org/show_bug.cgi?id=74992
3141
3142         Reviewed by Ryosuke Niwa.
3143
3144         This patch replaces the following constant global variables with "use constant"s.
3145             - $changeLogTimeZone
3146             - $SVN
3147             - $GIT
3148             - %supportedTestExtensions
3149
3150         * Scripts/prepare-ChangeLog:
3151         (changeLogNameFromArgs):
3152         (changeLogEmailAddressFromArgs):
3153         (resolveConflictedChangeLogs):
3154         (generateNewChangeLogs):
3155         (diffCommand):
3156         (statusCommand):
3157         (createPatchCommand):
3158         (findOriginalFileFromSvn):
3159         (determinePropertyChanges):
3160         (generateFileList):
3161         (reviewerAndDescriptionForGitCommit):
3162
3163 2011-12-20  Dirk Pranke  <dpranke@chromium.org>
3164
3165         nrwt: rename field references from _fs to _filesystem
3166         https://bugs.webkit.org/show_bug.cgi?id=74898
3167
3168         Reviewed by Adam Barth.
3169
3170         This is a simple cleanup; most of the code uses
3171         self._filesystem, but some used self._fs; this change renames
3172         the latter to the former to be more consistent.
3173
3174         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3175         (Manager.__init__):
3176         (Manager.collect_tests):
3177         (Manager._strip_test_dir_prefix):
3178         (Manager._split_into_chunks_if_necessary):
3179         (Manager.results_directory):
3180         (Manager._clobber_old_results):
3181         (Manager._upload_json_files):
3182         (Manager.print_config):
3183         (Manager._copy_results_html_file):
3184         (Manager._show_results_html_file):
3185         (Manager._log_worker_stack):
3186         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3187         (JSONLayoutResultsGenerator._normalize_results_json):
3188         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3189         (JSONResultsGeneratorBase.__init__):
3190         (JSONResultsGeneratorBase.generate_json_output):
3191         (JSONResultsGeneratorBase.generate_times_ms_file):
3192         (JSONResultsGeneratorBase.upload_json_files):
3193         (JSONResultsGeneratorBase._get_svn_revision):
3194         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3195         (Base.__init__):
3196
3197 2011-12-20  Kentaro Hara  <haraken@chromium.org>
3198
3199         Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
3200         https://bugs.webkit.org/show_bug.cgi?id=74836
3201
3202         Reviewed by David Kilzer.
3203
3204         webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
3205         This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
3206         for unit-testing of other Perl scripts. We are planning to use it for unit-testing
3207         of prepare-ChangeLog.
3208
3209         Using LoadAsModule.pm, you can load a Perl script as follows.
3210         The first argument is the arbitrary package name you want to use, and the second argument
3211         is the name of the Perl script you want to load.
3212
3213             use LoadAsModule qw(RunLeaks run-leaks);
3214             RunLeaks::someFunctionDefinedInRunLeaks(...);
3215
3216         Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
3217                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
3218                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
3219
3220         * Scripts/webkitperl/LoadAsModule.pm: Added.
3221         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
3222         (import):
3223         (readFile):
3224         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
3225         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
3226         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
3227
3228 2011-12-20  Balazs Kelemen  <kbalazs@webkit.org>
3229
3230         [Qt] WK2 Debugging quirks need some improvement
3231         https://bugs.webkit.org/show_bug.cgi?id=74859
3232
3233         Reviewed by Simon Hausmann.
3234
3235         Improvements added to make debugging WebKit2 more
3236         confortable and efficient:
3237         1. Unify debugging quirks. From now all of them are controlled
3238         by the QT_WEBKIT2_DEBUG environment variable.
3239         2. Disable crash handlers for WebKitTestRunner if debugging quirks
3240         are used to make it possible to use postmortem debugging via core dumps
3241         which is extremely useful for debugging bugs triggered by layout tests.
3242         3. Disable test timeout for WebKitTestRunner if debugging quirks
3243         are used because that makes debugging impossible.
3244
3245         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3246         (WTR::InjectedBundle::platformInitialize):
3247         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3248         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3249         * WebKitTestRunner/qt/TestControllerQt.cpp:
3250         (WTR::TestController::platformRunUntil):
3251
3252 2011-12-20  Rafael Brandao  <rafael.lobo@openbossa.org>
3253
3254         [Qt][WK2] Implement favicon support
3255         https://bugs.webkit.org/show_bug.cgi?id=71082
3256
3257         Reviewed by Simon Hausmann.
3258
3259         A favorite icon was added on MiniBrowser's url bar as example.
3260         We display a default icon when the page doesn't have an icon ready.
3261
3262         * MiniBrowser/qt/MiniBrowser.qrc:
3263         * MiniBrowser/qt/icons/favicon.png: Added.
3264         * MiniBrowser/qt/qml/BrowserWindow.qml:
3265
3266 2011-12-19  Sam Weinig  <sam@webkit.org>
3267
3268         Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
3269         https://bugs.webkit.org/show_bug.cgi?id=74907
3270
3271         Reviewed by Dan Bernstein.
3272
3273         Add ScrollByLineCommands API test.
3274
3275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3276         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
3277         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
3278
3279 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3280
3281         webkitpy: remove port.executive, port.filesystem, port.user properties
3282         https://bugs.webkit.org/show_bug.cgi?id=74896
3283
3284         Reviewed by Eric Seidel.
3285
3286         Following on the refactoring of the port and host objects, this
3287         removes the public executive, filesystem, and user properties
3288         from the Port interface (protected versions of executive and
3289         filesystem still exist). There is still some more clean up to
3290         make the code more consistent and rearrange some other files to
3291         talk to Hosts directly instead of getting them off of the Port
3292         class.
3293
3294         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3295         (Manager.__init__):
3296         (Manager.results_directory):
3297         (Manager._log_worker_stack):
3298         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3299         (ManagerTest.test_fallback_path_in_config):
3300         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3301         (_InlineManager.start_worker):
3302         (_InlineWorkerConnection.__init__):
3303         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3304         (Worker.safe_init):
3305         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3306         (TestConfiguration.from_port):
3307         * Scripts/webkitpy/layout_tests/port/base.py:
3308         (Port.__init__):
3309         (Port.tests):
3310         (Port.show_results_html_file):
3311         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3312         (PortTest.test_layout_tests_skipping):
3313         (PortTest.test_test_dirs):
3314         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3315         (_set_up_derived_options):
3316         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3317         (PerfTestsRunner.__init__):
3318         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3319         (HtmlGenerator.__init__):
3320         (HtmlGenerator.show_html):
3321         (real_main):
3322         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3323         (TestHtmlGenerator.make_generator):
3324
3325 2011-12-19  Daniel Bates  <dbates@webkit.org>
3326
3327         Pass command line arguments to GDB when debugging a Mac WebKit application
3328         https://bugs.webkit.org/show_bug.cgi?id=72829
3329
3330         Reviewed by David Kilzer.
3331
3332         Pass through any command line arguments given to debug-{safari, minibrowser}
3333         to GDB so that they may influence the application instance launched by GDB.
3334
3335         * Scripts/webkitdirs.pm:
3336         (execMacWebKitAppForDebugging):
3337
3338 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3339
3340         webkitpy: remove executive,filesystem,user parameters from Port constructor
3341         https://bugs.webkit.org/show_bug.cgi?id=74878
3342
3343         Reviewed by Eric Seidel.
3344
3345         This change concludes the refactoring that makes Host a required
3346         parameter for Port and ensures that all access to filesystem,
3347         executives, etc. is going through the Host.
3348
3349         * Scripts/webkitpy/layout_tests/port/base.py:
3350         (Port.__init__):
3351
3352 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3353
3354         webkitpy: finish refactoring port classes to make a host mandatory
3355         https://bugs.webkit.org/show_bug.cgi?id=74566
3356
3357         Reviewed by Eric Seidel.
3358
3359         This change makes all Port objects take a required (System)Host
3360         parameter, and updates the TestPort object to no longer create a
3361         mock filesystem or add files to the existing filesystem by
3362         default.
3363
3364         * Scripts/webkitpy/layout_tests/port/base.py:
3365         (Port.__init__):
3366         * Scripts/webkitpy/layout_tests/port/factory.py:
3367         (PortFactory.__init__):
3368         (PortFactory._get_kwargs):
3369         * Scripts/webkitpy/layout_tests/port/test.py:
3370         (TestInstance.__init__):
3371         (TestPort.__init__):
3372         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3373         (passing_run):
3374         (logging_run):
3375         (get_tests_run):
3376         (MainTest.test_single_file):
3377         (MainTest.test_stderr_is_saved):
3378         (MainTest.test_test_list):
3379         (MainTest.test_test_list_with_prefix):
3380         (MainTest.test_missing_and_unexpected_results):
3381         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
3382         (MainTest.test_crash_with_stderr):
3383         (MainTest.test_no_image_failure_with_image_diff):
3384         (MainTest.test_crash_log):
3385         (MainTest.test_web_process_crash_log):
3386         (MainTest.test_exit_after_n_failures_upload):
3387         (MainTest.test_results_directory_absolute):
3388         (MainTest.test_results_directory_relative):
3389         (MainTest.test_retries_directory):
3390         (MainTest.test_tolerance.get_port_for_run):
3391         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
3392         (EndToEndTest.test_end_to_end):
3393         (EndToEndTest.test_reftest_with_two_notrefs):
3394         (RebaselineTest.test_reset_results):
3395         (RebaselineTest.test_missing_results):
3396         (RebaselineTest.test_new_baseline):
3397         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3398         (Rebaseliner.__init__):
3399         (main):
3400         (real_main):
3401         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3402         (test_host_port_and_filesystem):
3403         (TestRebaseliner.make_rebaseliner):
3404         (TestRealMain.test_all_platforms):
3405         (TestHtmlGenerator.make_generator):
3406
3407 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3408
3409         webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
3410         https://bugs.webkit.org/show_bug.cgi?id=74562
3411
3412         Reviewed by Eric Seidel.
3413
3414         Apart from a minor change to style/checkers/test_expectations.py
3415         to take a host as a parameter to a TestExpectationsChecker(),
3416         there are only refactoring changes to unit tests here.
3417
3418         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3419         (TestResultWriterTest.test_reftest_diff_image):
3420         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3421         (JSONGeneratorTest._test_json_generation):
3422         (JSONGeneratorTest.test_test_timings_trie):
3423         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3424         (Base.__init__):
3425         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3426         (PortTest.make_port):
3427         (PortTest.test_layout_tests_skipping):
3428         (PortTest.test_test_dirs):
3429         (PortTest.test_additional_platform_directory):
3430         (PortTest.test_uses_test_expectations_file):
3431         (PortTest.test_find_no_paths_specified):
3432         (PortTest.test_find_one_test):
3433         (PortTest.test_find_glob):
3434         (PortTest.test_find_with_skipped_directories):
3435         (PortTest.test_find_with_skipped_directories_2):
3436         (PortTest.test_parse_reftest_list):
3437         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3438         (DryRunPort.__init__):
3439         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3440         (FactoryTest.setUp):
3441         (FactoryTest.tearDown):
3442         (FactoryTest.assert_port):
3443         (FactoryTest.assert_platform_port):
3444         (FactoryTest.test_unknown_specified):
3445         (FactoryTest.test_unknown_default):
3446         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3447         (GetGoogleChromePortTest._verify_expectations_overrides):
3448         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3449         (MockDRTPortTest.make_port):
3450         (MockDRTTest.assertTest):
3451         (MockDRTTest.test_main):
3452         (MockChromiumDRTTest.test_pixeltest__fails):
3453         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3454         (QtPortTest._assert_search_path):
3455         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3456         (TestWebKitPort.__init__):
3457         (WebKitPortTest.test_skipped_directories_for_symbols):
3458         (test_skipped_directories_for_features):
3459         (test_skipped_layout_tests):
3460         (test_skipped_file_search_paths):
3461         (test_root_option):
3462         (test_test_expectations):
3463         (test_build_driver):
3464         (test_linux_distro_detection):
3465         (test_apache_config_file_name_for_platform):
3466         (test_path_to_apache_config_file):
3467         (WebKitDriverTest.test_read_block):
3468         * Scripts/webkitpy/style/checkers/test_expectations.py:
3469         (TestExpectationsChecker.__init__):
3470         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3471         (TestExpectationsTestCase._expect_port_for_expectations_path):
3472         (TestExpectationsTestCase.assert_lines_lint):
3473         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3474         (get_test_config.TestMacPort):
3475
3476 2011-12-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
3477
3478         [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
3479         https://bugs.webkit.org/show_bug.cgi?id=74854
3480
3481         Reviewed by Csaba Osztrogonác.
3482
3483         Since r101052, libewebkit.so is built in a different location, so we
3484         need to adjust the path returned by builtDylibPathForName.
3485
3486         usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
3487         port also respects Release/Debug configurations.
3488
3489         These changes should make run-launcher finally work correctly with
3490         webkit-efl.
3491
3492         * Scripts/webkitdirs.pm:
3493         (usesPerConfigurationBuildDirectory):
3494         (builtDylibPathForName):
3495
3496 2011-12-19  Simon Hausmann  <simon.hausmann@nokia.com>
3497
3498         [Qt][WK2] Add support for modal event loop processing for WTR
3499         https://bugs.webkit.org/show_bug.cgi?id=74852
3500
3501         Reviewed by Kenneth Rohde Christiansen.
3502
3503         Rewrote event loop processing: Instead of terminating the event loop
3504         in notifyDone() - something no other platform does - we now respect the
3505         "bool& condition" parameter passed to platformRunUntil. This ensures
3506         proper termination even when the condition is changed from within a
3507         nested event loop, because only when we _exit_ from the nested event
3508         loop we will check the condition and terminate the test properly.
3509
3510         In addition this patch implements TestController::runModal by means of
3511         a nested event loop, which is passed to the platform webview that is
3512         supposed to be modal. It is that view's responsibility to exit the
3513         loop, upon destruction. I believe that's similar to how it works on the Mac,
3514         where it doesn't seem that NSApp's runModalForWindow is terminate via
3515         abort/stopModal but simply because the window is closed.
3516
3517         * WebKitTestRunner/PlatformWebView.h:
3518         (WTR::PlatformWebView::setModalEventLoop):
3519         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3520         (WTR::PlatformWebView::PlatformWebView):
3521         (WTR::PlatformWebView::~PlatformWebView):
3522         * WebKitTestRunner/qt/TestControllerQt.cpp:
3523         (WTR::TestController::notifyDone):
3524         (WTR::TestController::platformRunUntil):
3525         (WTR::TestController::runModal):
3526
3527 2011-12-18  Kentaro Hara  <haraken@chromium.org>
3528
3529         REGRESSION(r103149): prepare-ChangeLog outputs a warning
3530         https://bugs.webkit.org/show_bug.cgi?id=74808
3531
3532         Reviewed by David Kilzer.
3533
3534         Added the prototype declaration of main() to avoid warning messages.
3535         Sorted subroutine declarations in the alphabetical order.
3536
3537         * Scripts/prepare-ChangeLog:
3538
3539 2011-12-17  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3540
3541         [Qt] Fix QtTestBrowser compilation with QtWidgets module
3542         https://bugs.webkit.org/show_bug.cgi?id=74791
3543
3544         Reviewed by Andreas Kling.
3545
3546         * QtTestBrowser/QtTestBrowser.pro:
3547
3548 2011-12-17  Kentaro Hara  <haraken@chromium.org>
3549
3550         Remove top-level code completely from prepare-ChangeLog
3551         https://bugs.webkit.org/show_bug.cgi?id=74698
3552
3553         Reviewed by Darin Adler.
3554
3555         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
3556         This patch just moves all top-level code into main().
3557
3558         * Scripts/prepare-ChangeLog:
3559         (main):
3560
3561 2011-12-16  Dean Jackson  <dino@apple.com>
3562
3563         Move webkit-bug-importer to Contributor. It won't
3564         autocomplete as an Account.
3565         See https://bugs.webkit.org/show_bug.cgi?id=74739
3566         for some discussion.
3567
3568         Unreviewed.
3569
3570         * Scripts/webkitpy/common/config/committers.py:
3571
3572 2011-12-16  Dean Jackson  <dino@apple.com>
3573
3574         Add webkit-bug-importer@group.apple.com to accounts
3575         so that it autocompletes in bugzilla.
3576
3577         Unreviewed.
3578
3579         * Scripts/webkitpy/common/config/committers.py:
3580
3581 2011-12-16  Philippe Normand  <pnormand@igalia.com>
3582
3583         Unreviewed, skipping 3 failing GTK API tests.
3584
3585         * Scripts/run-gtk-tests:
3586
3587 2011-12-16  Philippe Normand  <pnormand@igalia.com>
3588
3589         Unreviewed, GTK API tests build fix attempt.
3590
3591         * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
3592
3593 2011-12-16  Philippe Normand  <pnormand@igalia.com>
3594
3595         Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
3596
3597         * Scripts/run-gtk-tests:
3598
3599 2011-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
3600
3601         [Qt] Fix the build for newer Qt5
3602         https://bugs.webkit.org/show_bug.cgi?id=74703
3603
3604         Reviewed by Csaba Osztrogonác.
3605
3606         * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
3607         * DumpRenderTree/qt/EventSenderQt.cpp:
3608         (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
3609         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
3610         (WTR::EventSenderProxy::sendTouchEvent):
3611         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3612         (MiniBrowserApplication::sendTouchEvent): Ditto.
3613         (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
3614
3615 2011-12-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3616
3617         [Qt] Detect and force clean build when feature defines are added
3618
3619         Reviewed by Ossy.
3620
3621         https://bugs.webkit.org/show_bug.cgi?id=74689
3622
3623         * Scripts/webkitdirs.pm:
3624
3625 2011-12-16  Kentaro Hara  <haraken@chromium.org>
3626
3627         [Refactoring] Remove all global variables from prepare-ChangeLog
3628         https://bugs.webkit.org/show_bug.cgi?id=74681
3629
3630         Reviewed by Ryosuke Niwa.
3631
3632         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
3633         manner. This bug is one of the incremental refactorings to remove all top-level
3634         code and global variables from prepare-ChangeLog. In this patch,
3635         we make the following global variables be used only through parameter passing.
3636         This patch removes all global variables from prepare-ChangeLog.
3637             - $mergeBase
3638             - $gitCommit
3639             - $gitIndex
3640
3641         * Scripts/prepare-ChangeLog:
3642         (generateFunctionLists):
3643         (changeLogNameFromArgs):
3644         (changeLogEmailAddressFromArgs):
3645         (generateNewChangeLogs):
3646         (printDiff):
3647         (diffFromToString):
3648         (diffCommand):
3649         (statusCommand):
3650         (createPatchCommand):
3651         (generateFileList):
3652         (isConflictStatus):
3653
3654 2011-12-15  Philippe Normand  <pnormand@igalia.com>
3655
3656         [GTK] Rounding errors on 32-bit machines causes tests to fail
3657         https://bugs.webkit.org/show_bug.cgi?id=72254
3658
3659         Initial patch by vanuan@gmail.com.
3660         Reviewed by Martin Robinson.
3661
3662         * Scripts/webkitdirs.pm:
3663         (runAutogenForAutotoolsProjectIfNecessary): Pass additional
3664         CXXFLAGS to autogen in an attempt to harmonize floating point
3665         values between 32-bit and 64-bit architectures.
3666
3667 2011-12-16  Martin Robinson  <mrobinson@igalia.com>
3668
3669         [GTK] Make distcheck fails during the install
3670         https://bugs.webkit.org/show_bug.cgi?id=74274
3671
3672         No review, since this is a build fix.
3673
3674         * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
3675         step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
3676         always runs. This means that the gtkdoc step was always running when make was
3677         invoked. Generating gtkdoc during 'make install' was triggering a race condition
3678         with the library file. Later we can fix generate-forwarding-headers and unbreak
3679         'make docs,' but this bandaid is sufficient to let us release.
3680
3681 2011-12-15  Eric Seidel  <eric@webkit.org>
3682
3683         NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
3684         https://bugs.webkit.org/show_bug.cgi?id=74650
3685
3686         Reviewed by Adam Barth.
3687
3688         * Scripts/webkitpy/common/system/platforminfo.py:
3689         (PlatformInfo._compute_bytes_from_vm_stat_output):
3690         * Scripts/webkitpy/layout_tests/port/base.py:
3691         (Port.default_child_processes):
3692         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3693         (PortTest.test_default_child_processes):
3694
3695 2011-12-15  Filip Pizlo  <fpizlo@apple.com>
3696
3697         bencher script should support remote benchmarking on platforms that don't have ruby
3698         https://bugs.webkit.org/show_bug.cgi?id=74659
3699
3700         Rubber-stamped by Sam Weinig.
3701         
3702         Added the ability to have bencher generate a benchmarking playload that consists of
3703         copies of all of the benchmarks, optionally copies of all of the frameworks and
3704         binaries to run all of the VMs, and a sh script that runs the benchmarks in random
3705         order, which then spits out a raw results file that bencher can parse.
3706         
3707         In normal operating mode, you never see this, as it just generates the payload and
3708         script internally, runs it, parses the results, and spits them out.
3709         
3710         The --remote mode has been changed to use this style, so any remote host that has
3711         sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
3712         a sh-compatible shell can be used for remote benchmarking.
3713         
3714         The feature to include VMs in the benchmarking payload is by default only activated
3715         when using --remote, but it can also be activated when doing local benchmarking; the
3716         benefit is that you remove any pathname-related performance pathologies. All VMs
3717         become equal because they are all located in
3718         /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
3719         (usually 0 or 1).
3720         
3721         Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
3722         through DumpRenderTree. This is only a bit slower than running in jsc.
3723
3724         * Scripts/bencher:
3725
3726 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
3727
3728         webkitpy: clean up TestPort to (mostly) not create a new filesystem
3729         https://bugs.webkit.org/show_bug.cgi?id=74556
3730
3731         This change modifies the TestPort to be ready to add tests to an
3732         existing filesystem instead of creating a new filesystem; we
3733         leave unit_test_filesystem() in for now for compatibility.
3734
3735         * Scripts/webkitpy/common/host_mock.py:
3736         (MockHost.__init__):
3737           - call add_unit_tests_to_mock_filesystem by default to make
3738             the MockHost more generally useful for layout_test unit tests.
3739         * Scripts/webkitpy/layout_tests/port/test.py:
3740         (TestInstance.__init__):
3741         (add_unit_tests_to_mock_filesystem):
3742         (add_file):
3743         (unit_test_filesystem):
3744         (TestPort.__init__):
3745         (TestPort._set_default_overriding_none):
3746
3747 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
3748
3749         webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
3750         https://bugs.webkit.org/show_bug.cgi?id=74551
3751
3752         This is some minor cleanup prior to making all of the host/port
3753         changes described in bug 74138.
3754
3755         * Scripts/webkitpy/common/host_mock.py:
3756         (MockHost.__init__):
3757           - make sure the scm object is initialized with the same mock
3758             executive and filesystem objects.
3759
3760         * Scripts/webkitpy/common/system/filesystem_mock.py:
3761         (MockFileSystem.clear_written_files):
3762           - add a routine that will be useful in testing.
3763         (MockFileSystem.maybe_make_directory):
3764         (MockFileSystem.write_binary_file):
3765           - fix bugs to make sure directories are created properly.
3766         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3767         (_Process.run):
3768           - add clarifying comments.
3769         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3770         (MockDRTPort.__init__):
3771         (MockDRT.__init__):
3772           - add clarifying comments.
3773
3774 2011-12-15  Anders Carlsson  <andersca@apple.com>
3775
3776         Regression (r102866): Navigating away from or closing a page with a plugin crashes
3777         https://bugs.webkit.org/show_bug.cgi?id=74655
3778
3779         Reviewed by Sam Weinig.
3780
3781         Add a bunch of tests.
3782
3783         * TestWebKitAPI/Tests/WTF/Functional.cpp:
3784
3785 2011-12-15  Stephanie Lewis  <slewis@apple.com>
3786
3787         https://bugs.webkit.org/show_bug.cgi?id=74469
3788         Escape paths to svn commands so our tools can handle filenames with @ symbols.
3789
3790         Reviewed by Adam Roben.
3791
3792         * Scripts/VCSUtils.pm:
3793         (scmMoveOrRenameFile):
3794         (scmAddExecutableBit):
3795         (scmRemoveExecutableBit):
3796         (determineSVNRoot):
3797         (svnRevisionForDirectory):
3798         (pathRelativeToSVNRepositoryRootForPath):
3799         (svnStatus):
3800         (escapeSubversionPath):
3801         * Scripts/parse-malloc-history:
3802         (main):
3803         * Scripts/prepare-ChangeLog:
3804         (diffCommand):
3805         (statusCommand):
3806         (findOriginalFileFromSvn):
3807         (determinePropertyChanges):
3808         * Scripts/resolve-ChangeLogs:
3809         (conflictFiles):
3810         (resolveConflict):
3811         (showStatus):
3812         * Scripts/svn-apply:
3813         (patch):
3814         (scmCopy):
3815         (scmAdd):
3816         (scmRemove):
3817         * Scripts/svn-create-patch:
3818         (findBaseUrl):
3819         (findMimeType):
3820         (findSourceFileAndRevision):
3821         (generateDiff):
3822         (generateFileList):
3823         (manufacturePatchForAdditionWithHistory):
3824         * Scripts/svn-unapply:
3825         (patch):
3826         (revertDirectories):
3827
3828 2011-12-15  Michael Bruning  <michael.bruning@nokia.com>
3829
3830         [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
3831         https://bugs.webkit.org/show_bug.cgi?id=74617
3832
3833         Reviewed by Kenneth Rohde Christiansen.
3834
3835         * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
3836         for viewport info button, adjusted height and added rounded corners.
3837
3838 2011-12-15  Andy Estes  <aestes@apple.com>
3839
3840         TestFailures: store the name of the buildbot results directory in a property
3841         https://bugs.webkit.org/show_bug.cgi?id=74663
3842
3843         Reviewed by Adam Barth.
3844         
3845         Store the name of the results directory as a property on Buildbot's
3846         prototype. This allows subclasses of Buildbot to customize the results
3847         directory.
3848
3849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
3850         (Buildbot.prototype.resultsDirectoryURL):
3851
3852 2011-12-15  Tony Chang  <tony@chromium.org>
3853
3854         [chromium] pass --delete_unversioned_trees to gclient on the bots
3855         https://bugs.webkit.org/show_bug.cgi?id=74565
3856
3857         Reviewed by Kenneth Russell.
3858
3859         It was temporarily removed in r102891 to keep the bots green.  Now
3860         that the bots have cycled, we can add it back.
3861
3862         * Scripts/update-webkit-chromium:
3863
3864 2011-12-15  Kentaro Hara  <haraken@chromium.org>
3865
3866         [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
3867         https://bugs.webkit.org/show_bug.cgi?id=74497
3868
3869         Reviewed by Ryosuke Niwa.
3870
3871         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
3872         manner. This bug is one of the incremental refactorings to remove all top-level
3873         code and global variables from prepare-ChangeLog. In this patch,
3874         we make the following global variables be used only through parameter passing.
3875             - $bugDescription
3876             - $bugNumber
3877             - $name
3878             - $emailAddress
3879             - $gitReviewer
3880             - $writeChangeLogs
3881
3882         * Scripts/prepare-ChangeLog:
3883         (fetchBugDescriptionFromURL):
3884         (generateNewChangeLogs):
3885         (reviewerAndDescriptionForGitCommit):
3886
3887 2011-12-15  Raphael Kubo da Costa  <kubo@profusion.mobi>
3888
3889         [EFL] Add a few more web database functions to ewk_settings.
3890         https://bugs.webkit.org/show_bug.cgi?id=72148
3891
3892         Reviewed by Antonio Gomes.
3893
3894         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3895         (LayoutTestController::clearAllDatabases):
3896         (LayoutTestController::setDatabaseQuota):
3897
3898 2011-12-15  Martin Kosiba  <mkosiba@google.com>
3899
3900         Fix find on web pages with -webkit-user-select: none for Chromium
3901         https://bugs.webkit.org/show_bug.cgi?id=72281
3902
3903         Reviewed by Ryosuke Niwa.
3904
3905         Provided a partial findString implementation. This doesn't support
3906         all of the FindOptions since they're not exposed via WebFindOptions.
3907
3908         * DumpRenderTree/chromium/LayoutTestController.cpp:
3909         (LayoutTestController::LayoutTestController):
3910         (LayoutTestController::findString):
3911         * DumpRenderTree/chromium/LayoutTestController.h:
3912
3913 2011-12-15  Kenneth Russell  <kbr@google.com>
3914
3915         [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
3916         https://bugs.webkit.org/show_bug.cgi?id=74581
3917
3918         Reviewed by Darin Fisher.
3919
3920         * DumpRenderTree/chromium/LayoutTestController.cpp:
3921         (LayoutTestController::overridePreference):
3922         * DumpRenderTree/chromium/WebPreferences.cpp:
3923         (WebPreferences::reset):
3924         (WebPreferences::applyTo):
3925         * DumpRenderTree/chromium/WebPreferences.h:
3926
3927 2011-12-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3928
3929         [Qt] Improve the look of the viewport info overlay
3930
3931         Reviewed by Tor Arne Vestbø.
3932
3933         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3934
3935 2011-12-15  Igor Oliveira  <igor.oliveira@openbossa.org>
3936
3937         [Qt] Support requestAnimationFrame API
3938         https://bugs.webkit.org/show_bug.cgi?id=74528
3939
3940         Add build-option for requestAnimationFrame feature.
3941
3942         Reviewed by Kenneth Rohde Christiansen.
3943
3944         * qmake/mkspecs/features/features.prf:
3945
3946 2011-12-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3947
3948         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
3949
3950         Reviewed by Simon Hausmann.
3951
3952         * qmake/mkspecs/features/webcore.prf:
3953
3954 2011-12-15  Michael Brüning  <michael.bruning@nokia.com>
3955
3956         [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
3957         https://bugs.webkit.org/show_bug.cgi?id=72893
3958
3959         Reviewed by Kenneth Rohde Christiansen.
3960
3961         This patch extends QQuickWebViewExperimental by a property named
3962         viewportInfo, which contains the viewport scalability and
3963         layout and contents size information. This property is exposed to
3964         QML through the experimental extension for QQuickWebView.
3965
3966         * MiniBrowser/qt/MiniBrowser.pro:
3967         * MiniBrowser/qt/MiniBrowser.qrc:
3968         * MiniBrowser/qt/icons/info.png: Added.
3969         * MiniBrowser/qt/qml/BrowserWindow.qml:
3970         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
3971
3972 2011-12-15  Shinya Kawanaka  <shinyak@google.com>
3973
3974         [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
3975         https://bugs.webkit.org/show_bug.cgi?id=74586
3976
3977         Reviewed by Hajime Morita.
3978
3979         No new tests. Covered by existing tests.
3980
3981         * DumpRenderTree/chromium/WebViewHost.cpp:
3982         (WebViewHost::requestCheckingOfText):
3983           Returns immediately if text is empty.
3984
3985 2011-12-15  Alexander Færøy  <ahf@0x90.dk>
3986
3987         [Qt] QtWebKit fails to build on Mac OS X after r102776
3988         https://bugs.webkit.org/show_bug.cgi?id=74593
3989
3990         Reviewed by Simon Hausmann.
3991
3992         CONFIG =+ link_pkgconfig is needed such that the correct parameters
3993         are passed to the compiler.
3994
3995         * DumpRenderTree/qt/DumpRenderTree.pro:
3996
3997 2011-12-14  Tony Chang  <tony@chromium.org>
3998
3999         [chromium] Remove redundant third_party entries from chromium DEPS
4000         https://bugs.webkit.org/show_bug.cgi?id=74472
4001
4002         Reviewed by Kenneth Russell.
4003
4004         * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
4005
4006 2011-12-14  Kentaro Hara  <haraken@chromium.org>
4007
4008         [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
4009         VCSUtils::isGit() and VCSUtils::isSVN().
4010         https://bugs.webkit.org/show_bug.cgi?id=74485
4011
4012         Reviewed by David Kilzer.
4013
4014         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
4015         manner. This bug is one of the incremental refactorings to remove all top-level
4016         code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
4017         with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
4018         assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
4019         just by looking at the current working directory.
4020
4021         * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
4022         (diffFromToString):
4023         (diffCommand):
4024         (statusCommand):
4025         (createPatchCommand):
4026         (diffHeaderFormat):
4027         (generateFileList):
4028         (isAddedStatus):
4029         (isConflictStatus):
4030         (statusDescription):
4031         (extractLineRange):
4032
4033 2011-12-14  Sam Weinig  <weinig@apple.com>
4034
4035         Remove whitespace from InheritedPropertySheets attributes in
4036         vsprops files to appease the Visual Studio project migrator.
4037
4038         Reviewed by Adam Roben.
4039
4040         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
4041         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
4042         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
4043         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
4044         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
4045         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
4046         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
4047         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
4048         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
4049         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
4050         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
4051         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
4052         * DumpRenderTree/win/ImageDiffDebug.vsprops:
4053         * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
4054         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
4055         * DumpRenderTree/win/ImageDiffProduction.vsprops:
4056         * DumpRenderTree/win/ImageDiffRelease.vsprops:
4057         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
4058         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
4059         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
4060         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
4061         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
4062         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
4063         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
4064         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
4065         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
4066         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
4067         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
4068         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
4069         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
4070         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
4071         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
4072         * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
4073         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
4074         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
4075         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
4076         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
4077         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
4078         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
4079         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
4080         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
4081         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
4082         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
4083         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
4084         * WinLauncher/WinLauncherDebug.vsprops:
4085         * WinLauncher/WinLauncherDebugAll.vsprops:
4086         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
4087         * WinLauncher/WinLauncherProduction.vsprops:
4088         * WinLauncher/WinLauncherRelease.vsprops:
4089         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
4090         * record-memory-win/record-memory-winDebug.vsprops:
4091         * record-memory-win/record-memory-winDebugAll.vsprops:
4092         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
4093         * record-memory-win/record-memory-winProduction.vsprops:
4094         * record-memory-win/record-memory-winRelease.vsprops:
4095         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
4096
4097 2011-12-14  Anders Carlsson  <andersca@apple.com>
4098
4099         Windows build fix.
4100
4101         Move CHECKs out of the destructor.
4102
4103         * TestWebKitAPI/Tests/WTF/Functional.cpp:
4104         (TestWebKitAPI::B::~B):
4105         (TestWebKitAPI::TEST):
4106
4107 2011-12-14  Anders Carlsson  <andersca@apple.com>
4108
4109         binding a member function should ref/deref the object pointer if needed
4110         https://bugs.webkit.org/show_bug.cgi?id=74552
4111
4112         Reviewed by Sam Weinig.
4113
4114         Add new tests.
4115
4116         * TestWebKitAPI/Tests/WTF/Functional.cpp:
4117         (TestWebKitAPI::B::B):
4118         (TestWebKitAPI::B::~B):
4119         (TestWebKitAPI::B::ref):
4120         (TestWebKitAPI::B::deref):
4121         (TestWebKitAPI::B::f):
4122         (TestWebKitAPI::B::g):
4123         (TestWebKitAPI::TEST):
4124
4125 2011-12-14  Hajime Morrita  <morrita@chromium.org>
4126
4127         JS_INLINE and WTF_INLINE should be visible from WebCore
4128         https://bugs.webkit.org/show_bug.cgi?id=73191
4129
4130         Reviewed by Kevin Ollivier.
4131
4132         Removed macro definitions which is now provided by Platform.h
4133
4134         * DumpRenderTree/chromium/config.h:
4135         * DumpRenderTree/config.h:
4136         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Added.
4137         * DumpRenderTree/ForwardingHeaders/wtf/ExportMacros.h: Added.
4138         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Add new ForwardingHeaders.
4139         * TestWebKitAPI/config.h:
4140         * WebKitTestRunner/config.h:
4141
4142 2011-12-14  Kentaro Hara  <haraken@chromium.org>
4143
4144         Unreviewed, rolling out r102761.
4145         http://trac.webkit.org/changeset/102761
4146         https://bugs.webkit.org/show_bug.cgi?id=74485
4147
4148         we came up with a better fix than this (see comments in bug
4149         74485)
4150
4151         * Scripts/prepare-ChangeLog:
4152         (generateFunctionLists):
4153         (printDiff):
4154         (diffCommand):
4155         (statusCommand):
4156         (createPatchCommand):
4157         (generateFileList):
4158         (isAddedStatus):
4159         (isConflictStatus):
4160         (statusDescription):
4161         (extractLineRange):
4162
4163 2011-12-14  Anders Carlsson  <andersca@apple.com>
4164
4165         Work around a bug in the MSVC2005 compiler
4166         https://bugs.webkit.org/show_bug.cgi?id=74550
4167
4168         Reviewed by Sam Weinig.
4169
4170         Re-enable tests.
4171
4172         * TestWebKitAPI/Tests/WTF/Functional.cpp:
4173
4174 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
4175
4176         [Qt] Test fonts are not used with Qt5
4177         https://bugs.webkit.org/show_bug.cgi?id=72513
4178
4179         My last unreviewed buildfix for this crazy bug.
4180
4181         * qmake/mkspecs/features/features.prf:
4182
4183 2011-12-14  Anders Carlsson  <andersca@apple.com>
4184
4185         Another attempt at fixing the Windows build.
4186
4187         Disable all the tests until I can figure out what's going on here.
4188
4189         * TestWebKitAPI/Tests/WTF/Functional.cpp:
4190
4191 2011-12-14  Anders Carlsson  <andersca@apple.com>
4192
4193         Fix the Windows build.
4194
4195         Disable some of the tests for now.
4196
4197         * TestWebKitAPI/Tests/WTF/Functional.cpp:
4198
4199 2011-12-14  Anders Carlsson  <andersca@apple.com>
4200
4201         bind should handle member functions
4202         https://bugs.webkit.org/show_bug.cgi?id=74529
4203
4204         Reviewed by Sam Weinig.
4205
4206         Add tests.
4207
4208         * TestWebKitAPI/Tests/WTF/Functional.cpp:
4209         (TestWebKitAPI::A::A):
4210         (TestWebKitAPI::A::f):
4211         (TestWebKitAPI::A::addF):
4212         (TestWebKitAPI::TEST):
4213
4214 2011-12-14  Anders Carlsson  <andersca@apple.com>
4215
4216         Add unary and binary bind overloads
4217         https://bugs.webkit.org/show_bug.cgi?id=74524
4218
4219         Reviewed by Sam Weinig.
4220
4221         Add tests.
4222
4223         * TestWebKitAPI/Tests/WTF/Functional.cpp:
4224         (TestWebKitAPI::TEST):
4225         (TestWebKitAPI::multiplyByTwo):
4226         (TestWebKitAPI::multiplyByOneAndAHalf):
4227         (TestWebKitAPI::multiply):
4228         (TestWebKitAPI::subtract):
4229
4230 2011-12-14  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
4231
4232         [Qt] Test fonts are not used with Qt5
4233         https://bugs.webkit.org/show_bug.cgi?id=72513
4234
4235         MIPS and SH4 buildfix after r102776 and r102795.
4236
4237         Reviewed by Csaba Osztrogonác.
4238
4239         * qmake/mkspecs/features/features.prf:
4240
4241 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
4242
4243         [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
4244
4245         * qmake/mkspecs/features/features.prf:
4246
4247 2011-12-14  Andreas Kling  <kling@webkit.org>
4248
4249         Make my e-mail address a little more awesome.
4250
4251         * Scripts/webkitpy/common/config/committers.py:
4252
4253 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
4254
4255         [Qt] Rollout r102769, because it broke Qt-4.8 builds.
4256
4257         * qmake/mkspecs/features/webcore.prf:
4258
4259 2011-12-14  Balazs Kelemen  <kbalazs@webkit.org>
4260
4261         [Qt] Test fonts are not used with Qt5
4262         https://bugs.webkit.org/show_bug.cgi?id=72513
4263
4264         Reviewed by Simon Hausmann.
4265
4266         Don't depend on Q_WS_X11 anymore since it's not the Qt5
4267         way to detect the platform. Make the guards depend
4268         on our own configtest for fontconfig. For Qt4 we can still
4269         use the preassumption that we have it on Linux.
4270
4271         * DumpRenderTree/qt/DumpRenderTree.pro:
4272         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4273         (WebCore::DumpRenderTree::open):
4274         (WebCore::DumpRenderTree::initializeFonts):
4275         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4276         * DumpRenderTree/qt/main.cpp:
4277         (main): Additionally remove a nonsense piece of code that was
4278         trying to reset the font settings - which is not necessary -
4279         after we have already returned from main.
4280         * WebKitTestRunner/InjectedBundle/Target.pri:
4281         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
4282         (WTR::activateFonts):
4283         * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
4284         from WTR. It is not needed. We set up the fonts via the injected bundle.
4285         * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
4286         (main):
4287         * qmake/config.tests/fontconfig/fontconfig.pro: Added.
4288         * qmake/mkspecs/features/features.prf:
4289         * qmake/sync.profile:
4290
4291 2011-12-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4292
4293         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
4294
4295         Followup to r102679
4296
4297         https://bugs.webkit.org/show_bug.cgi?id=74413
4298
4299         Reviewed by Simon Hausmann.
4300
4301         * qmake/mkspecs/features/webcore.prf:
4302
4303 2011-12-14  Pierre Rossi  <pierre.rossi@gmail.com>
4304
4305         [Qt] Mobi