3965d5da620dff26e51ffdbc6109638c47b75ce1
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         Unreviewed, move Frédéric Wang to committers list
4
5         He seems to be on the contributors list by accident. He has been landing his own commits for
6         about two years now.
7
8         * Scripts/webkitpy/common/config/contributors.json:
9
10 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
11
12         Unreviewed, move Sebastian Dröge to committers list harder
13
14         He accidentally added himself to the reviewers list because the file is confusing. Then I
15         accidentially moved him to the contributors list because the file is confusing, even though
16         I knew the contributors list existed in this file and was attempting to add him to the
17         committers list. Really move him to the committers list now.
18
19         * Scripts/webkitpy/common/config/contributors.json:
20
21 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
22
23         Python SCM should be able to retrieve untracked files - Add SVN support
24         https://bugs.webkit.org/show_bug.cgi?id=152546
25
26         Reviewed by Michael Catanzaro.
27
28         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
29         (test_untracked_files): Activating test for SVN.
30         * Scripts/webkitpy/common/checkout/scm/svn.py:
31         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
32
33 2015-12-31  Andy Estes  <aestes@apple.com>
34
35         Replace WTF::move with WTFMove
36         https://bugs.webkit.org/show_bug.cgi?id=152601
37
38         Reviewed by Brady Eidson.
39
40         * DumpRenderTree/TestRunner.h:
41         (TestRunner::setAllowedHosts):
42         * DumpRenderTree/win/DRTDataObject.cpp:
43         (DRTDataObject::SetData):
44         * TestWebKitAPI/Tests/WTF/Deque.cpp:
45         (TestWebKitAPI::TEST):
46         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
47         (TestWebKitAPI::TEST):
48         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
49         (TestWebKitAPI::TEST):
50         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
51         (TestWebKitAPI::TEST):
52         * TestWebKitAPI/Tests/WTF/Ref.cpp:
53         (TestWebKitAPI::passWithRef):
54         (TestWebKitAPI::TEST):
55         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
56         (TestWebKitAPI::TEST):
57         * TestWebKitAPI/Tests/WTF/Vector.cpp:
58         (TestWebKitAPI::TEST):
59         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
60         (TestWebKitAPI::TEST):
61         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
62         (TestWebKitAPI::TEST):
63         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
64         (TestWebKitAPI::createTestValue):
65         (TestWebKitAPI::TEST):
66         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
67         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
68         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
69         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
70         (TestWebKitAPI::createNFAs):
71         (TestWebKitAPI::TEST_F):
72         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
73         (TestWebKitAPI::combine):
74         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
75         (TestWebKitAPI::createNFAs):
76         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
77         (TEST):
78         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
79         (WebProcessTest::add):
80
81 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
82
83         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
84         https://bugs.webkit.org/show_bug.cgi?id=152634
85
86         Reviewed by Carlos Garcia Campos.
87
88         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
89         (testLoadFromGResource): Added test.
90         (beforeAll):
91         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
92         (registerGResource): Added.
93         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
94         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
95         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
96
97 2015-12-31  David Kilzer  <ddkilzer@apple.com>
98
99         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
100         <https://bugs.webkit.org/show_bug.cgi?id=152601>
101
102         Ignore unknown pragmas on older clangs.  Fixes the following
103         build failure:
104
105             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
106             #pragma clang diagnostic ignored "-Wself-move"
107                                              ^
108             1 error generated.
109
110         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
111         (TestWebKitAPI::TEST):
112         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
113         (TestWebKitAPI::TEST):
114
115 2015-12-31  Andy Estes  <aestes@apple.com>
116
117         Update the style checker to advise using WTFMove() instead of WTF::move()
118         https://bugs.webkit.org/show_bug.cgi?id=152601
119
120         Reviewed by Daniel Bates.
121
122         * Scripts/webkitpy/style/checkers/cpp.py:
123         (check_wtf_move):
124         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
125         (WebKitStyleTest.test_wtf_move):
126
127 2015-12-31  Andy Estes  <aestes@apple.com>
128
129         Fix warnings uncovered by migrating to WTF_MOVE
130         https://bugs.webkit.org/show_bug.cgi?id=152601
131
132         Reviewed by Daniel Bates.
133
134         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
135         self-move, even if doing so would trigger a warning.
136
137         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
138         (TestWebKitAPI::TEST):
139         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
140         (TestWebKitAPI::TEST):
141
142 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
143
144         [GTK] The install-dependencies script has a syntax error
145         https://bugs.webkit.org/show_bug.cgi?id=152613
146
147         Reviewed by Michael Catanzaro.
148
149         * gtk/install-dependencies: Add the missing 'then.'
150
151 2015-12-30  Philippe Normand  <pnormand@igalia.com>
152
153         [Mac][GTK] Jhbuild support for OSX
154         https://bugs.webkit.org/show_bug.cgi?id=150799
155
156         Reviewed by Michael Catanzaro.
157
158         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
159         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
160         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
161         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
162
163 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
164
165         Unreviewed, move Sebastian Dröge to committers list
166
167         He accidentally added himself to the reviewers list because the file is confusing.
168
169         * Scripts/webkitpy/common/config/contributors.json:
170
171 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
172
173         Remove the unused #define _USE_MATH_DEFINES
174         https://bugs.webkit.org/show_bug.cgi?id=152034
175
176         Reviewed by Tim Horton.
177         
178         Update this test to use piDouble from MathExtras.h, and
179         std::numeric_limits<>.
180
181         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
182
183 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
184
185         Python SCM should be able to retrieve untracked files - Generic changes
186         https://bugs.webkit.org/show_bug.cgi?id=152536
187
188         Reviewed by Brent Fulgham.
189
190         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
191         No support is yet added to GIT and SVN specific implementations.
192
193         * Scripts/webkitpy/common/checkout/scm/scm.py:
194         (SCM.untracked_files):
195         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
196         (SCMTest._shared_test_untracked_files):
197
198 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
199
200         SVN checkout used by RunBenchmark should be non-interactive
201         https://bugs.webkit.org/show_bug.cgi?id=152542
202
203         Reviewed by Ryosuke Niwa.
204
205         RunBenchmark should not require user interaction while running.
206
207         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
208         (BenchmarkBuilder._checkout_with_subversion):
209
210 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
211
212         Web Inspector: add support for running protocol-test.js tests on Windows
213         https://bugs.webkit.org/show_bug.cgi?id=148037
214         <rdar://problem/22292237>
215
216         Reviewed by Simon Fraser.
217
218         * DumpRenderTree/win/TestRunnerWin.cpp:
219         (TestRunner::inspectorTestStubURL): Provide implementation.
220
221 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
222
223         [MediaStream] MediaDeviceInfo.label must be empty in some situations
224         https://bugs.webkit.org/show_bug.cgi?id=152000
225
226         Reviewed by Brent Fulgham.
227
228         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
229         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
230         (WTR::InjectedBundle::setUserMediaPermission):
231         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
232         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
233
234         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
235         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
236         * WebKitTestRunner/InjectedBundle/TestRunner.h:
237
238         * WebKitTestRunner/TestController.cpp:
239         (WTR::TestController::setUserMediaPermissionForOrigin):
240         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
241         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
242           persistent permission for origin, that can be done from script now.
243         * WebKitTestRunner/TestController.h:
244
245         * WebKitTestRunner/TestInvocation.cpp:
246         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
247           SetUserMediaPermissionForOrigin.
248
249 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
250
251         [Win] Unreviewed build fix: Recognize Windows 10 variants.
252
253         * Scripts/webkitpy/common/system/platforminfo.py:
254         (PlatformInfo._determine_win_version):
255
256 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
257
258         Content blockers should be able to promote http to https
259         https://bugs.webkit.org/show_bug.cgi?id=148966
260
261         Reviewed by Benjamin Poulain.
262
263         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
264         (WebCore::ContentExtensions::operator<<):
265         (TestWebKitAPI::TEST_F):
266
267 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
268
269         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
270         https://bugs.webkit.org/show_bug.cgi?id=152516
271
272         Reviewed by Gyuyoung Kim.
273
274         * MiniBrowser/efl/main.c:
275
276 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
277
278         Unreviewed: Add John Wilander as a contributor.
279
280         * Scripts/webkitpy/common/config/contributors.json:
281
282 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
283
284         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
285         https://bugs.webkit.org/show_bug.cgi?id=152482
286
287         Reviewed by Brent Fulgham.
288
289         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
290         for the same property. On WK2, the element returned will not be valid, but is still present and
291         that can lead to looping.
292
293         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
294         (AccessibilityUIElement::horizontalScrollbar):
295         (AccessibilityUIElement::verticalScrollbar):
296         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
297         (WTR::AccessibilityUIElement::horizontalScrollbar):
298         (WTR::AccessibilityUIElement::verticalScrollbar):
299
300 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
301
302         Unreviewed.
303
304         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
305
306 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
307
308         [EFL] test_ewk2_context failed after r192808
309         https://bugs.webkit.org/show_bug.cgi?id=151846
310
311         Reviewed by Gyuyoung Kim.
312
313         Used the added ewk_context_web_process_count_limit_set api
314         instead of the deprecated ewk_context_process_model_set.
315
316         * MiniBrowser/efl/main.c:
317         (elm_main):
318
319 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
320
321         Unreviewed, move myself to reviewer list.
322
323         * Scripts/webkitpy/common/config/contributors.json:
324
325 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
326
327         Unreviewed, add myself to the committers list.
328
329         * Scripts/webkitpy/common/config/contributors.json:
330
331 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
332
333         [GTK] jquery.min.js violates DFSG
334         https://bugs.webkit.org/show_bug.cgi?id=152428
335
336         Reviewed by Joseph Pecoraro.
337
338         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
339         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
340
341         * gtk/manifest.txt.in:
342
343 2015-12-19  Dan Bernstein  <mitz@apple.com>
344
345         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
346         https://bugs.webkit.org/show_bug.cgi?id=152462
347
348         Reviewed by Alexey Proskuryakov.
349
350         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
351           OS X 10.9:
352
353         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
354         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
355         * MiniBrowser/Configurations/DebugRelease.xcconfig:
356         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
357         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
358
359         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
360           never getting compiled:
361
362         * DumpRenderTree/mac/TextInputController.m:
363         * MiniBrowser/mac/BrowserWindowController.m:
364         * TestWebKitAPI/Tests/mac/AttributedString.mm:
365         * WebKitTestRunner/mac/EventSenderProxy.mm:
366
367 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
368
369         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
370
371         This is to make it easy to CC it on Bugzilla.
372
373         * Scripts/webkitpy/common/config/contributors.json:
374
375 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
376
377         Pasteboard get messed up after running kill-old-processes
378         https://bugs.webkit.org/show_bug.cgi?id=152426
379
380         Reviewed by Alexey Proskuryakov.
381
382         * BuildSlaveSupport/kill-old-processes:
383         (main): Do not kill pasteboard anymore.
384
385 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
386
387         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
388         https://bugs.webkit.org/show_bug.cgi?id=152157
389         <rdar://problem/23851817>
390
391         Reviewed by Alexey Proskuryakov.
392
393         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
394         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
395         * Scripts/webkitpy/layout_tests/controllers/manager.py:
396         (Manager._get_test_inputs): Common method to calculate test_inputs.
397         (Manager._update_worker_count): Calculate and update required number of workers.
398
399 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
400
401         run-webkit-tests fails to delete Simulator device during cleanup
402         https://bugs.webkit.org/show_bug.cgi?id=152363
403
404         Reviewed by Alexey Proskuryakov.
405
406         * Scripts/webkitpy/xcode/simulator.py:
407         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
408
409 2015-12-16  Tim Horton  <timothy_horton@apple.com>
410
411         [mac-wk2] fast/events force click tests crashing
412         https://bugs.webkit.org/show_bug.cgi?id=152339
413
414         Reviewed by Beth Dakin.
415
416         * WebKitTestRunner/mac/EventSenderProxy.mm:
417         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
418         Set the NSEvent's _type member in addition to overriding -type,
419         because there are assertions in touch event handling code that depend on it.
420
421 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
422
423         Enforce temporarily bots to sync WebKit and WPT testharness.js
424         https://bugs.webkit.org/show_bug.cgi?id=152334
425
426         Reviewed by Darin Adler.
427
428         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
429         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
430
431 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
432
433         [Fetch API] Add fetch API compile time flag
434         https://bugs.webkit.org/show_bug.cgi?id=152254
435
436         Reviewed by Darin Adler.
437
438         * Scripts/webkitperl/FeatureList.pm:
439
440 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
441
442         Unreviewed.
443
444         Added files that have impact in building Streams API to the watchlist.
445
446         * Scripts/webkitpy/common/config/watchlist:
447
448 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
449
450         Unreviewed.
451
452         Added imported tests to Streams API watchlist.
453
454         * Scripts/webkitpy/common/config/watchlist:
455
456 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
457
458         Remove default copy of wpt testharness.js when launching wpt server
459         https://bugs.webkit.org/show_bug.cgi?id=152298
460
461         Reviewed by Darin Adler.
462
463         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
464         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
465
466 2015-12-15  David Kilzer  <ddkilzer@apple.com>
467
468         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
469         <http://webkit.org/b/152314>
470
471         Reviewed by Daniel Bates.
472
473         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
474         code path to exit immediately when calling main().
475         Unfortunately, DumpRenderTreeMain.mm was used for both
476         DumpRenderTree command-line binary and DumpRenderTree.app, which
477         meant that the app would exit immediately with no error code
478         when run!
479
480         The workaround is to introduce a separate source file called
481         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
482         already does.
483
484         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
485         DumpRenderTreeAppMain.mm to the project.  Make it the only
486         compiled source for the DumpRenderTree.app target.
487         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
488         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
489         case someone tries mistakenly to use the app.
490         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
491         Link to JavaScriptCore.framework on iOS for the assert.
492         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
493         Link to JavaScriptCore.framework on OS X for the assert.  Remove
494         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
495         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
496         (main): Add assert for iOS so that a crash occurs if someone
497         tries to run the wrong command.
498
499 2015-12-14  Tim Horton  <timothy_horton@apple.com>
500
501         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
502         https://bugs.webkit.org/show_bug.cgi?id=152266
503         <rdar://problem/22092676>
504
505         Reviewed by Simon Fraser.
506
507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
508         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
509         Add a test that crashed before this change, and doesn't crash after.
510
511 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
512
513         AX: iOS: Text field variations do not have the correct traits
514         https://bugs.webkit.org/show_bug.cgi?id=152237
515
516         Reviewed by Mario Sanchez Prada.
517
518         Add iOS calls for determing if an object is a search field or a text area.
519
520         * DumpRenderTree/AccessibilityUIElement.cpp:
521         (getIsSearchFieldCallback):
522         (getIsTextAreaCallback):
523         (stringForSelectionCallback):
524         (AccessibilityUIElement::getJSClass):
525         * DumpRenderTree/AccessibilityUIElement.h:
526         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
527         (AccessibilityUIElement::identifier):
528         (AccessibilityUIElement::isTextArea):
529         (AccessibilityUIElement::isSearchField):
530         (AccessibilityUIElement::traits):
531         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
532         (WTR::AccessibilityUIElement::scrollPageRight):
533         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
534         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
535         (WTR::AccessibilityUIElement::isSearchField):
536         (WTR::AccessibilityUIElement::isTextArea):
537         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
538         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
539         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
540         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
541         (WTR::AccessibilityUIElement::isTextArea):
542         (WTR::AccessibilityUIElement::isSearchField):
543         (WTR::AccessibilityUIElement::rowCount):
544
545 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
546
547         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
548         https://bugs.webkit.org/show_bug.cgi?id=152252
549
550         Reviewed by Sergio Villar Senin.
551
552         * gtk/install-dependencies: Add libtool-bin to the list of packages required
553         for building the JHBuild on Debian systems.
554
555 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
556
557         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
558         https://bugs.webkit.org/show_bug.cgi?id=152156
559
560         Reviewed by Dan Bernstein.
561
562         Our frameworks should appropriately prefix all ObjC classes,
563         not just external symbols.
564
565         * Scripts/check-for-inappropriate-objc-class-names:
566         Remove the -g switch to check all ObjC class names.
567
568 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
569
570         [MediaStream] Expose media capture devices persistent permissions to WebCore
571         https://bugs.webkit.org/show_bug.cgi?id=152087
572
573         Add support for the new user media permission checker page UI client method.
574
575         Reviewed by Chris Dumez.
576
577         * WebKitTestRunner/TestController.cpp:
578         (WTR::decidePolicyForUserMediaPermissionRequest):
579         (WTR::checkUserMediaPermissionForOrigin):
580         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
581         (WTR::TestController::createWebViewWithOptions): Ditto.
582         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
583         (WTR::originUserVisibleName): New, create a string for the origin.
584         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
585           according to the state of the origin permission map.
586         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
587           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
588         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
589           origin permission map.
590         * WebKitTestRunner/TestController.h:
591
592 2015-12-10  Alex Christensen  <achristensen@webkit.org>
593
594         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
595         https://bugs.webkit.org/show_bug.cgi?id=152022
596         rdar://problem/23763584
597
598         Reviewed by Darin Adler.
599
600         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
601         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
602         (WTR::InjectedBundlePage::willSendRequestForFrame):
603         * WebKitTestRunner/InjectedBundle/TestRunner.h:
604         (WTR::TestRunner::setWillSendRequestReturnsNull):
605         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
606         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
607         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
608         (WTR::TestRunner::willSendRequestHTTPBody):
609         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
610
611 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
612
613         Remove additional simulator checks before running layout-tests
614         https://bugs.webkit.org/show_bug.cgi?id=152146
615
616         Reviewed by Darin Adler.
617
618         * Scripts/webkitpy/port/ios.py:
619         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
620         * Scripts/webkitpy/xcode/simulator.py:
621         (Simulator._boot_and_shutdown_simulator_device): Deleted.
622         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
623
624 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
625
626         Run atleast one simulator even if max process limit is low
627         https://bugs.webkit.org/show_bug.cgi?id=152081
628         <rdar://problem/23819694>
629
630         Reviewed by Alexey Proskuryakov.
631
632 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
633
634         [GTK] Crash in WebProcess when loading large content with custom URI schemes
635         https://bugs.webkit.org/show_bug.cgi?id=144262
636
637         Reviewed by Carlos Garcia Campos.
638
639         Added new unit test to check the additional scenarios we now
640         handle for custom URI schemes.
641
642         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
643         (generateHTMLContent): New helper function to generate big enough content.
644         (testWebContextURIScheme): New unit test.
645
646 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
647
648         [EFL] Fix unhandled web process message when launching MiniBrowser
649         https://bugs.webkit.org/show_bug.cgi?id=152048
650
651         Reviewed by Gyuyoung Kim.
652
653         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
654         (TestWebKitAPI::TEST):
655
656 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
657
658         [GTK] Add API to handle beforeunload events
659         https://bugs.webkit.org/show_bug.cgi?id=139090
660
661         Reviewed by Gustavo Noronha Silva.
662
663         * MiniBrowser/gtk/BrowserWindow.c:
664         (browserWindowConstructed):
665         (browserWindowDeleteEvent):
666         (browser_window_class_init):
667         Handle delete-event to prevent the window from being closed when
668         the page has beforeunload handlers. Use
669         webkit_web_view_try_close() when the window is requested to be
670         closed.
671         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
672         (testWebViewJavaScriptDialogs):
673         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
674         script dialog type.
675
676 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
677
678         Refactored initialization code in LoadTrackingTest.
679
680         Rubber-stamped by Carlos Garcia Campos.
681
682         Small refactoring to make sure that the state of a LoadTrackingTest
683         gets properly reset before loading new web content.
684
685         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
686         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
687         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
688         functions and reset the remaining local variables.
689         (LoadTrackingTest::loadURI): Call reset();
690         (LoadTrackingTest::loadHtml): Ditto.
691         (LoadTrackingTest::loadPlainText): Ditto.
692         (LoadTrackingTest::loadBytes): Ditto.
693         (LoadTrackingTest::loadRequest): Ditto.
694         (LoadTrackingTest::reload): Ditto.
695         (LoadTrackingTest::goBack): Ditto.
696         (LoadTrackingTest::goForward): Ditto.
697
698 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
699
700         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
701         https://bugs.webkit.org/show_bug.cgi?id=151942
702
703         Reviewed by Darin Adler.
704
705         * MiniBrowser/efl/main.c:
706         (window_create): Enable offline web application cache feature on MiniBrowser.
707         (elm_main):
708
709 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
710
711         https://bugs.webkit.org/show_bug.cgi?id=151243
712         <rdar://problem/22955197>
713
714         Reviewed by Alexey Proskuryakov.
715
716         * LayoutTestRelay/LayoutTestRelay/main.m:
717         (getTestingSimDevice): Use separate testing device for each worker.
718         * Scripts/webkitpy/layout_tests/controllers/manager.py:
719         (Manager.run): Perform cleanup even if setup fails.
720         * Scripts/webkitpy/port/ios.py:
721         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
722         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
723         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
724         (IOSSimulatorPort._quit_ios_simulator): Same
725         (IOSSimulatorPort.clean_up_test_run): Same
726         (IOSSimulatorPort.check_sys_deps): Same
727         (IOSSimulatorPort.testing_device): Same
728         (IOSSimulatorPort.reset_preferences): Same
729         (IOSSimulatorPort.get_simulator_path): Return simulator path.
730         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
731         * Scripts/webkitpy/xcode/simulator.py:
732         (Device.delete): Delete the simulator device.
733         (Simulator.delete_device): Same
734         (Simulator.wait_until_device_is_booted): Wait for device booting.
735
736 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
737
738         [EFL] Add API to provide preferences before creating ewk_view
739         https://bugs.webkit.org/show_bug.cgi?id=151587
740
741         Reviewed by Gyuyoung Kim.
742
743         * MiniBrowser/efl/main.c:
744         (on_key_down):
745         (quit):
746         (window_create):
747         Moved settings related code to configuration() not to update settings
748         whenever ewk_view is created.
749         (configuration):
750         (elm_main):
751
752 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
753
754         Unreviewed. Fix GTK+ API tests after r193639.
755
756         The new jhbuild version needs some more variables ot be present in
757         the builtin dict, even if they are set to None.
758
759         * jhbuild/jhbuildutils.py:
760         (enter_jhbuild_environment_if_available):
761
762 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
763
764         [GTK] Notify WebCore when notification is clicked
765         https://bugs.webkit.org/show_bug.cgi?id=151951
766
767         Reviewed by Carlos Garcia Campos.
768
769         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
770         (testWebViewNotification): test the new API.
771
772 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
773
774         'jhbuild build' should fail immediately when building any module fails
775         https://bugs.webkit.org/show_bug.cgi?id=145697
776
777         Reviewed by Carlos Garcia Campos.
778
779         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
780         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
781         Everything is placed under lib instead of lib64 now.
782         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
783         --exit-on-error when running 'jhbuild build'.
784         * jhbuild/jhbuildrc_common.py:
785         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
786         jhbuild should be able to handle these for us without breaking things....
787
788 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
789
790         Add support to import w3c tests from a repository with a different root that the main repo dir
791         https://bugs.webkit.org/show_bug.cgi?id=151751
792
793         Reviewed by Ryosuke Niwa and Youenn Fablet.
794
795         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
796         in a different directory than the repository root.
797
798         This patch introduces a new parameter tests_directory that we will use as root directory to search for
799         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
800         requires having the copy_path lists including tuples of origin and destination directories.
801
802         * Scripts/webkitpy/w3c/test_downloader.py:
803         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
804         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
805         * Scripts/webkitpy/w3c/test_importer_unittest.py:
806         (TestImporterTest.test_tests_directory): Test.
807
808 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
809
810         Mock TestRepositories in W3C importer tests
811         https://bugs.webkit.org/show_bug.cgi?id=151938
812
813         Reviewed by Youenn Fablet.
814
815         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
816         is because the test repository method reading the file was using the filesystem directly instead of taking the
817         host one. This patch changes that.
818
819         * Scripts/webkitpy/w3c/test_downloader.py:
820         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
821         default one.
822         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
823         * Scripts/webkitpy/w3c/test_importer_unittest.py:
824         (TestImporterTest.test_harnesslinks_conversion):
825         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
826
827 2015-12-07  David Kilzer  <ddkilzer@apple.com>
828
829         TestNetscapePlugIn: Address review comment on 193607
830         <http://webkit.org/b/151881>
831
832         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
833         (testSetStatus): Initializing std::unique_ptr<char[]> with
834         nullptr is redundant.
835
836 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
837
838         [GTK] Add webkit_uri_request_get_http_method
839         https://bugs.webkit.org/show_bug.cgi?id=151601
840
841         Reviewed by Martin Robinson.
842
843         Add test case to check HTTP method of WebKitURIRequest.
844
845         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
846         (testURIRequestHTTPMethod):
847         (serverCallback):
848         (beforeAll):
849         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
850         (sendRequestCallback):
851
852 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
853
854         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
855         https://bugs.webkit.org/show_bug.cgi?id=79918
856
857         Reviewed by Gustavo Noronha Silva.
858
859         Add unit tests to check the different console messages.
860
861         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
862         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
863         (ConsoleMessageTest::ConsoleMessage::operator==):
864         (ConsoleMessageTest::consoleMessageReceivedCallback):
865         (ConsoleMessageTest::ConsoleMessageTest):
866         (ConsoleMessageTest::~ConsoleMessageTest):
867         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
868         (testWebKitConsoleMessageConsoleAPI):
869         (testWebKitConsoleMessageJavaScriptException):
870         (testWebKitConsoleMessageNetworkError):
871         (testWebKitConsoleMessageSecurityError):
872         (beforeAll):
873         (afterAll):
874         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
875         (consoleMessageSentCallback):
876         (pageCreatedCallback):
877
878 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
879
880         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
881         https://bugs.webkit.org/show_bug.cgi?id=151934
882
883         Reviewed by Csaba Osztrogonác.
884
885         * MiniBrowser/efl/main.c:
886         (on_window_deletion): Revert the changes of r192767.
887
888 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
889
890         [GTK] update-webkitgtk-libs cannot build mesa
891         https://bugs.webkit.org/show_bug.cgi?id=151535
892
893         Reviewed by Martin Robinson.
894
895         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
896         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
897         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
898         does not have a stable API and we cannot expect mesa to be buildable unless we control the
899         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
900         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
901
902         * gtk/jhbuild.modules:
903
904 2015-12-07  Philippe Normand  <pnormand@igalia.com>
905
906         [GTK][Mac] libWebExtensionTest link error
907         https://bugs.webkit.org/show_bug.cgi?id=150802
908
909         Reviewed by Carlos Garcia Campos.
910
911         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
912
913 2015-12-06  David Kilzer  <ddkilzer@apple.com>
914
915         TestNetscapePlugIn: Fix leaks found by static analyzer
916         <http://webkit.org/b/151881>
917
918         Reviewed by Darin Adler.
919
920         Fixes the following leaks found by the static analyzer:
921             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
922                     return false;
923                            ^~~~~
924             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
925                     return false;
926                            ^~~~~
927             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
928                     return false;
929                            ^~~~~
930
931         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
932         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
933         early return if allocation fails.
934         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
935         Make sure to call fclose() on filehandle, even for an early
936         return.
937         (testSetStatus): Switch to using std::unique_ptr<char[]>.
938
939 2015-12-05  David Kilzer  <ddkilzer@apple.com>
940
941         prepare-ChangeLog: Fix some warning messages when using svn
942         <http://webkit.org/b/151914>
943
944         Reviewed by Daniel Bates.
945
946         * Scripts/prepare-ChangeLog:
947         (generateFunctionLists): Simplify logic so that we never call
948         normalizePath() with an undefined value.
949         (attributeCommand): Quote $subPath for the shell so that we
950         don't try to run "svn propget" on invalid paths.
951
952 2015-12-04  David Kilzer  <ddkilzer@apple.com>
953
954         TestNetscapePlugIn: Fix remaining static analyzer warnings
955         <http://webkit.org/b/151888>
956
957         Reviewed by Alexey Proskuryakov.
958
959         Fixes the following static analyzer warnings:
960             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
961                     CRASH();
962                     ^~~~~~~
963             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
964                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
965                 ^~~~~~~~~~~~~~~~
966             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
967                 return obj->pluginTest->NPP_SetWindow(window);
968                        ^~~~~~~~~~~~~~~
969             2 warnings generated.
970
971         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
972         (CRASH): Use __builtin_trap() for gcc/clang.
973         (NPP_SetWindow): Add early return if obj is nullptr.
974
975 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
976
977         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
978         https://bugs.webkit.org/show_bug.cgi?id=151797
979
980         Reviewed by Martin Robinson.
981
982         Since we switched to use the network process to run the unit tests
983         the test /webkit2/WebKitWebResource/get-data sometimes fails and
984         sometimes passes. We are now also getting the notification for the
985         css image. Since we wait for 3 resources, sometimes the css image
986         is loaded before and then checkResourceData is called for it, but
987         not handled. When the css image is the last one loaded the test
988         passes. So, we just need to wait for the 4 resources.
989
990         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
991         (testWebResourceGetData):
992
993 2015-12-03  David Kilzer  <ddkilzer@apple.com>
994
995         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
996         <http://webkit.org/b/151845>
997
998         Reviewed by Simon Fraser.
999
1000         Fixes the following static analyzer warning:
1001             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1002                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1003                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1004
1005         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1006         (createBitmapContext): Free 'buffer' after using it in logging
1007         to fix the use-after-free.  Assign a value of nullptr to buffer
1008         so we don't return with it set to a freed address.
1009
1010 2015-12-03  Jer Noble  <jer.noble@apple.com>
1011
1012         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1013         https://bugs.webkit.org/show_bug.cgi?id=151830
1014
1015         Reviewed by Anders Carlsson.
1016
1017         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1018
1019         * DumpRenderTree/mac/DumpRenderTree.mm:
1020         (resetWebPreferencesToConsistentValues):
1021         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1022         (WTR::initializeWebViewConfiguration):
1023
1024 2015-12-03  Anders Carlsson  <andersca@apple.com>
1025
1026         Remove Objective-C GC support
1027         https://bugs.webkit.org/show_bug.cgi?id=151819
1028         rdar://problem/23746991
1029
1030         Reviewed by Dan Bernstein.
1031
1032         * asan/asan.xcconfig:
1033
1034 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1035
1036         Allow nil for unspecified benchmark pathes
1037         https://bugs.webkit.org/show_bug.cgi?id=151784
1038
1039         Reviewed by Filip Pizlo.
1040
1041         `Pathname.new(nil)` will raise an error.
1042         Only generate Pathname if the benchmark path is specified.
1043
1044         * Scripts/run-jsc-benchmarks:
1045
1046 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1047
1048         [Win] Run non-http tests without Cygwin
1049         https://bugs.webkit.org/show_bug.cgi?id=151721
1050
1051         Reviewed by Andy Estes.
1052
1053         Support native 32-bit and 64-bit Python (and Perl) builds
1054         for running tests:
1055
1056         1. Use "startswith('win')", rather than "== 'win32'" to support
1057         various Windows build types.
1058         2. Supply full path for some native Windows utilities, since the
1059         path environment does not always have the specified, and they are
1060         guaranteed to exist in those specific locations.
1061         3. Make sure native Windows Python test runs pass proper environment
1062         variables to run programs.
1063         4. Append 'exe' suffix when running Windows executables.
1064         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1065         command doesn't exist.
1066         
1067         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1068         the current Perl executable, rather than requiring a new path search.
1069         * Scripts/webkitpy/common/find_files_unittest.py:
1070         (TestWinNormalize.test_win): Use startswith('win').
1071         * Scripts/webkitpy/common/prettypatch_unittest.py:
1072         (test_pretty_diff_encodings): Ditto.
1073         * Scripts/webkitpy/common/system/executive.py:
1074         (Executive._should_close_fds): Ditto.
1075         (Executive.shell_command_for_script): Use startswith('win').
1076         (Executive.kill_process): Use full path to killall executable.
1077         (Executive.check_running_pid): Use startswith('win').
1078         (Executive.running_pids): Ditto.
1079         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1080         running under native Windows Python.
1081         (Executive._child_process_encoding): Use startswith('win').
1082         (Executive._should_encode_child_process_arguments): Ditto.
1083         (Executive.popen): Recognize proper script engine on Windows, since it
1084         does not support the shebang syntax.
1085         (Executive.run_in_parallel): Use startswith('win').
1086         * Scripts/webkitpy/common/system/executive_unittest.py:
1087         (never_ending_command): Ditto.
1088         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1089         (ExecutiveTest.serial_test_kill_process): Ditto.
1090         (ExecutiveTest.serial_test_kill_all): Ditto.
1091         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1092         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1093         (main): Ditto.
1094         * Scripts/webkitpy/common/system/file_lock.py:
1095         (FileLock._create_lock): Ditto.
1096         (FileLock._remove_lock): Ditto.
1097         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1098         (RealFileSystemTest.test_chdir): Ditto.
1099         (RealFileSystemTest.test_chdir__notexists): Ditto.
1100         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1101         * Scripts/webkitpy/common/system/path_unittest.py:
1102         (AbspathTest.test_abspath_to_uri_win): Ditto.
1103         * Scripts/webkitpy/common/system/platforminfo.py:
1104         (PlatformInfo._determine_os_name): Ditto.
1105         * Scripts/webkitpy/common/system/user.py: Ditto.
1106         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1107         (ManagerTest.integration_test_needs_servers): Ditto.
1108         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1109         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1110         driver letters.
1111         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1112         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1113         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1114         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1115         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1116         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1117         (TestHttpServer.test_start_cmd): Ditto.
1118         * Scripts/webkitpy/port/base.py:
1119         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1120         and 'SYSTEMROOT' in environment passed to test runners.
1121         (Port._apache_config_file_name_for_platform): Use startswith('win').
1122         (Port._build_path): Ditto.
1123         (Port._path_to_driver): Include 'exe' suffix when running under native
1124         Windows.
1125         * Scripts/webkitpy/port/driver.py:
1126         (Driver._setup_environ_for_driver): Explicitly make some environment
1127         variables strings.
1128         * Scripts/webkitpy/port/server_process.py:
1129         (ServerProcess.__init__): Use startswith('win').
1130         * Scripts/webkitpy/port/win.py:
1131         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1132         registry key formats.
1133         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1134         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1135         and regtool on Cygwin.
1136         (WinPort.write_registry_value): Ditto.
1137         (WinPort.setup_crash_log_saving): Ditto.
1138         (WinPort.restore_crash_log_saving): Ditto.
1139         (WinPort.prevent_error_dialogs): Ditto.
1140         (WinPort.allow_error_dialogs): Ditto.
1141         (WinPort.find_system_pid): Revise to use Windows management
1142         infrastructure on native Windows, continue using 'ps' on Cygwin.
1143         (WinPort.read_registry_string): Deleted.
1144         (WinPort.write_registry_string): Deleted.
1145         * Scripts/webkitpy/test/main.py:
1146         (main): Use startswith('win').
1147         (Tester._parse_args): Ditto.
1148
1149 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1150
1151         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1152         https://bugs.webkit.org/show_bug.cgi?id=150792
1153
1154         Reviewed by Saam Barati.
1155
1156         * Scripts/webkitperl/FeatureList.pm:
1157
1158 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1159
1160         Unreviewed, rolling out r192914.
1161         https://bugs.webkit.org/show_bug.cgi?id=151734
1162
1163         JSC tests for this change are failing on 32 and 64-bit bots
1164         (Requested by ryanhaddad on #webkit).
1165
1166         Reverted changeset:
1167
1168         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1169         enable this feature"
1170         https://bugs.webkit.org/show_bug.cgi?id=150792
1171         http://trac.webkit.org/changeset/192914
1172
1173 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1174
1175         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1176         <http://webkit.org/b/151726>
1177
1178         Reviewed by Simon Fraser.
1179
1180         * WebKitTestRunner/mac/EventSenderProxy.mm:
1181         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1182         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1183
1184 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1185
1186         Give String and AtomicString an existingHash() function
1187         https://bugs.webkit.org/show_bug.cgi?id=151717
1188
1189         Reviewed by Andreas Kling.
1190
1191         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1192         (TestWebKitAPI::TEST):
1193         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1194         (TestWebKitAPI::TEST):
1195
1196 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1197
1198         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1199         https://bugs.webkit.org/show_bug.cgi?id=150792
1200
1201         Reviewed by Saam Barati.
1202
1203         * Scripts/webkitperl/FeatureList.pm:
1204
1205 2015-12-01  Sam Weinig  <sam@webkit.org>
1206
1207         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1208         <rdar://problem/23320863>
1209         https://bugs.webkit.org/show_bug.cgi?id=151708
1210
1211         Reviewed by Anders Carlsson.
1212
1213         * WebKitTestRunner/TestController.cpp:
1214         (WTR::TestController::createOtherPage):
1215         (WTR::TestController::createWebViewWithOptions):
1216         Update for new WKPageUIClient.
1217
1218 2015-12-01  Anders Carlsson  <andersca@apple.com>
1219
1220         Remove WebKit2.framework
1221         https://bugs.webkit.org/show_bug.cgi?id=151715
1222
1223         Reviewed by Dan Bernstein.
1224
1225         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1226         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1227         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1228         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1229         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1230         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1231         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1232
1233 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
1234
1235         Unreviewed common typo fix "occurance" => "occurrence".
1236
1237         * Scripts/webkitpy/tool/commands/queries.py:
1238         (FindFlakyTests._print_statistics):
1239
1240 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1241
1242         Make ProcessModel always MultipleSecondaryProcesses
1243         https://bugs.webkit.org/show_bug.cgi?id=151662
1244
1245         Reviewed by Antti Koivisto.
1246
1247         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1248         (TestWebKitAPI::TEST):
1249         * WebKitTestRunner/TestController.cpp:
1250         (WTR::TestController::generatePageConfiguration):
1251
1252 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1253
1254         Make usesNetworkProcess always true
1255         https://bugs.webkit.org/show_bug.cgi?id=151580
1256
1257         Reviewed by Darin Adler.
1258
1259         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1260         (TestWebKitAPI::TEST):
1261         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1262         (TestWebKitAPI::TEST):
1263         * WebKitTestRunner/TestController.cpp:
1264         (WTR::TestController::generatePageConfiguration):
1265
1266 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1267
1268         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1269
1270         Add a way to skip unit tests only for Debug or Release builds and
1271         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1272
1273         * Scripts/run-gtk-tests:
1274         (SkippedTest):
1275         (SkippedTest.__init__):
1276         (SkippedTest.__str__):
1277         (SkippedTest.skip_entire_suite):
1278         (SkippedTest.skip_for_build_type):
1279         (TestRunner):
1280         (TestRunner.__init__):
1281
1282 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1283
1284         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
1285
1286         It's an assert hit because we are reloading a view loaded with
1287         HTML data which is not supported. Use loadURI instead.
1288
1289         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1290         (testWebViewCustomCharset):
1291
1292 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1293
1294         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
1295         https://bugs.webkit.org/show_bug.cgi?id=151633
1296
1297         Reviewed by Csaba Osztrogonác.
1298
1299         * TestWebKitAPI/PlatformGTK.cmake:
1300         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
1301
1302 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1303
1304         [GTK] Remove the remaining uses of GMainLoopSource
1305         https://bugs.webkit.org/show_bug.cgi?id=151632
1306
1307         Reviewed by Žan Doberšek.
1308
1309         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1310         (testWebViewSyncRequestOnMaxConns):
1311         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1312         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1313         (WTR::TestRunner::TestRunner):
1314         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1315         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1316         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1317         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1318         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1319         (WTR::timeoutSource):
1320         (WTR::TestController::notifyDone):
1321         (WTR::TestController::platformRunUntil):
1322
1323 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1324
1325         [cmake] Add testb3 to the build system
1326         https://bugs.webkit.org/show_bug.cgi?id=151619
1327
1328         Reviewed by Gyuyoung Kim.
1329
1330         * Scripts/build-jsc:
1331
1332 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1333
1334         [jhbuild] Fix pixman build with clang
1335         https://bugs.webkit.org/show_bug.cgi?id=151441
1336
1337         Reviewed by Carlos Garcia Campos.
1338
1339         * efl/jhbuild.modules:
1340         * gtk/jhbuild.modules:
1341
1342 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1343
1344         Extract prependToEnvironmentVariableList
1345         <http://webkit.org/b/151536>
1346
1347         Reviewed by Daniel Bates.
1348
1349         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1350                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1351
1352         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1353         and prependToEnvironmentVariableList.
1354         (appendToEnvironmentVariableList): Simplify variable name.
1355         Switch to use $Config{path_sep}.
1356         (prependToEnvironmentVariableList): Add new method.
1357         (setupMacWebKitEnvironment): Switch to use
1358         prependToEnvironmentVariableList().
1359         (setupIOSWebKitEnvironment): Ditto.
1360
1361         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1362         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1363
1364 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1365
1366         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1367         https://bugs.webkit.org/show_bug.cgi?id=151567
1368
1369         Reviewed by Darin Adler.
1370
1371         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1372         (on_window_deletion):
1373
1374 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1375
1376         [GTK] Use the network process unconditionally
1377         https://bugs.webkit.org/show_bug.cgi?id=151541
1378
1379         Reviewed by Alex Christensen.
1380
1381         Fix TestInspectorServer test. Do not assume we already have the
1382         title we want when the page has been loaded, since the title is
1383         changed afterwards. So, check if the title has already been set,
1384         and if not wait for it.
1385
1386         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1387         (openRemoteDebuggingSession):
1388
1389 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1390
1391         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1392         https://bugs.webkit.org/show_bug.cgi?id=151532
1393
1394         Reviewed by Benjamin Poulain.
1395
1396         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1397         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1398         (TestWebKitAPI::TEST):
1399         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1400         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
1401         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
1402         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
1403         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
1404         so it was calling a function on a test object that had gone out of scope.
1405         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
1406         but that will become the default soon and that call will be removed.
1407
1408 2015-11-22  David Kilzer  <ddkilzer@apple.com>
1409
1410         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
1411         <http://webkit.org/b/151542>
1412
1413         Reviewed by Daniel Bates.
1414
1415         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1416         (base_url): Use the Port object (already passed in) to give us
1417         the path to the LayoutTests directory, which already checks for a
1418         --layout-tests-directory command-line switch.
1419         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
1420         argument since we can get this from the Port object already
1421         passed in via Port.results_directory().  Also switch to use
1422         Port.layout_tests_dir() to get the LayoutTests directory.
1423
1424         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1425         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
1426         Add test case for custom LayoutTests directory.
1427         (TestWebPlatformTestServer.test_previously_spawned_instance):
1428         Update Port object to set mock results directory as if it was
1429         set on the command-line.  Remove unneeded argument from
1430         WebPlatformTestServer constructor.
1431         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
1432
1433         * Scripts/webkitpy/port/base.py:
1434         (Port.to.start_web_platform_test_server): Remove unneeded
1435         argument from WebPlatformTestServer constuctor.
1436
1437 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1438
1439         [GTK] Some unit tests fail when using the network process
1440         https://bugs.webkit.org/show_bug.cgi?id=151490
1441
1442         Reviewed by Martin Robinson.
1443
1444         Run the soup server in a separate thread in TestResources test to
1445         avoid deadlocks.
1446
1447         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1448         /webkit2/WebKitWebResource/get-data when using the network process.
1449
1450         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1451         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1452         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1453         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1454         present, create a WorkQueue to run the server.
1455         (WebKitTestServer::run): Run the server in the work queue if it
1456         has been created.
1457         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1458         type into server options as flags.
1459
1460 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1461
1462         [GTK] ImageDiff should normalize the diff image
1463         https://bugs.webkit.org/show_bug.cgi?id=151261
1464
1465         Reviewed by Sergio Villar Senin.
1466
1467         * ImageDiff/gtk/ImageDiff.cpp:
1468         (readPixbufFromStdin): Fix memory leak.
1469         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1470         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1471
1472 == Rolled over to ChangeLog-2015-11-21 ==