38841d296d4a31323ba53c16d2977494ec5d009b
[WebKit-https.git] / Tools / ChangeLog
1 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
2
3         Add myself (yoav@yoav.ws) to contributors.json
4         https://bugs.webkit.org/show_bug.cgi?id=133492
5
6         * Scripts/webkitpy/common/config/contributors.json:
7
8 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
9
10         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
11         https://bugs.webkit.org/show_bug.cgi?id=133149
12
13         Reviewed by Csaba Osztrogonác.
14
15         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
16
17 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
18
19         Add a verbose flag to binding tests
20         https://bugs.webkit.org/show_bug.cgi?id=122303
21
22         Reviewed by Csaba Osztrogonác.
23
24         This patch will:
25         - Add a verbose keyword argument to the BindingsTests constructor,
26         - Add --no-verbose option to the run-bindigs-test.
27         Verbose mode, which is on by default, prints positive results to stdout as before.
28         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
29
30         Original patch from Matthew Hanson <matthew_hanson@apple.com>
31
32         * Scripts/run-bindings-tests:
33         (main):
34         * Scripts/webkitpy/bindings/main.py:
35         (BindingsTests.__init__):
36         (BindingsTests.detect_changes):
37
38 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
39
40         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
41         https://bugs.webkit.org/show_bug.cgi?id=133455
42
43         Reviewed by Timothy Hatcher.
44
45         Since the perf. dashboard doesn't support following renamed benchmarks,
46         keep reporting Speedometer results as DoYouEvenBench results.
47
48         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
49         (_generate_results_dict):
50
51 2014-05-31  Darin Adler  <darin@apple.com>
52
53         Viewport percentage tests that resize the viewport are flaky
54         https://bugs.webkit.org/show_bug.cgi?id=133351
55
56         Reviewed by Anders Carlsson.
57
58         * DumpRenderTree/mac/DumpRenderTree.mm:
59         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
60         happens to be stored in the UI delegate object. This is part of resetting the
61         window position.
62
63         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
64         a frame rectangle. The size is stored in the size of the web view itself.
65         * DumpRenderTree/mac/UIDelegate.mm:
66         (-[UIDelegate resetWindowOrigin]): Added.
67         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
68         old version would store the frame, but not resize the web view!
69         (-[UIDelegate webViewFrame:]): Get the size from the web view.
70
71         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
72         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
73
74         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
75         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
76         the window.
77
78         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
79         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
80         window gets resized too, not just the web view.
81         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
82
83         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
84         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
85         window gets resized too, not just the web view.
86         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
87
88 2014-05-30  Michael Saboff  <msaboff@apple.com>
89
90         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
91         https://bugs.webkit.org/show_bug.cgi?id=133409
92
93         Reviewed by Filip Pizlo.
94
95         Handle creating a tarball the same way as running remote when processing
96         paths in prepareBundle.
97
98         * Scripts/run-jsc-stress-tests:
99
100 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
101
102         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
103         https://bugs.webkit.org/show_bug.cgi?id=132280
104
105         Reviewed by Chris Fleizach.
106
107         Remove implementation of logAccessibilityEvents() for ATK based
108         ports, as this has proved to be a flaky method of checking that
109         ATK events are being properly emitted. Instead, it's better to use
110         the addNotificationListener() functions and provide a JS callback
111         to check that the right events are being emmitted from the tests.
112
113         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
114         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
115         with dummy implementation.
116         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
117         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
118
119 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
120
121         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
122         https://bugs.webkit.org/show_bug.cgi?id=132280
123
124         Rubber stamped by Carlos Garcia Campos.
125
126         Fix two small issues with previous patch (r169483), that caused some tests to break.
127
128         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
129         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
130         duplicated entry.
131         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
132         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
133
134 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
135
136         [ATK] Added new accessibility signal: text-caret-moved.
137         Make AccessibilityUIElement.setSelectedTextRange work
138         as atk_text_set_caret_offset when given offset == 0.
139         https://bugs.webkit.org/show_bug.cgi?id=132527
140
141         Reviewed by Mario Sanchez Prada.
142
143         text-caret-moved signal in accessibilityController is needed to
144         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
145         as LayoutTests. Add the signal to the controller.
146
147         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
148         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
149         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
150         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
151         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
152         (setSelectedTextRange): Change return type to bool.
153         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
154         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
155         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
156         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
157         for extra arguments passed to handler and use it for text-caret-moved offset.
158         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
159         Connect callback to new listener for ATK:AtkText:text-caret-moved.
160         Refactor so that failures be reported.
161         Initialize atk interfaces before trying to connect to them, see
162         https://bugzilla.gnome.org/show_bug.cgi?id=729922
163         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
164         Simplify code by using a vector in place of dozen variables.
165         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
166         Comment about not synchronizing with accessibilityController.
167
168 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
169
170         [GTK] Add a WebKit2 Performance bot.
171         https://bugs.webkit.org/show_bug.cgi?id=132862
172
173         Reviewed by Csaba Osztrogonác.
174
175         This adds a GTK WebKit2 perf bot.
176
177         * BuildSlaveSupport/build.webkit.org-config/config.json:
178
179 2014-05-29  Dan Bernstein  <mitz@apple.com>
180
181         Fixed the WebKitTestRunner build after r169452.
182
183         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
184         (WTR::InjectedBundle::initialize):
185
186 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
187
188         Unreviewed. Update my email addresses in contributors.json.
189
190         * Scripts/webkitpy/common/config/contributors.json:
191
192 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
193
194         Need an API test for bug #133193 (r169315)
195         <https://bugs.webkit.org/show_bug.cgi?id=133324>
196
197         This adds an API test that ensures that calling "stop loading" during a
198         "did fail provisional load" callback doesn't crash.
199
200         Reviewed by Andy Estes.
201
202         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
203         Add new files to project.
204
205         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
206         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
207         If the message is the "test done" message, record that.
208         (TestWebKitAPI::setInjectedBundleClient):
209         Register a function for the "did receive message from injected bundle"
210         callback.
211         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
212         Assert that we received the message from the injected bundle, and set
213         'done' to finish the test.
214         (TestWebKitAPI::TEST):
215         Create a WebView, register a page loader client for the "did fail
216         provisional load" callback, and load a non-existent resource.
217
218         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
219         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
220         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
221         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
222         provisional load failed.
223         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
224         Register a page loader client for the "did fail provisional load"
225         callback.
226         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
227         Call WKBundlePageStopLoading() during the callback. This not crashing
228         is what we're ensuring with this test.
229
230 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
231
232         [GTK] Make it possible to build with FTL enabled
233         https://bugs.webkit.org/show_bug.cgi?id=133219
234
235         Reviewed by Philippe Normand.
236
237         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
238         same revision than mac.
239
240 2014-05-27  Michael Saboff  <msaboff@apple.com>
241
242         REGRESSION(r169265): sh: line 0: cd: ../.vm
243         https://bugs.webkit.org/show_bug.cgi?id=133242
244
245         Rubber stamped by Oliver Hunt.
246
247         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
248         array since the command may contain character escapes that don't work with the
249         array form of system().
250
251         * Scripts/run-jsc-stress-tests:
252
253 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
254
255         [EFL] Change download url of freetype6
256         https://bugs.webkit.org/show_bug.cgi?id=133303
257
258         Reviewed by Csaba Osztrogonác.
259
260         freetype6 tarball isn't downloaded in Korea. So, we need to
261         change the url for now.
262
263         * efl/jhbuild.modules:
264
265 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
266
267         Remove BLOB guards
268         https://bugs.webkit.org/show_bug.cgi?id=132863
269
270         Reviewed by Csaba Osztrogonác.
271
272         * Scripts/webkitperl/FeatureList.pm:
273
274 2014-05-27  Alberto Garcia  <berto@igalia.com>
275
276         Remove leftover comment from r165182.
277
278         Rubber stamped by Carlos Garcia Campos.
279
280         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
281
282 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
283
284         [EFL] Add LLVM as optional jhbuild module for FTL developers
285         https://bugs.webkit.org/show_bug.cgi?id=133216
286
287         Reviewed by Gyuyoung Kim.
288
289         * efl/jhbuild.modules:
290
291 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
292
293         Fix test failures on python test
294         https://bugs.webkit.org/show_bug.cgi?id=133297
295
296         Reviewed by Dirk Schulze.
297
298         2 tests are failing because of unbounded local variable reference in test_importer.py.
299
300         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
301         (TestImporter.import_tests):
302
303 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
304
305         [GTK] GObject DOM bindings API break test fails in the tests bots
306         https://bugs.webkit.org/show_bug.cgi?id=133211
307
308         Reviewed by Martin Robinson.
309
310         When generating the built product archive on platform GTK, we need
311         to copy also the file gtkdoc-webkitdom.cfg and the directory
312         DerivedSources/webkitdom.
313
314         * BuildSlaveSupport/built-product-archive:
315         (archiveBuiltProduct):
316
317 2014-05-26  Commit Queue  <commit-queue@webkit.org>
318
319         Unreviewed, rolling out r169122.
320         https://bugs.webkit.org/show_bug.cgi?id=133288
321
322         Broke CJK font fallback (Requested by ap on #webkit).
323
324         Reverted changeset:
325
326         "[Mac] WebProcess doesn't follow localization of UI process
327         when run as a service"
328         https://bugs.webkit.org/show_bug.cgi?id=133126
329         http://trac.webkit.org/changeset/169122
330
331 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
332
333         [GTK] WebProcess leaked when closing pages with network process enabled
334         https://bugs.webkit.org/show_bug.cgi?id=129684
335
336         Reviewed by Anders Carlsson.
337
338         Enable the test to check that web processes finish when the web
339         view is destroyed.
340
341         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
342
343 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
344
345         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
346         https://bugs.webkit.org/show_bug.cgi?id=133279
347
348         Reviewed by Philippe Normand.
349
350         generator.saw_warnings is only set by GTKDoc::generate(), so it
351         should only be used after generate.
352
353         * gtk/generate-gtkdoc:
354         (generate_documentation_for_config): Do not check
355         generator.saw_warnings again, simply return the value returned by
356         generate_doc() which is generator.saw_warnings. When rebasing,
357         returns always False since there aren't warnings.
358
359 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
360
361         W3C test importer should catch exceptions coming from HTML/CSS conversion
362         https://bugs.webkit.org/show_bug.cgi?id=133176
363
364         Reviewed by Darin Adler.
365
366         Exceptions raised when converting HTML/CSS are caught.
367         Files for which conversion failed are still copied to the target directory.
368         Each individual conversion failure is logged.
369         Total conversion failure number is logged at the end of the import process.
370
371         * Scripts/webkitpy/w3c/test_importer.py:
372         (TestImporter.import_tests):
373
374 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
375
376         [GTK] Allow to run the tests on the native X display.
377         https://bugs.webkit.org/show_bug.cgi?id=133157
378
379         Reviewed by Benjamin Poulain.
380
381         This adds a new driver (xorgdriver) that runs the tests on the
382         X display referenced by the environment variable DISPLAY.
383
384         This new driver will be activated only if the environment variable
385         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
386         tests and performance tests.
387
388         This patch also makes the script run-perf-tests to check the
389         system dependencies before starting the tests. Previously this
390         was not checked, and if the system dependencies were not met,
391         the script tried to execute the tests anyway, causing massive
392         failures. For example, if you had Xvfb not installed and you
393         wanted to use the Xvfb driver (the default on GTK and EFL),
394         run-perf-tests would not abort.
395
396         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
397         (PerfTestsRunner._parse_args): Check the system dependencies of
398         the driver before starting the tests.
399         * Scripts/webkitpy/port/driver.py:
400         (Driver): Implement generic check_driver method.
401         (Driver.check_driver):
402         (Driver.check_driver.implementation):
403         * Scripts/webkitpy/port/gtk.py:
404         (GtkPort._driver_class): Check for environment variable
405         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
406         * Scripts/webkitpy/port/xorgdriver.py: Added.
407         (XorgDriver): Implement Xorg driver.
408         (XorgDriver.check_driver):
409         (XorgDriver._start):
410
411 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
412
413         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
414         https://bugs.webkit.org/show_bug.cgi?id=133215
415
416         Reviewed by Csaba Osztrogonác.
417
418         This reverts r166798.
419
420         * BuildSlaveSupport/kill-old-processes:
421         (main):
422
423 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
424
425         [EFL] Turn on ENABLE_CSS_FILTERS in build script
426         https://bugs.webkit.org/show_bug.cgi?id=133278
427
428         Reviewed by Gyuyoung Kim.
429
430         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
431
432 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
433
434         run-javascriptcore-tests warning fix on non Mac platforms
435         https://bugs.webkit.org/show_bug.cgi?id=133260
436
437         Reviewed by Darin Adler.
438
439         * Scripts/webkitdirs.pm:
440         (argumentsForConfiguration):
441
442 2014-05-23  Michael Saboff  <msaboff@apple.com>
443
444         REGRESSION(r169265): sh: line 0: cd: ../.vm
445         https://bugs.webkit.org/show_bug.cgi?id=133242
446
447         Rubber stamped by Geoffrey Garen.
448
449         Added missing shell escapes '\' required as part of previous fix.
450
451         * Scripts/run-jsc-stress-tests:
452
453 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
454
455         Revert the erroneous change committed in r169286.
456
457         * Scripts/webkitpy/performance_tests/perftest.py:
458         (PerfTest._run_with_driver):
459
460 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
461
462         run-perf-tests should ignore whitespace lines when snarfing test output
463         https://bugs.webkit.org/show_bug.cgi?id=133238
464
465         Reviewed by Ryosuke Niwa.
466
467         Required for PerformanceTests/Canvas/terrain.html.
468
469         * Scripts/webkitpy/performance_tests/perftest.py:
470         (PerfTest._run_with_driver):
471         (PerfTest):
472
473 2014-05-23  Michael Saboff  <msaboff@apple.com>
474
475         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
476         https://bugs.webkit.org/show_bug.cgi?id=133223
477
478         Reviewed by Geoffrey Garen.
479
480         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
481         string before calling IO.popen() to work with older versions of ruby.
482         Changed the remote path in runShellTestRunner to quote the command
483         string we want to run via ssh so that it will work correctly with array
484         to string conversion needed for popen.
485
486         * Scripts/run-jsc-stress-tests:
487
488 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
489
490         Remove 'css-shaders' option from the build-webkit
491         https://bugs.webkit.org/show_bug.cgi?id=133212
492
493         Reviewed by Daniel Bates.
494
495         Original CSS shaders removed in r162644.
496
497         * Scripts/webkitperl/FeatureList.pm:
498
499 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
500
501         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
502         https://bugs.webkit.org/show_bug.cgi?id=133209
503
504         Reviewed by Sergio Villar Senin.
505
506         Return FAILURE when the command failed to run.
507
508         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
509         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
510
511 2014-05-23  Alberto Garcia  <berto@igalia.com>
512
513         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
514         https://bugs.webkit.org/show_bug.cgi?id=133210
515
516         Reviewed by Carlos Garcia Campos.
517
518         * gtk/install-dependencies:
519
520 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
521
522         Add Yusuke Suzuki to the list of contributors (for real)
523
524         Wrong section...
525
526         * Scripts/webkitpy/common/config/contributors.json:
527
528 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
529
530         Add Yusuke Suzuki to the list of contributors
531
532         * Scripts/webkitpy/common/config/contributors.json:
533
534 2014-05-22  Michael Saboff  <msaboff@apple.com>
535
536         Eliminate n/total progress update from run-jsc-stress-tests output to file
537         https://bugs.webkit.org/show_bug.cgi?id=133191
538
539         Reviewed by Geoffrey Garen.
540
541         Changed progressMeter setting to be based on stdout being a tty instead of
542         stdin.  Unified the processing of output from the shell runner to match the
543         same processing as is used by the makefile runner.  As part of this, the 
544         shell runner script was simplified.  It now forwards the output of each
545         test_script just like the Makefile and doesn't provide its own progress.
546
547         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
548         * Scripts/run-jsc-stress-tests:
549
550 2014-05-22  Michael Saboff  <msaboff@apple.com>
551
552         Add option to run-jsc-stress-tests to use installed jsc
553         https://bugs.webkit.org/show_bug.cgi?id=133102
554
555         Reviewed by Geoffrey Garen.
556
557         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
558         provied with the --jsc option.
559
560         * Scripts/run-jsc-stress-tests:
561
562 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
563
564         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
565         https://bugs.webkit.org/show_bug.cgi?id=132907
566
567         Reviewed by Gyuyoung Kim.
568
569         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
570         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
571
572         * efl/install-dependencies:
573
574 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
575
576         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
577         https://bugs.webkit.org/show_bug.cgi?id=133145
578
579         Reviewed by Csaba Osztrogonác.
580
581         * Scripts/run-jsc-stress-tests:
582
583 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
584
585         [Mac] WebProcess doesn't follow localization of UI process when run as a service
586         https://bugs.webkit.org/show_bug.cgi?id=133126
587         <rdar://problem/13396515>
588         <rdar://problem/16561084>
589
590         Reviewed by Sam Weinig and Tim Horton.
591
592         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
593         (WTR::InjectedBundle::platformInitialize): It was too late to override language
594         here, and it's not necessary any more. Keeping the code for older OS versions in
595         case it did have effect in some code paths.
596
597 2014-05-19  David Farler  <dfarler@apple.com>
598
599         Move WebKitTestRunner to std::unique_ptr
600         https://bugs.webkit.org/show_bug.cgi?id=133081
601
602         Reviewed by Daniel Bates.
603
604         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
605         (WTR::InjectedBundle::didCreatePage):
606         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
607         * WebKitTestRunner/TestController.cpp:
608         (WTR::TestController::initialize):
609         (WTR::TestController::createWebViewWithOptions):
610         (WTR::TestController::resetStateToConsistentValues):
611         (WTR::TestController::runTest):
612         * WebKitTestRunner/TestController.h:
613         * WebKitTestRunner/TestInvocation.cpp:
614         * WebKitTestRunner/TestInvocation.h:
615         * WebKitTestRunner/WorkQueueManager.cpp:
616         (WTR::WorkQueueManager::processWorkQueue):
617         (WTR::WorkQueueManager::enqueue):
618         * WebKitTestRunner/WorkQueueManager.h:
619
620 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
621
622         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
623         https://bugs.webkit.org/show_bug.cgi?id=133119
624
625         Reviewed by Sergio Villar Senin.
626
627         Check that redirect response parameter of
628         WebKitWebPage::send-request signal is NULL when not redirecting
629         and a valid WebKitURIResponse object when redirecting.
630
631         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
632         (testWebResourceSendRequest):
633         (serverCallback):
634         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
635         (sendRequestCallback):
636
637 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
638
639         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
640         https://bugs.webkit.org/show_bug.cgi?id=133117
641
642         Reviewed by Philippe Normand.
643
644         Bring back missing tests to the build.
645
646         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
647
648 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
649
650         Take care of some ARM64 test failures
651         https://bugs.webkit.org/show_bug.cgi?id=133090
652
653         Reviewed by Geoffrey Garen.
654
655         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
656
657 2014-05-19  David Kilzer  <ddkilzer@apple.com>
658
659         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
660         <http://webkit.org/b/133089>
661
662         Reviewed by Darin Adler.
663
664         * Scripts/webkitdirs.pm:
665         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
666         specified on the command line, we would remove the '--sdk'
667         arguments, but leave '--sim', potentially passing it along to
668         xcodebuild causing a build failure.  This happens when
669         'old-run-webkit-tests --release --sim' invokes
670         build-dumprendertree when DumpRenderTree hasn't been built yet.
671
672 2014-05-19  David Farler  <dfarler@apple.com>
673
674         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
675         https://bugs.webkit.org/show_bug.cgi?id=133086
676
677         Reviewed by Daniel Bates.
678
679         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
680
681 2014-05-19  David Kilzer  <ddkilzer@apple.com>
682
683         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
684         <http://webkit.org/b/132954>
685
686         * Scripts/webkitdirs.pm:
687         (sharedCommandLineOptionsUsage): Remove the prototype for the
688         subroutine.  Older perls don't like the "+@" syntax.
689
690 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
691
692         run-javascriptcore-tests should sort the list of failing stress tests
693         https://bugs.webkit.org/show_bug.cgi?id=132989
694
695         Reviewed by Csaba Osztrogonác.
696
697         * Scripts/run-javascriptcore-tests:
698
699 2014-05-19  David Kilzer  <ddkilzer@apple.com>
700
701         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
702         <http://webkit.org/b/132954>
703
704         Reviewed by Darin Adler.
705
706         Extract code into setupMacWebKitEnvironment() for setting up
707         common environment variables so it may be shared.  Sets
708         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
709         using guardmalloc to some scripts.
710
711         Also adds support for parsing shared (common) command-line
712         switches, initially just -g|--guard-malloc.
713
714         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
715         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
716         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
717         local copy of %ENV when launching Safari so we don't have to
718         restore variables.
719
720         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
721         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
722         Check result of GetOptions() to catch invalid command-line
723         switches.
724         (runTest): Use a local copy of %ENV when running tests so we
725         don't have to restore variables.
726         (prepareEnvironmentForRunningTestTool): Call
727         setupMacWebKitEnvironment().
728
729         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
730         using sharedCommandLineOptions() and
731         sharedCommandLineOptionsUsage().  Call
732         setupMacWebKitEnvironment().
733
734         * Scripts/webkitdirs.pm:
735         (sharedCommandLineOptions): Return array of common switches to
736         pass to Getopt::Long::GetOptions().
737         (sharedCommandLineOptionsUsage): Return formatted string of
738         common switches for printing usage help text.
739         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
740         guardmalloc.
741         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
742         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
743         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
744         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
745         local copy of %ENV when launching Safari so we don't have to
746         restore variables.
747         (execMacWebKitAppForDebugging): Call
748         setupMacWebKitEnvironment().
749
750 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
751
752         support for navigator.hardwareConcurrency
753         https://bugs.webkit.org/show_bug.cgi?id=132588
754
755         Reviewed by Filip Pizlo.
756
757         * Scripts/webkitperl/FeatureList.pm:
758
759 2014-05-18  Anders Carlsson  <andersca@apple.com>
760
761         Implement Navigations for all methods declared returning one
762         https://bugs.webkit.org/show_bug.cgi?id=133048
763         <rdar://problem/16830064>
764
765         Reviewed by Sam Weinig.
766
767         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
768         Import WebKit.h.
769         
770         * MiniBrowser/mac/WK2BrowserWindowController.m:
771         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
772         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
773         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
774         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
775         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
776         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
777         Print out the navigations.
778
779 2014-05-17  Zalan Bujtas  <zalan@apple.com>
780
781         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
782         https://bugs.webkit.org/show_bug.cgi?id=133029
783
784         Reviewed by Simon Fraser.
785
786         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
787         toggling it on a WK2 window needs restart.
788         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
789         the WebPreferences just to support this temporary toggle.
790
791         * MiniBrowser/mac/BrowserWindowController.h:
792         * MiniBrowser/mac/MainMenu.xib:
793         * MiniBrowser/mac/WK1BrowserWindowController.m:
794         (-[WK1BrowserWindowController validateMenuItem:]):
795         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
796         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
797         * MiniBrowser/mac/WK2BrowserWindowController.m:
798         (-[WK2BrowserWindowController validateMenuItem:]):
799         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
800         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
801
802 2014-05-17  Anders Carlsson  <andersca@apple.com>
803
804         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
805         https://bugs.webkit.org/show_bug.cgi?id=133033
806         <rdar://problem/16830143>
807
808         Reviewed by Sam Weinig.
809
810         Set up the WebSQL and IndexedDB directories.
811
812         * WebKitTestRunner/TestController.cpp:
813         (WTR::TestController::initialize):
814
815 2014-05-16  Martin Hock  <mhock@apple.com>
816
817         MemoryCache::addImageToCache should return the result of add().
818         https://bugs.webkit.org/show_bug.cgi?id=132928
819         <rdar://problem/16651547>
820
821         Reviewed by Alexey Proskuryakov.
822
823         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
825         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
826         (TestWebKitAPI::TEST):
827
828 2014-05-15  David Farler  <dfarler@apple.com>
829
830         old-run-webkit-tests: allow specifying a simulator app path
831         https://bugs.webkit.org/show_bug.cgi?id=132975
832
833         Reviewed by Anders Carlsson.
834
835         * Scripts/old-run-webkit-tests:
836         (openIPhoneSimulator):
837         Add new --simulator-app command line parameter for specifying the
838         absolute path to the simulator app to launch before starting a
839         session.
840
841 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
842
843         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
844         https://bugs.webkit.org/show_bug.cgi?id=131363
845
846         Reviewed by Csaba Osztrogonác.
847
848         * Scripts/webkitpy/common/checkout/checkout_mock.py:
849         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
850         (MockBugzilla):
851         * Scripts/webkitpy/tool/commands/download_unittest.py:
852         (test_create_rollout_multiple_revision_with_one_resolved):
853         (test_create_rollout_multiple_resolved):
854         (test_rollout_two_revisions):
855         (test_rollout_multiple_revisions):
856         (test_rollout_multiple_revisions_with_a_missing_bug_id):
857         * Scripts/webkitpy/tool/steps/createbug.py:
858         (CreateBug.run):
859         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
860         (ReopenBugAfterRollout.run):
861
862 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
863
864         [WK2] Change the remaining framework includes from WebKit2 to WebKit
865         https://bugs.webkit.org/show_bug.cgi?id=132956
866
867         Reviewed by Sam Weinig.
868
869         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
870         * MiniBrowser/mac/AppDelegate.m:
871         * MiniBrowser/mac/WK2BrowserWindowController.m:
872         * TestWebKitAPI/InjectedBundleController.h:
873         * TestWebKitAPI/InjectedBundleMain.cpp:
874         * TestWebKitAPI/JavaScriptTest.cpp:
875         * TestWebKitAPI/PlatformUtilities.h:
876         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
877         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
878         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
879         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
880         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
881         (TestWebKitAPI::TEST):
882         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
883         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
884         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
885         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
886         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
887         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
888         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
889         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
890         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
891         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
892         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
893         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
894         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
895         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
896         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
897         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
898         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
899         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
900         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
901         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
902         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
903         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
904         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
905         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
906         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
907         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
908         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
909         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
910         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
911         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
912         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
913         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
914         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
915         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
916         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
917         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
918         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
919         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
920         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
921         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
922         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
923         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
924         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
925         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
926         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
927         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
928         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
929         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
930         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
931         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
932         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
933         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
934         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
935         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
936         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
937         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
938         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
939         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
940         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
941         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
942         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
943         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
944         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
945         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
946         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
947         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
948         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
949         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
950         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
951         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
952         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
953         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
954         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
955         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
956         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
957         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
958         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
959         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
960         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
961         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
962         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
963         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
964         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
965         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
966         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
967         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
968         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
969         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
970         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
971         * TestWebKitAPI/config.h:
972         * TestWebKitAPI/efl/PlatformWebView.cpp:
973         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
974         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
975         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
976         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
977         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
978         * WebKitTestRunner/EventSenderProxy.h:
979         * WebKitTestRunner/GeolocationProviderMock.cpp:
980         * WebKitTestRunner/GeolocationProviderMock.h:
981         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
982         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
983         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
984         * WebKitTestRunner/InjectedBundle/GCController.cpp:
985         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
986         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
987         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
988         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
989         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
990         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
991         * WebKitTestRunner/InjectedBundle/TestRunner.h:
992         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
993         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
994         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
995         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
996         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
997         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
998         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
999         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1000         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1001         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1002         * WebKitTestRunner/PlatformWebView.h:
1003         * WebKitTestRunner/StringFunctions.h:
1004         * WebKitTestRunner/TestController.cpp:
1005         * WebKitTestRunner/TestController.h:
1006         * WebKitTestRunner/TestInvocation.cpp:
1007         * WebKitTestRunner/TestInvocation.h:
1008         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1009         * WebKitTestRunner/WebNotificationProvider.cpp:
1010         * WebKitTestRunner/WebNotificationProvider.h:
1011         * WebKitTestRunner/WorkQueueManager.cpp:
1012         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1013         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1014         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1015         * WebKitTestRunner/config.h:
1016         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1017         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1018         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1019         * WebKitTestRunner/ios/TestControllerIOS.mm:
1020         * WebKitTestRunner/mac/EventSenderProxy.mm:
1021         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1022         * WebKitTestRunner/mac/TestControllerMac.mm:
1023
1024 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1025
1026         [EFL][WK2] Skip failing unit tests
1027         https://bugs.webkit.org/show_bug.cgi?id=132979
1028
1029         Reviewed by Daniel Bates.
1030
1031         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
1032
1033 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1034
1035         [iOS] Support TestWebKitAPI in the iOS Simulator
1036         <http://webkit.org/b/129535>
1037         <rdar://problem/16203529>
1038
1039         Reviewed by Daniel Bates.
1040
1041         * Scripts/run-api-tests:
1042         (runTest):
1043         (listAllTests):
1044         - Extract common arguments into local variable.
1045         - Use xcrun to find the sim tool in order to invoke
1046         TestWebKitAPI properly in the iOS Simulator. 
1047
1048         * Scripts/webkitdirs.pm:
1049         (argumentsForConfiguration): Set --device or --sim as
1050         appropriate to fix buildTestTool() in run-api-tests.
1051
1052 2014-05-15  Tim Horton  <timothy_horton@apple.com>
1053
1054         Fix a logging typo in copy-webkitlibraries-to-product-directory
1055
1056         Reviewed by Dean Jackson.
1057
1058         * Scripts/copy-webkitlibraries-to-product-directory:
1059
1060 2014-05-15  David Kilzer  <ddkilzer@apple.com>
1061
1062         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
1063         <http://webkit.org/b/132959>
1064
1065         Reviewed by Dan Bernstein.
1066
1067         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1068         Cocoa directory to project and move URLExtras.mm into it.
1069         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
1070
1071 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1072
1073         [GTK] Compile all installed resources as GResources
1074         https://bugs.webkit.org/show_bug.cgi?id=131099
1075
1076         Reviewed by Philippe Normand.
1077
1078         * Scripts/webkitpy/port/gtk.py:
1079         (GtkPort.setup_environ_for_server): Removed now unneeded
1080         AUDIO_RESOURCES_PATH env var.
1081
1082 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1083
1084         Remove CSS_STICKY_POSITION guards
1085         https://bugs.webkit.org/show_bug.cgi?id=132676
1086
1087         Reviewed by Simon Fraser.
1088
1089         * Scripts/webkitperl/FeatureList.pm:
1090
1091 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1092
1093         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
1094         https://bugs.webkit.org/show_bug.cgi?id=132686
1095
1096         Reviewed by Philippe Normand.
1097
1098         Bring back InputMethodFilter test to the build and compile it into
1099         a single binary TestWebCore with the other WebCore tests. Also
1100         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
1101
1102         * Scripts/run-gtk-tests:
1103         (TestRunner): Remove WebCoreGtk from the list of test directories.
1104         * TestWebKitAPI/PlatformGTK.cmake:
1105         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
1106
1107 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1108
1109         [EFL] Make XVFBDriver optional
1110         https://bugs.webkit.org/show_bug.cgi?id=131036
1111
1112         Reviewed by Gyuyoung Kim.
1113
1114         * Scripts/webkitpy/port/efl.py:
1115         (EflPort._driver_class):
1116
1117 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1118
1119         Flakiness dashboard contains outdated list of bots on builders.jsonp
1120         https://bugs.webkit.org/show_bug.cgi?id=132874
1121
1122         Reviewed by Darin Adler.
1123
1124         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
1125         file by changing to the directory Tools/TestResultServer and executing
1126         the script generate_builders_json.py
1127
1128 2014-05-11  Anders Carlsson  <andersca@apple.com>
1129
1130         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
1131         https://bugs.webkit.org/show_bug.cgi?id=132809
1132
1133         Reviewed by Dan Bernstein.
1134
1135         * WebKitTestRunner/TestController.cpp:
1136         (WTR::TestController::initialize):
1137         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
1138
1139 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1140
1141         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
1142         https://bugs.webkit.org/show_bug.cgi?id=132739
1143
1144         Reviewed Anders Carlsson.
1145
1146         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
1147         the JSC unit tests.
1148         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
1149
1150 2014-05-11  Anders Carlsson  <andersca@apple.com>
1151
1152         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
1153         https://bugs.webkit.org/show_bug.cgi?id=132806
1154
1155         Reviewed by Beth Dakin.
1156
1157         Migrate to WKContextConfiguration.
1158
1159         * WebKitTestRunner/TestController.cpp:
1160         (WTR::TestController::initialize):
1161
1162 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1163
1164         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
1165         https://bugs.webkit.org/show_bug.cgi?id=132685
1166
1167         Reviewed by Martin Robinson.
1168
1169         Use a single TestWebKit2 binary for all WebKit2 C API tests.
1170
1171         * TestWebKitAPI/PlatformGTK.cmake:
1172
1173 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
1174
1175         [iOS] Switch geolocation to an explicit authorization query model
1176         https://bugs.webkit.org/show_bug.cgi?id=132717
1177
1178         Reviewed by Sam Weinig.
1179
1180         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1181         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
1182         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
1183
1184 2014-05-09  David Farler  <dfarler@apple.com>
1185
1186         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
1187         https://bugs.webkit.org/show_bug.cgi?id=132718
1188
1189         Reviewed by David Kilzer.
1190
1191         The simulator may not be able to look up runtimes by SDK paths
1192         and instead will map SDK versions to runtimes instead. In
1193         com.apple.iphonesimulator.startSession notifications,
1194         'runtimeIdentifier' (SDK version string) is preferred over
1195         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
1196         when creating a new DRT or WKTR simulator session.
1197
1198         IPhoneSimulatorNotification.pm filters out keys for this
1199         notification's userInfo with a hard-coded list. There's no harm
1200         in including extra key-value pairs in an NSNotification userInfo
1201         dictionary anyway and the simulator may again change its
1202         userInfo schema for this notification.
1203
1204         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
1205         (postStartSessionNotification):
1206         * Scripts/old-run-webkit-tests:
1207         (installAndLaunchDumpToolAppUsingNotification):
1208
1209 2014-05-09  Anders Carlsson  <andersca@apple.com>
1210
1211         Another build fix.
1212
1213         * Scripts/build-webkit:
1214         WebKit2 should always be built for OS X and iOS.
1215
1216 2014-05-09  Anders Carlsson  <andersca@apple.com>
1217
1218         Follow-up build fix.
1219
1220         * Scripts/build-webkit:
1221         WebKit2 should no longer be built before WebKit.
1222
1223 2014-05-09  Anders Carlsson  <andersca@apple.com>
1224
1225         Rename WebKit2.framework to WebKit.framework
1226         https://bugs.webkit.org/show_bug.cgi?id=132743
1227         <rdar://problem/15920046>
1228
1229         Reviewed by Dan Bernstein.
1230
1231         * Scripts/check-for-inappropriate-files-in-framework:
1232         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
1233         Change WebKit2 to WebKit.
1234
1235         * Scripts/check-for-webkit-framework-include-consistency:
1236         Change WebKit to WebKitLegacy.
1237
1238 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
1239
1240         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
1241         https://bugs.webkit.org/show_bug.cgi?id=132732
1242
1243         Reviewed by Alexey Proskuryakov.
1244
1245         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
1246
1247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1248         (EWS): Remove GTK+ WK1 EWS.
1249
1250 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1251
1252         Add new u-szeged contributors.
1253
1254         Reviewed by Csaba Osztrogonác.
1255
1256         * Scripts/webkitpy/common/config/contributors.json:
1257
1258 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1259
1260         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
1261         https://bugs.webkit.org/show_bug.cgi?id=132736
1262
1263         Reviewed by Philippe Normand.
1264
1265         There are two problems, the path returned by common.library_build_path() is wrong when
1266         common.binary_build_path() has previously been called, and the test is still looking for
1267         the .la instead of .so
1268
1269         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1270         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
1271         of .la as extension of the injected bundle library.
1272         * gtk/common.py:
1273         (binary_build_path): Remove unused global variable and add a new
1274         one for binary_build_dir instead of sharing the same global
1275         variable for library_build_path and binary_build_path.
1276
1277 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
1278
1279         [EFL] Enable MEDIA_STREAM for EFL port
1280         https://bugs.webkit.org/show_bug.cgi?id=132648
1281
1282         Reviewed by Gyuyoung Kim.
1283
1284         Script modified to enable MEDIA_STREAM for EFL build.
1285
1286         * Scripts/webkitperl/FeatureList.pm: 
1287
1288 2014-05-08  David Farler  <dfarler@apple.com>
1289
1290         old-run-webkit-tests: update strings for simulator devices and app name
1291         https://bugs.webkit.org/show_bug.cgi?id=132687
1292
1293         Reviewed by Darin Adler.
1294
1295         iPhone Retina (4-inch) -> iPhone 5
1296         iPhone Retina (4-inch 64-bit) -> iPhone 5s
1297
1298         * Scripts/old-run-webkit-tests:
1299         (installAndLaunchDumpToolAppUsingNotification):
1300         (openIPhoneSimulator):
1301         (quitIPhoneSimulator):
1302         quit iOS Simulator, not iPhone Simulator.
1303
1304 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1305
1306         REGRESSION(r168471): Update the builder names on the scheduler list.
1307         https://bugs.webkit.org/show_bug.cgi?id=132699
1308
1309         Reviewed by Martin Robinson.
1310
1311         On r168471 I missed to update the builder names for the GTK build
1312         bots on the AnyBranchScheduler type scheduler list of bots.
1313
1314         * BuildSlaveSupport/build.webkit.org-config/config.json:
1315
1316 2014-05-08  Brady Eidson  <beidson@apple.com>
1317
1318         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
1319         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
1320
1321         Reviewed by Tim Horton.
1322
1323         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1324         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1325
1326 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1327
1328         REGRESSION(r168471): Duplicate builddirs broke the build master.
1329         https://bugs.webkit.org/show_bug.cgi?id=132688
1330
1331         Reviewed by Carlos Garcia Campos.
1332
1333         Rename the builddirs of the new GTK bots introduced on r168471 to
1334         be unique. Otherwise the master will break.
1335
1336         * BuildSlaveSupport/build.webkit.org-config/config.json:
1337
1338 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1339
1340         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
1341         https://bugs.webkit.org/show_bug.cgi?id=132674
1342
1343         Reviewed by Philippe Normand.
1344
1345         Only ignore mkdir failure when exception is raised because the
1346         file already exists and it's a directory.
1347
1348         * gtk/webkitdom.py:
1349         (write_doc_files):
1350
1351 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1352
1353         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
1354         https://bugs.webkit.org/show_bug.cgi?id=131358
1355
1356         Reviewed by Carlos Garcia Campos.
1357
1358         Current 64-bit GTK build bots (Release and Debug) not only test
1359         the build, but run all tests. Split each one of the bots in
1360         BuildOnly and TestWebKit2.
1361
1362         This will allow us to have a better overview of the status of
1363         the GTK port.
1364
1365         Original patch from Sergio Villar Senin <svillar@igalia.com>
1366
1367         * BuildSlaveSupport/build.webkit.org-config/config.json:
1368         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1369         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1370         (WebKitBuildbot):
1371         * Scripts/webkitpy/port/builders.py:
1372         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1373         (TestRebaselineTest.test_baseline_directory):
1374         * TestResultServer/static-dashboards/builders.jsonp:
1375         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1376         (resetGlobals):
1377         * TestResultServer/static-dashboards/loader_unittests.js:
1378
1379 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1380
1381         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
1382         https://bugs.webkit.org/show_bug.cgi?id=126022
1383
1384         Reviewed by Benjamin Poulain.
1385
1386         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
1387
1388         Added an unit test case to check if scroll position and scale are restored properly.
1389
1390         * TestWebKitAPI/PlatformEfl.cmake:
1391         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
1392         (TestWebKitAPI::didFinishLoadForFrame):
1393         (TestWebKitAPI::didChangeContentsPosition):
1394         (TestWebKitAPI::TEST):
1395         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
1396         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
1397
1398 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
1399
1400         WebKit1 is flashy when compositing layers come and go
1401         https://bugs.webkit.org/show_bug.cgi?id=132655
1402         <rdar://problem/16830981&16788846>
1403
1404         Reviewed by Sam Weinig.
1405         
1406         Revert the change from r166117.
1407
1408         * DumpRenderTree/mac/DumpRenderTree.mm:
1409         (updateDisplay):
1410
1411 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
1412
1413         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
1414         https://bugs.webkit.org/show_bug.cgi?id=132622
1415
1416         Reviewed by Mario Sanchez Prada.
1417
1418         * DumpRenderTree/AccessibilityUIElement.cpp:
1419         (selectTextWithCriteriaCallback):
1420         (isEqualCallback):
1421         * DumpRenderTree/AccessibilityUIElement.h:
1422         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1423         (AccessibilityUIElement::selectTextWithCriteria):
1424         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1425         (AccessibilityUIElement::selectTextWithCriteria):
1426         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1427         (selectTextParameterizedAttributeForCriteria):
1428         (AccessibilityUIElement::selectTextWithCriteria):
1429         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1430         (AccessibilityUIElement::selectTextWithCriteria):
1431         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1432         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1433         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1434         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1435         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1436         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1437         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1438         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1439         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1440         (WTR::selectTextParameterizedAttributeForCriteria):
1441         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1442
1443 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1444
1445         [SOUP] TLSErrors do not cause page load to fail when not ignored
1446         https://bugs.webkit.org/show_bug.cgi?id=121548
1447
1448         Reviewed by Sergio Villar Senin.
1449
1450         Add unit tests to check that the load fails with TLS errors in
1451         case of a redirection.
1452
1453         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1454         (testTLSErrorsRedirect):
1455         (httpsServerCallback):
1456         (beforeAll):
1457
1458 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
1459
1460         [CSS Grid Layout] Remove runtime feature
1461         https://bugs.webkit.org/show_bug.cgi?id=132382
1462
1463         Reviewed by Benjamin Poulain.
1464
1465         Remove cssGridLayoutEnabled setting usage.
1466
1467         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1468         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1469         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1470         (TestRunner::overridePreference):
1471         * DumpRenderTree/mac/DumpRenderTree.mm:
1472         (resetWebPreferencesToConsistentValues):
1473
1474 2014-05-06  David Kilzer  <ddkilzer@apple.com>
1475
1476         Add Makefile targets for copying static libraries (LLVM and WKSI)
1477         <http://webkit.org/b/132619>
1478
1479         Reviewed by Mark Rowe.
1480
1481         * Scripts/copy-webkitlibraries-to-product-directory: Set a
1482         sensible default for product directory if not specified on
1483         either the command-line or in the environment (by Xcode) by
1484         calling productDir() in webkitdirs.pm.
1485
1486 2014-05-06  Brady Eidson  <beidson@apple.com>
1487
1488         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
1489         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
1490
1491         Reviewed by Sam Weinig.
1492
1493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1494
1495         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
1496         (TestWebKitAPI::itemURLLastComponentIsString):
1497         (TestWebKitAPI::didFinishLoadForFrame):
1498         (TestWebKitAPI::willGoToBackForwardListItem):
1499         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1500         (TestWebKitAPI::setPageLoaderClient):
1501         (TestWebKitAPI::TEST):
1502         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
1503         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
1504
1505         * WebKitTestRunner/TestController.cpp:
1506         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
1507
1508 2014-05-06  Darin Adler  <darin@apple.com>
1509
1510         Try to fix iOS build.
1511
1512         * DumpRenderTree/mac/TestRunnerMac.mm:
1513         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
1514         Updated since I changed testRunner into a pointer instead of a reference.
1515         Updated argument names to avoid conflict with field names.
1516         (-[APITestDelegateIPhone run]): Ditto.
1517         (-[APITestDelegateIPhone _cleanUp]): Ditto.
1518
1519 2014-05-06  Commit Queue  <commit-queue@webkit.org>
1520
1521         Unreviewed, rolling out r168304.
1522         https://bugs.webkit.org/show_bug.cgi?id=132607
1523
1524         Broke the build (Requested by KaL on #webkit).
1525
1526         Reverted changeset:
1527
1528         "[GTK][CMake] Unable to do make install"
1529         https://bugs.webkit.org/show_bug.cgi?id=130188
1530         http://trac.webkit.org/changeset/168304
1531
1532 2014-05-04  Darin Adler  <darin@apple.com>
1533
1534         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
1535         https://bugs.webkit.org/show_bug.cgi?id=80222
1536
1537         Reviewed by Alexey Proskuryakov.
1538
1539         * DumpRenderTree/mac/TestRunnerMac.mm:
1540         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
1541         do more work here so we don't use RetainPtr local variables.
1542         (-[APITestDelegateIPhone dealloc]): Added.
1543         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
1544         created. Updated for changes to member names and types.
1545         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
1546         updated for changes to member names and types. Changed to two word spelling.
1547         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
1548         name of _cleanUp method.
1549         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
1550         Ditto.
1551         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
1552
1553 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
1554
1555         Clean up Image Document and tweak the layout and viewport
1556         https://bugs.webkit.org/show_bug.cgi?id=132552
1557
1558         Reviewed by Anders Carlsson.
1559
1560         * DumpRenderTree/mac/DumpRenderTree.mm:
1561         (resetWebPreferencesToConsistentValues):
1562         Update the default settings to have something consistent with WebKit2.
1563
1564 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
1565
1566         [GTK][CMake] Unable to do make install
1567         https://bugs.webkit.org/show_bug.cgi?id=130188
1568
1569         Reviewed by Carlos Garcia Campos.
1570
1571         * Scripts/webkitdirs.pm:
1572         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
1573         will give an early signal that a change has broken the documentation.
1574
1575 2014-05-05  Pratik Solanki  <psolanki@apple.com>
1576
1577         Update framework locations in package-root
1578         https://bugs.webkit.org/show_bug.cgi?id=132571
1579
1580         Reviewed by Simon Fraser.
1581
1582         * Scripts/package-root:
1583
1584 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
1585
1586         [EFL][WK2] Refactor favicon database APIs
1587         https://bugs.webkit.org/show_bug.cgi?id=132519
1588
1589         Reviewed by Gyuyoung Kim.
1590
1591         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
1592         (update_view_favicon):
1593         (on_icon_changed_cb):
1594         (window_free):
1595         (on_url_changed):
1596         (window_create):
1597         (on_view_favicon_changed): Deleted.
1598
1599 2014-05-02  Mark Rowe  <mrowe@apple.com>
1600
1601         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
1602
1603         Reviewed by Dan Bernstein.
1604
1605         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
1606         when determining which LLVM archive to extract.
1607
1608 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1609
1610         Add Jeremy as a committer.
1611         https://bugs.webkit.org/show_bug.cgi?id=132492
1612
1613         Reviewed by Jer Noble.
1614
1615         Add myself as a committer.
1616
1617         * Scripts/webkitpy/common/config/contributors.json:
1618
1619 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
1620
1621         Add Jeremy as a committer.
1622         https://bugs.webkit.org/show_bug.cgi?id=132492
1623
1624         Reviewed by Jer Noble.
1625
1626         Add Jeremy Jones to the committers file.
1627
1628         * Scripts/webkitpy/common/config/contributors.json:
1629
1630 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
1631
1632         Hard to figure out how to run a single test with run-api-tests
1633         https://bugs.webkit.org/show_bug.cgi?id=116332
1634
1635         Reviewed by Alexey Proskuryakov.
1636
1637         * Scripts/run-api-tests: add two examples to the help message.
1638
1639 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
1640
1641         Fix several memory leaks found by code inspection
1642         https://bugs.webkit.org/show_bug.cgi?id=132472
1643
1644         Reviewed by Geoffrey Garen.
1645         
1646         Fix memory leaks.
1647
1648         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
1649         (TestWebKitAPI::TEST):
1650         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1651         (WTR::InjectedBundlePage::willSendRequestForFrame):
1652         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1653         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1654
1655 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
1656
1657         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
1658         https://bugs.webkit.org/show_bug.cgi?id=132446
1659
1660         Reviewed by Mark Hahnenberg.
1661         
1662         Test the FTL by default now that it's enabled by default.
1663
1664         * Scripts/run-javascriptcore-tests:
1665
1666 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
1667
1668         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
1669         https://bugs.webkit.org/show_bug.cgi?id=132240
1670
1671         Reviewed by Anders Carlsson.
1672
1673         Removed ewk_view_setting_tiled_backingstore related code.
1674
1675         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1676         (DumpRenderTreeChrome::createView):
1677         (shouldUseTiledBackingStore): Deleted.
1678         * EWebLauncher/main.c:
1679         (windowCreate):
1680         (parseUserArguments):
1681
1682 2014-05-01  Anders Carlsson  <andersca@apple.com>
1683
1684         window.testRunner.keepWebHistory() should update the UI process state
1685         https://bugs.webkit.org/show_bug.cgi?id=132440
1686
1687         Reviewed by Dan Bernstein.
1688
1689         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1690         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1691         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1692         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1693         (WTR::TestRunner::keepWebHistory):
1694         * WebKitTestRunner/TestInvocation.cpp:
1695         (WTR::TestInvocation::invoke):
1696         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1697
1698 2014-05-01  David Kilzer  <ddkilzer@apple.com>
1699
1700         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
1701         <http://webkit.org/b/132432>
1702
1703         Reviewed by Tim Horton.
1704
1705         * Scripts/webkitperl/FeatureList.pm: Remove support for
1706         --plugin-proxy-for-video switch.
1707
1708 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1709
1710         Kernel sysctl interface hw.activecpu don't exists on Linux.
1711         https://bugs.webkit.org/show_bug.cgi?id=132286
1712
1713         Reviewed by Filip Pizlo.
1714
1715         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
1716         calling sysctl over hw.activecpu
1717
1718 2014-04-30  Anders Carlsson  <andersca@apple.com>
1719
1720         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
1721         https://bugs.webkit.org/show_bug.cgi?id=132399
1722         <rdar://problem/15920046>
1723
1724         Reviewed by Dan Bernstein.
1725
1726         * Scripts/check-for-webkit-framework-include-consistency:
1727         Allos WAK headers in WebKitLegacy as well as WebKit.
1728
1729         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1730         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1731         Update header imports.
1732
1733 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1734
1735         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
1736         https://bugs.webkit.org/show_bug.cgi?id=131954
1737
1738         Reviewed by Darin Adler.
1739         
1740         WebKitTestRunner was adding application-specific information to crash reports
1741         to log the test path, but only in the web process. Fix it to also do this
1742         for the UI process, for both iOS and OS X.
1743         
1744         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
1745         both iOS and OS X.
1746         
1747         Factored crash reprorter-related code into CrashReporterInfo, and call it from
1748         a new TestController::platformWillRunTest() function on Mac and iOS.
1749         
1750         Also remove Xcode-added unit test junk from the project.
1751
1752         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1753         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1754         * WebKitTestRunner/TestController.cpp:
1755         (WTR::TestController::runTest):
1756         * WebKitTestRunner/TestController.h:
1757         * WebKitTestRunner/TestInvocation.cpp:
1758         (WTR::TestInvocation::url):
1759         * WebKitTestRunner/TestInvocation.h:
1760         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1761         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
1762         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
1763         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
1764         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
1765         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
1766         (WTR::testPathFromURL):
1767         (WTR::setCrashReportApplicationSpecificInformationToURL):
1768         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1769         (WTR::TestController::platformWillRunTest):
1770         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1771         (WTR::TestController::platformWillRunTest):
1772         * WebKitTestRunner/ios/TestControllerIOS.mm:
1773         (WTR::TestController::platformWillRunTest):
1774         (WTR::TestController::setHidden):
1775         * WebKitTestRunner/mac/TestControllerMac.mm:
1776         (WTR::TestController::platformWillRunTest):
1777
1778 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
1779
1780         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
1781
1782         Reviewed by Tim Horton.
1783
1784         * DumpRenderTree/mac/DumpRenderTree.mm:
1785         (resetWebPreferencesToConsistentValues):
1786         (prepareConsistentTestingEnvironment):
1787
1788 2014-04-30  Anders Carlsson  <andersca@apple.com>
1789
1790         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
1791         https://bugs.webkit.org/show_bug.cgi?id=132397
1792
1793         Reviewed by Dan Bernstein.
1794
1795         * Scripts/check-for-inappropriate-macros-in-external-headers:
1796
1797 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
1798
1799         [GTK] Make it easier to run CMake for downstreams
1800         https://bugs.webkit.org/show_bug.cgi?id=132370
1801
1802         Reviewed by Carlos Garcia Campos.
1803
1804         * Scripts/webkitdirs.pm:
1805         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
1806         the GTK+ port.
1807
1808 2014-04-29  Stephanie Lewis  <slewis@apple.com>
1809
1810         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
1811         
1812         Rubber stamped by Jessie Berlin.
1813
1814         JSON.pm was removed from our tools setup.
1815
1816         * Scripts/generate-coverage-data:
1817
1818 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
1819
1820         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
1821         https://bugs.webkit.org/show_bug.cgi?id=112840
1822
1823         Rubber stamped by Geoffrey Garen.
1824
1825         * Scripts/build-jsc: Enable it on Mac.
1826         * Scripts/build-webkit: Enable it on Mac.
1827         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
1828
1829 2014-04-28  Sam Weinig  <sam@webkit.org>
1830
1831         REGRESSION (r167751): svn-create-patch is very slow
1832         https://bugs.webkit.org/show_bug.cgi?id=132300
1833
1834         Reviewed by Alexey Proskuryakov.
1835
1836         * Scripts/svn-create-patch:
1837         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
1838         by calling `svn-create-patch --style`.
1839
1840 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
1841
1842         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
1843         https://bugs.webkit.org/show_bug.cgi?id=132190
1844
1845         Reviewed by Gustavo Noronha Silva.
1846
1847         * Scripts/webkitdirs.pm:
1848         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
1849             if ninja is in the path.
1850         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
1851             to the previous ninja generator if not.
1852
1853 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1854
1855         check-webkit-style should understand --git-index
1856         https://bugs.webkit.org/show_bug.cgi?id=125364
1857
1858         Reviewed by Csaba Osztrogonác.
1859
1860         * Scripts/webkitpy/common/checkout/scm/git.py:
1861         (Git.create_patch): The command now supports the --cached option.
1862         * Scripts/webkitpy/style/main.py:
1863         (CheckWebKitStyle.main): Passing the --git-index option.
1864         * Scripts/webkitpy/style/optparser.py:
1865         (CommandOptionValues.__init__): The git-index option is switched off by default.
1866         (CommandOptionValues.__eq__): Equality check for the new option.
1867         (ArgumentParser._create_option_parser):Adding the --git-index option
1868         (ArgumentParser.parse):
1869         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
1870         (CommandOptionValuesTest.test_init): 
1871         (CommandOptionValuesTest.test_eq):
1872
1873 2014-04-28  Michael Saboff  <msaboff@apple.com>
1874
1875         Crash in platform/mac/accessibility/table-visible-rows.html
1876         https://bugs.webkit.org/show_bug.cgi?id=132146
1877
1878         Reviewed by Filip Pizlo.
1879
1880         Instead of creating a local JSValueRef array on the stack and passing that to
1881         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
1882         values using the JSObjectSetPropertyAtIndex() API.
1883
1884         * DumpRenderTree/AccessibilityUIElement.cpp:
1885         (elementsForRangeCallback):
1886         (convertElementsToObjectArray):
1887         * DumpRenderTree/mac/TestRunnerMac.mm:
1888         (originsArrayToJS):
1889         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1890         (WTR::EventSendingController::contextClick):
1891         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1892         (WTR::stringArrayToJS):
1893         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1894         (WTR::convertElementsToObjectArray):
1895
1896 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
1897
1898         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
1899         "no-cjit" runs force the old-school threshold.
1900
1901         Rubber stamped by Mark Hahnenberg.
1902
1903         * Scripts/run-jsc-stress-tests:
1904
1905 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1906
1907         [GTK] install-dependencies should also install ruby-json and ruby-highline
1908         https://bugs.webkit.org/show_bug.cgi?id=132292
1909
1910         Reviewed by Philippe Normand.
1911
1912         * gtk/install-dependencies: Install ruby json and highline packages.
1913
1914 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
1915
1916         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
1917         https://bugs.webkit.org/show_bug.cgi?id=132176
1918
1919         Reviewed by Gyuyoung Kim.
1920
1921         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
1922         and turn off indexedDB feature until the sqlite implementation is introduced.
1923
1924         * Scripts/webkitperl/FeatureList.pm:
1925
1926 2014-04-25  James Craig  <jcraig@apple.com>
1927
1928         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
1929         https://bugs.webkit.org/show_bug.cgi?id=132209
1930
1931         Reviewed by Daniel Bates.
1932
1933         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
1934         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
1935
1936         * Scripts/prepare-ChangeLog:
1937         (main): 
1938
1939 2014-04-25  Michael Saboff  <msaboff@apple.com>
1940
1941         Crash in platform/mac/accessibility/table-visible-rows.html
1942         https://bugs.webkit.org/show_bug.cgi?id=132146
1943
1944         Reviewed by Mark Lam.
1945
1946         Changed to use a local JSValueRef array temporary instead of a
1947         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
1948         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
1949         the temporary values could be collected.
1950
1951         * DumpRenderTree/AccessibilityUIElement.cpp:
1952         (convertElementsToObjectArray):
1953         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1954         (WTR::EventSendingController::contextClick):
1955         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1956         (WTR::convertElementsToObjectArray):
1957
1958 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
1959
1960         Unreviewed GTK gardening
1961
1962         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
1963         (TestRunner):
1964
1965 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
1966
1967         prepare-ChangeLog reports as deleted methods that has not been removed.
1968         https://bugs.webkit.org/show_bug.cgi?id=131733
1969
1970         Reviewed by Ryosuke Niwa.
1971
1972         * Scripts/prepare-ChangeLog:
1973         (originalFile): Set merge base to origin/master by default.
1974
1975 2014-04-23  James Craig  <jcraig@apple.com>
1976
1977         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
1978         https://bugs.webkit.org/show_bug.cgi?id=131115
1979
1980         Reviewed by Daniel Bates.
1981
1982         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
1983
1984         * Scripts/commit-log-editor: Added --no-style.
1985         * Scripts/prepare-ChangeLog: Primary patch.
1986         (main): Primary patch.
1987         (createPatchCommand): Added --no-style.
1988         * Scripts/svn-create-patch: Primary patch.
1989         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
1990         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
1991         (SVN.create_patch): Added --no-style.
1992
1993 2014-04-23  Anders Carlsson  <andersca@apple.com>
1994
1995         Try to fix iOS build.
1996
1997         * DumpRenderTree/mac/DumpRenderTree.mm:
1998
1999 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
2000
2001         Eliminate internals.setMockScrollbarsEnabled()
2002         https://bugs.webkit.org/show_bug.cgi?id=132085
2003
2004         Reviewed by Tim Horton.
2005
2006         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
2007         No need to reset the preference, there is no way it can change.
2008
2009 2014-04-23  James Craig  <jcraig@apple.com>
2010
2011         Unreviewed. Moving myself from Contributors to Committers list.
2012
2013         * Scripts/webkitpy/common/config/contributors.json:
2014
2015 2014-04-23  Tim Horton  <timothy_horton@apple.com>
2016
2017         Mock scrollbars don't always work in DumpRenderTree
2018         https://bugs.webkit.org/show_bug.cgi?id=132082
2019
2020         Reviewed by Alexey Proskuryakov.
2021
2022         * DumpRenderTree/mac/DumpRenderTree.mm:
2023         (prepareConsistentTestingEnvironment):
2024         Set the mock scrollbar setting before creating the WebView, as this setting
2025         cannot be dynamically changed, so any scrollbars that are created during
2026         WebView initialization and are not replaced before snapshotting will end
2027         up being platform scrollbars instead of mock ones.
2028         WebKitTestRunner already sets this preference before creating WKViews,
2029         so we're just matching its behavior.
2030
2031 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2032
2033         [GTK] ShadowRoot API was removed in r164131
2034         https://bugs.webkit.org/show_bug.cgi?id=132059
2035
2036         Reviewed by Gustavo Noronha Silva.
2037
2038         Add WebKitDOMShadowRoot to the list of deleted classes to generate
2039         the API docs.
2040
2041         * gtk/webkitdom.py:
2042         (WebKitDOMDocGenerator):
2043
2044 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
2045
2046         [GTK] run-webkit-tests script is failing to invoke run-launcher
2047         https://bugs.webkit.org/show_bug.cgi?id=132051
2048
2049         Reviewed by Philippe Normand.
2050
2051         After the WK1 support was dropped, if run-webkit-tests is executed
2052         without --no-show-results parameter, the launcher is being called
2053         using a -2 parameter that is it causing the run-launcher to break.
2054
2055         * Scripts/webkitpy/port/gtk.py:
2056         (GtkPort.show_results_html_file):
2057
2058 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2059
2060         DumpRenderTree generates black snapshots on some platforms
2061         https://bugs.webkit.org/show_bug.cgi?id=132029
2062         <rdar://problem/16679363>
2063
2064         Reviewed by Simon Fraser.
2065
2066         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2067         (createBitmapContextFromWebView):
2068         DRT checks with the WebView to determine whether it can use the window's
2069         backing store directly or (because of compositing) needs to take a WindowServer
2070         snapshot. However, on some platforms and in some situations, the window can
2071         be layer backed without the WebView necessarily currently being composited.
2072         We should check with the window in addition to the WebView before going
2073         ahead and using its backing store.
2074
2075 2014-04-22  Tim Horton  <timothy_horton@apple.com>
2076
2077         DumpRenderTree generates white snapshots on some platforms
2078         https://bugs.webkit.org/show_bug.cgi?id=132026
2079         <rdar://problem/16679363>
2080
2081         Reviewed by Simon Fraser.
2082
2083         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2084         Link DRT against QuartzCore.
2085
2086         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2087         (createBitmapContextFromWebView):
2088         Force CoreAnimation to synchronously update layers in a more explicit
2089         way that doesn't depend on AppKit behavior. This is very similar to what
2090         WebKitTestRunner does (indirectly) during its force repaint.
2091
2092 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
2093
2094         [Win] Support Python 2.7 in Cygwin
2095         https://bugs.webkit.org/show_bug.cgi?id=132023
2096
2097         Reviewed by Michael Saboff.
2098
2099         * Scripts/webkitdirs.pm:
2100         (checkInstalledTools): Remove check for Python 2.7, since
2101         it now works properly.
2102
2103 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
2104
2105         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2106         https://bugs.webkit.org/show_bug.cgi?id=130867
2107         <rdar://problem/16432456> 
2108
2109         Reviewed by Mark Hahnenberg.
2110
2111         * Scripts/build-webkit:
2112         * Scripts/copy-webkitlibraries-to-product-directory:
2113
2114 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
2115
2116         [GTK] Fails to build documentation when output is redirected
2117         https://bugs.webkit.org/show_bug.cgi?id=131178
2118
2119         Reviewed by Martin Robinson.
2120
2121         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
2122         explicitly to avoid encoding issues when they are redirected.
2123
2124 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
2125
2126         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
2127         https://bugs.webkit.org/show_bug.cgi?id=131911
2128
2129         Reviewed by Martin Robinson.
2130
2131         common.get_build_path returns release path even though Debug configuration
2132         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
2133
2134         * gtk/ycm_extra_conf.py:
2135         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
2136         (FlagsForFile):
2137
2138 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
2139
2140         Unreviewed build fix.
2141
2142         * DumpRenderTree/mac/EventSendingController.mm:
2143         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2144         Correct a typo that prevented tests from working properly.
2145
2146 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
2147
2148         [GTK] Should have the ability to output composited contents during layout testing
2149         https://bugs.webkit.org/show_bug.cgi?id=131864
2150
2151         Reviewed by Philippe Normand.
2152
2153         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2154         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
2155         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
2156         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2157         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
2158
2159 2014-04-21  Sam Weinig  <sam@webkit.org>
2160
2161         Attempt to fix the tests.
2162
2163         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2164         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2165         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
2166
2167 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
2168
2169         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
2170         being the same as a "quick run", which is meant for genuinely slow tests).
2171
2172         * Scripts/run-jsc-stress-tests:
2173
2174 2014-04-21  Darin Adler  <darin@apple.com>
2175
2176         Add HashSet::takeAny
2177         https://bugs.webkit.org/show_bug.cgi?id=131928
2178
2179         Reviewed by Benjamin Poulain.
2180
2181         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
2182
2183 2014-04-20  Dan Bernstein  <mitz@apple.com>
2184
2185         Fixed a test timing out after r167572.
2186
2187         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2188         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
2189         -webView:didFinishLoadingNavigation:.
2190
2191 2014-04-20  Commit Queue  <commit-queue@webkit.org>
2192
2193         Unreviewed, rolling out r167510.
2194         https://bugs.webkit.org/show_bug.cgi?id=131915
2195
2196         broke GTK Debug bot (Requested by philn on #webkit).
2197
2198         Reverted changeset:
2199
2200         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
2201         it when running layout tests"
2202         https://bugs.webkit.org/show_bug.cgi?id=131472
2203         http://trac.webkit.org/changeset/167510
2204
2205 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
2206
2207         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2208         https://bugs.webkit.org/show_bug.cgi?id=131472
2209
2210         Reviewed by Philippe Normand.
2211
2212         * Scripts/webkitpy/port/gtk.py:
2213         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2214         when running WebKitTestRunner with run-webkit-tests.
2215         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
2216         installed.
2217         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
2218         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
2219         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
2220         deal.
2221
2222 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
2223
2224         DownloadDecideDestinationCrash API test uses an incorrect value for path
2225         https://bugs.webkit.org/show_bug.cgi?id=131845
2226         <rdar://problem/15925560>
2227
2228         Reviewed by Enrica Casucci.
2229
2230         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2231         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
2232
2233 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
2234
2235         [Mac] AttributedStringTest API tests fail with async text input
2236         https://bugs.webkit.org/show_bug.cgi?id=131833
2237
2238         Reviewed by Enrica Casucci.
2239
2240         Don't run sync NSTextInputClient tests where we don't implement these calls.
2241
2242         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2243         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2244         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
2245         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2246         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
2247         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
2248         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
2249
2250 2014-04-18  Philippe Normand  <pnormand@igalia.com>
2251
2252         Remove NETWORK_INFO support
2253         https://bugs.webkit.org/show_bug.cgi?id=131841
2254
2255         Reviewed by Gyuyoung Kim.
2256
2257         * Scripts/webkitperl/FeatureList.pm:
2258
2259 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
2260
2261         [GTK] YouCompleteMe doesn't work for cmake build system.
2262         https://bugs.webkit.org/show_bug.cgi?id=131591
2263
2264         Reviewed by Martin Robinson.
2265
2266         Add cmake build system support for YouCompleteMe. It should work regardless of
2267         using make or ninja. In addition, autotools related code is removed since it's
2268         not used anymore in WebKit.
2269
2270         * Scripts/webkitdirs.pm:
2271         (generateBuildSystemFromCMakeProject):
2272         * gtk/ycm_extra_conf.py:
2273         (transform_relative_paths_to_absolute_paths):
2274         (FlagsForFile):
2275
2276 2014-04-17  Anders Carlsson  <andersca@apple.com>
2277
2278         Fix build.
2279
2280         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2281         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2282         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2283
2284 2014-04-17  Anders Carlsson  <andersca@apple.com>
2285
2286         Remove unused API enums
2287         https://bugs.webkit.org/show_bug.cgi?id=131836
2288
2289         Reviewed by Tim Horton.
2290
2291         * MiniBrowser/mac/WK2BrowserWindowController.m:
2292         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2293
2294 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
2295
2296         [Win] A few final cleanups to the DataObject classes.
2297         https://bugs.webkit.org/show_bug.cgi?id=131784
2298
2299         Reviewed by Anders Carlsson.
2300
2301         * DumpRenderTree/win/DRTDataObject.cpp:
2302         (DRTDataObject::clearData): Use 'last()' method.
2303         * DumpRenderTree/win/UIDelegate.cpp:
2304         (DRTUndoStack::pop): Use 'takeLast()' method.
2305
2306 2014-04-17  Andres Gomez  <agomez@igalia.com>
2307
2308         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
2309         https://bugs.webkit.org/show_bug.cgi?id=131365
2310
2311         Reviewed by Brent Fulgham.
2312
2313         The cygwin installer is now downloading the wanted versions for
2314         the local installation given to the setup wizard.
2315
2316         * CygwinDownloader/cygwin-downloader.py:
2317         * CygwinDownloader/cygwin-downloader.zip:
2318
2319 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
2320
2321         [GTK] Make run-webkit-tests always use WKTR
2322         https://bugs.webkit.org/show_bug.cgi?id=131737
2323
2324         Reviewed by Darin Adler.
2325
2326         Now that the GTK+ port only has support for WebKit2, instruct
2327         run-webkit-tests to always use WKTR. This avoids needing to pass
2328         flag "-2" every time.
2329
2330         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
2331         (_set_up_derived_options): Always set webkit_test_runner when
2332         the platform is GTK+.
2333
2334 2014-04-17  Brendan Long  <b.long@cablelabs.com>
2335
2336         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
2337         https://bugs.webkit.org/show_bug.cgi?id=131760
2338
2339         Reviewed by Philippe Normand.
2340
2341         * gtk/install-dependencies: Install ninja-build when it's available.
2342
2343 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
2344
2345         [Win] run-javascriptcore-tests fails to run.
2346         https://bugs.webkit.org/show_bug.cgi?id=131761
2347
2348         Reviewed by Brent Fulgham.
2349
2350         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
2351
2352 2014-04-16  Andres Gomez  <agomez@igalia.com>
2353
2354         [Win] Pass default parameters to cygwin setup wizard
2355         https://bugs.webkit.org/show_bug.cgi?id=131361
2356
2357         Reviewed by Brent Fulgham.
2358
2359         Added some parameters to the cygwin setup wizard so the user
2360         doesn't really have to do any interaction.
2361
2362         * CygwinDownloader/cygwin-downloader.py:
2363         * CygwinDownloader/cygwin-downloader.zip:
2364
2365 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
2366
2367         [Win] Eliminate use of deleteAllValues in Windows Files
2368         https://bugs.webkit.org/show_bug.cgi?id=131631
2369
2370         Reviewed by Darin Adler.
2371
2372         Switch to std::unique_ptr for memory lifetime. Get rid of
2373         deleteAllValues now that it is no longer needed. Use ranged
2374         for loops where possible.
2375
2376         * DumpRenderTree/win/DRTDataObject.cpp:
2377         (WCEnumFormatEtc::WCEnumFormatEtc):
2378         (DRTDataObject::~DRTDataObject):
2379         (DRTDataObject::GetData):
2380         (DRTDataObject::QueryGetData):
2381         (DRTDataObject::SetData):
2382         (DRTDataObject::clearData):
2383         * DumpRenderTree/win/DRTDataObject.h:
2384         * DumpRenderTree/win/UIDelegate.cpp:
2385         (DRTUndoObject::DRTUndoObject):
2386         (DRTUndoObject::~DRTUndoObject):
2387         (DRTUndoStack::~DRTUndoStack):
2388         (DRTUndoStack::clear):
2389         (DRTUndoStack::pop):
2390         (DRTUndoManager::DRTUndoManager):
2391         (DRTUndoManager::redo):
2392         (DRTUndoManager::undo):
2393         (UIDelegate::UIDelegate):
2394         (UIDelegate::resetUndoManager):
2395         * DumpRenderTree/win/UIDelegate.h:
2396
2397 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2398
2399         [GTK] Unreviewed GTK gardening.
2400
2401         Update list of skipped unit tests:
2402
2403           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
2404
2405           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
2406           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
2407
2408         * Scripts/run-gtk-tests:
2409         (TestRunner):
2410
2411 2014-04-16  Tim Horton  <timothy_horton@apple.com>
2412
2413         check-webkit-style doesn't check code style in .mm or .m files
2414         https://bugs.webkit.org/show_bug.cgi?id=131708
2415
2416         Reviewed by Darin Adler.
2417
2418         * Scripts/webkitpy/style/checker.py:
2419         * Scripts/webkitpy/style/checker_unittest.py:
2420         (CheckerDispatcherDispatchTest.test_cpp_paths):
2421         (CheckerDispatcherDispatchTest.test_text_paths):
2422         Check .mm and .m files as C++.
2423
2424         * Scripts/webkitpy/style/checkers/cpp.py:
2425         (check_spacing):
2426         Add an override for our ordinary "missing spaces around =" for @synthesize,
2427         which should look like "@synthesize propertyName=_varName;"
2428
2429         Add an override for "missing space before {" for blocks' "^{".
2430
2431         Don't follow the "extra space before [" rule for Objective-C, because
2432         it breaks this rule in a multitude of ways because of method calls.
2433
2434         (check_braces):
2435         Don't complain about { not being on the end of the previous line if
2436         the previous line starts with "- (" or "+ (", which would indicate a
2437         Objective-C method definition.
2438
2439 2014-04-16  Darin Adler  <darin@apple.com>
2440
2441         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
2442         https://bugs.webkit.org/show_bug.cgi?id=131735
2443
2444         Reviewed by Alexey Proskuryakov.
2445
2446         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
2447         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
2448         is on the right. This can be confusing since our JavaScript test framework does it the opposite
2449         way, but gtest works better this way.
2450
2451 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
2452
2453         [EFL] Fix problems with the pixel dump.
2454         https://bugs.webkit.org/show_bug.cgi?id=131265
2455
2456         Reviewed by Gyuyoung Kim.
2457
2458         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
2459         However pixel dump codes still call deprecated functions like ewk_view_paint(),
2460         which causes that nothing is drawn.
2461
2462         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
2463         One of new functions is AcceleratedCompositingContext::extractImageData(),
2464         which replaces deprecated function calls. Besides the extractImageData() is invoked by
2465         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
2466
2467         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2468         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
2469
2470 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
2471
2472         Update LLVM export scrpt to handle the build directory being different from the
2473         source directory.
2474
2475         Rubber stamped by Geoffrey Garen.
2476
2477         * Scripts/export-llvm-build:
2478
2479 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
2480
2481         Update the hyperlink to waterfall views of perf bots on build.webkit.org
2482         https://bugs.webkit.org/show_bug.cgi?id=131695
2483
2484         Reviewed by Antti Koivisto.
2485
2486         Updated.
2487
2488         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2489
2490 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2491
2492         [GTK] Reduce the binary size by compressing the text based web inspector resources
2493         https://bugs.webkit.org/show_bug.cgi?id=121545
2494
2495         Reviewed by Gustavo Noronha Silva.
2496
2497         Compress text based files when compiling inspector resources. It
2498         reduces the binary size in 3MB.
2499
2500         * gtk/generate-inspector-gresource-manifest.py:
2501         (find_all_files_in_directory):
2502         (is_compressible):
2503
2504 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2505
2506         Remove Gtk WebKit1 tester.
2507
2508         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
2509         results over and over as fast as it could.
2510
2511         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2512         (WebKitBuildbot):
2513
2514 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2515
2516         Wrong link for webkitpy tests results in dashboard popover
2517         https://bugs.webkit.org/show_bug.cgi?id=131664
2518
2519         Reviewed by Timothy Hatcher.
2520
2521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2522         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2523         Use a correct link.
2524
2525 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
2526
2527         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
2528
2529         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
2530
2531         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2532         (CommitMessageForThisCommitTest):
2533
2534 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2535
2536         Fix commit-log-editor bug revealed by r165447
2537         https://bugs.webkit.org/show_bug.cgi?id=130676
2538
2539         Reviewed by Csaba Osztrogonác.
2540
2541         * Scripts/commit-log-editor:
2542         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
2543         Add \n before the first block too, because the longest common prefix now ends with only one newline.
2544         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
2545         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
2546
2547 2014-04-13  Darin Adler  <darin@apple.com>
2548
2549         userVisibleString should not try to "encode" host names
2550         https://bugs.webkit.org/show_bug.cgi?id=131587
2551         rdar://problem/14686849
2552
2553         Reviewed by Alexey Proskuryakov.
2554
2555         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
2556
2557         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
2558         Coverage is tiny at this point; we could add a lot more cases!
2559
2560 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
2561
2562         Use #include instead of #import
2563         https://bugs.webkit.org/show_bug.cgi?id=131604
2564
2565         Reviewed by Darin Adler.
2566
2567         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
2568
2569         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2570
2571 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
2572
2573         Make slow-stress tests run faster by running fewer VM variants.
2574
2575         Rubber stamped by Geoffrey Garen.
2576
2577         * Scripts/run-javascriptcore-tests:
2578         * Scripts/run-jsc-stress-tests:
2579
2580 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
2581
2582         [CMake] Add missing WTF unit tests
2583         https://bugs.webkit.org/show_bug.cgi?id=131459
2584
2585         Reviewed by Martin Robinson.
2586
2587         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
2588         that should be compiled into the TestWTF binary.
2589
2590 2014-04-10  Brendan Long  <b.long@cablelabs.com>
2591
2592         [Gtk] run-launcher doesn't work by default
2593         https://bugs.webkit.org/show_bug.cgi?id=131494
2594
2595         Reviewed by Philippe Normand.
2596
2597         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
2598         * Scripts/webkitdirs.pm:
2599         (launcherName): Same.
2600         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
2601         * gtk/common.py:
2602         (get_build_path.is_valid_build_directory): Same.
2603         * gtk/manifest.txt: Same.
2604
2605 2014-04-09  Commit Queue  <commit-queue@webkit.org>
2606
2607         Unreviewed, rolling out r167046.
2608         https://bugs.webkit.org/show_bug.cgi?id=131479
2609
2610         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
2611         on #webkit).
2612
2613         Reverted changeset:
2614
2615         "Remove "System Font" from whitelisted DRT fonts and char
2616         width calculations"
2617         https://bugs.webkit.org/show_bug.cgi?id=131411
2618         http://trac.webkit.org/changeset/167046
2619
2620 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2621
2622         Remove "System Font" from whitelisted DRT fonts and char width calculations
2623         https://bugs.webkit.org/show_bug.cgi?id=131411
2624
2625         Reviewed by Tim Horton.
2626
2627         Covered by existing tests.
2628
2629         * DumpRenderTree/mac/DumpRenderTree.mm:
2630         (allowedFontFamilySet):
2631
2632 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
2633
2634         systemHiddenFontFamilySet in DRT is unnecessary
2635         https://bugs.webkit.org/show_bug.cgi?id=131414
2636
2637         Reviewed by Tim Horton.
2638
2639         It doesn't seem to affect test results on my machine.
2640
2641         * DumpRenderTree/mac/DumpRenderTree.mm:
2642         (drt_NSFontManager_availableFonts):
2643         (systemHiddenFontFamilySet): Deleted.
2644
2645 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
2646
2647         [Win] Unreviewed test fix: Don't double-release BSTR.
2648
2649         * DumpRenderTree/win/DumpRenderTree.cpp:
2650         (dump): Remove unneeded call to SysFreeString now that we are
2651         using _bstr_t for this variable.
2652
2653 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
2654
2655         [Win] Various DumpRenderTree Fixes.
2656         https://bugs.webkit.org/show_bug.cgi?id=131446.
2657
2658         Reviewed by Tim Horton.
2659
2660         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2661         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2662         (AccessibilityUIElement::description): Ditto.
2663         (AccessibilityUIElement::helpText): Ditto.
2664         (AccessibilityUIElement::intValue): Ditto.
2665         (AccessibilityUIElement::isPressActionSupported): Ditto.
2666         (AccessibilityUIElement::accessibilityValue): Ditto.
2667         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2668         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2669         (DRTDesktopNotificationPresenter::AddRef): Ditto.
2670         (DRTDesktopNotificationPresenter::Release): Ditto.
2671         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2672         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
2673         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
2674         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
2675         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
2676         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2677         * DumpRenderTree/win/DumpRenderTree.cpp:
2678         (dumpFrameScrollPosition): Ditto.
2679         (dumpFramesAsText): Ditto.
2680         (compareHistoryItems): Ditto.
2681         (dumpHistoryItem): Ditto.
2682         (dump): Ditto.
2683         (resetDefaultsToConsistentValues): Ditto.
2684         (resetWebViewToConsistentStateBeforeTesting): Ditto.
2685         (runTest): Ditto.
2686         (createWebViewAndOffscreenWindow): Ditto.
2687         * DumpRenderTree/win/EditingDelegate.cpp:
2688         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2689         (EditingDelegate::AddRef): Ditto.
2690         (EditingDelegate::Release): Ditto.
2691         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
2692         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
2693         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2694         (EditingDelegate::shouldInsertNode): Ditto.
2695         (EditingDelegate::shouldInsertText): Ditto.
2696         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2697         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2698         (EditingDelegate::shouldApplyStyle): Ditto.
2699         (EditingDelegate::shouldChangeTypingStyle): Ditto.
2700         (EditingDelegate::doPlatformCommand): Ditto.
2701         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2702         (EditingDelegate::webViewDidChange): Ditto.
2703         (EditingDelegate::webViewDidEndEditing): Ditto.
2704         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
2705         (EditingDelegate::webViewDidChangeSelection): Ditto.
2706         (EditingDelegate::checkSpellingOfString): Ditto.
2707         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2708         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2709         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
2710         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2711         (FrameLoadDelegate::AddRef): Ditto.
2712         (FrameLoadDelegate::Release): Ditto.
2713         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2714         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
2715         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
2716         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
2717         (FrameLoadDelegate::didReceiveTitle): Ditto.
2718         (FrameLoadDelegate::didChangeIcons): Ditto.
2719         (delegatesWithDelayedWork): Ditto.
2720         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
2721         (FrameLoadDelegate::didFailLoadWithError): Ditto.
2722         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
2723         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
2724         (FrameLoadDelegate::willCloseFrame): Ditto.
2725         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
2726         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
2727         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2728         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
2729         (FrameLoadDelegate::didRunInsecureContent): Ditto.
2730         * DumpRenderTree/win/FrameLoadDelegate.h:
2731         * DumpRenderTree/win/HistoryDelegate.cpp:
2732         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2733         (HistoryDelegate::updateHistoryTitle): Ditto.
2734         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
2735         * DumpRenderTree/win/PolicyDelegate.cpp:
2736         (dumpPath):
2737         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2738         (PolicyDelegate::AddRef): Ditto.
2739         (PolicyDelegate::Release): Ditto.
2740         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2741         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
2742         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2743         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2744         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2745         (ResourceLoadDelegate::AddRef): Ditto.
2746         (ResourceLoadDelegate::Release): Ditto.
2747         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2748         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
2749         (ResourceLoadDelegate::willSendRequest): Ditto.
2750         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
2751         (ResourceLoadDelegate::didReceiveResponse): Ditto.
2752         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
2753         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
2754         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2755         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2756         (TestRunner::setUserStyleSheetLocation): Ditto.
2757         (TestRunner::execCommand): Ditto.
2758         (TestRunner::overridePreference): Ditto.
2759         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
2760         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
2761         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2762         (TextInputController::insertText): Ditto.
2763         * DumpRenderTree/win/UIDelegate.cpp:
2764         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
2765         (UIDelegate::AddRef): Ditto.
2766         (UIDelegate::Release): Ditto.
2767         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
2768         (UIDelegate::trackCustomPopupMenu): Ditto.
2769         (UIDelegate::registerUndoWithTarget): Ditto.
2770         (UIDelegate::removeAllActionsWithTarget): Ditto.
2771         (UIDelegate::setActionTitle): Ditto.
2772         (UIDelegate::undo): Ditto.
2773         (UIDelegate::redo): Ditto.
2774         (UIDelegate::canUndo): Ditto.
2775         (UIDelegate::canRedo): Ditto.
2776         (UIDelegate::printFrame): Ditto.
2777         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
2778         (UIDelegate::webViewHeaderHeight): Ditto.
2779         (UIDelegate::webViewFooterHeight): Ditto.
2780         (UIDelegate::drawHeaderInRect): Ditto.
2781         (UIDelegate::drawFooterInRect): Ditto.
2782         (UIDelegate::webViewPrintingMarginRect): Ditto.
2783         (UIDelegate::canRunModal): Ditto.
2784         (UIDelegate::createModalDialog): Ditto.
2785         (UIDelegate::runModal): Ditto.
2786         (UIDelegate::isMenuBarVisible): Ditto.
2787         (UIDelegate::setMenuBarVisible): Ditto.
2788         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
2789         (UIDelegate::paintCustomScrollbar): Ditto.
2790         (UIDelegate::paintCustomScrollCorner): Ditto.
2791         (UIDelegate::setFrame): Ditto.
2792         (UIDelegate::webViewFrame): Ditto.
2793         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
2794         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2795         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2796         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2797         (UIDelegate::webViewAddMessageToConsole): Ditto.
2798         (UIDelegate::doDragDrop): Ditto.
2799         (UIDelegate::webViewGetDlgCode): Ditto.
2800         (UIDelegate::createWebViewWithRequest): Ditto.
2801         (UIDelegate::webViewClose): Ditto.
2802         (UIDelegate::webViewFocus): Ditto.
2803         (UIDelegate::webViewUnfocus): Ditto.
2804         (UIDelegate::webViewPainted): Ditto.
2805         (UIDelegate::exceededDatabaseQuota): Ditto.
2806         (UIDelegate::embeddedViewWithArguments): Ditto.
2807         (UIDelegate::webViewClosing): Ditto.
2808         (UIDelegate::webViewSetCursor): Ditto.
2809         (UIDelegate::webViewDidInvalidate): Ditto.
2810         (UIDelegate::setStatusText): Ditto.
2811         (UIDelegate::desktopNotificationsDelegate): Ditto.
2812         (UIDelegate::drawBackground): Ditto.
2813         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
2814         (UIDelegate::didPressMissingPluginButton): Ditto.
2815         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
2816         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
2817         (LoadHTMLStringItem::invoke): Ditto.
2818         (ScriptItem::invoke): Ditto.
2819
2820 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
2821
2822         Stylechecker: False positive on inline asm code.
2823         https://bugs.webkit.org/show_bug.cgi?id=130570
2824
2825         Reviewed by Csaba Osztrogonác.
2826
2827         Disable stylechecking in asm blocks.
2828
2829         * Scripts/webkitpy/style/checkers/cpp.py:
2830         (process_line):
2831         (_InlineASMState):
2832         (_InlineASMState.__init__):
2833         (_InlineASMState.process_line):
2834         (_InlineASMState.isInside):
2835         (_process_lines):
2836         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2837         (WebKitStyleTest.test_member_initialization_list):
2838
2839 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2840
2841         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
2842         https://bugs.webkit.org/show_bug.cgi?id=131029
2843
2844         Reviewed by Philippe Normand.
2845
2846         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
2847         tests and remove the getWebKit1TestResoucesDir() method.
2848
2849         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2850         (testDownloadLocalFile): Use Test::getResourcesDir().
2851         (testDownloadLocalFileError): Ditto.
2852         (serverCallback): Ditto.
2853         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2854         (serverCallback): Ditto.
2855         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2856         (httpServerCallback): Ditto.
2857         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2858         (serverCallback): Ditto.
2859         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
2860         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
2861         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2862         (Test::getWebKit1TestResoucesDir): Deleted.
2863
2864 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
2865
2866         [WK2] HTTP authentication regression tests fail
2867         https://bugs.webkit.org/show_bug.cgi?id=81627
2868         <rdar://problem/11079296>
2869
2870         Reviewed by Anders Carlsson.
2871
2872         * WebKitTestRunner/TestController.h:
2873         * WebKitTestRunner/TestController.cpp:
2874         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
2875         to pageLoaderClient structure.
2876         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
2877         for password based authentication (we do get server trust challenges on some tests,
2878         which WKTR can't handle).
2879         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
2880         calls won't be made, at least on CFNetwork based platforms.
2881         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
2882         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
2883         make sense to associate auth requests with individual resources - there can be
2884         multiple resources loading at once from the same protection space, so WebKit1 API
2885         that had a resource identifier was inherently racy.
2886
2887 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
2888
2889         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
2890         https://bugs.webkit.org/show_bug.cgi?id=131427
2891
2892         Reviewed by Gyuyoung Kim.
2893
2894         Since r166973, font path was changed.
2895
2896         * DumpRenderTree/PlatformEfl.cmake:
2897         * WebKitTestRunner/PlatformEfl.cmake:
2898
2899 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
2900
2901         Fix the build-jsc build
2902         https://bugs.webkit.org/show_bug.cgi?id=131410
2903
2904         Reviewed by Michael Saboff.
2905
2906         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
2907         WTF depends on it.
2908
2909 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
2910
2911         [GTK] Remove WebKit1 unit tests
2912         https://bugs.webkit.org/show_bug.cgi?id=131359
2913
2914         Reviewed by Anders Carlsson.
2915
2916         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
2917         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
2918         they were inadvertently left in http://trac.webkit.org/changeset/166504.
2919
2920         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
2921         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
2922         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
2923         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
2924         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
2925         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
2926         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
2927         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
2928         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
2929         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
2930         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
2931         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
2932         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
2933         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
2934         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
2935         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
2936         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
2937         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
2938         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
2939         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
2940         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
2941         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
2942         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
2943         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
2944         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
2945         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
2946         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
2947         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
2948         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
2949         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
2950         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
2951         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
2952         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
2953         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
2954         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
2955         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
2956         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
2957         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
2958
2959 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
2960
2961         Unreviewed gardening (Take 2): Prevent users from attempting
2962         to build with known invalid cURL. 
2963
2964         * Scripts/webkitdirs.pm:
2965         (checkInstalledTools): Check for 7.34.0 (the broken version), not
2966         7.33.0 (the known good version).
2967
2968 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
2969
2970         [GTK] Remove DumpRenderTree and GtkLauncher
2971         https://bugs.webkit.org/show_bug.cgi?id=131373
2972
2973         Reviewed by Andreas Kling.
2974
2975         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
2976         no longer necessary now that WebKit1 GTK+ will be removed.
2977
2978         * CMakeLists.txt:
2979         * DumpRenderTree/PlatformGTK.cmake: Removed.
2980         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
2981         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
2982         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
2983         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
2984         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
2985         * DumpRenderTree/gtk/EventSender.cpp: Removed.
2986         * DumpRenderTree/gtk/EventSender.h: Removed.
2987         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
2988         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
2989         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
2990         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
2991         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
2992         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
2993         * DumpRenderTree/gtk/TextInputController.h: Removed.
2994         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
2995         * GtkLauncher/CMakeLists.txt: Removed.
2996         * GtkLauncher/LauncherInspectorWindow.c: Removed.
2997         * GtkLauncher/LauncherInspectorWindow.h: Removed.
2998         * GtkLauncher/main.c: Removed.
2999         * GtkLauncher/simple.svg: Removed.
3000         * GtkLauncher/text.html: Removed.
3001         * WebKitTestRunner/PlatformGTK.cmake:
3002         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
3003         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
3004         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
3005
3006 2014-04-08  Mark Rowe  <mrowe@apple.com>
3007
3008         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
3009         <https://webkit.org/b/131388> / <rdar://problem/16291687>
3010
3011         Reviewed by Alexey Proskuryakov.
3012
3013         * Scripts/webkitdirs.pm:
3014         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
3015         (execMacWebKitAppForDebugging): Ditto.
3016
3017 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
3018
3019         Build bmalloc on iOS too
3020         https://bugs.webkit.org/show_bug.cgi?id=131381
3021
3022         Reviewed by Andreas Kling.
3023
3024         * Scripts/build-webkit:
3025
3026 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
3027
3028         Unreviewed gardening: Prevent users from attempting
3029         to build with known invalid cURL.
3030
3031         * Scripts/webkitdirs.pm:
3032         (checkInstalledTools): Block build attempts with bad
3033         Cygwin tool set.
3034
3035 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
3036
3037         Build bmalloc on Mac
3038         https://bugs.webkit.org/show_bug.cgi?id=131333
3039
3040         Reviewed by Mark Rowe.
3041
3042         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
3043         (Note: Just testing Mac is not good enough because in this
3044         script 'Mac' means 'Mac or iOS'.)
3045
3046 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
3047
3048         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
3049         https://bugs.webkit.org/show_bug.cgi?id=130951
3050
3051         Reviewed by Geoffrey Garen.
3052
3053         * Scripts/run-javascriptcore-tests:
3054
3055 2014-04-06  Darin Adler  <darin@apple.com>
3056
3057         Rework CSS calc logic, fixing some reference count mistakes in Length
3058         https://bugs.webkit.org/show_bug.cgi?id=131280
3059
3060         Reviewed by Andreas Kling.
3061
3062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
3063         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
3064
3065 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
3066
3067         Enable WEB_REPLAY for PLATFORM(MAC)
3068         https://bugs.webkit.org/show_bug.cgi?id=130700
3069
3070         Reviewed by Timothy Hatcher.
3071
3072         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
3073
3074 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3075
3076         [CMake] Include X11's include dirs in TestNetscapePlugin
3077         https://bugs.webkit.org/show_bug.cgi?id=131270
3078
3079         Reviewed by Martin Robinson.
3080
3081         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
3082         TestNetscapePlugin includes WebCore code that includes X headers.
3083
3084 2014-04-05  David Kilzer  <ddkilzer@apple.com>
3085
3086         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
3087         <http://webkit.org/b/130986>
3088
3089         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
3090         prefix to TileCache class names in exception list.
3091
3092 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3093
3094         [GTK] kill-old-processes should kill dbus-daemon processes
3095         https://bugs.webkit.org/show_bug.cgi?id=127352
3096
3097         Reviewed by Martin Robinson.
3098
3099         * BuildSlaveSupport/kill-old-processes:
3100         (main):
3101
3102 2014-04-04  Andres Gomez  <agomez@igalia.com>
3103
3104         [Win] Update obsolete packages in cygwin
3105         https://bugs.webkit.org/show_bug.cgi?id=126264
3106
3107         Reviewed by Brent Fulgham.
3108
3109         Removed "apache" and "minires" as the first has been replaced by
3110         "lighttpd" and the second is now integrated into
3111         "cygwin". Replaced the transitional and now obsolete "gcc" package
3112         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
3113         since the newer version available is "2.7.3" which breaks the
3114         build due to some funniness with environment variable handling.
3115
3116         * CygwinDownloader/cygwin-downloader.py:
3117         * CygwinDownloader/cygwin-downloader.zip:
3118
3119 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
3120
3121         check-webkit-style: Improve warnings on Objective-C @property syntax
3122         https://bugs.webkit.org/show_bug.cgi?id=131200
3123
3124         Reviewed by Dan Bernstein.
3125
3126         * Scripts/webkitpy/style/checkers/cpp.py:
3127         (check_spacing):
3128         (CppChecker):
3129         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3130         (CppStyleTest.test_spacing_in_objective_c_properties):
3131
3132 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3133
3134         Unreviewed. Moving my name to commiter section
3135
3136         * Scripts/webkitpy/common/config/contributors.json:
3137
3138 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
3139
3140         Unreviewed. Add myself as a committer.
3141
3142         * Scripts/webkitpy/common/config/contributors.json:
3143
3144 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
3145
3146         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
3147         https://bugs.webkit.org/show_bug.cgi?id=130391
3148
3149         Reviewed by Gyuyoung Kim.
3150
3151         Change the implementation of the zoom functionality from ewk_view_scale_set
3152         to ewk_view_page_zoom_set.
3153
3154         * MiniBrowser/efl/main.c:
3155
3156 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
3157
3158         [webkitpy] perf profiler does not understand --call-graph argument
3159         https://bugs.webkit.org/show_bug.cgi?id=131132
3160
3161         Reviewed by Ryosuke Niwa.
3162
3163         New versions of perf profiler have changed the argument from --call-graph to -g.
3164
3165         * Scripts/webkitpy/common/system/profiler.py:
3166         (Perf.wrapper_arguments): Use -g instead of --call-graph.
3167         * Scripts/webkitpy/port/driver_unittest.py:
3168         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
3169
3170 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3171
3172         Add EFL WK2 performance bot to build.webkit.org
3173         https://bugs.webkit.org/show_bug.cgi?id=131034
3174
3175         Fix after r166707, use "Perf" instead of "perf" for consistency.
3176
3177         Reviewed by Csaba Osztrogonác.
3178
3179         * BuildSlaveSupport/build.webkit.org-config/config.json:
3180
3181 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3182
3183         Add EFL WK2 performance bot to build.webkit.org
3184         https://bugs.webkit.org/show_bug.cgi?id=131034
3185
3186         Reviewed by Csaba Osztrogonác.
3187
3188         * BuildSlaveSupport/build.webkit.org-config/config.json:
3189
3190 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
3191
3192         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
3193         https://bugs.webkit.org/show_bug.cgi?id=131151
3194
3195         Reviewed by Gyuyoung Kim.
3196
3197         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
3198         (TouchEventInfo::TouchEventInfo):
3199         (sendTouchEvent):
3200         (addTouchPointCallback):
3201         (updateTouchPointCallback):
3202         (cancelTouchPointCallback):
3203         (releaseTouchPointCallback):
3204
3205 2014-04-02  David Kilzer  <ddkilzer@apple.com>
3206
3207         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
3208         <http://webkit.org/b/131045>
3209
3210         Reviewed by Daniel Bates.
3211
3212         * Scripts/filter-build-webkit:
3213         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
3214         of clang, plus debug data for all DVTAssertions.
3215
3216 2014-04-01  Dean Jackson  <dino@apple.com>
3217
3218         Load Media Controls js/css from bundle
3219         https://bugs.webkit.org/show_bug.cgi?id=131086
3220
3221         Reviewed by Eric Carlson.
3222
3223         We're now putting CSS files into the bundle, so remove the test for them.
3224
3225         * Scripts/check-for-inappropriate-files-in-framework:
3226
3227 2014-04-02  Martin Hock  <mhock@apple.com>
3228
3229         Unify private browsing with sessions.
3230         https://bugs.webkit.org/show_bug.cgi?id=130099
3231
3232         Reviewed by Alexey Proskuryakov.
3233
3234         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
3235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3236         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
3237         (TestWebKitAPI::didNavigateWithNavigationData):
3238         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3239         (TestWebKitAPI::TEST):
3240
3241         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
3242         (TestWebKitAPI::didNavigateWithoutNavigationData):
3243         (TestWebKitAPI::didNavigateWithNavigationData):
3244         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3245         (TestWebKitAPI::TEST):
3246
3247 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
3248
3249         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
3250         https://bugs.webkit.org/show_bug.cgi?id=130343
3251
3252         Reviewed by Gustavo Noronha Silva.
3253
3254         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
3255         of directories on the command line and look for all appropriate files in those directories for the
3256         GResource archive. Also make archive paths relative to those directories.
3257         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
3258         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
3259
3260 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3261
3262         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
3263         https://bugs.webkit.org/show_bug.cgi?id=131106
3264
3265         Reviewed by Csaba Osztrogonác.
3266
3267         * Scripts/webkitpy/tool/commands/download.py:
3268         (AbstractRolloutPrepCommand._prepare_state):
3269         * Scripts/webkitpy/tool/commands/download_unittest.py:
3270         (test_prepare_rollout):
3271         (test_create_rollout):
3272         (test_create_rollout_resolved):
3273         (test_rollout):
3274
3275 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
3276
3277         [EFL] Add option to use separate web process for new window in MiniBrowser
3278         https://bugs.webkit.org/show_bug.cgi?id=130190
3279
3280         Reviewed by Gyuyoung Kim.
3281
3282         New created window (CTRL + n) will be open in separated web process.
3283         This option is enabled by adding a flag (S/separate-process) with launching
3284         MiniBrowser.
3285
3286         * MiniBrowser/efl/main.c:
3287         (elm_main):
3288
3289 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3290
3291         [GTK] Move NEWS file to a new location
3292         https://bugs.webkit.org/show_bug.cgi?id=130901
3293
3294         Reviewed by Brent Fulgham.
3295
3296         * gtk/manifest.txt: Update the NEWS file path.
3297
3298 2014-04-01  Anders Carlsson  <andersca@apple.com>
3299
3300         Fix build.
3301
3302         * MiniBrowser/mac/WK2BrowserWindowController.m:
3303         (-[WK2BrowserWindowController awakeFromNib]):
3304         (-[WK2BrowserWindowController dealloc]):
3305         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3306
3307 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
3308
3309         Unreviewed test gardening.
3310
3311         * Scripts/webkitpy/port/base_unittest.py:
3312         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
3313
3314 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
3315
3316         [CSS Exclusions] Remove exclusions parsing support
3317         https://bugs.webkit.org/show_bug.cgi?id=131046
3318
3319         Reviewed by David Hyatt.
3320
3321         * Scripts/webkitperl/FeatureList.pm:
3322
3323 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
3324
3325         [GTK] Remove last reference to GTK+ WK1 EWS
3326         https://bugs.webkit.org/show_bug.cgi?id=131058
3327
3328         Reviewed by Martin Robinson.
3329
3330         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
3331
3332         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
3333
3334 2014-04-01  Lucas Forschler  <lforschler@apple.com>
3335
3336         Add a 32bit JSC builder/tester.
3337         https://bugs.webkit.org/show_bug.cgi?id=131054
3338         
3339         Reviewed by Michael Saboff.
3340
3341         * BuildSlaveSupport/build.webkit.org-config/config.json:
3342         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3343         (Compile32bitJSC):
3344         (Run32bitJSCTests):
3345         (Run32bitJSCTests.countFailures):
3346         (BuildAndTest32bitJSCFactory):
3347         (BuildAndTest32bitJSCFactory.__init__):
3348
3349 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
3350
3351         [GTK] No longer build WebKit1 gtkdoc
3352         https://bugs.webkit.org/show_bug.cgi?id=130970
3353
3354         Reviewed by Anders Carlsson.
3355
3356         * gtk/common.py:
3357         (gtk_version_of_pkg_config_file): Deleted.
3358         * gtk/generate-gtkdoc:
3359         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
3360         was only applicable for WebKit1.
3361         (get_generator_for_config): No longer look for the WebKit1 configuration file.
3362
3363 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
3364
3365         [GTK] Running minibrowser with url crashes in debug build
3366         https://bugs.webkit.org/show_bug.cgi?id=130492
3367
3368         Reviewed by Martin Robinson.
3369
3370         Update "uri-scheme" test not to use invalid URIs in it, so we
3371         don't get a mistmatch when comparing the original URI stored in
3372         the test class with the one returned by the WebKitWebView.
3373
3374         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3375         (testWebContextURIScheme): Update the test.
3376
3377 2014-04-01  Mihai Tica  <mitica@adobe.com>
3378
3379         Unreviewed: Add myself as a commiter to the contributors list.
3380
3381         * Scripts/webkitpy/common/config/contributors.json:
3382
3383 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3384
3385         [EFL][WK2] Extract the control of page background out of color_set
3386         https://bugs.webkit.org/show_bug.cgi?id=127539
3387
3388         Reviewed by Gyuyoung Kim.
3389
3390         Added an option(C) to change background color.
3391
3392         * MiniBrowser/efl/main.c:
3393         (window_create):
3394         (elm_main):
3395
3396 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
3397
3398         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
3399
3400         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
3401
3402 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3403
3404         Unreviewed test correction after r166530.
3405
3406         * DumpRenderTree/mac/DumpRenderTree.mm:
3407         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
3408         fine-grained setting for swipe tests. This prevents existing tests from breaking.
3409
3410 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3411
3412         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
3413         https://bugs.webkit.org/show_bug.cgi?id=130987
3414
3415         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
3416         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
3417
3418         Reviewed by Martin Robinson.
3419
3420         * BuildSlaveSupport/build.webkit.org-config/config.json:
3421
3422 2014-03-31  Dean Jackson  <dino@apple.com>
3423
3424         Remove WEB_ANIMATIONS
3425         https://bugs.webkit.org/show_bug.cgi?id=130989
3426
3427         Reviewed by Simon Fraser.
3428
3429         Remove this feature flag until we plan to implement.
3430
3431         * Scripts/webkitperl/FeatureList.pm:
3432
3433 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
3434
3435         Reduced Latched Scroll Test Flakiness
3436         https://bugs.webkit.org/show_bug.cgi?id=130983
3437
3438         Reviewed by Darin Adler.
3439
3440         * DumpRenderTree/mac/DumpRenderTree.mm:
3441         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
3442         * DumpRenderTree/mac/EventSendingController.mm:
3443         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
3444         with high resolution flags turned on.
3445         * WebKitTestRunner/mac/EventSenderProxy.mm:
3446         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
3447
3448 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3449
3450         run-webkit-tests should have a --no-timeout option
3451         https://bugs.webkit.org/show_bug.cgi?id=128286
3452
3453         Reviewed by Joseph Pecoraro.
3454
3455         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3456         (Worker._run_test): Renaming _run_test_with_timeout()
3457         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
3458         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
3459         (Worker._run_test_in_this_thread):
3460         (Worker._run_test_with_timeout): Deleted.
3461         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3462         (parse_args): Added the --no-timeout option
3463
3464 2014-03-31  Samuel White  <samuel_white@apple.com>
3465
3466         AX: Need ability to get line range for text marker.
3467         https://bugs.webkit.org/show_bug.cgi?id=130906
3468
3469         Reviewed by Chris Fleizach.
3470
3471         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
3472
3473         * DumpRenderTree/AccessibilityUIElement.cpp:
3474         (lineTextMarkerRangeForTextMarkerCallback):
3475         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3476         (AccessibilityUIElement::getJSClass):
3477         * DumpRenderTree/AccessibilityUIElement.h:
3478         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3479         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3480         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3481         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3482         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3483         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3484         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3485         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3486         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3487         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3488         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3489         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
3490
3491 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
3492
3493         More validation for FTL inline caches
3494         https://bugs.webkit.org/show_bug.cgi?id=130948
3495
3496         Reviewed by Geoffrey Garen.
3497
3498         * Scripts/run-jsc-stress-tests:
3499
3500 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3501
3502         [GTK] Do not run WebKit1 unit tests by default
3503         https://bugs.webkit.org/show_bug.cgi?id=130968
3504
3505         Reviewed by Martin Robinson.
3506
3507         * Scripts/run-gtk-tests:
3508         (TestRunner):
3509
3510 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
3511
3512         [GTK] Remove scripts code only applicable to autotools
3513         https://bugs.webkit.org/show_bug.cgi?id=130841
3514
3515         Reviewed by Anders Carlsson.
3516
3517         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3518         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
3519         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
3520         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
3521         * gtk/find-make-dist-errors: Removed.
3522         * gtk/generate-feature-defines-files: Removed.
3523         * gtk/manifest.txt: No longer need to consider autotools files.
3524
3525 2014-03-30  Andy Estes  <aestes@apple.com>
3526
3527         Fix two failing layout tests on Mountain Lion after r166466.
3528
3529         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3530         (-[DownloadDelegate _downloadDidStart:]):
3531
3532 2014-03-30  Andy Estes  <aestes@apple.com>
3533
3534         [Cocoa] Add an originatingWebView property to _WKDownload
3535         https://bugs.webkit.org/show_bug.cgi?id=130945
3536
3537         Reviewed by Anders Carlsson.
3538
3539         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3540         (-[DownloadDelegate _downloadDidStart:]):
3541         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
3542         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3543         (TEST):
3544
3545 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
3546
3547         Land the stackmap register liveness glue with the uses of the liveness disabled
3548         https://bugs.webkit.org/show_bug.cgi?id=130924
3549
3550         Reviewed by Oliver Hunt.
3551
3552         * Scripts/run-jsc-stress-tests:
3553
3554 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
3555
3556         Update WebKit1.StringTruncator for Mountain Lion.
3557
3558         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
3559         due to different font metrics on 10.8.
3560
3561 2014-03-28  Darin Adler  <darin@apple.com>
3562
3563         Fix recently-introduced off-by-one error in centerTruncateToBuffer
3564         https://bugs.webkit.org/show_bug.cgi?id=130889
3565
3566         Reviewed by Alexey Proskuryakov.
3567
3568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
3569         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
3570         WebStringTruncator methods; should be good for a start. These are dependent on the
3571         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
3572
3573 2014-03-28  Martin Hock  <mhock@apple.com>
3574
3575         Unreviewed. Add myself as a committer.
3576
3577         * Scripts/webkitpy/common/config/contributors.json:
3578
3579 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
3580
3581         Remove WebKit1 GTK+ bots
3582         https://bugs.webkit.org/show_bug.cgi?id=130904
3583
3584         Reviewed by Anders Carlsson.
3585
3586         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
3587         all bots are testing WebKit2 only.
3588         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
3589         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
3590         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
3591         * Scripts/webkitpy/port/builders.py: Ditto.
3592         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
3593         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
3594
3595 2014-03-28  Timothy Hatcher  <timothy@apple.com>
3596
3597         Remove Brian Burg's apple.com email address.
3598
3599         * Scripts/webkitpy/common/config/contributors.json:
3600
3601 2014-03-28  David Kilzer  <ddkilzer@apple.com>
3602
3603         bisect-builds should print Trac 'changeset' URL if only one build is detected
3604         <http://webkit.org/b/130903>
3605
3606         Reviewed by Dan Bernstein.
3607
3608         * Scripts/bisect-builds:
3609         (printTracLink): Print a direct link to the Trac 'changeset'
3610         URL if there is only one revision in the range.
3611
3612 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3613
3614         [EFL] Bump glib version from 2.36 to 2.38 
3615         https://bugs.webkit.org/show_bug.cgi?id=130886
3616
3617         Reviewed by Csaba Osztrogonác.
3618
3619         There is a build break on EFL port when using glib 2.36 ver. To fix it,
3620         we need to bump glib version up to 2.38 as gtk port.
3621
3622         * efl/jhbuild.modules:
3623
3624 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3625
3626         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
3627
3628         Provide an implementation of WKContextHistoryClient that logs when called for tests in
3629         the globalhistory directory.
3630
3631         Reviewed by Sam Weinig.
3632
3633         * WebKitTestRunner/TestController.cpp:
3634         (WTR::TestController::TestController):
3635         (WTR::TestController::initialize): Set the history client.
3636         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
3637         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
3638         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
3639         and we don't yet have API to access the data in question.
3640         (WTR::TestController::didPerformClientRedirect):
3641         (WTR::TestController::didPerformServerRedirect):
3642         (WTR::TestController::didUpdateHistoryTitle):
3643         * WebKitTestRunner/TestController.h:
3644         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3645         * WebKitTestRunner/TestInvocation.cpp:
3646         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
3647         (WTR::TestInvocation::invoke):
3648
3649 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
3650
3651         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
3652
3653         * Scripts/build-webkit:
3654         * Scripts/copy-webkitlibraries-to-product-directory:
3655
3656 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
3657
3658         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
3659         https://bugs.webkit.org/show_bug.cgi?id=130867
3660         <rdar://problem/16432456> 
3661
3662         Reviewed by Mark Hahnenberg.
3663
3664         * Scripts/build-webkit:
3665         * Scripts/copy-webkitlibraries-to-product-directory:
3666
3667 2014-03-26  Andy Estes  <aestes@apple.com>
3668
3669         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
3670         https://bugs.webkit.org/show_bug.cgi?id=130805
3671
3672         Reviewed by Dan Bernstein.
3673
3674         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3675         (-[DownloadDelegate _download:didReceiveResponse:]):
3676         (-[DownloadDelegate _downloadDidFinish:]):
3677         (runTest):
3678         (TEST):
3679         (-[FailingDownloadDelegate _downloadDidFinish:]):
3680         (-[FailingDownloadDelegate _download:didFailWithError:]):
3681         (-[FailingDownloadDelegate _downloadDidCancel:]):
3682         (-[CancelledDownloadDelegate _downloadDidStart:]):
3683         (-[CancelledDownloadDelegate _downloadDidFinish:]):
3684         (-[CancelledDownloadDelegate _download:didFailWithError:]):
3685         (-[CancelledDownloadDelegate _downloadDidCancel:]):
3686         (-[DownloadDelegate initWithSourceURL:]): Deleted.
3687         (-[DownloadDelegate sourceURL]): Deleted.
3688         (runTestWithNavigationDelegate): Deleted.
3689
3690 2014-03-26  Anders Carlsson  <andersca@apple.com>
3691
3692         Change MiniBrowser to hold on to window controllers instead of windows
3693         https://bugs.webkit.org/show_bug.cgi?id=130797
3694
3695         Reviewed by Oliver Hunt.
3696
3697         * MiniBrowser/mac/AppDelegate.h:
3698         * MiniBrowser/mac/AppDelegate.m:
3699         (-[BrowserAppDelegate init]):
3700         (-[BrowserAppDelegate newWindow:]):
3701         (-[BrowserAppDelegate browserWindowWillClose:]):
3702         (-[BrowserAppDelegate applicationWillTerminate:]):
3703         (-[BrowserAppDelegate frontmostBrowserWindowController]):
3704
3705 2014-03-26  Commit Queue  <commit-queue@webkit.org>
3706
3707         Unreviewed, rolling out r166264.
3708         https://bugs.webkit.org/show_bug.cgi?id=130785
3709
3710         Broke some window.opener tests for WK2 Mavericks (Requested by
3711         brrian__ on #webkit).
3712
3713         Reverted changeset:
3714
3715         "Web Replay: resource unique identifiers should be unique-per-
3716         frame, not globally"
3717         https://bugs.webkit.org/show_bug.cgi?id=130632
3718         http://trac.webkit.org/changeset/166264
3719
3720 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
3721
3722         [CSS Shapes] Remove shape-inside support
3723         https://bugs.webkit.org/show_bug.cgi?id=130698
3724
3725         Reviewed by David Hyatt.
3726
3727         * Scripts/webkitperl/FeatureList.pm:
3728
3729 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
3730
3731         Unreviewed. Add myself as a committer.
3732
3733         * Scripts/webkitpy/common/config/contributors.json:
3734
3735 2014-03-26  Tomas Popela  <tpopela@redhat.com>
3736
3737         run-launcher is Perl script so use elsif and not elif
3738         https://bugs.webkit.org/show_bug.cgi?id=130771
3739
3740         Reviewed by Carlos Garcia Campos.
3741
3742         * Scripts/run-launcher:
3743
3744 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
3745
3746         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
3747         https://bugs.webkit.org/show_bug.cgi?id=130575
3748
3749         Reviewed by Mario Sanchez Prada.
3750
3751         Change ATK version to 2.11.92. Adjust current implementation.
3752
3753         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3754         (AccessibilityUIElement::intValue):
3755         (AccessibilityUIElement::minValue):
3756         (AccessibilityUIElement::maxValue):
3757         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3758         (WTR::AccessibilityUIElement::intValue):
3759         (WTR::AccessibilityUIElement::minValue):
3760         (WTR::AccessibilityUIElement::maxValue):
3761         * efl/jhbuild.modules:
3762         * gtk/jhbuild.modules:
3763
3764 2014-03-12  Philippe Normand  <pnormand@igalia.com>
3765
3766         [GTK] The gnumake package is no longer needed in jhbuild
3767         https://bugs.webkit.org/show_bug.cgi?id=130121
3768
3769         Reviewed by Martin Robinson.
3770
3771         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
3772         for a debug build cmake/system-gnumake worked just fine for me.
3773
3774         * gtk/jhbuild.modules: Removed gnumake.
3775         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
3776         * gtk/patches/make-3.82-parallel-build.patch: Removed.
3777
3778 2014-03-25  Andy Estes  <aestes@apple.com>
3779
3780         Fix a failing API test on Mountain Lion and remove temporary debug logging.
3781
3782         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3783         (-[DownloadDelegate _download:didReceiveData:]):
3784         (-[DownloadDelegate _downloadDidFinish:]):
3785
3786 2014-03-25  Brian Burg  <bburg@apple.com>
3787
3788         Web Replay: resource unique identifiers should be unique-per-frame, not globally
3789         https://bugs.webkit.org/show_bug.cgi?id=130623
3790
3791         Reviewed by Timothy Hatcher.
3792
3793         The resource loader callback dumping routines assumed that resource identifiers
3794         were globally unique. Its map of resource identifiers to URLs must also track the
3795         frame associated with the resource.
3796
3797         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3798         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
3799         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
3800         stable as long as the frame is valid.
3801         (WTR::InjectedBundlePage::didInitiateLoadForResource):
3802         (WTR::InjectedBundlePage::willSendRequestForFrame):
3803         (WTR::InjectedBundlePage::didReceiveResponseForResource):
3804         (WTR::InjectedBundlePage::didFinishLoadForResource):
3805         (WTR::InjectedBundlePage::didFailLoadForResource):
3806
3807 2014-03-25  Andy Estes  <aestes@apple.com>
3808
3809         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
3810
3811         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3812         (-[DownloadDelegate _download:didReceiveResponse:]):
3813         (-[DownloadDelegate _download:didReceiveData:]):
3814
3815 2014-03-25  Andy Estes  <aestes@apple.com>
3816
3817         Add some debug logging to an API test that's failing on Mountain Lion.
3818
3819         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3820         (-[DownloadDelegate _download:didReceiveResponse:]):
3821         (-[DownloadDelegate _downloadDidFinish:]):
3822
3823 2014-03-25  Anders Carlsson  <andersca@apple.com>
3824
3825         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
3826         https://bugs.webkit.org/show_bug.cgi?id=130732
3827
3828         Reviewed by Tim Horton.
3829
3830         * MiniBrowser/mac/WK2BrowserWindowController.m:
3831         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3832
3833 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
3834
3835         [GTK] Remove the autotools build
3836         https://bugs.webkit.org/show_bug.cgi?id=130717
3837
3838         Reviewed by Anders Carlsson.
3839
3840         * DumpRenderTree/config.h: Remove references to the autotools configure file.
3841         * GNUmakefile.am: Removed.
3842         * GtkLauncher/GNUmakefile.am: Removed.
3843         * GtkLauncher/main.c: Remove references to the autotools configure file.
3844         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
3845         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
3846         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
3847         * MiniBrowser/gtk/GNUmakefile.am: Removed.
3848         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
3849         * Scripts/build-webkit: No longer handle autotools.
3850         * Scripts/run-gtk-tests: Ditto.
3851         (TestRunner._setup_testing_environment):
3852         * Scripts/run-launcher: Ditto.
3853         * Scripts/webkitdirs.pm: Ditto.
3854         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
3855         * Scripts/webkitpy/common/config/contributors.json: Ditto.
3856         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
3857         * Scripts/webkitpy/style/checker.py:
3858         * TestWebKitAPI/GNUmakefile.am: Removed.
3859         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
3860         * WebKitTestRunner/GNUmakefile.am: Removed.
3861         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
3862         * gtk/GNUmakefile.am: Removed.
3863         * gtk/common.py: Remove checks for the autotools build.
3864         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
3865
3866 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
3867
3868         prepare-ChangeLog throws false positive warnings for modified files.
3869         https://bugs.webkit.org/show_bug.cgi?id=130687
3870
3871         Reviewed by Darin Adler.
3872
3873         * Scripts/prepare-ChangeLog:
3874         (originalFile): Ignore git commit paremeter.
3875         We don't need this to get the unmodified file.
3876         (extractLineRangeBeforeChange):
3877         Simplify the if statement. Follow-up after r166189.
3878
3879 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
3880
3881         [EFL] Add ARM64 build support
3882         https://bugs.webkit.org/show_bug.cgi?id=130506
3883
3884         Rubber stamped by Gyuyoung Kim.
3885
3886         * Scripts/webkitdirs.pm:
3887         (isARM): Detect aarch64 as ARM.
3888
3889 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3890
3891         [webkitpy] Improve _parse_bug_description to recognize more descriptions
3892         https://bugs.webkit.org/show_bug.cgi?id=130137
3893
3894         Reviewed by Csaba Osztrogonác.
3895
3896         * Scripts/webkitpy/common/checkout/changelog.py:
3897         (ChangeLogEntry._parse_bug_description):
3898         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3899         (test_parse_log_entries_from_changelog):
3900         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3901         (CheckoutTest.test_commit_info_for_revision):
3902
3903 2014-03-24  Andy Estes  <aestes@apple.com>
3904
3905         Fix the iOS build of TestWebKitAPI.
3906
3907         * TestWebKitAPI/Configurations/Base.xcconfig:
3908         * TestWebKitAPI/PlatformUtilities.h:
3909
3910 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3911
3912         Fix prepare-ChangeLog after r166156.
3913         https://bugs.webkit.org/show_bug.cgi?id=130674
3914
3915         Reviewed by Darin Adler.
3916
3917         * Scripts/prepare-ChangeLog:
3918         (generateFunctionLists):
3919         (extractLineRangeBeforeChange):
3920
3921 2014-03-24  Andy Estes  <aestes@apple.com>
3922
3923         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
3924         https://bugs.webkit.org/show_bug.cgi?id=129322
3925
3926         Reviewed by Anders Carlsson.
3927
3928         Add an API test suite for _WKDownload.
3929
3930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3931         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
3932         (-[DownloadDelegate initWithSourceURL:]):
3933         (-[DownloadDelegate sourceURL]):
3934         (-[DownloadDelegate _downloadDidStart:]):
3935         (-[DownloadDelegate _download:didReceiveResponse:]):
3936         (-[DownloadDelegate _download:didReceiveData:]):
3937         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3938         (-[DownloadDelegate _downloadDidFinish:]):
3939         (TEST):
3940         (runTestWithNavigationDelegate):
3941         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3942         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3943
3944 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
3945
3946         filter-build-webkit: reduce unfiltered output
3947         https://bugs.webkit.org/show_bug.cgi?id=130485
3948
3949         Reviewed by Brent Fulgham.
3950
3951         * Scripts/filter-build-webkit:
3952         (shouldIgnoreLine):
3953
3954 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
3955
3956         prepare-ChangeLog should list functions that have been removed too.
3957         https://bugs.webkit.org/show_bug.cgi?id=130508
3958
3959         Reviewed by Darin Adler.
3960
3961         The prepare-ChangeLog does not list the deleted functions in the Changelog.
3962         We have to read the functions and the line ranges of them from the source
3963         before the change, then search for overlaps between them and the changed
3964         line ranges from diff.
3965
3966         * Scripts/prepare-ChangeLog:
3967         (originalFile): Get original source command.
3968         (generateFunctionLists): Collect deleted functions too.
3969         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
3970         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
3971         deleted functions ranges too.
3972         (extractLineRange): Renamed to extractLineRangeAfterChange.
3973
3974 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
3975
3976         Move all EFL typedefs into EflTypedefs.h.
3977         https://bugs.webkit.org/show_bug.cgi?id=130511
3978
3979         Reviewed by Gyuyoung Kim.
3980
3981         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
3982         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
3983         * WebKitTestRunner/PlatformWebView.h: Ditto.
3984
3985 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
3986
3987         Don't flush compositing layers within FrameView::willPaintContents()
3988         https://bugs.webkit.org/show_bug.cgi?id=130627
3989         <rdar://problem/16368869>
3990
3991         Reviewed by Sam Weinig.
3992         
3993         Fix DRT to correctly render tests with layers now that FrameView::paintContents
3994         does not flush.
3995         
3996         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
3997         into an explicit function called before dumping. 
3998         
3999         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
4000         are flushed to CA. They will be pushed to the window by snapshotting.
4001
4002         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4003         Fix weird path to IOKit.framework.
4004         * DumpRenderTree/mac/DumpRenderTree.mm:
4005         (updateDisplay):
4006         (dump):
4007         * DumpRenderTree/mac/FrameLoadDelegate.mm:
4008         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
4009         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
4010
4011 2014-03-21  David Kilzer  <ddkilzer@apple.com>
4012
4013         fix-blink-patch: tool to fix up renamed directory paths in Blink
4014         <http://webkit.org/b/130609>
4015
4016         Reviewed by Ryosuke Niwa.
4017
4018         Usage: cat blink.patch | fix-blink-patch | svn-apply
4019
4020         * Scripts/fix-blink-patch: Added.
4021
4022 2014-03-21  Darin Adler  <darin@apple.com>
4023
4024         Remove use of deprecatedCharacters in WebKit API tests
4025         https://bugs.webkit.org/show_bug.cgi?id=130602
4026
4027         Reviewed by Antti Koivisto.
4028
4029         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
4030         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
4031         (TestWebKitAPI::expectEmpty): Use characters8.
4032         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
4033
4034         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4035         Removed the test that is entirely about 16-bit conversion since that's basically a test of
4036         the deprecatedCharacters function itself, which we are about to delete.
4037
4038 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4039
4040         [webkitpy] Fix has_valid_reviewer()
4041         https://bugs.webkit.org/show_bug.cgi?id=130589
4042
4043         Reviewed by Csaba Osztrogonác.
4044
4045         * Scripts/webkitpy/common/checkout/changelog.py:
4046         (ChangeLogEntry.has_valid_reviewer):
4047         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4048         (test_has_valid_reviewer):
4049         * Scripts/webkitpy/common/config/committers.py:
4050         (CommitterList._reviewer_only):
4051         (CommitterList.committer_by_name):
4052         (CommitterList.reviewer_by_email):
4053         (CommitterList):
4054         (CommitterList.reviewer_by_name):
4055
4056 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
4057
4058         Add cache support for jhbuild
4059         https://bugs.webkit.org/show_bug.cgi?id=130588
4060
4061         Reviewed by Csaba Osztrogonác.
4062
4063         * jhbuild/jhbuildrc_common.py:
4064         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
4065
4066 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4067
4068         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
4069         https://bugs.webkit.org/show_bug.cgi?id=130504
4070
4071         Reviewed by Martin Robinson.
4072
4073         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
4074         CMake if not specified.
4075         * Scripts/webkitdirs.pm:
4076         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
4077         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
4078
4079 2014-03-21  Andreas Kling  <akling@apple.com>
4080
4081         RetainPtr API test should use CFArray instead of CFString for testing.
4082         <rdar://problem/16384899>
4083
4084         Unreviewed bot fix.
4085
4086         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
4087         (TestWebKitAPI::TEST):
4088         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
4089         (TestWebKitAPI::TEST):
4090
4091 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
4092
4093         Move to using std::unique_ptr for EFL objects.
4094         https://bugs.webkit.org/show_bug.cgi?id=129853
4095
4096         Reviewed by Gyuyoung Kim.
4097
4098         EflUniquePtr is a template alias of std::unique_ptr
4099         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
4100         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
4101
4102         * DumpRenderTree/efl/DumpRenderTree.cpp:
4103         (main):
4104         * ImageDiff/efl/ImageDiff.cpp:
4105         (initEfl):
4106         (main):
4107
4108 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
4109
4110         Unreviewed buildfix after r165983 for non Cocoa platforms
4111
4112         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
4113
4114         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
4115         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
4116         * WebKitTestRunner/TestController.cpp:
4117
4118 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
4119
4120         [GTK][CMake] Add support for building with Clang
4121         https://bugs.webkit.org/show_bug.cgi?id=130260
4122
4123         Reviewed by Martin Robinson.
4124
4125         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
4126         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
4127         included GTest framework headers.
4128         * gtk/generate-gtkdoc:
4129         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
4130         in case of using Clang since that is now set by the CMake rule.
4131
4132 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
4133
4134         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
4135         https://bugs.webkit.org/show_bug.cgi?id=130476
4136
4137         Reviewed by Anders Carlsson.
4138         
4139         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
4140
4141         * MiniBrowser/mac/WK1BrowserWindowController.m:
4142         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
4143         Remove log.
4144         * MiniBrowser/mac/WK2BrowserWindowController.m:
4145         (-[WK2BrowserWindowController awakeFromNib]):
4146         (-[WK2BrowserWindowController validateMenuItem:]):
4147         (-[WK2BrowserWindowController reload:]):
4148         Hook up reload.
4149         (-[WK2BrowserWindowController toggleZoomMode:]):
4150         (-[WK2BrowserWindowController resetZoom:]):
4151         (-[WK2BrowserWindowController canResetZoom]):
4152         (-[WK2BrowserWindowController currentZoomFactor]):
4153         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
4154         (-[WK2BrowserWindowController canZoomIn]):
4155         (-[WK2BrowserWindowController canZoomOut]):
4156
4157 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
4158
4159         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
4160         https://bugs.webkit.org/show_bug.cgi?id=130463
4161
4162         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
4163
4164 2014-03-18  Samuel White  <samuel_white@apple.com>
4165
4166         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
4167         https://bugs.webkit.org/show_bug.cgi?id=130250
4168
4169         Reviewed by Chris Fleizach.
4170
4171         Added ability to toggle enhanced accessibility on and off to support tests that require it.
4172
4173         * DumpRenderTree/AccessibilityController.cpp:
4174         (enableEnhancedAccessibilityCallback):
4175         (getEnhancedAccessibilityEnabledCallback):
4176         (AccessibilityController::getJSClass):
4177         * DumpRenderTree/AccessibilityController.h:
4178         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4179         (AccessibilityController::enableEnhancedAccessibility):
4180         (AccessibilityController::enhancedAccessibilityEnabled):
4181         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
4182         (AccessibilityController::enableEnhancedAccessibility):
4183         (AccessibilityController::enhancedAccessibilityEnabled):
4184         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4185         (AccessibilityController::enableEnhancedAccessibility):
4186         (AccessibilityController::enhancedAccessibilityEnabled):
4187         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4188         (AccessibilityController::enableEnhancedAccessibility):
4189         (AccessibilityController::enhancedAccessibilityEnabled):
4190         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
4191         (WTR::AccessibilityController::enableEnhancedAccessibility):
4192         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
4193         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
4194         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
4195
4196 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
4197
4198         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
4199         yet).
4200
4201         * Scripts/webkitpy/common/config/contributors.json:
4202
4203 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
4204
4205         Web Inspector: Remove stale ReportMemoryUsagePlugin
4206         https://bugs.webkit.org/show_bug.cgi?id=130405
4207
4208         Reviewed by Andreas Kling.
4209
4210         This clang plugin looks like it was used for the old Inspector memory
4211         instrumentation that was removed. So the tool can be removed.
4212
4213         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
4214         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
4215         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
4216         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
4217
4218 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4219
4220         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
4221         https://bugs.webkit.org/show_bug.cgi?id=130220
4222
4223         Reviewed by Csaba Osztrogonác.
4224
4225         * Scripts/webkitpy/common/checkout/changelog.py:
4226         (ChangeLog.set_reviewer):
4227         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4228         (test_set_reviewer):
4229
4230 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
4231
4232         More FTL enabling.
4233
4234         Rubber stamped by Dan Bernstein.
4235
4236         * Tools/Scripts/build-webkit:
4237
4238 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
4239
4240         Renable pagination mode in WK2 MiniBrowser
4241         https://bugs.webkit.org/show_bug.cgi?id=130374
4242
4243         Reviewed by Anders Carlsson.
4244         
4245         Put the implementation of togglePaginationMode: back, and correctly
4246         enable the menu item.
4247
4248         * MiniBrowser/mac/WK2BrowserWindowController.m:
4249         (-[WK2BrowserWindowController validateMenuItem:]):
4250         (-[WK2BrowserWindowController isPaginated]):
4251         (-[WK2BrowserWindowController togglePaginationMode:]):
4252
4253 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4254
4255         Add --reset option to Tools/Scripts/set-webkit-configuration script
4256         https://bugs.webkit.org/show_bug.cgi?id=130401
4257
4258         Reviewed by Csaba Osztrogonác.
4259
4260         * Scripts/set-webkit-configuration:
4261
4262 2014-03-18  Alberto Garcia  <berto@igalia.com>
4263
4264         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
4265         https://bugs.webkit.org/show_bug.cgi?id=130388
4266
4267         Reviewed by Sergio Villar Senin.
4268
4269         * Scripts/webkitdirs.pm:
4270         (shouldRemoveCMakeCache): make sure that the build directory
4271         exists before attempting to create a file in it.
4272
4273 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
4274
4275         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
4276         https://bugs.webkit.org/show_bug.cgi?id=130336
4277
4278         Reviewed by Gyuyoung Kim.
4279
4280         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
4281         requires a space between literal and string macro [-Wliteral-suffix]'
4282         warning treated as error.
4283
4284         This patch applies a solution from r162448 to the EFL port.
4285
4286         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
4287         * efl/jhbuild.modules: Added appropriate patch section.
4288
4289 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
4290
4291         webkitpy test rebaseline.
4292
4293         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4294         (MainTest.test_default_args):
4295
4296 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
4297
4298         --profile should imply --test-runner-count=1 in run-perf-tests
4299         https://bugs.webkit.org/show_bug.cgi?id=130375
4300
4301         Reviewed by Benjamin Poulain.
4302
4303         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
4304
4305         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4306         (PerfTestsRunner._parse_args): Use -1 as the default value.
4307         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
4308         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
4309         should be 1.
4310
4311 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
4312
4313         Address some style nits.
4314
4315         * MiniBrowser/mac/WK2BrowserWindowController.m:
4316
4317 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
4318
4319         Add transparent window support back into MiniBrowser
4320         https://bugs.webkit.org/show_bug.cgi?id=130363
4321
4322         Reviewed by Anders Carlsson.
4323         
4324         Re-enable transparent window support for WK2.
4325
4326         * MiniBrowser/mac/WK2BrowserWindowController.m:
4327         (-[WK2BrowserWindowController validateMenuItem:]):
4328         (-[WK2BrowserWindowController toggleTransparentWindow:]):
4329
4330 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
4331
4332         Fix the 32-bit build; make the open panel make a WK1 window.
4333
4334         * MiniBrowser/mac/AppDelegate.m:
4335         (-[BrowserAppDelegate openDocument:]):
4336
4337 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
4338
4339         Convert MiniBrowser to use WKWebView API
4340         https://bugs.webkit.org/show_bug.cgi?id=130061