fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
[WebKit-https.git] / Tools / ChangeLog
1 2013-07-16  Filip Pizlo  <fpizlo@apple.com>
2
3         fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
4         https://bugs.webkit.org/show_bug.cgi?id=118647
5
6         Rubber stamped by Geoffrey Garen and Mark Hahnenberg.
7
8         Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
9         way that the FTL would.
10         
11         Also add a tool that combines multiple LLVM modules generated by FTL into a
12         single module.
13
14         * ReducedFTL: Added.
15         * ReducedFTL/ReducedFTL.c: Added.
16         (usage):
17         (currentTime):
18         (MemorySection):
19         (mmAllocateCodeSection):
20         (mmAllocateDataSection):
21         (mmApplyPermissions):
22         (mmDestroy):
23         (symbolLookupCallback):
24         (main):
25         * ReducedFTL/build.sh: Added.
26         * ReducedFTL/combineModules.rb: Added.
27
28 2013-06-09  Filip Pizlo  <fpizlo@apple.com>
29
30         Unreviewed, fix minor goof in profiling output layout. We weren't accounting
31         for the "/" that is printed between engine counts.
32
33         * Scripts/display-profiler-output:
34
35 2013-05-28  Filip Pizlo  <fpizlo@apple.com>
36
37         testRunner should have a way of disabling inlining of functions
38         https://bugs.webkit.org/show_bug.cgi?id=116875
39
40         Reviewed by Mark Hahnenberg.
41
42         * DumpRenderTree/TestRunner.cpp:
43         (neverInlineFunction):
44         (TestRunner::staticFunctions):
45
46 2013-05-27  Filip Pizlo  <fpizlo@apple.com>
47
48         testRunner should be able to tell you if a function is DFG compiled
49         https://bugs.webkit.org/show_bug.cgi?id=116847
50
51         Reviewed by Mark Hahnenberg.
52
53         * DumpRenderTree/TestRunner.cpp:
54         (numberOfDFGCompiles):
55         (TestRunner::staticFunctions):
56
57 2013-05-21  Filip Pizlo  <fpizlo@apple.com>
58
59         fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
60         https://bugs.webkit.org/show_bug.cgi?id=116556
61
62         Reviewed by Oliver Hunt.
63         
64         This adds three new capabilities:
65         
66         - 'display' now accepts negative compilation indices, and allows specifying
67           wildcard hashes combined with combination indices. Previously you could say
68           'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The
69           latter would display every compilation. This improves this so that you can
70           say 'display *-<index>-<engine>'. It also makes it so that you can give a
71           negative index, which allows you to say things like 'display blah--1-dfg',
72           which displays just the last DFG compilation. Also you can say
73           'display *--1-dfg', which displays the last DFG compilation for each code
74           block. I realize that this is kind of ugly, but gosh is it practical.
75         
76         - You can now say 'sort hash', which will henceforth sort all of the output
77           by code hash rather than by the time when it was compiled. This means that
78           if you're doing 'dispay *--1-dfg' and then want to diff the results against
79           something else, you can ensure that this doesn't get confused just by
80           changes in compilation order.
81         
82         - You can now say 'counts off', which will henceforth disable the display of
83           execution counts from 'bytecode' and 'display'. This is also useful for
84           diffs, since if you're trying to figure out why two compilations are
85           different, they probably have radically different counts. 'counts off' gets
86           this out of the output so that it doesn't confuse your diff.
87         
88         Note that to use this effectively you should also have a script that scrubs
89         pointers from text so that the diff doesn't get confused by pointers. I'll
90         post my elimptr script to the bug. Maybe at some point I'll integrate that
91         into display-profiler-output.
92         
93         Put together this is pretty awesome. I was able to do the following:
94         
95         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
96         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
97         diff -u richards-serial.asm richards-concurrent.asm
98         
99         And this immediately told me that the reason why richards is slower in the
100         concurrent compilation case is just that we end up compiling *tons* more
101         functions, most of which are trivially inlineable. Basically, concurrent
102         compilation breaks our previous heuristics for delaying compilation of
103         inlineables just enough that they never trigger compilation. We should fix
104         that in a separate bug.
105
106         * Scripts/display-profiler-output:
107
108 2013-04-30  Filip Pizlo  <fpizlo@apple.com>
109
110         fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no
111
112         Rubber stamped by Mark Rowe.
113
114         * Scripts/copy-webkitlibraries-to-product-directory:
115
116 2013-07-16  Oliver Hunt <oliver@apple.com>
117
118         Merge dfgFourthTier r148853
119
120     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
121
122         fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
123         https://bugs.webkit.org/show_bug.cgi?id=114933
124
125         Reviewed by Andy Estes.
126         
127         This makes it easy to get set up for tandem LLVM builds.
128
129         * Scripts/copy-webkitlibraries-to-product-directory:
130
131 2013-07-16  Oliver Hunt <oliver@apple.com>
132
133         Merge dfgFourthTier r148850
134
135     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
136
137         fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
138         https://bugs.webkit.org/show_bug.cgi?id=114926
139
140         Reviewed by Geoffrey Garen.
141         
142         If the LLVM libraries change, then touch a phony header, which will force relink
143         of JavaScriptCore.
144
145         * Scripts/copy-webkitlibraries-to-product-directory:
146         (unpackIfNecessary):
147
148 2013-07-16  Oliver Hunt <oliver@apple.com>
149
150         Merge dfgFourthTier r148848
151
152     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
153
154         fourthTier: developing LLVM in tandem with WebKit should be fun and easy
155         https://bugs.webkit.org/show_bug.cgi?id=114925
156
157         Reviewed by Geoffrey Garen.
158         
159         This enables building LLVM along with WebKit, so that build-jsc and build-webkit
160         will also optionally build LLVM and quickly symlink LLVM's built products into
161         the right places.
162         
163         Most WebKit and JSC hackers will want to rely on the checked-in already-built
164         versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
165         increasingly common use-case for me, and it may become a common use case for a
166         handful of others. Currently, this is really painful: you first have to build
167         LLVM, then you have to export-llvm-build (which takes a while), and then you
168         have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
169         variables are set to point to the thing you exported. The whole process loses
170         track of dependencies very quickly: making a tiny change in LLVM requires
171         packaging, and then unpackaging, a large number of potentially large headers and
172         static libraries. Not only is this slow but it then causes the WebKit build
173         system to rebuild anything that transitively includes any LLVM header, which is
174         now quite a few files. While this sort of use pattern is still worthwhile if
175         you're trying to package a binary drop and test it, it's not great if you're
176         just trying to do experimental development that involves making small changes
177         in both trees.
178         
179         This change fixes this use case while keeping the old use cases intact. You can
180         do tandem development using one of two modes:
181         
182         Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
183         the LLVM directory you're using. Once this is done, any invocation of a WebKit
184         build via build-jsc or build-webkit will also build LLVM, and then quickly
185         symlink things into place without perturbing dependency tracking.
186         
187         Internal LLVM directory: if you check out llvm into a directory called 'llvm'
188         right off of the WebKit source tree, then the build system will automatically
189         use this.
190         
191         Here's how this takes care of dependencies:
192         
193         Headers: the include/llvm and include/llvm-c directories are symlinked into
194         $productsDir/usr/local/include. And then everything just works.
195         
196         Libraries: the build system detects, by reading LLVM's Makefile.config, which
197         mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
198         the .a files into $productsDir/<thingy>. It will ranlib those libraries only
199         if they have changed, by checking both the modification time and also whether
200         the last time we had a symlink, that symlink was from the same directory.
201         This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
202         but that build wasn't yet ranlib'd.
203         
204         One problem that this does not yet solve is that xcodebuild will not relink
205         JavaScriptCore if the only thing that changed was the libraries. I will work
206         on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
207
208         * Scripts/copy-webkitlibraries-to-product-directory:
209         (unpackIfNecessary):
210         (fileContains):
211         (fileContentsEquals):
212
213 2013-04-15  Filip Pizlo  <fpizlo@apple.com>
214
215         fourthTier: Update LLVM-related build scripts to copy generated headers as well
216         https://bugs.webkit.org/show_bug.cgi?id=114551
217
218         Reviewed by Oliver Hunt.
219         
220         Also added the ability to use something other than bzip2 compression, since although
221         it is great for checking things into the tree, it increases turn-around times when
222         experimenting.
223
224         * Scripts/copy-webkitlibraries-to-product-directory:
225         (unpackIfNecessary):
226         * Scripts/export-llvm-build:
227
228 2013-04-03  Filip Pizlo  <fpizlo@apple.com>
229
230         fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
231         https://bugs.webkit.org/show_bug.cgi?id=113921
232
233         Reviewed by Oliver Hunt.
234
235         The LLVM community wants us to continue including all of LLVM's C++ headers. Change
236         the export script to do this.
237         
238         * Scripts/export-llvm-build:
239
240 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
241
242         fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
243         https://bugs.webkit.org/show_bug.cgi?id=113452
244
245         Rubber stamped by Mark Hahnenberg.
246
247         * Scripts/copy-webkitlibraries-to-product-directory:
248         * Scripts/export-llvm-build:
249
250 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
251
252         fourthTier: FTL JIT should be able run some simple function
253         https://bugs.webkit.org/show_bug.cgi?id=113481
254
255         Reviewed by Geoffrey Garen.
256         
257         Give the scripts the ability to find an LLVM build and use it.
258         
259         Also added a script, export-llvm-build, that allows you to take your
260         own build of LLVM and package it for use by WebKit's build system.
261         
262         The build system treats a "build" of LLVM as a pair of .tar.bz2's,
263         one for the library archives and one for the headers. It then unpacks
264         them into your built products directory in a mannner that is mostly
265         analogous to how WebKitSystemInterface works.
266
267         * Scripts/build-jsc:
268         * Scripts/copy-webkitlibraries-to-product-directory:
269         (unpackIfNecessary):
270         (dittoHeaders):
271         * Scripts/export-llvm-build: Added.
272
273 2013-07-24  Anders Carlsson  <andersca@apple.com>
274
275         Crash when calling WKPageGetProcessIdentifier after aborted process launch
276         https://bugs.webkit.org/show_bug.cgi?id=119069
277         <rdar://problem/14494064>
278
279         Reviewed by Andreas Kling.
280
281         Add a test.
282
283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
284         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
285         (TestWebKitAPI::didFinishLoadForFrame):
286         (TestWebKitAPI::TEST):
287
288 2013-07-24  Zan Dobersek  <zdobersek@igalia.com>
289
290         Make KURL::hasPath private
291         https://bugs.webkit.org/show_bug.cgi?id=118279
292
293         Reviewed by Darin Adler.
294
295         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
296         (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
297
298 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
299
300         [GTK] TestInspectorServer unit test is timing out
301         https://bugs.webkit.org/show_bug.cgi?id=105866
302
303         Reviewed by Gustavo Noronha Silva.
304
305         * Scripts/run-gtk-tests:
306         (TestRunner):
307
308 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
309
310         [GTK] [WK2] Handle wheel event with delta zero
311         https://bugs.webkit.org/show_bug.cgi?id=118973
312
313         Reviewed by Gustavo Noronha Silva.
314
315         Added handling of zero mouse scroll deltas in EventSenderProxy similar
316         to WK1 and Qt/EFL ports.
317
318         fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
319         failing on WK2.
320
321         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
322         (WTR::EventSenderProxy::mouseScrollBy):
323
324 2013-07-23  Andreas Kling  <akling@apple.com>
325
326         REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
327         <rdar://problem/14324895>
328         <http://webkit.org/b/119023>
329
330         Reviewed by Simon Fraser.
331
332         Add a test for this rather specific problem.
333
334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
335         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
336         (TestWebKitAPI::TEST):
337         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
338         (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
339         (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
340         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
341
342 2013-07-23  Tim Horton  <timothy_horton@apple.com>
343
344         Add a test for plug-in unavailability indicator obscurity detection
345         https://bugs.webkit.org/show_bug.cgi?id=119007
346
347         Reviewed by Anders Carlsson.
348
349         Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
350
351         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
352         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
353         (WTR::TestRunner::setBlockAllPlugins):
354         * WebKitTestRunner/InjectedBundle/TestRunner.h:
355         * WebKitTestRunner/TestInvocation.cpp:
356         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
357         Add testRunner.setBlockAllPlugins function (and corresponding message to
358         forward it through to TestController).
359
360         * WebKitTestRunner/TestController.cpp:
361         Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
362
363         (WTR::TestController::createWebViewWithOptions):
364         Register our pluginLoadPolicy callback.
365
366         (WTR::TestController::resetStateToConsistentValues):
367         Reset m_shouldBlockAllPlugins to false.
368
369         (WTR::TestController::pluginLoadPolicy):
370         Return the existing plugin load policy, unless setBlockAllPlugins(true)
371         was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
372
373         * WebKitTestRunner/TestController.h:
374         (WTR::TestController::setBlockAllPlugins):
375
376 2013-07-21  Andreas Kling  <akling@apple.com>
377
378         KURL creates duplicate strings when completing data: URIs.
379         <http://webkit.org/b/118952>
380         <rdar://problem/14504480>
381
382         Reviewed by Anders Carlsson.
383
384         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
385         (TestWebKitAPI::TEST_F):
386
387 2013-07-19  Chris Fleizach  <cfleizach@apple.com>
388
389         AX: VoiceOver not detecting misspelled words don't work in all cases
390         https://bugs.webkit.org/show_bug.cgi?id=118924
391
392         Reviewed by Tim Horton.
393
394         Make the misspelled detection dependent on both types of attributes being present.
395
396         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
397         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
398         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
399         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
400
401 2013-07-19  Alex Christensen  <achristensen@apple.com>
402
403         Improved code coverage generation.
404         https://bugs.webkit.org/show_bug.cgi?id=118926
405
406         Reviewed by Tim Horton.
407
408         * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
409         * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
410         (generateReport): Moved report generation to a subroutine.
411
412 2013-07-19  Stephanie Lewis  <slewis@apple.com>
413
414         <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
415
416         Unreviewed.
417
418         Rebaseline pagination test after http://trac.webkit.org/changeset/152911
419
420         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
421         (TestWebKitAPI::didLayout):
422
423 2013-07-19  Daniel Bates  <dabates@apple.com>
424
425         Make Perl tools work when using git bisect with Git branch build setup
426         https://bugs.webkit.org/show_bug.cgi?id=118512
427
428         Reviewed by Martin Robinson.
429
430         The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
431         during a git bisect session with a Git branch build setup (i.e. git config
432         core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
433         specific build of WebKit because they cannot determine the branch Git is on (since
434         git bisect puts Git into a detached HEAD state). We should teach our tooling to
435         parse the file .git/BISECT_START (created by git bisect start) for the name of the
436         branch Git was on when we began a git bisect session. Then the tools can determine
437         the path to the built WebKit.
438
439         * Scripts/VCSUtils.pm:
440         (gitDirectory): Added.
441         (gitBisectStartBranch): Added.
442         (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
443         HEAD (e.g. running git bisect).
444         (determineVCSRoot): Modified to call gitDirectory() to determine the path to
445         the .git directory in the Git checkout.
446
447 2013-07-19  Alex Christensen  <achristensen@apple.com>
448
449         Added x64 configuration to Visual Studio build.
450         https://bugs.webkit.org/show_bug.cgi?id=118888
451
452         Reviewed by Brent Fulgham.
453
454         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
455         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
456         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
457         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
458         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
459         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
460         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
461         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
462         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
463         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
464         * win/record-memory/record-memory.vcxproj:
465
466 2013-07-19  Martin Robinson  <mrobinson@igalia.com>
467
468         Add a couple people to the MathML watchlist
469         https://bugs.webkit.org/show_bug.cgi?id=118909
470
471         Reviewed by Andreas Kling.
472
473         Add a couple people to the MathML watchlist and add Kalyan's other
474         email address to fix style checker warnings about the watchlist
475         contents.
476
477         * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
478         list of contributors and add Kalyan's second email address.
479         * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
480         watchlist.
481
482 2013-07-19  Simon Pena  <simon.pena@samsung.com>
483
484         [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
485         https://bugs.webkit.org/show_bug.cgi?id=118895
486
487         Reviewed by Philippe Normand.
488
489         In r152782 an uri is used to create an string representation without checking first if it
490         is valid. That fails later when the string is used to check for existing redirections. This
491         patch ensures that the uri is valid before using it.
492
493         * DumpRenderTree/gtk/DumpRenderTree.cpp:
494         (willSendRequestCallback): Ensure an uri is valid before using it.
495
496 2013-07-18  Timothy Hatcher  <timothy@apple.com>
497
498         Add extract-localizable-js-strings and use it for WebInspectorUI.
499
500         https://bugs.webkit.org/show_bug.cgi?id=118851
501
502         Reviewed by Joseph Pecoraro.
503
504         * Scripts/extract-localizable-js-strings: Added.
505         * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
506         * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
507         the WebInspectorUI project.
508
509 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
510
511         [Windows] Build correction #2 after r152861.
512
513         * WinLauncher/WinLauncher.cpp: Declare proper linkage.
514
515 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
516
517         [Windows] Build correction after r152861.
518
519         * WinLauncher/WinLauncher.cpp: Don't reference private header.
520
521 2013-07-16  Brent Fulgham  <bfulgham@apple.com>
522
523         [Win] Support in-band text tracks.
524         https://bugs.webkit.org/show_bug.cgi?id=103770
525
526         Reviewed by Eric Carlson.
527
528         Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
529         libdispatch and CFRunLoop elements are services during the run loop.
530
531         * WinLauncher/WinLauncher.cpp:
532         (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
533         a CoreFoundation (or CFLite) support library.
534         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
535         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
536         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
537         and WinLauncherCFLite.props.
538
539 2013-07-18  Roger Fong  <roger_fong@apple.com>
540
541         Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
542
543         * Scripts/webkitpy/common/config/ews.json:
544
545 2013-07-18  Daniel Bates  <dabates@apple.com>
546
547         REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
548         https://bugs.webkit.org/show_bug.cgi?id=118854
549         <rdar://problem/14081339>
550
551         Reviewed by David Kilzer.
552
553         Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
554         Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
555         run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
556         listen on these ports so that we can run tests that use port 8443 and 8080.
557
558         * Scripts/old-run-webkit-tests:
559         (configureAndOpenHTTPDIfNeeded):
560
561 2013-07-17  Tim Horton  <timothy_horton@apple.com>
562
563         Update blocked/missing plug-in UI
564         https://bugs.webkit.org/show_bug.cgi?id=118347
565         <rdar://problem/14209318>
566
567         Reviewed by Sam Weinig.
568
569         * MiniBrowser/mac/WK2BrowserWindowController.m:
570         (-[WK2BrowserWindowController awakeFromNib]):
571         * WebKitTestRunner/TestController.cpp:
572         (WTR::TestController::createWebViewWithOptions):
573         Match new WKPageLoaderClient entry.
574
575 2013-07-17  Commit Queue  <commit-queue@webkit.org>
576
577         Unreviewed, rolling out r152701, r152703, r152739, r152754,
578         and r152756.
579         http://trac.webkit.org/changeset/152701
580         http://trac.webkit.org/changeset/152703
581         http://trac.webkit.org/changeset/152739
582         http://trac.webkit.org/changeset/152754
583         http://trac.webkit.org/changeset/152756
584         https://bugs.webkit.org/show_bug.cgi?id=118821
585
586         this was a buggy fix and we're going to try something
587         different (Requested by thorton on #webkit).
588
589         * MiniBrowser/mac/WK2BrowserWindowController.m:
590         (-[WK2BrowserWindowController awakeFromNib]):
591         * WebKitTestRunner/TestController.cpp:
592         (WTR::TestController::createWebViewWithOptions):
593
594 2013-07-17  Commit Queue  <commit-queue@webkit.org>
595
596         Unreviewed, rolling out r151535.
597         http://trac.webkit.org/changeset/151535
598         https://bugs.webkit.org/show_bug.cgi?id=118804
599
600         Re-disable WinEWS tests (Requested by rfong on #webkit).
601
602         * Scripts/webkitpy/common/config/ews.json:
603
604 2013-07-17  Simon Pena  <simon.pena@samsung.com>
605
606         [GTK] Make DRT obbey testRunner's addURLToRedirect
607         https://bugs.webkit.org/show_bug.cgi?id=118239
608
609         Reviewed by Gustavo Noronha Silva.
610
611         Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
612         to the proper URI when indicated.
613
614         * DumpRenderTree/gtk/DumpRenderTree.cpp:
615         (willSendRequestCallback):
616
617 2013-07-17  Gabor Abraham  <abrhm@inf.u-szeged.hu>
618
619         Add a new find-resolved-bugs command to webkit-patch.
620         https://bugs.webkit.org/show_bug.cgi?id=118060
621
622         Reviewed by Csaba Osztrogonác.
623
624         * Scripts/webkitpy/tool/commands/queries.py:
625         (PrintBaselines._platform_for_path):
626         (FindResolvedBugs):
627         (FindResolvedBugs.execute):
628
629 2013-07-16  Balazs Kelemen  <kbalazs@webkit.org>
630
631         [CMake] Undefined references should be detected at build time
632         https://bugs.webkit.org/show_bug.cgi?id=110236
633
634         Reviewed by Christophe Dumez.
635
636         Add library dependencies that were not defined explicitly before.
637
638         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
639         * TestWebKitAPI/CMakeLists.txt:
640         * WebKitTestRunner/CMakeLists.txt:
641
642 2013-07-16  Kwang Yul Seo  <skyul@company100.net>
643
644         check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
645         https://bugs.webkit.org/show_bug.cgi?id=118755
646
647         Reviewed by Ryosuke Niwa.
648
649         Fix r152719 to check "using namespace foo;" only in headers.
650
651         * Scripts/webkitpy/style/checkers/cpp.py:
652         (check_using_namespace):
653         (check_style):
654         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
655         (WebKitStyleTest.test_using_namespace):
656
657 2013-07-16  Christophe Dumez  <ch.dumez@sisa.samsung.com>
658
659         Get rid of multiple inheritance support from the bindings generators
660         https://bugs.webkit.org/show_bug.cgi?id=118353
661
662         Reviewed by Kentaro Hara.
663
664         Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
665         deprecated domInterface->parents.
666
667         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
668         (_parentInterface):
669
670 2013-07-16  Brian Holt  <brian.holt@samsung.com>
671
672         check-webkit-style: "using namespace foo;" should be flagged as an error in headers
673         https://bugs.webkit.org/show_bug.cgi?id=57241
674
675         Reviewed by Ryosuke Niwa.
676
677         Added check for "using namespace foo" and unit test.
678
679         * Scripts/webkitpy/style/checkers/cpp.py:
680         (check_using_namespace):
681         (check_style):
682         (CppChecker):
683         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
684         (WebKitStyleTest.test_using_namespace):
685
686 2013-07-16  Anton Obzhirov  <a.obzhirov@samsung.com>
687
688         [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
689         https://bugs.webkit.org/show_bug.cgi?id=110222
690
691         Reviewed by Gustavo Noronha Silva.
692
693         Added handling of zero mouse scroll deltas in EventSender.
694
695         * DumpRenderTree/gtk/EventSender.cpp:
696         (mouseScrollByCallback):
697
698 2013-07-16  Brian Holt  <brian.holt@samsung.com>
699
700         webkitpy: replace urllib with urllib2 for downloading additional modules
701         https://bugs.webkit.org/show_bug.cgi?id=118671
702
703         Reviewed by Ryosuke Niwa.
704
705         Urllib2 is available whereever urllib is, but has better proxy support.
706
707         * Scripts/webkitpy/common/system/autoinstall.py:
708         (AutoInstaller._download_to_stream):
709
710 2013-07-16  Krzysztof Czech  <k.czech@samsung.com>
711
712         [ATK] Adds support for aria-haspopup property.
713         https://bugs.webkit.org/show_bug.cgi?id=117834
714
715         Reviewed by Christophe Dumez.
716
717         Adds implementation for testing aria-haspopup property.
718
719         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
720         (getAttributeSetValueForId):
721         (AccessibilityUIElement::stringAttributeValue):
722         (AccessibilityUIElement::hasPopup):
723         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
724         (WTR::getAttributeSetValueForId):
725         (WTR::AccessibilityUIElement::stringAttributeValue):
726         (WTR::AccessibilityUIElement::hasPopup):
727
728 2013-07-16  Michael Brüning  <michael.bruning@digia.com>
729
730         [Qt] Replace Nokia references.
731         https://bugs.webkit.org/show_bug.cgi?id=118728
732
733         Reviewed by Simon Hausmann.
734
735         * MiniBrowser/qt/MiniBrowserApplication.cpp:
736         (MiniBrowserApplication::MiniBrowserApplication):
737         * QtTestBrowser/qttestbrowser.cpp:
738         (LauncherApplication::LauncherApplication):
739
740 2013-07-15  Tim Horton  <timothy_horton@apple.com>
741
742         Update blocked/missing plug-in UI
743         https://bugs.webkit.org/show_bug.cgi?id=118347
744         <rdar://problem/14209318>
745
746         Reviewed by Sam Weinig.
747
748         * MiniBrowser/mac/WK2BrowserWindowController.m:
749         (-[WK2BrowserWindowController awakeFromNib]):
750         * WebKitTestRunner/TestController.cpp:
751         (WTR::TestController::createWebViewWithOptions):
752         Match new WKPageLoaderClient entry.
753
754 2013-07-15  Chris Fleizach  <cfleizach@apple.com>
755
756         Update James Craig's email address.
757
758         * Scripts/webkitpy/common/config/contributors.json:
759
760 2013-07-15  Dong-Gwan Kim  <donggwan.kim@samsung.com>
761
762         [EFL] Add fallback for TestWebKitAPI if opengl is not available.
763         https://bugs.webkit.org/show_bug.cgi?id=118583
764
765         Reviewed by Christophe Dumez.
766
767         There're many fails on efl webkit2 API test if opengl is not available.
768         So, add fallback to non-opengl evas engine.
769
770         * TestWebKitAPI/efl/PlatformWebView.cpp:
771         (TestWebKitAPI::initEcoreEvas):
772
773 2013-07-15  Brian Holt  <brian.holt@samsung.com>
774
775         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
776         https://bugs.webkit.org/show_bug.cgi?id=118592
777
778         Reviewed by Martin Robinson.
779
780         Added a suppression for pylint false positives and a unit test.
781
782         * Scripts/webkitpy/style/checkers/python.py:
783         (Pylinter):
784         * Scripts/webkitpy/style/checkers/python_unittest.py:
785         (PythonCheckerTest.test_check):
786         (PythonCheckerTest):
787         (PythonCheckerTest.test_pylint_false_positives):
788         (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
789         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
790         (test_popen):
791
792 2013-07-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
793
794         [GTK] Increase the JHBuild version of GStreamer to 1.0.7
795         https://bugs.webkit.org/show_bug.cgi?id=115166
796
797         Reviewed by Philippe Normand.
798
799         * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
800
801 2013-07-12  Kwang Yul Seo  <skyul@company100.net>
802
803         Unreviewed. Add an email address and update my domain of experts.
804
805         * Scripts/webkitpy/common/config/contributors.json:
806
807 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
808
809         [jhbuild] Avoid restarting from scratch failed initial checkouts
810         https://bugs.webkit.org/show_bug.cgi?id=118603
811
812         Reviewed by Martin Robinson.
813
814         If the initial checkout is interrupted midway (eg. because the internet
815         connection went down) config files do not get generated and that causes
816         the next checkout to start from scratch (the missing files cause the
817         script to delete the build root and the downloaded sources).
818
819         By generating the files before invoking jhbuild, subsequent runs are able
820         to start where the previous run left.
821
822         * Scripts/update-webkit-libs-jhbuild:
823         (saveJhbuildMd5): invoke it before runJhbuild().
824
825 2013-07-12  Brent Fulgham  <bfulgham@apple.com>
826
827         [Windows] Remove single-worker restriction on tests.
828
829         * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
830
831 2013-07-12  Commit Queue  <commit-queue@webkit.org>
832
833         Unreviewed, rolling out r152599.
834         http://trac.webkit.org/changeset/152599
835         https://bugs.webkit.org/show_bug.cgi?id=118612
836
837         This patch includes a failing unit test (Requested by
838         mrobinson on #webkit).
839
840         * Scripts/webkitpy/style/checkers/python.py:
841         (Pylinter):
842         * Scripts/webkitpy/style/checkers/python_unittest.py:
843         (PythonCheckerTest.test_check):
844         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
845
846 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
847
848         [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
849         https://bugs.webkit.org/show_bug.cgi?id=91223
850
851         Reviewed by Martin Robinson.
852
853         When run on a clean checkout, `build-webkit` complains that no
854         GNUmakefile exists when trying to detect the previously configured
855         architecture, but in this case there's no previous configuration so
856         the warning is pointless.
857
858         * Scripts/webkitdirs.pm:
859         (determineArchitecture): Redirect grep stderr to /dev/null.
860
861 2013-07-12  Brian Holt  <brian.holt@samsung.com>
862
863         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
864         https://bugs.webkit.org/show_bug.cgi?id=118592
865
866         Reviewed by Martin Robinson.
867
868         Added a suppression for pylint false positives and a unit test.
869
870         * Scripts/webkitpy/style/checkers/python.py:
871         (Pylinter):
872         * Scripts/webkitpy/style/checkers/python_unittest.py:
873         (PythonCheckerTest.test_check):
874         (PythonCheckerTest):
875         (PythonCheckerTest.test_pylint_false_positives):
876         (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
877         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
878         (test_popen):
879
880 2013-07-11  Arnaud Renevier  <a.renevier@samsung.com>
881
882         Unreviewed. Add myself as a committer.
883
884         * Scripts/webkitpy/common/config/contributors.json:
885
886 2013-07-10  Sergio Correia  <sergio.correia@openbossa.org>
887
888         Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
889         https://bugs.webkit.org/show_bug.cgi?id=118538
890
891         Reviewed by Christophe Dumez.
892
893         When attempting some odd url such as ``foo'', MiniBrowser will now show an
894         error message such as "Cannot resolve hostname (foo)".
895
896         Previously, it had the following behavior if MiniBrowser was started with
897         such urls, e.g ``./MiniBrowser foo'':
898
899         - Debug:
900         It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
901
902         - Release:
903         No asserts, naturally, but the view would remain blank, even if we tried to
904         change to a valid url.
905
906         * MiniBrowser/efl/main.c:
907         (window_create):
908
909 2013-07-10  Simon Pena  <simon.pena@samsung.com>
910
911         [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
912         https://bugs.webkit.org/show_bug.cgi?id=118509
913
914         Reviewed by Martin Robinson.
915
916         In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
917         when trying to remove an event already removed, if another event is
918         processed in the middle. By using a Deque's takeFirst, we ensure the
919         element is removed before we dispatch it.
920
921         fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
922         crashes after this fix is added.
923
924         * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
925         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
926         (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
927         from the queue.
928
929 2013-07-09  Ryuan Choi  <ryuan.choi@samsung.com>
930
931         [EFL] Add ewk_view_device_pixel_ratio_set
932         https://bugs.webkit.org/show_bug.cgi?id=118521
933
934         Reviewed by Gyuyoung Kim.
935
936         * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
937         (windowCreate):
938         (parseUserArguments):
939
940 2013-07-09  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
941
942         Unreviewed change of my email addresses.
943         https://bugs.webkit.org/show_bug.cgi?id=100122
944
945         * Scripts/webkitpy/common/config/contributors.json:
946
947 2013-07-09  Anders Carlsson  <andersca@apple.com>
948
949         DumpRenderTree should stop sending unsupported URLs to NSWorkspace
950         https://bugs.webkit.org/show_bug.cgi?id=118514
951         <rdar://problem/13686836>
952
953         Reviewed by Sam Weinig.
954
955         Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
956
957         * DumpRenderTree/DefaultPolicyDelegate.h: Added.
958         * DumpRenderTree/DefaultPolicyDelegate.m: Added.
959         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
960         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
961         Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
962
963         * DumpRenderTree/mac/DumpRenderTree.mm:
964         (allocateGlobalControllers):
965         Allocate a DefaultPolicyDelegate object.
966
967         (resetWebViewToConsistentStateBeforeTesting):
968         Set the policy delegate to the default policy delegate.
969
970         * DumpRenderTree/mac/DumpRenderTreeMac.h:
971         Declare the defaultPolicyDelegate object.
972
973         * DumpRenderTree/mac/TestRunnerMac.mm:
974         (TestRunner::setCustomPolicyDelegate):
975         Set the policy delegate to the default delegate if setDelegate is false.
976
977 2013-07-08  Zan Dobersek  <zdobersek@igalia.com>
978
979         KURL unit test fixture class should have a meaningful name
980         https://bugs.webkit.org/show_bug.cgi?id=118467
981
982         Reviewed by Sam Weinig.
983
984         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
985         (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
986         instead of the generic and inappropriate 'WebCore' name.
987
988 2013-07-08  Antti Koivisto  <antti@apple.com>
989
990         Add Deque::removeLast
991         https://bugs.webkit.org/show_bug.cgi?id=118466
992
993         Reviewed by Andreas Kling.
994
995         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
996         * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
997         (TestWebKitAPI::TEST):
998
999 2013-07-08  Brian Holt  <brian.holt@samsung.com>
1000
1001         [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
1002         https://bugs.webkit.org/show_bug.cgi?id=118412
1003
1004         Reviewed by Martin Robinson.
1005
1006         An adoptRef is required to balance ref and deref calls.
1007
1008         * DumpRenderTree/gtk/EventSender.cpp:
1009         (beginDragWithFilesCallback):
1010
1011 2013-07-06  Sergio Correia  <sergio.correia@openbossa.org>
1012
1013         Update list of EFL WK2 API tests
1014         https://bugs.webkit.org/show_bug.cgi?id=118443
1015
1016         Reviewed by Christophe Dumez.
1017
1018         The following tests were included:
1019
1020         Passing:
1021         - CloseThenTerminate
1022         - DidAssociateFormControls
1023         - PageVisibilityState
1024         - ResponsivenessTimerDoesntFireEarly
1025         - TerminateTwice
1026         - WillLoad
1027
1028         Failing:
1029         - ResizeReversePaginatedWebView
1030         - ScrollPinningBehaviors
1031
1032         This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
1033         alphabetical order.
1034
1035         * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
1036         * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
1037
1038 2013-07-05  Tim Horton  <timothy_horton@apple.com>
1039
1040         Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
1041         https://bugs.webkit.org/show_bug.cgi?id=118439
1042         <rdar://problem/14366120>
1043
1044         Reviewed by Anders Carlsson.
1045
1046         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1047         (TestWebKitAPI::didLayout):
1048         (TestWebKitAPI::TEST):
1049         - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
1050         - Assert that we got the right number of pages for sanity.
1051         - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
1052             so much memory that SharedMemory asserts and makes the test time out.
1053         - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
1054             because paint doesn't fire if the window is offscreen.
1055
1056 2013-07-05  Tim Horton  <timothy_horton@apple.com>
1057
1058         [wk2] Add API to lock the scroll position at the top or bottom of the page
1059         https://bugs.webkit.org/show_bug.cgi?id=118429
1060         <rdar://problem/14120323>
1061
1062         Reviewed by Anders Carlsson.
1063
1064         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1065         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
1066         (TestWebKitAPI::didFinishDocumentLoadForFrame):
1067         (TestWebKitAPI::TEST):
1068         Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
1069         all work correctly in the face of resizing the view and scrolling from JS.
1070
1071 2013-07-05  Michael Pruett  <michael@68k.org>
1072
1073         Unreviewed. Add myself as a committer.
1074
1075         * Scripts/webkitpy/common/config/contributors.json:
1076
1077 2013-07-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1078
1079         [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
1080         https://bugs.webkit.org/show_bug.cgi?id=111434
1081
1082         Reviewed by Carlos Garcia Campos.
1083
1084         * Scripts/run-gtk-tests:
1085         (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
1086
1087 2013-07-04  Viatcheslav Ostapenko  <sl.ostapenko@samsung.com>
1088
1089         [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
1090         https://bugs.webkit.org/show_bug.cgi?id=118370
1091
1092         Reviewed by Christophe Dumez.
1093
1094         Add fallback to software X11 engine if opengl_x11 engine creation fails.
1095
1096         * DumpRenderTree/efl/DumpRenderTree.cpp:
1097         (initEcoreEvas):
1098
1099 2013-07-04  Brian Holt  <brian.holt@samsung.com>
1100
1101         [ATK] Leak: AtkAttributeSet* should be freed
1102         https://bugs.webkit.org/show_bug.cgi?id=118307
1103
1104         Reviewed by Christophe Dumez.
1105
1106         Fixed memory leaks for AtkAttributeSet by calling
1107         atk_attribute_set_free().
1108
1109         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1110         (AccessibilityController::childElementById):
1111         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1112         (getAtkAttributeSetAsString):
1113         (AccessibilityUIElement::allAttributes):
1114         (AccessibilityUIElement::stringAttributeValue):
1115         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1116         (WTR::childElementById):
1117         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1118         (WTR::getAtkAttributeSetAsString):
1119         (WTR::AccessibilityUIElement::allAttributes):
1120         (WTR::AccessibilityUIElement::stringAttributeValue):
1121
1122 2013-07-03  David Farler  <dfarler@apple.com>
1123
1124         Add Makefile to WebKitLauncher
1125         https://bugs.webkit.org/show_bug.cgi?id=118365
1126
1127         Reviewed by Mark Rowe.
1128
1129         * WebKitLauncher/Makefile: Added.
1130
1131 2013-07-03  Brian Holt  <brian.holt@samsung.com>
1132
1133         [ATK] Leak: more leaks in AccessibilityUIElement
1134         https://bugs.webkit.org/show_bug.cgi?id=118362
1135
1136         Reviewed by Christophe Dumez.
1137
1138         Free the memory created by g_strdup_printf.
1139
1140         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1141         (AccessibilityUIElement::language):
1142         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1143         (WTR::AccessibilityUIElement::language):
1144
1145 2013-07-03  Jer Noble  <jer.noble@apple.com>
1146
1147         Xcode often gets in a state where the debugger is completely unresponsive
1148         https://bugs.webkit.org/show_bug.cgi?id=118157
1149
1150         The GetPointeeData() operations we use to retrieve strings is extremely expensive.
1151         Rather than pull the character data out of the debugger one byte at a time
1152         through the GetPointeeData() API, retrieve the memory contents of the string through
1153         the ReadMemory() API, and convert the retrieved memory into a python string.
1154
1155         Reviewed by Anders Carlsson.
1156
1157         * lldb/lldb_webkit.py:
1158         (__lldb_init_module.lldb_webkit):
1159         (guess_string_length):
1160         (ustring_to_string):
1161         (lstring_to_string):
1162
1163 2013-07-03  Morten Stenshorne  <mstensho@opera.com>
1164
1165         [GTK] Let F5 refresh the page in MiniBrowser
1166         https://bugs.webkit.org/show_bug.cgi?id=117638
1167
1168         Reviewed by Carlos Garcia Campos.
1169
1170         Also use the correct icon for the refresh button that was already there.
1171
1172         * MiniBrowser/gtk/BrowserWindow.c:
1173         (browser_window_init):
1174
1175 2013-07-02  Kondapally Kalyan  <kalyan.kondapally@intel.com>
1176
1177         Unreviewed. Add my email to a few watchlists.
1178
1179         * Scripts/webkitpy/common/config/watchlist:
1180
1181 2013-07-02  David Farler  <dfarler@apple.com>
1182
1183         Unreviewed. Adding myself to contributors.json.
1184
1185         * Scripts/webkitpy/common/config/contributors.json:
1186
1187 2013-07-02  Brian Holt  <brian.holt@samsung.com>
1188
1189         [ATK] Leak: leaks in AccessibilityUIElement
1190         https://bugs.webkit.org/show_bug.cgi?id=118297
1191
1192         Fixed memory leak.
1193
1194         Reviewed by Christophe Dumez.
1195
1196         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1197         (AccessibilityUIElement::stringValue):
1198
1199 2013-07-02  Byungwoo Lee  <bw80.lee@samsung.com>
1200
1201         Fix WebKitTestRunner crashes.
1202         https://bugs.webkit.org/show_bug.cgi?id=117630
1203
1204         Reviewed by Darin Adler.
1205
1206         Create static function to dump for WebProcess unresponsiveness status,
1207         and use it before calling TestController::runTest().
1208
1209         Accessing TestController::m_currentInvocation before calling
1210         TestController::runTest() can make crash because the invocation
1211         instance will be assigned at the function.
1212
1213         * WebKitTestRunner/TestController.cpp:
1214         (WTR::TestController::run):
1215         * WebKitTestRunner/TestInvocation.cpp:
1216         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
1217         * WebKitTestRunner/TestInvocation.h:
1218
1219 2013-07-02  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1220
1221         [Qt][WK1] Support WebGL with EGL on Linux
1222         https://bugs.webkit.org/show_bug.cgi?id=118251
1223
1224         Reviewed by Kenneth Rohde Christiansen.
1225
1226         * qmake/mkspecs/features/features.prf:
1227
1228 2013-07-01  Nick Diego Yamane  <nick.yamane@openbossa.org>
1229
1230         [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
1231         https://bugs.webkit.org/show_bug.cgi?id=118267
1232
1233         Reviewed by Gyuyoung Kim.
1234
1235         After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
1236         WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
1237         Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
1238
1239         * efl/jhbuildrc:
1240         * gtk/jhbuildrc:
1241
1242 2013-07-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1243
1244         [GTK] Remove unsupported AC backends
1245         https://bugs.webkit.org/show_bug.cgi?id=117362
1246
1247         Reviewed by Martin Robinson.
1248
1249         * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
1250         and cogl, so removed.
1251
1252 2013-07-01  Timothy Hatcher  <timothy@apple.com>
1253
1254         Link to WebInspectorUI.framework at build time instead of soft linking.
1255
1256         https://bugs.webkit.org/show_bug.cgi?id=118261
1257
1258         Reviewed by Joseph Pecoraro.
1259
1260         * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
1261
1262 2013-07-01  Tim Horton  <timothy_horton@apple.com>
1263
1264         Maximum scroll position can be negative in some cases
1265         https://bugs.webkit.org/show_bug.cgi?id=118175
1266         <rdar://problem/14301217>
1267
1268         Reviewed by Anders Carlsson.
1269
1270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1271         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
1272         (TestWebKitAPI::didRunJavaScript):
1273         (TestWebKitAPI::didLayout):
1274         (TestWebKitAPI::TEST):
1275         * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
1276         Add a test that loads a vertical-lr document, paginates it horizontally
1277         from right to left, resizes the view to fit the entire document, and
1278         verifies that the scroll position is negative, as it must be for the
1279         document to be enclosed by the view.
1280
1281 2013-07-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1282
1283         [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
1284         https://bugs.webkit.org/show_bug.cgi?id=117249
1285
1286         Reviewed by Brent Fulgham.
1287
1288         Finish converting all use cases of WEBKITOUTPUTDIR to
1289         WEBKIT_OUTPUTDIR, which seems to be preferred these days.
1290
1291         * DumpRenderTree/efl/FontManagement.cpp:
1292         (getCustomBuildDir):
1293         (getPlatformFontsPath):
1294         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1295         (getOutputDir):
1296         * Scripts/webkitdirs.pm:
1297         (determineBaseProductDir):
1298         (usesPerConfigurationBuildDirectory):
1299         * Scripts/webkitpy/port/base.py:
1300         (Port.to.setup_environ_for_server):
1301         * Scripts/webkitpy/port/driver.py:
1302         (Driver._setup_environ_for_driver):
1303         * Scripts/webkitpy/port/gtk.py:
1304         (GtkPort.setup_environ_for_server):
1305         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1306         (WTR::getOutputDir):
1307         * jhbuild/jhbuildutils.py:
1308         (get_dependencies_path):
1309
1310 2013-07-01  Rafael Brandao  <rafael.lobo@webkit.org>
1311
1312         Unreviewed change of my email address.
1313
1314         * Scripts/webkitpy/common/config/contributors.json:
1315
1316 2013-06-28  Andreas Kling  <akling@apple.com>
1317
1318         Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
1319
1320         * DumpRenderTree/win/DumpRenderTree.cpp:
1321         (addFontFallbackIfPresent):
1322         (removeFontFallbackIfPresent):
1323
1324 2013-06-28  Anders Carlsson  <andersca@apple.com>
1325
1326         Remove String::deprecatedCharactersWithNullTermination() and related code
1327         https://bugs.webkit.org/show_bug.cgi?id=118211
1328
1329         Reviewed by Benjamin Poulain.
1330
1331         Remove all hasTerminatingNullCharacter() checks.
1332
1333         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1334         (TestWebKitAPI::TEST):
1335         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1336         (TestWebKitAPI::TEST):
1337         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1338         (TestWebKitAPI::TEST):
1339
1340 2013-06-28  Alexey Proskuryakov  <ap@apple.com>
1341
1342         [Mac] Crash when loading is stopped from -didReceiveResponse
1343         https://bugs.webkit.org/show_bug.cgi?id=118209
1344         <rdar://problem/14259249>
1345
1346         Reviewed by Brady Eidson.
1347
1348         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1349         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
1350         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
1351         (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
1352         (TestWebKitAPI::TEST):
1353
1354 2013-06-28  Andy Estes  <aestes@apple.com>
1355
1356         [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
1357         https://bugs.webkit.org/show_bug.cgi?id=118208
1358
1359         Reviewed by Mark Rowe.
1360
1361         Newer versions of clang use a default template depth of 128, but this
1362         is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
1363         previous default.
1364
1365         Clang lowered the default to keep recursive template instantiation
1366         from overflowing the stack (see <rdar://problem/13935016>), but
1367         TestWebKitAPI's C++ files don't trigger a stack overflow even with the
1368         higher limit. If for some reason this starts happening then we can
1369         lower the limit back down.
1370
1371         * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
1372
1373 2013-06-28  Nick Diego Yamane  <nick.yamane@openbossa.org>
1374
1375         [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
1376         https://bugs.webkit.org/show_bug.cgi?id=118195
1377
1378         Reviewed by Daniel Bates.
1379
1380         Currently, ports that use jhbuild fail to determine jhbuild directory
1381         when "webKitBranchBuild" git configuration property is enabled. To reproduce
1382         that issue in Efl port, enable that flag in .git/config, switch to a git branch
1383         other than "master" and try to build webkit. The build will fail to
1384         locate dependencies due to lack of pkg-config paths which should be set
1385         by jhbuild.
1386
1387         For more details about "webKitBranchBuild" option, see:
1388         https://trac.webkit.org/wiki/UsingGitWithWebKit
1389
1390         * Scripts/webkitdirs.pm:
1391         (getJhbuildPath):
1392
1393 2013-06-28  Jessie Berlin  <jberlin@apple.com>
1394
1395         WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
1396         https://bugs.webkit.org/show_bug.cgi?id=118201
1397
1398         Reviewed by Dean Jackson.
1399
1400         * WebKitTestRunner/mac/main.mm:
1401         (main):
1402         Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
1403         setAutomaticDashSubstitutionEnabled are not exposed on WKView.
1404
1405 2013-06-28  David Farler  <dfarler@apple.com>
1406
1407         Upstream WebKit Nightly’s WebKitLauncher
1408         https://bugs.webkit.org/show_bug.cgi?id=117418
1409
1410         Reviewed by Mark Rowe.
1411
1412         Literal patch from Nightly's OpenSource repo.
1413
1414         * WebKitLauncher/Configurations/Base.xcconfig:
1415         * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
1416         * WebKitLauncher/Info.plist:
1417         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1418         * WebKitLauncher/WebKitLauncherURLProtocol.m:
1419         (+[WebKitLauncherURLProtocol load]):
1420         (+[WebKitLauncherURLProtocol canInitWithRequest:]):
1421         (-[WebKitLauncherURLProtocol startLoading]):
1422         (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
1423         (-[WebKitLauncherURLProtocol resourceNotFound]):
1424         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
1425         (initializeSparkle):
1426         * WebKitLauncher/main.m:
1427         (determineExecutablePath):
1428         (currentMacOSXVersion):
1429         (main):
1430         * WebKitLauncher/start.html:
1431
1432 2013-06-28  Balazs Kelemen  <b.kelemen@samsung.com>
1433
1434         [EFL] back/forward keyboard shortcuts are non-intuitive
1435         https://bugs.webkit.org/show_bug.cgi?id=118193
1436
1437         Reviewed by Christophe Dumez.
1438
1439         Changed shortcuts for go-back/go-forward to alt+left and alt+right.
1440
1441         * EWebLauncher/main.c:
1442         (on_key_down):
1443         * MiniBrowser/efl/main.c:
1444         (on_key_down):
1445
1446 2013-06-28  Roger Fong  <roger_fong@apple.com>
1447
1448         Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
1449         https://bugs.webkit.org/show_bug.cgi?id=118194.
1450
1451         Reviewed by Brent Fulgham.
1452
1453         * DumpRenderTree/win/DumpRenderTree.cpp:
1454         (dllLauncherEntryPoint):
1455         * WinLauncher/WinLauncher.cpp:
1456         (dllLauncherEntryPoint):
1457
1458 2013-06-28  Roger Fong  <roger_fong@apple.com>
1459
1460         Unreviewed build fix for AppleWin port. Fix some file paths.
1461
1462         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1463         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1464
1465 2013-06-27  Roger Fong  <roger_fong@apple.com>
1466
1467         Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
1468         https://bugs.webkit.org/show_bug.cgi?id=118160.
1469
1470         Reviewed by Brent Fulgham.
1471
1472         * WinLauncher/AccessibilityDelegate.cpp: Added.
1473         (AccessibilityDelegate::QueryInterface):
1474         (AccessibilityDelegate::AddRef):
1475         (AccessibilityDelegate::Release):
1476         (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
1477         (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
1478         * WinLauncher/AccessibilityDelegate.h: Added.
1479         (AccessibilityDelegate::AccessibilityDelegate):
1480         * WinLauncher/WinLauncher.cpp:
1481         (dllLauncherEntryPoint):
1482         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1483         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1484
1485 2013-06-28  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1486
1487         Clean up temporary files created by the bindings test script
1488         https://bugs.webkit.org/show_bug.cgi?id=118189
1489
1490         Reviewed by Kentaro Hara.
1491
1492         Remove temporary files created by preprocess-idls.pl script after
1493         the bindings tests are executed.
1494
1495         Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
1496
1497         * Scripts/webkitpy/bindings/main.py:
1498         (BindingsTests.main):
1499
1500 2013-06-26  Dean Jackson  <dino@apple.com>
1501
1502         [Mac] Add Mavericks system font to Test systems
1503         https://bugs.webkit.org/show_bug.cgi?id=118109
1504
1505         Reviewed by Simon Fraser.
1506
1507         OS X Mavericks uses a different font for system controls. Tell DRT and
1508         WKTR about them otherwise they use a fallback font. Unfortunately the
1509         fonts are hidden (not found in the list of available fonts) so I
1510         had to add them manually.
1511
1512         Even though there is only one at the moment, I implemented this
1513         as a set so it will be easier to add new fonts if necessary.
1514
1515         * DumpRenderTree/mac/DumpRenderTree.mm:
1516         (allowedFontFamilySet): Fixed typo.
1517         (systemHiddenFontFamilySet): New method that returns the system control font.
1518         (drt_NSFontManager_availableFonts): Merge the hidden fonts.
1519         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1520         (WTR::allowedFontFamilySet): Fixed typo.
1521         (WTR::systemHiddenFontFamilySet): As above.
1522         (WTR::wtr_NSFontManager_availableFonts):
1523
1524 2013-06-27  Anders Carlsson  <andersca@apple.com>
1525
1526         Get rid of the last uses of deprecatedCharactersWithNullTermination()
1527         https://bugs.webkit.org/show_bug.cgi?id=118159
1528
1529         Reviewed by Andreas Kling.
1530
1531         Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
1532
1533         * DumpRenderTree/win/DumpRenderTree.cpp:
1534         (findFontFallback):
1535
1536 2013-06-27  Bem Jones-Bey  <bjonesbe@adobe.com>
1537
1538         Sync up w3c import script with changes in Blink
1539         https://bugs.webkit.org/show_bug.cgi?id=118149
1540
1541         Reviewed by Dirk Pranke.
1542
1543         This is a port of the following blink changes:
1544
1545         https://codereview.chromium.org/15366004
1546         https://chromiumcodereview.appspot.com/15592005
1547         https://codereview.chromium.org/16021006
1548         https://codereview.chromium.org/15590004
1549         https://codereview.chromium.org/15901008
1550         https://codereview.chromium.org/16171009
1551         https://codereview.chromium.org/16465007
1552         https://codereview.chromium.org/15981013
1553
1554         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1555         (setUp):
1556         (test_commit_message_for_this_commit):
1557         * Scripts/webkitpy/port/base.py:
1558         (Port):
1559         * Scripts/webkitpy/port/test.py:
1560         * Scripts/webkitpy/w3c/test_converter.py:
1561         (W3CTestConverter.__init__):
1562         (W3CTestConverter.read_webkit_prefixed_css_property_list):
1563         (W3CTestConverter.convert_for_webkit):
1564         (W3CTestConverter.convert_css):
1565         (W3CTestConverter.convert_html):
1566         (W3CTestConverter.convert_testharness_paths):
1567         (W3CTestConverter.convert_prefixed_properties):
1568         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
1569         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1570         * Scripts/webkitpy/w3c/test_importer.py:
1571         (main):
1572         (configure_logging):
1573         (configure_logging.LogHandler):
1574         (configure_logging.LogHandler.format):
1575         (parse_args):
1576         (TestImporter.__init__):
1577         (TestImporter.find_importable_tests):
1578         (TestImporter.import_tests):
1579         (TestImporter.setup_destination_directory):
1580         (TestImporter.remove_deleted_files):
1581         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1582         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
1583         (TestImporterTest.test_import_dir_with_no_tests):
1584         (TestImporterTest):
1585         * Scripts/webkitpy/w3c/test_parser.py:
1586         (TestParser.load_file):
1587         (TestParser.analyze_test):
1588         (TestParser.support_files):
1589         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1590
1591 2013-06-27  Csaba Osztrogonác  <ossy@webkit.org>
1592
1593         [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
1594         https://bugs.webkit.org/show_bug.cgi?id=118128
1595
1596         Reviewed by Ryosuke Niwa.
1597
1598         It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
1599         https://bugs.webkit.org/show_bug.cgi?id=117831
1600
1601         * Scripts/webkitpy/tool/commands/download.py:
1602         (AbstractPatchSequencingCommand):
1603         (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
1604         (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
1605         (AbstractPatchSequencingCommand._prepare_state): Added.
1606
1607 2013-06-27  Brendan Long  <b.long@cablelabs.com>
1608
1609         [Qt] Build overrides -j when given --makeargs="-sj40"
1610         https://bugs.webkit.org/show_bug.cgi?id=116897
1611
1612         Reviewed by Csaba Osztrogonác.
1613
1614         * Scripts/webkitdirs.pm:
1615         (buildQMakeProjects):
1616         Change regex checking for -j* to also check for -*j*
1617
1618 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1619
1620         Remove [NoInterfaceObject] from WorkerGlobalScope
1621         https://bugs.webkit.org/show_bug.cgi?id=118071
1622
1623         Reviewed by Kentaro Hara.
1624
1625         Update bindings test script to pass 2 additional parameters
1626         now needed by the preprocess-idls.pl script.
1627
1628         * Scripts/webkitpy/bindings/main.py:
1629         (BindingsTests.generate_supplemental_dependency):
1630         (BindingsTests.main):
1631
1632 2013-06-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1633
1634         Fixing some compiler warnings
1635         https://bugs.webkit.org/show_bug.cgi?id=117791
1636
1637         Reviewed by Martin Robinson.
1638
1639         * GNUmakefile.am: Silenced format warning.
1640         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1641         (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
1642         Solved warning about uninitialized variable.
1643
1644 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1645
1646         Fix bindings tests after r152080
1647         https://bugs.webkit.org/show_bug.cgi?id=118118
1648
1649         Reviewed by Gyuyoung Kim.
1650
1651         r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
1652         to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
1653         accordingly.
1654
1655         * Scripts/webkitpy/bindings/main.py:
1656         (BindingsTests.generate_supplemental_dependency):
1657         (BindingsTests.main):
1658
1659 2013-06-26  Carlos Garcia Campos  <cargarcia@blackberry.com>
1660
1661         [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
1662         https://bugs.webkit.org/show_bug.cgi?id=117982
1663
1664         Reviewed by Rob Buis.
1665
1666         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1667         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
1668         m_policyDelegateIsPermissive.
1669         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1670         Reset m_policyDelegateIsPermissive.
1671         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
1672         m_policyDelegateIsPermissive.
1673         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1674         (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
1675         Return whether custom policy is enabled.
1676         (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
1677         Return whether custom policy is permissive.
1678
1679 2013-06-26  Anders Carlsson  <andersca@apple.com>
1680
1681         Deprecate StringImpl::charactersWithNullTermination
1682         https://bugs.webkit.org/show_bug.cgi?id=118108
1683
1684         Reviewed by Beth Dakin.
1685
1686         Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
1687
1688         * DumpRenderTree/win/DumpRenderTree.cpp:
1689         (findFontFallback):
1690         (addFontFallbackIfPresent):
1691         (removeFontFallbackIfPresent):
1692
1693 2013-06-26  Nico Weber  <thakis@chromium.org>
1694
1695         Remove detect-mismached-virtual-const.
1696         https://bugs.webkit.org/show_bug.cgi?id=117999
1697
1698         Reviewed by Anders Carlsson.
1699
1700         Clang warns on mismatched virtual const, so there's no need for this
1701         script any more.
1702
1703         * Scripts/detect-mismatched-virtual-const: Removed.
1704
1705 2013-06-26  Alex Christensen  <achristensen@apple.com>
1706
1707         Added a code coverage report.
1708         https://bugs.webkit.org/show_bug.cgi?id=117941
1709
1710         Reviewed by Joseph Pecoraro.
1711
1712         * CodeCoverage: Added.
1713         * CodeCoverage/results-template.html: Added.
1714         * Scripts/generate-coverage-data: Generate and open the new report.
1715
1716 2013-06-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1717
1718         gdb: Remove the webcore.py pretty printer.
1719         https://bugs.webkit.org/show_bug.cgi?id=117992
1720
1721         Reviewed by Jochen Eisinger.
1722
1723         webcore.py has been only a placeholder for backwards compatibility
1724         for almost 3 years. It should be safe enough to remove it now.
1725
1726         * gdb/webcore.py: Removed.
1727
1728 2013-05-26  Peter Gal  <galpeter@inf.u-szeged.hu>
1729
1730         Creating cURL watchlist and adding myself to it.
1731
1732         Reviewed by Csaba Osztrogonác.
1733
1734         * Scripts/webkitpy/common/config/watchlist:
1735
1736 2013-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1737
1738         Unreviewed, change my email address for watch list.
1739
1740         * Scripts/webkitpy/common/config/watchlist:
1741
1742 2013-06-25  Byungwoo Lee  <bw80.lee@samsung.com>
1743
1744         [EFL] Add a script to install dependencies.
1745         https://bugs.webkit.org/show_bug.cgi?id=117968
1746
1747         Reviewed by Christophe Dumez.
1748
1749         Add a script which installs basic dependencies for building WebKit EFL.
1750
1751         The dependencies are from the current EFLWebKit wiki page.
1752         After this patch is landed, the wiki page will be updated to use
1753         this script.
1754
1755         * efl/install-dependencies: Added.
1756
1757 2013-06-24  Dean Jackson  <dino@apple.com>
1758
1759         [Mac] Update font used for Chinese in test systems
1760         https://bugs.webkit.org/show_bug.cgi?id=117970
1761
1762         Reviewed by Alexey Proskuryakov.
1763
1764         Add "Songti TC" and "Songti SC" to the list of allowed fonts
1765         in DRT and WKTR.
1766
1767         * DumpRenderTree/mac/DumpRenderTree.mm:
1768         (allowedFontFamilySet):
1769         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1770         (WTR::allowedFontFamilySet):
1771
1772 2013-06-24  Tim Horton  <timothy_horton@apple.com>
1773
1774         Make MiniBrowser paginated mode work with WebKit1
1775         https://bugs.webkit.org/show_bug.cgi?id=117950
1776
1777         Reviewed by Beth Dakin.
1778
1779         * MiniBrowser/mac/WK1BrowserWindowController.m:
1780         (-[WK1BrowserWindowController isPaginated]):
1781         (-[WK1BrowserWindowController togglePaginationMode:]):
1782         Hook up isPaginated and togglePaginationMode just as for WebKit2.
1783
1784 2013-06-24  David Kilzer  <ddkilzer@apple.com>
1785
1786         bisect-builds: improve heuristic for choosing the next build after a broken build
1787         <http://webkit.org/b/117918>
1788
1789         Reviewed by Simon Fraser.
1790
1791         * Scripts/bisect-builds: When a build is broken, use a heuristic
1792         that "bisects" the left side or the right side of the remaining
1793         revisions to pick a revision that's sufficiently different from
1794         the revision of the broken build.  This heuristic assumes there
1795         is a sequential range of broken builds whenever one broken build
1796         is found.
1797
1798 2013-06-24  Chris Rogers  <crogers@google.com>
1799
1800         WaveTable name has changed to PeriodicWave
1801         https://bugs.webkit.org/show_bug.cgi?id=117748
1802
1803         Reviewed by Jer Noble.
1804
1805         * Scripts/do-webcore-rename:
1806
1807 2013-06-22  Santosh Mahto  <santosh.ma@samsung.com>
1808
1809         [EFL] Add support for MHTML save/load feature to MiniBrowser
1810         https://bugs.webkit.org/show_bug.cgi?id=106620
1811
1812         Reviewed by Christophe Dumez.
1813
1814         Enable CTRL + S as save page in mhtml and CTRL + L to load any page
1815         from filesystem.
1816
1817         * MiniBrowser/efl/CMakeLists.txt:
1818         * MiniBrowser/efl/main.c:
1819         (page_contents_callback):
1820         (on_key_down):
1821         (show_file_entry_dialog): generic function to show file enrty
1822         selector dialogue
1823
1824 2013-06-21  Brent Fulgham  <bfulgham@apple.com>
1825
1826         [Windows] Unreviewed crash protection for DRT
1827
1828         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
1829         to avoid crashing during test runs.
1830
1831 2013-06-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1832
1833         REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
1834         https://bugs.webkit.org/show_bug.cgi?id=117825
1835
1836         Reviewed by Kentaro Hara.
1837
1838         DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
1839
1840         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1841         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1842         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1843         (TestRunner::overridePreference):
1844
1845 2013-06-21  Krzysztof Czech  <k.czech@samsung.com>
1846
1847         [ATK] Added support for aria-required attribute.
1848         https://bugs.webkit.org/show_bug.cgi?id=117730
1849
1850         Reviewed by Chris Fleizach.
1851
1852         Added support for testing aria-required attribute.
1853
1854         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1855         (AccessibilityUIElement::isRequired):
1856         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1857         (WTR::AccessibilityUIElement::isRequired):
1858
1859 2013-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
1860
1861         [CMAKE][EFL] Enable DOM4 Events Constructor
1862         https://bugs.webkit.org/show_bug.cgi?id=117858
1863
1864         Reviewed by Laszlo Gombos.
1865
1866         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
1867
1868 2013-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1869
1870         [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
1871         https://bugs.webkit.org/show_bug.cgi?id=117827
1872
1873         Reviewed by Rob Buis.
1874
1875         Reset the passed in request if willSendRequestReturnsNull() is
1876         true or willSendRequestReturnsNullOnRedirect() is true and it's a
1877         redirection.
1878
1879         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1880         (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
1881         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1882
1883 2013-06-20  Csaba Osztrogonác  <ossy@webkit.org>
1884
1885         Commit queue shouldn't reopen unrelated bugs because of flakiness
1886         https://bugs.webkit.org/show_bug.cgi?id=117503
1887
1888         Reviewed by Ryosuke Niwa.
1889
1890         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1891         (_follow_duplicate_chain):
1892         (_update_bug_for_flaky_test):
1893
1894 2013-06-19  Brent Fulgham  <bfulgham@apple.com>
1895
1896         [Windows] AX: Expand notification support.
1897         https://bugs.webkit.org/show_bug.cgi?id=117761
1898
1899         Reviewed by Anders Carlsson.
1900
1901         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1902         (AccessibilityUIElement::isPressActionSupported): Provide implementation.
1903         (AccessibilityUIElement::press): Provide implementation.
1904
1905 2013-06-19  Benjamin Poulain  <bpoulain@apple.com>
1906
1907         Use the PlatformEvent timestamp when creating a DOM Event
1908         https://bugs.webkit.org/show_bug.cgi?id=117179
1909
1910         Reviewed by Darin Adler.
1911
1912         * WebKitTestRunner/mac/EventSenderProxy.mm:
1913         (WTR::EventSenderProxy::mouseDown):
1914         (WTR::EventSenderProxy::mouseUp):
1915         (WTR::EventSenderProxy::mouseMoveTo):
1916         (WTR::EventSenderProxy::keyDown):
1917
1918 2013-06-18  Alex Christensen  <achristensen@apple.com>
1919
1920         Working on coverage script, added xml to json data extraction script.
1921         https://bugs.webkit.org/show_bug.cgi?id=117648
1922
1923         This is part of a new test code coverage analysis tool.  This compiles WebKit to generate
1924         coverage data, runs the tests, and collects all of the data in json format.
1925
1926         Reviewed by Stephanie Lewis.
1927
1928         * Scripts/generate-coverage-data:
1929         (parseGcovrOutput):
1930         (getFileHitsAndBranches):
1931         (addLineCounts):
1932         (createResultName):
1933         * Scripts/webkitpy/tool/gcovr: Added.
1934
1935 2013-06-18  Ryuan Choi  <ryuan.choi@samsung.com>
1936
1937         Unreviewed build fix after r151699.
1938
1939         * TestWebKitAPI/CMakeLists.txt:
1940         * WebKitTestRunner/CMakeLists.txt:
1941         Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
1942
1943 2013-06-18  Roger Fong  <roger_fong@apple.com>
1944
1945         Replace tools32 folder with tools and update WebKit Windows solution accordingly.
1946         <rdar://problem/14118143>.
1947
1948         Rubberstamped by Brent Fulgham.
1949
1950         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1951         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
1952         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1953         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1954         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
1955         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
1956         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
1957         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
1958         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
1959         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1960         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1961         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
1962         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
1963         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1964         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
1965         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
1966         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
1967         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
1968         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
1969         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
1970         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1971         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
1972         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
1973         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
1974         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1975         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
1976         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1977         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
1978         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
1979         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1980         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1981         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
1982         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1983         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
1984         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
1985         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
1986         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
1987         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
1988         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1989         * win/record-memory/record-memory.vcxproj:
1990         * win/record-memory/record-memoryDebug.props:
1991         * win/record-memory/record-memoryDebugWinCairo.props:
1992         * win/record-memory/record-memoryProduction.props:
1993         * win/record-memory/record-memoryRelease.props:
1994         * win/record-memory/record-memoryReleaseWinCairo.props:
1995
1996 2013-06-17  Kangil Han  <kangil.han@samsung.com>
1997
1998         Unreviewed. Add my email to a DOM watchlist.
1999
2000         * Scripts/webkitpy/common/config/watchlist:
2001
2002 2013-06-17  Zan Dobersek  <zdobersek@igalia.com>
2003
2004         Unreviewed GTK gardening.
2005
2006         * Scripts/run-gtk-tests:
2007         (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
2008
2009 2013-06-15  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
2010
2011         Unreviewed. Reorder my email addresses.
2012         https://bugs.webkit.org/show_bug.cgi?id=100122
2013
2014         * Scripts/webkitpy/common/config/contributors.json:
2015
2016 2013-06-14  Enrica Casucci  <enrica@apple.com>
2017
2018         WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
2019         https://bugs.webkit.org/show_bug.cgi?id=117647
2020         <rdar://problem/13881024>
2021
2022         Reviewed by Darin Adler.
2023         
2024         The test now uses content with a selection and tests both
2025         forwards and backward find as well as the case of a find
2026         that has no matches after the user selection.
2027
2028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2029         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2030         (TestWebKitAPI::didFindStringMatches):
2031         * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
2032
2033 2013-06-14  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2034
2035         Remove myself from Qt build system watchlist
2036
2037         Reviewed by Simon Hausmann.
2038
2039         * Scripts/webkitpy/common/config/watchlist:
2040
2041 2013-06-13  Michael Brüning  <michael.bruning@digia.com>
2042
2043         [Qt][Mac] Disable QTKit video on OS X.
2044         https://bugs.webkit.org/show_bug.cgi?id=117591
2045
2046         Reviewed by Tor Arne Vestbø.
2047
2048         Deployment of Qt binaries to different Mac OS X
2049         platform version makes it impossible to link against
2050         the correct version of the WebKitSystemInterface library,
2051         so we need to disable QTKit for media elements.
2052
2053         * qmake/mkspecs/features/features.prf:
2054
2055 2013-06-13  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2056
2057         [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
2058         https://bugs.webkit.org/show_bug.cgi?id=116610
2059
2060         Reviewed by Noam Rosenthal.
2061
2062         Remove unnecessary code adjusting context menu position to webview position.
2063         Now position is calculcated in EwkView.
2064
2065         * MiniBrowser/efl/main.c:
2066         (on_context_menu_show):
2067
2068 2013-06-12  Roger Fong  <roger_fong@apple.com>
2069
2070         Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
2071
2072         * Scripts/webkitpy/common/config/ews.json:
2073
2074 2013-06-12  Eduardo Lima Mitev  <elima@igalia.com>
2075
2076         [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
2077         https://bugs.webkit.org/show_bug.cgi?id=115647
2078
2079         Reviewed by Martin Robinson.
2080
2081         Locale resolution is moved to WebKitAccessibleWrapperAtk using
2082         AtkObject::get_object_locale() API. Now, implementation of
2083         AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
2084         be leveraged to get_object_locale() of AtkObject.
2085
2086         Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
2087         method.
2088
2089         No new functionality, no new tests.
2090
2091         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2092         (AccessibilityUIElement::language): Leverage locale resolution to
2093         AtkObject::get_object_locale().
2094         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2095         (WTR::AccessibilityUIElement::language): Leverage locale resolution to
2096         AtkObject::get_object_locale().
2097
2098 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
2099
2100         Remove last bits of GYP from build-webkit and update-webkit scripts
2101         https://bugs.webkit.org/show_bug.cgi?id=117557
2102
2103         Reviewed by Ryosuke Niwa.
2104
2105         * Scripts/build-webkit:
2106         * Scripts/update-webkit:
2107
2108 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
2109
2110         Remove forgotten unused Tools/Script/make-gypi script
2111         https://bugs.webkit.org/show_bug.cgi?id=117558
2112
2113         Reviewed by Ryosuke Niwa.
2114
2115         This script isn't used since the GYP removal from WebKit.
2116
2117         * Scripts/make-gypi: Removed.
2118
2119 2013-06-12  Andres Gomez  <agomez@igalia.com>
2120
2121         [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
2122         https://bugs.webkit.org/show_bug.cgi?id=117533
2123
2124         Reviewed by Carlos Garcia Campos.
2125
2126         MiniBrowser now starts automatically the download of the documents
2127         that cannot be shown just by WebKit itself on link left clicking.
2128
2129         * MiniBrowser/gtk/BrowserWindow.c:
2130         (webViewDecidePolicy): handled the
2131         WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
2132
2133 2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
2134
2135         [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
2136         https://bugs.webkit.org/show_bug.cgi?id=116723
2137
2138         Reviewed by Carlos Garcia Campos.
2139
2140         * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
2141         remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
2142         and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
2143         not expensive and produces a working archive without problems even on incremental builds.
2144
2145 2013-06-11  Santosh Mahto  <santosh.ma@samsung.com>
2146
2147         [EFL] Window resize should close the popupmenu
2148         https://bugs.webkit.org/show_bug.cgi?id=117391
2149
2150         Reviewed by Christophe Dumez.
2151         
2152         Added the code to close the popup when main window is resized.
2153
2154         * MiniBrowser/efl/main.c:
2155         (on_window_resize):
2156
2157 2013-06-11  Alex Christensen  <achristensen@apple.com>
2158
2159         Removed old broken code coverage tool.
2160         https://bugs.webkit.org/show_bug.cgi?id=117520
2161
2162         Reviewed by Sam Weinig.
2163
2164         * CodeCoverage: Removed.
2165         * CodeCoverage/README: Removed.
2166         * CodeCoverage/amber.png: Removed.
2167         * CodeCoverage/cov.py: Removed.
2168         * CodeCoverage/emerald.png: Removed.
2169         * CodeCoverage/gcov.css: Removed.
2170         * CodeCoverage/glass.png: Removed.
2171         * CodeCoverage/regenerate-coverage-display: Removed.
2172         * CodeCoverage/ruby.png: Removed.
2173         * CodeCoverage/run-generate-coverage-data: Removed.
2174         * CodeCoverage/snow.png: Removed.
2175
2176 2013-06-11  Timothy Hatcher  <timothy@apple.com>
2177
2178         Have build-webkit build the WebInspectorUI project.
2179
2180         * Scripts/build-webkit:
2181
2182 2013-06-11  Ryosuke Niwa  <rniwa@webkit.org>
2183
2184         Add an option to run-webkit-tests to skip java dependency check
2185         https://bugs.webkit.org/show_bug.cgi?id=117516
2186
2187         Reviewed by Andreas Kling.
2188
2189         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2190         (parse_args):
2191         * Scripts/webkitpy/port/mac.py:
2192         (MacPort._check_port_build):
2193
2194 2013-06-11  Alex Christensen  <achristensen@apple.com>
2195
2196         https://bugs.webkit.org/show_bug.cgi?id=117514
2197         Removed extra Xcode code coverage flags.
2198
2199         Reviewed by Sam Weinig.
2200
2201         * Scripts/webkitdirs.pm:
2202         (XcodeCoverageSupportOptions):
2203
2204 2013-06-11  Brent Fulgham  <bfulgham@apple.com>
2205
2206         [Windows] Implement 'attributeValue' accessor to support testing
2207         https://bugs.webkit.org/show_bug.cgi?id=117513
2208
2209         Reviewed by Anders Carlsson.
2210
2211         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2212         (comparableObject): Move earlier in file.
2213         (findAccessibleObjectById): New implemenation.
2214         (AccessibilityController::accessibleElementById): New implementation.
2215
2216 2013-06-11  Csaba Osztrogonác  <ossy@webkit.org>
2217
2218         Make WTR use its own temporary directory for application cache
2219         https://bugs.webkit.org/show_bug.cgi?id=117143
2220
2221         Reviewed by Alexey Proskuryakov.
2222
2223         * WebKitTestRunner/TestController.cpp:
2224         (WTR::TestController::initialize):
2225
2226 2013-06-10  Alexey Proskuryakov  <ap@apple.com>
2227
2228         https://bugs.webkit.org/show_bug.cgi?id=117449
2229         Remove dead code for storing fonts in __DATA section
2230
2231         Reviewed by Dan Bernstein.
2232
2233         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2234         Don't copy font resources to __DATA, as we don't have any code that reads them
2235         from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
2236
2237         * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
2238         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
2239         Removed comments suggesting that we want to restore the old solution.
2240
2241 2013-06-10  Bear Travis  <betravis@adobe.com>
2242
2243         [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
2244         https://bugs.webkit.org/show_bug.cgi?id=117162
2245
2246         Reviewed by Alexandru Chiculita.
2247
2248         Adding the WebCore/rendering/shapes directory to the include list.
2249
2250         * DumpRenderTree/efl/CMakeLists.txt:
2251
2252 2013-06-09  Brent Fulgham  <bfulgham@apple.com>
2253
2254         [Windows] Unreviewed test correction:  Prevent DumpRenderTree crashes
2255         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2256         (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
2257         happends in some of the 'accessibility' test cases.
2258
2259 2013-06-08  peavo@outlook.com  <peavo@outlook.com>
2260
2261         [WinCairo] TestWebKitAPI fails to link.
2262         https://bugs.webkit.org/show_bug.cgi?id=117345
2263
2264         Reviewed by Brent Fulgham.
2265
2266         Need to link with WTF.lib.
2267
2268         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
2269
2270 2013-06-07  Roger Fong  <roger_fong@apple.com>
2271
2272         Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
2273
2274         Rubberstamped by Ryousuke Niwa.
2275
2276         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2277         (RunTest.test_build_check):
2278
2279 2013-06-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
2280
2281         [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
2282         https://bugs.webkit.org/show_bug.cgi?id=117315
2283
2284         Reviewed by Benjamin Poulain.
2285
2286         Qt doesn't use the default values specified on FeatureList since r44681,
2287         this patch just remove a bit of noise.
2288
2289         * Scripts/webkitperl/FeatureList.pm:
2290
2291 2013-06-07  Jungsik Tae  <davidtlay88@gmail.com>
2292
2293         [EFL] Implement colorpicker for HTML5 input type color on Minibrowser
2294         https://bugs.webkit.org/show_bug.cgi?id=115890
2295
2296         Reviewed by Christophe Dumez.
2297
2298         When user clicks HTML5 input type color,
2299         color selector window is created on browser object by using elm_colorchooser_add().
2300         It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
2301         The evas_object_color_set() sets a color value returning to browser.
2302
2303         * MiniBrowser/efl/main.c:
2304         (window_free): When we delete parent window, deleting the colorpicker object.
2305         (on_color_changed): Change color of rectangle to show color selected by user.
2306         (on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
2307         (on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
2308         (on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
2309         (on_color_picker_dismiss): Delete colorpicker object.
2310         (on_color_picker_request): Create colorpicker window object.
2311         (window_create):
2312
2313 2013-06-06  Yuki Sekiguchi  <yuki.sekiguchi@access-company.com>
2314
2315         svn-apply cannot apply patches which is generated by git to files that contain space characters in their path
2316         https://bugs.webkit.org/show_bug.cgi?id=111066
2317
2318         Reviewed by Daniel Bates.
2319
2320         Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.
2321
2322         ParseGitDiffHeader() should support the path which line has space characters.
2323         To support this, I changed parsing algorithm like the following:
2324         - When the diff have prefix, we consider next characters after "b/" as part of a file path.
2325         - When the diff have no prefix, we assume that both path have same directory prefix, and we split the diff line using the prefix.
2326
2327         We only support --src-prefix and --dst-prefix don't contain a non-word character (\W) and end with '/' because we cannot distinguish the prefix from directory path.
2328
2329         If the path has a tab, the patch(1) command thinks file path is characters before the tab.
2330         I added a dummy tab and revision when we convert git diff to svn diff.
2331
2332         * Scripts/VCSUtils.pm:
2333         (parseGitDiffHeader):
2334         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Update expectations for dummy revision.
2335         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Ditto.
2336         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Ditto.
2337           - Added test case for files which have space in their path and --src-prefix and --dst-prefix option.
2338
2339 2013-06-06  Simon Fraser  <simon.fraser@apple.com>
2340
2341         Add a menu item to MiniBrowser to toggle Transparent windows
2342         https://bugs.webkit.org/show_bug.cgi?id=117316
2343
2344         Reviewed by Anders Carlsson.
2345         
2346         Add a menu item that toggles "Transparent window" mode, which is exposed
2347         via private WebKit API and WebKit2 API.
2348
2349         * MiniBrowser/mac/BrowserWindowController.h:
2350         * MiniBrowser/mac/MainMenu.xib:
2351         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2352         * MiniBrowser/mac/WK1BrowserWindowController.m:
2353         (-[WK1BrowserWindowController validateMenuItem:]):
2354         (-[WK1BrowserWindowController toggleTransparentWindow:]):
2355         * MiniBrowser/mac/WK2BrowserWindowController.m:
2356         (-[WK2BrowserWindowController validateMenuItem:]):
2357         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2358         (-[WK2BrowserWindowController dumpSourceToConsole:]): Fix a crash that was seen
2359         when testing.
2360
2361 2013-06-06  Roger Fong  <roger_fong@apple.com>
2362
2363         Stop copying AAS binaries into build folder.
2364         https://bugs.webkit.org/show_bug.cgi?id=117319.
2365
2366         Rubberstamped by Darin Adler.
2367
2368         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
2369
2370 2013-06-06  Hugo Parente Lima  <hugo.lima@openbossa.org>
2371
2372         Aligning build-webkit command line switch names to the WebKit flag names
2373         https://bugs.webkit.org/show_bug.cgi?id=117254
2374
2375         Reviewed by Laszlo Gombos.
2376
2377         * Scripts/webkitperl/FeatureList.pm: Rename some command line switches.
2378
2379 2013-06-06  Chris Fleizach  <cfleizach@apple.com>
2380
2381         AX: iOS ignores ARIA progressbar elements
2382         https://bugs.webkit.org/show_bug.cgi?id=116727
2383
2384         Reviewed by David Kilzer.
2385
2386         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2387         (AccessibilityUIElement::minValue):
2388         (AccessibilityUIElement::maxValue):
2389
2390 2013-06-06  peavo@outlook.com  <peavo@outlook.com>
2391
2392         [WinCairo] Fix build-webkit to build WinCairo under VS2010.
2393         https://bugs.webkit.org/show_bug.cgi?id=117255
2394
2395         Reviewed by Daniel Bates.
2396
2397         Need to update configuration names according to solution file.
2398
2399         * Scripts/webkitdirs.pm:
2400         (determineConfiguration):
2401         (determinePassedConfiguration):
2402
2403 2013-06-06  Ryosuke Niwa  <rniwa@webkit.org>
2404
2405         Remove run-performance-tests
2406         https://bugs.webkit.org/show_bug.cgi?id=117285
2407
2408         Reviewed by Andreas Kling.
2409         
2410         Remove the script since it's not used anywhere.
2411
2412         * BuildSlaveSupport/run-performance-tests: Removed.
2413
2414 2013-06-05  Bear Travis  <betravis@adobe.com>
2415
2416         [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
2417         https://bugs.webkit.org/show_bug.cgi?id=117172
2418
2419         Reviewed by Alexandru Chiculita.
2420
2421         Adding the CSS_SHAPES compile flag.
2422
2423         * Scripts/webkitperl/FeatureList.pm:
2424         * qmake/mkspecs/features/features.pri:
2425
2426 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
2427
2428         [Windows] Unreviewed build fix. Add CRLF eol-style for DOS shell scripts; if they accidentally change
2429         to UNIX-style they will not execute properly.
2430
2431         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added property svn:eol-style.
2432         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added property svn:eol-style.
2433
2434 2013-06-05  Roger Fong  <roger_fong@apple.com>
2435
2436         Unreviewed build fix. Don't pass in --use-remote-links argument on Windows now that we use NRWT.
2437
2438         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2439         (RunWebKitTests.start):
2440
2441 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
2442
2443         [Windows] Switch to NRWT
2444         https://bugs.webkit.org/show_bug.cgi?id=117200
2445
2446         Reviewed by Anders Carlsson.
2447
2448         * Scripts/run-webkit-tests:
2449         (useNewRunWebKitTests): No longer use old-run-webkit-tests for Windows port.
2450
2451 2013-06-05  Dominik Röttsches  <dominik.rottsches@intel.com>
2452
2453         Unreviewed name fix after r150662
2454
2455         My firstname got duplicated when fixing bug 116737.
2456
2457         * Scripts/webkitpy/common/config/contributors.json:
2458
2459 2013-06-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2460
2461         Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
2462         https://bugs.webkit.org/show_bug.cgi?id=117244
2463
2464         Reviewed by Daniel Bates.
2465
2466         Fixed a regression introduced by r151196: not only does webkit.org
2467         still mention WEBKITOUTPUTDIR instead of WEBKIT_OUTPUTDIR, but the
2468         infrastructure used by ports such as GTK+ and EFL also use on it for
2469         things such as jhbuild.
2470
2471         While everything is not fully transitioned to WEBKIT_OUTPUTDIR, read
2472         both environment variables.
2473
2474         * Scripts/webkitdirs.pm:
2475         (determineBaseProductDir):
2476
2477 2013-06-05  Wojciech Bielawski  <w.bielawski@samsung.com>
2478
2479         [GTK] Forwarding headers not generated for incremental build
2480         https://bugs.webkit.org/show_bug.cgi?id=117198
2481
2482         Reviewed by Carlos Garcia Campos.
2483
2484         * WebKitTestRunner/GNUmakefile.am: libTestRunnerInjectedBundle added to dependencies.
2485
2486 2013-06-05  Andras Becsi  <andras.becsi@digia.com>
2487
2488         [Qt][WK2] Fix layout testing with Qt 5.1
2489         https://bugs.webkit.org/show_bug.cgi?id=117203
2490
2491         Reviewed by Jocelyn Turcotte.
2492
2493         With Qt 5.1 synchronous requests via QNetworkAccessManager do not
2494         go into loading state but directly call handler functions for
2495         finished state instead of relying on a connection.
2496         Our wrapper QQuickView uses a data URI scheme to create the root
2497         item for testing which results in a synchronous request when loading
2498         the QML data, therefore the state of the QQuickWindow immediately
2499         becomes Ready.
2500         Since the final initialization of the root item depended on the
2501         emission of QQuickView::statusChanged(QQuickView::Ready) we ended
2502         up with a partially initialized wrapper window, thus most of our
2503         layout tests were failing.
2504         For compatibility with pre-5.1 Qt versions keep the old behaviour
2505         in case the WrapperWindow is not ready in the constructor yet.
2506
2507         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2508         (WTR::WrapperWindow::WrapperWindow):
2509         * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
2510         (TestWebKitAPI::WrapperWindow::WrapperWindow):
2511
2512 2013-06-05  Dariusz Frankiewicz  <d.frankiewic@samsung.com>
2513
2514         Bad value in tests counter at new-run-webkit-tests
2515         in --debug-rwt-logging mode
2516         https://bugs.webkit.org/show_bug.cgi?id=116858
2517
2518         Reviewed by Dirk Pranke.
2519
2520         Fix by moving counter incrementation, from after printing line,
2521         to before printing. Also changed variable name.
2522
2523         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2524         (LayoutTestRunner.run_tests):
2525         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2526         (FakePrinter):
2527         * Scripts/webkitpy/layout_tests/views/printing.py:
2528         (Printer.__init__):
2529         (Printer._test_status_line):
2530         (Printer.print_started_test):
2531         (Printer.print_finished_test):
2532         * Scripts/webkitpy/test/printer.py:
2533         (Printer.__init__):
2534         (Printer.print_finished_test):
2535         (Printer._test_line):
2536         (Printer.print_result):
2537
2538 2013-06-05  Zan Dobersek  <zdobersek@igalia.com>
2539
2540         Move MemoryInfo under window.internals
2541         https://bugs.webkit.org/show_bug.cgi?id=117197
2542
2543         Reviewed by Ryosuke Niwa.
2544
2545         * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
2546         the Automake build
2547         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
2548         testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
2549
2550 2013-06-03  Roger Fong  <roger_fong@apple.com>
2551
2552         Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
2553         <rdar://problem/14042021>.
2554
2555         Reviewed by Brent Fulgham.
2556
2557         * Scripts/build-api-tests:
2558         * Scripts/build-dumprendertree:
2559         * Scripts/build-webkit:
2560         * Scripts/update-webkit-dependency:
2561         * Scripts/update-webkit-support-libs:
2562         * Scripts/webkitdirs.pm:
2563         (determineBaseProductDir):
2564         (setupAppleWinEnv):
2565         (setupCygwinEnv):
2566
2567 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
2568
2569         [Windows] NRWT is not putting crash logs in proper place (corrections)
2570         https://bugs.webkit.org/show_bug.cgi?id=117212
2571
2572         Reviewed by Dirk Pranke.
2573
2574         * Scripts/webkitpy/common/system/crashlogs.py:
2575         (CrashLogs.__init__): Accept a result directory argument in constructor.
2576         (CrashLogs.find_newest_log): Don't require 'port' argument anymore.
2577         (CrashLogs._find_newest_log_win): No longer use 'port' argument.
2578         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2579         (CrashLogsTest.test_find_log_win): Simplify test.
2580         * Scripts/webkitpy/common/system/executive.py:
2581         (Executive.running_pids): Handle "win32" case separately from "cygwin" case.
2582         * Scripts/webkitpy/port/win.py:
2583         (WinPort._get_crash_log): No longer require 'port' argument.
2584
2585 2013-06-04  Ryosuke Niwa  <rniwa@webkit.org>
2586
2587         Build fix after r150592. We need to disable \2 shouldn't be treated as an escape character.
2588
2589         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2590
2591 2013-06-04  Greg Hughes  <ghughes@apple.com>
2592
2593         Add "VisibleOnly" key to search predicate
2594         https://bugs.webkit.org/show_bug.cgi?id=115491
2595
2596         Reviewed by Chris Fleizach.
2597
2598         Added support for accessibility clients to use the search predicate to find only visible elements
2599
2600         * DumpRenderTree/AccessibilityUIElement.cpp:
2601         (uiElementForSearchPredicateCallback):
2602         * DumpRenderTree/AccessibilityUIElement.h:
2603         (AccessibilityUIElement):
2604         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2605         (AccessibilityUIElement::uiElementForSearchPredicate):
2606         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2607         (AccessibilityUIElement::uiElementForSearchPredicate):
2608         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2609         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2610         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2611         (AccessibilityUIElement):
2612         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2613         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2614         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2615
2616 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
2617
2618         [Windows] Unreviewed build fix.  The last check-in lost CR/LF endings on the batch file,
2619         causing build failure.
2620
2621         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
2622         DOS-style CR/LF endings.
2623
2624 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
2625
2626         [Windows] Unreviewed test correction.
2627
2628         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
2629         QuartzCore dll's, which are needed by TestWebKitAPI.
2630         * TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
2631         with VS2010 will run when linked against VS2005 support libraries.
2632
2633 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2634
2635         Automatically generate WorkerContext constructor attributes
2636         https://bugs.webkit.org/show_bug.cgi?id=117183
2637
2638         Reviewed by Kentaro Hara.
2639
2640         Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
2641         tests.
2642
2643         * Scripts/webkitpy/bindings/main.py:
2644         (BindingsTests.generate_supplemental_dependency):
2645         (BindingsTests.main):
2646
2647 2013-06-04  Ryuan Choi  <ryuan.choi@samsung.com>
2648
2649         [EFL] File dialog of MiniBrowser have broken background.
2650         https://bugs.webkit.org/show_bug.cgi?id=117189
2651
2652         Reviewed by Christophe Dumez.
2653
2654         * MiniBrowser/efl/main.c:
2655         (on_file_chooser_request): Added elm_bg for elm_win of file chooser.
2656
2657 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2658
2659         [WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
2660         https://bugs.webkit.org/show_bug.cgi?id=117184
2661
2662         Reviewed by Gyuyoung Kim.
2663
2664         Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
2665         that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
2666
2667         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2668         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2669         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2670
2671 2013-06-03  Simon Pena  <simon.pena@samsung.com>
2672
2673         validate-committer-lists script is now outdated and does not work
2674         https://bugs.webkit.org/show_bug.cgi?id=115860
2675
2676         Reviewed by Brent Fulgham.
2677
2678         The script validate-committer-lists was outdated, still using the deprecated log
2679         system and having the old addresses for the mailing lists, as well as still referring
2680         to committers.py, after this was renamed to contributors.json. This patch fixes that
2681         so it can be used again.
2682
2683         * Scripts/validate-committer-lists: Replace calls to log and error with the
2684         new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
2685         to committers.py, which should be contributors.json.
2686         (CommitterListFromMailingList):
2687         (CommitterListFromMailingList.check_for_emails_missing_from_list):
2688         (CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
2689         (CommitterListFromGit._fill_in_emails_for_old_logins):
2690         (CommitterListFromGit.print_committers_missing_from_committer_list):
2691
2692 2013-06-03  Dirk Pranke  <dpranke@chromium.org>
2693
2694         add a script to dump the tests run most recently by a given worker
2695         https://bugs.webkit.org/show_bug.cgi?id=116571
2696
2697         Reviewed by Brent Fulgham.
2698
2699         The tests_run*.txt results files in layout-test-results/ were removed
2700         in r137356, in favor of collecting more data about how the tests were
2701         run and compressing it and storing it in stats.json. However, it was
2702         nice to just be able to look at a flat text file.
2703
2704         This script will extract the tests run by a given worker from a
2705         given stats.json file, and should help to address that.
2706
2707         * Scripts/dump-webkit-tests-run: Added.
2708         (main):
2709         (convert_trie_to_flat_paths):
2710
2711 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
2712
2713         [Windows] NRWT is not putting crash logs in proper place
2714         https://bugs.webkit.org/show_bug.cgi?id=117098
2715
2716         Reviewed by Ryosuke Niwa.
2717
2718         Provide windows-specific overloads for various Port features needed to create and capture
2719         crash logs.  This change makes it possible to view crash logs (when created) as part of the
2720         summary report at the end of the NRWT run.
2721
2722         * Scripts/webkitpy/common/system/crashlogs.py:
2723         (CrashLogs.find_newest_log): Add support for win32 crash logs
2724         (CrashLogs._find_newest_log_win): Added
2725         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2726         (make_mock_crash_report_win): Added
2727         (CrashLogsTest.test_find_log_win): Added.
2728         * Scripts/webkitpy/common/system/executive.py:
2729         (Executive.running_pids): Add support for Cygwin win32 crash logs
2730         * Scripts/webkitpy/common/system/executive_mock.py:
2731         (MockExecutive.__init__):
2732         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2733         (RealFileSystemTest.test_read_and_write_file): Add tests for
2734         malformed ascii/utf8 handling (i.e., Windows log files)
2735         * Scripts/webkitpy/port/base.py:
2736         (Port.find_system_pid): Added
2737         * Scripts/webkitpy/port/server_process.py:
2738         (ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
2739         * Scripts/webkitpy/port/win.py:
2740         (WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
2741         for user to hit enter.
2742         (WinPort._get_crash_log): Added
2743         (WinPort.look_for_new_crash_logs): Added
2744         (WinPort.find_system_pid): Added
2745         * Scripts/webkitpy/port/win_unittest.py:
2746         (WinPortTest.test_get_crash_log): Added test
2747
2748 2013-06-03  Eduardo Lima Mitev  <elima@igalia.com>
2749
2750         [EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
2751         https://bugs.webkit.org/show_bug.cgi?id=116726
2752
2753         Reviewed by Gyuyoung Kim.
2754
2755         Current version of ATK in efl-ews environment is 2.4.0 and is taken from
2756         the platform (it is not listed in jhbuild moduleset). That version is
2757         old-ish and contain deprecated symbols and missing API, that are blocking
2758         patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
2759         moduleset, which is the same version the gtk port uses.
2760
2761         See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
2762         why this is needed.
2763
2764         * efl/jhbuild.modules: Adds ATK module as dependency
2765
2766 2013-06-03  Erik van Pienbroek  <epienbro@fedoraproject.org>
2767
2768         [GTK] Respect PKG_CONFIG env variable when generating gtk-doc
2769         https://bugs.webkit.org/show_bug.cgi?id=117168
2770
2771         Reviewed by Martin Robinson.
2772
2773         The tool generate-gtkdoc internally calls pkg-config.
2774         When cross-compiling it shouldn't use pkg-config, but
2775         it should use the pkg-config which was detected by
2776         the ./configure script (for example this can be
2777         i686-w64-mingw32-pkg-config when cross-compiling)
2778
2779         * GNUmakefile.am:
2780         * gtk/gtkdoc.py:
2781         (PkgConfigGTKDoc.__init__):
2782
2783 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
2784
2785         [Windows] Unreviewed build fix.
2786
2787         * TestWebKitAPI/win/main.cpp: Embed proper manifest information to
2788         allow VS2010 builds to use VS2005 runtime libraries as needed.
2789
2790 2013-06-03  Roger Fong  <roger_fong@apple.com>
2791
2792         Nuke VS2005 files from the tree.
2793         <rdar://problem/14042021>.
2794
2795         Rubberstamped by Brent Fulgham.
2796
2797         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Removed.
2798         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Removed.
2799         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Removed.
2800         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Removed.
2801         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Removed.
2802         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Removed.
2803         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Removed.
2804         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Removed.
2805         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Removed.
2806         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Removed.
2807         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Removed.
2808         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Removed.
2809         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Removed.
2810         * DumpRenderTree/win/DumpRenderTree.vcproj: Removed.
2811         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Removed.
2812         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Removed.
2813         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Removed.
2814         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Removed.
2815         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Removed.
2816         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Removed.
2817         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Removed.
2818         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Removed.
2819         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Removed.
2820         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Removed.
2821         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Removed.
2822         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Removed.
2823         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Removed.
2824         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Removed.
2825         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Removed.
2826         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Removed.
2827         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Removed.
2828         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Removed.
2829         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Removed.
2830         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Removed.
2831         * DumpRenderTree/win/ImageDiff.vcproj: Removed.
2832         * DumpRenderTree/win/ImageDiffCommon.vsprops: Removed.
2833         * DumpRenderTree/win/ImageDiffDebug.vsprops: Removed.
2834         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Removed.
2835         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Removed.
2836         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Removed.
2837         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Removed.
2838         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Removed.
2839         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Removed.
2840         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Removed.
2841         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Removed.
2842         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Removed.
2843         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Removed.
2844         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Removed.
2845         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Removed.
2846         * DumpRenderTree/win/ImageDiffProduction.vsprops: Removed.
2847         * DumpRenderTree/win/ImageDiffRelease.vsprops: Removed.
2848         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Removed.
2849         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Removed.
2850         * Scripts/pdevenv: Removed.
2851         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Removed.
2852         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Removed.
2853         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Removed.
2854         * WebKitLauncherWin: Removed.
2855         * WebKitLauncherWin/Resource.h: Removed.
2856         * WebKitLauncherWin/WebKitLauncherWin.cpp: Removed.
2857         * WebKitLauncherWin/WebKitLauncherWin.rc: Removed.
2858         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Removed.
2859         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Removed.
2860         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Removed.
2861         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Removed.
2862         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Removed.
2863         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Removed.
2864         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Removed.
2865         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Removed.
2866         * WebKitLauncherWin/webkit.ico: Removed.
2867         * WinLauncher/WinLauncher.ico: Removed.
2868         * WinLauncher/WinLauncher.rc: Removed.
2869         * WinLauncher/WinLauncher.vcproj: Removed.
2870         * WinLauncher/WinLauncherCommon.vsprops: Removed.
2871         * WinLauncher/WinLauncherDebug.vsprops: Removed.
2872         * WinLauncher/WinLauncherDebugAll.vsprops: Removed.
2873         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Removed.
2874         * WinLauncher/WinLauncherLauncher.rc: Removed.
2875         * WinLauncher/WinLauncherLauncher.vcproj: Removed.
2876         * WinLauncher/WinLauncherLauncherCommon.vsprops: Removed.
2877         * WinLauncher/WinLauncherLauncherDebug.vsprops: Removed.
2878         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Removed.
2879         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Removed.
2880         * WinLauncher/WinLauncherLauncherProduction.vsprops: Removed.
2881         * WinLauncher/WinLauncherLauncherRelease.vsprops: Removed.
2882         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Removed.
2883         * WinLauncher/WinLauncherLauncherResource.h: Removed.
2884         * WinLauncher/WinLauncherPostBuild.cmd: Removed.
2885         * WinLauncher/WinLauncherPreBuild.cmd: Removed.
2886         * WinLauncher/WinLauncherProduction.vsprops: Removed.
2887         * WinLauncher/WinLauncherRelease.vsprops: Removed.
2888         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Removed.
2889         * WinLauncher/small.ico: Removed.
2890         * record-memory-win: Removed.
2891         * record-memory-win/main.cpp: Removed.
2892         * record-memory-win/record-memory-win-common.vsprops: Removed.
2893         * record-memory-win/record-memory-win.vcproj: Removed.
2894         * record-memory-win/record-memory-winDebug.vsprops: Removed.
2895         * record-memory-win/record-memory-winDebugAll.vsprops: Removed.
2896         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Removed.
2897         * record-memory-win/record-memory-winProduction.vsprops: Removed.
2898         * record-memory-win/record-memory-winRelease.vsprops: Removed.
2899         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Removed.
2900
2901 2013-06-03  Chris Fleizach  <cfleizach@apple.com>
2902
2903         AX: MathML multiscripts not exposed in Accessibility
2904         https://bugs.webkit.org/show_bug.cgi?id=115069
2905
2906         Reviewed by Tim Horton.
2907
2908         Add methods to help output components of math multiscripts for accessibility.
2909
2910         * DumpRenderTree/AccessibilityUIElement.cpp:
2911         (mathPostscriptsDescriptionCallback):
2912         (mathPrescriptsDescriptionCallback):
2913         (AccessibilityUIElement::getJSClass):
2914         * DumpRenderTree/AccessibilityUIElement.h:
2915         (AccessibilityUIElement):
2916         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2917         (convertMathMultiscriptPairsToString):
2918         (AccessibilityUIElement::mathPostscriptsDescription):
2919         (AccessibilityUIElement::mathPrescriptsDescription):
2920         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2921         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2922         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2923         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2924         (AccessibilityUIElement):
2925         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2926         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2927         (WTR::_convertMathMultiscriptPairsToString):
2928         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2929         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2930
2931 2013-06-03  Commit Queue  <commit-queue@webkit.org>
2932
2933         Unreviewed, rolling out r151109.
2934         http://trac.webkit.org/changeset/151109
2935         https://bugs.webkit.org/show_bug.cgi?id=117145
2936
2937         "Plugins in WK2 aren't implemented yet." (Requested by
2938         jturcotte on #webkit).
2939
2940         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2941         * qmake/mkspecs/features/features.prf:
2942         * qmake/mkspecs/features/unix/default_pre.prf:
2943
2944 2013-05-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2945
2946         [Qt] Re-enable plugins on Mac.
2947         https://bugs.webkit.org/show_bug.cgi?id=116622
2948
2949         Reviewed by Tor Arne Vestbø.
2950
2951         Plugins on Mac were only enabled if !embedded but the later was set if
2952         QPA is enabled, which is the default since Qt 5.0.
2953
2954         Remove references to 'embedded' and fix various build issues,
2955         PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
2956         months.
2957
2958         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2959         * qmake/mkspecs/features/features.prf:
2960         * qmake/mkspecs/features/unix/default_pre.prf:
2961
2962 2013-06-03  Krzysztof Czech  <k.czech@samsung.com>
2963
2964         [GTK][WK2] accessibility/placeholder.html is failing
2965         https://bugs.webkit.org/show_bug.cgi?id=106344
2966
2967         Reviewed by Gyuyoung Kim.
2968
2969         Adds support for retrieving attribute value.
2970
2971         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2972         (WTR::coreAttributeToAtkAttribute):
2973         (WTR::AccessibilityUIElement::stringAttributeValue):
2974
2975 2013-06-01  Tim Horton  <timothy_horton@apple.com>
2976
2977         Add a preferred email address and "expertise" for me.
2978
2979         * Scripts/webkitpy/common/config/contributors.json:
2980
2981 2013-05-31  Roger Fong  <roger_fong@apple.com>
2982
2983         Unreviewed. Make windows test bots search in the correct directory for build output.
2984
2985         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2986         (RunWebKitTests.start):
2987         * Scripts/webkitdirs.pm:
2988         (determineConfigurationProductDir):
2989
2990 2013-05-31  Roger Fong  <roger_fong@apple.com>
2991
2992         Unreviewed. Windows build fix...
2993
2994         * BuildSlaveSupport/built-product-archive:
2995         (createZip):
2996
2997 2013-05-31  Roger Fong  <roger_fong@apple.com>
2998
2999         Unreviewed. Windows build fix. One more time!
3000
3001         * BuildSlaveSupport/built-product-archive:
3002         (archiveBuiltProduct):
3003         (extractBuiltProduct):
3004
3005 2013-05-31  Roger Fong  <roger_fong@apple.com>
3006
3007         Unreviewed. Windows build fix.
3008
3009         * Scripts/build-webkit:
3010
3011 2013-05-31  Roger Fong  <roger_fong@apple.com>
3012
3013         Unreviewed. Windows build fix.
3014
3015         * Scripts/build-webkit:
3016
3017 2013-05-31  Roger Fong  <roger_fong@apple.com>
3018
3019         Make build-webkit output VCExpress 2010 build logs properly.
3020         https://bugs.webkit.org/show_bug.cgi?id=117096
3021
3022         Reviewed by Brent Fulgham.
3023
3024         Make it so that output from VCExpress is always printed to console.
3025         Get build log results from AssembleBuildLogs project output.
3026         We don't need those old VCExpress scripts anymore either. 
3027
3028         * Scripts/build-webkit:
3029         * Scripts/print-msvc-project-dependencies: Removed.
3030         * Scripts/print-vse-failure-logs: Removed.
3031
3032 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
3033
3034         [Windows] Use WinLauncher to display LayoutTest results
3035         https://bugs.webkit.org/show_bug.cgi?id=117085
3036
3037         Reviewed by Oliver Hunt.
3038
3039         * Scripts/webkitdirs.pm:
3040         (runSafari): Use WinLauncher to display content
3041         * WinLauncher/WinLauncher.cpp:
3042         (dllLauncherEntryPoint): Check for URL argument.
3043
3044 2013-05-31  Roger Fong  <roger_fong@apple.com>
3045
3046         Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
3047
3048         * win/AssembleBuildLogs/AssembleLogs.cmd:
3049
3050 2013-05-31  Commit Queue  <commit-queue@webkit.org>
3051
3052         Unreviewed, rolling out r151022.
3053         http://trac.webkit.org/changeset/151022
3054         https://bugs.webkit.org/show_bug.cgi?id=117084
3055
3056         Also breaks build by introducing duplicate symbols (Requested
3057         by bfulgham on #webkit).
3058
3059         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3060
3061 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
3062
3063         [Windows] Unreviewed build fix to NRWT
3064
3065         * Scripts/webkitpy/port/win.py:
3066         (WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.
3067
3068 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
3069
3070         [Windows] Unreviewed build fix after r151012
3071
3072         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
3073         WTF library to support SHA tests
3074
3075 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
3076
3077         [Windows] Unreviewed build fix after r151012
3078
3079         * TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
3080         snprintf definition for Windows.
3081
3082 2013-05-31  Zan Dobersek  <zdobersek@igalia.com>
3083
3084         Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
3085         https://bugs.webkit.org/show_bug.cgi?id=116445
3086
3087         Reviewed by Benjamin Poulain.
3088
3089         Add the MD5 and SHA1 unit tests that were previously located inside WTF.
3090
3091         * TestWebKitAPI/CMakeLists.txt:
3092         * TestWebKitAPI/GNUmakefile.am:
3093         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3094         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3095         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3096         * TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
3097         (TestWebKitAPI):
3098         (TestWebKitAPI::expectMD5):
3099         (TestWebKitAPI::TEST):
3100         * TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
3101         (TestWebKitAPI):
3102         (TestWebKitAPI::expectSHA1):
3103         (TestWebKitAPI::TEST):
3104         * TestWebKitAPI/Tests/WTF/WTF.pro:
3105         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3106
3107 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
3108
3109         [Windows] Unreviewed build correction.
3110
3111         * Scripts/webkitpy/port/win.py:
3112         (WinPort.create_debugger_command_file): The directory needs to be
3113         a string, not a temporary directory object.
3114
3115 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
3116
3117         [Windows] NRWT doesn't save crash logs on Apple's Windows port.
3118         https://bugs.webkit.org/show_bug.cgi?id=76935
3119
3120         Reviewed by Ryosuke Niwa.
3121
3122         Extend the WinPort class with commands to set and clean up various registry
3123         values needed to invoke the correct debugger to get crash files.
3124
3125         * Scripts/webkitpy/port/win.py:
3126         (WinPort): Added global caches for registry keys and settings
3127         (WinPort._ntsd_location): Added
3128         (WinPort.create_debugger_command_file): Added
3129         (WinPort.read_registry_string): Added
3130         (WinPort.write_registry_string): Added
3131         (WinPort.setup_crash_log_saving): Added
3132         (WinPort.restore_crash_log_saving): Added
3133         (WinPort.setup_test_run): Added overload to add registry settings.
3134         (WinPort.clean_up_test_run): Added overload to clean up registry settings.
3135
3136 2013-05-30  Roger Fong  <roger_fong@apple.com>
3137
3138         Get rid of JavaScript exports file on AppleWin port.
3139         https://bugs.webkit.org/show_bug.cgi?id=117050.
3140
3141         Reviewed by Darin Adler.
3142
3143         Start linking in WTF.lib now that it's a shared library.
3144
3145         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
3146         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
3147         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3148
3149 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
3150
3151         Web Inspector: tests in PerformanceTests/inspector/ are timing out
3152         https://bugs.webkit.org/show_bug.cgi?id=77024
3153
3154         Reviewed by Andreas Kling.
3155
3156         Remove inspector performance tests since they have been disabled for ages,
3157         and they don't use the standard parser-style performance output.
3158
3159         It's adding a lot of code complexity to our infrastructure.
3160
3161         * Scripts/webkitpy/performance_tests/perftest.py:
3162         (SingleProcessPerfTest.__init__):
3163         (PerfTestFactory):
3164         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3165         (TestPerfTestFactory.test_regular_test):
3166         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3167         (TestDriver.run_test):
3168         (MainTest.run_test):
3169         (MainTest._tests_for_runner):
3170         (MainTest.test_run_test_set_kills_drt_per_run):
3171         (MainTest._test_run_with_json_output):
3172         (MainTest):
3173         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
3174
3175 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
3176
3177         Remove requires_http_server as Chromium Android was the only port that needed this
3178         https://bugs.webkit.org/show_bug.cgi?id=117018
3179
3180         Reviewed by Benjamin Poulain.
3181
3182         Removed the unused code that existed for Chromium Android port.
3183
3184         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3185         (LayoutTestRunner.run_tests):
3186         (LayoutTestRunner._handle_finished_test_list):
3187         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3188         (Manager._run_tests):
3189         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3190         (PerfTestsRunner._collect_tests):
3191         (PerfTestsRunner.run):
3192         * Scripts/webkitpy/port/base.py:
3193         (Port.to.start_helper):
3194         * Scripts/webkitpy/port/base_unittest.py:
3195         (PortTest.test_build_path):
3196
3197 2013-05-29  Ruth Fong  <ruth_fong@apple.com>
3198
3199         prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
3200         https://bugs.webkit.org/show_bug.cgi?id=113221
3201
3202         Reviewed by Ryosuke Niwa.
3203
3204         Teach prepare-Changelog to not list the names of modified namespaces, 
3205         classes, or structs in C++ files. Thus, if a change is made 
3206         within a namespace/class/struct yet outside a function, it will 
3207         not be reflected in the ChangeLog entry. 
3208         See https://bugs.webkit.org/show_bug.cgi?id=113221#c8 
3209         for more details on how ChangeLog entries are affected.
3210
3211         * Scripts/prepare-ChangeLog:
3212         (get_function_line_ranges_for_cpp): 
3213         (delete_namespaces_from_ranges_for_cpp): Added.
3214         (is_function_in_namespace): Added.
3215         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Updated
3216         to reflect revised definition of a function (i.e. excludes namespaces, classes, structs)
3217
3218 2013-05-29  Praveen R Jadhav  <praveen.j@samsung.com>
3219
3220         Cleanup AudioSourceNode.idl from WebKit build.
3221         https://bugs.webkit.org/show_bug.cgi?id=116905.
3222
3223         Reviewed by Darin Adler.
3224
3225         AudioSourceNode.idl is not part of WebAudio Specifications anymore.
3226         AudioNode is inherited directly in all the audio source nodes.
3227
3228         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
3229
3230 2013-05-29  Andrew Lo  <anlo@rim.com>
3231
3232         Add Andrew Lo to contributors.json
3233         https://bugs.webkit.org/show_bug.cgi?id=116981
3234
3235         Reviewed by Rob Buis.
3236
3237         Adding Andrew Lo to contributors.json.
3238
3239         * Scripts/webkitpy/common/config/contributors.json:
3240
3241 2013-05-29  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3242
3243         Unreviewed. Adding myself as a committer.
3244
3245         * Scripts/webkitpy/common/config/contributors.json:
3246
3247 2013-05-29  Marcelo Lira  <marcelo.lira@openbossa.org>
3248
3249         [WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
3250         https://bugs.webkit.org/show_bug.cgi?id=116683
3251
3252         Reviewed by Noam Rosenthal.
3253
3254         A coordinates conversion test for WKViewUserViewportToContents was
3255         added to WebKit2 API tests.
3256
3257         * TestWebKitAPI/PlatformEfl.cmake:
3258         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
3259         (TestWebKitAPI):
3260         (TestWebKitAPI::TEST):
3261
3262 2013-05-29  Yong Li  <yong.li.webkit@outlook.com>
3263
3264         Unreviewed. Update my info.
3265
3266         * Scripts/webkitpy/common/config/contributors.json:
3267
3268 2013-05-29  Dongseong Hwang  <dongseong.hwang@intel.com>
3269
3270         Unreviewed. Add myself as committer in contributors.json.
3271
3272         * Scripts/webkitpy/common/config/contributors.json:
3273
3274 2013-05-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3275
3276         Unreviewed. Fix make distcheck.
3277
3278         * TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
3279         DISTCLEANFILES.
3280
3281 2013-05-29  Mary Wu  <mawu@blackberry.com>
3282
3283         Unreviewed: update my email address in contributors.json.
3284
3285         * Scripts/webkitpy/common/config/contributors.json:
3286
3287 2013-05-29  Kalyan Kondapally  <kalyan.kondapally@intel.com>
3288
3289         Unreviewed: Adding myself to committers list.
3290
3291         * Scripts/webkitpy/common/config/contributors.json:
3292
3293 2013-05-28  Arpita Bahuguna  <a.bah@samsung.com>
3294
3295         Unreviewed: Adding myself to committers list.
3296
3297         * Scripts/webkitpy/common/config/contributors.json:
3298
3299 2013-05-28  Brent Fulgham  <bfulgham@webkit.org>
3300
3301         [Windows] Many CSS2.1 tests fail under NRWT.
3302         https://bugs.webkit.org/show_bug.cgi?id=75707
3303
3304         Reviewed by Darin Adler.
3305
3306         * DumpRenderTree/win/DumpRenderTree.cpp:
3307         (findFontFallback): Added
3308         (addFontFallbackIfPresent): Added
3309         (removeFontFallbackIfPresent): Added
3310         (runTest): Set up/remove font fallbacks when needed.
3311
3312 2013-05-28  Brent Fulgham  <bfulgham@apple.com>
3313
3314         [Windows] NRWT reports failure for 'mac' test cases.
3315         https://bugs.webkit.org/show_bug.cgi?id=116698
3316
3317         Reviewed by Ryosuke Niwa.
3318
3319         The Windows port falls back to the Mac port for many test results,
3320         and so adds the mac and mac-wk2 to its set of fallbacks.
3321         Unfortunately, NRWT thinks that this means that tests in these
3322         folders should be executed, resulting in many failures on
3323         Windows.
3324
3325         This change overloads the '_tests_for_other_platforms' method
3326         to return a subset of the result fallback list so that we do
3327         not attempt to execute Mac tests on Windows.
3328
3329         * Scripts/webkitpy/port/base.py:
3330         (Port.test_search_path): Added. Defaults to just calling the
3331         baseline_search_path method, which is how most ports behave.
3332         (Port._test_for_other_platforms): Modified to call the new
3333         test_search_path method.
3334
3335         * Scripts/webkitpy/port/win.py:
3336         (WinPort.test_search_path): Added custom overload. Strips
3337         out mac-specific test paths.
3338
3339 2013-05-28  Martin Robinson  <mrobinson@igalia.com>
3340
3341         Fix GTK+ CMake build
3342
3343         * MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
3344         library target is simply "WebKit2."
3345
3346 2013-05-28  Zan Dobersek  <zdobersek@igalia.com>
3347
3348         [webkitpy] Explicitly specify the reference file extensions
3349         https://bugs.webkit.org/show_bug.cgi?id=116333
3350
3351         Reviewed by Benjamin Poulain.
3352
3353         Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
3354         between valid reference files required by reftests and text baselines that have the same extension as
3355         potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
3356         that were until this change recognized as reference files).
3357
3358         Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.
3359
3360         * Scripts/webkitpy/port/base.py:
3361         (Port.reference_files): Iterate through the _supported_reference_extensions set.
3362         (Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
3363         _supported_reference_extensions set, containing the extensions allowed for reference files.
3364         (Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
3365         (Port._has_supported_extension): Use _supported_test_extensions.
3366         * Scripts/webkitpy/port/base_unittest.py:
3367         (PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
3368         Port.is_reference_html_file method.
3369
3370 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
3371
3372         Yet another WKR build fix. Sorry for the mess. It seems like I can't win today :(
3373
3374         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3375         (NewCommitBot.next_work_item):
3376
3377 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
3378
3379         WKR and webkitbot build fixes.
3380
3381         * Scripts/webkitpy/tool/bot/irc_command.py:
3382         (RollChromiumDEPS.execute):
3383         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3384         (NewCommitBot.next_work_item):
3385
3386 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
3387
3388         roll-chromium-deps doesn't repeat the full name.
3389
3390         Rubber-stamped by Andreas Kling.
3391
3392         * Scripts/webkitpy/tool/bot/irc_command.py:
3393         (RollChromiumDEPS.execute):
3394
3395 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
3396
3397         Revert another erroneous change.
3398
3399         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3400         (NewCommitBot.next_work_item):
3401
3402 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
3403
3404         Revert an erroneous change.
3405
3406         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3407         (SheriffBot):
3408
3409 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
3410
3411         Some build fixes for WKR and webkitbot.
3412
3413         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3414         (IRCBotTest.test_help):
3415         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3416         (Agent):
3417         (Agent.__init__):
3418         (Agent.name):
3419         (NewCommitBot):
3420         (NewCommitBot.begin_work_queue):
3421         (NewCommitBot.next_work_item):
3422         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3423         (SheriffBot):
3424
3425 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
3426
3427         Teach webkitbot and WKR how to respond to yt?
3428         https://bugs.webkit.org/show_bug.cgi?id=116775
3429
3430         Reviewed by Andreas Kling.
3431
3432         * Scripts/webkitpy/tool/bot/irc_command.py:
3433         (Hi): Fixed the usage string.
3434         (Hi.execute): Made it more generic so that it works in WKR.
3435         (YouThere): Added.
3436         (YouThere.execute): Added.
3437         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3438
3439 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
3440
3441         Try to fix the EFL build.
3442         
3443         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3444         (TestRunner::setPageVisibility):
3445
3446 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
3447
3448         Unprefix Page Visibility API
3449         https://bugs.webkit.org/show_bug.cgi?id=102340
3450
3451         Reviewed by Tim Horton.
3452         
3453         Rename "preview" state to "unloaded" state, and adjust the tests
3454         to test for it.
3455
3456         * DumpRenderTree/mac/TestRunnerMac.mm:
3457         (TestRunner::setPageVisibility):
3458         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
3459         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
3460         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
3461         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
3462         (TestWebKitAPI::didRunStep4InStateUnloaded):
3463         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
3464         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3465         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3466         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3467         (WTR::TestRunner::setPageVisibility):
3468
3469 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
3470
3471         Unreviewed build fix. Don't use new NRWT logic needed
3472         by Windows yet. Activate (and fix test) when we cut over.
3473
3474         * Scripts/webkitpy/port/driver.py:
3475         (Driver._setup_environ_for_driver):
3476         (Driver._start):
3477
3478 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
3479
3480         [Windows] Expose database storage and cache locations via preferences.
3481         https://bugs.webkit.org/show_bug.cgi?id=116729
3482
3483         Reviewed by Tim Horton.
3484
3485         Update DumpRenderTree to use CFPreferences to control where WebKit
3486         stores its local databases, URL caches, etc.
3487
3488         * DumpRenderTree/win/DumpRenderTree.cpp:
3489         (libraryPathForDumpRenderTree): Added.
3490         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
3491         * Scripts/webkitpy/port/base.py:
3492         (Port._driver_tempdir): Added (to allow port-specific overload).
3493         (Port._driver_tempdir_for_environment): Ditto
3494         * Scripts/webkitpy/port/driver.py:
3495         (Driver._setup_environ_for_driver): Use new overload to set
3496         environment variable.
3497         (Driver._start): Use new overload for temp directory location.
3498         * Scripts/webkitpy/port/win.py:
3499         (WinPort._driver_tempdir_for_environment): New overload to supply
3500         Windows path to DumpRenderTree environment (while still using
3501         cygwin paths for internal operations.
3502
3503 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3504
3505         Remove custom code for webkitAudioContext global constructor getter
3506         https://bugs.webkit.org/show_bug.cgi?id=116530
3507
3508         Reviewed by Geoffrey Garen.
3509
3510         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
3511         WebAudio feature instead of public ewk_view API since that API was
3512         removed.
3513
3514         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3515         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3516         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3517         (TestRunner::overridePreference):
3518
3519 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
3520
3521         Make team.html have each contributor's area of expertise
3522         https://bugs.webkit.org/show_bug.cgi?id=116737
3523
3524         Reviewed by Benjamin Poulain.
3525
3526         * Scripts/webkitpy/common/config/contributors.json:
3527         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
3528         
3529         Changed formatting of the file because the lines are getting way to
3530         long, and I generated this, so it's easier if the formatting of the
3531         file is regular.
3532
3533 2013-05-24  Simon Pena  <simon.pena@samsung.com>
3534
3535         Update WTF::Vector pretty printers
3536         https://bugs.webkit.org/show_bug.cgi?id=116719
3537
3538         Reviewed by Anders Carlsson.
3539
3540         After r148891, WTF::Vector pretty printers were left outdated, as
3541         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
3542         one as a member. This patch updates the pretty printers so they work
3543         again. 
3544
3545         * gdb/webkit.py:
3546         (WTFVectorPrinter.children):
3547         (WTFVectorPrinter.to_string):
3548
3549 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
3550
3551         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
3552         https://bugs.webkit.org/show_bug.cgi?id=116710
3553
3554         Reviewed by Mark Rowe.
3555
3556         * DumpRenderTree/mac/DumpRenderTree.mm:
3557         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
3558
3559 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
3560
3561         Add missing dependencies to deps script.
3562
3563         [GTK] Missing packages in install-dependencies script.
3564         https://bugs.webkit.org/show_bug.cgi?id=116632
3565
3566         Reviewed by Martin Robinson.
3567
3568         * gtk/install-dependencies:
3569
3570 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
3571
3572         [Windows] Unreviewed change for NRWT support.
3573
3574         * Scripts/webkitpy/port/win.py:
3575         (WinPort.default_child_processes): Added a default implementation
3576         that limits NRWT to a single instance.
3577
3578 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
3579
3580         Remove meaningless "test_uses_apache" from Python test cases.
3581         https://bugs.webkit.org/show_bug.cgi?id=38756
3582
3583         Reviewed by Ryosuke Niwa.
3584
3585         * Scripts/webkitpy/port/port_testcase.py:
3586         (PortTestCase.test_driver_cmd_line): Remove the meaningless
3587         "test_uses_apache" test case from the Python test infrastructure.
3588         It was hard-coded to true, even though not all ports use
3589         Apache.
3590
3591 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
3592
3593         [Windows] Update new-run-webkit-tests for Windows port.
3594         https://bugs.webkit.org/show_bug.cgi?id=38756
3595
3596         Reviewed by Ryosuke Niwa.
3597
3598         * Scripts/new-run-webkit-httpd:
3599         (run): Switch from 'chromium' to 'win'
3600         * Scripts/webkitpy/port/win.py:
3601         (WinPort): Add support methods for lighttpd server.
3602         (WinPort._uses_apache):
3603         (WinPort._path_to_lighttpd):
3604         (WinPort._path_to_lighttpd_modules):
3605         (WinPort._path_to_lighttpd_php):
3606
3607 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
3608
3609         Make default bug links in buildbot clickable
3610         https://bugs.webkit.org/show_bug.cgi?id=116673
3611
3612         Reviewed by Ryosuke Niwa.
3613
3614         Use changecommentlink of html.WebStatus to make the links clickable.
3615
3616         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3617
3618 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
3619
3620         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
3621         https://bugs.webkit.org/show_bug.cgi?id=116595
3622
3623         Temporarily skip this test.
3624
3625         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
3626         (TestWebKitAPI::TEST):
3627
3628 2013-05-22  Alex Christensen  <achristensen@apple.com>
3629
3630         Unreviewed.  Added myself to contributors.json.
3631
3632         * Scripts/webkitpy/common/config/contributors.json:
3633         Added myself.
3634
3635 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3636
3637         [EFL][WK2] Add sub menus to MiniBrowser
3638         https://bugs.webkit.org/show_bug.cgi?id=114728
3639
3640         Reviewed by Christophe Dumez.
3641
3642         Elementary Ctxpopup widget API does not provide support for submenu item.
3643         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
3644         Elementary Menu widget.
3645
3646         * MiniBrowser/efl/main.c:
3647         (_Browser_Window):
3648         (on_window_resize):
3649         (window_free):
3650         (context_menu_item_selected_cb):
3651         (context_menu_populate):
3652         (on_context_menu_show):
3653         (on_context_menu_hide):
3654         (window_create):
3655
3656 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
3657
3658         [EFL] Add command line option to MiniBrowser to set cookies policy.
3659         https://bugs.webkit.org/show_bug.cgi?id=115028
3660
3661         Reviewed by Christophe Dumez.
3662
3663         Add command line option to MiniBrowser EFL to set cookies policy:
3664         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
3665         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
3666
3667         * MiniBrowser/efl/main.c:
3668         (elm_main):
3669
3670 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
3671
3672         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
3673         https://bugs.webkit.org/show_bug.cgi?id=116585
3674
3675         Rev