[Qt] Bail out when trying to build WebKit with Qt != 5
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
2
3         [Qt] Bail out when trying to build WebKit with Qt != 5
4
5         Reviewed by Tor Arne Vestbø.
6
7         Moved check for Qt version out of default_pre into top-level WebKit.pro,
8         because we never reach default_pre.prf due to the lack of .qmake.conf support
9         in older versions of Qt/QMake.
10
11         * qmake/mkspecs/features/default_pre.prf:
12
13 2012-09-21  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
14
15         WebKitTestRunner needs to print frame load delegate information
16         https://bugs.webkit.org/show_bug.cgi?id=42705
17
18         Reviewed by Kenneth Rohde Christiansen.
19
20         Added missing dumping from WTR::InjectedBundlePage::didFailLoadWithErrorForFrame.
21
22         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
23         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
24
25 2012-09-21  Christophe Dumez  <christophe.dumez@intel.com>
26
27         [EFL] EventSender should mimic CTRL+o emacs shortcut
28         https://bugs.webkit.org/show_bug.cgi?id=97224
29
30         Reviewed by Kenneth Rohde Christiansen.
31
32         Add support for mimicking CTRL+o emacs shortcut in EFL's
33         EventSender in DumpRenderTree and WebKitTestRunner.
34
35         * DumpRenderTree/efl/EventSender.cpp:
36         (sendKeyDown):
37         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
38         (WTR::EventSenderProxy::keyDown):
39
40 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
41
42         [Qt] Re-fix clean builds
43
44         Reviewed by Tor Arne Vestbø.
45
46         Re-introduce the sanitization for LIBS when creating a module to use
47         LIBS_PRIVATE and otherwise do _not_ use LIBS_PRIVATE. We decided to
48         continue to use QT, LIBS and PKGCONFIG instead of their _PRIVATE variants
49         throughout the code base, so just using LIBS_PRIVATE in linkAgainstLibrary()
50         causes build issues when depending system libraries end up in LIBS before
51         LIBS_PRIVATE.
52
53         * qmake/mkspecs/features/default_post.prf:
54         * qmake/mkspecs/features/functions.prf:
55
56 2012-09-20  Simon Fraser  <simon.fraser@apple.com>
57
58         Comment out a failing webkitpy unit test until Dirk can fix it.
59
60         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
61         (SemanticTests.test_skip_and_wontfix):
62
63 2012-09-20  Dirk Pranke  <dpranke@chromium.org>
64
65         make Skip, WontFix be the only expectations on a line
66         https://bugs.webkit.org/show_bug.cgi?id=97225
67
68         Reviewed by Ojan Vafai.
69
70         It is now incorrect in the new syntax to have a line like:
71
72             foo.html [ WontFix Crash ]
73
74         This will generate a lint warning and be treated as an invalid
75         line. Fixing this caused a whole bunch of unit tests to need updating
76         to no longer be marked as WontFix :). Also, this patch adjusts
77         the warnings so that missing Bug() identifiers will cause lint
78         warnings but will *not* cause the line to be treated as invalid.
79         Fixing these issues also revealed that test_hung_thread was no
80         longer testing the right logic, so I adjusted the timeouts in
81         test.py to make that test work again.
82
83         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
84         (Worker._run_test_in_another_thread):
85         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
86         (ResultSummaryTest.test_summarized_results_wontfix):
87         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
88         (TestExpectationParser._parse_modifiers):
89         (TestExpectationParser._tokenize_line_using_new_format):
90         (TestExpectationLine.is_invalid):
91         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
92         (BasicTests.test_basic):
93         (test_get_test_set):
94         (test_parse_warning):
95         (test_pixel_tests_flag):
96         (SemanticTests.test_missing_bugid):
97         (SemanticTests):
98         (SemanticTests.test_skip_and_wontfix):
99         * Scripts/webkitpy/layout_tests/port/test.py:
100         (TestDriver.run_test):
101         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
102         (MainTest.test_hung_thread):
103         * Scripts/webkitpy/tool/commands/queries_unittest.py:
104         (PrintExpectationsTest.test_basic):
105         (PrintExpectationsTest.test_multiple):
106         (PrintExpectationsTest.test_full):
107         (PrintExpectationsTest.test_exclude):
108         (PrintExpectationsTest.test_csv):
109
110 2012-09-20  Lucas Forschler  <lforschler@apple.com>
111
112         Unreviewed.  Start running tests on the mac-ews.
113         
114         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
115         (MacEWS):
116
117 2012-09-20  Tony Chang  <tony@chromium.org>
118
119         [chromium] Enable more clang warnings
120         https://bugs.webkit.org/show_bug.cgi?id=97257
121
122         Reviewed by James Robinson.
123
124         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add -Wunused-parameter. Don't add -Wglobal-constructors because
125         there are lots of violations in these files.
126
127 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
128
129         run-perf-tests should record individual value instead of statistics
130         https://bugs.webkit.org/show_bug.cgi?id=97155
131
132         Reviewed by Hajime Morita.
133
134         Parse the list of individual value reported by tests and include them as "values".
135         We strip "values" from the output JSON when uploading it to the perf-o-matic
136         since it doesn't know how to parse "values" or ignore it.
137
138         * Scripts/webkitpy/performance_tests/perftest.py:
139         (PerfTest):
140         (PerfTest.parse_output): Parse and report "values".
141         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
142         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
143         (MainTest.test_parse_output):
144         (MainTest.test_parse_output_with_failing_line):
145         (TestPageLoadingPerfTest.test_run):
146         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
147         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
148         until we update perf-o-matic.
149         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
150         (test_run_memory_test):
151         (test_run_with_json_output):
152         (test_run_with_description):
153         (test_run_with_slave_config_json):
154         (test_run_with_multiple_repositories):
155
156 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
157
158         [Qt] Fix production builds
159
160         Unreviewed trivial fix: Follow up r129119 and avoid clobbering LIBS through the use of LIBS_PRIVATE.
161
162         Otherwise the libQtWebKit.prl file for example contains -lWebKit1 -lWebCore, etc.
163
164         * qmake/mkspecs/features/functions.prf:
165
166 2012-09-20  Dirk Pranke  <dpranke@chromium.org>
167
168         REGRESSION: layout test results doesn't show diffs
169         https://bugs.webkit.org/show_bug.cgi?id=97182
170
171         Reviewed by Ojan Vafai.
172
173         Go back to storing TEXT, AUDIO, and IMAGE+TEXT in results.json
174         so that results.html (and hopefully garden-o-matic) can
175         determine which things actually failed. However, we keep mapping
176         these results to Failure so that we still only have a single
177         expectation type for them.
178
179         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
180         (JSONLayoutResultsGenerator):
181         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
182         (TestExpectationParser):
183         (TestExpectations):
184         (TestExpectations.result_was_expected):
185         * Scripts/webkitpy/layout_tests/models/test_failures.py:
186         (determine_result_type):
187         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
188         (MainTest.test_missing_and_unexpected_results):
189         (MainTest.test_retrying_and_flaky_tests):
190
191 2012-09-20  Tommy Widenflycht  <tommyw@google.com>
192
193         MediaStream API: Extend UserMediaRequest with a ownerDocument method
194         https://bugs.webkit.org/show_bug.cgi?id=97095
195
196         Reviewed by Adam Barth.
197
198         Extending WebUserMediaClientMock to check that the owning document is valid,
199         and that the document has a frame.
200
201         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
202         (WebKit::WebUserMediaClientMock::requestUserMedia):
203
204 2012-09-20  Stephen Chenney  <schenney@chromium.org>
205
206         [Chromium] DRT does not support --dump-all-pixels flag
207         https://bugs.webkit.org/show_bug.cgi?id=95098
208
209         Reviewed by Dirk Pranke.
210
211         Add support for the --pixel-tests and shorthand -p option in Chromium DumpRenderTree. Use
212         of this flag causes pixel results to be created for all tests, regardless of
213         individual test options. If an individual test provides a pixel hash it will be used,
214         otherwise the hash will be empty. This replaces a previously defined but unused option
215         --dump-all-pixels, and is useful primarily when debugging DRT instances.
216
217         * DumpRenderTree/chromium/DumpRenderTree.cpp:
218         (runTest): Add a parameter and code to force pixel results for the test.
219         (main): Add parameter handling for --pixels-test and -p, and remove --dump-all-pixels.
220
221 2012-09-20  Carlos Garcia Campos  <cgarcia@igalia.com>
222
223         [GTK] run-api-tests should not buffer test stdout
224         https://bugs.webkit.org/show_bug.cgi?id=88474
225
226         Reviewed by Philippe Normand.
227
228         * Scripts/run-gtk-tests:
229         (TestRunner._run_test_command): Use os.forkpty() instead of
230         subprocess.Popen() so that gtest sends the output with colors to
231         stdout. Use common.parse_output_lines() to parse the output and
232         write it to stdout while it's read.
233         (TestRunner._run_test_command.parse_line): Parse the line to get
234         the test pid and write the line to stdout.
235         (TestRunner._run_test_command.waitpid): Helper function to call
236         waitpid handling EINTR.
237         (TestRunner._run_test_command.return_code_from_exit_status):
238         Helper function to convert exit status of test commands to a
239         return code.
240         * gtk/common.py:
241         (parse_output_lines): Helper function that uses select to read
242         the given file descriptor and call the given callback for every
243         line read.
244
245 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
246
247         [Qt] Fix initial build
248
249         Reviewed by Tor Arne Vestbø.
250
251         When building QtWebKit the first time there is no qt_webkit.pri module pri file, and therefore
252         $$QT.webkit.name isn't set and so creating_module isn't set. That has all sorts of implications
253         causing incorrect linking for Makefile.api, etc.
254
255         Fix the determination by simply checking if MODULE is set, which only happens in api.pri.
256
257         * qmake/mkspecs/features/webkit_modules.prf:
258
259 2012-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
260
261         Unreviewed, rolling out r129091.
262         http://trac.webkit.org/changeset/129091
263         https://bugs.webkit.org/show_bug.cgi?id=97205
264
265         It broke perf tests everywhere (Requested by Ossy on #webkit).
266
267         * Scripts/webkitpy/performance_tests/perftest.py:
268         (PerfTest):
269         (PerfTest.parse_output):
270         (PageLoadingPerfTest.run):
271         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
272         (MainTest.test_parse_output):
273         (MainTest.test_parse_output_with_failing_line):
274         (TestPageLoadingPerfTest.test_run):
275         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
276         (PerfTestsRunner._generate_and_show_results):
277         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
278         (test_run_memory_test):
279         (test_run_with_json_output):
280         (test_run_with_description):
281         (test_run_with_slave_config_json):
282         (test_run_with_multiple_repositories):
283
284 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
285
286         [Qt] QtWebKit module header includes private dependencies
287
288         Reviewed by Tor Arne Vestbø.
289
290         * qmake/mkspecs/features/default_post.prf: Don't try to sanitize LIBS, because we can make sure
291         that LIBS_PRIVATE is set from the beginning. Moved the creating_module and PKGCONFIG/QT(_PRIVATE)
292         sanitization into webkit_modules.prf. creating_module determination requires TARGET to be set, so
293         we can't do it in default_pre.
294         * qmake/mkspecs/features/webkit_modules.prf:
295
296 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
297
298         [Qt] Fix build with MingW
299
300         Reviewed by Tor Arne Vestbø.
301
302         Don't try to compile WebCore, etc. with debug symbols for production
303         builds, it's just too big.
304
305         * qmake/mkspecs/features/production_build.prf:
306
307 2012-09-20  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
308
309         [EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
310         https://bugs.webkit.org/show_bug.cgi?id=97087
311
312         Reviewed by Gyuyoung Kim.
313
314         Add focusing a main frame on settings reset.
315         After editing/undo/undo-iframe-location-change was executed a frame
316         was left in unfocused state. This caused flakiness in two tests results.
317
318         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
319         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
320
321 2012-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
322
323         [Qt] Add eventSender.gestureTap
324         https://bugs.webkit.org/show_bug.cgi?id=66173
325
326         Reviewed by Kenneth Rohde Christiansen.
327
328         Implement support for sending raw QGesture events.
329
330         * DumpRenderTree/qt/EventSenderQt.cpp:
331         (EventSender::EventSender):
332         (EventSender::gestureTap):
333         * DumpRenderTree/qt/EventSenderQt.h:
334         (EventSender):
335
336 2012-09-19  Sheriff Bot  <webkit.review.bot@gmail.com>
337
338         Unreviewed, rolling out r129007.
339         http://trac.webkit.org/changeset/129007
340         https://bugs.webkit.org/show_bug.cgi?id=97172
341
342         It broke the build on the Qt bots (Requested by Ossy on
343         #webkit).
344
345         * qmake/config.tests/gccdepends/empty.cpp:
346         * qmake/config.tests/gccdepends/gccdepends.pro:
347         * qmake/mkspecs/features/default_pre.prf:
348
349 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
350
351         run-perf-tests should record indivisual value instead of statistics
352         https://bugs.webkit.org/show_bug.cgi?id=97155
353
354         Reviewed by Hajime Morita.
355
356         Parse the list of indivisual value reported by tests and include them as "values".
357         We strip "values" from the output JSON when uploading it to the perf-o-matic
358         since it doesn't know how to parse "values" or ignore it.
359
360         * Scripts/webkitpy/performance_tests/perftest.py:
361         (PerfTest):
362         (PerfTest.parse_output): Parse and report "values".
363         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
364         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
365         (MainTest.test_parse_output):
366         (MainTest.test_parse_output_with_failing_line):
367         (TestPageLoadingPerfTest.test_run):
368         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
369         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
370         until we update perf-o-matic.
371         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
372         (test_run_memory_test):
373         (test_run_with_json_output):
374         (test_run_with_description):
375         (test_run_with_slave_config_json):
376         (test_run_with_multiple_repositories):
377
378 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
379
380         Fix regex groups for bug matching in flakiness dashboard.
381         https://bugs.webkit.org/show_bug.cgi?id=97152
382
383         Unreviewed, build fix.
384
385         * TestResultServer/static-dashboards/flakiness_dashboard.js:
386         (htmlForBugs):
387
388 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
389
390         nrwt: print unexpected results using new TestExpectations syntax
391         https://bugs.webkit.org/show_bug.cgi?id=97159
392
393         Unreviewed, build fix.
394
395         Change new-run-webkit-tests to print out failures using the new
396         syntax when there are unexpected results, e.g.:
397
398         52 tests ran as expected, 19 didn't:
399
400
401         Regressions: Unexpected failures : (2)
402           failures/flaky/text.html [ Failure ]
403           failures/unexpected/text-image-checksum.html [ Failure ]
404
405         and so forth
406
407         * Scripts/webkitpy/layout_tests/views/printing.py:
408         (Printer._print_unexpected_results):
409
410 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
411
412         update flakiness dashboard after cutover to new test expectations syntax
413         https://bugs.webkit.org/show_bug.cgi?id=97152
414
415         Unreviewed, build fix.
416
417         Handle (??) the new Bug notations as well. Hopefully we don't
418         still need the old ones.
419
420         * TestResultServer/static-dashboards/flakiness_dashboard.js:
421         (filterBugs):
422         (htmlForBugs):
423         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
424
425 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
426
427         update flakiness dashboard after cutover to new test expectations syntax
428         https://bugs.webkit.org/show_bug.cgi?id=97152
429
430         Reviewed by Ryosuke Niwa.
431
432         This change clones the TestExpectation parsing state machine
433         from python into javascript.
434
435         * TestResultServer/static-dashboards/flakiness_dashboard.js:
436         (parsedExpectations.lines.forEach):
437         (parsedExpectations):
438         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
439
440 2012-09-19  Dana Jansens  <danakj@chromium.org>
441
442         Add backer@chromium.org as contributor
443         https://bugs.webkit.org/show_bug.cgi?id=97150
444
445         * Scripts/webkitpy/common/config/committers.py:
446
447 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
448
449         fix MISSING after TestExpectations conversion
450         https://bugs.webkit.org/show_bug.cgi?id=97148
451
452         Unreviewed, expectations change / build fix.
453
454         * Scripts/convert-test-expectations:
455         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
456         (TestExpectationParser):
457
458 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
459
460         nrwt: convert chromium TestExpectations to the new syntax
461         https://bugs.webkit.org/show_bug.cgi?id=97139
462
463         Reviewed by Ryosuke Niwa.
464     
465         Add in a file temporarily that does the conversion of
466         test expectations formats
467
468         * Tools/Scripts/convert-test-expectations: Added.
469
470 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
471
472         REGRESSION: run-perf-tests no longer reports the total test time
473         https://bugs.webkit.org/show_bug.cgi?id=97138
474
475         Reviewed by Tony Chang.
476
477         Report the finished time as a info-level log as opposed to a debug level log.
478
479         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
480         (PerfTestsRunner._run_single_test):
481         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
482         (MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
483         (test_run_test_pause_before_testing):
484         (test_run_test_set_for_parser_tests):
485         (test_run_memory_test):
486         (_test_run_with_json_output):
487
488 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
489
490         Support new TestExpectations format alongside old one
491         https://bugs.webkit.org/show_bug.cgi?id=96588
492
493         Reviewed by Ojan Vafai.
494
495         This patch adds support for actually reading in lines formatted
496         in the new style, and when we re-serialize/write out the file,
497         all lines will be written in the new style. Note that reading in
498         the old style is still supported, and no updates are being made
499         to the actual TestExpectations files as part of this change.
500
501         This change updates most but not all of the unit tests to use
502         the new syntax. I will update the rest when (or before where
503         possible) I drop support for the old format.
504
505         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
506         (TestExpectationParser):
507         (TestExpectationParser._tokenize_line):
508         (TestExpectationParser._tokenize_line_using_new_format):
509         (TestExpectationLine.to_string):
510         (TestExpectationLine._format_line):
511         (TestExpectations):
512         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
513         (test_parse_warning):
514         (SkippedTests.test_skipped_entry_dont_exist):
515         (NewExpectationSyntaxTests.test_warnings):
516         (RemoveConfigurationsTest.test_remove):
517         (test_remove_line):
518         (RebaseliningTest.test_remove):
519         (RebaseliningTest.test_no_get_rebaselining_failures):
520         (TestExpectationParserTests.test_tokenize_blank):
521         (TestExpectationParserTests.test_tokenize_extra_colon):
522         (TestExpectationParserTests.test_tokenize_missing_equal):
523         (TestExpectationParserTests.test_tokenize_extra_equal):
524         (TestExpectationSerializationTests.test_unparsed_to_string):
525         (TestExpectationSerializationTests.test_unparsed_list_to_string):
526         (TestExpectationSerializationTests.test_parsed_to_string):
527         (TestExpectationSerializationTests.test_format_line):
528         (TestExpectationSerializationTests.test_string_roundtrip):
529         (TestExpectationSerializationTests.test_list_roundtrip):
530         (TestExpectationSerializationTests.test_reconstitute_only_these):
531         (TestExpectationSerializationTests.test_string_whitespace_stripping):
532         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
533         (LintTest.test_lint_test_files__errors):
534         * Scripts/webkitpy/tool/commands/queries_unittest.py:
535         (PrintExpectationsTest.test_basic):
536         (PrintExpectationsTest.test_multiple):
537         (PrintExpectationsTest.test_full):
538         (PrintExpectationsTest.test_exclude):
539         * Scripts/webkitpy/tool/commands/rebaseline.py:
540         (RebaselineExpectations.execute):
541         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
542         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
543         (test_rebaseline_updates_expectations_file):
544         (test_rebaseline_does_not_include_overrides):
545         (test_rebaseline_expectations_noop):
546         (test_overrides_are_included_correctly):
547
548 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
549
550         implement first part of support for the new TestExpectations syntax
551         https://bugs.webkit.org/show_bug.cgi?id=96569
552
553         Reviewed by Ryosuke Niwa.
554
555         This patch implements support for parsing a line of the new
556         format for the TestExpectations file and converting it back into
557         the old format for compatibility. This routine is not yet used
558         by anything.
559
560         The new format is documented at:
561           http://trac.webkit.org/wiki/TestExpectations
562
563         but, in short:
564
565           [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]
566
567         - Comments are indicated with "#" instead of "//"
568         - If no expectations are specified we default to Skip for
569           compatibility with the Skipped files (these two changes make
570           Skipped files a subset of TestExpectations files)
571
572         - All of the tokens are now CamelCase instead of ALLCAPS.
573         - FAIL -> Failure
574         - IMAGE -> ImageOnlyFailure
575         - WONTFIX -> WontFix
576         - modifiers refer to just the platforms and configurations
577           (release/debug) that the line applies to.
578         - WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
579           expectations
580         - expectations will typically be written out in lexicographic order
581         - We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
582           instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.
583
584         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
585         (TestExpectationParser):
586         (TestExpectationParser._tokenize_line_using_new_format):
587         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
588         (NewExpectationSyntaxTests):
589         (NewExpectationSyntaxTests.assert_exp):
590         (NewExpectationSyntaxTests.test_bare_name):
591         (NewExpectationSyntaxTests.test_bare_name_and_bugs):
592         (NewExpectationSyntaxTests.test_comments):
593         (NewExpectationSyntaxTests.test_config_modifiers):
594         (NewExpectationSyntaxTests.test_unknown_config):
595         (NewExpectationSyntaxTests.test_unknown_expectation):
596         (NewExpectationSyntaxTests.test_skip):
597         (NewExpectationSyntaxTests.test_slow):
598         (NewExpectationSyntaxTests.test_wontfix):
599         (NewExpectationSyntaxTests.test_blank_line):
600         (NewExpectationSyntaxTests.test_warnings):
601
602 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
603
604         nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
605         https://bugs.webkit.org/show_bug.cgi?id=96845
606
607         Reviewed by Ojan Vafai.
608
609         In preparation for the new TestExpectations syntax, we replace
610         all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
611         make switching to the new syntax lossless (i.e., we lose
612         information now, not then).
613
614         Note that we can still parse in results.json files that have the
615         old data for backwards compatibility.
616         
617
618         * Scripts/webkitpy/common/net/resultsjsonparser.py:
619         (JSONTestResult._failure_types_from_actual_result):
620         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
621         (ResultsJSONParserTest):
622         (test_basic):
623         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
624         (ResultSummaryTest.test_summarized_results_wontfix):
625         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
626         (JSONLayoutResultsGenerator):
627         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
628         (TestExpectations):
629         (TestExpectations.remove_pixel_failures):
630         (TestExpectations.has_pixel_failures):
631         (TestExpectations.suffixes_for_expectations):
632         (TestExpectations.get_rebaselining_failures):
633         (TestExpectations.remove_configuration_from_test):
634         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
635         (assert_bad_expectations):
636         (BasicTests):
637         (BasicTests.test_basic):
638         (MiscTests):
639         (MiscTests.test_multiple_results):
640         (MiscTests.test_result_was_expected):
641         (MiscTests.test_remove_pixel_failures):
642         (MiscTests.test_suffixes_for_expectations):
643         (test_get_expectations_string):
644         (test_parse_warning):
645         (test_error_on_different_platform):
646         (test_error_on_different_build_type):
647         (test_overrides):
648         (test_overrides__directory):
649         (test_overrides__duplicate):
650         (test_pixel_tests_flag):
651         (test_more_specific_override_resets_skip):
652         (SkippedTests.test_skipped_file_overrides_expectations):
653         (SkippedTests.test_skipped_dir_overrides_expectations):
654         (SkippedTests.test_skipped_file_overrides_overrides):
655         (SkippedTests.test_skipped_dir_overrides_overrides):
656         (ExpectationSyntaxTests.test_missing_colon):
657         (ExpectationSyntaxTests.test_too_many_equals_signs):
658         (SemanticTests.test_bug_format):
659         (SemanticTests.test_bad_bugid):
660         (SemanticTests.test_missing_bugid):
661         (SemanticTests.test_rebaseline):
662         (test_missing_file):
663         (test_more_modifiers):
664         (test_order_in_file):
665         (test_macro_overrides):
666         (RemoveConfigurationsTest.test_remove):
667         (test_remove_line):
668         (RebaseliningTest.test_remove):
669         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
670         * Scripts/webkitpy/layout_tests/models/test_failures.py:
671         (determine_result_type):
672         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
673         (test_test_expectations):
674         * Scripts/webkitpy/layout_tests/port/test.py:
675         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
676         (MainTest.test_missing_and_unexpected_results):
677         (MainTest.test_retrying_and_flaky_tests):
678         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
679         (TestExpectationsTestCase.test_valid_expectations):
680         * Scripts/webkitpy/tool/commands/queries_unittest.py:
681         (PrintExpectationsTest.test_basic):
682         (PrintExpectationsTest.test_multiple):
683         (PrintExpectationsTest.test_full):
684         (PrintExpectationsTest.test_exclude):
685         (PrintExpectationsTest.test_csv):
686         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
687         (test_rebaseline_does_not_include_overrides):
688         (test_overrides_are_included_correctly):
689
690 2012-09-19  Dominic Mazzoni  <dmazzoni@google.com>
691
692         AX: A few control types are returning the wrong answer for isReadOnly
693         https://bugs.webkit.org/show_bug.cgi?id=96735
694
695         Reviewed by Chris Fleizach.
696
697         Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.
698
699         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
700         (AccessibilityUIElement::AccessibilityUIElement):
701         (AccessibilityUIElement::isReadOnlyGetterCallback):
702         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
703         (AccessibilityUIElement):
704
705 2012-09-19  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
706
707         [WTR] Memory leaks in TestRunner::deliverWebIntent()
708         https://bugs.webkit.org/show_bug.cgi?id=97111
709
710         Reviewed by Kenneth Rohde Christiansen.
711
712         Fix memory leaks in deliverWebIntent() by adopting strings
713         created with WKStringCreateWithUTF8CString().
714
715         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
716         (WTR::TestRunner::deliverWebIntent):
717
718 2012-09-19  Simon Hausmann  <simon.hausmann@digia.com>
719
720         [Qt] Fix incremental builds with all-in-one-files and gccdepends
721
722         Reviewed by Tor Arne Vestbø.
723
724         Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
725         are not only created for header files but also for .cpp files. AllInOne.cpp files
726         include other .cpp files, and when those are removed we need those dummy rules to
727         avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
728
729         * qmake/config.tests/gccdepends/empty.cpp:
730         (main):
731         * qmake/config.tests/gccdepends/gccdepends.pro:
732         * qmake/mkspecs/features/default_pre.prf:
733
734 2012-09-19  Rick Byers  <rbyers@chromium.org>
735
736         Do touch adjustment on GestureTapDown
737         https://bugs.webkit.org/show_bug.cgi?id=96677
738
739         Reviewed by Antonio Gomes.
740
741         Allow radius to be set for GestureTapDown events.
742         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
743         (EventSender::gestureEvent):
744
745 2012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
746
747         [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
748         https://bugs.webkit.org/show_bug.cgi?id=97100
749
750         Reviewed by Gyuyoung Kim.
751
752         EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
753         preference, in order to match WebKitTestRunner functionality.
754
755         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
756         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
757         * DumpRenderTree/efl/TestRunnerEfl.cpp:
758         (TestRunner::overridePreference):
759
760 2012-09-18  Kangil Han  <kangil.han@samsung.com>
761
762         [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
763         https://bugs.webkit.org/show_bug.cgi?id=96181
764
765         Reviewed by Daniel Bates.
766
767         This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
768
769         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
770         (new):
771         (_parseLicenseBlock):
772         (_parseLicenseBlockFromFile):
773         (_defaultLicenseBlock):
774         (_licenseBlock):
775         (_generateHeaderFile):
776         (_generateImplementationFile):
777
778 2012-09-18  Byungwoo Lee  <bw80.lee@samsung.com>
779
780         Title string should be changed when document.title is set to ''.
781         https://bugs.webkit.org/show_bug.cgi?id=96793
782
783         Reviewed by Kenneth Rohde Christiansen.
784
785         Change dump format of dumpTitleChanges more understandable.
786         Uses single quotation marks for the title string.
787
788         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
789         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
790         * DumpRenderTree/chromium/WebViewHost.cpp:
791         (WebViewHost::didReceiveTitle):
792         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
793         (DumpRenderTreeChrome::onFrameTitleChanged):
794         * DumpRenderTree/gtk/DumpRenderTree.cpp:
795         (webViewTitleChanged):
796         * DumpRenderTree/mac/FrameLoadDelegate.mm:
797         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
798         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
799         (WebCore::DumpRenderTree::titleChanged):
800         * DumpRenderTree/win/FrameLoadDelegate.cpp:
801         (FrameLoadDelegate::didReceiveTitle):
802         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
803         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
804         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
805         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
806
807 2012-09-18  Szilard Ledan  <szledan@inf.u-szeged.hu>
808
809         EWS shouldn't sleep if there are new patches in its queue
810         https://bugs.webkit.org/show_bug.cgi?id=83038
811
812         Reviewed by Eric Seidel.
813
814         EWS tries to process a security patch. Of course it can't, because the EWS isn't
815         the member of the security group. But the problem is that after it can't process
816         the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
817         and push the security patch to the end of the queue.
818         Now it stays in the loop until it finds a patch or the queue gets empty.
819
820         * Scripts/webkitpy/tool/commands/queues.py:
821         (AbstractPatchQueue._next_patch):
822         * Scripts/webkitpy/tool/commands/queues_unittest.py:
823         (AbstractPatchQueueTest.test_next_patch):
824
825 2012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
826
827         [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
828         https://bugs.webkit.org/show_bug.cgi?id=97014
829
830         Reviewed by Kenneth Rohde Christiansen.
831
832         According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
833         be used for literals rather than WTF::StringBuilder::append().
834
835         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
836         (WTR::InjectedBundle::booleanForKey):
837
838 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
839
840         Update my e-mail address.
841
842         * Scripts/webkitpy/common/config/committers.py:
843
844 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
845
846         Update my e-mail address.
847
848         Unreviewed.
849
850         * Scripts/webkitpy/common/config/committers.py:
851
852 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
853
854         [Qt] qt_webkit.pri should not be listed in Tools.pro
855
856         Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
857
858         Since r128751 the module pri file is auto-generated
859         but it was still listed in OTHER_FILES.
860
861         * Tools.pro: Remove unneeded line.
862
863 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
864
865         [Qt] Fix build with some versions of the gold linker
866
867         Reviewed by Tor Arne Vestbø.
868
869         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
870         Instead run a compile/link test first to see if it works.
871
872         * qmake/config.tests/gnuld/gnuld.pro: Added.
873         * qmake/config.tests/gnuld/main.cpp: Added.
874         (main):
875         * qmake/mkspecs/features/unix/default_post.prf:
876
877 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
878
879         [Qt] Remove forced use of gold.
880
881         Reviewed by Tor Arne Vestbø.
882
883         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
884         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
885         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
886
887         * qmake/mkspecs/features/unix/default_post.prf:
888
889 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
890
891         [Qt] Prospective Qt/Windows cross-compiling fix
892
893         Reviewed by Tor Arne Vestbø.
894
895         The win32 scope is not set when cross-compiling from Linux to Windows.
896
897         * qmake/mkspecs/features/functions.prf:
898
899 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
900
901         [EFL] Remove background view on EWebLauncher and MiniBrowser
902         https://bugs.webkit.org/show_bug.cgi?id=96905
903
904         Reviewed by Gyuyoung Kim.
905
906         The size of webview was changed after adding url bar.
907         And the background view is not necessary anymore, since it was used for debugging back in the day.
908
909         * EWebLauncher/main.c:
910         (_ELauncher):
911         (on_ecore_evas_resize):
912         (browserCreate):
913         * MiniBrowser/efl/main.c:
914         (_MiniBrowser):
915         (on_ecore_evas_resize):
916         (browserCreate):
917
918 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
919
920         [GTK] run-webkit-tests unable to find TestExpectations for WK2
921         https://bugs.webkit.org/show_bug.cgi?id=96998
922
923         Reviewed by Philippe Normand.
924
925         We should look for TestExpectations files in all the locations where
926         we currently look for Skipped files. This will allow
927         run-webkit-tests to look for TestExpectations files in
928         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
929
930         * Scripts/webkitpy/layout_tests/port/gtk.py:
931         (GtkPort.expectations_files):
932
933 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
934
935         [Qt] Fix build without the QtQuick module
936
937         Reviewed by Simon Hausmann.
938
939         * qmake/mkspecs/features/features.prf:
940
941 2012-09-18  Stephanie Lewis  <slewis@apple.com>
942
943         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
944
945         Unreviewed.
946
947         * DumpRenderTree/mac/DumpRenderTree.mm:
948         (poseAsClass):
949
950 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
951
952         Unreviewed update of email addresses for Berlin QtWebKit office.
953
954         * Scripts/webkitpy/common/config/committers.py:
955
956 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
957
958         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
959         https://bugs.webkit.org/show_bug.cgi?id=96899
960
961         Reviewed by Martin Robinson.
962
963         When overriding the 'WebKitDisplayImageKey' preference, use the
964         'auto-load-images' property of WebKitWebSettings as the property which
965         should be updated with the corresponding preference value.
966
967         * DumpRenderTree/gtk/DumpRenderTree.cpp:
968         (resetDefaultsToConsistentValues):
969         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
970         (TestRunner::overridePreference):
971
972 2012-09-17  Pratik Solanki  <psolanki@apple.com>
973
974         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
975         https://bugs.webkit.org/show_bug.cgi?id=96973
976
977         Reviewed by Dan Bernstein.
978
979         * DumpRenderTree/mac/Configurations/Base.xcconfig:
980         * WebKitTestRunner/Configurations/Base.xcconfig:
981         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
982
983 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
984
985         nrwt: remove "unexpected EOF" warnings
986         https://bugs.webkit.org/show_bug.cgi?id=96970
987
988         Reviewed by Ojan Vafai.
989
990         After debugging this a bit, it looks like there aren't any cases
991         that I can reproduce where a read() of zero indicates something
992         actually wrong; either it is a prelude to a crash, or a false
993         negative. So, I'm removing these warnings and adding a comment.
994
995         * Scripts/webkitpy/layout_tests/port/server_process.py:
996         (ServerProcess._wait_for_data_and_update_buffers_using_select):
997
998 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
999
1000         [chromium] ASAN bot is crashing at the end of the run
1001         https://bugs.webkit.org/show_bug.cgi?id=96967
1002
1003         Reviewed by Abhishek Arya.
1004
1005         The ASAN bot is crashing attempting to decode some output into
1006         UTF-8; there's no reason to do this, so let's not do this and
1007         see if something else is going on as well.
1008
1009         * Scripts/webkitpy/layout_tests/port/chromium.py:
1010         (ChromiumPort._get_crash_log):
1011
1012 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
1013
1014         nrwt: --results-directory isn't getting printed properly
1015         https://bugs.webkit.org/show_bug.cgi?id=96965
1016
1017         Reviewed by Ojan Vafai.
1018
1019         options.results_directory isn't actually initialized with the
1020         default values until after we call print_config(), so this
1021         changes things to print the value directly.
1022
1023         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1024         (run):
1025         * Scripts/webkitpy/layout_tests/views/printing.py:
1026         (Printer.print_config):
1027         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1028         (Testprinter.test_print_config):
1029
1030 2012-09-17  Rob Buis  <rbuis@rim.com>
1031
1032         [BlackBerry] Enable VIDEO_TRACK
1033         https://bugs.webkit.org/show_bug.cgi?id=96949
1034
1035         Reviewed by Antonio Gomes.
1036
1037         * Scripts/webkitperl/FeatureList.pm:
1038
1039 2012-09-17  Rick Byers  <rbyers@chromium.org>
1040
1041         Add handling of new GestureTapCancel in DRT
1042
1043         https://bugs.webkit.org/show_bug.cgi?id=96183
1044
1045         Reviewed by Antonio Gomes.
1046
1047         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1048         (TestWebPlugin::handleInputEvent):
1049         * DumpRenderTree/chromium/EventSender.cpp:
1050         (EventSender::gestureTapCancel):
1051
1052 2012-09-17  Philip Rogers  <pdr@google.com>
1053
1054         Teach style checker about preprocessor directive indentation rules
1055         https://bugs.webkit.org/show_bug.cgi?id=96874
1056
1057         Reviewed by Adam Barth.
1058
1059         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
1060         This is not explicit in our style guide but is generally followed in our code.
1061         Searching for violations in our codebase shows these are rarely indented:
1062             #include - indented in 6 files
1063             #ifdef - indented in 0 files
1064             #ifndef - indented in 1 file
1065             #define - indented in 11 files
1066             #if - indented in 7 files
1067
1068         * Scripts/webkitpy/style/checkers/cpp.py:
1069         (check_directive_indentation):
1070
1071             This is the simple test where we look for spaces followed by a #.
1072
1073         (check_style):
1074         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1075
1076             A few tests needed to be modified because they had unintentionally indented
1077             preprocessor directives.
1078
1079         (CppStyleTest.test_build_class.Foo):
1080         (CppStyleTest.test_build_class):
1081         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
1082         (WebKitStyleTest.test_line_breaking):
1083         (WebKitStyleTest.test_directive_indentation):
1084
1085 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1086
1087         [Qt] Auto-generate the module pri file for QtWebKit
1088
1089         Reviewed by Simon Hausmann.
1090
1091         * qmake/qt_webkit.pri: Removed.
1092
1093 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
1094
1095         nrwt: --additional-platform-dir is broken on chromium ports
1096         https://bugs.webkit.org/show_bug.cgi?id=96840
1097
1098         Reviewed by Ojan Vafai.
1099
1100         Looks like I broke this when cleaning things up as part of
1101         adding ML support. Fixing and adding a test.
1102
1103         * Scripts/webkitpy/layout_tests/port/chromium.py:
1104         (ChromiumPort.default_baseline_search_path):
1105         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1106         (ChromiumAndroidPort.default_baseline_search_path):
1107         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1108         (ChromiumLinuxPort.default_baseline_search_path):
1109         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1110         (ChromiumMacPort.__init__):
1111         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1112         (ChromiumWinPort.setup_environ_for_server):
1113         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1114         (test_check_build):
1115         (test_additional_platform_directory):
1116
1117 2012-09-13  Stephanie Lewis  <slewis@apple.com>
1118
1119         mac-future ignores previous platform TestExpectations.
1120         https://bugs.webkit.org/show_bug.cgi?id=96718.
1121
1122         Reviewed by Dirk Pranke.
1123
1124         TestExpectations match an expectation's configuraton against a list of configurations that are 
1125         valid for that port.  That list does not contain mac-future so none of the expectations can be
1126         applied.
1127
1128         * Scripts/webkitpy/layout_tests/port/apple.py:
1129         (ApplePort._generate_all_test_configurations):
1130
1131 2012-09-14  Adam Barth  <abarth@webkit.org>
1132
1133         Remove webkitPostMessage
1134         https://bugs.webkit.org/show_bug.cgi?id=96577
1135
1136         Reviewed by Ojan Vafai.
1137
1138         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
1139
1140         * Scripts/webkitperl/FeatureList.pm:
1141         * qmake/mkspecs/features/features.pri:
1142
1143 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
1144
1145         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
1146         https://bugs.webkit.org/show_bug.cgi?id=96817
1147
1148         Reviewed by Kenneth Rohde Christiansen.
1149
1150         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1151         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
1152         got overlooked when adding logging elsewhere.
1153
1154 2012-09-14  Peter Beverloo  <peter@chromium.org>
1155
1156         [Chromium] Build fix for DumpRenderTree following r128628
1157         https://bugs.webkit.org/show_bug.cgi?id=96808
1158
1159         Reviewed by Tony Chang.
1160
1161         When building DumpRenderTree from the Chromium project, a compile error
1162         shows up because including the header ForwardIOStreamsAndroid.h cannot
1163         be located. TestWebKitAPI does this correctly.
1164
1165         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1166
1167 2012-09-14  Dana Jansens  <danakj@chromium.org>
1168
1169         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
1170         https://bugs.webkit.org/show_bug.cgi?id=96805
1171
1172         Reviewed by Dirk Pranke.
1173
1174         * Scripts/webkitpy/common/config/committers.py:
1175         * Scripts/webkitpy/common/config/watchlist:
1176
1177 2012-09-14  Peter Beverloo  <peter@chromium.org>
1178
1179         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
1180         https://bugs.webkit.org/show_bug.cgi?id=96687
1181
1182         Reviewed by Tony Chang.
1183
1184         Android's DumpRenderTree currently supports these arguments, implemented
1185         as part of TestShellAndroid:
1186         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
1187
1188         They're used by the layout test runner to get the STDOUT and STDERR while
1189         a layout test run is in process, which is a safer alternative to parsing
1190         all the logcat output manually. The implementation can be seen here:
1191         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
1192
1193         This patch generalizes parsing of and applying the effects of these arguments
1194         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
1195         After this patch, this will make it possible to pull out the output-reading
1196         code from Android's layout test port and generalize it so it can be re-used
1197         in the new test-runner for the other two test suites.
1198
1199         This has no effect when compiling and running these tests as part of Chromium
1200         code, which has a much more advanced test-runner that does parse complete log
1201         output, but also directly depends on code licensed under Apache 2.
1202
1203         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1204         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1205         (platformInit):
1206         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1207
1208 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
1209
1210         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
1211         https://bugs.webkit.org/show_bug.cgi?id=96656
1212
1213         Reviewed by Adam Barth.
1214
1215         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
1216         macros in 1 line.
1217
1218         * Scripts/webkitpy/style/checkers/cpp.py:
1219         (check_style.definitions):
1220         (check_style): Add rule.
1221         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1222         (WebKitStyleTest.test_line_breaking): Add unittest.
1223
1224 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1225
1226         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
1227         https://bugs.webkit.org/show_bug.cgi?id=57570
1228
1229         Reviewed by Kenneth Rohde Christiansen.
1230
1231         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
1232         and dump the information expected by the test cases.
1233
1234         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1235         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1236         (WTR::InjectedBundle::beginTesting): Explicitly set the default
1237         database quota.
1238         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1239         (WTR::securityOriginToStr): New convenience function to convert
1240         a security origin to the string expected in test results.
1241         (WTR):
1242         (WTR::InjectedBundlePage::InjectedBundlePage):
1243         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
1244         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
1245         refactoring to share code with didExceedDatabaseQuota.
1246         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1247         (InjectedBundlePage):
1248         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1249         (WTR::TestRunner::TestRunner):
1250         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1251         (WTR::TestRunner::dumpDatabaseCallbacks):
1252         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
1253         (TestRunner):
1254
1255 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1256
1257         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
1258
1259         Rubber-stamped by Simon Hausmann.
1260
1261         * qmake/mkspecs/features/default_post.prf:
1262
1263 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1264
1265         [Qt] Remove old cruft from the qmake build system
1266
1267         Rubber-stamped by Simon Hausmann.
1268
1269         * DumpRenderTree/qt/DumpRenderTree.pro:
1270         * qmake/mkspecs/features/default_post.prf:
1271
1272 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1273
1274         [Qt] Enable force_static_libs_as_shared for development
1275
1276         Not enabled for buildbots or production-builds (part of Qt5)
1277
1278         Reviewed by Simon Hausmann.
1279
1280         * qmake/mkspecs/features/default_post.prf:
1281
1282 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1283
1284         [Qt] Make force_static_libs_as_shared work on Mac OS
1285
1286         We had to move a few LIBS += around that were in the wrong place,
1287         and not caught when everything was just linked into the final
1288         QtWebKit library.
1289
1290         Reviewed by Simon Hausmann.
1291
1292         * qmake/mkspecs/features/default_post.prf:
1293         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
1294
1295 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
1296
1297         [Qt] Fix build of WTR on Windows
1298
1299         Reviewed by Tor Arne Vestbø.
1300
1301         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
1302         With qmake's unix makefile generator as well as with the MingW generator,
1303         the directory where the pro file lives (WTR/) is automatically added to
1304         the include search path, but not so with MSVC. Instead of relying on qmake's
1305         implicit feature here, add WTR/ explicitly to the include search path.
1306
1307         * WebKitTestRunner/Target.pri:
1308
1309 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1310
1311         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
1312         https://bugs.webkit.org/show_bug.cgi?id=42691
1313
1314         Reviewed by Kenneth Rohde Christiansen.
1315
1316         Add implementation for testrunner.setStopProvisionalFrameLoads()
1317         in WebKitTestRunner.
1318
1319         Original patch by Alexey Proskuryakov.
1320
1321         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1322         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1323         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1324         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1325         (WTR::TestRunner::TestRunner):
1326         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1327         (TestRunner):
1328         (WTR::TestRunner::setStopProvisionalFrameLoads):
1329         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
1330
1331 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1332
1333         [Qt] Fix handling of debug/release/debug_and_release/build_all
1334
1335         We now pick up the defaults from Qt, in default_pre (CONFIG already
1336         contains the appropriate values for debug and release). We then let
1337         the command line arguments to qmake, or the project files themselves,
1338         override the configuration, and finally we sanitize the configuration
1339         in default_post.
1340
1341         Reviewed by Simon Hausmann.
1342
1343         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1344         * Scripts/webkitdirs.pm:
1345         (buildQMakeProjects):
1346         * qmake/mkspecs/features/default_post.prf:
1347         * qmake/mkspecs/features/default_pre.prf:
1348         * qmake/mkspecs/features/mac/default_pre.prf:
1349
1350 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1351
1352         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
1353         https://bugs.webkit.org/show_bug.cgi?id=42687
1354
1355         Reviewed by Kenneth Rohde Christiansen.
1356
1357         Implement testRunner.setTabKeyCyclesThroughElements for
1358         WebKitTestRunner.
1359
1360         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1361         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1362         (WTR::InjectedBundle::beginTesting):
1363         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1364         (WTR::TestRunner::setTabKeyCyclesThroughElements):
1365         (WTR):
1366         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1367         (TestRunner):
1368
1369 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1370
1371         EventSendingController::keyDown does not support non-array modifier arguments
1372         https://bugs.webkit.org/show_bug.cgi?id=96727
1373
1374         Reviewed by Kenneth Rohde Christiansen.
1375
1376         Add support for handling a string as modifier argument to
1377         EventSendingController::keyDown.
1378
1379         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1380         (WTR::parseModifierArray):
1381
1382 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1383
1384         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
1385         https://bugs.webkit.org/show_bug.cgi?id=42546
1386
1387         Reviewed by Kenneth Rohde Christiansen.
1388
1389         Exported TestRunner::setCustomPolicyDelegate() method.
1390         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
1391
1392         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1393         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1394         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1395
1396 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
1397
1398         [GTK] Clear application cache between tests in DumpRenderTree
1399         https://bugs.webkit.org/show_bug.cgi?id=96543
1400
1401         Reviewed by Philippe Normand.
1402
1403         Call the new DumpRenderTreeSupportGtk method to clear application cache
1404         after each test in DumpRenderTree.
1405
1406         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1407         as well. It's now being set in XvfbDriver._start so that each driver is assigned
1408         a cache directory that's constructed out of the driver's name and its worker
1409         number. These directories are located in the layout tests results directory.
1410         At least on the builders this ensures a driver-specific empty cache directory
1411         with each test run.
1412
1413         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1414         (runTest):
1415         * Scripts/webkitpy/layout_tests/port/gtk.py:
1416         (GtkPort.setup_environ_for_server):
1417         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1418         (XvfbDriver._start):
1419
1420 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
1421
1422         [Qt] Fix linking on Windows
1423
1424         Reviewed by Tor Arne Vestbø.
1425
1426         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
1427         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
1428         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
1429         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
1430
1431         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
1432         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
1433         after the module. Therefore QT did never contain webkit anymore and we always passed
1434         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
1435
1436         This patch introduces a creating_module configuration that is used to
1437         scope the qt/pkgconfig sanitization.
1438
1439         * qmake/mkspecs/features/default_post.prf:
1440
1441 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1442
1443         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
1444         https://bugs.webkit.org/show_bug.cgi?id=96740
1445
1446         Reviewed by Kenneth Rohde Christiansen.
1447
1448         Dump information expected by the test cases about the following
1449         frame load callbacks:
1450         "didDisplayInsecureContentForFrame"
1451         "didRunInsecureContentForFrame"
1452         "didDetectXSSForFrame"
1453
1454         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1455         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
1456         as expected by test results by calling pathSuitableForTestResult() instead
1457         of printing raw URL.
1458         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
1459         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
1460         (WTR::InjectedBundlePage::didDetectXSSForFrame):
1461
1462 2012-09-14  Peter Beverloo  <peter@chromium.org>
1463
1464         The runtime/unsigned category should be valid in the cpp style-checker.
1465         https://bugs.webkit.org/show_bug.cgi?id=96748
1466
1467         Reviewed by Csaba Osztrogonác.
1468
1469         This is causing the webkitpy tests to fail because it's not listed in the
1470         category array. Furthermore, change an "int" to "long" because it's
1471         throwing a double error in one of the earlier asserts.
1472
1473         * Scripts/webkitpy/style/checkers/cpp.py:
1474         (CppChecker):
1475         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1476         (WebKitStyleTest.test_names):
1477
1478 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1479
1480         Evas_Object* is a ref'ed structure, so tread it as such
1481         https://bugs.webkit.org/show_bug.cgi?id=96659
1482
1483         Reviewed by Adam Barth.
1484
1485         Replace OwnPtr<Evas_Object> with RefPtr.
1486
1487         * DumpRenderTree/efl/ImageDiff.cpp:
1488         (calculateDifference):
1489         (printImageDifferences):
1490         (readImageFromStdin):
1491         (main):
1492
1493 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1494
1495         Unreviewed, rolling out r128507.
1496         http://trac.webkit.org/changeset/128507
1497         https://bugs.webkit.org/show_bug.cgi?id=96659
1498
1499         Revert. r128507 makes too many crashes in EFL layout test bots.
1500
1501         * DumpRenderTree/efl/ImageDiff.cpp:
1502         (calculateDifference):
1503         (printImageDifferences):
1504         (readImageFromStdin):
1505         (main):
1506
1507 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
1508
1509         Make compile with both OS(WINCE) and PLATFORM(QT) support
1510         https://bugs.webkit.org/show_bug.cgi?id=95536
1511
1512         Reviewed by Simon Hausmann.
1513
1514         Fix wince support in qmake files
1515
1516         * Tools.pro:
1517         * qmake/mkspecs/features/configure.prf:
1518         * qmake/mkspecs/features/default_post.prf:
1519         * qmake/mkspecs/features/features.prf:
1520         * qmake/mkspecs/features/functions.prf:
1521
1522 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
1523
1524         [WK2] Add color picker API support for WebKit2
1525         https://bugs.webkit.org/show_bug.cgi?id=95058
1526
1527         Reviewed by Gyuyoung Kim.
1528
1529         Initialization code for color picker callbacks in UI client.
1530
1531         * MiniBrowser/mac/BrowserWindowController.m:
1532         (-[BrowserWindowController awakeFromNib]):
1533         * MiniBrowser/win/BrowserView.cpp:
1534         (BrowserView::create):
1535         * WebKitTestRunner/TestController.cpp:
1536         (WTR::TestController::createOtherPage):
1537         (WTR::TestController::initialize):
1538
1539 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
1540
1541         Upgrade yutak to reviewer
1542         https://bugs.webkit.org/show_bug.cgi?id=96721
1543
1544         Reviewed by Kent Tamura.
1545
1546         * Scripts/webkitpy/common/config/committers.py:
1547
1548 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1549
1550         Make the style checker report usage of "unsigned int"
1551         https://bugs.webkit.org/show_bug.cgi?id=96693
1552
1553         Reviewed by Dirk Pranke.
1554
1555         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
1556
1557         * Scripts/webkitpy/style/checkers/cpp.py:
1558         (check_language):
1559
1560 2012-09-13  Philip Rogers  <pdr@google.com>
1561
1562         Add gender-neutral form of webkit-patch land-cowboy
1563         https://bugs.webkit.org/show_bug.cgi?id=96709
1564
1565         Reviewed by Adam Barth.
1566
1567         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
1568
1569         * Scripts/webkitpy/tool/commands/download.py:
1570         (LandCowhand):
1571
1572 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
1573
1574         [EFL] Remove some parameters in browserCreate()
1575         https://bugs.webkit.org/show_bug.cgi?id=96499
1576
1577         Reviewed by Kenneth Rohde Christiansen.
1578
1579         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
1580         And I have moved some parameters into User_Arguments.
1581
1582         * EWebLauncher/main.c:
1583         (_User_Arguments):
1584         (_ELauncher):
1585         (on_key_down):
1586         (browserCreate):
1587         (findThemePath):
1588         (parseUserArguments):
1589         (main):
1590
1591 2012-09-13  Mark Lam  <mark.lam@apple.com>
1592
1593         Unreviewed. Adding myself to the committers list.
1594
1595         * Scripts/webkitpy/common/config/committers.py:
1596
1597 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1598
1599         run-perf-tests output cryptic error when the config file is missing.
1600         https://bugs.webkit.org/show_bug.cgi?id=96453
1601
1602         Reviewed by Tony Chang.
1603
1604         Add a special error message when a configuration file is missing.
1605
1606         Also update the help message of --source-json-path to signify the fact it specifies
1607         the configuration file on performance tests bots.
1608
1609         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1610         (PerfTestsRunner._parse_args):
1611         (PerfTestsRunner._generate_and_show_results):
1612         (PerfTestsRunner._merge_slave_config_json):
1613         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1614         (_test_run_with_json_output): Make upload to fail by default and assert the result
1615         in the function so that we can return logs instead.
1616         (_test_run_with_json_output.mock_upload_json):
1617         (test_run_with_json_output):
1618         (test_run_with_description):
1619         (test_run_respects_no_results):
1620         (test_run_with_slave_config_json):
1621         (test_run_with_bad_slave_config_json):
1622         (test_run_with_multiple_repositories):
1623
1624 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1625
1626         Evas_Object* is a ref'ed structure, so tread it as such
1627         https://bugs.webkit.org/show_bug.cgi?id=96659
1628
1629         Reviewed by Adam Barth.
1630
1631         Replace OwnPtr<Evas_Object> with RefPtr.
1632
1633         * DumpRenderTree/efl/ImageDiff.cpp:
1634         (calculateDifference):
1635         (printImageDifferences):
1636         (readImageFromStdin):
1637         (main):
1638
1639 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1640
1641         One more unreviewed trivial fix after r128399.
1642
1643         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
1644
1645 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1646
1647         Unreviewed trivial fix after r128399.
1648
1649         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
1650         (getLatestSVNRevision):
1651         (waitForSVNRevision):
1652
1653 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1654
1655         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
1656         https://bugs.webkit.org/show_bug.cgi?id=96366
1657
1658         Reviewed by Anders Carlsson.
1659
1660         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
1661         by calling shouldClose() on the FrameLoader.
1662
1663         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1664         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1665         (WTR::TestRunner::callShouldCloseOnWebView):
1666         (WTR):
1667         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1668         (TestRunner):
1669
1670 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1671
1672         Unreviewed, rolling out r128453.
1673         http://trac.webkit.org/changeset/128453
1674         https://bugs.webkit.org/show_bug.cgi?id=96681
1675
1676         Having tests use the same appcache directory leads to timeouts
1677         (Requested by zdobersek on #webkit).
1678
1679         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1680         (runTest):
1681         * Scripts/webkitpy/layout_tests/port/gtk.py:
1682         (GtkPort.setup_environ_for_server):
1683
1684 2012-09-13  James Robinson  <jamesr@chromium.org>
1685
1686         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
1687         https://bugs.webkit.org/show_bug.cgi?id=96678
1688
1689         Reviewed by Dirk Pranke.
1690
1691         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1692         (.):
1693
1694 2012-09-13  Rob Buis  <rbuis@rim.com>
1695
1696         Unreviewed changes to watchlist.
1697
1698         - Add myself to BlackBerry bugs
1699
1700         * Scripts/webkitpy/common/config/watchlist:
1701
1702 2012-09-13  Stephen Chenney  <schenney@chromium.org>
1703
1704         Add an SVG entry to the watchlist
1705
1706         Unreviewed config change.
1707
1708         * Scripts/webkitpy/common/config/watchlist:
1709         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
1710         - Added myself and pdr as watchers
1711
1712 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1713
1714         [Qt] Make WebKit2 work on Windows with Qt 5
1715         https://bugs.webkit.org/show_bug.cgi?id=76776
1716
1717         Reviewed by Tor Arne Vestbø.
1718
1719         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
1720         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
1721         that for the GL TextureMapper (it's only built when that feature is set).
1722
1723         * qmake/mkspecs/features/configure.prf:
1724
1725 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1726
1727         [Qt] Ensure that QT is finalized before loading qt_module.prf
1728
1729         As qt_module.prf does dependency tracking based on the content of the
1730         QT variable. The intermediate WebKit modules modify the variable in
1731         their .pri files, so we have to ensure we've loaded all the modules
1732         before loading qt_module.
1733
1734         Reviewed by Tor Arne Vestbø.
1735         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
1736
1737         * qmake/mkspecs/features/default_post.prf:
1738         * qmake/mkspecs/features/webkit_modules.prf: Added.
1739
1740 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1741
1742         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
1743         https://bugs.webkit.org/show_bug.cgi?id=96633
1744
1745         Reviewed by Csaba Osztrogonác.
1746
1747         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
1748         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
1749         It's the usual problem and the usual solution is to rename one of the conflicting files.
1750         This patch chooses to rename DRT instead of WTR and MBR.
1751
1752         Fixed include order at the same time to match style guide.
1753
1754         * DumpRenderTree/qt/DumpRenderTree.pro:
1755         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
1756         (messageHandler):
1757         (isOption):
1758         (takeOptionValue):
1759         (printUsage):
1760         (main):
1761
1762 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1763
1764         The Script run-launcher should support -2 in combination with --efl
1765         https://bugs.webkit.org/show_bug.cgi?id=96639
1766
1767         Reviewed by Simon Hausmann.
1768
1769         Support running the MiniBrowser then supplied -2 as argument.
1770
1771         * Scripts/run-launcher:
1772
1773 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1774
1775         Unreviewed, add my Intel email address to the list.
1776
1777         * Scripts/webkitpy/common/config/committers.py:
1778
1779 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1780
1781         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
1782
1783         Reviewed by Ossy.
1784
1785         * qmake/mkspecs/features/default_post.prf:
1786
1787 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1788
1789         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
1790         https://bugs.webkit.org/show_bug.cgi?id=82294
1791
1792         Reviewed by Gyuyoung Kim.
1793
1794         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
1795
1796         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1797         (TestRunner::layerTreeAsText):
1798
1799 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1800
1801         [GTK] Clear application cache between tests in DumpRenderTree
1802         https://bugs.webkit.org/show_bug.cgi?id=96543
1803
1804         Reviewed by Philippe Normand.
1805
1806         Call the new DumpRenderTreeSupportGtk method to clear application cache
1807         after each test.
1808
1809         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1810         as well. Currently it points to a subdirectory in the layout tests results
1811         directory. At least on the builders this ensures an empty cache directory
1812         with each test run.
1813
1814         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1815         (runTest):
1816         * Scripts/webkitpy/layout_tests/port/gtk.py:
1817         (GtkPort.setup_environ_for_server):
1818
1819 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1820
1821         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
1822
1823         Unless it's actually a dependency of the public QtWebKit API.
1824
1825         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
1826         files with their _PRIVATE equivivalent, but that's likely to break when
1827         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
1828         clean up the variables in default_post.
1829
1830         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
1831         longer needed, as it was a workaround for the intermediate libraries ending
1832         up in the prl file. And, since CONFIG -= staticlib was there to support
1833         the explicitlib option, we can remove that too (as well as the exception
1834         for gprof, since it would be empty). If gprof needs tweaks to always link
1835         statically they should go in gprof.prf.
1836
1837         Reviewed by Simon Hausmann.
1838
1839         * qmake/mkspecs/features/default_post.prf:
1840         * qmake/mkspecs/features/functions.prf:
1841
1842 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
1843
1844         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
1845         https://bugs.webkit.org/show_bug.cgi?id=96632
1846
1847         Reviewed by Carlos Garcia Campos.
1848
1849         Fix this by using atk_object_get_n_accessible_children instead of
1850         calling getChildren() from childCount.
1851
1852         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
1853         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
1854         loop by using atk_object_get_n_accessible_children().
1855
1856 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1857
1858         [Qt][Win] Enable USE(3D_GRAPHICS)
1859         https://bugs.webkit.org/show_bug.cgi?id=90879
1860
1861         Reviewed by Kenneth Rohde Christiansen.
1862
1863         Enable it on Windows as well as on QNX (bug fixed).
1864
1865         * qmake/mkspecs/features/features.prf:
1866
1867 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1868
1869         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
1870         https://bugs.webkit.org/show_bug.cgi?id=96359
1871
1872         Reviewed by Tor Arne Vestbø.
1873
1874         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
1875         lexer. The only viable alternative I could find on Windows that provides
1876         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
1877         so let's use that one instead.
1878
1879         * Scripts/webkitdirs.pm:
1880         (checkRequiredSystemConfig):
1881         * qmake/mkspecs/features/default_pre.prf:
1882
1883 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1884
1885         [Qt] Add configuration for production builds
1886         https://bugs.webkit.org/show_bug.cgi?id=96607
1887
1888         Reviewed by Kenneth Rohde Christiansen.
1889
1890         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
1891         and enable all-in-one-files optimizations.
1892
1893         * qmake/mkspecs/features/production_build.prf: Added.
1894
1895 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1896
1897         [Qt] GStreamer detection does not work when cross-compiling
1898         https://bugs.webkit.org/show_bug.cgi?id=96608
1899
1900         Reviewed by Kenneth Rohde Christiansen.
1901
1902         When cross-compiling it is not safe to just use system(pkg-config),
1903         because there is a high probability that it will find packages in the
1904         host system instead of in the target one. Instead use qmake's new
1905         packagesExist() function that takes care of this delicate aspect of
1906         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
1907         PKG_CONFIG_LIBDIR accordingly.
1908
1909         * qmake/mkspecs/features/features.prf:
1910
1911 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
1912
1913         [WK2][WTR] More efficient string handling in InjectedBundlePage
1914         https://bugs.webkit.org/show_bug.cgi?id=96609
1915
1916         Reviewed by Kenneth Rohde Christiansen.
1917
1918         Update StringBuilder usage in InjectedBundlePage to follow
1919         the latest recommandations for efficient string handling:
1920         http://trac.webkit.org/wiki/EfficientStrings
1921
1922         This involves using appendLiteral() or appendNumber()
1923         instead of append() whenever possible.
1924
1925         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1926         (WTR::dumpPath):
1927         (WTR::rangeToStr):
1928         (WTR::styleDecToStr):
1929         (WTR::frameToStr):
1930         (WTR::dumpResourceURL):
1931         (WTR):
1932         (WTR::dumpFrameDescriptionSuitableForTestResult):
1933         (WTR::dumpRequestDescriptionSuitableForTestResult):
1934         (WTR::dumpResponseDescriptionSuitableForTestResult):
1935         (WTR::dumpErrorDescriptionSuitableForTestResult):
1936         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1937         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1938         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1939         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1940         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1941         (WTR::InjectedBundlePage::didFinishProgress):
1942         (WTR::dumpFrameScrollPosition):
1943         (WTR::dumpFrameText):
1944         (WTR::dumpDescendantFramesText):
1945         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1946         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1947         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1948         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1949         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1950         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1951         (WTR::InjectedBundlePage::willSendRequestForFrame):
1952         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1953         (WTR::InjectedBundlePage::didFinishLoadForResource):
1954         (WTR::InjectedBundlePage::didFailLoadForResource):
1955         (WTR::InjectedBundlePage::shouldCacheResponse):
1956         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1957         (WTR::InjectedBundlePage::willAddMessageToConsole):
1958         (WTR::InjectedBundlePage::willSetStatusbarText):
1959         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1960         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1961         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1962         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1963         (WTR::InjectedBundlePage::shouldBeginEditing):
1964         (WTR::InjectedBundlePage::shouldEndEditing):
1965         (WTR::InjectedBundlePage::shouldInsertNode):
1966         (WTR::InjectedBundlePage::shouldInsertText):
1967         (WTR::InjectedBundlePage::shouldDeleteRange):
1968         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1969         (WTR::InjectedBundlePage::shouldApplyStyle):
1970         (WTR::InjectedBundlePage::didBeginEditing):
1971         (WTR::InjectedBundlePage::didEndEditing):
1972         (WTR::InjectedBundlePage::didChange):
1973         (WTR::InjectedBundlePage::didChangeSelection):
1974         (WTR::InjectedBundlePage::supportsFullScreen):
1975         (WTR::InjectedBundlePage::enterFullScreenForElement):
1976         (WTR::InjectedBundlePage::exitFullScreenForElement):
1977         (WTR::InjectedBundlePage::beganEnterFullScreen):
1978         (WTR::InjectedBundlePage::beganExitFullScreen):
1979         (WTR::InjectedBundlePage::closeFullScreen):
1980         (WTR::dumpBackForwardListItem):
1981         (WTR::InjectedBundlePage::dumpBackForwardList):
1982
1983 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1984
1985         [Qt][WK2] Memory leaks in Qt's TestRunner
1986         https://bugs.webkit.org/show_bug.cgi?id=96603
1987
1988         Reviewed by Csaba Osztrogonác.
1989
1990         Fix memory leaks in Qt's TestRunner code by adopting WKString
1991         created with WKStringCreateWithUTF8CString().
1992
1993         * WebKitTestRunner/qt/TestControllerQt.cpp:
1994         (WTR::TestController::initializeInjectedBundlePath):
1995         (WTR::TestController::initializeTestPluginDirectory):
1996
1997 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1998
1999         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
2000         https://bugs.webkit.org/show_bug.cgi?id=96506
2001
2002         Reviewed by Dirk Pranke.
2003
2004         Lower the timeout value to 6 seconds for release configuration and 12 seconds
2005         for debug configuration. These are the same values the Chromium port uses.
2006
2007         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
2008         the layout tests under WebKit2 generally) requires more attention and gardening
2009         than what the current effort produces.
2010
2011         The unit test is updated as well to test these changes.
2012
2013         * Scripts/webkitpy/layout_tests/port/gtk.py:
2014         (GtkPort.default_timeout_ms):
2015         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2016         (GtkPortTest.test_default_timeout_ms):
2017         (GtkPortTest.assertLinesEqual):
2018
2019 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
2020
2021         Add SVN mirror handling feature to build.webkit.org
2022         https://bugs.webkit.org/show_bug.cgi?id=85887
2023
2024         Reviewed by Dirk Pranke.
2025
2026         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
2027         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2028         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
2029         (ConfigureBuild.start):
2030         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
2031         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
2032         (Factory.__init__):
2033         (BuildFactory.__init__):
2034         (TestFactory.__init__):
2035         (BuildAndTestFactory.__init__):
2036         (BuildAndPerfTestFactory.__init__):
2037         (BuildAndPerfTestWebKit2Factory.__init__):
2038         (DownloadAndPerfTestFactory.__init__):
2039         (DownloadAndPerfTestWebKit2Factory.__init__):
2040         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
2041         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2042         (SVNMirrorTest):
2043         (SVNMirrorTest.setUp): Load config.json once at startup.
2044         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
2045         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
2046         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
2047         (getLatestSVNRevision): Get the latest SVN revison from the given server.
2048         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
2049                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
2050
2051 2012-09-12  Kangil Han  <kangil.han@samsung.com>
2052
2053         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
2054         https://bugs.webkit.org/show_bug.cgi?id=81606
2055
2056         Reviewed by Tim Horton.
2057
2058         6 seconds is harsh for some jquery test cases.
2059         Therefore, adjust the value to match DumpRenderTree.
2060
2061         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2062         (WTR):
2063
2064 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
2065
2066         [EFL] Support download attribute feature
2067         https://bugs.webkit.org/show_bug.cgi?id=96462
2068
2069         Reviewed by Gyuyoung Kim.
2070
2071         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
2072         and add "download,request" callback to the DumpRenderTree for EFL.
2073
2074         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2075         (DumpRenderTreeChrome::createView):
2076         (DumpRenderTreeChrome::onDownloadRequest):
2077         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2078         (DumpRenderTreeChrome):
2079         * Scripts/webkitperl/FeatureList.pm:
2080
2081 2012-09-12  Stephanie Lewis  <slewis@apple.com>
2082
2083         Reduce parallism on the wk2 testers.
2084         https://bugs.webkit.org/show_bug.cgi?id=95906
2085
2086         Reviewed by Dirk Pranke.
2087
2088         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
2089         resource contention.  Reducing the number of processes alleviates the issue.  
2090
2091         Starting by reducing 25%.
2092
2093         * Scripts/webkitpy/layout_tests/port/mac.py:
2094         (MacPort.default_child_processes):
2095
2096 2012-09-12  Brady Eidson  <beidson@apple.com>
2097
2098         Assert in NetscapePlugin::destroy() with async plugin init
2099         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
2100
2101         Reviewed by Anders Carlsson.
2102
2103         Expose NPN_Invoke to plug-in tests:
2104         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2105         (PluginTest::NPN_Invoke):
2106         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2107         (PluginTest):
2108
2109         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
2110         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
2111         (InvokeDestroysPluginWithinNPP_New):
2112         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
2113         (InvokeDestroysPluginWithinNPP_New::NPP_New):
2114         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2115
2116 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2117
2118         refactor TestExpectations tokenization slightly in preparation for the new syntax
2119         https://bugs.webkit.org/show_bug.cgi?id=96564
2120
2121         Reviewed by Ojan Vafai.
2122
2123         This change changes how we will tokenize/lex the
2124         TestExpectations files, in preparation for supporting both the
2125         old syntax and the new one. This change by itself should be a
2126         no-op.
2127
2128         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2129         (TestExpectationParser._tokenize_line):
2130         (TestExpectationParser):
2131         (TestExpectationParser._tokenize_line_using_old_format):
2132         (TestExpectationParser._tokenize_line_using_new_format):
2133
2134 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2135
2136         remove unused testexpectations editing code from webkitpy, garden-o-matic
2137         https://bugs.webkit.org/show_bug.cgi?id=96562
2138
2139         Reviewed by Adam Barth.
2140
2141         This code was prototyped but never fully realized. Removing
2142         until it reanimates :).
2143
2144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2146         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
2147         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
2148         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2149         (BuildCoverageExtrapolator.extrapolate_test_configurations):
2150         (GardeningHTTPRequestHandler._run_webkit_patch):
2151         (GardeningHTTPRequestHandler.ping):
2152         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2153         (BuildCoverageExtrapolatorTest.test_extrapolate):
2154         (GardeningServerTest.test_rebaseline_new_port):
2155
2156 2012-09-12  Lucas Forschler  <lforschler@apple.com>
2157
2158         Remove unused bot, apple-xserve-1.
2159         https://bugs.webkit.org/show_bug.cgi?id=96570
2160         
2161         Reviewed by Stephanie Lewis.
2162
2163         * BuildSlaveSupport/build.webkit.org-config/config.json:
2164
2165 2012-09-12  Xan Lopez  <xlopez@igalia.com>
2166
2167         [GTK] We attempt to rebase documentation even if it's not present
2168         https://bugs.webkit.org/show_bug.cgi?id=96553
2169
2170         Reviewed by Martin Robinson.
2171
2172         Do not make the documentation rebase step fatal. This allows make
2173         install to succeed when there's no documentation generated.
2174
2175         * gtk/generate-gtkdoc:
2176
2177 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2178
2179         Respect WEBKITOUTPUTDIR when running EFL tests
2180         https://bugs.webkit.org/show_bug.cgi?id=96528
2181
2182         Reviewed by Dirk Pranke.
2183
2184         Expose user set WEBKITOUTPUTDIR to the web process.
2185
2186         * Scripts/webkitpy/layout_tests/port/driver.py:
2187         (Driver._start): Add WEBKITOUTPUTDIR to the environment
2188         of the web process and its potential jhbuild wrapper.
2189
2190 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2191
2192         webkitdirs: fix uname version handling for cygwin
2193         https://bugs.webkit.org/show_bug.cgi?id=96436
2194
2195         Reviewed by Jon Honeycutt.
2196
2197         Newer versions of cygwin embed an additional version string
2198         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
2199         Update the code to handle that.
2200
2201         * Scripts/webkitdirs.pm:
2202         (setupAppleWinEnv):
2203
2204 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2205
2206         Regression(r128338): Broke Windows build
2207         https://bugs.webkit.org/show_bug.cgi?id=96537
2208
2209         Unreviewed build fix.
2210
2211         Fix Apple-Win build by allocating array dynamically
2212         since its size is not constant.
2213
2214         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2215         (WTR::stringArrayToJS):
2216
2217 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
2218
2219         [chromium] Add a virtual test suite for fast/hidpi
2220         https://bugs.webkit.org/show_bug.cgi?id=90192
2221
2222         Reviewed by Dirk Pranke.
2223
2224         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
2225         on the hardware accelerated path as the software path.
2226
2227         * DumpRenderTree/chromium/WebPreferences.cpp:
2228         (WebPreferences::applyTo):
2229         * Scripts/webkitpy/layout_tests/port/chromium.py:
2230         (ChromiumPort.virtual_test_suites):
2231
2232 2012-09-12  Adam Klein  <adamk@chromium.org>
2233
2234         [chromium] Add content_browsertests to the flakiness dashboard
2235         https://bugs.webkit.org/show_bug.cgi?id=96535
2236
2237         Reviewed by Ojan Vafai.
2238
2239         * TestResultServer/static-dashboards/dashboard_base.js:
2240
2241 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2242
2243         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
2244         https://bugs.webkit.org/show_bug.cgi?id=96496
2245
2246         Reviewed by Kenneth Rohde Christiansen.
2247
2248         Add implementation for originsWithApplicationCache to
2249         WebKitTestRunner.
2250
2251         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2252         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2253         (WTR::stringArrayToJS):
2254         (WTR):
2255         (WTR::TestRunner::originsWithApplicationCache):
2256         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2257         (TestRunner):
2258
2259 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2260
2261         Fix Qt/Windows build with Python3
2262         https://bugs.webkit.org/show_bug.cgi?id=96473
2263
2264         Reviewed by Csaba Osztrogonác.
2265
2266         In Python 3 print is a real function, so we must use parentheses around
2267         the function parameters. This is backwards compatible with Python 2.
2268
2269         * Scripts/generate-win32-export-forwards:
2270
2271 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2272
2273         Unreviewed trivial build fix for Qt/Windows after bug #96358.
2274
2275         As pointed out by Kevin, we should inject the "set PATH=..." statement
2276         to add the GnuWin32 directory only if that directory actually exists.
2277
2278         * qmake/mkspecs/features/default_post.prf:
2279
2280 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2281
2282         [EFL] [WK2] Memory leaks in TestControllerEfl
2283         https://bugs.webkit.org/show_bug.cgi?id=96525
2284
2285         Reviewed by Kenneth Rohde Christiansen.
2286
2287         Fix memory leaks in EFL's TestRunner code by adopting an allocation
2288         of WKString created with WKStringCreateWithUTF8CString().
2289
2290         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2291         (WTR::TestController::initializeInjectedBundlePath):
2292         (WTR::TestController::initializeTestPluginDirectory):
2293
2294 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2295
2296         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
2297         https://bugs.webkit.org/show_bug.cgi?id=96374
2298
2299         Reviewed by Kenneth Rohde Christiansen.
2300
2301         Implement support for dumpApplicationCacheDelegateCallbacks
2302         and disallowIncreaseForApplicationCacheQuota in
2303         WebKitTestRunner and properly dump the information
2304         expected by the tests.
2305
2306         If the application cache quota is reached for a given
2307         security origin, WebKitTestRunner will reset the quota
2308         to its default value, unless intructed not to via
2309         disallowIncreaseForApplicationCacheQuota().
2310
2311         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2312         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2313         (WTR::InjectedBundlePage::InjectedBundlePage):
2314         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2315         (WTR):
2316         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2317         (InjectedBundlePage):
2318         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2319         (WTR::TestRunner::TestRunner):
2320         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2321         (WTR):
2322         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2323         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2324         (TestRunner):
2325         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2326         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2327
2328 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2329
2330         [chromium] remove deprecated and unused sets import from chromium_android driver
2331         https://bugs.webkit.org/show_bug.cgi?id=96485
2332
2333         Reviewed by Dirk Pranke.
2334
2335         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2336
2337 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
2338
2339         Flakiness dashboard doesn't recognize new Chromium Android test builder
2340         https://bugs.webkit.org/show_bug.cgi?id=96523
2341
2342         Reviewed by Ojan Vafai.
2343
2344         Properly return 'ANDROID' as the Chromium platform for Android builders.
2345
2346         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2347         (chromiumPlatform):
2348         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2349         (test):
2350
2351 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2352
2353         [Qt] Build on Windows requires bison/flex in PATH
2354         https://bugs.webkit.org/show_bug.cgi?id=96358
2355
2356         Reviewed by Tor Arne Vestbø.
2357
2358         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
2359         and Linux that is rarely a problem given how easily available the tools are. On Windows however
2360         a separate installation of various GNU tools is required as the operating system doesn't come with
2361         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
2362         the gnuwin32 directory of the qt5.git top-level repository.
2363
2364         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
2365
2366         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
2367         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
2368         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
2369         updated with the new tool.
2370
2371         * Scripts/webkitdirs.pm:
2372         (checkRequiredSystemConfig):
2373         * qmake/mkspecs/features/default_post.prf:
2374
2375 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2376
2377         [Qt] Update build-jsc after r128174
2378
2379         Reviewed by Ossy.
2380
2381         * Scripts/build-jsc:
2382
2383 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2384
2385         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
2386
2387         By hard-coding the names of the targets we defined we ended up just
2388         redefining the previous target when using addStrictSubdirOrderBetween
2389         more than once in a single project file.
2390
2391         We now embed the two base targets into the target names.
2392
2393         Reviewed by Simon Hausmann.
2394
2395         * qmake/mkspecs/features/functions.prf:
2396
2397 2012-09-12  Philippe Liard  <pliard@google.com>
2398
2399         Depend on {base,net} GYP targets rather than {base,net}_java.
2400         https://bugs.webkit.org/show_bug.cgi?id=95690
2401
2402         Reviewed by Adam Barth.
2403
2404         {base,net}_java became 'private' targets on the Chromium side that
2405         clients should not depend on (see
2406         https://chromiumcodereview.appspot.com/10913083/).
2407         This removes a bunch of trailing white spaces additionally in
2408         TestWebkitAPI.gyp (which includes non-trailing white space changes).
2409
2410         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2411         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2412
2413 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2414
2415         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
2416         https://bugs.webkit.org/show_bug.cgi?id=96494
2417
2418         Reviewed by Tor Arne Vestbø.
2419
2420         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
2421         plugin process feature if we don't have NPAPI.
2422
2423         * qmake/mkspecs/features/features.prf:
2424
2425 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2426
2427         Unreviewed, rolling out r128280.
2428         http://trac.webkit.org/changeset/128280
2429         https://bugs.webkit.org/show_bug.cgi?id=96498
2430
2431         it broke compilation on windows debug bot (Requested by loislo
2432         on #webkit).
2433
2434         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2435         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2436         (WTR::InjectedBundlePage::InjectedBundlePage):
2437         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2438         (InjectedBundlePage):
2439         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2440         (WTR::TestRunner::TestRunner):
2441         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2442         (TestRunner):
2443
2444 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2445
2446         [Qt] Make it possible to build with "make release" and "make debug" on Windows
2447         https://bugs.webkit.org/show_bug.cgi?id=96488
2448
2449         Reviewed by Tor Arne Vestbø.
2450
2451         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
2452         because there are no such targets. We want the generated sources to be independent from release
2453         or debug build configurations, so it is sufficient to provide fake debug and release targets that
2454         redirect to the same general-purpose target (first) of creating the derived sources.
2455
2456         * qmake/mkspecs/features/default_post.prf:
2457
2458 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2459
2460         [EFL] Make DumpRenderTree smarter at finding the fonts
2461         http://webkit.org/b/96281
2462
2463         Reviewed by Gyuyoung Kim.
2464
2465         Respect WEBKITOUTPUTDIR and expand the font dir from it.
2466         Use CString consistently.
2467
2468         * DumpRenderTree/efl/FontManagement.cpp:
2469         (buildPath):
2470         (getCoreFontFiles):
2471         (addFontDirectory):
2472         (addFontFiles):
2473         (getCustomBuildDir):
2474         (getPlatformFontsPath):
2475         (addFontsToEnvironment):
2476
2477 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2478
2479         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
2480         https://bugs.webkit.org/show_bug.cgi?id=96374
2481
2482         Reviewed by Kenneth Rohde Christiansen.
2483
2484         Implement support for dumpApplicationCacheDelegateCallbacks
2485         and disallowIncreaseForApplicationCacheQuota in
2486         WebKitTestRunner and properly dump the information
2487         expected by the tests.
2488
2489         If the application cache quota is reached for a given
2490         security origin, WebKitTestRunner will reset the quota
2491         to its default value, unless intructed not to via
2492         disallowIncreaseForApplicationCacheQuota().
2493
2494         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2495         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2496         (WTR::InjectedBundlePage::InjectedBundlePage):
2497         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2498         (WTR):
2499         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2500         (InjectedBundlePage):
2501         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2502         (WTR::TestRunner::TestRunner):
2503         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2504         (WTR):
2505         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2506         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2507         (TestRunner):
2508         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2509         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2510
2511 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2512
2513         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
2514         https://bugs.webkit.org/show_bug.cgi?id=96388
2515
2516         Reviewed by Kenneth Rohde Christiansen.
2517
2518         Exported TestRunner.workerThreadCount as readonly attribute.
2519
2520         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2521         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
2522         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
2523         (WTR):
2524         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
2525         (TestRunner):
2526
2527 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2528
2529         [chromium] Consume a user gesture when creating a new view.
2530         https://bugs.webkit.org/show_bug.cgi?id=96373
2531
2532         Reviewed by Adam Barth.
2533
2534         * DumpRenderTree/chromium/WebViewHost.cpp:
2535         (WebViewHost::createView):
2536
2537 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2538
2539         [WK2][WTR] Some of TestRunner special options are not reset before testing
2540         https://bugs.webkit.org/show_bug.cgi?id=96384
2541
2542         Reviewed by Kenneth Rohde Christiansen.
2543
2544         Now values of the following special options are reset:
2545         void setAcceptsEditing(in boolean value);
2546         void setCloseRemainingWindowsWhenComplete(in boolean value);
2547         void setXSSAuditorEnabled(in boolean value);
2548         void setAllowFileAccessFromFileURLs(in boolean value);
2549         void setPluginsEnabled(in boolean value);
2550         void setPopupBlockingEnabled(in boolean value);
2551
2552         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2553         (WTR::InjectedBundle::beginTesting):
2554
2555 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
2556
2557         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
2558         https://bugs.webkit.org/show_bug.cgi?id=96273
2559
2560         Reviewed by Gyuyoung Kim.
2561
2562         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
2563         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
2564
2565         * WebKitTestRunner/CMakeLists.txt:
2566
2567 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
2568
2569         [chromium] rename webkit_resources
2570         https://bugs.webkit.org/show_bug.cgi?id=95874
2571
2572         Reviewed by James Robinson.
2573
2574         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2575
2576 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
2577
2578         [chromium] don't include content shell builders in the garden-o-matic view
2579         https://bugs.webkit.org/show_bug.cgi?id=96418
2580
2581         Reviewed by James Robinson.
2582
2583         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2584
2585 2012-09-11  Adam Klein  <adamk@chromium.org>
2586
2587         Garden-o-matic should ignore a wider variety of warnings in buildbot json
2588         https://bugs.webkit.org/show_bug.cgi?id=96411
2589
2590         Reviewed by Adam Barth.
2591
2592         Previously only the exact string "warning" was treated as a warning
2593         result. This patch treats any string with "warning" as a substring
2594         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
2595
2596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2597         (.):
2598         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2599
2600 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
2601
2602         Restore original value of mock scrollbars enabled in InternalSettings
2603         https://bugs.webkit.org/show_bug.cgi?id=87680
2604
2605         Reviewed by Adam Barth.
2606
2607         Added backup support for mock scrollbars state in
2608         InternalSettings::Backup, and removed support for these
2609         from Qt's DumpRenderTree.
2610
2611         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2612         (WebCore::WebPage::resetSettings):
2613         * DumpRenderTree/qt/TestRunnerQt.cpp:
2614         (TestRunner::setFrameFlatteningEnabled):
2615         * DumpRenderTree/qt/TestRunnerQt.h:
2616         (TestRunner):
2617
2618 2012-09-11  Dan Bernstein  <mitz@apple.com>
2619
2620         Fixed a bug where kill-old-processes failed to kill clang++.
2621
2622         Rubber-stamped by Alexey Proskuryakov.
2623
2624         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
2625         where it is passed as a regular expression to killall.
2626
2627 2012-09-11  Philippe Liard  <pliard@google.com>
2628
2629         Make sure that md5sum is not setup on non-Chromium Android platforms.
2630         https://bugs.webkit.org/show_bug.cgi?id=96393
2631
2632         Reviewed by Adam Barth.
2633
2634         Previously md5sum was setup in ChromiumAndroidDriver's constructor
2635         which is also invoked on non-Chromium Android platforms. The following patch
2636         moves this logic to _startup_test() which is guaranteed to be invoked
2637         only on Android.
2638
2639         This also updates the prompt unit test in chromium_android_unittest.py.
2640
2641         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2642         (ChromiumAndroidDriver.__init__):
2643         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
2644         (ChromiumAndroidDriver._setup_test):
2645
2646 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
2647
2648         [EFL] Rewrite the EFL-related Find modules
2649         https://bugs.webkit.org/show_bug.cgi?id=95237
2650
2651         Reviewed by Kenneth Rohde Christiansen.
2652
2653         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
2654         property and include all the Enlightenment Foundation Libraries
2655         required by the target.
2656         * EWebLauncher/CMakeLists.txt: Ditto.
2657         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2658         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
2659         now that they are not added implicitly.
2660         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
2661         property.
2662         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
2663         property and include all the Enlightenment Foundation Libraries
2664         required by the target.
2665
2666 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2667
2668         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
2669         https://bugs.webkit.org/show_bug.cgi?id=96379
2670
2671         Reviewed by Kenneth Rohde Christiansen.
2672
2673         Add implementation for setApplicationCacheOriginQuota
2674         to WebKitTestRunner.
2675
2676         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2677         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2678         (WTR::TestRunner::setApplicationCacheOriginQuota):
2679         (WTR):
2680         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2681         (TestRunner):
2682
2683 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
2684
2685         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
2686         https://bugs.webkit.org/show_bug.cgi?id=91988
2687
2688         Reviewed by Kenneth Rohde Christiansen.
2689
2690         Regular key events generated by Qt for the tab key fill both
2691         keyCode and keyText, so we should do the same for our fake events.
2692
2693         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2694         (WTR::EventSenderProxy::keyDown):
2695
2696 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2697
2698         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
2699         https://bugs.webkit.org/show_bug.cgi?id=96269
2700
2701         Reviewed by Kenneth Rohde Christiansen.
2702
2703         Exported missing testRunner.setSpatialNavigationEnabled() method.
2704
2705         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2706         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2707         (WTR::InjectedBundle::beginTesting):
2708         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2709         (WTR::TestRunner::setSpatialNavigationEnabled):
2710         (WTR):
2711         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2712         (TestRunner):
2713
2714 2012-09-11  Philippe Liard  <pliard@chromium.org>
2715
2716         Support LayoutTests on non-rooted devices for Chromium Android.
2717         https://bugs.webkit.org/show_bug.cgi?id=95346
2718
2719         Reviewed by Dirk Pranke.
2720
2721         We were requiring root permissions to sync resource files with the
2722         device by comparing host and device files' timestamp after we
2723         synchronized the device and host clocks.
2724         We now rely on md5sum provided by Chromium to handle data files
2725         synchronization.
2726
2727         * Scripts/webkitpy/layout_tests/port/chromium.py:
2728         (ChromiumPort._check_driver_build_up_to_date):
2729         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2730         (ChromiumAndroidDriver.__init__):
2731         (ChromiumAndroidDriver._setup_test):
2732         (ChromiumAndroidDriver._push_executable):
2733         (ChromiumAndroidDriver._push_test_resources):
2734         (ChromiumAndroidDriver._read_prompt):
2735
2736 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2737
2738         [Qt] Fix output paths on Windows
2739
2740         Reviewed by Tor Arne Vestbø.
2741
2742         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
2743         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
2744         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
2745         incorrect here and instead for the calculation we should use forward slashes.
2746
2747         * qmake/mkspecs/features/default_pre.prf:
2748
2749 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2750
2751         [Qt] Fix passing of defines from the build system
2752
2753         We explicitly have to pass -DENABLE_FOO=0 for every single feature
2754         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
2755         will add it's own defaults if the features are not defined.
2756
2757         At some point we might want to run a configure-test to inspect what
2758         Platform.h will do, so we can sync up the build system's view of
2759         the feature-defines with the compile-time situation.
2760
2761         Reviewed by Simon Hausmann.
2762
2763         * qmake/mkspecs/features/functions.prf:
2764
2765 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2766
2767         [Qt] Fix --qt option to build-webkit
2768
2769         Reviewed by Ossy.
2770
2771         * Scripts/webkitdirs.pm:
2772         (buildQMakeProjects):
2773
2774 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2775
2776         [Qt] Add a configure step to the Qt build system
2777
2778         This allows building the Qt port using just 'qmake WebKit.pro'. Using
2779         the build-webkit script is still supported, and will add slightly more
2780         logic to the build, such as detecting the need for clean or incremental
2781         builds.
2782
2783         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
2784         all things related to configuring the build, such as use/have/enable flags,
2785         and these are translated to defines in default_post. Project files should
2786         no longer check contains(DEFINES,...) to detect features, but use the new
2787         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
2788         options have been translated into WEBKIT_CONFIG options as well, and can
2789         be checked using build?().
2790
2791         Reviewed by Simon Hausmann.
2792
2793         * DumpRenderTree/qt/DumpRenderTree.pro:
2794         * MiniBrowser/qt/MiniBrowser.pro:
2795         * QtTestBrowser/QtTestBrowser.pro:
2796         * Scripts/build-webkit:
2797         * Scripts/webkitdirs.pm:
2798         (qtFeatureDefaults):
2799         (buildQMakeProjects):
2800         * Tools.pro:
2801         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2802         * WebKitTestRunner/InjectedBundle/Target.pri:
2803         * WebKitTestRunner/Target.pri:
2804         * qmake/.qmake.cache: Added.
2805         * qmake/configure.pri: Removed.
2806         * qmake/configure.pro: Removed.
2807         * qmake/dump-features: Added.
2808         * qmake/mkspecs/features/configure.prf: Added.
2809         * qmake/mkspecs/features/default_post.prf:
2810         * qmake/mkspecs/features/default_pre.prf:
2811         * qmake/mkspecs/features/features.prf:
2812         * qmake/mkspecs/features/features.pri:
2813         * qmake/mkspecs/features/functions.prf:
2814         * qmake/mkspecs/features/gprof.prf:
2815         * qmake/mkspecs/features/mac/default_pre.prf:
2816         * qmake/mkspecs/features/win32/default_pre.prf:
2817
2818 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2819
2820         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
2821         https://bugs.webkit.org/show_bug.cgi?id=96372
2822
2823         Reviewed by Kenneth Rohde Christiansen.
2824
2825         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
2826
2827         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2828         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2829         (WTR::TestRunner::clearApplicationCacheForOrigin):
2830         (WTR):
2831         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2832         (TestRunner):
2833
2834 2012-09-11  Peter Beverloo  <peter@chromium.org>
2835
2836         Don't ignore .pak files when making an archive for Android
2837         https://bugs.webkit.org/show_bug.cgi?id=96375
2838
2839         Reviewed by Jochen Eisinger.
2840
2841         The .pak files do need to be pushed to the device, which is currently
2842         preventing the layout test runner from correctly pushing all files.
2843
2844         * BuildSlaveSupport/built-product-archive:
2845         (archiveBuiltProduct):
2846
2847 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2848
2849         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
2850         https://bugs.webkit.org/show_bug.cgi?id=96256
2851
2852         Reviewed by Kenneth Rohde Christiansen.
2853
2854         Exported TestRunner::setMinimumTimerInterval() method.
2855
2856         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2857         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2858         (WTR::InjectedBundle::beginTesting):
2859         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2860         (WTR::TestRunner::setMinimumTimerInterval):
2861         (WTR):
2862         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2863         (TestRunner):
2864
2865 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
2866
2867         MediaStream API: add RTCPeerConnection::onnegotiationneeded
2868         https://bugs.webkit.org/show_bug.cgi?id=96097
2869
2870         Reviewed by Adam Barth.
2871
2872         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2873         (MockWebRTCPeerConnectionHandler::addStream):
2874         (MockWebRTCPeerConnectionHandler::removeStream):
2875
2876 2012-09-11  Peter Beverloo  <peter@chromium.org>
2877
2878         Recognize the "--chromium-android" argument in run-webkit-tests
2879         https://bugs.webkit.org/show_bug.cgi?id=96369
2880
2881         Reviewed by Jochen Eisinger.
2882
2883         Chromium for the Android platform cannot determine the platform based on
2884         the host itself, so we'll use the --chromium-android argument as the build
2885         master passes to run-webkit-tests. Make sure the layout test runner
2886         can pick the right port when doing so.
2887
2888         * Scripts/run-webkit-tests:
2889         * Scripts/webkitpy/layout_tests/port/factory.py:
2890         (port_options):
2891
2892 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2893
2894         [QT] Fix build with newer qmake from Qt 5
2895
2896         Rubber-stamped by Tor Arne Vestbø.
2897
2898         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
2899         it with the use of QT_HOST_DATA/mkspecs.
2900         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
2901
2902         * Scripts/webkitdirs.pm:
2903         (builtDylibPathForName):
2904         (qtMakeCommand):
2905
2906 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2907
2908         [Qt] Remove Qt 4 syncqt, no longer needed
2909
2910         Reviewed by Simon Hausmann.
2911
2912         * qmake/syncqt-4.8: Removed.
2913
2914 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
2915
2916         [Qt][WK2] Fix the build with recent Qt5
2917         https://bugs.webkit.org/show_bug.cgi?id=96283
2918
2919         Reviewed by Simon Hausmann.
2920
2921         We should not use deprecated Qt API because doing that results
2922         in build failure since all the deprecated API was disabled
2923         in qtbase (https://codereview.qt-project.org/#change,24890).
2924
2925         * DumpRenderTree/qt/main.cpp:
2926         (main):
2927         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2928         (MiniBrowserApplication::notify):
2929         * MiniBrowser/qt/raw/View.cpp:
2930         (View::exposeEvent):
2931         (main):
2932
2933 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2934
2935         WTR needs an implementation of applicationCacheDiskUsageForOrigin
2936         https://bugs.webkit.org/show_bug.cgi?id=87188
2937
2938         Reviewed by Kenneth Rohde Christiansen.
2939
2940         Add implementation for applicationCacheDiskUsageForOrigin()
2941         in WebKitTestRunner.
2942
2943         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2944         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2945         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2946         (WTR):
2947         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2948         (TestRunner):
2949
2950 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
2951
2952         Properly expose <legend> elements to ATs
2953         https://bugs.webkit.org/show_bug.cgi?id=84137
2954
2955         Reviewed by Chris Fleizach.
2956
2957         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
2958         the expected platform role, ATK_ROLE_LABEL. Also established the needed
2959         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
2960
2961         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2962         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
2963
2964 2012-09-10  Jer Noble  <jer.noble@apple.com>
2965
2966         Unreviewed; rolling out r128081.
2967         http://trac.webkit.org/changeset/128081
2968         https://bugs.webkit.org/show_bug.cgi?id=96134
2969
2970         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
2971
2972         * DumpRenderTree/TestRunner.cpp:
2973         (TestRunner::TestRunner):
2974         (TestRunner::staticFunctions):
2975         * DumpRenderTree/TestRunner.h:
2976         (TestRunner):
2977         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2978         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2979         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2980         (WTR::InjectedBundlePage::InjectedBundlePage):
2981         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2982         (InjectedBundlePage):
2983         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2984         (WTR::TestRunner::TestRunner):
2985         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2986         (TestRunner):
2987
2988 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2989
2990         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
2991         https://bugs.webkit.org/show_bug.cgi?id=96205
2992
2993         Reviewed by Tony Chang.
2994
2995         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
2996         internally, which means that it would support only 1 TestExpectations file per port. This
2997         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
2998         and efl-wk1 -> efl).
2999
3000         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
3001         instead so that all the ports TestExpectations are recognized. The ports are also
3002         constructed twice, with "webkit_test_runner" option set to True and False so that we
3003         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
3004
3005         * Scripts/webkitpy/style/checkers/test_expectations.py:
3006         (TestExpectationsChecker._determine_port_from_expectations_path):
3007         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
3008         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
3009
3010 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
3011
3012         [WTR] Generated source files should include config.h
3013         https://bugs.webkit.org/show_bug.cgi?id=96254
3014
3015         Reviewed by Benjamin Poulain.
3016
3017         Current coding style has encouraged to include config.h at the first position,
3018         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
3019         this rule.
3020         Therefore, this patch added it.
3021
3022         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3023         (_generateImplementationFile):
3024
3025 2012-09-10  Rick Byers  <rbyers@chromium.org>
3026
3027         Add handling of new GestureTapCancel in DRT
3028         
3029         https://bugs.webkit.org/show_bug.cgi?id=96183
3030
3031         Reviewed by Adam Barth.
3032
3033         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3034         (TestWebPlugin::handleInputEvent):
3035
3036 2012-09-10  Brady Eidson  <beidson@apple.com>
3037
3038         Javascript in foreground tabs should not wait synchronously for plug-ins to load
3039         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
3040
3041         Reviewed by Geoff Garen.
3042
3043         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
3044
3045         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
3046         (PluginObject):
3047         (SlowNPPNew::PluginObject::PluginObject):
3048         (SlowNPPNew::PluginObject::~PluginObject):
3049         (SlowNPPNew::PluginObject::hasProperty):
3050         (SlowNPPNew::PluginObject::getProperty):
3051         (SlowNPPNew::NPP_GetValue):
3052         (SlowNPPNew):
3053
3054 2012-09-10  Tim Horton  <timothy_horton@apple.com>
3055
3056         WKTR often reports an unresponsive WebProcess on Mac bots
3057         https://bugs.webkit.org/show_bug.cgi?id=95906
3058
3059         Reviewed by Dan Bernstein.
3060
3061         Attempt to work around resource contention issues by increasing the NRWT
3062         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
3063
3064         * Scripts/webkitpy/layout_tests/port/base.py:
3065         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
3066         * WebKitTestRunner/TestController.cpp:
3067         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
3068
3069 2012-09-07  Jer Noble  <jer.noble@apple.com>
3070
3071         <audio> and <video> should send Do Not Track when appropriate
3072         https://bugs.webkit.org/show_bug.cgi?id=96134
3073
3074         Reviewed by Eric Carlson.
3075
3076         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
3077         WTR. Add FrameLoaderClient client methods for retrieving that value.
3078
3079         * DumpRenderTree/TestRunner.cpp:
3080         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
3081         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
3082         * DumpRenderTree/TestRunner.h:
3083         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
3084         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
3085         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3086         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
3087             Pass the question on to the TestRunner.
3088         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3089         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3090         (WTR::InjectedBundlePage::InjectedBundlePage):
3091             Add the setShouldSendDoNotTrackHTTPHeader client function.
3092         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
3093             Pass the question on to the TestRunner.
3094         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3095         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3096         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3097         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
3098         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
3099
3100 2012-09-10  Ojan Vafai  <ojan@chromium.org>
3101
3102         Make EFL bots work on the flakiness dashboard
3103         https://bugs.webkit.org/show_bug.cgi?id=96164
3104
3105         Reviewed by Tony Chang.
3106
3107         Also, update outdated unittests that had started failing.
3108
3109         * TestResultServer/static-dashboards/builders.js:
3110         (isWebkitTestRunner):
3111         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3112         (nonChromiumPlatform):
3113         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3114         (test):
3115
3116 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
3117
3118         [chromium] MediaStream API: Remove the Descriptor postfix
3119         https://bugs.webkit.org/show_bug.cgi?id=96268
3120
3121         Reviewed by Adam Barth.
3122
3123         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
3124         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
3125
3126         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3127         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3128         (MockWebRTCPeerConnectionHandler::createOffer):
3129         (MockWebRTCPeerConnectionHandler::createAnswer):
3130         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3131         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3132         (MockWebRTCPeerConnectionHandler::localDescription):
3133         (MockWebRTCPeerConnectionHandler::remoteDescription):
3134         (MockWebRTCPeerConnectionHandler::addICECandidate):
3135         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3136         (MockWebRTCPeerConnectionHandler):
3137
3138 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
3139
3140         [Gtk] failure to build jhbuild dependencies with cups 1.6
3141         https://bugs.webkit.org/show_bug.cgi?id=95991
3142
3143         Reviewed by Gustavo Noronha Silva.
3144
3145         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
3146         building with cups >= 1.6 [GNOME #670373].
3147
3148         * gtk/jhbuild.modules:
3149
3150 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
3151
3152         [EFL][DRT] Encoding issue in printed console messages
3153         https://bugs.webkit.org/show_bug.cgi?id=96263
3154
3155         Reviewed by Kenneth Rohde Christiansen.
3156
3157         Correctly handle CONSOLE messages that contain non-ascii
3158         characters in EFL's DRT. We need to use String::fromUTF8()
3159         to construct a WTF::String from a raw string.
3160
3161         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3162         (onConsoleMessage):
3163
3164 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3165
3166         [WK2][WTR] User style sheet location should be reset before each test
3167         https://bugs.webkit.org/show_bug.cgi?id=96262
3168
3169         Reviewed by Kenneth Rohde Christiansen.
3170
3171         User style sheet location is reset before each test now.
3172
3173         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3174         (WTR::InjectedBundle::beginTesting):
3175
3176 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
3177
3178         Fix build of WTR with Qt on Windows
3179         https://bugs.webkit.org/show_bug.cgi?id=96249
3180
3181         Reviewed by Kenneth Rohde Christiansen.
3182
3183         Windows loves to define min and max as macros, which beautifully
3184         clashes in many places where min and max are used as variable or method
3185         names. It can be convinced not to do this when min and max are already
3186         define as macros (expanding to themselves). We have this kind of
3187         workaround in config.h files all over WebKit and as it turns out when
3188         building WTR with Qt on Windows we do end up with such a clash. Therefore
3189         we need the same workaround.
3190
3191         * WebKitTestRunner/config.h:
3192
3193 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
3194
3195         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
3196         https://bugs.webkit.org/show_bug.cgi?id=95936
3197
3198         Reviewed by Kenneth Rohde Christiansen.
3199
3200         Enable interactive form validation setting in WebKitTestRunner as
3201         we are currently doing in DumpRenderTree. This is needed for some
3202         tests to pass.
3203
3204         * WebKitTestRunner/TestController.cpp:
3205         (WTR::TestController::resetStateToConsistentValues):
3206
3207 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
3208
3209         Clean up the code in XvfbDriver
3210         https://bugs.webkit.org/show_bug.cgi?id=96202
3211
3212         Reviewed by Philippe Normand.
3213
3214         Changes:
3215         - Remove unneeded imports,
3216         - assign the _lock_file member variable when the display number is determined,
3217         - no need for parentheses around a single string format argument,
3218         - use FileSystem.exists method when checking if lock file is present as it
3219         makes the intention much more clearer.
3220
3221         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3222         (XvfbDriver._start):
3223         (XvfbDriver.stop):
3224
3225 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
3226
3227         Make the String initialization on the function side of String::number()
3228         https://bugs.webkit.org/show_bug.cgi?id=95940
3229
3230         Reviewed by Benjamin Poulain.
3231
3232         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
3233         (testBoundaries):
3234         (testNumbers):
3235
3236 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
3237
3238         [WK2] expose element rect for color input type
3239         https://bugs.webkit.org/show_bug.cgi?id=91664
3240
3241         Reviewed by Simon Hausmann.
3242
3243         Update the QML logic in MiniBrowser to take advantage of this.
3244         The picker size is now hardcoded and we try to place it below the
3245         input element if possible.
3246
3247         * MiniBrowser/qt/qml/ColorChooser.qml:
3248
3249 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
3250
3251         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
3252         https://bugs.webkit.org/show_bug.cgi?id=95329
3253
3254         Reviewed by Kenneth Rohde Christiansen.
3255
3256         Explicitely disable TabToLinks setting in WebKitTestRunner.
3257         Tests override the "WebKitTabToLinksPreferenceKey" preference
3258         to enable it.
3259
3260         * WebKitTestRunner/TestController.cpp:
3261         (WTR::TestController::resetStateToConsistentValues):
3262
3263 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
3264
3265         webkit.py gdb pretty printer can't print CString
3266         https://bugs.webkit.org/show_bug.cgi?id=96068
3267
3268         Reviewed by Tony Chang.
3269
3270         Update WTFCStringPrinter to follow r126191.
3271
3272         * gdb/webkit.py:
3273         (WTFCStringPrinter.to_string):
3274
3275 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
3276
3277         Rename the ustring() accessor to string()
3278         https://bugs.webkit.org/show_bug.cgi?id=95919
3279
3280         Reviewed by Geoffrey Garen.
3281
3282         Update EFL's DRT.
3283
3284         Fix some string conversion that have been made useless
3285         with recent changes.
3286
3287         * DumpRenderTree/efl/EventSender.cpp:
3288         (keyPadNameFromJSValue):
3289         (keyNameFromJSValue):
3290         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3291         (TestRunner::queueLoad):
3292         (TestRunner::addOriginAccessWhitelistEntry):
3293         (TestRunner::removeOriginAccessWhitelistEntry):
3294         (TestRunner::setUserStyleSheetLocation):
3295         (TestRunner::setValueForUser):
3296         (TestRunner::elementDoesAutoCompleteForElementWithId):
3297         (TestRunner::execCommand):
3298         (TestRunner::findString):
3299         (TestRunner::isCommandEnabled):
3300         (TestRunner::clearApplicationCacheForOrigin):
3301         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3302         (TestRunner::pauseAnimationAtTimeOnElementWithId):
3303         (TestRunner::pauseTransitionAtTimeOnElementWithId):
3304         (toInt):
3305         (TestRunner::overridePreference):
3306         (TestRunner::addUserScript):
3307         (TestRunner::addUserStyleSheet):
3308         (TestRunner::evaluateInWebInspector):
3309         (TestRunner::evaluateScriptInIsolatedWorld):
3310         (TestRunner::setTextDirection):
3311         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3312         (LoadItem::invoke):
3313         (LoadHTMLStringItem::invoke):
3314         (ScriptItem::invoke):
3315
3316 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
3317
3318         Extend third-party storage blocking API to optionally allow blocking all storage
3319         https://bugs.webkit.org/show_bug.cgi?id=95915
3320
3321         Reviewed by Brady Eidson.
3322
3323         Modified API test to use new revised API.
3324
3325         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3326         (TestWebKitAPI::TEST):
3327
3328 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
3329
3330         AX: WebCore accessibility roles should be cross-platform
3331         https://bugs.webkit.org/show_bug.cgi?id=94870
3332
3333         Reviewed by Chris Fleizach.
3334
3335         Add debug strings to Chromium for new accessibility roles.
3336
3337         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3338         (roleToString):
3339
3340 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
3341
3342         AX: Chromium needs access to canvasHasFallbackContent
3343         https://bugs.webkit.org/show_bug.cgi?id=96124
3344
3345         Reviewed by Chris Fleizach.
3346
3347         Distinguish between canvas roles with and without fallback
3348         content on Chromium.
3349
3350         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3351         (getRole):
3352
3353 2012-09-07  Ojan Vafai  <ojan@chromium.org>
3354
3355         Handle non-existant TestExpectations files gracefully
3356         https://bugs.webkit.org/show_bug.cgi?id=96149
3357
3358         Reviewed by Eric Seidel.
3359
3360         Even when we get rid of Skipped files, we shouldn't have each port
3361         require a TestExpectations file for each platform if it doesn't
3362         need one.
3363
3364         * Scripts/webkitpy/layout_tests/port/base.py:
3365         (Port.expectations_dict):
3366         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3367         (PortTest.test_nonexistant_expectations):
3368
3369 2012-09-07  Tony Chang  <tony@chromium.org>
3370
3371         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
3372         https://bugs.webkit.org/show_bug.cgi?id=96136
3373
3374         Reviewed by Ojan Vafai.
3375
3376         When we renamed the file to TestExpectations, it was no longer considered a text file so
3377         it was no longer being checked. Since then, test_expectations_overrides() has been removed
3378         from the port object, so I've removed that from the check. I'm not sure what it was
3379         supposed to do.
3380
3381         * Scripts/webkitpy/style/checker.py:
3382         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
3383         * Scripts/webkitpy/style/checkers/test_expectations.py:
3384         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
3385         (TestExpectationsChecker.check): Remove overrides param.
3386         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3387         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
3388
3389 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3390
3391         [EFL] Use same default minimum logical font size in DRT and WTR
3392         https://bugs.webkit.org/show_bug.cgi?id=96116
3393
3394         Reviewed by Martin Robinson.
3395
3396         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3397         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
3398         logical font size to 9 to match the value used in WTR.
3399         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3400         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
3401         logical font size to 9 (default value in WK2)
3402
3403 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
3404
3405         MediaStream API: add RTCPeerConnection::createAnswer
3406         https://bugs.webkit.org/show_bug.cgi?id=96092
3407
3408         Reviewed by Adam Barth.
3409
3410         Expanding and enhancing MockWebRTCPeerConnectionHandler.
3411
3412         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3413         (MockWebRTCPeerConnectionHandler::createOffer):
3414         (MockWebRTCPeerConnectionHandler::createAnswer):
3415         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3416         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3417         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3418         (MockWebRTCPeerConnectionHandler):
3419
3420 2012-09-07  Dean Jackson  <dino@apple.com>
3421
3422         Unreviewed changes to watchlist.
3423
3424         - Add new WebGL and Filters definitions
3425         - Add myself to OpenGL bugs
3426
3427         * Scripts/webkitpy/common/config/watchlist:
3428
3429 2012-09-07  Peter Beverloo  <peter@chromium.org>
3430
3431         Actually trigger the Android Tester
3432         https://bugs.webkit.org/show_bug.cgi?id=96118
3433
3434         Reviewed by Adam Barth.
3435
3436         * BuildSlaveSupport/build.webkit.org-config/config.json:
3437
3438 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
3439
3440         New time input needs accessibility
3441         https://bugs.webkit.org/show_bug.cgi?id=96032
3442
3443         Reviewed by Chris Fleizach.
3444
3445         Add support for valueDescription for testing.
3446
3447         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3448         (getValueDescription):
3449         (AccessibilityUIElement::AccessibilityUIElement):
3450         (AccessibilityUIElement::valueDescriptionGetterCallback):
3451         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
3452         (AccessibilityUIElement):
3453
3454 2012-09-07  Peter Beverloo  <peter@chromium.org>
3455
3456         Add the google-android-tests build slave to the master's config
3457         https://bugs.webkit.org/show_bug.cgi?id=96113
3458
3459         Reviewed by Csaba Osztrogonác.
3460
3461         * BuildSlaveSupport/build.webkit.org-config/config.json:
3462
3463 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3464
3465         [WK2] [EFL] Set theme for WebKit2 API test runner
3466         https://bugs.webkit.org/show_bug.cgi?id=96100
3467
3468         Reviewed by Kenneth Rohde Christiansen.
3469
3470         Set the theme generated by the build for the WebKit2 API test runner.
3471
3472         * TestWebKitAPI/PlatformEfl.cmake:
3473         * TestWebKitAPI/efl/PlatformWebView.cpp:
3474         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3475
3476 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
3477
3478         Unreviewed. Add Gábor Ballabás as contributor.
3479
3480         * Scripts/webkitpy/common/config/committers.py:
3481
3482 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
3483
3484         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
3485         https://bugs.webkit.org/show_bug.cgi?id=96078
3486
3487         Reviewed by Tor Arne Vestbø.
3488
3489         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
3490
3491         * qmake/mkspecs/features/default_pre.prf:
3492
3493 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3494
3495         [EFL] Add TestExpectations file for efl-wk1
3496         https://bugs.webkit.org/show_bug.cgi?id=96019
3497
3498         Reviewed by Gyuyoung Kim.
3499
3500         Update TestExpectations cascading for EFL port
3501         so that we use efl-wk1 -> efl search paths
3502         for WebKit1 EFL.
3503
3504         * Scripts/webkitpy/layout_tests/port/efl.py:
3505         (EflPort._search_paths):
3506
3507 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
3508
3509         [NRWT] XvfbDriver should stop the Xvfb more aggressively
3510         https://bugs.webkit.org/show_bug.cgi?id=95097
3511
3512         Reviewed by Dirk Pranke.
3513
3514         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
3515         terminating the process does not always work as expected, leading to timeouts
3516         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
3517         as it's not removed by the killed Xvfb process.
3518
3519         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
3520         is tested in different circumstances - whether pixel tests are enabled or not,
3521         with an arbitrary worker number or with an Xorg process already running on the system.
3522         The stopping of the driver is tested by checking that the Xvfb process is truly killed
3523         and then set to None.
3524
3525         * BuildSlaveSupport/kill-old-processes:
3526         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
3527         is left running, potentially clogging up a display at a certain position.
3528         * Scripts/webkitpy/common/system/executive_mock.py:
3529         (MockExecutive.__init__):
3530         The _running_pids is now a dictionary with process names as keys and pids
3531         as values.
3532         (MockExecutive.check_running_pid):
3533         Check whether the passed-in pid is in the _running_pids dictionary's values.
3534         (MockExecutive):
3535         (MockExecutive.running_pids):
3536         This method returns the list of all the process pids of which the name passes
3537         through the process_name_filter.
3538         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3539         Use the Executive object of the port's host to check for running pids and open
3540         new subprocesses or kill them throughout the class.
3541         (XvfbDriver._start):
3542         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
3543         start the server process after it's created.
3544         (XvfbDriver.stop):
3545         Now kills the Xvfb process instead of terminating it and waiting for it to close.
3546         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
3547         (XvfbDriverTest):
3548         (XvfbDriverTest.make_driver):
3549         (XvfbDriverTest.assertDriverStartSuccessful):
3550         (XvfbDriverTest.test_start_no_pixel_tests):
3551         (XvfbDriverTest.test_start_pixel_tests):
3552         (XvfbDriverTest.test_start_arbitrary_worker_number):
3553         (XvfbDriverTest.test_start_existing_xorg_process):
3554         (XvfbDriverTest.test_stop):
3555         (XvfbDriverTest.test_stop.FakeXvfbProcess):
3556
3557 2012-09-06  Peter Beverloo  <peter@chromium.org>
3558
3559         Introduce the Chromium Android Release (Tests) bot
3560         https://bugs.webkit.org/show_bug.cgi?id=95980
3561
3562         Reviewed by Adam Barth.
3563
3564         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
3565         which will be running layout tests on actual Android devices. Right now,
3566         four Galaxy Nexus phones are attached.
3567
3568         * BuildSlaveSupport/build.webkit.org-config/config.json:
3569
3570 2012-09-06  James Robinson  <jamesr@chromium.org>
3571
3572         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
3573         https://bugs.webkit.org/show_bug.cgi?id=96007
3574
3575         Reviewed by Adrienne Walker.
3576
3577         Fixes initialization / settings code to use WebCompositorSupport.
3578
3579         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3580         (main):
3581         * DumpRenderTree/chromium/TestShell.cpp:
3582         (TestShell::initialize):
3583         (TestShell::setPerTilePaintingEnabled):
3584
3585 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3586
3587         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
3588         https://bugs.webkit.org/show_bug.cgi?id=95995
3589
3590         Reviewed by Kenneth Rohde Christiansen.
3591
3592         Provide proper implementation for PlatformWebView::windowFrame()
3593         in EFL's WebKitTestRunner.
3594
3595         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3596         (WTR::PlatformWebView::windowFrame):
3597
3598 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
3599
3600         Fix WTF.Lrint on 32-bit platforms
3601         https://bugs.webkit.org/show_bug.cgi?id=96003
3602
3603         Reviewed by Benjamin Poulain.
3604
3605         Fixed failing WTF.Lrint test on 32-bit platforms.
3606
3607         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3608         (TestWebKitAPI::TEST):
3609
3610 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
3611
3612         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3613         https://bugs.webkit.org/show_bug.cgi?id=95839
3614
3615         Reviewed by Adam Barth.
3616
3617         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3618         up the task definitions a bit. There was no need to have them in the header file.
3619
3620         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3621         (RTCSessionDescriptionRequestSuccededTask):
3622         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3623         (RTCSessionDescriptionRequestFailedTask):
3624         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3625         (RTCVoidRequestTask):
3626         (RTCVoidRequestTask::RTCVoidRequestTask):
3627         (MockWebRTCPeerConnectionHandler::createOffer):
3628         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3629         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3630         (MockWebRTCPeerConnectionHandler::localDescription):
3631         (MockWebRTCPeerConnectionHandler::remoteDescription):
3632         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3633         (MockWebRTCPeerConnectionHandler):
3634
3635 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3636
3637         [Qt] Fix build on Mac OS X 10.6
3638         https://bugs.webkit.org/show_bug.cgi?id=95200
3639
3640         Reviewed by Tor Arne Vestbø.
3641
3642         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
3643         10.7 and newer.
3644
3645         * qmake/mkspecs/features/features.prf:
3646
3647 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3648
3649         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
3650         https://bugs.webkit.org/show_bug.cgi?id=95973
3651
3652         Reviewed by Kenneth Rohde Christiansen.
3653
3654         Correctly map "addSelectionKey" to "Control" modifier
3655         in WKTR's EventSender on other OSes than Mac OS X,
3656         instead of mapping it to the "Meta" modifier.
3657
3658         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3659         (WTR::parseModifier):
3660
3661 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
3662
3663         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
3664         https://bugs.webkit.org/show_bug.cgi?id=95710
3665
3666         Reviewed by Dirk Pranke.
3667
3668         The stdout / stderr output can be None so make sure
3669         we won't raise an exception in this case.
3670
3671         * Scripts/webkitpy/layout_tests/port/driver.py:
3672         (Driver.run_test):
3