[EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2
3         [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
4         https://bugs.webkit.org/show_bug.cgi?id=79904
5
6         build-webkit --efl will use jhbuild for fetching and building dependencies.
7
8         Reviewed by Gustavo Noronha Silva.
9
10         * Scripts/update-webkitefl-libs: Added.
11         * Scripts/webkitdirs.pm:
12         (jhbuildWrapperPrefixIfNeeded):
13         (generateBuildSystemFromCMakeProject):
14         (buildCMakeGeneratedProject):
15         * efl/common.py: Added.
16         (script_path):
17         (top_level_path):
18         (number_of_cpus):
19         * efl/jhbuild.modules: Added.
20         * efl/jhbuildrc: Added.
21         * efl/run-with-jhbuild: Added.
22
23 2012-03-16  Stephanie Lewis  <slewis@apple.com>
24
25         https://bugs.webkit.org/show_bug.cgi?id=81065
26         <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
27         Fix crash preventing WebKitTestRunner from working in Release.  
28         WebKitTestRunner used ostringstream to collect output from the test.  ostringstream is incompatible with our
29         FastMalloc overrides.  When copying strings out ostringstream a new string is allocated with FastMalloc because
30         the allocation is inlined.  When that string is freed is uses the system malloc because that call is not inlined.
31
32         I removed ostringstream in favor of StringBuilder.  
33
34         Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
35
36         Reviewed by Geoff Garen.
37
38         Add DEBUG_DEFINES to set NDEBUG on release builds.
39         * WebKitTestRunner/Configurations/Base.xcconfig:
40         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
41
42         Remove ostringstream member in favor of StringBuilder.
43         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
44         (WTR::InjectedBundle::initialize):
45         (WTR::InjectedBundle::beginTesting):
46         (WTR::InjectedBundle::done):
47         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
48         (WTF):
49         (WTR::InjectedBundle::stringBuilder):
50         (InjectedBundle):
51
52         Append output to StringBuilder.
53         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
54         (WTR::hasPrefix):
55         (WTR::dumpPath):
56         (WTR::rangeToStr):
57         (WTR::styleDecToStr):
58         (WTR::frameToStr):
59         (WTR::dumpFrameScrollPosition):
60         (WTR::dumpFrameText):
61         (WTR::dumpDescendantFramesText):
62         (WTR::InjectedBundlePage::dump):
63         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
64         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
65         (WTR::InjectedBundlePage::willSendRequestForFrame):
66         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
67         (WTR::lastFileURLPathComponent):
68         (WTR::InjectedBundlePage::willAddMessageToConsole):
69         (WTR::InjectedBundlePage::willSetStatusbarText):
70         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
71         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
72         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
73         (WTR::InjectedBundlePage::shouldBeginEditing):
74         (WTR::InjectedBundlePage::shouldEndEditing):
75         (WTR::InjectedBundlePage::shouldInsertNode):
76         (WTR::InjectedBundlePage::shouldInsertText):
77         (WTR::InjectedBundlePage::shouldDeleteRange):
78         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
79         (WTR::InjectedBundlePage::shouldApplyStyle):
80         (WTR::InjectedBundlePage::didBeginEditing):
81         (WTR::InjectedBundlePage::didEndEditing):
82         (WTR::InjectedBundlePage::didChange):
83         (WTR::InjectedBundlePage::didChangeSelection):
84         (WTR::InjectedBundlePage::supportsFullScreen):
85         (WTR::InjectedBundlePage::enterFullScreenForElement):
86         (WTR::InjectedBundlePage::exitFullScreenForElement):
87         (WTR::InjectedBundlePage::beganEnterFullScreen):
88         (WTR::InjectedBundlePage::beganExitFullScreen):
89         (WTR::dumpBackForwardListItem):
90         (WTR::InjectedBundlePage::dumpBackForwardList):
91         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
92         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
93         (WTR::LayoutTestController::dumpConfigurationForViewport):
94         
95         Convert between WTF::String and WKStringRef.
96         * WebKitTestRunner/StringFunctions.h:
97         (WTR::toWTFString):
98         (WTR):
99         * WebKitTestRunner/TestInvocation.cpp:
100         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
101
102 2012-03-16  Eric Seidel  <eric@webkit.org>
103
104         Add a land-from-url command
105         https://bugs.webkit.org/show_bug.cgi?id=81411
106
107         Reviewed by Adam Barth.
108
109         Very basic so far.  The goal is to make it landing smarter
110         so that users don't have to bother to parse out the ids out of the urls.
111
112         * Scripts/webkitpy/common/config/urls.py:
113         (parse_bug_id):
114         (parse_attachment_id):
115         * Scripts/webkitpy/common/config/urls_unittest.py:
116         (URLsTest.test_parse_bug_id):
117         (URLsTest):
118         (URLsTest.test_parse_attachment_id):
119         * Scripts/webkitpy/tool/commands/download.py:
120         (ProcessURLsMixin):
121         (ProcessURLsMixin._fetch_list_of_patches_to_process):
122         (LandFromURL):
123         * Scripts/webkitpy/tool/commands/download_unittest.py:
124         (test_land_from_bug):
125         (test_land_from_url):
126
127 2012-03-16  Dave Tharp  <dtharp@codeaurora.org>
128
129         build-webkit launcher instructions use wrong relative path for Qt
130         https://bugs.webkit.org/show_bug.cgi?id=81357
131
132         Reviewed by Eric Seidel.
133
134         Ensure we are at the proper directory before generating run-launcher
135         instructions.
136
137         * Scripts/build-webkit:
138
139 2012-03-16  Brady Eidson  <beidson@apple.com>
140
141         <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
142         REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
143
144         Reviewed by Geoff Garen.
145
146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
147         * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
148
149 2012-03-16  Ojan Vafai  <ojan@chromium.org>
150
151         Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
152         https://bugs.webkit.org/show_bug.cgi?id=81407
153
154         Reviewed by Adam Barth.
155
156         * Scripts/webkitpy/layout_tests/controllers/manager.py:
157         (summarize_results):
158         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
159         (ResultSummaryTest.summarized_results):
160         (ResultSummaryTest.test_no_svn_revision):
161         (ResultSummaryTest.test_svn_revision):
162         (ResultSummaryTest):
163         (ResultSummaryTest.test_summarized_results_wontfix):
164
165 2012-03-16  Ojan Vafai  <ojan@chromium.org>
166
167         Have webkit-patch rebaseline-test update test_expectations.txt
168         https://bugs.webkit.org/show_bug.cgi?id=81054
169
170         Recommit http://trac.webkit.org/changeset/110783 now that
171         http://trac.webkit.org/changeset/111034 has landed.
172
173         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
174         (TestExpectations.remove_configuration_from_test):
175         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
176         (RemoveConfigurationsTest):
177         (RemoveConfigurationsTest.test_remove):
178         (test_remove_line):
179         * Scripts/webkitpy/tool/commands/rebaseline.py:
180         (RebaselineTest._update_expectations_file):
181         (RebaselineTest._rebaseline_test_and_update_expectations):
182         (RebaselineTest):
183         (RebaselineTest.execute):
184         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
185         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
186         (test_rebaseline_updates_expectations_file):
187
188 2012-03-15  Ojan Vafai  <ojan@chromium.org>
189
190         Specifier collapsing when writing test expectations lines gets a number of cases wrong
191         https://bugs.webkit.org/show_bug.cgi?id=81309
192
193         Reviewed by Dimitri Glazkov.
194
195         I've run this over all the lines in the current Chromium test_expectations.txt file,
196         so I'm relatively confident we now cover all the cases.
197
198         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
199         (TestConfigurationConverter.__init__):
200         (TestConfigurationConverter.collapse_macros):
201         (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
202         (TestConfigurationConverter):
203         (TestConfigurationConverter.intersect_combination):
204         (TestConfigurationConverter.symmetric_difference):
205         (TestConfigurationConverter.to_specifiers_list):
206         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
207         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
208         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
209         (make_mock_all_test_configurations_set):
210         (TestConfigurationConverterTest.test_symmetric_difference):
211         (TestConfigurationConverterTest.test_to_config_set):
212         (TestConfigurationConverterTest.test_macro_expansion):
213         (TestConfigurationConverterTest.test_to_specifier_lists):
214         (TestConfigurationConverterTest.test_converter_macro_collapsing):
215         * Scripts/webkitpy/layout_tests/port/chromium.py:
216         (ChromiumPort):
217         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
218         (ChromiumAndroidPort.__init__):
219         The android port uses "arm" as it's architecture, which is technically correct,
220         but considerably complicates making collapsing work. We probably should kill
221         the concept of architecture entirely. The benefits are not worth the code
222         complexity.
223
224         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
225         (ChromiumPortTest.test_all_test_configurations):
226         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
227         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
228         (test_rebaseline_updates_expectations_file):
229
230 2012-03-16  Dinu Jacob  <dinu.jacob@nokia.com>
231
232         [Qt][Wk2] Assertion Failure and crash on file upload
233         https://bugs.webkit.org/show_bug.cgi?id=80854
234
235         Reviewed by Simon Hausmann.
236
237         Added filePicker to WebView using experimental API.
238
239         * MiniBrowser/qt/MiniBrowser.qrc:
240         * MiniBrowser/qt/icons/folder.png: Added.
241         * MiniBrowser/qt/icons/titlebar.png: Added.
242         * MiniBrowser/qt/icons/up.png: Added.
243         * MiniBrowser/qt/qml/BrowserWindow.qml:
244         * MiniBrowser/qt/qml/FilePicker.qml: Added.
245
246 2012-03-16  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
247
248         Updating email for committer.py script.
249
250         * Scripts/webkitpy/common/config/committers.py:
251
252 2012-03-16  Robert Kroeger  <rjkroege@chromium.org>
253
254         [chromium] DRT: Add support for sending gesture scrolls without a begin
255         https://bugs.webkit.org/show_bug.cgi?id=81292
256
257         Reviewed by Kent Tamura.
258
259         * DumpRenderTree/chromium/EventSender.cpp:
260         (EventSender::EventSender):
261         (EventSender::gestureScrollFirstPoint):
262         * DumpRenderTree/chromium/EventSender.h:
263         (EventSender):
264
265 2012-03-02  Carlos Garcia Campos  <cgarcia@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
266
267         [GTK] WebKitIconDatabase doesn't keep icons cached
268         https://bugs.webkit.org/show_bug.cgi?id=56200
269
270         Reviewed by Martin Robinson.
271
272         Add support for favicons in GtkLauncher.
273
274         * GtkLauncher/main.c:
275         (activateUriEntryCb):
276         (iconLoadedCb):
277         (createBrowser):
278
279 2012-03-16  Adam Barth  <abarth@webkit.org>
280
281         Remove sheriff-bot's last-green-revision command
282         https://bugs.webkit.org/show_bug.cgi?id=81314
283
284         Reviewed by Eric Seidel.
285
286         This command is a cruel joke.  WebKit doesn't really ever have a
287         last-green-revision.
288
289         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
290         (BuildBot._find_green_revision):
291         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
292         (MockBuildBot.builder_statuses):
293         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
294         (test_find_green_revision):
295         * Scripts/webkitpy/tool/bot/irc_command.py:
296         (IRCCommand.execute):
297         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
298         (SheriffIRCBotTest.test_help):
299         * Scripts/webkitpy/tool/commands/queries.py:
300         (PatchesToReview.execute):
301
302 2012-03-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
303
304         [Qt] Make gccdepends test aware of broken icecream deps generation
305
306         Icecream seems to build the files without passing -o to gcc with
307         the original destination path, which means the target name in the
308         dependency file is wrong.
309
310         Also, echo something to the final file instead of just touching it,
311         so it's not deleted on every build.
312
313         Reviewed by Simon Hausmann.
314
315         * qmake/config.tests/gccdepends/gccdepends.pro:
316
317 2012-03-16  Kihong Kwon  <kihong.kwon@samsung.com>
318
319         Support for Battery Status API
320         https://bugs.webkit.org/show_bug.cgi?id=62698
321
322         Add include directory and file.
323         http://www.w3.org/TR/battery-status/
324
325         Reviewed by Adam Barth.
326
327         * Scripts/build-webkit:
328
329 2012-03-16  Kishore Bolisetty  <kbolisetty@innominds.com>
330
331         check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
332         https://bugs.webkit.org/show_bug.cgi?id=81007
333
334         Reviewed by Adam Barth.
335
336         A dedidcated build slave is available for efl on build.webkit.org. 
337         This change add's an entry for the elf port in list of available port builders.
338         This is required because test_expectations.py when triggered, looks for a valid port object for the specified port. 
339
340         * Scripts/webkitpy/layout_tests/port/builders.py:
341
342 2012-03-16  Adam Barth  <abarth@webkit.org>
343
344         [webkitpy] StatusServer.next_work_item has an incorrectly named local variable
345         https://bugs.webkit.org/show_bug.cgi?id=81302
346
347         Reviewed by Eric Seidel.
348
349         This is a trivial patch, but the variable name turned up in a grep of
350         webkitpy and looks like copy pasta.
351
352         * Scripts/webkitpy/common/net/statusserver.py:
353         (StatusServer.next_work_item):
354
355 2012-03-16  Andrew Lo  <anlo@rim.com>
356
357         [BlackBerry] Enable PAGE_VISIBILITY_API
358         https://bugs.webkit.org/show_bug.cgi?id=81257
359
360         Enable Page Visibility API for BlackBerry.
361
362         Reviewed by Rob Buis.
363
364         * Scripts/build-webkit:
365
366 2012-03-16  Zan Dobersek  <zandobersek@gmail.com>
367
368         [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
369         https://bugs.webkit.org/show_bug.cgi?id=81232
370
371         Reviewed by Philippe Normand.
372
373         Use the newly-added helper method in DumpRenderTreeSupportGtk.
374
375         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
376         (LayoutTestController::computedStyleIncludingVisitedInfo):
377
378 2012-03-15  Eric Seidel  <eric@webkit.org>
379
380         Move parse_bug_id into config/urls in preparation for re-use elsewhere.
381         https://bugs.webkit.org/show_bug.cgi?id=81313
382
383         Reviewed by Adam Barth.
384
385         * Scripts/webkitpy/common/checkout/changelog.py:
386         (parse_bug_id_from_changelog):
387         * Scripts/webkitpy/common/config/urls.py:
388         (parse_bug_id):
389         * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
390         (URLsTest):
391         (URLsTest.test_parse_bug_id):
392         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
393         (test_parse_bug_id):
394         * Scripts/webkitpy/tool/bot/irc_command.py:
395         (_post_error_and_check_for_bug_url):
396         * Scripts/webkitpy/tool/bot/sheriff.py:
397         (Sheriff.post_rollout_patch):
398         (Sheriff.post_chromium_deps_roll):
399
400 2012-03-15  Adam Barth  <abarth@webkit.org>
401
402         The commit-queue should fast-track patches that have already passed the testing EWS bots
403         https://bugs.webkit.org/show_bug.cgi?id=81305
404
405         Reviewed by Eric Seidel.
406
407         If a patch has already passed the testing EWS bots (currently only the
408         chromium-ews bot), we should be able to land the patch without running
409         the tests again.  This patch is somewhat risky in that the tests might
410         have been broken between when the EWS bots ran and when the
411         commit-queue is processing the patch.  If that turns out to be a
412         problem in practice, we'll tighten up this fast-track in some way,
413         likely by making sure that the pass status is recent.
414
415         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
416         (CommitQueueTaskDelegate.did_pass_testing_ews):
417         (CommitQueueTask._did_pass_tests_recently):
418         (CommitQueueTask.run):
419         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
420         (MockCommitQueue.did_pass_testing_ews):
421         (test_fast_success_case):
422         * Scripts/webkitpy/tool/commands/queues.py:
423         (CommitQueue.did_pass_testing_ews):
424         * Scripts/webkitpy/tool/commands/queues_unittest.py:
425         (test_did_pass_testing_ews):
426
427 2012-03-15  Kentaro Hara  <haraken@chromium.org>
428
429         [PerformanceTests] run-perf-tests should output correct units
430         https://bugs.webkit.org/show_bug.cgi?id=78303
431
432         Reviewed by Ryosuke Niwa.
433
434         Previously run-perf-tests just supported "ms" for units.
435         Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
436         This patch fixes run-perf-tests so that they can support custom units.
437         The default unit is "ms".
438
439         The test result looks like this:
440
441         $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
442         RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
443         median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s
444
445         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
446         (PerfTestsRunner._process_parser_test_result):
447
448 2012-03-15  Brent Fulgham  <bfulgham@webkit.org>
449
450         [WinCairo] Unreviewed build change after wtf path changes.
451
452         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
453         directories to look at the private header directory to find 'wtf'.
454
455 2012-03-15  Kent Tamura  <tkent@chromium.org>
456
457         REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
458         https://bugs.webkit.org/show_bug.cgi?id=81293
459
460         Reviewed by Adam Barth.
461
462         r110595 introduced new format of the author field of ChangeLog entry:
463         "Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>"
464         Updte chanelog.py to support it.
465
466         * Scripts/webkitpy/common/checkout/changelog.py:
467         (ChangeLogEntry._split_contributor_names):
468         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
469         (test_parse_authors):
470
471 2012-03-15  Lynn Neir  <lynn.neir@skype.net>
472
473         Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
474
475         Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
476
477         Reviewed by Jessie Berlin.
478
479         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
480         (LayoutTestController::setValueForUser):
481         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
482         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
483         (WTR::LayoutTestController::setValueForUser):
484         (WTR):
485         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
486         (LayoutTestController):
487
488 2012-03-15  Adam Barth  <abarth@webkit.org>
489
490         Update the start-queue.sh script to match what we're using on the bots
491         https://bugs.webkit.org/show_bug.cgi?id=81277
492
493         Reviewed by Eric Seidel.
494
495         Over time we've added more magic git commands to clean up the local repo after
496         it has been borked in various ways. The idea behind this sequence is to clear
497         out any changes in the working copy and then to rebuild the master branch from
498         origin/master.
499
500         This patch also removes the watchdog timer that we've stopped using on the
501         bots.
502
503         This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
504         Note: Eric and I are experimenting with GitHub to see if it might be
505         useful for WebKit.  If you have thoughts on this topic, please feel
506         free to grab Eric or me on #webkit to chat.  I assume that he and I are
507         the only ones who care about this file so using this alternative
508         process for this patch shouldn't cause any trouble.
509
510         * EWSTools/start-queue.sh:
511
512 2012-03-15  Adam Barth  <abarth@webkit.org>
513
514         The commit-queue can hang when the test_expectations.txt style check fails during commit
515         https://bugs.webkit.org/show_bug.cgi?id=81251
516
517         Reviewed by Eric Seidel.
518
519         We forgot to check the --non-interactive flag, so we end up prompting
520         the "user" who doesn't exist on the bot.  We might consider teaching
521         the User class about non-interactive if we have this sort of bug again.
522
523         * Scripts/webkitpy/tool/steps/commit.py:
524         (Commit.options):
525         (Commit._check_test_expectations):
526         (Commit.run):
527         * Scripts/webkitpy/tool/steps/commit_unittest.py:
528         (CommitTest.test_check_test_expectations):
529
530 2012-03-15  Jessie Berlin  <jberlin@apple.com>
531
532         fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
533         Mac WK2 because WebAudio is not enabled
534         https://bugs.webkit.org/show_bug.cgi?id=81259
535
536         Reviewed by Dan Bernstein.
537
538         Enable WebAudio so that it appears in the window object in the tests.
539         The webaudio tests are all still skipped in the Mac Skipped list.
540
541         * WebKitTestRunner/TestController.cpp:
542         (WTR::TestController::resetStateToConsistentValues):
543
544 2012-03-15  David Levin  <levin@chromium.org>
545
546         Various autoresize fixes.
547         https://bugs.webkit.org/show_bug.cgi?id=81199
548
549         Reviewed by Darin Fisher.
550
551         * DumpRenderTree/chromium/LayoutTestController.cpp:
552         (LayoutTestController::reset): Stop using the deprecated api that was removed.
553
554 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
555
556         [GTK] Actually use --release and --debug command line options in run-gtk-test
557         https://bugs.webkit.org/show_bug.cgi?id=81234
558
559         Reviewed by Philippe Normand.
560
561         Actually handle --release and --debug command line options to
562         create the build directory, falling back to current hack to detect
563         whether it's a Release or Debug build when both options are missed.
564
565         * Scripts/run-gtk-tests:
566         (TestRunner.__init__): Receive options too.
567         (TestRunner._get_top_level_directory): Helper function to get the
568         top level directory.
569         (TestRunner._get_build_directory): Helper function to get the
570         build directory depending on --release/--debug command line
571         options or gessing it if both options are missing.
572         (TestRunner._ensure_accessibility_daemon_is_running): Use
573         self-options now.
574         (TestRunner.run): Ditto.
575         (TestRunner.run.run_tests): Pass options to the constructor
576         instead of run().
577
578 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
579
580         [GTK] Run unit tests with --verbose in the bots
581         https://bugs.webkit.org/show_bug.cgi?id=81230
582
583         Reviewed by Martin Robinson.
584
585         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
586         (RunGtkAPITests): Add --verbose to run-gtk-test command.
587
588 2012-03-15  Kevin Ollivier  <kevino@theolliviers.com>
589
590         Move wx port to using export macros
591         https://bugs.webkit.org/show_bug.cgi?id=77279
592
593         Reviewed by Hajime Morita.
594
595         * waf/build/settings.py:
596         (common_configure):
597
598 2012-03-15  Philippe Normand  <pnormand@igalia.com>
599
600         Unreviewed, GTK build fix attempt after r110845.
601
602         * Scripts/run-gtk-tests: Added --release and --debug options.
603
604 2012-03-15  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
605
606         Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
607         https://bugs.webkit.org/show_bug.cgi?id=79673
608
609         Preparatory work for bringing jhbuild enabled build to EFL port.
610
611         Reviewed by Philippe Normand.
612
613         * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
614         * Scripts/update-webkitgtk-libs:
615         * gtk/run-with-jhbuild:
616         * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
617         (top_level_path):
618         (jhbuild_installed):
619         (jhbuild_cloned):
620         (jhbuild_at_expected_revision):
621         (update_jhbuild):
622         (clone_jhbuild):
623         (install_jhbuild):
624         (update_webkit_libs_jhbuild):
625         (determine_platform):
626         (ensure_jhbuild):
627
628 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
629
630         [GTK] Add command line options to run-gtk-tests script
631         https://bugs.webkit.org/show_bug.cgi?id=81218
632
633         Reviewed by Philippe Normand.
634
635         Following command line options have been added:
636
637         -v, --verbose: to run gtester with --verbose. That would be used
638         by the bots to make it easier to know which test case it failing.
639
640         --display: to use a different display for Xvfb
641
642         It's also possible to pass one or more tests as arguments.
643
644         * Scripts/run-gtk-tests:
645         (TestRunner.__init__): Receive command line arguments.
646         (TestRunner._get_tests): Get all the tests or the ones passed by
647         command line arguments.
648         (TestRunner._ensure_accessibility_daemon_is_running): Use display
649         command line argument.
650         (TestRunner.run): Pas command line options.
651         (TestRunner.run.run_tests): Pass command line arguments.
652
653 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
654
655         [GTK] WebKit2APITests/TestPrinting timeout in the bots
656         https://bugs.webkit.org/show_bug.cgi?id=81211
657
658         Reviewed by Philippe Normand.
659
660         Add gtk+ patch to fix timeout in the bots. A similar patch has
661         already landed in updatream gtk+, see
662         http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f
663
664         * gtk/jhbuild.modules:
665         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
666
667 2012-03-14  Gustavo Noronha Silva  <gns@gnome.org>
668
669         sheriffbot should also be addressable with a comma in addition to colon
670         https://bugs.webkit.org/show_bug.cgi?id=81101
671
672         Reviewed by Adam Barth.
673
674         * Scripts/webkitpy/common/net/irc/ircbot.py:
675         (IRCBot.on_pubmsg):
676
677 2012-03-15  Alexander Færøy  <alexander.faeroy@nokia.com>
678
679         [Qt] MiniBrowser scroll indicators should not scroll out of view
680         https://bugs.webkit.org/show_bug.cgi?id=81131
681
682         Reviewed by Kenneth Rohde Christiansen.
683
684         * MiniBrowser/qt/qml/ScrollIndicator.qml:
685
686 2012-03-14  Chris Fleizach  <cfleizach@apple.com>
687
688         AX: ARIA tables need to support selected rows attribute/select rows changed notification
689         https://bugs.webkit.org/show_bug.cgi?id=79821
690
691         Reviewed by Beth Dakin.
692
693         * DumpRenderTree/AccessibilityUIElement.cpp:
694         (rowAtIndexCallback):
695         (AccessibilityUIElement::getJSClass):
696         * DumpRenderTree/AccessibilityUIElement.h:
697         (AccessibilityUIElement):
698         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
699         (AccessibilityUIElement::rowAtIndex):
700         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
701         (AccessibilityUIElement::rowAtIndex):
702         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
703         (AccessibilityUIElement::rowAtIndex):
704         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
705         (AccessibilityUIElement::rowAtIndex):
706
707 2012-03-14  Tim Horton  <timothy_horton@apple.com>
708
709         NRWT should respect --additional-platform-directory's Skipped list
710         https://bugs.webkit.org/show_bug.cgi?id=81172
711
712         Reviewed by Timothy Hatcher.
713
714         Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
715         from said path are already used, but the Skipped file is ignored.
716
717         * Scripts/webkitpy/layout_tests/port/webkit.py:
718         (WebKitPort._skipped_file_search_paths):
719         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
720         (test_skipped_file_search_paths):
721
722 2012-03-14  Ojan Vafai  <ojan@chromium.org>
723
724         Unreviewed, rolling out r110783.
725         http://trac.webkit.org/changeset/110783
726         https://bugs.webkit.org/show_bug.cgi?id=81054
727
728         Caused existing test expectation lines to expand to one for
729         each test configuration.
730
731         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
732         (TestExpectations.has_warnings):
733         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
734         (test_macro_overrides):
735         * Scripts/webkitpy/tool/commands/rebaseline.py:
736         (RebaselineTest._save_baseline):
737         (RebaselineTest._rebaseline_test):
738         (RebaselineTest.execute):
739         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
740         (TestRebaseline.test_tests_to_update):
741
742 2012-03-13  Jon Lee  <jonlee@apple.com>
743
744         Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
745         https://bugs.webkit.org/show_bug.cgi?id=80922
746         <rdar://problem/11035082>
747
748         Reviewed by Jian Li.
749
750         You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
751         LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
752         new API. Therefore, APIs that are common between the two will have:
753         #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
754
755         This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
756         the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
757
758         Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
759         * DumpRenderTree/chromium/LayoutTestController.cpp:
760         (LayoutTestController::grantDesktopNotificationPermission):
761         (LayoutTestController::simulateDesktopNotificationClick):
762         * DumpRenderTree/chromium/NotificationPresenter.cpp:
763         * DumpRenderTree/chromium/TestShell.cpp:
764         (TestShell::TestShell):
765         (TestShell::resetTestController):
766         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
767         (DRTDesktopNotificationPresenter::checkNotificationPermission):
768
769 2012-03-13  Ojan Vafai  <ojan@chromium.org>
770
771         Have webkit-patch rebaseline-test update test_expectations.txt
772         https://bugs.webkit.org/show_bug.cgi?id=81054
773
774         Reviewed by Dirk Pranke.
775
776         This will allow us to use the All Failures tab in garden-o-matic
777         to rebaseline tests without making test_expectations.txt stale.
778
779         It's conservative and only removes lines if the test is
780         not flaky and fails in a way the rebaseline would fix (e.g.
781         CRASH/TIMEOUT will not be touched).
782
783         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
784         (TestExpectations.remove_configuration_from_test):
785         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
786         (RemoveConfigurationsTest):
787         (RemoveConfigurationsTest.test_remove):
788         (test_remove_line):
789         * Scripts/webkitpy/tool/commands/rebaseline.py:
790         (RebaselineTest._is_supported_port):
791         (RebaselineTest):
792         (RebaselineTest._update_expectations_file):
793         (RebaselineTest._rebaseline_test_and_update_expectations):
794         (RebaselineTest.execute):
795         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
796         (TestRebaseline.test_rebaseline_updates_expectations_file):
797
798 2012-03-14  Jessie Berlin  <jberlin@apple.com>
799
800         Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
801         https://bugs.webkit.org/show_bug.cgi?id=81167
802
803         Reviewed by Sam Weinig.
804
805         Do not use 0 as a key in a HashMap.
806
807         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
808         cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
809
810 2012-03-14  Ojan Vafai  <ojan@chromium.org>
811
812         Add the chromium lion bot to garden-o-matic and remove
813         the platform_move_to in builders.py since the Chromium Lion
814         port is now a normal port.
815
816         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
817         * Scripts/webkitpy/layout_tests/port/builders.py:
818
819 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
820
821         Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
822
823         Unreviewed, build fix.
824
825         * Scripts/webkitpy/layout_tests/port/base.py:
826         (Port.skipped_tests):
827
828 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
829
830         Please add a way to manually skip some tests in NRWT
831         https://bugs.webkit.org/show_bug.cgi?id=81019
832
833         Reviewed by Ojan Vafai.
834
835         This patch implements the -i / --ignore-tests flag from ORWT
836         and refactors the test_expectations.py code slightly to handle
837         it.
838
839         * Scripts/webkitpy/layout_tests/controllers/manager.py:
840         (Manager.parse_expectations):
841         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
842         (TestExpectations.__init__):
843         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
844         (test_add_skipped_tests):
845         (test_add_skipped_tests_duplicate):
846         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
847         (parse_args):
848         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
849         (MainTest.test_ignore_tests):
850         (MainTest.test_ignore_tests.assert_ignored):
851
852 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
853
854         nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
855         https://bugs.webkit.org/show_bug.cgi?id=81028
856
857         Reviewed by Ojan Vafai.
858
859         The mac port had incorrect lookups for 'mac-lion' and
860         'mac-future' in some places. This patch fixes that and adds a
861         bunch of tests.
862
863         * Scripts/webkitpy/layout_tests/port/mac.py:
864         (MacPort.baseline_path):
865         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
866         (MacTest.assert_skipped_file_search_paths):
867         (MacTest.test_skipped_file_search_paths):
868         (_assert_search_path):
869         (test_baseline_search_path):
870         * Scripts/webkitpy/layout_tests/port/webkit.py:
871         (WebKitPort._skipped_file_search_paths):
872
873 2012-03-13  Jer Noble  <jer.noble@apple.com>
874
875         Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
876         https://bugs.webkit.org/show_bug.cgi?id=81056
877
878         Reviewed by Jessie Berlin.
879
880         Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
881
882         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
883         (WTR::InjectedBundlePage::InjectedBundlePage):
884         (WTR::InjectedBundlePage::beganEnterFullScreen):
885         (WTR::InjectedBundlePage::beganExitFullScreen):
886
887 2012-03-14  Alexander Færøy  <alexander.faeroy@nokia.com>
888
889         The width and height of the scroll indicators in the MiniBrowser does
890         not consider the offset margins.
891         https://bugs.webkit.org/show_bug.cgi?id=81112
892
893         Reviewed by Kenneth Rohde Christiansen.
894
895         This patch fixes the issue by withdrawing two times the anchor
896         margins.
897
898         * MiniBrowser/qt/qml/ScrollIndicator.qml:
899
900 2012-03-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
901
902         [EFL] Implement LayoutTestController::clearBackForwardList
903         https://bugs.webkit.org/show_bug.cgi?id=80142
904
905         Adding missing implementation clearBackForwardList to EFL's
906         LayoutTestController. This implementation allows us to unskip 
907         tests connected with history.
908
909         Reviewed by Antonio Gomes.
910
911         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
912         (LayoutTestController::clearBackForwardList): Implemented.
913
914 2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
915
916         [EFL][DRT] Expose window.internals object
917         https://bugs.webkit.org/show_bug.cgi?id=79900
918
919         Exposes window.internals for EFL's DRT. Makes possible to
920         remove some tests from the skip list.
921
922         Reviewed by Antonio Gomes.
923
924         * DumpRenderTree/efl/CMakeLists.txt:
925         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
926         (DumpRenderTreeChrome::onWindowObjectCleared):
927
928 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
929
930         Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
931         https://bugs.webkit.org/show_bug.cgi?id=78853
932
933         Reviewed by Adam Barth.
934
935         * Scripts/build-webkit:
936         * qmake/mkspecs/features/features.prf:
937
938 2012-03-12  Antonio Gomes  <agomes@rim.com>
939
940         Convert nodesFromRect tests to use Internals interface
941         https://bugs.webkit.org/show_bug.cgi?id=80886
942
943         Reviewed by Ryosuke Niwa.
944
945         This clean up allows to remove port specific bits of each
946         DRT implementation that supports testing Document::nodesFromRect,
947         in favor of making use of the 'Internals' interface to test it.
948
949         This makes its code conveniently more expansible and cleaner.
950
951         Also removed stubs from Win and EFL DRTs.
952
953         * DumpRenderTree/LayoutTestController.cpp:
954         (LayoutTestController::staticFunctions):
955         * DumpRenderTree/LayoutTestController.h:
956         (LayoutTestController):
957         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
958         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
959         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
960         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
961         * DumpRenderTree/qt/LayoutTestControllerQt.h:
962         (LayoutTestController):
963         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
964
965 2012-03-13  Ojan Vafai  <ojan@chromium.org>
966
967         Rebaselining for a new port doesn't work right with multiple fallback ports
968         https://bugs.webkit.org/show_bug.cgi?id=80932
969
970         Reviewed by Adam Barth.
971
972         Since chromium-leopard also falls back to mac-leopard, we need to
973         copy the existing result for both chromium-leopard and chromium-snowleopard
974         before doing lion rebaselines.
975
976         * Scripts/webkitpy/layout_tests/port/builders.py:
977         (fallback_port_names_for_new_port):
978         * Scripts/webkitpy/tool/commands/rebaseline.py:
979         (RebaselineTest):
980         (RebaselineTest._copy_existing_baseline):
981         (RebaselineTest._rebaseline_test):
982         (RebaselineTest.execute):
983         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
984         * Scripts/webkitpy/tool/servers/gardeningserver.py:
985         (GardeningHTTPRequestHandler.rebaseline):
986         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
987         (GardeningServerTest.test_rebaseline_new_port):
988
989 2012-03-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
990
991         [Qt] Tweak minibrowser UI
992
993         Add some margins to the scroll indicators, and set a dark background
994         color so you see the page dimensions.
995
996         Reviewed by Antonio Gomes.
997
998         * MiniBrowser/qt/qml/BrowserWindow.qml:
999         * MiniBrowser/qt/qml/ScrollIndicator.qml:
1000
1001 2012-03-13  ChangSeok Oh  <shivamidow@gmail.com>
1002
1003         [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
1004         https://bugs.webkit.org/show_bug.cgi?id=79601
1005
1006         Reviewed by Gustavo Noronha Silva.
1007
1008         Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
1009         createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
1010         and is taken over to sendKeyDown.
1011         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
1012         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
1013
1014         * DumpRenderTree/efl/EventSender.cpp:
1015         (KeyEventInfo::KeyEventInfo):
1016         (KeyEventInfo):
1017         (createKeyEventInfo):
1018         (sendKeyDown):
1019         (keyDownCallback):
1020         (sendAsynchronousKeyDown):
1021         (scheduleAsynchronousKeyDownCallback):
1022
1023 2012-03-12  Ojan Vafai  <ojan@chromium.org>
1024
1025         webkit-patch optimize-baselines sometimes creates a mac-future result
1026         https://bugs.webkit.org/show_bug.cgi?id=80717
1027
1028         Reviewed by Adam Barth.
1029
1030         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1031         (_baseline_search_hypergraph):
1032         (BaselineOptimizer._find_optimal_result_placement):
1033         (BaselineOptimizer._filter_virtual_ports):
1034         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1035         (BaselineOptimizerTest.test_no_add_mac_future):
1036
1037 2012-03-12  Jessie Berlin  <jberlin@apple.com>
1038
1039         More Windows build fixing.
1040
1041         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1042
1043 2012-03-12  Jessie Berlin  <jberlin@apple.com>
1044
1045         More Windows build fixing.
1046
1047         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1048         * DumpRenderTree/win/EditingDelegate.cpp:
1049         * DumpRenderTree/win/EventSender.cpp:
1050         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1051         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1052         * DumpRenderTree/win/UIDelegate.cpp:
1053
1054 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
1055
1056         remove the 'gpu' group from the flakiness dashboard
1057         https://bugs.webkit.org/show_bug.cgi?id=80353
1058
1059         Reviewed by Adam Barth.
1060
1061         Since those bots are obsolete, we don't need this any more.
1062
1063         * TestResultServer/static-dashboards/builders.js:
1064         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1065         (testPlatformAndBuildType):
1066         (testHtmlForTestTypeSwitcherGroup):
1067
1068 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
1069
1070         remove graphics_type from webkitpy.layout_tests.models.test_configuration
1071         https://bugs.webkit.org/show_bug.cgi?id=80643
1072
1073         Reviewed by Ojan Vafai.
1074
1075         Now that the chromium-gpu ports are gone, there's no need for
1076         the graphics_type CPU/GPU distinction. Most of this change is
1077         just updating tests accordingly.
1078
1079         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
1080         (TestExpectationEditorTests):
1081         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1082         (TestConfiguration.__init__):
1083         (TestConfiguration.category_order):
1084         (TestConfiguration.__str__):
1085         (TestConfiguration.__repr__):
1086         (TestConfiguration.__hash__):
1087         (TestConfigurationConverter.to_specifiers_list):
1088         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1089         (make_mock_all_test_configurations_set):
1090         (TestConfigurationTest.test_items):
1091         (TestConfigurationTest.test_keys):
1092         (TestConfigurationTest.test_str):
1093         (TestConfigurationTest.test_repr):
1094         (TestConfigurationTest.test_hash):
1095         (TestConfigurationTest.test_hash.query_unknown_key):
1096         (TestConfigurationTest.test_eq):
1097         (TestConfigurationTest.test_values):
1098         (SpecifierSorterTest.test_specifier_priority):
1099         (SpecifierSorterTest.test_sort_specifiers):
1100         (TestConfigurationConverterTest.test_to_config_set):
1101         (TestConfigurationConverterTest.test_macro_expansion):
1102         (TestConfigurationConverterTest.test_to_specifier_lists):
1103         (TestConfigurationConverterTest.test_converter_macro_collapsing):
1104         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1105         (test_error_on_different_build_type):
1106         (TestExpectationSerializerTests.test_parsed_to_string):
1107         (TestExpectationSerializerTests.test_reconstitute_only_these):
1108         * Scripts/webkitpy/layout_tests/port/apple.py:
1109         (ApplePort._generate_all_test_configurations):
1110         * Scripts/webkitpy/layout_tests/port/base.py:
1111         (Port.__init__):
1112         (Port.name):
1113         (Port.version):
1114         (Port.test_configuration):
1115         * Scripts/webkitpy/layout_tests/port/builders.py:
1116         * Scripts/webkitpy/layout_tests/port/chromium.py:
1117         (ChromiumPort):
1118         (ChromiumPort._generate_all_test_configurations):
1119         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1120         (ChromiumLinuxPort.__init__):
1121         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1122         (ChromiumLinuxPortTest.test_check_illegal_port_names):
1123         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1124         (ChromiumMacPortTest.test_baseline_path):
1125         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1126         (ChromiumPortTest.test_all_test_configurations):
1127         * Scripts/webkitpy/layout_tests/port/efl.py:
1128         (EflPort._generate_all_test_configurations):
1129         * Scripts/webkitpy/layout_tests/port/gtk.py:
1130         (GtkPort._generate_all_test_configurations):
1131         * Scripts/webkitpy/layout_tests/port/qt.py:
1132         (QtPort._generate_all_test_configurations):
1133         * Scripts/webkitpy/layout_tests/port/test.py:
1134         (TestPort.all_test_configurations):
1135         (TestPort._all_build_types):
1136         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1137         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1138         (BuildCoverageExtrapolatorTest.test_extrapolate):
1139         (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
1140         (GardeningExpectationsUpdaterTest.test_add_new_expectation):
1141         (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
1142         (GardeningExpectationsUpdaterTest.test_pass_expectation):
1143         (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
1144         (GardeningExpectationsUpdaterTest.test_spurious_updates):
1145
1146 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
1147
1148         _runtime_feature_list isn't supported on Apple Mac DRT
1149         https://bugs.webkit.org/show_bug.cgi?id=80906
1150
1151         Reviewed by Eric Seidel.
1152
1153         It looks like this feature is actually only supported on the Win
1154         DRT port, so this patch reworks the code to make that clearer
1155         and reduce unnecessary overrides.
1156
1157         * Scripts/webkitpy/layout_tests/port/efl.py:
1158         (EflPort._path_to_webcore_library):
1159         * Scripts/webkitpy/layout_tests/port/gtk.py:
1160         (GtkPort._path_to_webcore_library):
1161         * Scripts/webkitpy/layout_tests/port/qt.py:
1162         (QtPort._skipped_file_search_paths):
1163         * Scripts/webkitpy/layout_tests/port/webkit.py:
1164         (WebKitPort._runtime_feature_list):
1165         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1166         (TestWebKitPort.__init__):
1167         (TestWebKitPort.all_test_configurations):
1168         (test_skipped_directories_for_features):
1169         * Scripts/webkitpy/layout_tests/port/win.py:
1170         (WinPort):
1171         (WinPort._runtime_feature_list):
1172         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1173         (WinPortTest.test_operating_system):
1174         (WinPortTest):
1175         (WinPortTest.test_runtime_feature_list):
1176
1177 2012-03-12  Peter Beverloo  <peter@chromium.org>
1178
1179         [Chromium] Temporary build-fix for the Android bot
1180         https://bugs.webkit.org/show_bug.cgi?id=80862
1181
1182         Reviewed by Adam Barth.
1183
1184         Manually set the environmental variables required to compile source
1185         files through the Android NDK instead of relying on the envsetup.sh
1186         script. A proper fix will be landed to Chromium ASAP, and following
1187         a Chromium roll into WebKit this code will be removed.
1188
1189         * Scripts/webkitdirs.pm:
1190         (buildChromiumMakefile):
1191
1192 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1193
1194         [Qt] Use right construct to detect config_test_gccdepends
1195
1196         Reviewed by Andreas Kling.
1197
1198         * qmake/mkspecs/features/default_pre.prf:
1199
1200 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1201
1202         [Qt] Expose location of WebKit's bin and imports dir through module file
1203
1204         Reviewed by Andreas Kling.
1205
1206         * qmake/qt_webkit.pri:
1207
1208 2012-03-12  Andras Becsi  <andras.becsi@nokia.com>
1209
1210         [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
1211         https://bugs.webkit.org/show_bug.cgi?id=80832
1212
1213         Reviewed by Tor Arne Vestbø.
1214
1215         Add a basic scroll indicator component to MiniBrowser so that it
1216         behaves similar to the ScrollDecorator QML component.
1217
1218         * MiniBrowser/qt/MiniBrowser.qrc:
1219         * MiniBrowser/qt/qml/BrowserWindow.qml:
1220         * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
1221
1222 2012-03-12  C Anthony Risinger  <anthony@xtfx.me>
1223
1224         [GTK] r110296 included an extra $ in @$(AM_V_GEN)
1225         https://bugs.webkit.org/show_bug.cgi?id=80809
1226
1227         Reviewed by Philippe Normand.
1228
1229         * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
1230
1231 2012-03-12  Ming Xie  <mxie@rim.com>
1232
1233         [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
1234         https://bugs.webkit.org/show_bug.cgi?id=80812
1235
1236         Reviewed by Rob Buis.
1237
1238         * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
1239         * Scripts/webkitdirs.pm:
1240         (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
1241
1242
1243 2012-03-12  Simon Hausmann  <simon.hausmann@nokia.com>
1244
1245         [Qt] Fix build with newer Qt 5.
1246
1247         Reviewed by Tor Arne Vestbø.
1248
1249         Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
1250         renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
1251         we should disable -Werror.
1252
1253         Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
1254         implicit load was removed recently.
1255
1256         * qmake/mkspecs/features/default_pre.prf:
1257         * qmake/mkspecs/features/unix/default_post.prf:
1258
1259 2012-03-11  Maciej Stachowiak  <mjs@apple.com>
1260
1261         Add --instruments option to sunspider to profile with Instruments
1262         https://bugs.webkit.org/show_bug.cgi?id=80783
1263
1264         Reviewed by Filip Pizlo.
1265
1266         * Scripts/run-sunspider:
1267
1268 2012-03-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1269
1270         [Qt] [WK2] Support threaded renderer in WK2
1271         https://bugs.webkit.org/show_bug.cgi?id=76661
1272
1273         Remove disabling of threaded rendering.
1274
1275         Reviewed by Noam Rosenthal.
1276
1277         * MiniBrowser/qt/main.cpp:
1278         (main):
1279
1280 2012-03-09  Zan Dobersek  <zandobersek@gmail.com>
1281
1282         [WK2] run-perf-tests should be able to run with WTR
1283         https://bugs.webkit.org/show_bug.cgi?id=80042
1284
1285         Reviewed by Martin Robinson.
1286
1287         Add an option to PerfTestRunner to use WebKitTestRunner instead of
1288         DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
1289         to avoid timing out when running performance tests.
1290
1291         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1292         (PerfTestsRunner._parse_args):
1293         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1294         (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
1295         to true.
1296         (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
1297         as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
1298         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1299         (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
1300         publicly accessible.
1301         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1302         (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
1303         is required.
1304         * WebKitTestRunner/TestController.cpp:
1305         (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
1306         to true.
1307         (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
1308         if '--no-timeout' option is present.
1309         (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
1310         value, or -1.0 if timeout should not occur.
1311         * WebKitTestRunner/TestController.h:
1312         (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
1313         publicly accessible.
1314         * WebKitTestRunner/TestInvocation.cpp:
1315         (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
1316         containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
1317         Waiting for final message should not time out if not necessary.
1318         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1319         (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
1320         * WebKitTestRunner/qt/TestControllerQt.cpp:
1321         (WTR::TestController::platformRunUntil): Ditto.
1322         * WebKitTestRunner/mac/TestControllerMac.mm:
1323         (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
1324         is missing.
1325         * WebKitTestRunner/win/TestControllerWin.cpp:
1326         (WTR::TestController::platformRunUntil): Ditto.
1327
1328 2012-03-09  Jon Lee  <jonlee@apple.com>
1329
1330         Rename NotificationPresenter to NotificationClient
1331         https://bugs.webkit.org/show_bug.cgi?id=80488
1332         <rdar://problem/10965558>
1333
1334         Reviewed by Kentaro Hara.
1335
1336         Refactor to use renamed WebCore::NotificationClient.
1337         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1338         (DRTDesktopNotificationPresenter::checkNotificationPermission):
1339
1340 2012-03-07  James Robinson  <jamesr@chromium.org>
1341
1342         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
1343         https://bugs.webkit.org/show_bug.cgi?id=80523
1344
1345         Reviewed by Darin Fisher.
1346
1347         * DumpRenderTree/chromium/WebViewHost.cpp:
1348         (WebViewHost::createGraphicsContext3D):
1349         * DumpRenderTree/chromium/WebViewHost.h:
1350         (WebViewHost):
1351
1352 2012-03-09  Eric Seidel  <eric@webkit.org>
1353
1354         build-webkit should build Source/WTF on Mac
1355         https://bugs.webkit.org/show_bug.cgi?id=80728
1356
1357         Reviewed by Adam Barth.
1358
1359         We'll add other ports to this list in future commits.
1360
1361         * Scripts/build-webkit:
1362
1363 2012-03-09  Jon Lee  <jonlee@apple.com>
1364
1365         Add support for ENABLE(LEGACY_NOTIFICATIONS)
1366         https://bugs.webkit.org/show_bug.cgi?id=80497
1367
1368         Reviewed by Adam Barth.
1369
1370         Prep for b80472: Update API for Web Notifications
1371         * Scripts/build-webkit:
1372         * qmake/mkspecs/features/features.prf:
1373
1374 2012-03-09  Ashod Nakashian  <ashodnakashian@yahoo.com>
1375
1376         Bash scripts should support LF endings only
1377         https://bugs.webkit.org/show_bug.cgi?id=79509
1378
1379         Reviewed by David Kilzer.
1380
1381         * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
1382         * EWSTools/start-queue.sh: Added property svn:eol-style.
1383         * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
1384         * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
1385         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
1386         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
1387
1388 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
1389
1390         [BUILD] use detected python to run generate-gtkdoc
1391         https://bugs.webkit.org/show_bug.cgi?id=80695
1392
1393         Reviewed by Gustavo Noronha Silva.
1394
1395         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
1396
1397 2012-03-09  Nat Duca  <nduca@chromium.org>
1398
1399         Make check-webkit-style complain about "no new tests" lines in changelogs
1400         https://bugs.webkit.org/show_bug.cgi?id=80582
1401
1402         Reviewed by David Levin.
1403
1404         * Scripts/webkitpy/style/checkers/changelog.py:
1405         (ChangeLogChecker.check_entry):
1406         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1407         (ChangeLogCheckerTest.test_no_new_tests):
1408
1409 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1410
1411         Unreviewed, rolling out r110250.
1412         http://trac.webkit.org/changeset/110250
1413         https://bugs.webkit.org/show_bug.cgi?id=80682
1414
1415         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
1416         qt-linux at all. (Requested by Ossy on #webkit).
1417
1418         * Scripts/old-run-webkit-tests:
1419         * Scripts/webkitpy/layout_tests/port/qt.py:
1420         (QtPort):
1421         (QtPort.determine_full_port_name):
1422         (QtPort.baseline_search_path):
1423         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1424         (QtPortTest):
1425         (QtPortTest._assert_search_path):
1426         (QtPortTest.test_baseline_search_path):
1427
1428 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1429
1430         [Qt] Use Qt's module system for install rules and depending on QtWebKit
1431
1432         Instead of rolling our own install rules we now use the same approach as
1433         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
1434
1435         This ensures that we follow the same semantics as the rest of Qt on
1436         what sort of config options are enabled by default (create_cmake eg.).
1437         It also allows us to use QT += webkit instead of the workaround we had
1438         with CONFIG += qtwebkit.
1439
1440         We do however force Qt to always treat our build as a non-developer build,
1441         so the libraries will end up in the WebKit lib directory instead of the
1442         qtbase directory (as with a normal developer-build). This allows us to
1443         keep the webkit-build self-contained. If Qt is a developer build we still
1444         copy the module file manually to Qt, so that you don't have to install
1445         WebKit to make it available.
1446
1447         For non-developer builds of Qt, it is still possible to use the built
1448         WebKit libraries without having to install them, by having the variable
1449         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
1450         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
1451
1452         https://bugs.webkit.org/show_bug.cgi?id=80590
1453
1454         Reviewed by Simon Hausmann.
1455
1456         * DumpRenderTree/qt/DumpRenderTree.pro:
1457         * MiniBrowser/qt/BrowserWindow.cpp:
1458         * MiniBrowser/qt/MiniBrowser.pro:
1459         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1460         * MiniBrowser/qt/UrlLoader.cpp:
1461         * QtTestBrowser/QtTestBrowser.pro:
1462         * Tools.pro:
1463         * WebKitTestRunner/InjectedBundle/Target.pri:
1464         * WebKitTestRunner/Target.pri:
1465         * qmake/mkspecs/features/default_post.prf:
1466         * qmake/mkspecs/features/default_pre.prf:
1467         * qmake/mkspecs/features/functions.prf:
1468         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
1469         * qmake/mkspecs/features/qtwebkit.prf:
1470         * qmake/mkspecs/features/rpath.prf:
1471         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
1472         * qmake/qt_webkit.pri: Added.
1473
1474 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
1475
1476         Unreviewed. Update my email.
1477
1478         * Scripts/webkitpy/common/config/committers.py:
1479
1480 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
1481
1482         Recent changes to chromium.py etc. broke chromium_android.py
1483         https://bugs.webkit.org/show_bug.cgi?id=80623
1484
1485         Reviewed by Dirk Pranke.
1486
1487         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1488         (ChromiumAndroidDriver.__init__):
1489         (ChromiumAndroidDriver._start):
1490
1491 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
1492
1493         [Chromium] Exception running reftest with --no-pixel-tests
1494         https://bugs.webkit.org/show_bug.cgi?id=80642
1495
1496         Reviewed by Dirk Pranke.
1497
1498         * Scripts/webkitpy/layout_tests/port/chromium.py:
1499         (ChromiumDriver.__init__):
1500         (ChromiumDriver._wrapper_options):
1501
1502 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
1503
1504         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
1505         https://bugs.webkit.org/show_bug.cgi?id=72489
1506
1507         Reviewed by Dirk Pranke.
1508
1509         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
1510         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
1511         --platform will override the platform name and then we'll use it.
1512
1513         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
1514         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
1515         override it in the end.
1516
1517         * Scripts/old-run-webkit-tests:
1518         * Scripts/webkitpy/layout_tests/port/qt.py:
1519         (QtPort):
1520         (QtPort.determine_full_port_name):
1521         (QtPort.baseline_search_path):
1522         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1523         (QtPortTest):
1524         (QtPortTest._assert_search_path):
1525         (QtPortTest.test_baseline_search_path):
1526
1527 2012-03-08  Beth Dakin  <bdakin@apple.com>
1528
1529         https://bugs.webkit.org/show_bug.cgi?id=80463
1530         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
1531         -and corresponding-
1532         <rdar://problem/10970221>
1533
1534         Reviewed by Dan Bernstein.
1535
1536         New test!
1537         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1538         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
1539         (TestWebKitAPI):
1540         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
1541         (TestWebKitAPI::setPageLoaderClient):
1542         (TestWebKitAPI::TEST):
1543         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
1544         (TestWebKitAPI):
1545         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
1546         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
1547         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
1548         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
1549
1550 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1551
1552         [Qt] Prospective Windows build fix
1553
1554         Don't assume that windows-builds will always run inside a cmd.exe shell.
1555
1556         * qmake/mkspecs/features/default_pre.prf:
1557
1558 2012-03-08  Dan Bernstein  <mitz@apple.com>
1559
1560         <rdar://problem/10981173> Dashboard regions should not be in device space
1561
1562         Reviewed by John Sullivan.
1563
1564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1565         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
1566         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
1567         (TestWebKitAPI):
1568         (TestWebKitAPI::TEST):
1569
1570 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
1571
1572         webkit-patch works oddly on local Git branches
1573         https://bugs.webkit.org/show_bug.cgi?id=76958
1574
1575         Reviewed by Ojan Vafai.
1576
1577         This change makes the '-g' flag to webkit-patch behave a
1578         little more consistently with git. The 'HEAD..' syntax
1579         is changed to 'HEAD....' (four dots), so as to not
1580         collide with the underlying git syntax. We also generalize
1581         the syntax to support any refname, so 'foo....' means
1582         diff against foo and include working copy changes.
1583
1584         This change also adds the 'UPSTREAM' shortcut to identify
1585         whatever the current upstream/tracking branch is; this is
1586         useful if you have multiple local branches stacked up.
1587
1588         * Scripts/webkitpy/common/checkout/scm/git.py:
1589         (Git._branch_from_ref):
1590         (Git):
1591         (Git._current_branch):
1592         (Git._upstream_branch):
1593         (Git.merge_base):
1594         (Git._commit_on_branch):
1595         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1596         (GitSVNTest._second_local_commit):
1597         (GitSVNTest._two_local_commits):
1598         (GitSVNTest.test_commit_with_message_git_commit_range):
1599         (GitSVNTest.test_upstream_branch):
1600         (GitSVNTest.test_create_patch_working_copy_only):
1601         (GitSVNTest.test_changed_files_local_plus_working_copy):
1602         (GitSVNTest.test_changed_files_working_copy_only):
1603         (GitSVNTest.test_changed_files_upstream):
1604         * Scripts/webkitpy/tool/steps/options.py:
1605         (Options):
1606
1607 2012-03-08  John Sullivan  <sullivan@apple.com>
1608
1609         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
1610
1611         Reviewed by Eric Carlson.
1612
1613         * Scripts/extract-localizable-strings:
1614         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
1615         with NSLocalized. Also improved an error message to include the troublesome token.
1616
1617 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1618
1619         Unreviewed, rolling out r110115.
1620         http://trac.webkit.org/changeset/110115
1621         https://bugs.webkit.org/show_bug.cgi?id=80581
1622
1623         broke test-webkitpy (Requested by philn-tp on #webkit).
1624
1625         * Scripts/old-run-webkit-tests:
1626         * Scripts/webkitpy/layout_tests/port/qt.py:
1627         (QtPort):
1628         (QtPort.determine_full_port_name):
1629         (QtPort.baseline_search_path):
1630
1631 2012-03-08  Kentaro Hara  <haraken@chromium.org>
1632
1633         Unreviewed. Added myself to watchlist.
1634
1635         * Scripts/webkitpy/common/config/watchlist:
1636
1637 2012-03-07  Jessie Berlin  <jberlin@apple.com>
1638
1639         Clean Windows build fails after r110033
1640         https://bugs.webkit.org/show_bug.cgi?id=80553
1641
1642         Rubber-stamped by Jon Honeycutt and Eric Seidel.
1643
1644         Add the new JavaScriptCore include directory to some more vsprops files.
1645
1646         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1647         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1648         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1649
1650 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
1651
1652         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
1653         https://bugs.webkit.org/show_bug.cgi?id=72489
1654
1655         Reviewed by Dirk Pranke.
1656
1657         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
1658         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
1659         --platform will override the platform name and then we'll use it.
1660
1661         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
1662         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
1663         override it in the end.
1664
1665         * Scripts/old-run-webkit-tests:
1666         * Scripts/webkitpy/layout_tests/port/qt.py:
1667         (QtPort):
1668         (QtPort.determine_full_port_name):
1669         (QtPort.baseline_search_path):
1670
1671 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
1672
1673         [Qt][WK2] MiniBrowser on desktop does not react to click events
1674         https://bugs.webkit.org/show_bug.cgi?id=80314
1675
1676         Reviewed by Kenneth Rohde Christiansen.
1677
1678         Do not enable touch mocking on desktop mode.
1679
1680         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1681         (MiniBrowserApplication::handleUserOptions):
1682
1683 2012-03-07  Ojan Vafai  <ojan@chromium.org>
1684
1685         Automatically move to the next test after rebaseline in the results view
1686         https://bugs.webkit.org/show_bug.cgi?id=80527
1687
1688         Reviewed by Dimitri Glazkov.
1689
1690         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1691         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1692
1693 2012-03-07  Ojan Vafai  <ojan@chromium.org>
1694
1695         garden-o-matic rebaseline is broken for ports that don't have a fallback port
1696         https://bugs.webkit.org/show_bug.cgi?id=80526
1697
1698         Reviewed by Adam Barth.
1699
1700         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
1701         since there is no "None" port.
1702
1703         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1704         (GardeningHTTPRequestHandler.rebaseline):
1705         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1706         (GardeningServerTest.test_rebaseline):
1707
1708 2012-03-07  James Robinson  <jamesr@chromium.org>
1709
1710         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
1711         https://bugs.webkit.org/show_bug.cgi?id=80521
1712
1713         Reviewed by Kenneth Russell.
1714
1715         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
1716         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
1717         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
1718
1719         Covered by platform/chromium/compositing/plugins/*
1720
1721         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1722         (TestWebPlugin::TestWebPlugin):
1723         (TestWebPlugin::initialize):
1724         (TestWebPlugin::updateGeometry):
1725         (TestWebPlugin::initScene):
1726         (TestWebPlugin::destroyScene):
1727         * DumpRenderTree/chromium/TestWebPlugin.h:
1728         (TestWebPlugin):
1729         * DumpRenderTree/chromium/WebViewHost.cpp:
1730         (WebViewHost::createPlugin):
1731
1732 2012-03-07  Philippe Normand  <pnormand@igalia.com>
1733
1734         [GTK] remove webkitpy dependency in run-gtk-tests
1735         https://bugs.webkit.org/show_bug.cgi?id=80500
1736
1737         Reviewed by Martin Robinson.
1738
1739         Replace Executive calls with bare subprocess calls.
1740
1741         * Scripts/run-gtk-tests:
1742         (TestRunner):
1743         (TestRunner._lookup_atspi2_binary):
1744         (TestRunner.run):
1745         (TestRunner.run.run_for_real):
1746
1747 2012-03-07  Philippe Normand  <pnormand@igalia.com>
1748
1749         Unreviewed, GTK build fix after r110059.
1750
1751         * Scripts/run-gtk-tests:
1752         (TestRunner._check_if_tests_have_timed_out):
1753         (TestRunner.run.run_tests):
1754         (TestRunner):
1755
1756 2012-03-07  Philippe Normand  <pnormand@igalia.com>
1757
1758         [GTK] race condition in run-gtk-tests
1759         https://bugs.webkit.org/show_bug.cgi?id=80495
1760
1761         Reviewed by Martin Robinson.
1762
1763         Refactored the script to wait the a11y dbus service becomes
1764         available before starting the tests.
1765
1766         * Scripts/run-gtk-tests:
1767         (TestRunner._lookup_atspi2_binary):
1768         (TestRunner):
1769         (TestRunner._wait_dbus_service_and_run):
1770         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
1771         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
1772         (TestRunner.run):
1773         (TestRunner.run.bailout):
1774         (TestRunner.run.run_for_real):
1775
1776 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
1777
1778         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
1779         https://bugs.webkit.org/show_bug.cgi?id=80425
1780
1781         Reviewed by Simon Hausmann.
1782
1783         Set startScreenPos in mock touch point
1784
1785         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1786         (MiniBrowserApplication::notify):
1787         * MiniBrowser/qt/MiniBrowserApplication.h:
1788         (MiniBrowserApplication):
1789
1790 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
1791
1792         [Qt] Windows build fix.
1793
1794         Reviewed by Tor Arne Vestbø.
1795
1796         Pass the -j parameter only to "make", not "nmake".
1797
1798         * Scripts/webkitdirs.pm:
1799         (buildQMakeProjects):
1800
1801 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
1802
1803         [Qt] Fix compilation without QtQuick1
1804         https://bugs.webkit.org/show_bug.cgi?id=80503
1805
1806         Reviewed by Tor Arne Vestbø.
1807
1808         Introduce HAVE_QQUICK1 as feature and added haveQtModule
1809         as convenience function.
1810
1811         * qmake/mkspecs/features/features.prf:
1812         * qmake/mkspecs/features/functions.prf:
1813
1814 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
1815
1816         [Qt] Add qmake config tests for JPEG and PNG library
1817         https://bugs.webkit.org/show_bug.cgi?id=80398
1818
1819         Add JPEG and PNG library tests to config.tests and
1820         add error() abort to WebCore.pri if tests don't work.
1821
1822         Reviewed by Tor Arne Vestbø.
1823
1824         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
1825         (main):
1826         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
1827         * qmake/config.tests/libpng/libpng.cpp: Added.
1828         (main):
1829         * qmake/config.tests/libpng/libpng.pro: Added.
1830         * qmake/sync.profile:
1831
1832 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
1833
1834         [EFL] Build warning: Fix warn_unused_result warnings.
1835         https://bugs.webkit.org/show_bug.cgi?id=79194
1836
1837         Reviewed by Filip Pizlo.
1838
1839         Fixed build warning which is getting generated when not using return
1840         value of a fuction, especially declared with warn_unused_result
1841         attribute.
1842
1843         * DumpRenderTree/efl/ImageDiff.cpp:
1844         (printImage):
1845
1846 2012-03-07  Kangil Han  <kangil.han@samsung.com>
1847
1848         [DRT] Remove PlainTextController implementations.
1849         https://bugs.webkit.org/show_bug.cgi?id=79959
1850
1851         Reviewed by Hajime Morita.
1852
1853         PlainTextController usages in existing tests have been
1854         replaced by internals API by bug 78570.
1855         So this patch will remove PlainTextController implementations
1856         to avoid further usage in new tests.
1857
1858         * DumpRenderTree/DumpRenderTree.gypi:
1859         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1860         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
1861         * DumpRenderTree/chromium/PlainTextController.h: Removed.
1862         * DumpRenderTree/chromium/TestShell.cpp:
1863         (TestShell::TestShell):
1864         (TestShell::bindJSObjectsToWindow):
1865         * DumpRenderTree/chromium/TestShell.h:
1866         (TestShell):
1867         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1868         (webViewWindowObjectCleared):
1869         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
1870         * DumpRenderTree/gtk/PlainTextController.h: Removed.
1871         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1872         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1873         * DumpRenderTree/mac/PlainTextController.h: Removed.
1874         * DumpRenderTree/mac/PlainTextController.mm: Removed.
1875         * DumpRenderTree/qt/DumpRenderTree.pro:
1876         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1877         (WebCore::DumpRenderTree::DumpRenderTree):
1878         (WebCore::DumpRenderTree::initJSObjects):
1879         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1880         (DumpRenderTree):
1881         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
1882         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
1883         * GNUmakefile.am:
1884
1885 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1886
1887         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
1888         https://bugs.webkit.org/show_bug.cgi?id=80137
1889
1890         Reviewed by Eric Seidel.
1891
1892         Adds implementation LayoutTestController's setPopupBlockingEnabled.
1893         To pass popup-blocking-click-in-iframe.html EventSender should not
1894         repeat click events in idler's function. EventSender allows to
1895         asynchronously send click event through ecore_idler_add.
1896         This event will be called repeatedly as long as it return true.
1897         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
1898
1899         * DumpRenderTree/efl/EventSender.cpp:
1900         (sendMouseEvent): Changed return value from bool to void because it always returns true.
1901         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
1902         (mouseDownCallback): Remove unnecessary checking of return value.
1903         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1904         (LayoutTestController::setPopupBlockingEnabled):
1905
1906 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
1907
1908         rebaseline_chromium_webkit_tests is obsolete and should be removed
1909         https://bugs.webkit.org/show_bug.cgi?id=80347
1910
1911         Reviewed by Tony Chang.
1912
1913         * Scripts/rebaseline-chromium-webkit-tests: Removed.
1914         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
1915         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
1916
1917 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
1918
1919         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
1920         https://bugs.webkit.org/show_bug.cgi?id=80468
1921
1922         Unreviewed, build fix.
1923
1924         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
1925
1926         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1927         (Lighttpd._prepare_config):
1928
1929 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
1930
1931         remove chromium_gpu ports
1932         https://bugs.webkit.org/show_bug.cgi?id=80345
1933
1934         Reviewed by Ojan Vafai.
1935
1936         This change leaves in the 'graphics_type' distinction in the
1937         test_expectations; removing that will require more updates and a
1938         pass over test_expectations.txt, so I'm separating that out.
1939
1940         * Scripts/webkitpy/layout_tests/port/builders.py:
1941         * Scripts/webkitpy/layout_tests/port/chromium.py:
1942         (ChromiumPort):
1943         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
1944         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
1945         * Scripts/webkitpy/layout_tests/port/factory.py:
1946         (PortFactory):
1947         (PortFactory.get):
1948         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1949         (FactoryTest.test_qt):
1950         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1951         (TestRebaseline.test_rebaseline_expectations):
1952
1953 2012-03-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
1954
1955         undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
1956         https://bugs.webkit.org/show_bug.cgi?id=80282
1957
1958         Reviewed by Antonio Gomes.
1959
1960         Remove transitive library dependencies; they are especially
1961         dangerous when one ends up linking against WTF, JSC and then WTF
1962         again, since some symbols will not be defined.
1963
1964         Passing --no-copy-dt-needed-entries and --as-needed to the linker
1965         (which some recent Linux distros do by default) makes the issue
1966         even more evident.
1967
1968         * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
1969         as the other libraries have the needed symbols. Explicitly link
1970         against fontconfig.
1971
1972 2012-03-06  Dean Jackson  <dino@apple.com>
1973
1974         filter-build-webkit needs more filters
1975         https://bugs.webkit.org/show_bug.cgi?id=80440
1976
1977         Reviewed by Joseph Pecoraro.
1978
1979         Added as many missing filters as I could find for Apple
1980         builds. Plus a few minor style updates.
1981
1982         * Scripts/filter-build-webkit:
1983         (printLine):
1984
1985 2012-03-06  Ojan Vafai  <ojan@chromium.org>
1986
1987         Copying old baselines throws an error if the new directory doesn't exist
1988         https://bugs.webkit.org/show_bug.cgi?id=80443
1989
1990         Reviewed by Adam Barth.
1991
1992         Existing tests cover the new code with the fix to filesystem_mock.
1993
1994         * Scripts/webkitpy/common/system/filesystem_mock.py:
1995         (MockFileSystem.copyfile):
1996         Fix the mock to better match python's copyfile semantics.
1997
1998         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1999         (Rebaseliner._create_html_baseline_files):
2000         * Scripts/webkitpy/tool/commands/rebaseline.py:
2001         (RebaselineTest._copy_existing_baseline):
2002
2003 2012-03-05  Ojan Vafai  <ojan@chromium.org>
2004
2005         Add a mechanism to rebaseline new ports
2006         https://bugs.webkit.org/show_bug.cgi?id=80355
2007
2008         Reviewed by Adam Barth.
2009
2010         For a test that's only failing on a new port, we want
2011         to first copy the existing result into the location for the
2012         port it's replacing in order to not break that port.
2013
2014         For example, bringing up the chromium-lion port, if we just
2015         stick the results in the chromium-mac directory, the snow leopard
2016         will start failing. Instead, we first copy the existing result
2017         to the chromium-mac-snowleopard directory.
2018
2019         * Scripts/webkitpy/layout_tests/port/builders.py:
2020         (builder_path_for_port_name):
2021         (fallback_port_name_for_new_port):
2022         * Scripts/webkitpy/tool/commands/rebaseline.py:
2023         (RebaselineTest):
2024         (RebaselineTest._copy_existing_baseline):
2025         (RebaselineTest._rebaseline_test):
2026         (RebaselineTest.execute):
2027         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2028         (TestRebaseline.test_rebaseline_test):
2029         (TestRebaseline):
2030         (TestRebaseline.test_rebaseline_and_copy_test):
2031         (test_rebaseline_and_copy_test_no_existing_result):
2032         (test_rebaseline_and_copy_test_with_lion_result):
2033         (test_rebaseline_and_copy_no_overwrite_test):
2034         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2035         (GardeningHTTPRequestHandler.rebaseline):
2036         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2037         (GardeningServerTest.test_rebaseline):
2038         (GardeningServerTest):
2039         (GardeningServerTest.test_rebaseline_new_port):
2040
2041 2012-03-06  Beth Dakin  <bdakin@apple.com>
2042
2043         https://bugs.webkit.org/show_bug.cgi?id=80351
2044         InlineTextBox is using the wrong origin when calling 
2045         addRelevantRepaintedObject
2046         -and corresponding-
2047         <rdar://problem/10970221>
2048
2049         Reviewed by Sam Weinig.
2050
2051         This test has actually been broken since revision 109273. This change makes 
2052         the test pass again, and it makes it specifically exercise the fix for this 
2053         bug.
2054         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2055         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2056         (TestWebKitAPI::TEST):
2057
2058         Adjust comments in the other tests to reflect the API changes from 109273.
2059         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2060         (TestWebKitAPI::TEST):
2061         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
2062         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
2063         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
2064         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
2065         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
2066         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
2067         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
2068
2069 2012-03-06  Hans Wennborg  <hans@chromium.org>
2070
2071         Speech JavaScript API: add SpeechRecognitionError
2072         https://bugs.webkit.org/show_bug.cgi?id=80410
2073
2074         Chromium: enable the runtime flag for scripted speech so we can run
2075         the layout tests for it.
2076
2077         Reviewed by Adam Barth.
2078
2079         * DumpRenderTree/chromium/TestShell.cpp:
2080         (TestShell::TestShell):
2081
2082 2012-03-06  Sami Kyostila  <skyostil@chromium.org>
2083
2084         Enable universal newlines in chromium android layout test runner
2085         https://bugs.webkit.org/show_bug.cgi?id=80418
2086
2087         Reviewed by Adam Barth.
2088
2089         The Chromium Android layout test runner uses the 'adb' program to
2090         communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
2091         output lines from the test runner, while the test expectation files are
2092         written with LF ('\n') delimiters. This causes the results to have
2093         spurious whitespace differences, making them more difficult to
2094         interpret.
2095
2096         The fix is to enable universal newlines for the DumpRenderTree pipe,
2097         causing the output to only contain LF newlines like on other platforms.
2098
2099         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2100         (ChromiumAndroidDriver._start):
2101
2102 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2103
2104         [Qt] Revert r109900, it was completly busted
2105
2106         HAVE_FOO does _not_ have a WTF_ prefix, go figure.
2107
2108         We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
2109         of manual define checks.
2110
2111         Reviewed by Ossy.
2112
2113         * DumpRenderTree/qt/DumpRenderTree.pro:
2114         * QtTestBrowser/QtTestBrowser.pro:
2115         * WebKitTestRunner/InjectedBundle/Target.pri:
2116         * qmake/mkspecs/features/features.prf:
2117
2118 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2119
2120         [Qt] Use config test to determine if the compiler supports -MD
2121
2122         We used to assume that unix systems building against Qt5 would have
2123         a compiler that supported -MD. Although this was usually the case,
2124         we failed to take into account broken tools for distributed builds
2125         (e.g. teambuilder or icecream) which would end up producing .d files
2126         in the root of the build dir instead of along-side the object file.
2127
2128         Now that we use a config-test to determine the support, we'll capture
2129         those cases, unless distributed builds are enabled after the initial
2130         build-webkit run.
2131
2132         Reviewed by Csaba Osztrogonác.
2133
2134         * Tools.pro:
2135         * qmake/config.tests/gccdepends/empty.cpp: Added.
2136         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
2137         * qmake/mkspecs/features/default_pre.prf:
2138         * qmake/mkspecs/features/features.prf:
2139         * qmake/mkspecs/features/unix/default_pre.prf:
2140         * qmake/sync.profile:
2141
2142 2012-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2143
2144         REGRESSION(r109294): It broke the unittest of master.cfg
2145         https://bugs.webkit.org/show_bug.cgi?id=80253
2146
2147         Reviewed by Tor Arne Vestbø.
2148
2149         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
2150         (BuildBotConfigLoader._create_mock_passwords_dict):
2151         (BuildBotConfigLoader._mock_open):
2152         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
2153         (BuildBotConfigLoader.load_config):
2154
2155 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2156
2157         Qt API test buildstep throws exception after buildmaster update
2158         https://bugs.webkit.org/show_bug.cgi?id=80249
2159
2160         This patch based on Peter Gal's work.
2161
2162         Reviewed by Csaba Osztrogonác.
2163
2164         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2165         (RunQtAPITests):
2166         (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
2167
2168 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2169
2170         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
2171
2172         Reviewed by Simon Hausmann.
2173         Reviewed by Ossy.
2174
2175         * DumpRenderTree/qt/DumpRenderTree.pro:
2176         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
2177         (WebKit::initializeTestFonts):
2178         * QtTestBrowser/QtTestBrowser.pro:
2179         * WebKitTestRunner/InjectedBundle/Target.pri:
2180         * qmake/mkspecs/features/features.prf:
2181
2182 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2183
2184         [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
2185
2186         Reviewed by Ossy.
2187
2188         * qmake/mkspecs/features/default_post.prf:
2189
2190 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2191
2192         [Qt] Make sure clean builds are followed by make qmake && make if needed
2193
2194         On non-GNUmake systems we have to run make qmake so that the generated
2195         sources are generated before we run qmake on the target pro files. This
2196         is achieved by using the 'incremental' target.
2197
2198         Reviewed by Ossy.
2199
2200         * Scripts/webkitdirs.pm:
2201         (buildQMakeProjects):
2202
2203 2012-03-06  Filip Pizlo  <fpizlo@apple.com>
2204
2205         DumpRenderTree should support preciseTime()
2206         https://bugs.webkit.org/show_bug.cgi?id=80397
2207
2208         Reviewed by Gavin Barraclough.
2209
2210         * DumpRenderTree/LayoutTestController.cpp:
2211         (preciseTimeCallback):
2212         (LayoutTestController::staticFunctions):
2213
2214 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
2215
2216         Unreviewed, rolling out r109887.
2217         http://trac.webkit.org/changeset/109887
2218         https://bugs.webkit.org/show_bug.cgi?id=80402
2219
2220         It broke the build (Requested by Ossy on #webkit).
2221
2222         * DumpRenderTree/qt/DumpRenderTree.pro:
2223         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
2224         (WebKit::initializeTestFonts):
2225         * QtTestBrowser/QtTestBrowser.pro:
2226         * WebKitTestRunner/InjectedBundle/Target.pri:
2227         * qmake/mkspecs/features/features.prf:
2228
2229 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
2230
2231         Unreviewed, rolling out r109837.
2232         http://trac.webkit.org/changeset/109837
2233         https://bugs.webkit.org/show_bug.cgi?id=80399
2234
2235         breaks Mac Productions builds, too late to try and fix it
2236         tonight (Requested by eseidel on #webkit).
2237
2238         * Scripts/build-webkit:
2239
2240 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2241
2242         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
2243
2244         Reviewed by Simon Hausmann.
2245
2246         * DumpRenderTree/qt/DumpRenderTree.pro:
2247         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
2248         (WebKit::initializeTestFonts):
2249         * QtTestBrowser/QtTestBrowser.pro:
2250         * WebKitTestRunner/InjectedBundle/Target.pri:
2251         * qmake/mkspecs/features/features.prf:
2252
2253 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2254
2255         [Qt] Create EWS to build WebKit2
2256         https://bugs.webkit.org/show_bug.cgi?id=80277
2257
2258         Reviewed by Csaba Osztrogonác.
2259
2260         * QueueStatusServer/model/queues.py:
2261         (Queue):
2262         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2263         (QtWK2EWS):
2264         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2265         (EarlyWarningSytemTest.test_builder_ewses):
2266
2267 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2268
2269         Unreviewed, rolling out r109733.
2270         http://trac.webkit.org/changeset/109733
2271         https://bugs.webkit.org/show_bug.cgi?id=80378
2272
2273         It broke Qt5 build system (Requested by Ossy on #webkit).
2274
2275         * Tools.pro:
2276         * qmake/config.tests/gccdepends/empty.cpp: Removed.
2277         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
2278         * qmake/mkspecs/features/default_pre.prf:
2279         * qmake/mkspecs/features/features.prf:
2280         * qmake/mkspecs/features/unix/default_pre.prf:
2281         * qmake/sync.profile:
2282
2283 2012-03-05  Eric Seidel  <eric@webkit.org>
2284
2285         Update JavaScriptCore files to use fully-qualified WTF include path
2286         https://bugs.webkit.org/show_bug.cgi?id=79960
2287
2288         Reviewed by Adam Barth.
2289
2290         Build WTF/WTF.xcodeproj by default on Mac.
2291
2292         * Scripts/build-webkit:
2293
2294 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
2295
2296         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
2297         https://bugs.webkit.org/show_bug.cgi?id=69590
2298
2299         Reviewed by Ryosuke Niwa.
2300
2301         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
2302         to skip the 'optimize-expectations' step.
2303
2304         * Scripts/webkitpy/tool/commands/rebaseline.py:
2305         (RebaselineExpectations.__init__):
2306         (RebaselineExpectations.execute):
2307         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2308
2309 2012-03-05  Kent Tamura  <tkent@chromium.org>
2310
2311         [Chromium] Add new popup type: PagePopup
2312         https://bugs.webkit.org/show_bug.cgi?id=80106
2313
2314         Reviewed by Darin Fisher.
2315
2316         * DumpRenderTree/chromium/WebViewHost.cpp:
2317         (WebViewHost::createPopupMenu):
2318
2319 2012-03-05  Jessie Berlin  <jberlin@apple.com>
2320
2321         Add myself as a reviewer.
2322
2323         * Scripts/webkitpy/common/config/committers.py:
2324         Also, add my IRC nick so it is easier to find and yell at me.
2325
2326 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
2327
2328         Correctly compute the positions of GestureScroll* events on
2329         Chromium.
2330         https://bugs.webkit.org/show_bug.cgi?id=80075
2331
2332         Reviewed by Adam Barth.
2333
2334         * DumpRenderTree/chromium/EventSender.cpp:
2335         (EventSender::reset):
2336         (EventSender::gestureEvent):
2337         * DumpRenderTree/chromium/EventSender.h:
2338         (EventSender):
2339
2340 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
2341
2342         flakiness dashboard doesn't display baselines for virtual tests correctly
2343         https://bugs.webkit.org/show_bug.cgi?id=80341
2344
2345         Reviewed by Ojan Vafai.
2346
2347         If the test is part of a virtual test suite, we need to look for
2348         baselines in the underlying fallback path for the actual test
2349         being run, as well as baselines for the virtual version.
2350
2351         This patch adds code to handle both branches and also pulls the
2352         mapping of the test suites up into a constant.
2353
2354         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2355         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2356         (testLookupVirtualTestSuite):
2357         (testBaseTest):
2358
2359 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2360
2361         Unreviewed, rolling out r109760.
2362         http://trac.webkit.org/changeset/109760
2363         https://bugs.webkit.org/show_bug.cgi?id=80320
2364
2365         Caused many GTK+ tests to crash (Requested by mrobinson on
2366         #webkit).
2367
2368         * gtk/jhbuild.modules:
2369
2370 2012-03-05  Charlie Reis  <creis@chromium.org>
2371
2372         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
2373         https://bugs.webkit.org/show_bug.cgi?id=80057
2374
2375         Reviewed by Darin Fisher.
2376
2377         * DumpRenderTree/chromium/WebViewHost.cpp:
2378         (WebViewHost::createView):
2379         * DumpRenderTree/chromium/WebViewHost.h:
2380         (WebViewHost):
2381
2382 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
2383
2384         [soup] Crash while loading http://www.jusco.cn
2385         https://bugs.webkit.org/show_bug.cgi?id=68238
2386
2387         Reviewed by Philippe Normand.
2388
2389         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
2390         in the jhbuild file.
2391
2392 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2393
2394         Unreviewed, rolling out r109748.
2395         http://trac.webkit.org/changeset/109748
2396         https://bugs.webkit.org/show_bug.cgi?id=80296
2397
2398         Made some tests crash, will fix and recommit (Requested by
2399         noamr on #webkit).
2400
2401         * MiniBrowser/qt/main.cpp:
2402         (main):
2403
2404 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
2405
2406         [GTK] plugins/netscape-plugin-page-cache-works.html fails
2407         https://bugs.webkit.org/show_bug.cgi?id=74409
2408
2409         Reviewed by Martin Robinson.
2410
2411         Add support for overriding the page-cache-for-plugins preference
2412         through DumpRenderTreeSupport.
2413
2414         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2415         (booleanFromValue): A helper function to convert a string to boolean.
2416         (LayoutTestController::overridePreference):
2417
2418 2012-03-05  Rob Buis  <rbuis@rim.com>
2419
2420         [BlackBerry] Update Tools/DumpRenderTree
2421         https://bugs.webkit.org/show_bug.cgi?id=80287
2422
2423         Reviewed by Antonio Gomes.
2424
2425         Update so we are sure we can build our implementation of DRT.
2426
2427         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
2428         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
2429         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
2430         (AccessibilityController::addNotificationListener): add missing hook.
2431         (AccessibilityController::removeNotificationListener): add missing hook.
2432         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2433         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
2434         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2435         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
2436         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
2437
2438 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
2439
2440         [Qt] [WK2] Support threaded renderer in WK2
2441         https://bugs.webkit.org/show_bug.cgi?id=76661
2442
2443         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
2444
2445         Reviewed by Kenneth Rohde Christiansen.
2446
2447         * MiniBrowser/qt/main.cpp:
2448         (main):
2449
2450 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
2451
2452         Unreviewed. Add myself to committer list.
2453
2454         * Scripts/webkitpy/common/config/committers.py:
2455
2456 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2457
2458         [Qt] Use config test to determine if the compiler supports -MD
2459
2460         We used to assume that unix systems building against Qt5 would have
2461         a compiler that supported -MD. Although this was usually the case,
2462         we failed to take into account broken tools for distributed builds
2463         (e.g. teambuilder or icecream) which would end up producing .d files
2464         in the root of the build dir instead of along-side the object file.
2465
2466         Now that we use a config-test to determine the support, we'll capture
2467         those cases, unless distributed builds are enabled after the initial
2468         build-webkit run.
2469
2470         Reviewed by Csaba Osztrogonác.
2471
2472         * Tools.pro:
2473         * qmake/config.tests/gccdepends/empty.cpp: Added.
2474         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
2475         * qmake/mkspecs/features/default_pre.prf:
2476         * qmake/mkspecs/features/features.prf:
2477         * qmake/mkspecs/features/unix/default_pre.prf:
2478         * qmake/sync.profile:
2479
2480 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2481
2482         Qt API test buildstep throws exception after buildmaster update
2483         https://bugs.webkit.org/show_bug.cgi?id=80249
2484
2485         Reviewed by Zoltan Herczeg.
2486
2487         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
2488         (BuildAndTestFactory.__init__):
2489
2490 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
2491
2492         [GTK] Unit tests are noisy when run under jhbuild
2493         https://bugs.webkit.org/show_bug.cgi?id=80241
2494
2495         Reviewed by Philippe Normand.
2496
2497         Force the 'memory' backend in GSettings so that each unit
2498         test doesn't produce a warning when it's forced to fall back
2499         to the 'memory' backend.
2500
2501         * Scripts/run-gtk-tests:
2502         (TestRunner.run): Force the 'memory' backend.
2503
2504 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
2505
2506         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
2507         https://bugs.webkit.org/show_bug.cgi?id=80235
2508
2509         Reviewed by Philippe Normand.
2510
2511         * Scripts/run-gtk-tests:
2512         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
2513         inspector resources path determination is shared by all tests.
2514
2515 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
2516
2517         [GTK] REGRESSION: r108278 broke some tests that expect focus
2518         https://bugs.webkit.org/show_bug.cgi?id=79084
2519
2520         Reviewed by Philippe Normand.
2521
2522         Grab focus when dumping test results and also when sending
2523         events. During the course of testing, the WebView may lose
2524         focus and this seems to snap it back when tests demand it.
2525
2526         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2527         (dump): Grab focus.
2528         * DumpRenderTree/gtk/EventSender.cpp:
2529         (dispatchEvent): Ditto.
2530
2531 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
2532
2533         Unreviewed, Add myself to committer list.
2534         https://bugs.webkit.org/show_bug.cgi?id=80232
2535
2536         * Scripts/webkitpy/common/config/committers.py:
2537
2538 2012-03-04  Anders Carlsson  <andersca@apple.com>
2539
2540         Newer versions of clang fail to compile WebKit.
2541
2542         Fix build.
2543
2544         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2545         (descriptionOfValue):
2546         (AccessibilityUIElement::rowIndexRange):
2547         (AccessibilityUIElement::columnIndexRange):
2548         (AccessibilityUIElement::selectedTextRange):
2549         * DumpRenderTree/mac/EditingDelegate.mm:
2550         (-[DOMRange dump]):
2551         * DumpRenderTree/mac/PolicyDelegate.mm:
2552         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
2553         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2554         (-[NSError _drt_descriptionSuitableForTestResult]):
2555         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2556         (WTR::descriptionOfValue):
2557         (WTR::AccessibilityUIElement::rowIndexRange):
2558         (WTR::AccessibilityUIElement::columnIndexRange):
2559         (WTR::AccessibilityUIElement::selectedTextRange):
2560
2561 2012-03-03  Simon Hausmann  <simon.hausmann@nokia.com>
2562
2563         [Qt] Fix static_libs_as_shared build
2564         https://bugs.webkit.org/show_bug.cgi?id=80214
2565
2566         Reviewed by Tor Arne Vestbø.
2567
2568         * WebKitTestRunner/qt/main.cpp:
2569         (main): Set the correct environment variable for choosing the theme in the
2570         web process.
2571
2572 2012-03-03  Hans Wennborg  <hans@chromium.org>
2573
2574         Implement Speech JavaScript API
2575         https://bugs.webkit.org/show_bug.cgi?id=80019
2576
2577         Reviewed by Adam Barth.
2578
2579         Add ENABLE_SCRIPTED_SPEECH.
2580
2581         * Scripts/build-webkit:
2582         * qmake/mkspecs/features/features.prf:
2583
2584 2012-03-02  Alexey Proskuryakov  <ap@apple.com>
2585
2586         Fix commit queue, remove duplicate entry.
2587
2588         * Scripts/webkitpy/common/config/committers.py:
2589
2590 2012-03-02  Stephen Chenney  <schenney@chromium.org>
2591
2592         Unreviewed, add myself as a committer
2593
2594         * Scripts/webkitpy/common/config/committers.py:
2595
2596 2012-03-02  Ojan Vafai  <ojan@chromium.org>
2597
2598         Add the Chromium Lion canary bot to the flakiness dashboard.
2599         * TestResultServer/static-dashboards/builders.js:
2600
2601 2012-03-02  Dirk Pranke  <dpranke@chromium.org>
2602
2603         links for virtual tests are broken in the flakiness dashboard
2604         https://bugs.webkit.org/show_bug.cgi?id=80180
2605
2606         Reviewed by Ojan Vafai.
2607
2608         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2609         (linkHTMLToOpenWindow):
2610         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2611         (testLinkHTMLToOpenWindow): added.
2612
2613 2012-03-02  Philippe Normand  <pnormand@igalia.com>
2614
2615         [GTK] security/block-test.html baselines differ from mac
2616         https://bugs.webkit.org/show_bug.cgi?id=78343
2617
2618         Reviewed by Martin Robinson.
2619
2620         Improved the FrameLoader error heuristics to match mac behavior a
2621         bit more.
2622
2623         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2624         (pathFromSoupURI): Handle ftp urls the same as http urls.
2625         (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
2626
2627 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
2628
2629         [Qt][WK2] Fix typo in patch committed in r109575
2630
2631         Unreviewed typo fix.
2632
2633         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2634         (MiniBrowserApplication::notify): Cache the position
2635         in floating point coordinates.
2636
2637 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
2638
2639         [Qt][WK2] Infinite loop on history navigation, when panning
2640         https://bugs.webkit.org/show_bug.cgi?id=79119
2641
2642         Reviewed by Simon Hausmann.
2643
2644         Make the touch mocking more robust by creating touch events
2645         directly and sending them synchronously to the browser window.
2646         If the sent touch event was not accepted we propagate the
2647         original mouse event to its target.
2648         This way we make sure we only send either a touch or a mouse
2649         event and do not end up in an infinite loop between our mocking
2650         code and the Qt5 automatic mouse event synthesizing.
2651
2652         * MiniBrowser/qt/BrowserWindow.cpp:
2653         (BrowserWindow::updateVisualMockTouchPoints):
2654         * MiniBrowser/qt/BrowserWindow.h:
2655         (BrowserWindow):
2656         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2657         (touchRectForPosition):
2658         (MiniBrowserApplication::notify):
2659         (MiniBrowserApplication::sendTouchEvent):
2660         * MiniBrowser/qt/MiniBrowserApplication.h:
2661         (MiniBrowserApplication):
2662
2663 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2664
2665         [Qt] Use 'all' as default target when debug_and_release is in effect
2666
2667         When debug_and_release is enabled, in combination with build_all,
2668         qmake will generate an aggregate makefile that calls make on both
2669         the debug and the release makefiles, but with the 'all' target.
2670
2671         In this case we can't use 'first' as the default target, as the
2672         extra targets would then not be run, so we append extra targets
2673         to 'all' instead.
2674
2675         Reviewed by Simon Hausmann.
2676
2677         * qmake/mkspecs/features/default_post.prf:
2678
2679 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2680
2681         [Qt] Make sure activeBuildConfig() returns the right config
2682
2683         Using isActiveConfig fails, as that only checks if the given
2684         argument is in CONFIG, not the order.
2685
2686         Reviewed by Simon Hausmann.
2687
2688         * qmake/mkspecs/features/functions.prf:
2689
2690 2012-03-02  Simon Hausmann  <simon.hausmann@nokia.com>
2691
2692         [Qt] Fix tests run with WTR not using QStyle theme
2693         https://bugs.webkit.org/show_bug.cgi?id=80147
2694
2695         Reviewed by Csaba Osztrogonác.
2696
2697         * WebKitTestRunner/qt/main.cpp:
2698         (main): Set environment variable for web process to use QStyle theme.
2699
2700 2012-03-02  Philippe Normand  <pnormand@igalia.com>
2701
2702         Unreviewed, remove debug print call.
2703
2704         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2705         (descriptionSuitableForTestResult):
2706
2707 2012-03-02  Robert Kroeger  <rjkroege@chromium.org>
2708
2709         Updated EventSender to send complete gesture events.
2710         https://bugs.webkit.org/show_bug.cgi?id=80075
2711
2712         Reviewed by Adam Barth.
2713
2714         * DumpRenderTree/chromium/EventSender.cpp:
2715         (EventSender::gestureEvent): set additional parameters in sent events.
2716
2717 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
2718
2719         WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
2720         https://bugs.webkit.org/show_bug.cgi?id=80033
2721
2722         Reviewed by Gustavo Noronha Silva.
2723
2724         GCC 4.7 no longer includes unistd.h from most of the standard C++
2725         header files, so we need to explicitly include it for getcwd().
2726
2727         * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
2728         not only on Mac, but on all Unix platforms.
2729
2730 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
2731
2732         Actually look at the args in driver_input :(.
2733
2734         Unreviewed, build fix.
2735
2736         * Scripts/webkitpy/layout_tests/port/chromium.py:
2737         (ChromiumDriver.run_test):
2738
2739 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
2740
2741         Fix typo in flag used to run gpu virtual suites.
2742
2743         Unreviewed, build fix.
2744
2745         * Scripts/webkitpy/layout_tests/port/chromium.py:
2746         (ChromiumPort.virtual_test_suites):
2747
2748 2012-03-01  Adam Barth  <abarth@webkit.org>
2749
2750         Unreviewed, rolling out r109317.
2751         http://trac.webkit.org/changeset/109317
2752
2753         Let's try watchlists again now that we're using a pure git
2754         working copy
2755
2756         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2757         (StyleQueueTask.run):
2758         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2759
2760 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
2761
2762         webkitpy: test_run_test_pause_before_testing is failing after r109482
2763         https://bugs.webkit.org/show_bug.cgi?id=80084
2764
2765         Unreviewed, build fix.
2766
2767         Fixes the test string compare to ignore the time spent running
2768         the tests.
2769
2770         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2771         (test_run_test_pause_before_testing):
2772
2773 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
2774
2775         nrwt: virtual tests aren't being run
2776         https://bugs.webkit.org/show_bug.cgi?id=80083
2777
2778         Reviewed by Eric Seidel.
2779
2780         If we tried to run all of the tests by default (and
2781         didn't specify any paths), the virtual tests weren't
2782         picked up.
2783
2784         * Scripts/webkitpy/layout_tests/port/base.py:
2785         (Port._virtual_tests):
2786         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2787         (PortTest.test_tests):
2788         * Scripts/webkitpy/layout_tests/port/test.py:
2789         (TestPort.virtual_test_suites):
2790
2791 2012-03-01  Ryosuke Niwa  <rniwa@webkit.org>
2792
2793         run-perf-tests should report the test runtime
2794         https://bugs.webkit.org/show_bug.cgi?id=80078
2795
2796         Reviewed by Hajime Morita.
2797
2798         Record and output the aggreated test run time.
2799
2800         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2801         (PerfTestsRunner._run_single_test):
2802
2803 2012-03-01  Michael Nordman  <michaeln@google.com>
2804
2805         [chromium] Use webkit_support to create session storage namespaces in DRT.
2806         https://bugs.webkit.org/show_bug.cgi?id=79933
2807
2808         Reviewed by Tony Chang.
2809
2810         * DumpRenderTree/chromium/WebViewHost.cpp:
2811         (WebViewHost::createSessionStorageNamespace):
2812
2813 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
2814
2815         nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
2816         https://bugs.webkit.org/show_bug.cgi?id=80048
2817
2818         Reviewed by Adam Barth.
2819
2820         * Scripts/webkitpy/layout_tests/port/base.py:
2821         (Port.test_isfile):
2822         (Port.test_isdir):
2823         (Port):
2824         (Port.test_exists):
2825         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2826         (PortTest.test_test_exists):
2827         (PortTest):
2828         (PortTest.test_test_isfile):
2829         (PortTest.test_test_isdir):
2830         * Scripts/webkitpy/layout_tests/port/test.py:
2831         (TestPort.virtual_test_suites):
2832         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2833         (MainTest.test_virtual):
2834
2835 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
2836
2837         [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
2838         https://bugs.webkit.org/show_bug.cgi?id=80031
2839
2840         Reviewed by Gustavo Noronha Silva.
2841
2842         Only build the libTestRunnerInjectedBundle.la convenience library when
2843         ENABLE_WEBKIT2 is defined.
2844
2845         * WebKitTestRunner/GNUmakefile.am:
2846
2847 2012-03-01  Philippe Normand  <pnormand@igalia.com>
2848
2849         Unreviewed, second attempt to fix GTK NRWT after r109242.
2850
2851         * Scripts/webkitpy/layout_tests/port/gtk.py:
2852         (GtkDriver._start):
2853
2854 2012-03-01  Philippe Normand  <pnormand@igalia.com>
2855
2856         Unreviewed, GTK NRWT build fix attempt after r109242.
2857
2858         * Scripts/webkitpy/layout_tests/port/gtk.py:
2859         (GtkDriver._start):
2860
2861 2012-03-01  Kentaro Hara  <haraken@chromium.org>
2862
2863         REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
2864         https://bugs.webkit.org/show_bug.cgi?id=80008
2865
2866         Reviewed by Adam Barth.
2867
2868         In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
2869         to "preprocess-idls.pl". This patch renames it.
2870
2871         Test: Confirm that run-bindings-tests runs.
2872
2873         * Scripts/webkitpy/bindings/main.py:
2874         (BindingsTests.generate_supplemental_dependency):
2875
2876 2012-02-29  Simon Hausmann  <simon.hausmann@nokia.com>
2877
2878         [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
2879         https://bugs.webkit.org/show_bug.cgi?id=78047
2880
2881         Reviewed by Kenneth Rohde Christiansen.
2882
2883         Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
2884         sending to the item requires the QObject::event re-implementation to dispatch to the correct
2885         event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
2886         the event handlers directly, and with the removal of our own dispatching we need to go through
2887         that code path.
2888
2889         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2890         (WTR::PlatformWebView::sendEvent):
2891         (WTR::PlatformWebView::postEvent):
2892
2893 2012-02-29  Adam Barth  <abarth@webkit.org>
2894
2895         Disable watchlist.  It's been spamming CCs.
2896
2897         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2898         (StyleQueueTask.run):
2899         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2900
2901 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
2902
2903         need to clone the gpu baselines and expectations into the new "virtual" dir
2904         https://bugs.webkit.org/show_bug.cgi?id=79956
2905
2906         Reviewed by Adam Barth.
2907
2908         * Scripts/webkitpy/layout_tests/port/chromium.py:
2909         (ChromiumPort.virtual_test_suites):
2910
2911 2012-02-29  Mark Rowe  <mrowe@apple.com>
2912
2913         Switch to using json rather than simplejson now that the master is using Python 2.7.
2914
2915         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2916         (loadBuilderConfig):
2917
2918 2012-02-29  David Levin  <levin@chromium.org>
2919
2920         [chromium] Add the ability to turn off autoresize.
2921         https://bugs.webkit.org/show_bug.cgi?id=77452
2922
2923         Reviewed by Darin Fisher.
2924
2925         * DumpRenderTree/chromium/LayoutTestController.cpp:
2926         (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
2927         (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
2928         (LayoutTestController::disableAutoResizeMode):  Ditto.
2929         * DumpRenderTree/chromium/LayoutTestController.h: Ditto.
2930
2931 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
2932
2933         nrwt: make --print trace work with virtual tests
2934         https://bugs.webkit.org/show_bug.cgi?id=79952
2935
2936         Reviewed by Adam Barth.
2937
2938         * Scripts/webkitpy/layout_tests/views/printing.py:
2939         (Printer._print_test_trace):
2940         (Printer._print_baseline):
2941
2942 2012-02-28  Brian Weinstein  <bweinstein@apple.com>
2943
2944         WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
2945         https://bugs.webkit.org/show_bug.cgi?id=79849
2946
2947         Reviewed by Beth Dakin.
2948
2949         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2950         (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
2951
2952 2012-02-29  Lucas Forschler  <lforschler@apple.com>
2953
2954         Removed unused Apple buildslaves from the master configuration
2955         https://bugs.webkit.org/show_bug.cgi?id=79925
2956
2957         Reviewed by Stephanie Lewis.
2958
2959         * BuildSlaveSupport/build.webkit.org-config/config.json:
2960
2961 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
2962
2963         nrwt: implement simple 'virtual test suite' support
2964         https://bugs.webkit.org/show_bug.cgi?id=79737
2965
2966         Reviewed by Adam Barth.
2967
2968         Add very basic support for 'virtual test suites' to NRWT:
2969         a virtual suite is a directory that may contain new baselines,
2970         contains a pointer to a "base" directory of tests, and an
2971         optional list of command line arguments to pass to DRT;
2972         it gives us a way to run all of the tests in a given directory
2973         multiple times with multiple (potentially differing) sets of
2974         results and baselines.
2975
2976         This patch implements the support needed for this feature, and
2977         some basic tests, but no actual port will use the feature yet.
2978
2979         This is probably the simplest implementation possible - the
2980         list of virtual suites will be hard-coded into the port's
2981         implementation. One can imagine a more data-driven approach
2982         where the suite instructions are stored in a manifest file
2983         either in LayoutTests (all suites in one file), or per-port,
2984         or per-directory. If this feature ends up being useful we
2985         should probably add something like that so people don't have
2986         to hunt around in the code to add suites.
2987
2988         * Scripts/webkitpy/layout_tests/port/base.py:
2989         (Port.__init__):
2990         (Port.expected_filename):
2991         (Port.tests):
2992         (Port):
2993         (Port._real_tests):
2994         (Port._driver_class):
2995         (Port.virtual_test_suites):
2996         (Port.virtual_suite):
2997         (Port.virtual_suite.VirtualTestSuite):
2998         (Port.virtual_suite.VirtualTestSuite.__init__):
2999         (Port.virtual_suite.VirtualTestSuite.__repr__):
3000         (Port.populated_virtual_test_suites):
3001         (Port._virtual_tests):
3002         (Port.lookup_virtual_test_base):
3003         (Port.lookup_virtual_test_args):
3004         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3005         (PortTest.test_find_with_skipped_directories):
3006         * Scripts/webkitpy/layout_tests/port/driver.py:
3007         (DriverInput.__init__):
3008         (DriverProxy.run_test):
3009         * Scripts/webkitpy/layout_tests/port/test.py:
3010         (TestPort.virtual_test_suites):
3011         (TestDriver.run_test):
3012         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3013         (MainTest.test_all):
3014         (MainTest.test_virtual):
3015
3016 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
3017
3018         nrwt: support more than two drivers in DriverProxy
3019         https://bugs.webkit.org/show_bug.cgi?id=79736
3020
3021         Reviewed by Adam Barth.
3022
3023         Now that we can support per-test command lines for
3024         Drivers, modify DriverProxy to keep a map of running
3025         drivers for each needed command-line; this will allow
3026         us to transparently maintain a pool of appropriately
3027         configured DRTs without having to constantly start and stop
3028         them.
3029
3030         Note that this potentially raises a garbage collection
3031         problem - the number of running DRTs will grow with the
3032         number of different sets of command line args. For now
3033         this is no worse than the current code - if you're running
3034         with pixel tests, you will only need one DRT per worker,
3035         and if you aren't, you'll need two (one for text-only tests,
3036         and one for reftests).
3037
3038         An alternative would be to only ever have one running driver,
3039         and restart the driver as the command line changes, but this
3040         might (?) slow down execution in the text-only case - we
3041         should benchmark this because it would be simpler and possibly
3042         allow us to eliminate DriverProxy altogether.
3043
3044         * Scripts/webkitpy/layout_tests/port/driver.py:
3045         (DriverProxy.__init__):
3046         (DriverProxy):
3047         (DriverProxy._make_driver):
3048         (DriverProxy.run_test):
3049         (DriverProxy.has_crashed):
3050         (DriverProxy.stop):
3051         (DriverProxy.cmd_line):
3052         (DriverProxy._cmd_line_as_key):
3053
3054 2012-02-29  Adrienne Walker  <enne@google.com>
3055
3056         Unreviewed, add myself as a reviewer
3057
3058         * Scripts/webkitpy/common/config/committers.py:
3059
3060 2012-02-29  Greg Billock  <gbillock@google.com>
3061
3062         Add more tests for web intents
3063         https://bugs.webkit.org/show_bug.cgi?id=79527
3064
3065         Reviewed by Adam Barth.
3066
3067         * DumpRenderTree/chromium/LayoutTestController.cpp:
3068         (LayoutTestController::LayoutTestController):
3069         (LayoutTestController::sendWebIntentResponse):
3070         * DumpRenderTree/chromium/LayoutTestController.h:
3071         (LayoutTestController):
3072         * DumpRenderTree/chromium/WebViewHost.h:
3073         (WebViewHost):
3074         (WebViewHost::currentIntentRequest):
3075
3076 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
3077
3078         nrwt: port/Driver needs to support per-test command line args
3079         https://bugs.webkit.org/show_bug.cgi?id=79733
3080
3081         Reviewed by Adam Barth.
3082
3083         As part of removing the 'gpu' configurations and adding support
3084         for 'virtual test suites', the Driver classes need to support
3085         per-test command lines (since different tests will need to be
3086         run with different command line options).
3087
3088         The per-test args are not yet used, so this change should have
3089         no visible effects and need no additional testing.
3090
3091         * Scripts/webkitpy/layout_tests/port/base.py:
3092         (Port.driver_cmd_line):
3093         * Scripts/webkitpy/layout_tests/port/chromium.py:
3094         (ChromiumDriver.cmd_line):
3095         (ChromiumDriver._start):
3096         (ChromiumDriver.start):
3097         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3098         (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
3099         (ChromiumDriverTest):
3100         (ChromiumDriverTest.test_two_drivers):
3101         * Scripts/webkitpy/layout_tests/port/driver.py:
3102         (Driver.cmd_line):
3103         (DriverProxy.__init__):
3104         (DriverProxy.start):
3105         (DriverProxy.cmd_line):
3106         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3107         (DriverTest.test_virtual_driver_methods):
3108         * Scripts/webkitpy/layout_tests/port/gtk.py:
3109         (GtkDriver.cmd_line):
3110         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3111         * Scripts/webkitpy/layout_tests/port/test.py:
3112         (TestPort._path_to_driver):
3113         (TestDriver.cmd_line):
3114         (TestDriver.start):
3115         * Scripts/webkitpy/layout_tests/port/webkit.py:
3116         (WebKitDriver.cmd_line):
3117         (WebKitDriver._start):
3118         (WebKitDriver.run_test):
3119         (WebKitDriver.start):
3120         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3121         (WebKitDriverTest.test_no_timeout):
3122         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3123         (PerfTestsRunner._run_tests_set):
3124         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3125         (test_run_test_pause_before_testing):
3126
3127 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
3128
3129         perftestsrunner can call printer.write() after printer.cleanup()
3130         https://bugs.webkit.org/show_bug.cgi?id=79872
3131
3132         Reviewed by Ryosuke Niwa.
3133
3134         This patch fixes a unittest that was incorrectly calling
3135         PerfTestsRunner.run() twice (which led to a weird state in the
3136         printer object).
3137
3138         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3139         (MainTest.test_run_with_upload_json):
3140
3141 2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
3142
3143         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
3144         https://bugs.webkit.org/show_bug.cgi?id=76546
3145
3146         Reviewed by Simon Hausmann.
3147
3148         Revert the workaround introduced in r107868 and reintroduce
3149         the qml binding so we can test the code path that we are more
3150         interested in. The reason that it did not work before is that
3151         we don't have an active platform window which we now workaround
3152         by propagating the resize through QWindowSystemInterface.
3153
3154         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3155         (WTR::WrapperWindow::handleStatusChanged):
3156         (WTR::PlatformWebView::resizeTo):
3157
3158 2012-02-29  Gabor Rapcsanyi  <rgabor@webkit.org>
3159
3160         [GTK] Small fix for cross compilation to not generate gtkdoc.
3161
3162         Rubber-stamped by Csaba Osztrogonác.
3163
3164         * Scripts/webkitdirs.pm:
3165         (isCrossCompilation):
3166
3167 2012-02-28  Lucas Forschler  <lforschler@apple.com>
3168
3169         Fix a typo in config.json
3170         linx -> linux
3171         
3172         * BuildSlaveSupport/build.webkit.org-config/config.json:
3173
3174 2012-02-28  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3175
3176         [Qt] Allow read/write to the WebView.url property
3177         https://bugs.webkit.org/show_bug.cgi?id=77554
3178
3179         Reviewed by Tor Arne Vestbø.
3180
3181         Fix MiniBrowser to use WebView.url property and remove WebView.load usage.
3182
3183         * MiniBrowser/qt/qml/BrowserWindow.qml:
3184
3185 2012-02-28  Dan Winship  <danw@gnome.org>
3186
3187         [GTK] make tests explicitly request GSettingsBackendMemory
3188         https://bugs.webkit.org/show_bug.cgi?id=79788
3189
3190         Reviewed by Martin Robinson.
3191
3192         Explicitly request the fallback memory-based GSettings backend; if
3193         other backends are available then we don't want to use them,
3194         because they would make tests depend on the user's preferences.
3195         And if other backends aren't available, we don't need glib to
3196         print a warning about that fact.
3197
3198         * Scripts/webkitpy/layout_tests/port/gtk.py:
3199         (GtkPort.setup_environ_for_server):
3200
3201 2012-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
3202
3203         Unreviewed, rolling out r109110.
3204         http://trac.webkit.org/changeset/109110
3205         https://bugs.webkit.org/show_bug.cgi?id=79806
3206
3207         webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
3208         (Requested by aroben on #webkit).
3209
3210         * Scripts/webkitpy/common/checkout/changelog.py:
3211         (parse_bug_id):
3212         (parse_bug_id_from_changelog):
3213         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3214         * Scripts/webkitpy/common/config/urls.py:
3215
3216 2012-02-28  Adam Roben  <aroben@webkit.org>
3217
3218         Add my new email address
3219
3220         Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect
3221
3222         Reviewed by Anders Carlsson.
3223
3224         * Scripts/webkitpy/common/config/committers.py:
3225
3226 2012-02-28  Adam Roben  <aroben@apple.com>
3227
3228         Teach webkitpy about wkb.ug URLs
3229
3230         Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
3231         use wkb.ug URLs
3232
3233         Reviewed by Anders Carlsson.
3234
3235         * Scripts/webkitpy/common/checkout/changelog.py:
3236         (parse_bug_id):
3237         (parse_bug_id_from_changelog):
3238         Fall back to the tiny URL format if neither the short nor long URL formats work.
3239
3240         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3241         (ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.
3242
3243         * Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match
3244         wkb.ug URLs.
3245
3246 2012-02-28  János Badics  <dicska@gmail.com>
3247
3248         [Qt] build-webkit does not detect the number of CPUs
3249         https://bugs.webkit.org/show_bug.cgi?id=76445
3250
3251         Based on Seo Sanghyeon's work (modification:
3252         Automatically determine the number of CPUs for make
3253         only if -j make argument haven't already been specified.)
3254
3255         Reviewed by Csaba Osztrogonác.
3256
3257         * Scripts/webkitdirs.pm:
3258         (buildQMakeProjects):
3259
3260 2012-02-28  Kent Tamura  <tkent@chromium.org>
3261
3262         Update a pattern for forms files of watchlist
3263         https://bugs.webkit.org/show_bug.cgi?id=79767
3264
3265         Reviewed by Kentaro Hara.
3266
3267         * Scripts/webkitpy/common/config/watchlist:
3268         Catches the following files with the "Forms" pattern.
3269         - HTMLDatListElement.*
3270         - HTMLKeygenElement.*
3271         - HTMLLegendElement.*
3272         - HTMLOutputElement.*
3273         - FormAssociatedElement.*
3274         - SliderThumbElement.*
3275         - TextControlInnerElements.*
3276         - RenderFileUploadControl.*
3277
3278 2012-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3279
3280         Unreviewed, rolling out r109041.
3281         http://trac.webkit.org/changeset/109041
3282         https://bugs.webkit.org/show_bug.cgi?id=79741
3283
3284         Broke Chromium Win build (Requested by bashi on #webkit).
3285
3286         * DumpRenderTree/chromium/LayoutTestController.cpp:
3287         (LayoutTestController::LayoutTestController):
3288         * DumpRenderTree/chromium/LayoutTestController.h:
3289         (LayoutTestController):
3290         * DumpRenderTree/chromium/WebViewHost.h:
3291
3292 2012-02-27  James Robinson  <jamesr@chromium.org>
3293
3294         [chromium] Remove media tests from ChromiumGpu configurations
3295         https://bugs.webkit.org/show_bug.cgi?id=79720
3296
3297         Reviewed by Adam Barth.
3298
3299         We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
3300         composited playback path via tests in the compositing/ directory.
3301
3302         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3303         (_default_tests_paths):
3304         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3305         (ChromiumGpuTest.test_default_tests_paths):
3306         (ChromiumGpuTest.test_test_files):
3307
3308 2012-02-27  Dirk Pranke  <dpranke@chromium.org>
3309
3310         nrwt: log multiline stderr/crash output properly
3311         https://bugs.webkit.org/show_bug.cgi?id=79722
3312
3313         Reviewed by Adam Barth.
3314
3315         This cleans up some nits in the log output to make things
3316         slightly easier to read (every line gets timestamped, etc.).
3317
3318         Also tweaks the log message for pixel hash mismatches.
3319
3320         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3321         (SingleTestRunner._handle_error):
3322         (SingleTestRunner._compare_image):
3323
3324 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
3325
3326         Touch the master.cfg to force a reconfig.
3327
3328         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3329         (BuildAndTestLeaksFactory):
3330         (NewBuildAndTestFactory):
3331
3332 2012-02-27  Jacky Jiang  <zhajiang@rim.com>
3333
3334         [BlackBerry] Upstream BlackBerry API web page related files
3335         https://bugs.webkit.org/show_bug.cgi?id=74380
3336
3337         Reviewed by Antonio Gomes.
3338
3339         Adapt to the removing of WebPage::mainFrame(), use
3340         DumpRenderTreeSupport::corePage() and its mainFrame() instead.
3341
3342         No new tests as this patch doesn't change behavior.
3343
3344         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3345         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3346         (BlackBerry::WebKit::DumpRenderTree::runTests):
3347
3348 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
3349
3350         Add Windows and Linux Chromium perf bots
3351         https://bugs.webkit.org/show_bug.cgi?id=79418
3352
3353         Reviewed by Tony Chang.
3354
3355         Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
3356         the dedicated perf bot slave (uses the same hardware).
3357
3358         * BuildSlaveSupport/build.webkit.org-config/config.json:
3359
3360 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
3361
3362         Undefined variable 'current' when running chromium_android.py
3363         https://bugs.webkit.org/show_bug.cgi?id=79696
3364
3365         Reviewed by Adam Barth.
3366
3367         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3368         (ChromiumAndroidDriver._read_prompt):
3369
3370 2012-02-27  Greg Billock  <gbillock@google.com>
3371
3372         Add more tests for web intents
3373         https://bugs.webkit.org/show_bug.cgi?id=79527
3374
3375         Reviewed by Adam Barth.
3376
3377         * DumpRenderTree/chromium/LayoutTestController.cpp:
3378         (LayoutTestController::LayoutTestController):
3379         (LayoutTestController::sendWebIntentResponse):
3380         * DumpRenderTree/chromium/LayoutTestController.h:
3381         (LayoutTestController):
3382         * DumpRenderTree/chromium/WebViewHost.h:
3383         (WebViewHost):
3384         (WebViewHost::currentIntentRequest):
3385
3386 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
3387
3388         Chromium-Android layout test script: the adb shell prompt is not always '# '
3389         https://bugs.webkit.org/show_bug.cgi?id=79506
3390
3391         Reviewed by Adam Barth.
3392
3393         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3394         (ChromiumAndroidDriver._start):
3395         (ChromiumAndroidDriver._read_prompt):
3396
3397 2012-02-27  Dan Bernstein  <mitz@apple.com>
3398
3399         Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
3400         https://bugs.webkit.org/show_bug.cgi?id=79607
3401
3402         Reviewed by Adele Peterson.
3403
3404         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3405         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
3406         (TestWebKitAPI::AcceptsFirstMouse::url):
3407         (TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
3408         (TestWebKitAPI::AcceptsFirstMouse::runTest):
3409         (TestWebKitAPI::TEST_F):
3410         * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
3411
3412 2012-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3413
3414         Unreviewed. Fix make distcheck.
3415
3416         * GNUmakefile.am: Fix typo.
3417
3418 2012-02-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3419
3420         [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
3421
3422         Reviewed by Kenneth Rohde Christiansen..
3423
3424         * qmake/mkspecs/features/features.prf:
3425
3426 2012-02-27  Hao Zheng  <zhenghao@chromium.org>
3427
3428         Add a ChromiumGpuAndroid port.
3429         https://bugs.webkit.org/show_bug.cgi?id=79628
3430
3431         Reviewed by Adam Barth.
3432
3433         Android does have a gpu port, so revert r107697.
3434
3435         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3436         (ChromiumAndroidPort.__init__):
3437         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3438         (ChromiumGpuAndroidPort):
3439         (ChromiumGpuAndroidPort.__init__):
3440         (ChromiumGpuAndroidPort.baseline_search_path):
3441         (ChromiumGpuAndroidPort.default_child_processes):
3442         (ChromiumGpuAndroidPort.tests):
3443         * Scripts/webkitpy/layout_tests/port/factory.py:
3444         (PortFactory):
3445
3446 2012-02-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3447
3448         Change Build bot with BuildAndTest bot for EFL port.
3449         https://bugs.webkit.org/show_bug.cgi?id=77518
3450
3451         Reviewed by Ryosuke Niwa.
3452
3453         EFL build bot starts to support layout test.
3454
3455         * BuildSlaveSupport/build.webkit.org-config/config.json:
3456         * BuildSlaveSupport/built-product-archive:
3457         (archiveBuiltProduct):
3458         (extractBuiltProduct):
3459         * BuildSlaveSupport/test-result-archive:
3460         (archiveTestResults):
3461         * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
3462         (generateBuildSystemFromCMakeProject):
3463
3464 2012-02-24  Darin Fisher  <darin@chromium.org>
3465
3466         Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
3467
3468         Reviewed by James Robinson.
3469
3470         * Scripts/webkitpy/common/config/watchlist:
3471
3472 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
3473
3474         webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
3475         https://bugs.webkit.org/show_bug.cgi?id=79258
3476
3477         Reviewed by Ryosuke Niwa.
3478
3479         Split the fuzzy matching into separate functions so that they
3480         can be sharded and run in parallel.
3481
3482         Also, fix a bug in the svn_blame_regexp that was causing us
3483         to require ChangeLog lines to have at least one space after the
3484         author, making the code require trailing whitespace in the
3485         changelog in some places (this was making my life harder because
3486         I have my text editor set to strip trailing whitespace in python
3487         files, and that was causing test_parse_log_entries_from_changelog() to fail
3488         when the whitespace on line 275 was removed).
3489
3490         * Scripts/webkitpy/common/checkout/changelog.py:
3491         (ChangeLog):
3492         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3493         (test_fuzzy_reviewer_match__none):
3494         (test_fuzzy_reviewer_match_adam_barth):
3495         (test_fuzzy_reviewer_match_darin_adler_et_al):
3496         (test_fuzzy_reviewer_match_dimitri_glazkov):
3497         (test_fuzzy_reviewer_match_george_staikos):
3498         (test_fuzzy_reviewer_match_mark_rowe):
3499
3500 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
3501
3502         webkitpy: committers_unittest fuzzy matching is really slow
3503         https://bugs.webkit.org/show_bug.cgi?id=79179
3504
3505         Reviewed by Ryosuke Niwa.
3506
3507         Break the fuzzy matching tests into individual routines for
3508         each contributor so that the intent is a little clearer, so
3509         that it's easier to test individual names (and identify
3510         duplicate tests), and so that we can eventually run
3511         them in parallel.
3512
3513         Also, mark most of them as 'integration' tests so that they
3514         can be skipped if we want to go fast (we leave a few as
3515         regular tests for functional coverage).
3516
3517         * Scripts/webkitpy/common/config/committers_unittest.py:
3518         (CommittersTest):
3519         (CommittersTest.test_contributors_by_fuzzy_match):
3520         (CommittersTest.integration_test_contributors__none):
3521         (CommittersTest.integration_test_contributors__none_2):
3522         (CommittersTest.integration_test_contributors__none_3):
3523         (CommittersTest.integration_test_contributors_ada_chan):
3524         (CommittersTest.integration_test_contributors_adele_peterson):
3525         (CommittersTest.integration_test_contributors_alexey_proskuryakov):
3526         (CommittersTest.integration_test_contributors_alice_liu):
3527         (CommittersTest.integration_test_contributors_alp_toker):
3528         (CommittersTest.integration_test_contributors_anders_carlsson):
3529         (CommittersTest.integration_test_contributors_antti_koivisto):
3530         (CommittersTest.integration_test_contributors_beth_dakin):
3531         (CommittersTest.integration_test_contributors_brady_eidson):
3532         (CommittersTest.integration_test_contributors_cameron_zwarich):
3533         (CommittersTest.integration_test_contributors_chris_blumenberg):
3534         (CommittersTest.integration_test_contributors_dan_bernstein):
3535         (CommittersTest.integration_test_contributors_dan_bernstein_2):
3536         (CommittersTest.integration_test_contributors_darin_adler):
3537         (CommittersTest.integration_test_contributors_david_harrison):
3538         (CommittersTest.integration_test_contributors_david_harrison_2):
3539         (CommittersTest.integration_test_contributors_david_hyatt):
3540         (CommittersTest.integration_test_contributors_david_kilzer):
3541         (CommittersTest.integration_test_contributors_don_melton):
3542         (CommittersTest.integration_test_contributors_eric_seidel):
3543         (CommittersTest.integration_test_contributors_geoffrey_garen):
3544         (CommittersTest.integration_test_contributors_greg_bolsinga):
3545         (CommittersTest.integration_test_contributors_holger_freyther):
3546         (CommittersTest.integration_test_contributors_jon_sullivan):
3547         (CommittersTest.integration_test_contributors_jon_honeycutt):
3548         (CommittersTest.integration_test_contributors_joseph_pecoraro):
3549         (CommittersTest.integration_test_contributors_ken_kocienda):
3550         (CommittersTest.integration_test_contributors_kenneth_russell):
3551         (CommittersTest.integration_test_contributors_kevin_decker):
3552         (CommittersTest.integration_test_contributors_kevin_mccullough):
3553         (CommittersTest.integration_test_contributors_lars_knoll):
3554         (CommittersTest.integration_test_contributors_lars_weintraub):
3555         (CommittersTest.integration_test_contributors_maciej_stachowiak):
3556         (CommittersTest.integration_test_contributors_mark_rowe):
3557         (CommittersTest.integration_test_contributors_nikolas_zimmermann):
3558         (CommittersTest.integration_test_contributors_oliver_hunt):
3559         (CommittersTest.integration_test_contributors_rniwa):
3560         (CommittersTest.disabled_integration_test_contributors_simon_fraser):
3561         (CommittersTest.integration_test_contributors_steve_falkenburg):
3562         (CommittersTest.integration_test_contributors_sam_weinig):
3563         (CommittersTest.integration_test_contributors_tim_omernick):
3564         (CommittersTest.integration_test_contributors_timothy_hatcher):
3565         (CommittersTest.integration_test_contributors_tor_arne_vestbo):
3566         (CommittersTest.integration_test_contributors_vicki_murley):
3567         (CommittersTest.integration_test_contributors_zack_rusin):
3568
3569 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
3570
3571         webkitpy: should autoinstall coverage
3572         https://bugs.webkit.org/show_bug.cgi?id=79535
3573
3574         Reviewed by Eric Seidel.
3575
3576         We should automatically print the coverage report after the run, too.
3577
3578         * Scripts/webkitpy/test/main.py:
3579         (Tester._run_tests):
3580         * Scripts/webkitpy/thirdparty/__init__.py:
3581         (AutoinstallImportHook.find_module):
3582         (AutoinstallImportHook._install_coverage):
3583
3584 2012-02-24  Pablo Flouret  <pablof@motorola.com>
3585
3586         Fix copypasta in build-webkit's --vibration option description
3587         https://bugs.webkit.org/show_bug.cgi?id=79528
3588
3589         Reviewed by Andreas Kling.
3590
3591         * Scripts/build-webkit:
3592
3593 2012-02-24  Antonio Gomes  <agomes@rim.com>
3594
3595         Adding myself to ScrollingCoordinator watchlist
3596         https://bugs.webkit.org/show_bug.cgi?id=79525
3597
3598         Reviewed by Rob Buis.
3599
3600         * Scripts/webkitpy/common/config/watchlist:
3601
3602 2012-02-24  Darin Fisher  <darin@chromium.org>
3603
3604         Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
3605
3606         Reviewed by Adam Barth.
3607
3608         * Scripts/webkitpy/common/config/watchlist:
3609
3610 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
3611
3612         webkitpy: config_unittest is sensitive to other tests that might've already run
3613         https://bugs.webkit.org/show_bug.cgi?id=79382
3614
3615         Reviewed by Adam Barth.
3616
3617         If another test runs prior to config_unittest and pokes the
3618         cached configuration, the first test in config_unittest might
3619         fail; the tearDown() will then allow subsequent tests to pass.
3620         Clearing the configuration prior to each test makes things
3621         slightly slower but safer.
3622
3623         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3624         (ConfigTest.setUp):
3625
3626 2012-02-24  David Kilzer  <ddkilzer@apple.com>
3627
3628         Use xcrun to find compiler paths for Generate Derived Sources build phase script
3629         <http://webkit.org/b/79512>
3630
3631         Reviewed by Dan Bernstein.
3632
3633         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3634         (Generate Derived Sources): Use xcrun to find the path to the
3635         compiler since that works on both iOS and OS X.
3636
3637 2012-02-24  James Robinson  <jamesr@chromium.org>
3638
3639         Create a watchlist for ScrollingCoordinator changes
3640         https://bugs.webkit.org/show_bug.cgi?id=79511
3641
3642         Reviewed by Anders Carlsson.
3643
3644         * Scripts/webkitpy/common/config/watchlist:
3645
3646 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3647
3648         [EFL][DRT] Implement setValueForUser and setAutofilled.
3649         https://bugs.webkit.org/show_bug.cgi?id=79237
3650
3651         Reviewed by Andreas Kling.
3652
3653         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
3654         Those implementations are related with input fields and allow to pass following tests:
3655         fast/forms/onchange-setvalueforuser.html
3656         fast/forms/input-autofilled.html
3657         fast/forms/reset-autofilled.html
3658
3659         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3660         (LayoutTestController::setValueForUser):
3661         (LayoutTestController::setAutofilled):
3662
3663 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
3664
3665         [Qt] Allow to use WebCore imagedecoders
3666         https://bugs.webkit.org/show_bug.cgi?id=32410
3667
3668         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
3669
3670         Reviewed by Simon Hausmann.
3671
3672         * qmake/mkspecs/features/features.prf:
3673
3674 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
3675
3676         [Qt] Add Qt5 way to force 96 DPI for tests
3677         https://bugs.webkit.org/show_bug.cgi?id=79364
3678
3679         Reviewed by Simon Hausmann.
3680
3681         * DumpRenderTree/qt/main.cpp:
3682         (main):
3683         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3684         (WTR::activateFonts):
3685
3686 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3687
3688         [GTK] MiniBrowser should reload the view then the reload button is clicked
3689         https://bugs.webkit.org/show_bug.cgi?id=79472
3690
3691         Reviewed by Philippe Normand.
3692
3693         * MiniBrowser/gtk/BrowserWindow.c:
3694         (reloadCallback): Call webkit_web_view_reload().
3695         (browser_window_init): Connect reload item clicked even to
3696         reloadCallback instead of activateUriEntryCallback.
3697
3698 2012-02-24  Kentaro Hara  <haraken@chromium.org>
3699