[Win] A few final cleanups to the DataObject classes.
[WebKit-https.git] / Tools / ChangeLog
1 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
2
3         [Win] A few final cleanups to the DataObject classes.
4         https://bugs.webkit.org/show_bug.cgi?id=131784
5
6         Reviewed by Anders Carlsson.
7
8         * DumpRenderTree/win/DRTDataObject.cpp:
9         (DRTDataObject::clearData): Use 'last()' method.
10         * DumpRenderTree/win/UIDelegate.cpp:
11         (DRTUndoStack::pop): Use 'takeLast()' method.
12
13 2014-04-17  Andres Gomez  <agomez@igalia.com>
14
15         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
16         https://bugs.webkit.org/show_bug.cgi?id=131365
17
18         Reviewed by Brent Fulgham.
19
20         The cygwin installer is now downloading the wanted versions for
21         the local installation given to the setup wizard.
22
23         * CygwinDownloader/cygwin-downloader.py:
24         * CygwinDownloader/cygwin-downloader.zip:
25
26 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
27
28         [GTK] Make run-webkit-tests always use WKTR
29         https://bugs.webkit.org/show_bug.cgi?id=131737
30
31         Reviewed by Darin Adler.
32
33         Now that the GTK+ port only has support for WebKit2, instruct
34         run-webkit-tests to always use WKTR. This avoids needing to pass
35         flag "-2" every time.
36
37         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
38         (_set_up_derived_options): Always set webkit_test_runner when
39         the platform is GTK+.
40
41 2014-04-17  Brendan Long  <b.long@cablelabs.com>
42
43         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
44         https://bugs.webkit.org/show_bug.cgi?id=131760
45
46         Reviewed by Philippe Normand.
47
48         * gtk/install-dependencies: Install ninja-build when it's available.
49
50 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
51
52         [Win] run-javascriptcore-tests fails to run.
53         https://bugs.webkit.org/show_bug.cgi?id=131761
54
55         Reviewed by Brent Fulgham.
56
57         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
58
59 2014-04-16  Andres Gomez  <agomez@igalia.com>
60
61         [Win] Pass default parameters to cygwin setup wizard
62         https://bugs.webkit.org/show_bug.cgi?id=131361
63
64         Reviewed by Brent Fulgham.
65
66         Added some parameters to the cygwin setup wizard so the user
67         doesn't really have to do any interaction.
68
69         * CygwinDownloader/cygwin-downloader.py:
70         * CygwinDownloader/cygwin-downloader.zip:
71
72 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
73
74         [Win] Eliminate use of deleteAllValues in Windows Files
75         https://bugs.webkit.org/show_bug.cgi?id=131631
76
77         Reviewed by Darin Adler.
78
79         Switch to std::unique_ptr for memory lifetime. Get rid of
80         deleteAllValues now that it is no longer needed. Use ranged
81         for loops where possible.
82
83         * DumpRenderTree/win/DRTDataObject.cpp:
84         (WCEnumFormatEtc::WCEnumFormatEtc):
85         (DRTDataObject::~DRTDataObject):
86         (DRTDataObject::GetData):
87         (DRTDataObject::QueryGetData):
88         (DRTDataObject::SetData):
89         (DRTDataObject::clearData):
90         * DumpRenderTree/win/DRTDataObject.h:
91         * DumpRenderTree/win/UIDelegate.cpp:
92         (DRTUndoObject::DRTUndoObject):
93         (DRTUndoObject::~DRTUndoObject):
94         (DRTUndoStack::~DRTUndoStack):
95         (DRTUndoStack::clear):
96         (DRTUndoStack::pop):
97         (DRTUndoManager::DRTUndoManager):
98         (DRTUndoManager::redo):
99         (DRTUndoManager::undo):
100         (UIDelegate::UIDelegate):
101         (UIDelegate::resetUndoManager):
102         * DumpRenderTree/win/UIDelegate.h:
103
104 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
105
106         [GTK] Unreviewed GTK gardening.
107
108         Update list of skipped unit tests:
109
110           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
111
112           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
113           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
114
115         * Scripts/run-gtk-tests:
116         (TestRunner):
117
118 2014-04-16  Tim Horton  <timothy_horton@apple.com>
119
120         check-webkit-style doesn't check code style in .mm or .m files
121         https://bugs.webkit.org/show_bug.cgi?id=131708
122
123         Reviewed by Darin Adler.
124
125         * Scripts/webkitpy/style/checker.py:
126         * Scripts/webkitpy/style/checker_unittest.py:
127         (CheckerDispatcherDispatchTest.test_cpp_paths):
128         (CheckerDispatcherDispatchTest.test_text_paths):
129         Check .mm and .m files as C++.
130
131         * Scripts/webkitpy/style/checkers/cpp.py:
132         (check_spacing):
133         Add an override for our ordinary "missing spaces around =" for @synthesize,
134         which should look like "@synthesize propertyName=_varName;"
135
136         Add an override for "missing space before {" for blocks' "^{".
137
138         Don't follow the "extra space before [" rule for Objective-C, because
139         it breaks this rule in a multitude of ways because of method calls.
140
141         (check_braces):
142         Don't complain about { not being on the end of the previous line if
143         the previous line starts with "- (" or "+ (", which would indicate a
144         Objective-C method definition.
145
146 2014-04-16  Darin Adler  <darin@apple.com>
147
148         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
149         https://bugs.webkit.org/show_bug.cgi?id=131735
150
151         Reviewed by Alexey Proskuryakov.
152
153         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
154         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
155         is on the right. This can be confusing since our JavaScript test framework does it the opposite
156         way, but gtest works better this way.
157
158 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
159
160         [EFL] Fix problems with the pixel dump.
161         https://bugs.webkit.org/show_bug.cgi?id=131265
162
163         Reviewed by Gyuyoung Kim.
164
165         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
166         However pixel dump codes still call deprecated functions like ewk_view_paint(),
167         which causes that nothing is drawn.
168
169         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
170         One of new functions is AcceleratedCompositingContext::extractImageData(),
171         which replaces deprecated function calls. Besides the extractImageData() is invoked by
172         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
173
174         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
175         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
176
177 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
178
179         Update LLVM export scrpt to handle the build directory being different from the
180         source directory.
181
182         Rubber stamped by Geoffrey Garen.
183
184         * Scripts/export-llvm-build:
185
186 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
187
188         Update the hyperlink to waterfall views of perf bots on build.webkit.org
189         https://bugs.webkit.org/show_bug.cgi?id=131695
190
191         Reviewed by Antti Koivisto.
192
193         Updated.
194
195         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
196
197 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
198
199         [GTK] Reduce the binary size by compressing the text based web inspector resources
200         https://bugs.webkit.org/show_bug.cgi?id=121545
201
202         Reviewed by Gustavo Noronha Silva.
203
204         Compress text based files when compiling inspector resources. It
205         reduces the binary size in 3MB.
206
207         * gtk/generate-inspector-gresource-manifest.py:
208         (find_all_files_in_directory):
209         (is_compressible):
210
211 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
212
213         Remove Gtk WebKit1 tester.
214
215         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
216         results over and over as fast as it could.
217
218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
219         (WebKitBuildbot):
220
221 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
222
223         Wrong link for webkitpy tests results in dashboard popover
224         https://bugs.webkit.org/show_bug.cgi?id=131664
225
226         Reviewed by Timothy Hatcher.
227
228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
229         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
230         Use a correct link.
231
232 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
233
234         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
235
236         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
237
238         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
239         (CommitMessageForThisCommitTest):
240
241 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
242
243         Fix commit-log-editor bug revealed by r165447
244         https://bugs.webkit.org/show_bug.cgi?id=130676
245
246         Reviewed by Csaba Osztrogonác.
247
248         * Scripts/commit-log-editor:
249         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
250         Add \n before the first block too, because the longest common prefix now ends with only one newline.
251         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
252         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
253
254 2014-04-13  Darin Adler  <darin@apple.com>
255
256         userVisibleString should not try to "encode" host names
257         https://bugs.webkit.org/show_bug.cgi?id=131587
258         rdar://problem/14686849
259
260         Reviewed by Alexey Proskuryakov.
261
262         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
263
264         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
265         Coverage is tiny at this point; we could add a lot more cases!
266
267 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
268
269         Use #include instead of #import
270         https://bugs.webkit.org/show_bug.cgi?id=131604
271
272         Reviewed by Darin Adler.
273
274         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
275
276         * TestWebKitAPI/Tests/WTF/StringView.cpp:
277
278 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
279
280         Make slow-stress tests run faster by running fewer VM variants.
281
282         Rubber stamped by Geoffrey Garen.
283
284         * Scripts/run-javascriptcore-tests:
285         * Scripts/run-jsc-stress-tests:
286
287 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
288
289         [CMake] Add missing WTF unit tests
290         https://bugs.webkit.org/show_bug.cgi?id=131459
291
292         Reviewed by Martin Robinson.
293
294         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
295         that should be compiled into the TestWTF binary.
296
297 2014-04-10  Brendan Long  <b.long@cablelabs.com>
298
299         [Gtk] run-launcher doesn't work by default
300         https://bugs.webkit.org/show_bug.cgi?id=131494
301
302         Reviewed by Philippe Normand.
303
304         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
305         * Scripts/webkitdirs.pm:
306         (launcherName): Same.
307         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
308         * gtk/common.py:
309         (get_build_path.is_valid_build_directory): Same.
310         * gtk/manifest.txt: Same.
311
312 2014-04-09  Commit Queue  <commit-queue@webkit.org>
313
314         Unreviewed, rolling out r167046.
315         https://bugs.webkit.org/show_bug.cgi?id=131479
316
317         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
318         on #webkit).
319
320         Reverted changeset:
321
322         "Remove "System Font" from whitelisted DRT fonts and char
323         width calculations"
324         https://bugs.webkit.org/show_bug.cgi?id=131411
325         http://trac.webkit.org/changeset/167046
326
327 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
328
329         Remove "System Font" from whitelisted DRT fonts and char width calculations
330         https://bugs.webkit.org/show_bug.cgi?id=131411
331
332         Reviewed by Tim Horton.
333
334         Covered by existing tests.
335
336         * DumpRenderTree/mac/DumpRenderTree.mm:
337         (allowedFontFamilySet):
338
339 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
340
341         systemHiddenFontFamilySet in DRT is unnecessary
342         https://bugs.webkit.org/show_bug.cgi?id=131414
343
344         Reviewed by Tim Horton.
345
346         It doesn't seem to affect test results on my machine.
347
348         * DumpRenderTree/mac/DumpRenderTree.mm:
349         (drt_NSFontManager_availableFonts):
350         (systemHiddenFontFamilySet): Deleted.
351
352 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
353
354         [Win] Unreviewed test fix: Don't double-release BSTR.
355
356         * DumpRenderTree/win/DumpRenderTree.cpp:
357         (dump): Remove unneeded call to SysFreeString now that we are
358         using _bstr_t for this variable.
359
360 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
361
362         [Win] Various DumpRenderTree Fixes.
363         https://bugs.webkit.org/show_bug.cgi?id=131446.
364
365         Reviewed by Tim Horton.
366
367         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
368         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
369         (AccessibilityUIElement::description): Ditto.
370         (AccessibilityUIElement::helpText): Ditto.
371         (AccessibilityUIElement::intValue): Ditto.
372         (AccessibilityUIElement::isPressActionSupported): Ditto.
373         (AccessibilityUIElement::accessibilityValue): Ditto.
374         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
375         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
376         (DRTDesktopNotificationPresenter::AddRef): Ditto.
377         (DRTDesktopNotificationPresenter::Release): Ditto.
378         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
379         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
380         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
381         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
382         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
383         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
384         * DumpRenderTree/win/DumpRenderTree.cpp:
385         (dumpFrameScrollPosition): Ditto.
386         (dumpFramesAsText): Ditto.
387         (compareHistoryItems): Ditto.
388         (dumpHistoryItem): Ditto.
389         (dump): Ditto.
390         (resetDefaultsToConsistentValues): Ditto.
391         (resetWebViewToConsistentStateBeforeTesting): Ditto.
392         (runTest): Ditto.
393         (createWebViewAndOffscreenWindow): Ditto.
394         * DumpRenderTree/win/EditingDelegate.cpp:
395         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
396         (EditingDelegate::AddRef): Ditto.
397         (EditingDelegate::Release): Ditto.
398         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
399         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
400         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
401         (EditingDelegate::shouldInsertNode): Ditto.
402         (EditingDelegate::shouldInsertText): Ditto.
403         (EditingDelegate::shouldDeleteDOMRange): Ditto.
404         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
405         (EditingDelegate::shouldApplyStyle): Ditto.
406         (EditingDelegate::shouldChangeTypingStyle): Ditto.
407         (EditingDelegate::doPlatformCommand): Ditto.
408         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
409         (EditingDelegate::webViewDidChange): Ditto.
410         (EditingDelegate::webViewDidEndEditing): Ditto.
411         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
412         (EditingDelegate::webViewDidChangeSelection): Ditto.
413         (EditingDelegate::checkSpellingOfString): Ditto.
414         * DumpRenderTree/win/FrameLoadDelegate.cpp:
415         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
416         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
417         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
418         (FrameLoadDelegate::AddRef): Ditto.
419         (FrameLoadDelegate::Release): Ditto.
420         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
421         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
422         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
423         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
424         (FrameLoadDelegate::didReceiveTitle): Ditto.
425         (FrameLoadDelegate::didChangeIcons): Ditto.
426         (delegatesWithDelayedWork): Ditto.
427         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
428         (FrameLoadDelegate::didFailLoadWithError): Ditto.
429         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
430         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
431         (FrameLoadDelegate::willCloseFrame): Ditto.
432         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
433         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
434         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
435         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
436         (FrameLoadDelegate::didRunInsecureContent): Ditto.
437         * DumpRenderTree/win/FrameLoadDelegate.h:
438         * DumpRenderTree/win/HistoryDelegate.cpp:
439         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
440         (HistoryDelegate::updateHistoryTitle): Ditto.
441         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
442         * DumpRenderTree/win/PolicyDelegate.cpp:
443         (dumpPath):
444         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
445         (PolicyDelegate::AddRef): Ditto.
446         (PolicyDelegate::Release): Ditto.
447         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
448         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
449         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
450         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
451         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
452         (ResourceLoadDelegate::AddRef): Ditto.
453         (ResourceLoadDelegate::Release): Ditto.
454         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
455         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
456         (ResourceLoadDelegate::willSendRequest): Ditto.
457         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
458         (ResourceLoadDelegate::didReceiveResponse): Ditto.
459         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
460         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
461         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
462         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
463         (TestRunner::setUserStyleSheetLocation): Ditto.
464         (TestRunner::execCommand): Ditto.
465         (TestRunner::overridePreference): Ditto.
466         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
467         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
468         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
469         (TextInputController::insertText): Ditto.
470         * DumpRenderTree/win/UIDelegate.cpp:
471         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
472         (UIDelegate::AddRef): Ditto.
473         (UIDelegate::Release): Ditto.
474         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
475         (UIDelegate::trackCustomPopupMenu): Ditto.
476         (UIDelegate::registerUndoWithTarget): Ditto.
477         (UIDelegate::removeAllActionsWithTarget): Ditto.
478         (UIDelegate::setActionTitle): Ditto.
479         (UIDelegate::undo): Ditto.
480         (UIDelegate::redo): Ditto.
481         (UIDelegate::canUndo): Ditto.
482         (UIDelegate::canRedo): Ditto.
483         (UIDelegate::printFrame): Ditto.
484         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
485         (UIDelegate::webViewHeaderHeight): Ditto.
486         (UIDelegate::webViewFooterHeight): Ditto.
487         (UIDelegate::drawHeaderInRect): Ditto.
488         (UIDelegate::drawFooterInRect): Ditto.
489         (UIDelegate::webViewPrintingMarginRect): Ditto.
490         (UIDelegate::canRunModal): Ditto.
491         (UIDelegate::createModalDialog): Ditto.
492         (UIDelegate::runModal): Ditto.
493         (UIDelegate::isMenuBarVisible): Ditto.
494         (UIDelegate::setMenuBarVisible): Ditto.
495         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
496         (UIDelegate::paintCustomScrollbar): Ditto.
497         (UIDelegate::paintCustomScrollCorner): Ditto.
498         (UIDelegate::setFrame): Ditto.
499         (UIDelegate::webViewFrame): Ditto.
500         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
501         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
502         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
503         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
504         (UIDelegate::webViewAddMessageToConsole): Ditto.
505         (UIDelegate::doDragDrop): Ditto.
506         (UIDelegate::webViewGetDlgCode): Ditto.
507         (UIDelegate::createWebViewWithRequest): Ditto.
508         (UIDelegate::webViewClose): Ditto.
509         (UIDelegate::webViewFocus): Ditto.
510         (UIDelegate::webViewUnfocus): Ditto.
511         (UIDelegate::webViewPainted): Ditto.
512         (UIDelegate::exceededDatabaseQuota): Ditto.
513         (UIDelegate::embeddedViewWithArguments): Ditto.
514         (UIDelegate::webViewClosing): Ditto.
515         (UIDelegate::webViewSetCursor): Ditto.
516         (UIDelegate::webViewDidInvalidate): Ditto.
517         (UIDelegate::setStatusText): Ditto.
518         (UIDelegate::desktopNotificationsDelegate): Ditto.
519         (UIDelegate::drawBackground): Ditto.
520         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
521         (UIDelegate::didPressMissingPluginButton): Ditto.
522         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
523         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
524         (LoadHTMLStringItem::invoke): Ditto.
525         (ScriptItem::invoke): Ditto.
526
527 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
528
529         Stylechecker: False positive on inline asm code.
530         https://bugs.webkit.org/show_bug.cgi?id=130570
531
532         Reviewed by Csaba Osztrogonác.
533
534         Disable stylechecking in asm blocks.
535
536         * Scripts/webkitpy/style/checkers/cpp.py:
537         (process_line):
538         (_InlineASMState):
539         (_InlineASMState.__init__):
540         (_InlineASMState.process_line):
541         (_InlineASMState.isInside):
542         (_process_lines):
543         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
544         (WebKitStyleTest.test_member_initialization_list):
545
546 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
547
548         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
549         https://bugs.webkit.org/show_bug.cgi?id=131029
550
551         Reviewed by Philippe Normand.
552
553         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
554         tests and remove the getWebKit1TestResoucesDir() method.
555
556         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
557         (testDownloadLocalFile): Use Test::getResourcesDir().
558         (testDownloadLocalFileError): Ditto.
559         (serverCallback): Ditto.
560         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
561         (serverCallback): Ditto.
562         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
563         (httpServerCallback): Ditto.
564         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
565         (serverCallback): Ditto.
566         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
567         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
568         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
569         (Test::getWebKit1TestResoucesDir): Deleted.
570
571 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
572
573         [WK2] HTTP authentication regression tests fail
574         https://bugs.webkit.org/show_bug.cgi?id=81627
575         <rdar://problem/11079296>
576
577         Reviewed by Anders Carlsson.
578
579         * WebKitTestRunner/TestController.h:
580         * WebKitTestRunner/TestController.cpp:
581         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
582         to pageLoaderClient structure.
583         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
584         for password based authentication (we do get server trust challenges on some tests,
585         which WKTR can't handle).
586         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
587         calls won't be made, at least on CFNetwork based platforms.
588         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
589         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
590         make sense to associate auth requests with individual resources - there can be
591         multiple resources loading at once from the same protection space, so WebKit1 API
592         that had a resource identifier was inherently racy.
593
594 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
595
596         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
597         https://bugs.webkit.org/show_bug.cgi?id=131427
598
599         Reviewed by Gyuyoung Kim.
600
601         Since r166973, font path was changed.
602
603         * DumpRenderTree/PlatformEfl.cmake:
604         * WebKitTestRunner/PlatformEfl.cmake:
605
606 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
607
608         Fix the build-jsc build
609         https://bugs.webkit.org/show_bug.cgi?id=131410
610
611         Reviewed by Michael Saboff.
612
613         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
614         WTF depends on it.
615
616 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
617
618         [GTK] Remove WebKit1 unit tests
619         https://bugs.webkit.org/show_bug.cgi?id=131359
620
621         Reviewed by Anders Carlsson.
622
623         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
624         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
625         they were inadvertently left in http://trac.webkit.org/changeset/166504.
626
627         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
628         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
629         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
630         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
631         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
632         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
633         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
634         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
635         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
636         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
637         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
638         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
639         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
640         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
641         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
642         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
643         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
644         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
645         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
646         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
647         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
648         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
649         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
650         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
651         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
652         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
653         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
654         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
655         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
656         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
657         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
658         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
659         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
660         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
661         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
662         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
663         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
664         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
665
666 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
667
668         Unreviewed gardening (Take 2): Prevent users from attempting
669         to build with known invalid cURL. 
670
671         * Scripts/webkitdirs.pm:
672         (checkInstalledTools): Check for 7.34.0 (the broken version), not
673         7.33.0 (the known good version).
674
675 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
676
677         [GTK] Remove DumpRenderTree and GtkLauncher
678         https://bugs.webkit.org/show_bug.cgi?id=131373
679
680         Reviewed by Andreas Kling.
681
682         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
683         no longer necessary now that WebKit1 GTK+ will be removed.
684
685         * CMakeLists.txt:
686         * DumpRenderTree/PlatformGTK.cmake: Removed.
687         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
688         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
689         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
690         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
691         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
692         * DumpRenderTree/gtk/EventSender.cpp: Removed.
693         * DumpRenderTree/gtk/EventSender.h: Removed.
694         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
695         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
696         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
697         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
698         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
699         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
700         * DumpRenderTree/gtk/TextInputController.h: Removed.
701         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
702         * GtkLauncher/CMakeLists.txt: Removed.
703         * GtkLauncher/LauncherInspectorWindow.c: Removed.
704         * GtkLauncher/LauncherInspectorWindow.h: Removed.
705         * GtkLauncher/main.c: Removed.
706         * GtkLauncher/simple.svg: Removed.
707         * GtkLauncher/text.html: Removed.
708         * WebKitTestRunner/PlatformGTK.cmake:
709         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
710         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
711         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
712
713 2014-04-08  Mark Rowe  <mrowe@apple.com>
714
715         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
716         <https://webkit.org/b/131388> / <rdar://problem/16291687>
717
718         Reviewed by Alexey Proskuryakov.
719
720         * Scripts/webkitdirs.pm:
721         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
722         (execMacWebKitAppForDebugging): Ditto.
723
724 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
725
726         Build bmalloc on iOS too
727         https://bugs.webkit.org/show_bug.cgi?id=131381
728
729         Reviewed by Andreas Kling.
730
731         * Scripts/build-webkit:
732
733 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
734
735         Unreviewed gardening: Prevent users from attempting
736         to build with known invalid cURL.
737
738         * Scripts/webkitdirs.pm:
739         (checkInstalledTools): Block build attempts with bad
740         Cygwin tool set.
741
742 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
743
744         Build bmalloc on Mac
745         https://bugs.webkit.org/show_bug.cgi?id=131333
746
747         Reviewed by Mark Rowe.
748
749         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
750         (Note: Just testing Mac is not good enough because in this
751         script 'Mac' means 'Mac or iOS'.)
752
753 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
754
755         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
756         https://bugs.webkit.org/show_bug.cgi?id=130951
757
758         Reviewed by Geoffrey Garen.
759
760         * Scripts/run-javascriptcore-tests:
761
762 2014-04-06  Darin Adler  <darin@apple.com>
763
764         Rework CSS calc logic, fixing some reference count mistakes in Length
765         https://bugs.webkit.org/show_bug.cgi?id=131280
766
767         Reviewed by Andreas Kling.
768
769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
770         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
771
772 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
773
774         Enable WEB_REPLAY for PLATFORM(MAC)
775         https://bugs.webkit.org/show_bug.cgi?id=130700
776
777         Reviewed by Timothy Hatcher.
778
779         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
780
781 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
782
783         [CMake] Include X11's include dirs in TestNetscapePlugin
784         https://bugs.webkit.org/show_bug.cgi?id=131270
785
786         Reviewed by Martin Robinson.
787
788         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
789         TestNetscapePlugin includes WebCore code that includes X headers.
790
791 2014-04-05  David Kilzer  <ddkilzer@apple.com>
792
793         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
794         <http://webkit.org/b/130986>
795
796         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
797         prefix to TileCache class names in exception list.
798
799 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
800
801         [GTK] kill-old-processes should kill dbus-daemon processes
802         https://bugs.webkit.org/show_bug.cgi?id=127352
803
804         Reviewed by Martin Robinson.
805
806         * BuildSlaveSupport/kill-old-processes:
807         (main):
808
809 2014-04-04  Andres Gomez  <agomez@igalia.com>
810
811         [Win] Update obsolete packages in cygwin
812         https://bugs.webkit.org/show_bug.cgi?id=126264
813
814         Reviewed by Brent Fulgham.
815
816         Removed "apache" and "minires" as the first has been replaced by
817         "lighttpd" and the second is now integrated into
818         "cygwin". Replaced the transitional and now obsolete "gcc" package
819         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
820         since the newer version available is "2.7.3" which breaks the
821         build due to some funniness with environment variable handling.
822
823         * CygwinDownloader/cygwin-downloader.py:
824         * CygwinDownloader/cygwin-downloader.zip:
825
826 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
827
828         check-webkit-style: Improve warnings on Objective-C @property syntax
829         https://bugs.webkit.org/show_bug.cgi?id=131200
830
831         Reviewed by Dan Bernstein.
832
833         * Scripts/webkitpy/style/checkers/cpp.py:
834         (check_spacing):
835         (CppChecker):
836         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
837         (CppStyleTest.test_spacing_in_objective_c_properties):
838
839 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
840
841         Unreviewed. Moving my name to commiter section
842
843         * Scripts/webkitpy/common/config/contributors.json:
844
845 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
846
847         Unreviewed. Add myself as a committer.
848
849         * Scripts/webkitpy/common/config/contributors.json:
850
851 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
852
853         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
854         https://bugs.webkit.org/show_bug.cgi?id=130391
855
856         Reviewed by Gyuyoung Kim.
857
858         Change the implementation of the zoom functionality from ewk_view_scale_set
859         to ewk_view_page_zoom_set.
860
861         * MiniBrowser/efl/main.c:
862
863 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
864
865         [webkitpy] perf profiler does not understand --call-graph argument
866         https://bugs.webkit.org/show_bug.cgi?id=131132
867
868         Reviewed by Ryosuke Niwa.
869
870         New versions of perf profiler have changed the argument from --call-graph to -g.
871
872         * Scripts/webkitpy/common/system/profiler.py:
873         (Perf.wrapper_arguments): Use -g instead of --call-graph.
874         * Scripts/webkitpy/port/driver_unittest.py:
875         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
876
877 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
878
879         Add EFL WK2 performance bot to build.webkit.org
880         https://bugs.webkit.org/show_bug.cgi?id=131034
881
882         Fix after r166707, use "Perf" instead of "perf" for consistency.
883
884         Reviewed by Csaba Osztrogonác.
885
886         * BuildSlaveSupport/build.webkit.org-config/config.json:
887
888 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
889
890         Add EFL WK2 performance bot to build.webkit.org
891         https://bugs.webkit.org/show_bug.cgi?id=131034
892
893         Reviewed by Csaba Osztrogonác.
894
895         * BuildSlaveSupport/build.webkit.org-config/config.json:
896
897 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
898
899         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
900         https://bugs.webkit.org/show_bug.cgi?id=131151
901
902         Reviewed by Gyuyoung Kim.
903
904         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
905         (TouchEventInfo::TouchEventInfo):
906         (sendTouchEvent):
907         (addTouchPointCallback):
908         (updateTouchPointCallback):
909         (cancelTouchPointCallback):
910         (releaseTouchPointCallback):
911
912 2014-04-02  David Kilzer  <ddkilzer@apple.com>
913
914         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
915         <http://webkit.org/b/131045>
916
917         Reviewed by Daniel Bates.
918
919         * Scripts/filter-build-webkit:
920         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
921         of clang, plus debug data for all DVTAssertions.
922
923 2014-04-01  Dean Jackson  <dino@apple.com>
924
925         Load Media Controls js/css from bundle
926         https://bugs.webkit.org/show_bug.cgi?id=131086
927
928         Reviewed by Eric Carlson.
929
930         We're now putting CSS files into the bundle, so remove the test for them.
931
932         * Scripts/check-for-inappropriate-files-in-framework:
933
934 2014-04-02  Martin Hock  <mhock@apple.com>
935
936         Unify private browsing with sessions.
937         https://bugs.webkit.org/show_bug.cgi?id=130099
938
939         Reviewed by Alexey Proskuryakov.
940
941         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
942         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
943         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
944         (TestWebKitAPI::didNavigateWithNavigationData):
945         (TestWebKitAPI::didSameDocumentNavigationForFrame):
946         (TestWebKitAPI::TEST):
947
948         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
949         (TestWebKitAPI::didNavigateWithoutNavigationData):
950         (TestWebKitAPI::didNavigateWithNavigationData):
951         (TestWebKitAPI::didSameDocumentNavigationForFrame):
952         (TestWebKitAPI::TEST):
953
954 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
955
956         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
957         https://bugs.webkit.org/show_bug.cgi?id=130343
958
959         Reviewed by Gustavo Noronha Silva.
960
961         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
962         of directories on the command line and look for all appropriate files in those directories for the
963         GResource archive. Also make archive paths relative to those directories.
964         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
965         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
966
967 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
968
969         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
970         https://bugs.webkit.org/show_bug.cgi?id=131106
971
972         Reviewed by Csaba Osztrogonác.
973
974         * Scripts/webkitpy/tool/commands/download.py:
975         (AbstractRolloutPrepCommand._prepare_state):
976         * Scripts/webkitpy/tool/commands/download_unittest.py:
977         (test_prepare_rollout):
978         (test_create_rollout):
979         (test_create_rollout_resolved):
980         (test_rollout):
981
982 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
983
984         [EFL] Add option to use separate web process for new window in MiniBrowser
985         https://bugs.webkit.org/show_bug.cgi?id=130190
986
987         Reviewed by Gyuyoung Kim.
988
989         New created window (CTRL + n) will be open in separated web process.
990         This option is enabled by adding a flag (S/separate-process) with launching
991         MiniBrowser.
992
993         * MiniBrowser/efl/main.c:
994         (elm_main):
995
996 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
997
998         [GTK] Move NEWS file to a new location
999         https://bugs.webkit.org/show_bug.cgi?id=130901
1000
1001         Reviewed by Brent Fulgham.
1002
1003         * gtk/manifest.txt: Update the NEWS file path.
1004
1005 2014-04-01  Anders Carlsson  <andersca@apple.com>
1006
1007         Fix build.
1008
1009         * MiniBrowser/mac/WK2BrowserWindowController.m:
1010         (-[WK2BrowserWindowController awakeFromNib]):
1011         (-[WK2BrowserWindowController dealloc]):
1012         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1013
1014 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
1015
1016         Unreviewed test gardening.
1017
1018         * Scripts/webkitpy/port/base_unittest.py:
1019         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
1020
1021 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
1022
1023         [CSS Exclusions] Remove exclusions parsing support
1024         https://bugs.webkit.org/show_bug.cgi?id=131046
1025
1026         Reviewed by David Hyatt.
1027
1028         * Scripts/webkitperl/FeatureList.pm:
1029
1030 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1031
1032         [GTK] Remove last reference to GTK+ WK1 EWS
1033         https://bugs.webkit.org/show_bug.cgi?id=131058
1034
1035         Reviewed by Martin Robinson.
1036
1037         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
1038
1039         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
1040
1041 2014-04-01  Lucas Forschler  <lforschler@apple.com>
1042
1043         Add a 32bit JSC builder/tester.
1044         https://bugs.webkit.org/show_bug.cgi?id=131054
1045         
1046         Reviewed by Michael Saboff.
1047
1048         * BuildSlaveSupport/build.webkit.org-config/config.json:
1049         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1050         (Compile32bitJSC):
1051         (Run32bitJSCTests):
1052         (Run32bitJSCTests.countFailures):
1053         (BuildAndTest32bitJSCFactory):
1054         (BuildAndTest32bitJSCFactory.__init__):
1055
1056 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
1057
1058         [GTK] No longer build WebKit1 gtkdoc
1059         https://bugs.webkit.org/show_bug.cgi?id=130970
1060
1061         Reviewed by Anders Carlsson.
1062
1063         * gtk/common.py:
1064         (gtk_version_of_pkg_config_file): Deleted.
1065         * gtk/generate-gtkdoc:
1066         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
1067         was only applicable for WebKit1.
1068         (get_generator_for_config): No longer look for the WebKit1 configuration file.
1069
1070 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
1071
1072         [GTK] Running minibrowser with url crashes in debug build
1073         https://bugs.webkit.org/show_bug.cgi?id=130492
1074
1075         Reviewed by Martin Robinson.
1076
1077         Update "uri-scheme" test not to use invalid URIs in it, so we
1078         don't get a mistmatch when comparing the original URI stored in
1079         the test class with the one returned by the WebKitWebView.
1080
1081         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1082         (testWebContextURIScheme): Update the test.
1083
1084 2014-04-01  Mihai Tica  <mitica@adobe.com>
1085
1086         Unreviewed: Add myself as a commiter to the contributors list.
1087
1088         * Scripts/webkitpy/common/config/contributors.json:
1089
1090 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1091
1092         [EFL][WK2] Extract the control of page background out of color_set
1093         https://bugs.webkit.org/show_bug.cgi?id=127539
1094
1095         Reviewed by Gyuyoung Kim.
1096
1097         Added an option(C) to change background color.
1098
1099         * MiniBrowser/efl/main.c:
1100         (window_create):
1101         (elm_main):
1102
1103 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1104
1105         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
1106
1107         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
1108
1109 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1110
1111         Unreviewed test correction after r166530.
1112
1113         * DumpRenderTree/mac/DumpRenderTree.mm:
1114         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
1115         fine-grained setting for swipe tests. This prevents existing tests from breaking.
1116
1117 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1118
1119         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
1120         https://bugs.webkit.org/show_bug.cgi?id=130987
1121
1122         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
1123         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
1124
1125         Reviewed by Martin Robinson.
1126
1127         * BuildSlaveSupport/build.webkit.org-config/config.json:
1128
1129 2014-03-31  Dean Jackson  <dino@apple.com>
1130
1131         Remove WEB_ANIMATIONS
1132         https://bugs.webkit.org/show_bug.cgi?id=130989
1133
1134         Reviewed by Simon Fraser.
1135
1136         Remove this feature flag until we plan to implement.
1137
1138         * Scripts/webkitperl/FeatureList.pm:
1139
1140 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1141
1142         Reduced Latched Scroll Test Flakiness
1143         https://bugs.webkit.org/show_bug.cgi?id=130983
1144
1145         Reviewed by Darin Adler.
1146
1147         * DumpRenderTree/mac/DumpRenderTree.mm:
1148         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
1149         * DumpRenderTree/mac/EventSendingController.mm:
1150         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
1151         with high resolution flags turned on.
1152         * WebKitTestRunner/mac/EventSenderProxy.mm:
1153         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
1154
1155 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1156
1157         run-webkit-tests should have a --no-timeout option
1158         https://bugs.webkit.org/show_bug.cgi?id=128286
1159
1160         Reviewed by Joseph Pecoraro.
1161
1162         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1163         (Worker._run_test): Renaming _run_test_with_timeout()
1164         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
1165         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
1166         (Worker._run_test_in_this_thread):
1167         (Worker._run_test_with_timeout): Deleted.
1168         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1169         (parse_args): Added the --no-timeout option
1170
1171 2014-03-31  Samuel White  <samuel_white@apple.com>
1172
1173         AX: Need ability to get line range for text marker.
1174         https://bugs.webkit.org/show_bug.cgi?id=130906
1175
1176         Reviewed by Chris Fleizach.
1177
1178         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
1179
1180         * DumpRenderTree/AccessibilityUIElement.cpp:
1181         (lineTextMarkerRangeForTextMarkerCallback):
1182         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1183         (AccessibilityUIElement::getJSClass):
1184         * DumpRenderTree/AccessibilityUIElement.h:
1185         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1186         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1187         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1188         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1189         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1190         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1191         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1192         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1193         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1194         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1195         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1196         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1197
1198 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
1199
1200         More validation for FTL inline caches
1201         https://bugs.webkit.org/show_bug.cgi?id=130948
1202
1203         Reviewed by Geoffrey Garen.
1204
1205         * Scripts/run-jsc-stress-tests:
1206
1207 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1208
1209         [GTK] Do not run WebKit1 unit tests by default
1210         https://bugs.webkit.org/show_bug.cgi?id=130968
1211
1212         Reviewed by Martin Robinson.
1213
1214         * Scripts/run-gtk-tests:
1215         (TestRunner):
1216
1217 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
1218
1219         [GTK] Remove scripts code only applicable to autotools
1220         https://bugs.webkit.org/show_bug.cgi?id=130841
1221
1222         Reviewed by Anders Carlsson.
1223
1224         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1225         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
1226         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
1227         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
1228         * gtk/find-make-dist-errors: Removed.
1229         * gtk/generate-feature-defines-files: Removed.
1230         * gtk/manifest.txt: No longer need to consider autotools files.
1231
1232 2014-03-30  Andy Estes  <aestes@apple.com>
1233
1234         Fix two failing layout tests on Mountain Lion after r166466.
1235
1236         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1237         (-[DownloadDelegate _downloadDidStart:]):
1238
1239 2014-03-30  Andy Estes  <aestes@apple.com>
1240
1241         [Cocoa] Add an originatingWebView property to _WKDownload
1242         https://bugs.webkit.org/show_bug.cgi?id=130945
1243
1244         Reviewed by Anders Carlsson.
1245
1246         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1247         (-[DownloadDelegate _downloadDidStart:]):
1248         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
1249         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
1250         (TEST):
1251
1252 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
1253
1254         Land the stackmap register liveness glue with the uses of the liveness disabled
1255         https://bugs.webkit.org/show_bug.cgi?id=130924
1256
1257         Reviewed by Oliver Hunt.
1258
1259         * Scripts/run-jsc-stress-tests:
1260
1261 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
1262
1263         Update WebKit1.StringTruncator for Mountain Lion.
1264
1265         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
1266         due to different font metrics on 10.8.
1267
1268 2014-03-28  Darin Adler  <darin@apple.com>
1269
1270         Fix recently-introduced off-by-one error in centerTruncateToBuffer
1271         https://bugs.webkit.org/show_bug.cgi?id=130889
1272
1273         Reviewed by Alexey Proskuryakov.
1274
1275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
1276         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
1277         WebStringTruncator methods; should be good for a start. These are dependent on the
1278         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
1279
1280 2014-03-28  Martin Hock  <mhock@apple.com>
1281
1282         Unreviewed. Add myself as a committer.
1283
1284         * Scripts/webkitpy/common/config/contributors.json:
1285
1286 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
1287
1288         Remove WebKit1 GTK+ bots
1289         https://bugs.webkit.org/show_bug.cgi?id=130904
1290
1291         Reviewed by Anders Carlsson.
1292
1293         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
1294         all bots are testing WebKit2 only.
1295         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
1296         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
1297         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
1298         * Scripts/webkitpy/port/builders.py: Ditto.
1299         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
1300         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
1301
1302 2014-03-28  Timothy Hatcher  <timothy@apple.com>
1303
1304         Remove Brian Burg's apple.com email address.
1305
1306         * Scripts/webkitpy/common/config/contributors.json:
1307
1308 2014-03-28  David Kilzer  <ddkilzer@apple.com>
1309
1310         bisect-builds should print Trac 'changeset' URL if only one build is detected
1311         <http://webkit.org/b/130903>
1312
1313         Reviewed by Dan Bernstein.
1314
1315         * Scripts/bisect-builds:
1316         (printTracLink): Print a direct link to the Trac 'changeset'
1317         URL if there is only one revision in the range.
1318
1319 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1320
1321         [EFL] Bump glib version from 2.36 to 2.38 
1322         https://bugs.webkit.org/show_bug.cgi?id=130886
1323
1324         Reviewed by Csaba Osztrogonác.
1325
1326         There is a build break on EFL port when using glib 2.36 ver. To fix it,
1327         we need to bump glib version up to 2.38 as gtk port.
1328
1329         * efl/jhbuild.modules:
1330
1331 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1332
1333         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
1334
1335         Provide an implementation of WKContextHistoryClient that logs when called for tests in
1336         the globalhistory directory.
1337
1338         Reviewed by Sam Weinig.
1339
1340         * WebKitTestRunner/TestController.cpp:
1341         (WTR::TestController::TestController):
1342         (WTR::TestController::initialize): Set the history client.
1343         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
1344         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
1345         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
1346         and we don't yet have API to access the data in question.
1347         (WTR::TestController::didPerformClientRedirect):
1348         (WTR::TestController::didPerformServerRedirect):
1349         (WTR::TestController::didUpdateHistoryTitle):
1350         * WebKitTestRunner/TestController.h:
1351         (WTR::TestController::setShouldLogHistoryClientCallbacks):
1352         * WebKitTestRunner/TestInvocation.cpp:
1353         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
1354         (WTR::TestInvocation::invoke):
1355
1356 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
1357
1358         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
1359
1360         * Scripts/build-webkit:
1361         * Scripts/copy-webkitlibraries-to-product-directory:
1362
1363 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
1364
1365         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
1366         https://bugs.webkit.org/show_bug.cgi?id=130867
1367         <rdar://problem/16432456> 
1368
1369         Reviewed by Mark Hahnenberg.
1370
1371         * Scripts/build-webkit:
1372         * Scripts/copy-webkitlibraries-to-product-directory:
1373
1374 2014-03-26  Andy Estes  <aestes@apple.com>
1375
1376         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
1377         https://bugs.webkit.org/show_bug.cgi?id=130805
1378
1379         Reviewed by Dan Bernstein.
1380
1381         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1382         (-[DownloadDelegate _download:didReceiveResponse:]):
1383         (-[DownloadDelegate _downloadDidFinish:]):
1384         (runTest):
1385         (TEST):
1386         (-[FailingDownloadDelegate _downloadDidFinish:]):
1387         (-[FailingDownloadDelegate _download:didFailWithError:]):
1388         (-[FailingDownloadDelegate _downloadDidCancel:]):
1389         (-[CancelledDownloadDelegate _downloadDidStart:]):
1390         (-[CancelledDownloadDelegate _downloadDidFinish:]):
1391         (-[CancelledDownloadDelegate _download:didFailWithError:]):
1392         (-[CancelledDownloadDelegate _downloadDidCancel:]):
1393         (-[DownloadDelegate initWithSourceURL:]): Deleted.
1394         (-[DownloadDelegate sourceURL]): Deleted.
1395         (runTestWithNavigationDelegate): Deleted.
1396
1397 2014-03-26  Anders Carlsson  <andersca@apple.com>
1398
1399         Change MiniBrowser to hold on to window controllers instead of windows
1400         https://bugs.webkit.org/show_bug.cgi?id=130797
1401
1402         Reviewed by Oliver Hunt.
1403
1404         * MiniBrowser/mac/AppDelegate.h:
1405         * MiniBrowser/mac/AppDelegate.m:
1406         (-[BrowserAppDelegate init]):
1407         (-[BrowserAppDelegate newWindow:]):
1408         (-[BrowserAppDelegate browserWindowWillClose:]):
1409         (-[BrowserAppDelegate applicationWillTerminate:]):
1410         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1411
1412 2014-03-26  Commit Queue  <commit-queue@webkit.org>
1413
1414         Unreviewed, rolling out r166264.
1415         https://bugs.webkit.org/show_bug.cgi?id=130785
1416
1417         Broke some window.opener tests for WK2 Mavericks (Requested by
1418         brrian__ on #webkit).
1419
1420         Reverted changeset:
1421
1422         "Web Replay: resource unique identifiers should be unique-per-
1423         frame, not globally"
1424         https://bugs.webkit.org/show_bug.cgi?id=130632
1425         http://trac.webkit.org/changeset/166264
1426
1427 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
1428
1429         [CSS Shapes] Remove shape-inside support
1430         https://bugs.webkit.org/show_bug.cgi?id=130698
1431
1432         Reviewed by David Hyatt.
1433
1434         * Scripts/webkitperl/FeatureList.pm:
1435
1436 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
1437
1438         Unreviewed. Add myself as a committer.
1439
1440         * Scripts/webkitpy/common/config/contributors.json:
1441
1442 2014-03-26  Tomas Popela  <tpopela@redhat.com>
1443
1444         run-launcher is Perl script so use elsif and not elif
1445         https://bugs.webkit.org/show_bug.cgi?id=130771
1446
1447         Reviewed by Carlos Garcia Campos.
1448
1449         * Scripts/run-launcher:
1450
1451 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
1452
1453         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
1454         https://bugs.webkit.org/show_bug.cgi?id=130575
1455
1456         Reviewed by Mario Sanchez Prada.
1457
1458         Change ATK version to 2.11.92. Adjust current implementation.
1459
1460         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1461         (AccessibilityUIElement::intValue):
1462         (AccessibilityUIElement::minValue):
1463         (AccessibilityUIElement::maxValue):
1464         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1465         (WTR::AccessibilityUIElement::intValue):
1466         (WTR::AccessibilityUIElement::minValue):
1467         (WTR::AccessibilityUIElement::maxValue):
1468         * efl/jhbuild.modules:
1469         * gtk/jhbuild.modules:
1470
1471 2014-03-12  Philippe Normand  <pnormand@igalia.com>
1472
1473         [GTK] The gnumake package is no longer needed in jhbuild
1474         https://bugs.webkit.org/show_bug.cgi?id=130121
1475
1476         Reviewed by Martin Robinson.
1477
1478         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
1479         for a debug build cmake/system-gnumake worked just fine for me.
1480
1481         * gtk/jhbuild.modules: Removed gnumake.
1482         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
1483         * gtk/patches/make-3.82-parallel-build.patch: Removed.
1484
1485 2014-03-25  Andy Estes  <aestes@apple.com>
1486
1487         Fix a failing API test on Mountain Lion and remove temporary debug logging.
1488
1489         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1490         (-[DownloadDelegate _download:didReceiveData:]):
1491         (-[DownloadDelegate _downloadDidFinish:]):
1492
1493 2014-03-25  Brian Burg  <bburg@apple.com>
1494
1495         Web Replay: resource unique identifiers should be unique-per-frame, not globally
1496         https://bugs.webkit.org/show_bug.cgi?id=130623
1497
1498         Reviewed by Timothy Hatcher.
1499
1500         The resource loader callback dumping routines assumed that resource identifiers
1501         were globally unique. Its map of resource identifiers to URLs must also track the
1502         frame associated with the resource.
1503
1504         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1505         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
1506         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
1507         stable as long as the frame is valid.
1508         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1509         (WTR::InjectedBundlePage::willSendRequestForFrame):
1510         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1511         (WTR::InjectedBundlePage::didFinishLoadForResource):
1512         (WTR::InjectedBundlePage::didFailLoadForResource):
1513
1514 2014-03-25  Andy Estes  <aestes@apple.com>
1515
1516         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
1517
1518         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1519         (-[DownloadDelegate _download:didReceiveResponse:]):
1520         (-[DownloadDelegate _download:didReceiveData:]):
1521
1522 2014-03-25  Andy Estes  <aestes@apple.com>
1523
1524         Add some debug logging to an API test that's failing on Mountain Lion.
1525
1526         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1527         (-[DownloadDelegate _download:didReceiveResponse:]):
1528         (-[DownloadDelegate _downloadDidFinish:]):
1529
1530 2014-03-25  Anders Carlsson  <andersca@apple.com>
1531
1532         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
1533         https://bugs.webkit.org/show_bug.cgi?id=130732
1534
1535         Reviewed by Tim Horton.
1536
1537         * MiniBrowser/mac/WK2BrowserWindowController.m:
1538         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
1539
1540 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
1541
1542         [GTK] Remove the autotools build
1543         https://bugs.webkit.org/show_bug.cgi?id=130717
1544
1545         Reviewed by Anders Carlsson.
1546
1547         * DumpRenderTree/config.h: Remove references to the autotools configure file.
1548         * GNUmakefile.am: Removed.
1549         * GtkLauncher/GNUmakefile.am: Removed.
1550         * GtkLauncher/main.c: Remove references to the autotools configure file.
1551         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
1552         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
1553         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
1554         * MiniBrowser/gtk/GNUmakefile.am: Removed.
1555         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
1556         * Scripts/build-webkit: No longer handle autotools.
1557         * Scripts/run-gtk-tests: Ditto.
1558         (TestRunner._setup_testing_environment):
1559         * Scripts/run-launcher: Ditto.
1560         * Scripts/webkitdirs.pm: Ditto.
1561         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
1562         * Scripts/webkitpy/common/config/contributors.json: Ditto.
1563         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
1564         * Scripts/webkitpy/style/checker.py:
1565         * TestWebKitAPI/GNUmakefile.am: Removed.
1566         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
1567         * WebKitTestRunner/GNUmakefile.am: Removed.
1568         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
1569         * gtk/GNUmakefile.am: Removed.
1570         * gtk/common.py: Remove checks for the autotools build.
1571         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
1572
1573 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
1574
1575         prepare-ChangeLog throws false positive warnings for modified files.
1576         https://bugs.webkit.org/show_bug.cgi?id=130687
1577
1578         Reviewed by Darin Adler.
1579
1580         * Scripts/prepare-ChangeLog:
1581         (originalFile): Ignore git commit paremeter.
1582         We don't need this to get the unmodified file.
1583         (extractLineRangeBeforeChange):
1584         Simplify the if statement. Follow-up after r166189.
1585
1586 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
1587
1588         [EFL] Add ARM64 build support
1589         https://bugs.webkit.org/show_bug.cgi?id=130506
1590
1591         Rubber stamped by Gyuyoung Kim.
1592
1593         * Scripts/webkitdirs.pm:
1594         (isARM): Detect aarch64 as ARM.
1595
1596 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1597
1598         [webkitpy] Improve _parse_bug_description to recognize more descriptions
1599         https://bugs.webkit.org/show_bug.cgi?id=130137
1600
1601         Reviewed by Csaba Osztrogonác.
1602
1603         * Scripts/webkitpy/common/checkout/changelog.py:
1604         (ChangeLogEntry._parse_bug_description):
1605         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1606         (test_parse_log_entries_from_changelog):
1607         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1608         (CheckoutTest.test_commit_info_for_revision):
1609
1610 2014-03-24  Andy Estes  <aestes@apple.com>
1611
1612         Fix the iOS build of TestWebKitAPI.
1613
1614         * TestWebKitAPI/Configurations/Base.xcconfig:
1615         * TestWebKitAPI/PlatformUtilities.h:
1616
1617 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
1618
1619         Fix prepare-ChangeLog after r166156.
1620         https://bugs.webkit.org/show_bug.cgi?id=130674
1621
1622         Reviewed by Darin Adler.
1623
1624         * Scripts/prepare-ChangeLog:
1625         (generateFunctionLists):
1626         (extractLineRangeBeforeChange):
1627
1628 2014-03-24  Andy Estes  <aestes@apple.com>
1629
1630         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
1631         https://bugs.webkit.org/show_bug.cgi?id=129322
1632
1633         Reviewed by Anders Carlsson.
1634
1635         Add an API test suite for _WKDownload.
1636
1637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1638         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
1639         (-[DownloadDelegate initWithSourceURL:]):
1640         (-[DownloadDelegate sourceURL]):
1641         (-[DownloadDelegate _downloadDidStart:]):
1642         (-[DownloadDelegate _download:didReceiveResponse:]):
1643         (-[DownloadDelegate _download:didReceiveData:]):
1644         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1645         (-[DownloadDelegate _downloadDidFinish:]):
1646         (TEST):
1647         (runTestWithNavigationDelegate):
1648         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1649         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1650
1651 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
1652
1653         filter-build-webkit: reduce unfiltered output
1654         https://bugs.webkit.org/show_bug.cgi?id=130485
1655
1656         Reviewed by Brent Fulgham.
1657
1658         * Scripts/filter-build-webkit:
1659         (shouldIgnoreLine):
1660
1661 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
1662
1663         prepare-ChangeLog should list functions that have been removed too.
1664         https://bugs.webkit.org/show_bug.cgi?id=130508
1665
1666         Reviewed by Darin Adler.
1667
1668         The prepare-ChangeLog does not list the deleted functions in the Changelog.
1669         We have to read the functions and the line ranges of them from the source
1670         before the change, then search for overlaps between them and the changed
1671         line ranges from diff.
1672
1673         * Scripts/prepare-ChangeLog:
1674         (originalFile): Get original source command.
1675         (generateFunctionLists): Collect deleted functions too.
1676         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
1677         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
1678         deleted functions ranges too.
1679         (extractLineRange): Renamed to extractLineRangeAfterChange.
1680
1681 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
1682
1683         Move all EFL typedefs into EflTypedefs.h.
1684         https://bugs.webkit.org/show_bug.cgi?id=130511
1685
1686         Reviewed by Gyuyoung Kim.
1687
1688         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
1689         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
1690         * WebKitTestRunner/PlatformWebView.h: Ditto.
1691
1692 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
1693
1694         Don't flush compositing layers within FrameView::willPaintContents()
1695         https://bugs.webkit.org/show_bug.cgi?id=130627
1696         <rdar://problem/16368869>
1697
1698         Reviewed by Sam Weinig.
1699         
1700         Fix DRT to correctly render tests with layers now that FrameView::paintContents
1701         does not flush.
1702         
1703         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
1704         into an explicit function called before dumping. 
1705         
1706         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
1707         are flushed to CA. They will be pushed to the window by snapshotting.
1708
1709         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1710         Fix weird path to IOKit.framework.
1711         * DumpRenderTree/mac/DumpRenderTree.mm:
1712         (updateDisplay):
1713         (dump):
1714         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1715         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
1716         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
1717
1718 2014-03-21  David Kilzer  <ddkilzer@apple.com>
1719
1720         fix-blink-patch: tool to fix up renamed directory paths in Blink
1721         <http://webkit.org/b/130609>
1722
1723         Reviewed by Ryosuke Niwa.
1724
1725         Usage: cat blink.patch | fix-blink-patch | svn-apply
1726
1727         * Scripts/fix-blink-patch: Added.
1728
1729 2014-03-21  Darin Adler  <darin@apple.com>
1730
1731         Remove use of deprecatedCharacters in WebKit API tests
1732         https://bugs.webkit.org/show_bug.cgi?id=130602
1733
1734         Reviewed by Antti Koivisto.
1735
1736         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1737         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
1738         (TestWebKitAPI::expectEmpty): Use characters8.
1739         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
1740
1741         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1742         Removed the test that is entirely about 16-bit conversion since that's basically a test of
1743         the deprecatedCharacters function itself, which we are about to delete.
1744
1745 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1746
1747         [webkitpy] Fix has_valid_reviewer()
1748         https://bugs.webkit.org/show_bug.cgi?id=130589
1749
1750         Reviewed by Csaba Osztrogonác.
1751
1752         * Scripts/webkitpy/common/checkout/changelog.py:
1753         (ChangeLogEntry.has_valid_reviewer):
1754         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1755         (test_has_valid_reviewer):
1756         * Scripts/webkitpy/common/config/committers.py:
1757         (CommitterList._reviewer_only):
1758         (CommitterList.committer_by_name):
1759         (CommitterList.reviewer_by_email):
1760         (CommitterList):
1761         (CommitterList.reviewer_by_name):
1762
1763 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1764
1765         Add cache support for jhbuild
1766         https://bugs.webkit.org/show_bug.cgi?id=130588
1767
1768         Reviewed by Csaba Osztrogonác.
1769
1770         * jhbuild/jhbuildrc_common.py:
1771         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
1772
1773 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1774
1775         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
1776         https://bugs.webkit.org/show_bug.cgi?id=130504
1777
1778         Reviewed by Martin Robinson.
1779
1780         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
1781         CMake if not specified.
1782         * Scripts/webkitdirs.pm:
1783         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
1784         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
1785
1786 2014-03-21  Andreas Kling  <akling@apple.com>
1787
1788         RetainPtr API test should use CFArray instead of CFString for testing.
1789         <rdar://problem/16384899>
1790
1791         Unreviewed bot fix.
1792
1793         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1794         (TestWebKitAPI::TEST):
1795         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1796         (TestWebKitAPI::TEST):
1797
1798 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
1799
1800         Move to using std::unique_ptr for EFL objects.
1801         https://bugs.webkit.org/show_bug.cgi?id=129853
1802
1803         Reviewed by Gyuyoung Kim.
1804
1805         EflUniquePtr is a template alias of std::unique_ptr
1806         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
1807         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
1808
1809         * DumpRenderTree/efl/DumpRenderTree.cpp:
1810         (main):
1811         * ImageDiff/efl/ImageDiff.cpp:
1812         (initEfl):
1813         (main):
1814
1815 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
1816
1817         Unreviewed buildfix after r165983 for non Cocoa platforms
1818
1819         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
1820
1821         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1822         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1823         * WebKitTestRunner/TestController.cpp:
1824
1825 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
1826
1827         [GTK][CMake] Add support for building with Clang
1828         https://bugs.webkit.org/show_bug.cgi?id=130260
1829
1830         Reviewed by Martin Robinson.
1831
1832         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
1833         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
1834         included GTest framework headers.
1835         * gtk/generate-gtkdoc:
1836         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
1837         in case of using Clang since that is now set by the CMake rule.
1838
1839 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
1840
1841         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
1842         https://bugs.webkit.org/show_bug.cgi?id=130476
1843
1844         Reviewed by Anders Carlsson.
1845         
1846         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
1847
1848         * MiniBrowser/mac/WK1BrowserWindowController.m:
1849         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1850         Remove log.
1851         * MiniBrowser/mac/WK2BrowserWindowController.m:
1852         (-[WK2BrowserWindowController awakeFromNib]):
1853         (-[WK2BrowserWindowController validateMenuItem:]):
1854         (-[WK2BrowserWindowController reload:]):
1855         Hook up reload.
1856         (-[WK2BrowserWindowController toggleZoomMode:]):
1857         (-[WK2BrowserWindowController resetZoom:]):
1858         (-[WK2BrowserWindowController canResetZoom]):
1859         (-[WK2BrowserWindowController currentZoomFactor]):
1860         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
1861         (-[WK2BrowserWindowController canZoomIn]):
1862         (-[WK2BrowserWindowController canZoomOut]):
1863
1864 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
1865
1866         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
1867         https://bugs.webkit.org/show_bug.cgi?id=130463
1868
1869         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
1870
1871 2014-03-18  Samuel White  <samuel_white@apple.com>
1872
1873         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
1874         https://bugs.webkit.org/show_bug.cgi?id=130250
1875
1876         Reviewed by Chris Fleizach.
1877
1878         Added ability to toggle enhanced accessibility on and off to support tests that require it.
1879
1880         * DumpRenderTree/AccessibilityController.cpp:
1881         (enableEnhancedAccessibilityCallback):
1882         (getEnhancedAccessibilityEnabledCallback):
1883         (AccessibilityController::getJSClass):
1884         * DumpRenderTree/AccessibilityController.h:
1885         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1886         (AccessibilityController::enableEnhancedAccessibility):
1887         (AccessibilityController::enhancedAccessibilityEnabled):
1888         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1889         (AccessibilityController::enableEnhancedAccessibility):
1890         (AccessibilityController::enhancedAccessibilityEnabled):
1891         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1892         (AccessibilityController::enableEnhancedAccessibility):
1893         (AccessibilityController::enhancedAccessibilityEnabled):
1894         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1895         (AccessibilityController::enableEnhancedAccessibility):
1896         (AccessibilityController::enhancedAccessibilityEnabled):
1897         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1898         (WTR::AccessibilityController::enableEnhancedAccessibility):
1899         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
1900         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1901         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1902
1903 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
1904
1905         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
1906         yet).
1907
1908         * Scripts/webkitpy/common/config/contributors.json:
1909
1910 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
1911
1912         Web Inspector: Remove stale ReportMemoryUsagePlugin
1913         https://bugs.webkit.org/show_bug.cgi?id=130405
1914
1915         Reviewed by Andreas Kling.
1916
1917         This clang plugin looks like it was used for the old Inspector memory
1918         instrumentation that was removed. So the tool can be removed.
1919
1920         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
1921         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
1922         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
1923         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
1924
1925 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1926
1927         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
1928         https://bugs.webkit.org/show_bug.cgi?id=130220
1929
1930         Reviewed by Csaba Osztrogonác.
1931
1932         * Scripts/webkitpy/common/checkout/changelog.py:
1933         (ChangeLog.set_reviewer):
1934         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1935         (test_set_reviewer):
1936
1937 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
1938
1939         More FTL enabling.
1940
1941         Rubber stamped by Dan Bernstein.
1942
1943         * Tools/Scripts/build-webkit:
1944
1945 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
1946
1947         Renable pagination mode in WK2 MiniBrowser
1948         https://bugs.webkit.org/show_bug.cgi?id=130374
1949
1950         Reviewed by Anders Carlsson.
1951         
1952         Put the implementation of togglePaginationMode: back, and correctly
1953         enable the menu item.
1954
1955         * MiniBrowser/mac/WK2BrowserWindowController.m:
1956         (-[WK2BrowserWindowController validateMenuItem:]):
1957         (-[WK2BrowserWindowController isPaginated]):
1958         (-[WK2BrowserWindowController togglePaginationMode:]):
1959
1960 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1961
1962         Add --reset option to Tools/Scripts/set-webkit-configuration script
1963         https://bugs.webkit.org/show_bug.cgi?id=130401
1964
1965         Reviewed by Csaba Osztrogonác.
1966
1967         * Scripts/set-webkit-configuration:
1968
1969 2014-03-18  Alberto Garcia  <berto@igalia.com>
1970
1971         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
1972         https://bugs.webkit.org/show_bug.cgi?id=130388
1973
1974         Reviewed by Sergio Villar Senin.
1975
1976         * Scripts/webkitdirs.pm:
1977         (shouldRemoveCMakeCache): make sure that the build directory
1978         exists before attempting to create a file in it.
1979
1980 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
1981
1982         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
1983         https://bugs.webkit.org/show_bug.cgi?id=130336
1984
1985         Reviewed by Gyuyoung Kim.
1986
1987         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
1988         requires a space between literal and string macro [-Wliteral-suffix]'
1989         warning treated as error.
1990
1991         This patch applies a solution from r162448 to the EFL port.
1992
1993         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
1994         * efl/jhbuild.modules: Added appropriate patch section.
1995
1996 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
1997
1998         webkitpy test rebaseline.
1999
2000         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2001         (MainTest.test_default_args):
2002
2003 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2004
2005         --profile should imply --test-runner-count=1 in run-perf-tests
2006         https://bugs.webkit.org/show_bug.cgi?id=130375
2007
2008         Reviewed by Benjamin Poulain.
2009
2010         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
2011
2012         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2013         (PerfTestsRunner._parse_args): Use -1 as the default value.
2014         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
2015         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
2016         should be 1.
2017
2018 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2019
2020         Address some style nits.
2021
2022         * MiniBrowser/mac/WK2BrowserWindowController.m:
2023
2024 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2025
2026         Add transparent window support back into MiniBrowser
2027         https://bugs.webkit.org/show_bug.cgi?id=130363
2028
2029         Reviewed by Anders Carlsson.
2030         
2031         Re-enable transparent window support for WK2.
2032
2033         * MiniBrowser/mac/WK2BrowserWindowController.m:
2034         (-[WK2BrowserWindowController validateMenuItem:]):
2035         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2036
2037 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2038
2039         Fix the 32-bit build; make the open panel make a WK1 window.
2040
2041         * MiniBrowser/mac/AppDelegate.m:
2042         (-[BrowserAppDelegate openDocument:]):
2043
2044 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2045
2046         Convert MiniBrowser to use WKWebView API
2047         https://bugs.webkit.org/show_bug.cgi?id=130061
2048
2049         Reviewed by Anders Carlsson.
2050         
2051         Convert the MiniBrowser WK2 window to use WebKit2 API as much
2052         as possible.
2053         
2054         Some functionality was removed temporarily:
2055             - text zoom, page zoom
2056             - reload
2057             - pagination mode
2058             - transparent window
2059             - dumping source
2060             - window.open support
2061             - beforeUnload panel
2062             - find in page
2063
2064         * MiniBrowser/mac/AppDelegate.h:
2065         * MiniBrowser/mac/AppDelegate.m:
2066         (-[BrowserAppDelegate init]):
2067         (-[BrowserAppDelegate newWindow:]):
2068         (-[BrowserAppDelegate applicationWillTerminate:]):
2069         (-[BrowserAppDelegate openDocument:]):
2070         * MiniBrowser/mac/WK2BrowserWindowController.h:
2071         * MiniBrowser/mac/WK2BrowserWindowController.m:
2072         (-[WK2BrowserWindowController awakeFromNib]):
2073         (-[WK2BrowserWindowController dealloc]):
2074         (-[WK2BrowserWindowController fetch:]):
2075         (-[WK2BrowserWindowController validateMenuItem:]):
2076         (-[WK2BrowserWindowController reload:]):
2077         (-[WK2BrowserWindowController goBack:]):
2078         (-[WK2BrowserWindowController goForward:]):
2079         (-[WK2BrowserWindowController toggleZoomMode:]):
2080         (-[WK2BrowserWindowController resetZoom:]):
2081         (-[WK2BrowserWindowController canResetZoom]):
2082         (-[WK2BrowserWindowController dumpSourceToConsole:]):
2083         (-[WK2BrowserWindowController togglePaginationMode:]):
2084         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2085         (-[WK2BrowserWindowController windowShouldClose:]):
2086         (-[WK2BrowserWindowController applicationTerminating]):
2087         (-[WK2BrowserWindowController currentZoomFactor]):
2088         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2089         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2090         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2091         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2092         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2093         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2094         (-[WK2BrowserWindowController find:]):
2095         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2096         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
2097         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
2098         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
2099         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
2100         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2101         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2102         * WebKitTestRunner/PlatformWebView.h:
2103         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2104         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2105
2106 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
2107
2108         Use RunLoop objects through references instead of pointers
2109         https://bugs.webkit.org/show_bug.cgi?id=130313
2110
2111         Reviewed by Andreas Kling.
2112
2113         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
2114         return RunLoop reference instead of a pointer.
2115
2116         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
2117         (loadedCallback):
2118         (clickedCallback):
2119
2120 2014-03-17  Tim Horton  <timothy_horton@apple.com>
2121
2122         sort-export-file --help doesn't work (missing 'use')
2123         https://bugs.webkit.org/show_bug.cgi?id=130338
2124
2125         Reviewed by Anders Carlsson.
2126
2127         * Scripts/sort-export-file:
2128         Add a missing 'use', and fix a typo in an error message.
2129
2130 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
2131
2132         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
2133         https://bugs.webkit.org/show_bug.cgi?id=130155
2134
2135         Reviewed by Philippe Normand.
2136
2137         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
2138
2139 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2140
2141         [GTK] MiniBrowser fails to load injected bundle lib
2142         https://bugs.webkit.org/show_bug.cgi?id=130332
2143
2144         Reviewed by Anders Carlsson.
2145
2146         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
2147
2148         * MiniBrowser/gtk/main.c:
2149         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
2150         process is spawn.
2151
2152 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
2153
2154         [EFL] Enable TOUCH_SLIDER macro
2155         https://bugs.webkit.org/show_bug.cgi?id=130185
2156
2157         Reviewed by Gyuyoung Kim.
2158
2159         * Scripts/webkitperl/FeatureList.pm:
2160
2161 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
2162
2163         [GTK][CMake] Build with -fno-rtti
2164         https://bugs.webkit.org/show_bug.cgi?id=130261
2165
2166         Reviewed by Martin Robinson.
2167
2168         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
2169         defined to 0 to prevent typeid use in included GTest headers.
2170
2171 2014-03-16  Brian Burg  <bburg@apple.com>
2172
2173         Web Inspector: vended backend commands file should be generated as part of the build
2174         https://bugs.webkit.org/show_bug.cgi?id=130110
2175
2176         Reviewed by Timothy Hatcher.
2177
2178         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
2179
2180 2014-03-16  Diego Pino García  <dpino@igalia.com>
2181
2182         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
2183         https://bugs.webkit.org/show_bug.cgi?id=128999
2184
2185         Reviewed by Philippe Normand.
2186
2187         * MiniBrowser/gtk/BrowserWindow.c:
2188         (reloadPage):
2189         (reloadPageIgnoringCache):
2190         (browser_window_init):
2191
2192 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
2193
2194         [GTK] Improve ninja detection in webkitdirs.pm
2195         https://bugs.webkit.org/show_bug.cgi?id=129902
2196
2197         Reviewed by Daniel Bates.
2198
2199         * Scripts/webkitdirs.pm:
2200         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
2201         us to look for ninja-build as well.
2202
2203 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
2204
2205         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
2206         https://bugs.webkit.org/show_bug.cgi?id=130276
2207         <rdar://problem/16266927>
2208         
2209         Reviewed by Simon Fraser.
2210
2211         * BuildSlaveSupport/build-launcher-app:
2212         * BuildSlaveSupport/build-launcher-dmg:
2213         * DumpRenderTree/DumpRenderTree.h:
2214         * DumpRenderTree/DumpRenderTreePrefix.h:
2215         * DumpRenderTree/GCController.cpp:
2216         * DumpRenderTree/GCController.h:
2217         * DumpRenderTree/JavaScriptThreading.cpp:
2218         * DumpRenderTree/JavaScriptThreading.h:
2219         * DumpRenderTree/PixelDumpSupport.cpp:
2220         * DumpRenderTree/PixelDumpSupport.h:
2221         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
2222         * DumpRenderTree/TestRunner.cpp:
2223         * DumpRenderTree/TestRunner.h:
2224         * DumpRenderTree/WorkQueue.cpp:
2225         * DumpRenderTree/WorkQueue.h:
2226         * DumpRenderTree/WorkQueueItem.h:
2227         * DumpRenderTree/atk/AccessibilityCallbacks.h:
2228         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2229         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
2230         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2231         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2232         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2233         * DumpRenderTree/efl/EditingCallbacks.cpp:
2234         * DumpRenderTree/efl/EditingCallbacks.h:
2235         * DumpRenderTree/efl/EventSender.cpp:
2236         * DumpRenderTree/efl/EventSender.h:
2237         * DumpRenderTree/efl/GCControllerEfl.cpp:
2238         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2239         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2240         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2241         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2242         * DumpRenderTree/gtk/EditingCallbacks.cpp:
2243         * DumpRenderTree/gtk/EditingCallbacks.h:
2244         * DumpRenderTree/gtk/EventSender.cpp:
2245         * DumpRenderTree/gtk/EventSender.h:
2246         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2247         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2248         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
2249         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
2250         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2251         * DumpRenderTree/gtk/TextInputController.cpp:
2252         * DumpRenderTree/gtk/TextInputController.h:
2253         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
2254         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
2255         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2256         * DumpRenderTree/mac/AppleScriptController.h:
2257         * DumpRenderTree/mac/AppleScriptController.m:
2258         * DumpRenderTree/mac/CheckedMalloc.cpp:
2259         * DumpRenderTree/mac/CheckedMalloc.h:
2260         * DumpRenderTree/mac/DumpRenderTree.mm:
2261         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2262         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2263         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2264         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2265         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2266         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2267         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2268         * DumpRenderTree/mac/EditingDelegate.h:
2269         * DumpRenderTree/mac/EditingDelegate.mm:
2270         * DumpRenderTree/mac/EventSendingController.h:
2271         * DumpRenderTree/mac/EventSendingController.mm:
2272         * DumpRenderTree/mac/FrameLoadDelegate.h:
2273         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2274         * DumpRenderTree/mac/GCControllerMac.mm:
2275         * DumpRenderTree/mac/MockWebNotificationProvider.h:
2276         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2277         * DumpRenderTree/mac/NavigationController.h:
2278         * DumpRenderTree/mac/NavigationController.m:
2279         * DumpRenderTree/mac/ObjCController.h:
2280         * DumpRenderTree/mac/ObjCController.m:
2281         * DumpRenderTree/mac/ObjCPlugin.h:
2282         * DumpRenderTree/mac/ObjCPlugin.m:
2283         * DumpRenderTree/mac/ObjCPluginFunction.h:
2284         * DumpRenderTree/mac/ObjCPluginFunction.m:
2285         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2286         * DumpRenderTree/mac/PolicyDelegate.h:
2287         * DumpRenderTree/mac/PolicyDelegate.mm:
2288         * DumpRenderTree/mac/ResourceLoadDelegate.h:
2289         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2290         * DumpRenderTree/mac/TestRunnerMac.mm:
2291         * DumpRenderTree/mac/TextInputController.h:
2292         * DumpRenderTree/mac/TextInputController.m:
2293         * DumpRenderTree/mac/UIDelegate.h:
2294         * DumpRenderTree/mac/UIDelegate.mm:
2295         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2296         * DumpRenderTree/win/DRTDataObject.cpp:
2297         * DumpRenderTree/win/DRTDataObject.h:
2298         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2299         * DumpRenderTree/win/DRTDropSource.cpp:
2300         * DumpRenderTree/win/DRTDropSource.h:
2301         * DumpRenderTree/win/DraggingInfo.h:
2302         * DumpRenderTree/win/DumpRenderTree.cpp:
2303         * DumpRenderTree/win/DumpRenderTreeWin.h:
2304         * DumpRenderTree/win/EditingDelegate.cpp:
2305         * DumpRenderTree/win/EditingDelegate.h:
2306         * DumpRenderTree/win/EventSender.cpp:
2307         * DumpRenderTree/win/EventSender.h:
2308         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2309         * DumpRenderTree/win/FrameLoadDelegate.h:
2310         * DumpRenderTree/win/GCControllerWin.cpp:
2311         * DumpRenderTree/win/HistoryDelegate.cpp:
2312         * DumpRenderTree/win/HistoryDelegate.h:
2313         * DumpRenderTree/win/MD5.cpp:
2314         * DumpRenderTree/win/MD5.h:
2315         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2316         * DumpRenderTree/win/PolicyDelegate.cpp:
2317         * DumpRenderTree/win/PolicyDelegate.h:
2318         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2319         * DumpRenderTree/win/ResourceLoadDelegate.h:
2320         * DumpRenderTree/win/TestRunnerWin.cpp:
2321         * DumpRenderTree/win/TextInputController.cpp:
2322         * DumpRenderTree/win/TextInputController.h:
2323         * DumpRenderTree/win/TextInputControllerWin.cpp:
2324         * DumpRenderTree/win/UIDelegate.cpp:
2325         * DumpRenderTree/win/UIDelegate.h:
2326         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2327         * EWebLauncher/main.c:
2328         * GtkLauncher/main.c:
2329         * ImageDiff/efl/ImageDiff.cpp:
2330         * ImageDiff/gtk/ImageDiff.cpp:
2331         * MiniBrowser/gtk/main.c:
2332         * Scripts/SpacingHeuristics.pm:
2333         * Scripts/VCSUtils.pm:
2334         * Scripts/bisect-builds:
2335         * Scripts/build-dumprendertree:
2336         * Scripts/build-jsc:
2337         * Scripts/build-webkit:
2338         * Scripts/check-dom-results:
2339         * Scripts/check-for-exit-time-destructors:
2340         * Scripts/check-for-global-initializers:
2341         * Scripts/commit-log-editor:
2342         * Scripts/compare-timing-files:
2343         * Scripts/debug-minibrowser:
2344         * Scripts/debug-safari:
2345         * Scripts/do-file-rename:
2346         * Scripts/find-extra-includes:
2347         * Scripts/generate-coverage-data:
2348         * Scripts/make-script-test-wrappers:
2349         * Scripts/malloc-tree:
2350         * Scripts/old-run-webkit-tests:
2351         * Scripts/parse-malloc-history:
2352         * Scripts/report-include-statistics:
2353         * Scripts/resolve-ChangeLogs:
2354         * Scripts/run-bindings-tests:
2355         * Scripts/run-iexploder-tests:
2356         * Scripts/run-javascriptcore-tests:
2357         * Scripts/run-jsc:
2358         * Scripts/run-launcher:
2359         * Scripts/run-leaks:
2360         * Scripts/run-mangleme-tests:
2361         * Scripts/run-minibrowser:
2362         * Scripts/run-pageloadtest:
2363         * Scripts/run-regexp-tests:
2364         * Scripts/run-safari:
2365         * Scripts/run-sunspider:
2366         * Scripts/run-webkit-app:
2367         * Scripts/sampstat:
2368         * Scripts/set-webkit-configuration:
2369         * Scripts/sort-Xcode-project-file:
2370         * Scripts/sort-export-file:
2371         * Scripts/split-file-by-class:
2372         * Scripts/sunspider-compare-results:
2373         * Scripts/svn-apply:
2374         * Scripts/svn-create-patch:
2375         * Scripts/svn-unapply:
2376         * Scripts/test-webkit-scripts:
2377         * Scripts/update-javascriptcore-test-results:
2378         * Scripts/update-webkit:
2379         * Scripts/update-webkit-auxiliary-libs:
2380         * Scripts/update-webkit-dependency:
2381         * Scripts/update-webkit-localizable-strings:
2382         * Scripts/update-webkit-support-libs:
2383         * Scripts/update-webkit-wincairo-libs:
2384         * Scripts/webkit-build-directory:
2385         * Scripts/webkitdirs.pm:
2386         (installedSafariPath):
2387         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
2388         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2389         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
2390         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
2391         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2392         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2393         * Scripts/webkitperl/features.pm:
2394         * Scripts/webkitperl/httpd.pm:
2395         * Scripts/webkitpy/bindings/main.py:
2396         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2397         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2398         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2399         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2400         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2401         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2402         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2403         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2404         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2405         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
2406         * WebKitTestRunner/PixelDumpSupport.cpp:
2407         * WebKitTestRunner/PixelDumpSupport.h:
2408         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2409         * WinLauncher/WinLauncher.cpp:
2410         * WinLauncher/WinLauncher.h:
2411         * WinLauncher/stdafx.cpp:
2412         * WinLauncher/stdafx.h:
2413
2414 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
2415
2416         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
2417         https://bugs.webkit.org/show_bug.cgi?id=130265
2418
2419         Reviewed by Michael Saboff.
2420
2421         * Scripts/build-webkit:
2422         * Scripts/copy-webkitlibraries-to-product-directory:
2423
2424 2014-03-14  Landry Breuil  <landry@openbsd.org>
2425
2426         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
2427         Also allow to set MAKE in the environment.
2428         https://bugs.webkit.org/show_bug.cgi?id=129991
2429
2430         Reviewed by Andreas Kling.
2431
2432         * Scripts/webkitdirs.pm:
2433         (determineArchitecture):
2434         (determineNumberOfCPUs):
2435         (isBSD):
2436         (buildAutotoolsProject):
2437         * Scripts/webkitpy/common/system/platforminfo.py:
2438         (PlatformInfo.__init__):
2439         (PlatformInfo.is_openbsd):
2440         (PlatformInfo):
2441         (PlatformInfo.is_netbsd):
2442         (PlatformInfo._determine_os_name):
2443
2444 2014-03-14  Dean Jackson  <dino@apple.com>
2445
2446         Remove libWebKitSystemInterfaceLion.a
2447         https://bugs.webkit.org/show_bug.cgi?id=130254
2448
2449         Reviewed by Geoffrey Garen and Andreas Kling.
2450
2451         No need to copy the Lion libraries into the build.
2452
2453         * Scripts/copy-webkitlibraries-to-product-directory:
2454
2455 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2456
2457         [EFL][MiniBrowser] Revise help messages of command line parameters
2458         https://bugs.webkit.org/show_bug.cgi?id=130222
2459
2460         Reviewed by Csaba Osztrogonác.
2461
2462         Correct the default value description and make help messages to be consistent.
2463
2464         * MiniBrowser/efl/main.c:
2465
2466 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
2467
2468         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
2469         https://bugs.webkit.org/show_bug.cgi?id=129612
2470
2471         Reviewed by Darin Adler.
2472
2473         For new code use static NeverDestroyed<T> instead.
2474
2475         * DumpRenderTree/JavaScriptThreading.cpp:
2476         (javaScriptThreadsMutex):
2477         (javaScriptThreads):
2478         * DumpRenderTree/efl/EventSender.cpp:
2479         (touchPointList):
2480         (delayedEventQueue):
2481         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2482         (delegatesWithDelayedWork):
2483         * Scripts/check-for-exit-time-destructors:
2484         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
2485         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2486         (testsMap):
2487
2488 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
2489
2490         [EFL][WK2] Fix compilation warning in Minibrowser
2491         https://bugs.webkit.org/show_bug.cgi?id=130132
2492
2493         Reviewed by Csaba Osztrogonác.
2494
2495         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
2496
2497         * MiniBrowser/efl/main.c:
2498         (on_download_request):
2499
2500 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
2501
2502         FTL should support IsBlah
2503         https://bugs.webkit.org/show_bug.cgi?id=130202
2504
2505         Reviewed by Geoffrey Garen.
2506         
2507         Running existing JSRegress tests with noInline gives us coverage for these
2508         changes. Chances are, this will also give coverage for other interesting things
2509         as well.
2510
2511         * Scripts/run-jsc-stress-tests:
2512
2513 2014-03-12  Brian Burg  <bburg@apple.com>
2514
2515         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
2516         https://bugs.webkit.org/show_bug.cgi?id=129744
2517
2518         Reviewed by Timothy Hatcher.
2519
2520         * DumpRenderTree/TestRunner.cpp:
2521         (evaluateInWebInspectorCallback):
2522         * DumpRenderTree/TestRunner.h:
2523         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2524         (TestRunner::evaluateInWebInspector):
2525         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2526         (TestRunner::evaluateInWebInspector):
2527         * DumpRenderTree/mac/TestRunnerMac.mm:
2528         (TestRunner::evaluateInWebInspector):
2529         * DumpRenderTree/win/TestRunnerWin.cpp:
2530         (TestRunner::evaluateInWebInspector):
2531         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2532         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2533         (WTR::TestRunner::evaluateInWebInspector):
2534         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2535
2536 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2537
2538         [GTK] build-webkit shouldn't show error message when ninja isn't installed
2539         https://bugs.webkit.org/show_bug.cgi?id=130129
2540
2541         Reviewed by Csaba Osztrogonác.
2542
2543         * Scripts/webkitdirs.pm:
2544         (canUseNinja): Redirecting stderr to /dev/null
2545
2546 2014-03-13  Andres Gomez  <agomez@igalia.com>
2547
2548         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
2549         https://bugs.webkit.org/show_bug.cgi?id=130092
2550
2551         Reviewed by Csaba Osztrogonác.
2552
2553         Added "python-dev" as dependency for deb based distros. It is
2554         already present for rpm based distros. This dependency will allow
2555         libxml2 to generate its python bindings, needed by gtk-doc.
2556
2557         * gtk/install-dependencies:
2558
2559 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2560
2561         Unreviewed. Fix GTK+ cmake build after r165488.
2562
2563         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
2564
2565 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2566
2567         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
2568         https://bugs.webkit.org/show_bug.cgi?id=130014
2569
2570         Reviewed by Martin Robinson.
2571
2572         Include cmake or autotools config header.
2573
2574         * MiniBrowser/gtk/BrowserDownloadsBar.c:
2575         * MiniBrowser/gtk/BrowserSearchBar.c:
2576         * MiniBrowser/gtk/BrowserWindow.c:
2577         * MiniBrowser/gtk/main.c:
2578
2579 2014-03-12  Commit Queue  <commit-queue@webkit.org>
2580
2581         Unreviewed, rolling out r165471.
2582         https://bugs.webkit.org/show_bug.cgi?id=130139
2583
2584         Didn't really fix the issue and broke another bot (Requested
2585         by mrobinson on #webkit).
2586
2587         Reverted changeset:
2588
2589         "[CMake] Newer versions of CMake cannot find older versions of
2590         Freetype"
2591         https://bugs.webkit.org/show_bug.cgi?id=130107
2592         http://trac.webkit.org/changeset/165471
2593
2594 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
2595
2596         It should be possible to build WebKit with FTL on iOS
2597         https://bugs.webkit.org/show_bug.cgi?id=130116
2598
2599         Reviewed by Dan Bernstein.
2600
2601         * Scripts/build-webkit:
2602         * Scripts/copy-webkitlibraries-to-product-directory:
2603
2604 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
2605
2606         [Win] Remove use of QTSDK
2607         https://bugs.webkit.org/show_bug.cgi?id=130049
2608
2609         Reviewed by Darin Adler.
2610
2611         * DumpRenderTree/win/DumpRenderTree.cpp:
2612         (initialize): Remove QuickTime code.
2613         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
2614         building QTMovieWin.
2615
2616 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
2617
2618         [GTK][CMAKE] Too verbose build output
2619         https://bugs.webkit.org/show_bug.cgi?id=130076
2620
2621         Reviewed by Carlos Garcia Campos.
2622
2623         Instead of building with cmake --build which isn't smart about pretty printing and
2624         colors, we build with a script which calls the proper build command.
2625
2626         * Scripts/webkitdirs.pm:
2627         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
2628         the CMake configuration pass.
2629
2630 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
2631
2632         [CMake] Newer versions of CMake cannot find older versions of Freetype
2633         https://bugs.webkit.org/show_bug.cgi?id=130107
2634
2635         Reviewed by Gustavo Noronha Silva.
2636
2637         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
2638         to CMake during jhbuild initialization.
2639
2640 2014-03-12  Zalan Bujtas  <zalan@apple.com>
2641
2642         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
2643         https://bugs.webkit.org/show_bug.cgi?id=129961
2644
2645         Reviewed by Simon Fraser.
2646
2647         Now scaled content can go through the window capturing mechanism too for compositing content.
2648         AppleMagnifiedMode is redundant.
2649
2650         * DumpRenderTree/mac/DumpRenderTree.mm:
2651         (setDefaultsToConsistentValuesForTesting):
2652         (runTest):
2653         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2654         (createBitmapContextFromWebView):
2655         * WebKitTestRunner/PlatformWebView.h:
2656         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2657         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2658         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2659         (WTR::PlatformWebView::didInitializeClients):
2660         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2661         (WTR::PlatformWebView::forceWindowFramesChanged):
2662         * WebKitTestRunner/mac/main.mm:
2663         (setDefaultsToConsistentValuesForTesting):
2664
2665 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
2666
2667         Unreviewed. Add myself as a committer.
2668
2669         * Scripts/webkitpy/common/config/contributors.json:
2670
2671 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
2672
2673         Unreviewed build fix on the EFL port when used lower version of ATK
2674
2675         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2676         (WTR::AccessibilityUIElement::y): Fixed typo.
2677
2678 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
2679
2680         Some images are blank in the rebaseline server UI
2681         https://bugs.webkit.org/show_bug.cgi?id=130104
2682
2683         Reviewed by Tim Horton.
2684
2685         Let the server check for images in the 'retries' directory
2686         if it can't find an image otherwise.
2687
2688         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2689         (RebaselineHTTPRequestHandler.test_result):
2690
2691 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2692
2693         [GTK][CMake] --update-gtk has no effect
2694         https://bugs.webkit.org/show_bug.cgi?id=130088
2695
2696         Reviewed by Philippe Normand.
2697
2698         * Scripts/webkitdirs.pm:
2699         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
2700         as an argument.
2701
2702 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
2703
2704         Add "System Font" to the list of whitelisted DRT fonts
2705         https://bugs.webkit.org/show_bug.cgi?id=130046
2706
2707         Reviewed by Darin Adler.
2708
2709         * DumpRenderTree/mac/DumpRenderTree.mm:
2710         (allowedFontFamilySet):
2711         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2712
2713 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
2714
2715         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
2716         https://bugs.webkit.org/show_bug.cgi?id=130064
2717
2718         Reviewed by Philippe Normand.
2719
2720         * efl/jhbuildrc: Remove duplicated code.
2721         * gtk/jhbuildrc: Remove duplicated code.
2722         * jhbuild/jhbuildrc_common.py:
2723         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
2724         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
2725         and is apparently necessary for GTK+.
2726
2727 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
2728
2729         check-webkit-style failed to complain about missing braces
2730         https://bugs.webkit.org/show_bug.cgi?id=34189
2731
2732         Reviewed by Ryosuke Niwa.
2733
2734         * Scripts/webkitpy/style/checkers/cpp.py:
2735         (check_braces):
2736         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2737         (WebKitStyleTest.test_braces):
2738
2739 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
2740
2741         Remove Qt cruft from style checker.
2742         https://bugs.webkit.org/show_bug.cgi?id=130085
2743
2744         Reviewed by Csaba Osztrogonác.
2745
2746         There is no 'foreach' keyword in c++. That was a Qt feature
2747         added in: http://trac.webkit.org/changeset/46113
2748         Qt was removed from WebKit, so we should remove the checks
2749         of this keyword from check-webkit-style scripts.
2750
2751         * Scripts/webkitpy/style/checkers/cpp.py:
2752         (check_spacing_for_function_call):
2753         (check_spacing):
2754         (check_braces):
2755         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2756         (CppStyleTest.test_mismatching_spaces_in_parens):
2757         (CppStyleTest.test_spacing_for_fncall):
2758         (WebKitStyleTest.test_braces):
2759
2760 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
2761
2762         [GTK] update-webkitgtk-libs needs itstool
2763         https://bugs.webkit.org/show_bug.cgi?id=130082
2764
2765         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
2766         itstool is a dependency of building gtk-doc from version 1.19, so it should
2767         be added to Tools/gtk/install-dependencies script, too.
2768
2769         Reviewed by Philippe Normand.
2770
2771         * gtk/install-dependencies:
2772
2773 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2774
2775         webkitbot rollout ChangeLogs should be nicer
2776         https://bugs.webkit.org/show_bug.cgi?id=122654
2777
2778         Reviewed by Csaba Osztrogonác.
2779
2780         Added bug urls and descriptions of rolled out patches to the rollout changelog
2781         if they are present in the original changelog. Additionally removed the list of
2782         changed files and functions.
2783
2784         * Scripts/webkitpy/common/checkout/changelog.py:
2785         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
2786         * Scripts/webkitpy/common/checkout/checkout.py:
2787         (Checkout._changelog_data_for_revision): Store bug description.
2788         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2789         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2790         (CheckoutTest.test_commit_info_for_revision):
2791         * Scripts/webkitpy/common/checkout/commitinfo.py:
2792         (CommitInfo.bug_description): Added.
2793         (CommitInfo.to_json):
2794         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
2795         (CommitInfoTest.test_commit_info_creation):
2796         * Scripts/webkitpy/tool/commands/download.py:
2797         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
2798         out patches for creating rollout changelog.
2799         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
2800         caused the regression is stored in state["bug_blocked"] now.
2801         * Scripts/webkitpy/tool/commands/download_unittest.py:
2802         (test_prepare_rollout):
2803         (test_create_rollout_multiple_revision):
2804         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2805         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
2806         rolled out patches to the changelog.
2807         (PrepareChangeLogForRevert.run):
2808         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2809         (UpdateChangeLogsForRevertTest):
2810         (test_message_for_revert):
2811         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2812         (ReopenBugAfterRollout.run):
2813
2814 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
2815
2816         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
2817         https://bugs.webkit.org/show_bug.cgi?id=130021
2818
2819         Reviewed by Mario Sanchez Prada.
2820
2821         Replace deprecated functions to use new API from ATK 2.11.90.
2822
2823         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2824         (AccessibilityUIElement::x):
2825         (AccessibilityUIElement::y):
2826         (AccessibilityUIElement::width):
2827         (AccessibilityUIElement::height):
2828         (AccessibilityUIElement::clickPointX):
2829         (AccessibilityUIElement::clickPointY):
2830         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2831         (WTR::AccessibilityUIElement::x):
2832         (WTR::AccessibilityUIElement::y):
2833         (WTR::AccessibilityUIElement::width):
2834         (WTR::AccessibilityUIElement::height):
2835         (WTR::AccessibilityUIElement::clickPointX):
2836         (WTR::AccessibilityUIElement::clickPointY):
2837
2838 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
2839
2840         [ATK] Expose aria-posinset and aria-setsize through object attributes
2841         https://bugs.webkit.org/show_bug.cgi?id=130011
2842
2843         Reviewed by Chris Fleizach.
2844
2845         Added missing implementation of numberAttributeValue both to WKTR and DRT.
2846
2847         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2848         (AccessibilityUIElement::numberAttributeValue):
2849         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2850         (WTR::AccessibilityUIElement::numberAttributeValue):
2851
2852 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
2853
2854         [Win] Unreviewed build fix.
2855
2856         Some bad Windows code was committed at some point that prevents the Apple Windows port
2857         from finding its runtime dependencies reliably.
2858
2859         * win/DLLLauncher/DLLLauncherMain.cpp:
2860         (appleApplicationSupportDirectory): Restored this function.
2861         (modifyPath): Update to use appleApplicationSupportDirectory function.
2862
2863 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
2864
2865         Let the user define the full address of the performance-site-server for uploading results
2866         https://bugs.webkit.org/show_bug.cgi?id=129819
2867
2868         Reviewed by Ryosuke Niwa.
2869
2870         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
2871         can be confusing. It's more straightforward, if you need to define explicitly the server's full
2872         address along with the protocol, when you're using this parameter. I added HTTPS as the default
2873         protocol for now, in order to avoid breaking the perf bots.
2874
2875         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2876         (_upload_json):
2877         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2878         (MainTest.test_upload_json):
2879
2880 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
2881
2882         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
2883         https://bugs.webkit.org/show_bug.cgi?id=130023
2884
2885         Reviewed by Dean Jackson.
2886
2887         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
2888         /SAFESEH flag to DLL launcher process.
2889
2890 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
2891
2892         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
2893         https://bugs.webkit.org/show_bug.cgi?id=129980
2894
2895         Reviewed by Carlos Garcia Campos.
2896
2897         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
2898
2899 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
2900
2901         [GTK] Remove the WebView source-mode WebKit1 test
2902         https://bugs.webkit.org/show_bug.cgi?id=129976
2903
2904         Reviewed by Carlos Garcia Campos.
2905
2906         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
2907
2908 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
2909
2910         Unreviewed build fix for GTKbuild after the switch to CMake
2911
2912         * gtk/common.py:
2913         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
2914         test-only bot doesn't have any build files.
2915
2916 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
2917
2918         [GTK] built-product-archive does not handle GTK+ CMake build
2919         https://bugs.webkit.org/show_bug.cgi?id=129941
2920
2921         * BuildSlaveSupport/built-product-archive:
2922         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
2923         the CMake build.
2924
2925 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
2926
2927         [GTK] Include CMake into install-dependencies script
2928         https://bugs.webkit.org/show_bug.cgi?id=129909
2929
2930         Reviewed by Martin Robinson.
2931
2932         As since r165267 buid-webkit uses CMake by default, the dependency
2933         with 'cmake' package should be introduced.
2934
2935         * gtk/install-dependencies: Ditto.
2936
2937 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
2938
2939         REGRESSION(165267): Broke a webkitpy unit tests
2940         https://bugs.webkit.org/show_bug.cgi?id=129904
2941
2942         Reviewed by Jon Honeycutt.
2943
2944         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
2945         (GtkPort._is_cmake_build):
2946
2947 2014-03-07  Andres Gomez  <agomez@igalia.com>
2948
2949         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
2950         https://bugs.webkit.org/show_bug.cgi?id=129893
2951
2952         Reviewed by Martin Robinson.
2953
2954         Added "git-svn" as dependency for deb based distros and,
2955         additionally, "subversion" for rpm based distros.
2956
2957         * gtk/install-dependencies:
2958
2959 2014-03-07  Roger Fong  <roger_fong@apple.com>
2960
2961         Remove dummy setSystemWebGLLoadPolicy client method.
2962         https://bugs.webkit.org/show_bug.cgi?id=129873.
2963
2964         Reviewed by Dean Jackson.
2965
2966         * WebKitTestRunner/TestController.cpp:
2967         (WTR::TestController::createWebViewWithOptions):
2968
2969 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
2970
2971         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
2972         https://bugs.webkit.org/show_bug.cgi?id=129886
2973
2974         Reviewed by Mark Lam.
2975
2976         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
2977         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
2978         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
2979         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
2980         make it through when in non-verbose mode.
2981
2982 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
2983
2984         [GTK] buid-webkit should use CMake by default
2985         https://bugs.webkit.org/show_bug.cgi?id=129855
2986
2987         Reviewed by Carlos Garcia Campos.
2988
2989         Make the CMake build the default GTK+ build when using build-webkit. This will
2990         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
2991         so that we have --gtk and --gtkautotools.
2992
2993         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
2994         * Scripts/webkitpy/port/gtk.py: Ditto.
2995
2996 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
2997
2998         [CMake] [GTK] Build with ninja when it is available
2999         https://bugs.webkit.org/show_bug.cgi?id=129805
3000
3001         Reviewed by Philippe Normand.
3002
3003         * Scripts/webkitdirs.pm:
3004         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
3005         if it's available on the system.
3006         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
3007         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
3008
3009 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
3010
3011         If the FTL is build-time enabled then it should be run-time enabled.
3012
3013         Rubber stamped by Geoffrey Garen.
3014
3015         * Scripts/run-jsc-stress-tests:
3016
3017 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
3018
3019         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
3020         https://bugs.webkit.org/show_bug.cgi?id=129837
3021
3022         Reviewed by Michael Saboff.
3023
3024         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
3025         The fix is to use find instead of ls like we do in shell-runner.sh.
3026
3027         * Scripts/run-jsc-stress-tests:
3028
3029 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
3030
3031         filter-build-webkit should not strip .o
3032         https://bugs.webkit.org/show_bug.cgi?id=129614
3033
3034         Reviewed by Dean Jackson.
3035
3036         This makes it much easier to jump from the failing output at
3037         the end back up to the compile errors earlier in the output.
3038
3039         * Scripts/filter-build-webkit:
3040
3041 2014-03-06  Anders Carlsson  <andersca@apple.com>
3042
3043         Build WebKit2 before building WebKit
3044         https://bugs.webkit.org/show_bug.cgi?id=129831
3045         <rdar://problem/15920020>
3046
3047         Reviewed by Dan Bernstein.
3048
3049         * Scripts/build-webkit:
3050         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
3051
3052 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
3053
3054         make-3.82 fails to build on ARM/Linux
3055         https://bugs.webkit.org/show_bug.cgi?id=107926
3056
3057         Reviewed by Martin Robinson.
3058
3059         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
3060         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
3061         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
3062         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
3063
3064         * gtk/patches/make-3.82-arg-list-length.patch:
3065
3066 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3067
3068         [GTK] Close the page when the view is disposed instead of when finalized
3069         https://bugs.webkit.org/show_bug.cgi?id=129783
3070
3071         Reviewed by Sergio Villar Senin.
3072
3073         Add test case but disabled for now because it's affetected by bug #129684.
3074
3075         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3076         (testProcessPerWebView):
3077
3078 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3079
3080         [GTK] MiniBrowser crashes when opening several urls passed as command line options
3081         https://bugs.webkit.org/show_bug.cgi?id=129738
3082
3083         Reviewed by Sergio Villar Senin.
3084
3085         The problem is that we are calling g_object_unref() for the
3086         WebKitWebSettings everytime we set it to a WebKitWebView, but the
3087         view only increases the reference counter when the settings is not
3088         the same it currently has. We should release our reference once.
3089
3090         * MiniBrowser/gtk/main.c:
3091         (createBrowserWindow):
3092         (main):
3093
3094 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3095
3096         [GTK][CMake] Tarball is created with wrong tarball paths
3097         https://bugs.webkit.org/show_bug.cgi?id=129496
3098
3099         Reviewed by Daniel Bates.
3100
3101         * gtk/make-dist.py:
3102         (Manifest.__init__): I inadvertently inverted the logic of these checks when
3103         landing the original patch with some suggestions from the reviewer. With the
3104         checks corrected, the tarball path is constructed properly.
3105
3106 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
3107
3108         Unreviewed. Update my email in contributors.json
3109
3110         * Scripts/webkitpy/common/config/contributors.json:
3111
3112 2014-03-05  Dean Jackson  <dino@apple.com>
3113
3114         [WebGL] Use WKSI to see what the system policy for WebGL is
3115         https://bugs.webkit.org/show_bug.cgi?id=129722
3116         <rdar://problem/15790542>
3117
3118         Reviewed by Tim Horton.
3119
3120         Dummy entry for setSystemWebGLLoadPolicy.
3121
3122         * WebKitTestRunner/TestController.cpp:
3123         (WTR::TestController::createWebViewWithOptions):
3124
3125 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
3126
3127         [GTK][CMake] Generate documentation for the DOM bindings
3128         https://bugs.webkit.org/show_bug.cgi?id=126211
3129
3130         Reviewed by Carlos Garcia Campos.
3131
3132         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
3133         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
3134         * gtk/generate-webkitdom-doc-files: Removed.
3135         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
3136         that it can be called by generate-gtkdoc.
3137
3138 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3139
3140         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
3141         https://bugs.webkit.org/show_bug.cgi?id=129380
3142
3143         Reviewed by Philippe Normand.
3144
3145         * Scripts/webkitdirs.pm:
3146         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
3147         skipping CMake execution.
3148
3149 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3150
3151         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
3152         https://bugs.webkit.org/show_bug.cgi?id=129651
3153
3154         Reviewed by Philippe Normand.
3155
3156         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
3157
3158 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3159
3160         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
3161         https://bugs.webkit.org/show_bug.cgi?id=129637
3162
3163         Reviewed by Carlos Garcia Campos.
3164
3165         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3166         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
3167         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
3168         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
3169         New API typically just requires a rebaseline and isn't necessarily a faiulre.
3170         (TestFactory.__init__): Add the test for GTK+.
3171         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
3172
3173 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
3174
3175         [ATK] Expose missing functionalities of AtkTableCell to AT
3176         https://bugs.webkit.org/show_bug.cgi?id=129492
3177
3178         Reviewed by Mario Sanchez Prada.
3179
3180         Reducing some code by using new API of AtkTableCell.
3181
3182         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3183         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3184
3185 2014-03-04  Alex Christensen  <achristensen@webkit.org>
3186
3187         Preparing to run layout tests on Wincairo.
3188         https://bugs.webkit.org/show_bug.cgi?id=129709
3189
3190         Reviewed by Brent Fulgham.
3191
3192         * Scripts/webkitdirs.pm:
3193         (setPathForRunningWebKitApp):
3194         Add GStreamer directory for WinCairo running layout tests.
3195         * win/DLLLauncher/DLLLauncherMain.cpp:
3196         (modifyPath):
3197         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
3198
3199 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
3200
3201         [GTK] Simplify the GObject DOM bindings API break check into one step
3202         https://bugs.webkit.org/show_bug.cgi?id=129571
3203
3204         Reviewed by Carlos Garcia Campos.
3205
3206         * GNUmakefile.am: Add the API break check to 'make check.'
3207         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
3208         * gtk/check-gdom-symbols: Removed.
3209         * gtk/webkitdom.py: Added.
3210         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
3211         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
3212
3213 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
3214
3215         Add Jeremy Jones to the contributors list as a contributor.
3216
3217         * Scripts/webkitpy/common/config/contributors.json:
3218
3219 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3220
3221         Unreviewed. Update contact email.
3222         https://bugs.webkit.org/show_bug.cgi?id=129610
3223
3224         * Scripts/webkitpy/common/config/contributors.json:
3225
3226 2014-03-02  Brian Burg  <bburg@apple.com>
3227
3228         Web Inspector model tests load wrong inspector page under WebKitTestRunner
3229         https://bugs.webkit.org/show_bug.cgi?id=129460
3230
3231         Reviewed by Dan Bernstein.
3232
3233         Don't unconditionally open the inspector before running an inspector test.
3234         Instead, the test should request that the inspector open when it's ready.
3235
3236         This change was lost during a rebase, but is the same change made to
3237         DumpRenderTree.
3238
3239         * WebKitTestRunner/TestInvocation.cpp:
3240         (WTR::TestInvocation::invoke): 
3241
3242 2014-03-02  Darin Adler  <darin@apple.com>
3243
3244         Split TextIteratorBehavior into a separate header
3245         https://bugs.webkit.org/show_bug.cgi?id=129578
3246
3247         Reviewed by Sam Weinig.
3248
3249         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
3250         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
3251         task easy, but the remove is still a bit of a pain.
3252
3253 2014-03-02  Darin Adler  <darin@apple.com>
3254
3255         Sort Mac platform export files so they merge better
3256         https://bugs.webkit.org/show_bug.cgi?id=129581
3257
3258         Reviewed by Sam Weinig.
3259
3260         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
3261         Mac export files in a "canonical" order for this project.
3262
3263 2014-02-28  Zalan Bujtas  <zalan@apple.com>
3264
3265         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
3266         https://bugs.webkit.org/show_bug.cgi?id=129438
3267
3268         Reviewed by Simon Fraser.
3269
3270         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
3271         offscreen window. It makes testing subpixel rendering and positioning possible.
3272
3273         Both the offscreen window's and WebKit's scaling are set accordingly.
3274
3275         * DumpRenderTree/mac/DumpRenderTree.mm:
3276         (createWebViewAndOffscreenWindow): cleanup
3277         (destroyWebViewAndOffscreenWindow): cleanup
3278         (dumpRenderTree):
3279         (changeWindowScaleIfNeeded):
3280         (runTest):
3281         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3282         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3283         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
3284         * WebKitTestRunner/PlatformWebView.h:
3285         * WebKitTestRunner/TestInvocation.cpp:
3286         (WTR::changeWindowScaleIfNeeded):
3287         (WTR::TestInvocation::invoke):
3288         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3289         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3290         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3291         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3292         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3293         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3294         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3295         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3296
3297 2014-02-28  Anders Carlsson  <andersca@apple.com>
3298
3299         Remove logging.
3300
3301         Reviewed by Dan Bernstein.
3302
3303         * MiniBrowser/mac/WK2BrowserWindowController.m:
3304         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
3305
3306 2014-02-28  Daniel Bates  <dabates@apple.com>
3307
3308         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
3309         https://bugs.webkit.org/show_bug.cgi?id=129163
3310
3311         Reviewed by David Kilzer.
3312
3313         Fixes an issue where DumpRenderTree Perl Support may build with the specified
3314         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
3315         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
3316         bundle.
3317
3318         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
3319         which is specified either explicitly when building with MAKE(1) or implicitly by
3320         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
3321         the OS X SDK and toolchain since the built products are only applicable to OS X.
3322
3323         * DumpRenderTree/ios/PerlSupport/Makefile:
3324
3325 2014-02-28  Commit Queue  <commit-queue@webkit.org>
3326
3327         Unreviewed, rolling out r164859.
3328         http://trac.webkit.org/changeset/164859
3329         https://bugs.webkit.org/show_bug.cgi?id=129483
3330
3331         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
3332         #webkit).
3333
3334         * DumpRenderTree/mac/DumpRenderTree.mm:
3335         (createWebViewAndOffscreenWindow):
3336         (dumpRenderTree):
3337         (runTest):
3338         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3339         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3340         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
3341         * WebKitTestRunner/PlatformWebView.h:
3342         * WebKitTestRunner/TestInvocation.cpp:
3343         (WTR::TestInvocation::invoke):
3344         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3345         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3346         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3347         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3348         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
3349
3350 2014-02-28  Zalan Bujtas  <zalan@apple.com>
3351
3352         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
3353         https://bugs.webkit.org/show_bug.cgi?id=129438
3354
3355         Reviewed by Simon Fraser.
3356
3357         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
3358         offscreen window. It makes testing subpixel rendering and positioning possible.
3359
3360         Both the offscreen window's and WebKit's scaling are set accordingly.
3361
3362         * DumpRenderTree/mac/DumpRenderTree.mm:
3363         (createWebViewAndOffscreenWindow): unrelated cleanup.
3364         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
3365         (dumpRenderTree):
3366         (changeOffscreenWindowScaleIfNeeded):
3367         (runTest):
3368         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3369         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3370         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
3371         * WebKitTestRunner/PlatformWebView.h:
3372         * WebKitTestRunner/TestInvocation.cpp:
3373         (WTR::changeOffscreenWindowScaleIfNeeded):
3374         (WTR::TestInvocation::invoke):
3375         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3376         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
3377
3378 2014-02-27  Brian Burg  <bburg@apple.com>
3379
3380         Web Inspector: model tests should use a special Test.html inspector page
3381         https://bugs.webkit.org/show_bug.cgi?id=129190
3382
3383         Reviewed by Timothy Hatcher.
3384
3385         Remove code that immediately opens the Web Inspector based on the file path of the test.
3386         Instead, the test page should request that the inspector open inside its `test()` method.
3387
3388         This change is necessary because otherwise, the inspector would be opened too early for
3389         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
3390         will get loaded instead of the minimal test page.
3391
3392         * DumpRenderTree/efl/DumpRenderTree.cpp:
3393         (createTestRunner):
3394         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3395         (runTest):
3396         * DumpRenderTree/mac/DumpRenderTree.mm:
3397         (runTest):
3398         * DumpRenderTree/win/DumpRenderTree.cpp:
3399         (runTest):
3400
3401 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
3402
3403         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
3404         https://bugs.webkit.org/show_bug.cgi?id=127076
3405
3406         Reviewed by Anders Carlsson.
3407
3408         Avoid match for :: as start of a member initialization list. Modify expression to match
3409         after a colon either non-colon character or end of line.
3410
3411         * Scripts/webkitpy/style/checkers/cpp.py:
3412         (check_member_initialization_list):
3413         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3414         (WebKitStyleTest.test_member_initialization_list):
3415
3416 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
3417
3418         Unreviewed. Update my email addresses in contributors.json.
3419
3420         * Scripts/webkitpy/common/config/contributors.json:
3421
3422 2014-02-27  Alberto Garcia  <berto@igalia.com>
3423
3424         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
3425         https://bugs.webkit.org/show_bug.cgi?id=128927
3426
3427         Reviewed by Philippe Normand.
3428
3429         Encode manually the data for sys.{stdout,stderr}.write.
3430
3431         * gtk/gtkdoc.py:
3432         (GTKDoc._run_command):
3433
3434 2014-02-27  Andres Gomez  <agomez@igalia.com>
3435
3436         Unreviewed. Add myself to watchlists
3437
3438         * Scripts/webkitpy/common/config/watchlist: Add myself to
3439         watchlists.
3440
3441 2014-02-27  Andres Gomez  <agomez@igalia.com>
3442
3443         Unreviewed, rolling out r164790.
3444         http://trac.webkit.org/changeset/164790
3445
3446         Revert r164790 because of erroneous commit log
3447
3448         * Scripts/webkitpy/common/config/watchlist:
3449
3450 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
3451
3452         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
3453         https://bugs.webkit.org/show_bug.cgi?id=129250
3454
3455         Reviewed by Mario Sanchez Prada.
3456
3457         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
3458         Implementing methods so that we could test column/row headers represented as an array of cells.
3459
3460         * DumpRenderTree/AccessibilityUIElement.cpp:
3461         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3462         (AccessibilityUIElement::columnHeaders):
3463         (AccessibilityUIElement::rowHeaders):
3464         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
3465         (AccessibilityUIElement::columnHeaders):
3466         (AccessibilityUIElement::rowHeaders):
3467         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3468         (WTR::AccessibilityUIElement::rowHeaders):
3469         (WTR::AccessibilityUIElement::columnHeaders):
3470         * efl/jhbuild.modules:
3471         * gtk/jhbuild.modules:
3472
3473 2014-02-27  Andres Gomez  <agomez@igalia.com>
3474
3475         Unreviewed. Add myself to watchlists
3476
3477         * Scripts/webkitpy/common/config/watchlist: Add myself to
3478         watchlists.
3479
3480 2014-02-27  Andres Gomez  <agomez@igalia.com>
3481
3482         Unreviewed. Add myself as a committer.
3483
3484         * Scripts/webkitpy/common/config/contributors.json:
3485
3486 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3487
3488         Unreviewed. Add Víctor Jáquez and myself to watchlists
3489
3490         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
3491         myself to watchlists.
3492
3493 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
3494
3495         Unreviewed. Add myself as a committer.
3496
3497         * Scripts/webkitpy/common/config/contributors.json:
3498
3499 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
3500
3501         Unreviewed. Moved myself to the list of committers.
3502
3503         * Scripts/webkitpy/common/config/contributors.json:
3504
3505 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
3506
3507         [GTK] Reduplicate common.top_level_path in scripts
3508         https://bugs.webkit.org/show_bug.cgi?id=129291
3509
3510         Reviewed by Philippe Normand.
3511
3512         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
3513         path manipulation and weird dependencies on the jhbuild infrastructure.
3514
3515         * Scripts/run-gtk-tests: Use common again.
3516         (TestRunner._setup_testing_environment): Ditto.
3517         * gtk/check-gdom-symbols: Ditto.
3518         * gtk/common.py:
3519         (top_level_path): Re-add top_level_path..
3520         (get_build_path): Use the builtin top_level_path again.
3521         * gtk/find-make-dist-errors: Use common again.
3522         (get_missing_headers): Ditto.
3523         * gtk/generate-inspector-gresource-manifest.py: Ditto.
3524
3525 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
3526
3527         runscript: line 42: /bin/ls: Argument list too long
3528         https://bugs.webkit.org/show_bug.cgi?id=129376
3529
3530         Reviewed by Michael Saboff.
3531
3532         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
3533         We should use find instead, which generates the list of files rather than expanding them all on 
3534         the command line and spitting them back out.
3535
3536         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
3537
3538 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
3539
3540         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
3541         https://bugs.webkit.org/show_bug.cgi?id=129377
3542
3543         Reviewed by Csaba Osztrogonác.
3544
3545         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
3546
3547 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
3548
3549         [GTK] Re-enable gtk-doc in EWS
3550         https://bugs.webkit.org/show_bug.cgi?id=128369
3551
3552         Reviewed by Carlos Garcia Campos.
3553
3554         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
3555
3556         * Scripts/webkitpy/common/config/ports.py:
3557         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
3558         (GtkWK2Port.build_webkit_command): Ditto.
3559         * Scripts/webkitpy/common/config/ports_unittest.py:
3560         (DeprecatedPortTest.test_gtk_port): Ditto.
3561         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
3562
3563 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
3564
3565         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
3566         https://bugs.webkit.org/show_bug.cgi?id=129319
3567
3568         Reviewed by Carlos Garcia Campos.
3569
3570         * gtk/generate-gtkdoc:
3571         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
3572
3573 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
3574
3575         Unreviewed. Add myself as a committer.
3576
3577         * Scripts/webkitpy/common/config/contributors.json:
3578
3579 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
3580
3581         [CSS Grid Layout] Add ENABLE flag
3582         https://bugs.webkit.org/show_bug.cgi?id=129153
3583
3584         Reviewed by Simon Fraser.
3585
3586         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
3587         all ports for developer builds.
3588
3589         * Scripts/webkitperl/FeatureList.pm:
3590
3591 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
3592
3593         Added myself as a committer.
3594
3595         Unreviewed.
3596
3597         * Scripts/webkitpy/common/config/contributors.json:
3598
3599 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
3600
3601         Unreviewed. Moved myself to the list of committers.
3602
3603         * Scripts/webkitpy/common/config/contributors.json:
3604
3605 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3606
3607         Move myself to the committers list.
3608
3609         Unreviewed.
3610
3611         * Scripts/webkitpy/common/config/contributors.json:
3612
3613 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
3614
3615         Unreviewed. Add myself as a committer.
3616
3617         * Scripts/webkitpy/common/config/contributors.json:
3618
3619 2014-02-25  Commit Queue  <commit-queue@webkit.org>
3620
3621         Unreviewed, rolling out r164639.
3622         http://trac.webkit.org/changeset/164639
3623         https://bugs.webkit.org/show_bug.cgi?id=129302
3624
3625         gtk-doc still have problems in EWS (Requested by rego on
3626         #webkit).
3627
3628         * Scripts/webkitpy/common/config/ports.py:
3629         (GtkPort.build_webkit_command):
3630         (GtkWK2Port.build_webkit_command):
3631         * Scripts/webkitpy/common/config/ports_unittest.py:
3632         (DeprecatedPortTest.test_gtk_port):
3633         (DeprecatedPortTest.test_gtk_wk2_port):
3634
3635 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
3636
3637         [GTK] Re-enable gtk-doc in EWS
3638         https://bugs.webkit.org/show_bug.cgi?id=128369
3639
3640         Reviewed by Carlos Garcia Campos.
3641
3642         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
3643
3644         * Scripts/webkitpy/common/config/ports.py:
3645         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
3646         (GtkWK2Port.build_webkit_command): Ditto.
3647         * Scripts/webkitpy/common/config/ports_unittest.py:
3648         (DeprecatedPortTest.test_gtk_port): Ditto.
3649         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
3650
3651 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3652
3653         [GTK] Mark view source mode methods as deprecated
3654         https://bugs.webkit.org/show_bug.cgi?id=128920
3655
3656         Reviewed by Martin Robinson.
3657
3658         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3659         (beforeAll): Remove view mode test.
3660
3661 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
3662
3663         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
3664         https://bugs.webkit.org/show_bug.cgi?id=128417
3665
3666         Reviewed by Carlos Garcia Campos.
3667
3668         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
3669         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
3670         a makefile. This allows accepting a header list from the build system, which can be used
3671         to dynamically build a list of ignored files. We can ignore any source file that doesn't
3672         have a corresponding header file on the header list. 
3673   &n