345532c7593427e59610fbffc302a083ccfe3671
[WebKit-https.git] / Tools / ChangeLog
1 2012-12-09  Alejandro Piñeiro  <apinheiro@igalia.com>
2
3         [GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and AccessibilityUIElementGtk::isMultiSelectable
4         https://bugs.webkit.org/show_bug.cgi?id=104481
5
6         Reviewed by Martin Robinson.
7
8         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
9         (AccessibilityUIElement::isSelectable): Implement this by checking
10         the current state of the AtkObject.
11         (AccessibilityUIElement::isMultiSelectable): Implement this by
12         checking the current state of the AtkObject.
13
14 2012-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
15
16         [GTK] accessibility/placeholder.html is failing
17         https://bugs.webkit.org/show_bug.cgi?id=98373
18
19         Reviewed by Martin Robinson.
20
21         The test was failing because the placeholder text was not supported and
22         AccessibilityUIElement::stringAttributeValue() was not implemented.
23
24         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
25         (coreAttributeToAtkAttribute): New convenience method to convert WebCore attribute
26         names into AtkObject attribute names
27         (AccessibilityUIElement::stringAttributeValue): implemented
28
29 2012-12-09  Dan Winship  <danw@gnome.org>
30
31         [GTK] Bump libxml2 requirement in jhbuild.modules
32         https://bugs.webkit.org/show_bug.cgi?id=104477
33
34         Reviewed by Martin Robinson.
35
36         Fedora 18's Apache depends on symbols in libxml2 2.9.0, so the
37         tests won't run if we only have libxml2 2.8.0 installed in the
38         jhbuild root.
39
40         * gtk/jhbuild.modules:
41
42 2012-12-09  Zan Dobersek  <zandobersek@gmail.com>
43
44         Remove testRunner.disableImageLoading()
45         https://bugs.webkit.org/show_bug.cgi?id=98083
46
47         Reviewed by Gustavo Noronha Silva.
48
49         Remove the disableImageLoading methods and callback.
50         No tests use the method anymore and all ports except Wx
51         now support this behavior through overriding the
52         WebKitDisplayImagesKey preference.
53
54         * DumpRenderTree/TestRunner.cpp:
55         (TestRunner::staticFunctions):
56         * DumpRenderTree/TestRunner.h:
57         (TestRunner):
58         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
59         (TestRunner::overridePreference): Add support for overriding the
60         WebKitDisplayImagesKey preference which is now the preferred way
61         of disabling image loading.
62         * DumpRenderTree/efl/TestRunnerEfl.cpp:
63         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
64         * DumpRenderTree/mac/TestRunnerMac.mm:
65         * DumpRenderTree/qt/TestRunnerQt.cpp:
66         * DumpRenderTree/qt/TestRunnerQt.h:
67         (TestRunner):
68         * DumpRenderTree/win/TestRunnerWin.cpp:
69         * DumpRenderTree/wx/TestRunnerWx.cpp:
70
71 2012-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
72
73         [GTK] accessibility/label-for-control-hittest.html is failing
74         https://bugs.webkit.org/show_bug.cgi?id=98368
75
76         Reviewed by Martin Robinson.
77
78         The test was failing because AccessibilityUIElement::elementAtPoint was
79         not implemented.
80
81         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
82         (AccessibilityUIElement::elementAtPoint): implemented
83
84 2012-12-09  Jon Lee  <jonlee@apple.com>
85
86         [WK2] Move button image to injected bundle
87         https://bugs.webkit.org/show_bug.cgi?id=104107
88         <rdar://problem/12813842>
89
90         Reviewed by Simon Fraser.
91
92         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
93         (WTR::InjectedBundlePage::InjectedBundlePage): Update the bundle page UI client.
94
95 2012-12-08  Halton Huo  <halton.huo@intel.com>
96
97         [CMake] Add CMake style checker
98         https://bugs.webkit.org/show_bug.cgi?id=104240
99
100         Reviewed by Eric Seidel.
101
102         The CMake style checker is followed by existing style checkers like cpp, python.
103         Unit test is added as well.
104
105         * Scripts/webkitpy/style/checker.py: Use CMakeChecker CMAKE type files(.cmake or CMakeLists.txt)
106         (FileType):
107         (CheckerDispatcher._file_type):
108         (CheckerDispatcher._create_checker):
109         * Scripts/webkitpy/style/checkers/cmake.py: Added.
110         (CMakeChecker):
111         (CMakeChecker.__init__): 
112         (CMakeChecker.check):
113         (CMakeChecker._process_line):
114         (CMakeChecker._check_trailing_whitespace):
115         (CMakeChecker._check_no_space_cmds):
116         (CMakeChecker._check_one_space_cmds):
117         (CMakeChecker._check_non_lowercase_cmd):
118         (CMakeChecker._check_indent):
119         * Scripts/webkitpy/style/checkers/cmake_unittest.py: Added.
120         (CMakeCheckerTest):
121         (CMakeCheckerTest.test_init):
122         (CMakeCheckerTest.test_init._mock_handle_style_error):
123         (CMakeCheckerTest.test_check):
124         (CMakeCheckerTest.test_check._mock_handle_style_error):
125
126 2012-12-08  Kondapally Kalyan  <kalyan.kondapally@intel.com>
127
128         [EFL] Enable WebGL by default.
129         https://bugs.webkit.org/show_bug.cgi?id=102991.
130
131         Reviewed by Kenneth Rohde Christiansen.
132
133         Enable WebGL by default.
134
135         * Scripts/webkitperl/FeatureList.pm:
136
137 2012-12-07  Scott Violet  <sky@chromium.org>
138
139         [chromium] Remove linux theme related files and switch to default
140         https://bugs.webkit.org/show_bug.cgi?id=103897
141
142         Reviewed by Dimitri Glazkov.
143
144         * Scripts/webkitpy/common/config/build_unittest.py:
145         (ShouldBuildTest): linux->default
146
147 2012-12-07  Mike Lattanzio  <mlattanzio@rim.com>
148
149         [BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
150         https://bugs.webkit.org/show_bug.cgi?id=104121
151
152         Reviewed by Rob Buis.
153
154         Update createBuffer call to reflect new BufferType enum.
155         Internal PR 254649
156         Internal Review: Jakob Petsovits
157
158         DRT is always backed for maximum compatibility.
159
160         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
161         (createBitmapContextFromWebView):
162
163 2012-12-07  Jochen Eisinger  <jochen@chromium.org>
164
165         Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers
166         https://bugs.webkit.org/show_bug.cgi?id=104355
167
168         Reviewed by Dirk Pranke.
169
170         This enables chromium's content_shell driver to run with the full SUID
171         sandbox.
172
173         * Scripts/webkitpy/layout_tests/port/base.py:
174         (Port.to.setup_environ_for_server):
175
176 2012-12-07  KyungTae Kim  <ktf.kim@samsung.com>
177
178         [EFL] Fix tools for WebKit2-only builds
179         https://bugs.webkit.org/show_bug.cgi?id=103904
180
181         Reviewed by Laszlo Gombos.
182
183         The libewebkit2.so should be used for library path for EFL WebKit2.
184
185         * Scripts/webkitdirs.pm:
186         (builtDylibPathForName):
187
188 2012-12-07  Xiaobo Wang  <xbwang@torchmobile.com.cn>
189
190         [BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
191         https://bugs.webkit.org/show_bug.cgi?id=104243
192
193         RIM PR 259337
194
195         Reviewed by Rob Buis.
196
197         1. Implement calculation of navigation originating in
198         didDecidePolicyForNavigationAction().
199         2. Implement policy delegate for resource response.
200         3. Enable customPolicyDelegate if waitForPolicyDelegate() is called.
201         4. Minor optional updates in dump() and dumpFrameLoadCallbacks().
202
203         The patch fixed the following tests:
204         - http/tests/download
205         - fast/forms/mailto/formenctype-attribute-button-html.html
206         - fast/forms/mailto/formenctype-attribute-input-html.html
207         - fast/encoding/mailto-always-utf-8.html
208
209         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
210         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
211         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
212         (BlackBerry::WebKit::DumpRenderTree::dump):
213         (BlackBerry::WebKit::DumpRenderTree::didFinishLoadForFrame):
214         (BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForNavigationAction):
215         (BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForResponse):
216         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate):
217         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
218         (DumpRenderTree):
219         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
220         (TestRunner::setCustomPolicyDelegate):
221         (TestRunner::waitForPolicyDelegate):
222         (TestRunner::overridePreference):
223
224 2012-12-07  Gwang Yoon Hwang  <ryumiel@company100.net>
225
226         [Qt] Adjust library name in layout_tests/port/qt.py after Qt5-r40
227         https://bugs.webkit.org/show_bug.cgi?id=104348
228
229         Reviewed by Csaba Osztrogonác.
230
231         After Qt-5.0.0-r40, the library was renamed from QtWebKitWidgets to
232         Qt5WebKitWidgets. run-webkit-tests were still looking for QtWebKitWidgets
233
234         * Scripts/webkitpy/layout_tests/port/qt.py:
235         (QtPort._path_to_webcore_library):
236
237 2012-12-07  Csaba Osztrogonác  <ossy@webkit.org>
238
239         Unreviewed fix, unbreak run-launcher after library renaming.
240
241         * Scripts/webkitdirs.pm:
242         (builtDylibPathForName):
243
244 2012-12-06  Csaba Osztrogonác  <ossy@webkit.org>
245
246         Unreviewed fix after r136896, unbreak --debug-rwt to make bots result verbose again.
247         https://bugs.webkit.org/show_bug.cgi?id=104296
248
249         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
250         (main):
251
252 2012-12-06  Rick Byers  <rbyers@chromium.org>
253
254         CSS cursor property should support webkit-image-set
255         https://bugs.webkit.org/show_bug.cgi?id=99493
256
257         Reviewed by Beth Dakin.
258
259         Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default
260
261         * Scripts/webkitperl/FeatureList.pm:
262         * qmake/mkspecs/features/features.pri:
263
264 2012-12-06  Vivek Galatage  <vivek.vg@samsung.com>
265
266         Unreviewed. Fixing the email address order to work correctly with bugzilla.
267
268         * Scripts/webkitpy/common/config/committers.py:
269
270 2012-12-06  Jochen Eisinger  <jochen@chromium.org>
271
272         [chromium] when forwarding events through the WebPluginContainer, create a UserGestureIndicator if processing a user gesture
273         https://bugs.webkit.org/show_bug.cgi?id=104306
274
275         Reviewed by Dimitri Glazkov.
276
277         * DumpRenderTree/chromium/TestWebPlugin.cpp:
278         (TestWebPlugin::TestWebPlugin):
279         (TestWebPlugin::handleInputEvent): add support for printing the user gesture status
280         * DumpRenderTree/chromium/TestWebPlugin.h:
281         (TestWebPlugin):
282
283 2012-12-06  Dirk Pranke  <dpranke@chromium.org>
284
285         new-run-webkit-tests --lint-test-files seems to be broken
286         https://bugs.webkit.org/show_bug.cgi?id=104296
287
288         Unreviewed, build fix.
289
290         My recent refactoring caused me to not initialize the printer
291         before calling lint(); this patch restructures the code to make
292         the lint routine self-contained and do all the work necessary.
293         This will also make it easier to move this code out into a standalone
294         file.
295
296         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
297         (lint):
298         (main):
299         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
300         (LintTest.test_all_configurations):
301         (LintTest.test_lint_test_files):
302         (LintTest.test_lint_test_files__errors):
303
304 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
305
306         DFG profiler should be helpful about gem installation
307         https://bugs.webkit.org/show_bug.cgi?id=104217
308
309         Reviewed by Oliver Hunt.
310         
311         'json' and 'highline' are not installed by default on the ruby distributions with
312         which I am familiar, and the default error messages don't make me happy. This makes
313         display-profiler-output print a helpful message if those gems are not found.
314
315         * Scripts/display-profiler-output:
316
317 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
318
319         Profiler should print a helpful message if you pass the wrong arguments
320         https://bugs.webkit.org/show_bug.cgi?id=104222
321
322         Reviewed by Oliver Hunt.
323
324         * Scripts/display-profiler-output:
325
326 2012-12-06  Ojan Vafai  <ojan@chromium.org>
327
328         Allow for CCing a secondary email address from watchlists
329         https://bugs.webkit.org/show_bug.cgi?id=104286
330
331         Reviewed by Dirk Pranke.
332
333         Change my watchlist CC address so I can filter these separately from
334         when people explicitly CC me and update the watchlist parser to allow that.
335
336         * Scripts/webkitpy/common/config/committers.py:
337         * Scripts/webkitpy/common/config/watchlist:
338         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
339         (WatchListParser._validate):
340         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
341         (WatchListParserTest.test_cc_rule_with_invalid_email):
342         (WatchListParserTest.test_cc_rule_with_secondary_email):
343
344 2012-12-06  Max Vujovic  <mvujovic@adobe.com>
345
346         Unreviewed. Add myself to committers.py.
347
348         * Scripts/webkitpy/common/config/committers.py:
349
350 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
351
352         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
353         https://bugs.webkit.org/show_bug.cgi?id=104139
354
355         Reviewed by Kenneth Rohde Christiansen.
356
357         Resize the window back to 800x600 between tests.
358         This should be a no-op if the test did not resize the window.
359
360         * WebKitTestRunner/TestController.cpp:
361         (WTR::TestController::resetStateToConsistentValues):
362
363 2012-12-06  Tommy Widenflycht  <tommyw@google.com>
364
365         Speech Recognition API: Change the error code to a string on SpeechRecognitionError
366         https://bugs.webkit.org/show_bug.cgi?id=104254
367
368         Reviewed by Adam Barth.
369
370         Changes the mock error function to take a string instead of an int.
371
372         * DumpRenderTree/chromium/DRTTestRunner.cpp:
373         (DRTTestRunner::setMockSpeechRecognitionError):
374         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
375         (WebTestRunner::ErrorTask::ErrorTask):
376         (MockWebSpeechRecognizer::setError):
377         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
378         (MockWebSpeechRecognizer):
379
380 2012-12-06  Andras Becsi  <andras.becsi@digia.com>
381
382         [Qt][Mac] Fix libxslt and libxml2 config tests
383         https://bugs.webkit.org/show_bug.cgi?id=104164
384
385         Reviewed by Simon Hausmann.
386
387         We should not use pkg-config on Mac instead use direct include
388         paths and add needed libraries to the linker options to detect
389         libxslt and libxml2 provided by the system.
390         Previously we would always fall back to qtxmlpatterns.
391
392         * qmake/config.tests/libxml2/libxml2.pro:
393         * qmake/config.tests/libxslt/libxslt.pro:
394
395 2012-12-06  Csaba Osztrogonác  <ossy@webkit.org>
396
397         [Qt] Fix the build if the path contains "+" character
398         https://bugs.webkit.org/show_bug.cgi?id=104120
399
400         Reviewed by Tor Arne Vestbø.
401
402         The second parameter of qmake's replace() is regular expression, so
403         we have to escape special characters in paths passed to replace().
404
405         * qmake/mkspecs/features/default_post.prf:
406         * qmake/mkspecs/features/default_pre.prf:
407         * qmake/mkspecs/features/functions.prf:
408
409 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
410
411         Unreviewed, rolling out r136825.
412         http://trac.webkit.org/changeset/136825
413         https://bugs.webkit.org/show_bug.cgi?id=104251
414
415         It made 100+ test fail on Qt-WK2 pixel bot, and 1800+ test
416         flakey on Qt-WK2 non-pixel bot (Requested by Ossy on #webkit).
417
418         * WebKitTestRunner/TestController.cpp:
419         (WTR::TestController::resetStateToConsistentValues):
420
421 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
422
423         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
424         https://bugs.webkit.org/show_bug.cgi?id=104139
425
426         Reviewed by Kenneth Rohde Christiansen.
427
428         Resize the window back to 800x600 between tests.
429         This should be a no-op if the test did not resize the window.
430
431         * WebKitTestRunner/TestController.cpp:
432         (WTR::TestController::resetStateToConsistentValues):
433
434 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
435
436         Unreviewed, rolling out r136784 and r136802.
437         http://trac.webkit.org/changeset/136784
438         http://trac.webkit.org/changeset/136802
439         https://bugs.webkit.org/show_bug.cgi?id=104231
440
441         breaks chromium canary (Requested by morrita on #webkit).
442
443         * Scripts/webkitpy/common/config/build_unittest.py:
444         (ShouldBuildTest):
445
446 2012-12-05  Ryosuke Niwa  <rniwa@webkit.org>
447
448         Add myself to watch changes in PerformanceTests/*.
449
450         * Scripts/webkitpy/common/config/watchlist:
451
452 2012-12-05  Shinya Kawanaka  <shinyak@chromium.org>
453
454         [Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
455         https://bugs.webkit.org/show_bug.cgi?id=102459
456
457         Reviewed by Dimitri Glazkov.
458
459         Since WebThemeControlDRTWin::markState does not consider indeterminate state, DRT caused a crash.
460
461         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
462         (WebThemeControlDRTWin::markState):
463
464 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
465
466         DFG profiler should be able to display where a code block was inlined into, and what it inlined
467         https://bugs.webkit.org/show_bug.cgi?id=104216
468
469         Reviewed by Oliver Hunt.
470
471         Added an "inlines" command that shows the inline stacks that a code block participated
472         in. Also cleaned up some of the ways we print compilation units.
473
474         * Scripts/display-profiler-output:
475
476 2012-12-05  Halton Huo  <halton.huo@intel.com>
477
478         [CMake] Unify coding style for CMake files
479         https://bugs.webkit.org/show_bug.cgi?id=103605
480
481         Reviewed by Laszlo Gombos.
482
483         Update cmake files(.cmake, CMakeLists.txt) with following style rules:
484         1. Indentation
485         1.1 Use spaces, not tabs.
486         1.2 Four spaces as indent.
487         2. Spacing
488         2.1 Place one space between control statements and their parentheses.
489             For eg, if (), else (), elseif (), endif (), foreach (),
490             endforeach (), while (), endwhile (), break ().
491         2.2 Do not place spaces between function and macro statements and
492             their parentheses. For eg, macro(), endmacro(), function(),
493             endfunction().
494         2.3 Do not place spaces between a command or function or macro and its
495             parentheses, or between a parenthesis and its content. For eg,
496             message("testing") not message( "testing") or message ("testing" )
497         2.4 No space at line ending.
498         3. Lowercase when call commands macros and functions. For eg,
499            add_executable() not ADD_EXECUTABLE(), set() not SET().
500
501         * CMakeLists.txt:
502         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
503         * DumpRenderTree/efl/CMakeLists.txt:
504         * EWebLauncher/CMakeLists.txt:
505         * EWebLauncher/ControlTheme/CMakeLists.txt:
506         * MiniBrowser/efl/CMakeLists.txt:
507         * TestWebKitAPI/CMakeLists.txt:
508         * TestWebKitAPI/PlatformEfl.cmake:
509         * WebKitTestRunner/CMakeLists.txt:
510         * WebKitTestRunner/PlatformEfl.cmake:
511         * WinCELauncher/CMakeLists.txt:
512         * clang/ReportMemoryUsagePlugin/CMakeLists.txt:
513
514 2012-12-05  Scott Violet  <sky@chromium.org>
515
516         [chromium] Remove linux theme related files and switch to default
517         https://bugs.webkit.org/show_bug.cgi?id=103897
518
519         Reviewed by Tony Chang.
520
521         * Scripts/webkitpy/common/config/build_unittest.py:
522         (ShouldBuildTest): linux->default
523
524 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
525
526         nrwt: run_webkit_tests_integrationtest.py depends on being able to share a port w/ between master and worker
527         https://bugs.webkit.org/show_bug.cgi?id=78168
528
529         Reviewed by Ojan Vafai.
530
531         This patch adds a single ordered list to ResultSummary that contains
532         the results of every test run in order of result received, and
533         modifies the TestResults class to contain the list of references used
534         for each test as well as the pid of the driver; this allows us to stop
535         having to override the test drivers to record the tests, and makes the
536         integration tests that test rdering, retries, restarts, etc. black-box
537         tests.
538
539         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
540         (SingleTestRunner._run_rebaseline):
541         (SingleTestRunner._compare_output):
542         (SingleTestRunner._run_reftest):
543         (SingleTestRunner._compare_output_with_reference):
544         * Scripts/webkitpy/layout_tests/models/result_summary.py:
545         (ResultSummary.__init__):
546         (ResultSummary.add):
547         * Scripts/webkitpy/layout_tests/models/test_results.py:
548         (TestResult.__init__):
549         * Scripts/webkitpy/layout_tests/port/driver.py:
550         (DriverOutput.__init__):
551         (Driver.run_test):
552         * Scripts/webkitpy/layout_tests/port/test.py:
553         (TestDriver):
554         (TestDriver.__init__):
555         (TestDriver.run_test):
556         (TestDriver.stop):
557         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
558         (get_tests_run):
559         (get_test_batches):
560         (get_test_results):
561         (MainTest.test_batch_size):
562         (MainTest.test_dryrun):
563         (MainTest.test_natural_order):
564         (MainTest.test_natural_order_test_specified_multiple_times):
565         (MainTest.test_random_order):
566         (MainTest.test_random_order_test_specified_multiple_times):
567         (MainTest.test_no_order):
568         (MainTest.test_no_order_test_specified_multiple_times):
569         (MainTest.test_no_order_with_directory_entries_in_natural_order):
570         (MainTest.test_repeat_each):
571         (MainTest.test_ignore_flag):
572         (MainTest.test_skipped_flag):
573         (MainTest.test_iterations):
574         (MainTest.test_run_chunk):
575         (MainTest.test_run_part):
576         (MainTest.test_run_singly):
577         (MainTest.test_skip_failing_tests):
578         (MainTest.test_single_file):
579         (MainTest.test_single_file_with_prefix):
580         (MainTest.test_single_skipped_file):
581         (MainTest.test_test_list):
582         (MainTest.test_test_list_with_prefix):
583         (MainTest.test_exit_after_n_failures):
584         (MainTest.test_exit_after_n_crashes):
585         (MainTest.test_run_order__inline):
586         (MainTest.test_reftest_run):
587         (MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
588         (MainTest.test_reftest_skip_reftests_if_no_ref_tests):
589         (MainTest.test_reftest_expected_html_should_be_ignored):
590         (MainTest.test_reftest_driver_should_run_expected_html):
591         (MainTest.test_reftest_driver_should_run_expected_mismatch_html):
592         (MainTest.test_no_http_tests):
593         (MainTest.test_platform_tests_are_found):
594
595 2012-12-05  Dana Jansens  <danakj@chromium.org>
596
597         [chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
598         https://bugs.webkit.org/show_bug.cgi?id=103967
599
600         Reviewed by James Robinson.
601
602         Use the WebCompositorSupport methods to create an OutputSurface. If they
603         fail, then fall back to the WebViewHost methods.
604
605         Once the chromium side lands, the WebCompositorSupport methods will stop
606         failing, and will replace the WebViewHost ones.
607
608         * DumpRenderTree/chromium/WebViewHost.cpp:
609         (WebViewHost::createOutputSurface):
610
611 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
612
613         nrwt: split all of the buildbot-specific output into its own file
614         https://bugs.webkit.org/show_bug.cgi?id=104165
615
616         Reviewed by Ojan Vafai.
617
618         Now that we have the RunDetails object we can move all of the
619         buildbot-specific knowledge out of the core test-running code
620         and into the outermost run_webkit_tests layer.
621
622         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
623         (run):
624         (main):
625         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
626         (passing_run):
627         (logging_run):
628         (run_and_capture):
629         (MainTest.test_all):
630         (MainTest.test_max_locked_shards):
631         (MainTest.test_child_processes_2):
632         (MainTest.test_child_processes_min):
633         (MainTest.test_full_results_html):
634         (MainTest.test_hung_thread):
635         (MainTest.test_keyboard_interrupt):
636         (MainTest.test_no_tests_found):
637         (MainTest.test_no_tests_found_2):
638         (MainTest.test_repeat_each_iterations_num_tests):
639         (MainTest.test_run_singly_actually_runs_tests):
640         (MainTest.test_test_list):
641         (MainTest.test_unexpected_failures):
642         (MainTest.test_missing_and_unexpected_results):
643         (MainTest.test_pixel_test_directories):
644         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
645         (MainTest.test_crash_with_stderr):
646         (MainTest.test_no_image_failure_with_image_diff):
647         (MainTest.test_crash_log):
648         (MainTest.test_web_process_crash_log):
649         (MainTest.test_exit_after_n_failures_upload):
650         (MainTest.test_results_directory_absolute):
651         (MainTest.test_results_directory_default):
652         (MainTest.test_results_directory_relative):
653         (MainTest.test_retrying_and_flaky_tests):
654         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
655         (MainTest.test_output_diffs):
656         (MainTest.test_unsupported_platform):
657         (MainTest.test_verbose_in_child_processes):
658         (EndToEndTest.test_end_to_end):
659         (EndToEndTest.test_reftest_with_two_notrefs):
660         (RebaselineTest.test_reset_results):
661         (RebaselineTest.test_missing_results):
662         (RebaselineTest.test_new_baseline):
663         * Scripts/webkitpy/layout_tests/views/buildbot_results.py: Added.
664         (BuildBotPrinter):
665         (BuildBotPrinter.__init__):
666         (BuildBotPrinter.print_results):
667         (BuildBotPrinter._print):
668         (BuildBotPrinter.print_result_summary):
669         (BuildBotPrinter._print_result_summary_entry):
670         (BuildBotPrinter.print_unexpected_results):
671         (BuildBotPrinter.print_unexpected_results.add_to_dict_of_lists):
672         (BuildBotPrinter.print_unexpected_results.add_result):
673         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py: Added.
674         (BuildBotPrinterTests):
675         (BuildBotPrinterTests.assertEmpty):
676         (BuildBotPrinterTests.assertNotEmpty):
677         (BuildBotPrinterTests.get_printer):
678         (BuildBotPrinterTests.get_result):
679         (BuildBotPrinterTests.get_result_summary):
680         (BuildBotPrinterTests.test_print_unexpected_results):
681         (BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
682         * Scripts/webkitpy/layout_tests/views/printing.py:
683         (Printer):
684         (Printer.__init__):
685         (Printer.print_results):
686         (Printer._print_statistics_for_test_timings):
687         (Printer._print_baseline):
688         (Printer._print_debug):
689         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
690         (Testprinter.get_printer):
691         (Testprinter.get_result):
692         (Testprinter.test_configure_and_cleanup):
693         (Testprinter.test_print_config):
694         (Testprinter.test_print_one_line_summary):
695         (Testprinter.test_test_status_line):
696         (Testprinter.test_details):
697
698 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
699
700         nrwt: collect all of the information about a run into a new RunDetails class
701         https://bugs.webkit.org/show_bug.cgi?id=104158
702
703         Reviewed by Ojan Vafai.
704
705         This patch collects the information from both test passes (the
706         main one and the retries) as well as the summarized results and
707         the exit code into a RunDetails class, so that the integration
708         tests can more easily tell what happened.
709
710         Also, change the way the --lint-test-files works slightly so that
711         we don't need to create a printer object (and hence we need to
712         rework the tests that are testing logging).
713
714         * Scripts/webkitpy/layout_tests/controllers/manager.py:
715         (RunDetails):
716         (RunDetails.__init__):
717         (Manager.run):
718         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
719         (run):
720         (main):
721         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
722         (passing_run):
723         (run_and_capture):
724         (LintTest.test_lint_test_files):
725         (LintTest.test_lint_test_files__errors):
726         (MainTest.test_verbose_in_child_processes):
727
728 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
729
730         nrwt: remove --no-record-results
731         https://bugs.webkit.org/show_bug.cgi?id=104072
732
733         Reviewed by Ojan Vafai.
734
735         The command line flag was only being used in the unit tests and
736         wasn't really needed once we started using a mock filesystem.
737
738         Also, reformat a bunch of long lines ...
739
740         * Scripts/webkitpy/layout_tests/controllers/manager.py:
741         (Manager.run):
742         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
743         (parse_args):
744         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
745         (parse_args):
746         (passing_run):
747         (logging_run):
748         (MainTest.test_repeat_each_iterations_num_tests):
749         (MainTest.test_test_list):
750         (MainTest.test_missing_and_unexpected_results):
751         (MainTest.test_pixel_test_directories):
752         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
753         (MainTest.test_crash_with_stderr):
754         (MainTest.test_no_image_failure_with_image_diff):
755         (MainTest.test_crash_log):
756         (MainTest.test_web_process_crash_log):
757         (MainTest.test_exit_after_n_failures_upload):
758         (MainTest.test_results_directory_absolute):
759         (MainTest.test_results_directory_relative):
760         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
761         (MainTest.test_additional_expectations):
762         (MainTest.test_output_diffs):
763         (EndToEndTest.test_end_to_end):
764         (EndToEndTest.test_reftest_with_two_notrefs):
765         (RebaselineTest.test_reset_results):
766         (RebaselineTest.test_missing_results):
767         (RebaselineTest.test_new_baseline):
768
769 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
770
771         nrwt: only summarize the results one way
772         https://bugs.webkit.org/show_bug.cgi?id=104064
773
774         Reviewed by Ojan Vafai.
775
776         Change manager.summarize_results so that we always (and only)
777         include both expected and unexpected results. Previously we
778         would summarize the results twice, once with expected results
779         and once without. This made the code much more confusing than
780         it needed to be.
781
782         * Scripts/webkitpy/layout_tests/controllers/manager.py:
783         (summarize_results):
784         (Manager.run):
785         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
786         (ResultSummaryTest.summarized_results):
787         (ResultSummaryTest.test_no_svn_revision):
788         (ResultSummaryTest.test_svn_revision):
789         (ResultSummaryTest.test_summarized_results_wontfix):
790         * Scripts/webkitpy/layout_tests/views/printing.py:
791         (Printer.print_results):
792         (Printer._print_unexpected_results):
793         (Printer._print_unexpected_results.add_result):
794         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
795         (Testprinter.test_print_unexpected_results.get_unexpected_results):
796         (Testprinter):
797
798 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
799
800         DFG profiler should display more information
801         https://bugs.webkit.org/show_bug.cgi?id=104163
802
803         Reviewed by Gavin Barraclough.
804
805         Added the following:
806         
807         - Distinguish between source counts and bytecode counts.
808         
809         - Add a "full" summary view that shows both kinds of counts, plus inline counts.
810         
811         - Add a "source" command to see the source.
812         
813         - Add a "bytecode" command to see the bytecode and counts.
814
815         * Scripts/display-profiler-output:
816
817 2012-12-05  Yong Li  <yoli@rim.com>
818
819         [BlackBerry] Build with libjpegturbo
820         https://bugs.webkit.org/show_bug.cgi?id=104152
821
822         Reviewed by Rob Buis.
823
824         RIM PR# 196975.
825         Make sure the right include path for libjpeg is included.
826
827         * Scripts/webkitdirs.pm:
828         (blackberryCMakeArguments):
829
830 2012-12-05  Joseph Pecoraro  <pecoraro@apple.com>
831
832         Remove stale check in check-for-webkit-framework-include-consistency
833         https://bugs.webkit.org/show_bug.cgi?id=103775
834
835         Reviewed by David Kilzer.
836
837         The underlying issue was fixed in r81173.
838
839         * Scripts/check-for-webkit-framework-include-consistency:
840
841 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
842
843         nrwt: simplify the finding of tests to retry
844         https://bugs.webkit.org/show_bug.cgi?id=104067
845
846         Reviewed by Ryosuke Niwa.
847
848         I think this makes the code a little clearer; note that
849         we were no longer using the include_missing flag.
850
851         * Scripts/webkitpy/layout_tests/controllers/manager.py:
852         (Manager.run):
853         (Manager._failed_test_names):
854
855 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
856
857         nrwt: remove two unused parameters from a function
858         https://bugs.webkit.org/show_bug.cgi?id=104059
859
860         Reviewed by Ryosuke Niwa.
861
862         Also remove an old, stale FIXME.
863
864         * Scripts/webkitpy/layout_tests/controllers/manager.py:
865         (interpret_test_failures):
866         (summarize_results):
867         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
868         (ResultSummaryTest.test_interpret_test_failures):
869
870 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
871
872         nrwt: return result_summaries from LayoutTestRunner.run_tests()
873         https://bugs.webkit.org/show_bug.cgi?id=104051
874
875         Reviewed by Ojan Vafai.
876
877         This patch completes the refactoring that makes the result summary      
878         an object returned from the layout test runner, rather than having      
879         it passed in and modified. This makes the split of duties between       
880         the manager and runner clearer and makes the data flow more             
881         functionally.                                                           
882
883         Also clean up some minor lint issues.
884
885         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
886         (LayoutTestRunner.__init__):
887         (LayoutTestRunner.run_tests):
888         (LayoutTestRunner._mark_interrupted_tests_as_skipped):
889         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
890         (FakePrinter.print_expected):
891         (LockCheckingRunner.__init__):
892         (LayoutTestRunnerTests._runner):
893         (LayoutTestRunnerTests._run_tests):
894         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
895         * Scripts/webkitpy/layout_tests/controllers/manager.py:
896         (Manager.__init__):
897         (Manager.run):
898         (Manager._run_tests):
899
900 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
901
902         nrwt: move creation of the resultsummary objects into Manager._run_tests()
903         https://bugs.webkit.org/show_bug.cgi?id=104048
904
905         Reviewed by Ojan Vafai.
906
907         This is a preparatory step to making the resultsummary just get
908         returned from the layout_test_runner; this does most of manager-side
909         changes.
910
911         * Scripts/webkitpy/layout_tests/controllers/manager.py:
912         (Manager._prepare_lists):
913         (Manager.run):
914         (Manager._run_tests):
915
916 2012-12-05  Leo Yang  <leoyang@rim.com>
917
918         [BlackBerry] Enable CSS_IMAGE_RESOLUTION
919         https://bugs.webkit.org/show_bug.cgi?id=104132
920
921         Reviewed by Yong Li.
922
923         * Scripts/webkitperl/FeatureList.pm:
924
925 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
926
927         JSC profiler should not count executions of op_call_put_result because doing so changes DFG codegen
928         https://bugs.webkit.org/show_bug.cgi?id=104102
929
930         Reviewed by Oliver Hunt.
931
932         Modify the profiler to not output counts for op_call_put_result, since there
933         won't be any. Also fix a few weird bugs, like providing better error reporting
934         when you type something incorrectly and not reporting counts for slow paths
935         in the old JIT since those counts are actually not what you think they are
936         (we don't actually count slow path executions separately).
937
938         * Scripts/display-profiler-output:
939
940 2012-12-05  Andras Becsi  <andras.becsi@digia.com>
941
942         Fix compilation for Qt5.0.0 stable branch.
943         https://bugs.webkit.org/show_bug.cgi?id=103870
944
945         Reviewed by Simon Hausmann.
946
947         Fix the use of renamed QWindow functions.
948         Patch by Andras Becsi <andras.becsi@digia.com>
949
950         * MiniBrowser/qt/BrowserWindow.cpp:
951         (BrowserWindow::BrowserWindow):
952         (BrowserWindow::onTitleChanged):
953         * MiniBrowser/qt/raw/View.cpp:
954         (View::View):
955
956 2012-12-05  Jussi Kukkonen  <jussi.kukkonen@intel.com>
957
958         [WK2] InjectedBundle should check Intent url for null
959         https://bugs.webkit.org/show_bug.cgi?id=104117
960
961         Reviewed by Kenneth Rohde Christiansen.
962
963         WKIntentServiceInfoCopyHref() can return null, we need to check
964         for that in InjectedBundlePage::registerIntentServiceForFrame()
965         to avoid crashing.
966
967         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
968         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
969
970 2012-12-04  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
971
972         Change email address of Jonathan Dong
973         https://bugs.webkit.org/show_bug.cgi?id=103976
974
975         Unreviewed, change my email address from jonathan.dong@torchmobile.com.cn
976         to jonathan.dong.webkit@gmail.com in committers list.
977
978         * Scripts/webkitpy/common/config/committers.py:
979
980 2012-12-04  Xiaobo Wang  <xbwang@torchmobile.com.cn>
981
982         [BlackBerry] DRT - Tests under "dumpAsText" directory should be dumped as text
983         https://bugs.webkit.org/show_bug.cgi?id=103986
984
985         Reviewed by Rob Buis.
986
987         Also move declaration of webSettingTransaction to before any WebSettings
988         ::setXXX() calls so that it works as expected (commit only once in the
989         function scope).
990
991         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
992         (shouldDumpAsText):
993         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
994
995 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
996
997         display-profiler-output should be able to show source code
998         https://bugs.webkit.org/show_bug.cgi?id=104073
999
1000         Reviewed by Oliver Hunt.
1001
1002         Display source code in the summary, using a one-line shortening.
1003
1004         * Scripts/display-profiler-output:
1005
1006 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
1007
1008         display-profiler-output should not use reflective infocation to resolve command names
1009
1010         Rubber stamped by Mark Hahnenberg.
1011
1012         Reflection is amazing, but here it was just kind of a bit much.
1013
1014         * Scripts/display-profiler-output:
1015
1016 2012-12-02  Filip Pizlo  <fpizlo@apple.com>
1017
1018         JSC should be able to report profiling data associated with the IR dumps and disassembly
1019         https://bugs.webkit.org/show_bug.cgi?id=102999
1020
1021         Reviewed by Gavin Barraclough.
1022
1023         Added a tool that allows you to grok the output from JSC's new profiler. Currently,
1024         this still gets confused a bit about the execution counts of a method running
1025         standalone versus a method running inlined, but other than that, it's pretty cool.
1026         See the attached "sampling profiling session" attached to the bug to see it in
1027         action.
1028         
1029         Also had to feed EFL's build system.
1030
1031         * DumpRenderTree/efl/CMakeLists.txt:
1032         * Scripts/display-profiler-output: Added.
1033
1034 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1035
1036         nrwt: fix total number of tests computed in the result summary
1037         https://bugs.webkit.org/show_bug.cgi?id=104061
1038
1039         Unreviewed, build fix.
1040
1041         One of the recent changes to the resultsummary refactoring caused
1042         us to not include the number of skipped tests in the total number
1043         of tests, throwing off the totals printed in print_one_line_summary().
1044
1045         Unfortunately, given the current state of the code it is difficult
1046         to construct an accurate unit test for this. I have verified the
1047         fix by hand, and will write a test once the remaining refactoring
1048         patches land, at which point it will be trivial to test it.
1049
1050         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1051         (Manager._prepare_lists):
1052
1053 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1054
1055         nrwt is not returning the exit status properly
1056         https://bugs.webkit.org/show_bug.cgi?id=103830
1057
1058         Unreviewed, build fix.
1059
1060         The fix in r136474 wasn't quite right either, and would return
1061         the correct exceptional status, but not the correct failing status.
1062
1063         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1064
1065 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1066
1067         nrwt: make paths and test_names passed arguments in Manager._prepare_lists et al
1068         https://bugs.webkit.org/show_bug.cgi?id=104047
1069
1070         Reviewed by Eric Seidel.
1071
1072         The code becomes cleaner if we are just passing values around rather
1073         than hanging them off the manager object, helps move _prepare_lists()
1074         to a pure function, and is needed to eventually make the
1075         result_summary object something returned from runner.run_tests()
1076         (note that two more patches are needed for that to happen).
1077
1078         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1079         (Manager.__init__):
1080         (Manager._http_tests):
1081         (Manager._prepare_lists):
1082         (Manager.needs_servers):
1083         (Manager._set_up_run):
1084         (Manager.run):
1085         (Manager._run_tests):
1086         (Manager._upload_json_files):
1087         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1088         (ManagerTest.test_needs_servers.get_manager):
1089         (ManagerTest.test_needs_servers):
1090         (ManagerTest.integration_test_needs_servers.get_manager):
1091         (ManagerTest.integration_test_needs_servers):
1092         (ManagerTest.test_look_for_new_crash_logs.get_manager):
1093         (ManagerTest):
1094         (ManagerTest.test_look_for_new_crash_logs):
1095         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1096         (JSONLayoutResultsGenerator.__init__):
1097         (JSONLayoutResultsGenerator._get_modifier_char):
1098
1099 2012-12-04  Adam Barth  <abarth@webkit.org>
1100
1101         commit-queue can get stuck with a local commit
1102         https://bugs.webkit.org/show_bug.cgi?id=104032
1103
1104         Reviewed by Dirk Pranke.
1105
1106         Previously the commit-queue would only clean down to HEAD. If the
1107         commit-queue gets interrupted in the middle of a commit (e.g., after
1108         the local commit but before the dcommit), then it can end up with a
1109         patch locally committed. That patch will then prevent the commit-queue
1110         from functioning.
1111
1112         This patch teaches the commit-queue to clean down to the merge base,
1113         which will remove any local commits.
1114
1115         * Scripts/webkitpy/common/checkout/scm/git.py:
1116         (Git.working_directory_is_clean):
1117         (Git.clean_working_directory):
1118         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1119         * Scripts/webkitpy/tool/steps/commit.py:
1120         (Commit._commit_warning):
1121         (Commit.run):
1122
1123 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1124
1125         nrwt: store only the total number of tests in the result summary
1126         https://bugs.webkit.org/show_bug.cgi?id=103963
1127
1128         Reviewed by Ryosuke Niwa.
1129
1130         The result summary only needs the total number of tests that will
1131         be run (including repetitions) in order to provide the correct stats;
1132         it doesn't actually need to know how many unique tests there are, or
1133         or how many repetitions there are.
1134
1135         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1136         (LayoutTestRunnerTests._result_summary):
1137         (LayoutTestRunnerTests.test_update_summary_with_result):
1138         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1139         (Manager._prepare_lists):
1140         (Manager.run):
1141         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1142         (ManagerTest.test_look_for_new_crash_logs):
1143         (ResultSummaryTest.get_result_summary):
1144         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1145         (ResultSummary.__init__):
1146         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1147         (Testprinter.get_result_summary):
1148
1149 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1150
1151         nrwt: do less work when ctrl-c'ed
1152         https://bugs.webkit.org/show_bug.cgi?id=103961
1153
1154         Reviewed by Ryosuke Niwa.
1155
1156         Do less work when we are ctrl-c'ed, because the statistics aren't
1157         that useful anyway. While we're at it, modify summarize_results
1158         to be aware that we don't always retry results (instead of pretending
1159         that the retry produced the same results the initial run did).
1160
1161         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1162         (summarize_results):
1163         (Manager.run):
1164
1165 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1166
1167         nrwt: result summaries should not require a list of tests to skip
1168         https://bugs.webkit.org/show_bug.cgi?id=103951
1169
1170         Reviewed by Ryosuke Niwa.
1171
1172         We shouldn't really be passing a list of tests to skip to the
1173         ResultSummary objects; they should be handled like any other
1174         test result as much as possible.
1175
1176         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1177         (LayoutTestRunnerTests._result_summary):
1178         (LayoutTestRunnerTests.test_update_summary_with_result):
1179         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1180         (Manager._prepare_lists):
1181         (Manager.run):
1182         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1183         (ManagerTest.test_look_for_new_crash_logs):
1184         (ResultSummaryTest.get_result_summary):
1185         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1186         (ResultSummary.__init__):
1187         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1188         (TestExpectations):
1189         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1190         (Testprinter.get_result_summary):
1191
1192 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1193
1194         nrwt: derive per-thread, per-worker stats from result summaries
1195         https://bugs.webkit.org/show_bug.cgi?id=103943
1196
1197         Reviewed by Ojan Vafai.
1198
1199         This patch changes the manager and printing code to pull more           
1200         information from the ResultSummary object rather than tracking          
1201         additional statistics on the side. This allows us to consolidate        
1202         a bunch of logic and remove a bunch of free-floating lists and dicts of 
1203         of values. We add the shard_name and worker_name to each TestResult,    
1204         and then modify print_timing_statistics() and upload_json_files()       
1205         to just need the result summaries.                                      
1206
1207         Note that this patch also changes the timing statistics slightly
1208         so that the individual test times are the times to run just the
1209         tests themselves (TestResult.test_run_time) and do not include the
1210         times taken to run the ref tests, compute diffs, etc. The aggregated
1211         per-worker and per-shard statistics still use the total time to
1212         process each test (TestResult.total_run_time).
1213
1214         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1215         (LayoutTestRunner.__init__):
1216         (LayoutTestRunner.run_tests):
1217         (LayoutTestRunner._handle_finished_test_list):
1218         (LayoutTestRunner._handle_finished_test):
1219         (Worker.handle):
1220         (Worker._run_test):
1221         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1222         (summarize_results):
1223         (Manager.run):
1224         (Manager._upload_json_files):
1225         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1226         (ResultSummaryTest.summarized_results):
1227         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1228         (JSONLayoutResultsGenerator.__init__):
1229         (JSONLayoutResultsGenerator._get_test_timing):
1230         * Scripts/webkitpy/layout_tests/models/test_results.py:
1231         (TestResult.__init__):
1232         * Scripts/webkitpy/layout_tests/views/printing.py:
1233         (Printer.print_results):
1234         (Printer._print_timing_statistics):
1235         (Printer):
1236         (Printer._print_worker_statistics):
1237         (Printer._print_aggregate_test_statistics):
1238         (Printer._print_individual_test_times):
1239         (Printer._print_directory_timings):
1240         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1241         (Testprinter.test_print_unexpected_results.get_unexpected_results):
1242         (Testprinter):
1243
1244 2012-12-04  Adam Barth  <abarth@webkit.org>
1245
1246         Remove obsolete code from webkitpy
1247         https://bugs.webkit.org/show_bug.cgi?id=104029
1248
1249         Reviewed by Eric Seidel.
1250
1251         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1252         (CommitQueueTask.run):
1253         * Scripts/webkitpy/tool/steps/commit.py:
1254         (Commit.options):
1255         * Scripts/webkitpy/tool/steps/options.py:
1256         (Options):
1257
1258 2012-12-04  Jochen Eisinger  <jochen@chromium.org>
1259
1260         [chromium] move WebPreferences and methods for modifying them to the TestRunner library
1261         https://bugs.webkit.org/show_bug.cgi?id=103841
1262
1263         Reviewed by Darin Fisher.
1264
1265         * DumpRenderTree/DumpRenderTree.gypi:
1266         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1267         (DRTTestRunner::DRTTestRunner):
1268         (DRTTestRunner::reset):
1269         * DumpRenderTree/chromium/DRTTestRunner.h:
1270         (DRTTestRunner):
1271         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.h.
1272         (WebKit):
1273         (WebTestRunner):
1274         (WebPreferences):
1275         (WebTestRunner::WebPreferences::WebPreferences):
1276         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1277         (WebTestRunner):
1278         (WebTestDelegate):
1279         (WebTestRunner::WebTestDelegate::localFileToDataURL):
1280         (WebTestRunner::WebTestDelegate::rewriteLayoutTestsURL):
1281         (WebTestRunner::WebTestDelegate::preferences):
1282         (WebTestRunner::WebTestDelegate::applyPreferences):
1283         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1284         (WebTestRunner::TestRunner::TestRunner):
1285         (WebTestRunner::TestRunner::reset):
1286         (WebTestRunner::TestRunner::setUserStyleSheetEnabled):
1287         (WebTestRunner):
1288         (WebTestRunner::TestRunner::setUserStyleSheetLocation):
1289         (WebTestRunner::TestRunner::setAuthorAndUserStylesEnabled):
1290         (WebTestRunner::TestRunner::setPopupBlockingEnabled):
1291         (WebTestRunner::TestRunner::setJavaScriptCanAccessClipboard):
1292         (WebTestRunner::TestRunner::setXSSAuditorEnabled):
1293         (WebTestRunner::TestRunner::setAllowUniversalAccessFromFileURLs):
1294         (WebTestRunner::TestRunner::setAllowFileAccessFromFileURLs):
1295         (WebTestRunner::TestRunner::overridePreference):
1296         (WebTestRunner::TestRunner::setPluginsEnabled):
1297         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1298         (TestRunner):
1299         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.cpp.
1300         (WebTestRunner::WebPreferences::reset):
1301         (WebTestRunner):
1302         (WebTestRunner::WebPreferences::applyTo):
1303         * DumpRenderTree/chromium/TestShell.h:
1304         (TestShell::preferences):
1305         (TestShell):
1306         * DumpRenderTree/chromium/WebViewHost.cpp:
1307         (WebViewHost::localFileToDataURL):
1308         (WebViewHost::rewriteLayoutTestsURL):
1309         (WebViewHost::preferences):
1310         (WebViewHost::applyPreferences):
1311         * DumpRenderTree/chromium/WebViewHost.h:
1312         (WebViewHost):
1313
1314 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1315
1316         Many webkitpy unit tests can be run standalone, are executable
1317         https://bugs.webkit.org/show_bug.cgi?id=103900
1318
1319         Reviewed by Eric Seidel.
1320
1321         There's no need anymore to run unit tests in standalone mode as they
1322         are now handled by test-webkitpy in a formidable fashion. This makes
1323         it possible for this patch to remove the following unnecessary bits:
1324         - remove shebang lines from unit test files,
1325         - remove calls to unittest.main(),
1326         - make unit test files non-executable.
1327
1328         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1329         (DiffParserTest.test_git_mnemonicprefix):
1330         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1331         (GitTestWithMock.test_push_local_commits_to_server_without_username_and_with_password):
1332         * Scripts/webkitpy/common/config/build_unittest.py:
1333         (ShouldBuildTest.test_should_build):
1334         * Scripts/webkitpy/common/config/ports_unittest.py:
1335         (DeprecatedPortTest.test_chromium_xvfb_port):
1336         * Scripts/webkitpy/common/find_files_unittest.py:
1337         (TestWinNormalize.test_win):
1338         * Scripts/webkitpy/common/lru_cache_unittest.py:
1339         (LRUCacheTest.test_set_again):
1340         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1341         (test_results_zip_url):
1342         * Scripts/webkitpy/common/net/credentials_unittest.py:
1343         (test_keyring_without_git_repo_nor_keychain):
1344         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
1345         (OmahaProxyTest.test_get_revisions):
1346         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
1347         * Scripts/webkitpy/common/newstringio_unittest.py:
1348         (NewStringIOTest.test_with):
1349         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
1350         (ReadChecksumFromPngTest.test_read_checksum):
1351         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
1352         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1353         (MockFileSystemTest.test_normpath):
1354         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1355         (RealFileSystemTest.test_sep):
1356         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1357         (TestPlatformInfo.test_total_bytes_memory):
1358         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1359         (ZipFileSetTest.test_namelist):
1360         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1361         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1362         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1363         (TestResultWriterTest.test_reftest_diff_image):
1364         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1365         (JSONGeneratorTest.test_test_timings_trie):
1366         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1367         (TestExpectationSerializationTests.test_string_whitespace_stripping):
1368         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1369         (KeyCompareTest.test_test_key):
1370         * Scripts/webkitpy/layout_tests/port/builders_unittest.py:
1371         (BuildersTest.test_path_from_name):
1372         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1373         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
1374         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1375         (ChromiumLinuxPortTest.test_path_to_image_diff):
1376         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1377         (ChromiumMacPortTest.test_path_to_image_diff):
1378         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1379         (ChromiumPortLoggingTest.test_check_sys_deps):
1380         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1381         (ChromiumPortLoggingTest.test_check_sys_deps):
1382         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1383         (ConfigTest.test_default_configuration__scripterror):
1384         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1385         (DriverTest.test_start_actually_starts):
1386         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1387         (FactoryTest.test_get_from_builder_name):
1388         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
1389         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
1390         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1391         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:
1392         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1393         (PortTest.disabled_test_mac_lion):
1394         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1395         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1396         (VerboseTest.test_log_args):
1397         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1398         (test_details):
1399         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1400         (TestPerfTestFactory.test_inspector_test):
1401         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1402         (test_parse_args):
1403         * Scripts/webkitpy/style/checker_unittest.py:
1404         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1405         (ChangeLogCheckerTest.test_no_error):
1406         * Scripts/webkitpy/style/checkers/common_unittest.py:
1407         (TabCheckerTest.test_tab):
1408         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1409         (CppCheckerTest.test_ne):
1410         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
1411         * Scripts/webkitpy/style/checkers/png_unittest.py:
1412         (PNGCheckerTest.test_check):
1413         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1414         * Scripts/webkitpy/style/checkers/text_unittest.py:
1415         (TextCheckerTest.test_init):
1416         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
1417         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
1418         (XcodeProjectFileCheckerTest.test_detect_development_region):
1419         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1420         (XMLCheckerTest.test_no_error):
1421         * Scripts/webkitpy/style/patchreader_unittest.py:
1422         * Scripts/webkitpy/test/finder_unittest.py:
1423         (FinderTest.test_paths):
1424         * Scripts/webkitpy/test/runner_unittest.py:
1425         (RunnerTest.test_run):
1426         * Scripts/webkitpy/test/skip_unittest.py:
1427         (SkipTest.test_skip_if_true):
1428         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1429         (ThirdpartyTest.test_imports):
1430         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1431         (TestTranslation.test_include_rewriting):
1432         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1433         (QueueEngineTest.tearDown):
1434         * Scripts/webkitpy/tool/grammar_unittest.py:
1435         (GrammarTest.test_join_with_separators):
1436         * Scripts/webkitpy/tool/mocktool_unittest.py:
1437         (MockOptionsTest.test_kwarg__set):
1438         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1439         (test_command_help):
1440
1441 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1442
1443         Many webkitpy module files are executable, have shebang line
1444         https://bugs.webkit.org/show_bug.cgi?id=103985
1445
1446         Reviewed by Dirk Pranke.
1447
1448         Remove the executable bit from webkitpy module files that are
1449         unnecessarily executable. Remove the shebang line from webkitpy
1450         module files, they are of no use. Only non-third-party files are
1451         changed.
1452
1453         * Scripts/webkitpy/bindings/main.py:
1454         * Scripts/webkitpy/common/config/watchlist:
1455         * Scripts/webkitpy/common/find_files.py:
1456         * Scripts/webkitpy/common/lru_cache.py:
1457         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1458         * Scripts/webkitpy/common/net/file_uploader.py:
1459         * Scripts/webkitpy/common/newstringio.py:
1460         * Scripts/webkitpy/common/read_checksum_from_png.py:
1461         * Scripts/webkitpy/common/system/autoinstall.py:
1462         * Scripts/webkitpy/common/system/file_lock.py:
1463         * Scripts/webkitpy/common/system/file_lock_mock.py:
1464         * Scripts/webkitpy/common/version_check.py:
1465         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1466         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1467         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1468         * Scripts/webkitpy/layout_tests/models/test_input.py:
1469         * Scripts/webkitpy/layout_tests/port/__init__.py:
1470         * Scripts/webkitpy/layout_tests/port/base.py:
1471         * Scripts/webkitpy/layout_tests/port/builders.py:
1472         * Scripts/webkitpy/layout_tests/port/chromium.py:
1473         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1474         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1475         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1476         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1477         * Scripts/webkitpy/layout_tests/port/config.py:
1478         * Scripts/webkitpy/layout_tests/port/factory.py:
1479         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1480         * Scripts/webkitpy/layout_tests/port/image_diff.py:
1481         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1482         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1483         * Scripts/webkitpy/layout_tests/port/server_process.py:
1484         * Scripts/webkitpy/layout_tests/port/test.py:
1485         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1486         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1487         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1488         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1489         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1490         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1491         * Scripts/webkitpy/layout_tests/views/printing.py:
1492         * Scripts/webkitpy/performance_tests/perftest.py:
1493         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1494         * Scripts/webkitpy/style/checkers/changelog.py:
1495         * Scripts/webkitpy/style/checkers/cpp.py:
1496         * Scripts/webkitpy/style/checkers/xcodeproj.py:
1497         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1498         (main): There's no need to run this module in standalone because
1499         it's wrapped by the Tools/Scripts/update-webgl-conformance-tests script.
1500         * Scripts/webkitpy/tool/commands/upload.py:
1501         * Scripts/webkitpy/tool/comments.py:
1502         * Scripts/webkitpy/tool/main.py:
1503
1504 2012-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1505
1506         Add a Chromium Android Release (Perf) to the list of perf. bots.
1507
1508         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1509
1510 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1511
1512         [GTK] Insert the jhbuild wrapper command at the beginning of the command list
1513         https://bugs.webkit.org/show_bug.cgi?id=103991
1514
1515         Reviewed by Martin Robinson.
1516
1517         Insert the Tools/gtk/run-with-jhbuild wrapper at the beginning of the
1518         command that's being formed in multiprocessing bootstrap. The wrapper is
1519         an executable Python script while the command being wrapped perhaps isn't
1520         and therefore requires the Python interpreter to be listed at the beginning
1521         of the command sublist that is then executed by the wrapper.
1522
1523         Specifically, the webkitpy/layout_tests/run_webkit_tests.py module file
1524         is about to lose the executable bit and the Python-signaling shebang line.
1525         The Jhbuild wrapper simply executes the command that's passed, but that errs
1526         in this case unless the Python executable is executed and the module file
1527         is passed to it as an argument.
1528
1529         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1530         (run):
1531
1532 2012-12-04  Peter Beverloo  <peter@chromium.org>
1533
1534         Add the Chromium Android Release (Perf) bot
1535         https://bugs.webkit.org/show_bug.cgi?id=103891
1536
1537         Reviewed by Eric Seidel.
1538
1539         Add configuration for the bot itself. It will be triggered by the Chromium
1540         Android Release builder. When running for Android, the DownloadAndPerfTest
1541         factory will also add the OutputAndroidDeviceStatus step.
1542
1543         * BuildSlaveSupport/build.webkit.org-config/config.json:
1544         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1545         (DownloadAndPerfTestFactory.__init__):
1546
1547 2012-12-04  Peter Beverloo  <peter@chromium.org>
1548
1549         [Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
1550         https://bugs.webkit.org/show_bug.cgi?id=103758
1551
1552         Reviewed by Eric Seidel.
1553
1554         Lazily initialize the adb command parameters rather than initializing it in the
1555         constructor now that there is an assert if adb is not available on the system and
1556         we're not in a Chromium Android checkout.
1557
1558         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1559         (ChromiumAndroidDriver.__init__):
1560         (ChromiumAndroidDriver._push_file_if_needed):
1561         (ChromiumAndroidDriver._run_adb_command):
1562         (ChromiumAndroidDriver.cmd_line):
1563         (ChromiumAndroidDriver._start_once):
1564         (ChromiumAndroidDriver._read_prompt):
1565         (ChromiumAndroidDriver):
1566         (ChromiumAndroidDriver._adb_command):
1567
1568 2012-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1569
1570         Dromaeo should report individual test result
1571         https://bugs.webkit.org/show_bug.cgi?id=99800
1572
1573         Reviewed by Eric Seidel.
1574
1575         Ignore subtest results spit out by Dromaeo tests.
1576
1577         * Scripts/webkitpy/performance_tests/perftest.py:
1578         (PerfTest): Added a line to ignore.
1579         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1580         (MainTest.test_parse_output_with_subtests): Added.
1581
1582 2012-12-03  Zan Dobersek  <zandobersek@gmail.com>
1583
1584         Unreviewed, functionality fix after r136437.
1585
1586         Calling sys.exit actually raises a SystemExit exception that
1587         is then handled in the second block and causes the script to
1588         return an 'exceptional' exit code rather than the code presenting
1589         the number of failed tests.
1590
1591         This is just a temporary fix to get the faultless bots green while
1592         they are unnecessarily red at the moment. The problem and a proper
1593         fix will be properly addressed.
1594
1595         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1596
1597 2012-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1598
1599         Unreviewed, rolling out r136460.
1600         http://trac.webkit.org/changeset/136460
1601         https://bugs.webkit.org/show_bug.cgi?id=103958
1602
1603         This patch caused compile error when building DumpRenderTree
1604         (Requested by tasak on #webkit).
1605
1606         * Scripts/webkitpy/common/config/build_unittest.py:
1607         (ShouldBuildTest):
1608
1609 2012-12-03  Scott Violet  <sky@chromium.org>
1610
1611         [chromium] Remove linux theme related files and switch to default
1612         https://bugs.webkit.org/show_bug.cgi?id=103897
1613
1614         Reviewed by Darin Fisher.
1615
1616         * Scripts/webkitpy/common/config/build_unittest.py:
1617         (ShouldBuildTest): linux->default
1618
1619 2012-12-03  Roger Fong  <roger_fong@apple.com>
1620
1621         Disable WebKit2 API tests on Apple Windows port.
1622         https://bugs.webkit.org/show_bug.cgi?id=103929.
1623
1624         Reviewed by Timothy Horton.
1625
1626         * Scripts/run-api-tests:
1627         (runTestsBySuite):
1628
1629 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1630
1631         webkitpy's run_webkit_tests should initialize the printer earlier on
1632         https://bugs.webkit.org/show_bug.cgi?id=103661
1633
1634         Reviewed by Eric Seidel.
1635
1636         Initialize the printer before computing the derived options
1637         from the command line arguments, so that we can safely log from
1638         port methods.
1639
1640         Also clean up a few miscellaneous lint warnings.
1641
1642         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1643         (ChromiumAndroidPort.path_to_adb):
1644         * Scripts/webkitpy/layout_tests/port/mac.py:
1645         (MacPort.default_child_processes):
1646         (MacPort.sample_process):
1647         (MacPort.start_helper):
1648         (MacPort.stop_helper):
1649         (MacPort.nm_command):
1650         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1651         (test_default_child_processes):
1652         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1653         (run):
1654         (_set_up_derived_options):
1655
1656 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1657
1658         webkitpy: autoinstaller is failing on windows
1659         https://bugs.webkit.org/show_bug.cgi?id=103699
1660
1661         Reviewed by Tony Chang.
1662
1663         Attempt to fix the python autoinstaller to work for pylint on win32
1664         again ... it turns out one of the dependent packages contains
1665         a write-protected test file and windows will choke when it tries to move
1666         it into place. Fortunately we can just delete the file prior to
1667         installing it in the final location, but we have to jump through
1668         a couple of hoops to do so.
1669
1670         Also, make sure that we're flattening nested module names like
1671         "logilab/common" into either safe basenames (logilab_common) or
1672         host-specific subdirs (logilab\common) as needed.
1673
1674         * Scripts/webkitpy/common/system/autoinstall.py:
1675         (AutoInstaller._url_downloaded_path):
1676         (AutoInstaller._install):
1677         (AutoInstaller.install):
1678         * Scripts/webkitpy/thirdparty/__init__.py:
1679         (AutoinstallImportHook._install_pylint):
1680
1681 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1682
1683         nrwt: clean up exception propagation / handling for interrupts and early exits
1684         https://bugs.webkit.org/show_bug.cgi?id=103830
1685
1686         Reviewed by Ojan Vafai.
1687
1688         The code for propagating early exits out of the test run was
1689         convoluted and hard to follow. By adjusting the WorkerException to
1690         derive from BaseException rather than Exception (which is a fair
1691         way of representing an error that was really unexpected/unrecoverable
1692         anyway) and pushing the TestRunInterruptedException into the
1693         ResultSummary (which is also fair since it was more of a result
1694         than an exception) this allows us to consolidate and clean up
1695         a bunch of the try/catch logic and pass fewer state flags around.
1696
1697         There are no real functional changes to this patch; there's an
1698         API change in that we stop exporting TestRunInterruptedException
1699         and WorkerException out of the Manager, and the existence of the
1700         MessagePool is now completely hidden.
1701
1702         * Scripts/webkitpy/common/message_pool.py:
1703         (WorkerException):
1704         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1705         (LayoutTestRunner.run_tests):
1706         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1707         (summarize_results):
1708         (Manager.run):
1709         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1710         (ResultSummaryTest.summarized_results):
1711         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1712         (ResultSummary.__init__):
1713         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1714         (run):
1715         (main):
1716         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1717         (MainTest.test_exception_raised.of):
1718         (MainTest.test_exception_raised):
1719         (MainTest.test_run_force):
1720         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1721         (Testprinter.test_print_unexpected_results.get_unexpected_results):
1722         (Testprinter):
1723
1724 2012-12-03  Julien BRIANCEAU   <jbrianceau@nds.com>
1725
1726         Add Qt/SH4 build slave to build.webkit.org
1727         https://bugs.webkit.org/show_bug.cgi?id=103384
1728
1729         Reviewed by Csaba Osztrogonác.
1730
1731         * BuildSlaveSupport/build.webkit.org-config/config.json:
1732
1733 2012-12-03  Alexis Menard  <alexis@webkit.org>
1734
1735         Enable CSS3 background-position offset by default
1736         https://bugs.webkit.org/show_bug.cgi?id=103917
1737
1738         Reviewed by Benjamin Poulain.
1739
1740         Even though each port may enable or not the feature we still need
1741         to pass it at configure time otherwise it will be disabled.
1742
1743         * Scripts/webkitperl/FeatureList.pm:
1744
1745 2012-12-03  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1746
1747         Unreviewed. Adding myself to committers.py.
1748
1749         * Scripts/webkitpy/common/config/committers.py:
1750
1751 2012-12-03  Laszlo Gombos  <l.gombos@samsung.com>
1752
1753         [CMake] Enable building WebKit2-only build for the EFL port
1754         https://bugs.webkit.org/show_bug.cgi?id=103820
1755
1756         Reviewed by Gyuyoung Kim.
1757
1758         Set ENABLE_WEBKIT2 to OFF if build-webkit was run with --no-webkit2.
1759         Never set ENABLE_WEBKIT in build-webkit. This will simplyfy invoking
1760         cmake directly. Initialize $cmakeArgs to avoid potential
1761         warnings when running the script.
1762
1763         * Scripts/build-webkit:
1764
1765 2012-12-03  Tommy Widenflycht  <tommyw@google.com>
1766
1767         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
1768         https://bugs.webkit.org/show_bug.cgi?id=103407
1769
1770         Reviewed by Kentaro Hara.
1771
1772         Changing the mock to use the new results delivery API.
1773
1774         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1775
1776 2012-12-03  Alexis Menard  <alexis@webkit.org>
1777
1778         [Qt] Enable CSS3 background-position offsets by default.
1779         https://bugs.webkit.org/show_bug.cgi?id=103877
1780
1781         Reviewed by Tor Arne Vestbø.
1782
1783         Enable by default CSS3 background-position offsets.
1784
1785         * qmake/mkspecs/features/features.pri:
1786
1787 2012-12-03  KyungTae Kim  <ktf.kim@samsung.com>
1788
1789         [EFL][WK2] Use float variable for zoom levels for MiniBrowser
1790         https://bugs.webkit.org/show_bug.cgi?id=103863
1791
1792         Reviewed by Gyuyoung Kim.
1793
1794         Use float instead of int for zoomLevels variables for a clearer expression
1795
1796         * MiniBrowser/efl/main.c:
1797         (on_key_down):
1798
1799 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
1800
1801         [EFL][WK2] Add support for a zoom level setting to MiniBrowser
1802         https://bugs.webkit.org/show_bug.cgi?id=99285
1803
1804         Reviewed by Gyuyoung Kim.
1805
1806          Add support for a zoom level setting to MiniBrowser.
1807          Shortcuts for setting operations are same as common browsers:
1808          Ctrl + '+' to zoom in, Ctrl + '-' to zoom out and Ctrl + '0' to zoom to default.
1809
1810         * MiniBrowser/efl/main.c:
1811         (on_key_down):
1812
1813 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
1814
1815         [EFL][WK2] ECORE_GETOPT_VALUE_BOOL need to be used for Eina_Bool
1816         https://bugs.webkit.org/show_bug.cgi?id=103835
1817
1818         Reviewed by Kentaro Hara.
1819
1820         Because legacy_behavior_enabled is Eina_Bool, ECORE_GETOPT_VALUE_BOOL need to be used
1821
1822         * MiniBrowser/efl/main.c:
1823         (elm_main):
1824
1825 2012-12-02  Mike West  <mkwst@chromium.org>
1826
1827         Garden-o-matic shouldn't die when blank JSON results are received.
1828         https://bugs.webkit.org/show_bug.cgi?id=103838
1829
1830         Reviewed by Adam Barth.
1831
1832         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1833             If the JSONP string doesn't contain '(' or ')', return an empty object.
1834         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1835             Check that this behavior stays in place.
1836
1837 2012-12-02  Eric Seidel  <eric@webkit.org>
1838
1839         run-perf-tests --profile should use iprofiler instead of instruments on Mac
1840         https://bugs.webkit.org/show_bug.cgi?id=103765
1841
1842         Unreviewed.  Updating the unittests after my previous change.
1843
1844         * Scripts/webkitpy/common/system/profiler_unittest.py:
1845         (ProfilerFactoryTest.test_basic):
1846
1847 2012-12-02  Julie Parent  <jparent@chromium.org>
1848
1849         Remove dead code in flakiness dashboard for obsolete buildDir option
1850         https://bugs.webkit.org/show_bug.cgi?id=103792
1851
1852         Reviewed by Dirk Pranke.
1853
1854         * TestResultServer/static-dashboards/dashboard_base.js:
1855         (initBuilders):
1856
1857 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
1858
1859         nrwt: clean up logic for retrying failed tests a bit
1860         https://bugs.webkit.org/show_bug.cgi?id=103829
1861
1862         Reviewed by Ojan Vafai.
1863
1864         The code for determining when to retry test failures and
1865         show the results.html file was awkward and could stand some
1866         cleaning up. This patch should have no functional changes.
1867
1868         The routine called _get_failures() returned a dict of test names
1869         to failure types, but we only ever used the names, so I've converted
1870         it to return a list (and renamed it); also, the show_results_html()
1871         file was calling that routine to figure out if anything failed, when
1872         the information was already in the result_summary (as either
1873         unexpected_results or total_failures), so we were doing unnecessary work.
1874
1875         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1876         (Manager.__init__):
1877         (Manager.run):
1878         (Manager._run_tests):
1879         (Manager._failed_test_names):
1880         (Manager._copy_results_html_file):
1881
1882 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
1883
1884         nrwt: remove unused methods in manager.py
1885         https://bugs.webkit.org/show_bug.cgi?id=103828
1886
1887         Reviewed by Eric Seidel.
1888
1889         These two methods weren't being called by anything and were no
1890         longer needed.
1891
1892         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1893         (Manager._get_failures):
1894         (Manager._upload_json_files):
1895
1896 2012-12-02  Laszlo Gombos  <l.gombos@samsung.com>
1897
1898         Correct the spelling of the cmakeargs argument
1899         https://bugs.webkit.org/show_bug.cgi?id=103814
1900
1901         Reviewed by Darin Adler.
1902
1903         The script expects cmakeargs (plural), so lets get the
1904         documentation of the script report the same.
1905
1906         * Scripts/build-webkit:
1907
1908 2012-12-02  Mike West  <mkwst@chromium.org>
1909
1910         [gtk] Enable the CSP_NEXT runtime flag.
1911         https://bugs.webkit.org/show_bug.cgi?id=103810
1912
1913         Reviewed by Adam Barth.
1914
1915         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1916         (resetDefaultsToConsistentValues):
1917             Turn on the CSP_NEXT runtime flag when running tests under GTK.
1918
1919 2012-12-02  Eric Seidel  <eric@webkit.org>
1920
1921         run-perf-tests --profile should use iprofiler instead of instruments on Mac
1922         https://bugs.webkit.org/show_bug.cgi?id=103765
1923
1924         Reviewed by Ryosuke Niwa.
1925
1926         Stephanie pointed out that iprofiler is the newer command-line interface
1927         to replace /usr/bin/instruments in Instruments 4 (which according to the
1928         interblags is supported on everything since 10.6.6), so I've moved --profile
1929         to use iprofiler on Mac.
1930
1931         I also made the IProfiler class wait for iprofiler to complete so that
1932         iprofiler won't continue running after run-perf-tests is complete (and
1933         spam over the top of your shell output).
1934
1935         There are a couple of "got-chas" to this approach:
1936         1.  iprofiler will ask for your password the first time you run it, which may
1937             cause your first test to fail.  /usr/bin/instruments doesn't seem to do that.
1938         2.  iprofiler has nice (but kinda awkward for our purposes) support for separate
1939             directory and basename arguments, making IProfiler a somewhat awkward
1940             baseclass of SingleFileOutputProfiler
1941
1942         I suspect we'll iterate from here.  It does seem slightly faster than
1943         /usr/bin/instruments was.
1944
1945         * Scripts/webkitpy/common/system/profiler.py:
1946         (ProfilerFactory.create_profiler):
1947         (IProfiler):
1948         (IProfiler.__init__):
1949         (IProfiler.attach_to_pid):
1950
1951 2012-12-02  Yongjun Zhang  <yongjun_zhang@apple.com>
1952
1953         Need a method to close all idle localstorage databases immediately.
1954         https://bugs.webkit.org/show_bug.cgi?id=103469
1955
1956         Reviewed by David Kilzer.
1957
1958         Add an JS method to TestRunner, to enable testing closing idle local storage databases in
1959         DumpRenderTree layout tests.
1960
1961         * DumpRenderTree/TestRunner.cpp:
1962         (closeIdleLocalStorageDatabasesCallback):
1963         (TestRunner::staticFunctions):
1964         * DumpRenderTree/TestRunner.h:
1965         (TestRunner):
1966         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1967         (TestRunner::closeIdleLocalStorageDatabases):
1968         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1969         (TestRunner::closeIdleLocalStorageDatabases):
1970         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1971         (TestRunner::closeIdleLocalStorageDatabases):
1972         * DumpRenderTree/mac/TestRunnerMac.mm:
1973         (TestRunner::closeIdleLocalStorageDatabases):
1974         * DumpRenderTree/win/TestRunnerWin.cpp:
1975         (TestRunner::closeIdleLocalStorageDatabases):
1976         * DumpRenderTree/wx/TestRunnerWx.cpp:
1977         (TestRunner::closeIdleLocalStorageDatabases):
1978
1979 2012-12-02  Yael Aharon  <yael.aharon@intel.com>
1980
1981         [EFL][WK2] MiniBrowser should have a legacy mode
1982         https://bugs.webkit.org/show_bug.cgi?id=103679
1983
1984         Reviewed by Kenneth Rohde Christiansen.
1985
1986         Add an option to start MiniBrowser in legacy mode.
1987
1988         * MiniBrowser/efl/main.c:
1989         (window_create):
1990         (elm_main):
1991
1992 2012-12-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1993
1994         Unreviewed, rolling out r136236.
1995         http://trac.webkit.org/changeset/136236
1996         https://bugs.webkit.org/show_bug.cgi?id=103833
1997
1998         [chromium] Flakey crashes in SpeechRecognitionEvent::emma
1999         during GC. (Requested by mkwst on #webkit).
2000
2001         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2002
2003 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
2004
2005         [XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
2006         https://bugs.webkit.org/show_bug.cgi?id=103806
2007
2008         Reviewed by Dirk Pranke.
2009
2010         There are occasional mishaps on builders where XvfbDriver doesn't properly
2011         clean up the Xvfb instance it was managing so the related guard lock files
2012         are still existing when the webkitpy unit tests are run. This can cause failures
2013         in XvfbDriverTest.test_next_free_display as the test tries to acquire displays
2014         with a specific number but is unable to due to the stale locks.
2015
2016         The solution to this is to use MockFileLock when inside unit test. This is achievable
2017         by creating a file lock through the SystemHost instance connected to the Port object,
2018         the latter available to the Driver.
2019
2020         * Scripts/webkitpy/common/system/file_lock_mock.py:
2021         (MockFileLock.acquire_lock): Return True to signal lock acquiring succeeded.
2022         (MockFileLock.release_lock): Return True to signal lock releasing succeeded.
2023         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2024         (XvfbDriver._next_free_display): Create the file lock through a mockable way.
2025         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
2026         (XvfbDriverTest.test_next_free_display): Enable back the unit test.
2027
2028 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
2029
2030         [GTK] A11y tests in WK2 report badly-formatted AX roles
2031         https://bugs.webkit.org/show_bug.cgi?id=102947
2032
2033         Reviewed by Xan Lopez.
2034
2035         As in DRT, convert the ATK accessibility roles to corresponding AXRoles.
2036         These are expected in both tests and their baselines.
2037
2038         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2039         (WTR::roleToString):
2040         (WTR):
2041         (WTR::AccessibilityUIElement::role):
2042
2043 2012-11-30  Mike West  <mkwst@chromium.org>
2044
2045         CSP 1.1: Make the CSP_NEXT flag runtime enabled.
2046         https://bugs.webkit.org/show_bug.cgi?id=103652
2047
2048         Reviewed by Adam Barth.
2049
2050         Ensures that the new SecurityPolicy runtime flag is enabled for Chromium's tests.
2051
2052         * DumpRenderTree/chromium/TestShell.cpp:
2053         (TestShell::TestShell):
2054
2055 2012-11-30  Roger Fong  <roger_fong@apple.com>
2056
2057         Unreviewed. Removed temporary debugging change from DRT (r136300).
2058
2059         * DumpRenderTree/win/DumpRenderTree.cpp:
2060         (dump):
2061
2062 2012-11-30  Roger Fong  <roger_fong@apple.com>
2063
2064         Unreviewed. Temporary change to DRT for debugging purposes.
2065
2066         * DumpRenderTree/win/DumpRenderTree.cpp:
2067         (dump):
2068
2069 2012-11-29  Tommy Widenflycht  <tommyw@google.com>
2070
2071         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
2072         https://bugs.webkit.org/show_bug.cgi?id=103407
2073
2074         Reviewed by Adam Barth.
2075
2076         Changing the mock to use the new results delivery API.
2077
2078         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2079
2080 2012-11-30  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi  <pierre.rossi@digia.com>
2081
2082         [Qt] Separate Qt WebKit into Qt WebKit and Qt WebKit Widgets
2083         https://bugs.webkit.org/show_bug.cgi?id=99314
2084
2085         Reviewed by Tor Arne Vestbø.
2086
2087         This big change separates QtWebKit into QtWebKit and QtWebKitWidgets as
2088         shared libraries.
2089
2090         It's a big refactoring that mostly involves moving WebCore dependent
2091         code into QtWebKit and accessing it through exported QWebFrameAdapter
2092         and QWebPageAdapter classes.
2093
2094         * DumpRenderTree/qt/DumpRenderTree.pro:
2095         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2096         (WebCore::DumpRenderTree::dump): Adapt to internal API changes.
2097         * MiniBrowser/qt/MiniBrowser.pro:
2098         * Scripts/webkitpy/style/checker.py: Adapt Qt exceptions to new paths.
2099         * Scripts/webkitpy/style/checker_unittest.py:
2100         (GlobalVariablesTest.test_path_rules_specifier):
2101         * WebKitTestRunner/InjectedBundle/Target.pri:
2102         * qmake/mkspecs/features/default_post.prf:
2103         * qmake/mkspecs/features/webkit_modules.prf:
2104         * qmake/mkspecs/modules/webkitwidgets.prf: Removed.
2105
2106 2012-11-30  Csaba Osztrogonác  <ossy@webkit.org>
2107
2108         [Qt] Unreviewed trivial fix.
2109
2110         Add empty.cpp back, it was removed accidentally by r129092.
2111
2112         * qmake/config.tests/gccdepends/empty.cpp: Added.
2113
2114 2012-11-30  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2115
2116         [Qt] Add support for prepare_docs and generate_docs
2117
2118         Follow-up to changes in Qt in how documentation is built.
2119
2120         Reviewed by Simon Hausmann.
2121
2122         * qmake/mkspecs/features/default_post.prf:
2123
2124 2012-11-30  Zan Dobersek  <zandobersek@gmail.com>
2125
2126         Finally remove webkitpy.common.system.deprecated_logging
2127         https://bugs.webkit.org/show_bug.cgi?id=103624
2128
2129         Reviewed by Adam Barth.
2130
2131         Remove the deprecated logging module and its unit tests now that such logging is not
2132         used anymore in webkitpy.
2133
2134         The tee and OutputTee classes are moved into a new module, webkitpy.common.system.outputtee.
2135         The tee class is renamed to Tee to conform with the usual guidelines.
2136
2137         Only unit test for the Tee class is currently provided as the OutputTee is not currently
2138         using the webkitpy Filesystem abstraction that would make its functionality testable.
2139
2140         * Scripts/webkitpy/common/system/executive.py: tee (now Tee) is now in a new module.
2141         (Executive.run_and_throw_if_fail):
2142         * Scripts/webkitpy/common/system/outputtee.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging.py.
2143         (Tee):
2144         (Tee.__init__):
2145         (Tee.write):
2146         (OutputTee):
2147         (OutputTee.__init__):
2148         (OutputTee.add_log):
2149         (OutputTee.remove_log):
2150         (OutputTee._open_log_file):
2151         (OutputTee._tee_outputs_to_files):
2152         * Scripts/webkitpy/common/system/outputtee_unittest.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging_unittest.py.
2153         (SimpleTeeTest):
2154         (SimpleTeeTest.test_simple_tee):
2155         * Scripts/webkitpy/tool/bot/queueengine.py: OutputTee is now in a new module.
2156         * Scripts/webkitpy/webkitpy.pyproj: Remove the deprecated_logging module and related unit test file.
2157
2158 2012-11-30  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2159
2160         [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
2161         https://bugs.webkit.org/show_bug.cgi?id=103634
2162
2163         Reviewed by Gyuyoung Kim.
2164
2165         Add support for PlatformWebView::simulateRightClick() and enable
2166         WebKit2 API test HitTestResultNodeHandle.
2167
2168         * TestWebKitAPI/PlatformEfl.cmake:
2169         * TestWebKitAPI/efl/PlatformWebView.cpp:
2170         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2171         (TestWebKitAPI):
2172
2173 2012-11-30  Mihai Maerean  <mmaerean@adobe.com>
2174
2175         [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
2176         https://bugs.webkit.org/show_bug.cgi?id=101192
2177
2178         Reviewed by Hajime Morita.
2179
2180         Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
2181
2182         Tests: No new tests because there is no functional change.
2183
2184         * DumpRenderTree/chromium/WebPreferences.cpp:
2185         (WebPreferences::applyTo):
2186
2187 2012-11-29  Rafael Weinstein  <rafaelw@chromium.org>
2188
2189         [HTMLTemplateElement] Add feature flag
2190         https://bugs.webkit.org/show_bug.cgi?id=103694
2191
2192         Reviewed by Adam Barth.
2193
2194         This flag will guard the implementation of the HTMLTemplateElement.
2195         http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html
2196
2197         * Scripts/webkitperl/FeatureList.pm:
2198
2199 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2200
2201         Ignore errors when removing directories on win32 during autoinstall
2202         https://bugs.webkit.org/show_bug.cgi?id=103699
2203
2204         Unreviewed, build fix.
2205
2206         I think this will work on win32; if not, I'll have to actually
2207         reproduce this :). The problem is that the logilab files
2208         appear to contain a write-protected file, and deleting those
2209         is problematic on windows.
2210
2211         * Scripts/webkitpy/common/system/autoinstall.py:
2212         (AutoInstaller._install):
2213         (AutoInstaller.install):
2214
2215 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2216
2217         webkitpy: autoinstaller is failing on windows
2218         https://bugs.webkit.org/show_bug.cgi?id=103699
2219
2220         Unreviewed, build fix.
2221
2222         We're attempting to create directories with forward slashes in them;
2223         this is a no-no on windows.
2224
2225         * Scripts/webkitpy/common/system/autoinstall.py:
2226         (AutoInstaller._create_scratch_directory_inner):
2227
2228 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2229
2230         Fix python unit tests after r136158 (android port tests failing)
2231         https://bugs.webkit.org/show_bug.cgi?id=103581
2232
2233         Unreviewed, build fix.
2234
2235         The unit tests apparently weren't ran for this patch; we failed
2236         to update the mock executive calls out to adb to determine various
2237         aspects of the environment, and were failing to create drivers.
2238
2239         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2240         (MockRunCommand.mock_run_command_fn):
2241
2242 2012-11-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2243
2244         Unreviewed, rolling out r136175 and r136177.
2245         http://trac.webkit.org/changeset/136175
2246         http://trac.webkit.org/changeset/136177
2247         https://bugs.webkit.org/show_bug.cgi?id=103683
2248
2249         Changes did not correct Windows build. (Requested by bfulgham
2250         on #webkit).
2251
2252         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2253
2254 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
2255
2256         [Windows, WinCairo] Unreviewed build correction. Correct debug
2257         build case on build machine.
2258
2259         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2260
2261 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
2262
2263         [Windows, WinCairo] Unreviewed build correction. Hide the
2264         unexported 'notSolidColor' symbol when testing against
2265         the BitmapImage class to avoid having to deal with a
2266         debug-only symbol in the Windows export definition file.
2267
2268         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: 
2269
2270 2012-11-29  Peter Beverloo  <peter@chromium.org>
2271
2272         run-perf-tests --chromium-android should not require adb in my path
2273         https://bugs.webkit.org/show_bug.cgi?id=103581
2274
2275         Reviewed by Eric Seidel.
2276
2277         Remove the need to have "adb" available in the path for Layout and Performance
2278         tests. We'll determine the versions of the "adb" version in path (if any) and
2279         the one provided in the Chromium Android checkout. Unless the "adb" available
2280         in the path is newer, the provided version will be used.
2281
2282         Some other minor nits addressed:
2283         - The path_to_forwarder/path_to_md5sum should not be in the "private overrides"
2284           section, as they're not overriding anything and are used by the driver.
2285         - Make _restart_adb_as_root slightly more robust by waiting for the device
2286           to come back online regardless of the output.
2287
2288         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2289         (ChromiumAndroidPort.__init__):
2290         (ChromiumAndroidPort.check_build):
2291         (ChromiumAndroidPort.path_to_adb):
2292         (ChromiumAndroidPort):
2293         (ChromiumAndroidPort.path_to_forwarder):
2294         (ChromiumAndroidPort.path_to_md5sum):
2295         (ChromiumAndroidPort._path_to_helper):
2296         (ChromiumAndroidPort._determine_adb_version):
2297         (ChromiumAndroidPort._get_devices):
2298         (ChromiumAndroidDriver.__init__):
2299         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
2300         (ChromiumAndroidDriver._push_executable):
2301         (ChromiumAndroidDriver._restart_adb_as_root):
2302
2303 2012-11-29  Martin Robinson  <mrobinson@igalia.com>
2304
2305         [GTK] [WebKit2] Embed the HTTP authentication dialog into the WebView
2306         https://bugs.webkit.org/show_bug.cgi?id=103277
2307
2308         Reviewed by Carlos Garcia Campos.
2309
2310         Skip the new WebKit2GtkAuthenticationDialog files so that they are not processed
2311         during gtkdoc generation.
2312
2313         * gtk/generate-gtkdoc:
2314         (get_webkit2_options):
2315
2316 2012-11-29  Eric Seidel  <eric@webkit.org>
2317
2318         run-perf-tests --chromium-android fails due to Skia INFO logging
2319         https://bugs.webkit.org/show_bug.cgi?id=103585
2320
2321         Reviewed by Adam Barth.
2322
2323         Ignore all INFO logging from Chromium code.
2324         Also added some basic testing of the ignored-stderr lines code.
2325
2326         * Scripts/webkitpy/performance_tests/perftest.py:
2327         (PerfTest):
2328         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2329         (MainTest.test_ignored_stderr_lines):
2330
2331 2012-11-29  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2332
2333         [EFL][WK2] Add support for PlatformWebView::simulateMouseMove() in TestWebKitAPI
2334         https://bugs.webkit.org/show_bug.cgi?id=103252
2335
2336         Reviewed by Kenneth Rohde Christiansen.
2337
2338         Add support for PlatformWebView::simulateMouseMove() and enable
2339         WebKit2 API test MouseMoveAfterCrash.
2340
2341         * TestWebKitAPI/PlatformEfl.cmake: Enable MouseMoveAfterCrash API
2342         test.
2343         * TestWebKitAPI/efl/PlatformWebView.cpp:
2344         (TestWebKitAPI::onWebProcessCrashed): Handle 'webprocess,crashed' signal
2345         to prevent loading an error page since the test case is reloading actual
2346         page after web process has terminated and recovered.
2347         (TestWebKitAPI):
2348         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2349         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Implemented.
2350
2351 2012-11-29  Andras Becsi  <andras.becsi@digia.com>
2352
2353         [Qt] Fix installation of QtWebProcess binary
2354         https://bugs.webkit.org/show_bug.cgi?id=101735
2355
2356         Reviewed by Simon Hausmann.
2357
2358         Add config test to detect the availability of support
2359         for "program executables" in Qt (libexec).
2360
2361         This test can be removed after the Qt5 release.
2362
2363         * Tools.pro:
2364         * qmake/mkspecs/features/features.prf:
2365         * qmake/config.tests/libexecdir/libexecdir.cpp:
2366         * qmake/config.tests/libexecdir/libexecdir.pro:
2367
2368 2012-11-29  Eric Seidel  <eric@webkit.org>
2369
2370         run-perf-tests does not work when the layout test directory does not exist
2371         https://bugs.webkit.org/show_bug.cgi?id=103572
2372
2373         Reviewed by Ryosuke Niwa.
2374
2375         Make sure that Profiler() calls maybe_make_directory for the output_dir
2376         before ever using it.  It's a little awkward to create the directory
2377         from the constructor, but its simplest that way as the various subclasses
2378         all use the directory at different times.
2379
2380         Since this required having a filesystem in Profiler (and I didn't want
2381         to grab inside Workspace to get one), I just made Profiler expect a
2382         SystemHost instead of a separate filesystem, executive and workspace.
2383
2384         * Scripts/webkitpy/common/system/profiler.py:
2385         (ProfilerFactory.create_profiler):
2386         (Profiler.__init__):
2387         (SingleFileOutputProfiler.__init__):
2388         (GooglePProf.__init__):
2389         (GooglePProf.profile_after_exit):
2390         (Instruments.__init__):
2391         (Instruments.attach_to_pid):
2392         * Scripts/webkitpy/common/system/profiler_unittest.py:
2393         (ProfilerFactoryTest.test_basic):
2394
2395 2012-11-28  Vivek Galatage  <vivek.vg@samsung.com>
2396
2397         Adding secondary email id
2398         https://bugs.webkit.org/show_bug.cgi?id=103594
2399
2400         Unreviewed. Adding secondary email.
2401
2402         * Scripts/webkitpy/common/config/committers.py:
2403
2404 2012-11-28  Kent Tamura  <tkent@chromium.org>
2405
2406         garden-o-matic: Use indeterminate <progress> in the status area
2407         https://bugs.webkit.org/show_bug.cgi?id=103494
2408
2409         Reviewed by Adam Barth.
2410
2411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2412         Wrap the "Processing..." message with an indeterminate progress bar.
2413         We keep the message as a fallback content.
2414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2415         Follow the above change.
2416
2417 2012-11-28  Nima Ghanavatian  <nghanavatian@rim.com>
2418
2419         Adding Nima Ghanavatian to committers.py
2420         https://bugs.webkit.org/show_bug.cgi?id=103533
2421
2422         Reviewed by Rob Buis.
2423
2424         Adding myself to committers.py as a Committer.
2425
2426         * Scripts/webkitpy/common/config/committers.py:
2427
2428 2012-11-28  peavo@outlook.com  <peavo@outlook.com>
2429
2430         [WinCairo] Crash when requesting favicon.
2431         https://bugs.webkit.org/show_bug.cgi?id=102689
2432
2433         Reviewed by Brent Fulgham.
2434
2435         * TestWebKitAPI/Tests/WebCore/win: Added.
2436         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: Added.
2437         (TestWebKitAPI::BitmapImageTest::BitmapImageTest): Allocate frame in constructor.
2438         (TestWebKitAPI::BitmapImageTest::frameCount): Override frameCount() method.
2439         (TestWebKitAPI::TEST): Added new test.
2440         * TestWebKitAPI/config.h: Make sure defines are correct for WinCairo.
2441        * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
2442
2443 2012-11-28  Eric Seidel  <eric@webkit.org>
2444
2445         run-perf-tests should have a --profile option for easy profiling
2446         https://bugs.webkit.org/show_bug.cgi?id=99517
2447
2448         Reviewed by Adam Barth.
2449
2450         This is a very basic implementation which works on Mac and Linux
2451         and makes it trivial for anyone to profile a PerformanceTest.
2452
2453         Currently it's not "hard" to profile a PerformanceTest
2454         but lowering the barriers to entry here allows all of us to focus
2455         less on the tools and more on the code.
2456
2457         This also paves the way for adding easy mobile-profiling (e.g. chromium-android)
2458         which is actually "hard", and this option will make much easier.
2459
2460         * Scripts/webkitpy/common/system/profiler.py: Added.
2461         (ProfilerFactory):
2462         (ProfilerFactory.create_profiler):
2463         (Profiler):
2464         (Profiler.__init__):
2465         (Profiler.adjusted_environment):
2466         (Profiler.attach_to_pid):
2467         (Profiler.did_stop):
2468         (SingleFileOutputProfiler):
2469         (SingleFileOutputProfiler.__init__):
2470         (GooglePProf):
2471         (GooglePProf.__init__):
2472         (GooglePProf.adjusted_environment):
2473         (GooglePProf.did_stop):
2474         (Instruments):
2475         (Instruments.__init__):
2476         (Instruments.attach_to_pid):
2477         * Scripts/webkitpy/common/system/profiler_unittest.py: Added.
2478         (ProfilerFactoryTest):
2479         (ProfilerFactoryTest.test_basic):
2480         * Scripts/webkitpy/layout_tests/port/driver.py:
2481         (Driver.__init__):
2482         (Driver._start):
2483         (Driver.stop):
2484         (Driver.cmd_line):
2485         * Scripts/webkitpy/performance_tests/perftest.py:
2486         (PerfTest.parse_output):
2487         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2488         (MainTest.test_parse_output):
2489         (MainTest.test_parse_output_with_failing_line):
2490         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2491         (PerfTestsRunner._parse_args):
2492         (PerfTestsRunner.run):
2493
2494 2012-11-28  Zan Dobersek  <zandobersek@gmail.com>
2495
2496         Remove deprecated logging usage from QueueEngine
2497         https://bugs.webkit.org/show_bug.cgi?id=103532
2498
2499         Reviewed by Dirk Pranke.
2500
2501         Replace usage of deprecated logging in webkitpy.tool.bot.queueengine with
2502         logging through the Logger object. The unit test is modified to reflect
2503         these changes.
2504
2505         After these changes the deprecated logging (i.e. logging to stderr) is not
2506         used anymore through webkitpy and can be removed.
2507
2508         * Scripts/webkitpy/tool/bot/queueengine.py:
2509         (QueueEngine.exit_after_handled_error):
2510         (QueueEngine.run):
2511         (QueueEngine._stopping):
2512         (QueueEngine._sleep):
2513         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2514         (QueueEngineTest._run_engine):
2515
2516 2012-11-28  Nate Chapin  <japhet@chromium.org>
2517
2518         Move empty loading to DocumentLoader, simplify FrameLoader::init()
2519         https://bugs.webkit.org/show_bug.cgi?id=101512
2520
2521         Reviewed by Adam Barth.
2522
2523         * DumpRenderTree/chromium/WebViewHost.cpp:
2524         (WebViewHost::updateForCommittedLoad): This function doesn't play nicely with empty urls and incorrectly
2525             interprets them as a non-empty load. This change is required for
2526              http/tests/navigation/new-window-redirect-history.html to continue to pass in chromium.
2527         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: This test relies on a callback that no longer
2528              is sent for about:blank loads.  Hook into didFinishLoadForFrame() instead.
2529         (TestWebKitAPI::didFinishLoadForFrame):
2530         (TestWebKitAPI::TEST):
2531
2532 2012-11-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2533
2534         [chromium] Allow plugins to opt-in to receive synthetic mouse events out of touch events.
2535         https://bugs.webkit.org/show_bug.cgi?id=103092
2536
2537         Reviewed by Tony Chang.
2538
2539         Update the test web-plugin to be able to opt-in to receive synthesized mouse events created
2540         from touch events.
2541
2542         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2543         (parseTouchEventRequestType):
2544         (TestWebPlugin::TestWebPlugin):
2545         (TestWebPlugin::initialize):
2546         * DumpRenderTree/chromium/TestWebPlugin.h:
2547         (TestWebPlugin):
2548
2549 2012-11-28  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2550
2551         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
2552         https://bugs.webkit.org/show_bug.cgi?id=103123
2553
2554         Reviewed by Laszlo Gombos.
2555
2556         Add support for PlatformWebView::simulateSpacebarKeyPress().
2557         This functionality is needed by WebKit2 API test MouseMoveAfterCrash
2558         which is going to be unskipped in bug #103252.
2559
2560         * TestWebKitAPI/efl/PlatformUtilities.cpp:
2561         (TestWebKitAPI::Util::sleep):
2562         * TestWebKitAPI/efl/PlatformWebView.cpp: Use usleep() instead of
2563         sleep().
2564         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2565         (TestWebKitAPI):
2566
2567 2012-11-28  Yael Aharon  <yael.aharon@intel.com>
2568
2569         Minor cleanup in TestInvocation
2570         https://bugs.webkit.org/show_bug.cgi?id=103512
2571
2572         Reviewed by Kenneth Rohde Christiansen.
2573
2574         Remove a function declaration that is not defined and not used.
2575         Fix spelling error in m_webProcessIsUnresponsive.
2576
2577         * WebKitTestRunner/TestInvocation.cpp:
2578         (WTR::TestInvocation::TestInvocation):
2579         (WTR::TestInvocation::invoke):
2580         * WebKitTestRunner/TestInvocation.h:
2581         (TestInvocation):
2582         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2583         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2584         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2585         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2586
2587 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2588
2589         Unreviewed. Use my personal email as bugzilla email.
2590
2591         * Scripts/webkitpy/common/config/committers.py:
2592
2593 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2594
2595         Unreviewed. Adding myself to committers.py.
2596
2597         * Scripts/webkitpy/common/config/committers.py:
2598
2599 2012-11-26  Andrey Adaikin  <aandrey@chromium.org>
2600
2601         Unreviewed. Adding myself to committers.py.
2602
2603         * Scripts/webkitpy/common/config/committers.py:
2604
2605 2012-11-28  Tommy Widenflycht  <tommyw@google.com>
2606
2607         Add basic implementation for MediaStreamAudioDestinationNode
2608         https://bugs.webkit.org/show_bug.cgi?id=101815
2609
2610         Reviewed by Chris Rogers.
2611
2612         Adds a bit of code that exercises the WebKit API.
2613
2614         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2615         (MockWebMediaStreamSourceConsumer):
2616         (MockWebMediaStreamSourceConsumer::~MockWebMediaStreamSourceConsumer):
2617         (MockWebMediaStreamCenter::didCreateMediaStream):
2618
2619 2012-11-28  Matt Falkenhagen  <falken@chromium.org>
2620
2621         Unreviewed. Adding myself to committers list.
2622
2623         * Scripts/webkitpy/common/config/committers.py:
2624
2625 2012-11-27  Li Yin  <li.yin@intel.com>
2626
2627         Unreviewed. Adding myself to committers list.
2628
2629         * Scripts/webkitpy/common/config/committers.py:
2630
2631 2012-11-27  Christophe Dumez  <christophe.dumez@intel.com>
2632
2633         Unreviewed. Adding myself to committers.py.
2634
2635         * Scripts/webkitpy/common/config/committers.py:
2636
2637 2012-11-27  Vivek Galatage  <vivek.vg@samsung.com>
2638
2639         Unreviewd. Adding myself to committers list.
2640
2641         * Scripts/webkitpy/common/config/committers.py:
2642
2643 2012-11-27  Tony Chang  <tony@chromium.org>
2644
2645         Bring back partytime!
2646         https://bugs.webkit.org/show_bug.cgi?id=103466
2647
2648         Reviewed by Adam Barth.
2649
2650         "code 404, message Unknown function images/partytime_gif" since we didn't
2651         allow .gif or .png files to be served.
2652
2653         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2654         (GardeningHTTPRequestHandler):
2655
2656 2012-11-27  Adam Barth  <abarth@webkit.org>
2657
2658         run-perf-tests fails on Android because of stderr output
2659         https://bugs.webkit.org/show_bug.cgi?id=103462
2660
2661         Reviewed by Ryosuke Niwa.
2662
2663         The chromium-android port produces some stderr output that causes
2664         run-perf-tests to get sad and not record the results of the performance
2665         test. This patch teaches run-perf-test to ignore this output much in
2666         the same way that it currently ignores some stdout messages.
2667
2668         * Scripts/webkitpy/performance_tests/perftest.py:
2669         (PerfTest.run):
2670         (PerfTest._should_ignore_line):
2671         (PerfTest):
2672         (PerfTest._should_ignore_line_in_stderr):
2673         (PerfTest._filter_stderr):
2674         (PerfTest._should_ignore_line_in_parser_test_result):
2675
2676 2012-11-27  Tony Chang  <tony@chromium.org>
2677
2678         Fix garden-o-matic for non-chromium ports
2679         https://bugs.webkit.org/show_bug.cgi?id=103458
2680
2681         Reviewed by Adam Barth.
2682
2683         I was getting a 403 error when trying to select any non-chromium port.
2684
2685         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2686         (ReflectionHandler._handle_request): Use the path without query params.
2687
2688 2012-11-27  Yael Aharon  <yael.aharon@intel.com>
2689
2690         [EFL][WK2] 3D pixel tests are failing
2691         https://bugs.webkit.org/show_bug.cgi?id=102833
2692
2693         Reviewed by Kenneth Rohde Christiansen.
2694
2695         Generate a snapshot of the view in the UI process instead of the web process.
2696         We have to use Texture Mapper in order to correctly paint 3D transforms etc.
2697
2698         * WebKitTestRunner/TestInvocation.h:
2699         (TestInvocation):
2700         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2701         (WTR::writeFunction):
2702         (WTR::paintRepaintRectOverlay):
2703         (WTR):
2704         (WTR::TestInvocation::forceRepaintDoneCallback):
2705         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2706         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2707         (WTR::PlatformWebView::windowSnapshotImage):
2708
2709 2012-11-27  Adam Barth  <abarth@webkit.org>
2710
2711         Make it possible to run performance tests on Chromium Android
2712         https://bugs.webkit.org/show_bug.cgi?id=103268
2713
2714         Reviewed by Ryosuke Niwa.
2715
2716         Based on a patch by Peter Beverloo.
2717
2718         This patch (almost) makes it possible to run WebKit performance tests
2719         on the Chromium port for Android. There are a few things I had to do
2720         in order to make this happen:
2721
2722         1) The worker number when creating a driver for a port is zero-based
2723            for layout tests and elsewhere. Android uses this to determine
2724            which device it has to run on, so make it zero based for performance
2725            tests as well.
2726
2727         2) Tests aren't available on the Android device, so we start an HTTP
2728            server that serves the tests to the device or emulator.
2729
2730         The one shortcoming of this patch is that chromium-android produces
2731         some stderr output that confuses run-perf-tests. I'll address that
2732         issue in a subsequent CL. This patch also depends on
2733         https://codereview.chromium.org/11416182 in order to work.
2734
2735         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2736         (ChromiumAndroidPort.start_http_server):
2737         (ChromiumAndroidDriver._command_from_driver_input):
2738         * Scripts/webkitpy/performance_tests/perftest.py:
2739         (ReplayPerfTest.prepare):
2740         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2741         (PerfTestsRunner.__init__):
2742         (PerfTestsRunner._parse_args):
2743         (PerfTestsRunner._start_servers):
2744         (PerfTestsRunner):
2745         (PerfTestsRunner._stop_servers):
2746         (PerfTestsRunner.run):
2747         (PerfTestsRunner._run_tests_set):
2748
2749 2012-11-27  Zan Dobersek  <zandobersek@gmail.com>
2750
2751         Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
2752         https://bugs.webkit.org/show_bug.cgi?id=103408
2753
2754         Reviewed by Dirk Pranke.
2755
2756         Remove the use of the deprecated log and error methods by replacing them with
2757         logging through Python's logging.Logger objects.
2758
2759         This patch covers such changes in webkitpy.common and webkitpy.layout_tests and also
2760         updates any affected unit test.
2761
2762         * Scripts/webkitpy/common/checkout/changelog.py:
2763         (ChangeLogEntry._parse_entry):
2764         * Scripts/webkitpy/common/checkout/checkout.py:
2765         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2766         (CheckoutTest.test_apply_patch):
2767         * Scripts/webkitpy/common/checkout/deps_mock.py:
2768         (MockDEPS.write_variable):
2769         * Scripts/webkitpy/common/checkout/scm/detection.py:
2770         (SCMDetector.default_scm):
2771         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2772         (SCMDetectorTest.test_detect_scm_system):
2773         * Scripts/webkitpy/common/checkout/scm/git.py:
2774         (Git._check_git_architecture):
2775         (Git._commit_on_branch):
2776         * Scripts/webkitpy/common/checkout/scm/scm.py:
2777         (SCM.ensure_clean_working_directory):
2778         (SCM.ensure_no_local_commits):
2779         (SCM.will.commit_locally_with_message):
2780         * Scripts/webkitpy/common/checkout/scm/svn.py:
2781         (SVN.apply_reverse_diff):
2782         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
2783         (Attachment._validate_flag_value):
2784         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2785         (Bugzilla._fetch_bug_page):
2786         (Bugzilla.bug_id_for_attachment_id):
2787         (Bugzilla.authenticate):
2788         (Bugzilla._commit_queue_flag):
2789         (Bugzilla.add_attachment_to_bug):
2790         (Bugzilla.add_patch_to_bug):
2791         (Bugzilla.create_bug):
2792         (Bugzilla.clear_attachment_flags):
2793         (Bugzilla.set_flag_on_attachment):
2794         (Bugzilla.obsolete_attachment):
2795         (Bugzilla.add_cc_to_bug):
2796         (Bugzilla.post_comment_to_bug):
2797         (Bugzilla.close_bug_as_fixed):
2798         (Bugzilla.reassign_bug):
2799         (reopen_bug):
2800         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2801         (MockBugzilla.create_bug):
2802         (MockBugzilla.reassign_bug):
2803         (MockBugzilla.set_flag_on_attachment):
2804         (MockBugzilla.post_comment_to_bug):
2805         (MockBugzilla.add_attachment_to_bug):
2806         (MockBugzilla.add_patch_to_bug):
2807         (MockBugzilla.reopen_bug):
2808         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2809         (test_add_cc_to_bug):
2810         (_assert_reopen):
2811         (test_reopen_bug):
2812         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2813         (MockBuilder.force_build):
2814         * Scripts/webkitpy/common/net/credentials.py:
2815         (Credentials._run_security_tool):
2816         * Scripts/webkitpy/common/net/credentials_unittest.py:
2817         (_assert_security_call):
2818         * Scripts/webkitpy/common/net/irc/irc_mock.py:
2819         (MockIRC.post):
2820         (MockIRC.disconnect):
2821         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2822         (IRCProxy.__init__):
2823         (IRCProxy.disconnect):
2824         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
2825         (IRCProxyTest.test_trivial):
2826         * Scripts/webkitpy/common/net/layouttestresults.py:
2827         (ORWTResultsHTMLParser._failures_from_fail_row):
2828         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2829         (test_failures_from_fail_row):
2830         * Scripts/webkitpy/common/net/networktransaction.py:
2831         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2832         (JSONTestResult._tokenize):
2833         (JSONTestResult._failure_types_from_actual_result):
2834         * Scripts/webkitpy/common/net/statusserver.py:
2835         (StatusServer.update_status):
2836         (StatusServer.update_svn_revision):
2837         * Scripts/webkitpy/common/net/statusserver_mock.py:
2838         (MockStatusServer.release_work_item):
2839         (MockStatusServer.update_work_items):
2840         (MockStatusServer.submit_to_ews):
2841         (MockStatusServer.update_status):
2842         * Scripts/webkitpy/common/net/unittestresults.py:
2843         (UnitTestResults.results_from_string):
2844         * Scripts/webkitpy/common/system/executive_mock.py:
2845         (MockExecutive.running_pids):
2846         (MockExecutive.run_and_throw_if_fail):
2847         (MockExecutive.run_command):
2848         (MockExecutive.popen):
2849         * Scripts/webkitpy/common/system/user_mock.py:
2850         (MockUser.confirm):
2851         (MockUser.open_url):
2852         * Scripts/webkitpy/common/system/workspace_unittest.py:
2853         (WorkspaceTest.test_create_zip):
2854         (WorkspaceTest.test_create_zip_exception):
2855         * Scripts/webkitpy/common/watchlist/watchlist_mock.py:
2856         (MockWatchList.determine_cc_and_messages):
2857         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2858         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
2859         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2860         (EflPortTest.test_show_results_html_file):
2861         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2862         (GtkPortTest.test_show_results_html_file):
2863         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2864         (test_show_results_html_file):
2865         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2866         (test_build_driver):
2867         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2868         (QtPortTest.test_show_results_html_file):
2869         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2870         (WinPortTest.test_show_results_html_file):
2871         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
2872         (XvfbDriverTest.assertDriverStartSuccessful):
2873         (XvfbDriverTest.test_start_no_pixel_tests):
2874         (XvfbDriverTest.test_start_pixel_tests):
2875         (XvfbDriverTest.test_start_arbitrary_worker_number):
2876         (XvfbDriverTest.test_start_next_worker):
2877         (XvfbDriverTest.test_stop):
2878         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2879         (TestLayoutTestApacheHttpd.test_start_cmd):
2880         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2881         (test_run_test_pause_before_testing):
2882         (test_run_memory_test):
2883         (_test_run_with_json_output):
2884         (test_run_respects_no_results):
2885         (test_run_generates_and_show_results_page):
2886         (test_run_respects_no_show_results):
2887         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2888         (FeedersTest.test_commit_queue_feeder):
2889         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2890         (FlakyTestReporterTest.test_create_bug_for_flaky_test):
2891         (test_report_flaky_tests_creating_bug):
2892         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2893         (IRCCommandTest.test_rollout_updates_working_copy):
2894         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2895         (IRCBotTest.test_exception_during_command):
2896         (IRCBotTest.test_hi):
2897         (IRCBotTest.test_help):
2898         (IRCBotTest.test_restart):
2899         (IRCBotTest.test_rollout):
2900         (IRCBotTest.test_revert):
2901         (IRCBotTest.test_roll_chromium_deps):
2902         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
2903         (IRCBotTest.test_multi_rollout):
2904         (IRCBotTest.test_rollout_with_r_in_svn_revision):
2905         (IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
2906         (IRCBotTest.test_rollout_bananas):
2907         (IRCBotTest.test_rollout_invalidate_revision):
2908         (IRCBotTest.test_rollout_invalidate_reason):
2909         (test_multi_rollout_invalidate_reason):
2910         (test_rollout_no_reason):
2911         (test_multi_rollout_no_reason):
2912         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2913         (SheriffTest.test_post_blame_comment_on_bug):
2914         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
2915         (ApplyWatchListLocalTest.test_args_parsing):
2916         (test_args_parsing_with_bug):
2917         * Scripts/webkitpy/tool/commands/download_unittest.py:
2918         (test_land_cowboy):
2919         (test_check_style):
2920         (test_create_rollout):
2921         (test_create_rollout_resolved):
2922         (test_rollout):
2923         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2924         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2925         (EarlyWarningSytemTest._default_expected_logs):
2926         (EarlyWarningSytemTest._test_builder_ews):
2927         (EarlyWarningSytemTest._test_testing_ews):
2928         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
2929         (OpenBugsTest.test_args_parsing):
2930         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2931         (QueryCommandsTest.test_bugs_to_commit):
2932         (QueryCommandsTest.test_patches_in_commit_queue):
2933         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2934         (FeederQueueTest.test_feeder_queue):
2935         (AbstractPatchQueueTest.test_next_patch):
2936         (AbstractPatchQueueTest.test_upload_results_archive_for_patch):
2937         (CommitQueueTest.test_commit_queue):
2938         (test_commit_queue_failure):
2939         (test_commit_queue_failure_with_failing_tests):
2940         (test_rollout):
2941         (test_rollout_lands):
2942         (test_auto_retry):
2943         (test_manual_reject_during_processing):
2944         (test_report_flaky_tests):
2945         (StyleQueueTest.test_style_queue_with_style_exception):
2946         (test_style_queue_with_watch_list_exception):
2947         * Scripts/webkitpy/tool/commands/queuestest.py:
2948         (QueuesTest._default_begin_work_queue_logs):
2949         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2950         (RollCommandsTest.test_update_chromium_deps):
2951         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2952         (UploadCommandsTest.test_assign_to_committer):
2953         (test_post):
2954         (test_attach_to_bug):
2955         (test_attach_to_bug_no_description_or_comment):
2956         (test_land_safely):
2957         (test_prepare):
2958         (test_upload):
2959         (test_mark_bug_fixed):
2960         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
2961         (ApplyWatchListTest.test_apply_watch_list_local):
2962         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2963         (CommitTest._test_check_test_expectations):
2964         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2965         (RunTestsTest.test_webkit_run_unit_tests):
2966         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2967         (StepsTest._assert_step_output_with_bug):
2968         (StepsTest._assert_post_diff_output_for_bug):
2969         (StepsTest.test_post_diff):
2970         (StepsTest.test_post_diff_for_commit):
2971         (StepsTest.test_ensure_bug_is_open_and_assigned):
2972         (StepsTest.test_runtests_args):
2973         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
2974         (SuggestReviewersTest.test_basic):
2975         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2976         (ValidateChangeLogsTest._assert_start_line_produces_output):
2977
2978 2012-11-27  Pratik Solanki  <psolanki@apple.com>
2979
2980         objc/objc-runtime.h does not exist on all PLATFORM(MAC)
2981         https://bugs.webkit.org/show_bug.cgi?id=101780
2982
2983         Reviewed by Brent Fulgham.
2984
2985         Clean up header includes so we don't include objc/objc-runtime.h.
2986
2987         * DumpRenderTree/mac/DumpRenderTree.mm:
2988         * DumpRenderTree/mac/ObjCPlugin.m:
2989         * TestWebKitAPI/mac/InstanceMethodSwizzler.h:
2990         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2991
2992 2012-11-27  Marja Hölttä  <marja@chromium.org>
2993
2994         Add callbacks to the FrameLoaderClient when a resource is requested
2995         https://bugs.webkit.org/show_bug.cgi?id=92761
2996
2997         Reviewed by Adam Barth.
2998
2999         In Chromium, when an extension script cancels a network
3000         request (which happens out of process), we'd like to
3001         notify content scripts running on the current page about
3002         which elements failed to load because the requests were
3003         cancelled (as opposed to e.g. the network request just
3004         didn't work). Since the resource request itself does not
3005         carry any information what DOM element is was made for,
3006         currently a content script has to search the DOM tree and
3007         guess which requests will be cancelled by its counter
3008         part. By adding these callbacks, the embedder can make
3009         this connection explictly.
3010
3011         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3012         (DRTTestRunner::DRTTestRunner):
3013         (DRTTestRunner::dumpResourceRequestCallbacks):
3014         (DRTTestRunner::reset):
3015         * DumpRenderTree/chromium/DRTTestRunner.h:
3016         (DRTTestRunner):
3017         (DRTTestRunner::setShouldDumpResourceRequestCallbacks):
3018         (DRTTestRunner::shouldDumpResourceRequestCallbacks):
3019         * DumpRenderTree/chromium/TestShell.h:
3020         (TestShell::shouldDumpResourceRequestCallbacks):
3021         * DumpRenderTree/chromium/WebViewHost.cpp:
3022         (WebViewHost::willRequestResource):
3023         * DumpRenderTree/chromium/WebViewHost.h:
3024         (WebViewHost):
3025
3026 2012-11-27  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3027
3028         [GStreamer] Verify if GStreamer was previously initialized
3029         https://bugs.webkit.org/show_bug.cgi?id=103151
3030
3031         Reviewed by Philippe Normand.
3032
3033         This patch adds the gst_init() in GtkLauncher, so we can add the
3034         GStreamer options in the command line through
3035         gst_init_get_option_group().
3036
3037         This approach is not valid for MiniBrowser because it uses WebKit2,
3038         where the GStreamer backend lives in the web process, which is
3039         different from the UI process.
3040
3041         * GNUmakefile.am:
3042         * GtkLauncher/main.c:
3043         (main):
3044
3045 2012-11-27  Andras Becsi  <andras.becsi@digia.com>
3046
3047         [Qt] Fix the build with new Qt5 hash
3048         https://bugs.webkit.org/show_bug.cgi?id=103406
3049
3050         Reviewed by Csaba Osztrogonác.
3051
3052         Remove references to deprecated QApplication::GuiServer which
3053         has been removed, and use QStyleFactory::create instead of
3054         instantiating a QWindowsStyle directly since it is about to
3055         become an internal class.
3056
3057         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3058         (main):
3059         * QtTestBrowser/qttestbrowser.cpp:
3060         (LauncherApplication::LauncherApplication):
3061         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3062         (WTR::InjectedBundle::platformInitialize):
3063
3064 2012-11-27  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3065
3066         [style] Add a style-check for enum-member names
3067         https://bugs.webkit.org/show_bug.cgi?id=103157
3068
3069         Reviewed by Daniel Bates.
3070
3071         * Scripts/webkitpy/style/checkers/cpp.py:
3072         (_EnumState):
3073         (_EnumState.__init__):
3074         (_EnumState.process_clean_line):
3075         (check_enum_casing):
3076         (check_style):
3077         (process_line):
3078         (_process_lines):
3079         (CppChecker):
3080         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3081         (NoNonVirtualDestructorsTest.test_enum_casing):
3082         (NoNonVirtualDestructorsTest.test_internal_braces.Foo):
3083
3084 2012-11-26  Ryuan Choi  <ryuan.choi@gmail.com>
3085
3086         [EFL][jhbuild] Disable unnecessary options of elementary module
3087         https://bugs.webkit.org/show_bug.cgi?id=103360
3088
3089         Reviewed by Gyuyoung Kim.
3090
3091         When jhbuild configures elementary, unnecessary options may be enabled by
3092         user installed modules and it causes build break.
3093
3094         * efl/jhbuild.modules:
3095         Added --disable-emap --disable-ethumb --disable-eweather to elementary.
3096
3097 2012-11-26  Varun Jain  <varunjain@chromium.org>
3098
3099         LongPress and LongTap gestures should start drag/drop and open context menu respectively.
3100         https://bugs.webkit.org/show_bug.cgi?id=101545
3101
3102         Reviewed by Antonio Gomes.
3103
3104         For LongPress, we simulate drag by sending a mouse down and mouse drag
3105         events. If a drag is not started (because maybe there is no draggable
3106         element), then we show context menu instead (which is the current
3107         behavior for LongPress). For LongTap, we use the existing functions that
3108         LongPress uses to summon the context menu. LongPress initiated drag and
3109         drop can be enabled/disabled by the platform using the Setting
3110         touchDragDropEnabled which is disabled by default.
3111
3112         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3113         (WebTestRunner):
3114         (WebTestRunner::EventSender::EventSender):
3115         (WebTestRunner::EventSender::gestureLongTap):
3116         (WebTestRunner::EventSender::gestureEvent):
3117         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
3118         (EventSender):
3119         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3120         (WebTestRunner::TestRunner::TestRunner):
3121         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
3122         (WebTestRunner):
3123         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3124         (TestRunner):
3125
3126 2012-11-26  Christophe Dumez  <christophe.dumez@intel.com>
3127
3128         [EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
3129         https://bugs.webkit.org/show_bug.cgi?id=103224
3130
3131         Reviewed by Laszlo Gombos.
3132
3133         Add --local-storage command line argument to MiniBrowser to
3134         explicitely disable HTML5 local storage functionality. This
3135         is useful for testing purposes.
3136
3137         * MiniBrowser/efl/main.c:
3138         (window_create):
3139         (elm_main):
3140
3141 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
3142
3143         Remove use of deprecated logging from most of webkitpy.tool
3144         https://bugs.webkit.org/show_bug.cgi?id=103180
3145
3146         Reviewed by Dirk Pranke.
3147
3148         Remove calls to log and error methods of the deprecated_logging module, replacing them
3149         by using Python's Logger objects. This patch covers the switch in all of webkitpy.tool
3150         except the QueueEngine.
3151
3152         Unit tests are adjusted for these changes, moving output from expected stderr to expected logs.
3153
3154         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3155         (MockCommitQueue.run_command):
3156         (MockCommitQueue.command_passed):
3157         (MockCommitQueue.command_failed):
3158         (MockCommitQueue.report_flaky_tests):
3159         (MockCommitQueue.archive_last_test_results):
3160         (CommitQueueTaskTest._run_through_task):
3161         (CommitQueueTaskTest.test_success_case):
3162         (test_fast_success_case):
3163         (test_clean_failure):
3164         (test_update_failure):
3165         (test_apply_failure):
3166         (test_validate_changelog_failure):
3167         (test_build_failure):
3168         (test_red_build_failure):
3169         (test_flaky_test_failure):
3170         (test_failed_archive):
3171         (test_double_flaky_test_failure):
3172         (test_test_failure):
3173         (test_red_test_failure):
3174         (test_very_red_tree_retry):
3175         (test_red_tree_patch_rejection):
3176         (test_land_failure):
3177         * Scripts/webkitpy/tool/bot/feeders.py:
3178         (CommitQueueFeeder._update_work_items):
3179         (EWSFeeder.feed):
3180         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3181         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3182         (LayoutTestResultsReader.archive):
3183         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3184         (test_archive_last_layout_test_results):
3185         * Scripts/webkitpy/tool/bot/sheriff.py:
3186         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3187         (AbstractSequencedCommand.execute):
3188         * Scripts/webkitpy/tool/commands/commandtest.py:
3189         (CommandsTest.assert_execute_outputs):
3190         * Scripts/webkitpy/tool/commands/download.py:
3191         (AbstractPatchProcessingCommand._process_patch.execute):
3192         (ProcessBugsMixin._fetch_list_of_patches_to_process):
3193         (ProcessURLsMixin._fetch_list_of_patches_to_process):
3194         (AbstractRolloutPrepCommand._commit_info):
3195         * Scripts/webkitpy/tool/commands/download_unittest.py:
3196         (AbstractRolloutPrepCommandTest.test_commit_info):
3197         (DownloadCommandsTest.test_build):
3198         (DownloadCommandsTest.test_build_and_test):
3199         (test_apply_attachment):
3200         (test_apply_from_bug):
3201         (test_apply_watch_list):
3202         (test_land):
3203         (test_land_red_builders):
3204         (test_check_style):
3205         (test_build_attachment):
3206         (test_land_attachment):
3207         (test_land_from_bug):
3208         (test_land_from_url):
3209         (test_prepare_rollout):
3210         (test_create_rollout):
3211         (test_create_rollout_resolved):
3212         (test_rollout):
3213         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3214         (AbstractEarlyWarningSystem.handle_script_error.does):
3215         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3216         (EarlyWarningSytemTest._default_expected_stderr):
3217         (EarlyWarningSytemTest._default_expected_logs):
3218         (EarlyWarningSytemTest._test_testing_ews):
3219         * Scripts/webkitpy/tool/commands/openbugs.py:
3220         (OpenBugs.execute):
3221         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3222         (OpenBugsTest.test_args_parsing):
3223         * Scripts/webkitpy/tool/commands/perfalizer.py:
3224         (Perfalizer.handle_unexpected_error):
3225         * Scripts/webkitpy/tool/commands/queries.py:
3226         (PatchesInCommitQueue.execute):
3227         (PatchesToCommitQueue._needs_commit_queue):
3228         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3229         (QueryCommandsTest.test_bugs_to_commit):
3230         (QueryCommandsTest.test_patches_in_commit_queue):
3231         (QueryCommandsTest.test_patches_to_commit_queue):
3232         * Scripts/webkitpy/tool/commands/queues.py:
3233         (AbstractQueue._cc_watchers):
3234         (AbstractQueue.begin_work_queue):
3235         (FeederQueue.handle_unexpected_error):
3236         (CommitQueue.handle_script_error):
3237         (AbstractReviewQueue.handle_unexpected_error):
3238         (AbstractReviewQueue.handle_script_error):
3239         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3240         (test_auto_retry):
3241         * Scripts/webkitpy/tool/commands/queuestest.py:
3242         (QueuesTest.assert_outputs):
3243         (QueuesTest._default_begin_work_queue_stderr):
3244         (QueuesTest):
3245         (QueuesTest._default_begin_work_queue_logs):
3246         (QueuesTest.assert_queue_outputs):
3247         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3248         (RollCommandsTest.test_update_chromium_deps):
3249         (test_update_chromium_deps_older_revision):
3250         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3251         (SheriffBot.handle_unexpected_error):
3252         * Scripts/webkitpy/tool/commands/stepsequence.py:
3253         (StepSequence.run_and_handle_errors):
3254         * Scripts/webkitpy/tool/commands/upload.py:
3255         (AssignToCommitter._assign_bug_to_last_patch_attacher):
3256         (AbstractPatchUploadingCommand._prepare_state):
3257         (PostCommits.execute):
3258         (MarkBugFixed._determine_bug_id_and_svn_revision):
3259         (MarkBugFixed.execute):
3260         (CreateBug.create_bug_from_commit):
3261         (CreateBug.execute):
3262         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3263         (test_obsolete_attachments):
3264         (test_land_safely):
3265         (test_mark_bug_fixed):
3266         * Scripts/webkitpy/tool/multicommandtool.py:
3267         (Command.check_arguments_and_execute):
3268         (MultiCommandTool.main):
3269         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
3270         (CommandTest.test_required_arguments):
3271         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:
3272         (AddSvnMimetypeForPng.run):
3273         * Scripts/webkitpy/tool/steps/applypatch.py:
3274         (ApplyPatch.run):
3275         * Scripts/webkitpy/tool/steps/build.py:
3276         (Build.run):
3277         * Scripts/webkitpy/tool/steps/checkstyle.py:
3278         * Scripts/webkitpy/tool/steps/closebug.py:
3279         (CloseBug.run):
3280         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
3281         (CloseBugForLandDiff.run):
3282         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3283         (CloseBugForLandDiffTest.test_empty_state):
3284         * Scripts/webkitpy/tool/steps/commit.py:
3285         (Commit.run):
3286         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3287         (CommitTest._test_check_test_expectations):
3288         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
3289         (EnsureLocalCommitIfNeeded.run):
3290         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
3291         (ObsoletePatches.run):
3292         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3293         (PrepareChangeLog.run):
3294         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3295         (ReopenBugAfterRollout.run):
3296         * Scripts/webkitpy/tool/steps/runtests.py:
3297         (RunTests.run):
3298         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3299         (RunTestsTest.test_webkit_run_unit_tests):
3300         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3301         (StepsTest.test_update_step):
3302         (StepsTest.test_runtests_args):
3303         * Scripts/webkitpy/tool/steps/update.py:
3304         (Update.run):
3305         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3306         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
3307         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_multipatch_bug):
3308         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3309         (UpdateChangeLogsWithReviewer._guess_reviewer_from_bug):
3310         (UpdateChangeLogsWithReviewer.run):
3311         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
3312         (UpdateChromiumDEPS._validate_revisions):
3313         (UpdateChromiumDEPS.run):
3314         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3315         (ValidateChangeLogs._check_changelog_diff):
3316         (ValidateChangeLogs.run):
3317         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3318         (ValidateChangeLogsTest._assert_start_line_produces_output):
3319         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3320         (ValidateReviewer.run):
3321
3322 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
3323
3324         Coverage testing in webkitpy should omit some paths
3325         https://bugs.webkit.org/show_bug.cgi?id=103267
3326
3327         Reviewed by Dirk Pranke.
3328
3329         Omit testing coverage of any file under /usr directory and any file
3330         that is of third party origin and was autoinstalled.
3331
3332         * Scripts/webkitpy/test/main.py:
3333         (Tester._run_tests):
3334
3335 2012-11-26  Jaehun Lim  <ljaehun.lim@samsung.com>
3336
3337         Text Autosizing: Add Text Autosizing APIs for WK2
3338         https://bugs.webkit.org/show_bug.cgi?id=100633
3339
3340         Reviewed by Sam Weinig.
3341
3342         Add test cases for Text Autosizing in WKPreferences.
3343
3344         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3345         (TestWebKitAPI::TEST):
3346
3347 2012-11-26  Pierre Rossi  <pierre.rossi@gmail.com>
3348
3349         [Qt] REGRESSION(r135575): It made all tests assert
3350         https://bugs.webkit.org/show_bug.cgi?id=103169
3351
3352         Reviewed by Simon Hausmann.
3353
3354         This fixes another regression introduced in r135515:
3355         initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
3356         since it can be called from WebKit2 to initialize QStyle for testing.
3357         This would then lead to things such as PlatformStrategies being
3358         initialized twice.
3359
3360         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Also propagate the change to DRT this time.
3361         (WebCore::DumpRenderTree::DumpRenderTree):
3362
3363 2012-11-24  Zan Dobersek  <zandobersek@gmail.com>
3364
3365         Add the --order option to NRWT
3366         https://bugs.webkit.org/show_bug.cgi?id=102229
3367
3368         Reviewed by Dirk Pranke.
3369
3370         The --order option controls in what order the gathered tests will be run.
3371         There are 3 options:
3372         - natural, the tests are sorted in natural order,
3373         - random, the tests are sorted in random order,
3374         - none, the tests are kept in the order in which they were specified through
3375         arguments or the test list.
3376
3377         The natural option is the default one and maintains the current behavior.
3378
3379         The none option is primarily intended to be used with the --test-list option,
3380         with the test list file expected to list specific test names.
3381         When a directory is specified as one of the paths from under which tests should
3382         be gathered and the none option is used, that path will expand to all the tests
3383         under it, with these tests sorted in the natural order.
3384
3385         Using --order=random duplicated the behavior of the --randomize-order option, so
3386         the latter is removed.
3387
3388         This patch also incorporates the change with which makes it is possible to specify
3389         a test via arguments or the test list multiple tests and then have the test run
3390         that many times.
3391
3392         * Scripts/webkitpy/common/find_files.py:
3393         (find): Accept an optional sorting key that is used to sort files found in the directories
3394         that the given paths specify.
3395         (_normalized_find): Both paths that are then searched for the tests and the tests that
3396         were found are now kept in lists. This makes it possible to run a test multiple times
3397         by specifying it multiple times through arguments or the test list file.
3398         (_normalized_find.sort_by_directory_key):
3399         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3400         (LayoutTestFinder.find_tests): Keep the paths where we should search for tests in a list.
3401         (LayoutTestFinder.skip_tests): Subtracting from a set of paths is necessary.
3402         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3403         (LayoutTestRunner.__init__): The Sharder class no longer needs a test path separator.
3404         (Sharder.__init__): Ditto.
3405         (Sharder._resize_shards):
3406         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3407         (SharderTests.get_shards): Modify the Shader initializing as required.
3408         (SharderTests.test_multiple_locked_shards): The natural sorting and test name key unit tests
3409         are now moved to the base Port unit tests.
3410         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3411         (Manager._prepare_lists): Keep the test names in a list. Order that list as specified by
3412         the new --order option.
3413         * Scripts/webkitpy/layout_tests/port/base.py:
3414         (Port.tests): This method should now return a list of all the tests found in the specified
3415         paths.
3416         (Port._real_tests): A list is required, so no conversion to a set is made.
3417         (Port):
3418         (Port.test_key): Place this method here for now, but it should really move into a separate
3419         module.
3420         (Port._natural_sort_key): Ditto.
3421         (Port._natural_sort_key.tryint):
3422         (Port._virtual_tests): A list is required, so the function now operates on that rather than
3423         on a set.
3424         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3425         (PortTest.test_find_with_skipped_directories_2): Adjust the test case to check for an empty
3426         list rather than an empty set.
3427         (PortTest.test_dont_require_http_server):
3428         (NaturalCompareTest): The natural sorting unit tests are placed here for now.
3429         (NaturalCompareTest.assert_cmp):
3430         (NaturalCompareTest.test_natural_compare):
3431         (KeyCompareTest): The test name key unit tests are placed here for now.
3432         (KeyCompareTest.assert_cmp):
3433         (KeyCompareTest.test_test_key):
3434         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3435         (parse_args): Remove the --randomize-order option, it's now possible to replicate its behavior
3436         by using --order=random.
3437         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Add unit tests covering
3438         various aspects of this change.
3439         (MainTest.test_natural_order):
3440         (MainTest):
3441         (MainTest.test_natural_order_test_specified_multiple_times):
3442         (MainTest.test_random_order):
3443         (MainTest.test_random_order_test_specified_multiple_times):
3444         (MainTest.test_no_order):
3445         (MainTest.test_no_order_test_specified_multiple_times):
3446         (MainTest.test_no_order_with_directory_entries_in_natural_order):
3447         * Scripts/webkitpy/tool/commands/queries.py:
3448         (PrintExpectations.execute): Operate on a set of tests when printing out expectations.
3449
3450 2012-11-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3451
3452         Unreviewed, rolling out r135600.
3453         http://trac.webkit.org/changeset/135600
3454         https://bugs.webkit.org/show_bug.cgi?id=103173
3455
3456         It made EFL API test is failed (Requested by gyuyoung_mbp on
3457         #webkit).
3458
3459         * TestWebKitAPI/PlatformEfl.cmake:
3460         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3461         (TestWebKitAPI::Util::sleep):
3462         * TestWebKitAPI/efl/PlatformWebView.cpp:
3463
3464 2012-11-23  Alexis Menard  <alexis@webkit.org>
3465
3466         [CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
3467         https://bugs.webkit.org/show_bug.cgi?id=102104
3468
3469         Reviewed by Julien Chaffraix.
3470
3471         Protect the new feature behind a feature flag.
3472
3473         * Scripts/webkitperl/FeatureList.pm:
3474         * qmake/mkspecs/features/features.pri:
3475
3476 2012-11-23  Mario Sanchez Prada  <mario@webkit.org>
3477
3478         Unreviewed. Update my e-mail address.
3479
3480         * Scripts/webkitpy/common/config/committers.py:
3481
3482 2012-11-23  Mateusz Leszko  <m.leszko@samsung.com>
3483
3484         [EFL][GTK] Adapt accessibility feature to WebKitTestRunner.
3485         https://bugs.webkit.org/show_bug.cgi?id=100757
3486
3487         Reviewed by Laszlo Gombos.
3488
3489         Allow to build accessibility feature in WebkitTestRunner for EFL Platform.
3490         Updating CMake files due to changes from Bug 99011.
3491
3492         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3493         (WTR::AccessibilityController::AccessibilityController):
3494         (WTR):
3495         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3496         (AccessibilityController):
3497         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3498         (WTR):
3499         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3500         (AccessibilityUIElement):
3501         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: - Removed gtk/gtk.h dependency.
3502         * WebKitTestRunner/PlatformEfl.cmake: - Adding atk includes.
3503
3504 2012-11-16  Yury Semikhatsky  <yurys@chromium.org>
3505
3506         Memory instrumentation: extract MemoryObjectInfo declaration into a separate file
3507         https://bugs.webkit.org/show_bug.cgi?id=102510
3508
3509         Reviewed by Pavel Feldman.
3510
3511         Added missing includes.
3512
3513         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3514
3515 2012-11-23  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3516
3517         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
3518         https://bugs.webkit.org/show_bug.cgi?id=103123
3519
3520         Reviewed by Kenneth Rohde Christiansen.
3521
3522         Add support for PlatformWebView::simulateSpacebarKeyPress() and enable
3523         WebKit2 API test ResponsivenessTimerDoesntFireEarly.
3524
3525         * TestWebKitAPI/PlatformEfl.cmake: Enable ResponsivenessTimerDoesntFireEarly
3526         test.
3527         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3528         (TestWebKitAPI::Util::sleep): Use usleep() instead of sleep since the
3529         test case is passing 0.5 seconds to sleep.
3530         * TestWebKitAPI/efl/PlatformWebView.cpp:
3531         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Implemented.
3532         (TestWebKitAPI):
3533
3534 2012-11-23  Wojciech Bielawski  <w.bielawski@samsung.com>
3535
3536         [WK2][WKTR] WebKitTestRunner needs eventSender.contextClick()
3537         https://bugs.webkit.org/show_bug.cgi?id=86881
3538
3539         Reviewed by Kenneth Rohde Christiansen.
3540
3541         eventSender object extended with contextClick() method in WebKitTestRunner.
3542         contextClick() method returns an array of menu items objects with field 'title' containing title of single
3543         context menu entry. According to some tests menu items objects shall also support 'click()' method, but it's not
3544         delivered in this patch.
3545
3546         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3547         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3548         (WTR::EventSendingController::contextClick):
3549         (WTR):
3550         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3551         (EventSendingController):
3552
3553 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
3554
3555         [Qt] Compiling against QtWebkit API requires QT_DLL to be defined
3556         https://bugs.webkit.org/show_bug.cgi?id=102942
3557
3558         Reviewed by Tor Arne Vestbø.
3559
3560         Remove the requirement of having QT_DLL defined in order for the QWEBKIT_EXPORT
3561         macro to be defined as Q_DECL_IMPORT. Instead unify the export macro definition
3562         to follow the same rules as other Qt 5 modules, with the exception that instead of
3563         QT_BUILD_WEBKIT_LIB we continue to use BUILDING_WEBKIT, because that's used also
3564         in other cross-platform header files to determine the correct meaning of export
3565         macros.
3566
3567         * qmake/mkspecs/features/default_post.prf:
3568         * qmake/mkspecs/features/win32/default_post.prf:
3569
3570 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
3571
3572         [Qt] QWebPage::shouldInterruptJavaScript should be virtual in Qt 5
3573         https://bugs.webkit.org/show_bug.cgi?id=103111
3574
3575         Reviewed by Kenneth Rohde Christiansen.
3576
3577         This function was added as a slot during Qt 4.x times because adding
3578         virtual functions breaks binary compatibility. This constraint is gone
3579         with the initial release of WebKit with Qt 5, and therefore we can
3580         make it virtual now.
3581
3582         The change is fully source compatible as existing "re-implementations"
3583         as slots will now be called through it being a virtual function. They
3584         become unused slots.
3585
3586         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3587         (WebCore::WebPage::shouldInterruptJavaScript):
3588         (WebPage):
3589         * QtTestBrowser/webpage.h:
3590         (WebPage):
3591
3592 2012-11-22  Peter Beverloo  <peter@chromium.org>
3593
3594         [Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
3595         https://bugs.webkit.org/show_bug.cgi?id=103065
3596
3597         Reviewed by Dirk Pranke.
3598
3599         This addresses two further reliability issues in the Android test running
3600         scripts. Firstly, the run_tests.py script needs to have the --exit_code
3601         argument passed in order to return non-zero codes, which we need for the
3602         build master to distinguish failures from successful runs.
3603
3604         Secondly, it modifies the layout test runner to briefly wait (through
3605         the wait-for-device command) after requesting a device to switch to root
3606         mode. Without this waiting period, commands might get lost and thereby
3607         unexpectedly fail.
3608
3609         * Scripts/run-api-tests:
3610         * Scripts/run-chromium-webkit-unit-tests:
3611         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3612         (ChromiumAndroidDriver._setup_test):
3613         (ChromiumAndroidDriver._restart_adb_as_root):
3614
3615 2012-11-22  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi <pierre.rossi@digia.com>
3616
3617         [Qt] Separate QWidget dependant code into separate WebKitWidgets static library
3618         https://bugs.webkit.org/show_bug.cgi?id=102800
3619
3620         Reviewed by Tor Arne Vestbø.
3621
3622         This patch separates code that needs to use QWidget related APIs in
3623         WebKit/qt/WebCoreSupport and Api from code that doesn't. This means for
3624         example FrameLoaderClientQt.cpp remains in the WebKit1 static library,
3625         while qwebpage.cpp and qwebframe.cpp become part of the WebKitWidgets
3626         static library. WebKit1 is compiled without QT += widgets and therefore
3627         any widget related dependency has been moved "up" and out of WebKit1 into
3628         the WebKitWidgets library.
3629
3630         Between the code in WebKit.a and WebKitWidgets.a new adapters and
3631         interfaces have been introduced, such as QWebPageAdapter and
3632         QWebFrameAdapter. QWebPageAdapter, when used from WebKit1, is a way to
3633         call out into the API layer, implemented by QWebPage (QWebPagePrivate).
3634         The other way around if QWebPage wants to access WebCore or
3635         WebCoreSupport related functionality, it will go through
3636         QWebPageAdapater (as base class). The separation in the direction up
3637         into the API layer is complete with this patch, no code in WebKit1
3638         depends on QtWidgets. The separation the other way around, code in the
3639         API layer not using any WebCore types, is not complete yet.
3640
3641         Some classes such as QWebSettings, QWebElement or
3642         DumpRenderTreeSupportQt remain in WebKit1. While they are API layer,
3643         they do not depend on widget related Qt APIs and they make much more
3644         use of WebCore internal APIs and therefore are easier to keep in
3645         WebKit1.
3646
3647         In the future we plan to place a real shared library boundary between
3648         WebKit1 and WebKitWidgets, by keeping the WebKit1 static library as
3649         part of the QtWebKit shared library and by turning the WebKitWidgets
3650         static library into a shared one.
3651
3652         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3653         (WebCore::WebPage::resetSettings):
3654         (WebCore::WebPage::createWindow):
3655         (WebCore::DumpRenderTree::DumpRenderTree):
3656         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3657         (WebCore::DumpRenderTree::initJSObjects):
3658         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
3659         (WebCore::DumpRenderTree::dumpFramesAsText):
3660         (WebCore::DumpRenderTree::dump):
3661         (WebCore::DumpRenderTree::createWindow):
3662         (WebCore::DumpRenderTree::pageAdapter):
3663         (WebCore):
3664         (WebCore::DumpRenderTree::mainFrameAdapter):
3665         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3666         (DumpRenderTree):
3667         * DumpRenderTree/qt/EventSenderQt.cpp:
3668         (EventSender::contextClick):
3669         (EventSender::scalePageBy):
3670         * DumpRenderTree/qt/TestRunnerQt.cpp:
3671         (TestRunner::reset):
3672         (TestRunner::display):
3673         (TestRunner::closeWebInspector):
3674         (TestRunner::showWebInspector):
3675         (TestRunner::evaluateInWebInspector):
3676         (TestRunner::setFrameFlatteningEnabled):
3677         (TestRunner::goBack):
3678         (TestRunner::setDefersLoading):
3679         (TestRunner::pauseAnimationAtTimeOnElementWithId):
3680         (TestRunner::pauseTransitionAtTimeOnElementWithId):
3681         (TestRunner::numberOfActiveAnimations):
3682         (TestRunner::setCaretBrowsingEnabled):
3683         (TestRunner::setAuthorAndUserStylesEnabled):
3684         (TestRunner::callShouldCloseOnWebView):
3685         (TestRunner::setSmartInsertDeleteEnabled):
3686         (TestRunner::setSelectTrailingWhitespaceEnabled):
3687         (TestRunner::execCommand):
3688         (TestRunner::isCommandEnabled):
3689         (TestRunner::findString):
3690         (TestRunner::elementDoesAutoCompleteForElementWithId):
3691         (TestRunner::setMockDeviceOrientation):
3692         (TestRunner::setGeolocationPermission):
3693         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3694         (TestRunner::setMockGeolocationPositionUnavailableError):
3695         (TestRunner::setMockGeolocationPosition):
3696         (TestRunner::evaluateScriptInIsolatedWorld):
3697         (TestRunner::addUserStyleSheet):
3698         (TestRunner::setMinimumTimerInterval):
3699         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3700         (TextInputController::selectedRange):
3701         (TextInputController::firstRectForCharacterRange):
3702         (TextInputController::unmarkText):
3703         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
3704         (LoadAlternateHTMLStringItem::invoke):
3705         * qmake/mkspecs/features/default_post.prf:
3706         * qmake/mkspecs/features/production_build.prf:
3707         * qmake/mkspecs/features/webkit_modules.prf:
3708         * qmake/mkspecs/modules/webkitwidgets.prf: Added.
3709
3710 2012-11-22  Christophe Dumez  <christophe.dumez@intel.com>
3711
3712         WebKitTestRunner needs layoutTestController.setCacheModel
3713         https://bugs.webkit.org/show_bug.cgi?id=42684
3714
3715         Reviewed by Kenneth Rohde Christiansen.
3716
3717         Add support for testRunner.setCacheModel to WebKitTestRunner.
3718
3719         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3720         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3721         (WTR::InjectedBundle::beginTesting):
3722         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3723         (WTR::TestRunner::setCacheModel):
3724         (WTR):
3725         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3726         (TestRunner):
3727
3728 2012-11-22  Balazs Kelemen  <kbalazs@webkit.org>
3729
3730         [Qt][WTR] TestController::platformRunUntil should not do busy waiting
3731         https://bugs.webkit.org/show_bug.cgi?id=101327
3732
3733         Reviewed by Simon Hausmann.
3734
3735         Avoid busy waiting for events in platformRunUntil while making
3736         sure we don't change the behavior of modal event loops.
3737
3738         * WebKitTestRunner/TestController.cpp:
3739         (WTR::TestController::~TestController):
3740         * WebKitTestRunner/TestController.h:
3741         (TestController):
3742         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3743         (WTR::TestController::platformDestroy):
3744         (WTR):
3745         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3746         (WTR::TestController::platformDestroy):
3747         (WTR):
3748         * WebKitTestRunner/mac/TestControllerMac.mm:
3749         (WTR::TestController::platformDestroy):
3750         (WTR):
3751         * WebKitTestRunner/qt/TestControllerQt.cpp:
3752         (TestController::RunLoop): Helper class to handle
3753         the event loop logic
3754         (WTR):
3755         (WTR::TestController::RunLoop::RunLoop):
3756         (WTR::TestController::RunLoop::runUntil): Use QEventLoop to implement
3757         the run loop. This is the appropriate API to push the WaitForMoreEvents
3758         flag to QCoreApplication::processEvents and also being able to exit the
3759         loop if we have timed out.
3760         (WTR::TestController::RunLoop::notifyDone):
3761         (WTR::TestController::RunLoop::timerFired):
3762         (WTR::TestController::RunLoop::runModal):
3763         (WTR::TestController::notifyDone):
3764         (WTR::TestController::platformInitialize):
3765         (WTR::TestController::platformDestroy):
3766         (WTR::TestController::platformRunUntil):
3767         (WTR::TestController::runModal):
3768         * WebKitTestRunner/win/TestControllerWin.cpp:
3769         (WTR::TestController::platformDestroy):
3770         (WTR):
3771
3772 2012-11-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3773
3774         [EFL][WK2] Enable WKPreferences and AboutBlankLoad API tests
3775         https://bugs.webkit.org/show_bug.cgi?id=102926
3776
3777         Reviewed by Kenneth Rohde Christiansen.
3778
3779         Add missing bits needed by WKPreferences and AboutBlankLoad API
3780         tests in the test harness and enable these tests on EFL port.
3781
3782         * TestWebKitAPI/PlatformEfl.cmake:
3783         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3784         (TestWebKitAPI::TEST):
3785         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3786         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3787         (Util):
3788
3789 2012-11-21  Zan Dobersek  <zandobersek@gmail.com>
3790
3791         [GTK][WTR] Implement AccessibilityUIElement::stringValue
3792         https://bugs.webkit.org/show_bug.cgi?id=102951
3793
3794         Reviewed by Martin Robinson.
3795
3796         Implement AccessibilityUIElement::stringValue in the ATK backend
3797         in the same manner it is implemented in DumpRenderTree.
3798
3799         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3800         (WTR::replaceCharactersForResults):
3801         (WTR):
3802         (WTR::AccessibilityUIElement::stringValue):
3803
3804 2012-11-21  Vineet Chaudhary  <rgf748@motorola.com>
3805
3806         Unreviewed. Adding myself to committers.py.
3807
3808         * Scripts/webkitpy/common/config/committers.py:
3809
3810 2012-11-21  Tien-Ren Chen  <trchen@chromium.org>
3811
3812         [chromium] Device scale factor should be no-op when applyDeviceScaleFactorInCompositor == 0
3813         https://bugs.webkit.org/show_bug.cgi?id=100061
3814
3815         Reviewed by Adam Barth.
3816
3817         On Android we're using a different pixel scaling implementation
3818         (WebCore::Settings::applyDefaultDeviceScaleFactorInCompositor() == 0) than other
3819         platforms. In this mode, we don't make use of device-independent pixels. Device
3820         scale factor is provided to WebKit and get merged into page scale factor. Other
3821         than that device scale factor should have no effects on rendering.
3822
3823         * DumpRenderTree/chromium/WebPreferences.cpp:
3824         (WebPreferences::applyTo):
3825
3826 2012-11-21  Fady Samuel  <fsamuel@chromium.org>
3827
3828         Clear MousePressed state on context menu to avoid initiating a drag
3829         https://bugs.webkit.org/show_bug.cgi?id=101786
3830
3831         Reviewed by Ojan Vafai.
3832
3833         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3834         (WebTestRunner):
3835         (WebTestRunner::EventSender::EventSender):
3836         (WebTestRunner::EventSender::contextClick):
3837         Only send a MouseUp on Windows. Keep the current mouse pressed state when
3838         calling up a context menu.
3839
3840 2012-11-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3841
3842         [EFL] KURL unit test crashing when tiled backing store is enabled on Release Bots
3843         https://bugs.webkit.org/show_bug.cgi?id=102895
3844
3845         Reviewed by Gyuyoung Kim.
3846
3847         Change the link order so it wont override the new operator on gtest.
3848         Looks like it was crashing because an allocator mismatch (using libc's
3849         new and later fastMalloc delete. Thanks to Kangil Han for hinting on
3850         the fastMalloc issue.
3851
3852         * TestWebKitAPI/CMakeLists.txt:
3853
3854 2012-11-21  Kentaro Hara  <haraken@chromium.org>
3855
3856         Unreviewed, rolling out r135340.
3857         http://trac.webkit.org/changeset/135340
3858         https://bugs.webkit.org/show_bug.cgi?id=102492
3859
3860         It broke Safari's internal build
3861
3862         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3863         (new):
3864         (GenerateModule):
3865         (GenerateInterface):
3866         (finish):
3867
3868 2012-11-21  Yael Aharon  <yael.aharon@intel.com>, Gyuyoung Kim <gyuyoung.kim@samsung.com>
3869
3870         [EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
3871         https://bugs.webkit.org/show_bug.cgi?id=101526
3872
3873         Reviewed by Kenneth Rohde Christiansen.
3874
3875         Turn on WTF_USE_TILED_BACKING_STORE for EFL port.
3876
3877         * Scripts/webkitperl/FeatureList.pm:
3878         * TestWebKitAPI/CMakeLists.txt: No include KURL.cpp because of API test crash.
3879
3880 2012-11-21  Jongseok Yang  <js45.yang@samsung.com>
3881
3882         [EFL][WK2] Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX
3883         https://bugs.webkit.org/show_bug.cgi?id=102867
3884
3885         Reviewed by Gyuyoung Kim.
3886
3887         Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX.
3888
3889         ewk_view_setting_encoding_custom_XXX APIs might be misunderstanded as the "setting" word
3890         because ewk_view_setting_encoding_custom_set triggers the "reload" operation.
3891         And ewk_view_setting_XXX is not correct because there is ewk_settings object for settings.
3892
3893         * MiniBrowser/efl/main.c:
3894         (on_key_down):
3895
3896 2012-11-20  Sheriff Bot  <webkit.review.bot@gmail.com>
3897
3898         Unreviewed, rolling out r133859.
3899         http://trac.webkit.org/changeset/133859
3900         https://bugs.webkit.org/show_bug.cgi?id=102875
3901
3902         This patch makes API test broken (Requested by gyuyoung on
3903         #webkit).
3904
3905         * Scripts/webkitperl/FeatureList.pm:
3906
3907 2012-11-20  Jinwoo Song  <jinwoo7.song@samsung.com>
3908
3909         [EFL][WK2] Add Ewk_Window_Features API and related UI callbacks
3910         https://bugs.webkit.org/show_bug.cgi?id=99114
3911
3912         Reviewed by Gyuyoung Kim.
3913
3914         Implemented window_create and window_close smartcallback functions.
3915
3916         * MiniBrowser/efl/main.c:
3917         (on_window_create):
3918         (on_window_close):
3919         (window_create):
3920
3921 2012-11-20  Ojan Vafai  <ojan@chromium.org>
3922
3923         Simplify builder filters now that we have lists of which builders run which tests
3924         https://bugs.webkit.org/show_bug.cgi?id=102849
3925
3926         Reviewed by Dirk Pranke.
3927
3928         We only need filters when we load the same master for multiple groups in the
3929         same test type, i.e. when we need to only include some of the builders that run
3930         a given test suite on a given master.
3931
3932         Also, get rid of the DEFAULT_BUILDER enum. We were always using the first builder anyways.
3933         Now just make it a method on BuilderGroup.
3934
3935         * TestResultServer/static-dashboards/builders.js:
3936         (BuilderGroup.prototype.append):
3937         (BuilderGroup.prototype.setup):
3938         (BuilderGroup.prototype._defaultBuilder):
3939         (BuilderGroup.prototype.master):
3940         (requestBuilderList):
3941         (isChromiumWebkitTipOfTreeTestRunner):
3942         (isChromiumWebkitDepsTestRunner):
3943         (loadBuildersList):
3944         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3945         (test):
3946
3947 2012-11-20  Ojan Vafai  <ojan@chromium.org>
3948
3949         Remove perfav master for webkit_unit_tests and test_shell_tests.
3950         There are no bots on this master that run these tests.
3951         * TestResultServer/static-dashboards/builders.js:
3952
3953 2012-11-20  Ojan Vafai  <ojan@chromium.org>
3954
3955         Remove special case for layout tests when builders fail to load
3956         https://bugs.webkit.org/show_bug.cgi?id=102842
3957
3958         Reviewed by Tony Chang.
3959
3960         Now that we load only builders that actually run the given test
3961         type, we can reliably show errors to the users because it
3962         represents a broken bot.
3963         * TestResultServer/static-dashboards/loader.js:
3964
3965 2012-11-15  Ojan Vafai  <ojan@chromium.org>
3966
3967         Generate a list of builders/test suites from the buildbot json
3968         https://bugs.webkit.org/show_bug.cgi?id=102443
3969
3970         Reviewed by Dirk Pranke.
3971
3972         Instead of the cludgy things we do now to track which bots run which tests,
3973         we generate all that data from the buildbots' json files.
3974         This is the minimal amount to keep everything working. Once this lands,
3975         we can also do a bunch of followup cleanup.
3976
3977         For now we commit the generated data. In theory, in the future, we could
3978         have the test results server generate the data on the fly.
3979
3980         For the sake of easily understanding what changes when we run the generate script,
3981         also checkin a pretty printed version of the output. The pretty printed version
3982         is too large to serve as part of the flakiness dashboard though.
3983
3984         This also has the benefit of making the dashboard load much faster since
3985         we no longer ever need to block on requests to buildbot.
3986
3987         * TestResultServer/generate_builders_json.py: Added.
3988         (master_json_url):
3989         (builder_json_url):
3990         (cached_build_json_url):
3991         (fetch_json):
3992         (insert_builder_and_test_data):
3993         (main):
3994         * TestResultServer/generate_builders_json_unittest.py: Added.
3995         (GenerateBuildersJsonTest):
3996         (GenerateBuildersJsonTest.test_master_json_url):
3997         (GenerateBuildersJsonTest.test_builder_json_url):
3998         (GenerateBuildersJsonTest.test_cached_build_json_url):
3999         (GenerateBuildersJsonTest.test_generate_json_data):
4000         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
4001         * TestResultServer/static-dashboards/builders-pretty.jsonp: Added.
4002         * TestResultServer/static-dashboards/builders.js:
4003         (LOAD_BUILDBOT_DATA):
4004         (BuilderGroup):
4005         (BuilderGroup.prototype.append):
4006         (BuilderGroup.prototype.master):
4007         (requestBuilderList):
4008         * TestResultServer/static-dashboards/builders.jsonp: Added.
4009         * TestResultServer/static-dashboards/builders_unittests.js: Added.
4010         * TestResultServer/static-dashboards/dashboard_base.js:
4011         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4012         (showPopupForBuild):
4013         (htmlForTestResults):
4014         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
4015         (loadExpectationsLayoutTests):
4016         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4017         (resetGlobals):
4018         (test):
4019         * TestResultServer/static-dashboards/loader.js:
4020         * TestResultServer/static-dashboards/loader_unittests.js:
4021         * TestResultServer/static-dashboards/run-embedded-unittests.html:
4022         * TestResultServer/static-dashboards/run-unittests.html:
4023         * TestResultServer/static-dashboards/timeline_explorer.html:
4024
4025 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
4026
4027         [WTR][Qt] Enable fixedLayout when needed by the test
4028         https://bugs.webkit.org/show_bug.cgi?id=102811
4029
4030         Reviewed by Kenneth Rohde Christiansen.
4031
4032         Create a flickable view for CSS Device Adaptation tests. This is
4033         crucial for testing them since they will change the size of the
4034         viewport.
4035
4036         * WebKitTestRunner/PlatformWebView.h:
4037         (PlatformWebView):
4038         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4039         (WTR::PlatformWebView::PlatformWebView):
4040         (WTR::PlatformWebView::viewSupportsOptions):
4041         (WTR):
4042         * WebKitTestRunner/qt/main.cpp:
4043         (main):
4044
4045 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
4046
4047         [WTR] WebKitTestRunner should be able to run tests using fixed layout
4048         https://bugs.webkit.org/show_bug.cgi?id=102517
4049
4050         Reviewed by Kenneth Rohde Christiansen.
4051
4052         WTR will now request the creation of a view that has a page using
4053         fixed layout for CSS Device Adaptation tests, but this feature might
4054         be used in the future by any other test that requires a mobile-like type
4055         of viewport (i.e. Viewport META tests should be ported).
4056
4057         The viewport type of the other tests remains unchanged and is restored
4058         when the runner leaves the device-adapt/ folder.
4059
4060         * WebKitTestRunner/PlatformWebView.h:
4061         (PlatformWebView):
4062         * WebKitTestRunner/TestInvocation.cpp:
4063         (WTR):
4064         (WTR::shouldUseFixedLayout):
4065         (WTR::updateLayoutType):
4066         (WTR::TestInvocation::invoke):
4067         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4068         (WTR::PlatformWebView::PlatformWebView):
4069         (WTR::PlatformWebView::viewSupportsOptions):
4070         (WTR):
4071
4072 2012-11-20  Csaba Osztrogonác  <ossy@webkit.org>
4073
4074         [Qt] REGRESSION(r128174): Fast build path doesn't work now
4075         https://bugs.webkit.org/show_bug.cgi?id=100360
4076
4077         Reviewed by Tor Arne Vestbø.
4078
4079         Use a separated .builtRevisions.cache file instead of .qmake.cache to cache built SVN revisions.
4080
4081         * Scripts/webkitdirs.pm:
4082         (buildQMakeProjects):
4083
4084 2012-11-20  Mateusz Leszko  <m.leszko@samsung.com>
4085
4086         [EFL][GTK]Sharing accessibility support in WebKitTestRunner.
4087         https://bugs.webkit.org/show_bug.cgi?id=99011
4088
4089         Reviewed by Martin Robinson.
4090
4091         Accessibility files from gtk folder are moved to atk folder due to common implementation. Event Type naming changed to default, from Gtk to ATK.
4092
4093         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp.
4094         (WTR::AccessibilityController::logAccessibilityEvents):
4095         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp.
4096
4097 2012-11-20  Zan Dobersek  <zandobersek@gmail.com>
4098
4099         webkitpy unit tests should run serially when checking code coverage
4100         https://bugs.webkit.org/show_bug.cgi?id=102693
4101
4102         Reviewed by Dirk Pranke.
4103
4104         When checking code coverage, the unit tests should not be run in parallel
4105         as this causes the tracing functions (set via sys.settrace in the coverage
4106         module) being overriden, resulting in incorrect coverage reports.
4107
4108         * Scripts/webkitpy/test/main.py:
4109         (Tester._run_tests):
4110
4111 2012-11-19  Viatcheslav Ostapenko  <v.ostapenko@samsung.com>
4112
4113         [EFL] Add fallback for WebkitTestRunner if opengl is not available.
4114         https://bugs.webkit.org/show_bug.cgi?id=102704
4115
4116         Reviewed by Laszlo Gombos.
4117
4118         Add fallback to non-opengl evas engine in WebkitTestRunner if opengl is not available.
4119
4120         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4121         (WTR::initEcoreEvas):
4122
4123 2012-11-19  Dimitri Glazkov  <dglazkov@chromium.org>
4124
4125         [garden-o-matic] Switch frontend to use the gardeningserver.
4126         https://bugs.webkit.org/show_bug.cgi?id=102712
4127
4128         Reviewed by Dirk Pranke.
4129
4130         Instead of serving garden-o-matic frontend as file, we now serve it from the gardening server. This enables
4131         using garden-o-matic in a Chrome OS device, with a separate machine as a headless server.
4132
4133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Changed CSP policy to use 'self'.
4134         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Removed now-unnecessary references to kLocalServerURL.
4135         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Tweaked the test expectation.
4136         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Removed kLocalServerURL.
4137         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Spuriously updated the name of the webkit-patch command.
4138         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Removed kLocalServerURL.
4139         * Scripts/webkitpy/tool/servers/gardeningserver.py: Changed to use the new launch URL.
4140
4141 2012-11-19  Sheriff Bot  <webkit.review.bot@gmail.com>
4142
4143         Unreviewed, rolling out r135172.
4144         http://trac.webkit.org/changeset/135172
4145         https://bugs.webkit.org/show_bug.cgi?id=102710
4146
4147         Broke some WebKit2 api tests :( (Requested by japhet on
4148         #webkit).
4149
4150         * DumpRenderTree/chromium/WebViewHost.cpp:
4151         (WebViewHost::updateForCommittedLoad):
4152
4153 2012-11-19  Dimitri Glazkov  <dglazkov@chromium.org>
4154
4155         [garden-o-matic] Enable serving garden-o-matic with gardeningserver.
4156         https://bugs.webkit.org/show_bug.cgi?id=102703
4157
4158         Reviewed by Ojan Vafai.
4159
4160         To enable gardening from a Chrome OS device, we need the ability to serve garden-o-matic
4161         from the same origin as the gardening server. This change gently massages the current
4162         logic to adapt an extension-sniffing-based approach of identifying static files,
4163         rather than requiring an explicit list.
4164
4165         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
4166         (ReflectionHandler): Replaced STATIC_FILE_NAMES with STATIC_FILE_EXTENSIONS.
4167         (ReflectionHandler._handle_request): Changed the logic to smell for extensions, rather than specific files.
4168         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py: Added.
4169
4170 2012-11-19  Ojan Vafai  <ojan@chromium.org>
4171
4172         Add DOM and HTML watchlists and add myself to a bunch of lists
4173         https://bugs.webkit.org/show_bug.cgi?id=102707
4174
4175         Reviewed by Eric Seidel.
4176
4177         * Scripts/webkitpy/common/config/watchlist:
4178
4179 2012-11-19  Jochen Eisinger  <jochen@chromium.org>
4180
4181         [chromium] move methods that only use the WebKit API from DRTTestRunner to TestRunner
4182         https://bugs.webkit.org/show_bug.cgi?id=102676
4183
4184         Reviewed by Tony Chang.
4185
4186         In addition, I've replaced parsePageNumber with the more commonly used
4187         cppVariantToInt32, moved abortModal to the list of stubbed out methods,
4188         and removed setAutomaticLinkDetectionEnabled which wasn't used
4189         anywhere.
4190
4191         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4192         (DRTTestRunner::DRTTestRunner):
4193         (DRTTestRunner::reset):
4194         (DRTTestRunner::overridePreference):
4195         * DumpRenderTree/chromium/DRTTestRunner.h:
4196         (DRTTestRunner):
4197         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4198         (WebTestRunner::TestRunner::TestRunner):
4199         (WebTestRunner::TestRunner::reset):
4200         (WebTestRunner):
4201         (WebTestRunner::TestRunner::setTabKeyCyclesThroughElements):
4202         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
4203         (WebTestRunner::TestRunner::execCommand):
4204         (WebTestRunner::TestRunner::isCommandEnabled):
4205         (WebTestRunner::TestRunner::pauseAnimationAtTimeOnElementWithId):
4206         (WebTestRunner::TestRunner::pauseTransitionAtTimeOnElementWithId):
4207         (WebTestRunner::TestRunner::elementDoesAutoCompleteForElementWithId):
4208         (WebTestRunner::TestRunner::numberOfActiveAnimations):
4209         (WebTestRunner::TestRunner::callShouldCloseOnWebView):
4210         (WebTestRunner::TestRunner::setDomainRelaxationForbiddenForURLScheme):
4211         (WebTestRunner::TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
4212         (WebTestRunner::TestRunner::evaluateScriptInIsolatedWorld):
4213         (WebTestRunner::TestRunner::setIsolatedWorldSecurityOrigin):
4214         (WebTestRunner::TestRunner::setIsolatedWorldContentSecurityPolicy):
4215         (WebTestRunner::TestRunner::addOriginAccessWhitelistEntry):
4216         (WebTestRunner::TestRunner::removeOriginAccessWhitelistEntry):
4217         (WebTestRunner::TestRunner::hasCustomPageSizeStyle):
4218         (WebTestRunner::TestRunner::forceRedSelectionColors):
4219         (WebTestRunner::TestRunner::addUserScript):
4220         (WebTestRunner::TestRunner::addUserStyleSheet):
4221         (WebTestRunner::TestRunner::startSpeechInput):
4222         (WebTestRunner::TestRunner::loseCompositorContext):
4223         (WebTestRunner::TestRunner::markerTextForListItem):
4224         (WebTestRunner::TestRunner::findString):
4225         (WebTestRunner::TestRunner::setMinimumTimerInterval):
4226         (WebTestRunner::TestRunner::setAutofilled):
4227         (WebTestRunner::TestRunner::setValueForUser):
4228         (WebTestRunner::TestRunner::enableFixedLayoutMode):
4229         (WebTestRunner::TestRunner::setFixedLayoutSize):
4230         (WebTestRunner::TestRunner::selectionAsMarkup):
4231         (WebTestRunner::TestRunner::setTextSubpixelPositioning):
4232         (WebTestRunner::TestRunner::resetPageVisibility):
4233         (WebTestRunner::TestRunner::setPageVisibility):
4234         (WebTestRunner::TestRunner::setTextDirection):
4235         (WebTestRunner::TestRunner::textSurroundingNode):
4236         (WebTestRunner::TestRunner::workerThreadCount):
4237         (WebTestRunner::TestRunner::cppVariantToBool):
4238         (WebTestRunner::TestRunner::cppVariantToInt32):
4239         (WebTestRunner::TestRunner::cppVariantToWebString):
4240         (WebTestRunner::TestRunner::cppVariantToWebStringArray):
4241         (WebTestRunner::TestRunner::printErrorMessage): formerly logErrorToConsole
4242         (WebTestRunner::TestRunner::fallbackMethod):
4243         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4244         (WebKit):
4245         (WebTestRunner::TestRunner::setWebView):
4246         (TestRunner):
4247         * DumpRenderTree/chromium/TestShell.cpp:
4248         (TestShell::createMainWindow):
4249         (TestShell::~TestShell):
4250
4251 2012-11-19  Yusuke Sato  <yusukes@chromium.org>
4252
4253         [Chromium] Flash cannot receive scroll events when threaded compositing is in use
4254         https://bugs.webkit.org/show_bug.cgi?id=101423
4255
4256         Reviewed by James Robinson.
4257
4258         Call setWantsWheelEvents(true) in initialize() so that gesture-events and transformed-events tests in
4259         LayoutTests/platform/chromium/plugins/ will not fail even if a buildbot introduces threaded compositing
4260         in the future.
4261
4262         * DumpRenderTree/chromium/TestWebPlugin.cpp:
4263         (TestWebPlugin::initialize):
4264
4265 2012-11-19  Nate Chapin  <japhet@chromium.org>
4266
4267         Move empty loading to DocumentLoader, simplify FrameLoader::init()
4268         https://bugs.webkit.org/show_bug.cgi?id=101512
4269
4270         Reviewed by Adam Barth.
4271
4272       &n