3432e3d18234e0eac3b92a324d6f4747e2df5cc1
[WebKit-https.git] / Tools / ChangeLog
1 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
2
3         nrwt: handle errors from image diff better
4         https://bugs.webkit.org/show_bug.cgi?id=92934
5
6         Reviewed by Ojan Vafai.
7
8         Currently if ImageDiff crashes, returns a weird exit code, or
9         produces any stderr output, it's basically swallowed. This
10         change ensures that we log errors to stderr, and also appends
11         the error to the stderr for the test (so it'll show up in
12         results.html).
13
14         Most importantly, it'll cause diff_image() to fail and we'll
15         report ImageHashMismatch ... this may be kinda untrue, but I
16         think it's better than ignoring the error.
17
18         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
19         (SingleTestRunner._compare_image):
20         (SingleTestRunner._compare_output_with_reference):
21         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
22         (write_test_result):
23         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
24         (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
25         (TestResultWriterTest):
26         * Scripts/webkitpy/layout_tests/port/base.py:
27         (Port.diff_image):
28         * Scripts/webkitpy/layout_tests/port/chromium.py:
29         (ChromiumPort.diff_image):
30         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
31         (ChromiumPortTestCase.test_diff_image_crashed):
32         * Scripts/webkitpy/layout_tests/port/driver.py:
33         (Driver.run_test):
34         * Scripts/webkitpy/layout_tests/port/image_diff.py:
35         (ImageDiffer.diff_image):
36         (ImageDiffer._read):
37         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
38         (TestImageDiffer.test_diff_image):
39         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
40         (MockDRTPortTest.test_diff_image_crashed):
41         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
42         (PortTestCase.test_diff_image):
43         (PortTestCase):
44         (PortTestCase.test_diff_image_crashed):
45         (PortTestCase.test_diff_image_crashed.make_proc):
46         * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
47         (MockServerProcess.__init__):
48         * Scripts/webkitpy/layout_tests/port/test.py:
49         (TestPort.diff_image):
50         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
51         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
52
53 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
54
55         nrwt: clean up printing.py
56         https://bugs.webkit.org/show_bug.cgi?id=93026
57
58         Reviewed by Dirk Pranke.
59
60         This patch cleans up the implementation of printing.py now
61         that we're not using all the original complexity.
62
63         There should be no changes in functionality and everything
64         should be covered by the existing tests.
65
66         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
67         (LayoutTestRunner.run_tests):
68         * Scripts/webkitpy/layout_tests/views/printing.py:
69         (Printer.__init__):
70         (Printer.__del__):
71         (Printer.print_config):
72         (Printer.print_found):
73         (Printer.print_expected):
74         (Printer.print_workers_and_shards):
75         (Printer):
76         (Printer._print_expected_results_of_type):
77         (Printer.print_results):
78         (Printer._print_timing_statistics):
79         (Printer._print_aggregate_test_statistics):
80         (Printer._print_individual_test_times):
81         (Printer._print_test_list_timing):
82         (Printer._print_directory_timings):
83         (Printer._print_statistics_for_test_timings):
84         (Printer._print_result_summary):
85         (Printer._print_result_summary_entry):
86         (Printer._print_one_line_summary):
87         (Printer.print_finished_test):
88         (Printer._print_test_result):
89         (Printer._print_test_trace):
90         (Printer._print_baseline):
91         (Printer._print_unexpected_test_result):
92         (Printer._print_progress):
93         (Printer._print_unexpected_results):
94         (Printer._print_unexpected_results.add_result):
95         (Printer._print_quiet):
96         (Printer._print_default):
97         (Printer._print_debug):
98         (Printer._print_for_bot):
99         (Printer.write_update):
100         (Printer.writeln):
101         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
102         (Testprinter.get_printer):
103         (Testprinter.test_print_config):
104         (Testprinter.test_print_one_line_summary):
105         (Testprinter.test_print_unexpected_results):
106         (test_details):
107
108 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
109
110         change bots to pass --debug-rwt-logging instead of --verbose to new-run-webkit-tests
111         https://bugs.webkit.org/show_bug.cgi?id=93043
112
113         Reviewed by Ryosuke Niwa.
114
115         in preparation for the cleanup of the logging flags in new-run-webkit-tests.
116
117         * Scripts/run-webkit-tests:
118
119 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
120
121         nrwt: clean up logging, part 1
122         https://bugs.webkit.org/show_bug.cgi?id=93018
123
124         Reviewed by Ojan Vafai.
125
126         remove --print, --help-printing from nrwt, add three new options:
127         --quiet, which just logs warnings,errors, and unexpected results
128         --debug-rwt-logging, a new name for --verbose
129         --details, to get the old --print trace-everything behavior
130
131         This patch does not implement the new "one line per test"
132         --verbose behavior specified in bug 88702, and there's a bunch
133         of internal cleanup I can do in printing.py that I'll defer to
134         a later patch to make things easier to review.
135
136         This patch deletes a lot of unit tests that are no longer
137         necessary since there aren't so many logging combinations.
138
139         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
140         (run):
141         (main):
142         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
143         (parse_args):
144         (passing_run):
145         (StreamTestingMixin.assertContains):
146         (MainTest.test_child_processes_2):
147         (MainTest.test_child_processes_min):
148         (MainTest.test_full_results_html):
149         (MainTest.test_no_tests_found):
150         (MainTest.test_no_tests_found_2):
151         (MainTest.test_repeat_each_iterations_num_tests):
152         (MainTest.test_additional_platform_directory):
153         (RebaselineTest.assertBaselines):
154         * Scripts/webkitpy/layout_tests/views/printing.py:
155         (print_options):
156         (Printer.__init__):
157         (Printer.enabled):
158         (Printer.print_unexpected_results):
159         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
160         (TestUtilityFunctions.test_print_options):
161         (Testprinter.get_result_summary):
162         (Testprinter.test_configure_and_cleanup):
163         (Testprinter.test_print_config):
164         (Testprinter.test_print_one_line_summary):
165         (Testprinter.test_print_unexpected_results):
166         (test_details):
167         (test_default):
168         (test_quiet):
169         (test_verbose):
170
171 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
172
173         [Chromium-Android] Store test executable, data and fonts in /data/local/tmp
174         https://bugs.webkit.org/show_bug.cgi?id=91910
175
176         /data/local/tmp is a directory with permission 0777 by default.
177         Place DumpRenderTree resources here so that both the native test app and
178         the NRWT script can access them even if adb shell isn't running as root.
179
180         Reviewed by Adam Barth.
181
182         * DumpRenderTree/chromium/TestShellAndroid.cpp:
183         (createFIFO): Set fifo mode to 0666 to allow unrooted adb shell to access.
184         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
185         (ChromiumAndroidPort.driver_cmd_line):
186         (ChromiumAndroidDriver.__init__):
187         (ChromiumAndroidDriver._setup_test):
188         (ChromiumAndroidDriver._push_executable):
189         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
190         (ChromiumAndroidPortTest.make_port):
191         (ChromiumAndroidPortTest.test_expectations_files):
192         (ChromiumAndroidDriverTest.test_drt_cmd_line):
193
194 2012-08-06  Abhishek Arya  <inferno@chromium.org>
195
196         [Chromium] Re-expose layoutTestController as various fuzzers depend on it
197         https://bugs.webkit.org/show_bug.cgi?id=93282
198
199         Reviewed by Ryosuke Niwa.
200
201         Unfortunately, various fuzzers used in the Chromium project still depends on
202         window.layoutTestController. Re-expose the object while they're making the transition.
203
204         * DumpRenderTree/chromium/TestShell.cpp:
205         (TestShell::bindJSObjectsToWindow):
206
207 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
208
209         WTR should be able to load external resources
210         https://bugs.webkit.org/show_bug.cgi?id=89382
211
212         Reviewed by Ryosuke Niwa.
213
214         Allow to load an external resource as the main frame
215         and allow all subsequent external loads for such a main
216         frame. This behavior is necessary for being able to run
217         performance tests (https://bugs.webkit.org/show_bug.cgi?id=84008).
218
219         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
220         (WTR::isLocalHost):
221         (WTR):
222         (WTR::isHTTPOrHTTPSScheme):
223         (WTR::InjectedBundlePage::willSendRequestForFrame):
224
225 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
226
227         [WK2] REGRESSION(124596) lot of web process unresponsiveness appears on Apple bots
228         https://bugs.webkit.org/show_bug.cgi?id=93120
229
230         Reviewed by Csaba Osztrogonác.
231
232         Set the short timeout back to 15 seconds and add more time to WebKitTestRunner
233         so it will be able to detect an unresponsive web process.
234
235         * Scripts/webkitpy/layout_tests/port/base.py:
236         (Port.default_timeout_ms):
237         * WebKitTestRunner/TestController.cpp:
238         (WTR):
239
240 2012-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
241
242         Unreviewed. Fix make distcheck.
243
244         * GNUmakefile.am: Add jhbuildutils.py to EXTRA_DIST.
245
246 2012-08-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
247
248         [EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation
249         https://bugs.webkit.org/show_bug.cgi?id=82724
250
251         Reviewed by Csaba Osztrogonác.
252
253         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
254         (LayoutTestController::removeAllVisitedLinks):
255
256 2012-08-06  Mario Sanchez Prada  <msanchez@igalia.com>
257
258         [WK2][GTK] Implement a new spell checker API for WebKit2GTK+
259         https://bugs.webkit.org/show_bug.cgi?id=90268
260
261         Reviewed by Martin Robinson.
262
263         Ignore WebKitTextChecker.* private files for gtk-doc.
264
265         * gtk/generate-gtkdoc:
266         (get_webkit2_options):
267
268 2012-08-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
269
270         Unreviewed. Roll out r124728 because of build bot test fail.
271
272         * Scripts/webkitpy/common/config/watchlist:
273
274 2012-08-05  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
275
276         Unreviewed. Change my email address for watch list.
277
278         * Scripts/webkitpy/common/config/watchlist:
279
280 2012-08-04  Nico Weber  <thakis@chromium.org>
281
282         [Chromium Mac] Tests are exiting early due to failures to load missingImage.png
283         https://bugs.webkit.org/show_bug.cgi?id=93186
284
285         Reviewed by Ryosuke Niwa.
286
287         Add missingImage.png to DumpRenderTree.app's Resource folder.
288         Depends on http://crrev.com/150037 rolling into webkit first.
289
290         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
291
292 2012-08-03  Ryosuke Niwa  <rniwa@webkit.org>
293
294         Stop exposing window.layoutTestController in layout tests in favor of window.testRunner
295         https://bugs.webkit.org/show_bug.cgi?id=93173
296
297         Reviewed by Adam Barth.
298
299         Don't expose window.layoutTestController since all layout tests use window.testRunner
300         instead of window.layoutTestController as of r124685.
301
302         We can safely rename classes and files to use TestRunner once this patch is landed.
303
304         * DumpRenderTree/LayoutTestController.cpp:
305         (LayoutTestController::makeWindowObject):
306         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
307         (notifyTestCompletion):
308         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
309         (PluginTest::waitUntilDone):
310         (PluginTest::notifyDone):
311         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
312         (ConvertPoint::NPP_SetWindow):
313         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
314         (handleEventCarbon):
315         (handleEventCocoa):
316         (handleEventWin):
317         * DumpRenderTree/chromium/TestShell.cpp:
318         (TestShell::bindJSObjectsToWindow):
319         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
320         (WebCore::DumpRenderTree::initJSObjects):
321         * Scripts/bencher:
322         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
323         (WTR::LayoutTestController::makeWindowObject):
324
325 2012-08-04  Ilya Tikhonovsky  <loislo@chromium.org>
326
327         Unreviewed: Web Inspector: extend instrumenting methods set in ReportMemoryUsage clang plugin
328         Three methods addString, addVectorPtr and addInstrumentedVectorPtr were added to the list of instrumentation methods.
329
330         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
331         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
332
333 2012-08-03  Yaron Friedman  <yfriedman@chromium.org>
334
335         [Chrome-Android] - Prepare apk tests for switch to checked in SDK.
336         https://bugs.webkit.org/show_bug.cgi?id=92931
337
338         Reviewed by Adam Barth.
339
340         Pass Android-specific gyp variables to the native test generator,
341         avoiding any dependencies on environment variables during build time.
342
343         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
344         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
345
346 2012-08-03  Rick Byers  <rbyers@chromium.org>
347
348         Double tap gesture should send dblclick event
349         https://bugs.webkit.org/show_bug.cgi?id=92412
350
351         Reviewed by Adam Barth.
352
353         Enable EventSender to set the tap count on tap gesture events.  The
354         delta X/Y parameters were not actually being used anymore (used to be
355         used for radius information).
356
357         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
358         (EventSender::gestureEvent):
359
360 2012-08-03  Ryosuke Niwa  <rniwa@webkit.org>
361
362         run-perf-tests should generate JSON output and results page by default
363         https://bugs.webkit.org/show_bug.cgi?id=93042
364
365         Reviewed by Eric Seidel.
366
367         Generate results JSON and page named PerfTestResults.json and PerfTestResults.html by default.
368
369         * Scripts/webkitpy/layout_tests/port/base.py:
370         (Port.perf_results_directory): Added.
371         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
372         (PerfTestsRunner): Added _DEFAULT_JSON_FILENAME.
373         (PerfTestsRunner._parse_args): Added --no-results option in the case a user doens't want to generate
374         results JSON or results page.
375         (PerfTestsRunner.run):
376         (PerfTestsRunner._generate_and_show_results): Extracted from run. Set the default json file path using
377         port's perf_results_directory and call show_results_html_file at the end if the results page is generated.
378         (PerfTestsRunner._generate_results_dict): Renamed from _generate_output to disambiguate it from
379         _generate_and_show_results.
380         (PerfTestsRunner._generate_output_files): Takes results page's path instead of a boolean indicating
381         whether results page should be generated or not.
382         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
383         (create_runner_and_setup_results_template):
384         (test_run_respects_results_output): Added.
385         (test_run_generates_json_by_default): Added.
386         (test_run_generates_and_show_results_page): Added a check to ensure show_results_html_file is called.
387
388 2012-08-03  Sheriff Bot  <webkit.review.bot@gmail.com>
389
390         Unreviewed, rolling out r124628.
391         http://trac.webkit.org/changeset/124628
392         https://bugs.webkit.org/show_bug.cgi?id=93155
393
394         Causes random crashes of DRT on Chromium bots (Requested by
395         dimich on #webkit).
396
397         * DumpRenderTree/DumpRenderTree.gypi:
398         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
399         (MockWebKitPlatformSupport::createMediaStreamCenter):
400         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
401         (MockWebKitPlatformSupport):
402         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
403         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
404         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Removed.
405         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Removed.
406
407 2012-08-03  Brady Eidson  <beidson@apple.com>
408
409         Small part of "Out-of-process plug-ins should support asynchronous initialization."
410         <rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919
411
412         Reviewed by Anders Carlsson.
413
414         * WebKitTestRunner/TestController.cpp:
415         (WTR::TestController::resetStateToConsistentValues): Reset all preferences related to asynchronous plugin initialization.
416
417 2012-08-02  Jeffrey Pfau  <jpfau@apple.com>
418
419         Add API for enabling blanket third-party data blocking
420         https://bugs.webkit.org/show_bug.cgi?id=93022
421
422         Reviewed by Anders Carlsson.
423
424         Added test for default setting of new third-party storage blocking API.
425
426         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
427         (TestWebKitAPI::TEST):
428
429 2012-08-03  Arvid Nilsson  <anilsson@rim.com>
430
431         Unreviewed, adding self to committers.py after becoming committer.
432
433         * Scripts/webkitpy/common/config/committers.py:
434
435 2012-08-03  Ádám Kallai  <kadam@inf.u-szeged.hu>
436
437         Limited the number of queried cached build infos in URLs used by Garden-o-matic.
438         https://bugs.webkit.org/show_bug.cgi?id=92992.
439
440         Reviewed by Adam Barth.
441
442         I added a limit to the cached builds that are included in the URL to avoid too long URLs in Garden-o-matic.
443
444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
445         (.):
446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
447
448 2012-08-03  Tommy Widenflycht  <tommyw@google.com>
449
450         [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
451         https://bugs.webkit.org/show_bug.cgi?id=93091
452
453         Reviewed by Adam Barth.
454
455         Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
456         to complete the infrastructure for RTCPeerConnection.
457
458         * DumpRenderTree/DumpRenderTree.gypi:
459         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
460         (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
461         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
462         (MockWebKitPlatformSupport):
463         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
464         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
465         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
466         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
467         (MockWebRTCPeerConnectionHandler::initialize):
468         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
469         (WebKit):
470         (MockWebRTCPeerConnectionHandler):
471         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
472
473 2012-08-03  Hugo Parente Lima  <hugo.lima@openbossa.org>
474
475         [Qt][WK2] There's no way to test the gesture tap on WTR
476         https://bugs.webkit.org/show_bug.cgi?id=92895
477
478         Reviewed by Kenneth Rohde Christiansen.
479
480         WTR doesn't create the QQuickItem from C++, not from QML, so a call
481         to componentComplete() was added to mimic the QML behaviour.
482
483         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
484         (WTR::PlatformWebView::PlatformWebView):
485
486 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
487
488         Unreviewed, rolling out r124567.
489         http://trac.webkit.org/changeset/124567
490         https://bugs.webkit.org/show_bug.cgi?id=89382
491
492         Broke some tests with external resources
493
494         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
495         (WTR::InjectedBundlePage::willSendRequestForFrame):
496
497 2012-08-03  Philippe Normand  <pnormand@igalia.com>
498
499         Unreviewed, rolling out r124614.
500         http://trac.webkit.org/changeset/124614
501         https://bugs.webkit.org/show_bug.cgi?id=91727
502
503         gstreamer core .po files mess up the build again
504
505         * Scripts/webkitdirs.pm:
506         (buildAutotoolsProject):
507         * gtk/jhbuild.modules:
508
509 2012-08-03  Philippe Normand  <pnormand@igalia.com>
510
511         [GTK][jhbuild] Switch to GStreamer 0.11 build
512         https://bugs.webkit.org/show_bug.cgi?id=91727
513
514         Reviewed by Gustavo Noronha Silva.
515
516         Switch build-webkit --gtk to GStreamer 0.11 support and build the
517         necessary GStreamer git modules from JHBuild.
518
519         * Scripts/webkitdirs.pm:
520         (buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
521         * gtk/jhbuild.modules: GStreamer build support.
522
523 2012-08-03  Nico Weber  <thakis@chromium.org>
524
525         [chromium mac] DumpRenderTree compile fails with warning/error in LayoutTestHelper.mm with 10.7sdk
526         https://bugs.webkit.org/show_bug.cgi?id=92820
527
528         Reviewed by Jochen Eisinger.
529
530         When building with the 10.7 SDK, use newer functions to switch color
531         profiles. Note that these newer functions aren't available on 10.6,
532         but we don't intend to ship DRT to users, and no bots that currently
533         build with the 10.7 SDK ship their binaries to 10.6 testers.
534
535         The new code was copied from Apple's DRT/mac/LayoutTestHelper.m.
536
537         * DumpRenderTree/chromium/LayoutTestHelper.mm:
538         (installLayoutTestColorProfile):
539         (restoreUserColorProfile):
540         (saveCurrentColorProfile):
541
542 2012-08-03  Benjamin Poulain  <benjamin@webkit.org>
543
544         StringImpl created from literal should be BufferInternal
545         https://bugs.webkit.org/show_bug.cgi?id=92940
546
547         Reviewed by Anders Carlsson.
548
549         Add tests for the contruction of strings from literal.
550
551         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
552         * TestWebKitAPI/Tests/WTF/AtomicString.cpp: Added.
553         (TestWebKitAPI):
554         (TestWebKitAPI::TEST):
555         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Added.
556         (TestWebKitAPI):
557         (TestWebKitAPI::TEST):
558
559 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
560
561         [nrwt] fix unit tests after turned pixel testing to be a per test setting
562         https://bugs.webkit.org/show_bug.cgi?id=93112
563
564         Reviewed by Csaba Osztrogonác.
565
566         Change unit tests in accordance of per test switching of pixel testing.
567
568         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
569         (ChromiumAndroidDriverTest.test_command_from_driver_input):
570         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
571         (DriverTest.test_no_timeout):
572
573 2012-08-03  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
574
575         [Qt] Populate .qmake.cache from the top-level project file
576
577         This makes it possible to build webkit without using the perl build
578         script. The duplicated logic in build-webkit will be removed when we
579         remove the Qt4 code paths. The build-webkit script will then simply
580         call 'qmake WebKit.pro' from WEBKITOUTPUTDIR.
581
582         Reviewed by Tor Arne Vestbø.
583
584         * qmake/mkspecs/features/win32/default_pre.prf:
585
586 2012-08-03  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
587
588         [Qt] Move build config default to build-webkit instead of default_pre
589
590         Allows the qmake buildsystem have its own default.
591
592         Reviewed by Tor Arne Vestbø.
593
594         * Scripts/webkitdirs.pm:
595         (buildQMakeProjects):
596         * qmake/mkspecs/features/default_pre.prf:
597
598 2012-08-03  Mario Sanchez Prada  <msanchez@igalia.com>
599
600         Unreviewed build fix for GTK after r124581.
601
602         * DumpRenderTree/gtk/DumpRenderTree.cpp:
603         (runTest): Fix wrong variable name in ASSERT.
604
605 2012-08-03  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
606
607         [Qt] Always save CONFIG & DEFINES in default_pre
608
609         Always doing it is cheaper than checking whether it needs to be done.
610         apart from that, it would break configuration initiated from another
611         project.
612
613         Reviewed by Tor Arne Vestbø.
614
615         * qmake/mkspecs/features/default_pre.prf:
616
617 2012-08-03  Joone Hur  <joone.hur@intel.com>
618
619         [EFL][DRT] fast/loader/stop-provisional-loads.html fails
620         https://bugs.webkit.org/show_bug.cgi?id=92219
621
622         Reviewed by Kenneth Rohde Christiansen.
623
624         This patch adds the ability to tell DRT to call ewk_frame_stop 
625         inside of a didStartProvisionalLoadForFrame signal handler.
626         It allows to pass fast/loader/stop-provisional-loads.html.
627
628         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
629         (DumpRenderTreeChrome::onFrameProvisionalLoad):
630
631 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
632
633         [WTR] process unresponsiveness is reported to the wrong test
634         https://bugs.webkit.org/show_bug.cgi?id=88404
635
636         2nd unreviewed buildfix.
637
638         * WebKitTestRunner/TestInvocation.cpp:
639
640 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
641
642         [WTR] process unresponsiveness is reported to the wrong test
643         https://bugs.webkit.org/show_bug.cgi?id=88404
644
645         Unreviewed buildfix. Also made the change on the array size
646         suggested on review because I forgot it when landed.
647
648         * WebKitTestRunner/TestInvocation.cpp:
649         (WTR::TestInvocation::invoke):
650
651 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
652
653         [WTR] process unresponsiveness is reported to the wrong test
654         https://bugs.webkit.org/show_bug.cgi?id=88404
655
656         Reviewed by Zoltan Herczeg.
657
658         Do resetting to consistent state after the finished test,
659         not before the next. This way we can report unresponsiveness
660         to the test that triggered it, and we do a restart before the
661         next test so it will start in a functional state.
662
663         * Scripts/webkitpy/layout_tests/port/webkit.py:
664         (WebKitDriver._check_for_driver_crash):
665         Print the error line for unresponsive web process, otherwise
666         it's hard to tell what happened.
667         * WebKitTestRunner/TestController.cpp:
668         (WTR):
669         Decreased the default short timeout so we can detect unresponsiveness
670         before the timer of the test harness times out. It was unnecessarily
671         high anyway, we should get answer from the web process in those cases
672         when the short timeout is used in less than a second.
673         (WTR::TestController::runTest):
674         (WTR::TestController::run):
675         * WebKitTestRunner/TestController.h:
676         (TestController):
677         * WebKitTestRunner/TestInvocation.cpp:
678         (WTR::TestInvocation::invoke):
679         (WTR::TestInvocation::dump):
680         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
681         * WebKitTestRunner/TestInvocation.h:
682         (TestInvocation): Make the dump function static as it doesn't need an object.
683
684 2012-08-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
685
686         [EFL] (REGRESSION 124581) : EFL 64-bit Debug bot is red and build is exiting early after 20 test crashes
687         https://bugs.webkit.org/show_bug.cgi?id=93084
688
689         Reviewed by Csaba Osztrogonác.
690
691         Fix regression introduced in r124581.
692
693         * DumpRenderTree/efl/DumpRenderTree.cpp:
694         (getFinalTestURL): Convert the path into a full file URL.
695         (runTest):
696
697 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
698
699         All ports should support per test switching of pixel testing
700         https://bugs.webkit.org/show_bug.cgi?id=92398
701
702         Reviewed by Dirk Pranke.
703
704         Teach all test drivers to accept a per test control of whether
705         to dump pixels. Drivers now accept a -p/--pixel-test argument
706         on the standart input that means that running the current
707         test as pixel test is allowed (even if the expected hash is
708         missing). Removed the --pixel-tests command line option since
709         there is no need for it anymore.
710
711         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
712         * DumpRenderTree/DumpRenderTree.gypi:
713         * DumpRenderTree/DumpRenderTree.h:
714         (TestCommand::TestCommand):
715         (TestCommand):
716         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
717         * DumpRenderTree/DumpRenderTreeCommon.cpp: Added.
718         (CommandTokenizer):
719         (CommandTokenizer::CommandTokenizer):
720         (CommandTokenizer::pump):
721         (CommandTokenizer::next):
722         (CommandTokenizer::hasNext):
723         (die):
724         (parseInputLine):
725         Common logic to parse the input line from the standard input (or from the command line
726         in standalone mode). Made it somewhat general so we can easily add more arguments if
727         there is a need.
728
729         * DumpRenderTree/chromium/DumpRenderTree.cpp:
730         (runTest):
731         (main):
732
733         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityController.cpp.
734         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityController.h.
735         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.cpp.
736         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.h.
737         Renamed these files with a Chromium suffix because they were clashing with the common ones used by other ports after adding the root
738         DumpRenderTree directory to the include path.
739
740         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
741         * DumpRenderTree/chromium/TestShell.cpp:
742         (TestShell::TestShell):
743         (TestShell::runFileTest):
744         (TestShell::dump):
745         * DumpRenderTree/chromium/TestShell.h:
746         (TestParams::TestParams):
747         (TestShell):
748         * DumpRenderTree/efl/CMakeLists.txt:
749         * DumpRenderTree/efl/DumpRenderTree.cpp:
750         (parseCommandLineOptions):
751         (runTest):
752         (shouldDumpPixelsAndCompareWithExpected):
753         (main):
754         * DumpRenderTree/gtk/DumpRenderTree.cpp:
755         (initializeGlobalsFromCommandLineOptions):
756         (dump):
757         (runTest):
758         (main):
759         * DumpRenderTree/mac/DumpRenderTree.mm:
760         (initializeGlobalsFromCommandLineOptions):
761         (dumpRenderTree):
762         (dump):
763         (runTest):
764         * DumpRenderTree/qt/DumpRenderTree.pro:
765         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
766         (WebCore::DumpRenderTree::DumpRenderTree):
767         (WebCore::DumpRenderTree::open):
768         (WebCore::DumpRenderTree::processLine):
769         (WebCore::DumpRenderTree::dump):
770         * DumpRenderTree/qt/DumpRenderTreeQt.h:
771         (DumpRenderTree):
772         * DumpRenderTree/qt/main.cpp:
773         (isOption):
774         (printUsage):
775         (main):
776         * DumpRenderTree/win/DumpRenderTree.cpp:
777         (dump):
778         (runTest):
779         (dllLauncherEntryPoint):
780         * DumpRenderTree/win/DumpRenderTree.vcproj:
781         * DumpRenderTree/wscript:
782         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
783         (dump):
784         (runTest):
785         (MyApp::OnInit):
786         * GNUmakefile.am:
787
788         * Scripts/old-run-webkit-tests:
789         * Scripts/old-run-webkit-tests:
790         Pass --pixel-test before the hash.
791
792         * Scripts/webkitpy/layout_tests/port/base.py:
793         (Port.should_run_as_pixel_test): Removed now that all ports supports it.
794         * Scripts/webkitpy/layout_tests/port/driver.py:
795         (Driver.cmd_line): Don't pass --pixel-tests anymore.
796         (Driver._command_from_driver_input):
797         * Scripts/webkitpy/layout_tests/port/qt.py:
798         (QtPort.should_run_as_pixel_test):
799         * Scripts/webkitpy/layout_tests/port/test.py:
800         (TestPort.should_run_as_pixel_test):
801
802         * WebKitTestRunner/TestController.cpp:
803         (WTR::TestController::TestController):
804         (WTR::TestController::initialize):
805         (WTR::TestCommand::TestCommand):
806         (TestCommand):
807         (WTR):
808         (CommandTokenizer):
809         (WTR::CommandTokenizer::CommandTokenizer):
810         (WTR::CommandTokenizer::pump):
811         (WTR::CommandTokenizer::next):
812         (WTR::CommandTokenizer::hasNext):
813         (WTR::die):
814         (WTR::parseInputLine):
815         (WTR::TestController::runTest):
816         * WebKitTestRunner/TestController.h:
817         (TestController):
818         Duplicate the logic for parsing the command line because
819         unfortunately there is no way to share code between
820         WebKitTestRunner and DumpRenderTree.
821
822 2012-08-03  Ilya Tikhonovsky  <loislo@chromium.org>
823
824         Web Inspector: clang plugin for checking native memory instrumentation coverage.
825         https://bugs.webkit.org/show_bug.cgi?id=92650
826
827         Reviewed by Yury Semikhatsky.
828
829         This is the clang plugin for checking native memory instrumentation coverage.
830         The idea: InspectorMemoryAgent traverses through instrumented objects and collects pointers and their sizes and types.
831         It is doing that with help of reportMemoryUsage function that needs to be implemented in each, significant
832         from native memory footprint point of view, WebCore class.
833         This plugin checks that the list of class members is matching with the list of members reported in reportMemoryUsage function
834         and makes a warning for the each member that needs to be reported.
835
836         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Added.
837         * clang/ReportMemoryUsagePlugin/Makefile: Added.
838         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Added.
839         (clang):
840         (AddMemberCallVisitor):
841         (clang::AddMemberCallVisitor::VisitCallExpr):
842         (clang::AddMemberCallVisitor::instrumentedMembers):
843         (ReportMemoryUsageVisitor):
844         (clang::ReportMemoryUsageVisitor::ReportMemoryUsageVisitor):
845         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
846         (clang::ReportMemoryUsageVisitor::emitWarning):
847         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
848         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
849         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
850         (ReportMemoryUsageConsumer):
851         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
852         (clang::ReportMemoryUsageConsumer::HandleTranslationUnit):
853         (ReportMemoryUsageAction):
854         (clang::ReportMemoryUsageAction::CreateASTConsumer):
855         (clang::ReportMemoryUsageAction::ParseArgs):
856         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Added.
857         (aNamespace):
858         (MemoryInstrumentation):
859         (MemoryClassInfo):
860         (aNamespace::MemoryClassInfo::MemoryClassInfo):
861         (aNamespace::MemoryClassInfo::addMember):
862         (aNamespace::MemoryClassInfo::addInstrumentedMember):
863         (OwnPtr):
864         (aNamespace::OwnPtr::OwnPtr):
865         (RefPtr):
866         (aNamespace::RefPtr::RefPtr):
867         (Vector):
868         (String):
869         (NotInstrumentedClass):
870         (InstrumentedClass):
871         (aNamespace::InstrumentedClass::reportMemoryUsage):
872         (InstrumentedChildClass):
873         (aNamespace::InstrumentedChildClass::reportMemoryUsage):
874         (InstrumentedChildChildClass):
875         (InstrumentedChildChildClass::reportMemoryUsage):
876         (main):
877
878 2012-08-03  Joone Hur  <joone.hur@intel.com>
879
880         [EFL][DRT] WebKitAnimation API compile-time disabled
881         https://bugs.webkit.org/show_bug.cgi?id=84593
882
883         Reviewed by Laszlo Gombos.
884
885         Enable ENABLE_ANIMATION_API by default on the Efl port.
886
887         * Scripts/webkitperl/FeatureList.pm:
888
889 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
890
891         WTR should be able to load external resources
892         https://bugs.webkit.org/show_bug.cgi?id=89382
893
894         Reviewed by Ryosuke Niwa.
895
896         Allow to load an external resource as the main frame
897         and allow all subsequent external loads for such a main
898         frame. This behavior is necessary for being able to run
899         performance tests (wkb.ug/84008).
900
901         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
902         (WTR::isLocalHost):
903         (WTR):
904         (WTR::isHTTPOrHTTPSScheme):
905         (WTR::InjectedBundlePage::willSendRequestForFrame):
906
907 2012-08-02  Joone Hur  <joone.hur@intel.com>
908
909         [GTK] Build break when building DumpRenderTree/gtk/EditingCallbacks.cpp
910         https://bugs.webkit.org/show_bug.cgi?id=93061
911
912         Unreviewed, Fix build break for WebKitGtk+.
913
914         Use webkit_dom_element_get_class_name instead of webkit_dom_html_element_get_class_name.
915
916         * DumpRenderTree/gtk/EditingCallbacks.cpp:
917         (shouldShowDeleteInterfaceForElement):
918
919 2012-08-02  Dirk Pranke  <dpranke@chromium.org>
920
921         test-webkitpy can fail on a clean checkout
922         https://bugs.webkit.org/show_bug.cgi?id=93039
923
924         Reviewed by Adam Barth.
925
926         Now that we run tests in parallel that can cause the installer
927         to try and install packages in parallel (even the same package),
928         and that probably won't work. We fix this by autoinstalling
929         everything up front (serially).
930
931         * Scripts/webkitpy/test/main.py:
932         (Tester._run_tests):
933         * Scripts/webkitpy/thirdparty/__init__.py:
934         (autoinstall_everything):
935
936 2012-06-15  David Barton  <dbarton@mathscribe.com>
937
938         MathML: nested square root symbols have varying descenders
939         https://bugs.webkit.org/show_bug.cgi?id=43819
940
941         Reviewed by Eric Seidel.
942
943         Allow the STIXGeneral font to be used during layout tests, especially for MathML.
944
945         * DumpRenderTree/mac/DumpRenderTree.mm:
946         (allowedFontFamilySet):
947         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
948         (WTR::allowedFontFamilySet):
949
950 2012-08-02  Dirk Pranke  <dpranke@chromium.org>
951
952         test-webkitpy: some tests need to run by themselves
953         https://bugs.webkit.org/show_bug.cgi?id=92926
954
955         Reviewed by Ojan Vafai.
956
957         Due to timing issues some of the executive tests will collide
958         and fail if they're run concurrently. This patch adds support
959         for writing tests that will be executed one at a time
960         (serially); to get them, add "serial_" to the front of the test
961         method name. 
962
963         * Scripts/webkitpy/common/system/executive_unittest.py:
964         (ExecutiveTest.serial_test_kill_process):
965         (ExecutiveTest.serial_test_kill_all):
966         (ExecutiveTest.serial_test_check_running_pid):
967         (ExecutiveTest.serial_test_running_pids):
968         (ExecutiveTest.serial_test_run_in_parallel):
969         * Scripts/webkitpy/test/main.py:
970         (Tester._run_tests):
971         (Tester._test_names):
972
973 2012-08-02  Dirk Pranke  <dpranke@chromium.org>
974
975         test-webkitpy: integrate proper support for integration tests
976         https://bugs.webkit.org/show_bug.cgi?id=92925
977
978         Reviewed by Ojan Vafai.
979
980         This patch merges the custom loader I used for integration tests
981         into the main test-webkitpy code. Integration tests are not run
982         by default yet, but at least they can be run.
983
984         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
985         (MockTestShellTest.test_test_shell_parse_options):
986         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
987         (test_path_to_apache_config_file):
988         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
989         (WebsocketserverTest):
990         * Scripts/webkitpy/test/main.py:
991         (Tester._parse_args):
992         (Tester._run_tests):
993         (Tester._test_names):
994         (Tester._log_exception):
995         (_Loader):
996         (_Loader.getTestCaseNames):
997         (_Loader.getTestCaseNames.isTestMethod):
998
999 2012-08-02  Dirk Pranke  <dpranke@chromium.org>
1000
1001         test-webkitpy: clean up runner in preparation for running tests serially as necessary
1002         https://bugs.webkit.org/show_bug.cgi?id=92922
1003
1004         Reviewed by Ojan Vafai.
1005
1006         In order to run some tests by themselves (serially, rather than
1007         in parallel with other tests), we will need to be able to run
1008         multiple test suites; this causes us to move loading the logic
1009         for finding test method names out of the runner and into main.
1010
1011         I'm taking advantage of this to simplify some other stuff from
1012         the runner as well; it is now very simple and doesn't expose its
1013         dependency on unittest.TestResult at all (nor will the Printer
1014         use TestResult).
1015
1016         Subsequent patches will move the custom loader from
1017         port_testcase so that we can properly choose whether to run
1018         integration tests and/or serial tests, and then update the
1019         appropriate tests to run only serially.
1020
1021         * Scripts/webkitpy/test/main.py:
1022         (Tester._run_tests):
1023         (Tester):
1024         (Tester._check_imports):
1025         (Tester._test_names):
1026         (Tester._all_test_names):
1027         * Scripts/webkitpy/test/printer.py:
1028         (Printer.__init__):
1029         (Printer.write_update):
1030         (Printer):
1031         (Printer.print_finished_test):
1032         (Printer.print_result):
1033         * Scripts/webkitpy/test/runner.py:
1034         (unit_test_name):
1035         (Runner.__init__):
1036         (Runner.run):
1037         (Runner.handle):
1038         (_Worker.handle):
1039         * Scripts/webkitpy/test/runner_unittest.py:
1040         (FakeLoader.loadTestsFromName):
1041         (RunnerTest.test_run):
1042
1043 2012-08-02  Adam Barth  <abarth@webkit.org>
1044
1045         Turn on tests for the mac-ews, for realz this time.
1046
1047         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1048         (MacEWS):
1049
1050 2012-08-02  Xianzhu Wang  <wangxianzhu@chromium.org>
1051
1052         [Chromium-Android] Run layout tests on multiple devices in parallel
1053         https://bugs.webkit.org/show_bug.cgi?id=92877
1054
1055         Reviewed by Dirk Pranke.
1056
1057         Moved methods that run command on a particular device from ChromiumAndroidPort to ChromiumAndroidDriver.
1058         The drivers run adb commands with the '-s serial_number' parameter which specifies the device according to the work_number.
1059
1060         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1061         (ChromiumAndroidPort.__init__):
1062         (ChromiumAndroidPort.default_child_processes): Default to the number of attached devices.
1063         (ChromiumAndroidPort.test_expectations): Removed because it is unused. 
1064         (ChromiumAndroidPort.setup_test_run): Most contents moved into ChromiumAndroidDriver._setup_test()
1065         (ChromiumAndroidPort.clean_up_test_run): Now the http server is stopped here.
1066         (ChromiumAndroidPort._get_devices):
1067         (ChromiumAndroidPort._get_device_serial):
1068         (ChromiumAndroidDriver):
1069         (ChromiumAndroidDriver.__init__):
1070         (ChromiumAndroidDriver.__del__):
1071         (ChromiumAndroidDriver._setup_test): Original contents of ChromiumAndroidPort.setup_test_run().
1072         (ChromiumAndroidDriver._push_executable): Moved from ChromiumAndroidPort.
1073         (ChromiumAndroidDriver._push_fonts): Moved from ChromiumAndroidPort.
1074         (ChromiumAndroidDriver._push_test_resources): Moved from ChromiumAndroidPort.
1075         (ChromiumAndroidDriver._synchronize_datetime): Moved from ChromiumAndroidPort.
1076         (ChromiumAndroidDriver._run_adb_command): Moved from ChromiumAndroidPort.
1077         (ChromiumAndroidDriver._teardown_performance): Moved from ChromiumAndroidPort.
1078         (ChromiumAndroidDriver._get_crash_log): Moved from ChromiumAndroidPort.
1079         (ChromiumAndroidDriver.cmd_line):
1080         (ChromiumAndroidDriver._file_exists_on_device):
1081         (ChromiumAndroidDriver._remove_all_pipes):
1082         (ChromiumAndroidDriver._start):
1083         (ChromiumAndroidDriver._start_once):
1084         (ChromiumAndroidDriver.stop):
1085         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1086         (MockRunCommand):
1087         (MockRunCommand.__init__):
1088         (MockRunCommand.mock_run_command_fn):
1089         (MockRunCommand.mock_no_device):
1090         (MockRunCommand.mock_one_device):
1091         (MockRunCommand.mock_two_devices):
1092         (MockRunCommand.mock_no_tombstone_dir):
1093         (MockRunCommand.mock_no_tombstone_file):
1094         (MockRunCommand.mock_ten_tombstones):
1095         (MockRunCommand.mock_logcat):
1096         (ChromiumAndroidPortTest):
1097         (ChromiumAndroidPortTest.make_port):
1098         (ChromiumAndroidPortTest.test_driver_cmd_line):
1099         (ChromiumAndroidPortTest.test_get_devices_no_device):
1100         (ChromiumAndroidPortTest.test_get_devices_one_device):
1101         (ChromiumAndroidPortTest.test_get_devices_two_devices):
1102         (ChromiumAndroidPortTest.test_get_device_serial_no_device):
1103         (ChromiumAndroidPortTest.test_get_device_serial_one_device):
1104         (ChromiumAndroidPortTest.test_get_device_serial_two_devices):
1105         (ChromiumAndroidDriverTest):
1106         (ChromiumAndroidDriverTest.setUp):
1107         (ChromiumAndroidDriverTest.test_get_last_stacktrace):
1108         (ChromiumAndroidDriverTest.test_get_crash_log):
1109         (ChromiumAndroidDriverTest.test_cmd_line):
1110         (ChromiumAndroidDriverTwoDriversTest):
1111         (ChromiumAndroidDriverTwoDriversTest.test_two_drivers):
1112         * Scripts/webkitpy/layout_tests/port/driver.py:
1113         (Driver.run_test):
1114         (Driver._get_crash_log): Added to allow subclasses to override.
1115         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1116         (parse_args): Removed the --adb-args command-line parameter because now we select device automatically. Added --adb-device to specify devices.
1117
1118 2012-08-02  Dinu Jacob  <dinu.jacob@nokia.com>
1119
1120         WebKitTestRunner needs layoutTestController.setUserStyleSheetEnabled
1121         https://bugs.webkit.org/show_bug.cgi?id=42679
1122
1123         Reviewed by Eric Seidel.
1124
1125         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added 
1126         setUserStyleSheetEnabled and setUserStyleSheetLocation.
1127         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1128         (WTR::LayoutTestController::LayoutTestController): Initialize new members added.
1129         (WTR::LayoutTestController::setUserStyleSheetEnabled): Added.
1130         (WTR::LayoutTestController::setUserStyleSheetLocation): Added.
1131         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added members
1132         userStyleSheetEnabled, and m_userStyleSheetLocation and methods
1133         setUserStyleSheetEnabled, and setUserStyleSheetLocation.
1134
1135 2012-08-02  Hans Wennborg  <hans@chromium.org>
1136
1137         Speech JavaScript API: Fire speech start event at the same time as sound start event
1138         https://bugs.webkit.org/show_bug.cgi?id=92971
1139
1140         Reviewed by Adam Barth.
1141
1142         Update the MockWebSpeechRecognizer to not fire "speech started" events
1143         separately.
1144
1145         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1146         (MockWebSpeechRecognizer::start):
1147
1148 2012-08-02  Philippe Normand  <pnormand@igalia.com>
1149
1150         [GTK] make sometimes using a single core
1151         https://bugs.webkit.org/show_bug.cgi?id=92998
1152
1153         Reviewed by Martin Robinson.
1154
1155         In the GTK 64-bit Release buildbot some builds use a single core
1156         for the make process. I suspect this is because in those cases
1157         nproc reports a single core available. The proposed solution is to
1158         always rely on all the cores available in the machine.
1159
1160         * Scripts/webkitdirs.pm:
1161         (determineNumberOfCPUs):
1162
1163 2012-08-02  Adam Barth  <abarth@webkit.org>
1164
1165         Re-land http://trac.webkit.org/changeset/94441 now that lforschler is ready.
1166
1167         This patch enables testing on the mac-ews bots.
1168
1169         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1170
1171 2012-08-02  Adam Barth  <abarth@webkit.org>
1172
1173         [Chromium] Merge final nits to DumpRenderTree.gyp for Android
1174         https://bugs.webkit.org/show_bug.cgi?id=90920
1175
1176         Reviewed by Tony Chang.
1177
1178         This patch contains the last few small changes to DumpRenderTree.gyp
1179         from the chromium-android branch. After this change, this file will be
1180         fully merged.
1181
1182         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1183
1184 2012-08-02  Peter Beverloo  <peter@chromium.org>
1185
1186         [Chromium] Toggle the type of ant compile for webkit_unit_tests and TestWebKitAPI
1187         https://bugs.webkit.org/show_bug.cgi?id=92858
1188
1189         Reviewed by Adam Barth.
1190
1191         Now that the sdk_build variable is available, we can remove these two differences
1192         as well. This goes together with Adam's bug 90920.
1193
1194         After this patch, the whole Tools/ directory will be unforked :-).
1195
1196         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1197
1198 2012-08-02  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
1199
1200         [Qt] MSVC specific buildfix for DRT.
1201         https://bugs.webkit.org/show_bug.cgi?id=92978
1202
1203         Reviewed by Simon Hausmann.
1204
1205         DumpRenderTree/qt subdirectory is missing from generated makefile under MSVC build, need to be added to the pro file.
1206
1207         * DumpRenderTree/qt/DumpRenderTree.pro:
1208
1209 2012-08-02  Alexander Shalamov  <alexander.shalamov@intel.com>
1210
1211         [EFL][WK2] WTR is failing when X server is not running
1212         https://bugs.webkit.org/show_bug.cgi?id=92719
1213
1214         Reviewed by Hajime Morita.
1215
1216         EFL's WebKitTestRunner doesn't execute tests when X server is not running.
1217         This patch fixes the problem by checking environment variable before ecore x initialization.
1218
1219         * Scripts/webkitpy/layout_tests/port/efl.py:
1220         (EflPort.setup_environ_for_server):
1221         * WebKitTestRunner/efl/main.cpp:
1222         (main):
1223
1224 2012-08-01  Dirk Pranke  <dpranke@chromium.org>
1225
1226         REGRESSION(r123893): Reftest mismatches are run through ImageDiff with 0.1 tolerance
1227         https://bugs.webkit.org/show_bug.cgi?id=92847
1228
1229         Reviewed by Ojan Vafai.
1230
1231         I was failing to distinguish between 'None' and 0 :(. Fixed and added tests.
1232
1233         * Scripts/webkitpy/layout_tests/port/base.py:
1234         (Port.diff_image):
1235         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1236         (PortTestCase.test_diff_image.make_proc):
1237         (PortTestCase.test_diff_image):
1238
1239 2012-08-01  Dirk Pranke  <dpranke@chromium.org>
1240
1241         test-webkitpy: clean up handling of tests to skip
1242         https://bugs.webkit.org/show_bug.cgi?id=92909
1243
1244         Reviewed by Ryosuke Niwa.
1245
1246         This change moves the handling of tests to skip into main.py
1247         where it is at least slightly more findable and generic.
1248
1249         Also fix a couple of lint nits.
1250
1251         * Scripts/webkitpy/test/finder.py:
1252         (Finder.__init__):
1253         (Finder.skip):
1254         (Finder._default_names):
1255         * Scripts/webkitpy/test/main.py:
1256         (main):
1257         (Tester.skip):
1258         * Scripts/webkitpy/test/main_unittest.py:
1259         (TesterTest.test_no_tests_found):
1260         * Scripts/webkitpy/test/runner_unittest.py:
1261
1262 2012-08-01  Dirk Pranke  <dpranke@chromium.org>
1263
1264         test-webkitpy: remove --skip-integrationtests flag
1265         https://bugs.webkit.org/show_bug.cgi?id=92907
1266
1267         Reviewed by Ryosuke Niwa.
1268
1269         This flag is no longer used since the tests complete quickly.
1270         
1271         Also clean up the unused skip_if_parallel arg in finder, and
1272         make a couple of lint fixes.
1273
1274         * Scripts/webkitpy/test/finder.py:
1275         (Finder.find_names):
1276         (Finder._default_names):
1277         * Scripts/webkitpy/test/finder_unittest.py:
1278         (FinderTest.check_names):
1279         (FinderTest.test_default_names):
1280         * Scripts/webkitpy/test/main.py:
1281         (Tester._parse_args):
1282         (Tester.run):
1283         * Scripts/webkitpy/test/main_unittest.py:
1284         (TesterTest.test_no_tests_found):
1285
1286 2012-08-01  Ryosuke Niwa  <rniwa@webkit.org>
1287
1288         Generalize SheriffIRCBot to prepare for PerfBot
1289         https://bugs.webkit.org/show_bug.cgi?id=92912
1290
1291         Reviewed by Adam Barth.
1292
1293         Renamed SheriffIRCBot to IRCBot and generalized to support non-sheriffbot IRC bot in the future.
1294         This will be useful when I add an experimental perf EWS IRC bot.
1295
1296         * Scripts/webkitpy/tool/bot/irc_command.py:
1297         (Whois.execute):
1298         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1299         (IRCCommandTest):
1300         * Scripts/webkitpy/tool/bot/ircbot.py: Moved from Tools/Scripts/webkitpy/tool/bot/sheriffircbot.py.
1301         (Eliza): Moved from irc_command.
1302         (Eliza.__init__):
1303         (Eliza.execute):
1304         (IRCBot):
1305         (IRCBot.__init__):
1306         (IRCBot.irc_delegate):
1307         (IRCBot._parse_command_and_args):
1308         (IRCBot.process_message):
1309         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Moved from Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py.
1310         (run):
1311         (IRCBotTest):
1312         (IRCBotTest.test_eliza): Moved from IRCCommandTest.
1313         (IRCBotTest.test_parse_command_and_args):
1314         (IRCBotTest.test_exception_during_command):
1315         * Scripts/webkitpy/tool/bot/sheriffircbot.py: Removed.
1316         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Removed.
1317         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1318         (SheriffBot.begin_work_queue):
1319         * Scripts/webkitpy/webkitpy.pyproj:
1320
1321 2012-08-01  Dirk Pranke  <dpranke@chromium.org>
1322
1323         nrwt: reenable the test for --verbose working in child processes
1324         https://bugs.webkit.org/show_bug.cgi?id=92894
1325
1326         Reviewed by Ryosuke Niwa.
1327
1328         This change rewrites the test to not use outputcapture, meaning
1329         that the MockHost can propagate to Worker properly and things
1330         work again :).
1331
1332         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1333         (MainTest.test_verbose_in_child_processes):
1334
1335 2012-08-01  Ryosuke Niwa  <rniwa@webkit.org>
1336
1337         run-perf-tests --build-directory doesn't work
1338         https://bugs.webkit.org/show_bug.cgi?id=92051
1339
1340         Reviewed by Dirk Pranke.
1341
1342         The bug was caused by not prepending build_directory even when one is defined.
1343         Fixed that.
1344
1345         * Scripts/webkitpy/layout_tests/port/base.py:
1346         (Port._build_path):
1347         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1348         (PortTest.test_build_path):
1349
1350 2012-08-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1351
1352         Unreviewed, rolling out r123865.
1353         http://trac.webkit.org/changeset/123865
1354         https://bugs.webkit.org/show_bug.cgi?id=92891
1355
1356         This patch is causing the style-queue to fall behind
1357         (Requested by abarth on #webkit).
1358
1359         * Scripts/webkitpy/tool/commands/queues.py:
1360         (AbstractReviewQueue.begin_work_queue):
1361         (StyleQueue.__init__):
1362         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1363         (StyleQueueTest.test_style_queue_with_style_exception):
1364         (test_style_queue_with_watch_list_exception):
1365
1366 2012-08-01  Ryosuke Niwa  <rniwa@webkit.org>
1367
1368         run-perf-tests throws an exception when the output json is malformed
1369         https://bugs.webkit.org/show_bug.cgi?id=92887
1370
1371         Reviewed by Dirk Pranke.
1372
1373         Catch exceptions and gracefully fail. Also split _generate_json into smaller methods.
1374
1375         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1376         (PerfTestsRunner):
1377         (PerfTestsRunner.run):
1378         (PerfTestsRunner._generate_output): Extracted from _generate_json.
1379         (PerfTestsRunner._merge_source_json): Ditto; catch all exceptions since they are too many
1380         exceptions to consder here.
1381         (PerfTestsRunner._merge_outputs): Ditto.
1382         (PerfTestsRunner._generate_output_files): Extracted from _generate_json.
1383         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1384         (_test_run_with_json_output): Don't assert logs when we except an non-zero exit code.
1385         (create_runner_and_setup_results_template): Extracted from test_run_generates_results_page.
1386         (test_run_generates_results_page):
1387         (test_run_with_bad_output_json): Added.
1388         (test_run_with_bad_json_source): Added.
1389         (test_run_with_upload_json):
1390
1391 2012-08-01  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1392
1393         Regression(r124135): nrwt: --verbose logging does not work right on windows
1394         https://bugs.webkit.org/show_bug.cgi?id=92845
1395
1396         Reviewed by Dirk Pranke.
1397
1398         Disabled the failing test. The Workers spawned by this test are using Host()
1399         instead of MockHost() and trying to access the real filesystem instead of the
1400         MockFilesytem.
1401
1402         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1403         (MainTest.disabled_test_verbose):
1404
1405 2012-08-01  Arnaud Renevier  <a.renevier@sisa.samsung.com>
1406
1407         keyring.get_password may raise an exception.
1408         https://bugs.webkit.org/show_bug.cgi?id=92876
1409
1410         Reviewed by Dirk Pranke.
1411
1412         keyring.get_password sometimes raises an exception. We wrap this call,
1413         and also set_password to avoid breaking webkit-patch in that case.
1414
1415         * Scripts/webkitpy/common/net/credentials.py:
1416         (Credentials._offer_to_store_credentials_in_keyring):
1417         (Credentials.read_credentials):
1418
1419 2012-08-01  Xianzhu Wang  <wangxianzhu@chromium.org>
1420
1421         Layout Test fast/text/descent-clip-in-scaled-page.html is failing on linux since it was added
1422         https://bugs.webkit.org/show_bug.cgi?id=91386
1423
1424         Reviewed by Tony Chang.
1425
1426         Added font mapping from SubpixelPositioningAhem to Ahem on Linux and Android
1427         (used in layout test fast/text/descent-clip-in-scaled-page.html).
1428         Added font mapping from SubpixelPositioning to Times New Roman on Android to match Linux
1429         (used in platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html)
1430
1431         * DumpRenderTree/chromium/android_main_fonts.xml:
1432         * DumpRenderTree/chromium/fonts.conf:
1433
1434 2012-08-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1435
1436         Unreviewed, rolling out r124325.
1437         http://trac.webkit.org/changeset/124325
1438         https://bugs.webkit.org/show_bug.cgi?id=92865
1439
1440         broke android build (Requested by mnaganov on #webkit).
1441
1442         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1443
1444 2012-08-01  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1445
1446         [EFL] Dump a backtrace in case of a crash on the UIProcess
1447         https://bugs.webkit.org/show_bug.cgi?id=92843
1448
1449         Reviewed by Csaba Osztrogonác.
1450
1451         We are already dumping the backtraces when automated tests are
1452         crashing, but only for the WebProcess. This patch adds the same
1453         hooks for the UIProcess.
1454
1455         * TestWebKitAPI/efl/main.cpp:
1456         (main):
1457         * WebKitTestRunner/efl/main.cpp:
1458         (main):
1459
1460 2012-08-01  Adam Barth  <abarth@webkit.org>
1461
1462         [Chromium] Merge final nits to DumpRenderTree.gyp for Android
1463         https://bugs.webkit.org/show_bug.cgi?id=90920
1464
1465         Reviewed by Tony Chang.
1466
1467         This patch contains the last few small changes to DumpRenderTree.gyp
1468         from the chromium-android branch. After this change, this file will be
1469         fully merged.
1470
1471         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1472
1473 2012-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1474
1475         [Qt] ImageDiff should use float division instead of integer
1476         https://bugs.webkit.org/show_bug.cgi?id=92859
1477
1478         Reviewed by Zoltan Herczeg.
1479
1480         * DumpRenderTree/qt/ImageDiff.cpp:
1481         (main):
1482
1483 2012-08-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1484
1485         Unreviewed, rolling out r124313.
1486         http://trac.webkit.org/changeset/124313
1487         https://bugs.webkit.org/show_bug.cgi?id=92855
1488
1489         Compilation failed on Chromium ports (Requested by yosin on
1490         #webkit).
1491
1492         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1493         * DumpRenderTree/DumpRenderTree.gypi:
1494         * DumpRenderTree/DumpRenderTree.h:
1495         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1496         * DumpRenderTree/DumpRenderTreeCommon.cpp: Removed.
1497         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1498         (runTest):
1499         (main):
1500         * DumpRenderTree/chromium/TestShell.cpp:
1501         (TestShell::TestShell):
1502         (TestShell::runFileTest):
1503         (TestShell::dump):
1504         * DumpRenderTree/chromium/TestShell.h:
1505         (TestParams):
1506         (TestParams::TestParams):
1507         (TestShell):
1508         * DumpRenderTree/efl/CMakeLists.txt:
1509         * DumpRenderTree/efl/DumpRenderTree.cpp:
1510         (parseCommandLineOptions):
1511         (getFinalTestURL):
1512         (getExpectedPixelHash):
1513         (runTest):
1514         (shouldDumpPixelsAndCompareWithExpected):
1515         (main):
1516         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1517         (initializeGlobalsFromCommandLineOptions):
1518         (dump):
1519         (runTest):
1520         (main):
1521         * DumpRenderTree/mac/DumpRenderTree.mm:
1522         (initializeGlobalsFromCommandLineOptions):
1523         (dumpRenderTree):
1524         (dump):
1525         (runTest):
1526         * DumpRenderTree/qt/DumpRenderTree.pro:
1527         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1528         (WebCore::DumpRenderTree::processLine):
1529         * DumpRenderTree/win/DumpRenderTree.cpp:
1530         (dump):
1531         (runTest):
1532         (dllLauncherEntryPoint):
1533         * DumpRenderTree/win/DumpRenderTree.vcproj:
1534         * DumpRenderTree/wscript:
1535         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1536         (dump):
1537         (runTest):
1538         (MyApp::OnInit):
1539         * GNUmakefile.am:
1540         * Scripts/old-run-webkit-tests:
1541         * Scripts/webkitpy/layout_tests/port/base.py:
1542         (Port.supports_switching_pixel_tests_per_test):
1543         (Port):
1544         (Port._supports_switching_pixel_tests_per_test):
1545         (Port.should_run_as_pixel_test):
1546         * Scripts/webkitpy/layout_tests/port/driver.py:
1547         (Driver.cmd_line):
1548         (Driver._command_from_driver_input):
1549         * Scripts/webkitpy/layout_tests/port/qt.py:
1550         (QtPort._supports_switching_pixel_tests_per_test):
1551         * Scripts/webkitpy/layout_tests/port/test.py:
1552         (TestPort.supports_switching_pixel_tests_per_test):
1553         * WebKitTestRunner/TestController.cpp:
1554         (WTR::TestController::TestController):
1555         (WTR::TestController::initialize):
1556         (WTR::TestController::runTest):
1557         * WebKitTestRunner/TestController.h:
1558         (TestController):
1559
1560 2012-08-01  Balazs Kelemen  <kbalazs@webkit.org>
1561
1562         All ports should support per test switching of pixel testing
1563         https://bugs.webkit.org/show_bug.cgi?id=92398
1564
1565         Reviewed by Dirk Pranke.
1566
1567         Teach all test drivers to accept a per test control of whether
1568         to dump pixels. Drivers now accept a -p/--pixel-test argument
1569         on the standart input that means that running the current
1570         test as pixel test is allowed (even if the expected hash is
1571         missing). Removed the --pixel-tests command line option since
1572         there is no need for it anymore.
1573
1574         * DumpRenderTree/DumpRenderTree.gypi:
1575         * DumpRenderTree/DumpRenderTree.h:
1576         (TestCommand::TestCommand):
1577         (TestCommand):
1578         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1579         * DumpRenderTree/DumpRenderTreeCommon.cpp: Added.
1580         (CommandTokenizer):
1581         (CommandTokenizer::CommandTokenizer):
1582         (CommandTokenizer::pump):
1583         (CommandTokenizer::next):
1584         (CommandTokenizer::hasNext):
1585         (die):
1586         (parseInputLine):
1587         Common logic to parse the input line from the standard input (or from the command line
1588         in standalone mode). Made it somewhat general so we can easily add more arguments if
1589         there is a need.
1590         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1591         (runTest):
1592         (main):
1593         * DumpRenderTree/chromium/TestShell.cpp:
1594         (TestShell::TestShell):
1595         (TestShell::runFileTest):
1596         (TestShell::dump):
1597         * DumpRenderTree/chromium/TestShell.h:
1598         (TestParams::TestParams):
1599         (TestShell):
1600         * DumpRenderTree/efl/CMakeLists.txt:
1601         * DumpRenderTree/efl/DumpRenderTree.cpp:
1602         (parseCommandLineOptions):
1603         (runTest):
1604         (shouldDumpPixelsAndCompareWithExpected):
1605         (main):
1606         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1607         (initializeGlobalsFromCommandLineOptions):
1608         (dump):
1609         * DumpRenderTree/mac/DumpRenderTree.mm:
1610         (initializeGlobalsFromCommandLineOptions):
1611         (dumpRenderTree):
1612         * DumpRenderTree/qt/DumpRenderTree.pro:
1613         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1614         (WebCore::DumpRenderTree::processLine):
1615         * DumpRenderTree/win/DumpRenderTree.cpp:
1616         (dump):
1617         (runTest):
1618         (dllLauncherEntryPoint):
1619         * DumpRenderTree/win/DumpRenderTree.vcproj:
1620         * DumpRenderTree/wscript:
1621         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1622         (dump):
1623         (runTest):
1624         (MyApp::OnInit):
1625         * Scripts/old-run-webkit-tests: Pass --pixel-test before the hash.
1626         Changed the separator form ' to : because it don't need to be escaped
1627         when passing manually on the comand line.
1628         * Scripts/webkitpy/layout_tests/port/base.py:
1629         (Port.should_run_as_pixel_test): Removed now that all ports supports it.
1630         * Scripts/webkitpy/layout_tests/port/driver.py:
1631         (Driver.cmd_line): Don't pass --pixel-tests anymore.
1632         (Driver._command_from_driver_input):
1633
1634         * WebKitTestRunner/TestController.cpp:
1635         (WTR::TestController::TestController):
1636         (WTR::TestController::initialize):
1637         (WTR::TestCommand::TestCommand):
1638         (TestCommand):
1639         (WTR):
1640         (CommandTokenizer):
1641         (WTR::CommandTokenizer::CommandTokenizer):
1642         (WTR::CommandTokenizer::pump):
1643         (WTR::CommandTokenizer::next):
1644         (WTR::CommandTokenizer::hasNext):
1645         (WTR::die):
1646         (WTR::parseInputLine):
1647         (WTR::TestController::runTest):
1648         * WebKitTestRunner/TestController.h:
1649         (TestController):
1650         Duplicate the logic for parsing the command line because
1651         unfortunately there is no way to share code between
1652         WebKitTestRunner and DumpRenderTree.
1653
1654 2012-08-01  Martin Robinson  <mrobinson@igalia.com>
1655
1656         Add the jhbuild source directory to the __builtin__ object
1657
1658         Reviewed by Philippe Normand.
1659
1660         It seems that the jhbuild script explicitly looks for the SRCDIR __builtin__ when
1661         initializing. This is necessary for loading the jhbuild from the checkout directory.
1662
1663         * jhbuild/jhbuildutils.py:
1664         (enter_jhbuild_environment_if_available): Set SRCDIR to the source directory.
1665
1666 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
1667
1668         nrwt: move actual test-running code into layout_test_runner.py
1669         https://bugs.webkit.org/show_bug.cgi?id=92806
1670
1671         Reviewed by Ryosuke Niwa.
1672
1673         This is the final patch in manager-refactoring series (for now).
1674         This moves all of the logic to actually run the tests into
1675         layout_test_runner (in a new LayoutTestRunner) class. Now
1676         the mechanics of actually executing all of  the tests are
1677         contained in one file (of course the actual work of talking to
1678         DRT/WTR and diff'ing the results is still in single_test_runner).
1679
1680         Now manager is left with setting up and tearing down the test
1681         environment, finding the tests to run, and processing the
1682         results of the tests, which is a pretty managable amount of code
1683         (no pun intended).
1684
1685         The unit tests for manager were split in two and all of the
1686         runner-specific tests moved into layout_test_runner_unittest.
1687         They were significantly cleaned up to be easier to read and
1688         maintain as a part of this.
1689
1690         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1691         (TestRunInterruptedException):
1692         (TestRunInterruptedException.__init__):
1693         (TestRunInterruptedException.__reduce__):
1694         (LayoutTestRunner):
1695         (LayoutTestRunner.__init__):
1696         (LayoutTestRunner.test_key):
1697         (LayoutTestRunner.run_tests):
1698         (LayoutTestRunner.run_tests.worker_factory):
1699         (LayoutTestRunner.run_tests.instead):
1700         (LayoutTestRunner._mark_interrupted_tests_as_skipped):
1701         (LayoutTestRunner._interrupt_if_at_failure_limits):
1702         (LayoutTestRunner._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
1703         (LayoutTestRunner._update_summary_with_result):
1704         (LayoutTestRunner.start_servers_with_lock):
1705         (LayoutTestRunner.stop_servers_with_lock):
1706         (LayoutTestRunner.handle):
1707         (LayoutTestRunner._handle_started_test):
1708         (LayoutTestRunner._handle_finished_test_list):
1709         (LayoutTestRunner._handle_finished_test_list.find):
1710         (LayoutTestRunner._handle_finished_test):
1711         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1712         (FakePrinter):
1713         (FakePrinter.print_workers_and_shards):
1714         (FakePrinter.print_finished_test):
1715         (FakePrinter.write):
1716         (FakePrinter.write_update):
1717         (FakePrinter.flush):
1718         (LockCheckingRunner):
1719         (LockCheckingRunner.__init__):
1720         (LockCheckingRunner.handle_finished_list):
1721         (LayoutTestRunnerTests):
1722         (LayoutTestRunnerTests._runner):
1723         (LayoutTestRunnerTests._result_summary):
1724         (LayoutTestRunnerTests._run_tests):
1725         (LayoutTestRunnerTests.test_http_locking):
1726         (LayoutTestRunnerTests.test_perf_locking):
1727         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
1728         (LayoutTestRunnerTests.test_update_summary_with_result):
1729         (LayoutTestRunnerTests.test_servers_started):
1730         (LayoutTestRunnerTests.test_servers_started.start_http_server):
1731         (LayoutTestRunnerTests.test_servers_started.start_websocket_server):
1732         (LayoutTestRunnerTests.test_servers_started.stop_http_server):
1733         (LayoutTestRunnerTests.test_servers_started.stop_websocket_server):
1734         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1735         (summarize_results):
1736         (Manager.__init__):
1737         (Manager._is_http_test):
1738         (Manager):
1739         (Manager._is_websocket_test):
1740         (Manager._websocket_tests):
1741         (Manager._prepare_lists):
1742         (Manager._is_ref_test):
1743         (Manager.run):
1744         (Manager._run_tests):
1745         (Manager._look_for_new_crash_logs):
1746         (Manager._show_results_html_file):
1747         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1748         (ManagerTest.test_look_for_new_crash_logs):
1749         (ResultSummaryTest.summarized_results):
1750         (ResultSummaryTest.test_summarized_results_wontfix):
1751
1752 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
1753
1754         nrwt: move sharding logic into layout_test_runner.py
1755         https://bugs.webkit.org/show_bug.cgi?id=92805
1756
1757         Reviewed by Ryosuke Niwa.
1758
1759         The sharding logic is specific to how we actually run the tests,
1760         so it belongs in this file instead of manager.py or finder.py.
1761
1762         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1763         (Worker._run_single_test):
1764         (TestShard):
1765         (TestShard.__init__):
1766         (TestShard.__repr__):
1767         (TestShard.__eq__):
1768         (Sharder):
1769         (Sharder.__init__):
1770         (Sharder.shard_tests):
1771         (Sharder.shard_tests.or):
1772         (Sharder._shard_in_two):
1773         (Sharder._shard_every_file):
1774         (Sharder._shard_by_directory):
1775         (Sharder._resize_shards):
1776         (Sharder._resize_shards.divide_and_round_up):
1777         (Sharder._resize_shards.extract_and_flatten):
1778         (Sharder._resize_shards.split_at):
1779         (Sharder._dir_for_test_input):
1780         (Sharder.test_key):
1781         (Sharder.natural_sort_key):
1782         (Sharder.natural_sort_key.tryint):
1783         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Added.
1784         (SharderTests):
1785         (SharderTests.get_test_input):
1786         (SharderTests.get_shards):
1787         (SharderTests.get_shards.split):
1788         (SharderTests.assert_shards):
1789         (SharderTests.test_shard_by_dir):
1790         (SharderTests.test_shard_by_dir_sharding_ref_tests):
1791         (SharderTests.test_shard_every_file):
1792         (SharderTests.test_shard_in_two):
1793         (SharderTests.test_shard_in_two_sharding_ref_tests):
1794         (SharderTests.test_shard_in_two_has_no_locked_shards):
1795         (SharderTests.test_shard_in_two_has_no_unlocked_shards):
1796         (SharderTests.test_multiple_locked_shards):
1797         (NaturalCompareTest):
1798         (NaturalCompareTest.assert_cmp):
1799         (NaturalCompareTest.test_natural_compare):
1800         (KeyCompareTest):
1801         (KeyCompareTest.setUp):
1802         (KeyCompareTest.setUp.split):
1803         (KeyCompareTest.assert_cmp):
1804         (KeyCompareTest.test_test_key):
1805         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1806         (Manager.__init__):
1807         (Manager._prepare_lists):
1808         (Manager._is_ref_test):
1809         (Manager._run_tests):
1810         (Manager._handle_finished_test):
1811         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1812         (ManagerTest.get_options):
1813         (ManagerTest.test_interrupt_if_at_failure_limits):
1814         (ManagerTest.test_update_summary_with_result):
1815         (ManagerTest.test_needs_servers.get_manager_with_tests):
1816         (ManagerTest.integration_test_needs_servers.get_manager_with_tests):
1817         (ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):
1818         (ManagerTest.test_servers_started):
1819         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1820         (parse_args):
1821
1822 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
1823
1824         nrwt: rename worker.py to layout_test_runner.py
1825         https://bugs.webkit.org/show_bug.cgi?id=92804
1826
1827         Reviewed by Ojan Vafai.
1828
1829         Home stretch of this round of manager refactoring ... I will be
1830         moving all of the actual test-running code (which includes the
1831         code that shards the tests for the workers) into a different
1832         module, and it makes sense for that module to contain the actual
1833         worker code, so I'm renaming worker.py to layout_test_runner.py.
1834
1835         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/worker.py.
1836         (Worker):
1837         (Worker.__init__):
1838         (Worker.__del__):
1839         (Worker.start):
1840         (Worker.handle):
1841         (Worker._update_test_input):
1842         (Worker._run_test):
1843         (Worker.stop):
1844         (Worker._timeout):
1845         (Worker._kill_driver):
1846         (Worker._run_test_with_timeout):
1847         (Worker._clean_up_after_test):
1848         (Worker._run_test_in_another_thread):
1849         (Worker._run_test_in_another_thread.SingleTestThread):
1850         (Worker._run_test_in_another_thread.SingleTestThread.__init__):
1851         (Worker._run_test_in_another_thread.SingleTestThread.run):
1852         (Worker._run_test_in_this_thread):
1853         (Worker._run_single_test):
1854         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1855         (Manager._run_tests.worker_factory):
1856
1857 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
1858
1859         nrwt: clean up names in sharding code
1860         https://bugs.webkit.org/show_bug.cgi?id=92785
1861
1862         Reviewed by Ryosuke Niwa.
1863
1864         More refactoring ... this makes the methods use TestInputs
1865         consistently (and updates the names accordingly) and improves
1866         encapsulation a bit. The sharding code is now pretty
1867         self-contained.
1868
1869         This change adds no new functionality and is covered by the
1870         existing (updated) tests.
1871
1872         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1873         (TestShard.visible.__init__):
1874         (TestShard.visible.__repr__):
1875         (Manager._dir_for_test_input):
1876         (Manager._shard_tests):
1877         (Manager._shard_in_two):
1878         (Manager._shard_every_file):
1879         (Manager._shard_by_directory):
1880         (Manager._run_tests):
1881         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1882         (ManagerWrapper._test_input_for_file):
1883         (ShardingTests.get_shards):
1884         * Scripts/webkitpy/layout_tests/models/test_input.py:
1885         (TestInput.__init__):
1886         (TestInput.__repr__):
1887
1888 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
1889
1890         nrwt: clean up TestInputs in preparation for cleaning up sharding
1891         https://bugs.webkit.org/show_bug.cgi?id=92784
1892
1893         Reviewed by Ryosuke Niwa.
1894
1895         Currently, in order to shard the tests you need to refer to
1896         state in the manager as well as the state in the TestInputs;
1897         this change embeds the necessary state into the TestInputs so
1898         sharding them can be a standalone operation.
1899
1900         The actual clean up of the sharding will follow in a subsequent patch.
1901
1902         Covered by existing tests; no new functionality. However, I did
1903         rework the sharding tests to be less dependent on the test
1904         scaffolding and easier to follow.
1905
1906         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1907         (Manager._test_input_for_file):
1908         (Manager._shard_in_two):
1909         (Manager._shard_every_file):
1910         (Manager._shard_by_directory):
1911         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1912         (ManagerWrapper._test_input_for_file):
1913         (ShardingTests.assert_shards):
1914         (ShardingTests.test_shard_by_dir):
1915         (ShardingTests.test_shard_by_dir_sharding_ref_tests):
1916         (ShardingTests.test_shard_every_file):
1917         (ShardingTests.test_shard_in_two):
1918         (ShardingTests.test_shard_in_two_sharding_ref_tests):
1919         (ShardingTests.test_shard_in_two_has_no_unlocked_shards):
1920         (ShardingTests.test_multiple_locked_shards):
1921         * Scripts/webkitpy/layout_tests/models/test_input.py:
1922         (TestInput.__init__):
1923         (TestInput.__repr__):
1924
1925 2012-07-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1926
1927         [EFL] Dump a backtrace in case of a crash
1928         https://bugs.webkit.org/show_bug.cgi?id=92489
1929
1930         Reviewed by Csaba Osztrogonác.
1931
1932         Dump a stack trace in case of a unexpected signal. This should
1933         provide a better report at the build bots when WTR crashes.
1934
1935         * DumpRenderTree/efl/DumpRenderTree.cpp:
1936         (main):
1937         * TestWebKitAPI/efl/InjectedBundleController.cpp:
1938         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1939         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp:
1940         (WTR::InjectedBundle::platformInitialize):
1941
1942 2012-07-31  Joshua Netterfield  <jnetterfield@rim.com>
1943
1944         [BlackBerry] Enable CSS Filter Effects
1945         https://bugs.webkit.org/show_bug.cgi?id=92685
1946
1947         Reviewed by Rob Buis.
1948
1949         Enable CSS filter effects, with the exception of custom effects (CSS shaders) and reference effects (SVG effects)
1950
1951         Internally reviewed by Arvid Nilsson <anilsson@rim.com> and Antonio Gomes <agomes@rim.com>.
1952
1953         * Scripts/webkitperl/FeatureList.pm: Acknowledge CSS filter effects.
1954
1955 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
1956
1957         nrwt: clean up prepare_lists_and_print_output, run, set_up_run a bit
1958         https://bugs.webkit.org/show_bug.cgi?id=92781
1959
1960         Reviewed by Ryosuke Niwa.
1961
1962         More refactoring ... rename prepare_lists_and_print_output to
1963         just prepare_lists so that it only has a single purpose, and
1964         clean up the surrounding code a bit as well.
1965
1966         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1967         (Manager._collect_tests):
1968         (Manager._prepare_lists):
1969         (Manager._set_up_run):
1970         (Manager.run):
1971
1972 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
1973
1974         nrwt: clean up self._test_files_list vs. self._test_files, other nits
1975         https://bugs.webkit.org/show_bug.cgi?id=92702
1976
1977         Reviewed by Ojan Vafai.
1978
1979         Get rid of self._test_files, rename self._test_files_list to
1980         self._test_names (removing the confusion between the two fields).
1981
1982         Also inline the one call to _parse_expectations, remove the one
1983         use of more_tests_to_skip, and fix a couple of minor nits.
1984
1985         * Scripts/webkitpy/layout_tests/controllers/finder.py:
1986         (LayoutTestFinder.split_into_chunks):
1987         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1988         (Manager.__init__):
1989         (Manager._collect_tests):
1990         (Manager._http_tests):
1991         (Manager._websocket_tests):
1992         (Manager._is_perf_test):
1993         (Manager.prepare_lists_and_print_output):
1994         (Manager.needs_servers):
1995         (Manager.run):
1996         (Manager._mark_interrupted_tests_as_skipped):
1997         (Manager._update_summary_with_result):
1998         (Manager._upload_json_files):
1999         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2000         (ManagerTest.test_interrupt_if_at_failure_limits):
2001         (ManagerTest.test_needs_servers.get_manager_with_tests):
2002         (ManagerTest.test_servers_started):
2003
2004 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
2005
2006         nrwt: --verbose logging does not work right on windows
2007         https://bugs.webkit.org/show_bug.cgi?id=92673
2008
2009         Reviewed by Ojan Vafai.
2010
2011         Add a test for r124090.
2012
2013         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2014         (MainTest.test_verbose):
2015
2016 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
2017
2018         REGRESSION(124116): Number of skipped tests isn't printed anymore
2019         https://bugs.webkit.org/show_bug.cgi?id=92736
2020
2021         Reviewed by Tony Chang.
2022
2023         Add the skipped number back in; it was useful ... also clean up
2024         the formatting a little bit.
2025
2026         * Scripts/webkitpy/layout_tests/views/printing.py:
2027         (Printer.print_found):
2028
2029 2012-07-31  Hans Wennborg  <hans@chromium.org>
2030
2031         Speech JavaScript API: Throw exception for start() when already started
2032         https://bugs.webkit.org/show_bug.cgi?id=92756
2033
2034         Reviewed by Adam Barth.
2035
2036         Fix the task queue in MockWebSpeechRecognizer.
2037         It's important that we remove the task from the queue before we run
2038         it, as running the task could alter the queue's state.
2039
2040         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2041         (MockWebSpeechRecognizer::abort):
2042         (MockWebSpeechRecognizer::setError):
2043         (MockWebSpeechRecognizer::clearTaskQueue):
2044         (MockWebSpeechRecognizer::StepTask::runIfValid):
2045         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
2046         (MockWebSpeechRecognizer):
2047
2048 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
2049
2050         nrwt: move handling the initial list of tests to skip to finder
2051         https://bugs.webkit.org/show_bug.cgi?id=92701
2052
2053         Reviewed by Ryosuke Niwa.
2054
2055         More refactoring of manager ...
2056
2057         * Scripts/webkitpy/layout_tests/controllers/finder.py:
2058         (LayoutTestFinder.skip_tests):
2059         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2060         (Manager._collect_tests):
2061         (Manager.prepare_lists_and_print_output):
2062
2063 2012-07-31  Alexey Proskuryakov  <ap@apple.com>
2064
2065         [WK2] Kill the concept of secondary shared process
2066         https://bugs.webkit.org/show_bug.cgi?id=92676
2067
2068         Reviewed by Sam Weinig.
2069
2070         * MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Update Windows build fix.
2071         Don't create a new context for every view.
2072
2073 2012-07-31  Peter Beverloo  <peter@chromium.org>
2074
2075         [Chromium] Don't use ninja for building Chromium for Android
2076         https://bugs.webkit.org/show_bug.cgi?id=92764
2077
2078         Reviewed by Adam Barth.
2079
2080         When Ninja projects files are generated (which will be done for Android),
2081         make sure that the Android builder doesn't unintentionally switch to
2082         using Ninja. We should make that switch at a predetermined time.
2083
2084         * Scripts/webkitdirs.pm:
2085         (buildChromium):
2086
2087 2012-07-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2088
2089         Add a mechanism to dump the stack trace in case of a crash
2090         https://bugs.webkit.org/show_bug.cgi?id=92666
2091
2092         Reviewed by Csaba Osztrogonác.
2093
2094         Move crash signal handlers to WTFInstallReportBacktraceOnCrashHook()
2095         and eliminate some duplicated code.
2096
2097         * DumpRenderTree/qt/main.cpp:
2098         (main):
2099         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2100         (WTR::InjectedBundle::platformInitialize):
2101
2102 2012-07-31  Jochen Eisinger  <jochen@chromium.org>
2103
2104         [chromium] move EventSender into TestRunner.a
2105         https://bugs.webkit.org/show_bug.cgi?id=92277
2106
2107         Reviewed by Adam Barth.
2108
2109         * DumpRenderTree/DumpRenderTree.gypi:
2110         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2111         * DumpRenderTree/chromium/TestRunner/EventSender.cpp: Renamed from Tools/DumpRenderTree/chromium/EventSender.cpp.
2112         * DumpRenderTree/chromium/TestRunner/EventSender.h: Renamed from Tools/DumpRenderTree/chromium/EventSender.h.
2113         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
2114         (TestInterfaces::Internal::eventSender):
2115         (TestInterfaces::Internal):
2116         (TestInterfaces::Internal::Internal):
2117         (TestInterfaces::Internal::~Internal):
2118         (TestInterfaces::Internal::setWebView):
2119         (TestInterfaces::Internal::setDelegate):
2120         (TestInterfaces::Internal::bindTo):
2121         (TestInterfaces::Internal::resetAll):
2122         (TestInterfaces::eventSender):
2123         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
2124         (TestInterfaces):
2125         * DumpRenderTree/chromium/TestShell.cpp:
2126         (TestShell::initialize):
2127         (TestShell::createMainWindow):
2128         (TestShell::~TestShell):
2129         (TestShell::resetTestController):
2130         (TestShell::bindJSObjectsToWindow):
2131         * DumpRenderTree/chromium/TestShell.h:
2132         (TestShell::eventSender):
2133         (TestShell):
2134         * DumpRenderTree/chromium/WebViewHost.cpp:
2135
2136 2012-07-31  Jochen Eisinger  <jochen@chromium.org>
2137
2138         Unreviewed. Update watchlist
2139
2140         * Scripts/webkitpy/common/config/watchlist: Turned out to be less useful than I had hoped
2141
2142 2012-07-31  Kent Tamura  <tkent@chromium.org>
2143
2144         Unreviewed, update watchlist
2145
2146         * Scripts/webkitpy/common/config/watchlist:
2147         - Improve "Forms" filename pattern.
2148         - tkent stops watching Chromium DRT. It was not so helpful.
2149
2150 2012-07-31  Martin Robinson  <mrobinson@igalia.com>
2151
2152         [jhbuild] Also try to load jhbuild Python module from the source checkout
2153
2154         Reviewed by Philippe Normand.
2155
2156         JHBuild also seems to have an installation mode where it prefers to load its
2157         Python modules from the source checkout. This seems to be used particularly
2158         on the GTK+ 64-bit release bot. We should fall back to this mode.
2159
2160         * jhbuild/jhbuildutils.py:
2161         (enter_jhbuild_environment_if_available): Use the source checkout if there
2162         is no installation path.
2163
2164 2012-07-30  Ryosuke Niwa  <rniwa@webkit.org>
2165
2166         Revert r124153 and land the "right" build fix per ap's comment on the bug 92676.
2167
2168         * MiniBrowser/win/BrowserView.cpp:
2169         (BrowserView::create):
2170
2171 2012-07-30  Sam Weinig  <sam@webkit.org>
2172
2173         Rename WebKit2.h to WebKit2_C.h
2174         https://bugs.webkit.org/show_bug.cgi?id=92704
2175
2176         Reviewed by Dan Bernstein.
2177
2178         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2179         * MiniBrowser/win/BrowserView.h:
2180         * TestWebKitAPI/config.h:
2181         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2182         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2183         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2184         * WebKitTestRunner/config.h:
2185         Update for changed header file name.
2186
2187 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
2188
2189         chromium win compile broken after removing webkit.py
2190         https://bugs.webkit.org/show_bug.cgi?id=92549
2191
2192         Reviewed by Ryosuke Niwa.
2193
2194         Remove the stub file for webkit.py now that it's no longer
2195         necessary.
2196
2197         * Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
2198
2199 2012-07-30  Ryosuke Niwa  <rniwa@webkit.org>
2200
2201         Windows build fix attempt after r124092.
2202
2203         * MiniBrowser/win/BrowserView.cpp:
2204         (BrowserView::create):
2205
2206 2012-07-30  Ryosuke Niwa  <rniwa@webkit.org>
2207
2208         Remove erroneously committed debugging print call from a test.
2209
2210         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2211         (test_run_generates_results_page):
2212
2213 2012-07-30  Arnaud Renevier  <a.renevier@sisa.samsung.com>
2214
2215         webkit-patch: system keyring is not used to read my password
2216         https://bugs.webkit.org/show_bug.cgi?id=92532
2217
2218         Reviewed by Dirk Pranke.
2219
2220         In case no username can be fetched from environment, git or keychain,
2221         prompt for username, and try to get password from keyring associated
2222         with that username.
2223
2224         * Scripts/webkitpy/common/net/credentials.py:
2225         (Credentials.read_credentials):
2226         * Scripts/webkitpy/common/net/credentials_unittest.py:
2227         (test_keyring_without_git_repo_nor_keychain):
2228         (test_keyring_without_git_repo_nor_keychain.MockKeyring):
2229         (test_keyring_without_git_repo_nor_keychain.MockKeyring.get_password):
2230         (test_keyring_without_git_repo_nor_keychain.FakeCredentials):
2231         (test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_keychain):
2232         (test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_environment):
2233         (test_keyring_without_git_repo_nor_keychain.FakeUser):
2234         (test_keyring_without_git_repo_nor_keychain.FakeUser.prompt):
2235         (test_keyring_without_git_repo_nor_keychain.FakeUser.prompt_password):
2236
2237 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
2238
2239         nrwt: move the code that identifies the chunk of tests to run into finder
2240         https://bugs.webkit.org/show_bug.cgi?id=92694
2241
2242         Reviewed by Ryosuke Niwa.
2243
2244         Another patch to make manager.py smaller and clearer; this patch moves
2245         the handling of breaking the list of tests into chunks (--run-part,
2246         --run-chunk) from manager.py to finder.py.
2247
2248         There are no functional changes and this is covered by existing tests.
2249
2250         * Scripts/webkitpy/layout_tests/controllers/finder.py:
2251         (Finder.__init__):
2252         (Finder._read_test_files):
2253         (Finder):
2254         (Finder.split_into_chunks_if_necessary):
2255         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2256         (Manager.__init__):
2257         (Manager._collect_tests):
2258         (Manager._parse_expectations):
2259         (Manager.prepare_lists_and_print_output):
2260
2261 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
2262
2263         nrwt: split test-finding code out from manager.py
2264         https://bugs.webkit.org/show_bug.cgi?id=92693
2265
2266         Reviewed by Ryosuke Niwa.
2267
2268         In the interest of making manager.py smaller, this patch moves
2269         the code that actually takes the command line arguments and
2270         --test-file lists of tests to run and expands them into an
2271         actual list of tests out into a separate module.
2272
2273         * Scripts/webkitpy/layout_tests/controllers/finder.py: Added.
2274         (LayoutTestFinder):
2275         (LayoutTestFinder.__init__):
2276         (LayoutTestFinder.find_tests):
2277         (LayoutTestFinder._strip_test_dir_prefixes):
2278         (LayoutTestFinder._strip_test_dir_prefix):
2279         (LayoutTestFinder._read_test_names_from_file):
2280         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2281         (Manager._collect_tests):
2282         (Manager._handle_finished_test):
2283         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2284         (strip_comments):
2285
2286 2012-07-30  Adam Barth  <abarth@webkit.org>
2287
2288         commit-queue is corrupting ChangeLogs
2289         https://bugs.webkit.org/show_bug.cgi?id=92681
2290
2291         Reviewed by Tony Chang.
2292
2293         Some commits made with the commit-queue are ending up with duplicate
2294         ChangeLog entries. I've hot-patched the servers to not use a special
2295         merge driver for ChangeLogs, which should fix this issue. This patch
2296         removes the merge driver from our cold-boot.sh script so that we won't
2297         use it on new commit-queue instances.
2298
2299         * EWSTools/cold-boot.sh:
2300
2301 2012-07-28  Sam Weinig  <sam@webkit.org>
2302
2303         Add ability to load from a string to the ObjC WK API
2304         https://bugs.webkit.org/show_bug.cgi?id=92590
2305
2306         Reviewed by Dan Bernstein.
2307
2308         Add tests for [WKBrowsingContextController loadHTMLString:baseURL:]. We will be able
2309         to greatly improve these tests (to test more than just not crashing) when methods to
2310         access page content are added (soon!).
2311
2312         Adds:
2313             Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString
2314             Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilBaseURL
2315             Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilHTMLStringAndBaseURL
2316
2317         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2318         Adds tests and refactors delegates to not use global state.
2319
2320 2012-07-30  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2321
2322         [CMake] TestWebKitAPI bundle should link with WTF
2323         https://bugs.webkit.org/show_bug.cgi?id=92616
2324
2325         Reviewed by Antonio Gomes.
2326
2327         Fixes build when shared core is disabled.
2328
2329         * TestWebKitAPI/CMakeLists.txt:
2330
2331 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
2332
2333         nrwt: clean up handling of 'expected' stats
2334         https://bugs.webkit.org/show_bug.cgi?id=92527
2335
2336         Reviewed by Tony Chang.
2337
2338         This patch alters the way we compute and log the "expected"
2339         results and how we treat skipped tests; we will now log the
2340         number of skipped tests separately from the categories, e.g.:
2341
2342         Found 31607 tests; running 24464.
2343         Expect: 23496 passes   (23496 now,    0 wontfix)
2344         Expect:   548 failures (  543 now,    5 wontfix)
2345         Expect:   420 flaky    (  245 now,  175 wontfix)
2346
2347         (so that the "expect" totals add up to the "running" totals);
2348         in addition, the totals in the one-line-progress reflect the
2349         number of tests we will actually run. If --iterations or
2350         --repeat-each are specified, the number of tests we run are
2351         multiplied as appropriate, but the "expect" numbers are
2352         unchanged, since we don't count multiple invocations of the same
2353         test multiple times. In addition, if we are using --run-part or
2354         --run-chunk, the tests we don't run are treated as skipped
2355         for consistency. We will also log the values for --iterations
2356         and --repeat each as part of the found/running line.
2357
2358         Previously the code had parsed and re-parsed the
2359         TestExpectations files several times in an attempt to come up
2360         with some sane statistics, but this was expensive and lead to
2361         confusing layer; treating files as skipped in the way described
2362         above is more consistent and cleaner.
2363
2364         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2365         (Manager._split_into_chunks_if_necessary):
2366         (Manager.prepare_lists_and_print_output):
2367         (Manager.run):
2368         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2369         (ManagerTest.test_interrupt_if_at_failure_limits):
2370         (ManagerTest.test_update_summary_with_result):
2371         (ManagerTest.test_look_for_new_crash_logs):
2372         (ResultSummaryTest.get_result_summary):
2373         * Scripts/webkitpy/layout_tests/models/result_summary.py:
2374         (ResultSummary.__init__):
2375         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2376         (TestExpectationParser.expectation_for_skipped_test):
2377         (TestExpectations.__init__):
2378         (TestExpectations.add_skipped_tests):
2379           Here we make add_skipped_tests() public, so that we can update
2380           the expectations for tests that we are skipping due to
2381           --run-part or --run-chunk; we use the wontfix flag so that
2382           the tests that are intentionally skipped aren't considered
2383           "fixable".
2384         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2385         (SkippedTests.check):
2386         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2387         (parse_args):
2388         * Scripts/webkitpy/layout_tests/views/printing.py:
2389         (Printer.print_found):
2390         (Printer):
2391         (Printer.print_expected):
2392         (Printer._print_result_summary):
2393         (Printer._print_result_summary_entry):
2394           Here we split out printing the number of tests found and run
2395           from the expected results, to be clearer and so that we don't
2396           have to reparse the expectations to update the stats.
2397         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2398         (Testprinter.get_result_summary):
2399
2400 2012-07-30  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2401
2402         Propagate gesture events to plugins.
2403         https://bugs.webkit.org/show_bug.cgi?id=92281
2404
2405         Reviewed by Adam Barth.
2406
2407         Update TestWebPlugin to receive events, and output logs for the events.
2408
2409         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2410         (TestWebPlugin::handleInputEvent):
2411         * DumpRenderTree/chromium/TestWebPlugin.h:
2412         (TestWebPlugin::acceptsInputEvents):
2413         (TestWebPlugin):
2414
2415 2012-07-30  Raphael Kubo da Costa  <rakuco@webkit.org>
2416
2417         [jhbuild] gnutls 2.12.14 does not build with glibc 2.16.0
2418         https://bugs.webkit.org/show_bug.cgi?id=90643
2419
2420         Reviewed by Gustavo Noronha Silva.
2421
2422         The 2.x series of gnutls has a version of Gnulib that is
2423         incompatible with glibc 2.16.0, which now does not define gets()
2424         by default.
2425
2426         After talking to kov, mrobinson and philn, it looks like it makes
2427         sense to simply remove gnutls from jhbuild.modules and rely on the
2428         version installed on the system being recent enough.
2429
2430         This means at least version 2.12.8 for PKCS11 support, or at the
2431         very least 2.11.0 (these are the minimum versions enforced by
2432         glib-networking's configure.ac).
2433
2434         * efl/jhbuild.modules: Do not build gnutls anymore, make
2435         glib-networking depend on glib instead, and move the libgcrypt
2436         dependency to eet, which is what currently needs it.
2437         * gtk/jhbuild.modules: Do not build gnutls anymore.
2438
2439 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
2440
2441         nrwt: --verbose logging does not work right on windows
2442         https://bugs.webkit.org/show_bug.cgi?id=92673
2443
2444         Unreviewed, build fix.
2445
2446         The --verbose log level is not being propagated to the worker
2447         processes on windows properly; this has been broken ever since I
2448         refactored logging into the message pool directly :(.
2449
2450         Also, fixing this revealed that outputcapture wasn't saving and
2451         restoring log levels correctly, so I had to fix that as well.
2452
2453         * Scripts/webkitpy/common/message_pool.py:
2454         (_MessagePool._start_workers):
2455         (_MessagePool._worker_log_level):
2456         (_Worker.__init__):
2457         (_Worker._set_up_logging):
2458         (_WorkerLogHandler.__init__):
2459         * Scripts/webkitpy/common/system/outputcapture.py:
2460         (OutputCapture.capture_output):
2461         (OutputCapture.restore_output):
2462
2463 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
2464
2465         After r123895, new-run-webkit-tests can fail with TypeError when a test crashes
2466         https://bugs.webkit.org/show_bug.cgi?id=92664
2467
2468         Reviewed by Michael Saboff.
2469
2470         Updated to handle crash_logs being returned as a tuple of (stderr, crash_log).
2471
2472         * Scripts/webkitpy/layout_tests/port/mac.py:
2473         (MacPort.look_for_new_crash_logs):
2474
2475 2012-07-30  Stephen White  <senorblanco@chromium.org>
2476
2477         Added a SkiaGraphics definition to the watchlist file; cc'ed myself
2478         to that group.  Unreviewed.
2479
2480         * Scripts/webkitpy/common/config/watchlist:
2481
2482 2012-07-30  Sheriff Bot  <webkit.review.bot@gmail.com>
2483
2484         Unreviewed, rolling out r123966 and r123967.
2485         http://trac.webkit.org/changeset/123966
2486         http://trac.webkit.org/changeset/123967
2487         https://bugs.webkit.org/show_bug.cgi?id=92656
2488
2489         This patch is causing assertion failures on the debug bot
2490         (also rolling out a dependent patch) (Requested by mrobinson
2491         on #webkit).
2492
2493         * gtk/generate-gtkdoc:
2494         (get_webkit2_options):
2495
2496 2012-07-30  Martin Robinson  <mrobinson@igalia.com>
2497
2498         [GTK] Add a non-subprocess jhbuild environment and use it for run-gtk-tests
2499         https://bugs.webkit.org/show_bug.cgi?id=92626
2500
2501         Reviewed by Gustavo Noronha Silva.
2502
2503         Instead of always shelling out to enter a jhbuild environment, add a Python
2504         hook for entering a jhbuild environment directly. This avoids requiring a
2505         script to be wrapped in jhbuild.
2506
2507         * GNUmakefile.am: Remove gtk/run-api-tests from the distribution list.
2508         * Scripts/run-gtk-tests: Move most of the logic from run-api-tests here
2509         with additional code for entering a jhbuild environment directly.
2510         * gtk/run-api-tests: Removed.
2511         * jhbuild/jhbuild-wrapper: Use the new helper methods defined in jhbuildutils.py.
2512         * jhbuild/jhbuildutils.py: Add some new helper methods here including
2513         a method which can transform the current environment into a jhbuild-ified one.
2514
2515 2012-07-30  Alexander Pavlov  <apavlov@chromium.org>
2516
2517         Unreviewed, upgrade apavlov to reviewer.
2518         http://lists.webkit.org/mailman/private/webkit-committers/2012-July/000184.html
2519
2520         * Scripts/webkitpy/common/config/committers.py:
2521
2522 2012-07-30  Robin Cao  <robin.cao@torchmobile.com.cn>
2523
2524         [BlackBerry] Adapt to changes in the SharedArray platform API
2525         https://bugs.webkit.org/show_bug.cgi?id=92631
2526
2527         Reviewed by Rob Buis.
2528
2529         Adapt to changes in the SharedArray platform API. No behavioural change.
2530
2531         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2532         (LayoutTestController::webHistoryItemCount):
2533
2534 2012-07-30  Balazs Kelemen  <kbalazs@webkit.org>
2535
2536         [Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work
2537         https://bugs.webkit.org/show_bug.cgi?id=92627
2538
2539         Reviewed by Noam Rosenthal.
2540
2541         Remove the default behavior I added in r123729 so that we run all tests as pixel
2542         test with -p. It was intentional but it seems like we don't have consensus on
2543         that we want it.
2544
2545         * Scripts/webkitpy/layout_tests/port/qt.py:
2546         (QtPort._supports_switching_pixel_tests_per_test):
2547
2548 2012-07-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2549
2550         [EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender.
2551         https://bugs.webkit.org/show_bug.cgi?id=92366
2552
2553         Reviewed by Antonio Gomes.
2554
2555         Add SHIFT modifier for capital letters as VK_
2556         codes do not distinguish between lows and caps and also to be consistent
2557         with other ports which send caps as lowercase letters with the shift key down.
2558
2559         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2560         (WTR::EventSenderProxy::keyDown):
2561
2562 2012-07-29  Raphael Kubo da Costa  <rakuco@webkit.org>
2563
2564         [EFL][jhbuild] Make run-with-jhbuild become the jhbuild process itself.
2565         https://bugs.webkit.org/show_bug.cgi?id=92592
2566
2567         Reviewed by Eric Seidel.
2568
2569         Adapt to the changes made to GTK+'s run-with-jhbuild in r123979
2570         and make EFL's run-with-jhbuild call os.execve() instead of
2571         launching a subprocess as well.
2572
2573         This should make it possible to interrupt execution of jhbuild
2574         cleanly.
2575
2576         * efl/run-with-jhbuild:
2577
2578 2012-07-28  Ryosuke Niwa  <rniwa@webkit.org>
2579
2580         run-perf-tests should generate a results page
2581         https://bugs.webkit.org/show_bug.cgi?id=92575
2582
2583         Reviewed by Eric Seidel.
2584
2585         Added the ability to generate a results page that summarizes performance test results from
2586         multiple runs of run-perf-tests when --output-json-path is specified and --test-results-server
2587         is not specified. We cannot generate a results page when --test-results-server is specified
2588         because perf-o-matic cannot parse the new JSON format.
2589
2590         The new JSON format is simply an array of the old JSON output. This JSON is then merged into
2591         results-template.html along with jQuery and copied as a HTML file of the same filename as
2592         the output JSON file with a .html extension.
2593
2594         We merge all scripts and the JSON output into the results page as opposed to including them
2595         with the src content attribute to make it standalone so that we may post it on Bugzilla or
2596         e-mail it to someone else without breaking it.
2597
2598         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2599         (PerfTestsRunner.run):
2600         (PerfTestsRunner._generate_json): Merge "contents" with the existing JSON file when generating
2601         a results page, and generate the results page from results-template.html merged with jQuery and
2602         the generated JSON output.
2603         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2604         (_test_run_with_json_output): Extracted from test_run_with_upload_json to be shared with
2605         several test cases.
2606         (_test_run_with_json_output.mock_upload_json): Ditto.
2607         (test_run_with_json_output): Refactored to use _test_run_with_json_output.
2608         (test_run_generates_results_page): Added. Tests the new feature.
2609         (test_run_with_json_source): Refactored to use _test_run_with_json_output.
2610         (test_run_with_multiple_repositories): Ditto.
2611         (test_run_with_upload_json): Ditto.
2612
2613 2012-07-29  Rik Cabanier  <cabanier@adobe.com>
2614
2615         Add ENABLE_CSS_COMPOSITING flag
2616         https://bugs.webkit.org/show_bug.cgi?id=92553
2617
2618         Reviewed by Dirk Schulze.
2619
2620         Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html
2621
2622         * Scripts/webkitperl/FeatureList.pm:
2623
2624 2012-07-29  Gustavo Noronha Silva  <gns@gnome.org>
2625
2626         Reviewed by Martin Robinson.
2627
2628         Make the jhbuild wrapper scripts become the jhbuild process
2629         instead of starting it as a child. This should make it possible to
2630         interrupt execution of jhbuild cleanly.
2631
2632         * gtk/run-with-jhbuild:
2633         * jhbuild/jhbuild-wrapper:
2634
2635 2012-07-29  Mike West  <mkwst@chromium.org>
2636
2637         Extend `application/x-webkit-test-netscape` plugins to better support multiple frames.
2638         https://bugs.webkit.org/show_bug.cgi?id=92478
2639
2640         Reviewed by Adam Barth.
2641
2642         DumpRenderTree currently understands
2643         `<object src="data:application/x-webkit-test-netscape,alertwhenloaded">`.
2644         It would be useful if it understood `logifloaded`, which could give
2645         more context regarding test expectations, and can be written in such
2646         as way as to support plugins loaded into multiple iframes in a single
2647         test.
2648
2649         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2650         (NPP_New):
2651             Adding support for `logifloaded`.
2652
2653 2012-07-28  Peter Kasting  <pkasting@google.com>
2654
2655         Fix Chromium/Win compile.
2656         https://bugs.webkit.org/show_bug.cgi?id=88787
2657
2658         Unreviewed, build fix.
2659
2660         Chromium/Win needs _USE_MATH_DEFINES but doesn't define PLATFORM(WIN).
2661         The other files in WebKit that define this macro (both in
2662         WebCore/platform/graphics/cg) do it by unconditionally #defining it to 1
2663         above the #include of "config.h", so copy that pattern here.
2664
2665         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2666
2667 2012-07-28  Mario Sanchez Prada  <msanchez@igalia.com>
2668
2669         [WK2][GTK] Implement a new spell checker API for WebKit2GTK+
2670         https://bugs.webkit.org/show_bug.cgi?id=90268
2671
2672         Reviewed by Martin Robinson.
2673
2674         Ignore WebKitTextChecker.* private files for gtk-doc.
2675
2676         * gtk/generate-gtkdoc:
2677         (get_webkit2_options):
2678
2679 2012-07-28  Philippe Normand  <pnormand@igalia.com>
2680
2681         [GTK] Transparent Media controls timeline and panel
2682         https://bugs.webkit.org/show_bug.cgi?id=85279
2683
2684         Reviewed by Martin Robinson.
2685
2686         * gtk/jhbuild.modules: Provide gnome-themes-standard build
2687         support, this is necessary so the media controls panel colors are
2688         properly initialized from the GTK+ theme.
2689
2690 2012-07-27  Kihong Kwon  <kihong.kwon@samsung.com>
2691
2692         [EFL] Support for HTML media capture
2693         https://bugs.webkit.org/show_bug.cgi?id=91842
2694
2695         Reviewed by Ryosuke Niwa.
2696
2697         Add HTML media capture feature to the feature list.
2698         In addition, enable that on the Efl port.
2699
2700         * Scripts/webkitperl/FeatureList.pm:
2701
2702 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
2703
2704         "webkit-patch rebaseline <test>" fails with exit_code 1
2705         https://bugs.webkit.org/show_bug.cgi?id=91560
2706
2707         Reviewed by Adam Barth.
2708
2709         webkit-patch rebaseline-json crashes in an svn checkout if it
2710         tries to add files and there are no files to add; arguably
2711         svn.add() should be robust against this, but rebaseline-json
2712         shouldn't be calling it, either. This patch fixes the latter and
2713         adds better debugging info to garden-o-matic so we can see what
2714         caused the crash.
2715
2716         * Scripts/webkitpy/tool/commands/rebaseline.py:
2717         (AbstractParallelRebaselineCommand._rebaseline):
2718         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2719         (GardeningHTTPRequestHandler.rebaselineall):
2720         (GardeningHTTPRequestHandler.rebaselineall.error_handler):
2721         (GardeningHTTPRequestHandler):
2722
2723 2012-07-27  Brady Eidson  <beidson@apple.com>
2724
2725         Plugins should not be allowed to override standard properties/attributes in non-standard worlds
2726         <rdar://problem/11975252> and https://bugs.webkit.org/show_bug.cgi?id=92519
2727
2728         Reviewed by Anders Carlsson.
2729
2730         Add a test plugin which overrides all properties it is asked about:
2731         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableObjectOverridesAllProperties.cpp: Added.
2732         (PluginScriptableObjectOverridesAllProperties):
2733         (PluginScriptableObjectOverridesAllProperties::PluginScriptableObjectOverridesAllProperties):
2734         (PluginObject):
2735         (PluginScriptableObjectOverridesAllProperties::PluginObject::PluginObject):
2736         (PluginScriptableObjectOverridesAllProperties::PluginObject::~PluginObject):
2737         (PluginScriptableObjectOverridesAllProperties::PluginObject::hasProperty):
2738         (PluginScriptableObjectOverridesAllProperties::PluginObject::getProperty):
2739         (PluginScriptableObjectOverridesAllProperties::NPP_GetValue):
2740
2741         Expose NPN_MemAlloc to the test plugin:
2742         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2743         (PluginTest::NPN_MemAlloc):
2744         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2745         (PluginTest):
2746
2747         * DumpRenderTree/DumpRenderTree.gypi:
2748         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2749         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2750         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2751
2752 2012-07-27  Rafael Brandao  <rafael.lobo@openbossa.org>
2753
2754         "webkit-patch upload" should strip colors from patch if necessary
2755         https://bugs.webkit.org/show_bug.cgi?id=92306
2756
2757         Reviewed by Adam Barth.
2758
2759         * Scripts/webkitpy/common/checkout/scm/git.py: Explicity remove colors from diff.
2760
2761 2012-07-27  Eric Seidel  <eric@webkit.org>
2762
2763         clean-pending-commit throws exception when encountering Ossy
2764         https://bugs.webkit.org/show_bug.cgi?id=92534
2765
2766         Reviewed by Adam Barth.
2767
2768         Mark a couple strings as unicode so that reviewers with unicode names do not cause
2769         clean-pending-commit to barf.
2770
2771         * Scripts/webkitpy/tool/commands/upload.py:
2772         (CleanPendingCommit._flags_to_clear_on_patch):
2773         (CleanPendingCommit.execute):
2774         (AssignToCommitter._assign_bug_to_last_patch_attacher):
2775
2776 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
2777
2778         chromium win compile broken after removing webkit.py
2779         https://bugs.webkit.org/show_bug.cgi?id=92549
2780
2781         Unreviewed, build fix.
2782
2783         It turns out that this file is listed in the chromium downstream
2784         'browser_tests.isolate' file, and so deleting it broke gyp.
2785         Adding a stub file back in until we can remove the entry from
2786         the file.
2787
2788         * Scripts/webkitpy/layout_tests/port/webkit.py: Added.
2789
2790 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
2791
2792         nrwt: remove 'webkit.py' and the 'WebKitPort'
2793         https://bugs.webkit.org/show_bug.cgi?id=92450
2794
2795         Reviewed by Ryosuke Niwa.
2796
2797         This patch finishes the work of merging WebKitPort into Port.
2798         Now Port is way too big :).
2799
2800         This is all cutting and pasting; no new functionality and
2801         no changes in the tests.
2802
2803         * Scripts/webkitpy/layout_tests/port/apple.py:
2804         (ApplePort):
2805         (ApplePort.__init__):
2806         * Scripts/webkitpy/layout_tests/port/base.py:
2807         (Port.skipped_layout_tests):
2808         (Port):
2809         (Port._port_flag_for_scripts):
2810         (Port._arguments_for_configuration):
2811         (Port._run_script):
2812         (Port._build_driver):
2813         (Port._build_driver_flags):
2814         (Port._tests_for_other_platforms):
2815         (Port._runtime_feature_list):
2816         (Port.nm_command):
2817         (Port._modules_to_search_for_symbols):
2818         (Port._symbols_string):
2819         (Port._missing_feature_to_skipped_tests):
2820         (Port._missing_symbol_to_skipped_tests):
2821         (Port._has_test_in_directories):
2822         (Port._skipped_tests_for_unsupported_features):
2823         (Port._wk2_port_name):
2824         (Port._skipped_file_search_paths):
2825         * Scripts/webkitpy/layout_tests/port/chromium.py:
2826         (ChromiumPort):
2827         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2828         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
2829         (ChromiumPortTestCase.test_check_build):
2830         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2831         * Scripts/webkitpy/layout_tests/port/efl.py:
2832         (EflPort):
2833         (EflPort.__init__):
2834         * Scripts/webkitpy/layout_tests/port/gtk.py:
2835         (GtkPort):
2836         (GtkPort.setup_environ_for_server):
2837         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2838         (TestWebKitPort):
2839         (TestWebKitPort.__init__):
2840         (TestWebKitPort.all_test_configurations):
2841         (TestWebKitPort._symbols_string):
2842         (TestWebKitPort._tests_for_other_platforms):
2843         (TestWebKitPort._tests_for_disabled_features):
2844         (PortTestCase):
2845         (PortTestCase.test_diff_image):
2846         (PortTestCase.test_path_to_test_expectations_file):
2847         (PortTestCase.test_skipped_directories_for_symbols):
2848         (test_skipped_directories_for_features):
2849         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
2850         (test_skipped_tests_for_unsupported_features_empty_test_list):
2851         (test_skipped_layout_tests):
2852         (test_skipped_file_search_paths):
2853         (test_root_option):
2854         (test_test_expectations):
2855         (test_build_driver):
2856         (_assert_config_file_for_platform):
2857         (test_linux_distro_detection):
2858         (test_apache_config_file_name_for_platform):
2859         (test_path_to_apache_config_file):
2860         * Scripts/webkitpy/layout_tests/port/qt.py:
2861         (QtPort):
2862         (QtPort.__init__):
2863         (QtPort.setup_environ_for_server):
2864         * Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
2865         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Removed.
2866         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2867         (get_test_baselines.AllPlatformsPort):
2868         (get_test_baselines.AllPlatformsPort.__init__):
2869         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2870         (get_test_config.TestMacPort):
2871
2872 2012-07-27  Christophe Dumez  <christophe.dumez@intel.com>
2873
2874         [WK2][WTR] LayoutTestController.deliverWebIntent() needs to be implemented
2875         https://bugs.webkit.org/show_bug.cgi?id=92228
2876
2877         Reviewed by Anders Carlsson.
2878
2879         Implement LayoutTestController.deliverWebIntent() to
2880         allow test cases to deliver a Web intent and test this
2881         functionality.
2882
2883         This functionality is needed by:
2884         - webintents/web-intents-delivery.html
2885
2886         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2887         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2888         (WTR::LayoutTestController::deliverWebIntent):
2889         (WTR):
2890         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2891         (LayoutTestController):
2892
2893 2012-07-27  Jer Noble  <jer.noble@apple.com>
2894
2895         Unreviewed build fix.
2896
2897         Wrap MSVC-specific fixes is a COMPILER() check, not a PLATFORM() check.
2898
2899         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2900
2901 2012-07-27  Xianzhu Wang  <wangxianzhu@chromium.org>
2902
2903         [Chromium-Android] NRWT better handling of DRT deadlocks and crashes
2904         https://bugs.webkit.org/show_bug.cgi?id=92299
2905
2906         Reviewed by Dirk Pranke.
2907
2908         1. Changed the deadlock detector thread target from a method of driver to a function to avoid its reference to the
2909            current driver (see the bug for the problem of the reference.
2910         2. Let the deadlock detector thread exit early when the normal_startup_event is set to avoid it from blocking the main thread when the main thread is exiting.
2911         3. Extracted common loop until timeout logic into ChromiumAndroidDriver._loop_with_timeout().
2912         4. Use the "for i in range(n)" style suggested by dpranke in https://bugs.webkit.org/show_bug.cgi?id=89124 in several functions.
2913
2914         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2915         (ChromiumAndroidPort.__init__):
2916         (ChromiumAndroidPort._run_adb_command): Reduced the verbose output.
2917         (ChromiumAndroidDriver.__init__):
2918         (ChromiumAndroidDriver._loop_with_timeout): Extracted common loop until timeout logic here.
2919         (ChromiumAndroidDriver._all_pipes_created):
2920         (ChromiumAndroidDriver._remove_all_pipes):
2921         (ChromiumAndroidDriver._start): Changed the retry loop style.
2922         (ChromiumAndroidDriver._start_once): Changed the loop style and code related to deadlock detector.
2923         (ChromiumAndroidDriver._start_once.deadlock_detector): Moved the original ChromiumAndroidDriver._deadlock_detector() here.
2924         (ChromiumAndroidDriver.stop): Changed the loop style.
2925
2926 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
2927
2928         nrwt: move collect_tests(), parse_expectations() into manager
2929         https://bugs.webkit.org/show_bug.cgi?id=92423
2930
2931         Reviewed by Ojan Vafai.
2932
2933         This is the first in a series of patches refactoring
2934         run_webkit_tests.py and manager.py to make them more
2935         maintainable; all this patch does is move a couple of functions
2936         into manager.run_tests() so manager's public interface is
2937         simple.
2938
2939         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2940         (Manager._collect_tests):
2941         (Manager._parse_expectations):
2942         (Manager._split_into_chunks_if_necessary):
2943         (Manager.run):
2944         (read_test_files):
2945         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2946         (ManagerTest.test_http_locking):
2947         (ManagerTest.test_perf_locking):
2948         (ManagerTest.integration_test_needs_servers.get_manager_with_tests):
2949         (ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):
2950         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2951         (run):
2952
2953 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
2954
2955         nrwt: print filtered stderr after a crash correctly
2956         https://bugs.webkit.org/show_bug.cgi?id=92428
2957
2958         Reviewed by Adam Barth.
2959
2960         Some ports will run the stderr output from DRT/WTR through a
2961         filter after a crash in order to print a more useful stack
2962         trace; while that gets written to the crash log correctly, we
2963         don't log it to the debug output properly. This change fixes
2964         that and makes it clearer that we're logging stderr, not the
2965         crash log.
2966
2967         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2968         (SingleTestRunner._handle_error):
2969         * Scripts/webkitpy/layout_tests/port/base.py:
2970         (Port._get_crash_log):
2971         * Scripts/webkitpy/layout_tests/port/chromium.py:
2972         (ChromiumPort._get_crash_log):
2973         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2974         (ChromiumAndroidPortTest.test_get_crash_log):
2975         * Scripts/webkitpy/layout_tests/port/driver.py:
2976         (Driver.run_test):
2977         * Scripts/webkitpy/layout_tests/port/gtk.py:
2978         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2979         * Scripts/webkitpy/layout_tests/port/mac.py:
2980         (MacPort._get_crash_log):
2981         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2982         (PortTestCase.test_get_crash_log):
2983
2984 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
2985
2986         nrwt: move image diffing code to a separate module
2987         https://bugs.webkit.org/show_bug.cgi?id=92447
2988
2989         Reviewed by Ryosuke Niwa.
2990
2991         This patch moves the code to talk to ImageDiff into its own
2992         module, and adds more tests for it. In addition, the patch
2993         modifies diff_image() so that we don't automatically stop
2994         ImageDiff after a single invocation, and thus subsequent
2995         diffs may be slightly faster. (Note that the chromium ports
2996         don't use any of this code; that is not changed by this patch).
2997
2998         The main motivation for this change is to move more "generic"
2999         code out of the port/* classes, and in particular to move more
3000         code out of webkit.py so that we can eventually eliminate it by
3001         merging it into base.py.
3002
3003         This patch also splits MockServerProcess out from driver_unittest.py
3004         so that it can be re-used.
3005
3006         * Scripts/webkitpy/layout_tests/port/base.py:
3007         (Port.__init__):
3008         (Port.diff_image):
3009         (Port.clean_up_test_run):
3010         * Scripts/webkitpy/layout_tests/port/driver.py:
3011         (Driver.__init__):
3012         (Driver._start):
3013         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3014         (DriverTest.test_stop_cleans_up_properly):
3015         (DriverTest.test_two_starts_cleans_up_properly):
3016         (DriverTest.test_start_actually_starts):
3017         * Scripts/webkitpy/layout_tests/port/efl.py:
3018         (EflPort.clean_up_test_run):
3019         * Scripts/webkitpy/layout_tests/port/gtk.py:
3020         (GtkPort.clean_up_test_run):
3021         * Scripts/webkitpy/layout_tests/port/image_diff.py: Added.
3022         (ImageDiffer):
3023         (ImageDiffer.__init__):
3024         (ImageDiffer.diff_image):
3025         (ImageDiffer._start):
3026         (ImageDiffer._read):
3027         (ImageDiffer.stop):
3028         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py: Added.
3029         (for):
3030         (FakePort):
3031         (FakePort.__init__):
3032         (FakePort._path_to_image_diff):
3033         (FakePort.setup_environ_for_server):
3034         (TestImageDiffer):
3035         (TestImageDiffer.test_diff_image):
3036         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3037         (MockDRTPortTest.test_diff_image):
3038         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3039         (PortTestCase.test_diff_image__missing_both):
3040         (PortTestCase.test_diff_image):
3041         (PortTestCase.test_diff_image.make_proc):
3042         * Scripts/webkitpy/layout_tests/port/server_process.py:
3043         (ServerProcess._start):
3044         * Scripts/webkitpy/layout_tests/port/server_process_mock.py: Added.
3045         (MockServerProcess):
3046         (MockServerProcess.__init__):
3047         (MockServerProcess.write):
3048         (MockServerProcess.has_crashed):
3049         (MockServerProcess.read_stdout_line):
3050         (MockServerProcess.read_stdout):
3051         (MockServerProcess.pop_all_buffered_stderr):
3052         (MockServerProcess.read_either_stdout_or_stderr_line):
3053         (MockServerProcess.start):
3054         (MockServerProcess.stop):
3055         (MockServerProcess.kill):
3056         * Scripts/webkitpy/layout_tests/port/webkit.py:
3057         (WebKitPort._build_driver_flags):
3058         (WebKitPort._symbols_string):
3059
3060 2012-07-27  Tom Hudson  <hudson@google.com>
3061
3062         Activate committer bit granted April 6th so I can garden.
3063         https://bugs.webkit.org/show_bug.cgi?id=92500
3064
3065         Reviewed by Jochen Eisinger.
3066
3067         * Scripts/webkitpy/common/config/committers.py:
3068
3069 2012-07-27  Jer Noble  <jer.noble@apple.com>
3070
3071         Support a rational time class for use by media elements.
3072         https://bugs.webkit.org/show_bug.cgi?id=88787
3073
3074         Add unit tests for the WTF::MediaTime class.
3075
3076         Reviewed by Eric Carlson.
3077
3078         * TestWebKitAPI/GNUmakefile.am:
3079         * TestWebKitAPI/TestWebKitAPI.gypi:
3080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3081         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Added.
3082         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3083         (WTF::operator<<):
3084         (TestWebKitAPI):
3085         (TestWebKitAPI::TEST):
3086
3087 2012-07-27  Balazs Kelemen  <kbalazs@webkit.org>
3088
3089         [NRWT] should have a way to restrict pixel tests for individual directories
3090         https://bugs.webkit.org/show_bug.cgi?id=91754
3091
3092         Unreviewed attempt to fix the chaos I introduced.
3093
3094         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3095         (WebCore::DumpRenderTree::processLine):
3096
3097 2012-07-27  YoungTaeck Song  <youngtaeck.song@samsung.com>
3098
3099         [WK2][EFL] Add an ACCELERATED_COMPOSITING implementation for Efl WebKit2
3100         https://bugs.webkit.org/show_bug.cgi?id=91581
3101
3102         Reviewed by Noam Rosenthal.
3103
3104         Add a MiniBrowser's option for selecting evas engine.
3105
3106         * MiniBrowser/efl/main.c:
3107         (browserCreate):
3108         (main):
3109
3110 2012-07-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3111
3112         Unreviewed, rolling out r123869.
3113         http://trac.webkit.org/changeset/123869
3114         https://bugs.webkit.org/show_bug.cgi?id=92501
3115
3116         "it did not fix anything but made things even worst"
3117         (Requested by kbalazs on #webkit).
3118
3119         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3120         (WebCore::DumpRenderTree::DumpRenderTree):
3121         (WebCore::DumpRenderTree::open):
3122         (WebCore::DumpRenderTree::processLine):
3123         (WebCore::DumpRenderTree::setDumpPixelsForAllTests):
3124         (WebCore::DumpRenderTree::dump):
3125         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3126         (DumpRenderTree):
3127         * DumpRenderTree/qt/main.cpp:
3128         (main):
3129         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3130         (SingleTestRunner._should_fetch_expected_checksum):
3131         (SingleTestRunner._overwrite_baselines):
3132         (SingleTestRunner._compare_output):
3133         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3134         (Worker._update_test_input):
3135         * Scripts/webkitpy/layout_tests/port/base.py:
3136         (Port.supports_switching_pixel_tests_per_test):
3137         (Port):
3138         (Port._supports_switching_pixel_tests_per_test):
3139         (Port.should_run_as_pixel_test):
3140         (Port._should_run_as_pixel_test):
3141         * Scripts/webkitpy/layout_tests/port/driver.py:
3142         (Driver.cmd_line):
3143         (Driver._command_from_driver_input):
3144         * Scripts/webkitpy/layout_tests/port/qt.py:
3145         (QtPort.check_sys_deps):
3146         (QtPort):
3147         (QtPort._supports_switching_pixel_tests_per_test):
3148         (QtPort._should_run_as_pixel_test):
3149         (QtPort._default_pixel_test_directories):
3150         * Scripts/webkitpy/layout_tests/port/test.py:
3151         (TestPort.supports_switching_pixel_tests_per_test):
3152         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3153         (_set_up_derived_options):
3154         (parse_args):
3155         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3156         (MainTest.test_run_singly_actually_runs_tests):
3157         (MainTest.test_pixel_test_directories):
3158         * WebKitTestRunner/TestController.cpp:
3159         (WTR::TestController::TestController):
3160         (WTR::TestController::initialize):
3161         (WTR::TestController::runTest):
3162         * WebKitTestRunner/TestController.h:
3163         (TestController):
3164
3165 2012-07-27  Balazs Kelemen  <kbalazs@webkit.org>
3166
3167         [NRWT] should have a way to restrict pixel tests for individual directories
3168         https://bugs.webkit.org/show_bug.cgi?id=91754
3169
3170         Reviewed by Zoltan Herczeg.
3171
3172         Rollout r123729 because it made Qt debug bots crasy.
3173
3174         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3175         (WebCore::DumpRenderTree::DumpRenderTree):
3176         (WebCore::DumpRenderTree::open):
3177         (WebCore::DumpRenderTree::processLine):
3178         (WebCore::DumpRenderTree::setDumpPixels):
3179         (WebCore::DumpRenderTree::dump):
3180         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3181         (DumpRenderTree):
3182         * DumpRenderTree/qt/main.cpp:
3183         (main):
3184         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3185         (SingleTestRunner._should_fetch_expected_checksum):
3186         (SingleTestRunner._overwrite_baselines):
3187         (SingleTestRunner._compare_output):
3188         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3189         (Worker._update_test_input):
3190         * Scripts/webkitpy/layout_tests/port/base.py:
3191         (Port.lookup_virtual_test_args):
3192         * Scripts/webkitpy/layout_tests/port/driver.py:
3193         (Driver.cmd_line):
3194         (Driver._command_from_driver_input):
3195         * Scripts/webkitpy/layout_tests/port/qt.py:
3196         (QtPort.check_sys_deps):
3197         * Scripts/webkitpy/layout_tests/port/test.py:
3198         (TestPort.virtual_test_suites):
3199         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3200         (_set_up_derived_options):
3201         (parse_args):
3202         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3203         (MainTest.test_run_singly_actually_runs_tests):
3204         (MainTest.test_missing_and_unexpected_results):
3205         * WebKitTestRunner/TestController.cpp:
3206         (WTR::TestController::TestController):
3207         (WTR::TestController::initialize):
3208         (WTR::TestController::runTest):
3209         * WebKitTestRunner/TestController.h:
3210         (TestController):
3211
3212 2012-07-27  Adam Barth  <abarth@webkit.org>
3213
3214         webkit.review.bot should run clean-review-queue and clean-pending-commit periodically
3215         https://bugs.webkit.org/show_bug.cgi?id=92472
3216
3217         Reviewed by Eric Seidel.
3218
3219         We need to run these command periodically to keep cruft from
3220         accumulating in bugs.webkit.org. Rather than running them manually, we
3221         should just have a bot run them. This patch has the style-queue run the
3222         commands, which admittedly is a bit odd but it doesn't seem worthwhile
3223         to create another bot specifically for this purposes.
3224
3225         * Scripts/webkitpy/tool/commands/queues.py:
3226         (AbstractReviewQueue):
3227         (StyleQueue.begin_work_queue):
3228         (StyleQueue):
3229         (StyleQueue.clean_bugzilla):
3230         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3231         (StyleQueueTest.test_style_queue_with_style_exception):
3232         (test_style_queue_with_watch_list_exception):
3233
3234 2012-07-27  Dominik Röttsches  <dominik.rottsches@intel.com>
3235
3236         [Cairo] Add complex font drawing using HarfbuzzNG
3237         https://bugs.webkit.org/show_bug.cgi?id=91864
3238
3239         Reviewed by Simon Hausmann and Martin Robinson.
3240
3241         Bringing Harfbuzz support to EFL with this patch, so we need HarfBuzz in the pulled in jhbuild dependencies.
3242
3243         * WebKitTestRunner/CMakeLists.txt: Adding additional header include directories.
3244         * efl/jhbuild.modules: Adding source for HarfBuzz release version 0.9.0.
3245
3246 2012-07-27  KwangYong Choi  <ky0.choi@samsung.com>
3247
3248         [WK2][EFL][WTR] TestNetscapePlugin is required.
3249         https://bugs.webkit.org/show_bug.cgi?id=88756
3250
3251         Reviewed by Simon Hausmann.
3252
3253         libTestNetscapePlugin.so should be required for DRT/WTR/EFL.
3254
3255         * CMakeLists.txt:
3256         * DumpRenderTree/TestNetscapePlugin/CMakeList.txt:
3257
3258 2012-07-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3259
3260         [EFL] Memory leaks in EFL DRT
3261         https://bugs.webkit.org/show_bug.cgi?id=92347
3262
3263         Reviewed by Simon Hausmann.
3264
3265         Fix a memory leak in EFL's DRT code by adopting an allocation
3266         of JSString created with JSStringCreateWithUTF8CString.
3267
3268         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3269         (DumpRenderTreeChrome::onWindowObjectCleared):
3270
3271 2012-07-27  Adam Barth  <abarth@webkit.org>
3272
3273         Simplify ExpectedFailures
3274         https://bugs.webkit.org/show_bug.cgi?id=92216
3275
3276         Reviewed by Eric Seidel.
3277
3278         This patch simplifies the ExpectedFailures class we use to remember
3279         which tests are currently failing on the bots. When we wrote this code
3280         originally, we weren't entirely sure how it would work. Now that we
3281         understand it more clearly, we can write the code more clearly.
3282
3283         * Scripts/webkitpy/tool/bot/expectedfailures.py:
3284         (_has_failures):
3285         (_is_trustworthy):
3286         (ExpectedFailures.__init__):
3287         (ExpectedFailures.failures_were_expected):
3288         (ExpectedFailures.unexpected_failures_observed):
3289         (ExpectedFailures.update):
3290         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3291         (ExpectedFailuresTest._assert_can_trust):
3292         (ExpectedFailuresTest.test_failures_were_expected):
3293         (ExpectedFailuresTest.test_unexpected_failures_observed):
3294         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
3295         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3296         (PatchAnalysisTask._test):
3297         (PatchAnalysisTask._build_and_test_without_patch):
3298         (PatchAnalysisTask._test_patch):
3299
3300 2012-07-27  Csaba Osztrogonác  <ossy@webkit.org>
3301
3302         [Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
3303         https://bugs.webkit.org/show_bug.cgi?id=88064
3304
3305         Reviewed by Zoltan Herczeg.
3306
3307         Use resetInternalsObject() instead of injectInternalsObject().
3308
3309         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3310         (WTR::InjectedBundlePage::resetAfterTest):
3311
3312 2012-07-26  Ryuan Choi  <ryuan.choi@samsung.com>
3313
3314         [EFL] Remove forwarding headers from MiniBrowser/Efl.
3315         https://bugs.webkit.org/show_bug.cgi?id=91627
3316
3317         Reviewed by Kentaro Hara.
3318
3319         * MiniBrowser/efl/CMakeLists.txt: Remove unnecessary forwarding headers.
3320
3321 2012-07-26  Yoshifumi Inoue  <yosin@chromium.org>
3322
3323         [Forms] Introduce runtime feature flags for input type datetime, datetimelocal, month, time, week
3324         https://bugs.webkit.org/show_bug.cgi?id=92339
3325
3326         Reviewed by Kent Tamura.
3327
3328         This patch enables runtime features for input type datetime, datetime-local,
3329         month, time and week for Chromium DRT.
3330
3331         * DumpRenderTree/chromium/TestShell.cpp:
3332         (TestShell::TestShell): Call enableInputType{DateTime,DateTimeLocal,Month,Time,Week}.
3333
3334 2012-07-26  Jeffrey Pfau  <jpfau@apple.com>
3335
3336         Reloading substitute-data/alternate html string for unreachableURL will add an item to the back-forward-history for each reload
3337         https://bugs.webkit.org/show_bug.cgi?id=84041
3338
3339         Reviewed by Brady Eidson.
3340
3341         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3342         * TestWebKitAPI/Tests/mac/BackForwardList.mm: Added.
3343         (-[BackForwardListTest webView:didFinishLoadForFrame:]):
3344         (-[BackForwardListTest webView:didFailProvisionalLoadWithError:forFrame:]):
3345         (TestWebKitAPI):
3346         (TestWebKitAPI::TEST):
3347
3348 2012-07-26  Sheriff Bot  <webkit.review.bot@gmail.com>
3349
3350         Unreviewed, rolling out r123799.
3351         http://trac.webkit.org/changeset/123799
3352         https://bugs.webkit.org/show_bug.cgi?id=92431
3353
3354         broke the Apple Mac build (Requested by bweinstein on
3355         #webkit).
3356
3357         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3358         * DumpRenderTree/chromium/TestWebPlugin.h:
3359         (TestWebPlugin::acceptsInputEvents):
3360         (TestWebPlugin::handleInputEvent):
3361
3362 2012-07-26  Dirk Pranke  <dpranke@chromium.org>
3363
3364         nrwt: pass --verbose twice on the bots to ensure getting the debug output for now
3365         https://bugs.webkit.org/show_bug.cgi?id=92172
3366
3367         Reviewed by Tony Chang.
3368
3369         Right now new-run-webkit-tests --verbose prints out too much
3370         information (it's like --verbose + debugging). I plan to fix
3371         this in bug 88702, and also clean up and simplify all of the
3372         --print options, but in preparation for these changes I need to
3373         pass --verbose twice to get the same level of output
3374         temporarily (for compatibility).
3375
3376         * Scripts/run-webkit-tests:
3377
3378 2012-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3379
3380         Propagate gesture events to plugins.
3381         https://bugs.webkit.org/show_bug.cgi?id=92281
3382
3383         Reviewed by Adam Barth.
3384
3385         Update TestWebPlugin to receive events, and output logs for the events.
3386
3387         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3388         (TestWebPlugin::handleInputEvent):
3389         * DumpRenderTree/chromium/TestWebPlugin.h:
3390         (TestWebPlugin::acceptsInputEvents):
3391         (TestWebPlugin):
3392
3393 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
3394
3395         [nrwt] get rid of --skip-pixel-test-if-no-baseline
3396         https://bugs.webkit.org/show_bug.cgi?id=92377
3397
3398         Reviewed by Adam Barth.
3399
3400         Remove the option and all code paths that handled it.
3401
3402         * Scripts/webkitpy/layout_tests/port/base.py:
3403         (Port.should_run_as_pixel_test):
3404         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3405         (_set_up_derived_options):
3406         (parse_args):
3407         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3408         (MainTest.test_repeat_each):
3409
3410 2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
3411
3412         Add FastMalloc statistics in window.internals
3413         https://bugs.webkit.org/show_bug.cgi?id=91274
3414
3415         Reviewed by Ryosuke Niwa.
3416
3417         * GNUmakefile.am:
3418
3419 2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
3420
3421         Add FastMalloc statistics in window.internals
3422         https://bugs.webkit.org/show_bug.cgi?id=91274
3423
3424         Reviewed by Ryosuke Niwa.
3425
3426         * GNUmakefile.am:
3427
3428 2012-07-20  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
3429
3430         buildbot: Remove the configuration of hfreyther*
3431         https://bugs.webkit.org/show_bug.cgi?id=91849
3432
3433         Reviewed by Adam Roben.
3434
3435         The machine running these configs was decommissioned and
3436         there is no replacement at this point. Remove them from the
3437         configuration.
3438
3439         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove hfreyther* from
3440         the config. The Qt Linux SH4 and Qt Linux MIPS schedulers are orphaned, remove
3441         them too.
3442
3443 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
3444
3445         Unreviewed speculative Mac buildfix after r123729 - 2nd attempt.
3446
3447         * WebKitTestRunner/TestController.cpp:
3448         (WTR::TestController::runTest):
3449
3450 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
3451
3452         Unreviewed speculative buildfix after r123729.
3453
3454         * WebKitTestRunner/TestController.cpp:
3455         (WTR::TestController::runTest): Fix sign errors.
3456
3457 2012-07-26  Zoltan Nyul  <zoltan.nyul@intel.com>
3458
3459         [EFL] EFL port should use XDG paths
3460         https://bugs.webkit.org/show_bug.cgi?id=91719
3461
3462         Reviewed by Kenneth Rohde Christiansen.
3463
3464         The appcache/localstorage/webdatabase path should be set in the
3465         ewk_main.cpp instead of the DumpRenderTree, and the XDG_DATA_HOME and
3466         XDG_CACHE_HOME should be set to different directory for each processes
3467         for the layout-tests.
3468
3469         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3470         (DumpRenderTreeChrome::initialize):
3471         * Scripts/webkitpy/layout_tests/port/efl.py:
3472         (EflPort.setup_environ_for_server):
3473         * efl/jhbuild.modules:
3474
3475 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
3476
3477         [NRWT] should have a way to restrict pixel tests for individual directories
3478         https://bugs.webkit.org/show_bug.cgi?id=91754
3479
3480         Reviewed by Dirk Pranke.
3481
3482         Added --pixel-test-directories option to nrwt. It implies --pixel-tests.
3483         If the platform supports this option only tests from these directories will
3484         be executed as pixel tests. Furthermore, platforms can have a default set of
3485         pixel test directories. To support the feature the test harness have to be
3486         able to inform the driver whether to dump pixels for each tests. For this
3487         purpose I changed WTR and the Qt DRT to handle a --pixel-test argument from
3488         the standard output and made NRWT use this argument with these drivers.
3489
3490         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3491         (WebCore::DumpRenderTree::DumpRenderTree):
3492         (WebCore::DumpRenderTree::open):
3493         (WebCore::DumpRenderTree::processLine):
3494         (WebCore::DumpRenderTree::setDumpPixelsForAllTests):
3495         (WebCore::DumpRenderTree::dump):
3496         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3497         (DumpRenderTree):
3498         * DumpRenderTree/qt/main.cpp:
3499         (main):
3500         Handle the --pixel-test argument.
3501
3502         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3503         (SingleTestRunner._should_fetch_expected_checksum):
3504         (SingleTestRunner._overwrite_baselines):
3505         (SingleTestRunner._compare_output):
3506         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3507         (Worker._update_test_input):
3508         * Scripts/webkitpy/layout_tests/port/base.py:
3509         (Port.supports_switching_pixel_tests_per_test): Ports can override this to inform
3510         the harness that --pixel-test argument is supported. True for WTR, otherwise calls
3511         private version that can be overridden by the actual platform. Only true with WTR
3512         and Qt DRT currently. This supposed to exist only temporary until there are ports
3513         that doesn't support the feature in their DRT's.
3514         (Port):
3515         (Port._supports_switching_pixel_tests_per_test):
3516         (Port.should_run_as_pixel_test):
3517         (Port._should_run_as_pixel_test): Ports can override this to define their
3518         default set of pixel tests directories.
3519         * Scripts/webkitpy/layout_tests/port/driver.py:
3520         (Driver.cmd_line): Don't pass --pixel-tests if the platform supports per test
3521         --pixel-test.
3522         (Driver._command_from_driver_input): Pass --pixel-test if it is supported and pixel
3523         tests are enabled.
3524         * Scripts/webkitpy/layout_tests/port/qt.py:
3525         (QtPort.check_sys_deps):
3526         (QtPort):
3527         (QtPort._supports_switching_pixel_tests_per_test):
3528         (QtPort._should_run_as_pixel_test):
3529         (QtPort._default_pixel_test_directories): Only compositing will be our default pixel
3530         test directory for the time being.
3531         * Scripts/webkitpy/layout_tests/port/test.py:
3532         (TestPort.supports_switching_pixel_tests_per_test):
3533         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3534         (_set_up_derived_options):
3535         (parse_args):
3536         Handle the --pixel-test-directory option. It expect a directory below LayoutTests
3537         and can be specified multiple times. Added fixme's that we should improve how we
3538         handle these arguments.
3539
3540         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3541         (MainTest.test_run_singly_actually_runs_tests):
3542         (MainTest.test_pixel_test_directories):
3543         Added an integration test for the feature.
3544
3545         * WebKitTestRunner/TestController.cpp:
3546         (WTR::TestController::TestController):
3547         (WTR::TestController::initialize):
3548         (WTR::TestController::runTest):
3549         * WebKitTestRunner/TestController.h:
3550         (TestController):
3551         Handle the --pixel-test argument.
3552
3553 2012-07-26  Christophe Dumez  <christophe.dumez@intel.com>
3554
3555         [EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is crashing
3556         https://bugs.webkit.org/show_bug.cgi?id=92349
3557
3558         Reviewed by Kentaro Hara.
3559
3560         Fix crash occurring after r123604, which replaced strdup()
3561         usage with eina_stringshare_add(). Unfortunately, the DRT
3562         was not updated accordingly to use eina_stringshare_del()
3563         instead of free() on the values returned by Ewk_Intent
3564         getters and it was causing
3565         webintents/web-intents-obj-constructor.html to crash.
3566
3567         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3568         (DumpRenderTreeChrome::onFrameIntentNew):
3569
3570 2012-07-26  Adam Barth  <abarth@webkit.org>
3571
3572         Unreviewed attempt to fix the chromium-win build.
3573
3574         * DumpRenderTree/chromium/TestRunner/TestRunner.cpp:
3575
3576 2012-07-26  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3577
3578         [DRT] LTC:: pageNumberForElementById() could be moved to Internals
3579         https://bugs.webkit.org/show_bug.cgi?id=92091
3580
3581         Reviewed by Adam Barth.
3582
3583         Move the pageNumberForElementById from LayoutTestCotroller to Internals and
3584         remove the old platform specific implementations as it exclusively tests WebCore functionality.
3585
3586         * DumpRenderTree/LayoutTestController.cpp:
3587         (LayoutTestController::staticFunctions):
3588         * DumpRenderTree/LayoutTestController.h:
3589         (LayoutTestController):
3590         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3591         * DumpRenderTree/chromium/LayoutTestController.cpp:
3592         (LayoutTestController::LayoutTestController):
3593         (LayoutTestController::setPrinting):
3594         * DumpRenderTree/chromium/LayoutTestController.h:
3595         (LayoutTestController):
3596         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3597         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3598         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3599         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3600         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3601         (LayoutTestController):
3602         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3603         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3604         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3605         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3606         (WTR):
3607         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3608         (LayoutTestController):
3609
3610 2012-07-25  Adam Barth  <abarth@webkit.org>
3611
3612         TestRunner.a should contain a TestRunner object
3613         https://bugs.webkit.org/show_bug.cgi?id=92313
3614
3615         Reviewed by Kent Tamura.
3616
3617         This patch adds a stub implementation of TestRunner, which is the new
3618         home for our implementation of window.testRunner. A future patch will
3619         migrate functions from LayoutTestController to TestRunner.
3620
3621         * DumpRenderTree/DumpRenderTree.gypi:
3622         * DumpRenderTree/chromium/LayoutTestController.h:
3623         * DumpRenderTree/chromium/TestRunner/TestRunner.cpp: Added.
3624         * DumpRenderTree/chromium/TestRunner/TestRunner.h: Added.
3625
3626 2012-07-25  Wei James  <james.wei@intel.com>
3627
3628         [Chromium] Fix infinite loop issue for chromium android layout test
3629         https://bugs.webkit.org/show_bug.cgi?id=92197
3630
3631         Reviewed by Adam Barth.
3632
3633         The change brought in by r123530 will cause infinite loop when running
3634         Chromium Android Layout Test.
3635         Revert the change for this line only.
3636
3637         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3638         (ChromiumAndroidPort._build_path):
3639
3640 2012-07-25  Adam Barth  <abarth@webkit.org>
3641
3642         Jochen is our a newest reviewer!
3643
3644         * Scripts/webkitpy/common/config/committers.py:
3645
3646 2012-07-25  Jochen Eisinger  <jochen@chromium.org>
3647
3648         [chromium] don't use webkit_support methods directly from test runners but through the test delegate
3649         https://bugs.webkit.org/show_bug.cgi?id=92256
3650
3651         Reviewed by Adam Barth.
3652
3653         This will allow for the content_shell to provide its own implementation
3654         for setting the Gamepad data instead.
3655
3656         * DumpRenderTree/chromium/TestRunner/GamepadController.cpp:
3657         (GamepadController::setDelegate):
3658         (GamepadController::reset):
3659         (GamepadController::connect):
3660         (GamepadController::disconnect):
3661         (GamepadController::setId):
3662         (GamepadController::setButtonCount):
3663         (GamepadController::setButtonData):
3664         (GamepadController::setAxisCount):
3665         (GamepadController::setAxisData):
3666         * DumpRenderTree/chromium/TestRunner/GamepadController.h:
3667         (GamepadController):
3668         * DumpRenderTree/chromium/TestRunner/TestDelegate.h:
3669         (WebKit):
3670         (TestDelegate):
3671         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
3672         (TestInterfaces::Internal):
3673         (TestInterfaces::Internal::~Internal):
3674         (TestInterfaces::Internal::setDelegate):
3675         (TestInterfaces::setDelegate):
3676         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
3677         (TestInterfaces):
3678         * DumpRenderTree/chromium/TestShell.cpp:
3679         (TestShell::createMainWindow):
3680         (TestShell::~TestShell):
3681         * DumpRenderTree/chromium/WebViewHost.cpp:
3682         (WebViewHost::setGamepadData):
3683         * DumpRenderTree/chromium/WebViewHost.h:
3684         (WebViewHost):
3685
3686 2012-07-25  Christophe Dumez  <christophe.dumez@intel.com>
3687
3688         [WK2][WTR] LayoutTestController.sendWebIntentResponse() needs to be implemented
3689         https://bugs.webkit.org/show_bug.cgi?id=92227
3690
3691         Reviewed by Kenneth Rohde Christiansen.
3692
3693         Implement LayoutTestController.sendWebIntentResponse() so
3694         that a test case can reply to a Web intent request and
3695         test this functionality.
3696
3697         In order to support this functionality, we need to keep
3698         a pointer to the current intent request in
3699         InjectedBundlePage::didReceiveIntentForFrame() so that
3700         we can reuse it later in
3701         LayoutTestController::sendWebIntentResponse().
3702
3703         The following tests need this functionality:
3704         - webintents/web-intents-failure.html
3705         - webintents/web-intents-reply.html
3706
3707         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3708         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3709         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
3710         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3711         (InjectedBundlePage):
3712         (WTR::InjectedBundlePage::currentIntentRequest):
3713         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3714         (WTR::LayoutTestController::sendWebIntentResponse):
3715         (WTR):
3716         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3717         (LayoutTestController):
3718
3719 2012-07-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3720
3721         [EFL][WK2][WTR] Alt, Shift and Ctrl keys are not handled by EventSenderProxy.
3722         https://bugs.webkit.org/show_bug.cgi?id=92241
3723
3724         Reviewed by Kenneth Rohde Christiansen.
3725
3726         Alt, Shift and Ctrl keys were not handled by EventSenderProxy.
3727         It caused failure of fast/events/keydown-leftright-keys.html test.
3728
3729         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added handling of Alt, Shift and Ctrl keys.
3730         (WTR::keyName):
3731
3732 2012-07-25  Christophe Dumez  <christophe.dumez@intel.com>
3733
3734         [EFL][WK2] Fix timeout issues when debugging WebProcess.
3735         https://bugs.webkit.org/show_bug.cgi?id=92245
3736
3737         Reviewed by Dirk Pranke.
3738
3739         Fix timeout issues when debugging the WebProcess
3740         under valgrind or gdb.
3741
3742         * Scripts/webkitpy/layout_tests/port/efl.py:
3743         (EflPort.default_timeout_ms):
3744         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3745         (WTR::TestController::platformInitialize):
3746
3747 2012-07-25  Xianzhu Wang  <wangxianzhu@chromium.org>
3748
3749         [Chromium-Android] NRWT driver should not restart between reftests
3750         https://bugs.webkit.org/show_bug.cgi?id=92267
3751
3752         Reviewed by Dirk Pranke.
3753
3754         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3755         (ChromiumAndroidDriver.start): Resets self._pixel_tests when the pixel_tests parameter changes.
3756
3757 2012-07-25  Tommy Widenflycht  <tommyw@google.com>
3758
3759         MediaStream API: Update MediaStreamTrack to match the specification
3760         https://bugs.webkit.org/show_bug.cgi?id=90180
3761
3762         Reviewed by Adam Barth.
3763
3764         Adding a Mock WebMediaStreamCenter to enable better LayoutTests.
3765
3766         * DumpRenderTree/DumpRenderTree.gypi:
3767         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
3768         (MockWebKitPlatformSupport::createMediaStreamCenter):
3769         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
3770         (WebKit):
3771         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
3772         (WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
3773         (WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
3774         (WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
3775         (WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
3776         (WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
3777         (WebKit::MockWebMediaStreamCenter::constructSDP):
3778         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
3779         (WebKit):
3780         (MockWebMediaStreamCenter):
3781         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
3782
3783 2012-07-25  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3784
3785         [NRWT] Rename baseline_search_path() to default_baseline_search_path()
3786         https://bugs.webkit.org/show_bug.cgi?id=92122
3787
3788         Reviewed by Dirk Pranke.
3789
3790         * Scripts/webkitpy/layout_tests/port/base.py:
3791         (Port.baseline_version_dir):
3792         (Port.baseline_search_path):
3793         (Port):
3794         (Port.default_baseline_search_path):
3795         (Port.expected_baselines):
3796         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3797         (PortTest.test_additional_platform_directory):
3798         * Scripts/webkitpy/layout_tests/port/mac.py:
3799         (MacPort.default_baseline_search_path):
3800         * Scripts/webkitpy/layout_tests/port/qt.py:
3801         (QtPort.default_baseline_search_path):
3802         * Scripts/webkitpy/layout_tests/port/win.py:
3803         (WinPort.default_baseline_search_path):
3804
3805 2012-07-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3806
3807         [EFL] Use eina_stringshare_add instead of strdup.
3808         https://bugs.webkit.org/show_bug.cgi?id=92072
3809
3810         Reviewed by Kentaro Hara.
3811
3812         Eina of EFL libraries supports a string functionality that replaces strdup. So, EFL port needs
3813         to replace strdup with eina_stringshare_add function.
3814
3815         DumpRenderTree also needs to be modified according to ewk APIs's parameter change.
3816
3817         * DumpRenderTree/efl/DumpRenderTree.cpp:
3818         (dumpFramesAsText):
3819         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3820         (DumpRenderTreeChrome::onFrameIntentNew):
3821         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3822         (onJavaScriptPrompt):
3823
3824 2012-07-25  Alexander Shalamov  <alexander.shalamov@intel.com>
3825
3826         [WTR][EFL] Wheel events are not emitted
3827         https://bugs.webkit.org/show_bug.cgi?id=92094
3828
3829         Reviewed by Csaba Osztrogonác.
3830
3831         Wheel events are not emitted, therefore, layout tests that use mouseScrollBy method are failing.
3832
3833         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3834         (WTR::dispatchMouseScrollByEvent):
3835         (WTR::EventSenderProxy::mouseScrollBy):
3836         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3837         (WTR::PlatformWebView::PlatformWebView):
3838         (WTR::PlatformWebView::focus):
3839
3840 2012-07-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3841
3842         [EFL][WK2] Add ewk_main.{cpp,h} to EFL WK2
3843         https://bugs.webkit.org/show_bug.cgi?id=92101
3844
3845         Reviewed by Kenneth Rohde Christiansen.
3846
3847         Added a centralized place for general initialization in UI process for EFL WK2.
3848
3849         * MiniBrowser/efl/main.c: Added using of newly added ewk_init() and ewk_shutdown() functions.
3850         (main):
3851         * WebKitTestRunner/efl/main.cpp: Ditto.
3852         (main):
3853
3854 2012-07-24  Benjamin Poulain  <bpoulain@apple.com> && Joseph Pecoraro  <pecoraro@apple.com>
3855
3856         QualifiedName's HashSet should be big enough to hold at least all the static names
3857         https://bugs.webkit.org/show_bug.cgi?id=91891
3858
3859         Reviewed by Darin Adler.
3860
3861         Add a test for WTF::hashTableCapacityForSize.
3862
3863         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3864         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added.
3865         (InitialCapacityTestHashTraits):
3866         (TestWebKitAPI::testInitialCapacity):
3867         (TestWebKitAPI::generateTestCapacityUpToSize):
3868         (TestWebKitAPI::TEST):
3869
3870 2012-07-24  Adam Barth  <abarth@webkit.org>
3871
3872         The EWS bots get flaky when we hit the failure limit
3873         https://bugs.webkit.org/show_bug.cgi?id=92212
3874
3875         Reviewed by Eric Seidel.
3876
3877         Previously we were missing some failure types, which means we didn't
3878         notice that the bots were hitting the failure limit.
3879
3880         * Scripts/webkitpy/common/net/layouttestresults.py:
3881         (LayoutTestResults.failing_test_results):
3882         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3883         (LayoutTestResultsTest.test_results_from_string):
3884         (LayoutTestResultsTest.test_tests_matching_failure_types):
3885
3886 2012-07-24  Raphael Kubo da Costa  <rakuco@webkit.org>
3887
3888         [EFL] Unreviewed build fix.
3889
3890         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Include unistd.h
3891         for usleep(3).
3892
3893 2012-07-24  Dirk Pranke  <dpranke@chromium.org>
3894
3895         make test-webkitpy at least kinda work in parallel on win32
3896         https://bugs.webkit.org/show_bug.cgi?id=91700
3897
3898         Reviewed by Adam Barth.
3899
3900         This change makes the hoop-jumping we have to do to make running
3901         new-run-webkit-tests in parallel on win32 generic so that we can
3902         re-use it for test-webkitpy as well.
3903
3904         * Scripts/new-run-webkit-tests:
3905         * Scripts/test-webkitpy:
3906         * Scripts/webkitpy/common/multiprocessing_bootstrap.py: Copied from Tools/Scripts/new-run-webkit-tests.
3907         (run):
3908         * Scripts/webkitpy/test/main.py:
3909         (main):
3910         (Tester._log_exception):
3911
3912 2012-07-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3913
3914         Unreviewed, rolling out r123499.
3915         http://trac.webkit.org/changeset/123499
3916         https://bugs.webkit.org/show_bug.cgi?id=92161
3917
3918         Android fails to compile (Requested by zhenyao on #webkit).
3919
3920         * DumpRenderTree/DumpRenderTree.gypi:
3921         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
3922         (MockWebKitPlatformSupport::createMediaStreamCenter):
3923         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
3924         (MockWebKitPlatformSupport):
3925         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Removed.
3926         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Removed.
3927
3928 2012-07-24  Dirk Pranke  <dpranke@chromium.org>
3929
3930         nrwt: never finds binaries in the 'out' dir on chromium win
3931         https://bugs.webkit.org/show_bug.cgi?id=91890
3932
3933         Reviewed by Tony Chang.
3934
3935         Attempt to fix this bug yet again; it turns out that --root and
3936         --build-directory don't have the same meaning (--root should
3937         include the configuration, --build-directory should not).
3938
3939         * Scripts/webkitpy/layout_tests/port/base.py:
3940         (Port._build_path):
3941         * Scripts/webkitpy/layout_tests/port/chromium.py:
3942         (ChromiumPort._static_build_path):
3943         (ChromiumPort.default_results_directory):
3944         (ChromiumPort._build_path):
3945         (ChromiumPort):
3946         (ChromiumPort._build_path_with_configuration):
3947         (ChromiumPort._build_path_with_configuration.does):
3948         (ChromiumPort._path_to_image_diff):
3949         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3950         (ChromiumAndroidPort._build_path):
3951         (ChromiumAndroidPort):
3952         (ChromiumAndroidPort._build_path_with_configuration):
3953         (ChromiumAndroidPort._path_to_driver):
3954         (ChromiumAndroidPort._path_to_forwarder):
3955         (ChromiumAndroidPort._push_executable):
3956         (ChromiumAndroidPort._push_fonts):
3957         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3958         (ChromiumLinuxPort._determine_driver_path_statically):
3959         (ChromiumLinuxPort._modules_to_search_for_symbols):
3960         (ChromiumLinuxPort._path_to_driver):
3961         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3962         (ChromiumLinuxPortTest.test_build_path):
3963         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3964         (ChromiumMacPort._modules_to_search_for_symbols):
3965         (ChromiumMacPort._path_to_driver):
3966         (ChromiumMacPort._path_to_helper):
3967         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3968         (ChromiumMacPortTest.test_build_path):
3969         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3970         (ChromiumWinPort._path_to_driver):
3971         (ChromiumWinPort._path_to_helper):
3972         (ChromiumWinPort._path_to_image_diff):
3973         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3974         (ChromiumWinTest.test_build_path):
3975         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3976         (parse_args):
3977
3978 2012-07-24  Peter Beverloo  <peter@chromium.org>
3979
3980         Android-chromium layout tests failing with GPU related crash
3981         https://bugs.webkit.org/show_bug.cgi?id=92126
3982
3983         Reviewed by Adam Barth.
3984
3985         Remove support for the "--enable-hardware-gpu" flag from run_webkit_tests,
3986         as it's not being used by any port anymore, and neither is being passed
3987         on to the test runner. Instead, append the flag directly to DRT for the
3988         Chromium Android port, which does rely on this functionality.
3989
3990         The ChromiumAndroidUnitTest tests didn't catch this as the property was
3991         set to True, but it's unable to detect whether they'll actually be used.
3992         No occurrances of "--enable-hardware-gpu" exist in either Tools/Scripts/
3993         or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.
3994
3995         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3996         (ChromiumAndroidPort.__init__):
3997         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3998         (ChromiumAndroidPortTest.test_attributes):
3999         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4000         (parse_args):
4001
4002 2012-07-24  Alexander Shalamov  <alexander.shalamov@intel.com>
4003
4004         [WTR][EFL] Multiple mouse clicks are not emitted in EventSenderProxyEfl
4005         https://bugs.webkit.org/show_bug.cgi?id=92107
4006
4007         Reviewed by Kenneth Rohde Christiansen.
4008
4009         Fixes mouse click events in EventSenderProxyEfl.
4010
4011         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
4012         (WTR::dispatchMouseDownEvent):
4013         (WTR::EventSenderProxy::dispatchEvent):
4014
4015 2012-07-24  Tommy Widenflycht  <tommyw@google.com>
4016
4017         MediaStream API: Update MediaStreamTrack to match the specification
4018         https://bugs.webkit.org/show_bug.cgi?id=90180
4019
4020         Reviewed by Adam Barth.
4021
4022         Adding a Mock WebMediaStreamCenter to enable better LayoutTests.
4023
4024         * DumpRenderTree/DumpRenderTree.gypi:
4025         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
4026         (MockWebKitPlatformSupport::createMediaStreamCenter):
4027         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
4028         (WebKit):
4029         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
4030         (WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
4031         (WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
4032         (WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
4033         (WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
4034         (WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
4035         (WebKit::MockWebMediaStreamCenter::constructSDP):
4036         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
4037         (WebKit):
4038         (MockWebMediaStreamCenter):
4039         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
4040
4041 2012-07-23  Ryosuke Niwa  <rniwa@webkit.org>
4042
4043         Fix regressions in replay performance tests
4044         https://bugs.webkit.org/show_bug.cgi?id=92052
4045
4046         Reviewed by Dirk Pranke.
4047
4048         Fix regression that accumulated over time to make replay tests work again.
4049
4050         * DumpRenderTree/chromium/WebViewHost.cpp:
4051         (WebViewHost::willSendRequest): Use the main document URL in the request since the main frame's
4052         URL hadn't been updated yet When requesting a new URL on the main frame.
4053         * Scripts/webkitpy/performance_tests/perftest.py:
4054         (ReplayServer.wait_until_ready): Waiting for 6 seconds (3 tries) seems enough.
4055         (ReplayPerfTest.prepare): Pass self._archive_path to run_signle as that is the current contract.
4056         (ReplayPerfTest.run_single): Use the archive path to generate -expected.png path.
4057         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
4058         (TestReplayPerfTest.test_run_single):
4059         (TestReplayPerfTest.test_prepare):
4060         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
4061         (TestReplayPerfTest):
4062
4063 2012-07-24  Simon Hausmann  <simon.hausmann@nokia.com>
4064
4065         [Qt] MSVC: unresolved external symbol __DllMainCRTStartup@12
4066         https://bugs.webkit.org/show_bug.cgi?id=91229
4067
4068         Reviewed by Jocelyn Turcotte.
4069
4070         In order to successfully link a DLL on Windows we need to have at least
4071         one object file (or compilation unit). The forward export header files were
4072         supposed to be that, but unfortunately the rule in win32/default_post.prf for
4073         creating the header files had some bugs, among others that it did an exists()
4074         check on the depending static library. At the time qmake is ran those libraries
4075         do not exist yet and therefore the corresponding extra compiler rules were never
4076         created, resulting in empty OBJECTS/SOURCES.
4077
4078         Even without such an exists() check, qmake extra compilers require the files
4079         referred to in the .input variable to exist at qmake time. In this case the input
4080         files were the static libraries, which do not exist yet.
4081
4082         This patch solves this by using a qmake extra target instead of extra
4083         compiler, which does not have this limitation. The target is referenced
4084         through the extension of GENERATED_SOURCES.
4085
4086         The patch also adds a d/_debug suffix for debug builds, do allow for separate
4087         symbol exports if necessary.
4088
4089         * Scripts/generate-win32-export-forwards: Support multiple input files, i.e.
4090         consider the last argument to be the output file and everything else input.
4091         * qmake/mkspecs/features/win32/default_post.prf:
4092
4093 2012-07-24  Balazs Kelemen  <kbalazs@webkit.org>
4094
4095         [Qt] Add quirks for running the web process in a profiler shell, like valgrind
4096         https://bugs.webkit.org/show_bug.cgi?id=87672
4097
4098         Reviewed by Jocelyn Turcotte.
4099
4100         Add --no-timeout-at-all command line switch to not time out no matter how
4101         long the web process does it's job. --no-timeout is not enough for profiling
4102         purposes because it only affects the timeout when we are waiting for the end
4103         of the test. We use another timeout to control how much we wait for the web
4104         process to initialize before and reset after the test and it could also easily
4105         expire when running under valgrind. We should keep the behavior of --no-timeout
4106         to not disable this timout check because --no-timeout is used by performace tests
4107         and those should not wait for the web process to initialize and reset more than
4108         normal tests.
4109
4110         * WebKitTestRunner/TestController.cpp:
4111         (WTR::TestController::TestController):
4112         (WTR::TestController::initialize):
4113         (WTR::TestController::runUntil):
4114         * WebKitTestRunner/TestController.h:
4115
4116 2012-07-24  Peter Beverloo  <peter@chromium.org>
4117
4118         [Chromium] Fix a class/struct mismatch error in TestDelegate.h (showing up on clang)
4119         https://bugs.webkit.org/show_bug.cgi?id=92097
4120
4121         Unreviewed build fix.
4122
4123         WebContextMenuData is declared as a struct in Source/WebKit/chromium/public/WebContextMenuData.h,
4124         but TestDelegate.h forward declares it as a class.
4125
4126         * DumpRenderTree/chromium/TestRunner/TestDelegate.h:
4127         (WebKit):
4128
4129 2012-07-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
4130
4131         [Qt] Fix compilation against namespaced Qt
4132
4133         Reviewed by Simon Hausmann.
4134
4135         * QtTestBrowser/launcherwindow.h:
4136         * WebKitTestRunner/PlatformWebView.h:
4137
4138 2012-07-24  Peter Beverloo  <peter@chromium.org>
4139
4140         Update a few Chromium Android contributors in committers.py
4141         https://bugs.webkit.org/show_bug.cgi?id=92090
4142
4143         Reviewed by Kent Tamura.
4144
4145         Add Sami Kyostila, who has been doing significant work on Chromium's
4146         compositor. Add IRC nicknames for John Mellor and Tien-Ren Chen, and
4147         remove John Grabowski who changed projects, and add my webkit.org alias.
4148
4149         * Scripts/webkitpy/common/config/committers.py:
4150
4151 2012-07-24  Pierre Rossi  <pierre.rossi@gmail.com>
4152
4153         [Qt] Enable touch slider when touch events are enabled
4154         https://bugs.webkit.org/show_bug.cgi?id=91013
4155
4156         Reviewed by Kenneth Rohde Christiansen.
4157
4158         TOUCH_SLIDER guards are used in WebCore, so we should really
4159         be setting the corresponding ENABLE define in features.prf.
4160
4161         * qmake/mkspecs/features/features.prf:
4162
4163 2012-07-24  Ryuan Choi  <ryuan.choi@samsung.com>
4164
4165         [EFL] EWebLauncher should not require config.h in the style check
4166         https://bugs.webkit.org/show_bug.cgi?id=92070
4167
4168         Reviewed by Kentaro Hara.
4169
4170         * Scripts/webkitpy/style/checker.py:
4171         Remove the include rules from the style-check for EWebLauncher because
4172         EWebLauncher is simple EFL application.
4173
4174 2012-07-24  Jochen Eisinger  <jochen@chromium.or>
4175
4176         [Chromium] EventSender shouldn't know about TestShell
4177         https://bugs.webkit.org/show_bug.cgi?id=91449
4178
4179         Reviewed by Adam Barth.
4180
4181         Original patch by Adam Barth.
4182
4183         This patch removes the dependency from EventSender to TestShell.  Most
4184         of EventSender works directly with a WebView, but there are a handful
4185         of references to WebViewHost.  We don't want to re-use WebViewHost in
4186         ContentShell because we want to use the multi-process embedding
4187         environment for WebViews.
4188
4189         To avoid the dependency on WebViewHost, this patch introduces
4190         TestDelegate, which is an abstract base class for WebViewHost.  In
4191         ContentShell, we'll need another object to implement these functions.
4192
4193         * DumpRenderTree/chromium/EventSender.cpp:
4194         (EventSender::EventSender):
4195         (EventSender::keyDown):
4196         (makeMenuItemStringsFor):
4197         (EventSender::contextClick):
4198         * DumpRenderTree/chromium/EventSender.h:
4199         (EventSender):
4200         (EventSender::setDelegate):
4201         (EventSender::setWebView):
4202         (EventSender::webview):
4203         * DumpRenderTree/chromium/TestRunner/TestDelegate.h: Added.
4204         (WebKit):
4205         (TestDelegate):
4206         * DumpRenderTree/chromium/TestShell.cpp:
4207         (TestShell::initialize):
4208         (TestShell::createMainWindow):
4209         (TestShell::~TestShell):
4210         * DumpRenderTree/chromium/WebViewHost.cpp:
4211         (WebViewHost::fillSpellingSuggestionList):
4212         * DumpRenderTree/chromium/WebViewHost.h:
4213         (WebViewHost):
4214
4215 2012-07-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
4216
4217         Make WebIntents and WebIntentsTag a build option for the build-webkit script
4218         https://bugs.webkit.org/show_bug.cgi?id=91841
4219
4220         Reviewed by Philippe Normand.
4221
4222         And it will also be disabled when building with --minimal.
4223
4224         * Scripts/webkitperl/FeatureList.pm:
4225
4226 2012-07-23  Dirk Pranke  <dpranke@chromium.org>
4227
4228         Unreviewed, rolling out r123360.
4229         http://trac.webkit.org/changeset/123360
4230         https://bugs.webkit.org/show_bug.cgi?id=91890
4231
4232         broke the chromium bots
4233
4234         * Scripts/webkitpy/layout_tests/port/chromium.py:
4235         (ChromiumPort._static_build_path):
4236         (ChromiumPort.default_results_directory):
4237         (ChromiumPort._build_path):
4238         (ChromiumPort._path_to_image_diff):
4239         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4240         (ChromiumAndroidPort._build_path):
4241         (ChromiumAndroidPort._path_to_driver):
4242         (ChromiumAndroidPort._path_to_forwarder):
4243         (ChromiumAndroidPort._push_executable):
4244         (ChromiumAndroidPort._push_fonts):
4245         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4246         (ChromiumLinuxPort._determine_driver_path_statically):
4247         (ChromiumLinuxPort._modules_to_search_for_symbols):
4248         (ChromiumLinuxPort._path_to_driver):
4249         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
4250         (ChromiumLinuxPortTest.test_build_path):
4251         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4252         (ChromiumMacPort._modules_to_search_for_symbols):
4253         (ChromiumMacPort._path_to_driver):
4254         (ChromiumMacPort._path_to_helper):
4255         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4256         (ChromiumMacPortTest.test_build_path):
4257         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4258         (ChromiumWinPort._path_to_driver):
4259         (ChromiumWinPort._path_to_helper):
4260         (ChromiumWinPort._path_to_image_diff):
4261         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4262         (ChromiumWinTest.test_build_path):
4263
4264 2012-07-23  Adam Barth  <abarth@webkit.org>
4265
4266         [Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
4267         https://bugs.webkit.org/show_bug.cgi?id=91459
4268
4269         Reviewed by Ryosuke Niwa.
4270
4271         Rather than having TestShell own and bind each of these JavaScript APIs
4272         individually, TestShell should delegate that work to TestInterfaces.
4273         This patch moves AccessibilityController and TextInputController to be
4274         the responsibility of TestInterfaces.
4275
4276         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
4277         (TestInterfaces::TestInterfaces):
4278         (TestInterfaces::~TestInterfaces):
4279         (TestInterfaces::setWebView):
4280         (TestInterfaces::bindTo):
4281         (TestInterfaces::resetAll):
4282         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
4283         (WebKit):
4284         (TestInterfaces):
4285         (TestInterfaces::accessibilityController):
4286         * DumpRenderTree/chromium/TestShell.cpp:
4287         (TestShell::initialize):
4288         (TestShell::createMainWindow):
4289         (TestShell::~TestShell):
4290         (TestShell::resetTestController):
4291         (TestShell::bindJSObjectsToWindow):
4292         * DumpRenderTree/chromium/TestShell.h:
4293         (TestShell::accessibilityController):
4294         (TestShell):
4295
4296 2012-07-23  Balazs Kelemen  <kbalazs@webkit.org>