Add rafaelw as a committer.
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
2
3         Add rafaelw as a committer.
4
5         Unreviewed.
6
7         * Scripts/webkitpy/common/config/committers.py:
8
9 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
10
11         webkitpy: update names after deleting message_broker
12         https://bugs.webkit.org/show_bug.cgi?id=79000
13
14         Reviewed by Eric Seidel.
15
16         Part 3 of 3 in deleting message_broker.py; this change just
17         adjusts the names for the newly merged symbols so that they are
18         private as appropriate.
19
20         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
21         (get):
22         (_Broker):
23         (_BrokerConnection):
24         (_BrokerConnection.__init__):
25         (AbstractWorker.__init__):
26         (_ManagerConnection):
27         (_ManagerConnection.__init__):
28         (_WorkerConnection):
29         (_WorkerConnection.__init__):
30
31 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
32
33         webkitpy: merge message_broker.py into manager_worker_broker.py
34         https://bugs.webkit.org/show_bug.cgi?id=78999
35
36         Reviewed by Tony Chang.
37
38         This is pretty much a straight cut-and-paste of one file into
39         another (broken up so that docstrings and imports are in the
40         right place).
41
42         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
43         (BrokerClient):
44         (BrokerClient.is_done):
45         (BrokerClient.name):
46         (Broker):
47         (Broker.__init__):
48         (Broker.add_topic):
49         (Broker._get_queue_for_topic):
50         (Broker.post_message):
51         (Broker.run_message_loop):
52         (Broker.run_all_pending):
53         (Broker._run_loop):
54         (Broker._dispatch_message):
55         (_Message):
56         (_Message.loads):
57         (_Message.__init__):
58         (_Message.dumps):
59         (_Message.__repr__):
60         (BrokerConnection):
61         (BrokerConnection.__init__):
62         (BrokerConnection.run_message_loop):
63         (BrokerConnection.post_message):
64         (BrokerConnection.raise_exception):
65         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
66
67 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
68
69         webkitpy: prepare to delete message_broker.py
70         https://bugs.webkit.org/show_bug.cgi?id=78997
71
72         Reviewed by Eric Seidel.
73
74         This is part 1 of 3 changes to fix bug 78187. This change
75         prepares the code for merging message_broker.py into
76         manager_worker_broker.py; the tests in message_broker_unittest
77         are merged into manager_worker_broker_unittest, the symbols
78         needed by the tests are exported from manager_worker_broker.py,
79         and manager_worker_broker itself is updated to refer to the
80         symbols directly (without the module prefix).
81
82         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
83         (get):
84         (AbstractWorker):
85         (AbstractWorker.__init__):
86         (_ManagerConnection):
87         (_ManagerConnection.__init__):
88         (_WorkerConnection):
89         (_WorkerConnection.__init__):
90         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
91         (InterfaceTest.test_brokerclient_is_abstract):
92         (InterfaceTest.test_brokerclient_is_abstract.methods):
93         (MessageTest):
94         (MessageTest.test__no_body):
95         (MessageTest.test__body):
96         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
97
98 2012-02-21  Sam Weinig  <sam@webkit.org>
99
100         Attempt to fix the Snow Leopard build.
101
102         * DumpRenderTree/mac/Configurations/Base.xcconfig:
103         * MiniBrowser/Configurations/Base.xcconfig:
104         * TestWebKitAPI/Configurations/Base.xcconfig:
105         * WebKitTestRunner/Configurations/Base.xcconfig:
106
107 2012-02-21  Sam Weinig  <sam@webkit.org>
108
109         Use libc++ when building with Clang on Mac
110         https://bugs.webkit.org/show_bug.cgi?id=78981
111
112         Reviewed by Dan Bernstein.
113
114         * DumpRenderTree/mac/Configurations/Base.xcconfig:
115         * MiniBrowser/Configurations/Base.xcconfig:
116         * TestWebKitAPI/Configurations/Base.xcconfig:
117         * WebKitTestRunner/Configurations/Base.xcconfig:
118
119 2012-02-21  Adam Roben  <aroben@apple.com>
120
121         Roll out r108309, r108323, and r108326
122
123         They broke the 32-bit Lion build.
124
125         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
126
127         * DumpRenderTree/efl/CMakeLists.txt:
128
129 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
130
131         [Qt][WK2] Get rid of the dependency to QtWidgets
132         https://bugs.webkit.org/show_bug.cgi?id=76276
133
134         Reviewed by Simon Hausmann.
135
136         * MiniBrowser/qt/MiniBrowser.pro:
137         * MiniBrowser/qt/MiniBrowserApplication.cpp:
138         (MiniBrowserApplication::MiniBrowserApplication):
139         (MiniBrowserApplication::notify):
140         (MiniBrowserApplication::sendTouchEvent):
141         * MiniBrowser/qt/MiniBrowserApplication.h:
142         (MiniBrowserApplication):
143         * QtTestBrowser/locationedit.h:
144         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
145         (WTR::activateFonts):
146         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
147
148 2012-02-20  Adam Barth  <abarth@webkit.org>
149
150         mastercfg_unittest.py fails without simplejson
151         https://bugs.webkit.org/show_bug.cgi?id=79070
152
153         Reviewed by Csaba Osztrogonác.
154
155         Now that we require Python 2.6 (and higher) we can import json rather
156         than simplejson.  We still need to use the simplejson name because
157         that's what the master.cfg script expects.
158
159         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
160         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
161
162 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
163
164         JSC should be a triple-tier VM
165         https://bugs.webkit.org/show_bug.cgi?id=75812
166         <rdar://problem/10079694>
167
168         Reviewed by Gavin Barraclough.
169
170         Changed EFL's build system to include a new directory in JavaScriptCore.
171
172         * DumpRenderTree/efl/CMakeLists.txt:
173
174 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
175
176         Update pywebsocket to 0.7.2
177         https://bugs.webkit.org/show_bug.cgi?id=79066
178
179         This version includes vendor-prefixed deflate-frame extension support.
180
181         Reviewed by Kent Tamura.
182
183         * Scripts/webkitpy/thirdparty/__init__.py:
184         (AutoinstallImportHook._install_pywebsocket):
185
186 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
187
188         [UNIX] Plugin information fields are not interpreted as UTF-8
189         https://bugs.webkit.org/show_bug.cgi?id=78635
190
191         Reviewed by Gustavo Noronha Silva.
192
193         Interpret plugin metadata as UTF8 aways. This matches the behavior
194         of Chromium and the Totem plugin.
195
196         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
197         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
198
199 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
200
201         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
202         https://bugs.webkit.org/show_bug.cgi?id=78935
203
204         Reviewed by Gustavo Noronha Silva.
205
206         Move the TestNetscapePlugin headers to a more appropriate directory and update
207         the build files to match.
208
209         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
210         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
211         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
212         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
213         * GNUmakefile.am: Ditto.
214
215 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
216
217         Add a new API for the Vibration API(W3C).
218         https://bugs.webkit.org/show_bug.cgi?id=72010
219
220         Reviewed by Hajime Morita.
221
222         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
223
224 2012-02-20  János Badics  <dicska@gmail.com>
225
226         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
227         https://bugs.webkit.org/show_bug.cgi?id=71816
228
229         RunQtAPITests will notify if a timeout occurs during testing.
230         Added unittest to the master.cfg
231
232         Reviewed by Csaba Osztrogonác.
233
234         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
235         (RunQtAPITests.evaluateCommand):
236         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
237         (RunQtAPITestsTest):
238         (RunQtAPITestsTest.assertResults):
239         (RunQtAPITestsTest.test_timeout):
240         (test_success):
241         (test_failure):
242         (test_timeout_and_failure):
243
244 2012-02-20  Andy Wingo  <wingo@igalia.com>
245
246         Add wingo as a committer.
247
248         Unreviewed.
249
250         * Scripts/webkitpy/common/config/committers.py: Add myself to the
251         committers list.
252
253 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
254
255         [chromium] check that we're not running multiple modal dialogs at the same time
256         https://bugs.webkit.org/show_bug.cgi?id=78486
257
258         Reviewed by Kent Tamura.
259
260         * DumpRenderTree/chromium/TestShell.cpp:
261         (TestShell::TestShell):
262         * DumpRenderTree/chromium/TestShell.h:
263         (TestShell::setIsDisplayingModalDialog):
264         (TestShell::isDisplayingModalDialog):
265         (TestShell):
266         * DumpRenderTree/chromium/WebViewHost.cpp:
267         (WebViewHost::runModal):
268
269 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
270
271         Fix WebKit2GTK+ for 'make distcheck'.
272
273         Instead of conditionally including WebKit2 GNUmakefiles, always
274         include them and conditionally activate the final targets.
275
276         * MiniBrowser/gtk/GNUmakefile.am:
277         * WebKitTestRunner/GNUmakefile.am:
278
279 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
280
281         Enable video option for EFL port in build-webkit.
282         https://bugs.webkit.org/show_bug.cgi?id=79006
283
284         Reviewed by Daniel Bates.
285
286         * Scripts/build-webkit:
287
288 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
289
290         [EFL] Use modifier keys to execute pre-rendering.
291         https://bugs.webkit.org/show_bug.cgi?id=77933
292
293         Reviewed by Chang Shu.
294
295         Use modifier key to execute pre-rendering instead of using reserved function keys.
296
297         * EWebLauncher/main.c:
298         (on_key_down):
299
300 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
301
302         Fix one more dangling reference to worker_connection.name, delete unused code.
303
304         Unreviewed, build fix.
305
306         * Scripts/webkitpy/layout_tests/controllers/manager.py:
307         (Manager.update):
308         (_WorkerState.__init__):
309
310 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
311
312         Add a change that should've been in r108005.
313
314         Unreviewed, build fix.
315
316         In the refactoring/cleanup in r108005 I should've changed the
317         implementation of WorkerConnection to make it match BrokerClient
318         (and everything else) so that objects had a name() method
319         instead of a name property.
320
321         * Scripts/webkitpy/layout_tests/controllers/manager.py:
322         (Manager._run_tests):
323         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
324         (_WorkerConnection.__init__):
325         (_WorkerConnection.name):
326         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
327         (_TestWorker.__init__):
328         (_TestsMixin.name):
329         (_TestsMixin.test_name):
330         (_TestsMixin.test_cancel):
331         (_TestsMixin.test_unknown_message):
332
333 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
334
335         webkitpy: remove webkitpy.common.array_stream
336         https://bugs.webkit.org/show_bug.cgi?id=78952
337
338         Reviewed by Eric Seidel.
339
340         Turns out array_stream didn't really do anything that StringIO
341         didn't do (at least as of Python 2.6). This change removes it
342         and updates all of the callers. Where possible, I changed the
343         test assertions in order to capture the intent more clearly,
344         e.g., instead of calling self.assertTrue('foo' in stream.get()),
345         we have self.assertContainsLine(stream, 'foo'), and instead of
346         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
347         the latter isn't that much more readable, but StringIO doesn't
348         export an empty() method.
349
350         * Scripts/webkitpy/common/array_stream.py: Removed.
351         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
352         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
353         (passing_run):
354         (run_and_capture):
355         (StreamTestingMixin):
356         (StreamTestingMixin.assertContains):
357         (StreamTestingMixin.assertContainsLine):
358         (StreamTestingMixin.assertEmpty):
359         (StreamTestingMixin.assertNotEmpty):
360         (LintTest):
361         (LintTest.test_lint_test_files):
362         (LintTest.test_lint_test_files__errors):
363         (MainTest):
364         (MainTest.test_child_process_1):
365         (MainTest.test_child_processes_2):
366         (MainTest.test_child_processes_min):
367         (MainTest.test_help_printing):
368         (MainTest.test_hung_thread):
369         (MainTest.test_no_tests_found):
370         (MainTest.test_no_tests_found_2):
371         (MainTest.test_repeat_each_iterations_num_tests):
372         (MainTest.test_test_list):
373         (MainTest.test_unexpected_failures):
374         (MainTest.test_worker_model__inline_with_child_processes):
375         (MainTest.test_additional_platform_directory):
376         (RebaselineTest):
377         (RebaselineTest.assertBaselines):
378         (RebaselineTest.test_reset_results):
379         (RebaselineTest.test_missing_results):
380         (RebaselineTest.test_new_baseline):
381         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
382         (MeteredStream.update):
383         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
384         (TestMeteredStream.test_regular):
385         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
386         (TestUtilityFunctions.assertEmpty):
387         (TestUtilityFunctions):
388         (TestUtilityFunctions.assertNotEmpty):
389         (TestUtilityFunctions.assertWritten):
390         (TestUtilityFunctions.test_configure_logging):
391         (Testprinter.assertEmpty):
392         (Testprinter):
393         (Testprinter.assertNotEmpty):
394         (Testprinter.assertWritten):
395         (Testprinter.reset):
396         (Testprinter.get_printer):
397         (Testprinter.test_help_printer):
398         (Testprinter.do_switch_tests.do_helper):
399         (Testprinter.test_print_one_line_summary):
400         (Testprinter.test_print_test_result):
401         (Testprinter.test_print_progress):
402         (Testprinter.test_write_nothing):
403         (Testprinter.test_write_misc):
404         (Testprinter.test_write_everything):
405         (Testprinter.test_write_verbose):
406         (Testprinter.test_print_unexpected_results):
407         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
408         (MainTest.assertWritten):
409         (create_runner):
410         (test_run_test_set):
411         (test_run_test_set_kills_drt_per_run):
412         (test_run_test_set_for_parser_tests):
413         (test_run_test_set_with_json_output):
414         (test_run_test_set_with_json_source):
415         (test_run_test_set_with_multiple_repositories):
416         (test_upload_json):
417
418 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
419
420         [wx] Add the WebCore/page/scrolling directory to the build dirs.
421
422         * waf/build/settings.py:
423
424 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
425
426         [wx] Unreviewed build fix. Don't error out or hang if we have
427         downloaded dependencies but server update check fails.
428
429         * waf/build/build_utils.py:
430         (download_if_newer):
431
432 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
433
434         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
435         https://bugs.webkit.org/show_bug.cgi?id=69444
436
437         Reviewed by Tony Chang.
438
439         Currently if a test's image checksum doesn't match the checksum
440         in the baseline, but the images themselves match according to
441         ImageDiff, new-run-webkit-tests ignores the problem. This is
442         probably bad, but it's not yet clear what the right thing to do
443         is. This patch will log a warning to stderr, at least (but the
444         test will still pass).
445
446         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
447         (SingleTestRunner._compare_image):
448         (SingleTestRunner._run_reftest):
449         * Scripts/webkitpy/layout_tests/port/test.py:
450         (unit_test_list):
451         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
452
453 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
454
455         NRWT does not report failure for a skipped test
456         https://bugs.webkit.org/show_bug.cgi?id=78750
457
458         Reviewed by Eric Seidel.
459
460         If a test is listed in a Skipped file and you run it anyway
461         with --force, and the test fails, currently NRWT will print
462         "test ran as expected"; this is confusing, because you probably
463         expect the test to fail and yet this might lead you to think the
464         test passed. This patch changes the expected behavior to "PASS",
465         so tests that fail will be reported.
466
467         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
468         (result_was_expected):
469         (TestExpectationParser):
470         (TestExpectationParser.expectation_for_skipped_test):
471         (TestExpectations):
472         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
473         (test_add_skipped_tests):
474         * Scripts/webkitpy/layout_tests/port/test.py:
475         (unit_test_list): Add some tests that are expected to be in a Skipped file.
476         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
477
478 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
479
480         webkitpy: fix test code after bug 78181
481         https://bugs.webkit.org/show_bug.cgi?id=78870
482
483         Reviewed by Adam Barth.
484
485         I forgot to update the test code as per Tony's suggestion in
486         bug 78181 (r108005). This change does that, and in doing so
487         it revealed a subtle bug in _InlineWorkerConnection.run() that
488         I am fixing as part of this (_alive would not be cleared if an
489         exception was thrown).
490
491         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
492         (_InlineWorkerConnection.run):
493         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
494         (_TestWorker.__init__):
495         (_TestWorker.handle_stop):
496         (_TestWorker.handle_test):
497         (_TestWorker.run):
498         (_TestsMixin.handle_exception):
499         (_TestsMixin.test_unknown_message):
500
501 2012-02-17  Adam Roben  <aroben@apple.com>
502
503         Mac build fix after r108119
504
505         * DumpRenderTree/mac/DumpRenderTree.mm:
506         (runThread):
507         (runPthread):
508         (testThreadIdentifierMap):
509         Updated to match current WTF threading APIs.
510
511 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
512
513         revert r107147 - breaks webkit-patch on Mac SL
514         https://bugs.webkit.org/show_bug.cgi?id=78866
515
516         Reviewed by Adam Barth.
517
518         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
519         which is the version that ships on Mac SL. Reverting this
520         change until we no longer have to worry about that version.
521
522         * Scripts/webkitpy/common/system/autoinstall.py:
523         (AutoInstaller):
524         (AutoInstaller._extract_all): Added a comment about SL.
525         (AutoInstaller._unzip):
526
527 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
528
529         CSS regions enabled by default
530         https://bugs.webkit.org/show_bug.cgi?id=78525
531
532         Reviewed by David Hyatt.
533
534         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
535         CSSRegions are still enabled by default.
536         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
537
538         * DumpRenderTree/chromium/LayoutTestController.cpp:
539         (LayoutTestController::overridePreference):
540         * DumpRenderTree/chromium/WebPreferences.cpp:
541         (WebPreferences::reset):
542         (WebPreferences::applyTo):
543         * DumpRenderTree/chromium/WebPreferences.h:
544         (WebPreferences):
545         * DumpRenderTree/mac/DumpRenderTree.mm:
546         (resetDefaultsToConsistentValues):
547
548 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
549
550         Some API tests erroneously use = instead of == (causing build failures)
551         https://bugs.webkit.org/show_bug.cgi?id=78915
552
553         Reviewed by Sam Weinig.
554
555         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
556         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
557         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
558
559 2012-02-17  Peter Beverloo  <peter@chromium.org>
560
561         [Chromium] Include TestShellLinux.cpp in the build for Android
562         https://bugs.webkit.org/show_bug.cgi?id=78865
563
564         Reviewed by Eric Seidel.
565
566         Android will be re-using the TestShellLinux.cpp file. I already
567         added this r104033, but it seems to have gotten lost in the
568         recent refactorings.
569
570         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
571
572 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
573
574         Unreviewed, disable video build on EFL until it can be
575         supported by EFL build bot.
576
577         * Scripts/build-webkit:
578
579 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
580
581         [GTK] Implement zoom in/out in MiniBrowser
582         https://bugs.webkit.org/show_bug.cgi?id=75253
583
584         Reviewed by Gustavo Noronha Silva.
585
586         * MiniBrowser/gtk/BrowserWindow.c:
587         (browserWindowCanZoomIn):
588         (browserWindowCanZoomOut):
589         (browserWindowUpdateZoomActions):
590         (webViewZoomLevelChanged):
591         (zoomInCallback):
592         (zoomOutCallback):
593         (browser_window_init):
594         (browserWindowConstructed):
595
596 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
597
598         layoutTestController.display() is flaky for SVG tests
599         https://bugs.webkit.org/show_bug.cgi?id=78021
600
601         Reviewed by Adam Roben.
602
603         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
604         Size the web view before running the test, not when dumping.
605         All platforms handle this correctly now.
606
607         * DumpRenderTree/win/DumpRenderTree.cpp:
608         (dump):
609         (sizeWebViewForCurrentTest):
610         (runTest):
611
612 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
613
614         [GTK] Make install is broken when building without --enable-gtk-doc
615         https://bugs.webkit.org/show_bug.cgi?id=78828
616
617         Reviewed by Martin Robinson.
618
619         * gtk/generate-gtkdoc:
620         (rebase_installed_docs): Check documentation has been generated
621         before trying to rebase it.
622
623 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
624
625         nrwt: simplify worker interface
626         https://bugs.webkit.org/show_bug.cgi?id=78181
627
628         Reviewed by Tony Chang.
629
630         This change moves code in name(), is_done(), run(), and cancel()
631         from Worker to AbstractWorker, since the logic is pretty much
632         boilerplate code that any implementation would want to use.
633
634         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
635         (get.should):
636         (AbstractWorker.__init__):
637         (AbstractWorker):
638         (AbstractWorker.name):
639         (AbstractWorker.stop_handling_messages):
640         (AbstractWorker.run):
641         (AbstractWorker.is_done):
642         (AbstractWorker.cancel):
643         * Scripts/webkitpy/layout_tests/controllers/worker.py:
644         (Worker.__init__):
645         (Worker.run):
646         (Worker.handle_stop):
647
648 2012-02-16  Michael Saboff  <msaboff@apple.com>
649
650         ENH: Add ability to run subset of JavaScript layout tests with JSC
651         https://bugs.webkit.org/show_bug.cgi?id=78764
652
653         Reviewed by Gavin Barraclough.
654
655         New simple test drive shell script that runs a defined
656         list of javascript tests using jsc and the standalone-{pre,post}.js
657         wrappers.
658
659         * Scripts/run-fast-jsc: Added.
660
661 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
662
663         Add new Qt performance tester bot to build.webkit.org
664         https://bugs.webkit.org/show_bug.cgi?id=78795
665
666         Reviewed by Adam Roben.
667
668         * BuildSlaveSupport/build.webkit.org-config/config.json:
669
670 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
671
672         Disable inspector on WinCE.
673
674         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
675
676         * Scripts/build-webkit:
677
678 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
679
680         WinCE build fix after r107656.
681
682         Disable FTPDIR on WinCE, since it does not compile there.
683
684         * Scripts/build-webkit:
685
686 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
687
688         Build fix after r107863.
689
690         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
691
692 2012-02-15  Tony Chang  <tony@chromium.org>
693
694         [chromium] add linux dbg back to garden-o-matic
695         https://bugs.webkit.org/show_bug.cgi?id=78752
696
697         Reviewed by Adam Barth.
698
699         This reflects the current linux debug bot name (there's only one bot).
700         I'm also remove the mac clang builder since it doesn't exist (mac
701         always uses clang now).
702
703         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
704         * Scripts/webkitpy/layout_tests/port/builders.py:
705
706 2012-02-15  Sam Weinig  <sam@webkit.org>
707
708         Add style check for ctype functions that are generally frowned upon in WebKit
709         https://bugs.webkit.org/show_bug.cgi?id=78748
710
711         Reviewed by Anders Carlsson.
712
713         Not every platform has DisallowCType.h to check for uses of the ctype.h
714         functions, so add a style check for them as well.
715
716         * Scripts/webkitpy/style/checkers/cpp.py:
717         (check_ctype_functions):
718         (check_style):
719         (CppChecker):
720         Add check.
721
722         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
723         (WebKitStyleTest.test_ctype_fucntion):
724         Add checker.
725
726 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
727
728         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
729         https://bugs.webkit.org/show_bug.cgi?id=76546
730
731         Reviewed by Simon Hausmann.
732
733         Resize the web view programatically because the declarative property binding
734         does not work. Seems like our qml environment is not initialized fully but it
735         needs more investigation.
736
737         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
738         (WTR::WrapperWindow::handleStatusChanged):
739         (WTR::PlatformWebView::resizeTo):
740
741 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
742
743         webkitpy: add a worker_args concept to start_worker()
744         https://bugs.webkit.org/show_bug.cgi?id=78572
745
746         Reviewed by Tony Chang.
747
748         This change replaces the three NRWT-specific arguments passed
749         through the broker to the worker with a generic WorkerArguments
750         wrapper class and a separate set_inline_arguments() call that can
751         be used to pass additional data to the worker when it is running
752         in the same process as the manager (this is needed for testing).
753         With the addition of set_inline_arguments() we also no longer
754         need to pass an optional argument to the worker.run() call.
755
756         Note that this method is *only* implemented on inline workers,
757         so calling this on a regular (child process) worker will result
758         in a runtime error.
759
760         * Scripts/webkitpy/layout_tests/controllers/manager.py:
761         (Manager._run_tests):
762         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
763         (AbstractWorker.__init__):
764         (AbstractWorker.run):
765         (_ManagerConnection.start_worker):
766         (_InlineManager.start_worker):
767         (_InlineManager.set_inline_arguments):
768         (_InlineManager.run_message_loop):
769         (_MultiProcessManager.start_worker): Reworked signature.
770         (_WorkerConnection.__init__):
771         (_InlineWorkerConnection.__init__):
772         (_InlineWorkerConnection.set_inline_arguments): New method.
773         (_InlineWorkerConnection):
774         (_InlineWorkerConnection.run):
775         (_Process.run):
776         (_MultiProcessWorkerConnection.__init__):
777         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
778         (_TestWorker.__init__):
779         (_TestWorker.set_inline_arguments):
780         (_TestWorker.handle_test):
781         (_TestWorker.run):
782         (_TestsMixin.test_cancel):
783         (_TestsMixin.test_done):
784         (_TestsMixin.test_unknown_message):
785         (InlineBrokerTests): New class for more testing.
786         (InlineBrokerTests.setUp):
787         (InlineBrokerTests.test_inline_arguments): New test.
788         (InterfaceTest.test_managerconnection_is_abstract):
789         (InterfaceTest.test_workerconnection_is_abstract):
790         * Scripts/webkitpy/layout_tests/controllers/worker.py:
791         (WorkerArguments):
792         (WorkerArguments.__init__):
793         (Worker.__init__):
794         (Worker.set_inline_arguments):
795         (Worker):
796         (Worker.run):
797         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
798         (WorkerTest.test_default_platform_in_worker):
799
800 2012-02-15  Adam Klein  <adamk@chromium.org>
801
802         Unreviewed, rolling out r107704.
803         http://trac.webkit.org/changeset/107704
804         https://bugs.webkit.org/show_bug.cgi?id=78486
805
806         Caused layout test crashes in debug builds.
807
808         Specific crashing tests:
809
810         fast/events/show-modal-dialog-onblur-onfocus.html
811         fast/harness/show-modal-dialog.html
812         inspector/console/console-long-eval-crash.html
813
814         * DumpRenderTree/chromium/TestShell.cpp:
815         (TestShell::TestShell):
816         * DumpRenderTree/chromium/TestShell.h:
817         (TestShell):
818         * DumpRenderTree/chromium/WebViewHost.cpp:
819         (WebViewHost::runModal):
820
821 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
822
823         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
824         https://bugs.webkit.org/show_bug.cgi?id=76347
825
826         Reviewed by Kenneth Rohde Christiansen.
827
828         * MiniBrowser/qt/MiniBrowser.qrc:
829         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. 
830         * MiniBrowser/qt/qml/BrowserWindow.qml:
831         * MiniBrowser/qt/qml/DialogLineInput.qml:
832
833 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
834
835         [Qt] Fix WebGL in QtTestBrowser
836
837         Reviewed by Tor Arne Vestbø.
838
839         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
840         the options for enabling GL we also pass them on properly.
841
842 2012-02-14  Sam Weinig  <sam@webkit.org>
843
844         Add #include of unistd.h on the mac for getcwd. 
845
846         Reviewed by Anders Carlsson.
847
848         This is necessary when building with libc++.
849
850         * WebKitTestRunner/TestInvocation.cpp:
851
852 2012-02-14  Sam Weinig  <sam@webkit.org>
853
854         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
855         https://bugs.webkit.org/show_bug.cgi?id=78663
856
857         Reviewed by Anders Carlsson.
858
859         * DumpRenderTree/DumpRenderTreePrefix.h:
860         * DumpRenderTree/cg/ImageDiffCG.cpp:
861
862 2012-02-14  Adam Barth  <abarth@webkit.org>
863
864         Implement an adb-based driver for the ChromiumAndroidPort
865         https://bugs.webkit.org/show_bug.cgi?id=78627
866
867         Reviewed by Eric Seidel.
868
869         This driver mostly just wires up the ChromiumDriver through adb.  In
870         some cases, it translates protocol elements, such as URIs, so that the
871         rest of webkitpy is insulated from the "remoteness" of the target device.
872
873         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
874         (ChromiumAndroidPort.start_helper):
875         (ChromiumAndroidPort._driver_class):
876         (ChromiumAndroidPort._update_version):
877         (ChromiumAndroidPort._get_stderr):
878         (ChromiumAndroidPort):
879         (ChromiumAndroidPort._get_last_stacktrace):
880         (ChromiumAndroidPort._teardown_performance):
881         (ChromiumAndroidDriver):
882         (ChromiumAndroidDriver.__init__):
883         (ChromiumAndroidDriver._start):
884         (ChromiumAndroidDriver.run_test):
885         (ChromiumAndroidDriver.stop):
886         (ChromiumAndroidDriver._test_shell_command):
887         (ChromiumAndroidDriver._write_command_and_read_line):
888         (ChromiumAndroidDriver._output_image):
889         (ChromiumAndroidDriver._has_crash_hint):
890
891 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
892
893         webkitpy: the real_name() method in the Port class is no longer needed
894         https://bugs.webkit.org/show_bug.cgi?id=78651
895
896         Reviewed by Eric Seidel.
897
898         The change in bug 78565 / r107718 made it no longer necessary
899         (we can use options.platform instead).
900
901         * Scripts/webkitpy/layout_tests/port/base.py:
902         (Port.name):
903         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
904         (MockDRTPort.__init__):
905
906 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
907
908         webkitpy: clean up options, port handling in manager_worker_broker
909         https://bugs.webkit.org/show_bug.cgi?id=78568
910
911         Reviewed by Tony Chang.
912
913         manager_worker_broker no longer needs options or port objects
914         directly, so we make them only be passed in start_worker().
915
916         * Scripts/webkitpy/layout_tests/controllers/manager.py:
917         (Manager._run_tests):
918         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
919         (get):
920         (_ManagerConnection.__init__):
921         (_ManagerConnection.start_worker):
922         (_InlineManager.__init__):
923         (_InlineManager.start_worker):
924         (_InlineManager.run_message_loop):
925         (_MultiProcessManager.__init__):
926         (_MultiProcessManager):
927         (_MultiProcessManager.start_worker):
928         (_InlineWorkerConnection.__init__):
929         (_InlineWorkerConnection.run):
930         (_Process.__init__):
931         (_MultiProcessWorkerConnection.__init__):
932         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
933         (make_broker):
934         (_TestWorker.run):
935         (_TestsMixin.test_cancel):
936         (_TestsMixin.test_done):
937         (_TestsMixin.test_unknown_message):
938         (MultiProcessBrokerTests.setUp):
939         (InterfaceTest.test_managerconnection_is_abstract):
940         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
941         (Broker.__init__):
942
943 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
944
945         nrwt: add a unit test for regression introduced in bug 78565
946         https://bugs.webkit.org/show_bug.cgi?id=78646
947
948         Reviewed by Tony Chang.
949
950         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
951         (FakeConnection):
952         (FakeConnection.run_message_loop):
953         (FakeConnection.post_message):
954         (WorkerTest):
955         (WorkerTest.test_default_platform_in_worker):
956
957 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
958
959         NRWT is broken for the default port
960         https://bugs.webkit.org/show_bug.cgi?id=78640
961     
962         Reviewed by Tony Chang.
963
964         The change in r107718 (bug 78565) broke NRWT if you didn't
965         specify any sort of --platform flag or equivalent. I didn't
966         catch this because it's a full integration test (which we don't
967         have an automated test for) and I missed this command line
968         variant when testing interactively.
969
970         * Scripts/webkitpy/layout_tests/controllers/worker.py:
971         (Worker.run):
972
973 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
974
975         Last character display for passwords in Android.
976         https://bugs.webkit.org/show_bug.cgi?id=78532
977
978         Reviewed by Adam Barth.
979
980         * DumpRenderTree/chromium/WebPreferences.cpp:
981         (WebPreferences::applyTo):
982
983 2012-02-14  Adam Barth  <abarth@webkit.org>
984
985         Finish implementing start_helper for ChromiumAndroidPort
986         https://bugs.webkit.org/show_bug.cgi?id=78582
987
988         Reviewed by Eric Seidel.
989
990         This patch contains the remaining odds and ends for the start_helper function.
991
992         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
993         (ChromiumAndroidPort.start_helper):
994         (ChromiumAndroidPort._synchronize_datetime):
995         (ChromiumAndroidPort):
996         (ChromiumAndroidPort._check_version):
997         (ChromiumAndroidPort._run_adb_command):
998         (ChromiumAndroidPort._copy_device_file):
999
1000 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1001
1002         webkitpy: create ports in Workers, not in manager_worker_broker
1003         https://bugs.webkit.org/show_bug.cgi?id=78565
1004
1005         Reviewed by Tony Chang.
1006
1007         We will now create the Port object (if necessary) in the Worker
1008         directly, so that the manager_worker_broker module doesn't need
1009         all of this layout_test-specific logic. Part of the fixes for
1010         bug 78171.
1011
1012         These changes are all well-tested by the existing tests in
1013         run_webkit_tests_integrationtest.py.
1014
1015         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1016         (_Process.run):
1017         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1018         (Worker.__init__):
1019         (Worker.safe_init):
1020         (Worker.run):
1021         (Worker.cleanup):
1022         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1023         (parse_args):
1024         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
1025
1026 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
1027
1028         [chromium] check that we're not running multiple modal dialogs at the same time
1029         https://bugs.webkit.org/show_bug.cgi?id=78486
1030
1031         Reviewed by Kent Tamura.
1032
1033         * DumpRenderTree/chromium/TestShell.cpp:
1034         (TestShell::TestShell):
1035         * DumpRenderTree/chromium/TestShell.h:
1036         (TestShell::setIsDisplayingModalDialog):
1037         (TestShell::isDisplayingModalDialog):
1038         (TestShell):
1039         * DumpRenderTree/chromium/WebViewHost.cpp:
1040         (WebViewHost::runModal):
1041
1042 2012-02-14  Adam Barth  <abarth@webkit.org>
1043
1044         Enable the GPU codepath in the chromium-android port
1045         https://bugs.webkit.org/show_bug.cgi?id=78580
1046
1047         Reviewed by James Robinson.
1048
1049         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
1050         Android always uses the GPU codepath, so we set the GPU flags on the
1051         main chromium-android port instead.
1052
1053         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1054         (ChromiumAndroidPort.__init__):
1055
1056 2012-02-14  Adam Barth  <abarth@webkit.org>
1057
1058         NRWT should expose --adb-args flag for Android
1059         https://bugs.webkit.org/show_bug.cgi?id=78579
1060
1061         Reviewed by Eric Seidel.
1062
1063         This flag is already wired up to the ChromiumAndroidPort.
1064
1065         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1066         (parse_args):
1067
1068 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
1069
1070         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
1071         https://bugs.webkit.org/show_bug.cgi?id=78541
1072         <rdar://problem/10036695>
1073
1074         Reviewed by Kent Tamura.
1075
1076         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
1077         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
1078         After each test, reset to using new protocol.
1079
1080 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
1081
1082         Convert svg/animations to use SMIL methods for driving the timeline
1083         https://bugs.webkit.org/show_bug.cgi?id=78422
1084
1085         Reviewed by Dirk Schulze.
1086
1087         Remove no longer needed SVG specific animation sampling functionality from DRT.
1088         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
1089
1090         * DumpRenderTree/LayoutTestController.cpp:
1091         (LayoutTestController::staticFunctions):
1092         * DumpRenderTree/LayoutTestController.h:
1093         (LayoutTestController):
1094         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1095         * DumpRenderTree/chromium/LayoutTestController.cpp:
1096         (LayoutTestController::LayoutTestController):
1097         * DumpRenderTree/chromium/LayoutTestController.h:
1098         (LayoutTestController):
1099         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1100         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1101         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1102         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1103         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1104         (LayoutTestController):
1105         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1106         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1107
1108 2012-02-13  Rob Flack  <flackr@chromium.org>
1109
1110         Add Linux ChromiumOS test results to flakiness dashboard.
1111         https://bugs.webkit.org/show_bug.cgi?id=78495
1112
1113         Reviewed by Ojan Vafai.
1114
1115         * TestResultServer/static-dashboards/builders.js:
1116         * TestResultServer/static-dashboards/dashboard_base.js:
1117
1118 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
1119
1120         [GTK] Mutation Observers build is broken
1121         https://bugs.webkit.org/show_bug.cgi?id=78433
1122
1123         Reviewed by Martin Robinson.
1124
1125         Enabled mutation observers as a default feature for GTK port, too.
1126
1127         * Scripts/build-webkit:
1128
1129 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
1130
1131         Allow to configure ENABLE_FTPDIR in build-webkit
1132         https://bugs.webkit.org/show_bug.cgi?id=65098
1133
1134         Reviewed by Eric Seidel.
1135
1136         Allow to disable ENABLE_FTPDIR by command line.
1137         Remove ENABLE_FTPDIR from --minimal build
1138
1139         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
1140         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
1141         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
1142
1143 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
1144
1145         Add shinyak as committer.
1146
1147         Unreviewed.
1148
1149         * Scripts/webkitpy/common/config/committers.py:
1150
1151 2012-02-13  Adam Barth  <abarth@webkit.org>
1152
1153         Implement start/stop_helper for ChromiumAndroidPort
1154         https://bugs.webkit.org/show_bug.cgi?id=78558
1155
1156         Reviewed by Dirk Pranke.
1157
1158         These functions (and their dependencies) set up the Android device for
1159         testing.
1160
1161         This patch also includes a few tweaks on the previous patch recommended
1162         by dpranke.
1163
1164         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1165         (ChromiumAndroidPort.__init__):
1166         (ChromiumAndroidPort.start_helper):
1167         (ChromiumAndroidPort.stop_helper):
1168         (ChromiumAndroidPort._shut_down_http_server):
1169         (ChromiumAndroidPort):
1170         (ChromiumAndroidPort._push_executable):
1171         (ChromiumAndroidPort._push_fonts):
1172         (ChromiumAndroidPort._restore_system_font):
1173         (ChromiumAndroidPort._push_test_resources):
1174         (ChromiumAndroidPort._push_to_device):
1175         (ChromiumAndroidPort._pull_from_device):
1176         (ChromiumAndroidPort._kill_device_process):
1177         (ChromiumAndroidPort._setup_performance):
1178         (ChromiumAndroidPort._teardown_performance):
1179         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1180         (ChromiumAndroidPortTest):
1181         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1182         (PortTestCase):
1183         (PortTestCase.make_port):
1184         (PortTestCase.test_default_worker_model):
1185
1186 2012-02-13  Adam Barth  <abarth@webkit.org>
1187
1188         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
1189         https://bugs.webkit.org/show_bug.cgi?id=78550
1190
1191         Reviewed by Eric Seidel.
1192
1193         Much of this code just forwards to the "host" port, which seems like a
1194         reasonable thing to do.
1195
1196         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1197         (ChromiumAndroidPort.__init__):
1198         (ChromiumAndroidPort.stop_helper):
1199         (ChromiumAndroidPort):
1200         (ChromiumAndroidPort._build_path):
1201         (ChromiumAndroidPort._path_to_apache):
1202         (ChromiumAndroidPort._path_to_apache_config_file):
1203         (ChromiumAndroidPort._path_to_driver):
1204         (ChromiumAndroidPort._path_to_helper):
1205         (ChromiumAndroidPort._path_to_image_diff):
1206         (ChromiumAndroidPort._path_to_lighttpd):
1207         (ChromiumAndroidPort._path_to_lighttpd_modules):
1208         (ChromiumAndroidPort._path_to_lighttpd_php):
1209         (ChromiumAndroidPort._path_to_wdiff):
1210         (ChromiumAndroidPort._shut_down_http_server):
1211         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1212         (ChromiumAndroidPortTest):
1213         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1214         (PortTestCase):
1215         (PortTestCase.make_port):
1216         (PortTestCase.test_default_worker_model):
1217
1218 2012-02-13  Adam Barth  <abarth@webkit.org>
1219
1220         chromium_android.py should implement "virtual" methods from ChromiumPort
1221         https://bugs.webkit.org/show_bug.cgi?id=78545
1222
1223         Reviewed by Dirk Pranke.
1224
1225         This patch adds basic implementations that specialize a bunch of
1226         functions from ChromiumPort.
1227
1228         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1229         (ChromiumAndroidPort):
1230         (ChromiumAndroidPort.__init__):
1231         (ChromiumAndroidPort.default_child_processes):
1232         (ChromiumAndroidPort.baseline_search_path):
1233         (ChromiumAndroidPort.check_build):
1234         (ChromiumAndroidPort.check_sys_deps):
1235         (ChromiumAndroidPort.default_worker_model):
1236         (ChromiumAndroidPort.test_expectations):
1237         (ChromiumAndroidPort.start_http_server):
1238         (ChromiumAndroidPort.stop_http_server):
1239         (ChromiumAndroidPort.start_helper):
1240         (ChromiumAndroidPort.stop_helper):
1241
1242 2012-02-13  Adam Barth  <abarth@webkit.org>
1243
1244         Add a skeleton ChromiumAndroid port to webkitpy
1245         https://bugs.webkit.org/show_bug.cgi?id=78543
1246
1247         Reviewed by Eric Seidel.
1248
1249         This patch just adds an empty ChromiumAndroid port object to webkitpy
1250         and wires it up to the factory objects.  An actual implementation will
1251         follow.
1252
1253         * Scripts/webkitpy/layout_tests/port/chromium.py:
1254         (ChromiumPort):
1255         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
1256         (ChromiumAndroidPort):
1257         (ChromiumAndroidPort.__init__):
1258         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1259         (ChromiumPortTest.test_all_test_configurations):
1260         * Scripts/webkitpy/layout_tests/port/factory.py:
1261         (PortFactory):
1262
1263 2012-02-13  Adam Barth  <abarth@webkit.org>
1264
1265         NRWT's HTTP servers should support additional directories for resources
1266         https://bugs.webkit.org/show_bug.cgi?id=78528
1267
1268         Reviewed by Eric Seidel.
1269
1270         This functionality will be used by the Chromium-Android port.
1271
1272         * Scripts/webkitpy/layout_tests/port/base.py:
1273         (Port.to.start_http_server):
1274         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1275         (LayoutTestApacheHttpd.__init__):
1276         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1277         (Lighttpd.__init__):
1278         (Lighttpd._prepare_config):
1279
1280 2012-02-13  Ami Fischman  <fischman@chromium.org>
1281
1282         Add fischman as committer.
1283
1284         Unreviewed
1285
1286         * Scripts/webkitpy/common/config/committers.py:
1287
1288 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
1289
1290         [EFL] Drop support for the Curl network backend.
1291         https://bugs.webkit.org/show_bug.cgi?id=77874
1292
1293         Reviewed by Eric Seidel.
1294
1295         Nobody seems to be maintaining the Curl backend in WebCore, the
1296         EFL port developers all seem to be using the Soup backend and the
1297         port itself has many features which are only implemented for the
1298         latter.
1299
1300         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
1301         and always add the required include directories.
1302         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
1303         include directories and link to them.
1304
1305 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
1306
1307         [WebSocket] Update pywebsocket to 0.7.1
1308         https://bugs.webkit.org/show_bug.cgi?id=78484
1309
1310         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
1311
1312         Reviewed by Kent Tamura.
1313
1314         * Scripts/webkitpy/thirdparty/__init__.py:
1315         (AutoinstallImportHook._install_pywebsocket):
1316
1317 2012-02-12  Kangil Han  <kangil.han@samsung.com>
1318
1319         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
1320         https://bugs.webkit.org/show_bug.cgi?id=78091
1321
1322         Reviewed by Hajime Morita.
1323
1324         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
1325         This patch will activate around 1,900 test cases from skipped list in EFL port.
1326
1327         * DumpRenderTree/efl/EventSender.cpp:
1328         (textZoom):
1329         (pageZoom):
1330         (textZoomInCallback):
1331         (textZoomOutCallback):
1332         (zoomPageInCallback):
1333         (zoomPageOutCallback):
1334
1335 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
1336
1337         KeywordLookupGenerator.py script fails in some cases
1338         https://bugs.webkit.org/show_bug.cgi?id=77886
1339
1340         Reviewed by Benjamin Poulain.
1341
1342         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
1343         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
1344         (GlobalVariablesTest.test_path_rules_specifier):
1345
1346 2012-02-12  Joe Thomas  <joethomas@motorola.com>
1347
1348         Add toText and isTextNode helpers in Text class.
1349         https://bugs.webkit.org/show_bug.cgi?id=78140
1350
1351         Unit test case for the new style checker introduced.
1352
1353         Reviewed by Adam Barth.
1354
1355         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1356         (CppStyleTest):
1357         (CppStyleTest.test_static_cast_readability): Added a unit test case.
1358
1359 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1360
1361         Enable features supported by EFL port in build-webkit.
1362         https://bugs.webkit.org/show_bug.cgi?id=78348
1363
1364         Reviewed by Ryosuke Niwa.
1365
1366         Sync build-webkit with OptionEfl.cmake, as some features enabled in
1367         OptionEfl.cmake are not enabled in build-webkit.
1368
1369         * Scripts/build-webkit:
1370
1371 2012-02-12  Joe Thomas  <joethomas@motorola.com>
1372
1373         Add toText and isTextNode helpers in Text class.
1374         https://bugs.webkit.org/show_bug.cgi?id=78140
1375
1376         Added a style checker to use toText rather than static_cast<Text*>.
1377
1378         Reviewed by Adam Barth.
1379
1380         * Scripts/webkitpy/style/checkers/cpp.py:
1381         (check_language): Style checker for static_cast<Text*>.
1382
1383 2012-02-12  Philippe Normand  <pnormand@igalia.com>
1384
1385         Unreviewed, disable Mutation observers build on GTK until it can
1386         actually build.
1387
1388         * Scripts/build-webkit:
1389
1390 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
1391
1392         Add back WTFURL to WebKit
1393         https://bugs.webkit.org/show_bug.cgi?id=77291
1394
1395         Reviewed by Adam Barth.
1396
1397         Add a flag to build-webkit to easily build WebKit with WTFURL.
1398
1399         * Scripts/build-webkit:
1400
1401 2012-02-10  Adam Klein  <adamk@chromium.org>
1402
1403         Enable MUTATION_OBSERVERS by default on all platforms
1404         https://bugs.webkit.org/show_bug.cgi?id=78196
1405
1406         Reviewed by Ojan Vafai.
1407
1408         * Scripts/build-webkit:
1409
1410 2012-02-10  Adam Barth  <abarth@webkit.org>
1411
1412         Move garden-o-matic's All Failures out of experimental
1413         https://bugs.webkit.org/show_bug.cgi?id=78395
1414
1415         Reviewed by Dimitri Glazkov.
1416
1417         Several folks have tried this feature and found it useful.
1418
1419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1420
1421 2012-02-10  Tim Horton  <timothy_horton@apple.com>
1422
1423         NRWT should categorize options in --help
1424         https://bugs.webkit.org/show_bug.cgi?id=76221
1425
1426         Reviewed by Eric Seidel.
1427         
1428         Use optparse's OptionGroup mechanism to logically group NRWT's options,
1429         providing a better experience when scanning all the options.
1430
1431         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1432         (parse_args):
1433
1434 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1435
1436         [Qt][WK2] Refactor on Qt5 Layout tests' structure
1437         https://bugs.webkit.org/show_bug.cgi?id=77450
1438
1439         Reviewed by Csaba Osztrogonác.
1440
1441         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
1442         to qt-5.0-wk2 and qt-5.0-wk1.
1443
1444         * Scripts/old-run-webkit-tests:
1445         (buildPlatformResultHierarchy):
1446         (readSkippedFiles):
1447         * Scripts/webkitpy/layout_tests/port/qt.py:
1448         (QtPort._wk2_port_name):
1449         (QtPort._skipped_file_search_paths):
1450         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1451         (QtPortTest.test_baseline_search_path):
1452         * Scripts/webkitpy/layout_tests/port/webkit.py:
1453         (WebKitPort._wk2_port_name):
1454
1455 2012-02-09  Philippe Normand  <pnormand@igalia.com>
1456
1457         [GTK] EWS command-line option to run the tests
1458         https://bugs.webkit.org/show_bug.cgi?id=78211
1459
1460         Reviewed by Adam Barth.
1461
1462         New --run-tests option (defaults to False) for the EWS commands.
1463
1464         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1465         (AbstractEarlyWarningSystem):
1466         (AbstractEarlyWarningSystem.__init__):
1467         (AbstractEarlyWarningSystem.review_patch):
1468         (ChromiumLinuxEWS):
1469         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1470         (EarlyWarningSytemTest._test_builder_ews):
1471
1472 2012-02-09  Eric Seidel  <eric@webkit.org>
1473
1474         Rename compare_text and compare_audio to make it clear that they're !=
1475         https://bugs.webkit.org/show_bug.cgi?id=78301
1476
1477         Reviewed by Adam Barth.
1478
1479         I also removed the maybe_create_directory function which was redundant.
1480
1481         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1482         (Manager.set_up_run):
1483         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1484         (TestResultWriter._make_output_directory):
1485         * Scripts/webkitpy/layout_tests/port/base.py:
1486         (Port.do_text_results_differ):
1487         (Port.do_audio_results_differ):
1488         (Port.diff_text):
1489         (Port.driver_name):
1490         (Port.skips_perf_test):
1491         * Scripts/webkitpy/layout_tests/port/win.py:
1492         (WinPort.do_text_results_differ):
1493         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1494         (WinPortTest.test_do_text_results_differ):
1495         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1496         (LayoutTestApacheHttpd.__init__):
1497         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1498         (HttpServerBase.__init__):
1499         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1500         (Rebaseliner._diff_baselines):
1501
1502 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
1503
1504         [GTK] Add DRT support for modal dialogs
1505         https://bugs.webkit.org/show_bug.cgi?id=53600
1506
1507         Reviewed by Martin Robinson.
1508
1509         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
1510         Most significantly, when creating a new web view in GtkLauncher, the window
1511         of the web view opener is passed around. In DumpRenderTree, the window of
1512         the main web view is always considered as the opener. This is required so
1513         the modal dialog's toplevel can be made transient for the opener's toplevel.
1514
1515         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1516         (webViewRunModalDialog):
1517         (createWebView):
1518         * GtkLauncher/main.c:
1519         (createWebViewCb):
1520         (runModalDialogCb):
1521         (createBrowser):
1522         (createWindow):
1523         (main):
1524
1525 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
1526
1527         [Gtk] security/set-form-autocomplete-attribute.html fails
1528         https://bugs.webkit.org/show_bug.cgi?id=78261
1529
1530         Reviewed by Martin Robinson.
1531
1532         Use the new helper in DumpRenderTreeSupportGtk to properly
1533         test whether an element performs autocompletion.
1534
1535         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1536         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
1537
1538 2012-02-09  James Robinson  <jamesr@chromium.org>
1539
1540         [chromium] Enable mock scrollbars for compositing layout tests
1541         https://bugs.webkit.org/show_bug.cgi?id=78299
1542
1543         Reviewed by Dirk Pranke.
1544
1545         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
1546         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
1547         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
1548
1549         * DumpRenderTree/chromium/TestShell.cpp:
1550         (TestShell::runFileTest):
1551         * DumpRenderTree/chromium/WebPreferences.cpp:
1552         (WebPreferences::reset):
1553         (WebPreferences::applyTo):
1554         * DumpRenderTree/chromium/WebPreferences.h:
1555         (WebPreferences):
1556
1557 2012-02-09  Eric Seidel  <eric@webkit.org>
1558
1559         Remove more uses of "os" from our webkitpy code
1560         https://bugs.webkit.org/show_bug.cgi?id=78292
1561
1562         Reviewed by Adam Barth.
1563
1564         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1565         (MockCheckout.__init__):
1566         (MockCheckout.is_path_to_changelog):
1567         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1568         * Scripts/webkitpy/common/system/filesystem_mock.py:
1569         (MockFileSystem._split):
1570         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1571         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1572         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1573         * Scripts/webkitpy/layout_tests/port/webkit.py:
1574         * Scripts/webkitpy/tool/bot/queueengine.py:
1575         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1576         * Scripts/webkitpy/tool/commands/download.py:
1577         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1578         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1579         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1580         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1581         * Scripts/webkitpy/tool/commands/upload.py:
1582         (CreateBug.prompt_for_bug_title_and_comment):
1583         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1584         * Scripts/webkitpy/tool/steps/attachtobug.py:
1585         (AttachToBug.run):
1586         * Scripts/webkitpy/tool/steps/checkstyle.py:
1587         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1588         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1589         * Scripts/webkitpy/tool/steps/editchangelog.py:
1590         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1591         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1592         (PrepareChangeLogTest.test_ensure_bug_url):
1593         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1594         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1595         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1596         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1597
1598 2012-02-09  Eric Seidel  <eric@webkit.org>
1599
1600         Remove the cr-mac-ews (it's long been dead)
1601         https://bugs.webkit.org/show_bug.cgi?id=78267
1602
1603         Reviewed by Adam Barth.
1604
1605         * QueueStatusServer/model/queues.py:
1606         (Queue):
1607         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1608         (ChromiumWindowsEWS):
1609         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1610         (EarlyWarningSytemTest._test_builder_ews):
1611         (EarlyWarningSytemTest._test_testing_ews):
1612
1613 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
1614
1615         some tests in webkitpy are being run three times
1616         https://bugs.webkit.org/show_bug.cgi?id=78283
1617
1618         Reviewed by Ryosuke Niwa.
1619
1620         It turns out that if you import a class derived from
1621         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
1622         the unittest framework treats it as if the class was defined in
1623         the file (as well in the original file). This led us to running
1624         the tests in ChangeLogTest three times.
1625
1626         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1627         (PrepareChangeLogTest):
1628         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1629         (_assert_message_for_revert_output):
1630
1631 2012-02-09  Adam Barth  <abarth@webkit.org>
1632
1633         Remove extraneous line in previous patch.  I forgot to remove this
1634         before landing.
1635
1636         * Scripts/webkitpy/layout_tests/port/driver.py:
1637         (DriverProxy.start):
1638
1639 2012-02-09  Adam Barth  <abarth@webkit.org>
1640
1641         run-perf-tests should have an option to pause before running tests so we can attach Instruments
1642         https://bugs.webkit.org/show_bug.cgi?id=78271
1643
1644         Reviewed by Ryosuke Niwa.
1645
1646         This lets me attach instruments to profile the performance of the test.
1647
1648         * Scripts/webkitpy/layout_tests/port/chromium.py:
1649         (ChromiumDriver.start):
1650         * Scripts/webkitpy/layout_tests/port/driver.py:
1651         (Driver.start):
1652         (DriverProxy.start):
1653         * Scripts/webkitpy/layout_tests/port/server_process.py:
1654         (ServerProcess.start):
1655         * Scripts/webkitpy/layout_tests/port/test.py:
1656         (TestDriver.start):
1657         * Scripts/webkitpy/layout_tests/port/webkit.py:
1658         (WebKitDriver.start):
1659         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1660         (get_tests_run.RecordingTestDriver.start):
1661         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1662         (PerfTestsRunner._parse_args):
1663         (PerfTestsRunner._run_tests_set):
1664         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1665         (start):
1666         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1667         (test_run_test_set_kills_drt_per_run):
1668         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
1669         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
1670
1671 2012-02-09  Adam Barth  <abarth@webkit.org>
1672
1673         run-perf-tests --chromium should run the chromium port
1674         https://bugs.webkit.org/show_bug.cgi?id=78266
1675
1676         Reviewed by Ryosuke Niwa.
1677
1678         This patch makes run-perf-tests work more like run-webkit-tests.
1679
1680         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1681         (PerfTestsRunner._parse_args):
1682
1683 2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1684
1685         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
1686         https://bugs.webkit.org/show_bug.cgi?id=77466
1687
1688         Reviewed by Dirk Pranke.
1689
1690         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
1691         is set or if we should raise an error. A unit test was added.
1692
1693         * Scripts/webkitpy/layout_tests/port/qt.py:
1694         (QtPort.operating_system):
1695         (QtPort):
1696         (QtPort.check_sys_deps):
1697         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1698         (QtPortTest.test_operating_system):
1699         (QtPortTest):
1700         (QtPortTest.test_check_sys_deps):
1701
1702 2012-02-09  Eric Seidel  <eric@webkit.org>
1703
1704         Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
1705         https://bugs.webkit.org/show_bug.cgi?id=78263
1706
1707         Reviewed by Adam Barth.
1708
1709         * Scripts/webkitpy/common/config/ports.py:
1710         (DeprecatedPort):
1711         (DeprecatedPort.name):
1712         (DeprecatedPort.flag):
1713         (DeprecatedPort.script_path):
1714         (DeprecatedPort.script_shell_command):
1715         (DeprecatedPort.port):
1716         (DeprecatedPort.makeArgs):
1717         (DeprecatedPort.update_webkit_command):
1718         (DeprecatedPort.check_webkit_style_command):
1719         (DeprecatedPort.prepare_changelog_command):
1720         (DeprecatedPort.build_webkit_command):
1721         (DeprecatedPort.run_javascriptcore_tests_command):
1722         (DeprecatedPort.run_webkit_unit_tests_command):
1723         (DeprecatedPort.run_webkit_tests_command):
1724         (DeprecatedPort.run_python_unittests_command):
1725         (DeprecatedPort.run_perl_unittests_command):
1726         (DeprecatedPort.layout_tests_results_path):
1727         (MacPort):
1728         (WinPort):
1729         (GtkPort):
1730         (GtkPort.build_webkit_command):
1731         (GtkPort.run_webkit_tests_command):
1732         (QtPort):
1733         (QtPort.build_webkit_command):
1734         (EflPort):
1735         (EflPort.build_webkit_command):
1736         (ChromiumPort):
1737         (ChromiumPort.update_webkit_command):
1738         (ChromiumPort.build_webkit_command):
1739         (ChromiumPort.run_webkit_tests_command):
1740         (ChromiumPort.run_javascriptcore_tests_command):
1741         (ChromiumXVFBPort):
1742         (ChromiumXVFBPort.run_webkit_tests_command):
1743         * Scripts/webkitpy/common/config/ports_unittest.py:
1744         (DeprecatedPortTest):
1745         (DeprecatedPortTest.test_mac_port):
1746         (DeprecatedPortTest.test_gtk_port):
1747         (DeprecatedPortTest.test_qt_port):
1748         (DeprecatedPortTest.test_chromium_port):
1749         (DeprecatedPortTest.test_chromium_xvfb_port):
1750         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1751         (AbstractEarlyWarningSystem.__init__):
1752         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1753         * Scripts/webkitpy/tool/main.py:
1754         (WebKitPatch):
1755         (WebKitPatch.handle_global_options):
1756         * Scripts/webkitpy/tool/steps/abstractstep.py:
1757         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1758         (StepsTest.test_runtests_args):
1759
1760 2012-02-09  Jochen Eisinger  <jochen@chromium.org>
1761
1762         [chromium] always initialize makeArgs in buildChromiumNinja
1763         https://bugs.webkit.org/show_bug.cgi?id=78231
1764
1765         Reviewed by Tony Gentilcore.
1766
1767         * Scripts/webkitdirs.pm:
1768         (buildChromiumNinja):
1769
1770 2012-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1771
1772         [GTK] Show url of current hovered link in MiniBrowser
1773         https://bugs.webkit.org/show_bug.cgi?id=78098
1774
1775         Reviewed by Martin Robinson.
1776
1777         * MiniBrowser/gtk/BrowserWindow.c:
1778         (webViewMouseTargetChanged): Check whether hit test result is a
1779         link and use the url to update the status bar text.
1780         (browserWindowConstructed): Connect to
1781         WebKitWebView::mouse-target-changed signal.
1782
1783 2012-02-09  Rob Buis  <rbuis@rim.com>
1784
1785         [BlackBerry] Upstream DumpRenderTreeBlackBerry
1786         https://bugs.webkit.org/show_bug.cgi?id=78042
1787
1788         Reviewed by Antonio Gomes.
1789
1790         Upstream final part of our DRT implementation.
1791
1792         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
1793         * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
1794         * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
1795         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
1796         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
1797
1798 2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>
1799
1800         kill-old-processes should kill gcc and clang
1801         https://bugs.webkit.org/show_bug.cgi?id=78189
1802
1803         Reviewed by Eric Seidel.
1804
1805         Added a bunch of processes names of gcc and clang to the list.
1806
1807         * BuildSlaveSupport/kill-old-processes:
1808
1809 2012-02-07  MORITA Hajime  <morrita@google.com>
1810
1811         Replacement text should be available from the marker.
1812         https://bugs.webkit.org/show_bug.cgi?id=77934
1813
1814         Made the mock requestCheckingOfText() implementation to return
1815         a replacement text for each misspelled word if available.
1816
1817         Reviewed by Kent Tamura.
1818
1819         * DumpRenderTree/chromium/WebViewHost.cpp:
1820         (WebViewHost::finishLastTextCheck):
1821
1822 2012-02-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1823
1824         [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
1825         https://bugs.webkit.org/show_bug.cgi?id=78146
1826
1827         Reviewed by Ryosuke Niwa.
1828
1829         Our DumpRenderTree should support --no-timeout and --timeout options in order
1830         to be able to use run-perf-tests and have a Performance Bot.
1831         This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
1832         and the necessary code to handle such command line arguments to our DumpRenderTree.
1833
1834         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1835         (WebCore::DumpRenderTree::setTimeout):
1836         (WebCore):
1837         (WebCore::DumpRenderTree::setShouldTimeout):
1838         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1839         (DumpRenderTree):
1840         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1841         (LayoutTestController::LayoutTestController):
1842         (LayoutTestController::waitUntilDone):
1843         (LayoutTestController::notifyDone):
1844         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1845         (LayoutTestController::setTimeout):
1846         (LayoutTestController::setShouldTimeout):
1847         (LayoutTestController):
1848         * DumpRenderTree/qt/main.cpp:
1849         (isOption):
1850         (printUsage):
1851         (main):
1852
1853 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1854
1855         Rubber-stamped by Martin Robinson.
1856
1857         * gtk/common.py:
1858         (get_build_path): Move test for current directory being a valid
1859         directory up so it takes precedence over WebKitBuild/Release and
1860         WebKitBuild/Debug when they exist as well.
1861
1862 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1863
1864         [GTK] doc rebasing does not respect DESTDIR
1865         https://bugs.webkit.org/show_bug.cgi?id=78177
1866
1867         Reviewed by Martin Robinson.
1868
1869         * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
1870         calling it for rebasing.
1871         * gtk/generate-gtkdoc:
1872         (get_common_options): Handle the new --virtual-root option.
1873         * gtk/gtkdoc.py:
1874         (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
1875         it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
1876
1877 2012-02-08  Adam Barth  <abarth@webkit.org>
1878
1879         Remove Python 2.5 support from WebKit
1880         https://bugs.webkit.org/show_bug.cgi?id=71593
1881
1882         Reviewed by Eric Seidel.
1883
1884         This is the last vestige of our Python 2.5 support.
1885
1886         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1887         (AbstractQueueTest.test_log_from_script_error_for_upload):
1888
1889 2012-02-08  Adam Barth  <abarth@webkit.org>
1890
1891         version_check.py should inform users that we don't support Python 2.5 anymore
1892         https://bugs.webkit.org/show_bug.cgi?id=78179
1893
1894         Reviewed by Eric Seidel.
1895
1896         We don't support Python 2.5 anymore.
1897
1898         * Scripts/webkitpy/common/version_check.py:
1899
1900 2012-02-08  Adam Barth  <abarth@webkit.org>
1901
1902         test_configuration.py shouldn't re-implement itertools
1903         https://bugs.webkit.org/show_bug.cgi?id=78178
1904
1905         Reviewed by Eric Seidel.
1906
1907         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1908         (TestConfigurationConverter.to_specifiers_list):
1909         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1910         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1911         (TestConfigurationConverter):
1912
1913 2012-02-08  Adam Barth  <abarth@webkit.org>
1914
1915         webkitpy should reply upon the multiprocessing package existing
1916         https://bugs.webkit.org/show_bug.cgi?id=78176
1917
1918         Reviewed by Eric Seidel.
1919
1920         Now that we don't support Python 2.5, this import can't fail.
1921
1922         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1923         (get):
1924         (_Process):
1925         (_Process.__init__):
1926         (_Process.run):
1927         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1928         (FunctionTests.test_get__processes):
1929         (MultiProcessBrokerTests.setUp):
1930         * Scripts/webkitpy/layout_tests/port/base.py:
1931         (Port.__init__):
1932         (Port.default_worker_model):
1933         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1934         (ChromiumMacPort.check_build):
1935         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1936         (PortTestCase.test_default_worker_model):
1937         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1938
1939 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1940
1941         Unreviewed typo fix that makes docs build again for the gtk2-based
1942         library.
1943
1944         * gtk/generate-gtkdoc:
1945
1946 2012-02-08  Adam Barth  <abarth@webkit.org>
1947
1948         Don't re-implement ZipFile.extractall
1949         https://bugs.webkit.org/show_bug.cgi?id=78173
1950
1951         Reviewed by Eric Seidel.
1952
1953         We can use ZipFile.extractall now that we don't support Python 2.5.
1954
1955         * Scripts/webkitpy/common/system/autoinstall.py:
1956         (AutoInstaller._extract_targz):
1957         (AutoInstaller._unzip):
1958
1959 2012-02-08  Adam Barth  <abarth@webkit.org>
1960
1961         Remove the ospath compat shim from webkitpy
1962         https://bugs.webkit.org/show_bug.cgi?id=78170
1963
1964         Reviewed by Eric Seidel.
1965
1966         We no longer need this compat shim now that we don't support Python 2.5.
1967
1968         * Scripts/webkitpy/common/checkout/scm/git.py:
1969         * Scripts/webkitpy/common/checkout/scm/svn.py:
1970         * Scripts/webkitpy/common/system/filesystem.py:
1971         (FileSystem.relpath):
1972         * Scripts/webkitpy/common/system/filesystem_mock.py:
1973         (MockFileSystem.relpath):
1974         * Scripts/webkitpy/common/system/ospath.py: Removed.
1975         * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
1976
1977 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
1978
1979         Build fix attempt after r107053.
1980
1981         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1982         (test_collect_tests):
1983
1984 2012-02-08  Adam Barth  <abarth@webkit.org>
1985
1986         Remove simplejson because it's no longer used by webkitpy
1987         https://bugs.webkit.org/show_bug.cgi?id=78164
1988
1989         Reviewed by Eric Seidel.
1990
1991         All the importers of this code were removed in a previous patch.
1992
1993         * Scripts/webkitpy/thirdparty/simplejson: Removed.
1994         * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
1995         * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
1996         * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
1997         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
1998         * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
1999         * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
2000         * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
2001         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
2002         * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
2003         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
2004
2005 2012-02-08  Adam Barth  <abarth@webkit.org>
2006
2007         webkitpy still imports simplejson
2008         https://bugs.webkit.org/show_bug.cgi?id=78161
2009
2010         Reviewed by Eric Seidel.
2011
2012         We no longer support Python 2.5, so we can rely upon Python's built-in
2013         JSON package.
2014
2015         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2016         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2017         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
2018         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2019         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2020         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2021         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2022         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2023         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2024         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2025         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2026
2027 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2028
2029         [GTK] Fails to build docs with non-standard build directories
2030         https://bugs.webkit.org/show_bug.cgi?id=78118
2031
2032         * gtk/common.py:
2033         (get_build_path): add comment to document changes done in r107098,
2034         as requested by the reviewer and forgotten by me.
2035
2036 2012-02-08  Adam Barth  <abarth@webkit.org>
2037
2038         Stop importing with_statement from the mysterious future
2039         https://bugs.webkit.org/show_bug.cgi?id=78156
2040
2041         Reviewed by Eric Seidel.
2042
2043         The future is now!  (Well, at least 2008, when Python 2.6 was released,
2044         is no longer the __future__.)
2045
2046         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2047         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2048         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2049         * Scripts/webkitpy/common/net/credentials_unittest.py:
2050         * Scripts/webkitpy/common/net/file_uploader.py:
2051         * Scripts/webkitpy/common/newstringio_unittest.py:
2052         * Scripts/webkitpy/common/system/autoinstall.py:
2053         * Scripts/webkitpy/common/system/crashlogs.py:
2054         * Scripts/webkitpy/common/system/fileset.py:
2055         * Scripts/webkitpy/common/system/filesystem.py:
2056         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2057         * Scripts/webkitpy/common/system/path.py:
2058         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
2059         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2060         * Scripts/webkitpy/layout_tests/port/base.py:
2061         (of):
2062         * Scripts/webkitpy/layout_tests/port/gtk.py:
2063         * Scripts/webkitpy/layout_tests/port/test.py:
2064         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2065         * Scripts/webkitpy/style/filereader_unittest.py:
2066         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2067         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2068         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2069         * Scripts/webkitpy/tool/commands/queues.py:
2070         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2071         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2072
2073 2012-02-08  Rob Buis  <rbuis@rim.com>
2074
2075         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2076         https://bugs.webkit.org/show_bug.cgi?id=78042
2077
2078         Reviewed by Antonio Gomes.
2079
2080         Upstream more parts of our DRT implementation.
2081
2082         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
2083         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
2084         * DumpRenderTree/blackberry/EventSender.cpp: Added.
2085         * DumpRenderTree/blackberry/EventSender.h: Added.
2086         * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
2087         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
2088
2089 2012-02-08  Dirk Pranke  <dpranke@chromium.org>
2090
2091         check-webkit-style failing with "Path does not exist."
2092         https://bugs.webkit.org/show_bug.cgi?id=77873
2093
2094         Reviewed by Ojan Vafai.
2095
2096         This change fixes the way the style checker determines which
2097         Port class to use for a given test_expectations.txt path; the
2098         previous version used a heuristic that didn't really work in the
2099         first place.
2100
2101         * Scripts/webkitpy/style/checkers/test_expectations.py:
2102         (TestExpectationsChecker._determine_port_from_expectations_path):
2103         (TestExpectationsChecker.__init__):
2104         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2105         (TestExpectationsTestCase._expect_port_for_expectations_path):
2106         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2107
2108 2012-02-08  Fehér Zsolt  <feherzs@inf.u-szeged.hu>
2109
2110         nrwt: make --skip-pixel-test-if-no-baseline option
2111         https://bugs.webkit.org/show_bug.cgi?id=70484
2112
2113         Reviewed by Dirk Pranke.
2114
2115         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2116         (SingleTestRunner.__init__):
2117         (SingleTestRunner._should_fetch_expected_checksum):
2118         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2119         (Worker.handle_test_list):
2120         * Scripts/webkitpy/layout_tests/models/test_input.py:
2121         (TestInput.__init__):
2122         * Scripts/webkitpy/layout_tests/port/webkit.py:
2123         (WebKitDriver.cmd_line):
2124         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2125         (_set_up_derived_options):
2126         (parse_args):
2127         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2128         (MainTest.test_skip_pixel_test_if_no_baseline_option):
2129         * WebKitTestRunner/TestController.cpp:
2130         (WTR::TestController::TestController):
2131         (WTR::TestController::initialize):
2132         (WTR::TestController::runTest):
2133         * WebKitTestRunner/TestController.h:
2134         (TestController):
2135         * WebKitTestRunner/TestInvocation.cpp:
2136         (WTR::TestInvocation::TestInvocation):
2137         (WTR::TestInvocation::setIsPixelTest):
2138         * WebKitTestRunner/TestInvocation.h:
2139         (WTR::TestInvocation::setSkipPixelTestOption):
2140         (TestInvocation):
2141
2142 2012-02-08  Rob Buis  <rbuis@rim.com>
2143
2144         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2145         https://bugs.webkit.org/show_bug.cgi?id=78042
2146
2147         Reviewed by Antonio Gomes.
2148
2149         Add implementation for our DumpRenderTree solution.
2150
2151         * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
2152         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
2153
2154 2012-02-08  Antti Koivisto  <antti@apple.com>
2155
2156         REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
2157         https://bugs.webkit.org/show_bug.cgi?id=78080
2158
2159         Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
2160         
2161         Add API test.
2162
2163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2164         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
2165         (TestWebKitAPI):
2166         (TestWebKitAPI::TEST):
2167
2168 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2169
2170         [GTK] Fails to build docs with non-standard build directories
2171         https://bugs.webkit.org/show_bug.cgi?id=78118
2172
2173         Reviewed by Martin Robinson.
2174
2175         * gtk/common.py:
2176         (get_build_path): also try the current directory as a valid build
2177         dir, which makes non-standard build directories such as build-2.0
2178         and build-3.0 work
2179
2180 2012-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2181
2182         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
2183         https://bugs.webkit.org/show_bug.cgi?id=78099
2184
2185         Reviewed by Martin Robinson.
2186
2187         * MiniBrowser/gtk/BrowserWindow.c:
2188         (webViewDecidePolicy): Check whether it's a link clicked with the
2189         middle mouse button and load the request in a new window.
2190         (browserWindowConstructed): Connect to
2191         WebKitWebView::decide-policy signal.
2192
2193 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2194
2195         Revert a part of the change in r106687 as a build fix.
2196
2197         Since Chromium port doesn't checkout the entire WebKit trunk,
2198         we can't run "svn info" on webkit_base.
2199
2200         * Scripts/webkitpy/layout_tests/port/base.py:
2201         (Port.repository_paths):
2202
2203 2012-02-07  Ryosuke Niwa  <rniwa@webkit.org>
2204
2205         run-perf-tests doesn't recognize paths that start with PerformanceTests
2206         https://bugs.webkit.org/show_bug.cgi?id=78012
2207
2208         Reviewed by Adam Barth.
2209
2210         Use resolve paths using filesystem.relpath before passing it to find_files.find.
2211
2212         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2213         (PerfTestsRunner):
2214         (PerfTestsRunner._collect_tests):
2215         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2216         (test_collect_tests):
2217         (test_collect_tests.add_file):
2218
2219 2012-02-07  Justin Novosad  <junov@chromium.org>
2220
2221         [Chromium] add option for 2d canvas defered rendering to DumpRenderTree
2222         https://bugs.webkit.org/show_bug.cgi?id=78039
2223
2224         Reviewed by Stephen White.
2225
2226         Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
2227
2228         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2229         (main):
2230         * DumpRenderTree/chromium/TestShell.cpp:
2231         (TestShell::TestShell):
2232         (TestShell::resetWebSettings):
2233         (TestShell::runFileTest):
2234         * DumpRenderTree/chromium/TestShell.h:
2235         (TestShell::setDeferred2dCanvasEnabled):
2236         (TestShell):
2237         * DumpRenderTree/chromium/WebPreferences.cpp:
2238         (WebPreferences::reset):
2239         (WebPreferences::applyTo):
2240         * DumpRenderTree/chromium/WebPreferences.h:
2241         (WebPreferences):
2242
2243 2012-02-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2244
2245         [CMAKE] Use *bin* and *lib* directories for executable and libraries.
2246         https://bugs.webkit.org/show_bug.cgi?id=77928
2247
2248         Reviewed by Daniel Bates.
2249
2250         CMake has used *Programs* directory for executable. In addition, shared libraries are being
2251         built in source directory. It is better to set common places in order to maintain executable
2252         and libraries. *bin* is for executable and *lib* is for library.
2253
2254         * DumpRenderTree/efl/CMakeLists.txt:
2255         * EWebLauncher/CMakeLists.txt:
2256         * Scripts/run-launcher:
2257         * Scripts/webkitdirs.pm:
2258         (jscProductDir):
2259         * Scripts/webkitpy/layout_tests/port/efl.py:
2260         (EflPort._path_to_driver):
2261         (EflPort._path_to_image_diff):
2262
2263 2012-02-07  Adam Klein  <adamk@chromium.org>
2264
2265         Add JSC support for delivering mutations when the outermost script context exits
2266         https://bugs.webkit.org/show_bug.cgi?id=70289
2267
2268         Reviewed by Eric Seidel.
2269
2270         * DumpRenderTree/mac/EventSendingController.mm: Add support for
2271         eventSender.scheduleAsynchronousKeyDown.
2272         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2273         (+[EventSendingController webScriptNameForSelector:]):
2274         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
2275         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
2276         * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
2277
2278 2012-02-07  Chris Rogers  <crogers@google.com>
2279
2280         Add Chris Rogers to reviewers section
2281         https://bugs.webkit.org/show_bug.cgi?id=78016
2282
2283         Reviewed by Adam Barth.
2284
2285         * Scripts/webkitpy/common/config/committers.py:
2286
2287 2012-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>
2288
2289         layoutTestController.display() is flaky for SVG tests
2290         https://bugs.webkit.org/show_bug.cgi?id=78021
2291
2292         Reviewed by Dan Bernstein.
2293
2294         Fix race condition in repaint rect tracking. When running a test using the repaint.js
2295         harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
2296         the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
2297         hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
2298         svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
2299         the repaint test already run, thus invalidating the previously tracked repaint rects.
2300
2301         * DumpRenderTree/mac/DumpRenderTree.mm:
2302         (dump):
2303         (runTest):
2304
2305 2012-02-07  Hans Wennborg  <hans@chromium.org>
2306
2307         Chromium: remove WebSpeechInputResult::set
2308         https://bugs.webkit.org/show_bug.cgi?id=77977
2309
2310         Reviewed by Darin Fisher.
2311
2312         It was renamed to assign() in r106475.
2313
2314         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2315         (makeRectResult):
2316
2317 2012-02-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2318
2319         [Qt] Give emulated touch-point a radius
2320         https://bugs.webkit.org/show_bug.cgi?id=77985
2321         
2322         Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
2323
2324         Reviewed by Kenneth Rohde Christiansen.
2325
2326         * MiniBrowser/qt/BrowserWindow.cpp:
2327         (BrowserWindow::updateVisualMockTouchPoints):
2328         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2329         (MiniBrowserApplication::notify):
2330         * MiniBrowser/qt/qml/MockTouchPoint.qml:
2331
2332 2012-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
2333
2334         [GTK] Include gdk-pixbuf in the jhbuild modules
2335         https://bugs.webkit.org/show_bug.cgi?id=77980
2336
2337         Reviewed by Gustavo Noronha Silva.
2338
2339         * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
2340
2341 2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
2342
2343         [Qt] Prevent early test termination with newer Qt 5
2344         https://bugs.webkit.org/show_bug.cgi?id=77945
2345
2346         Reviewed by Csaba Osztrogonác.
2347
2348         QTBUG-24120 tracks a regression in Qt that would make layout tests
2349         terminate early. This patch works around it in a Qt 4 + 5 safe manner
2350         by disabling the quitOnLastWindowClosed feature, which we don't want/need
2351         for DRT anyway.
2352
2353         * DumpRenderTree/qt/main.cpp:
2354         (main): Don't quit on last window closed.
2355
2356 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
2357
2358         Fix some miscellaneous 'make dist' error for WebKitGTK+.
2359
2360         * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
2361         files should not be distributed.
2362
2363 2012-02-02  Hajime Morrita  <morrita@chromium.org>
2364
2365         [PerformanceTests] Each Dromaeo test needs its landing html.
2366         https://bugs.webkit.org/show_bug.cgi?id=77504
2367
2368         Reviewed by Ryosuke Niwa.
2369
2370         Added an ignorable pattern which happens in some Dromaeo tests.
2371
2372         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2373         (PerfTestsRunner):
2374
2375 2012-02-06  Kalev Lember  <kalevlember@gmail.com>
2376
2377         [GTK] Add missing pango include dir to fix build
2378         https://bugs.webkit.org/show_bug.cgi?id=77832
2379
2380         Reviewed by Martin Robinson.
2381
2382         * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
2383
2384 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
2385
2386         [GTK] Fix remaining errors in GTK+ WebKit2 API
2387         https://bugs.webkit.org/show_bug.cgi?id=77890
2388
2389         Reviewed by Gustavo Noronha Silva.
2390
2391         Verify that WebKit2 GTK+ test files are not skipped during style checks.
2392         Skip soup_server_new when checking for NULL versus 0 usage.
2393
2394         * Scripts/webkitpy/style/checker_unittest.py:
2395         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
2396         * Scripts/webkitpy/style/checkers/cpp.py:
2397         (check_for_null):
2398
2399 2012-02-06  Eric Seidel  <eric@webkit.org>
2400
2401         webkit-patch apply-from-bug should be able to apply non-reviewed patches
2402         https://bugs.webkit.org/show_bug.cgi?id=77883
2403
2404         Reviewed by Adam Barth.
2405
2406         This is very helpful if you use bugzilla as a replacement for git-stash.
2407         Makes it simpler to re-apply the patch w/o having to look up the patch id.
2408
2409         * Scripts/webkitpy/tool/commands/download.py:
2410         (ProcessBugsMixin._fetch_list_of_patches_to_process):
2411         * Scripts/webkitpy/tool/commands/download_unittest.py:
2412         (DownloadCommandsTest.test_apply_from_bug):
2413
2414 2012-02-06  Philippe Normand  <pnormand@igalia.com>
2415
2416         [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
2417         https://bugs.webkit.org/show_bug.cgi?id=77866
2418
2419         Reviewed by Martin Robinson.
2420
2421         * Scripts/webkitpy/style/checker.py: Ignore readability/naming
2422         errors in some gstreamer source code files defining new GStreamer elements.
2423         * Scripts/webkitpy/style/checker_unittest.py:
2424         (GlobalVariablesTest.test_path_rules_specifier):
2425
2426 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2427
2428         [GTK] Make sure html_dir exists before calling gtkdoc-rebase
2429         https://bugs.webkit.org/show_bug.cgi?id=77869
2430
2431         Reviewed by Philippe Normand.
2432
2433         * gtk/gtkdoc.py:
2434         (GTKDoc.rebase_installed_docs): Check html_dir exists.
2435
2436 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2437
2438         [Qt] Don't version QtWebKit.experimental.
2439         https://bugs.webkit.org/show_bug.cgi?id=77739
2440
2441         Reviewed by Tor Arne Vestbø.
2442
2443         * MiniBrowser/qt/qml/BrowserWindow.qml:
2444
2445 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2446
2447         [GTK] Fix several gtkdoc-fixxref warnings
2448         https://bugs.webkit.org/show_bug.cgi?id=77613
2449
2450         Reviewed by Martin Robinson.
2451
2452         * gtk/generate-gtkdoc:
2453         (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
2454         of ignored files, since it's private.
2455         * gtk/gtkdoc.py:
2456         (GTKDoc._ignored_files_basenames): Helper function that returns a
2457         string with the list of ignored files basenames separated by a
2458         spaces, as expected by several gtkdoc commands.
2459         (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
2460         --ignore-headers option.
2461         (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
2462         --ignore-files option.
2463
2464 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2465
2466         [GTK] Fix xrefs after installing API documentation
2467         https://bugs.webkit.org/show_bug.cgi?id=77551
2468
2469         Reviewed by Martin Robinson.
2470
2471         * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
2472         api docs.
2473         * gtk/common.py:
2474         (prefix_of_pkg_config_file): Get the prefix variable of the given
2475         pkg-config file.
2476         (gtk_version_of_pkg_config_file): Get the gtk version required by
2477         the given pkg-config file.
2478         * gtk/generate-gtkdoc: Add --rebase command line option to rebase
2479         installed documentation.
2480         (get_gtkdoc_module_paths): Get paths where API doc is installed
2481         for the dependencies of the given pkg-config file.
2482         (get_common_xref_deps): Get API doc directories of dependencies
2483         common to WebKit1 and WebKit2.
2484         (get_webkit2_options): Add cross_reference_deps option.
2485         (get_webkit1_options): Ditto
2486         (rebase_installed_docs): Helper function to create a generator for
2487         the given pkg-config file and options and call rebase_installed_docs.
2488         * gtk/gtkdoc.py:
2489         (GTKDoc.__init__): Initialize cross_reference_deps.
2490         (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
2491         dependencies.
2492         (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
2493         links of installed documentation.
2494         (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
2495         file.
2496
2497 2012-02-06  Sergio Villar Senin  <svillar@igalia.com>
2498
2499         Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
2500         https://bugs.webkit.org/show_bug.cgi?id=77672
2501
2502         Reviewed by Dirk Pranke.
2503
2504         Test repetitions must be taken into account when working out
2505         the statistics shown by run-webkit-tests.
2506
2507         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2508         (Manager.prepare_lists_and_print_output):
2509         (Manager._print_result_summary):
2510         * Scripts/webkitpy/layout_tests/models/result_summary.py:
2511         (ResultSummary.__init__):
2512         (ResultSummary.add):
2513         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2514         (MainTest.test_repeat_each_iterations_num_tests):
2515
2516 2012-02-05  Dan Bernstein  <mitz@apple.com>
2517
2518         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
2519         https://bugs.webkit.org/show_bug.cgi?id=77823
2520
2521         Reviewed by Anders Carlsson.
2522
2523         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2524         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
2525
2526 2012-02-04  Dan Bernstein  <mitz@apple.com>
2527
2528         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
2529         https://bugs.webkit.org/show_bug.cgi?id=77822
2530
2531         Reviewed by Sam Weinig.
2532
2533         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2534         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
2535
2536 2012-02-04  Sam Weinig  <sam@webkit.org>
2537
2538         Add ability to send WKURLRequests in WebKit2 API user messages
2539         https://bugs.webkit.org/show_bug.cgi?id=77819
2540
2541         Reviewed by Anders Carlsson.
2542
2543         Add testing for round-tripping WKTypes from the UIProcess,
2544         to the WebProcess, and back.
2545
2546         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
2547           More can easily be added.
2548
2549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2550         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
2551         (TestWebKitAPI):
2552         (WebKit2UserMessageRoundTripTest):
2553         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
2554         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
2555         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
2556         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
2557         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
2558         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
2559         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
2560         (TestWebKitAPI::TEST_F):
2561         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
2562         (TestWebKitAPI):
2563         (UserMessageTest):
2564         (TestWebKitAPI::UserMessageTest::UserMessageTest):
2565         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
2566         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2567         (TestWebKitAPI::PlatformWebView::resizeTo):
2568         (TestWebKitAPI):
2569         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2570         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2571
2572 2012-02-04  Dan Bernstein  <mitz@apple.com>
2573
2574         <rdar://problem/10772406> WKPreferences instances cannot be copied
2575         https://bugs.webkit.org/show_bug.cgi?id=77816
2576
2577         Reviewed by Sam Weinig.
2578
2579         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2580         (TestWebKitAPI::TEST):
2581
2582 2012-02-04  Adam Barth  <abarth@webkit.org>
2583
2584         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
2585         https://bugs.webkit.org/show_bug.cgi?id=77802
2586
2587         Reviewed by Eric Seidel.
2588
2589         This patch refactors our directory grouping code into base.js where it
2590         can be shared between failures.js and notifications.js.  It then adds
2591         an Examine action to each group of failures that triggers the "results"
2592         view.
2593
2594         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2598         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2599         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
2600
2601 2012-02-04  Ojan Vafai  <ojan@chromium.org>
2602
2603         check-webkit-style is throwing an exception
2604         https://bugs.webkit.org/show_bug.cgi?id=77744
2605
2606         Reviewed by David Levin.
2607
2608         If the test_list is None, then we don't need to check for unsupported
2609         feature tests to skip.
2610
2611         * Scripts/webkitpy/layout_tests/port/webkit.py:
2612         (WebKitPort._has_test_in_directories):
2613         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2614         (test_skipped_tests_for_unsupported_features_empty_test_list):
2615
2616 2012-02-03  Adam Barth  <abarth@webkit.org>
2617
2618         List of all failures in garden-o-matic should actually list all the failures
2619         https://bugs.webkit.org/show_bug.cgi?id=77796
2620
2621         Reviewed by Eric Seidel.
2622
2623         This patch wires a bit more data into the new "All Failures" tab.  I've
2624         also iterated on how we enable this experimental feature.  The tab is
2625         still just a dumb list, but we'll make it smarter.
2626
2627         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2628         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2629         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2630         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2631
2632 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2633
2634         Windows build fix after r106692.
2635
2636         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2637         (PortTest.test_reference_files):
2638
2639 2012-02-03  Beth Dakin  <bdakin@apple.com>
2640
2641         https://bugs.webkit.org/show_bug.cgi?id=77782
2642         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than 
2643         once on some pages with frames
2644         -and corresponding-
2645         <rdar://problem/10798474>
2646
2647         Reviewed by Sam Weinig.
2648
2649         One new test.
2650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2651         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
2652         (TestWebKitAPI):
2653         (TestWebKitAPI::didForceRepaint):
2654         (TestWebKitAPI::didFinishLoadForFrame):
2655         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2656         (TestWebKitAPI::setPageLoaderClient):
2657         (TestWebKitAPI::TEST):
2658         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
2659         (TestWebKitAPI):
2660         (NewFirstVisuallyNonEmptyLayoutFramesTest):
2661         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
2662         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
2663         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
2664
2665 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
2666
2667         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
2668         https://bugs.webkit.org/show_bug.cgi?id=77781
2669
2670         Reviewed by Eric Seidel.
2671
2672         This change fixes a couple of issues discovered while debugging
2673         test-webkitpy; both calling exit() instead of sys.exit() --
2674         which is discouraged in program code instead of the interpreter
2675         -- and a particular usage of outputcapture were stdin to get whacked
2676         and preventing debugging.
2677        
2678         This change introduces a couple of common _exit() methods that
2679         will standardize how webkit-patch exit's, in case we need to do
2680         something different in the future.
2681
2682         * Scripts/webkitpy/common/system/deprecated_logging.py:
2683         (error):
2684         * Scripts/webkitpy/common/system/outputcapture.py:
2685         (OutputCapture.assert_outputs):
2686         * Scripts/webkitpy/tool/bot/queueengine.py:
2687         (QueueEngine.exit_after_handled_error):
2688         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2689         (AbstractSequencedCommand.execute):
2690         * Scripts/webkitpy/tool/commands/queues.py:
2691         (StyleQueue.handle_script_error):
2692         * Scripts/webkitpy/tool/commands/upload.py:
2693         (MarkBugFixed.execute):
2694         * Scripts/webkitpy/tool/multicommandtool.py:
2695         (Command._exit):
2696         * Scripts/webkitpy/tool/steps/abstractstep.py:
2697         (AbstractStep._exit):
2698         * Scripts/webkitpy/tool/steps/checkstyle.py:
2699         (CheckStyle.run):
2700         * Scripts/webkitpy/tool/steps/commit.py:
2701         (Commit._check_test_expectations):
2702         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2703         (ConfirmDiff.run):
2704
2705 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2706
2707         Perf bot build fix.
2708
2709         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2710         (PerfTestsRunner._generate_json):
2711
2712 2012-02-03  Adam Barth  <abarth@webkit.org>
2713
2714         Add a blank "Expected Failures" tab to garden-o-matic
2715         https://bugs.webkit.org/show_bug.cgi?id=77793
2716
2717         Reviewed by Eric Seidel.
2718
2719         This tab will help us explore and manage our expected failures.  The
2720         tab is hidden by default via a new "experimental features" flag.
2721
2722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2726         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2727         (#unexpected):
2728         (#onebar.partytime #unexpected):
2729
2730 2012-02-03  Lucas Forschler  <lforschler@apple.com>
2731
2732         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
2733         https://bugs.webkit.org/show_bug.cgi?id=77785
2734
2735         Fix the build bots.
2736         
2737         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
2738
2739         * Scripts/update-webkit-support-libs:
2740         (downloadExpectedVersionNumber):
2741
2742 2012-02-03  Lucas Forschler  <lforschler@apple.com>
2743
2744         Add a Mac Lion Performance bot.
2745         https://bugs.webkit.org/show_bug.cgi?id=77765
2746
2747         Reviewed by Adam Roben.
2748
2749         This will update the master configuration in the following ways:
2750             Add a new performance slave (apple-xseve-11)
2751             Add a new Factory to download a build and run perf tests.
2752             
2753         * BuildSlaveSupport/build.webkit.org-config/config.json:
2754         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2755         (DownloadAndPerfTestFactory):
2756         (DownloadAndPerfTestFactory.__init__):
2757
2758 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
2759
2760         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
2761         https://bugs.webkit.org/show_bug.cgi?id=77752
2762
2763         Reviewed by James Robinson.
2764
2765         Delete unneeded file accidentally checked in in r106481.
2766
2767         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
2768
2769 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2770
2771         Ref Tests should support plain SVG files
2772         https://bugs.webkit.org/show_bug.cgi?id=77685
2773
2774         Reviewed by Tony Chang.
2775
2776         Don't assume reference files always use .html as the extension.
2777         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
2778
2779         Also fix various bugs in MockFileSystem and TestPort.
2780
2781         * Scripts/webkitpy/common/system/filesystem_mock.py:
2782         (MockFileSystem.isdir):
2783         * Scripts/webkitpy/layout_tests/port/base.py:
2784         (Port.reference_files):
2785         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2786         (PortTest.test_is_test_file):
2787         (PortTest.test_reference_files):
2788         * Scripts/webkitpy/layout_tests/port/test.py:
2789         (TestInstance.__init__):
2790
2791 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2792
2793         perf-o-matic should store chromium svn revision
2794         https://bugs.webkit.org/show_bug.cgi?id=77725
2795
2796         Reviewed by Dirk Pranke.
2797
2798         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
2799         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
2800         is implemented in terms of newly added svn_revision.
2801
2802         * Scripts/webkitpy/common/checkout/scm/git.py:
2803         (Git.svn_revision):
2804         * Scripts/webkitpy/common/checkout/scm/scm.py:
2805         (SCM.head_svn_revision):
2806         (SCM):
2807         (SCM.svn_revision):
2808         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2809         (MockSCM.svn_revision):
2810         * Scripts/webkitpy/common/checkout/scm/svn.py:
2811         (SVN.svn_revision):
2812         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2813         (JSONLayoutResultsGenerator.__init__):
2814         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2815         (JSONResultsGeneratorBase._insert_generic_metadata):
2816         * Scripts/webkitpy/layout_tests/port/base.py:
2817         (Port.repository_paths):
2818         * Scripts/webkitpy/layout_tests/port/chromium.py:
2819         (ChromiumPort.repository_paths):
2820         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2821         (PerfTestsRunner._generate_json):
2822         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2823         (test_run_test_set_with_json_output):
2824         (test_run_test_set_with_json_source):
2825         (test_run_test_set_with_multiple_repositories):
2826
2827 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2828
2829         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
2830         https://bugs.webkit.org/show_bug.cgi?id=77632
2831
2832         Reviewed by Kenneth Rohde Christiansen.
2833
2834         * MiniBrowser/qt/BrowserWindow.cpp:
2835         (BrowserWindow::BrowserWindow):
2836         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2837         (MiniBrowserApplication::sendTouchEvent):
2838         (MiniBrowserApplication::handleUserOptions):
2839         * MiniBrowser/qt/MiniBrowserApplication.h:
2840         (WindowOptions):
2841         (WindowOptions::WindowOptions):
2842         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2843         (WTR::PlatformWebView::PlatformWebView):
2844         * WebKitTestRunner/qt/main.cpp:
2845         (main):
2846         * qmake/mkspecs/features/default_post.prf:
2847
2848 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
2849
2850         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
2851         https://bugs.webkit.org/show_bug.cgi?id=77723
2852
2853         Reviewed by Tor Arne Vestbø.
2854
2855         * Tools.pro: Compile WTR again on all platforms with WK2.
2856
2857 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
2858
2859         Ensure that inspector disabled build works
2860         https://bugs.webkit.org/show_bug.cgi?id=77604
2861
2862         Reviewed by Tor Arne Vestbø.
2863
2864         * qmake/mkspecs/features/features.prf:
2865
2866 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
2867
2868         [chromium] add support for --makeargs to the ninja-based build
2869         https://bugs.webkit.org/show_bug.cgi?id=77688
2870
2871         Reviewed by Adam Barth.
2872
2873         * Scripts/webkitdirs.pm:
2874         (buildChromiumNinja):
2875
2876 2012-02-02  Eric Seidel  <eric@webkit.org>
2877
2878         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
2879         https://bugs.webkit.org/show_bug.cgi?id=75145
2880
2881         Reviewed by Dirk Pranke.
2882
2883         * Scripts/webkitpy/layout_tests/port/mac.py:
2884         (MacPort.default_child_processes):
2885         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2886         (test_operating_system):
2887         (test_default_child_processes):
2888
2889 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
2890
2891        nrwt shouldn't blow up when there are errors in test_expectations.txt
2892        https://bugs.webkit.org/show_bug.cgi?id=73603
2893
2894        Reviewed by Ojan Vafai.
2895
2896        This change removes the distinction between 'errors' and 'warnings'
2897        in the test expectations parser. Now, any problem is a
2898        'warning', and if we are linting the file, warnings become fatal (errors).
2899
2900         This will allow a normal run-webkit-tests run to proceed even if
2901         there are bad lines.
2902
2903         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2904         (ParseError.__init__):
2905         (ParseError.__str__):
2906         (ParseError.__repr__):
2907         (TestExpectationSerializer.to_string):
2908         (TestExpectationParser._parse_modifiers):
2909         (TestExpectationParser._parse_expectations):
2910         (TestExpectationParser._check_modifiers_against_expectations):
2911         (TestExpectationParser._tokenize):
2912         (TestExpectationLine.__init__):
2913         (TestExpectationLine.is_invalid):
2914         (TestExpectationsModel.add_expectation_line):
2915         (TestExpectationsModel._already_seen_better_match):
2916         (TestExpectations.__init__):
2917         (TestExpectations._report_warnings):
2918         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
2919         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2920         (assert_bad_expectations):
2921         (test_parse_warning):
2922         (test_overrides__duplicate):
2923         (ExpectationSyntaxTests.test_missing_expectation):
2924         (ExpectationSyntaxTests.test_missing_colon):
2925         (ExpectationSyntaxTests.test_too_many_colons):
2926         (ExpectationSyntaxTests.test_too_many_equals_signs):
2927         (ExpectationSyntaxTests.test_unrecognized_expectation):
2928         (SemanticTests.test_bug_format):
2929         (SemanticTests.test_bad_bugid):
2930         (SemanticTests.test_slow_and_timeout):
2931         (test_ambiguous):
2932         (test_more_modifiers):
2933         (test_order_in_file):
2934         (test_macro_overrides):
2935         (RebaseliningTest.assertRemove):
2936         (TestExpectationParserTests.test_tokenize_blank):
2937         (TestExpectationParserTests.test_tokenize_missing_colon):
2938         (TestExpectationParserTests.test_tokenize_extra_colon):
2939         (TestExpectationParserTests.test_tokenize_empty_comment):
2940         (TestExpectationParserTests.test_tokenize_comment):
2941         (TestExpectationParserTests.test_tokenize_missing_equal):
2942         (TestExpectationParserTests.test_tokenize_extra_equal):
2943         (TestExpectationParserTests.test_tokenize_valid):
2944         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2945         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2946         (TestExpectationSerializerTests.test_unparsed_to_string):
2947         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2948         (lint):
2949         * Scripts/webkitpy/style/checkers/test_expectations.py:
2950         (TestExpectationsChecker.check_test_expectations):
2951
2952 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2953
2954         Unreviewed, rolling out r106543.
2955         http://trac.webkit.org/changeset/106543
2956         https://bugs.webkit.org/show_bug.cgi?id=77671
2957
2958         Made tests less stable (Requested by rniwa on #webkit).
2959
2960         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2961         (PerfTestsRunner):
2962         (PerfTestsRunner.__init__):
2963         (PerfTestsRunner._run_tests_set):
2964         (PerfTestsRunner._run_single_test):
2965         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2966         (MainTest.TestDriver.run_test):
2967         (run_test):
2968
2969 2012-02-02  Beth Dakin  <bdakin@apple.com>
2970
2971         https://bugs.webkit.org/show_bug.cgi?id=77664
2972         Add API tests for didNewFirstVisuallyNonEmptyLayout
2973
2974         Reviewed by Darin Adler.
2975
2976         Two new tests.
2977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2978         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
2979         (TestWebKitAPI):
2980         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2981         (TestWebKitAPI::setPageLoaderClient):
2982         (TestWebKitAPI::TEST):
2983         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
2984         (TestWebKitAPI):
2985         (TestWebKitAPI::didForceRepaint):
2986         (TestWebKitAPI::didFinishLoadForFrame):
2987         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2988         (TestWebKitAPI::setPageLoaderClient):
2989         (TestWebKitAPI::TEST):
2990         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
2991         (TestWebKitAPI):
2992         (NewFirstVisuallyNonEmptyLayoutFailsTest):
2993         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
2994         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
2995         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
2996         (TestWebKitAPI):
2997         (NewFirstVisuallyNonEmptyLayoutTest):
2998         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
2999         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
3000
3001 2012-02-02  Michael Saboff  <msaboff@apple.com>
3002
3003         Add Michael Saboff to reviewers list.
3004
3005         Rubber-stamped by Gavin Barraclough.
3006
3007         * Scripts/webkitpy/common/config/committers.py:
3008
3009 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3010
3011         Add myself as a committer
3012
3013         Unreviewed
3014
3015         * Scripts/webkitpy/common/config/committers.py:
3016
3017 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
3018
3019         [PerformanceTests] tests have dependencies
3020         https://bugs.webkit.org/show_bug.cgi?id=77506
3021
3022         Reviewed by Hajime Morita.
3023
3024         Load an initialization page before each test after starting a DRT so that
3025         warming up DRT won't affect the performance test results.
3026
3027         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3028         (PerfTestsRunner):
3029         (PerfTestsRunner.__init__):
3030         (PerfTestsRunner._run_tests_set):
3031         (PerfTestsRunner._run_single_test):
3032         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3033         (MainTest.TestDriver.run_test):
3034         (test_initial_page_loaded):
3035         (test_initial_page_loaded.run_test):
3036
3037 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
3038
3039         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
3040
3041         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3042         (PerfTestsRunner._run_tests_set):
3043         (PerfTestsRunner._run_single_test):
3044         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3045         (create_runner):
3046         (test_run_passing_test):
3047         (test_run_silent_test):
3048         (test_run_failed_test):
3049         (test_run_tonguey_test):
3050         (test_run_timeout_test):
3051         (test_run_crash_test):
3052         (test_run_test_set_kills_drt_per_run):
3053         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
3054         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
3055         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
3056
3057 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
3058
3059         Webkit generate-coverage-data script needs update to use new test script
3060         https://bugs.webkit.org/show_bug.cgi?id=77597
3061
3062         Reviewed by Dirk Schulze.
3063
3064         * Scripts/generate-coverage-data:
3065
3066 2012-02-01  Adam Barth  <abarth@webkit.org>
3067
3068         Update the tests to show that the mac-ews processes patches from
3069         non-committers.
3070
3071         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3072         (EarlyWarningSytemTest.test_committer_only_ewses):
3073         (EarlyWarningSytemTest.test_builder_ewses):
3074
3075 2012-02-01  Adam Barth  <abarth@webkit.org>
3076
3077         Mac-ews logs are huge
3078         https://bugs.webkit.org/show_bug.cgi?id=77045
3079
3080         Reviewed by Eric Seidel.
3081
3082         In order to get the cr-linux-ews bot to run tests on EC2, we created
3083         the chromium-xvfb port, which contained a number of tweaks to the
3084         Chromium port's behavior.  This patch refactors those tweaks so they
3085         can be shared with the mac-ews, mostly by moving them into the
3086         non-interactive mode of RunTests.
3087
3088         * Scripts/webkitpy/common/config/ports.py:
3089         (WebKitPort):
3090         (WebKitPort.layout_tests_results_path):
3091         (ChromiumPort.run_javascriptcore_tests_command):
3092         (ChromiumXVFBPort):
3093         (ChromiumXVFBPort.run_webkit_tests_command):
3094         * Scripts/webkitpy/common/config/ports_mock.py:
3095         (MockPort):
3096         (MockPort.layout_tests_results_path):
3097         * Scripts/webkitpy/common/config/ports_unittest.py:
3098         (WebKitPortTest.test_chromium_xvfb_port):
3099         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3100         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
3101         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3102         (CommitQueueTest.test_commit_queue):
3103         (test_rollout):
3104         (test_manual_reject_during_processing):
3105         * Scripts/webkitpy/tool/steps/runtests.py:
3106         (RunTests.run):
3107         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3108         (RunTestsTest.test_no_unit_tests):
3109         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3110         (StepsTest.test_runtests_args):
3111
3112 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
3113
3114         Roll out r106442. It made some tests more stable but others less stable.
3115
3116         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3117         (PerfTestsRunner._run_tests_set):
3118         (PerfTestsRunner._run_single_test):
3119         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3120         (create_runner):
3121         (test_run_passing_test):
3122         (test_run_silent_test):
3123         (test_run_failed_test):
3124         (test_run_tonguey_test):
3125         (test_run_timeout_test):
3126         (test_run_crash_test):
3127         (test_run_test_set):
3128
3129 2012-02-01  Lucas Forschler  <lforschler@apple.com>
3130
3131         Enable EWS for non-contributers.
3132         https://bugs.webkit.org/show_bug.cgi?id=77576
3133         
3134         Reviewed by Adam Barth.
3135
3136         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3137         (MacEWS):
3138
3139 2012-02-01  Beth Dakin  <bdakin@apple.com>
3140
3141         https://bugs.webkit.org/show_bug.cgi?id=77383
3142         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
3143         -and corresponding-
3144         <rdar://problem/10709560>
3145
3146         Reviewed by Sam Weinig.
3147
3148         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
3149         for.
3150         * MiniBrowser/mac/BrowserWindowController.m:
3151         (-[BrowserWindowController awakeFromNib]):
3152         * WebKitTestRunner/TestController.cpp:
3153         (WTR::TestController::initialize):
3154
3155 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
3156
3157         TestWebKitAPI isn't being built on chromium bots any more
3158         https://bugs.webkit.org/show_bug.cgi?id=77563
3159
3160         Reviewed by Dimitri Glazkov.
3161
3162         I accidentally dropped it in the refactoring in r105449.
3163
3164         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
3165
3166 2012-02-01  Hans Wennborg  <hans@chromium.org>
3167
3168         Rename WebSpeechInputResult::set() to assign()
3169         https://bugs.webkit.org/show_bug.cgi?id=77540
3170
3171         Reviewed by Darin Fisher.
3172
3173         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3174         (MockWebSpeechInputController::addMockRecognitionResult):
3175         (MockWebSpeechInputController::speechTaskFired):
3176
3177 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3178
3179         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
3180         https://bugs.webkit.org/show_bug.cgi?id=77542
3181
3182         Reviewed by Martin Robinson.
3183
3184         * gtk/generate-gtkdoc: Check first whether there's
3185         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
3186         instead.
3187         (get_webkit2_options): Return just the options since the
3188         pkg_config_path doesn't depend on options
3189         (get_webkit1_options): Ditto.
3190         (generate_doc): Helper function to create a generator and generate
3191         documentation for the given pkg-config file with the given options.
3192         * gtk/gtkdoc.py:
3193         (GTKDoc.__init__): Don't use ** for args parameter, since it's
3194         used as a dict and never expanded.
3195         (PkgConfigGTKDoc.__init__): Ditto.
3196
3197 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3198
3199         [GTK] API documentation is not installed even when building with --enable-gtk-doc
3200         https://bugs.webkit.org/show_bug.cgi?id=77094
3201
3202         Reviewed by Martin Robinson.
3203
3204         * GNUmakefile.am: Add install-data-local and uninstall-local rules
3205         to install/uninstall WebKit1 and WebKit2 API documentation.
3206
3207 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3208
3209         Unreviewed, rolling out r106460.
3210         http://trac.webkit.org/changeset/106460
3211         https://bugs.webkit.org/show_bug.cgi?id=77552
3212
3213         It break unit tests if WEBKIT_TESTFONTS isn't defined.
3214         (Requested by Ossy on #webkit).
3215
3216         * Scripts/webkitpy/layout_tests/port/qt.py:
3217
3218 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
3219
3220         [Qt] Automatic clean build feature always do clean build with --no-webkit2
3221         https://bugs.webkit.org/show_bug.cgi?id=74519
3222
3223         Reviewed by Tor Arne Vestbø.
3224
3225         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
3226
3227         * qmake/mkspecs/features/features.prf:
3228
3229 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3230
3231         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
3232         https://bugs.webkit.org/show_bug.cgi?id=77466
3233
3234         Reviewed by Kenneth Rohde Christiansen.
3235
3236         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
3237         is set or if we should raise an error.
3238
3239         * Scripts/webkitpy/layout_tests/port/qt.py:
3240         (QtPort.setup_environ_for_server):
3241
3242 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
3243
3244         Reviewed by Martin Robinson.
3245
3246         [GTK] Improve FrameLoader signals. Resource loading
3247         https://bugs.webkit.org/show_bug.cgi?id=49543
3248
3249         Support for the new loader signals in DRT.
3250
3251         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3252         (urlPath):
3253         (willSendRequestCallback):
3254         (urlSuitableForTestResult):
3255         (descriptionSuitableForTestResult):
3256         (didReceiveResponse):
3257         (didFinishLoading):
3258         (didFailLoadingWithError):
3259         (createWebView):
3260
3261 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
3262
3263         run-perf-tests should restart DRT for each test
3264         https://bugs.webkit.org/show_bug.cgi?id=77506
3265
3266         Reviewed by Adam Barth.
3267
3268         Always restart DRT when running performance tests in order to minimize the dependency between tests.
3269
3270         * Scripts/webkitpy/layout_tests/port/chromium.py:
3271         (ChromiumDriver.stop):
3272         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3273         (PerfTestsRunner._run_tests_set):
3274         (PerfTestsRunner._run_single_test):
3275         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3276         (create_runner):
3277         (test_run_passing_test):
3278         (test_run_silent_test):
3279         (test_run_failed_test):
3280         (test_run_tonguey_test):
3281         (test_run_timeout_test):
3282         (test_run_crash_test):
3283         (test_run_test_set_kills_drt_per_run):
3284         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
3285         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
3286         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
3287
3288 2012-01-31  Hans Wennborg  <hans@chromium.org>
3289
3290         Speech Input: Report speech element rect relative to window rather than frame
3291         https://bugs.webkit.org/show_bug.cgi?id=76443
3292
3293         Reviewed by Darin Fisher.
3294
3295         Update LayoutTestController to allow for retrieving the speech
3296         element's position used in a request.
3297
3298         In Chromium this is handled by the MockWebSpeechInputController;
3299         adding stubs for the other implementations.
3300
3301         * DumpRenderTree/LayoutTestController.cpp:
3302         (setMockSpeechInputDumpRectCallback):
3303         (LayoutTestController::staticFunctions):
3304         * DumpRenderTree/LayoutTestController.h:
3305         (LayoutTestController):
3306         * DumpRenderTree/chromium/LayoutTestController.cpp:
3307         (LayoutTestController::LayoutTestController):
3308         (LayoutTestController::setMockSpeechInputDumpRect):
3309         * DumpRenderTree/chromium/LayoutTestController.h:
3310         (LayoutTestController):
3311         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3312         (MockWebSpeechInputController::setDumpRect):
3313         (MockWebSpeechInputController::clearResults):
3314         (MockWebSpeechInputController::startRecognition):
3315         (MockWebSpeechInputController::MockWebSpeechInputController):
3316         (makeRectResult):
3317         (MockWebSpeechInputController::speechTaskFired):
3318         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
3319         (MockWebSpeechInputController):
3320         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3321         (LayoutTestController::setMockSpeechInputDumpRect):
3322         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3323         (LayoutTestController::setMockSpeechInputDumpRect):
3324         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3325         (LayoutTestController::setMockSpeechInputDumpRect):
3326         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3327         (LayoutTestController::setMockSpeechInputDumpRect):
3328         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3329         (LayoutTestController):
3330         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3331         (LayoutTestController::setMockSpeechInputDumpRect):
3332         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3333         (LayoutTestController::setMockSpeechInputDumpRect):
3334
3335 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
3336
3337         [EFL] Add basic DRT/Efl implementation to support viewport test.
3338         https://bugs.webkit.org/show_bug.cgi?id=77320
3339
3340         Reviewed by Andreas Kling.
3341
3342         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3343         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
3344
3345 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
3346
3347         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
3348         https://bugs.webkit.org/show_bug.cgi?id=77473
3349         <rdar://problem/10751357>
3350
3351         Reviewed by Darin Adler.
3352
3353         * DumpRenderTree/mac/EventSendingController.mm:
3354         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3355         * WebKitTestRunner/mac/EventSenderProxy.mm:
3356         (WTR::EventSenderProxy::keyDown):
3357         Added a new special keyDown value to test this.
3358
3359 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
3360
3361         nrwt: fix the mock port to work with DriverProxy, reftests
3362         https://bugs.webkit.org/show_bug.cgi?id=77170
3363
3364         Reviewed by Eric Seidel.
3365
3366         The DryrunPort used for benchmarking and testing NRWT has been
3367         broken since we added the DriverProxy code. It isn't really
3368         needed any more, so I've removed it.
3369
3370         The MockDRT port was also broken by DriverProxy, and moreover,
3371         never worked w/ reftests. Since we don't exercise this module in
3372         the unit tests, the code had also bitrotted some. I have cleaned
3373         it up and made it use DriverInput and DriverOutput for
3374         consistency.
3375
3376         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3377         (DryRunPort.__init__):
3378         (DryRunPort):
3379         (DryRunPort.real_name):
3380         (DryRunPort.create_driver):
3381         (DryRunPort.driver_cmd_line):
3382         (DryRunPort._driver_class):
3383         (DryrunDriver):
3384         (DryrunDriver.run_test):
3385         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3386         (MockDRTPort.create_driver):
3387         (MockChromiumDRT.run_one_test):
3388
3389 2012-01-31  Ojan Vafai  <ojan@chromium.org>
3390
3391         run-webkit-tests calls out to webkit-build-directory twice
3392         https://bugs.webkit.org/show_bug.cgi?id=77248
3393
3394         Reviewed by Dirk Pranke.
3395
3396         * Scripts/webkit-build-directory:
3397         If called with no arguments, print out both the top-level directory and the 
3398         configuration directory
3399
3400         * Scripts/webkitpy/layout_tests/port/config.py:
3401         (Config.build_directory):
3402         When called with no arguments, get and cache both the top-level and configuration directories.
3403
3404         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3405         (main):
3406         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3407         (ConfigTest.assert_configuration):
3408         (ConfigTest.test_build_directory.mock_webkit_build_directory):
3409         (ConfigTest.test_build_directory):
3410         (ConfigTest.test_default_configuration__notfound):
3411         * Scripts/webkitpy/layout_tests/port/webkit.py:
3412         (WebKitPort._build_path):
3413         Cache the build directory in the options object so that other users
3414         of the options object don't need to call out to webkit-build-directory.
3415         Also, properly support the existing --build-directory argument.
3416
3417 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
3418
3419         Bump up the timeout for performance tests since DOM/DOMTable.html
3420         and Parser/html5-full-render.html are timing out on the bot.
3421
3422         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3423         (PerfTestsRunner._parse_args):
3424
3425 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
3426
3427         Fix the update_webgl_conformance_tests.py script in order to enable it
3428         to detect the SCM being used correctly.
3429         https://bugs.webkit.org/show_bug.cgi?id=77462
3430
3431         Reviewed by Kenneth Russell.
3432
3433         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3434         (default_out_dir):
3435
3436 2012-01-31  Eric Seidel  <eric@webkit.org>
3437
3438         webkit-patch apply-from-bug should work regardless of your CWD
3439         https://bugs.webkit.org/show_bug.cgi?id=77482
3440
3441         Reviewed by Adam Barth.
3442
3443         webkit-patch only ever works with patches made from the root
3444         directory.  We should pass the CWD to svn-apply in the case
3445         where we're running not from the webkit root.  I believe
3446         this used to work in the past and regressed.
3447
3448         * Scripts/webkitpy/common/checkout/checkout.py:
3449         (Checkout.apply_patch):
3450         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3451         (CheckoutTest.test_apply_patch):
3452
3453 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3454
3455         Unreviewed, rolling out r106302.
3456         http://trac.webkit.org/changeset/106302
3457         https://bugs.webkit.org/show_bug.cgi?id=77472
3458
3459         Broke building DRT before running the tests (Requested by ojan
3460         on #webkit).
3461
3462         * Scripts/webkit-build-directory:
3463         * Scripts/webkitpy/layout_tests/port/config.py:
3464         (Config.build_directory):
3465         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3466         (main):
3467         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3468         (ConfigTest.assert_configuration):
3469         (ConfigTest.test_build_directory.mock_webkit_build_directory):
3470         (ConfigTest.test_build_directory):
3471         (ConfigTest.test_default_configuration__notfound):
3472         * Scripts/webkitpy/layout_tests/port/webkit.py:
3473         (WebKitPort._build_path):
3474
3475 2012-01-31  Antoine Labour  <piman@chromium.org>
3476
3477         Merge WebGraphicsContext3D creation and initialization, and move it to
3478         WebViewClient.
3479         https://bugs.webkit.org/show_bug.cgi?id=76593
3480
3481         Reviewed by Darin Fisher.
3482
3483         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3484         (TestWebPlugin::TestWebPlugin):
3485         (TestWebPlugin::initialize):
3486         * DumpRenderTree/chromium/TestWebPlugin.h:
3487         * DumpRenderTree/chromium/WebViewHost.cpp:
3488         (WebViewHost::createGraphicsContext3D):
3489         (WebViewHost::createPlugin):
3490         * DumpRenderTree/chromium/WebViewHost.h:
3491
3492 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
3493
3494         [GTK] build-webkit warning.
3495         https://bugs.webkit.org/show_bug.cgi?id=77411
3496
3497         Reviewed by Philippe Normand.
3498
3499         * Scripts/webkitdirs.pm:
3500         (isCrossCompilation):
3501
3502 2012-01-31  Dan Bernstein  <mitz@apple.com>
3503
3504         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
3505
3506         Reviewed by Anders Carlsson.
3507
3508         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3509
3510 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
3511
3512         If the QTDIR environment variable is set, the build system fails to compile WinCairo
3513         https://bugs.webkit.org/show_bug.cgi?id=77112
3514
3515         Reviewed by Daniel Bates.
3516
3517         * Scripts/webkitdirs.pm:
3518         (determineIsQt):
3519
3520 2012-01-31  Adam Roben  <aroben@apple.com>
3521
3522         Only call -typingAttributes on WebViews, not WebHTMLViews
3523
3524         Looks like this case was just missed in r105908.
3525
3526         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
3527
3528         Reviewed by Antti Koivisto.
3529
3530         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3531         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
3532         earlier.
3533
3534 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3535
3536         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
3537         https://bugs.webkit.org/show_bug.cgi?id=77221
3538
3539         Reviewed by Kenneth Rohde Christiansen.
3540
3541         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
3542
3543         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3544         (MiniBrowserApplication::sendTouchEvent):
3545
3546 2012-01-26  Hans Wennborg  <hans@chromium.org>
3547
3548         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
3549         https://bugs.webkit.org/show_bug.cgi?id=77083
3550
3551         Reviewed by Darin Fisher.
3552
3553         Add MockWebSpeechInputController which provides a mock implementation
3554         of the WebSpeechInputController interface, and use that in
3555         DumpRenderTree.
3556
3557         * DumpRenderTree/DumpRenderTree.gypi:
3558         * DumpRenderTree/chromium/LayoutTestController.cpp:
3559         (LayoutTestController::addMockSpeechInputResult):
3560         * DumpRenderTree/chromium/LayoutTestController.h:
3561         ():
3562         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
3563         (MockWebSpeechInputController::create):
3564         (MockWebSpeechInputController::addMockRecognitionResult):
3565         (MockWebSpeechInputController::clearResults):
3566         (MockWebSpeechInputController::startRecognition):
3567         (MockWebSpeechInputController::cancelRecognition):
3568         (MockWebSpeechInputController::stopRecording):
3569         (MockWebSpeechInputController::MockWebSpeechInputController):
3570         (MockWebSpeechInputController::speechTaskFired):
3571         (MockWebSpeechInputController::SpeechTask::SpeechTask):
3572         (MockWebSpeechInputController::SpeechTask::stop):
3573         (MockWebSpeechInputController::SpeechTask::runIfValid):
3574         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
3575         (WebKit):
3576         (MockWebSpeechInputController):
3577         (MockWebSpeechInputController::taskList):
3578         (SpeechTask):
3579         * DumpRenderTree/chromium/TestShell.cpp:
3580         * DumpRenderTree/chromium/WebViewHost.cpp:
3581         (WebViewHost::speechInputController):
3582         * DumpRenderTree/chromium/WebViewHost.h:
3583         (WebKit):
3584         (WebViewHost::speechInputControllerMock):
3585         (WebViewHost):
3586         ():
3587
3588 2012-01-31  Hajime Morrita  <morrita@chromium.org>
3589
3590         [PerformanceTests] Add landing html for Dromaeo dom-query test
3591         https://bugs.webkit.org/show_bug.cgi?id=77329
3592
3593         Reviewed by Ryosuke Niwa.
3594
3595         Added some more ignorable output patterns to allow warnings
3596         from a third party test suite.
3597
3598         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3599         (PerfTestsRunner):
3600         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
3601
3602 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
3603
3604         [wx] Unreviewed. Update download URLs to new domain.
3605         
3606         * waf/build/build_utils.py:
3607         (update_wx_deps):
3608
3609 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
3610
3611         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
3612         to the list of build directories.
3613         
3614         * waf/build/settings.py:
3615
3616 2012-01-30  Kentaro Hara  <haraken@chromium.org>
3617
3618         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
3619         output an empty method name (i.e. "()")
3620         https://bugs.webkit.org/show_bug.cgi?id=77336
3621
3622         Reviewed by Darin Adler.
3623
3624         r105797 tried to detect a change outside methods, but it causes a bug that
3625         prepare-ChangeLog can output an empty method name, like this:
3626
3627             * foo/bar/baz.cpp:
3628             (method1):
3629             ():
3630             (method2):
3631
3632         This is because the cpp parser in prepare-ChangeLog cannot distinguish
3633         '{' as the beginning of a method with '{' as the beginning of an array definition
3634         at the top level.
3635
3636             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
3637
3638             void func() { // This '{' is the beginning of a method.
3639                 ...;
3640             }
3641
3642         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
3643
3644         * Scripts/prepare-ChangeLog:
3645         (get_function_line_ranges_for_cpp): Modified as described above.
3646         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
3647         an empty method name. Ideally this should not happen but may happen, since the
3648         parsers are not perfect.
3649         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
3650         (NameSpace7):
3651         (NameSpace8):
3652         (Class109):
3653         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
3654
3655 2012-01-30  Ojan Vafai  <ojan@chromium.org>
3656
3657         run-webkit-tests calls out to webkit-build-directory twice
3658         https://bugs.webkit.org/show_bug.cgi?id=77248
3659
3660         Reviewed by Dirk Pranke.
3661
3662         This reduces to calls to webkit-build-directory to one call and
3663         saves 500ms for run-webkit-tests over a single file.
3664
3665         * Scripts/webkit-build-directory:
3666         If called with no arguments, print out both the top-level directory and the 
3667         configuration directory.
3668
3669         * Scripts/webkit-build-directory:
3670         * Scripts/webkitpy/layout_tests/port/config.py:
3671         (Config.build_directory):
3672         When called with no arguments, get and cache both the top-level and configuration directories.
3673
3674         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3675         (main):
3676         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3677         (ConfigTest.assert_configuration):
3678         (ConfigTest.test_build_directory.mock_webkit_build_directory):
3679         (ConfigTest.test_build_directory):
3680         (ConfigTest.test_default_configuration__notfound):
3681         * Scripts/webkitpy/layout_tests/port/webkit.py:
3682         (WebKitPort._build_path):
3683         Cache the root directory in the options object so that other users
3684         of the options object don't need to call out to webkit-build-directory.
3685
3686 2012-01-30  Ojan Vafai  <ojan@chromium.org>
3687
3688         Parsing test_expecations.txt + Skipped lists takes too long
3689         https://bugs.webkit.org/show_bug.cgi?id=77059
3690
3691         Reviewed by Dirk Pranke.
3692
3693         This saves ~100ms on the Apple Mac port.
3694         -memoize a bunch of path methods.
3695         -Avoid doing multiple disk accesses per line.
3696         -Parse the skipped list directly instead of turning it into a test_expecations.txt
3697         formatting string and parsing that.
3698
3699         * Scripts/webkitpy/layout_tests/models/test_expectations.py: