32ac04b11f0c008f89324c8fa2dde66d823d7cc1
[WebKit-https.git] / Tools / ChangeLog
1 2015-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         [CMake] Ignore warnings from system headers when compiling Tools
4         https://bugs.webkit.org/show_bug.cgi?id=146185
5
6         Reviewed by Martin Robinson.
7
8         Use the SYSTEM argument to the include_directories() command to silence compiler warnings
9         from system headers that we don't control.
10
11         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
12         * ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
13         * ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
14         * ImageDiff/PlatformGTK.cmake:
15         * MiniBrowser/efl/CMakeLists.txt:
16         * MiniBrowser/gtk/CMakeLists.txt:
17         * TestWebKitAPI/PlatformEfl.cmake:
18         * TestWebKitAPI/PlatformGTK.cmake:
19         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
20         * WebKitTestRunner/CMakeLists.txt:
21         * WebKitTestRunner/PlatformEfl.cmake:
22         * WebKitTestRunner/PlatformGTK.cmake:
23
24 2015-06-20  Michael Catanzaro  <mcatanzaro@igalia.com>
25
26         [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
27         https://bugs.webkit.org/show_bug.cgi?id=146186
28
29         Reviewed by Martin Robinson.
30
31         Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
32         deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
33
34         * MiniBrowser/gtk/CMakeLists.txt:
35
36 2015-06-19  Ryosuke Niwa  <rniwa@webkit.org>
37
38         Build fix after r146125.
39
40         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
41         (OSXSafariDriver):
42         (OSXSafariDriver.prepareEnv):
43
44 2015-06-19  Brady Eidson  <beidson@apple.com>
45
46         Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp.
47         https://bugs.webkit.org/show_bug.cgi?id=146152
48
49         Reviewed by Dan Bernstein.
50
51         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
52         * WebKitTestRunner/WebNotificationProvider.cpp:
53
54 2015-06-19  Mark Lam  <mark.lam@apple.com>
55
56         CheckedArithmetic's operator bool() and operator==() is broken.
57         https://bugs.webkit.org/show_bug.cgi?id=146129
58
59         Reviewed by Geoffrey Garen and Oliver Hunt.
60
61         Added API tests for operator ==, !=, <, <=, >, and >=, and tested for both normal
62         and overflow scenarios in usage of the Checked arithmetic class.
63
64         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
65         (TestWebKitAPI::OverflowCrashLogger::overflowed):
66         (TestWebKitAPI::OverflowCrashLogger::clearOverflow):
67         (TestWebKitAPI::OverflowCrashLogger::crash):
68         (TestWebKitAPI::OverflowCrashLogger::reset):
69         (TestWebKitAPI::OverflowCrashLogger::hasOverflowed):
70         (TestWebKitAPI::OverflowCrashLogger::overflowCount):
71         (TestWebKitAPI::OverflowCrashLogger::didCrash):
72         - crash logger for verifying that a crash occurs when expected. 
73
74         (TestWebKitAPI::resetOverflow):
75         - convenience function for resetting a test value to an initial overflowed state
76           before a crash.  We will use this value in the overflow testing.
77
78         (TestWebKitAPI::CheckedArithmeticTester::run):
79         - Added new tests for all the comparison operators.
80
81 2015-06-19  Per Arne Vollan  <peavo@outlook.com>
82
83         Fix the Windows build after r185721
84         https://bugs.webkit.org/show_bug.cgi?id=146146
85
86         Reviewed by Csaba Osztrogonác.
87
88         Speculative buildfix.
89
90         * DumpRenderTree/win/UIDelegate.h:
91         (UIDelegate::unused4): Added.
92         (UIDelegate::webViewShouldInterruptJavaScript): Deleted.
93
94 2015-06-19  Diego Pino Garcia  <dpino@igalia.com>
95
96         Unreviewed. Add myself as a committer.
97
98         * Scripts/webkitpy/common/config/contributors.json:
99
100 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
101
102         Remove unnecessary svn:executable flags
103         https://bugs.webkit.org/show_bug.cgi?id=146107
104
105         Reviewed by Alexey Proskuryakov.
106
107         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Removed property svn:executable.
108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Removed property svn:executable.
109         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Removed property svn:executable.
110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Removed property svn:executable.
111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Removed property svn:executable.
112         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Removed property svn:executable.
113         * CygwinDownloader/cygwin-downloader.zip: Removed property svn:executable.
114         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed property svn:executable.
115         * DumpRenderTree/win/TextInputController.cpp: Removed property svn:executable.
116         * DumpRenderTree/win/TextInputController.h: Removed property svn:executable.
117         * DumpRenderTree/win/TextInputControllerWin.cpp: Removed property svn:executable.
118         * Scripts/webkitpy/port/base_unittest.py: Removed property svn:executable.
119         * Scripts/webkitpy/port/driver.py: Removed property svn:executable.
120         * Scripts/webkitpy/w3c/test_parser.py: Removed property svn:executable.
121
122 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
123
124         Disable tests on the WinCairo buildbot
125         https://bugs.webkit.org/show_bug.cgi?id=146106
126
127         Reviewed by Alexey Proskuryakov.
128
129         * BuildSlaveSupport/build.webkit.org-config/config.json:
130         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
131
132 2015-06-19  Hunseop Jeong  <hs85.jeong@samsung.com>
133
134         [EFL] Fix the minibrowser after r185725
135         https://bugs.webkit.org/show_bug.cgi?id=146135
136
137         Reviewed by Gyuyoung Kim.
138
139         Removed the HAVE_ECORE_X guard in MiniBrowser because it is an unnecessary guard
140         for the elm_config_accel_preference_set() to set the config of acceleration preference.
141
142         * MiniBrowser/efl/main.c:
143         (elm_main): Deleted the HAVE_ECORE_X guard.
144
145 2015-06-18  Dewei Zhu  <dewei_zhu@apple.com>
146
147         Extend capability of run-benchmark script to support mobile device
148         https://bugs.webkit.org/show_bug.cgi?id=146125
149
150         Reviewed by Ryosuke Niwa.
151
152         Extend capability of run-benchmark to support mobile device, and move majority of run-benchmark script code to
153         benchmark_runner directory, and make run-benchmark a wrapping script. Also correct a typo.
154
155         * Scripts/run-benchmark:
156         (main): Deleted.
157         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
158         (BenchmarkRunner.__init__):
159         (BenchmarkRunner.execute):
160         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
161         (BrowserDriver.prepareEnv):
162         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
163         (OSXBrowserDriver.prepareEnv):
164         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
165         (OSXSafariDriver.prepareEnv):
166         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
167         (HTTPServerDriver.getReturnCode):
168         (HTTPServerDriver):
169         (HTTPServerDriver.setDeviceID):
170         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Copied from Tools/Scripts/run-benchmark.
171         (parse_args):
172         (start):
173         (main):
174         * Scripts/webkitpy/benchmark_runner/utils.py:
175         (getPathFromProjectRoot):
176
177 2015-06-18  Jon Lee  <jonlee@apple.com>
178
179         Unreviewed. Add Matt Daiter as a contributor.
180
181         * Scripts/webkitpy/common/config/contributors.json:
182
183 2015-06-18  Mark Lam  <mark.lam@apple.com>
184
185         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
186         https://bugs.webkit.org/show_bug.cgi?id=146103
187
188         Not reviewed.
189
190         Follow up to fix some typos not caught before original patch was landed.
191
192         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
193         (TestWebKitAPI::CheckedArithmeticTester::run):
194         (TestWebKitAPI::AllowMixedSignednessTest::run):
195         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
196
197 2015-06-18  Daniel Bates  <dabates@apple.com>
198
199         Make webkitdirs::runGitUpdate() work when invoked in more than one Git checkout
200         https://bugs.webkit.org/show_bug.cgi?id=146082
201
202         Reviewed by Darin Adler.
203
204         The function webkitdirs::runGitUpdate may not update the Git checkout in the current
205         working directory after being invoked in a different Git checkout. In particular,
206         calling runGitUpdate() inside a Git SVN checkout and subsequently calling it inside
207         a pure Git checkout g will fail to update g.
208
209         Currently webkitdirs::runGitUpdate() calls VCSUtils::isGitSVN() to determine whether
210         the current working directory is a Git SVN checkout. And isGitSVN() caches its result
211         to speed up subsequent queries. This prevents runGitUpdate() from being used to update
212         an arbitrary Git checkout (since isGitSVN() may return a cached result for a directory
213         different than the current working directory). Instead runGitUpdate() should check
214         whether the current working directory is a Git SVN checkout on each invocation.
215
216         * Scripts/VCSUtils.pm: Export function isGitSVNDirectory so that it can be used from webkitdirs::runGitUpdate().
217         (isGitSVNDirectory): Extracted logic to determine whether a directory is a Git
218         SVN directory from isGitSVN().
219         (isGitSVN): Implemented in terms of isGitSVNDirectory().
220         * Scripts/webkitdirs.pm:
221         (runGitUpdate): Modified to use isGitSVNDirectory().
222
223 2015-06-18  Mark Lam  <mark.lam@apple.com>
224
225         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
226         https://bugs.webkit.org/show_bug.cgi?id=146103
227
228         Reviewed by Anders Carlsson.
229
230         Presently, the tests in CheckedArithmeticOperations.cpp are all implemented as
231         part of a large macro.  This makes them harder to:
232
233         1. write: no editor help with indentations, have to add trailing '\'s,
234            inconvenient to add line breaks and comments.
235
236         2. read: no chroma coding / syntax highlighting.
237
238         3. debug: compile time errors are reported as being on the single line where
239            the macro is used.
240
241         Refactoring the tests to use C++ templates solves all these issues.
242
243         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
244         (TestWebKitAPI::CheckedArithmeticTester::run):
245         (TestWebKitAPI::AllowMixedSignednessTest::run):
246         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
247         (TestWebKitAPI::CoerceLiteralToUnsigned::coerce):
248         (TestWebKitAPI::CoerceLiteralNop::coerce):
249
250 2015-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
251
252         [EFL][WK2] Use Web Browser cache model in MiniBrowser
253         https://bugs.webkit.org/show_bug.cgi?id=112273
254
255         Reviewed by Laszlo Gombos.
256
257         Set cache model to EWK_CACHE_MODEL_PRIMARY_WEBBROWSER in EFL's MiniBrowser
258         instead of leaving the default value (EWK_CACHE_MODEL_DOCUMENT_VIEWER).
259         This way we have a decent cache capacity and the page cache actually works.
260
261         * MiniBrowser/efl/main.c:
262         (elm_main):
263
264 2015-06-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
265
266         Remove redundant Chromium bug keyword
267         https://bugs.webkit.org/show_bug.cgi?id=146097
268
269         Reviewed by Csaba Osztrogonác.
270
271         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
272         (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
273         (TestExpectationLine._format_line): Deleted.
274
275 2015-06-17  Daniel Bates  <dabates@apple.com>
276
277         Client may receive began editing callback for already focused text field
278         https://bugs.webkit.org/show_bug.cgi?id=146074
279         <rdar://problem/21293562>
280
281         Reviewed by Darin Adler.
282
283         Add a unit test to ensure that a client receives exactly one began editing
284         callback when a text field is newly focused. In particular, dispatching
285         a DOM focus event at an already focused text field does not dispatch a
286         began editing callback to the client.
287
288         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
289         (TestWebKitAPI::TEST_F):
290
291 2015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
292
293         [Win]Implement layoutTestController.dispatchPendingLoadRequests. 
294         https://bugs.webkit.org/show_bug.cgi?id=26481
295
296         Reviewed by Darin Adler.
297
298         Implement WebView::dispatchPendingLoadRequests() private API for test runner.
299
300         * DumpRenderTree/win/TestRunnerWin.cpp:
301         (TestRunner::dispatchPendingLoadRequests):
302         (TestRunner::overridePreference):
303
304 2015-06-17  Alex Christensen  <achristensen@webkit.org>
305
306         [Content Extensions] Fail to parse invalid arrays
307         https://bugs.webkit.org/show_bug.cgi?id=146079
308         rdar://problem/21422649
309
310         Reviewed by Benjamin Poulain.
311
312         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
313         (TestWebKitAPI::TEST_F):
314         Correct and add parsing tests with invalid arrays.
315
316 2015-06-17  Matt Rajca  <mrajca@apple.com>
317
318         Unreviewed. Added myself as a committer.
319
320         * Scripts/webkitpy/common/config/contributors.json:
321
322 2015-06-17  Daniel Bates  <dabates@apple.com>
323
324         Export VCSUtils::gitTreeDirectory()
325         <rdar://problem/21248901>
326
327         Rubber-stamped by Alexey Proskuryakov.
328
329         * Scripts/VCSUtils.pm:
330
331 2015-06-17  Tim Horton  <timothy_horton@apple.com>
332
333         Safari tabs still have shrunken content after coming out of fullscreen
334         https://bugs.webkit.org/show_bug.cgi?id=146037
335         <rdar://problem/21105960>
336
337         Reviewed by Simon Fraser and Darin Adler.
338
339         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
340         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Added.
341         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]):
342         (TEST):
343         Add a test that ensures that disabling scale-to-fit mode correctly updates
344         the page's layout.
345
346 2015-06-17  Dan Bernstein  <mitz@apple.com>
347
348         [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate
349         https://bugs.webkit.org/show_bug.cgi?id=145957
350
351         Reviewed by Darin Adler.
352
353         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
354         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]): Renamed from -_webViewClose:.
355
356 2015-06-15  Chris Fleizach  <cfleizach@apple.com>
357
358         AX:  iOS accessibility tests are not running because we need WKTR support
359         https://bugs.webkit.org/show_bug.cgi?id=145991
360
361         Reviewed by Daniel Bates.
362
363         Add support for WKTR iOS accessibility.
364         Utilize the notification handling mechanisms that Mac already uses.
365         Rename iphone* DRT methods to either use existing methods that are similar, or rename to more generic names.
366
367         * DumpRenderTree/AccessibilityUIElement.cpp:
368         (stringForSelectionCallback):
369         (getIdentifierCallback):
370         (getTraitsCallback):
371         (getElementTextPositionCallback):
372         (getElementTextLengthCallback):
373         (AccessibilityUIElement::getJSClass):
374         (getIPhoneLabelCallback): Deleted.
375         (getIPhoneHintCallback): Deleted.
376         (getIPhoneValueCallback): Deleted.
377         (getIPhoneIdentifierCallback): Deleted.
378         (getIPhoneTraitsCallback): Deleted.
379         (getIPhoneIsElementCallback): Deleted.
380         (getIPhoneElementTextPositionCallback): Deleted.
381         (getIPhoneElementTextLengthCallback): Deleted.
382         * DumpRenderTree/AccessibilityUIElement.h:
383         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
384         (AccessibilityUIElement::identifier):
385         (AccessibilityUIElement::traits):
386         (AccessibilityUIElement::elementTextPosition):
387         (AccessibilityUIElement::elementTextLength):
388         (AccessibilityUIElement::description):
389         (AccessibilityUIElement::orientation):
390         (AccessibilityUIElement::stringValue):
391         (AccessibilityUIElement::language):
392         (AccessibilityUIElement::helpText):
393         (AccessibilityUIElement::intValue):
394         (AccessibilityUIElement::isSelected):
395         (AccessibilityUIElement::isExpanded):
396         (AccessibilityUIElement::documentURI):
397         (AccessibilityUIElement::addNotificationListener):
398         (AccessibilityUIElement::removeNotificationListener):
399         (AccessibilityUIElement::isFocusable):
400         (AccessibilityUIElement::isIgnored):
401         (AccessibilityUIElement::hasPopup):
402         (AccessibilityUIElement::iphoneLabel): Deleted.
403         (AccessibilityUIElement::iphoneHint): Deleted.
404         (AccessibilityUIElement::iphoneValue): Deleted.
405         (AccessibilityUIElement::iphoneIdentifier): Deleted.
406         (AccessibilityUIElement::iphoneTraits): Deleted.
407         (AccessibilityUIElement::iphoneIsElement): Deleted.
408         (AccessibilityUIElement::iphoneElementTextPosition): Deleted.
409         (AccessibilityUIElement::iphoneElementTextLength): Deleted.
410         (_accessibilityNotificationCallback): Deleted.
411         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
412         (WTR::AccessibilityUIElement::isValid):
413         (WTR::AccessibilityUIElement::identifier):
414         (WTR::AccessibilityUIElement::traits):
415         (WTR::AccessibilityUIElement::elementTextPosition):
416         (WTR::AccessibilityUIElement::elementTextLength):
417         (WTR::AccessibilityUIElement::stringForSelection):
418         (WTR::AccessibilityUIElement::elementsForRange):
419         (WTR::AccessibilityUIElement::increaseTextSelection):
420         (WTR::AccessibilityUIElement::decreaseTextSelection):
421         (WTR::AccessibilityUIElement::linkedElement):
422         (WTR::AccessibilityUIElement::headerElementAtIndex):
423         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
424         (WTR::AccessibilityUIElement::characterAtOffset):
425         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
426         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
427         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
428         (WTR::findAccessibleObjectById):
429         (WTR::AccessibilityController::accessibleElementById):
430         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
431         (+[NSString stringWithJSStringRef:]):
432         (-[NSString createJSStringRef]):
433         (WTR::convertNSArrayToVector):
434         (WTR::concatenateAttributeAndValue):
435         (WTR::AccessibilityUIElement::AccessibilityUIElement):
436         (WTR::AccessibilityUIElement::isEqual):
437         (WTR::AccessibilityUIElement::headerElementAtIndex):
438         (WTR::AccessibilityUIElement::linkedElement):
439         (WTR::AccessibilityUIElement::getLinkedUIElements):
440         (WTR::AccessibilityUIElement::elementAtPoint):
441         (WTR::convertElementsToObjectArray):
442         (WTR::AccessibilityUIElement::elementsForRange):
443         (WTR::AccessibilityUIElement::indexOfChild):
444         (WTR::AccessibilityUIElement::stringAttributeValue):
445         (WTR::AccessibilityUIElement::description):
446         (WTR::AccessibilityUIElement::orientation):
447         (WTR::AccessibilityUIElement::stringValue):
448         (WTR::AccessibilityUIElement::language):
449         (WTR::AccessibilityUIElement::helpText):
450         (WTR::AccessibilityUIElement::x):
451         (WTR::AccessibilityUIElement::clickPointX):
452         (WTR::AccessibilityUIElement::clickPointY):
453         (WTR::AccessibilityUIElement::intValue):
454         (WTR::AccessibilityUIElement::minValue):
455         (WTR::AccessibilityUIElement::maxValue):
456         (WTR::AccessibilityUIElement::valueDescription):
457         (WTR::AccessibilityUIElement::isSelected):
458         (WTR::AccessibilityUIElement::isSelectedOptionActive):
459         (WTR::AccessibilityUIElement::stringForRange):
460         (WTR::AccessibilityUIElement::attributedStringForRange):
461         (WTR::AccessibilityUIElement::attributesOfHeader):
462         (WTR::AccessibilityUIElement::traits):
463         (WTR::AccessibilityUIElement::identifier):
464         (WTR::AccessibilityUIElement::rowCount):
465         (WTR::AccessibilityUIElement::rowIndexRange):
466         (WTR::AccessibilityUIElement::columnIndexRange):
467         (WTR::AccessibilityUIElement::cellForColumnAndRow):
468         (WTR::AccessibilityUIElement::horizontalScrollbar):
469         (WTR::AccessibilityUIElement::documentURI):
470         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
471         (WTR::AccessibilityUIElement::increaseTextSelection):
472         (WTR::AccessibilityUIElement::decreaseTextSelection):
473         (WTR::AccessibilityUIElement::stringForSelection):
474         (WTR::AccessibilityUIElement::elementTextPosition):
475         (WTR::AccessibilityUIElement::elementTextLength):
476         (WTR::AccessibilityUIElement::url):
477         (WTR::AccessibilityUIElement::addNotificationListener):
478         (WTR::AccessibilityUIElement::removeNotificationListener):
479         (WTR::AccessibilityUIElement::isFocusable):
480         (WTR::AccessibilityUIElement::isIgnored):
481         (WTR::AccessibilityUIElement::hasPopup):
482         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
483         (WTR::_CGPathEnumerationIteration):
484         (WTR::AccessibilityUIElement::pathDescription):
485         (WTR::AccessibilityUIElement::supportedActions):
486
487 2015-06-16  Mark Lam  <mark.lam@apple.com>
488
489         Use NakedPtr<Exception>& to return exception results.
490         https://bugs.webkit.org/show_bug.cgi?id=145870
491
492         Reviewed by Anders Carlsson and Filip Pizlo.
493
494         * TestWebKitAPI/CMakeLists.txt:
495         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
496         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
497         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
498         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: Added.
499         (TestWebKitAPI::TEST):
500         (TestWebKitAPI::nakedPtrFoo):
501
502 2015-06-16  Tobias Reiss  <tobi+webkit@basecode.de>
503
504         Unreviewed. Adding myself as a committer.
505
506         * Scripts/webkitpy/common/config/contributors.json:
507
508 2015-06-15  Alexey Proskuryakov  <ap@apple.com>
509
510         Add test expectations for El Capitan
511         https://bugs.webkit.org/show_bug.cgi?id=146005
512
513         Rubber-stamped by Dan Bernstein.
514
515         Add appropriate tools code.
516
517         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
518         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added.
519         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
521         Added dashboard support.
522
523         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
524         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
525         Trigger the right build queues on check-in.
526
527         * Scripts/webkitpy/common/system/platforminfo.py:
528         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
529         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
530         * Scripts/webkitpy/port/mac.py:
531         * Scripts/webkitpy/port/mac_unittest.py:
532         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
533         * TestResultServer/static-dashboards/flakiness_dashboard.js:
534         Added cases for El Capitan, and updated tests for new baseline search paths.
535
536 2015-06-15  Alex Christensen  <achristensen@webkit.org>
537
538         [Content Extensions] Make max NFA size and max rule count user defaults.
539         https://bugs.webkit.org/show_bug.cgi?id=145663
540
541         Reviewed by Benjamin Poulain.
542
543         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
544         (TestWebKitAPI::TEST_F):
545
546 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
547
548         -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
549         https://bugs.webkit.org/show_bug.cgi?id=145900
550
551         Reviewed by Sam Weinig.
552
553         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
554         (TEST): Added tests.
555
556 2015-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
557
558         [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
559         https://bugs.webkit.org/show_bug.cgi?id=145969
560
561         Reviewed by Sergio Villar Senin.
562
563         Add a test case to the custom URI schemes unit test.
564
565         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
566         (testWebContextURIScheme):
567
568 2015-06-15  Csaba Osztrogonác  <ossy@webkit.org>
569
570         [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
571         https://bugs.webkit.org/show_bug.cgi?id=145922
572
573         Reviewed by Carlos Garcia Campos.
574
575         * gtk/jhbuild.modules:
576         * gtk/patches/glib-warning-fix.patch: Added.
577
578 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
579
580         Update springLoadingHighlight type
581         https://bugs.webkit.org/show_bug.cgi?id=145939
582         rdar://problem/20880213
583
584         Reviewed by Darin Adler.
585
586         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
587         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
588         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
589         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
590
591 2015-06-12  Dewei Zhu  <dewei_zhu@apple.com>
592
593         Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
594         https://bugs.webkit.org/show_bug.cgi?id=145945
595
596         Reviewed by Stephanie Lewis.
597
598         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
599         (OSXBrowserDriver.prepareEnv):
600         (OSXBrowserDriver.moveCursor): Deleted.
601         (OSXBrowserDriver): Deleted.
602         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
603         (OSXSafariDriver.prepareEnv):
604
605 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
606
607         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
608         https://bugs.webkit.org/show_bug.cgi?id=145938
609
610         Reviewed by Alexey Proskuryakov.
611
612         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
613         LWP::UserAgent to get access to more robust HTTPS support.
614
615 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
616
617         [GTK] Fix return type warning in WebViewTest.cpp
618         https://bugs.webkit.org/show_bug.cgi?id=145914
619
620         Reviewed by Darin Adler.
621
622         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
623         (WebViewTest::isEditable):
624
625 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
626
627         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
628         https://bugs.webkit.org/show_bug.cgi?id=145799
629
630         Reviewed by Carlos Garcia Campos.
631
632         Update header inclusions for headers that have been moved
633         to Source/WTF/wtf/glib/.
634
635         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
636         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
637
638         * TestWebKitAPI/PlatformGTK.cmake:
639         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
640         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
641         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
642         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
643         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
644         (TestWebKitAPI::GMainLoopSourceTest::finish):
645         (TestWebKitAPI::GMainLoopSourceTest::source):
646         (TestWebKitAPI::basicRescheduling):
647         (TestWebKitAPI::TEST):
648         (TestWebKitAPI::reentrantRescheduling):
649         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
650         (TestWebKitAPI::basicDestroyCallbacks):
651         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
652         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
653         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
654         (log):
655         (takeLogStr):
656         (TestWebKitAPI::TEST):
657         (TestWebKitAPI::returnOutChar):
658         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
659         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
660         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
661         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
662         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
663         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
664         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
665         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
666         (TestWebKitAPI::basicRescheduling): Deleted.
667         (TestWebKitAPI::TEST): Deleted.
668         (TestWebKitAPI::reentrantRescheduling): Deleted.
669         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
670         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
671         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
672         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
673         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
674         (log): Deleted.
675         (takeLogStr): Deleted.
676         (TestWebKitAPI::TEST): Deleted.
677         (TestWebKitAPI::returnOutChar): Deleted.
678         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
679         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
680         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
681         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
682         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
683         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
684         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
685         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
686         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
687         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
688         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
689         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
690         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
691         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
692         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
693         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
694         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
695         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
696         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
697         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
698         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
699         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
700         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
701         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
702         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
703         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
704         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
705         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
706         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
707         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
708         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
709         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
710         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
711         * WebKitTestRunner/InjectedBundle/TestRunner.h:
712         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
713         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
714         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
715         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
716         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
717         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
718         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
719         * WebKitTestRunner/PlatformGTK.cmake:
720         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
721         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
722
723 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
724
725         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
726         https://bugs.webkit.org/show_bug.cgi?id=145913
727
728         Reviewed by Gyuyoung Kim.
729
730         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
731         (TestWebKitAPI::setupGeolocationProvider):
732         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
733         (TestWebKitAPI::setPageLoaderClient):
734         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
735         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
736         * WebKitTestRunner/GeolocationProviderMock.cpp:
737         (WTR::GeolocationProviderMock::GeolocationProviderMock):
738         * WebKitTestRunner/WebNotificationProvider.cpp:
739         (WTR::WebNotificationProvider::provider):
740
741 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
742
743         Fix the libusrsctp build with clang
744         https://bugs.webkit.org/show_bug.cgi?id=145128
745
746         Reviewed by Gyuyoung Kim.
747
748         * efl/jhbuild.modules:
749         * gtk/jhbuild.modules:
750
751 2015-06-11  Mark Lam  <mark.lam@apple.com>
752
753         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
754         https://bugs.webkit.org/show_bug.cgi?id=145872
755
756         Reviewed by Michael Saboff.
757
758         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
759         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
760         - Exercises the JSC ObjC API to call a function which throws an exception.  That
761           exception will be returned as a JSValue instead of an Exception object.  We
762           will use this JSValue to test WebCore::reportException() to confirm that it is
763           able to handle an exception value which is not an Exception object.
764
765 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
766
767         Move cursor to corner and fix safari window size before running benchmark
768         https://bugs.webkit.org/show_bug.cgi?id=145858
769
770         Reviewed by Ryosuke Niwa
771
772         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
773         (OSXBrowserDriver.prepareEnv):
774         (OSXBrowserDriver):
775         (OSXBrowserDriver.moveCursor):
776         (OSXBrowserDriver.getScreenSize):
777         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
778         (OSXChromeDriver.launchUrl):
779         (OSXChromeCanaryDriver.launchUrl):
780         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
781         (OSXFirefoxDriver.launchUrl):
782         (OSXFirefoxNightlyDriver.launchUrl):
783         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
784         (OSXSafariDriver.prepareEnv):
785         (OSXSafariDriver):
786         (OSXSafariDriver.maximizeWindow):
787
788 2015-06-11  Daniel Bates  <dabates@apple.com>
789
790         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
791         https://bugs.webkit.org/show_bug.cgi?id=145319
792
793         Reviewed by David Kilzer.
794
795         Add SPI wrapper header for CoreSimulator and update the source files to reference
796         it instead of directly referencing the CoreSimulator header.
797
798         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
799         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
800         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
801         * LayoutTestRelay/LayoutTestRelay/main.m:
802
803 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
804
805         [EFL] dimmed area for popup does not cover the fullscreen mode.
806         https://bugs.webkit.org/show_bug.cgi?id=145133
807
808         Reviewed by Gyuyoung Kim.
809
810         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
811         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
812
813         * MiniBrowser/efl/main.c:
814         (on_fullscreen_accept):
815         (on_fullscreen_deny):
816         (on_fullscreen_enter):
817
818 2015-06-10  Commit Queue  <commit-queue@webkit.org>
819
820         Unreviewed, rolling out r185442.
821         https://bugs.webkit.org/show_bug.cgi?id=145871
822
823         seems to have broken WTF.StringOperators test (Requested by
824         alexchristensen on #webkit).
825
826         Reverted changeset:
827
828         "[Content Extensions] Limit number of rules."
829         https://bugs.webkit.org/show_bug.cgi?id=145663
830         http://trac.webkit.org/changeset/185442
831
832 2015-06-10  Alex Christensen  <achristensen@webkit.org>
833
834         [Content Extensions] Make max NFA size and max rule count user defaults.
835         https://bugs.webkit.org/show_bug.cgi?id=145663
836         rdar://problem/21242407
837
838         Reviewed by Benjamin Poulain.
839
840         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
841         (TestWebKitAPI::TEST_F):
842
843 2015-06-10  Hyungwook Lee  <hyungwook.lee@navercorp.com>
844
845         [EFL] Execute Javascript method in mini browser address bar.
846         https://bugs.webkit.org/show_bug.cgi?id=145725
847
848         Reviewed by Gyuyoung Kim.
849
850         Support 'javascript:' scheme in WebKit EFL Mini Browser.
851
852         * MiniBrowser/efl/main.c:
853         (url_from_user_input):
854         (url_load_from_user_input):
855         (on_url_bar_activated):
856         (elm_main):
857
858 2015-06-09  Hyungwook Lee  <hyungwook.lee@navercorp.com>
859
860         Implement dumpProgressFinishedCallback() for Win layoutTestController.
861         https://bugs.webkit.org/show_bug.cgi?id=66773
862
863         Reviewed by Darin Adler.
864
865         * DumpRenderTree/win/FrameLoadDelegate.cpp:
866         * DumpRenderTree/win/FrameLoadDelegate.h:
867
868 2015-06-09  Ryosuke Niwa  <rniwa@webkit.org>
869
870         run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
871         https://bugs.webkit.org/show_bug.cgi?id=145764
872
873         Reviewed by Darin Adler.
874
875         Added the support for checkout a subversion directory in run-benchmark and used in the plans for
876         JetStream and SunSpider.
877
878         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
879         (GenericBenchmarkBuilder):
880         (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept
881         the whole JSON as the input.
882         (GenericBenchmarkBuilder._checkoutWithSubverion): Added.
883         (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead.
884         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
885         (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in
886         a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare.
887         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
888         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
889
890 2015-06-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
891
892         Remove ewstool scripts used by chromium port
893         https://bugs.webkit.org/show_bug.cgi?id=145789
894
895         Reviewed by Csaba Osztrogonác.
896
897         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
898         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
899         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
900         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
901         * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
902
903 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
904
905         Unreviewed, updated my list of email addresses.
906
907         * Scripts/webkitpy/common/config/contributors.json:
908
909 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
910
911         [cmake] Fix the style issues in cmake project files
912         https://bugs.webkit.org/show_bug.cgi?id=145755
913
914         Reviewed by Darin Adler.
915
916         * TestWebKitAPI/CMakeLists.txt:
917         * TestWebKitAPI/PlatformEfl.cmake:
918
919 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
920
921         Fix a typo in r185345.
922
923         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
924         (OSXSafariDriver.closeBrowsers):
925
926 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
927
928         Yet another unreviewed build fix :(
929
930         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
931         (OSXSafariDriver):
932         (OSXSafariDriver.launchUrl):
933         (OSXSafariDriver.closeBrowsers):
934
935 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
936
937         Unreviewed build fix. Initialize result in the case things blow up below.
938
939         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
940         (BenchmarkRunner.execute):
941
942 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
943
944         Partially revert and fix after r185243.
945
946         * Scripts/benchmark_runner/benchmark_runner.py:
947         * Scripts/run-benchmark:
948
949 2015-06-08  Daniel Bates  <dabates@apple.com>
950
951         Many LayoutTests/http tests time out in DumpRenderTree
952         https://bugs.webkit.org/show_bug.cgi?id=145770
953         <rdar://problem/19593910>
954
955         Reviewed by Alexey Proskuryakov.
956
957         * DumpRenderTree/ios/Info.plist: Add ATS key.
958         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
959         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
960         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
961         that make use of testRunner.pathToLocalResource().
962
963 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
964
965         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
966         https://bugs.webkit.org/show_bug.cgi?id=145759
967
968         Reviewed by Carlos Garcia Campos.
969
970         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
971         (testWebViewSave):
972
973 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
974
975         [GTK] Add editor mode to MiniBrowser
976         https://bugs.webkit.org/show_bug.cgi?id=145595
977
978         Reviewed by Sergio Villar Senin.
979
980         It loads an empty editable web view with an edit toolbar. It makes
981         easier to test the editor, editing commands and input methods.
982
983         * MiniBrowser/gtk/BrowserWindow.c:
984         (editingCommandCallback):
985         (browserWindowSetupEditorToolbar):
986         (browserWindowConstructed):
987         * MiniBrowser/gtk/main.c:
988         (createBrowserWindow):
989
990 2015-06-05  Zalan Bujtas  <zalan@apple.com>
991
992         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
993
994         Reviewed by Dan Bernstein.
995
996         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
997         (TestWebKitAPI::TEST):
998
999 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1000
1001         [EFL] API test has been broken since r184357
1002         https://bugs.webkit.org/show_bug.cgi?id=145635
1003
1004         Reviewed by Darin Adler.
1005
1006         r184357 suppress cmake build warning using TARGET_FILE property. However
1007         many EFL API test cases have been broken after applying it.
1008
1009         * TestWebKitAPI/CMakeLists.txt:
1010
1011 2015-06-05  Anders Carlsson  <andersca@apple.com>
1012
1013         Make the network cache directory part of WKContextConfigurationRef
1014         https://bugs.webkit.org/show_bug.cgi?id=145711
1015
1016         Reviewed by Antti Koivisto.
1017
1018         * WebKitTestRunner/TestController.cpp:
1019         (WTR::TestController::initialize):
1020
1021 2015-06-05  Anders Carlsson  <andersca@apple.com>
1022
1023         Make the application cache directory part of WKContextConfigurationRef
1024         https://bugs.webkit.org/show_bug.cgi?id=145704
1025
1026         Reviewed by Geoffrey Garen.
1027
1028         * WebKitTestRunner/TestController.cpp:
1029         (WTR::TestController::initialize):
1030
1031 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1032
1033         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
1034         https://bugs.webkit.org/show_bug.cgi?id=145680
1035
1036         Reviewed by Brent Fulgham.
1037
1038         * Scripts/webkitpy/style/checkers/cpp.py:
1039         (check_for_null):
1040         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1041         (WebKitStyleTest.test_null_false_zero):
1042
1043 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1044
1045         Make the web server more robust to timing issues..
1046
1047         Reviewed by Ryosuke Niwa.
1048
1049         Cleaned up exception handling.
1050         Test server is actually serving pages before returning.
1051         Clean up some style issues.
1052
1053         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
1054         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1055         (SimpleHTTPServerDriver.__init__):
1056         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
1057         (SimpleHTTPServerDriver.baseUrl): 
1058         (SimpleHTTPServerDriver.fetchResult):
1059         (SimpleHTTPServerDriver.killServer):
1060         (SimpleHTTPServerDriver.getReturnCode):
1061
1062 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1063
1064
1065         Add errors to run-benchmark exception handling.
1066
1067         Reviewed by Ryosuke Niwa.
1068
1069         * Scripts/run-benchmark:
1070         (main):
1071         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1072         (GenericBenchmarkBuilder.prepare):
1073         (GenericBenchmarkBuilder._runCreateScript):
1074         (GenericBenchmarkBuilder._applyPatch):
1075         (GenericBenchmarkBuilder.clean):
1076         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1077         (BenchmarkRunner.__init__):
1078         (BenchmarkRunner.execute):
1079         (BenchmarkRunner):
1080         (BenchmarkRunner.cleanup):
1081         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
1082         (GenericFactory.iterateGetItem):
1083         (GenericFactory.create):
1084         * Scripts/webkitpy/benchmark_runner/utils.py:
1085         (loadModule):
1086         (loadJSONFromFile):
1087         (forceRemove):
1088
1089 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1090
1091         Streamline run-benchmark browser
1092
1093         Reviewed by Ryosuke Niwa.
1094
1095         Add Caffeinate so computer won't sleep while running.
1096         Remove calls to collect output since we were just dumping to stdout anyway.
1097         Add xpc dyld_path.
1098         Default to system safari.
1099
1100         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1101         (OSXBrowserDriver.launchProcess):
1102         (OSXBrowserDriver.terminateProcesses):
1103         (OSXBrowserDriver):
1104         (OSXBrowserDriver.launchCaffeinateForProcess):
1105         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1106         (OSXSafariDriver.launchUrl):
1107         (OSXSafariDriver.closeBrowsers):
1108
1109 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
1110
1111         Combine tiny DFAs into slightly larger ones
1112         https://bugs.webkit.org/show_bug.cgi?id=145572
1113
1114         Reviewed by Alex Christensen.
1115
1116         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1117         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
1118         (TestWebKitAPI::DFACombinerTest::SetUp):
1119         (TestWebKitAPI::combine):
1120         (TestWebKitAPI::TEST_F):
1121         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
1122         (TestWebKitAPI::countLiveNodes):
1123         (TestWebKitAPI::createNFAs):
1124         (TestWebKitAPI::buildDFAFromPatterns):
1125         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1126         (TestWebKitAPI::countLiveNodes): Deleted.
1127         (TestWebKitAPI::createNFAs): Deleted.
1128         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
1129
1130 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
1131
1132         WebKitTestRunner leaks strings in generateWhitelist()
1133         https://bugs.webkit.org/show_bug.cgi?id=145665
1134
1135         Reviewed by Myles C. Maxfield.
1136
1137         * WebKitTestRunner/mac/TestControllerMac.mm:
1138         (WTR::generateWhitelist):
1139
1140 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
1141
1142         Fix options in build-jsc for CMake builds
1143         https://bugs.webkit.org/show_bug.cgi?id=145636
1144
1145         Reviewed by Gyuyoung Kim.
1146
1147         CMake only accepts -DXXX=YYY style options.
1148         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
1149
1150         * Scripts/build-jsc:
1151
1152 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
1153
1154         Added a patch so that the colors displayed on the page could be toggled
1155         in case people need accessibility colors displayed in their browser.
1156         https://bugs.webkit.org/show_bug.cgi?id=145570
1157         <rdar://problem/20994468>
1158
1159         Added in CSS colors and toggle buttons for checkmarks in the page, so that
1160         the page could be rendered in a specific way for accessibility needs if needed.
1161
1162         Reviewed by Alexey Proskuryakov.
1163
1164         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1165         (updateHiddenPlatforms):
1166         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
1167         (toggleAccessibilityColors): Toggle colors on and off
1168         (documentReady): Needed to make changes to the initialization
1169         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1170         (a:hover):
1171         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
1172         (div.cellButton.hide, div.accessibilityButton.hide):
1173         (div.cellButton.unhide, div.accessibilityButton.unhide):
1174         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
1175         (.popover-tracking:hover):
1176         (.accessibilityButton):
1177         (div.cellButton): Deleted.
1178         (div.cellButton.hide): Deleted.
1179         (div.cellButton.unhide): Deleted.
1180         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
1181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1182         (.status-line.neutral .bubble):
1183         (.status-line.unauthorized .bubble):
1184         (.status-line.danger .bubble.pictogram):
1185         (.status-line.bad .bubble.pictogram):
1186         (.status-line.no-bubble .message):
1187         (.status-line.bad .bubble):
1188         (.status-line.good .bubble):
1189         (.status-line.good .message):
1190         (.status-line.bad .message):
1191         (body.accessibility-colors .status-line.good .bubble):
1192         (body.accessibility-colors .status-line.bad .bubble):
1193         (body.accessibility-colors .status-line.good .message):
1194         (body.accessibility-colors .status-line.bad .message):
1195         (.status-line.danger .message):
1196         (.status-line.unauthorized .message):
1197
1198 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
1199
1200         Unreviewed build fix for Dromaeo.
1201
1202         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1203         (BenchmarkResults._aggregate_results_for_test):
1204
1205 2015-06-03  Anders Carlsson  <andersca@apple.com>
1206
1207         Fix build.
1208
1209         * DumpRenderTree/mac/TestRunnerMac.mm:
1210
1211 2015-06-03  Daniel Bates  <dabates@apple.com>
1212
1213         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
1214         https://bugs.webkit.org/show_bug.cgi?id=145616
1215
1216         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
1217         of the test. Further investigation is needed.
1218
1219         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
1220         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
1221
1222 2015-06-03  Brady Eidson  <beidson@apple.com>
1223
1224         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
1225         https://bugs.webkit.org/show_bug.cgi?id=145580
1226
1227         Reviewed by Mark Lam.
1228
1229         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1230         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
1231
1232 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
1233
1234         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
1235
1236         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
1237         (TestWebKitAPI::TEST): Update the syntax.
1238
1239 2015-06-02  Mark Lam  <mark.lam@apple.com>
1240
1241         build-jsc's --cloop option is broken.
1242         https://bugs.webkit.org/show_bug.cgi?id=145516
1243
1244         Reviewed by Darin Adler.
1245
1246         * Scripts/build-jsc:
1247         - Make sure to disable the JIT when --cloop is specified.
1248           Did analogous fix for --ftljit.
1249
1250 2015-06-02  Daniel Bates  <dabates@apple.com>
1251
1252         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
1253
1254         Rubber-stamped by Alexey Proskuryakov.
1255
1256         * MiniBrowser/mac/Info.plist:
1257         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1258
1259 2015-06-01  Commit Queue  <commit-queue@webkit.org>
1260
1261         Unreviewed, rolling out r185066.
1262         https://bugs.webkit.org/show_bug.cgi?id=145543
1263
1264         it breaks the FTL JIT builds with a local checkout of llvm
1265         (Requested by pizlo on #webkit).
1266
1267         Reverted changeset:
1268
1269         "build-jsc's --cloop option is broken."
1270         https://bugs.webkit.org/show_bug.cgi?id=145516
1271         http://trac.webkit.org/changeset/185066
1272
1273 2015-06-01  Daniel Bates  <dabates@apple.com>
1274
1275         Notify client that we began editing when text field is focused
1276         https://bugs.webkit.org/show_bug.cgi?id=145439
1277         <rdar://problem/21142108>
1278
1279         Reviewed by Anders Carlsson.
1280
1281         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
1282         a text field is focused and defocused.
1283
1284         * TestWebKitAPI/CMakeLists.txt:
1285         * TestWebKitAPI/PlatformEfl.cmake:
1286         * TestWebKitAPI/PlatformGTK.cmake:
1287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1288         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
1289         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
1290         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
1291         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
1292         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
1293         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
1294         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
1295         (TestWebKitAPI::TEST_F):
1296         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
1297         (TestWebKitAPI::textFieldDidBeginEditing):
1298         (TestWebKitAPI::textFieldDidEndEditing):
1299         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
1300         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
1301         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
1302
1303 2015-06-01  Alex Christensen  <achristensen@webkit.org>
1304
1305         [Content Extensions] resource-type and load-type should be independent.
1306         https://bugs.webkit.org/show_bug.cgi?id=145528
1307         rdar://problem/21190765
1308
1309         Reviewed by Benjamin Poulain.
1310
1311         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1312         (TestWebKitAPI::TEST_F):
1313
1314 2015-06-01  Daniel Bates  <dabates@apple.com>
1315
1316         Add ATS keys to WebKitTestRunnerApp
1317         https://bugs.webkit.org/show_bug.cgi?id=145519
1318
1319         Reviewed by Alexey Proskuryakov.
1320
1321         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
1322
1323         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1324
1325 2015-06-01  Brady Eidson  <beidson@apple.com>
1326
1327         Add WKTR support for "should open external URLs".
1328         https://bugs.webkit.org/show_bug.cgi?id=145505
1329
1330         Reviewed by Darin Adler.
1331
1332         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
1333           "should open external URLs" bit set.
1334         
1335         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
1336           the policy delegate, including whether or not the bit was set.
1337         
1338         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1339         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1340         (WTR::TestRunner::queueLoad):
1341         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1342         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
1343         (WTR::TestRunner::shouldDumpPolicyCallbacks):
1344         
1345         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1346         (WTR::InjectedBundle::queueLoad):
1347         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1348
1349         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1350         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1351
1352         * WebKitTestRunner/TestInvocation.cpp:
1353         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1354
1355         * WebKitTestRunner/WorkQueueManager.cpp:
1356         (WTR::WorkQueueManager::queueLoad):
1357         * WebKitTestRunner/WorkQueueManager.h:
1358
1359 2015-06-01  Mark Lam  <mark.lam@apple.com>
1360
1361         build-jsc's --cloop option is broken.
1362         https://bugs.webkit.org/show_bug.cgi?id=145516
1363
1364         Reviewed by Darin Adler.
1365
1366         * Scripts/build-jsc:
1367         - Make sure to disable the JIT when --cloop is specified.
1368           Did analogous fix for --ftljit.
1369
1370 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1371
1372         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
1373         https://bugs.webkit.org/show_bug.cgi?id=144959
1374
1375         Reviewed by Darin Adler.
1376
1377         * Scripts/webkitpy/style/checkers/cmake.py:
1378         (CMakeChecker.check): Use enumerate instead of xrange.
1379         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
1380         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1381         (CMakeCheckerTest.test_check): Update the expected results.
1382
1383 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1384
1385         Fix the webkitpy scm unittests after r174051
1386         https://bugs.webkit.org/show_bug.cgi?id=145511
1387
1388         Reviewed by Darin Adler.
1389
1390         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1391         (GitTestWithMock.make_scm):
1392
1393 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1394
1395         EWS provides misleading information for not applyable patches
1396         https://bugs.webkit.org/show_bug.cgi?id=145307
1397
1398         Reviewed by Alexey Proskuryakov.
1399
1400         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
1401
1402 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
1403
1404         Further tweak results of WebKit1.StringTruncator after r184965.
1405
1406         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1407
1408 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1409
1410         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
1411         https://bugs.webkit.org/show_bug.cgi?id=145264
1412
1413         Reviewed by Carlos Garcia Campos.
1414
1415         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
1416
1417 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1418
1419         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
1420
1421         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1422         (BenchmarkResults._lint_subtest_results):
1423         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
1424         (test_aggregate_nested_results):
1425         (test_lint_results):
1426         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
1427
1428 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
1429
1430         run-benchmark should print out the results
1431         https://bugs.webkit.org/show_bug.cgi?id=145398
1432
1433         Reviewed by Antti Koivisto.
1434
1435         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
1436         of the output to catch early errors.
1437
1438         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
1439         (BenchmarkResults): Added.
1440         (BenchmarkResults.__init__): Added.
1441         (BenchmarkResults.format): Added.
1442         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
1443         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
1444         Uses the sample standard deviation to compute the significant figures for the value.
1445         (BenchmarkResults._unit_from_metric): Added.
1446         (BenchmarkResults._aggregate_results): Added.
1447         (BenchmarkResults._aggregate_results_for_test): Added.
1448         (BenchmarkResults._flatten_list): Added.
1449         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
1450         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
1451         (BenchmarkResults._aggregate_values): Added.
1452         (BenchmarkResults._lint_results): Added.
1453         (BenchmarkResults._lint_subtest_results): Added.
1454         (BenchmarkResults._lint_aggregator_list): Added.
1455         (BenchmarkResults._lint_configuration): Added.
1456         (BenchmarkResults._lint_values): Added.
1457         (BenchmarkResults._is_numeric): Added.
1458         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
1459         (BenchmarkResultsTest):
1460         (BenchmarkResultsTest.test_init):
1461         (BenchmarkResultsTest.test_format):
1462         (test_format_values_with_large_error):
1463         (test_format_values_with_small_error):
1464         (test_format_values_with_time):
1465         (test_format_values_with_no_error):
1466         (test_format_values_with_small_difference):
1467         (test_aggregate_results):
1468         (test_aggregate_results_with_gropus):
1469         (test_aggregate_nested_results):
1470         (test_lint_results):
1471         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1472         (BenchmarkRunner.execute): Added a call to show_results
1473         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
1474         (BenchmarkRunner.show_results): Added.
1475
1476 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
1477
1478         run_benchmark should have an option to specify the number of runs
1479         https://bugs.webkit.org/show_bug.cgi?id=145091
1480
1481         Reviewed by Antti Koivisto.
1482
1483         Added --count option.
1484
1485         * Scripts/run-benchmark:
1486         (main):
1487         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1488         (BenchmarkRunner.__init__):
1489
1490 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
1491
1492         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
1493
1494         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
1495
1496 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
1497
1498         Update results of WebKit1.StringTruncator after r184965.
1499
1500         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
1501
1502 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1503
1504         Unreviewed, updated my list of email addresses.
1505
1506         * Scripts/webkitpy/common/config/contributors.json:
1507
1508 2015-05-27  Dean Jackson  <dino@apple.com>
1509
1510         img.currentSrc problem in strict mode with old picturefill
1511         https://bugs.webkit.org/show_bug.cgi?id=144095
1512         <rdar://problem/21087013>
1513
1514         Reviewed by Simon Fraser.
1515
1516         Add a PICTURE_SIZES flag.
1517
1518         * Scripts/webkitperl/FeatureList.pm:
1519
1520 2015-05-26  Dana Burkart  <dburkart@apple.com>
1521
1522         Fixes compatibility issues with recent dashboard cleanup.
1523         https://bugs.webkit.org/show_bug.cgi?id=144814
1524
1525         Reviewed by Alexey Proskuryakov.
1526
1527         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
1528         (BuildbotStaticAnalyzerQueueView):
1529         (BuildbotStaticAnalyzerQueueView.prototype.update):
1530         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1531         (documentReady):
1532
1533 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
1534
1535         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
1536         https://bugs.webkit.org/show_bug.cgi?id=143091
1537         rdar://problem/19330328
1538
1539         Reviewed by Darin Adler and Timothy Hatcher.
1540
1541         We have many of these, which are hard to fit on the dashboard. Added a view that
1542         collapses to a single green bubble when everything is good, and expands when there
1543         are failures (or manually).
1544
1545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
1546
1547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1548         (Buildbot.prototype.set isAuthenticated):
1549         (Buildbot.prototype._normalizeQueueInfo):
1550         (Buildbot.prototype._normalizeQueuesInfo):
1551         (Buildbot.prototype.updateQueues):
1552         Moved queue info normalization here from BuildbitQueue. The latter is a model class
1553         that shouldn't have to know about presentation, and this lets us leep the knowledge
1554         about combined queues out if it. Later, we can refactor existing code, and move out
1555         all knowledge about headings and such.
1556
1557         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1558         Added the new view. It's not quite universal, and doesn't have as helpful popovers
1559         as other views, but we can extend it when/if we use it for more than JSC.
1560
1561         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1562         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
1563
1564         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1565         (documentReady): Added support for combined queues. These are currently always ending up
1566         in Other column, but it's easy to customize in the future if we need to.
1567
1568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1569         (WebKitBuildbot): Added JSC queus.
1570
1571         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1572         (.combined-queue-popover):
1573         (.combined-queue-popover .revision):
1574         Added styles for the combined view.
1575
1576 2015-05-26  Dan Bernstein  <mitz@apple.com>
1577
1578         Changed a file to use Unix line endings.
1579
1580         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1581
1582 2015-05-26  Dan Bernstein  <mitz@apple.com>
1583
1584         <rdar://problem/21104551> Update build settings
1585
1586         Reviewed by Anders Carlsson.
1587
1588         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1589         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1590         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1591         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1592         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1593         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1594         * asan/asan.xcconfig:
1595
1596 2015-05-26  Anders Carlsson  <andersca@apple.com>
1597
1598         Fix build.
1599
1600         * WebKitTestRunner/mac/EventSenderProxy.mm:
1601         (WTR::EventSenderProxy::mouseForceDown):
1602         (WTR::EventSenderProxy::mouseForceUp):
1603         (WTR::EventSenderProxy::mouseForceChanged):
1604
1605 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
1606
1607         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
1608         https://bugs.webkit.org/show_bug.cgi?id=145342
1609
1610         Reviewed by Darin Adler.
1611
1612         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1613         (BuildbotIteration.prototype._parseData):
1614
1615 2015-05-26  Milan Crha  <mcrha@redhat.com>
1616
1617         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
1618         https://bugs.webkit.org/show_bug.cgi?id=138134
1619
1620         Reviewed by Žan Doberšek.
1621
1622         * gtk/generate-inspector-gresource-manifest.py:
1623         (get_filenames): Command line with expanded resources exceeds 32KB, which
1624         is a limit on Windows. It's better to expand wildcards inside the python script.
1625
1626 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1627
1628         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
1629         https://bugs.webkit.org/show_bug.cgi?id=140882
1630
1631         Reviewed by Gustavo Noronha Silva.
1632
1633         Make sure unit tests write IndexedDB databases to the temporary
1634         directory, and add a test case to check that the directory is
1635         correctly created at the expected path.
1636
1637         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1638         (testWebContextConfiguration):
1639         (serverCallback):
1640         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1641         (Test::Test):
1642
1643 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1644
1645         [GTK] Enable IndexedDB
1646         https://bugs.webkit.org/show_bug.cgi?id=98932
1647
1648         Reviewed by Žan Doberšek.
1649
1650         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
1651
1652 2015-05-24  Sam Weinig  <sam@webkit.org>
1653
1654         Crash when using a removed ScriptMessageHandler
1655         <rdar://problem/20888499>
1656         https://bugs.webkit.org/show_bug.cgi?id=145359
1657
1658         Reviewed by Dan Bernstein.
1659
1660         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1661         Add tests for removing script message handlers.
1662
1663 2015-05-23  Dan Bernstein  <mitz@apple.com>
1664
1665         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
1666         https://bugs.webkit.org/show_bug.cgi?id=145345
1667
1668         Reviewed by Sam Weinig.
1669
1670         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1671         * LayoutTestRelay/Configurations/Base.xcconfig:
1672         * TestWebKitAPI/Configurations/Base.xcconfig:
1673         * WebKitTestRunner/Configurations/Base.xcconfig:
1674
1675 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1676
1677         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
1678         https://bugs.webkit.org/show_bug.cgi?id=144848
1679
1680         Reviewed by Darin Adler.
1681
1682         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
1683
1684         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1685
1686 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
1687
1688         Fix one more merge error in static analyzer support.
1689
1690         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
1691         (BuildbotStaticAnalyzerQueueView):
1692
1693 2015-05-22  Dana Burkart  <dburkart@apple.com>
1694
1695         Fix internal dashboard breakage from recent commit.
1696         https://bugs.webkit.org/show_bug.cgi?id=144814
1697
1698         Unreviewed build fix.
1699
1700         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
1701         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
1702         (BuildbotStaticAnalyzerQueueView.prototype.update):
1703
1704 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
1705
1706         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
1707         https://bugs.webkit.org/show_bug.cgi?id=130463
1708         rdar://problem/20461342
1709
1710         Reviewed by Tim Horton.
1711
1712         This was more of a timing related flakiness than an actual OS version specific bug,
1713         we weren't getting window visibility notifications.
1714         
1715         I will look into adding this function call to DumpRenderTree separately, layout tests
1716         might actually rely on the broken behavior.
1717
1718         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1719         (TestWebKitAPI::TEST_F):
1720         * TestWebKitAPI/mac/mainMac.mm:
1721         (main):
1722
1723 2015-05-22  Dana Burkart  <dburkart@apple.com>
1724
1725         Add missing file from r184804 (mis-applied diff).
1726         https://bugs.webkit.org/show_bug.cgi?id=144814
1727
1728         Reviewed by Alexey Proskuryakov.
1729
1730         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
1731         (BuildbotStaticAnalyzerQueueView):
1732         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
1733         (BuildbotStaticAnalyzerQueueView.prototype.update):
1734
1735 2015-05-22  Dana Burkart  <dburkart@apple.com>
1736
1737         Add support to the botwatchers dashboard for a static analyzer bot.
1738         https://bugs.webkit.org/show_bug.cgi?id=144814
1739
1740         Reviewed by Alexey Proskuryakov.
1741
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1743         scan-build should be considered a productive step.
1744
1745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1746         (BuildbotQueue):
1747         Adds support for the staticAnalyzer property
1748
1749         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1750         (BuildbotTestResults.prototype._parseResults):
1751         Get bug count from the scan-build step output
1752
1753         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1754         (documentReady):
1755         Rename the performance column 'Other', and merge the current 'Other' column with it.
1756
1757         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1758         (WebKitBuildbot):
1759         Now that performance bots are part of the 'Other' column, give them better headings.
1760
1761 2015-05-22  Tim Horton  <timothy_horton@apple.com>
1762
1763         Turn on autosaving of toolbar configuration in MiniBrowser
1764
1765         Rubber-stamped by Dan Bernstein.
1766
1767         * MiniBrowser/mac/BrowserWindow.xib:
1768
1769 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
1770
1771         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
1772         https://bugs.webkit.org/show_bug.cgi?id=145297
1773
1774         Reviewed by Tim Horton.
1775
1776         This is a refactoring to simplify code, and to make it more logical.
1777
1778         It is up to the view to decide how to present the queues, and whether to split
1779         them into debug and release, or in some different way.
1780
1781         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1782         (BuildbotBuilderQueueView.filterQueues):
1783         (BuildbotBuilderQueueView):
1784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1785         (BuildbotLeaksQueueView):
1786         (BuildbotLeaksQueueView.prototype.update):
1787         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
1788         (BuildbotPerformanceQueueView):
1789         (BuildbotPerformanceQueueView.prototype.update):
1790         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1791         (BuildbotQueueView):
1792         (BuildbotQueueView.prototype._updateQueues):
1793         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1794         (BuildbotTesterQueueView):
1795         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1796         (documentReady):
1797
1798 2015-05-22  Tim Horton  <timothy_horton@apple.com>
1799
1800         Remove action menu support
1801         https://bugs.webkit.org/show_bug.cgi?id=145305
1802         <rdar://problem/21070771>
1803
1804         Reviewed by Anders Carlsson.
1805
1806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1807         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
1808         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
1809         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
1810         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
1811         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
1812         Remove the tests.
1813
1814 2015-05-22  Dan Bernstein  <mitz@apple.com>
1815
1816         Removed the Use Shrink To Fit button from the toolbar’s default set.
1817
1818         Rubber-stamped by Tim Horton.
1819
1820         * MiniBrowser/mac/BrowserWindow.xib:
1821
1822 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
1823
1824         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
1825         https://bugs.webkit.org/show_bug.cgi?id=128420
1826
1827         Reviewed by Chris Fleizach.
1828
1829         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1830         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
1831
1832 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
1833
1834         [EFL] Bump libsoup version to 2.50.0
1835         https://bugs.webkit.org/show_bug.cgi?id=145127
1836
1837         Reviewed by Gyuyoung Kim.
1838
1839         * efl/jhbuild.modules:
1840         * efl/patches/soup-clang-warning-fix1.patch: Removed.
1841         * efl/patches/soup-clang-warning-fix2.patch: Removed.
1842
1843 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
1844
1845         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
1846         https://bugs.webkit.org/show_bug.cgi?id=145117
1847
1848         Reviewed by Csaba Osztrogonác.
1849
1850         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
1851         Tools/TestWebKitAPI/Tests/WTF/glib/.
1852
1853         * TestWebKitAPI/PlatformGTK.cmake:
1854         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
1855         (TestWebKitAPI::TEST):
1856
1857 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
1858
1859         [EFL] fix efreet error
1860         https://bugs.webkit.org/show_bug.cgi?id=143670
1861
1862         Reviewed by Gyuyoung Kim.
1863
1864         Fix efreet error by using external variable efreet_cache_update.
1865         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
1866         efreet error for efreet_cache does not occur.
1867
1868         * MiniBrowser/efl/main.c:
1869         (elm_main):
1870
1871 2015-05-20  Michael Saboff  <msaboff@apple.com>
1872
1873         Add option to run_jsc_stress_tests to disable JIT testing
1874         https://bugs.webkit.org/show_bug.cgi?id=145233
1875
1876         Reviewed by Mark Lam.
1877
1878         Added --no-jit option.
1879
1880         * Scripts/run-jsc-stress-tests:
1881
1882 2015-05-20  Alex Christensen  <achristensen@webkit.org>
1883
1884         Use correct String for StringView in WTF API tests
1885         https://bugs.webkit.org/show_bug.cgi?id=145226
1886         rdar://problem/20361786
1887
1888         Reviewed by Benjamin Poulain.
1889
1890         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1891         (TestWebKitAPI::TEST):
1892         Use patternHolder for pattern.
1893
1894 2015-05-20  Alex Christensen  <achristensen@webkit.org>
1895
1896         [Content Extensions] Relax restrictions on triggers that match everything.
1897         https://bugs.webkit.org/show_bug.cgi?id=145069
1898
1899         Reviewed by Benjamin Poulain.
1900
1901         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1902         (TestWebKitAPI::TEST_F):
1903         Update and add tests for new possibilities with .*
1904
1905 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
1906
1907         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
1908         https://bugs.webkit.org/show_bug.cgi?id=144992
1909
1910         Reviewed by Gyuyoung Kim.
1911
1912         * MiniBrowser/efl/main.c:
1913         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
1914         (on_key_down):
1915         (on_fullscreen_enter):
1916         (on_fullscreen_exit):
1917         (window_create):
1918
1919 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1920
1921         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
1922         https://bugs.webkit.org/show_bug.cgi?id=145109
1923
1924         Reviewed by Darin Adler.
1925
1926         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1927         (TestWebKitAPI::TEST):
1928
1929 2015-05-19  Anders Carlsson  <andersca@apple.com>
1930
1931         Add alternate menu items for performing operations on the default data store
1932         https://bugs.webkit.org/show_bug.cgi?id=145184
1933
1934         Reviewed by Sam Weinig.
1935
1936         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
1937         associated with a data store.
1938
1939         * MiniBrowser/mac/AppDelegate.m:
1940         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
1941         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
1942         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
1943         * MiniBrowser/mac/MainMenu.xib:
1944
1945 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
1946
1947         Fix tautological-compare warning in AtomicString.cpp
1948         https://bugs.webkit.org/show_bug.cgi?id=145120
1949
1950         Reviewed by Alexey Proskuryakov.
1951
1952         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1953         (TestWebKitAPI::TEST): Removed always true assert.
1954
1955 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
1956
1957         [EFL] Fix unsequenced warning in MiniBrowser's main.c
1958         https://bugs.webkit.org/show_bug.cgi?id=145123
1959
1960         Reviewed by Gyuyoung Kim.
1961
1962         * MiniBrowser/efl/main.c:
1963         (on_key_down):
1964
1965 2015-05-18  Daniel Bates  <dabates@apple.com>
1966
1967         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
1968         when staged non-empty file for commit
1969         https://bugs.webkit.org/show_bug.cgi?id=145082
1970
1971         Reviewed by Darin Adler.
1972
1973         Fixes two issues when running prepare-ChangeLog:
1974             1. The function above a deleted function is reported as changed.
1975             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
1976             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
1977             included in this patch).
1978
1979         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
1980         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
1981         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
1982         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
1983         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
1984         VCSUtil::parseChunkRange() has existing test coverage.
1985
1986         * Scripts/prepare-ChangeLog:
1987         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
1988         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
1989         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
1990         examine files that only have deletions. Currently this works as a side effect of the behavior of
1991         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
1992         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
1993         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
1994         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
1995         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
1996         We return (-1, -1) when the change represents a deletion.
1997         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
1998         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
1999         We return (-1, -1) when the change represents an addition.
2000         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
2001         unit tests.
2002
2003 2015-05-18  Anders Carlsson  <andersca@apple.com>
2004
2005         Add ATS keys to MiniBrowser
2006         https://bugs.webkit.org/show_bug.cgi?id=145141
2007
2008         Reviewed by Sam Weinig.
2009
2010         * MiniBrowser/mac/Info.plist:
2011
2012 2015-05-17  David Kilzer  <ddkilzer@apple.com>
2013
2014         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
2015         <http://webkit.org/b/145100>
2016
2017         Reviewed by Darin Adler.
2018
2019         * Scripts/bisect-builds:
2020         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
2021         - Switch to using PROMPT_RESPONSE_* constants when testing the
2022           value of $didReproduceBug.
2023         - Add do { } while loops to implement 'retry' mode.
2024         (promptForTest):
2025         - Switch to returning PROMPT_RESPONSE_* constants.
2026         - Add support for 'retry' response.
2027
2028 2015-05-16  Tanay C  <tanay.c@samsung.com>
2029
2030         [EFL][WK2] Minibrowser : Add search icon to search bar
2031         https://bugs.webkit.org/show_bug.cgi?id=139773
2032
2033         Reviewed by Gyuyoung Kim.
2034
2035         * MiniBrowser/efl/main.c: 
2036         (search_icon_show): Added.
2037         (search_box_show): Modified.
2038
2039 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
2040
2041         run_benchmark should have an option to specify the number of runs
2042         https://bugs.webkit.org/show_bug.cgi?id=145091
2043
2044         Reviewed by Stephanie Lewis.
2045
2046         Added --count option.
2047
2048         * Scripts/run-benchmark:
2049         (main):
2050         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2051         (BenchmarkRunner.__init__):
2052
2053 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
2054
2055         Temporarily disable failing API test.
2056
2057         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2058         (TestWebKitAPI::TEST):
2059
2060 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
2061
2062         User interruption while running of run-webkit-tests should also generate results.html
2063         https://bugs.webkit.org/show_bug.cgi?id=122154
2064
2065         Reviewed by Csaba Osztrogonác.
2066
2067         Generation of results.html on execution of run-webkit-tests happens only
2068         on completion of entire layout tests run. It should be created even when
2069         the execution has been interrupted - either by user (by pressing Ctrl+C)
2070         or because of other interruptions (like exit-after-n-failures option).
2071
2072         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2073         (LayoutTestRunner.run_tests):
2074         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2075         (Manager.run):
2076         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2077         (TestRunResults.__init__):
2078         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2079         (main):
2080         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2081         (RunTest.test_keyboard_interrupt):
2082         (MainTest.test_exception_handling):
2083
2084 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
2085
2086         [buildbot] Fix the URL of the performance bots
2087         https://bugs.webkit.org/show_bug.cgi?id=145043
2088
2089         Reviewed by Ryosuke Niwa.
2090
2091         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2092
2093 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
2094
2095         Add a layout mode that scales down the view to try to fit the document
2096         https://bugs.webkit.org/show_bug.cgi?id=145022
2097         <rdar://problem/19790341>
2098
2099         Reviewed by Dean Jackson.
2100
2101         * MiniBrowser/mac/BrowserWindow.xib:
2102         * MiniBrowser/mac/BrowserWindowController.h:
2103         * MiniBrowser/mac/WK2BrowserWindowController.m:
2104         (-[WK2BrowserWindowController toggleShrinkToFit:]):
2105         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
2106         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
2107
2108 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
2109
2110         [CMake] Don't read the LOCATION property of targets
2111         https://bugs.webkit.org/show_bug.cgi?id=145018
2112
2113         Reviewed by Martin Robinson.
2114
2115         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
2116         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
2117         be the same at configure-time as it is at generate-time.
2118
2119         * TestWebKitAPI/CMakeLists.txt:
2120
2121 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
2122
2123         Add String literal overloads to equalIgnoringASCIICase()
2124         https://bugs.webkit.org/show_bug.cgi?id=145008
2125
2126         Reviewed by Benjamin Poulain.
2127
2128         Test changes to WTF.
2129
2130         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2131         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
2132         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2133         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2134         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
2135         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2136
2137 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2138
2139         SharedBuffer::createWithContentsOfFile should use map file routines
2140         https://bugs.webkit.org/show_bug.cgi?id=144192
2141
2142         Reviewed by Darin Adler.
2143
2144         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
2145
2146         * TestWebKitAPI/PlatformGTK.cmake:
2147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2148         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
2149         (TestWebKitAPI::FileSystemTest::tempFilePath):
2150         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
2151         (TestWebKitAPI::TEST_F):
2152         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
2153         (TestWebKitAPI::SharedBufferTest::tempFilePath):
2154         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
2155         (TestWebKitAPI::TEST_F):
2156
2157 2015-05-13  Alex Christensen  <achristensen@webkit.org>
2158
2159         [Content Extensions] Test interactions between multiple extensions and multiple domains.
2160         https://bugs.webkit.org/show_bug.cgi?id=144967
2161
2162         Reviewed by Benjamin Poulain.
2163
2164         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2165         Xcode wanted to fix an alphabetization issue.
2166         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2167         (TestWebKitAPI::TEST_F):
2168         Test interactions that worked but were not explicitly tested before.
2169
2170 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2171
2172         Unreviewed build fix.
2173
2174         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
2175
2176         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
2177
2178 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2179
2180         Fix the previous commit, which made both bubbles green.
2181
2182         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2183         (.status-line.good .bubble):
2184         (.status-line.bad .bubble):
2185         (.status-line.good .message):
2186
2187 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2188
2189         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
2190         https://bugs.webkit.org/show_bug.cgi?id=144929
2191
2192         Reviewed by Eric Carlson.
2193
2194         Tweaked colors as I see fit.
2195
2196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2197         (.status-line.good .bubble):
2198         (.status-line.bad .bubble):
2199
2200 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
2201
2202         [Mac] Share cookie storage between UI process and secondary processes
2203         https://bugs.webkit.org/show_bug.cgi?id=144820
2204         rdar://problem/20572830
2205
2206         Reviewed by Darin Adler.
2207
2208         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2209         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
2210         for testing.
2211
2212 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
2213
2214         Fix internal build configuration issues
2215         https://bugs.webkit.org/show_bug.cgi?id=144762
2216
2217         Reviewed by David Kilzer.
2218
2219         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
2220
2221         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2222         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2223         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2224         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2225         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
2226         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2227         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
2228         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2229
2230 2015-05-12  David Kilzer  <ddkilzer@apple.com>
2231
2232         Switch to launching iOS Simulator using bundle ID
2233         <rdar://problem/20916096>
2234
2235         This is required to fix the layout tests on internal bots.
2236
2237         * Scripts/webkitdirs.pm:
2238         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
2239         Simulator.  Add FIXME.
2240         (quitIOSSimulator): Add FIXME.
2241         * Scripts/webkitpy/port/ios.py:
2242         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
2243         launch iOS Simulator.  Add FIXME.
2244         (IOSSimulatorPort.check_sys_deps): Add FIXME.
2245
2246 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
2247
2248         Fix run-javascriptcore-tests step on the WinCairo bot
2249         https://bugs.webkit.org/show_bug.cgi?id=144866
2250
2251         Reviewed by Csaba Osztrogonác.
2252
2253         Catch exception when failing to create soft link, so we can fall back to copy.
2254
2255         * Scripts/run-jsc-stress-tests:
2256
2257 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
2258
2259         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
2260         https://bugs.webkit.org/show_bug.cgi?id=116971
2261
2262         Reviewed by Chris Fleizach.
2263
2264         Implement rowAtIndex for ATK.
2265
2266         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2267         (WTR::AccessibilityUIElement::rowAtIndex):
2268
2269 2015-05-11  Dan Bernstein  <mitz@apple.com>
2270
2271         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
2272
2273         Reviewed by Alexey Proskuryakov.
2274
2275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2276         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
2277         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
2278         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
2279
2280 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
2281
2282         Fix internal build configuration issues
2283         https://bugs.webkit.org/show_bug.cgi?id=144762
2284
2285         Reviewed by Darin Adler.
2286
2287         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
2288
2289         * TestWebKitAPI/Configurations/Base.xcconfig:
2290         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2291         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2292         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2293         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2294         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2295         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2296
2297 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
2298
2299         [Win] Move Windows build target to Windows 7 (or newer)
2300         https://bugs.webkit.org/show_bug.cgi?id=144890
2301         <rdar://problem/20707307>
2302
2303         Reviewed by Anders Carlsson.
2304
2305         Update linked SDK and minimal Windows level to be compatible with
2306         Windows 7 or newer.
2307
2308         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2309         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2310         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2311         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2312         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2313         * DumpRenderTree/config.h:
2314         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2315         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2316         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2317         * WinLauncher/stdafx.h:
2318
2319 2015-05-11  Commit Queue  <commit-queue@webkit.org>
2320
2321         Unreviewed, rolling out r184119.
2322         https://bugs.webkit.org/show_bug.cgi?id=144888
2323
2324         broke JSC tests on Apple Windows bots (Requested by kling on
2325         #webkit).
2326
2327         Reverted changeset:
2328
2329         "Fix run-javascriptcore-tests step on the WinCairo bot"
2330         https://bugs.webkit.org/show_bug.cgi?id=144866
2331         http://trac.webkit.org/changeset/184119
2332
2333 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2334
2335         run-benchmark should support Dromaeo
2336         https://bugs.webkit.org/show_bug.cgi?id=144849
2337
2338         Reviewed by Chris Dumez.
2339
2340         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
2341         they can take as much as 15 minutes to run each.
2342
2343         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
2344         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
2345         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
2346         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
2347
2348 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2349
2350         Build fix. jetstream has a local copy, not remote archive.
2351
2352         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2353
2354 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2355
2356         run-benchmark should support SunSpider, Kraken and Octane
2357         https://bugs.webkit.org/show_bug.cgi?id=144840
2358
2359         Reviewed by Darin Adler.
2360
2361         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
2362         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
2363         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
2364         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
2365
2366         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
2367         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
2368
2369         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
2370         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
2371
2372         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
2373         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
2374         now has the ability to run an arbitrary "create script".
2375
2376         * Scripts/run-benchmark:
2377         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
2378         This also overrides the remote archive URL specified in the plan.
2379
2380         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
2381
2382         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
2383         JetStreamBenchmarkBuilder.
2384
2385         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
2386         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
2387         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
2388         _runCreateScript and _applyPatch to clean after themselves.
2389         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
2390         JetStream, SunSpider, Kraken all use this feature.
2391         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
2392         the leaf directory name since the latter is not available when a remote ZIP file is used.
2393         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
2394         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
2395         the benchmark name in the patches.
2396
2397         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
2398
2399         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2400         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
2401         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
2402         the browser opens by planName as the plan file no longer contains that.
2403
2404         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
2405         the top directory of JetStream instead of its parent.
2406         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
2407         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
2408         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
2409         the top directory of JetStream instead of its parent.
2410         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
2411         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
2412         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
2413         done in JetStream.patch.
2414         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
2415         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
2416         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
2417         path from the top directory of JetStream as done in JetStream.patch.
2418         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
2419
2420 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
2421
2422         Fix run-javascriptcore-tests step on the WinCairo bot
2423         https://bugs.webkit.org/show_bug.cgi?id=144866
2424
2425         Reviewed by Darin Adler.
2426
2427         * Scripts/run-jsc-stress-tests:
2428
2429 2015-05-11  Alex Christensen  <achristensen@webkit.org>
2430
2431         [Content Extensions] Support domain-specific rules and exceptions.
2432         https://bugs.webkit.org/show_bug.cgi?id=144833
2433
2434         Reviewed by Darin Adler.
2435
2436         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2437         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2438         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2439         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2440         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
2441         (TestWebKitAPI::mainDocumentRequest):
2442         (TestWebKitAPI::subResourceRequest):
2443         (TestWebKitAPI::TEST_F):
2444         (TestWebKitAPI::checkCompilerError):
2445         Added tests for parsing and functionality of if-domain and unless-domain.
2446
2447 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2448
2449         run-benchmark should support Chrome Canary and Firefox Nightly
2450         https://bugs.webkit.org/show_bug.cgi?id=144850
2451
2452         Reviewed by Darin Adler.
2453
2454         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
2455
2456         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
2457
2458         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
2459         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
2460         (OSXBrowserDriver):
2461         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
2462         (OSXBrowserDriver.closeBrowsers): Ditto.
2463         (OSXBrowserDriver.launchProcess): Ditto.
2464         (OSXBrowserDriver.terminateProcesses): Ditto.
2465         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2466         (OSXChromeDriver): Removed the unused self.chromePreferences.
2467         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
2468         (OSXChromeDriver.closeBrowsers): Ditto.
2469         (OSXChromeDriver.launchUrl):
2470         (OSXChromeCanaryDriver): Added.
2471         (OSXChromeCanaryDriver.launchUrl):
2472         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
2473         (OSXFirefoxDriver): Added.
2474         (OSXFirefoxDriver.launchUrl):
2475         (OSXFirefoxNightlyDriver): Added.
2476         (OSXFirefoxNightlyDriver.launchUrl):
2477         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2478         (OSXSafariDriver):
2479         (OSXSafariDriver.closeBrowsers):
2480
2481 2015-05-11  Tim Horton  <timothy_horton@apple.com>
2482
2483         Page overlay action context override should indicate the source of the request
2484         https://bugs.webkit.org/show_bug.cgi?id=144832
2485         <rdar://problem/20562594>
2486
2487         Reviewed by Darin Adler.
2488
2489         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
2490         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
2491
2492 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
2493
2494         [GTK] fast/events/page-visibility-transition-test.html is timing out
2495         https://bugs.webkit.org/show_bug.cgi?id=114789
2496
2497         Reviewed by Darin Adler.
2498
2499         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2500         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
2501         requests visibility changes.
2502
2503 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
2504
2505         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
2506         https://bugs.webkit.org/show_bug.cgi?id=144798
2507
2508         Reviewed by Darin Adler.
2509
2510         * efl/install-dependencies:
2511
2512 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
2513
2514         Make arguments of run-benchmark more user friendly
2515         https://bugs.webkit.org/show_bug.cgi?id=144835
2516
2517         Reviewed by Darin Adler.
2518
2519         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
2520         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
2521         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
2522         default values from --platform and --browser as they are required arguments.
2523
2524         * Scripts/run-benchmark:
2525         (main): Made --build-directory optional, and removed default values from --platform and --browser.
2526         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
2527         are not dynamically obtained via BrowserDriverFactory.
2528         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2529         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
2530         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
2531         run any benchmark in that case.
2532         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
2533         the specified file isn't a valid relative or an absolute path.
2534         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2535         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
2536         and browsers.
2537         (BrowserDriverFactory.available_browsers): Ditto.
2538         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2539         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
2540         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
2541         browserBuildPath was None.
2542         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2543         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
2544         so that we can use locally built WebKit to launch Safari.
2545
2546 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
2547
2548         Remove the PICTURE_SIZES build flag
2549         https://bugs.webkit.org/show_bug.cgi?id=144679
2550
2551         Reviewed by Benjamin Poulain.
2552
2553         Removed the PICTURE_SIZES build time flag.
2554
2555         * Scripts/webkitperl/FeatureList.pm:
2556
2557 2015-05-09  David Kilzer  <ddkilzer@apple.com>
2558
2559         Layout tests broke due to unexpected simctl output
2560
2561         * Scripts/webkitpy/xcode/simulator.py:
2562         (Simulator._parse_devices): Handle new Device Pairs header.
2563         * Scripts/webkitpy/xcode/simulator_unittest.py:
2564         (test_device_pairs): Add unit test for Device Pairs header.
2565
2566 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
2567
2568         Remove convenience constructors for TextRun
2569         https://bugs.webkit.org/show_bug.cgi?id=144752
2570
2571         Reviewed by Anders Carlsson.
2572
2573         Test the StringView which takes a StringImpl*.
2574
2575         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2576         (StringView8Bit): Testing is8Bit() on StringView
2577
2578 2015-05-07  Sam Weinig  <sam@webkit.org>
2579
2580         [Content Extensions] Add simple tester that takes an extension and compiles it
2581         https://bugs.webkit.org/show_bug.cgi?id=144781
2582
2583         Reviewed by Dan Bates.
2584
2585         * ContentExtensionTester: Added.
2586         * ContentExtensionTester/Configurations: Added.
2587         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
2588         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
2589         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
2590         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
2591         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
2592         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
2593         * ContentExtensionTester/main.m: Added.
2594         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
2595
2596 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
2597
2598         Build fix.
2599
2600         Reviewed by Dan Bernstein.
2601
2602         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2603         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2604         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
2605         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2606         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2607         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2608         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
2609         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2610
2611 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
2612
2613         [GTK] Some tests fail because they do not assume the popup menu captures click events
2614         https://bugs.webkit.org/show_bug.cgi?id=40601
2615
2616         Reviewed by Carlos Garcia Campos.
2617
2618         Popdown all attached menus when moving between tests and between each new
2619         event sent to the WebView. This prevents context and popup menus from eating
2620         events.
2621
2622         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
2623         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
2624         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2625         (WTR::dispatchEvent): Popdown all menus between dispatching events.
2626         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
2627         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
2628         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2629         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
2630         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2631         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
2632         longer in the platform-independent file.
2633         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
2634
2635 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
2636
2637         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
2638         https://bugs.webkit.org/show_bug.cgi?id=144746
2639
2640         Reviewed by Carlos Garcia Campos.
2641
2642         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
2643
2644         * MiniBrowser/gtk/main.c:
2645         (main):
2646
2647 2015-05-08  Commit Queue  <commit-queue@webkit.org>
2648
2649         Unreviewed, rolling out r183996.
2650         https://bugs.webkit.org/show_bug.cgi?id=144806
2651
2652         ASan detected use-after free (Requested by ap on #webkit).
2653
2654         Reverted changeset:
2655
2656         "Remove convenience constructors for TextRun"
2657         https://bugs.webkit.org/show_bug.cgi?id=144752
2658         http://trac.webkit.org/changeset/183996
2659
2660 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
2661
2662         Remove convenience constructors for TextRun
2663         https://bugs.webkit.org/show_bug.cgi?id=144752
2664
2665         Reviewed by Anders Carlsson.
2666
2667         Test the StringView which takes a StringImpl*.
2668
2669         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2670         (StringView8Bit): Testing is8Bit() on StringView
2671
2672 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2673
2674         [GTK] WTR doesn't correctly handle the Escape key
2675         https://bugs.webkit.org/show_bug.cgi?id=144788
2676
2677         Reviewed by Martin Robinson.
2678
2679         Correctly handle 0x001B character code in GTK+ event sender to be
2680         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
2681         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
2682         to dismiss popup menus.
2683
2684         Fixes editing/selection/5354455-1.html.
2685
2686         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2687         (WTR::getGDKKeySymForKeyRef):
2688
2689 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2690
2691         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
2692         https://bugs.webkit.org/show_bug.cgi?id=144748
2693
2694         Reviewed by Sergio Villar Senin.
2695
2696         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2697         (testWebKitSettings): Check the new setting is correctly
2698         initialized and updated.
2699         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2700         (testWebContextSecurityFileXHR): Check XHR to local files is
2701         allowed from file URLs after changing the setting.
2702         (beforeAll): Add new test.
2703
2704 2015-05-08  Commit Queue  <commit-queue@webkit.org>
2705
2706         Unreviewed, rolling out r183945.
2707         https://bugs.webkit.org/show_bug.cgi?id=144789
2708
2709         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
2710
2711         Reverted changeset:
2712
2713         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
2714         https://bugs.webkit.org/show_bug.cgi?id=144746
2715         http://trac.webkit.org/changeset/183945
2716
2717 2015-05-07  Anders Carlsson  <andersca@apple.com>
2718
2719         Build fixes.
2720
2721         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
2722         (TestWebKitAPI::TEST):
2723         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
2724         (TestWebKitAPI::TEST):
2725         Add casts.
2726
2727 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
2728
2729         GC has trouble with pathologically large array allocations
2730         https://bugs.webkit.org/show_bug.cgi?id=144609
2731
2732         Reviewed by Geoffrey Garen.
2733         
2734         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
2735         and it's a frequently requested feature.
2736         
2737         Also add the ability to run a test pretending that your system has a particular RAM size.
2738         This is useful for GC tests, and the new GC test that I added uses this.
2739
2740         * Scripts/run-javascriptcore-tests:
2741         (runJSCStressTests):
2742         * Scripts/run-jsc-stress-tests:
2743
2744 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
2745
2746         [EFL] Bump EFL version to 1.14.0
2747         https://bugs.webkit.org/show_bug.cgi?id=144743
2748
2749         Reviewed by Darin Adler.
2750
2751         Bump EFL and elementary version to 1.14.0 and removed
2752         md5sum, because it isn't used at all if hash is present.
2753
2754         * efl/jhbuild.modules:
2755
2756 2015-05-07  Saam Barati  <saambarati1@gmail.com>
2757
2758         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
2759         https://bugs.webkit.org/show_bug.cgi?id=144753
2760
2761         Reviewed by Mark Lam.
2762
2763         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2764
2765 2015-05-07  Beth Dakin  <bdakin@apple.com>
2766
2767         New force-related DOM events should fire in WK1 views
2768         https://bugs.webkit.org/show_bug.cgi?id=144663
2769         -and corresponding-
2770         rdar://problem/20281886
2771
2772         Reviewed by Sam Weinig.
2773
2774         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
2775         now. Just send nil. 
2776         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2777         (TestWebKitAPI::buildAndPerformTest):
2778
2779 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2780
2781         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
2782         https://bugs.webkit.org/show_bug.cgi?id=144746
2783
2784         Reviewed by Martin Robinson.
2785
2786         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
2787
2788         * MiniBrowser/gtk/main.c:
2789         (main):
2790
2791 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
2792
2793         Revert "Introducing the Platform Abstraction Layer (PAL)"
2794         https://bugs.webkit.org/show_bug.cgi?id=144751
2795
2796         Unreviewed.
2797
2798         PAL should be a new target inside WebCore, rather than a top-level folder.
2799
2800         * Scripts/build-webkit: Add it to build-webkit.
2801
2802 2015-05-07  Ada Chan  <adachan@apple.com>
2803
2804         Add a test for WKPageCopySessionState() with filtering.
2805         https://bugs.webkit.org/show_bug.cgi?id=144666
2806
2807         Reviewed by Darin Adler.
2808
2809         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2810         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
2811         (TestWebKitAPI::didFinishLoadForFrame):
2812         (TestWebKitAPI::setPageLoaderClient):
2813         (TestWebKitAPI::filterFirstItemCallback):
2814         (TestWebKitAPI::filterAllItemsCallback):
2815         (TestWebKitAPI::createSessionStates):
2816         (TestWebKitAPI::TEST):
2817
2818 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
2819
2820         iOS build fix attempt
2821
2822         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
2823
2824         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2825
2826 2015-05-06  Matt Baker  <mattbaker@apple.com>
2827
2828         Unreviewed, updated my list of email addresses.
2829
2830         * Scripts/webkitpy/common/config/contributors.json:
2831
2832 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
2833
2834         Do not link tools to WebKit2.framework
2835         https://bugs.webkit.org/show_bug.cgi?id=144699
2836
2837         Unreviewed build fix.
2838
2839         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2840         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2841         These linked to WebKit2 in two ways, eliminating the other one.
2842
2843 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
2844
2845         Introducing the Platform Abstraction Layer (PAL)
2846         https://bugs.webkit.org/show_bug.cgi?id=143358
2847
2848         Reviewed by Simon Fraser.
2849
2850         * Scripts/build-webkit: Add it to build-webkit.
2851
2852 2015-05-06  Alex Christensen  <achristensen@webkit.org>
2853
2854         Fix api tests after r183877.
2855
2856         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2857         (TestWebKitAPI::TEST_F):
2858         Generate all DFAs before compiling them.
2859
2860 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
2861
2862         Do not link tools to WebKit2.framework
2863         https://bugs.webkit.org/show_bug.cgi?id=144699
2864
2865         Reviewed by Tim Horton.
2866
2867         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2869         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2870
2871 2015-05-06  Alex Christensen  <achristensen@webkit.org>
2872
2873         [Content Extensions] Test splitting NFAs by max NFA size.
2874         https://bugs.webkit.org/show_bug.cgi?id=144659
2875
2876         Reviewed by Darin Adler.
2877
2878         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2879         (TestWebKitAPI::createNFAs):
2880         (TestWebKitAPI::TEST_F):
2881         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2882         (TestWebKitAPI::createNFAs):
2883
2884 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
2885
2886         Remove the remaining vestiges of SVG feature define
2887         https://bugs.webkit.org/show_bug.cgi?id=144655
2888
2889         Reviewed by Alexey Proskuryakov.
2890
2891         * Scripts/webkitperl/FeatureList.pm:
2892
2893 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
2894
2895         Add a layout mode for computing fixed layout size from a minimum size
2896         https://bugs.webkit.org/show_bug.cgi?id=144610
2897         <rdar://problem/19790341>
2898
2899         Reviewed by Simon Fraser.
2900
2901         * MiniBrowser/mac/BrowserWindow.xib:
2902         * MiniBrowser/mac/BrowserWindowController.h:
2903         * MiniBrowser/mac/WK1BrowserWindowController.m:
2904         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
2905         * MiniBrowser/mac/WK2BrowserWindowController.m:
2906         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
2907         Add a optional toolbar item to toggle a minimum view size of 1024x0.
2908
2909 2015-05-05  Alex Christensen  <achristensen@webkit.org>
2910
2911         [Content Extensions] Release input NSString when finished copying it.
2912         https://bugs.webkit.org/show_bug.cgi?id=144642
2913
2914         Reviewed by Brian Weinstein.
2915
2916         * WebKitTestRunner/mac/TestControllerMac.mm:
2917         (WTR::TestController::platformConfigureViewForTest):
2918         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
2919
2920 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
2921
2922         Unreviewed test fix after r183798.
2923
2924         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2925         (convertToDRTLabel): Mimic behavior of Mac accessibility output
2926         so we can share results.
2927
2928 2015-05-05  Alex Christensen  <achristensen@webkit.org>
2929
2930         [Content Extensions] Use less memory to store the json input.
2931         https://bugs.webkit.org/show_bug.cgi?id=144604
2932
2933         Reviewed by Benjamin Poulain.
2934
2935         * MiniBrowser/mac/ExtensionManagerWindowController.m:
2936         (-[ExtensionManagerWindowController add:]):
2937         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2938         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2939         * WebKitTestRunner/mac/TestControllerMac.mm:
2940         (WTR::TestController::platformConfigureViewForTest):
2941
2942 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2943
2944         Unreviewed. Make myself a WebKit reviewer.
2945
2946         * Scripts/webkitpy/common/config/contributors.json:
2947
2948 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
2949
2950         [GTK] r183783 breaks build
2951         https://bugs.webkit.org/show_bug.cgi?id=144632
2952
2953         Reviewed by Martin Robinson.
2954
2955         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
2956
2957         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2958         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2959
2960 2015-05-05  Alex Christensen  <achristensen@webkit.org>
2961
2962         [Content Extensions] Combine NFAs properly and free memory as we compile.
2963         https://bugs.webkit.org/show_bug.cgi?id=144485
2964
2965         Reviewed by Benjamin Poulain.
2966
2967         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2968         (TestWebKitAPI::TEST_F):
2969         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
2970         Added tests for deep NFAs.
2971
2972 2015-05-04  Alex Christensen  <achristensen@webkit.org>
2973
2974         [Content Extensions] Use less memory when writing byte code to file
2975         https://bugs.webkit.org/show_bug.cgi?id=144602
2976
2977         Reviewed by Darin Adler.
2978
2979         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2980
2981 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2982
2983         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
2984         https://bugs.webkit.org/show_bug.cgi?id=144541
2985
2986         Reviewed by Žan Doberšek.
2987
2988         Add a test case to WorkQueue unit test, to check that sources of
2989         asynchronous IO operations running in the WorkQueue thread are
2990         dispatched by the WorkQueue main loop.
2991
2992         * TestWebKitAPI/PlatformGTK.cmake:
2993         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
2994         (TestWebKitAPI::TEST):
2995
2996 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
2997
2998         Correct '--show-webview' option for Tiled Drawing tests
2999         https://bugs.webkit.org/show_bug.cgi?id=144621
3000
3001         Reviewed by Simon Fraser.
3002
3003         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
3004         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
3005
3006         * WebKitTestRunner/mac/TestControllerMac.mm:
3007         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
3008         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
3009
3010 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
3011
3012         Large array shouldn't be slow
3013         https://bugs.webkit.org/show_bug.cgi?id=144617
3014
3015         Reviewed by Geoffrey Garen.
3016         
3017         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
3018         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
3019         long-running. So, hash-map sort of belongs here.
3020
3021         * Scripts/run-jsc-benchmarks:
3022
3023 2015-05-04  Doug Russell  <d_russell@apple.com>
3024
3025         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
3026         https://bugs.webkit.org/show_bug.cgi?id=144489
3027
3028         Reviewed by Chris Fleizach.
3029
3030         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
3031         on the returned control.
3032         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
3033         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
3034         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
3035         Add support for setSelectedVisibleTextRange() in accessibility tests.
3036
3037         * DumpRenderTree/AccessibilityUIElement.cpp:
3038         (setSelectedVisibleTextRangeCallback):
3039         (AccessibilityUIElement::setSelectedVisibleTextRange):
3040         (AccessibilityUIElement::getJSClass):
3041         (AccessibilityUIElement::textMarkerForIndex): Deleted.
3042         * DumpRenderTree/AccessibilityUIElement.h:
3043         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3044         (AccessibilityUIElement::setSelectedVisibleTextRange):
3045         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3046         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3047         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
3048         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3049         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3050         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3051         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3052         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3053         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3054         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3055         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3056
3057 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
3058
3059         [Win] Implement the "--show-webview" option for Windows
3060         https://bugs.webkit.org/show_bug.cgi?id=144589
3061
3062         Reviewed by Alex Christensen.
3063
3064         Add another runtime flag (--show-webview) that causes DumpRenderTree
3065         to draw its view on-screen, rather than the standard offscreen mode.
3066
3067         * DumpRenderTree/win/DumpRenderTree.cpp:
3068         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
3069         (initializeGlobalsFromCommandLineOptions): Recognize the new
3070         command-line argument, and set the global 'showWebView' state if
3071         appropriate.
3072
3073 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
3074
3075         Remove dead code from TestInvocationCairo.cpp
3076         https://bugs.webkit.org/show_bug.cgi?id=144564
3077
3078         Reviewed by Gyuyoung Kim.
3079
3080         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
3081
3082         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3083         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3084
3085 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
3086
3087         [GTK] Add libnotify in gtk install-dependencies
3088         https://bugs.webkit.org/show_bug.cgi?id=144379
3089
3090         Reviewed by Csaba Osztrogonác.
3091
3092         * gtk/install-dependencies:
3093
3094 2015-05-01  Dan Bernstein  <mitz@apple.com>
3095
3096         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
3097         https://bugs.webkit.org/show_bug.cgi?id=144501
3098
3099         Reviewed by Darin Adler.
3100
3101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3102         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
3103         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
3104         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
3105
3106 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
3107
3108         check-webkit-style fails due to system pylint
3109         https://bugs.webkit.org/show_bug.cgi?id=144360
3110
3111         Reviewed by Darin Adler.
3112
3113         Make sure that the directory containing third party autoinstalled modules
3114         is at the beginning of the search path, to avoid conflicts with other
3115         versions of the same modules installed in the system (e.g. pylint).
3116
3117         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
3118         modules directory to sys.path, instead of appending it.
3119
3120 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
3121
3122         Unreviewed, updated my list of email addresses.
3123
3124         * Scripts/webkitpy/common/config/contributors.json: Updated.
3125
3126 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
3127
3128         USE(...) macro should expect unprefixed variables
3129         https://bugs.webkit.org/show_bug.cgi?id=144454
3130
3131         Reviewed by Daniel Bates.
3132
3133         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
3134         * DumpRenderTree/config.h: Ditto.
3135         * TestWebKitAPI/config.h: Ditto.
3136
3137 2015-05-01  Basile Clement  <basile_clement@apple.com>
3138
3139         Unreviewed. Add myself as a commiter in contributors.json.
3140
3141         * Scripts/webkitpy/common/config/contributors.json:
3142
3143 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
3144
3145         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
3146         https://bugs.webkit.org/show_bug.cgi?id=144487
3147
3148         Reviewed by Ryosuke Niwa.
3149
3150         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3151         (BenchmarkRunner.merge): Fix bug.
3152         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
3153
3154 2015-05-01  Brady Eidson  <beidson@apple.com>
3155
3156         Add API to disable meta refreshes.
3157         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
3158
3159         Reviewed by Alexey Proskuryakov.
3160
3161         * DumpRenderTree/mac/DumpRenderTree.mm:
3162         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
3163
3164 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
3165
3166         Provide a runtime flag to run-webkit-tests that shows the test view
3167         https://bugs.webkit.org/show_bug.cgi?id=144079.
3168
3169         Unreviewed correction to r183651.
3170
3171         * WebKitTestRunner/TestController.cpp:
3172         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
3173         flag is included in the options dictionary passed to the PlatformWebView.
3174
3175 2015-05-01  Antti Koivisto  <antti@apple.com>
3176
3177         Remove network process load serialization code
3178         https://bugs.webkit.org/show_bug.cgi?id=144448
3179
3180         Reviewed by Alexey Proskuryakov.
3181
3182         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3183         (WTR::InjectedBundle::beginTesting):
3184         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3185         (WTR::TestRunner::setSerializeHTTPLoads):
3186         (WTR::TestRunner::dispatchPendingLoadRequests):
3187
3188 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3189
3190         [GTK] Add libhyphen-dev to the build dependencies
3191         https://bugs.webkit.org/show_bug.cgi?id=144452
3192
3193         Reviewed by Martin Robinson.
3194
3195         * gtk/install-dependencies: Added hyphen as Fedora and Arch
3196         dependencies.
3197
3198 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
3199
3200         Provide a runtime flag to run-webkit-tests that shows the test view
3201         https://bugs.webkit.org/show_bug.cgi?id=144079.
3202
3203         Reviewed by Dean Jackson.
3204
3205         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
3206         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
3207         option:
3208         
3209         --additional-drt-flag="--show-webview"
3210
3211         * DumpRenderTree/mac/DumpRenderTree.mm:
3212         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
3213         '--show-webview' flag.
3214         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
3215         * WebKitTestRunner/Options.cpp:
3216         (WTR::Options::Options):
3217         (WTR::handleOptionShowWebView):
3218         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
3219         * WebKitTestRunner/Options.h:
3220         * WebKitTestRunner/TestController.cpp:
3221         (WTR::TestController::TestController):
3222         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
3223         * WebKitTestRunner/TestController.h:
3224         (WTR::TestController::shouldShowWebView):
3225         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3226         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
3227         options dictionary. If it is true, display the web view while running the test.
3228
3229 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
3230
3231         r183355 didn't trigger Mac tests
3232         https://bugs.webkit.org/show_bug.cgi?id=144464
3233
3234         Reviewed by Simon Fraser.
3235
3236         Update badly neglected filters and unit tests.
3237
3238         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3239         (_should_file_trigger_build):
3240         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3241         (ShouldBuildTest):
3242         (ShouldBuildTest.test_should_build):
3243
3244 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3245
3246         [GTK] Add libhyphen-dev to the build dependencies
3247         https://bugs.webkit.org/show_bug.cgi?id=144452
3248
3249         Reviewed by Martin Robinson.
3250
3251         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
3252         build dependencies.
3253
3254 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
3255
3256         [GTK] Testing dictionaries are not installed automatically
3257         https://bugs.webkit.org/show_bug.cgi?id=144460
3258
3259         Reviewed by Carlos Garcia Campos.
3260
3261         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
3262
3263 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
3264
3265         Fix return code issue, check return code of safari process and dump results to log
3266         https://bugs.webkit.org/show_bug.cgi?id=144436
3267
3268         Reviewed by Ryosuke Niwa.
3269
3270         * Scripts/run-benchmark:
3271         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3272         (BenchmarkRunner.dump): Correct typo.
3273         (BenchmarkRunner.wrap): Add results to console.
3274         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
3275         (OSXSafariDriver.prepareEnv):
3276         (OSXSafariDriver.launchUrl):
3277         (OSXSafariDriver.closeBrowsers):
3278
3279 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
3280
3281         Should no longer need to worry about very old versions of Xcode
3282         https://bugs.webkit.org/show_bug.cgi?id=144437
3283
3284         Reviewed by Dan Bernstein.
3285
3286         * Scripts/check-for-exit-time-destructors:
3287         * Scripts/check-for-global-initializers:
3288         * Scripts/check-for-weak-vtables-and-externals:
3289
3290 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
3291
3292         REGRESSION(183583): [Mac] make without SDKROOT has issues
3293         https://bugs.webkit.org/show_bug.cgi?id=144431
3294
3295         Reviewed by Dan Bernstein.
3296
3297         * Makefile:
3298         * WebKitTestRunner/Makefile:
3299         Assume an empty SDKROOT means an macosx variant, so only
3300         enable settings if the SDKROOT is not empty and does not
3301         contain "macosx".
3302
3303 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
3304
3305         Expand test infrastructure to support scrolling tests
3306         https://bugs.webkit.org/show_bug.cgi?id=143684
3307         <rdar://problem/20375516>
3308
3309         Reviewed by Simon Fraser.
3310
3311         * DumpRenderTree/mac/DumpRenderTree.mm:
3312         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
3313         reset before the next test run.
3314         * WebKitTestRunner/TestController.cpp:
3315         (WTR::TestController::resetStateToConsistentValues): Ditto."
3316
3317 2015-04-29  Alex Christensen  <achristensen@webkit.org>
3318
3319         Run javascriptcore tests on Windows without cygwin
3320         https://bugs.webkit.org/show_bug.cgi?id=144419
3321
3322         Reviewed by Brent Fulgham.
3323
3324         * Scripts/run-javascriptcore-tests:
3325         (runJSCStressTests):
3326         Just call ruby, not /usr/bin/env ruby.
3327
3328 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
3329
3330         [GTK] Add --enable-shared option to LLVM to build mesa
3331         https://bugs.webkit.org/show_bug.cgi?id=144393
3332
3333         Reviewed by Martin Robinson.
3334
3335         The updated mesa requires the shared LLVM libraries.
3336         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
3337         to LLVM configure script. It will provide shared libraries in addition to static libraries.
3338
3339         * gtk/jhbuild-optional.modules:
3340
3341 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
3342
3343         [GTK] Add support for automatic hyphenation
3344         https://bugs.webkit.org/show_bug.cgi?id=44478
3345
3346         Reviewed by Carlos Garcia Campos.
3347
3348         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
3349         all systems will use the same dictionaries for testing purposes.
3350
3351 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
3352
3353         Failure when building WebKit for appletvsimulator.
3354         https://bugs.webkit.org/show_bug.cgi?id=144356
3355
3356         Reviewed by Alexey Proskuryakov.
3357
3358         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
3359         make TVOS and WatchOS behave correctly.
3360
3361         * Makefile:
3362         * WebKitTestRunner/Makefile:
3363
3364 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
3365
3366         Use-after-free when invalidating WKPageForceRepaint callback
3367         https://bugs.webkit.org/show_bug.cgi?id=144401
3368         rdar://problem/20741111
3369
3370         Reviewed by Tim Horton.
3371
3372         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
3373
3374         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
3375         Don't do anything on error, because the context may be a stale pointer now.
3376
3377 2015-04-29  David Kilzer  <ddkilzer@apple.com>
3378
3379         check-webkit-style: Don't complain about returning value from Objective-C method call in header
3380         <http://webkit.org/b/144395>
3381
3382         Reviewed by Andy Estes.
3383
3384         * Scripts/webkitpy/style/checkers/cpp.py:
3385         (check_spacing): Update regex so 'return' is ignored if it
3386         precedes the whitespace and bracket.  Change category name to
3387         'whitespace/brackets'.  Add period to error message.
3388         (CppChecker): Add 'whitespace/brackets' as a category.
3389         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3390         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
3391         'CppChecker.categories' since that's where the list lives now.
3392         (CppStyleTest.test_spacing_before_brackets): Add tests for
3393         'whitespace/brackets' issues and non-issues.
3394
3395 2015-04-29  Alex Christensen  <achristensen@webkit.org>
3396
3397         Fix WinCairo bot.
3398
3399         * Scripts/webkitdirs.pm:
3400         (determinePassedConfiguration):
3401         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
3402
3403 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
3404
3405         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
3406         https://bugs.webkit.org/show_bug.cgi?id=132159
3407
3408         Reviewed by Darin Adler.
3409
3410         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
3411         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
3412
3413         * DumpRenderTree/mac/DumpRenderTree.mm:
3414         (fontWhitelist):
3415         (adjustFonts):
3416         (createWebViewAndOffscreenWindow):
3417         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3418         (WTR::activateFonts):
3419         * WebKitTestRunner/mac/TestControllerMac.mm:
3420         (WTR::allowedFontFamilySet):
3421         (WTR::systemHiddenFontFamilySet):
3422         (WTR::generateWhitelist):
3423         (WTR::TestController::platformInitializeContext):
3424
3425 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
3426
3427         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
3428         https://bugs.webkit.org/show_bug.cgi?id=144155
3429
3430         Reviewed by Andreas Kling.
3431
3432         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
3433         Make sure that test window is "visible" before each test. While there is no concrete
3434         evidence that this is the problem indeed, the behavior is consistent with what would
3435         happen for an invisible window. Also, WKTR obviously needs to do this to protect
3436         against potential buggy tests that hide the window and don't show it.
3437
3438 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3439
3440         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
3441
3442         Latest changes in the inspector UI made this test fail. We were
3443         relying that the sidebar was always visible and the first 'li'
3444         element of the inspector was the one containing the title. This is
3445         no longer true, so better use document title that is not likely
3446         to change.
3447
3448         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
3449         (openRemoteDebuggingSession):
3450
3451 2015-04-29  Andres Gomez  <agomez@igalia.com>
3452
3453         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
3454
3455         * Scripts/webkitpy/common/config/contributors.json:
3456
3457 2015-04-29  Andres Gomez  <agomez@igalia.com>
3458
3459         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
3460
3461         * Scripts/webkitpy/common/config/watchlist:
3462
3463 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
3464
3465         [EFL] Allow to run the tests on the native X display
3466         https://bugs.webkit.org/show_bug.cgi?id=144247
3467
3468         Reviewed by Gyuyoung Kim.
3469
3470         Added the USE_NATIVE_XDISPLAY option for the WTR.
3471         We can select the Xorg driver if environment variable is set up before running the tests.
3472
3473         * Scripts/webkitpy/port/efl.py:
3474         (EflPort._driver_class):
3475
3476 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
3477
3478         [GTK] Add libnotify-dev in gtk install-dependencies
3479         https://bugs.webkit.org/show_bug.cgi?id=144379
3480
3481         Reviewed by Žan Doberšek.
3482
3483         * gtk/install-dependencies:
3484
3485 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
3486
3487         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
3488         https://bugs.webkit.org/show_bug.cgi?id=143001
3489
3490         Reviewed by Gyuyoung Kim.
3491
3492         * WebKitTestRunner/TestController.cpp:
3493         (WTR::shouldUseFixedLayout):
3494
3495 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
3496
3497         Increase stablility of run-benchmark script
3498         https://bugs.webkit.org/show_bug.cgi?id=144361
3499
3500         Reviewed by Ryosuke Niwa.
3501
3502         * Scripts/run-benchmark:
3503         (main):
3504         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
3505         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
3506         (GenericBenchmarkBuilder.clean):
3507         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
3508         (BenchmarkRunner.__init__):
3509         (BenchmarkRunner.execute):
3510         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3511         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
3512         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
3513         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
3514         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
3515         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
3516         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
3517         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
3518         (HTTPServerDriver.fetchResult):
3519         (HTTPServerDriver):
3520         (HTTPServerDriver.killServer): Add kill server interface.
3521         (HTTPServerDriver.getReturnCode): Add get return code interface.
3522         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
3523         (SimpleHTTPServerDriver.serve):
3524         (SimpleHTTPServerDriver.fetchResult):
3525         (SimpleHTTPServerDriver):
3526         (SimpleHTTPServerDriver.killServer):
3527         (SimpleHTTPServerDriver.getReturnCode):
3528         * Scripts/webkitpy/benchmark_runner/utils.py:
3529         (forceRemove): Provide python version of 'rm -rf'.
3530
3531 2015-04-28  Sam Weinig  <sam@webkit.org>
3532
3533         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
3534         https://bugs.webkit.org/show_bug.cgi?id=144363
3535
3536         Reviewed by Alex Christensen.
3537
3538         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3539         (TestWebKitAPI::createNFAs):
3540         (TestWebKitAPI::TEST_F):
3541         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3542         (TestWebKitAPI::countLiveNodes):
3543         (TestWebKitAPI::createNFAs):
3544         (TestWebKitAPI::buildDFAFromPatterns):
3545         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
3546
3547 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3548
3549         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
3550         https://bugs.webkit.org/show_bug.cgi?id=144304
3551
3552         Reviewed by Geoffrey Garen.
3553
3554         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
3555         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
3556         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
3557
3558 2015-04-28  Commit Queue  <commit-queue@webkit.org>
3559
3560         Unreviewed, rolling out r183514.
3561         https://bugs.webkit.org/show_bug.cgi?id=144359
3562
3563         It broke cloop test bots (Requested by mcatanzaro on #webkit).
3564
3565         Reverted changeset:
3566
3567         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
3568         https://bugs.webkit.org/show_bug.cgi?id=144304
3569         http://trac.webkit.org/changeset/183514
3570
3571 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3572
3573         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
3574         https://bugs.webkit.org/show_bug.cgi?id=144304
3575
3576         Reviewed by Geoffrey Garen.
3577
3578         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
3579         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
3580         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
3581         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
3582
3583 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3584
3585         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
3586         https://bugs.webkit.org/show_bug.cgi?id=144319
3587
3588         Reviewed by Csaba Osztrogonác.
3589
3590         * TestWebKitAPI/CMakeLists.txt:
3591         * TestWebKitAPI/PlatformEfl.cmake:
3592
3593 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
3594
3595         Fix common typo "targetting" => "targeting"
3596         https://bugs.webkit.org/show_bug.cgi?id=144349
3597
3598         Reviewed by Daniel Bates.
3599
3600         * Scripts/webkitdirs.pm:
3601         (execMacWebKitAppForDebugging):
3602
3603 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
3604
3605         [GTK][jhbuild] Mesa build failure with llvm 3.6
3606         https://bugs.webkit.org/show_bug.cgi?id=144250
3607
3608         Reviewed by Žan Doberšek.
3609
3610         Bump the version of Mesa to 10.5.4
3611
3612         * gtk/jhbuild.modules:
3613
3614 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
3615
3616         Disable App Nap in WebKitTestRunner UI process
3617         https://bugs.webkit.org/show_bug.cgi?id=144308
3618
3619         Reviewed by Daniel Bates.
3620
3621         * WebKitTestRunner/mac/main.mm:
3622         (disableAppNapInUIProcess):
3623         (main):
3624
3625 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
3626
3627         [GTK] Update JHBuild Mesa download directory
3628         https://bugs.webkit.org/show_bug.cgi?id=144318
3629
3630         Update the download directory of Mesa module since the previous one
3631         doesn't exist any more.
3632
3633         Reviewed by Žan Doberšek.
3634
3635         * gtk/jhbuild.modules:
3636
3637 2015-04-28  Commit Queue  <commit-queue@webkit.org>
3638
3639         Unreviewed, rolling out r183477.
3640         https://bugs.webkit.org/show_bug.cgi?id=144334
3641
3642         Roll back the Mesa dependency bump in fear of uncaught
3643         regressions while the testing bots are no-op. (Requested by
3644         zdobersek on #webkit).
3645
3646         Reverted changeset:
3647
3648         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
3649         https://bugs.webkit.org/show_bug.cgi?id=144250
3650         http://trac.webkit.org/changeset/183477
3651
3652 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
3653
3654         [GTK][jhbuild] Mesa build failure with llvm 3.6
3655         https://bugs.webkit.org/show_bug.cgi?id=144250
3656
3657         Reviewed by Žan Doberšek.
3658
3659         Bump the version of Mesa to 10.5.4
3660
3661         * gtk/jhbuild.modules:
3662
3663 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
3664
3665         Add '__init__.py' and fix known bug in benchmark runner.
3666         https://bugs.webkit.org/show_bug.cgi?id=144296
3667
3668         Reviewed by Ryosuke Niwa
3669
3670         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
3671         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
3672         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3673         (BenchmarkRunner.__init__):
3674         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
3675         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
3676         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
3677
3678 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
3679
3680         More build fix.
3681
3682         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3683         (-[AccessibilityNotificationHandler _notificationReceived:]):
3684         Use -objectForKey:, not array subscript.
3685
3686 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
3687
3688         Catch unexpected exits in DumpRenderTree
3689         https://bugs.webkit.org/show_bug.cgi?id=144288
3690
3691         Reviewed by Tim Horton.
3692
3693         * DumpRenderTree/mac/DumpRenderTree.mm:
3694         (atexitFunction):
3695         (DumpRenderTreeMain):
3696
3697 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
3698
3699         Build fix
3700
3701         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3702         (-[AccessibilityNotificationHandler _notificationReceived:]):
3703         Use -objectForKey:, not array subscript.
3704
3705 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
3706
3707         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
3708         https://bugs.webkit.org/show_bug.cgi?id=144155
3709
3710         Reviewed by Tim Horton.
3711
3712         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
3713         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
3714         and we clearly don't want App Nap while testing.
3715
3716 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
3717
3718         [CMake] Autogenerate cmakeconfig.h.cmake
3719         https://bugs.webkit.org/show_bug.cgi?id=143997
3720
3721         Reviewed by Csaba Osztrogonác.
3722
3723         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
3724         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
3725
3726 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
3727
3728         REGRESSION(r182879): Images and video can no longer be downloaded
3729         https://bugs.webkit.org/show_bug.cgi?id=144267
3730         <rdar://problem/20702844>
3731
3732         Reviewed by Simon Fraser.
3733
3734         Revise tests to check for proper download menu state.
3735         1. Downloading a loal image should be disabled.
3736         2. Downloading a local media file should be disabled.
3737         3. Downloading non-downloadable media should be disabled.
3738
3739         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3740         (TestWebKitAPI::TEST):
3741
3742 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
3743
3744         Merge run-launcher into run-minibrowser
3745         https://bugs.webkit.org/show_bug.cgi?id=141928
3746
3747         Reviewed by Darin Adler.
3748
3749         * Scripts/run-iexploder-tests:
3750         (runSafariWithIExploder):
3751         * Scripts/run-launcher: Removed.
3752         * Scripts/run-minibrowser:
3753         * Scripts/webkitdirs.pm:
3754         (launcherPath):
3755         * Scripts/webkitpy/port/efl.py:
3756         (EflPort.show_results_html_file):
3757         * Scripts/webkitpy/port/efl_unittest.py:
3758         (EflPortTest.test_show_results_html_file):
3759         * Scripts/webkitpy/port/gtk.py:
3760         (GtkPort.print_leaks_summary):
3761         (GtkPort.show_results_html_file):
3762         (GtkPort): Deleted.
3763         * Scripts/webkitpy/port/gtk_unittest.py:
3764         (GtkPortTest.test_show_results_html_file):
3765
3766 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
3767
3768         [buildbot] Fix the output of perf-test buildstep on timeout
3769         https://bugs.webkit.org/show_bug.cgi?id=144097
3770
3771         Reviewed by Ryosuke Niwa.
3772
3773         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3774         (RunAndUploadPerfTests.getText2):
3775         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3776         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
3777         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
3778
3779 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
3780
3781         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
3782         https://bugs.webkit.org/show_bug.cgi?id=143874
3783
3784         Reviewed by Gyuyoung Kim.
3785
3786         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
3787
3788 2015-04-24  Philippe Normand  <pnormand@igalia.com>
3789
3790         [JHBuild] Move to upstream OpenWebRTC
3791         https://bugs.webkit.org/show_bug.cgi?id=144145
3792
3793         Reviewed by Carlos Garcia Campos.
3794
3795         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
3796         and add a new simple patch to gst-plugins-base, required for
3797         OpenWebRTC build.
3798         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
3799         * gtk/jhbuild.modules: Ditto.
3800         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
3801
3802 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3803
3804         [ES6] Implement ES6 template literals
3805         https://bugs.webkit.org/show_bug.cgi?id=142691
3806
3807         Reviewed by Darin Adler.
3808
3809         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
3810
3811         * Scripts/webkitperl/FeatureList.pm:
3812
3813 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3814
3815         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
3816         https://bugs.webkit.org/show_bug.cgi?id=144217
3817
3818         Reviewed by Darin Adler.
3819
3820         * WebKitTestRunner/PlatformEfl.cmake:
3821
3822 2015-04-26  Doug Russell  <d_russell@apple.com>
3823
3824         AX: richer text change notifications (142719)
3825         https://bugs.webkit.org/show_bug.cgi?id=142719
3826
3827         Reviewed by Darin Adler.
3828
3829         Richer accessibility value change notifications. Introduce AXTextEditType,
3830         postTextStateChangeNotification and postTextReplacementNotification to give assistive
3831         tech apps more reliable context for responding to changes in web content. Also implement
3832         a mechanism to post value changes in password form fields in coalesced ticks to thwart
3833         analyzing the cadence of changes.
3834
3835         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
3836         and an overload of postTextReplacementNotification to give assistive tech apps more
3837         reliable context for responding to changes in web content selection. Also block posting
3838         selection changes on password fields.
3839
3840         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
3841         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3842         (-[AccessibilityNotificationHandler stopObserving]):
3843         (-[AccessibilityNotificationHandler _notificationReceived:]):
3844         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3845         (AccessibilityUIElement::removeNotificationListener):
3846         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3847         (-[AccessibilityNotificationHandler _notificationReceived:]):
3848         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3849         (WTR::AccessibilityUIElement::removeNotificationListener):
3850
3851 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
3852
3853         Add myself to contributors.json
3854         https://bugs.webkit.org/show_bug.cgi?id=144204
3855
3856         Reviewed by Darin Adler.
3857
3858         * Scripts/webkitpy/common/config/contributors.json:
3859
3860 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
3861
3862         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
3863         https://bugs.webkit.org/show_bug.cgi?id=144182
3864
3865         Reviewed by Simon Fraser.
3866
3867         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
3868
3869 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
3870
3871         https://bugs.webkit.org/show_bug.cgi?id=144038
3872
3873         Reviewed by Ryosuke Niwa
3874
3875         Add a script to run Speedometer and JetStream on a browser.
3876
3877         * Scripts/run-benchmark: Wrapper script to run benchmark.
3878         (main):
3879         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
3880         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
3881         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
3882         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
3883         (BenchmarkBuilderFactory):
3884         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
3885         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
3886         (GenericBenchmarkBuilder):
3887         (GenericBenchmarkBuilder.prepare):
3888         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
3889         (GenericBenchmarkBuilder._applyPatch):
3890         (GenericBenchmarkBuilder.clean):
3891         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
3892         (JetStreamBenchmarkBuilder):
3893         (JetStreamBenchmarkBuilder.prepare):
3894         (JetStreamBenchmarkBuilder._runCreateScript):
3895         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
3896         (BenchmarkRunner):
3897         (BenchmarkRunner.__init__):
3898         (BenchmarkRunner.execute):
3899         (BenchmarkRunner.dump):
3900         (BenchmarkRunner.wrap):
3901         (BenchmarkRunner.merge):
3902         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
3903         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
3904         (BrowserDriver):
3905         (BrowserDriver.prepareEnv):
3906         (BrowserDriver.launchUrl):
3907         (BrowserDriver.closeBrowser):
3908         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
3909         (BrowserDriverFactory):
3910         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
3911         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
3912         (OSXChromeDriver):
3913         (OSXChromeDriver.prepareEnv):
3914         (OSXChromeDriver.launchUrl):
3915         (OSXChromeDriver.closeBrowsers):
3916         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
3917         (OSXSafariDriver):
3918         (OSXSafariDriver.prepareEnv):
3919         (OSXSafariDriver.launchUrl):
3920         (OSXSafariDriver.closeBrowsers):
3921         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
3922         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
3923         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
3924         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
3925         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
3926         (GenericFactory):
3927         (GenericFactory.iterateGetItem):
3928         (GenericFactory.create):
3929         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
3930         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
3931         (ServerControl):
3932         (ServerControl.render_GET):
3933         (ServerControl.render_POST):
3934         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
3935         (HTTPServerDriver):
3936         (HTTPServerDriver.serve):
3937         (HTTPServerDriver.fetchResult):
3938         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
3939         (HTTPServerDriverFactory):
3940         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
3941         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
3942         (SimpleHTTPServerDriver):
3943         (SimpleHTTPServerDriver.depends):
3944         (SimpleHTTPServerDriver.__init__):
3945         (SimpleHTTPServerDriver.serve):
3946         (SimpleHTTPServerDriver.baseUrl):
3947         (SimpleHTTPServerDriver.fetchResult):
3948         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
3949         (ModuleNotFoundError):
3950         (loadModule):
3951         (getPathFromProjectRoot):
3952         (loadJSONFromFile):
3953         (TimeoutError):
3954         (timeout):
3955         (timeout.__init__):
3956         (timeout.handle_timeout):
3957         (timeout.__enter__):
3958         (timeout.__exit__):
3959
3960 2015-04-24  Commit Queue  <commit-queue@webkit.org>
3961
3962         Unreviewed, rolling out r183303.
3963         https://bugs.webkit.org/show_bug.cgi?id=144181
3964
3965         Change was incorrect, broke builds (Requested by smfr on
3966         #webkit).
3967
3968         Reverted changeset:
3969
3970         "Fix the build."
3971         http://trac.webkit.org/changeset/183303
3972
3973 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
3974
3975         Fix the build.
3976
3977         * MiniBrowser/mac/WK2BrowserWindowController.m:
3978         (-[WK2BrowserWindowController initWithConfiguration:]):
3979
3980 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
3981
3982         Disable ActionMenusPDFTest due to timeout on test bot
3983
3984         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3985         (TestWebKitAPI::TEST):
3986
3987 2015-04-24  Commit Queue  <commit-queue@webkit.org>
3988
3989         Unreviewed, rolling out r183266.
3990         https://bugs.webkit.org/show_bug.cgi?id=144164
3991
3992         Broke 32-bit build and a test. (Requested by ap on #webkit).
3993
3994         Reverted changeset:
3995
3996         "AX: richer text change notifications (142719)"
3997         https://bugs.webkit.org/show_bug.cgi?id=142719
3998         http://trac.webkit.org/changeset/183266
3999
4000 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
4001
4002         REGRESSION: WebKit2.ActionMenusTest API test fails
4003         https://bugs.webkit.org/show_bug.cgi?id=144149
4004         <rdar://problem/20677770>
4005
4006         Reviewed by Tim Horton.
4007
4008         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
4009         as the 'ActionMenusPDFTest'.
4010         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
4011         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
4012         to match the hit test on the 'action-menu-target.pdf' test file.
4013
4014 2015-04-24  Daniel Bates  <dabates@apple.com>
4015
4016         Cleanup: Use @memoized for property IOSSimulator.testing_device
4017         https://bugs.webkit.org/show_bug.cgi?id=141715
4018
4019         Reviewed by Darin Adler.
4020
4021         Simplify the caching of the result of IOSSimulator.testing_device
4022         and make the code more readable by making use of the @memoized declarator
4023         instead of explicitly managing a private instance variable,
4024         IOSSimulator._testing_device, for the cached result.
4025
4026         * Scripts/webkitpy/port/ios.py:
4027         (IOSPort.determine_full_port_name):
4028         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
4029         (IOSSimulatorPort):
4030         (IOSSimulatorPort.testing_device): No need to cache the created device object in
4031         IOSSimulatorPort._testing_device since we are marking this function @memoized.
4032         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
4033         of caching in local variable since we only make use of this value exactly once in this function.
4034         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
4035         been used since being added in r178622. So, we can remove this constructor since
4036         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
4037
4038 2015-04-24  Anders Carlsson  <andersca@apple.com>
4039
4040         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
4041         https://bugs.webkit.org/show_bug.cgi?id=144158
4042
4043         Reviewed by Beth Dakin.
4044
4045         * MiniBrowser/mac/WK2BrowserWindowController.m:
4046         (-[WK2BrowserWindowController initWithConfiguration:]):
4047
4048 2015-04-24  Doug Russell  <d_russell@apple.com>
4049
4050         AX: richer text change notifications (142719)
4051         https://bugs.webkit.org/show_bug.cgi?id=142719
4052
4053         Reviewed by Darin Adler.
4054
4055         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
4056
4057         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
4058
4059         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
4060         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
4061         (-[AccessibilityNotificationHandler stopObserving]):
4062         (-[AccessibilityNotificationHandler _notificationReceived:]):
4063         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4064         (AccessibilityUIElement::removeNotificationListener):
4065         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
4066         (-[AccessibilityNotificationHandler _notificationReceived:]):
4067         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4068         (WTR::AccessibilityUIElement::removeNotificationListener):
4069
4070 2015-04-24  Darin Adler  <darin@apple.com>
4071
4072         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
4073         https://bugs.webkit.org/show_bug.cgi?id=128007
4074
4075         Reviewed by Anders Carlsson.
4076
4077         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
4078         * DumpRenderTree/win/UIDelegate.h: Ditto.
4079
4080         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
4081         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
4082
4083         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
4084
4085         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
4086         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
4087         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
4088         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
4089         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
4090         (WebKitDOMDOMWindowTest::create): Ditto.
4091         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
4092         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
4093         of smart pointers to DelayedSIgnal objects.
4094         (uriChangedCallback): Ditto.
4095
4096 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
4097
4098         [Mac] Unreviewed test fix.
4099         https://bugs.webkit.org/show_bug.cgi?id=144149
4100
4101         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
4102         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
4103         test.
4104
4105 2015-04-23  Darin Adler  <darin@apple.com>
4106
4107         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
4108         https://bugs.webkit.org/show_bug.cgi?id=144090
4109
4110         Reviewed by Anders Carlsson.
4111
4112         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
4113
4114 2015-04-23  Michael Saboff  <msaboff@apple.com>
4115
4116         lldb macro btjs sometimes can't get a frame description
4117         https://bugs.webkit.org/show_bug.cgi?id=144130
4118
4119         Reviewed by Filip Pizlo.
4120
4121         We look to execute ExecState::describeFrame().  It appears that in some contexts the
4122         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
4123         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
4124
4125         * lldb/lldb_webkit.py:
4126         (btjs):
4127
4128 2015-04-23  Alex Christensen  <achristensen@webkit.org>
4129
4130         Use less memory when compiling content extensions.
4131         https://bugs.webkit.org/show_bug.cgi?id=144051
4132
4133         Reviewed by Darin Adler and Benjamin Poulain.
4134
4135         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4136         (TestWebKitAPI::TEST_F):
4137         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
4138         (TestWebKitAPI::countLiveNodes):
4139
4140 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
4141
4142         [CMake] Clean up JSC JIT options
4143         https://bugs.webkit.org/show_bug.cgi?id=143998
4144
4145         Reviewed by Filip Pizlo.
4146
4147         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
4148         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
4149
4150 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
4151
4152         [Mac] Extend action menus to support PDF
4153         https://bugs.webkit.org/show_bug.cgi?id=143895
4154         <rdar://problem/19003333>
4155
4156         Reviewed by Tim Horton.
4157
4158         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
4159         of PDF content works.
4160
4161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
4162         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
4163         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
4164         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
4165         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
4166         Update to support PDF tests.
4167         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
4168         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
4169
4170 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
4171
4172         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
4173
4174         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
4175         (beforeAll):
4176         (testWebViewAudioOnlyUserMediaPermissionRequests):
4177
4178 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
4179
4180         Add myself to watchlist
4181         https://bugs.webkit.org/show_bug.cgi?id=144041
4182
4183         Reviewed by Alex Christensen.
4184
4185         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
4186
4187         * Scripts/webkitpy/common/config/watchlist:
4188
4189 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
4190
4191         [GTK] MiniBrowser should use NetworkProcess by default
4192         https://bugs.webkit.org/show_bug.cgi?id=143948
4193
4194         Reviewed by Sergio Villar Senin.
4195
4196         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
4197         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
4198
4199         * MiniBrowser/gtk/main.c:
4200         (main):
4201
4202 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
4203
4204         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
4205
4206         Unreviewed build fix.
4207
4208         * Scripts/prepare-ChangeLog:
4209         (get_function_line_ranges_for_cpp):
4210         Use grep instead of any to determine if a string is an element of an array.
4211
4212 2015-04-21  Anders Carlsson  <andersca@apple.com>
4213
4214         Fix block signatures
4215         https://bugs.webkit.org/show_bug.cgi?id=144002
4216
4217         Reviewed by Andreas Kling.
4218
4219         * MiniBrowser/mac/WK2BrowserWindowController.m:
4220         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4221
4222 2015-04-21  Philippe Normand  <pnormand@igalia.com>
4223
4224         [GTK] jhbuild should not use a branch for openwebrtc
4225         https://bugs.webkit.org/show_bug.cgi?id=143981
4226
4227         Reviewed by Carlos Garcia Campos.
4228
4229         * gtk/jhbuild.modules:
4230
4231 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
4232
4233         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
4234
4235         Unreviewed build fix.
4236
4237         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
4238         However, it has been exposed by List::MoreUtils since its inception. This patch uses
4239         the any function exposed by List::MoreUtils for greater compatibility.
4240
4241         * Scripts/prepare-ChangeLog:
4242         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
4243         the any function in all of versions of Perl used by our infrastructure.
4244
4245 2015-04-20  Alex Christensen  <achristensen@webkit.org>
4246
4247         Remove unnecessary logs when resetting tests.
4248
4249         * WebKitTestRunner/mac/TestControllerMac.mm:
4250         (WTR::TestController::platformResetPreferencesToConsistentValues):
4251         In r183020 I added some logs when compiling or removing content extensions fails.
4252         We often try to remove a content extension that does not exist, and that is not a problem.
4253
4254 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
4255
4256         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
4257         https://bugs.webkit.org/show_bug.cgi?id=143897
4258
4259         Reviewed by David Kilzer.
4260
4261         This is a speculative fix that addresses two issues:
4262
4263         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
4264         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
4265
4266         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
4267         Before: (723, 729)
4268         After: (721, 720)
4269
4270         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
4271         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
4272
4273         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
4274         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
4275
4276         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
4277
4278         2. Creating git diffs from HEAD and not origin/master by default.
4279
4280         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
4281         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
4282
4283         * Scripts/prepare-ChangeLog:
4284         (originalFile):
4285         Use HEAD instead of origin/master in default Git case.
4286
4287         (generateFunctionLists):
4288         Ensure that the end line is not less than the start line.
4289
4290         (extractLineRangeAfterChange):
4291         Set the end line to the start line if the end line is less than the start line.
4292
4293         (extractLineRangeBeforeChange):
4294         Ditto.
4295
4296 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
4297
4298         Suppress warning in prepare-ChangeLog.
4299         https://bugs.webkit.org/show_bug.cgi?id=143882
4300
4301         Reviewed by David Kilzer.
4302
4303         Prune noisy prepare-ChangeLog output by using the List::Util::any function
4304         instead of the deprecated smartmatch operator.
4305
4306         * Scripts/prepare-ChangeLog:
4307         Import the List::Util::any function.
4308
4309         (get_function_line_ranges_for_cpp):
4310         Use the any function instead of smartmatch.
4311
4312 2015-04-20  Anders Carlsson  <andersca@apple.com>
4313
4314         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
4315         https://bugs.webkit.org/show_bug.cgi?id=143966
4316
4317         Reviewed by Dan Bernstein.
4318
4319         * MiniBrowser/mac/WK2BrowserWindowController.m:
4320         (dataTypes):
4321         (-[WK2BrowserWindowController fetchWebsiteData:]):
4322         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
4323         (-[WK2BrowserWindowController clearWebsiteData:]):
4324
4325 2015-04-20  Alex Christensen  <achristensen@webkit.org>
4326
4327         Fix content extension test flakiness.
4328         https://bugs.webkit.org/show_bug.cgi?id=143950
4329
4330         Reviewed