324e1691438523a9a96d11d07e1344294e7d4e79
[WebKit-https.git] / Tools / ChangeLog
1 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
4
5         * Scripts/webkitpy/tool/commands/suggestnominations.py:
6         (AbstractCommitLogCommand._recent_commit_messages):
7
8 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
9
10         [GTK] [CMake] Add support for building WebKit2
11         https://bugs.webkit.org/show_bug.cgi?id=116372
12
13         Reviewed by Gustavo Noronha Silva.
14
15         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
16         * MiniBrowser/gtk/CMakeLists.txt: Added.
17
18 2013-05-21  Jessie Berlin  <jberlin@apple.com>
19
20         Revert r149635, it was too optimistic.
21
22         Rubber-stamped by Andreas Kling.
23
24         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
25         #ifdefs in WebCore code outside of WebCore/platform.
26
27         * Scripts/webkitpy/style/checkers/cpp.py:
28         (check_invalid_increment):
29         (process_line):
30         (CppChecker):
31         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
32         (CppStyleTest.test_plain_integral_bitfields):
33
34 2013-05-21  Jer Noble  <jer.noble@apple.com>
35
36         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
37
38         * lldb/lldb_webkit.py:
39         (WTFVectorProvider.num_children):
40         (WTFVectorProvider.get_child_index):
41         (WTFVectorProvider.get_child_at_index):
42         (WTFVectorProvider.update):
43
44 2013-05-21  Jessie Berlin  <jberlin@apple.com>
45
46         Expose a way to know when forms are added to a page or when form controls are added to a form
47         in the injected bundle
48         https://bugs.webkit.org/show_bug.cgi?id=116334
49
50         Reviewed by Alexey Proskuryakov.
51
52         Add tests for the new callbacks.
53
54         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
55         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
56
57         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
58         (TestWebKitAPI::nullJavaScriptCallback):
59         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
60         being passed in for the callback.
61         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
62         After receiving the message that didAssociateFormControls callback was invoked from adding
63         the form in the onload handler, tell the page to add a password field to the form, which
64         should also invoke didAssociateFormControls callback.
65         (TestWebKitAPI::setInjectedBundleClient):
66         Register to receive messages.
67         (TestWebKitAPI::TEST):
68         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
69         been invoked for both adding the form and for adding a password field to the form.
70
71         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
72         (TestWebKitAPI::shouldNotifyOnFormChanges):
73         Return true so the didAssociateFormControls callback is invoked.
74         (TestWebKitAPI::didAssociateFormControls):
75         Tell the UI process.
76         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
77         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
78         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
79
80         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
81         Add a form in response to the onload event. Add a button that will add the password field
82         for manual testing.
83
84 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
85
86         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
87         https://bugs.webkit.org/show_bug.cgi?id=106341
88
89         Reviewed by Martin Robinson.
90
91         Adds support for retrieving accessibility element at exact point.
92
93         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
94         (WTR::AccessibilityUIElement::elementAtPoint):
95
96 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
97
98         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
99         https://bugs.webkit.org/show_bug.cgi?id=112913
100
101         Reviewed by Martin Robinson.
102
103         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
104         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
105         so the leak appears.
106
107         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
108         (WTR):
109         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
110         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
111         (WTR::AccessibilityController::rootElement):
112         (WTR):
113         (WTR::AccessibilityController::focusedElement):
114         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
115         (WTR::checkElementState):
116         (WTR::indexRangeInTable):
117         (WTR::alterCurrentValue):
118         (WTR::AccessibilityUIElement::getChildren):
119         (WTR::AccessibilityUIElement::getChildrenWithRange):
120         (WTR::AccessibilityUIElement::childrenCount):
121         (WTR::AccessibilityUIElement::indexOfChild):
122         (WTR::AccessibilityUIElement::titleUIElement):
123         (WTR::AccessibilityUIElement::parentElement):
124         (WTR::AccessibilityUIElement::allAttributes):
125         (WTR::AccessibilityUIElement::role):
126         (WTR::AccessibilityUIElement::title):
127         (WTR::AccessibilityUIElement::description):
128         (WTR::AccessibilityUIElement::orientation):
129         (WTR::AccessibilityUIElement::stringValue):
130         (WTR::AccessibilityUIElement::language):
131         (WTR::AccessibilityUIElement::x):
132         (WTR::AccessibilityUIElement::y):
133         (WTR::AccessibilityUIElement::width):
134         (WTR::AccessibilityUIElement::height):
135         (WTR::AccessibilityUIElement::intValue):
136         (WTR::AccessibilityUIElement::minValue):
137         (WTR::AccessibilityUIElement::maxValue):
138         (WTR::AccessibilityUIElement::isEnabled):
139         (WTR::AccessibilityUIElement::isFocused):
140         (WTR::AccessibilityUIElement::isSelected):
141         (WTR::AccessibilityUIElement::isExpanded):
142         (WTR::AccessibilityUIElement::isChecked):
143         (WTR::AccessibilityUIElement::rowCount):
144         (WTR::AccessibilityUIElement::columnCount):
145         (WTR::AccessibilityUIElement::rowIndexRange):
146         (WTR::AccessibilityUIElement::columnIndexRange):
147         (WTR::AccessibilityUIElement::cellForColumnAndRow):
148         (WTR::AccessibilityUIElement::increment):
149         (WTR::AccessibilityUIElement::decrement):
150         (WTR::AccessibilityUIElement::press):
151         (WTR::AccessibilityUIElement::documentEncoding):
152         (WTR::AccessibilityUIElement::documentURI):
153         (WTR::AccessibilityUIElement::isFocusable):
154         (WTR::AccessibilityUIElement::isSelectable):
155         (WTR::AccessibilityUIElement::isMultiSelectable):
156         (WTR::AccessibilityUIElement::isVisible):
157
158 2013-05-20  Lucas Forschler  <lforschler@apple.com>
159
160     Rollout 150398.
161     
162 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
163
164         [GTK] Fix concatenations of string literals that are not C++11-compliant
165         https://bugs.webkit.org/show_bug.cgi?id=116449
166
167         Reviewed by Martin Robinson.
168
169         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
170         is simply a matter of separating the string and the string literal that are being concatenated with a space.
171
172         * ImageDiff/gtk/ImageDiff.cpp:
173         (printImage):
174
175 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
176
177         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
178         https://bugs.webkit.org/show_bug.cgi?id=116450
179
180         Reviewed by Martin Robinson.
181
182         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
183         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
184         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
185         TestWebKitAPI programs when compiling them.
186
187         * TestWebKitAPI/GNUmakefile.am:
188
189 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
190
191         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
192         https://bugs.webkit.org/show_bug.cgi?id=116492
193
194         Reviewed by Dirk Pranke.
195
196         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
197
198         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
199         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
200         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
201         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
202         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
203         to memory pressure on the machine.
204
205         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
206         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
207         for a subsequent patch just to make things easier to follow.
208
209         * Scripts/webkitpy/port/driver.py:
210         (DriverProxy.__init__):
211         (DriverProxy.run_test):
212         (DriverProxy.has_crashed):
213         (DriverProxy.stop):
214
215 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
216
217         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
218         https://bugs.webkit.org/show_bug.cgi?id=116423
219
220         Reviewed by Ryosuke Niwa.
221
222         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
223
224         * BuildSlaveSupport/build.webkit.org-config/config.json:
225
226 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
227
228         Remove remaining link-prerender code
229         https://bugs.webkit.org/show_bug.cgi?id=116429
230
231         Reviewed by Darin Adler.
232
233         Link prerendering code was removed in r150356.
234
235         * Scripts/webkitperl/FeatureList.pm:
236         * qmake/mkspecs/features/features.pri:
237
238 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
239
240         commit-queue should check for oops in changelog entries
241         https://bugs.webkit.org/show_bug.cgi?id=116395
242
243         Reviewed by Martin Robinson.
244
245         Make changelog validation fail when it contains oops!.
246
247         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
248         (CommitQueueTask._validate_changelog):
249         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
250         (CommitQueueTaskTest._run_through_task):
251         * Scripts/webkitpy/tool/commands/queues_unittest.py:
252         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
253         (ValidateChangeLogs.options):
254         (ValidateChangeLogs._check_changelog_diff):
255         (ValidateChangeLogs._changelog_contains_oops):
256         (ValidateChangeLogs.run):
257         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
258         (ValidateChangeLogsTest._assert_start_line_produces_output):
259         (ValidateChangeLogsTest.test_check_changelog_diff):
260         (ValidateChangeLogsTest):
261         (ValidateChangeLogsTest.test_changelog_contains_oops):
262
263 2013-05-20  Jessie Berlin  <jberlin@apple.com>
264
265         Expose a way to know when forms are added to a page or when form controls are added to a form
266         in the injected bundle
267         https://bugs.webkit.org/show_bug.cgi?id=116334
268
269         Reviewed by Alexey Proskuryakov.
270
271         Add tests for the new callbacks.
272
273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
274         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
275
276         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
277         (TestWebKitAPI::nullJavaScriptCallback):
278         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
279         being passed in for the callback.
280         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
281         After receiving the message that didAssociateFormControls callback was invoked from adding
282         the form in the onload handler, tell the page to add a password field to the form, which
283         should also invoke didAssociateFormControls callback.
284         (TestWebKitAPI::setInjectedBundleClient):
285         Register to receive messages.
286         (TestWebKitAPI::TEST):
287         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
288         been invoked for both adding the form and for adding a password field to the form.
289
290         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
291         (TestWebKitAPI::shouldNotifyOnFormChanges):
292         Return true so the didAssociateFormControls callback is invoked.
293         (TestWebKitAPI::didAssociateFormControls):
294         Tell the UI process.
295         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
296         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
297         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
298
299         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
300         Add a form in response to the onload event. Add a button that will add the password field
301         for manual testing.
302
303 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
304
305         [EFL][JHBUILD] Make sure eet is built before evas
306         https://bugs.webkit.org/show_bug.cgi?id=116440
307
308         Reviewed by Gyuyoung Kim.
309
310         Mark eet as a dependency of evas since evas requires eet to enable some of its
311         functionality.
312
313         * efl/jhbuild.modules:
314
315 2013-05-20  Alex Christensen  <achristensen@apple.com>
316
317         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
318         https://bugs.webkit.org/show_bug.cgi?id=116125
319
320         Reviewed by Tim Horton.
321
322         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
323         (WTR::pathSuitableForTestResult):
324         Changed string operations to match _drt_descriptionSuitableForTestResult.
325         (WTR::dumpRequestDescriptionSuitableForTestResult):
326         (WTR::dumpResponseDescriptionSuitableForTestResult):
327         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
328         (WTR::InjectedBundlePage::didInitiateLoadForResource):
329         (WTR::InjectedBundlePage::willSendRequestForFrame):
330         (WTR::InjectedBundlePage::didReceiveResponseForResource):
331         Pass the main frame's URL to pathSuitableForTestResult.
332         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
333         Added WKBundlePageRef to willPerformClientRedirectForFrame.
334
335 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
336
337         fix w3c test importer unit tests after r150324
338         https://bugs.webkit.org/show_bug.cgi?id=116459
339
340         Reviewed by Ryosuke Niwa.
341
342         This patch fixes the unit tests to not actually call out to
343         'hg' (by using a mock executive) and also changes the real
344         directory we crawl from Source/WebCore/css to
345         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
346         still change this to a mock filesystem, but that's a separate change.
347
348         * Scripts/webkitpy/w3c/test_importer.py:
349         (main):
350         (TestImporter.__init__):
351         (TestImporter.load_changeset):
352         * Scripts/webkitpy/w3c/test_importer_unittest.py:
353         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
354         (TestImporterTest.test_import_dir_with_no_tests):
355
356 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
357
358         Unreviewed EFL build fix.
359
360         Fix linking errors due to undefined symbols on Ubuntu 13.04.
361
362         * DumpRenderTree/efl/CMakeLists.txt:
363         * EWebLauncher/CMakeLists.txt:
364         * MiniBrowser/efl/CMakeLists.txt:
365
366 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
367
368         [EFL] Reenabled INDEXED_DATABASE after r150344
369         https://bugs.webkit.org/show_bug.cgi?id=116430
370
371         Reviewed by Gyuyoung Kim.
372
373         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
374         build was fixed in r150344.
375
376         * Scripts/webkitperl/FeatureList.pm:
377
378 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
379
380         [EFL] init/shutdown should be paired in EWebLauncher
381         https://bugs.webkit.org/show_bug.cgi?id=116427
382
383         Reviewed by Christophe Dumez.
384
385         Added ecore_file_shutdown() for cleanup of ecore_file.
386         Removed edje_init and ecore_evas_init because it was in ewk_init().
387
388         * EWebLauncher/main.c:
389         (main):
390
391 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
392
393         [EFL] Add command line option to MiniBrowser to set user agent
394         https://bugs.webkit.org/show_bug.cgi?id=116387
395
396         Reviewed by Christophe Dumez.
397
398         We need this option to compare the rendering differences according to different user agents.
399
400         * MiniBrowser/efl/main.c:
401         (window_create):
402         (elm_main):
403
404 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
405
406         Unreviewed, addressing test-webkitpy failures after r150317.
407
408         * Scripts/webkitpy/w3c/test_converter.py:
409         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
410
411 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
412
413         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
414         https://bugs.webkit.org/show_bug.cgi?id=114554
415
416         Reviewed by Gyuyoung Kim.
417
418         Using variables as target names is very uncommon in CMake.
419         The usual way to specify the name of the resulting binary
420         is to set the OUTPUT_NAME target property.
421
422         * DumpRenderTree/efl/CMakeLists.txt:
423         * EWebLauncher/CMakeLists.txt:
424         * ImageDiff/CMakeLists.txt:
425         * MiniBrowser/efl/CMakeLists.txt:
426         * TestWebKitAPI/CMakeLists.txt:
427         * WebKitTestRunner/CMakeLists.txt:
428         * WebKitTestRunner/PlatformEfl.cmake:
429         * WinCELauncher/CMakeLists.txt:
430
431 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
432
433         Unreviewed EFL build fix.
434
435         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
436         WK2 build after r150305.
437
438         * Scripts/webkitperl/FeatureList.pm:
439
440 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
441
442         [GTK] Parallel build fails if gtk-doc is enabled
443         https://bugs.webkit.org/show_bug.cgi?id=116227
444
445         Reviewed by Martin Robinson.
446
447         * GNUmakefile.am:
448         Don't use the 'all' target to generate the documentation.
449         The prerequisites of this target must be files that need to be
450         built _before_ the actual compilation of WebKit starts. Since the
451         documentation depends on WebKit being built first, this means in
452         practice that the code will be built in parallel with the
453         generation of its dependencies, potentially making the build fail.
454
455 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
456
457         Don't run hg.
458
459         * Scripts/webkitpy/w3c/test_importer_unittest.py:
460         (TestImporterTest):
461
462 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
463
464         Create a script to import W3C tests
465         https://bugs.webkit.org/show_bug.cgi?id=111513
466
467         Reviewed by Ryosuke Niwa.
468
469         This patch attempts to re-land the 'import-w3c-tests'
470         script and accompanying modules.  The tests and code have
471         been cleaned up so that we do not log anything to stdout/stderr
472         while running the tests (thanks to outputcapture) and do not
473         write into the source tree while running the tests, and much
474         but not all of the code has been converted over to using the webkitpy
475
476         * Scripts/import-w3c-tests: Added.
477         * Scripts/webkitpy/w3c/__init__.py: Added.
478         * Scripts/webkitpy/w3c/test_converter.py: Added.
479         (W3CTestConverter):
480         (W3CTestConverter.__init__):
481         (W3CTestConverter.path_from_webkit_root):
482         (W3CTestConverter.read_webkit_prefixed_css_property_list):
483         (W3CTestConverter.convert_for_webkit):
484         (W3CTestConverter.convert_css):
485         (W3CTestConverter.convert_html):
486         (W3CTestConverter.convert_testharness_paths):
487         (W3CTestConverter.convert_prefixed_properties):
488         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
489         (W3CTestConverter.replace_tag):
490         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
491         (W3CTestConverterTest):
492         (W3CTestConverterTest.fake_dir_path):
493         (W3CTestConverterTest.test_read_prefixed_property_list):
494         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
495         (test_convert_for_webkit_harness_only):
496         (test_convert_for_webkit_properties_only):
497         (test_convert_for_webkit_harness_and_properties):
498         (test_convert_test_harness_paths):
499         (test_convert_prefixed_properties):
500         (verify_conversion_happened):
501         (verify_no_conversion_happened):
502         (verify_test_harness_paths):
503         (verify_prefixed_properties):
504         (generate_test_content):
505         * Scripts/webkitpy/w3c/test_importer.py: Added.
506         (main):
507         (parse_args):
508         (validate_import_directory):
509         (TestImporter):
510         (TestImporter.__init__):
511         (TestImporter.path_from_webkit_root):
512         (TestImporter.do_import):
513         (TestImporter.load_changeset):
514         (TestImporter.find_importable_tests):
515         (TestImporter.import_tests):
516         (TestImporter.setup_destination_directory):
517         (TestImporter.update_test_status):
518         (TestImporter.remove_deleted_files):
519         (TestImporter.write_import_log):
520         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
521         (TestImporterTest):
522         (TestImporterTest.test_import_dir_with_no_tests):
523         * Scripts/webkitpy/w3c/test_parser.py: Added.
524         (TestParser):
525         (TestParser.__init__):
526         (TestParser.load_file):
527         (TestParser.analyze_test):
528         (TestParser.reference_links_of_type):
529         (TestParser.is_jstest):
530         (TestParser.support_files):
531         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
532         (TestParserTest):
533         (TestParserTest.test_analyze_test_reftest_one_match):
534         (test_analyze_test_reftest_multiple_matches):
535         (test_analyze_test_reftest_match_and_mismatch):
536         (test_analyze_test_reftest_with_ref_support_Files):
537         (test_analyze_jstest):
538         (test_analyze_pixel_test_all_true):
539         (test_analyze_pixel_test_all_false):
540         (test_analyze_non_html_file):
541
542 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
543
544         Leaks builders exit early frequently
545         https://bugs.webkit.org/show_bug.cgi?id=116355
546
547         Reviewed by Stephanie Lewis.
548
549         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
550         we tolerate from 20 to 50.
551
552         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
553         (RunWebKitTests.start):
554         * Scripts/webkitpy/port/mac.py:
555         (MacPort.default_child_processes):
556
557 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
558
559         Remove chrome-channels command from the webkit-patch
560         https://bugs.webkit.org/show_bug.cgi?id=116303
561
562         Reviewed by Ryosuke Niwa.
563
564         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
565         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
566         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
567         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
568         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
569         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
570
571 2013-05-17  David Kilzer  <ddkilzer@apple.com>
572
573         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
574         Part 3 of 3: <http://webkit.org/b/116247>
575
576         Reviewed by Benjamin Poulain.
577
578         * Scripts/filter-build-webkit: Change while() loop to for() loop
579         to track $previousLine, then pass $previousLine into
580         shouldIgnoreLine().
581         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
582         line that begins with four spaces if the previous line is a
583         linker error message.
584         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
585         - Add "Ignored: " to test descriptions to document expected
586           behavior.
587         - Add comment blocks for various groups of tests.
588         - Expand "Build settings" tests since we're changing the code in
589           shouldIgnoreLine() that ignores those lines.
590         - Add tests for undefined symbols error message.
591         (description): Add.  Extract from global code.
592
593 2013-05-17  David Kilzer  <ddkilzer@apple.com>
594
595         Add tests for shouldIgnoreLine() in filter-build-webkit
596         Part 2 of 3: <http://webkit.org/b/116247>
597
598         Reviewed by Benjamin Poulain.
599
600         * Scripts/filter-build-webkit:
601         (shouldIgnoreLine): Add.  Extract code from global scope into
602         subroutine to make it testable.
603         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
604         Tests shouldIgnoreLine() using output from a real build
605         transcript.
606
607 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
608
609         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
610         https://bugs.webkit.org/show_bug.cgi?id=116341
611
612         Reviewed by Brady Eidson.
613
614         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
615
616 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
617
618         [Windows] Don't use pdevenv when building with VS2010.
619         https://bugs.webkit.org/show_bug.cgi?id=116338.
620
621         Reviewed by Adam Roben.
622
623         * Scripts/webkitdirs.pm:
624         (setupCygwinEnv): Check if we are using VS2005, and only use
625         the 'pdevenv' hack if we are. Otherwise, just build with
626         our standard project since it uses VS2010+'s native
627         parallel building features.
628
629 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
630
631         Unreviewed. Disable accelerated compositing until we figure out why it does not work
632         properly in the 64 bits release bot.
633
634         * DumpRenderTree/gtk/DumpRenderTree.cpp:
635         (resetDefaultsToConsistentValues):
636
637 2013-05-17  David Kilzer  <ddkilzer@apple.com>
638
639         Make filter-build-webkit testable using LoadAsModule
640         Part 1 of 3: <http://webkit.org/b/116247>
641
642         Reviewed by Benjamin Poulain.
643
644         * Scripts/filter-build-webkit: Change global variables that are
645         used in subroutines from 'my' to 'our' to make it possible to
646         evaluate the script in a package context in LoadAsModule.pm.
647
648 2013-05-14  Sam Weinig  <sam@webkit.org>
649
650         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
651         https://bugs.webkit.org/show_bug.cgi?id=116132
652
653         Reviewed by Anders Carlsson.
654
655         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
656         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
657
658         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
659         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
660         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
661         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
662
663 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
664
665         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
666         https://bugs.webkit.org/show_bug.cgi?id=114781
667
668         Reviewed by Christophe Dumez.
669
670         Add run_before_unload_confirm and
671         Print the log message with "CONFIRM NAVIGATION: " in console.
672
673         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
674         (onBeforeUnloadConfirm):
675         (drtViewAdd):
676
677 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
678
679         Fix Analyze ChangeLog's entry processing
680         https://bugs.webkit.org/show_bug.cgi?id=116219
681
682         Reviewed by Ryosuke Niwa.
683
684         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
685         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
686
687 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
688
689         [Qt] UrlLoader::loadNext is broken in MiniBrowser
690         https://bugs.webkit.org/show_bug.cgi?id=116099
691
692         Reviewed by Jocelyn Turcotte.
693
694         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
695         are not available any more. So, UrlLoader::loadNext was broken
696         because it failed to connect to those signals.
697
698         * MiniBrowser/qt/UrlLoader.cpp:
699         (UrlLoader::UrlLoader):
700         (UrlLoader::loadingChanged):
701         * MiniBrowser/qt/UrlLoader.h:
702         (UrlLoader):
703
704 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
705
706         [WebSocket] Update pywebsocket to r760
707         https://bugs.webkit.org/show_bug.cgi?id=115863
708
709         Reviewed by Alexey Proskuryakov.
710
711         Version r760 supports a newer draft of message compression.
712         We need this update to finish the permessage compression patch in
713         bug 98840. This patch also fixes failing unit tests after the update.
714
715         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
716         (StreamBase._read):
717         (StreamBase._read.of):
718         (StreamBase._write):
719         (StreamBase.receive_bytes):
720         (StreamBase._read_until):
721         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
722         (parse_frame):
723         (StreamOptions.__init__):
724         (Stream.__init__):
725         (Stream._receive_frame_as_frame_object):
726         (Stream._get_message_from_frame):
727         (Stream._process_close_message):
728         (Stream.close_connection):
729         (Stream.get_last_received_opcode):
730         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
731         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
732         (Dispatcher.do_extra_handshake):
733         (Dispatcher.transfer_data):
734         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
735         (ExtensionProcessorInterface.__init__):
736         (ExtensionProcessorInterface.request):
737         (ExtensionProcessorInterface):
738         (ExtensionProcessorInterface.name):
739         (ExtensionProcessorInterface.check_consistency_with_other_processors):
740         (ExtensionProcessorInterface.set_active):
741         (ExtensionProcessorInterface.is_active):
742         (ExtensionProcessorInterface._get_extension_response_internal):
743         (ExtensionProcessorInterface.get_extension_response):
744         (ExtensionProcessorInterface._setup_stream_options_internal):
745         (ExtensionProcessorInterface.setup_stream_options):
746         (_log_outgoing_compression_ratio):
747         (_log_incoming_compression_ratio):
748         (_parse_window_bits):
749         (_AverageRatioCalculator):
750         (_AverageRatioCalculator.__init__):
751         (_AverageRatioCalculator.add_original_bytes):
752         (_AverageRatioCalculator.add_result_bytes):
753         (_AverageRatioCalculator.get_average_ratio):
754         (DeflateFrameExtensionProcessor):
755         (DeflateFrameExtensionProcessor.__init__):
756         (DeflateFrameExtensionProcessor._get_extension_response_internal):
757         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
758         (DeflateFrameExtensionProcessor._outgoing_filter):
759         (DeflateFrameExtensionProcessor._incoming_filter):
760         (CompressionExtensionProcessorBase.for):
761         (CompressionExtensionProcessorBase.__init__):
762         (CompressionExtensionProcessorBase._get_extension_response_internal):
763         (CompressionExtensionProcessorBase._setup_stream_options_internal):
764         (PerFrameCompressExtensionProcessor):
765         (PerMessageDeflateExtensionProcessor):
766         (PerMessageDeflateExtensionProcessor.__init__):
767         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
768         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
769         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
770         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
771         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
772         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
773         (PerMessageDeflateExtensionProcessor.set_bfinal):
774         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
775         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
776         (_PerMessageDeflateFramer):
777         (_PerMessageDeflateFramer.__init__):
778         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
779         (_PerMessageDeflateFramer._process_incoming_message):
780         (_PerMessageDeflateFramer._process_outgoing_message):
781         (_PerMessageDeflateFramer.setup_stream_options):
782         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
783         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
784         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
785         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
786         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
787         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
788         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
789         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
790         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
791         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
792         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
793         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
794         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
795         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
796         (PerMessageCompressExtensionProcessor):
797         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
798         (MuxExtensionProcessor.__init__):
799         (MuxExtensionProcessor.check_consistency_with_other_processors):
800         (MuxExtensionProcessor):
801         (MuxExtensionProcessor._get_extension_response_internal):
802         (MuxExtensionProcessor._setup_stream_options_internal):
803         (MuxExtensionProcessor.set_quota):
804         (MuxExtensionProcessor.quota):
805         (MuxExtensionProcessor.set_extensions):
806         (MuxExtensionProcessor.extensions):
807         (is_compression_extension):
808         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
809         (validate_subprotocol):
810         (parse_host_header):
811         (format_header):
812         (check_request_line):
813         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
814         (Handshaker.do_handshake):
815         (Handshaker._create_handshake_response):
816         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
817         (_validate_subprotocol):
818         (_check_header_lines):
819         (_build_location):
820         (Handshaker.do_handshake):
821         (Handshaker._set_subprotocol):
822         (Handshaker._set_location):
823         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
824         (_create_dispatcher):
825         (headerparserhandler):
826         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
827         (_create_add_channel_response):
828         (_create_drop_channel):
829         (_create_flow_control):
830         (_create_new_channel_slot):
831         (_create_fallback_new_channel_slot):
832         (_MuxFramePayloadParser._read_number):
833         (_MuxFramePayloadParser._read_size_and_contents):
834         (_MuxFramePayloadParser._read_flow_control):
835         (_MuxFramePayloadParser._read_new_channel_slot):
836         (_LogicalConnection.__init__):
837         (_LogicalConnection.write):
838         (_LogicalConnection.on_write_data_done):
839         (_LogicalConnection):
840         (_LogicalConnection.on_writer_done):
841         (_InnerMessage):
842         (_InnerMessage.__init__):
843         (_InnerMessageBuilder):
844         (_InnerMessageBuilder.that):
845         (_InnerMessageBuilder.__init__):
846         (_InnerMessageBuilder._handle_first):
847         (_InnerMessageBuilder._process_first_fragmented_control):
848         (_InnerMessageBuilder._process_first_fragmented_message):
849         (_InnerMessageBuilder._handle_fragmented_control):
850         (_InnerMessageBuilder._reassemble_fragmented_control):
851         (_InnerMessageBuilder._handle_fragmented_message):
852         (_InnerMessageBuilder._reassemble_fragmented_message):
853         (_InnerMessageBuilder.build):
854         (_LogicalStream.__init__):
855         (_LogicalStream._create_inner_frame):
856         (_LogicalStream._write_inner_frame):
857         (_LogicalStream.replenish_send_quota):
858         (_LogicalStream.send_message):
859         (_LogicalStream._receive_frame):
860         (_LogicalStream._get_message_from_frame):
861         (_LogicalStream.stop_sending):
862         (_PhysicalConnectionWriter.__init__):
863         (_PhysicalConnectionWriter._write_data):
864         (_PhysicalConnectionWriter.run):
865         (_PhysicalConnectionWriter.stop):
866         (_Worker.run):
867         (_MuxHandshaker.__init__):
868         (_MuxHandshaker._create_stream):
869         (_MuxHandshaker._create_handshake_response):
870         (_HandshakeDeltaBase.create_headers):
871         (_MuxHandler.start):
872         (_MuxHandler.wait_until_done):
873         (_MuxHandler.notify_write_data_done):
874         (_MuxHandler._process_drop_channel):
875         (_MuxHandler._process_logical_frame):
876         (_MuxHandler.notify_reader_done):
877         (_MuxHandler):
878         (_MuxHandler.notify_writer_done):
879         (_MuxHandler.fail_physical_connection):
880         (_MuxHandler.fail_logical_channel):
881         (use_mux):
882         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
883         (_StandaloneRequest.get_uri):
884         (_StandaloneRequest.get_unparsed_uri):
885         (_StandaloneRequest):
886         (_StandaloneRequest.is_https):
887         (_import_ssl):
888         (_import_pyopenssl):
889         (_StandaloneSSLConnection.for):
890         (_StandaloneSSLConnection):
891         (_StandaloneSSLConnection.__getattribute__):
892         (_StandaloneSSLConnection.__setattr__):
893         (_StandaloneSSLConnection.makefile):
894         (_StandaloneSSLConnection.shutdown):
895         (_StandaloneSSLConnection.recv):
896         (WebSocketServer.__init__):
897         (WebSocketServer._create_sockets):
898         (WebSocketServer.handle_error):
899         (WebSocketServer.get_request):
900         (WebSocketServer.get_request.default_callback):
901         (WebSocketRequestHandler.parse_request):
902         (_build_option_parser):
903         (_main):
904         (_main.if):
905         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
906         (RepeatedXorMasker.__init__):
907         (RepeatedXorMasker._mask_using_swig):
908         (RepeatedXorMasker):
909         (RepeatedXorMasker._mask_using_array):
910         (_Deflater.compress_and_finish):
911         (_RFC1979Deflater.filter):
912         (DeflateSocket.send):
913
914 2013-05-16  Jonathan Liu  <net147@gmail.com>
915
916         Fix testing if program exists in PATH
917         https://bugs.webkit.org/show_bug.cgi?id=116216
918
919         Reviewed by Jocelyn Turcotte.
920
921         functions.prf incorrectly uses win_cmd_shell to test whether to
922         add .exe to the executable name when checking if it exists in
923         the PATH environment variable. This works correctly when
924         building using Windows Command Prompt but not under MSYS shell.
925
926         To resolve this, check the win32 platform scope instead of
927         win_cmd_shell so that it correctly adds .exe to the executable
928         name on Windows regardless of the shell used when testing if
929         it exists in PATH.
930
931         * qmake/mkspecs/features/functions.prf:
932
933 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
934
935         Fix the hard-coded names of EWS bots that run tests.
936
937         * Scripts/webkitpy/tool/commands/queues.py:
938         (CommitQueue.did_pass_testing_ews):
939
940 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
941
942         [GTK] Build Xvfb with jhbuild
943         https://bugs.webkit.org/show_bug.cgi?id=115907
944
945         Reviewed by Martin Robinson.
946
947         Build our own Xvfb so that we can avoid problems with the system Xvfb
948         relying on symbols not present in our jhbuilt libraries such as pixman,
949         and also to ensure we have the fix for a GLX module crasher.
950
951         * DumpRenderTree/gtk/DumpRenderTree.cpp:
952         (resetDefaultsToConsistentValues): enable accelerated compositing.
953         * gtk/install-dependencies: list packages required for building Xvfb.
954         * gtk/jhbuild.modules: add xserver as a jhbuild module.
955         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
956         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
957         initializing the GLX module for Xvfb.
958
959 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
960
961         [jhbuild] Should remove the sources directory as well when cleaning
962         https://bugs.webkit.org/show_bug.cgi?id=116229
963
964         Reviewed by Martin Robinson.
965
966         * Scripts/update-webkit-libs-jhbuild:
967         (cleanJhbuild): remove the Source directory as well when cleaning.
968
969 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
970
971         [EFL] Remove Intel Wk2 Buildbots from Master
972         https://bugs.webkit.org/show_bug.cgi?id=116149
973
974         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
975         since Gyuyoung Kim from Samsung plans to take over and maintain it.
976
977         Reviewed by Benjamin Poulain.
978
979         * BuildSlaveSupport/build.webkit.org-config/config.json:
980
981 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
982
983         [Windows] Update various build tools to understand VS2010 environment.
984         https://bugs.webkit.org/show_bug.cgi?id=116169.
985
986         Reviewed by Anders Carlsson.
987
988         * Scripts/build-api-tests: Identify VS2010 environment.
989         * Scripts/build-dumprendertree: Ditto.
990         * Scripts/build-webkit: Ditto.
991         * Scripts/webkitdirs.pm:
992         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
993         range of acceptable SDK's.
994
995 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
996
997         Allow http tests on Arch Linux
998         https://bugs.webkit.org/show_bug.cgi?id=116155
999
1000         Reviewed by Ryosuke Niwa.
1001
1002         * Scripts/webkitpy/port/base.py:
1003         (Port._is_arch_based): Added check for /etc/arch-release file.
1004         (Port._apache_config_file_name_for_platform): Call the check.
1005         * Scripts/webkitpy/port/port_testcase.py:
1006         (test_linux_distro_detection): Testcase added.
1007
1008 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
1009
1010         Remove a leftover v8 file from the watchlist
1011         https://bugs.webkit.org/show_bug.cgi?id=116158
1012
1013         Reviewed by Csaba Osztrogonác.
1014
1015         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
1016
1017 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
1018
1019         [GTK] Fails to build while generating gtkdoc
1020         https://bugs.webkit.org/show_bug.cgi?id=115612
1021
1022         Reviewed by Philippe Normand.
1023
1024         Fix typo in the prerequisites of docs-build.stamp.
1025
1026         * GNUmakefile.am:
1027
1028 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
1029
1030         Unreviewed, fixing the current test-webkitpy failure.
1031
1032         * Scripts/webkitpy/port/mac_unittest.py:
1033         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
1034         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
1035
1036 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
1037
1038         Fix build after r150090.
1039         https://bugs.webkit.org/show_bug.cgi?id=116129
1040
1041         Unreviewed build fix after r150090.
1042
1043         * WebKitTestRunner/TestInvocation.cpp:
1044         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1045
1046 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1047
1048         [Windows, others] Unreviewed build fix after r150090.
1049
1050         * DumpRenderTree/TestRunner.cpp:
1051         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
1052         doesn't exist on other platforms.
1053
1054 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
1055
1056         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
1057         https://bugs.webkit.org/show_bug.cgi?id=115889
1058
1059         Reviewed by Benjamin Poulain.
1060
1061         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1062         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1063
1064 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1065
1066         [Windows] Identify proper run environment for scripts.
1067         https://bugs.webkit.org/show_bug.cgi?id=116114
1068
1069         Reviewed by David Kilzer.
1070
1071         Determine (based on Visual Studio version) which path to use for
1072         executables (bin versus bin32).
1073
1074         * Scripts/webkitdirs.pm:
1075         (determineVisualStudioInstallDir): Added.
1076         (determineVisualStudioVersion): Added.
1077         (determineConfigurationProductDir): Modified to choose proper bin
1078         or bin32 directory.
1079         (visualStudioVersion): Added
1080         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
1081
1082 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1083
1084         [Mac] Add tests for secure event input
1085         https://bugs.webkit.org/show_bug.cgi?id=116121
1086
1087         Reviewed by Mark Rowe.
1088
1089         * DumpRenderTree/TestRunner.cpp:
1090         (getSecureEventInputIsEnabledCallback):
1091         (TestRunner::staticValues):
1092         Expose an accessor for current secure event input state.
1093
1094         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1095         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1096         (WTR::TestRunner::secureEventInputIsEnabled):
1097         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1098         * WebKitTestRunner/TestInvocation.cpp:
1099         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1100         Expose an accessor for current secure event input state. This has to be done in
1101         UI process, as this is where it's changed by WebKit.
1102
1103 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1104
1105         [Mac] Add a testing shim for secure event input functions
1106         https://bugs.webkit.org/show_bug.cgi?id=116122
1107
1108         Reviewed by Mark Rowe.
1109
1110         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
1111         Inject WebCore testing shim library to override system framework functions.
1112
1113 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1114
1115         [Windows] Switch to embedded manifest commands for launcher executables.
1116         https://bugs.webkit.org/show_bug.cgi?id=116109
1117
1118         Reviewed by Darin Adler.
1119
1120         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
1121         now-unused WinLauncher.exe.manifest file.
1122         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1123         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
1124         when building with VS2010 or newer.
1125
1126 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1127
1128         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
1129         https://bugs.webkit.org/show_bug.cgi?id=116079
1130
1131         Reviewed by David Kilzer.
1132
1133         * Scripts/old-run-webkit-tests:
1134         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
1135
1136 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
1137
1138         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
1139         https://bugs.webkit.org/show_bug.cgi?id=115921
1140
1141         Reviewed by Gustavo Noronha Silva.
1142
1143         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
1144         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
1145
1146 2013-05-13  Alex Christensen  <achristensen@apple.com>
1147
1148         Added testRunner.setPrinting.
1149         https://bugs.webkit.org/show_bug.cgi?id=42693
1150         rdar://problem/8213845
1151
1152         Reviewed by Darin Adler.
1153
1154         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1155         Added setPrinting JavaScript function.
1156         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1157         (WTR::InjectedBundlePage::dump):
1158         Dump the external representation for printing if setPrinting has been called.
1159         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1160         (WTR::TestRunner::isPrinting): Added.
1161         (WTR::TestRunner::setPrinting): Added.
1162         Added and initialized m_isPrinting member boolean.
1163
1164 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
1165
1166         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
1167         https://bugs.webkit.org/show_bug.cgi?id=116016
1168
1169         Reviewed by Dirk Pranke.
1170
1171         Same fix as in the upstream style checker, but without hg support.
1172         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
1173
1174         * Scripts/webkitpy/style/checkers/cpp.py:
1175         (FileInfo.repository_name):
1176
1177 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
1178
1179         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
1180         https://bugs.webkit.org/show_bug.cgi?id=115918
1181
1182         Reviewed by Gustavo Noronha Silva.
1183
1184         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
1185         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
1186         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
1187         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
1188         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
1189         problems.
1190
1191         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
1192         These are then used as dependencies for the archive creation rule as well as the list from which the archive
1193         file paths are constructed and then used to dump the member files from these archives. The member files are
1194         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
1195         successfully link.
1196
1197         * TestWebKitAPI/GNUmakefile.am:
1198
1199 2013-05-13  Anders Carlsson  <andersca@apple.com>
1200
1201         Remove UnusedParam.h
1202         https://bugs.webkit.org/show_bug.cgi?id=116029
1203
1204         Reviewed by Andreas Kling.
1205
1206         Stop including UnusedParam.h.
1207
1208         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1209         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1210
1211 2013-05-12  Commit Queue  <commit-queue@webkit.org>
1212
1213         Unreviewed, rolling out r149955.
1214         http://trac.webkit.org/changeset/149955
1215         https://bugs.webkit.org/show_bug.cgi?id=115990
1216
1217         Broke lots of tests (Requested by smfr on #webkit).
1218
1219         * Scripts/webkitpy/port/mac.py:
1220
1221 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1222
1223         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
1224         https://bugs.webkit.org/show_bug.cgi?id=115914
1225
1226         Reviewed by Martin Robinson.
1227
1228         * GtkLauncher/main.c:
1229         (createToolbar):
1230         * MiniBrowser/gtk/BrowserWindow.c:
1231         (_BrowserWindow):
1232         (browserWindowSetStatusText):
1233         (fullScreenMessageTimeoutCallback):
1234         (webViewEnterFullScreen):
1235         (webViewLeaveFullScreen):
1236         (browserWindowFinalize):
1237         (browserWindowConstructed):
1238         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1239         (WTR::EventSenderProxy::mouseScrollBy):
1240         (WTR::EventSenderProxy::continuousMouseScrollBy):
1241
1242 2013-05-11  Anders Carlsson  <andersca@apple.com>
1243
1244         Crash when terminating a process that has not been fully launched
1245         https://bugs.webkit.org/show_bug.cgi?id=115962
1246         <rdar://problem/13660916>
1247
1248         Reviewed by Andreas Kling.
1249
1250         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
1251         before the process has had a chance to be fully launched.
1252
1253         * TestWebKitAPI/GNUmakefile.am:
1254         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1255         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
1256         (TestWebKitAPI):
1257         (TestWebKitAPI::didFinishLoadForFrame):
1258         (TestWebKitAPI::TEST):
1259         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1260
1261 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
1262
1263         Remove Mac OS X Leopard (10.5) support
1264         https://bugs.webkit.org/show_bug.cgi?id=107964
1265
1266         Reviewed by Ryosuke Niwa.
1267
1268         Removed the code for 10.5 and removed if-def for 10.6.
1269
1270         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1271         (convertMIMEType):
1272         (createXMLStringFromWebArchiveData):
1273         * DumpRenderTree/mac/TestRunnerMac.mm:
1274         (TestRunner::authenticateSession):
1275         (TestRunner::setTextDirection):
1276         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1277         (convertMIMEType):
1278         (createXMLStringFromWebArchiveData):
1279
1280 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
1281
1282         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
1283         https://bugs.webkit.org/show_bug.cgi?id=115935
1284
1285         Reviewed by Jer Noble.
1286
1287         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
1288         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
1289         to the new manifest file.
1290         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1291
1292 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
1293
1294         Fix some compiler warnings (miscellaneous)
1295         https://bugs.webkit.org/show_bug.cgi?id=80790
1296
1297         Reviewed by Rob Buis.
1298
1299         Fix the following warnings for BlackBerry:
1300         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
1301         used as truth value [-Wparentheses].
1302
1303         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1304         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1305
1306 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1307
1308         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
1309         https://bugs.webkit.org/show_bug.cgi?id=115928
1310
1311         Reviewed by Kenneth Rohde Christiansen.
1312
1313         WKViewSetThemePath was moved to WKViewEfl.h.
1314
1315         * TestWebKitAPI/efl/PlatformWebView.cpp:
1316
1317 2013-05-10  Andreas Kling  <akling@apple.com>
1318
1319         I accidentally the Java testing.
1320
1321         * Scripts/webkitpy/port/mac.py:
1322
1323 2013-05-10  Brian Holt  <brian.holt@samsung.com>
1324
1325         [GTK] Module Cairo fails to build under jhbuild
1326         https://bugs.webkit.org/show_bug.cgi?id=115854
1327
1328         Reviewed by Martin Robinson.
1329
1330         Make cairo depend on glib in jhbuild.modules.
1331
1332         * gtk/jhbuild.modules:
1333
1334 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1335
1336         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
1337         https://bugs.webkit.org/show_bug.cgi?id=115904
1338
1339         Reviewed by Martin Robinson.
1340
1341         * ImageDiff/gtk/ImageDiff.cpp:
1342         (main):
1343
1344 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
1345
1346         Add my new address to contributors.json. (Unreviewed)
1347
1348         * Scripts/webkitpy/common/config/contributors.json:
1349
1350 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1351
1352         Unreviewed. Move myself to the reviewers list.
1353
1354         * Scripts/webkitpy/common/config/contributors.json:
1355
1356 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1357
1358         Unreviewed. Add my email to a few watchlists.
1359
1360         * Scripts/webkitpy/common/config/watchlist:
1361
1362 2013-05-10  Simon Pena  <simon.pena@samsung.com>
1363
1364         Unicode support missing from string representation of Contributors in committers.py
1365         https://bugs.webkit.org/show_bug.cgi?id=115859
1366
1367         Reviewed by Darin Adler.
1368
1369         Contributors, in committers.py, provided a string representation in __str__ which
1370         didn't support unicode characters, so printing a contributor would fail in that case.
1371         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
1372         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
1373
1374         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
1375         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
1376         representation.
1377         (Contributor.__str__):
1378         (Contributor):
1379         (Contributor.__unicode__):
1380         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
1381         a contributor with unicode characters can be represented as a string.
1382         (CommittersTest):
1383         (CommittersTest.test_contributor_encoding):
1384
1385 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1386
1387         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
1388         https://bugs.webkit.org/show_bug.cgi?id=92371
1389
1390         Reviewed by Brent Fulgham.
1391
1392         Use JavaScriptThreading.cpp where the same functionality is
1393         implemented too. This reduces the dependency on the pthread
1394         library. Also replace assert() with WebKit ASSERT().
1395
1396         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1397         * DumpRenderTree/win/DumpRenderTree.cpp:
1398         (dumpHistoryItem):
1399         (dumpBackForwardList):
1400         * DumpRenderTree/win/DumpRenderTree.vcproj:
1401
1402 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1403
1404         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
1405         https://bugs.webkit.org/show_bug.cgi?id=92505
1406
1407         Reviewed by Brent Fulgham.
1408
1409         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1410         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
1411         (javaScriptThreadsMutex):
1412         (javaScriptThreads):
1413         (runJavaScriptThread):
1414         (startJavaScriptThreads):
1415         (stopJavaScriptThreads):
1416         * DumpRenderTree/pthreads: Removed.
1417         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
1418
1419 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1420
1421         Unreviewed. Update Simon Pena email on his behalf.
1422
1423         * Scripts/webkitpy/common/config/contributors.json:
1424
1425 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1426
1427         Add support for [NoInterfaceObject] Web IDL extended attribute
1428         https://bugs.webkit.org/show_bug.cgi?id=115714
1429
1430         Reviewed by Kentaro Hara.
1431
1432         Update BindingsTests.generate_supplemental_dependency() to pass an
1433         additional windowConstructorsFile argument to preprocess-idls.pl.
1434
1435         * Scripts/webkitpy/bindings/main.py:
1436         (BindingsTests.generate_supplemental_dependency):
1437         (BindingsTests.main):
1438
1439 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
1440
1441         [GTK][AC] Buildfix after r149694
1442         https://bugs.webkit.org/show_bug.cgi?id=115797
1443
1444         Reviewed by Gustavo Noronha Silva.
1445
1446         Add CLUTTER_LIBS for linking TestWebCore.
1447
1448         * TestWebKitAPI/GNUmakefile.am:
1449
1450 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1451
1452         [EFL] Remove unnecessary pkgs in EFL jhbuild
1453         https://bugs.webkit.org/show_bug.cgi?id=114908
1454
1455         Reviewed by Laszlo Gombos.
1456
1457         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
1458         handle them using jhbuild. We can reduce build time when using --update-efl.
1459
1460         * efl/jhbuild.modules:
1461
1462 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
1463
1464         [EFL] Disable SHADOW DOM feature in FeatureList.pm
1465         https://bugs.webkit.org/show_bug.cgi?id=115834
1466
1467         Reviewed by Gyuyoung Kim.
1468
1469         * Scripts/webkitperl/FeatureList.pm:
1470
1471 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1472
1473         Add Scheduler for Mac MtnLion 32bit Release builder.
1474         
1475         Unreviewed.
1476         
1477         * BuildSlaveSupport/build.webkit.org-config/config.json:
1478
1479 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
1480
1481         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
1482         https://bugs.webkit.org/show_bug.cgi?id=115808
1483
1484         Reviewed by Darin Adler.
1485
1486         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
1487         was left outdated after r127191, when the m_string member was changed
1488         from UString to String. This patch calls the right pretty printer for it.
1489
1490         * gdb/webkit.py:
1491         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
1492         WTFImplPrettyPrinter.
1493
1494 2013-05-08  Andy Estes  <aestes@apple.com>
1495
1496         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
1497         https://bugs.webkit.org/show_bug.cgi?id=115790
1498
1499         Reviewed by Alexey Proskuryakov.
1500
1501         Added two API tests:
1502
1503         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
1504         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
1505
1506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1507         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
1508         (TestWebKitAPI):
1509         (TestWebKitAPI::TEST):
1510         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
1511         (TestWebKitAPI):
1512         (TestWebKitAPI::decidePolicyForNavigationAction):
1513         (CustomProtocolInvalidSchemeTest):
1514         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
1515
1516 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1517
1518         Teach buildbot how to compile 32-bit on Mac.
1519
1520         Reviewed by Ryosuke Niwa.
1521
1522         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1523         (CompileWebKit.start):
1524         (ExtractTestResultsAndLeaks):
1525
1526 2013-05-08  Eli Fidler  <efidler@blackberry.com>
1527
1528         [BlackBerry] Fix usage of BlackBerry::Platform::String
1529         https://bugs.webkit.org/show_bug.cgi?id=115781
1530
1531         Reviewed by Rob Buis.
1532
1533         BlackBerry PRs 304193 and 327181
1534         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
1535
1536         We currently have a problem where we're passing UTF-8 encoded data into
1537         the char* constructors of BlackBerry::Platform::String. This means the string
1538         thinks its data is not UTF-8.
1539
1540         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1541         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1542         (BlackBerry::WebKit::dumpHistoryItem):
1543         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1544         (TestRunner::setUserStyleSheetLocation):
1545         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1546         (LoadHTMLStringItem::invoke):
1547
1548 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
1549
1550         Tools: add new BlackBerry include dirs.
1551         https://bugs.webkit.org/show_bug.cgi?id=115514
1552
1553         Reviewed by Rob Buis.
1554
1555         iType include dirs are missing, and HarfBuzz needs to be fixed.
1556
1557         * Scripts/webkitdirs.pm:
1558         (blackberryCMakeArguments):
1559
1560 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
1561
1562         [GTK] Plumb the Automake build system for the Battery Status API feature
1563         https://bugs.webkit.org/show_bug.cgi?id=115718
1564
1565         Reviewed by Martin Robinson.
1566
1567         * Scripts/webkitdirs.pm:
1568         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
1569         through the --(enable|disable)-battery-status flag passed to configure.
1570
1571 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
1572
1573         new-run-webkit-websocketserver doesn't work after Chromium removal
1574         https://bugs.webkit.org/show_bug.cgi?id=115816
1575
1576         Reviewed by Joseph Pecoraro.
1577
1578         Fix the bug by instantiating the correct port object.
1579
1580         * Scripts/new-run-webkit-websocketserver:
1581         (main):
1582
1583 2013-05-07  Lucas Forschler  <lforschler@apple.com>
1584
1585         Configure buildbot for 32bit builder.
1586         https://bugs.webkit.org/show_bug.cgi?id=115769
1587         
1588         Reviewed by Ryosuke Niwa.
1589
1590         * BuildSlaveSupport/build.webkit.org-config/config.json:
1591
1592 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
1593
1594         Unreviewed. Update to show my apple.com address.
1595
1596         * Scripts/webkitpy/common/config/contributors.json: Added
1597         my apple.com e-mail address.
1598
1599 2013-05-08  David Kilzer  <ddkilzer@apple.com>
1600
1601         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
1602
1603         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1604         (concatenateAttributeAndValue): Switch to appendVector().
1605
1606 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1607
1608         [Qt][WTR] Fix the build on Mac after r149692
1609
1610         Unreviewed build fix.
1611
1612         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1613         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1614
1615 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1616
1617         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
1618         to the watchlist for Accessibility.
1619
1620         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
1621         * Scripts/webkitpy/common/config/watchlist: Added myself.
1622
1623 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1624
1625         [Qt] Build fails with clang
1626         https://bugs.webkit.org/show_bug.cgi?id=115741
1627
1628         Reviewed by Benjamin Poulain.
1629
1630         Since r149112 std::move is used in AtomicString for compilers that
1631         support rvalue references and this requires a standard library
1632         implementing c++11 move semantics.
1633         We only explicitely require c++11 for WebKit2, but since clang supports
1634         rvalue references the build of subtargets using AtomicString fails because
1635         of missing std::move.
1636         It is safe to add CONFIG += c++11 for the whole project when using clang
1637         since we explicitely disable c++11 for ANGLE that had probems with libc++.
1638
1639         * qmake/mkspecs/features/unix/default_pre.prf:
1640
1641 2013-05-08  Darin Adler  <darin@apple.com>
1642
1643         Fix one more place that needed to use adoptCF/NS
1644         https://bugs.webkit.org/show_bug.cgi?id=115778
1645
1646         Reviewed by Benjamin Poulain.
1647
1648         Not sure why I missed this code last time, but found a bit more code that needs
1649         to switch to the newer style adoptCF/NS.
1650
1651         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1652         (convertWebResourceDataToString): Use adoptCF.
1653         (convertWebResourceResponseToDictionary): Ditto.
1654         (createXMLStringFromWebArchiveData): Ditto.
1655         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
1656         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
1657
1658 2013-05-08  Commit Queue  <commit-queue@webkit.org>
1659
1660         Unreviewed, rolling out r149271.
1661         http://trac.webkit.org/changeset/149271
1662         https://bugs.webkit.org/show_bug.cgi?id=115780
1663
1664         The mangled symbols are now enforced through LDFLAGS
1665         (Requested by zdobersek on #webkit).
1666
1667         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1668
1669 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
1670
1671         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
1672         https://bugs.webkit.org/show_bug.cgi?id=115636
1673
1674         Reviewed by Ryosuke Niwa.
1675
1676         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1677         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
1678         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
1679         while Chromium-specific, can't be removed just yet as there's more code that uses it.
1680
1681 2013-05-06  Darin Adler  <darin@apple.com>
1682
1683         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
1684         https://bugs.webkit.org/show_bug.cgi?id=115657
1685
1686         Reviewed by Sam Weinig.
1687
1688         This is similar to my last set of changes, but covers code that I missed with
1689         global replace using the Safari Xcode workspace.
1690
1691         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1692         (convertWebResourceDataToString):
1693         (convertWebResourceResponseToDictionary):
1694         (createXMLStringFromWebArchiveData):
1695         * DumpRenderTree/cg/ImageDiffCG.cpp:
1696         (createImageFromStdin):
1697         (createDifferenceImage):
1698         (main):
1699         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1700         (printPNG):
1701         (dumpBitmap):
1702         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1703         (BitmapContext::BitmapContext):
1704         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
1705         (-[MockWebNotificationProvider init]):
1706         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1707         (createBitmapContext):
1708         * DumpRenderTree/mac/TestRunnerMac.mm:
1709         (TestRunner::addDisallowedURL):
1710         (TestRunner::applicationCacheDiskUsageForOrigin):
1711         (TestRunner::localStorageDiskUsageForOrigin):
1712         (TestRunner::clearApplicationCacheForOrigin):
1713         (TestRunner::deleteLocalStorageForOrigin):
1714         (TestRunner::copyDecodedHostName):
1715         (TestRunner::copyEncodedHostName):
1716         (TestRunner::queueLoad):
1717         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1718         (TestRunner::setMockGeolocationPositionUnavailableError):
1719         (TestRunner::setUserStyleSheetLocation):
1720         (TestRunner::setValueForUser):
1721         (TestRunner::overridePreference):
1722         (TestRunner::setPersistentUserStyleSheetLocation):
1723         (TestRunner::execCommand):
1724         (TestRunner::findString):
1725         (TestRunner::isCommandEnabled):
1726         (TestRunner::addOriginAccessWhitelistEntry):
1727         (TestRunner::removeOriginAccessWhitelistEntry):
1728         (TestRunner::addUserScript):
1729         (TestRunner::addUserStyleSheet):
1730         (TestRunner::evaluateInWebInspector):
1731         (TestRunner::evaluateScriptInIsolatedWorld):
1732         (TestRunner::apiTestNewWindowDataLoadBaseURL):
1733         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
1734         (TestRunner::authenticateSession):
1735         (TestRunner::grantWebNotificationPermission):
1736         (TestRunner::denyWebNotificationPermission):
1737         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
1738         (createCFURLResponseFromResponseData):
1739         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1740         (LoadItem::invoke):
1741         (LoadHTMLStringItem::invoke):
1742         (ScriptItem::invoke):
1743         * DumpRenderTree/win/DumpRenderTree.cpp:
1744         (substringFromIndex):
1745         (urlSuitableForTestResult):
1746         (lastPathComponent):
1747         (sharedCFURLCache):
1748         * DumpRenderTree/win/ImageDiffCairo.cpp:
1749         (createImageFromStdin):
1750         (main):
1751         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1752         (createBitmapContextFromWebView):
1753         * DumpRenderTree/win/TestRunnerWin.cpp:
1754         (TestRunner::setUserStyleSheetLocation):
1755         (TestRunner::setPersistentUserStyleSheetLocation):
1756         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1757         (TestWebKitAPI::TEST):
1758         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
1759         (TestWebKitAPI::TEST):
1760         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1761         (TestWebKitAPI::TEST):
1762         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1763         (TestWebKitAPI::TEST):
1764         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1765         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1766         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1767         (TestWebKitAPI::createWindow):
1768         (TestWebKitAPI::TEST):
1769         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1770         (TestWebKitAPI::TEST):
1771         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
1772         (TestWebKitAPI::AcceptsFirstMouse::runTest):
1773         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1774         (TestWebKitAPI::TEST):
1775         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
1776         (TestWebKitAPI::TEST):
1777         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
1778         (TestWebKitAPI::TEST):
1779         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1780         (TestWebKitAPI::TEST):
1781         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
1782         (TestWebKitAPI::TEST):
1783         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1784         (TestWebKitAPI::TEST):
1785         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
1786         (TestWebKitAPI::TEST):
1787         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1788         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
1789         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1790         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
1791         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
1792         (TestWebKitAPI::TEST):
1793         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
1794         (TestWebKitAPI::TEST):
1795         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
1796         (TestWebKitAPI::TEST):
1797         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
1798         (TestWebKitAPI::TEST):
1799         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
1800         (TestWebKitAPI::TEST):
1801         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1802         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1803         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
1804         (TestWebKitAPI::TEST):
1805         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
1806         (TestWebKitAPI::TEST):
1807         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1808         (TestWebKitAPI::TEST):
1809         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
1810         (TestWebKitAPI::TEST):
1811         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1812         (TestWebKitAPI::TEST):
1813         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
1814         (TestWebKitAPI::TEST):
1815         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
1816         (TestWebKitAPI::TEST):
1817         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1818         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1819         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1820         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
1821         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1822         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
1823         (WTR::testPathFromURL):
1824         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1825         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1826         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1827         (WTR::createCGContextFromImage):
1828         (WTR::dumpBitmap):
1829         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1830         * WebKitTestRunner/mac/EventSenderProxy.mm:
1831         (WTR::EventSenderProxy::mouseScrollBy):
1832         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1833         (WTR::PlatformWebView::windowSnapshotImage):
1834         * WebKitTestRunner/win/TestControllerWin.cpp:
1835         (WTR::TestController::initializeTestPluginDirectory):
1836         Use adoptCF and adoptNS.
1837
1838 2013-05-07  Alex Christensen  <achristensen@apple.com>
1839
1840         Fix a memory leak introduced in r149692
1841         https://bugs.webkit.org/show_bug.cgi?id=115766
1842
1843         Reviewed by Mark Rowe.
1844
1845         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
1846         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
1847
1848         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1849         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1850         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
1851
1852 2013-05-07  Darin Adler  <darin@apple.com>
1853
1854         [Win] Fix storage leak in Windows DumpRenderTree
1855         https://bugs.webkit.org/show_bug.cgi?id=115651
1856
1857         Reviewed by Sam Weinig.
1858
1859         * DumpRenderTree/win/DumpRenderTree.cpp:
1860         (lastPathComponent): Added a missing call to adoptCF.
1861
1862 2013-05-07  Alex Christensen  <achristensen@apple.com>
1863
1864         fixed a memory leak introduced by bug 42324 by using a RetainPtr
1865         https://bugs.webkit.org/show_bug.cgi?id=115760
1866
1867         Reviewed by Tim Horton.
1868
1869         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1870         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1871         fixed memory leak, added UNUSED_PARAM macros
1872
1873 2013-05-07  Alex Christensen  <achristensen@apple.com>
1874
1875         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
1876         https://bugs.webkit.org/show_bug.cgi?id=42324
1877         <rdar://problem/8193633>
1878
1879         Reviewed by Tim Horton.
1880
1881         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1882         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
1883         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1884         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1885         Added dumpDOMAsWebArchive code that is called when dumping.        
1886         (WTR::InjectedBundlePage::dump):
1887         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
1888         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1889         (InjectedBundlePage):
1890         Added dumpDOMAsWebArchive declaration.
1891         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
1892         (WTR::TestRunner::dumpDOMAsWebArchive):
1893         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
1894         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1895         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
1896         * Tools/WebKitTestRunner/cf: Added.
1897         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
1898         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
1899         (convertMIMEType):
1900         (convertWebResourceDataToString):
1901         (normalizeHTTPResponseHeaderFields):
1902         (normalizeWebResourceURL):
1903         (convertWebResourceResponseToDictionary):
1904         (compareResourceURLs):
1905         (createXMLStringFromWebArchiveData):
1906         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
1907         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
1908         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
1909         Copied from Tools/DumpRenderTree/mac for used functions.
1910         (createCFURLResponseFromResponseData):
1911         (supportedNonImageMIMETypes):
1912
1913 2013-05-07  Alex Christensen  <achristensen@apple.com>
1914
1915         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
1916         https://bugs.webkit.org/show_bug.cgi?id=115745
1917
1918         Reviewed by Tim Horton.
1919
1920         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1921         (compareResourceURLs):
1922         Updated style.
1923
1924 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
1925
1926         Add an 'isReadOnly' member to IDL parse tree structure
1927         https://bugs.webkit.org/show_bug.cgi?id=115704
1928
1929         Reviewed by Kentaro Hara.
1930
1931         Use newly added isReadOnly attribute.
1932
1933         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1934         (_generateHeaderFile):
1935         (_generateImplementationFile):
1936         (_staticValuesGetterImplementation):
1937
1938 2013-05-07  Anders Carlsson  <andersca@apple.com>
1939
1940         Remove AlwaysInline.h from WTF
1941         https://bugs.webkit.org/show_bug.cgi?id=115727
1942
1943         Reviewed by Brent Fulgham.
1944
1945         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
1946         to keep AlwaysInline.h around anymore.
1947
1948         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
1949         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1950
1951 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
1952
1953         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
1954         https://bugs.webkit.org/show_bug.cgi?id=114808
1955
1956         Reviewed by Jocelyn Turcotte.
1957
1958         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
1959         (https://codereview.qt-project.org/#change,54234)
1960
1961         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1962         (WTR::WrapperWindow::handleStatusChanged):
1963
1964 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1965
1966         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
1967
1968         * Scripts/webkitpy/common/config/watchlist:
1969
1970 2013-05-06  Kangil Han  <kangil.han@samsung.com>
1971
1972         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
1973         https://bugs.webkit.org/show_bug.cgi?id=115645
1974
1975         Reviewed by Gyuyoung Kim.
1976
1977         To run performance tests in wk1, we need --no-timeout option implementation.
1978         So adopt it from gtk+ port.
1979
1980         * DumpRenderTree/efl/DumpRenderTree.cpp:
1981         (shouldSetWaitToDumpWatchdog):
1982         (parseCommandLineOptions):
1983         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
1984         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1985         (TestRunner::setWaitToDump):
1986
1987 2013-05-06  Commit Queue  <commit-queue@webkit.org>
1988
1989         Unreviewed, rolling out r149547.
1990         http://trac.webkit.org/changeset/149547
1991         https://bugs.webkit.org/show_bug.cgi?id=115682
1992
1993         Added unittests that fail on bots and spits out text into
1994         stdout (Requested by rniwa on #webkit).
1995
1996         * Scripts/import-w3c-tests: Removed.
1997         * Scripts/webkitpy/w3c/__init__.py: Removed.
1998         * Scripts/webkitpy/w3c/test_converter.py: Removed.
1999         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
2000         * Scripts/webkitpy/w3c/test_importer.py: Removed.
2001         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
2002         * Scripts/webkitpy/w3c/test_parser.py: Removed.
2003         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
2004
2005 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
2006
2007         [jhbuild] bump jhbuild version to take advantage of new improvements
2008         https://bugs.webkit.org/show_bug.cgi?id=115558
2009
2010         Reviewed by Martin Robinson.
2011
2012         One of the important improvements is jhbuild no longer fetches git
2013         repositories if they are already at the expected revision, which should
2014         make the EWS bots more robust to git servers unavailability.
2015
2016         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
2017
2018 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
2019
2020         [GTK] Add webkit_uri_scheme_request_finish_error
2021         https://bugs.webkit.org/show_bug.cgi?id=94316
2022
2023         Reviewed by Anders Carlsson.
2024
2025         * MiniBrowser/gtk/main.c:
2026         (miniBrowserErrorQuark): Add function to create a global quark for
2027         MiniBrowser.
2028         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
2029         function webkit_uri_scheme_request_finish_error().
2030
2031 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
2032
2033         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
2034         https://bugs.webkit.org/show_bug.cgi?id=113808
2035
2036         Reviewed by Rob Buis.
2037
2038         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
2039         to true for BlackBerry.
2040
2041         * Scripts/webkitperl/FeatureList.pm:
2042
2043 2013-05-06  Jessie Berlin  <jberlin@apple.com>
2044
2045         check-webkit-style should complain about a layering violation if platform-specific guards are
2046         used in WebCore outside of the platform directory
2047         https://bugs.webkit.org/show_bug.cgi?id=115567
2048
2049         Reviewed by Benjamin Poulain.
2050
2051         * Scripts/webkitpy/style/checkers/cpp.py:
2052         (check_for_webcore_platform_layering_violation):
2053         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
2054         (process_line):
2055         Add the check_for_webcore_platform_layering_violation.
2056         (CppChecker):
2057         List the new check.
2058
2059         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2060         (CppStyleTest.test_webcore_platform_layering_violation):
2061         Add tests.
2062
2063 2013-05-06  David Kilzer  <ddkilzer@apple.com>
2064
2065         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
2066         <http://webkit.org/b/115667>
2067
2068         Reviewed by Dirk Pranke.
2069
2070         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2071         (Bugzilla._check_create_bug_response): Update regex to work with
2072         Bugzilla 3.2.3 and 4.2.5.
2073         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2074         (test__check_create_bug_response): Add new test that covers both
2075         old and new <title> variations.
2076
2077 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2078
2079         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
2080         https://bugs.webkit.org/show_bug.cgi?id=115661
2081
2082         Reviewed by Ryosuke Niwa.
2083
2084         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
2085         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
2086         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
2087
2088         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2089         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2090
2091 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2092
2093         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
2094         https://bugs.webkit.org/show_bug.cgi?id=114603
2095
2096         Reviewed by Ryosuke Niwa.
2097
2098         * TestResultServer/generate_builders_json.py:
2099         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
2100         to represent these to be 'layout-test', for backwards compatibility.
2101         (main): Remove all the build.chromium.org masters.
2102         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
2103         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2104         (GenerateBuildersJsonTest):
2105         (GenerateBuildersJsonTest.test_generate_json_data):
2106         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
2107         test-running builders from the webkit.org master.
2108
2109 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2110
2111         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
2112         https://bugs.webkit.org/show_bug.cgi?id=114988
2113
2114         Reviewed by Ryosuke Niwa.
2115
2116         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
2117         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
2118         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
2119         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
2120         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
2121
2122 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2123
2124         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
2125         https://bugs.webkit.org/show_bug.cgi?id=114954
2126
2127         Reviewed by Ryosuke Niwa.
2128
2129         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2130         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
2131         modifier unions in the list of modifiers.
2132         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
2133         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
2134
2135 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2136
2137         [Flakiness Dashboard] Simplify builder-name-based platform recognition
2138         https://bugs.webkit.org/show_bug.cgi?id=114957
2139
2140         Reviewed by Ryosuke Niwa.
2141
2142         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2143         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
2144         (chromiumPlatform): Removed, unnecessary.
2145         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
2146         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
2147         the builder operates with debug builds, no webkit.org builders are named this way.
2148         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2149         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
2150
2151 2013-05-06  Andy Estes  <aestes@apple.com>
2152
2153         Added two files I neglected to commit in r149589.
2154
2155         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2156         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2157
2158 2013-05-04  Andy Estes  <aestes@apple.com>
2159
2160         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
2161         https://bugs.webkit.org/show_bug.cgi?id=115609
2162
2163         Reviewed by Oliver Hunt.
2164
2165         Added an API test.
2166
2167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2168         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2169         (+[TestDelegate shared]):
2170         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2171         (-[TestDelegate webView:createWebViewWithRequest:]):
2172         (TestWebKitAPI):
2173         (TestWebKitAPI::TEST):
2174         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2175
2176 2013-05-06  Antoine Quint  <graouts@apple.com>
2177
2178         Manage the presentation of the snapshotted plug-in using JavaScript
2179         https://bugs.webkit.org/show_bug.cgi?id=115548
2180
2181         Reviewed by Dean Jackson.
2182
2183         Take into account the new plugInExtraScript method added to support
2184         the injection of a JS file from the chrome client to customize the
2185         rendering of a snapshotted plug-in's shadow tree.
2186
2187         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2188         (WTR::InjectedBundlePage::InjectedBundlePage):
2189
2190 2013-05-05  Anders Carlsson  <andersca@apple.com>
2191
2192         Remove the Vector::append overload that takes a Vector
2193         https://bugs.webkit.org/show_bug.cgi?id=115535
2194
2195         Reviewed by Andreas Kling.
2196
2197         Use Vector::appendVector instead.
2198
2199         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2200         (concatenateAttributeAndValue):
2201         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2202         (WTR::concatenateAttributeAndValue):
2203
2204 2013-05-04  Sam Weinig  <sam@webkit.org>
2205
2206         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
2207         <rdar://problem/13702008>
2208         https://bugs.webkit.org/show_bug.cgi?id=115607
2209
2210         Reviewed by Benjamin Poulain.
2211
2212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2213         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
2214         (TestWebKitAPI::didFinishLoadForFrame):
2215         (TestWebKitAPI::TEST):
2216         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
2217
2218 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2219
2220         Unreviewed.
2221
2222         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
2223
2224 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
2225
2226         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
2227
2228         * Scripts/webkitpy/common/config/contributors.json:
2229
2230 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2231
2232         [GTK] Catch select.error exceptions in parse_output_lines
2233         https://bugs.webkit.org/show_bug.cgi?id=115253
2234
2235         Reviewed by Gustavo Noronha Silva.
2236
2237         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
2238         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
2239         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
2240         error code and the error message) and the loop is re-entered.
2241
2242         * gtk/common.py:
2243         (parse_output_lines):
2244
2245 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2246
2247         [GTK] Set up the TestWebCore in TestWebKitAPI
2248         https://bugs.webkit.org/show_bug.cgi?id=115237
2249
2250         Reviewed by Gustavo Noronha Silva.
2251
2252         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2253         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2254         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2255         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2256         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2257
2258         * TestWebKitAPI/GNUmakefile.am:
2259
2260 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
2261
2262         Create a script to import W3C tests
2263         https://bugs.webkit.org/show_bug.cgi?id=111513
2264
2265         Reviewed by Dirk Pranke.
2266
2267         Script to automate the import of W3C tests into WebKit. 
2268         For the full description of how it works, see the comments
2269         at the top of test_importer.py.
2270
2271         * Scripts/import-w3c-tests: Added.
2272         * Scripts/webkitpy/w3c/__init__.py: Added.
2273         * Scripts/webkitpy/w3c/test_converter.py: Added.
2274         (TestConverter):
2275         (TestConverter.__init__):
2276         (TestConverter.load_prefixed_prop_list):
2277         (TestConverter.load_file):
2278         (TestConverter.convert_for_webkit):
2279         (TestConverter.convert_testharness_paths):
2280         (TestConverter.convert_prefixed_properties):
2281         (TestConverter.scrub_unprefixed_props):
2282         (TestConverter.replace_tag):
2283         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2284         (TestConverterTest):
2285         (TestConverterTest.testLoadPrefixedPropList):
2286         (TestConverterTest.test_convertForWebkitNothingToConvert):
2287         (test_convertForWebkitHarnessOnly):
2288         (test_convertForWebkitPropsOnly):
2289         (test_convertForWebkitHarnessAndProps):
2290         (test_convertTestHarnessPaths):
2291         (test_convertPrefixedProperties):
2292         (verifyTestHarnessPaths):
2293         (verifyPrefixedProperties):
2294         (generateTestContent):
2295         * Scripts/webkitpy/w3c/test_importer.py: Added.
2296         (main):
2297         (parse_args):
2298         (validate_import_directory):
2299         (TestImporter):
2300         (TestImporter.__init__):
2301         (TestImporter.do_import):
2302         (TestImporter.get_changeset):
2303         (TestImporter.scan_source_directory):
2304         (TestImporter.import_tests):
2305         (TestImporter.setup_destination_directory):
2306         (TestImporter.get_test_status):
2307         (TestImporter.remove_deleted_files):
2308         (TestImporter.write_import_log):
2309         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2310         (TestImporterTest):
2311         (TestImporterTest.test_ImportDirWithNoTests):
2312         * Scripts/webkitpy/w3c/test_parser.py: Added.
2313         (TestParser):
2314         (TestParser.__init__):
2315         (TestParser.load_file):
2316         (TestParser.analyze_test):
2317         (TestParser.get_reftests):
2318         (TestParser.is_jstest):
2319         (TestParser.get_support_files):
2320         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2321         (TestParserTest):
2322         (TestParserTest.test_analyzeTestReftestOneMatch):
2323         (test_analyzeTestReftestMultipleMatches):
2324         (test_analyzeTestReftestMatchAndMismatch):
2325         (test_analyzeTestReftestWithRefSupportFiles):
2326         (test_analyzeJSTest):
2327         (test_analyzePixelTestAllTrue):
2328         (test_analyzePixelTestAllFalse):
2329         (test_analyzeNonHTMLFile):
2330
2331 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2332
2333         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
2334
2335         * Scripts/webkitpy/common/config/contributors.json:
2336
2337 2013-05-02  Nico Weber  <thakis@chromium.org>
2338
2339         Remove a stale script file.
2340         https://bugs.webkit.org/show_bug.cgi?id=115521
2341
2342         Reviewed by Anders Carlsson.
2343
2344         This script was added in
2345         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
2346         Bakefile system that was removed in
2347         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
2348         script just asserts when it's run and is useless.
2349
2350         * Scripts/update-sources-list.py: Removed.
2351
2352 2013-05-01  Glenn Adams  <glenn@skynav.com>
2353
2354         [webkitpy] Need abstract base class for commands that analyze commit logs
2355         https://bugs.webkit.org/show_bug.cgi?id=115391
2356
2357         Reviewed by Benjamin Poulain.
2358
2359         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
2360         in preparation for adding two new commands that will reuse this functionality along with
2361         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
2362         https://bugs.webkit.org/show_bug.cgi?id=115388.
2363
2364         No new tests as this patch does not change existing functionality or behavior.
2365
2366         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2367         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
2368         (AbstractCommitLogCommand.__init__):
2369         (AbstractCommitLogCommand._init_options):
2370         (AbstractCommitLogCommand._parse_commit_message):
2371         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
2372         (SuggestNominations.__init__): 
2373         (SuggestNominations._init_options):
2374
2375 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
2376
2377         Web Inspector: Fix check-inspector-strings script and fix localized strings
2378         https://bugs.webkit.org/show_bug.cgi?id=115495
2379
2380         Reviewed by Joseph Pecoraro.
2381
2382         * Scripts/check-inspector-strings:
2383
2384 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2385
2386         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
2387         https://bugs.webkit.org/show_bug.cgi?id=115470
2388
2389         Reviewed by Martin Robinson.
2390
2391         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
2392         not building either of the IOS, Windows or GTK-WK1 platforms.
2393
2394         Up until now the header was included for everything but the IOS and Windows platforms due to
2395         an incorrectly stated condition regarding the GTK platform.
2396
2397         * TestWebKitAPI/config.h:
2398
2399 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2400
2401         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
2402         https://bugs.webkit.org/show_bug.cgi?id=115469
2403
2404         Reviewed by Martin Robinson.
2405
2406         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
2407         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
2408         for the WebKit2 tests and the injected bundle required by them.
2409
2410         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
2411         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
2412         under the WebKit2 code).
2413
2414         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
2415         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
2416         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
2417
2418         * TestWebKitAPI/GNUmakefile.am:
2419
2420 2013-04-30  Glenn Adams  <glenn@skynav.com>
2421
2422         Unreviewed. Add myself to watchlist entries.
2423
2424         * Scripts/webkitpy/common/config/watchlist:
2425
2426 2013-04-30  Glenn Adams  <glenn@skynav.com>
2427
2428         [webkitpy] suggest-nominations doesn't count all qualified patches
2429         https://bugs.webkit.org/show_bug.cgi?id=115285
2430
2431         Reviewed by Benjamin Poulain.
2432
2433         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
2434         nomination. Improve commit log parsing.
2435
2436         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2437         (CommitLogError):
2438         (CommitLogError.__init__):
2439         (CommitLogMissingReviewer):
2440         (CommitLogMissingReviewer.__init__):
2441         (SuggestNominations):
2442         (SuggestNominations.__init__):
2443         (SuggestNominations._recent_commit_messages):
2444         (SuggestNominations._author_name_from_email):
2445         (SuggestNominations._contributor_from_email):
2446         (SuggestNominations._parse_commit_message):
2447         (SuggestNominations._count_commit):
2448         (SuggestNominations._count_recent_patches):
2449         (SuggestNominations._collect_nominations):
2450         (SuggestNominations._print_nominations):
2451         (SuggestNominations.execute):
2452         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2453         (_make_options):
2454         (test_recent_commit_messages):
2455         (test_basic):
2456
2457 2013-04-30  Commit Queue  <rniwa@webkit.org>
2458
2459         Unreviewed, rolling out r149309.
2460         http://trac.webkit.org/changeset/149309
2461         https://bugs.webkit.org/show_bug.cgi?id=115430
2462
2463         The patch does not build on WK1-only builds of the GTK port
2464         (Requested by zdobersek on #webkit).
2465
2466         * TestWebKitAPI/GNUmakefile.am:
2467
2468 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2469
2470         Stop using "in" keyword in IDL files
2471         https://bugs.webkit.org/show_bug.cgi?id=115418
2472
2473         Reviewed by Kentaro Hara.
2474
2475         Remove "in" keyword from IDL files as this is no longer part of the Web
2476         IDL specification.
2477
2478         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2479         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2480         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2481         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2482         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2483         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
2484         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2485         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2486
2487 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2488
2489         [EFL] Enable scaled cursors
2490         https://bugs.webkit.org/show_bug.cgi?id=106242
2491
2492         Reviewed by Gyuyoung Kim.
2493
2494         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
2495
2496         * Scripts/webkitperl/FeatureList.pm:
2497
2498 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2499
2500         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
2501         https://bugs.webkit.org/show_bug.cgi?id=115380
2502
2503         Reviewed by Kentaro Hara.
2504
2505         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
2506         keyword.
2507
2508         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2509         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2510
2511 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2512
2513         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
2514         https://bugs.webkit.org/show_bug.cgi?id=114684
2515
2516         Reviewed by Simon Hausmann.
2517
2518         Remove the ANGLE requirement for USE(3D_GRAPHICS).
2519         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
2520
2521         * qmake/mkspecs/features/features.prf:
2522
2523 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2524
2525         [GTK] Disable Shadow DOM feature
2526         https://bugs.webkit.org/show_bug.cgi?id=115374
2527
2528         Reviewed by Martin Robinson.
2529
2530         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
2531
2532         * Scripts/webkitperl/FeatureList.pm:
2533
2534 2013-04-29  Glenn Adams  <glenn@skynav.com>
2535
2536         [webkitpy] Add missing contributor email addresses
2537         https://bugs.webkit.org/show_bug.cgi?id=115394
2538
2539         Reviewed by Ryosuke Niwa.
2540
2541         * Scripts/webkitpy/common/config/contributors.json:
2542
2543 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
2544
2545         Remove all remaining Skia code
2546         https://bugs.webkit.org/show_bug.cgi?id=115263
2547
2548         Reviewed by Benjamin Poulain.
2549
2550         Remove all remaining references to Skia.
2551
2552         * Scripts/webkitdirs.pm:
2553         (blackberryCMakeArguments):
2554         * Scripts/webkitpy/common/config/contributionareas.py:
2555         * Scripts/webkitpy/common/config/watchlist:
2556
2557 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
2558
2559         Get rid of unused options in Tools/Scripts/webkit-build-directory
2560         https://bugs.webkit.org/show_bug.cgi?id=115383
2561
2562         Reviewed by Darin Adler.
2563
2564         * Scripts/webkit-build-directory:
2565
2566 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2567
2568         [WK2][Mac] Test with NetworkProcess enabled.
2569
2570         Fix the build for non-Mac.
2571
2572         * WebKitTestRunner/TestController.cpp:
2573         (WTR::TestController::initialize):
2574
2575 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2576
2577         [WK2][Mac] Test with NetworkProcess enabled.
2578
2579         Reviewed by Sam Weinig.
2580
2581         * WebKitTestRunner/TestController.cpp:
2582         (WTR::TestController::initialize):
2583
2584 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2585
2586         [GTK] Set up the TestWebCore in TestWebKitAPI
2587         https://bugs.webkit.org/show_bug.cgi?id=115237
2588
2589         Reviewed by Gustavo Noronha Silva.
2590
2591         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2592         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2593         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2594         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2595         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2596
2597         * TestWebKitAPI/GNUmakefile.am:
2598
2599 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2600
2601         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
2602         https://bugs.webkit.org/show_bug.cgi?id=115236
2603
2604         Reviewed by Gustavo Noronha Silva.
2605
2606         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
2607         under the TestWebKitAPI/Tests/JavaScriptCore directory.
2608
2609         * TestWebKitAPI/GNUmakefile.am:
2610
2611 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2612
2613         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
2614         https://bugs.webkit.org/show_bug.cgi?id=115323
2615
2616         Reviewed by Philippe Normand.
2617
2618         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
2619         Its presence enforces linkers to output mangled symbols when reporting linking failures
2620         due to unresolved references. People trying to fix the build can then simply copy
2621         the printed mangled symbol into the symbols.filter file instead of doing a manual build
2622         or connecting to the builders to discover the mangled version of the missing symbol.
2623
2624         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2625
2626 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2627
2628         Remove Chromium code from Tools/BuildSlaveSupport
2629         https://bugs.webkit.org/show_bug.cgi?id=115325
2630
2631         Reviewed by Benjamin Poulain.
2632
2633         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
2634         covering archiving test results and built products.
2635
2636         * BuildSlaveSupport/built-product-archive:
2637         (archiveBuiltProduct):
2638         (extractBuiltProduct):
2639         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
2640         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
2641         * BuildSlaveSupport/test-result-archive:
2642         (archiveTestResults):
2643
2644 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
2645
2646         Remove support for Chromium from webkitdirs.pm
2647         https://bugs.webkit.org/show_bug.cgi?id=115338
2648
2649         Reviewed by Darin Adler.
2650
2651         * Scripts/webkitdirs.pm:
2652         (determineBaseProductDir):
2653         (argumentsForConfiguration):
2654         (builtDylibPathForName):
2655         (determineIsQt):
2656         (isAppleWebKit):
2657
2658 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2659
2660         Rename TestRunner's setAudioData to setAudioResult
2661         https://bugs.webkit.org/show_bug.cgi?id=115326
2662
2663         Reviewed by Darin Adler.
2664
2665         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
2666         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
2667         affected tests are adjusted accordingly.
2668
2669         * DumpRenderTree/qt/TestRunnerQt.cpp:
2670         (TestRunnerQt::setAudioResult):
2671         * DumpRenderTree/qt/TestRunnerQt.h:
2672         (TestRunnerQt):
2673         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2674         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2675         (WTR::TestRunner::setAudioResult):
2676         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2677         (TestRunner):
2678
2679 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2680
2681         [WKTR] Tests dumping audio data shouldn't dump pixels
2682         https://bugs.webkit.org/show_bug.cgi?id=115270
2683
2684         Reviewed by Benjamin Poulain.
2685
2686         Prevent dumping the pixel output when Web Audio tests are dumping output data
2687         as the testing output. Pixel output in these tests has no real meaning and is
2688         as such unnecessary.
2689
2690         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2691         (WTR::TestRunner::setAudioData):
2692
2693 2013-04-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2694
2695         [EFL] Unreviewed Intel bots fix after r149231.
2696
2697         * efl/jhbuild.modules: Disable the libxml Python bindings since the
2698         bots don't have Python's development files installed. libxml should
2699         detect this kind of thing better.
2700
2701 2013-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
2702
2703         [EFL] Build break using jhbuild on ubuntu 13.04
2704         https://bugs.webkit.org/show_bug.cgi?id=115225
2705
2706         Reviewed by Gyuyoung Kim.
2707
2708         libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
2709         libxml 2.9.0 has a bug to make regression which r138422 mentioned.
2710         So this patch bumped libxml version to 2.9.1.
2711
2712         * efl/jhbuild.modules:
2713
2714 2013-04-26  Jeffrey Pfau  <jpfau@apple.com>
2715
2716         delete-stale-build-files does not clear .d files
2717         http://bugs.webkit.org/show_bug.cgi?id=115293
2718
2719         Reviewed by Ryosuke Niwa.
2720
2721         * BuildSlaveSupport/delete-stale-build-files:
2722         (main): Add .d to the file type list
2723
2724 2013-04-26  Roger Fong  <roger_fong@apple.com>
2725
2726         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
2727         Make the DebugSuffix configuration use _debug dependencies.
2728
2729         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2730         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
2731         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2732         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
2733         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2734         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2735         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
2736         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
2737         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
2738         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
2739         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
2740         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
2741         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
2742         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2743         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2744         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
2745         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
2746         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
2747         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2748         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
2749         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
2750         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
2751         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
2752         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
2753         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
2754         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
2755         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
2756         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2757         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2758         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2759         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
2760         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
2761         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
2762         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
2763         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2764         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2765         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2766         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
2767         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2768         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
2769         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
2770         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2771         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2772         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
2773         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
2774         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2775         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
2776         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
2777         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
2778         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
2779         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
2780         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
2781         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2782         * win/AssembleBuildLogs/AssembleLogs.cmd:
2783         * win/record-memory/record-memory.vcxproj:
2784         * win/record-memory/record-memoryDebug.props:
2785         * win/record-memory/record-memoryDebugWinCairo.props:
2786         * win/record-memory/record-memoryProduction.props:
2787         * win/record-memory/record-memoryRelease.props:
2788         * win/record-memory/record-memoryReleaseWinCairo.props:
2789
2790 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
2791
2792         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
2793         https://bugs.webkit.org/show_bug.cgi?id=115233
2794
2795         Reviewed by Martin Robinson.
2796
2797         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
2798         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
2799         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
2800         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
2801         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
2802
2803         * TestWebKitAPI/GNUmakefile.am:
2804
2805 2013-04-25  Andy Estes  <aestes@apple.com>
2806
2807         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
2808         https://bugs.webkit.org/show_bug.cgi?id=115223
2809
2810         Reviewed by Darin Adler.
2811
2812         Added an API test.
2813
2814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2815         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
2816         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
2817         when it loads a request with a custom protocol.
2818         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
2819         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
2820         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
2821         miscellaneous cleanup.
2822         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
2823         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
2824         (+[TestProtocol canInitWithRequest:]):
2825         (+[TestProtocol canonicalRequestForRequest:]):
2826         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
2827         (+[TestProtocol scheme]):
2828         (-[TestProtocol startLoading]):
2829         (-[TestProtocol stopLoading]):
2830
2831 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
2832
2833         Remove the remaining Skia #ifdefs
2834         https://bugs.webkit.org/show_bug.cgi?id=114886
2835
2836         Reviewed by Benjamin Poulain.
2837
2838         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2839         (createBitmapContextFromWebView): Remove Skia #ifdef references.
2840
2841 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
2842
2843         [BlackBerry] Clean up load interface in WebPage
2844         https://bugs.webkit.org/show_bug.cgi?id=113267
2845
2846         Reviewed by Rob Buis.
2847
2848         Update DumpRenderTree with change of load() interface in WebPage.
2849         RIM Bug# 315535, internally reviewed by Joe Mason.
2850
2851         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2852         (BlackBerry::WebKit::DumpRenderTree::runTest):
2853
2854 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
2855
2856         Remove the HeapGraphSerializer unit test
2857         https://bugs.webkit.org/show_bug.cgi?id=115231
2858
2859         Reviewed by Andreas Kling.
2860
2861         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
2862         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
2863
2864         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
2865
2866 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2867
2868         Remove support for Chromium from build/update scripts
2869         https://bugs.webkit.org/show_bug.cgi?id=115218
2870
2871         Reviewed by Darin Adler.
2872
2873         * Scripts/build-webkit:
2874         (writeCongrats):
2875         * Scripts/update-webkit:
2876
2877 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2878
2879         Remove support for Chromium from api-test
2880         https://bugs.webkit.org/show_bug.cgi?id=115211
2881
2882         Reviewed by Dirk Pranke.
2883
2884         * Scripts/build-api-tests:
2885         * Scripts/run-api-tests:
2886         (isSupportedPlatform):
2887
2888 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2889
2890         Get rid of Chromium in build-dumprendertree
2891         https://bugs.webkit.org/show_bug.cgi?id=115212
2892
2893         Reviewed by Dirk Pranke.
2894
2895         * Scripts/build-dumprendertree:
2896
2897 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
2898
2899         Pass relatedPage when creating a page in WebKitTestRunner
2900         https://bugs.webkit.org/show_bug.cgi?id=115206
2901
2902         Reviewed by Geoffrey Garen.
2903
2904         To make sure that window.open() opens in the same process even when using multiple processes.
2905
2906         * WebKitTestRunner/PlatformWebView.h:
2907         * WebKitTestRunner/TestController.cpp:
2908         (WTR::TestController::createOtherPage):
2909         (WTR::TestController::createWebViewWithOptions):
2910         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2911         (WTR::PlatformWebView::PlatformWebView):
2912         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2913         (WTR::PlatformWebView::PlatformWebView):
2914         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2915         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
2916         (WTR::PlatformWebView::PlatformWebView):
2917         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2918         (WTR::PlatformWebView::PlatformWebView):
2919         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2920         (WTR::PlatformWebView::PlatformWebView):
2921
2922 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2923
2924         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
2925
2926         * Scripts/webkitpy/common/config/contributors.json:
2927
2928 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2929
2930         Build fix. Forgot to merge args.
2931
2932         * Scripts/webkitpy/tool/bot/irc_command.py:
2933         (Hi.execute):
2934
2935 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2936
2937         webkitbot should recognize its own nickname in greetings.
2938         https://bugs.webkit.org/show_bug.cgi?id=115196
2939
2940         Reviewed by Andreas Kling.
2941
2942         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
2943
2944         * Scripts/webkitpy/tool/bot/irc_command.py:
2945         (Hi.execute):
2946
2947 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
2948
2949         [GTK] Tools/gtk/install-dependencies added ragel dependency
2950         https://bugs.webkit.org/show_bug.cgi?id=115163
2951
2952         Reviewed by Xan Lopez.
2953
2954         The install-dependencies script was missing a dependency on ragel
2955         which is expected when building HarfBuzz.
2956
2957         * gtk/install-dependencies: Added a dependency on ragel for both
2958         apt and yum.
2959
2960 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
2961
2962         [GTK] Remove pango from optional jhbuild dependencies
2963         https://bugs.webkit.org/show_bug.cgi?id=115162
2964
2965         Reviewed by Martin Robinson.
2966
2967         Pango is not needed since revision r148293 that lowers the pango
2968         dependency to 1.30, which is available in most distributions.
2969
2970         * gtk/jhbuild-optional.modules: Removes description of pango module.
2971
2972 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
2973
2974         Remove Chromium-specific cases from FeatureList.pm
2975         https://bugs.webkit.org/show_bug.cgi?id=115169
2976
2977         Reviewed by Andreas Kling.
2978
2979         * Scripts/webkitperl/FeatureList.pm:
2980
2981 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
2982
2983         Remove checking chromium from run-webkit-tests
2984         https://bugs.webkit.org/show_bug.cgi?id=115139
2985
2986         Reviewed by Benjamin Poulain.
2987
2988         * Scripts/run-webkit-tests:
2989         (useNewRunWebKitTests):
2990
2991 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
2992
2993         Pixel tests in SVG are all broken in WK2
2994         https://bugs.webkit.org/show_bug.cgi?id=114218
2995
2996         Reviewed by Darin Adler.
2997         
2998         Window snapshots in WebKitTestRunner on Mac are window-sized
2999         (800x600), which is wrong for the W3C SVG tests that require a
3000         480x360 snapshot.
3001         
3002         Fix by resizing the window, as well as the web view in
3003         PlatformWebView::resizeTo() so that window snapshots are correctly
3004         sized.
3005         
3006         Also do some drive-by cleanup of the window size constants in both
3007         DRT and WTR to remove magic numbers, and make the code more similar.
3008         
3009         * DumpRenderTree/TestRunner.cpp:
3010         (TestRunner::setShouldPaintBrokenImage):
3011         * DumpRenderTree/TestRunner.h:
3012         * DumpRenderTree/efl/DumpRenderTree.cpp:
3013         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3014         (webInspectorShowWindow):
3015         * DumpRenderTree/mac/DumpRenderTree.mm:
3016         (createWebViewAndOffscreenWindow):
3017         (sizeWebViewForCurrentTest):
3018         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3019         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3020         (createPagedBitmapContext):
3021         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3022         (DumpRenderTree::DumpRenderTree):
3023         (DumpRenderTree::open):
3024         * DumpRenderTree/qt/TestRunnerQt.cpp:
3025         * DumpRenderTree/qt/TestRunnerQt.h:
3026         * DumpRenderTree/win/DumpRenderTree.cpp:
3027         (sizeWebViewForCurrentTest):
3028         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3029         * WebKitTestRunner/TestController.cpp:
3030         (WTR::TestController::resetStateToConsistentValues):
3031         * WebKitTestRunner/TestController.h:
3032         * WebKitTestRunner/TestInvocation.cpp:
3033         (WTR::sizeWebViewForCurrentTest):
3034         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3035         (WTR::PlatformWebView::PlatformWebView):
3036         (WTR::PlatformWebView::resizeTo):
3037
3038 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
3039
3040         [EFL] Fix build error after r148963.
3041         https://bugs.webkit.org/show_bug.cgi?id=115126
3042
3043         Reviewed by Laszlo Gombos.
3044
3045         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
3046
3047         * TestWebKitAPI/PlatformEfl.cmake:
3048
3049 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3050
3051         [GTK] Use stamp files for generate-forwarding-headers makefile rules
3052         https://bugs.webkit.org/show_bug.cgi?id=115118
3053
3054         Reviewed by Martin Robinson.
3055
3056         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
3057         forwarding generator rules and don't call it for soup since there
3058         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
3059
3060         * TestWebKitAPI/GNUmakefile.am:
3061         * WebKitTestRunner/GNUmakefile.am:
3062
3063 2013-04-24  Simon Pena  <simon.pena@samsung.com>
3064
3065         [GTK] Update build dependencies
3066         https://bugs.webkit.org/show_bug.cgi?id=115111
3067
3068         Reviewed by Martin Robinson.
3069
3070         The install-dependencies script was missing a dependency on EGL,
3071         which is expected when building Cairo.
3072
3073         * gtk/install-dependencies: Added a dependency on libegl1-mesa
3074         for both apt and yum.
3075
3076 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
3077
3078         Remove the Chromium-specific helper from run_webkit_tests.py
3079         https://bugs.webkit.org/show_bug.cgi?id=114996
3080
3081         Reviewed by Dirk Pranke.
3082
3083         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3084         (parse_args):
3085
3086 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
3087
3088         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
3089         https://bugs.webkit.org/show_bug.cgi?id=114850
3090
3091         Reviewed by Andreas Kling.
3092
3093         Revision r148312 fixed WebPageProxy cleanup and also changed the process
3094         termination semantics when requested by the user so that a client is not
3095         notified of a crash anymore, since there was no crash anyway.
3096
3097         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
3098         relied on being notified of a crash after calling WKPageTerminate(). As
3099         a result of not being notified of such non-existent crash, the test would
3100         timeout right after making the terminate call.
3101
3102         This patch adds an InjectedBundle to be used for simulating a crash, by
3103         calling abort() upon receiving a "Crash" message, and thus we are able to
3104         keep testing the crash callback.
3105
3106         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
3107         had been disabled in revisions r148858 and r148855, since it was failing.
3108
3109         * TestWebKitAPI/PlatformEfl.cmake:
3110         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3111         (TestWebKitAPI::TEST):
3112         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
3113         (TestWebKitAPI):
3114         (WKViewClientWebProcessCallbacksTest):
3115         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
3116         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
3117
3118 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3119
3120         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
3121         https://bugs.webkit.org/show_bug.cgi?id=115095
3122
3123         Reviewed by Antonio Gomes.
3124
3125         Use different subfolders under DumpRenderTree Temp folder for every
3126         functionality (icon database, cache, localstorage, ...). This makes
3127         sure there is no conflict between the functionalities.
3128
3129         In EFL's case, libsoup cache was causing problems for the icon
3130         database if sharing the same folder.
3131
3132         * WebKitTestRunner/TestController.cpp:
3133         (WTR::TestController::initialize):
3134
3135 == Rolled over to ChangeLog-2013-04-24 ==