Add a WebKit1 preference for selection services
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-09  Tim Horton  <timothy_horton@apple.com>
2
3         Add a WebKit1 preference for selection services
4         https://bugs.webkit.org/show_bug.cgi?id=137498
5         <rdar://problem/18572699>
6
7         Reviewed by Simon Fraser.
8
9         * MiniBrowser/mac/WK1BrowserWindowController.m:
10         (-[WK1BrowserWindowController awakeFromNib]):
11         Turn on image and selection services in the Legacy WebKit MiniBrowser.
12
13 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
14
15         Get the patch scripts running on Haiku
16         https://bugs.webkit.org/show_bug.cgi?id=137559
17
18         Reviewed by Benjamin Poulain.
19
20         Use /usr/bin/env instead of hardcoding path to perl.
21         Declare haiku platform in platforminfo.py to avoid check-webkit-style
22         failure.
23
24         * Scripts/commit-log-editor:
25         * Scripts/num-cpus:
26         * Scripts/prepare-ChangeLog:
27         * Scripts/run-launcher:
28         * Scripts/svn-create-patch:
29         * Scripts/webkitpy/common/system/platforminfo.py:
30         (PlatformInfo._determine_os_name):
31
32 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
33
34         StyleQueue should throw a PatchIsNotValid exception to achieve
35         consistency with CommitQueue and EWS
36         https://bugs.webkit.org/show_bug.cgi?id=137500
37
38         Reviewed by Alexey Proskuryakov.
39
40         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
41         Adds a call to validate() in run().
42         (StyleQueueTask.run):
43         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
44         Adds a return False in the patch is not valid exception statement.
45         (AbstractEarlyWarningSystem.review_patch):
46         * Scripts/webkitpy/tool/commands/queues.py:
47         Adds a return False in the patch is not valid exception statement in
48         commit queue, and adds an except statement to catch PatchIsNotValid
49         exceptions in style queue.
50         (CommitQueue.process_work_item):
51         (StyleQueue.review_patch):
52
53 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
54
55         Race condition with WebKitWebView:is-loading after starting page load
56         https://bugs.webkit.org/show_bug.cgi?id=136692
57
58         Reviewed by Gustavo Noronha Silva.
59
60         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
61         (loadChangedCallback): Only check is-loading is false when load
62         has finished if the load didn't fail due to a cancellation.
63         (loadFailedCallback): Only check is-loading is false if the load
64         didn't fail due to a cancellation.
65         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
66         (WebViewTest::loadURI): Check is-loading is true and active URI is
67         the requested one rigth after requesting the load.
68         (WebViewTest::loadHtml): Ditto.
69         (WebViewTest::loadPlainText): Ditto.
70         (WebViewTest::loadBytes): Ditto.
71         (WebViewTest::loadRequest): Ditto.
72         (WebViewTest::loadAlternateHTML): Ditto.
73         (WebViewTest::goBack): Ditto.
74         (WebViewTest::goForward): Ditto.
75         (WebViewTest::goToBackForwardListItem): Ditto.
76
77 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
78
79         [Win] Resolve various static analyzer warnings in Tools.
80         https://bugs.webkit.org/show_bug.cgi?id=137534
81
82         Reviewed by Dean Jackson.
83
84         * DumpRenderTree/cg/ImageDiffCG.cpp:
85         (main): User proper printf specifiers.
86         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
87         (AccessibilityUIElement::childrenCount): Handle possibility that
88         gcc_accChildCount returns with an error.
89         (accessibilityState): Ditto for gcc_accState.
90         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
91         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
92         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
93         be treated as such.
94         * DumpRenderTree/win/DumpRenderTree.cpp:
95         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
96         by comparing an unsigned value as being greater-than zero.
97         * DumpRenderTree/win/EditingDelegate.cpp:
98         (dump): Pass proper character pointer type to printf.
99         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
100         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
101         (EditingDelegate::shouldInsertNode): Ditto.
102         (EditingDelegate::shouldInsertText): Ditto.
103         (EditingDelegate::shouldDeleteDOMRange): Ditto.
104         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
105         (EditingDelegate::shouldApplyStyle): Ditto.
106         * DumpRenderTree/win/EventSender.cpp:
107         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
108         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
109         system headers.
110         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
111         from CreateDIBSection.
112         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
113         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
114         older versions of MSVC we no longer support.
115         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
116         for 64-bit builds.
117         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
118         * TestWebKitAPI/TestsController.h: Ditto.
119         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
120         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
121         performing bitwise | before the comparison is done.
122
123 2014-10-08  Ada Chan  <adachan@apple.com>
124
125         Add a test for WKPageIsPlayingAudio().
126         https://bugs.webkit.org/show_bug.cgi?id=137048
127
128         Reviewed by Darin Adler.
129
130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
131         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
132         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
133         (TestWebKitAPI::nullJavaScriptCallback):
134         (TestWebKitAPI::didFinishLoadForFrame):
135         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
136         (TestWebKitAPI::setUpClients):
137         (TestWebKitAPI::TEST):
138         This test loads a page with a video in it. When the page is loaded, we first check that
139         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
140         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
141         now returns true for the page.
142         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
143         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
144         This is a video copied from LayoutTests/media/content.
145
146 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
147
148         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
149         https://bugs.webkit.org/show_bug.cgi?id=137516
150
151         Reviewed by Alexey Proskuryakov.
152
153         * Scripts/webkitpy/thirdparty/__init__.py:
154         (AutoinstallImportHook._install_irc):
155
156 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
157
158         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
159         https://bugs.webkit.org/show_bug.cgi?id=137520
160
161         Reviewed by Philippe Normand.
162
163         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
164         For other distributions, we are already installing libjpeg-turbo.
165         So, do the same for Debian and derivatives.
166
167         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
168
169 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
170
171         [webkitpy] Add back the workaround to replace ZipFile.extractall()
172         https://bugs.webkit.org/show_bug.cgi?id=137519
173
174         Reviewed by Csaba Osztrogonác.
175
176         It was removed by <http://trac.webkit.org/changeset/174266>,
177         because the comment stated it is a workaround for buggy python
178         2.6.1 which shipped on Snow Leopard. But it turned out the bug
179         is still valid with python 2.7 shipped on the latest Ubuntu
180         (12.04 and 14.04) and OS X 10.9.
181
182         * Scripts/webkitpy/common/system/autoinstall.py:
183         (AutoInstaller):
184         (AutoInstaller._extract_all):
185         (AutoInstaller._unzip):
186
187 2014-10-08  Commit Queue  <commit-queue@webkit.org>
188
189         Unreviewed, rolling out r174335.
190         https://bugs.webkit.org/show_bug.cgi?id=137515
191
192         It broke EFL layout test totally (Requested by gyuyoung on
193         #webkit).
194
195         Reverted changeset:
196
197         "[EFL] Introduce EWebKit_Extension"
198         https://bugs.webkit.org/show_bug.cgi?id=134921
199         http://trac.webkit.org/changeset/174335
200
201 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
202
203         [GTK] Make forwarding headers generation depend on source code
204         https://bugs.webkit.org/show_bug.cgi?id=137394
205
206         Reviewed by Philippe Normand.
207
208         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
209         * TestWebKitAPI/PlatformGTK.cmake: Only run
210         generate-forwarding-headers.pl when source code changes.
211         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
212
213 2014-10-07  Tanay C  <tanay.c@samsung.com>
214
215         Remove build warnings in Hashmap API tests
216         https://bugs.webkit.org/show_bug.cgi?id=137484
217
218         Reviewed by Darin Adler.
219
220         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
221         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
222
223 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
224
225         Commit queue doesn't drop obsolete patches sometimes
226         https://bugs.webkit.org/show_bug.cgi?id=137460
227
228         Reviewed by Alexey Proskuryakov.
229
230         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
231         Adds another test patch for use in queues_unittest.py.
232         courtesy of Csaba Osztrogonác <ossy@webkit.org>
233         (MockBugzilla):
234         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
235         Raises a PatchIsNotValid exception in the case of validate() returning
236         false.
237         (CommitQueueTask.run):
238         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
239         Raises a PatchIsNotValid exception in the case of validate() returning
240         false.
241         (EarlyWarningSystemTask.run):
242         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
243         Defines PatchIsNotValid exception. 
244         (PatchIsNotValid):
245         (PatchIsNotValid.__init__):
246         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
247         Remove call to validate() and instead catches the PatchIsNotValid
248         exception.
249         (AbstractEarlyWarningSystem.review_patch):
250         * Scripts/webkitpy/tool/commands/queues.py:
251         Adds logic to catch the PatchIsNotValid exception.
252         (CommitQueue.process_work_item):
253         * Scripts/webkitpy/tool/commands/queues_unittest.py:
254         Adds the test_non_valid_patch test to ensure that invalid patches are
255         handled properly, and don't just result in indefinite spinning.
256         courtesy of Csaba Osztrogonác <ossy@webkit.org>
257         (test_non_valid_patch):
258
259 2014-10-07  Daniel Bates  <dabates@apple.com>
260
261         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
262         https://bugs.webkit.org/show_bug.cgi?id=137499
263
264         Reviewed by Simon Fraser.
265
266         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
267         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
268         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
269         bit simulator builds of iOS WebKit.
270
271         * Scripts/webkitpy/port/ios.py:
272         (IOSSimulatorPort._generate_all_test_configurations):
273
274 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
275
276         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
277         https://bugs.webkit.org/show_bug.cgi?id=137482
278
279         Reviewed by Martin Robinson.
280
281         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
282
283 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
284
285         [SOUP] TLS errors should take precedence over HTTP authentication
286         https://bugs.webkit.org/show_bug.cgi?id=137300
287
288         Reviewed by Sergio Villar Senin.
289
290         Add a test case to check that authenticate signal is not emitted
291         in case of TLS errors, and the load fails instead.
292
293         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
294         (webViewAuthenticationCallback):
295         (testTLSErrorsHTTPAuth):
296         (httpsServerCallback):
297         (beforeAll):
298
299 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
300
301         Make webkit-patch find-users useful
302         https://bugs.webkit.org/show_bug.cgi?id=137475
303
304         Reviewed by Alexey Proskuryakov.
305
306         Make find-users use the CommitterList instead of accessing Bugzilla.
307
308         This essentially exposes the same functionality as webkitbot's whois command.
309
310         * Scripts/webkitpy/tool/commands/findusers.py:
311         (FindUsers.execute):
312
313 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
314
315         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
316         https://bugs.webkit.org/show_bug.cgi?id=137289
317
318         Unreviewed build fix.
319
320         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
321         (AccessibilityUIElement::getChildrenWithRange):
322
323 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
324
325         build.webkit.org/dashboard: Add commit queue
326         https://bugs.webkit.org/show_bug.cgi?id=137462
327
328         Reviewed by Tim Horton.
329
330         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
331         Style queue is still invisible, as it doesn't have an associated platform, and also
332         we never have problems with it anyway, so it's not worth watching.
333
334         The UI now allows for adding more bots to the Other column (such as leaks bot).
335         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
336         sources of data in a cell.
337
338         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
339         (BubbleQueue):
340         (BubbleQueue.prototype.get statusPageURL):
341         (BubbleQueue.prototype.update):
342         (BubbleQueue.prototype.loadDetailedStatus):
343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
344         (BubbleQueueServer):
345         (BubbleQueueServer.prototype.jsonQueueLengthURL):
346         (BubbleQueueServer.prototype.jsonQueueStatusURL):
347         (BubbleQueueServer.prototype.queueStatusURL):
348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
349         (BubbleQueueView):
350         (BubbleQueueView.prototype.update.appendQueue):
351         (BubbleQueueView.prototype.update):
352         (BubbleQueueView.prototype._addQueueHeadingToPopover):
353         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
354         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
355         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
361         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
362         (.bubble-server-popover .latest-status-no-link):
363         (.bubble-server-popover .bot-status-description):
364         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
365
366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
367         (buildAggregateTable):
368         (buildQueuesTable):
369         Removed dysfunctional support for EWS for now. It will be different.
370
371 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
372
373         One more case of incorrect comparison in recordpatchevent.py
374         https://bugs.webkit.org/show_bug.cgi?id=137459
375
376         Reviewed by Tim Horton.
377
378         * QueueStatusServer/app.yaml:
379         * QueueStatusServer/loggers/recordpatchevent.py:
380         (RecordPatchEvent.started):
381
382 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
383
384         webkit-queues PatchLog is incorrect for patches that took less than a second
385         https://bugs.webkit.org/show_bug.cgi?id=137453
386
387         Reviewed by Tim Horton.
388
389         * QueueStatusServer/app.yaml: Updated app version.
390
391         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
392         Don't bail out for patches that took 0 seconds to process (as frequently happens
393         when a patch is obsolete).
394
395 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
396
397         EWS bubble hover shows wrong timestamps
398         https://bugs.webkit.org/show_bug.cgi?id=137252
399
400         Reviewed by Alexey Proskuryakov.
401
402         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
403
404         * QueueStatusServer/handlers/queuestatusjson.py:
405         (QueueStatusJSON.get):
406         * QueueStatusServer/handlers/statusbubble.py:
407         (StatusBubble._iso_time):
408
409 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
410
411         Unreviewed, updated list of email addresses in contributors.json
412
413         * Scripts/webkitpy/common/config/contributors.json: Added my former
414         email address in Igalia, for the sake of completeness.
415
416 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
417
418         Unreviewed, moved myself to the list of committers.
419
420         * Scripts/webkitpy/common/config/contributors.json:
421
422 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
423
424         [EFL] Introduce EWebKit_Extension
425         https://bugs.webkit.org/show_bug.cgi?id=134921
426
427         Reviewed by Gyuyoung Kim.
428
429         * MiniBrowser/efl/main.c: Added x option to test extension path.
430         (window_create):
431         (elm_main):
432         * Scripts/webkitpy/common/config/watchlist:
433         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
434         * Scripts/webkitpy/style/checker.py:
435         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
436
437 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
438
439         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
440         https://bugs.webkit.org/show_bug.cgi?id=137390
441
442         Reviewed by Carlos Garcia Campos.
443
444         * Scripts/update-webkit-libs-jhbuild:
445
446 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
447
448         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
449         https://bugs.webkit.org/show_bug.cgi?id=137391
450
451         Reviewed by Martin Robinson.
452
453         Add a custom command to only re-generate
454         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
455
456         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
457
458 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
459
460         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
461         https://bugs.webkit.org/show_bug.cgi?id=135502
462
463         Reviewed by Martin Robinson.
464
465         When writing to stdout/stderr fails due to a UnicodeDecodeError
466         exception, try again without encoding the output.
467
468         * gtk/gtkdoc.py:
469         (GTKDoc._run_command):
470
471 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
472
473         Bugzilla status bubble displays an exception showing attachment 175738
474         https://bugs.webkit.org/show_bug.cgi?id=137410
475
476         Reviewed by Tim Horton.
477
478         * QueueStatusServer/app.yaml: Update version.
479
480         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
481         Don't fail even if expected status message is missing.
482
483         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
484         the field in the same way it's defined in QueueStatus table.
485
486 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
487
488         Record latest message in PatchLog for quick access
489         https://bugs.webkit.org/show_bug.cgi?id=137405
490
491         Fixing a typo.
492
493         * QueueStatusServer/app.yaml:
494         * QueueStatusServer/handlers/releasepatch.py:
495
496 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
497
498         Record latest message in PatchLog for quick access
499         https://bugs.webkit.org/show_bug.cgi?id=137405
500
501         Reviewed by Ryosuke Niwa.
502
503         It's no SQL...
504
505         * QueueStatusServer/handlers/releasepatch.py:
506         * QueueStatusServer/handlers/updatestatus.py:
507         * QueueStatusServer/loggers/recordpatchevent.py:
508         * QueueStatusServer/model/patchlog.py:
509
510 2014-10-02  David Farler  <dfarler@apple.com>
511
512         -asan-blacklist option also renamed to generic -fsanitize-blacklist
513         https://bugs.webkit.org/show_bug.cgi?id=137377
514
515         Reviewed by Daniel Bates.
516
517         * asan/asan.xcconfig:
518         -asan-blacklist -> -fsanitize-blacklist
519
520         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
521
522 2014-10-03  Roger Fong  <roger_fong@apple.com>
523
524         [Windows] Include batch size argument to layout tests on Windows.
525
526         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
527         (RunWebKitTests.start): 
528         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
529         These crashes seem to happen on random tests though generally in a spread out fashion.
530         It seems possible that the DRT instance is being clobbered somehow after running too many
531         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
532
533 2014-10-03  Roger Fong  <roger_fong@apple.com>
534
535         [Windows] Settle for 2 chid processes running NRWT on Windows.
536
537         * Scripts/webkitpy/port/win.py:
538         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
539
540 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
541
542         [GTK] Bump up and patch dependencies to allow building for aarch64
543         https://bugs.webkit.org/show_bug.cgi?id=137147
544
545         Reviewed by Martin Robinson.
546
547         The currently used versions of pixman, libffi, librsvg, glib,
548         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
549         and/or build for aarch64, so they are bumped up and patched where
550         necessary. Wherever possible, the same versions and patches were used as
551         for the EFL port bump-up
552         (https://bugs.webkit.org/show_bug.cgi?id=135885).
553
554         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
555         regression by crashing http/tests/media/video-redirect.html . A patch
556         already in upstream fixes that bug.
557
558         This change does not touch xserver, which also needs bumping up, but 
559         will be dealt with later.
560
561         * gtk/jhbuild.modules:
562         Specified versions and patches necessary to correctly build for aarch64.
563         * gtk/patches/gst-events-arent-gstobjects.patch:
564         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
565         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
566         Added. Patches gst-plugins-base to configure correctly for aarch64.
567         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
568         Added. Bumps up config.guess and config.sub in librsvg to recognize
569         aarch64.
570         * gtk/patches/libxml2-2.9.0-dtd.patch:
571         Removed. Not necessary for libxml2 v2.9.1 anymore.
572
573 2014-09-28  Sam Weinig  <sam@webkit.org>
574
575         Remove RefPtrHashMap
576         https://bugs.webkit.org/show_bug.cgi?id=137200
577
578         Reviewed by Darin Adler.
579
580         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
581         (TestWebKitAPI::TEST):
582         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
583         a minimum of refcount churn occurs.
584
585 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
586
587         Remove workarounds for versions of Python before 2.7
588         https://bugs.webkit.org/show_bug.cgi?id=137338
589
590         Reviewed by Csaba Osztrogonác.
591
592         * Scripts/webkitpy/common/system/autoinstall.py:
593         (AutoInstaller._extract_targz):
594         (AutoInstaller._unzip):
595         (AutoInstaller): Deleted.
596         (AutoInstaller._extract_all): Deleted.
597         * Scripts/webkitpy/common/webkitunittest.py:
598         (TestCase.setUp): Deleted.
599         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
600         (TestConfigurationConverter.collapse_macros):
601         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
602         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
603         (TestConfigurationConverter):
604         (TestConfigurationConverter.combinations): Deleted.
605         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
606         * Scripts/webkitpy/port/base.py:
607
608 2014-10-03  Commit Queue  <commit-queue@webkit.org>
609
610         Unreviewed, rolling out r174264.
611         https://bugs.webkit.org/show_bug.cgi?id=137392
612
613         It broke run-webkit-tests (Requested by ebalazsfalvi on
614         #webkit).
615
616         Reverted changeset:
617
618         "Remove workarounds for versions of Python before 2.7"
619         https://bugs.webkit.org/show_bug.cgi?id=137338
620         http://trac.webkit.org/changeset/174264
621
622 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
623
624         Remove workarounds for versions of Python before 2.7
625         https://bugs.webkit.org/show_bug.cgi?id=137338
626
627         Reviewed by Csaba Osztrogonác.
628
629         * Scripts/webkitpy/common/system/autoinstall.py:
630         (AutoInstaller._extract_targz):
631         (AutoInstaller._unzip):
632         (AutoInstaller): Deleted.
633         (AutoInstaller._extract_all): Deleted.
634         * Scripts/webkitpy/common/webkitunittest.py:
635         (TestCase.setUp): Deleted.
636         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
637         (TestConfigurationConverter.collapse_macros):
638         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
639         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
640         (TestConfigurationConverter):
641         (TestConfigurationConverter.combinations): Deleted.
642         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
643         * Scripts/webkitpy/port/base.py:
644         * Scripts/webkitpy/port/driver.py:
645         (ContentBlock.__init__):
646         * Scripts/webkitpy/port/server_process.py:
647         (ServerProcess._reset):
648
649 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
650
651         Remove autoinstaller workaround for python 2.6
652         https://bugs.webkit.org/show_bug.cgi?id=137343
653
654         Reviewed by Daniel Bates.
655
656         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
657         2.6, nor Snow Leopard is supported anymore, so the workaround is not
658         needed anymore.
659
660         * Scripts/webkitpy/common/system/autoinstall.py:
661         (AutoInstaller.install):
662         * Scripts/webkitpy/test/main.py:
663         (Tester._run_tests):
664         * Scripts/webkitpy/thirdparty/__init__.py:
665         (AutoinstallImportHook._install_mechanize):
666         (AutoinstallImportHook._install_pep8):
667         (AutoinstallImportHook._install_pylint):
668         (AutoinstallImportHook._install_buildbot):
669         (AutoinstallImportHook._install_coverage):
670         (AutoinstallImportHook._install_eliza):
671         (AutoinstallImportHook._install_irc):
672         (AutoinstallImportHook._install):
673         (autoinstall_everything):
674
675 2014-10-02  Daniel Bates  <dabates@apple.com>
676
677         Use version number 101000 instead of 10100 for OS X Yosemite
678         https://bugs.webkit.org/show_bug.cgi?id=137372
679
680         Reviewed by Mark Rowe.
681
682         The version number for OS X Yosemite is 101000.
683
684         * DumpRenderTree/mac/TextInputController.m:
685
686 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
687
688         update-work-items should never delete items
689         https://bugs.webkit.org/show_bug.cgi?id=137366
690
691         Reviewed by Ryosuke Niwa.
692
693         As we don't just replace the whole list any more, indicate which items are high
694         priority, and which are not. Hight priority ones will be prepended to the queue,
695         others will be appended.
696
697         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
698         But hopefully we will never have many rollouts competing like that.
699
700         * QueueStatusServer/app.yaml: Update version.
701
702         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
703         priority and regular items separately. Removed some error handling that used to
704         end up in returning status 500 - an uncaught exception does that automatically.
705
706         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
707
708         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
709
710         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
711         priority items.
712
713         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
714         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
715         line that complicated testing.
716
717         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
718
719         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
720         priority items into separate lists.
721
722         * Scripts/webkitpy/common/net/statusserver_mock.py:
723         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
724         * Scripts/webkitpy/tool/commands/queues_unittest.py:
725         Updated tests.
726
727 2014-10-02  Brendan Long  <b.long@cablelabs.com>
728
729         Annoying build warnings in WTFString API tests
730         https://bugs.webkit.org/show_bug.cgi?id=137360
731
732         Reviewed by Darin Adler.
733
734         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
735         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
736
737 2014-10-02  Roger Fong  <roger_fong@apple.com>
738
739         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
740
741         * Scripts/webkitpy/port/win.py:
742         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
743
744 2014-10-02  David Farler  <dfarler@apple.com>
745
746         Move ASan arguments from LLVM (-mllvm) to the frontend
747         https://bugs.webkit.org/show_bug.cgi?id=137365
748
749         Reviewed by David Kilzer.
750
751         * asan/asan.xcconfig:
752         Remove the -mllvm prefix to the asan-blacklist argument, moving it
753         to the clang frontend.
754
755         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
756
757 2014-10-02  Commit Queue  <commit-queue@webkit.org>
758
759         Unreviewed, rolling out r174120.
760         https://bugs.webkit.org/show_bug.cgi?id=137350
761
762         While number of failures is reasonable with 2 processes, test
763         results seem to be inconsistent between runs (Requested by
764         rfong on #webkit).
765
766         Reverted changeset:
767
768         "[Windows] Back to 2 child processes for NRWT on Windows."
769         http://trac.webkit.org/changeset/174120
770
771 2014-10-02  Jeff Miller  <jeffm@apple.com>
772
773         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
774         https://bugs.webkit.org/show_bug.cgi?id=137347
775
776         Reviewed by Dan Bernstein.
777
778         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
779         Use WebKitSystemInterfaceYosemite on OS X 10.10.
780
781         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
782         Ditto.
783
784 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
785
786         [GTK] [JHBuild] Switch sourceware.org mirror to http.
787
788         Unreviewed.
789
790         The ftp access is recently failing to work as expected, and the
791         bots fail to download the file.
792         The same mirror is available via http and seems to work better.
793
794         * gtk/jhbuild.modules:
795
796 2014-10-01  Commit Queue  <commit-queue@webkit.org>
797
798         Unreviewed, rolling out r174185.
799         https://bugs.webkit.org/show_bug.cgi?id=137334
800
801         Patch that adds logging causes webkitpy failures (Requested by
802         rfong on #webkit).
803
804         Reverted changeset:
805
806         "commitqueuetasks_unittest references a non-existent member
807         variable"
808         https://bugs.webkit.org/show_bug.cgi?id=137303
809         http://trac.webkit.org/changeset/174185
810
811 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
812
813         EWS and Commit Queue should know better than to spew 500 failed
814         results in the case of extremely red patches.
815         https://bugs.webkit.org/show_bug.cgi?id=137324
816
817         Reviewed by Alexey Proskuryakov.
818
819         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
820         Adds a check for did_exceed_test_failure_limit.
821         (AbstractEarlyWarningSystem._failing_tests_message):
822         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
823         Alters the task mock to respond properly to
824         results_from_patch_test_run(patch)
825         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
826         * Scripts/webkitpy/tool/commands/queues.py:
827         Adds a check for did_exceed_test_failure_limit.
828         (CommitQueue._failing_tests_message):
829
830 2014-10-01  Daniel Bates  <dabates@apple.com>
831
832         Unreviewed, rolling out r174192.
833
834         Revert the unit test fix in r174192 since we reverted r174187
835         in r174194 due to correctness issues. See
836         <http://webkit.org/b/137329> for more details.
837
838         Reverted changeset:
839
840         "Test fix after r174187"
841         http://trac.webkit.org/changeset/174192
842
843 2014-10-01  Mark Rowe  <mrowe@apple.com>
844
845         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
846
847         Reviewed by Dan Bernstein.
848
849         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
850         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
851         for the LLVM components when on Yosemite.
852
853 2014-10-01  Commit Queue  <commit-queue@webkit.org>
854
855         Unreviewed, rolling out r174187.
856         https://bugs.webkit.org/show_bug.cgi?id=137329
857
858         webkitpy failures, and thorton says the patch is wrong
859         (Requested by dethbakin on #webkit).
860
861         Reverted changeset:
862
863         "[Windows] Increase layout test timeout for Windows following
864         r174162."
865         http://trac.webkit.org/changeset/174187
866
867 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
868
869         Test fix after r174187
870
871         * Scripts/webkitpy/port/win_unittest.py:
872         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
873
874 2014-10-01  Roger Fong  <roger_fong@apple.com>
875
876         [Windows] Increase layout test timeout for Windows following r174162.
877
878         * Scripts/webkitpy/port/win.py:
879         (WinPort.default_timeout_ms):
880
881 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
882
883         commitqueuetasks_unittest references a non-existent member variable
884         when mock-reporting flaky tests.
885         https://bugs.webkit.org/show_bug.cgi?id=137303
886
887         Reviewed by Daniel Bates.
888
889         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
890         (MockCommitQueue.report_flaky_tests):
891         Makes the appropriate name change.
892         (test_simple_flaky_test_failure):
893         Adds a unit test to make sure that the code is excercised.
894
895 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
896
897         EWS is inconclusively spinning forever on a patch that breaks 500+
898         tests
899         https://bugs.webkit.org/show_bug.cgi?id=137223
900
901         Reviewed by Tim Horton.
902
903         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
904         Checks to see whether the tests have exceeded the failure limit, and
905         only spins off another test if they have not exceeded the limit.
906         (PatchAnalysisTask._test_patch):
907
908 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
909
910         Unreviewed, add Katie Madonna as a contributor.
911
912         * Scripts/webkitpy/common/config/contributors.json:
913
914 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
915
916         commitqueuetasks_unittest does not construct FailingTestCommitQueue
917         objects properly in its test cases.
918         https://bugs.webkit.org/show_bug.cgi?id=137281
919
920         Reviewed by Daniel Bates.
921
922         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
923         (FailingTestCommitQueue.test_results):
924         Adds an assert to make FailingTestCommitQueue harder to mis-use.
925         (test_double_flaky_test_failure):
926         Nests the intended test failure strings into one-length lists.
927         (test_red_test_failure):
928         Nests the intended test failure strings into one-length lists.
929
930 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
931
932         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
933         https://bugs.webkit.org/show_bug.cgi?id=136987
934
935         Reviewed by Daniel Bates.
936
937         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
938         Specify the default encoding for all WebKit developers to get consistent results.
939
940 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
941
942         EWS is too eager to say that a patch does not apply to trunk of repository
943         https://bugs.webkit.org/show_bug.cgi?id=137290
944
945         Reviewed by Ryosuke Niwa.
946
947         * QueueStatusServer/app.yaml: Updated app version.
948
949         * QueueStatusServer/handlers/statusbubble.py:
950         (StatusBubble._build_bubble):
951         (StatusBubble._build_bubbles_for_attachment):
952         Rewrote to make more sense.
953
954 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
955
956         Remove thirdparty/unittest2 from webkitpy
957         https://bugs.webkit.org/show_bug.cgi?id=137251
958
959         Reviewed by Brent Fulgham.
960
961         Additionally ordered imports in related webkitpy files and
962         removed unnecessary shebangs from unittest files.
963
964         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
965         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
966         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
967         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
968         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
969         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
970         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
971         * Scripts/webkitpy/common/config/committers_unittest.py:
972         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
973         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
974         * Scripts/webkitpy/common/config/ports_unittest.py:
975         * Scripts/webkitpy/common/config/urls_unittest.py:
976         * Scripts/webkitpy/common/editdistance_unittest.py:
977         * Scripts/webkitpy/common/find_files_unittest.py:
978         * Scripts/webkitpy/common/lru_cache_unittest.py:
979         * Scripts/webkitpy/common/memoized_unittest.py:
980         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
981         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
982         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
983         * Scripts/webkitpy/common/net/credentials_unittest.py:
984         * Scripts/webkitpy/common/net/failuremap_unittest.py:
985         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
986         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
987         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
988         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
989         * Scripts/webkitpy/common/net/statusserver_unittest.py:
990         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
991         * Scripts/webkitpy/common/newstringio_unittest.py:
992         * Scripts/webkitpy/common/prettypatch_unittest.py:
993         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
994         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
995         * Scripts/webkitpy/common/system/environment_unittest.py:
996         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
997         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
998         * Scripts/webkitpy/common/system/executive_unittest.py:
999         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
1000         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1001         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1002         * Scripts/webkitpy/common/system/logtesting.py:
1003         * Scripts/webkitpy/common/system/logutils_unittest.py:
1004         * Scripts/webkitpy/common/system/outputcapture.py:
1005         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
1006         * Scripts/webkitpy/common/system/outputtee_unittest.py:
1007         * Scripts/webkitpy/common/system/path_unittest.py:
1008         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1009         * Scripts/webkitpy/common/system/profiler_unittest.py:
1010         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
1011         * Scripts/webkitpy/common/system/user_unittest.py:
1012         * Scripts/webkitpy/common/system/workspace_unittest.py:
1013         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1014         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
1015         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
1016         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
1017         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
1018         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
1019         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
1020         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
1021         * Scripts/webkitpy/common/webkitunittest.py:
1022         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1023         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1024         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1025         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1026         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1027         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1028         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1029         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
1030         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
1031         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1032         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1033         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1034         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
1035         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1036         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1037         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
1038         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1039         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1040         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1041         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1042         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1043         * Scripts/webkitpy/port/base_unittest.py:
1044         * Scripts/webkitpy/port/builders_unittest.py:
1045         * Scripts/webkitpy/port/config_unittest.py:
1046         * Scripts/webkitpy/port/driver_unittest.py:
1047         * Scripts/webkitpy/port/efl_unittest.py:
1048         * Scripts/webkitpy/port/factory_unittest.py:
1049         * Scripts/webkitpy/port/gtk_unittest.py:
1050         * Scripts/webkitpy/port/http_lock_unittest.py:
1051         * Scripts/webkitpy/port/image_diff_unittest.py:
1052         * Scripts/webkitpy/port/leakdetector_unittest.py:
1053         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
1054         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1055         * Scripts/webkitpy/port/mock_drt_unittest.py:
1056         * Scripts/webkitpy/port/port_testcase.py:
1057         * Scripts/webkitpy/port/server_process_unittest.py:
1058         * Scripts/webkitpy/port/westondriver_unittest.py:
1059         * Scripts/webkitpy/port/win_unittest.py:
1060         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1061         * Scripts/webkitpy/style/checker_unittest.py:
1062         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1063         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1064         * Scripts/webkitpy/style/checkers/common_unittest.py:
1065         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1066         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
1067         * Scripts/webkitpy/style/checkers/js_unittest.py:
1068         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
1069         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
1070         * Scripts/webkitpy/style/checkers/png_unittest.py:
1071         * Scripts/webkitpy/style/checkers/python_unittest.py:
1072         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1073         * Scripts/webkitpy/style/checkers/text_unittest.py:
1074         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
1075         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
1076         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1077         * Scripts/webkitpy/style/error_handlers_unittest.py:
1078         * Scripts/webkitpy/style/filereader_unittest.py:
1079         * Scripts/webkitpy/style/filter_unittest.py:
1080         * Scripts/webkitpy/style/main_unittest.py:
1081         * Scripts/webkitpy/style/optparser_unittest.py:
1082         * Scripts/webkitpy/style/patchreader_unittest.py:
1083         * Scripts/webkitpy/test/finder_unittest.py:
1084         * Scripts/webkitpy/test/main.py: Ordered imports.
1085         * Scripts/webkitpy/test/main_unittest.py:
1086         * Scripts/webkitpy/test/printer.py: Ordered imports.
1087         (Printer.configure):
1088         * Scripts/webkitpy/test/runner_unittest.py:
1089         * Scripts/webkitpy/test/skip_unittest.py:
1090         * Scripts/webkitpy/thirdparty/__init__.py:
1091         (AutoinstallImportHook._install_irc):
1092         (AutoinstallImportHook._install_unittest2): Deleted.
1093         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1094         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
1095         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1096         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1097         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1098         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
1099         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1100         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1101         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1102         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1103         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1104         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1105         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1106         * Scripts/webkitpy/tool/commands/download_unittest.py:
1107         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1108         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
1109         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1110         * Scripts/webkitpy/tool/commands/queuestest.py:
1111         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1112         * Scripts/webkitpy/tool/grammar_unittest.py:
1113         * Scripts/webkitpy/tool/mocktool_unittest.py:
1114         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1115         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1116         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1117         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
1118         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
1119         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
1120         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1121         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
1122         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1123         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
1124         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
1125         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1126         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1127         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1128         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1129         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1130         * Scripts/webkitpy/tool/steps/update_unittest.py:
1131         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1132         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1133         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1134         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1135         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1136
1137 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
1138
1139         LayoutTestResults and ExpectedFailures should know about the
1140         interrupted flag from the json results file
1141         https://bugs.webkit.org/show_bug.cgi?id=137229
1142
1143         Reviewed by Daniel Bates.
1144
1145         Changes LayoutTestResults to use the interrupted flag instead of
1146         counting failures.
1147
1148         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1149         (BuilderTest._install_fetch_build._mock_fetch_build):
1150         (BuilderTest.test_latest_layout_test_results):
1151         * Scripts/webkitpy/common/net/layouttestresults.py:
1152         Removes notion of failure_limit_count, and adds
1153         did_exceed_test_failure_limit.
1154
1155         (LayoutTestResults.results_from_string):
1156         (LayoutTestResults.__init__):
1157         (LayoutTestResults.did_exceed_test_failure_limit):
1158         (LayoutTestResults): Deleted.
1159         (LayoutTestResults.set_failure_limit_count): Deleted.
1160         (LayoutTestResults.failure_limit_count): Deleted.
1161         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1162         Removes unit test for failure_limit_count logic.
1163
1164         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
1165         * Scripts/webkitpy/common/net/resultsjsonparser.py:
1166         Instead of providing a class method that returns a list of
1167         TestResults objects, resultsjsonparser now provides a class
1168         ParsedJSONResults that serves as an interface between the results.json
1169         file and the rest of webkitpy.
1170
1171         (ParsedJSONResults):
1172         (ParsedJSONResults.__init__):
1173         (ParsedJSONResults.did_exceed_test_failure_limit):
1174         (ParsedJSONResults.test_results):
1175         (ResultsJSONParser): Deleted.
1176         (ResultsJSONParser.parse_results_json): Deleted.
1177         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
1178         Updates the unit test so that it can test the new ResultsJSONParser
1179         class.
1180
1181         (ParsedJSONResultsTest):
1182         (test_basic):
1183         (ResultsJSONParserTest): Deleted.
1184         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1185         Updates the unit test to instantiate ResultsJSONParser objects rather
1186         than simple lists of TestResult objects.
1187
1188         (MockCommitQueue.test_results):
1189         (FailingTestCommitQueue.test_results):
1190         (test_flaky_test_failure):
1191         (test_failed_archive):
1192         * Scripts/webkitpy/tool/bot/expectedfailures.py:
1193         Updates ExpectedFailures to use the did_exceed_test_failure_limit
1194         method rather than counting the number of failed tests.
1195
1196         (ExpectedFailures._should_trust):
1197         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
1198         Updates MockResults to more closely resemble the updated
1199         LayoutTestResults class.
1200
1201         (MockResults.__init__):
1202         (MockResults.did_exceed_test_failure_limit):
1203         (ExpectedFailuresTest.test_can_trust_results):
1204         (ExpectedFailuresTest.test_unexpected_failures_observed):
1205         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
1206         (MockResults.failure_limit_count): Deleted.
1207         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1208         Removes a FIXME regarding the use of the
1209         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
1210
1211         (LayoutTestResultsReader.results):
1212         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1213         Updates test to not check the now-nonexistant failure_count_limit
1214         method.
1215
1216         (test_missing_unit_test_results_path):
1217         (test_layout_test_results):
1218         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1219         Accounts for name change: ResultsJSONParserTest ->
1220         ParsedJSONParserTest.
1221
1222         (RebaselineTestTest.test_gather_baselines):
1223
1224 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1225
1226         [EFL] Rename TEST_THEME_DIR macro
1227         https://bugs.webkit.org/show_bug.cgi?id=137244
1228
1229         Reviewed by Csaba Osztrogonác.
1230
1231         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
1232         DEFAULT_THEME_DIR is better than it.
1233
1234         * MiniBrowser/efl/main.c:
1235         (window_create):
1236         * TestWebKitAPI/efl/PlatformWebView.cpp:
1237         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1238         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1239         (WTR::PlatformWebView::PlatformWebView):
1240
1241 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1242
1243         Windows EWS went purple when it failed to build
1244         https://bugs.webkit.org/show_bug.cgi?id=137267
1245
1246         Reviewed by Ryosuke Niwa.
1247
1248         * QueueStatusServer/app.yaml: Update the version.
1249
1250         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
1251         Make it work for style and win-ews queues.
1252
1253 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
1254
1255         It should be fun and easy to run every possible JavaScript benchmark from the command line
1256         https://bugs.webkit.org/show_bug.cgi?id=137245
1257
1258         Reviewed by Oliver Hunt.
1259         
1260         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
1261         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
1262         having their own private scripts for doing benchmark runs, and didn't share them in the open
1263         source community, because of fears about the shady licensing of the benchmarks suites that
1264         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
1265         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
1266         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
1267         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
1268         but some of them are. The non-public tests are exclusively those that were not made by any
1269         WebKit contributor, but which JSC/WebKit devs found useful for testing.
1270
1271         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
1272         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
1273         checked into WebKit svn at all) can be run by passing the path to them via a configuration
1274         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
1275         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
1276         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
1277         probably never be checked in because there is no license text anywhere in that benchmark.
1278         A valid ~/.run-jsc-benchmarks file will just be something like:
1279         
1280             {
1281                 "OctanePath": "/path/to/Octane2",
1282                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
1283             }
1284         
1285         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
1286         run-jsc-benchmarks will just gracefully avoid running that test suite.
1287         
1288         Finally, a word about policy: it is understood that different organizations that do
1289         development on JSC may find themselves having internal benchmarks that they cannot share
1290         because of weird licensing. It happens - usually because the organization doing JSC
1291         development found some test in the wild that is owned by someone else and therefore cannot
1292         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
1293         that add support for some new kind of benchmark suite even if the suite is not made public
1294         as part of the same patch - so long as the patch isn't too invasive. An example of
1295         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
1296         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
1297         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
1298         completely open-sourced and committed to the WebKit repo - but the reality is that this
1299         can't always be done safely.
1300
1301         * Scripts/bencher: Removed.
1302         * Scripts/run-jsc-benchmarks: Added.
1303
1304 2014-09-30  Roger Fong  <roger_fong@apple.com>
1305
1306         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
1307
1308         * Scripts/webkitpy/port/drdiver.py:
1309         (Driver.stop):
1310         * Scripts/webkitpy/port/server_process.py:
1311         (ServerProcess.stop):
1312
1313 2014-09-30  Roger Fong  <roger_fong@apple.com>
1314
1315         [Windows] Back to 2 child processes for NRWT on Windows.
1316
1317         * Scripts/webkitpy/port/win.py:
1318         (WinPort.default_child_processes):
1319         Changing the number of processes to 1 did not have an effect on the layout test results. 
1320         It does introduce an issue with one of the workers hanging indefinitely and causing the 
1321         layout tests to timeout as a whole occasionally, but we should just fix that.
1322
1323 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1324
1325         Remove an accidentally committed line..
1326
1327         * QueueStatusServer/handlers/statusbubble.py:
1328         (StatusBubble._build_bubble):
1329
1330 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1331
1332         build.webkit.org/dashboard: Switch EWS view to using actual retry count
1333         https://bugs.webkit.org/show_bug.cgi?id=137240
1334
1335         Reviewed by Ryosuke Niwa.
1336
1337         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1338         (EWSQueue.prototype.loadDetailedStatus):
1339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1340         (EWSQueueView.prototype._popoverContentForEWSQueue):
1341         Use the new retry_count data member from JSON.
1342
1343         * QueueStatusServer/app.yaml: Updating the version.
1344
1345         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
1346         Instead of message_count, produce retry_count.
1347
1348 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1349
1350         EWS doesn't need to show all the bubbles when a patch fails to apply
1351         https://bugs.webkit.org/show_bug.cgi?id=137256
1352
1353         Reviewed by Ryosuke Niwa.
1354
1355         * QueueStatusServer/app.yaml: Updated app version.
1356
1357         * QueueStatusServer/handlers/statusbubble.py:
1358         (StatusBubble._build_bubble):
1359         (StatusBubble._build_bubbles_for_attachment):
1360         (StatusBubble.get):
1361         * QueueStatusServer/templates/statusbubble.html:
1362         When some queues fail to apply, and no queues had meaningful output (meaning that
1363         they will almost certainly fail to apply later), we can show a single bubble
1364         telling the user just that.
1365
1366 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1367
1368         [EFL] Bump EFL version to 1.11.2
1369         https://bugs.webkit.org/show_bug.cgi?id=137118
1370
1371         Reviewed by Gyuyoung Kim.
1372
1373         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
1374         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
1375
1376         * efl/jhbuild.modules:
1377         * efl/patches/ecore.patch: Removed.
1378
1379 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1380
1381         REGRESSION(r173929): [GTK] TestInspector fails after r173929
1382         https://bugs.webkit.org/show_bug.cgi?id=137247
1383
1384         Reviewed by Philippe Normand.
1385
1386         Wait until can-attach property changes before trying to attach the
1387         inspector after resizing the view.
1388
1389         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
1390         (testInspectorDefault):
1391
1392 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1393
1394         Require Python 2.7 version
1395         https://bugs.webkit.org/show_bug.cgi?id=137112
1396
1397         Reviewed by Csaba Osztrogonác.
1398
1399         * Scripts/ensure-valid-python:
1400         (checkPythonVersion):
1401         * Scripts/webkitpy/common/version_check.py:
1402
1403 2014-09-30  Martin Hock  <mhock@apple.com>
1404
1405         Skip a JSC test after r174036.
1406         https://bugs.webkit.org/show_bug.cgi?id=137236
1407
1408         Reviewed by Csaba Osztrogonác.
1409
1410         * Scripts/run-javascriptcore-tests:
1411
1412 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1413
1414         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
1415         https://bugs.webkit.org/show_bug.cgi?id=137212
1416
1417         This moves TestNetscapePlugin to a new folder (lib/plugins).
1418         We should not use the same directory for TestNetscapePlugin and
1419         the other libraries, because we end up scanning all the .so in the
1420         lib dir for every test.
1421
1422         Reviewed by Carlos Garcia Campos.
1423
1424         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
1425         * Scripts/webkitpy/port/efl.py:
1426         (EflPort.setup_environ_for_server): Update plugin path.
1427         * Scripts/webkitpy/port/gtk.py:
1428         (GtkPort.setup_environ_for_server): Update plugin path.
1429         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
1430
1431 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
1432
1433         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
1434
1435         Rubber-stamped by Tim Horton.
1436
1437         * QueueStatusServer/app.yaml:
1438         * QueueStatusServer/handlers/statusbubble.py:
1439         (StatusBubble._build_bubble):
1440
1441 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
1442
1443         Typo fix, suggested by Tim Horton.
1444
1445         * QueueStatusServer/handlers/statusbubble.py:
1446         (StatusBubble._build_message_for_provisional_failure):
1447
1448 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
1449
1450         Improve Bugzilla status bubbles
1451         https://bugs.webkit.org/show_bug.cgi?id=137232
1452
1453         Reviewed by Ryosuke Niwa.
1454
1455         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
1456
1457         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
1458         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
1459         that are stuck, as it was only confusing that they disappeared after 99.
1460
1461         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
1462         by old bubbles. We need a lot more information to determine color, so the implementation
1463         can not be here.
1464
1465         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
1466         always have a link for consistency. Added code to convert timestamps in tooltips
1467         to local time zone.
1468
1469 2014-09-29  Commit Queue  <commit-queue@webkit.org>
1470
1471         Unreviewed, rolling out r174045.
1472         https://bugs.webkit.org/show_bug.cgi?id=137231
1473
1474         Introduced a crash during page loading tests on Mac (Requested
1475         by rniwa on #webkit).
1476
1477         Reverted changeset:
1478
1479         "Replace OSObjectPtr with RetainPtr/adoptOS"
1480         https://bugs.webkit.org/show_bug.cgi?id=137158
1481         http://trac.webkit.org/changeset/174045
1482
1483 2014-09-29  Tim Horton  <timothy_horton@apple.com>
1484
1485         Add Jake as a contributor.
1486
1487         * Scripts/webkitpy/common/config/contributors.json:
1488
1489 2014-09-29  Roger Fong  <roger_fong@apple.com>
1490
1491         [Windows] Skip a javascriptcore test following r174036.
1492
1493         * Scripts/run-javascriptcore-tests:
1494
1495 2014-09-29  Roger Fong  <roger_fong@apple.com>
1496
1497         [Windows] Reduce number of processes used by NRWT on Windows to 1.
1498
1499         * Scripts/webkitpy/port/win.py:
1500         (WinPort.default_child_processes):
1501         Reduce number of processes to 1 so we can get a good baseline for what failures
1502         we should be expecting to see from the Windows bots.
1503
1504 2014-09-29  Darin Adler  <darin@apple.com>
1505
1506         Tweak and tighten SVG font converter
1507         https://bugs.webkit.org/show_bug.cgi?id=136956
1508
1509         Reviewed by Myles Maxfield.
1510
1511         I was investigating behavior of String::toInt, String::toDouble, and
1512         String::toFloat for various failure cases, and decided to start some
1513         unit tests for those functions here.
1514
1515         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1516         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
1517         StringToDouble testing.
1518
1519 2014-09-29  Philippe Normand  <pnormand@igalia.com>
1520
1521         [GTK][CMake] TestWebCore target build sometimes fail
1522         https://bugs.webkit.org/show_bug.cgi?id=137207
1523
1524         Reviewed by Csaba Osztrogon.
1525
1526         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
1527         headers are generated before the TestWebCore target is built.
1528
1529 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1530
1531         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
1532         https://bugs.webkit.org/show_bug.cgi?id=137209
1533
1534         Reviewed by Philippe Normand.
1535
1536         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
1537         from the WebCore test sources.
1538
1539 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
1540
1541         Allow webkit-patch upload to respect the --directory argument with git checkouts
1542         https://bugs.webkit.org/show_bug.cgi?id=137166
1543
1544         Reviewed by Darin Adler.
1545
1546         We simply hadn't plumbed it through.
1547
1548         * Scripts/webkitpy/common/checkout/scm/detection.py:
1549         (SCMDetector.detect_scm_system):
1550         * Scripts/webkitpy/common/checkout/scm/git.py:
1551         (Git.__init__):
1552         (Git.changed_files):
1553
1554 2014-09-26  Sam Weinig  <sam@webkit.org>
1555
1556         Replace OSObjectPtr with RetainPtr/adoptOS
1557         https://bugs.webkit.org/show_bug.cgi?id=137158
1558
1559         Reviewed by Dan Bernstein.
1560
1561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1562         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
1563         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
1564         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
1565
1566 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
1567
1568         Disable function.arguments
1569         https://bugs.webkit.org/show_bug.cgi?id=137167
1570
1571         Rubber stamped by Geoffrey Garen
1572         
1573         Enable the feature by default during tests.
1574
1575         * Scripts/run-jsc-stress-tests:
1576
1577 2014-09-26  Beth Dakin  <bdakin@apple.com>
1578
1579         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
1580         https://bugs.webkit.org/show_bug.cgi?id=137089
1581
1582         Reviewed by Tim Horton.
1583
1584         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
1585         tests run at 1x, but that code does not seem to execute at the right time for 
1586         these tests, so if we just ensure we start out at 1x, that appears to fix these 
1587         tests and does not break the HiDPI tests either.
1588         * WebKitTestRunner/TestController.cpp:
1589         (WTR::TestController::createWebViewWithOptions):
1590
1591 2014-09-26  Roger Fong  <roger_fong@apple.com>
1592
1593         [Windows] Decrease default number of child processes used by Windows.
1594
1595         * Scripts/webkitpy/port/win.py:
1596         (WinPort.default_child_processes):
1597         Having too many seems to cause many tests to crash or timeout. 
1598         We may even need to make it have only 1 child process if we’re still seeing problems after this.
1599
1600 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1601
1602         Mac EWS bots do not keep logs as promised
1603         https://bugs.webkit.org/show_bug.cgi?id=137151
1604
1605         Reviewed by Ryosuke Niwa.
1606
1607         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
1608
1609 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1610
1611         Get rid of webkit-queues dashboard
1612         https://bugs.webkit.org/show_bug.cgi?id=137141
1613
1614         Reviewed by Ryosuke Niwa.
1615
1616         * QueueStatusServer/app.yaml: Updated version.
1617
1618         * QueueStatusServer/templates/dashboard.html: Removed.
1619         * QueueStatusServer/handlers/dashboard.py: Removed.
1620         * QueueStatusServer/main.py:
1621         Kill it!
1622
1623         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
1624         (.status-cell): Deleted.
1625         (.status-cell:hover): Deleted.
1626         (.status-cell.pass): Deleted.
1627         (.status-cell.fail): Deleted.
1628         (.status-cell.pending): Deleted.
1629         (.status-cell.error): Deleted.
1630         * QueueStatusServer/stylesheets/dashboard.css: Removed.
1631         * QueueStatusServer/templates/activebots.html:
1632         * QueueStatusServer/templates/patch.html:
1633         * QueueStatusServer/templates/queuestatus.html:
1634         * QueueStatusServer/templates/recentstatus.html:
1635         Renamed dashboard.css to common.css, and removed dashboard-only rules.
1636
1637 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
1638
1639         Get rid of Retry status in webkit-queues
1640         https://bugs.webkit.org/show_bug.cgi?id=137135
1641
1642         Reviewed by Ryosuke Niwa.
1643
1644         * QueueStatusServer/config/messages.py: Removed Retry.
1645
1646         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
1647         no longer needs to check the latest status. It just always both unlocks the patch
1648         and removes it from WorkItems.
1649
1650         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
1651         I don't understand why we even needed to check for retries here, but now that there
1652         are no retries, that code can go to /dev/null.
1653
1654         * QueueStatusServer/loggers/recordpatchevent.py:
1655         (RecordPatchEvent.started):
1656         (RecordPatchEvent.retrying): Deleted.
1657         Fixed retry counting, it should work for all queues now.
1658
1659         * QueueStatusServer/model/queuestatus.py:
1660         (QueueStatus.is_retry_request): Deleted. These are no more.
1661
1662         * Scripts/webkitpy/common/net/statusserver_mock.py:
1663         (MockStatusServer.release_lock):
1664         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1665         Did whatever it took to keep passing the tests. The particular test doesn't seem
1666         quite right, but whatever.
1667
1668         * Scripts/webkitpy/tool/commands/queues.py:
1669         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
1670         and let others pick up. Also, added explicit returns for clarity.
1671         (AbstractPatchQueue._did_retry): Deleted.
1672
1673 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
1674
1675         [EFL] Fix the gst-libav build on ARM Thumb2
1676         https://bugs.webkit.org/show_bug.cgi?id=137022
1677
1678         Reviewed by Zoltan Herczeg.
1679
1680         * efl/jhbuild.modules:
1681         * efl/patches/gst-libav.patch: Added.
1682
1683 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
1684
1685         [EFL] Bump up dependencies not to conflict with the GTK port.
1686         https://bugs.webkit.org/show_bug.cgi?id=137143
1687
1688         Reviewed by Gyuyoung Kim.
1689
1690         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
1691         installing and removing different versions of libgnutls-dev, thus
1692         hindering the development for both ports on the same machine. GTK is
1693         using the newer version of the package, now bumping up EFL to use the 
1694         same.
1695
1696         * efl/install-dependencies:
1697
1698 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
1699
1700         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
1701         https://bugs.webkit.org/show_bug.cgi?id=136854
1702
1703         Reviewed by Gyuyoung Kim.
1704
1705         'Escape' key should exit fullscreen first and then should be used to stop page load.
1706
1707         * MiniBrowser/efl/main.c:
1708         (on_key_down):
1709
1710 2014-09-25  Dean Jackson  <dino@apple.com>
1711
1712         Add Said to the contributors list so his name completes in bugzilla.
1713
1714         * Scripts/webkitpy/common/config/contributors.json:
1715
1716 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
1717
1718         EWS only repeats its cycle every two hours
1719         https://bugs.webkit.org/show_bug.cgi?id=137129
1720
1721         Reviewed by Ryosuke Niwa.
1722
1723         * QueueStatusServer/app.yaml: Updated version.
1724
1725         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
1726
1727         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
1728         the patch from work items.
1729
1730         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
1731
1732         * QueueStatusServer/main.py: Added release-lock.
1733
1734         * QueueStatusServer/model/activeworkitems.py:
1735         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
1736
1737         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
1738         we don't want it to be immediately picked up again, it's better to give other patches
1739         a chance.
1740
1741         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
1742         these interactive versions, but OK.
1743
1744         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
1745         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
1746         or svn is down).
1747
1748         * Scripts/webkitpy/tool/commands/queues.py:
1749         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
1750         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
1751         meaning that these handlers could never do the right thing. We'd either get a duplicate
1752         _did_fail, or try to unlock an already unlocked patch.
1753         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
1754         making it eligible for retry immediately.
1755
1756         * Scripts/webkitpy/common/net/statusserver.py:
1757         (StatusServer._post_release_lock):
1758         (StatusServer.release_lock):
1759         Added a call to release-lock.
1760
1761 2014-09-25  Roger Fong  <roger_fong@apple.com>
1762
1763         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
1764
1765         * Scripts/webkitpy/common/system/path.py:
1766         (_CygPath.convert):
1767
1768 2014-09-25  Roger Fong  <roger_fong@apple.com>
1769
1770         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
1771
1772         * Scripts/webkitpy/common/system/path.py:
1773         (_CygPath.convert):
1774
1775 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1776
1777         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
1778         https://bugs.webkit.org/show_bug.cgi?id=136377
1779
1780         Reviewed by Philippe Normand.
1781
1782         * Scripts/webkitdirs.pm:
1783         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
1784
1785 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
1786
1787         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
1788         https://bugs.webkit.org/show_bug.cgi?id=137117
1789
1790         Tools/efl/install-dependencies relies on apt-get to install packages.
1791         Unfortunately, if a package does not exist (e.g., for a given
1792         architecture) then apt-get install is not able to ignore the missing
1793         package and install the rest but fails to run entirely (and there
1794         seems to be no intent to change this behaviour).
1795
1796         On ARM64, the luajit package is missing and currently it needs manual
1797         editing of install-dependencies to get the script install as much as it
1798         can.
1799
1800         This patch separates the installation of the universally available
1801         packages from those which might not be available for all architectures.
1802
1803         Reviewed by Gyuyoung Kim.
1804
1805         * efl/install-dependencies:
1806
1807 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
1808
1809         Remove WinCE port from trunk
1810         https://bugs.webkit.org/show_bug.cgi?id=136951
1811
1812         Reviewed by Alex Christensen.
1813
1814         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1815         (_should_file_trigger_build):
1816         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1817         (ShouldBuildTest):
1818         * CMakeLists.txt:
1819         * DumpRenderTree/win/DRTDataObject.cpp:
1820         (DRTDataObject::CopyMedium):
1821         * Scripts/build-webkit:
1822         * Scripts/webkit-build-directory:
1823         * Scripts/webkitdirs.pm:
1824         (argumentsForConfiguration):
1825         (builtDylibPathForName):
1826         (isAppleWinWebKit):
1827         (launcherPath):
1828         (launcherName):
1829         (shouldRemoveCMakeCache):
1830         (cmakeBasedPortArguments):
1831         (cmakeBasedPortName):
1832         (isCMakeBuild):
1833         (isWinCE): Deleted.
1834         (determineIsWinCE): Deleted.
1835         * Scripts/webkitperl/FeatureList.pm:
1836         * Scripts/webkitpy/port/port_testcase.py:
1837         (test_apache_config_file_name_for_platform):
1838         * TestWebKitAPI/config.h:
1839         * WinCELauncher/CMakeLists.txt: Removed.
1840         * WinCELauncher/main.cpp: Removed.
1841         * gtk/manifest.txt:
1842
1843 2014-09-23  David Farler  <dfarler@apple.com>
1844
1845         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
1846         https://bugs.webkit.org/show_bug.cgi?id=136895
1847
1848         Reviewed by David Kilzer.
1849
1850         Create Device, DeviceType, and Runtime data classes.
1851         Create Simulator class represent simctl output.
1852
1853         Wherever possible, use structured data classes anywhere a raw
1854         identifier or UDID string was used for a cleaner implementation
1855         and to encapsulate the inherent fragility of scraping simctl output.
1856
1857         Create a suitably named testing device if one doesn't exist.
1858
1859         Finally, accurately handle having multiple simulator runtimes (SDKs)
1860         installed in the active Xcode.app bundle.
1861
1862         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1863         (_set_up_derived_options):
1864         * Scripts/webkitpy/port/driver.py:
1865         (IOSSimulatorDriver.cmd_line):
1866         Construct DeviceType and Runtime objects from identifiers passed at the
1867         command line, still providing sensible defaults for 32- and 64-bit testing.
1868         * Scripts/webkitpy/port/ios.py:
1869         (IOSSimulatorPort.__init__):
1870         (IOSSimulatorPort.setup_test_run):
1871         (IOSSimulatorPort):
1872         (IOSSimulatorPort.testing_device):
1873         Cache the testing device once it is created or found.
1874         (IOSSimulatorPort.reset_preferences):
1875         Get the device path from the Device object instead of consructing it
1876         in the port class.
1877         (IOSSimulatorPort.simulator_udid): Deleted.
1878         Get the UDID from the testing_device :: Device object itself.
1879         * Scripts/webkitpy/xcode/simulator.py:
1880         Created Device, DeviceType, Runtime, and Simulator classes.
1881         (get_runtimes): Deleted.
1882         (get_devices): Deleted.
1883         (get_device_types): Deleted.
1884         (get_latest_runtime): Deleted.
1885
1886 2014-09-24  Roger Fong  <roger_fong@apple.com>
1887
1888         [Windows] Tentative fix for Windows test bots.
1889
1890         * Scripts/webkitpy/common/system/path.py:
1891         (_CygPath.convert):
1892
1893 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
1894
1895         Change more build.webkit.org links to https
1896         https://bugs.webkit.org/show_bug.cgi?id=137049
1897
1898         Reviewed by Csaba Osztrogonác.
1899
1900         Fix appspot, svn.webkit.org and Trac links.
1901
1902         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1903         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
1904         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1905         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1906         (ViewController.prototype._domForBuildName):
1907         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1908         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1909         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1910         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1911         (.):
1912         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1913         (EWS):
1914         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1915         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
1916         (TestHistory):
1917         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1918
1919 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
1920
1921         Update the list of u-szeged contributors.
1922
1923         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
1924
1925         * Scripts/webkitpy/common/config/contributors.json:
1926
1927 2014-09-23  Roger Fong  <roger_fong@apple.com>
1928
1929         [Windows] More debugging for the Windows bots.
1930
1931         * Scripts/webkitpy/common/system/path.py:
1932         (_CygPath):
1933
1934 2014-09-23  Roger Fong  <roger_fong@apple.com>
1935
1936         Unreviewed. Fix for r173899, those tabs should be spaces.
1937
1938         * Scripts/webkitpy/port/driver.py:
1939         (Driver._command_from_driver_input):
1940         (Driver): Deleted.
1941
1942 2014-09-23  Roger Fong  <roger_fong@apple.com>
1943
1944         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
1945
1946         * Scripts/webkitpy/port/driver.py:
1947         (Driver):
1948
1949 2014-09-23  Jer Noble  <jer.noble@apple.com>
1950
1951         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
1952         https://bugs.webkit.org/show_bug.cgi?id=137031
1953
1954         Reviewed by Joseph Pecoraro.
1955
1956         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
1957         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
1958         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
1959         ChangeLog locations before passing them to createCommitMessage().
1960
1961         * Scripts/commit-log-editor:
1962
1963 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1964
1965         W3C test importer should detect manual and reference tests according their filenames
1966         https://bugs.webkit.org/show_bug.cgi?id=133852
1967
1968         Reviewed by Bem Jones-Bey.
1969
1970         * Scripts/webkitpy/w3c/test_parser.py:
1971         (TestParser.analyze_test): Adding checks based on WPT filename rules.
1972         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
1973         (TestParser):
1974         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
1975         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
1976         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1977         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
1978
1979 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
1980
1981         Unreviewed, add Rebecca Hauck as a contributor.
1982
1983         * Scripts/webkitpy/common/config/contributors.json:
1984
1985 2014-09-23  David Kilzer  <ddkilzer@apple.com>
1986
1987         Switch build.webkit.org URLs to https
1988
1989         Reviewed by Lucas Forschler and Alexey Proskuryakov.
1990
1991         * TestResultServer/app.yaml: Update version to this commit
1992         revision.
1993
1994         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1995         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1996         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1997         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
1998         (WebKitBuildbot):
1999         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2002         (.):
2003         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2004         (WebKitBuildbot):
2005         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2006         * Scripts/webkitpy/common/config/urls.py:
2007         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2008         (test_builder_with_name):
2009         * Scripts/webkitpy/tool/commands/queries.py:
2010         (TreeStatus):
2011         * TestResultServer/generate_builders_json.py:
2012         (main):
2013         * TestResultServer/generate_builders_json_unittest.py:
2014         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2015         (GenerateBuildersJsonTest):
2016         (GenerateBuildersJsonTest.test_generate_json_data):
2017         * TestResultServer/static-dashboards/builders.jsonp:
2018         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2019         (loadExpectationsLayoutTests):
2020         * TestResultServer/static-dashboards/timeline_explorer.js:
2021
2022 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2023
2024         W3C test importer should copy .htaccess files
2025         https://bugs.webkit.org/show_bug.cgi?id=136850
2026
2027         Reviewed by Bem Jones-Bey.
2028
2029         * Scripts/webkitpy/w3c/test_importer.py:
2030         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
2031         (TestImporter):
2032         (TestImporter.find_importable_tests): Making use of new helper function.
2033
2034 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
2035
2036         Trying to revive bot watcher's dashboard after HSTS.
2037
2038         Unreviewed.
2039
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2041         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
2042
2043 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2044
2045         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
2046         https://bugs.webkit.org/show_bug.cgi?id=137026
2047
2048         Reviewed by Csaba Osztrogonác.
2049
2050         * BuildSlaveSupport/wait-for-SVN-server.py:
2051         (getLatestSVNRevision):
2052         (waitForSVNRevision):
2053
2054 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2055
2056         Remove unlinkZeroFiles from build-webkit
2057         https://bugs.webkit.org/show_bug.cgi?id=137018
2058
2059         Reviewed by Csaba Osztrogonác.
2060
2061         * Scripts/build-webkit:
2062         (unlinkZeroFiles): Deleted.
2063
2064 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
2065
2066         [GTK] Minibrowser : Add keyboard support for stop page load
2067         https://bugs.webkit.org/show_bug.cgi?id=136857
2068
2069         Reviewed by Philippe Normand.
2070
2071         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
2072
2073         * MiniBrowser/gtk/BrowserWindow.c:
2074         (stopPageLoad): Callback to stop page load.
2075         (browser_window_init):
2076
2077 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
2078
2079         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
2080         https://bugs.webkit.org/show_bug.cgi?id=136813
2081
2082         Reviewed by Gyuyoung Kim.
2083
2084         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
2085
2086         * MiniBrowser/efl/main.c:
2087         (on_key_down):
2088
2089 2014-09-22  Daniel Bates  <dabates@apple.com>
2090
2091         [Cocoa] Add UI delegate callback when window.close() is called
2092         https://bugs.webkit.org/show_bug.cgi?id=137008
2093         <rdar://problem/17801001>
2094
2095         Reviewed by Anders Carlsson.
2096
2097         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
2098         for window opened via JavaScript (i.e. window.open()).
2099
2100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2101         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
2102         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
2103
2104 2014-09-22  Youenn Fablet  <youennf@gmail.com>
2105
2106         W3C importer should import html files within resources folders
2107         https://bugs.webkit.org/show_bug.cgi?id=127548
2108
2109         Reviewed by Ryosuke Niwa.
2110         
2111         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
2112
2113         * Scripts/webkitpy/w3c/test_importer.py:
2114         (TestImporter.find_importable_tests):
2115
2116 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2117
2118         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
2119         https://bugs.webkit.org/show_bug.cgi?id=136998
2120
2121         Reviewed by Philippe Normand.
2122
2123         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2124         (testWebViewCanShowMIMEType): Remove the check of PDF as
2125         unsupported MIME type.
2126
2127 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2128
2129         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
2130
2131         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
2132         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
2133
2134         * Scripts/webkitpy/common/config/watchlist: Use
2135         Source/WebCore/platform/gtk/po/ as directory to watch for
2136         WebKitGTKTranslations rule and add berto and myself to the list of
2137         watchers.
2138
2139 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
2140
2141         Fix syntaxError in watchlist since r173594
2142         https://bugs.webkit.org/show_bug.cgi?id=136996
2143
2144         Reviewed by Philippe Normand.
2145
2146         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
2147
2148 2014-09-20  Sam Weinig  <sam@webkit.org>
2149
2150         Make possible HashSet<std::unique_ptr<>>
2151         https://bugs.webkit.org/show_bug.cgi?id=136166
2152
2153         Reviewed by Darin Adler.
2154
2155         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
2156         * TestWebKitAPI/Counters.cpp: Added.
2157         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
2158         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
2159         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
2160         translation unit.
2161     
2162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2163         Add new files.
2164
2165         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2166         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
2167
2168         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2169         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
2170
2171 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2172
2173         run-webkit-tests should count tests submitted as absolute paths once
2174         https://bugs.webkit.org/show_bug.cgi?id=136848
2175
2176         Reviewed by Darin Adler.
2177
2178         * Scripts/webkitpy/port/base.py:
2179         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
2180
2181 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
2182
2183         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
2184         https://bugs.webkit.org/show_bug.cgi?id=136974
2185
2186         Reviewed by Chris Fleizach.
2187
2188         * DumpRenderTree/AccessibilityUIElement.cpp:
2189         (selectTextWithCriteriaCallback):
2190         Be sure to release the string if it was allocated.
2191
2192 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
2193
2194         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
2195         https://bugs.webkit.org/show_bug.cgi?id=136966
2196
2197         Reviewed by Daniel Bates.
2198
2199         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2200         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
2201
2202 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2203
2204         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
2205         https://bugs.webkit.org/show_bug.cgi?id=136917
2206
2207         Reviewed by Darin Adler.
2208
2209         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
2210
2211         * TestWebKitAPI/PlatformEfl.cmake:
2212         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
2213         (TestWebKitAPI::didFinishLoadForFrame):
2214         (TestWebKitAPI::TEST):
2215         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
2216
2217 2014-09-19  Daniel Bates  <dabates@apple.com>
2218
2219         Always assume internal SDK when building configuration Production
2220         https://bugs.webkit.org/show_bug.cgi?id=136925
2221         <rdar://problem/18362399>
2222
2223         Reviewed by Dan Bernstein.
2224
2225         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2226         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2227         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2228         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2229
2230 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2231
2232         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
2233         https://bugs.webkit.org/show_bug.cgi?id=136847
2234
2235         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
2236
2237         Reviewed by Alexey Proskuryakov.
2238
2239         * WebKitTestRunner/TestController.cpp:
2240         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
2241
2242 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2243
2244         [GTK] Missing inspector files in the tarball
2245         https://bugs.webkit.org/show_bug.cgi?id=136952
2246
2247         Reviewed by Gustavo Noronha Silva.
2248
2249         * gtk/manifest.txt: Add
2250         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
2251         to the tarball.
2252
2253 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2254
2255         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
2256         https://bugs.webkit.org/show_bug.cgi?id=136632
2257
2258         Reviewed by Gustavo Noronha Silva.
2259
2260         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
2261         the gtk icons.
2262         * gtk/manifest.txt: Only include the free icons in the tarball.
2263
2264 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2265
2266         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
2267         https://bugs.webkit.org/show_bug.cgi?id=136943
2268
2269         Reviewed by Philippe Normand.
2270
2271         Update the script to receive the list of files from the command
2272         line instead of scanning the given directories.
2273
2274         * gtk/generate-inspector-gresource-manifest.py:
2275         (get_filenames): Convert filenames to use relative paths.
2276         (find_all_files_in_directory): Deleted.
2277         (find_all_files_in_directory.select_file): Deleted.
2278
2279 2014-09-18  Tanay C  <tanay.c@samsung.com>
2280
2281         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
2282         https://bugs.webkit.org/show_bug.cgi?id=136739
2283
2284         Reviewed by Gyuyoung Kim.
2285
2286         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
2287         (on_mouse_wheel): Modified.
2288
2289 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2290
2291         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
2292         https://bugs.webkit.org/show_bug.cgi?id=136923
2293
2294         Reviewed by Gustavo Noronha Silva.
2295
2296         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
2297         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
2298         the source.
2299
2300 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
2301
2302         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
2303         https://bugs.webkit.org/show_bug.cgi?id=136856
2304
2305         Reviewed by Darin Adler.
2306
2307         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2308         (RunLLINTCLoopTests.countFailures):
2309         (Run32bitJSCTests.countFailures):
2310         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2311         (RunLLINTCLoopTestsTest.test_failures):
2312         (RunLLINTCLoopTestsTest.test_failure):
2313         (RunLLINTCLoopTestsTest.test_no_failure):
2314         (Run32bitJSCTestsTest.test_failures):
2315         (Run32bitJSCTestsTest.test_failure):
2316         (Run32bitJSCTestsTest.test_no_failure):
2317
2318 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
2319
2320         GMainLoopSource is exposed to race conditions
2321         https://bugs.webkit.org/show_bug.cgi?id=135800
2322
2323         Reviewed by Carlos Garcia Campos.
2324
2325         Add unit tests for GMainLoopSource.
2326
2327         The tests check correct behavior of GMainLoopSource in various conditions --
2328         from the most simple rescheduling to rescheduling during dispatch, cancelling
2329         or destroying the GMainLoopSource during dispatch, proper destroy callback
2330         dispatching etc.
2331
2332         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
2333         State of the GMainLoopSource object (either ready, sheduled or active) is
2334         thoroughly tested throughout the lifetime of that object.
2335
2336         Still missing are tests for socket callbacks, which are a bit trickier because
2337         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
2338         are also not tested thoroughly, simply because it is at the moment impossible
2339         to test that the objects are actually destroyed when the corresponding source
2340         is finally deleted.
2341
2342         * TestWebKitAPI/PlatformGTK.cmake:
2343         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
2344         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
2345         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
2346         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
2347         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
2348         (TestWebKitAPI::GMainLoopSourceTest::finish):
2349         (TestWebKitAPI::GMainLoopSourceTest::source):
2350         (TestWebKitAPI::TEST):
2351
2352 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
2353
2354         Unreviewed, Update my email in contributors.json
2355
2356         * Scripts/webkitpy/common/config/contributors.json:
2357
2358 2014-09-17  Daniel Bates  <dabates@apple.com>
2359
2360         Unreviewed, rolling out r173695.
2361
2362         Broke building third-party Legacy WebKit apps; will
2363         investigate offline
2364
2365         Reverted changeset:
2366
2367         "[iOS] Make WebCore build with public iOS SDK"
2368         https://bugs.webkit.org/show_bug.cgi?id=136487
2369         http://trac.webkit.org/changeset/173695
2370
2371 2014-09-17  Daniel Bates  <dabates@apple.com>
2372
2373         [iOS] Make WebCore build with public iOS SDK
2374         https://bugs.webkit.org/show_bug.cgi?id=136487
2375
2376         Reviewed by David Kilzer.
2377
2378         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
2379
2380         * DumpRenderTree/mac/CheckedMalloc.cpp:
2381
2382 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2383
2384         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
2385         https://bugs.webkit.org/show_bug.cgi?id=136889
2386
2387         Reviewed by Gustavo Noronha Silva.
2388
2389         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2390         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
2391         event was added to the events vector.
2392         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2393         (loadFailedCallback): Do not assume the web view URI is the
2394         failing URI when the load fails before the committed state.
2395         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
2396         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
2397         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
2398         (LoadTrackingTest::loadFailedWithTLSErrors): Add
2399         LoadFailedWithTLSErrors event to the events vector.
2400         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
2401
2402 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
2403
2404         [EFL][GTK] Remove WebKit1 related codes
2405         https://bugs.webkit.org/show_bug.cgi?id=136853
2406
2407         Reviewed by Csaba Osztrogonác.
2408
2409         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
2410         from scripts.
2411
2412         * BuildSlaveSupport/build.webkit.org-config/config.json:
2413         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2414         (Compile32bitJSC):
2415         (BuildAndTestWebKit2Factory):
2416         (CompileWebKit1Only): Deleted.
2417         (CompileWebKit2Only): Deleted.
2418         (BuildAndTestWebKit1OnlyFactory): Deleted.
2419         (BuildAndTestWebKit2OnlyFactory): Deleted.
2420         * Scripts/build-webkit:
2421         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
2422         * Scripts/webkitpy/common/config/ports.py:
2423         (GtkWK2Port.build_webkit_command):
2424         (EflWK2Port.build_webkit_command):
2425         * Scripts/webkitpy/common/config/ports_unittest.py:
2426         (DeprecatedPortTest.test_gtk_wk2_port):
2427         * Scripts/webkitpy/port/efl.py:
2428         (EflPort.build_webkit_command):
2429         * Scripts/webkitpy/port/gtk.py:
2430         (GtkPort._built_libraries_path):
2431         (GtkPort._search_paths):
2432         (GtkPort.test_expectations_file_position):
2433         (GtkPort.build_webkit_command):
2434         (GtkPort.run_webkit_tests_command):
2435         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
2436
2437 2014-09-16  Daniel Bates  <dabates@apple.com>
2438
2439         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
2440         https://bugs.webkit.org/show_bug.cgi?id=136862
2441
2442         Reviewed by David Kilzer.
2443
2444         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2445         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2446         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
2447         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
2448
2449 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2450
2451         Mac queue slaves should reboot every so often
2452         https://bugs.webkit.org/show_bug.cgi?id=136791
2453
2454         Reviewed by Alexey Proskuryakov.
2455
2456         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
2457
2458         * EWSTools/start-queue-mac.sh:
2459
2460 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2461
2462         Unreviewed gardening, skip one more tests on Windows.
2463
2464         * Scripts/run-javascriptcore-tests:
2465
2466 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2467
2468         JSC test gardening
2469         https://bugs.webkit.org/show_bug.cgi?id=136823
2470
2471         Reviewed by Geoffrey Garen.
2472
2473         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
2474
2475 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2476
2477         Remove shouldAbortEarly cruft from master.cfg
2478         https://bugs.webkit.org/show_bug.cgi?id=136779
2479
2480         Reviewed by Csaba Osztrogonác.
2481
2482         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2483         (ConfigureBuild.start):
2484         (RunWebKitTests.start):
2485         (RunWebKit2Tests.start): Deleted.
2486
2487 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2488
2489         Remove ORWT related crufts from webkitdirs.pm
2490         https://bugs.webkit.org/show_bug.cgi?id=136821
2491
2492         Reviewed by Alexey Proskuryakov.
2493
2494         * Scripts/webkitdirs.pm:
2495         (isPerianInstalled): Deleted.
2496         (determineIPhoneSimulatorVersion): Deleted.
2497         (iPhoneSimulatorVersion): Deleted.
2498         (isSnowLeopard): Deleted.
2499         (isLion): Deleted.
2500         (quitIOSSimulator): Deleted.
2501
2502 2014-09-15  Roger Fong  <roger_fong@apple.com>
2503
2504         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
2505         https://bugs.webkit.org/show_bug.cgi?id=25160
2506
2507         * Scripts/run-javascriptcore-tests:
2508
2509 2014-09-15  Lucas Forschler  <lforschler@apple.com>
2510
2511         Add another Apple build slave to the Mountain Lion Debug WK1 queue
2512         
2513         Rubber stamped by Matt Hanson.
2514         
2515         * BuildSlaveSupport/build.webkit.org-config/config.json:
2516
2517 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2518
2519         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
2520         https://bugs.webkit.org/show_bug.cgi?id=136822
2521
2522         Reviewed by Gyuyoung Kim.
2523
2524         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
2525         initialized as we already does it in PlatformWebView::PlatformWebView
2526         calling ewk_init(). The reason for that was to ensure testing for example,
2527         WTF where creating the view is not mandatory.
2528
2529         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
2530         in order to properly initalize and release EWebKit.
2531
2532         * TestWebKitAPI/PlatformEfl.cmake:
2533         * TestWebKitAPI/efl/PlatformWebView.cpp:
2534         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2535         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2536         * TestWebKitAPI/efl/main.cpp:
2537         (main):
2538
2539 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
2540
2541         [WinCairo] Make it easier to enable/disable GStreamer.
2542         https://bugs.webkit.org/show_bug.cgi?id=135766
2543
2544         Reviewed by Brent Fulgham.
2545
2546         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
2547
2548         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
2549
2550 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
2551
2552         Web Inspector: remind about rebaselining generator test results
2553         https://bugs.webkit.org/show_bug.cgi?id=136759
2554
2555         Reviewed by Joseph Pecoraro.
2556
2557         For now, we can implement this as a watchlist message. Add watchlist
2558         groups and messages for the inspector and web replay generators.
2559
2560         * Scripts/webkitpy/common/config/watchlist:
2561
2562 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
2563
2564         build.webkit.org/dashboard: Overlapping text when status is long
2565         https://bugs.webkit.org/show_bug.cgi?id=136794
2566
2567         Reviewed by Timothy Hatcher.
2568
2569         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2570         (.status-line): Replaces height with min-height.
2571
2572 2014-09-12  Timothy Hatcher  <timothy@apple.com>
2573
2574         Make Brian Burg a WebKit reviewer.
2575
2576         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
2577
2578 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
2579
2580         Multiple EWS or commit bots can pick up processing of the same patch
2581         https://bugs.webkit.org/show_bug.cgi?id=136793
2582
2583         Reviewed by Ryosuke Niwa.
2584
2585         Change timeout from one hour to two hours. This will let bots finish, and in the
2586         unlikely event of a bot being frozen, will only delay patch processing restart by
2587         one hour.
2588
2589         * QueueStatusServer/app.yaml:
2590         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
2591
2592 2014-09-11  Andy Estes  <aestes@apple.com>
2593
2594         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
2595         https://bugs.webkit.org/show_bug.cgi?id=136768
2596
2597         Reviewed by Tim Horton.
2598
2599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2600         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
2601         (TestWebKitAPI::TEST):
2602
2603 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2604
2605         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
2606         https://bugs.webkit.org/show_bug.cgi?id=136669
2607
2608         Reviewed by Antti Koivisto.
2609
2610         * Scripts/run-gtk-tests:
2611         (TestRunner): Unskip SSL test.
2612
2613 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
2614
2615         Strip extraneous AVFoundation and CoreMedia logging
2616         https://bugs.webkit.org/show_bug.cgi?id=136747
2617
2618         Reviewed by Jer Noble.
2619
2620         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2621         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
2622
2623         * Scripts/webkitpy/port/base.py:
2624         (Port.stderr_patterns_to_strip): Base class, empty list
2625
2626         * Scripts/webkitpy/port/driver.py:
2627         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
2628
2629         * Scripts/webkitpy/port/ios.py:
2630         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
2631
2632         * Scripts/webkitpy/port/mac.py:
2633         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
2634
2635
2636 2014-09-11  Michael Saboff  <msaboff@apple.com>
2637
2638         lldb_webkit.py:btjs doesn't work with release builds
2639         https://bugs.webkit.org/show_bug.cgi?id=136760
2640
2641         Reviewed by Jer Noble.
2642
2643         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
2644         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
2645         we can't get a valid result from trying either call.  In that case, we fallback to
2646         just showing the PC.  Also added check for both entry points.  If neither is found,
2647         we issue a warning and output the stack trace without JavaScript annotations.
2648
2649         * lldb/lldb_webkit.py:
2650         (btjs):
2651
2652 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
2653
2654         webkitpy test failures from import-w3c-tests
2655         https://bugs.webkit.org/show_bug.cgi?id=136752
2656
2657         Reviewed by Bem Jones-Bey.
2658
2659         This patch fixes a bug in import-w3c-tests where we were appending
2660         the wrong set of files to the copy_list. This also updates the tests
2661         to clear the failures introduced in the patch for bug 135929.
2662
2663         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2664         (W3CTestConverterTest.test_read_prefixed_property_list):
2665         * Scripts/webkitpy/w3c/test_parser.py:
2666         (TestParser.analyze_test):
2667         (TestParser.support_files):
2668         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2669
2670 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
2671
2672         Blink merge: Speculative fix for windows run-webkit-tests hangs
2673         https://bugs.webkit.org/show_bug.cgi?id=136727
2674
2675         Reviewed by Csaba Osztrogonác.
2676
2677         Merged from Blink (patch by Dirk Pranke):
2678         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
2679
2680         * Scripts/webkitpy/common/system/executive.py:
2681         (Executive.kill_process):
2682
2683 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2684
2685         Added myself as a committer.
2686
2687         Unreviewed.
2688
2689         * Scripts/webkitpy/common/config/contributors.json:
2690
2691 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
2692
2693         [JavaScriptCore] Fix FTL on platform EFL.
2694         https://bugs.webkit.org/show_bug.cgi?id=133571
2695
2696         Reviewed by Filip Pizlo.
2697
2698         * efl/install-dependencies: Revert r169181.
2699         * efl/jhbuild.modules: Clone and build a custom branch.
2700         This branch contains some fix for FTL of platform EFL.
2701         The branch is a fork of llvm r206311.
2702
2703 2014-09-10  Tanay C  <tanay.c@samsung.com>
2704
2705         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
2706         https://bugs.webkit.org/show_bug.cgi?id=136698
2707
2708         Reviewed by Gyuyoung Kim.
2709
2710         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
2711         (on_mouse_wheel): Added.
2712         (window_free):
2713         (window_create):
2714
2715 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
2716
2717         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
2718         https://bugs.webkit.org/show_bug.cgi?id=136284
2719
2720         Reviewed by Gyuyoung Kim.
2721
2722         * MiniBrowser/efl/main.c:
2723         (window_create):
2724
2725 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
2726
2727         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
2728         https://bugs.webkit.org/show_bug.cgi?id=135929
2729
2730         Reviewed by Bem Jones-Bey.
2731
2732         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
2733         were made when this script was originally written with respect to relative paths
2734         in ref files. This patch updates import-w3c-tests to update paths in ref files if
2735         they move relative to the test file.
2736
2737
2738         * Scripts/webkitpy/w3c/test_converter.py:
2739         (convert_for_webkit):
2740         (_W3CTestConverter.__init__):
2741         (_W3CTestConverter.convert_reference_relpaths):
2742         (_W3CTestConverter.convert_style_data):
2743         (_W3CTestConverter.convert_attributes_if_needed):
2744         * Scripts/webkitpy/w3c/test_importer.py:
2745         (TestImporter.find_importable_tests):
2746         (TestImporter.import_tests):
2747         * Scripts/webkitpy/w3c/test_parser.py:
2748         (TestParser.load_file):
2749         (TestParser.analyze_test):
2750         (TestParser.support_files):
2751
2752 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2753
2754         [GTK] allow overwriting destination of download
2755         https://bugs.webkit.org/show_bug.cgi?id=136372
2756
2757         Reviewed by Carlos Garcia Campos.
2758
2759         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2760         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
2761         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
2762         (createFileAtDestination): Added
2763         (testDownloadOverwriteDestinationAllowed): Added
2764         (testDownloadOverwriteDestinationDisallowed): Added
2765         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
2766         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
2767         (beforeAll): New tests
2768
2769 2014-08-05  David Farler  <dfarler@apple.com>
2770
2771         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
2772         https://bugs.webkit.org/show_bug.cgi?id=135551
2773
2774         Reviewed by Daniel Bates.
2775
2776         Prevent printing invalid Unicode strings going to stderr.
2777         Also, make filesystem.py more tolerant about receiving
2778         Unicode (encoded as UTF-8) when writing to files, in the
2779         rare case that an NSError description will make it to
2780         stderr, such as -[LTRelayController createUniqueApp].
2781
2782         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2783         (-[LTRelayController launchSimulator]): Removed.
2784         (-[LTRelayController createUniqueApp]):
2785         Don't explicitly try to uninstall the app. It is automatically handled
2786         when installing an app with the same bundle identifier.
2787         (-[LTRelayController start]):
2788         (-[LTRelayController bootDevice]): Removed.
2789         The device already boots as a part of starting the simulator. Attempting
2790         to boot a second time may cause spurious stderr output.
2791         * Scripts/webkitpy/port/driver.py:
2792         (IOSSimulatorDriver._setup_environ_for_driver):
2793         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
2794         Open the iOS Simulator once instead of the LayoutTestRelay trying
2795         to do it.
2796         * Scripts/webkitpy/port/ios.py:
2797         (IOSSimulatorPort._get_crash_log):
2798         Make sure stderr is at least an empty string.
2799         (IOSSimulatorPort):
2800         (IOSSimulatorPort.developer_dir):
2801         New property for setting up DEVELOPER_DIR in the driver environment.
2802
2803 2014-09-09  Dan Bernstein  <mitz@apple.com>
2804
2805         Clean up the MiniBrowser Xcode project
2806         https://bugs.webkit.org/show_bug.cgi?id=136684
2807
2808         Reviewed by Tim Horton.
2809
2810         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
2811         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
2812         WebKit2.framework. Upgraded project file version.
2813
2814 2014-09-09  Daniel Bates  <dbates@webkit.org>
2815
2816         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
2817         https://bugs.webkit.org/show_bug.cgi?id=136379
2818
2819         Reviewed by David Kilzer.
2820
2821         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
2822         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
2823         and sets a property on F (say, the executable bit).
2824
2825         * Scripts/svn-apply:
2826         (patch): Only add file if the diff has text chunks.
2827         * Scripts/svn-unapply:
2828         (patch): Only delete added file if the diff has text chunks.
2829
2830 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2831
2832         [GTK] Unreviewed GTK gardening.
2833
2834         * Scripts/run-gtk-tests:
2835         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
2836
2837 2014-09-09  Christophe Dumez  <cdumez@apple.com>
2838
2839         Update my email in contributors.json
2840         https://bugs.webkit.org/show_bug.cgi?id=136671
2841
2842         Reviewed by Andreas Kling.
2843
2844         * Scripts/webkitpy/common/config/contributors.json:
2845
2846 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2847
2848         [EFL] Enable fixed layout by default
2849         https://bugs.webkit.org/show_bug.cgi?id=136607
2850
2851         Reviewed by Csaba Osztrogonác.
2852
2853         Fixed layout is being used by Tizen platform by default. However, the feature
2854         has still many defects now. So, we need to enable it by default, then should fix
2855         those bugs. 
2856
2857         * MiniBrowser/efl/main.c:
2858
2859 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2860
2861         Remove FILTERS flag
2862         https://bugs.webkit.org/show_bug.cgi?id=136571
2863
2864         Reviewed by Darin Adler.
2865
2866         * Scripts/webkitperl/FeatureList.pm:
2867
2868 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
2869
2870         Dashboard metrics should ignore commits that didn't trigger builds
2871         https://bugs.webkit.org/show_bug.cgi?id=136618
2872
2873         Reviewed by Darin Adler.
2874
2875         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
2876         other platforms etc. It does not make sense to count wait time for these, as it
2877         can be arbitrarily long.
2878
2879         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
2880
2881         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2882         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
2883
2884         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2885         We used to walk the timeline to see which revisions are fully tested, but that's not
2886         correct. A revision that's only tested by a subset of queues finishes independently
2887         of another that's tested by another subset. Now, we just search for the answer for
2888         each revision individually.
2889
2890         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
2891         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
2892         the analyzer now reports. Removed best time, which is more confusing than meaningful.
2893
2894 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2895
2896         Remove EWebLauncher from webkitdirs.pm
2897         https://bugs.webkit.org/show_bug.cgi?id=136622
2898
2899         Reviewed by Gyuyoung Kim.
2900
2901         * Scripts/webkitdirs.pm:
2902         (launcherName):
2903
2904 2014-09-06  Sam Weinig  <sam@webkit.org>
2905
2906         XPCPtr should be converted into an all purpose smart pointer for os_objects
2907         https://bugs.webkit.org/show_bug.cgi?id=136602
2908
2909         Reviewed by Darin Adler.
2910
2911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2912         * TestWebKitAPI/Tests/WTF/darwin: Added.
2913         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
2914         Add basic unit tests for OSObjectPtr.
2915
2916 2014-09-06  Saam Barati  <saambarati1@gmail.com>
2917
2918         Unreviewed. Add myself as a committer.
2919
2920         * Scripts/webkitpy/common/config/contributors.json:
2921
2922 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2923
2924         Unreviewed, EFL build fix when SHARED_CORE is on.
2925
2926         * TestWebKitAPI/PlatformEfl.cmake:
2927
2928 2014-09-05  Lucas Forschler  <lforschler@apple.com>
2929
2930         <https://webkit.org/b/136586> Add bots to Apple build/test queues
2931         
2932         Reviewed by Daniel Bates.
2933
2934         * BuildSlaveSupport/build.webkit.org-config/config.json:
2935
2936 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
2937
2938         Buildbot metrics page gives wrong results after a new bot gets added
2939         https://bugs.webkit.org/show_bug.cgi?id=136516
2940
2941         Reviewed by Tim Horton.
2942
2943         Part 2: Fix elapsed times.
2944
2945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2946         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
2947         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
2948
2949 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2950
2951         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
2952         https://bugs.webkit.org/show_bug.cgi?id=136562
2953
2954         Reviewed by Martin Robinson.
2955
2956         * Scripts/run-gtk-tests:
2957         (TestRunner): Remove failure expectations for tests that now pass.
2958
2959 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
2960
2961         Dashboard metrics page wastes a lot of time sorting iterations
2962         https://bugs.webkit.org/show_bug.cgi?id=136559
2963
2964         Reviewed by Tim Horton.
2965
2966         Also fixes comments here and there, and adds a missing "var".
2967
2968         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2969         (BuildbotIteration.prototype._parseData):
2970         (BuildbotIteration.prototype._updateWithData):
2971         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2972         (BuildbotQueue.prototype.loadAll):
2973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2974         (Analyzer.prototype._countTimes):
2975
2976 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2977
2978         [GTK] Unreviewed GTK gardening.
2979
2980         * Scripts/run-gtk-tests:
2981         (TestRunner): Skip tests failing since r173272.
2982
2983 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
2984
2985         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
2986         https://bugs.webkit.org/show_bug.cgi?id=136561
2987
2988         Reviewed by Tim Horton.
2989         
2990         Log for calloc() and CGBitmapContextCreate() failures.
2991
2992         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2993         (createBitmapContext):
2994         (createBitmapContextFromWebView):
2995
2996 2014-09-04  Andy Estes  <aestes@apple.com>
2997
2998         Fix the Mac Production build after r173283.
2999
3000         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
3001
3002 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
3003
3004         [Win] webkitpy test suite frequently fails to complete
3005         https://bugs.webkit.org/show_bug.cgi?id=136546
3006
3007         Reviewed by Daniel Bates.
3008
3009         Properly convert the ASCII crash log produced by ntsd into
3010         a unicode string as early as possible so that we handle it
3011         properly when generating our logs and other test support output.
3012
3013         We were mixing ASCII/unicode strings under Windows, which was
3014         causing test system failures when we processed some crash logs.
3015
3016         Also do a better job of handling garbage pid entries in the
3017         Cygwin lock files.
3018
3019         * Scripts/webkitpy/common/system/crashlogs.py:
3020         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
3021         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
3022         handle the strings as unicode from that point on.
3023         * Scripts/webkitpy/port/http_lock.py:
3024         (HttpLock._current_lock_pid): Add logging and handle case of
3025         the current_pid failing to cleanly convert to 'int'.
3026         * Scripts/webkitpy/port/win.py:
3027         (WinPort): Add 64-bit architecture as a known target for the
3028         Windows build.
3029
3030 2014-09-04  Andy Estes  <aestes@apple.com>
3031
3032         Address additional review feedback after landing r173283.
3033
3034         Reviewed by Daniel Bates.
3035
3036         * DumpRenderTree/config.h: Removed redundant includes.
3037         * TestWebKitAPI/config.h: Ditto.
3038         * WebKitTestRunner/config.h: Ditto.
3039
3040 2014-09-03  Andy Estes  <aestes@apple.com>
3041
3042         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
3043         https://bugs.webkit.org/show_bug.cgi?id=136521
3044
3045         Reviewed by Anders Carlsson.
3046
3047         * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
3048         * TestWebKitAPI/config.h: Ditto.
3049         * WebKitTestRunner/config.h: Ditto.
3050
3051 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
3052
3053         REGRESSION: Dashboard metrics page aggregation counts performance bots
3054         https://bugs.webkit.org/show_bug.cgi?id=136539
3055
3056         Reviewed by Tim Horton.
3057
3058         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3059
3060 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
3061
3062         [Win] Perl test fix.
3063
3064         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
3065         VersionStamp.exe tool, not just the driver script.
3066
3067 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3068
3069         Remove CSS_FILTERS flag
3070         https://bugs.webkit.org/show_bug.cgi?id=136529
3071
3072         Reviewed by Dirk Schulze.
3073
3074         * Scripts/webkitperl/FeatureList.pm:
3075
3076 2014-09-04  Commit Queue  <commit-queue@webkit.org>
3077
3078         Unreviewed, rolling out r173201.
3079         https://bugs.webkit.org/show_bug.cgi?id=136538
3080
3081         Improves the situation but also introduces additional crashes.
3082         (Requested by zdobersek on #webkit).
3083
3084         Reverted changeset:
3085
3086         "GMainLoopSource is exposed to race conditions"
3087         https://bugs.webkit.org/show_bug.cgi?id=135800
3088         http://trac.webkit.org/changeset/173201
3089
3090 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
3091
3092         Buildbot metrics page gives wrong results after a new bot gets added
3093         https://bugs.webkit.org/show_bug.cgi?id=136516
3094
3095         Part 1: Fix red/green counters. Dashboard is considered green at a given time
3096         if all the bots that ever had results before this time are green.
3097
3098         This doesn't (and cannot) address situations where the bot gets removed and then
3099         re-added. It also gives wrong results after a bot gets removed, because it doesn't
3100         know that it was ever displayed on the dashboard.
3101
3102         Reviewed by Darin Adler.
3103
3104         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3105         (Analyzer.prototype._dashboardIsAllGreen):
3106         (Analyzer.prototype._updateStretchOfRedCounters):
3107         (Analyzer.prototype._countPercentageOfGreen):
3108         (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
3109
3110 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
3111
3112         [Win] Unreviewed test fix.
3113
3114         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
3115         test if user doesn't have the VersionStamp.exe program.
3116
3117 2014-09-03  Dana Burkart  <dburkart@apple.com>
3118
3119         Unreviewed. Add myself as a committer.
3120
3121         * Scripts/webkitpy/common/config/contributors.json:
3122
3123 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
3124
3125         build.webkit.org/dashboard performance popover is unstyled
3126         https://bugs.webkit.org/show_bug.cgi?id=136499
3127
3128         Reviewed by Tim Horton.
3129
3130         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3131         (.performance-popover):
3132         (.performance-popover .dashboard-link):
3133
3134 2014-09-03  Saam Barati  <saambarati1@gmail.com>
3135
3136         Create tests for type profiling
3137         https://bugs.webkit.org/show_bug.cgi?id=136161
3138
3139         Reviewed by Geoffrey Garen.
3140
3141         Have run-javascriptcore-tests run the newly created
3142         tests for the type profiler.
3143
3144         * Scripts/run-javascriptcore-tests:
3145         * Scripts/run-jsc-stress-tests:
3146
3147 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
3148
3149         [Win] Revise test environment for Windows build.
3150         https://bugs.webkit.org/show_bug.cgi?id=136486
3151
3152         Reviewed by David Kilzer.
3153
3154         The various calls to get the Safari path really only have
3155         meaning on the Mac. Other ports get access to the build
3156         and test environment separately, so remove the various
3157         checks in the Safari-specific code to simplify things.
3158
3159         Remove some 64-bit hacks used on Windows now that the
3160         various tools know how to find the 64-bit runtime environment.
3161
3162         * Scripts/run-javascriptcore-tests: 
3163         * Scripts/webkitdirs.pm:
3164         (safariPathFromSafariBundle): Revise to expect Mac.
3165         (installedSafariPath): Ditto.
3166         (safariPath): Ditto.
3167         (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
3168         (setPathForRunningWebKitApp): Get rid of unused SafariPath
3169         argument for Windows runs.
3170
3171 2014-09-03  Dana Burkart  <dburkart@apple.com>
3172
3173         Dashboard should show performance bots.
3174         https://bugs.webkit.org/show_bug.cgi?id=136386
3175
3176         Reviewed by Alexey Proskuryakov.
3177
3178         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3179         (BuildbotIteration.prototype._parseData.collectPerfTestResults):
3180         (BuildbotIteration.prototype._parseData):
3181         Support possible performance failures.
3182
3183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
3184         New QueueView to manage the way we present performance data.
3185
3186         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3187         (BuildbotQueue):
3188         Support new 'performance' and 'performanceTestName' keys.
3189
3190
3191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3192         Add performance column to the main page.
3193
3194         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3195         (WebKitBuildbot):
3196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3197         (body):
3198         Make sure everything fits on 13 inch screens.
3199
3200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3201
3202 2014-09-03  Zan Dobersek  <zdobersek@igalia.com>
3203
3204         GMainLoopSource is exposed to race conditions
3205         https://bugs.webkit.org/show_bug.cgi?id=135800
3206
3207         Reviewed by Carlos Garcia Campos.
3208
3209         Add a unit test for GMainLoopSource that tests different
3210         types of rescheduling tasks on already-active sources.
3211
3212         * TestWebKitAPI/PlatformGTK.cmake:
3213         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
3214         (GMainLoopSourceTest::GMainLoopSourceTest):
3215         (GMainLoopSourceTest::~GMainLoopSourceTest):
3216         (GMainLoopSourceTest::runLoop):
3217         (GMainLoopSourceTest::finish):
3218         (GMainLoopSourceTest::source):
3219         (testGMainLoopSourceBasicRescheduling):
3220         (testGMainLoopSourceReentrantRescheduling):
3221         (testGMainLoopSourceDifferentThreadRescheduling):
3222         (beforeAll):
3223         (afterAll):
3224         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
3225         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
3226         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
3227         (TestWebKitAPI::GMainLoopSourceTest::finish):
3228         (TestWebKitAPI::GMainLoopSourceTest::source):
3229         (TestWebKitAPI::TEST):
3230
3231 2014-09-02  Simon Fraser  <simon.fraser@apple.com>
3232
3233         Make sure WK1 prefs are initialized in MiniBrowser
3234         https://bugs.webkit.org/show_bug.cgi?id=136465
3235
3236         Reviewed by Tim Horton.
3237         
3238         Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
3239         for WK2 windows, to make sure that WebPreferences are updated (to get
3240         layer borders to work consistently).
3241
3242         * MiniBrowser/mac/WK1BrowserWindowController.m:
3243         (-[WK1BrowserWindowController awakeFromNib]):
3244
3245 2014-09-02  Renato Nagy  <rnagy@inf.u-szeged.hu>
3246
3247         check-webkit-style should complain about C++ comments in Platform.h
3248         https://bugs.webkit.org/show_bug.cgi?id=133802
3249
3250         Reviewed by Csaba Osztrogonác.
3251
3252         * Scripts/webkitpy/style/checkers/cpp.py:
3253         (check_platformh_comments):
3254         (_process_lines):
3255         (CppChecker):
3256         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3257         (CppStyleTest.test_platformh_comment):
3258
3259 2014-09-02  Brendan Long  <self@brendanlong.com>
3260
3261         [Gtk] Make install-dependencies work on Arch Linux
3262         https://bugs.webkit.org/show_bug.cgi?id=136374
3263
3264         Reviewed by Philippe Normand.
3265
3266         * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
3267
3268 2014-09-01  Brian J. Burg  <burg@cs.washington.edu>
3269
3270         Provide column numbers to DTrace willExecute/didExecute probes
3271         https://bugs.webkit.org/show_bug.cgi?id=136434
3272
3273         Reviewed by Antti Koivisto.
3274
3275         Create a directory for DTrace scripts. Add an example script that
3276         shows how to use static probes provided by JavaScriptCore's profiler.
3277
3278         * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
3279
3280 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3281
3282         [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
3283         https://bugs.webkit.org/show_bug.cgi?id=136431
3284
3285         Reviewed by Martin Robinson.
3286
3287         * gtk/jhbuild.modules: Disable cairo SVG testsuite.
3288         Add missing dependencies for librsvg (glib and cairo).
3289
3290 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3291
3292         [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
3293         https://bugs.webkit.org/show_bug.cgi?id=136425
3294
3295         Reviewed by Martin Robinson.
3296
3297         * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
3298
3299 2014-09-01  Ryuan Choi  <ryuan.choi@samsung.com>
3300
3301         Update my list of email addresses in contributors.json
3302         https://bugs.webkit.org/show_bug.cgi?id=136424
3303
3304         Reviewed by Gyuyoung Kim.
3305
3306         * Scripts/webkitpy/common/config/contributors.json:
3307
3308 2014-08-30  Filip Pizlo  <fpizlo@apple.com>
3309
3310         [RJST] eager-no-cjit should really mean eager
3311         https://bugs.webkit.org/show_bug.cgi?id=136407
3312
3313         Reviewed by Mark Hahnenberg.
3314         
3315         At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
3316         and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
3317         after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
3318         all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
3319         threshold setting that NO_CJIT_OPTIONS was currently setting
3320         (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
3321         NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
3322         
3323         Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
3324
3325         * Scripts/run-jsc-stress-tests:
3326
3327 2014-08-29  Daniel Bates  <dabates@apple.com>
3328
3329         [iOS] Configure Xcode to build a command line tool for the iOS Simulator
3330         https://bugs.webkit.org/show_bug.cgi?id=136388
3331
3332         Reviewed by David Kilzer.
3333
3334         Add a script, called configure-xcode-for-ios-development, to configure Xcode to
3335         support building a command line tool for the iOS Simulator. You must run this
3336         script as root.
3337
3338         The script uses the xcspec files in the OS X SDK to create xcspec files in the
3339         iOS Simulator SDK with the product- and package- type definitions to build a
3340         command line tool, if applicable.
3341
3342         * Scripts/configure-xcode-for-ios-development: Added.
3343
3344 2014-08-29  Tim Horton  <timothy_horton@apple.com>
3345
3346         Remove Windows WebKit2 code from TestWebKitAPI
3347         https://bugs.webkit.org/show_bug.cgi?id=136385
3348
3349         Reviewed by Alexey Proskuryakov.
3350
3351         * TestWebKitAPI/PlatformUtilities.h:
3352         * TestWebKitAPI/PlatformWebView.h:
3353         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
3354         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3355         (TestWebKitAPI::TEST): Deleted.
3356         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3357         (TestWebKitAPI::TEST):
3358         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3359         (TestWebKitAPI::TEST):
3360         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
3361         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
3362         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
3363         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
3364         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
3365         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
3366         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
3367
3368 2014-08-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3369
3370         [JSC] Some JSC tests are dependent on the machine time zone.
3371         https://bugs.webkit.org/show_bug.cgi?id=136363
3372
3373         Reviewed by Filip Pizlo.
3374
3375         * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
3376         Unskip the tests that were skipped on r99580.
3377
3378 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3379
3380         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
3381         https://bugs.webkit.org/show_bug.cgi?id=135560
3382
3383         Reviewed by Gyuyoung Kim.
3384
3385         * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
3386
3387 2014-08-28  Daniel Bates  <dabates@apple.com>
3388
3389         [Win] update-webkit should update auxiliary libs by default
3390
3391         Reviewed by Dan Bernstein.
3392
3393         The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
3394         from updating the Windows auxiliary libs by default. We should make update-webkit update the
3395         Windows auxiliary libs by default. This will make its behavior match its usage text.
3396
3397         * Scripts/update-webkit:
3398
3399 2014-08-28  Brian J. Burg  <burg@cs.washington.edu>
3400
3401         build-webkit --inspector-frontend tries to copy files from old inspector path
3402         https://bugs.webkit.org/show_bug.cgi?id=136346
3403
3404         Reviewed by Timothy Hatcher.
3405
3406         Remove the old code path for copying inspector resources. It doesn't work.
3407         Complain if this option is passed to CMake-based builds.
3408
3409         * Scripts/build-webkit:
3410         * Scripts/webkitdirs.pm:
3411         (copyInspectorFrontendFiles): Deleted.
3412
3413 2014-08-28  Alexey Proskuryakov  <ap@apple.com>
3414
3415         Dashboard metrics page could show longest stretch of red
3416         https://bugs.webkit.org/show_bug.cgi?id=136334
3417
3418         Reviewed by Sam Weinig.
3419
3420         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3421         (Analyzer.prototype._updateStretchOfRedCounters):
3422         (Analyzer.prototype._countPercentageOfGreen):
3423         When counting percentage of green, also keep track of how long the page was red.
3424
3425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
3426         (MetricsView.prototype._update.addDivider):
3427         (MetricsView.prototype._update.appendQueueResults):
3428         Show it in aggregate queues (can't think of a reason to have it in individual ones).
3429
3430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
3431         Changed to use an explicit divider element between green time and performance groups,
3432         as there are too many combinations to easily express in CSS.
3433
3434 2014-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3435
3436         [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
3437         https://bugs.webkit.org/show_bug.cgi?id=136248
3438
3439         Reviewed by Gustavo Noronha Silva.
3440
3441         Add new test case for webkit_uri_response_get_http_headers().
3442
3443         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3444         (testURIResponseHTTPHeaders):
3445         (serverCallback):
3446         (beforeAll):
3447
3448 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3449
3450         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
3451         https://bugs.webkit.org/show_bug.cgi?id=131668
3452
3453         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3454         (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
3455
3456 2014-08-27  Zalan Bujtas  <zalan@apple.com>
3457
3458         Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
3459         https://bugs.webkit.org/show_bug.cgi?id=136264
3460
3461         Reviewed by Simon Fraser.
3462         
3463         1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
3464         functions. ->snappedIntSize()/snapSizeToDevicePixel().
3465         2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
3466
3467         Covered by existing tests.
3468
3469         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3470         (TestWebKitAPI::TEST): Deleted.
3471
3472 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3473
3474         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
3475         https://bugs.webkit.org/show_bug.cgi?id=131668
3476
3477         Reviewed by Daniel Bates.
3478
3479         We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
3480         to not just hardcode.
3481
3482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3483         (EWS.prototype.queueStatusURL): Added.
3484
3485         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3486         (EWSQueue.prototype.get statusPageURL): Use the above function.
3487         (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
3488
3489         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
3490         (EWSQueueView.prototype.update): While at it, made a popover show up even if there
3491         are no patches in the queue. The popover has other useful information, such as charts
3492         link and bot status.
3493
3494 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3495
3496         https://bugs.webkit.org/show_bug.cgi?id=136317
3497         Dashboard metrics page sometimes shows 0 for best time
3498
3499         Reviewed by Tim Horton.
3500
3501         This also affects regular dashboard display in a good way - iterations that failed
3502         due to infrastructure misbehavior will more reliably show up as yellow and not red.
3503
3504         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3505         (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
3506         updated if we rename steps.
3507         (BuildbotIteration.prototype.get productive): Now that computation is more involved,
3508         do it once.
3509         (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
3510         that failed e.g. at downloading built archive step are not productive.
3511
3512 2014-08-27  Brent Fulgham  <bfulgham@apple.com>
3513
3514         [Win] Unreviewed gardening.
3515
3516         * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
3517         of logs assembled into the final build output.
3518
3519 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
3520
3521         build.webkit.org/dashboard: Add a metrics page with overall bot performance results
3522         https://bugs.webkit.org/show_bug.cgi?id=136196
3523
3524         Reviewed by Timothy Hatcher.
3525
3526         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
3527         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
3528         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
3529         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
3530         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
3531         A date range picker control with dependencies.
3532         There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
3533         - Fixed a bug where selected dates were not at midnight the first time a range was chosen
3534         (it didn't happen again upon re-opening the picker).
3535         - Made made style tweaks to match Dashboard UI.
3536
3537         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3538         Don't create objects that are not needed by the given app, and thus are not loaded at all.
3539
3540         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
3541         Math to count all the things. Only supports open source tree and trunk at the moment,
3542         but written with internal tree and branches in mind.
3543
3544         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
3545         Like dashboard Main.js, draws the UI and creates all necessary objects.
3546
3547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
3548         A view for table cells.
3549
3550         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3551         (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
3552         Metrics page has individual platforms initially scrolled away form the view, so 
3553         it needs to scroll down to reveal what's being configured.
3554
3555         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3556         Added Array.prototype.average and Array.prototype.median.
3557
3558         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3559         Made gear icon fixed instead of absolute, so that it's visible on metrics page when
3560         in settings mode.
3561
3562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
3563         Additional style rules.
3564
3565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
3566         The metrics page.
3567
3568 2014-08-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3569
3570         Remove networkinfo watch category in watchlist
3571         https://bugs.webkit.org/show_bug.cgi?id=136279
3572
3573         Reviewed by Alexey Proskuryakov.
3574
3575         Network info was removed. So, it is not needed anymore.
3576
3577         * Scripts/webkitpy/common/config/watchlist:
3578
3579 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3580
3581         build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
3582         https://bugs.webkit.org/show_bug.cgi?id=136281
3583
3584         Reviewed by Tim Horton.
3585
3586         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3587         Track and expose whether the itertion is being loaded. Made update() a no-op if
3588         the iteration is already being loaded.
3589
3590         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3591         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
3592         loading everything at once, ask the queue to load a little more. We can always repeat
3593         if we still don't have enough data.
3594
3595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3596         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
3597         10 more iterations intelligently.
3598
3599 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3600
3601         build.webkit.org/dashboard raises an exception when Trac RSS fails to load
3602         https://bugs.webkit.org/show_bug.cgi?id=136283
3603
3604         Reviewed by Tim Horton.
3605
3606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3607         Don't.
3608
3609 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
3610
3611         build.webkit.org/dashboard raises an exception after a hidden platform is removed
3612         https://bugs.webkit.org/show_bug.cgi?id=136282
3613
3614         Reviewed by Tim Horton.
3615
3616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3617         (updateHiddenPlatforms): Check that the platform is still valid.
3618
3619 2014-08-26  Matt Lilek  <mrl@apple.com>
3620
3621         Add WebKit SPI to control the navigator.standalone property
3622         https://bugs.webkit.org/show_bug.cgi?id=136189
3623
3624         Reviewed by Andy Estes.
3625
3626         Add API test for WKPreferences
3627
3628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3629         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3630         (TEST):
3631
3632 2014-08-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3633
3634         Remove ENABLE_DRT environment variable to enable SHARED_CORE
3635         https://bugs.webkit.org/show_bug.cgi?id=136205
3636
3637         Reviewed by Andrei Bucur.
3638