2011-04-22 Yi Shen <yi.4.shen@nokia.com>
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-22  Yi Shen  <yi.4.shen@nokia.com>
2
3         Reviewed by Kenneth Rohde Christiansen.
4
5         [Qt] Upstream Symbian platform plugin
6         https://bugs.webkit.org/show_bug.cgi?id=58435
7
8         Exempting directory WebKit/qt/symbian/platformplugin from style guide.
9
10         * Scripts/webkitpy/style/checker.py:
11         * Scripts/webkitpy/style/checker_unittest.py:
12
13 2011-04-22  Balazs Kelemen  <kbalazs@webkit.org>
14
15         Reviewed by Csaba Osztrogonác.
16
17         [Qt][WK2] Qt should use the mac-wk2 skipped list
18         https://bugs.webkit.org/show_bug.cgi?id=58536
19
20         * Scripts/old-run-webkit-tests:
21
22 2011-04-21  Tony Chang  <tony@chromium.org>
23
24         Reviewed by Mihai Parparita.
25
26         Remove find-mismatched-layout-test-results since it's not needed in a
27         checksum free world.
28         https://bugs.webkit.org/show_bug.cgi?id=59156
29
30         * Scripts/find-mismatched-layout-test-results: Removed.
31
32 2011-04-21  Brent Fulgham  <bfulgham@webkit.org>
33
34         Reviewed by Martin Robinson.
35
36         Teach build-webkit and update-webkit that the WinCairo port does
37         not need the non-redistributable WebKitSupportLibraries.zip file.
38         Also append the _Cairo_CFLite label to the build target for the
39         default (no argument) case when building with '--wincairo'
40     
41         https://bugs.webkit.org/show_bug.cgi?id=58801
42
43         * Scripts/build-webkit: Don't die if WebKitSupportLibraries.zip
44           doesn't exist.
45         * Scripts/webkitdirs.pm: Append '_Cairo_CFLite' to the default
46           'Release' build target when passed the '--wincairo' flag.
47         * Scripts/update-webkit: Don't die if WebKitSupportLibraries.zip
48           doesn't exist.
49
50 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
51
52         Reviewed by Eric Seidel.
53
54         new-run-webkit-tests: obsolete old code, part 5: rename message_broker2 to message_broker
55         https://bugs.webkit.org/show_bug.cgi?id=58758
56
57         Since worker_mixin is now only used by worker, there's no point
58         in having it split across two files.
59
60         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
61         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
62         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added
63         * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Removed.
64         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: * Added
65         * Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Removed.
66
67 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
68
69         Reviewed by Tony Chang.
70
71         new-run-webkit-tests: obsolete old code, part 4: merge worker_mixin into worker
72         https://bugs.webkit.org/show_bug.cgi?id=58756
73
74         Since worker_mixin is now only used by worker, there's no point
75         in having it split across two files.
76
77         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
78         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Removed.
79
80 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
81
82         Reviewed by Tony Chang.
83
84         new-run-webkit-tests: obsolete old code, part 3 - rename test_runner to manager
85         https://bugs.webkit.org/show_bug.cgi?id=58754
86
87         test_runner hasn't been a great name for some time, since all of
88         the test running is actually done in worker and
89         single_test_runner. Rename to manager to match the terminology
90         elsewhere.
91
92         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Added.
93         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py: Added.
94         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
95         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: Removed.
96         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py: Removed.
97         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
98
99 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
100
101         Reviewed by Tony Chang.
102
103         new-run-webkit-tests: obsolete old threading code, part 2
104         https://bugs.webkit.org/show_bug.cgi?id=58753
105
106         This merges the test_runner2 code back into test_runner since
107         there's only a single type of test runner now.
108
109         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
110         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: Removed.
111         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
112
113 2011-04-21  Maciej Stachowiak  <mjs@apple.com>
114
115         Reviewed by Adam Roben.
116
117         Add a feature define to allow <details> and <summary> to be disabled
118         https://bugs.webkit.org/show_bug.cgi?id=59118
119         <rdar://problem/9257045>
120
121         * Scripts/build-webkit:
122         * Tools.pro:
123
124 2011-04-21  Adam Barth  <abarth@webkit.org>
125
126         Reviewed by Eric Seidel.
127
128         webkit-patch upload should assign the bug to you
129         https://bugs.webkit.org/show_bug.cgi?id=33699
130
131         This patch only re-assigns the bug if it is currently unassigned.  We
132         can be more aggressive in the future if people want us to be more
133         agressive.
134
135         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
136         * Scripts/webkitpy/tool/commands/upload_unittest.py:
137         * Scripts/webkitpy/tool/mocktool.py:
138         * Scripts/webkitpy/tool/steps/postdiff.py:
139
140 2011-04-21  Ojan Vafai  <ojan@chromium.org>
141
142         Reviewed by Tony Chang.
143
144         move json_results.html over to LayoutTests/fast/harness
145         https://bugs.webkit.org/show_bug.cgi?id=59154
146
147         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
148
149 2011-04-21  Adam Barth  <abarth@webkit.org>
150
151         Reviewed by Eric Seidel.
152
153         ValidateChangeLogs doesn't work on SVN
154         https://bugs.webkit.org/show_bug.cgi?id=59115
155
156         svn-create-patch lies about the diff in the working copy by moving
157         ChangeLog entries to the top of the diff.  That's fine on most cases,
158         but causes problems for ValidateChangeLogs, which is trying validate
159         the where the ChangeLog entry appears.
160
161         I haven't added a test for this change because I couldn't figure out
162         how to write one.  The issue is more of an integration issue, which
163         we're not really set up to test in our unit testing framework.  If this
164         patch had worked around the output from svn-create-patch, then I could
165         have tested that we behave correctly on sample svn-create-patch output,
166         but, in this case, I've removed the dependency on svn-create-patch.  I
167         could test that we behave correctly on "svn diff" output, but we
168         already have those tests.
169
170         * Scripts/webkitpy/tool/commands/download_unittest.py:
171         * Scripts/webkitpy/tool/mocktool.py:
172         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
173
174 2011-04-21  Tony Chang  <tony@chromium.org>
175
176         Reviewed by Ojan Vafai.
177
178         old-run-webkit-tests/new-run-webkit-tests shouldn't read or write .checksum files
179         https://bugs.webkit.org/show_bug.cgi?id=58402
180
181         * Scripts/old-run-webkit-tests: Don't read or write .checksum files.
182         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Don't write .checksum files.
183         * Scripts/webkitpy/layout_tests/port/base.py: Don't read .checksum files.
184         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
185         * Scripts/webkitpy/layout_tests/port/test.py: Update passing pngs to include a checksum.
186         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
187
188 2011-04-21  Ojan Vafai  <ojan@chromium.org>
189
190         Reviewed by Tony Chang.
191
192         final tests for results.html file
193         https://bugs.webkit.org/show_bug.cgi?id=59150
194
195         This gets us close to 100% code coverage. Once this is
196         checked in, I'll move this file over to LayoutTests/fast/harness
197         and make it a proper layout test.
198
199         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
200         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
201
202 2011-04-21  Ojan Vafai  <ojan@chromium.org>
203
204         Reviewed by Tony Chang.
205
206         only expand visible rows
207         https://bugs.webkit.org/show_bug.cgi?id=59130
208
209         For the chromium port, where there are many expected failures,
210         expanding all of them is quite slow. Only expand the visible ones.
211         This makes the default case. Also, make the expanding async to
212         avoid totally killing the process.
213
214         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
215         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
216
217 2011-04-21  Martin Robinson  <mrobinson@igalia.com>
218
219         [GTK] DRT: implement eventSender.scalePageBy
220         https://bugs.webkit.org/show_bug.cgi?id=59082
221
222         Rolling out r84507 since it broke many GTK+ tests.
223
224         * DumpRenderTree/gtk/EventSender.cpp:
225
226 2011-04-21  Sam Weinig  <sam@webkit.org>
227
228         Reviewed by Simon Fraser.
229
230         Add way to garbage collect between each test when running layout tests
231         https://bugs.webkit.org/show_bug.cgi?id=59126
232
233         * DumpRenderTree/mac/DumpRenderTree.mm:
234         (initializeGlobalsFromCommandLineOptions):
235         (runTest):
236         * Scripts/old-run-webkit-tests:
237         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
238         (WTR::InjectedBundle::didReceiveMessage):
239         * WebKitTestRunner/TestController.cpp:
240         (WTR::TestController::TestController):
241         (WTR::TestController::initialize):
242         (WTR::TestController::resetStateToConsistentValues):
243         * WebKitTestRunner/TestController.h:
244
245 2011-04-21  Ojan Vafai  <ojan@chromium.org>
246
247         Reviewed by Mihai Parparita.
248
249         fix another innocuous JS error in expand/collapseAllExpectations
250         https://bugs.webkit.org/show_bug.cgi?id=59122
251
252         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
253         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
254
255 2011-04-20  Ojan Vafai  <ojan@chromium.org>
256
257         Reviewed by Tony Chang.
258
259         put unexpected passes into their own table
260         https://bugs.webkit.org/show_bug.cgi?id=59016
261
262         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
263
264 2011-04-20  Ojan Vafai  <ojan@chromium.org>
265
266         Reviewed by Tony Chang.
267
268         initial set of tests for new results.html file
269         https://bugs.webkit.org/show_bug.cgi?id=59031
270
271         Also, fix the bugs (mostly innocuous JS errors) the tests found.
272
273         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
274         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js: Added.
275
276 2011-04-21  Philippe Normand  <pnormand@igalia.com>
277
278         Reviewed by Martin Robinson.
279
280         [GTK] missing LayoutTestController::callShouldCloseOnWebView()
281         https://bugs.webkit.org/show_bug.cgi?id=59086
282
283         callShouldCloseOnWebView() implementation.
284
285         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
286         (LayoutTestController::callShouldCloseOnWebView):
287
288 2011-04-21  Philippe Normand  <pnormand@igalia.com>
289
290         Reviewed by Martin Robinson.
291
292         [GTK] DRT: implement eventSender.scalePageBy
293         https://bugs.webkit.org/show_bug.cgi?id=59082
294
295         * DumpRenderTree/gtk/EventSender.cpp:
296         (scalePageByCallback): scalePageBy() support.
297
298 2011-04-20  Dominic Cooney  <dominicc@chromium.org>
299
300         Reviewed by Dimitri Glazkov.
301
302         layoutTestController can create and destroy shadow DOM
303         https://bugs.webkit.org/show_bug.cgi?id=59058
304
305         Chromium, Mac, GTK and Qt DRT; and WK2 test runner.
306
307         * DumpRenderTree/LayoutTestController.cpp:
308         (ensureShadowRootCallback):
309         (removeShadowRootCallback):
310         (LayoutTestController::staticFunctions):
311         * DumpRenderTree/LayoutTestController.h:
312         * DumpRenderTree/chromium/LayoutTestController.cpp:
313         (LayoutTestController::LayoutTestController):
314         (LayoutTestController::ensureShadowRoot):
315         (LayoutTestController::removeShadowRoot):
316         * DumpRenderTree/chromium/LayoutTestController.h:
317         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
318         (LayoutTestController::ensureShadowRoot):
319         (LayoutTestController::removeShadowRoot):
320         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
321         (LayoutTestController::shadowRoot):
322         (LayoutTestController::ensureShadowRoot):
323         (LayoutTestController::removeShadowRoot):
324         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
325         (LayoutTestController::ensureShadowRoot):
326         (LayoutTestController::removeShadowRoot):
327         * DumpRenderTree/qt/LayoutTestControllerQt.h:
328         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
329         (LayoutTestController::ensureShadowRoot):
330         (LayoutTestController::removeShadowRoot):
331         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
332         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
333         (WTR::LayoutTestController::shadowRoot):
334         (WTR::LayoutTestController::ensureShadowRoot):
335         (WTR::LayoutTestController::removeShadowRoot):
336         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
337
338 2011-04-20  Dirk Pranke  <dpranke@chromium.org>
339
340         Reviewed by Eric Seidel.
341
342         new-run-webkit-tests: handle ctrl-c more cleanly
343         https://bugs.webkit.org/show_bug.cgi?id=58849
344
345         * Scripts/new-run-webkit-tests:
346         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
347
348 2011-04-20  Sheriff Bot  <webkit.review.bot@gmail.com>
349
350         Unreviewed, rolling out r84431.
351         http://trac.webkit.org/changeset/84431
352         https://bugs.webkit.org/show_bug.cgi?id=59061
353
354         Breaks for folks who don't have editbugs (Requested by abarth
355         on #webkit).
356
357         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
358         * Scripts/webkitpy/tool/commands/upload_unittest.py:
359         * Scripts/webkitpy/tool/mocktool.py:
360         * Scripts/webkitpy/tool/steps/postdiff.py:
361
362 2011-04-20  Leo Yang  <leo.yang@torchmobile.com.cn>
363
364         Unreviewed.
365
366         Adding myself to committers.py.
367
368         * Scripts/webkitpy/common/config/committers.py:
369
370 2011-04-20  Adam Barth  <abarth@webkit.org>
371
372         Reviewed by Eric Seidel.
373
374         webkit-patch upload should assign the bug to you
375         https://bugs.webkit.org/show_bug.cgi?id=33699
376
377         This patch only re-assigns the bug if it is currently unassigned.  We
378         can be more aggressive in the future if people want us to be more
379         agressive.
380
381         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
382         * Scripts/webkitpy/tool/commands/upload_unittest.py:
383         * Scripts/webkitpy/tool/mocktool.py:
384         * Scripts/webkitpy/tool/steps/postdiff.py:
385
386 2011-04-20 Peter Gal <galpeter@inf.u-szeged.hu>
387
388         Reviewed by Csaba Osztrogonác.
389
390         Modify builder.html template to allow easy access
391         to list more builds on the builder's page.
392
393         https://bugs.webkit.org/show_bug.cgi?id=59008
394
395         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
396
397 2011-04-20  Peter Gal  <galpeter@inf.u-szeged.hu>
398
399         Reviewed by Csaba Osztrogonác.
400
401         Add the default template for builder page.
402
403         https://bugs.webkit.org/show_bug.cgi?id=59008
404
405         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html: Added.
406
407 2011-04-20  Ojan Vafai  <ojan@chromium.org>
408
409         Reviewed by Eric Seidel.
410
411         move page generation into a single function
412         https://bugs.webkit.org/show_bug.cgi?id=59027
413
414         Now executing the script doesn't create any state. We should then
415         be able to write tests for this by setting custom results data.
416
417         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
418
419 2011-04-20  Ojan Vafai  <ojan@chromium.org>
420
421         Reviewed by Eric Seidel.
422
423         move global state into a shared object
424         https://bugs.webkit.org/show_bug.cgi?id=59023
425
426         This makes the code more testable.
427
428         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
429
430 2011-04-20  Ojan Vafai  <ojan@chromium.org>
431
432         Reviewed by Tony Chang.
433
434         move global state into a shared object
435         https://bugs.webkit.org/show_bug.cgi?id=59023
436
437         This makes the code more testable.
438
439         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
440
441 2011-04-20  Ojan Vafai  <ojan@chromium.org>
442
443         Reviewed by Eric Seidel.
444
445         add expandAll/collapseAll links
446         https://bugs.webkit.org/show_bug.cgi?id=59011
447
448         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
449
450 2011-04-20  Kevin Ollivier  <kevino@theolliviers.com>
451
452         [wx] Unreviewed build fixes for wx 2.9.1, Cocoa and 64-bit builds.
453
454         * Scripts/webkitdirs.pm:
455         * wx/build/build_utils.py:
456         * wx/build/settings.py:
457         * wx/install-unix-extras:
458         * wx/packaging/build-mac-installer.py:
459         * wx/packaging/build-win-installer.py:
460
461 2011-04-20  Adam Roben  <aroben@apple.com>
462
463         Replace old-run-webkit-tests's win-7 platform with win-7sp0
464
465         It was an error that we had a win-7 platform to begin with. Windows 7 was the most recent
466         version of Windows we cared about, so its results should just go in win. But now that
467         Windows 7 SP1 exists (and has different results for some tests), we need a place to store
468         results for Windows 7 without SP1 (and older versions of Windows).
469
470         Part of <http://webkit.org/b/56617> Several tests fail on Windows 7 SP1 due to font
471         differences from Windows 7 "SP0"
472
473         Reviewed by David Kilzer.
474
475         * Scripts/old-run-webkit-tests: Replaced win-7 with win-7sp0. Newer versions of Windows 7
476         will just use "win".
477
478         * Scripts/webkitdirs.pm:
479         (isWindows7SP0): Added. Replaces isWindows7, because that function had no remaining callers.
480
481 2011-04-20  Adam Roben  <aroben@apple.com>
482
483         Teach webkitdirs::winVersion about build numbers
484
485         The build number isn't currently used, but soon will be.
486
487         As a bonus, winVersion now works on non-Cygwin variants of Perl!
488
489         Fixes <http://webkit.org/b/58991> Need a way to distinguish between Windows 7 and Windows 7
490         SP1
491
492         Reviewed by Anders Carlsson.
493
494         * Scripts/webkitdirs.pm:
495         (isAnyWindows): Added. Returns true if we're running on any Windows-ish Perl.
496         (determineWinVersion): Use `cmd /c ver` to get the version number, including the build
497         number. Parse the version number into a hash, similar to how osXVersion() works.
498
499         (isWindows7):
500         (isWindowsVista):
501         (isWindowsXP):
502         Updated for changes to winVersion().
503
504 2011-04-20  W. James MacLean  <wjmaclean@chromium.org>
505
506         Reviewed by Kenneth Russell.
507
508         Add support for composite-to-texture to DumpRenderTree.
509         https://bugs.webkit.org/show_bug.cgi?id=58675
510
511         * DumpRenderTree/chromium/DumpRenderTree.cpp:
512         (main):
513         * DumpRenderTree/chromium/TestShell.cpp:
514         (TestShell::TestShell):
515         (TestShell::resetWebSettings):
516         * DumpRenderTree/chromium/TestShell.h:
517         (TestShell::setCompositeToTexture):
518         * DumpRenderTree/chromium/WebPreferences.cpp:
519         (WebPreferences::reset):
520         (WebPreferences::applyTo):
521         * DumpRenderTree/chromium/WebPreferences.h:
522
523 2011-04-19  Eric Seidel  <eric@webkit.org>
524
525         Reviewed by Adam Barth.
526
527         The commit-queue is confused when non-layout tests fail
528         https://bugs.webkit.org/show_bug.cgi?id=58955
529
530         As seen in http://queues.webkit.org/results/8474435
531
532         It fails to create an archive of the layout test results
533         and then throws an exception.
534
535         I've fixed this by making it catch the exception as well
536         as made it so it never calls that path in the common case.
537
538         I've updated MockFileSystem to understand rmtree's affect on
539         directories as well as files.
540
541         * Scripts/webkitpy/common/system/filesystem_mock.py:
542         * Scripts/webkitpy/common/system/workspace.py:
543         * Scripts/webkitpy/tool/commands/queues.py:
544         * Scripts/webkitpy/tool/commands/queues_unittest.py:
545         * Scripts/webkitpy/tool/mocktool.py:
546
547 2011-04-19  Ojan Vafai  <ojan@chromium.org>
548
549         Fix check for whether a failure is expected to deal with
550         flaky tests and FAIL expectations.
551         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
552
553 2011-04-19  Ojan Vafai  <ojan@chromium.org>
554
555         Reviewed by Eric Seidel.
556
557         don't show missing text results for tests that only dump image results
558         https://bugs.webkit.org/show_bug.cgi?id=58931
559
560         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
561         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
562
563 2011-04-19  Ojan Vafai  <ojan@chromium.org>
564
565         Reviewed by Eric Seidel.
566
567         don't show failures table if there are only new tests
568         https://bugs.webkit.org/show_bug.cgi?id=58929
569
570         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
571
572 2011-04-19  Ojan Vafai  <ojan@chromium.org>
573
574         Reviewed by Eric Seidel.
575
576         don't show failures table if there are only new tests
577         https://bugs.webkit.org/show_bug.cgi?id=58929
578
579         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
580
581 2011-04-19  Ojan Vafai  <ojan@chromium.org>
582
583         Fix unittest failures from http://trac.webkit.org/changeset/84294.
584
585         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
586         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
587
588 2011-04-18  Ojan Vafai  <ojan@chromium.org>
589
590         Reviewed by Eric Seidel.
591
592         switch new-run-webkit-tests to using the new results file
593         https://bugs.webkit.org/show_bug.cgi?id=58861
594
595         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
596         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
597         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
598
599 2011-04-19  Renata Hodovan  <reni@webkit.org>
600
601         Reviewed by Eric Seidel.
602
603         Move the alignment related macros from Vector.h to new Alignment.h.
604         https://bugs.webkit.org/show_bug.cgi?id=56000
605
606         Adding the new file to the forwarding headers of Tools.
607
608         * DumpRenderTree/ForwardingHeaders/wtf/Alignment.h: Added.
609
610 2011-04-19  Kevin Ollivier  <kevino@theolliviers.com>
611
612         [wx] Unreviewed build fix for Win / wx 2.9 wxPython installation.
613
614         * wx/packaging/build-win-installer.py:
615         * wx/packaging/wxWebKitInstaller.iss.in:
616
617 2011-04-19  Adam Roben  <aroben@apple.com>
618
619         Skip another accelerated-compositing-sensitive test when accelerated compositing is disabled
620
621         * Scripts/old-run-webkit-tests: Skip media/controls-without-preload.html on Windows when
622         accelerated compositing is disabled.
623
624 2011-04-19  Ojan Vafai  <ojan@chromium.org>
625
626         Remove accidentally committed debug code.
627         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
628
629 2011-04-19  Brent Fulgham  <bfulgham@webkit.org>
630
631         Unreviewed build correction.
632
633         Avoid duplicate stub implementation of test routine
634         for WinCairo build.
635
636         * WebKitTestRunner/win/TestInvocationWin.cpp: Exclude
637         WinCairo from using this stub.
638
639 2011-04-18  Ojan Vafai  <ojan@chromium.org>
640
641         Reviewed by Eric Seidel.
642
643         make results file work with audio and reftests
644         https://bugs.webkit.org/show_bug.cgi?id=58860
645
646         Also fix bug with timeout tests and store a bit in the JSON
647         for new image tests instead of loading the image result to check if it's there.
648
649         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
650         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
651
652 2011-04-19  Jer Noble  <jer.noble@apple.com>
653
654         Reviewed by Adam Roben.
655
656         REGRESSION (r84206): 50 tests failing on SnowLeopard Intel Release (WebKit2 Tests) due to extra "supportsFullScreen() == true" output
657         https://bugs.webkit.org/show_bug.cgi?id=58890
658
659         Add a layoutTestController flag which controls when full screen callbacks are written to stdout.
660         Defaults to false.
661
662         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpFullScreenCallbacks().
663         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
664         (WTR::InjectedBundlePage::supportsFullScreen): Only write to stdout if shouldDumpFullScreenCallbacks is set.
665         (WTR::InjectedBundlePage::enterFullScreenForElement): Ditto.
666         (WTR::InjectedBundlePage::exitFullScreenForElement): Ditto.
667         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
668         (WTR::LayoutTestController::LayoutTestController): Initialize new ivar.
669         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
670         (WTR::LayoutTestController::dumpFullScreenCallbacks): Added.
671         (WTR::LayoutTestController::shouldDumpFullScreenCallbacks): Added.
672
673 2011-04-19  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
674
675         Reviewed by Andreas Kling.
676
677         [Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
678         https://bugs.webkit.org/show_bug.cgi?id=35086
679
680         fast/xmlhttprequest/xmlhttprequest-no-file-access.html caused
681         a DRT sideeffect problem, because the resetSettings didn't set
682         the default value of LocalContentCanAccessFileUrls.
683
684         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
685         (WebCore::WebPage::resetSettings):
686
687 2011-04-18  Zan Dobersek  <zandobersek@gmail.com>
688
689         Reviewed by Martin Robinson.
690
691         [GTK] Need support for dumping focus rectangles in pixel results
692         https://bugs.webkit.org/show_bug.cgi?id=53647
693
694         Dump the selection rect if it has been requested.
695
696         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
697         (createBitmapContextFromWebView):
698
699 2011-04-18  Eric Seidel  <eric@webkit.org>
700
701         Reviewed by Adam Barth.
702
703         test-webkitpy should run the ActiveWorkItems tests
704         https://bugs.webkit.org/show_bug.cgi?id=58859
705
706         Also make the unit tests pass. :)
707
708         * QueueStatusServer/model/activeworkitems.py:
709         * QueueStatusServer/model/queue.py:
710         * QueueStatusServer/model/workitems.py:
711
712 2011-04-18  Eric Seidel  <eric@webkit.org>
713
714         Reviewed by Adam Barth.
715
716         queues.webkit.org should show trailing-days pass counts for queues
717         https://bugs.webkit.org/show_bug.cgi?id=58812
718
719         This lets us see if each bot is pulling its own weight or not.
720         Before I wrote this patch our suspicious was that one of the
721         cq bots was doing most of the work.  Turns out they're actually
722         pretty even in their recent pass counts.
723
724         * QueueStatusServer/handlers/queuestatus.py:
725         * QueueStatusServer/index.yaml:
726         * QueueStatusServer/templates/queuestatus.html:
727
728 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
729
730         Reviewed by Eric Seidel.
731
732         new-run-webkit-tests: obsolete old threading code, part 1
733         https://bugs.webkit.org/show_bug.cgi?id=58752
734
735         This patch removes support for the 'old-inline' and
736         'old-threads' worker models, and deletes the corresponding code.
737         Now that the new code is stable, this stuff is no longer
738         necessary.
739
740         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Removed.
741         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
742         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
743         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
744         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
745         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
746
747 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
748
749         Reviewed by Eric Seidel.
750
751         new-run-webkit-tests: add an --additional-drt-flag option
752         https://bugs.webkit.org/show_bug.cgi?id=58680
753
754         NRWT has a bunch of command line flags that exist to pass
755         custom flags to DRT, especially on chromium. It would be nice
756         if there was a generic mechanism to pass through flags so we
757         didn't have all the custom ones.
758
759         * Scripts/webkitpy/layout_tests/port/chromium.py:
760         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
761         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
762         * Scripts/webkitpy/layout_tests/port/test.py:
763         * Scripts/webkitpy/layout_tests/port/webkit.py:
764         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
765
766 2011-04-05  Jer Noble  <jer.noble@apple.com>
767
768         Reviewed by Sam Weinig.
769
770         WebKit2: WKTR should support WebKit2 full screen APIs
771         https://bugs.webkit.org/show_bug.cgi?id=56318
772
773         Respond to enterFullScreenForElement() and exitFullScreenForElement(), allowing 
774         WKTR to test the LayoutTest/fullscreen/ tests.
775
776         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
777         (WTR::InjectedBundlePage::InjectedBundlePage): Add support for WKBundlePageFullScreenClient.
778         (WTR::InjectedBundlePage::supportsFullScreen): Added.
779         (WTR::InjectedBundlePage::enterFullScreenForElement): Added.
780         (WTR::InjectedBundlePage::exitFullScreenForElement): Added.
781         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
782         * WebKitTestRunner/TestController.cpp:
783         (WTR::TestController::resetStateToConsistentValues): Enable the full screen preference.
784
785 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
786
787         Reviewed by Tony Chang.
788
789         new-run-webkit-tests: remove chromium-specific relpath hack for --results-directory
790         https://bugs.webkit.org/show_bug.cgi?id=58388
791
792         * Scripts/webkitpy/layout_tests/port/chromium.py:
793
794 2011-04-18  Evan Martin  <evan@chromium.org>
795
796         Reviewed by Eric Seidel.
797
798         [chromium] expose title direction to webkit client
799         https://bugs.webkit.org/show_bug.cgi?id=58823
800
801         * DumpRenderTree/chromium/LayoutTestController.cpp:
802         (LayoutTestController::LayoutTestController):
803         (LayoutTestController::reset):
804         * DumpRenderTree/chromium/LayoutTestController.h:
805         (LayoutTestController::setTitleTextDirection):
806         Add member and setter to let us stash the title direction at load time.
807
808         * DumpRenderTree/chromium/WebViewHost.cpp:
809         (WebViewHost::didReceiveTitle):
810         * DumpRenderTree/chromium/WebViewHost.h:
811         Adapt to new API; push the title into layoutTestController when we
812         receive it.
813
814 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
815
816         Unreviewed.
817
818         Re-land r84112. It was rolled out in r84127 but it didn't need
819         to be. Only r84111 actually broke things.
820
821         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
822         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
823
824 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
825
826         Reviewed by Tony Chang.
827
828         new-run-webkit-tests: don't run more processes than necessary
829         https://bugs.webkit.org/show_bug.cgi?id=58751
830
831         Previously NRWT would start up 1 process for each processor on
832         the machine by default, which was a waste if we were only
833         running a few shards of tests.
834
835         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
836         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
837         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
838
839 2011-04-18  Ojan Vafai  <ojan@chromium.org>
840
841         Reviewed by Eric Seidel.
842
843         include links to actual.png files for new pixel tests
844         https://bugs.webkit.org/show_bug.cgi?id=58831
845
846         Load image elements to confirm whether the files exist.
847         Image elements will load without being appended to the DOM.
848
849         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
850
851 2011-04-18  Ojan Vafai  <ojan@chromium.org>
852
853         Reviewed by Eric Seidel.
854
855         add a zoomed view for pixel results to the new results html file
856         https://bugs.webkit.org/show_bug.cgi?id=58827
857
858         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
859
860 2011-04-18  Ojan Vafai  <ojan@chromium.org>
861
862         Reviewed by Eric Seidel.
863
864         add labels to results html page
865         https://bugs.webkit.org/show_bug.cgi?id=58803
866
867         -fix iframe size to be the size of the png results
868         -fix a bunch of aesthetic nits
869         -fix some incorrectly styled code
870
871         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
872
873 2011-04-18  Chang Shu  <cshu@webkit.org>
874
875         Reviewed by Eric Seidel.
876
877         WebKitTestRunner needs layoutTestController.pathToLocalResource
878         https://bugs.webkit.org/show_bug.cgi?id=42541
879
880         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
881         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
882         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
883         (WTR::LayoutTestController::pathToLocalResource):
884         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
885         (WTR::LayoutTestController::pathToLocalResource):
886         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
887         (WTR::LayoutTestController::pathToLocalResource):
888
889 2011-04-18  Timothy Hatcher  <timothy@apple.com>
890
891         Make update-webkit-localizable-strings put WebKit/win strings in WebCore
892         now that all localized strings in WebKit/win use WEB_UI_STRING.
893
894         https://webkit.org/b/58747
895
896         Reviewed by Dan Bernstein.
897
898         * Scripts/update-webkit-localizable-strings: Remove the code that updated WebKit/win differently.
899
900 2011-04-18  Patrick Gansterer  <paroga@webkit.org>
901
902         Reviewed by Adam Roben.
903
904         [WIN] Use WCHAR instead of TCHAR
905         https://bugs.webkit.org/show_bug.cgi?id=58755
906
907         We always use the UNICODE versions of windows functions, so
908         the usage of TCHAR makes no sense and mixing them is bad style.
909
910         * WinLauncher/PrintWebUIDelegate.cpp:
911           Also fix various style issues (including indentation and removal of ugly C-casts).
912         * WinLauncher/WinLauncher.cpp:
913
914 2011-04-18  Dominic Cooney  <dominicc@chromium.org>
915
916         Reviewed by Andreas Kling.
917
918         Add layoutTestController.shadowRoot to Qt DRT.
919         https://bugs.webkit.org/show_bug.cgi?id=58759
920
921         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
922         (LayoutTestController::shadowRoot): Added.
923         * DumpRenderTree/qt/LayoutTestControllerQt.h:
924
925 2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
926
927         Unreviewed, rolling out r84111.
928         http://trac.webkit.org/changeset/84111
929         https://bugs.webkit.org/show_bug.cgi?id=58771
930
931         Chromium linux layout tests are broken. (Requested by loislo2
932         on #webkit).
933
934         * Scripts/webkitpy/layout_tests/port/chromium.py:
935         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
936         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
937
938 2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
939
940         Unreviewed, rolling out r84112.
941         http://trac.webkit.org/changeset/84112
942         https://bugs.webkit.org/show_bug.cgi?id=58770
943
944         Chromium linux layout tests are broken. (Requested by loislo2
945         on #webkit).
946
947         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
948         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
949
950 2011-04-17  Daniel Bates  <dbates@webkit.org>
951
952         Reviewed by Eric Seidel and Adam Barth.
953
954         webkit-patch land hangs if svn prompts for credentials
955         https://bugs.webkit.org/show_bug.cgi?id=31500
956
957         Prompt for username and password when using git-svn and there aren't cached SVN credentials.
958
959         * Scripts/webkitpy/common/checkout/scm.py:
960           - Added mixin class SVNRepository and made both class SVN and Git inherit from it.
961           - Moved SVN.has_authorization_for_realm() to class SVNRepository and removed default value
962             for argument realm; modified call sites as needed.
963           - Modified AuthenticationError constructor to take optional prompt_for_password argument.
964           - Modified {SCM, SVN, Git}.commit_with_message() to take optional password argument.
965           - Modified Git._commit_on_branch() to take optional username and password argument.
966           - Modified Git.push_local_commits_to_server() to take optional username and password
967             argument and to call has_authorization_for_realm().
968         * Scripts/webkitpy/common/checkout/scm_unittest.py:
969           - Modified SVNTest.test_commit_without_authorization() to take dummy realm argument.
970           - Modified SVNTest.test_not_have_authorization_for_realm() to pass realm argument to
971             SVN.has_authorization_for_realm().
972         * Scripts/webkitpy/common/net/credentials.py:
973           - Modified Credentials.read_credentials() to call User.prompt_password() instead
974             of using getpass.getpass() directly.
975         * Scripts/webkitpy/common/system/user.py:
976           - Added User.prompt_password().
977         * Scripts/webkitpy/tool/steps/commit.py:
978           - Modified Commit.run() to prompt for a password if needed.
979
980 2011-04-17  Dirk Pranke  <dpranke@chromium.org>
981
982         Reviewed by Ojan Vafai.
983
984         new-run-webkit-tests: save stderr into the layout-test-results dir
985         https://bugs.webkit.org/show_bug.cgi?id=58690
986
987         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
988         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
989
990 2011-04-17  Dirk Pranke  <dpranke@chromium.org>
991
992         Reviewed by Ojan Vafai.
993
994         new-run-webkit-tests: read stderr from chromium DRT separately
995         https://bugs.webkit.org/show_bug.cgi?id=58708
996
997         * Scripts/webkitpy/layout_tests/port/chromium.py:
998         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
999         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1000
1001 2011-04-17  Patrick Gansterer  <paroga@webkit.org>
1002
1003         Reviewed by Adam Barth.
1004
1005         Rename PLATFORM(CA) to USE(CA)
1006         https://bugs.webkit.org/show_bug.cgi?id=58742
1007
1008         * DumpRenderTree/mac/DumpRenderTree.mm:
1009         (resetDefaultsToConsistentValues):
1010
1011 2011-04-17  Patrick Gansterer  <paroga@webkit.org>
1012
1013         Reviewed by Adam Barth.
1014
1015         Rename PLATFORM(CG) to USE(CG)
1016         https://bugs.webkit.org/show_bug.cgi?id=58729
1017
1018         * DumpRenderTree/PixelDumpSupport.cpp:
1019         * DumpRenderTree/chromium/WebViewHost.cpp:
1020         (WebViewHost::paintRect):
1021         * DumpRenderTree/config.h:
1022         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1023         (createBitmapContextFromWebView):
1024         * TestWebKitAPI/PlatformWebView.h:
1025         * WebKitTestRunner/config.h:
1026         * WebKitTestRunner/win/TestInvocationWin.cpp:
1027
1028 2011-04-16  Patrick Gansterer  <paroga@webkit.org>
1029
1030         Reviewed by Eric Seidel.
1031
1032         Rename PLATFORM(CAIRO) to USE(CAIRO)
1033         https://bugs.webkit.org/show_bug.cgi?id=55192
1034
1035         * DumpRenderTree/PixelDumpSupport.cpp:
1036         * DumpRenderTree/config.h:
1037         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1038         (createBitmapContextFromWebView):
1039         * WebKitTestRunner/config.h:
1040
1041 2011-04-16  Ojan Vafai  <ojan@chromium.org>
1042
1043         Reviewed by Eric Seidel.
1044
1045         show diffs+test inline in the results page
1046         https://bugs.webkit.org/show_bug.cgi?id=58723
1047         
1048         Put each row in it's own tbody and sort based on tbodies. That way
1049         we can append the results to the tbody inline as another table row.
1050
1051         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1052
1053 2011-04-16  Ojan Vafai  <ojan@chromium.org>
1054
1055         Reviewed by Eric Seidel.
1056
1057         handle new tests in the new results html file
1058         https://bugs.webkit.org/show_bug.cgi?id=58715
1059
1060         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1061
1062 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
1063
1064         Reviewed by Ojan Vafai.
1065
1066         old-run-webkit-tests: save the list of tests actually run to a file
1067         https://bugs.webkit.org/show_bug.cgi?id=58692
1068
1069         * Scripts/old-run-webkit-tests:
1070
1071 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
1072
1073         Reviewed by Ojan Vafai.
1074
1075         fix MockFileSystem.abspath() on windows
1076         https://bugs.webkit.org/show_bug.cgi?id=58713
1077
1078         The existing code was borked on Windows if a path was passed
1079         in using a drive letter (e.g., "d:\foo.txt"), and would go
1080         into an infinite recursive loop. While win paths shouldn't
1081         normally be passed into the mock filesystem, this just
1082         bulletproofs things a bit (note that "/foo.txt" is considered
1083         an absolute path on windows python as well.
1084
1085         * Scripts/webkitpy/common/system/filesystem_mock.py:
1086
1087 2011-04-15  Ojan Vafai  <ojan@chromium.org>
1088
1089         Reviewed by Eric Seidel.
1090
1091         show stderr files and httpd log files
1092         https://bugs.webkit.org/show_bug.cgi?id=58714
1093
1094         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1095         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1096
1097 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
1098
1099         Reviewed by James Robinson.
1100
1101         Add a flag to guard Page Visibility API changes.
1102         https://bugs.webkit.org/show_bug.cgi?id=58464
1103
1104         * Scripts/build-webkit:
1105
1106 2011-04-15  Chang Shu  <cshu@webkit.org>
1107
1108         Reviewed by Alexey Proskuryakov.
1109
1110         When a message with url embedded is added to console, the "file:" scheme
1111         and path should be stripped.
1112         https://bugs.webkit.org/show_bug.cgi?id=58665
1113
1114         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1115         (WTR::lastFileURLPathComponent):
1116         (WTR::InjectedBundlePage::willAddMessageToConsole):
1117
1118 2011-04-15  Jeff Miller  <jeffm@apple.com>
1119
1120         Reviewed by Sam Weinig.
1121
1122         Add takeFocus callback to WKPageUIClient
1123         https://bugs.webkit.org/show_bug.cgi?id=58686
1124
1125         Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner.
1126
1127         * MiniBrowser/mac/BrowserWindowController.m:
1128         (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry.
1129         * MiniBrowser/win/BrowserView.cpp:
1130         (BrowserView::create): Added empty takeFocus entry.
1131         * WebKitTestRunner/TestController.cpp:
1132         (WTR::TestController::createOtherPage): Added empty takeFocus entry.
1133         (WTR::TestController::initialize): Added empty takeFocus entry.
1134
1135 2011-04-15  Ojan Vafai  <ojan@chromium.org>
1136
1137         Reviewed by Eric Seidel.
1138
1139         only show pretty-diff/wdiff if they were generated
1140         https://bugs.webkit.org/show_bug.cgi?id=58682
1141
1142         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1143         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1144         * Scripts/webkitpy/layout_tests/port/base.py:
1145
1146 2011-04-15  Andreas Kling  <kling@webkit.org>
1147
1148         Reviewed by Antonio Gomes.
1149
1150         [Qt] DRT: Default custom policy delegate decision should be Ignore.
1151
1152         If layoutTestController.setCustomPolicyDelegate() is called with only
1153         one argument, the second ("permissive") should default to false.
1154
1155         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1156
1157 2011-04-15  Ojan Vafai  <ojan@chromium.org>
1158
1159         Reviewed by Eric Seidel.
1160
1161         fix path to layout test in new results file
1162         https://bugs.webkit.org/show_bug.cgi?id=58618
1163
1164         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1165         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1166
1167 2011-04-15  Ojan Vafai  <ojan@chromium.org>
1168
1169         Reviewed by Eric Seidel.
1170
1171         fix sorting in new results file
1172         https://bugs.webkit.org/show_bug.cgi?id=58616
1173
1174         -Fix the custom sort to return -1, 0, 1 instead of true/false.
1175         -Secondary sort by test name when sort values are equal.
1176         -Sort by test name by default.
1177
1178         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1179
1180 2011-04-15  Dmitry Lomov  <dslomov@google.com>
1181
1182         Reviewed by David Levin.
1183
1184         check-webkit-style shouldn't complain about not including a primary header file 
1185         if none exists
1186         https://bugs.webkit.org/show_bug.cgi?id=39514
1187
1188         * Scripts/webkitpy/style/checkers/cpp.py:
1189         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1190
1191 2011-04-15  Eric Seidel  <eric@webkit.org>
1192
1193         Reviewed by Mihai Parparita.
1194
1195         queues.webkit.org should display when a bot last rebooted
1196         https://bugs.webkit.org/show_bug.cgi?id=58562
1197
1198         There is more repeated code here than I would like.  I fear
1199         my django-fu isn't quite up to snuff.
1200
1201         * QueueStatusServer/handlers/queuestatus.py:
1202         * QueueStatusServer/templates/queuestatus.html:
1203
1204 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
1205
1206         Reviewed by Adam Barth.
1207
1208         Remove dependency on chromium skia::PlatformCanvas
1209         https://bugs.webkit.org/show_bug.cgi?id=57563
1210         
1211         Fixed compile error on Mac when using Core Graphics.
1212
1213         * DumpRenderTree/chromium/WebViewHost.cpp:
1214         (WebViewHost::paintRect):
1215
1216 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
1217
1218         Reviewed by James Robinson.
1219
1220         Remove dependency on chromium skia::PlatformCanvas
1221         https://bugs.webkit.org/show_bug.cgi?id=57563
1222
1223         * DumpRenderTree/chromium/TestShell.cpp:
1224         (makeCanvasOpaque):
1225         (TestShell::dumpImage):
1226         * DumpRenderTree/chromium/TestShell.h:
1227         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1228         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1229         (WebThemeControlDRTWin::draw):
1230         (WebThemeControlDRTWin::drawTextField):
1231         (WebThemeControlDRTWin::drawProgressBar):
1232         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1233         * DumpRenderTree/chromium/WebViewHost.cpp:
1234         (WebViewHost::canvas):
1235         * DumpRenderTree/chromium/WebViewHost.h:
1236
1237 2011-04-14  Keith Kyzivat  <keith.kyzivat@nokia.com>
1238
1239         Reviewed by Laszlo Gombos.
1240
1241         [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser
1242         https://bugs.webkit.org/show_bug.cgi?id=58007
1243
1244         Adds flag to start the test browsers maximized.
1245         Symbian started maximized on QtTestBrowser - made MiniBrowser follow
1246         suit.
1247         Also fixes some ToggleFullScreen issues so that prior window state is
1248         restored.
1249
1250         * MiniBrowser/qt/BrowserWindow.cpp:
1251         (BrowserWindow::BrowserWindow):
1252         (BrowserWindow::toggleFullScreenMode):
1253         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1254         (MiniBrowserApplication::handleUserOptions):
1255         * MiniBrowser/qt/MiniBrowserApplication.h:
1256         (WindowOptions::WindowOptions):
1257         * QtTestBrowser/launcherwindow.cpp:
1258         (LauncherWindow::init):
1259         (LauncherWindow::toggleFullScreenMode):
1260         * QtTestBrowser/launcherwindow.h:
1261         (WindowOptions::WindowOptions):
1262         * QtTestBrowser/main.cpp:
1263         (LauncherApplication::handleUserOptions):
1264
1265 2011-04-14  Ojan Vafai  <ojan@chromium.org>
1266
1267         Reviewed by Eric Seidel.
1268
1269         add checkbox to only show unexpected results to new results file
1270         https://bugs.webkit.org/show_bug.cgi?id=58606
1271
1272         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1273
1274 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
1275
1276         Reviewed by Martin Robinson.
1277
1278         [WinCairo] Implement ImageDiff Logic.
1279         http://bugs.webkit.org/show_bug.cgi?id=58486
1280
1281         * DumpRenderTree/win/ImageDiffCairo.cpp: Added.
1282         (strtof):
1283         (readFromData):
1284         (createImageFromStdin):
1285         (releaseMallocBuffer):
1286         (createDifferenceImage):
1287         (imageHasAlpha):
1288         (writeToData):
1289         (main):
1290         * DumpRenderTree/win/ImageDiff.vcproj: Updated for new
1291           ImageDiffCairo.cpp (excluding from Apple builds).
1292         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Use
1293           new ImageDiffWinCairoCommon.vsprops file.
1294         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Use
1295           new ImageDiffWinCairoCommon.vsprops file.
1296         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added.
1297         * Scripts/old-run-webkit-tests: Make sure proper executable
1298           is built and executed for WinCairo port.
1299
1300 2011-04-14  Ojan Vafai  <ojan@chromium.org>
1301
1302         Reviewed by Eric Seidel.
1303
1304         only show expected failure type for ports that use an expectations file
1305         https://bugs.webkit.org/show_bug.cgi?id=58588
1306
1307         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1308         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1309
1310 2011-04-14  Eric Seidel  <eric@webkit.org>
1311
1312         Reviewed by Adam Barth.
1313
1314         commit-queue fails to catch IOError when results.html is missing
1315         https://bugs.webkit.org/show_bug.cgi?id=58589
1316
1317         * Scripts/webkitpy/tool/commands/queues.py:
1318         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1319
1320 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
1321
1322         [wx] Unreviewed build fix for Mac installation script.
1323
1324         * wx/packaging/build-mac-installer.py:
1325
1326 2011-04-14  Ojan Vafai  <ojan@chromium.org>
1327
1328         Reviewed by Tony Chang.
1329
1330         sort columns in the new json_results.html file
1331         https://bugs.webkit.org/show_bug.cgi?id=58581
1332
1333         Also fix padding on TDs and the path to layout tests.
1334
1335         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1336
1337 2011-04-14  Eric Seidel  <eric@webkit.org>
1338
1339         Reviewed by Dimitri Glazkov.
1340
1341         queues.webkit.org should display when a bot last passed a patch
1342         https://bugs.webkit.org/show_bug.cgi?id=58546
1343
1344         I am suspicious that some of our commit-queue instances are never
1345         actually passing anything.
1346
1347         This will let us know if those bots are never passing patches.
1348
1349         * QueueStatusServer/handlers/queuestatus.py:
1350         * QueueStatusServer/index.yaml:
1351         * QueueStatusServer/templates/queuestatus.html:
1352
1353 2011-04-14  Dirk Pranke  <dpranke@chromium.org>
1354
1355         Reviewed by Adam Roben.
1356
1357         REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
1358         https://bugs.webkit.org/show_bug.cgi?id=58545
1359
1360         Remove platform-specific overrides; the default behavior should
1361         be working everywhere now, I think.
1362
1363         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1364         * Scripts/webkitpy/layout_tests/port/mac.py:
1365
1366 2011-04-14  Eric Seidel  <eric@webkit.org>
1367
1368         Reviewed by Adam Barth.
1369
1370         commit-queues are hitting an exception trying to land when the tree is red
1371         https://bugs.webkit.org/show_bug.cgi?id=58558
1372
1373         Just an un-tested (and thus broken) code path from yesterday's changes.
1374
1375         * Scripts/webkitpy/common/net/layouttestresults.py:
1376         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1377         * Scripts/webkitpy/tool/commands/queues.py:
1378         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1379
1380 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
1381
1382         [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
1383
1384         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1385         (LayoutTestController::shadowRoot):
1386         * wx/build/wxpresets.py:
1387
1388 2011-04-14  Victoria Kirst  <vrk@google.com>
1389
1390         Reviewed by James Robinson.
1391
1392         [chromium] Failing GPU video tests
1393         https://bugs.webkit.org/show_bug.cgi?id=57926
1394
1395         Added/updated GPU directory names for rebaseline tool.
1396
1397         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1398
1399 2011-04-13  Daniel Bates  <dbates@rim.com>
1400
1401         Reviewed by Adam Barth.
1402
1403         Perl unit test removeEOL.pl should print test case name on failure
1404         https://bugs.webkit.org/show_bug.cgi?id=58513
1405
1406         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as
1407           second argument of Test::Simple::ok().
1408
1409 2011-04-13  Kent Tamura  <tkent@chromium.org>
1410
1411         Reviewed by Eric Seidel.
1412
1413         gdb-safari should pass arguments to safari.
1414         https://bugs.webkit.org/show_bug.cgi?id=58439
1415
1416         We can do:
1417           gdb-safari --debug LayoutTests/.../foo.html
1418
1419         * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
1420
1421 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1422
1423         Unreviewed, build fix.
1424         https://bugs.webkit.org/show_bug.cgi?id=52763
1425
1426         r83799 broke test-webkitpy because it assumed we always have
1427         access to a real filesystem (we don't during the unit tests).
1428         Stubbing out the copy for now but we might need a better
1429         solution at some point.
1430
1431         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1432
1433 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1434
1435         Reviewed by Tony Chang.
1436
1437         new-run-webkit-tests --run-singly option is busted
1438         https://bugs.webkit.org/show_bug.cgi?id=55909
1439
1440         Python's broken lexical scoping strikes again :(.
1441
1442         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
1443         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1444
1445 2011-04-13  Ojan Vafai  <ojan@chromium.org>
1446
1447         Reviewed by Eric Seidel.
1448
1449         generated unexpected_results.html from unexpected_results.json
1450         https://bugs.webkit.org/show_bug.cgi?id=52763
1451
1452         Eventually, we'll merge this with results.html and have a single richer results page.
1453         For now, I just want to get something checked in that we can iterate on.
1454
1455         * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
1456         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1457
1458 2011-04-13  Eric Seidel  <eric@webkit.org>
1459
1460         Reviewed by Adam Barth.
1461
1462         Up the failure limit to allow the commit-queue to actually land when the tree is red
1463         https://bugs.webkit.org/show_bug.cgi?id=58499
1464
1465         This change increases the --exit-after-N-failures limit used by the commit-queue
1466         from 1 to 10.  This will cause the code added in bug 58494 to actually get
1467         exercised and the queues should start being able to land when the trees are red.
1468
1469         When testing I found that test_runtests_leopard_commit_queue_hack_command was the
1470         only unit test to actually detect this change!  Since we don't actually
1471         run on leopard anymore, I removed the hack code and repurposed the test.
1472
1473         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1474         * Scripts/webkitpy/tool/steps/runtests.py:
1475         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1476
1477 2011-04-13  Eric Seidel  <eric@webkit.org>
1478
1479         Reviewed by Adam Barth.
1480
1481         commit-queue should be able to land when tree is red
1482         https://bugs.webkit.org/show_bug.cgi?id=58494
1483
1484         There is some yak hair on my hands, I will admit.
1485
1486         This change is mostly about adding an ExpectedFailures
1487         class to track when the bots are red and we should be
1488         ignoring failures when landing from the commit-queue.
1489
1490         However, to make intelligent decisions about patches we
1491         need to know whether the run hit the --exit-after-N-failures limit
1492         or not.  Right now that information is not saved off in results.html
1493         so we have to pull the information from RunTests.
1494
1495         I've plumbed the --exit-after-N-failures information into
1496         LayoutTestResults for now to make the ExpectedFailures code cleaner.
1497
1498         As a result of adding all these additional calls to delegate.layout_test_results()
1499         I broke some of our flaky test detection tests and had to re-write them
1500         to not depend on the number of layout_test_results code.
1501
1502         At the same time I updated the commit-queue to use the newer filesystem
1503         API (to allow us to use MockFileSystem) which required further changes
1504         to the layout tests.  Changes were required in either case, since
1505         we're now calling layout_test_results() in more cases, which previously
1506         would try and hit the disk (until I moved it to use tool.filesystem).
1507
1508         I should note that *all* of this code is disabled for now, since our
1509         --exit-after-N-failures limit is currently 1!  (Thus were always in the
1510         case where we can't actually tell if the layout test results are legit.)
1511         I will up that limit in a second patch (which may require a couple more unit test tweaks).
1512
1513         * Scripts/webkitpy/common/net/layouttestresults.py:
1514         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1515         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1516         * Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
1517         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
1518         * Scripts/webkitpy/tool/commands/queues.py:
1519         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1520         * Scripts/webkitpy/tool/commands/queuestest.py:
1521         * Scripts/webkitpy/tool/steps/runtests.py:
1522
1523 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
1524
1525         Unreviewed build correction.
1526
1527         * TestWebKitAPI/PlatformWebView.h: Limit include of
1528           <CoreGraphics/CGGeometry> to PLATFORM(CG) users.
1529
1530 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
1531
1532         Reviewed by Eric Seidel.
1533
1534         [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
1535         https://bugs.webkit.org/show_bug.cgi?id=58489
1536         
1537         r83743 added --additional-platform-directory to old-run-webkit-tests,
1538         rename the equivalent flag in new-run-webkit-tests to be consistent.
1539
1540         * Scripts/webkitpy/layout_tests/port/base.py:
1541         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1542         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1543         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1544
1545 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
1546
1547         Reviewed by Eric Seidel.
1548
1549         Rebaseline queue server
1550         https://bugs.webkit.org/show_bug.cgi?id=57891
1551
1552         Adds a simple rebaseline queue server (meant to run at
1553         http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
1554         builders and their failing tests, and allows those tests to be added to
1555         a per-builer rebaseline queue.
1556
1557         A subsequent change will add a mode to NRWT (and/or a wrapper script)
1558         for pulling the tests to be rebaselined from the server and running them
1559         with --reset-results (the initial use-case is for the GPU hardware bots,
1560         which do not have checked-in baselines, therefore there is no need for a
1561         check-in step yet).
1562
1563         * RebaselineQueueServer/app.yaml: Added.
1564         * RebaselineQueueServer/handlers/__init__.py: Added.
1565         * RebaselineQueueServer/handlers/builderqueue.py: Added.
1566         * RebaselineQueueServer/handlers/pages.py: Added.
1567         * RebaselineQueueServer/index.yaml: Added.
1568         * RebaselineQueueServer/main.py: Added.
1569         * RebaselineQueueServer/model/__init__.py: Added.
1570         * RebaselineQueueServer/model/queueentry.py: Added.
1571         * RebaselineQueueServer/static/builder-frame-empty.html: Added.
1572         * RebaselineQueueServer/static/styles.css: Added.
1573         * RebaselineQueueServer/templates/builder-picker.html: Added.
1574         * RebaselineQueueServer/templates/builder-queue-edit.html: Added.
1575         * RebaselineQueueServer/templates/builder-queue-list.html: Added.
1576         * RebaselineQueueServer/templates/home.html: Added.
1577
1578 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1579
1580         Reviewed by Mihai Parparita.
1581
1582         nrwt: enable multiple processes by default on Chromium Win.
1583         https://bugs.webkit.org/show_bug.cgi?id=55163
1584
1585         Re-land r79268; it should be more stable now and will hopefully
1586         work.
1587
1588         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1589         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1590
1591 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1592
1593         Reviewed by Ojan Vafai.
1594
1595         new-run-webkit-tests: configure logging in child processes properly
1596         https://bugs.webkit.org/show_bug.cgi?id=58296
1597
1598         Logging propagated properly from manager to worker processes on
1599         Unix but not on Windows; this fixes that.
1600
1601         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1602         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
1603
1604 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1605
1606         Reviewed by Ojan Vafai.
1607
1608         new-run-webkit-tests: suppress extraneous pretty patch warnings
1609         https://bugs.webkit.org/show_bug.cgi?id=58295
1610
1611         NRWT wasn't being careful about when it logged messages from
1612         PrettyPatch not being available; it should only log during
1613         check_build(), and be silent otherwise. This was causing us to
1614         get multiple errors at runtime, which was confusing.
1615
1616         * Scripts/webkitpy/layout_tests/port/base.py:
1617         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1618         * Scripts/webkitpy/layout_tests/port/chromium.py:
1619
1620 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1621
1622         Reviewed by Jian Li.
1623
1624         add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
1625         https://bugs.webkit.org/show_bug.cgi?id=58461
1626
1627         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1628
1629 2011-04-13  Tony Chang  <tony@chromium.org>
1630
1631         Unreviewed, fix NRWT.  Stack:
1632
1633             return super(ChromiumPort, self).results_directory(self)
1634         TypeError: results_directory() takes exactly 1 argument (2 given)
1635
1636         * Scripts/webkitpy/layout_tests/port/chromium.py:
1637
1638 2011-04-13  Adam Roben  <aroben@apple.com>
1639
1640         Teach ORWT about extra platform-specific directories to be searched before the default ones
1641
1642         Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
1643         platform-specific results
1644
1645         Reviewed by Anders Carlsson.
1646
1647         * Scripts/old-run-webkit-tests:
1648         (top-level): Added @additionalPlatformDirectories and hooked up
1649         --additional-platform-directories to populate it.
1650         (buildPlatformResultHierarchy): Prepend the additional platform directories to the default
1651         list (after filtering out any of the additional directories that don't exist).
1652
1653 2011-04-13  Lucas Forschler  <lforschler@apple.com>
1654
1655         Reviewed by Adam Roben.
1656
1657         Add the /T command to taskkill.exe.
1658         This will kill spawned child processes.
1659         
1660         * BuildSlaveSupport/win/kill-old-processes:
1661
1662 2011-04-13  Lucas Forschler  <lforschler@apple.com>
1663
1664         Reviewed by Adam Roben.
1665
1666         Sort kill list alphabeticaly.
1667         Fixed capitalization on VcBuildHelper.  
1668
1669         * BuildSlaveSupport/win/kill-old-processes:
1670
1671 2011-04-13  Lucas Forschler  <lforschler@apple.com>
1672
1673         Reviewed by Adam Roben.
1674
1675         https://bugs.webkit.org/show_bug.cgi?id=58384
1676         Update kill-old-processes to include a few new ones.
1677         
1678         * BuildSlaveSupport/win/kill-old-processes:
1679
1680 2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>
1681
1682         Reviewed by Martin Robinson.
1683
1684         [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
1685         https://bugs.webkit.org/show_bug.cgi?id=58297
1686
1687         Do not disable flash specifically when built with GTK+ 3 -
1688         PluginPackage should do the right thing while loading plugins.
1689
1690         * GtkLauncher/main.c:
1691         (main):
1692
1693 2011-04-12  Kent Tamura  <tkent@chromium.org>
1694
1695         Reviewed by Dimitri Glazkov.
1696
1697         [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
1698         https://bugs.webkit.org/show_bug.cgi?id=57426
1699
1700         * DumpRenderTree/chromium/WebPreferences.cpp:
1701         (WebPreferences::applyTo): Disable the validation message timer.
1702
1703 2011-04-12  James Kozianski  <koz@chromium.org>
1704
1705         Unreviewed.
1706
1707         Adding myself to committers.py.
1708
1709         * Scripts/webkitpy/common/config/committers.py:
1710
1711 2011-04-12  Brent Fulgham  <bfulgham@webkit.org>
1712
1713         Unreviewed build correction for WinCairo bot after r83639.
1714         https://bugs.webkit.org/show_bug.cgi?id=51790
1715
1716         Correct typo for the new "update-webkit-wincairo-libs" script.
1717
1718         * Scripts/build-webkit: Incorrectly calling the
1719           update-webkit-cairo-libs which does not exist.
1720
1721 2011-04-12  Alice Liu  <alice.liu@apple.com>
1722
1723         Reviewed by Jon Honeycutt.
1724
1725         A change that should have been part of http://trac.webkit.org/changeset/83628
1726
1727         * DumpRenderTree/win/DumpRenderTree.cpp:
1728         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
1729
1730 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
1731
1732         Reviewed by Tony Chang.
1733
1734         new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
1735         https://bugs.webkit.org/show_bug.cgi?id=58272
1736
1737         NRWT was interpreting the --results-directory cmd line arg as
1738         relative to the build directory, not the current working
1739         directory (ORWT uses the latter, which is much more intuitive).
1740         
1741         This patch fixes the base case, but includes an override for
1742         Chromium that is needed until the bots can be updated.
1743
1744         * Scripts/webkitpy/layout_tests/port/base.py:
1745         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1746         * Scripts/webkitpy/layout_tests/port/chromium.py:
1747         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1748         * Scripts/webkitpy/layout_tests/port/test.py:
1749         * Scripts/webkitpy/layout_tests/port/webkit.py:
1750         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1751         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1752
1753 2011-04-12  Philippe Normand  <pnormand@igalia.com>
1754
1755         Unreviewed, roll out r83621 as it broke the GTK build.
1756
1757         [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
1758         https://bugs.webkit.org/show_bug.cgi?id=58333
1759
1760         * Scripts/build-jsc:
1761         * Scripts/build-webkit:
1762
1763 2011-04-12  Carl Lobo  <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
1764
1765         Reviewed by Adam Roben.
1766
1767         Patch to download the WinCairo dependancies as part of build-webkit.
1768         https://bugs.webkit.org/show_bug.cgi?id=51790
1769
1770         This patch downloads the dependancies from 
1771             http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip 
1772         checking the modification timestamp etc. 
1773
1774         * Tools/Scripts/build-webkit
1775         * Tools/Scripts/update-webkit: Modified to understand the --wincairo
1776           flag, and to update WinCairo dependencies when used.
1777         * Tools/Scripts/update-webkit-cairo-libs: added
1778         * Tools/Scripts/update-webkit-dependency: added
1779         * Tools/Scripts/update-webkit-auxiliary-libs
1780
1781 2011-04-12  Jeff Miller  <jeffm@apple.com>
1782
1783         Reviewed by Adam Roben.
1784
1785         WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
1786         https://bugs.webkit.org/show_bug.cgi?id=56020
1787
1788         Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
1789         since WebKit will do this for us.  If we didn't do this, TranslateMessage() would be called twice,
1790         which would generate two characters for every keypress (for example).  I didn't bother doing this for
1791         WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
1792         
1793         Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
1794
1795         * MiniBrowser/win/main.cpp:
1796         (shouldTranslateMessage): Added.
1797         (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
1798         * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
1799         * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
1800         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
1801         (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
1802         (TestWebKitAPI::runAndWatchForWMChar): Added.
1803         (TestWebKitAPI::TEST): Added.
1804         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1805         (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
1806         (TestWebKitAPI::Util::shouldTranslateMessage): Added.
1807         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1808         (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
1809         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
1810
1811 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
1812
1813         Reviewed by Tony Chang.
1814
1815         new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
1816         https://bugs.webkit.org/show_bug.cgi?id=58290
1817
1818         This is some preliminary refactoring for bug 58272.
1819
1820         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1821         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1822         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1823         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
1824         * Scripts/webkitpy/layout_tests/port/test.py:
1825         * Scripts/webkitpy/layout_tests/port/chromium.py:
1826         * Scripts/webkitpy/layout_tests/port/base.py:
1827         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1828
1829 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
1830
1831         Reviewed by Eric Seidel.
1832
1833         webkitpy: fix mock_filesystem abspath to handle relative paths
1834         and add filesystem.chdir() and filesystem.getcwd() to be able
1835         to test this and mock it out.
1836
1837         https://bugs.webkit.org/show_bug.cgi?id=58288
1838
1839         * Scripts/webkitpy/common/system/filesystem.py:
1840         * Scripts/webkitpy/common/system/filesystem_mock.py:
1841         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1842
1843 2011-04-12  Alice Liu  <alice.liu@apple.com>
1844
1845         Reviewed by Sam Weinig.
1846
1847         https://bugs.webkit.org/show_bug.cgi?id=58292
1848         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
1849
1850         * DumpRenderTree/mac/DumpRenderTree.mm:
1851         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
1852
1853 2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
1854
1855         Reviewed by Eric Seidel.
1856
1857         [Qt] Enable JIT build for SH4 platforms.
1858         https://bugs.webkit.org/show_bug.cgi?id=58317
1859
1860
1861         * DumpRenderTree/qt/DumpRenderTree.pro:
1862         * QtTestBrowser/QtTestBrowser.pro:
1863         * Scripts/webkitdirs.pm:
1864
1865 2011-04-12  Tony Chang  <tony@chromium.org>
1866
1867         Reviewed by Andreas Kling.
1868
1869         [Qt] embed checksums in PNGs written by Qt-DRT
1870         https://bugs.webkit.org/show_bug.cgi?id=58173
1871
1872         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1873         (WebCore::DumpRenderTree::dump):
1874
1875 2011-04-12  Eric Seidel  <eric@webkit.org>
1876
1877         Reviewed by Adam Barth.
1878
1879         commit-queue should upload failure diffs when tests fail
1880         https://bugs.webkit.org/show_bug.cgi?id=58348
1881
1882         This change was mostly just plumbing.  We were already saving
1883         this information for flaky test reporting.  I just made it possible
1884         for normal failures to report archives as well.
1885
1886         I did a little abstraction work to try and share some code between
1887         flakytestreporter.py and this new code.  There is still more we could do.
1888
1889         In making this change I also went through and updated the various
1890         places we have urls hard-coded in our python and pointed them at
1891         common.config.urls.
1892
1893         * Scripts/webkitpy/common/checkout/scm.py:
1894         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1895         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1896         * Scripts/webkitpy/common/net/statusserver.py:
1897         * Scripts/webkitpy/layout_tests/port/base.py:
1898         * Scripts/webkitpy/tool/bot/botinfo.py: Added.
1899         * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
1900         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1901         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1902         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1903         * Scripts/webkitpy/tool/commands/queues.py:
1904
1905 2011-04-12  Daniel Bates  <dbates@rim.com>
1906
1907         Rubber-stamped by Eric Seidel.
1908
1909         svn-apply and/or patch(1) has trouble applying patches that makes changes to files
1910         with Windows line endings
1911         https://bugs.webkit.org/show_bug.cgi?id=53625
1912
1913         Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
1914         applied to an SCM checkout on a Windows file system and vice-versa.
1915
1916         This issue manifests itself due to custom SCM settings as well as differences in
1917         gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
1918         into svn-apply/unapply to compensate for differences in line endings by converting
1919         the line endings in a patch to match the line endings in the target file (if it exists).
1920
1921         * Scripts/VCSUtils.pm:
1922           - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
1923             content read from the specified file handle. Obviously, this heuristic will not work
1924             for files with mixed line endings, but I don't envision such files to be the norm. If
1925             this turns out to be an issue then we can improve the heuristic.
1926           - Added firstEOLInFile().
1927           - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
1928             In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
1929             endings in the diff instead of the line endings in the target file.
1930           - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
1931             re-used in parseDiff().
1932         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
1933           to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
1934           mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
1935         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
1936         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
1937
1938 2011-04-12  Sam Weinig  <sam@webkit.org>
1939
1940         Reviewed by Adam Roben.
1941
1942         REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
1943         https://bugs.webkit.org/show_bug.cgi?id=58336
1944
1945         * WebKitTestRunner/TestController.cpp:
1946         (WTR::TestController::resetStateToConsistentValues):
1947         Remove cache clearing as that is causing tests to crash on Windows 7.
1948
1949 2011-04-11  Sam Weinig  <sam@webkit.org>
1950
1951         Reviewed by Anders Carlsson.
1952
1953         REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
1954         <rdar://problem/8981346>
1955         https://bugs.webkit.org/show_bug.cgi?id=54159
1956
1957         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1958         (WTR::InjectedBundlePage::InjectedBundlePage):
1959         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1960         (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
1961         (WTR::InjectedBundlePage::decidePolicyForResponse):
1962         (WTR::InjectedBundlePage::unableToImplementPolicy):
1963         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1964         Add short-circuited policy client which matches WebKit1.
1965
1966         * WebKitTestRunner/TestController.cpp:
1967         (WTR::TestController::resetStateToConsistentValues):
1968         Clear the cache between tests to ensure consistent results.
1969
1970 2011-04-11  George Guo  <George.Guo@nokia.com>
1971
1972         Reviewed by Eric Seidel.
1973
1974         prepare-ChangeLog support email input but -h did not show the option
1975         https://bugs.webkit.org/show_bug.cgi?id=58164
1976
1977         Add email option to -h to improve the usability
1978
1979         * Scripts/prepare-ChangeLog:
1980
1981 2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
1982
1983         Reviewed by Eric Carlson.
1984
1985         Rename MediaControls to MediaControlRootElement.
1986         https://bugs.webkit.org/show_bug.cgi?id=58250
1987
1988         * Scripts/do-webcore-rename: Documented the renaming.
1989
1990 2011-04-11  Sam Weinig  <sam@webkit.org>
1991
1992         Fix Windows build.
1993
1994         * MiniBrowser/win/BrowserView.cpp:
1995         (BrowserView::create):
1996
1997 2011-04-11  Sam Weinig  <sam@webkit.org>
1998
1999         Reviewed by Anders Carlsson.
2000
2001         Move focus management out of WebKit via  the UIClient
2002         <rdar://problem/8784068>
2003         https://bugs.webkit.org/show_bug.cgi?id=58278
2004
2005         * MiniBrowser/mac/BrowserWindowController.m:
2006         (-[BrowserWindowController awakeFromNib]):
2007         * WebKitTestRunner/TestController.cpp:
2008         (WTR::TestController::createOtherPage):
2009         (WTR::TestController::initialize):
2010         Add stubs for new UIClient functions.
2011
2012 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
2013
2014         Reviewed by Eric Seidel.
2015
2016         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
2017         https://bugs.webkit.org/show_bug.cgi?id=53605
2018
2019         Add an implementation of the PlainTextController for the GTK+ DRT.
2020
2021         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2022         (addControllerToWindow): Added this helper method.
2023         (webViewWindowObjectCleared): Use the new helper to add EventSender
2024         and the PlainTextController to the window object.
2025         * GNUmakefile.am: Added PlainTextController source files.
2026         * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
2027         on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
2028         until that functionality exists somewhere in the WebKitGTK+ stack.
2029         * DumpRenderTree/gtk/PlainTextController.h: Added.
2030
2031 2011-04-11  Yael Aharon  <yael.aharon@nokia.com>
2032
2033         Unreviewed.
2034
2035         Adding my IRC nick.
2036
2037         * Scripts/webkitpy/common/config/committers.py:
2038
2039 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
2040
2041         Reviewed by Adam Roben.
2042
2043         new-run-webkit-tests: fix crash when running under windows cmd.exe
2044         https://bugs.webkit.org/show_bug.cgi?id=58197
2045
2046         We would intermittently crash when running NRWT directly under
2047         cmd.exe on windows because we were sharing the stdin file
2048         descriptor between the python process and the http server.
2049         cmd.exe really didn't like that, and there was no reason to
2050         share the descriptor, so we now use a PIPE instead.
2051
2052         * Scripts/webkitpy/layout_tests/port/http_server.py:
2053
2054 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
2055
2056         Reviewed by Ojan Vafai.
2057
2058         new-run-webkit-tests: add unit tests for Port.diff_image()
2059         https://bugs.webkit.org/show_bug.cgi?id=58196
2060
2061         Add the unit tests for the fix in bug 58195.
2062
2063         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2064         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2065         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2066
2067 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
2068
2069         Reviewed by Tony Chang.
2070
2071         new-run-webkit-tests: implement support for audio, take two
2072         https://bugs.webkit.org/show_bug.cgi?id=58195
2073
2074         Attempt to re-land the fix for bug 58101 (which was initially
2075         landed in r83330, but rolled out). This is the same patch but
2076         fixes crashes in Port.diff_image() caused by the change for
2077         empty image files being None instead of ''.
2078
2079         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2080         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2081         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2082         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2083         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2084         * Scripts/webkitpy/layout_tests/port/base.py:
2085         * Scripts/webkitpy/layout_tests/port/chromium.py:
2086         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2087         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2088         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2089         * Scripts/webkitpy/layout_tests/port/test.py:
2090         * Scripts/webkitpy/layout_tests/port/webkit.py:
2091
2092 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
2093
2094         Reviewed by Xan Lopez.
2095
2096         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
2097         https://bugs.webkit.org/show_bug.cgi?id=57854
2098
2099         Implement missing features in GTK's DRT.
2100
2101         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2102         (indexRangeInTable): New helper function to get the range string
2103         for the current cell inside the parent table, either from the
2104         point of view of rows or columns.
2105         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
2106         the new helper function indexRangeInTable().
2107         (AccessibilityUIElement::columnIndexRange): Ditto.
2108
2109 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
2110
2111         Reviewed by Chris Fleizach.
2112
2113         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
2114         https://bugs.webkit.org/show_bug.cgi?id=57826
2115
2116         Implement missing feature in GTK's DRT.
2117
2118         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2119         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
2120         relying on the analogous function from the AtkTable interface.
2121
2122 2011-04-05  Timothy Hatcher  <timothy@apple.com>
2123
2124         Fix the extract-localizable-strings script errors that started after
2125         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
2126
2127         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
2128
2129 2011-04-11  Tony Chang  <tony@chromium.org>
2130
2131         Reviewed by Eric Seidel.
2132
2133         fix crc computation on 64 bit machines
2134         https://bugs.webkit.org/show_bug.cgi?id=58243
2135
2136         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
2137
2138         * DumpRenderTree/CyclicRedundancyCheck.cpp:
2139         (makeCrcTable):
2140         (computeCrc):
2141         * DumpRenderTree/CyclicRedundancyCheck.h:
2142         * DumpRenderTree/PixelDumpSupport.cpp:
2143         (appendIntToVector):
2144         (convertChecksumToPNGComment):
2145
2146 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
2147
2148         Reviewed by Eric Seidel.
2149
2150         Require no undefined symbols during compilation.
2151
2152         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
2153         https://bugs.webkit.org/show_bug.cgi?id=54896
2154
2155         Add -Wl,--no-undefined to catch missing symbols early.
2156
2157         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2158         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2159
2160 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
2161
2162         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
2163
2164         * wx/build/settings.py:
2165
2166 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
2167
2168         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
2169
2170         * wx/build/settings.py:
2171
2172 2011-04-10  David Levin  <levin@chromium.org>
2173
2174         Reviewed by Dimitri Glazkov.
2175
2176         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
2177         https://bugs.webkit.org/show_bug.cgi?id=58201
2178
2179         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
2180         and filed bug 58202.
2181
2182 2011-04-09  David Levin  <levin@chromium.org>
2183
2184         Unreviewed, rolling out r83394.
2185         http://trac.webkit.org/changeset/83394
2186         https://bugs.webkit.org/show_bug.cgi?id=53625
2187
2188         Patch was incorrect as noted in the bug.
2189
2190         * Scripts/svn-apply:
2191
2192 2011-04-09  David Levin  <levin@chromium.org>
2193
2194         Reviewed by Adam Barth.
2195
2196         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
2197         https://bugs.webkit.org/show_bug.cgi?id=53625
2198
2199         * Scripts/svn-apply: Ensure that the portions of patches
2200         which are for vcproj/vsprops files has DOS line endings.
2201
2202 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
2203
2204         Reviewed by Tony Chang.
2205
2206         It looks like NRWT has not been stopping DRT/TestShell
2207         instances properly on windows, probably for a long time.
2208         This would go a long way to explaining why we often have
2209         processes lying around :)
2210
2211         https://bugs.webkit.org/show_bug.cgi?id=57807
2212
2213         * Scripts/webkitpy/layout_tests/port/chromium.py:
2214         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2215
2216 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
2217
2218         Reviewed by Laszlo Gombos.
2219
2220         [Qt] Don't link against fontconfig or X11 if embedded
2221         https://bugs.webkit.org/show_bug.cgi?id=58104
2222
2223         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
2224         * QtTestBrowser/QtTestBrowser.pro: ditto
2225         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
2226         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
2227
2228 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
2229
2230         http/tests/loading/preload-append-scan.php is failing on Windows
2231         https://bugs.webkit.org/show_bug.cgi?id=58178
2232
2233         Reviewed by Brian Weinstein.
2234
2235         * DumpRenderTree/win/DumpRenderTree.cpp:
2236         (lastPathComponent):
2237         Use CFURL API to find the last path component, rather than
2238         PathFindFileName(), because the latter will include the query string.
2239
2240 2011-04-08  Jian Li  <jianli@chromium.org>
2241
2242         Unreviewed, rolling out r83327, r83330 since these patches are very
2243         likely to break chromium webkit mac10.6 builders.
2244
2245         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2246         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2247         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2248         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2249         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2250         * Scripts/webkitpy/layout_tests/port/base.py:
2251         * Scripts/webkitpy/layout_tests/port/chromium.py:
2252         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2253         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2254         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2255         * Scripts/webkitpy/layout_tests/port/test.py:
2256         * Scripts/webkitpy/layout_tests/port/webkit.py:
2257
2258 2011-04-08  Vincent Scheib  <scheib@chromium.org>
2259
2260         Reviewed by Eric Seidel.
2261
2262         add chromium-gpu-linux-x86_64 to the recognized list of ports
2263         https://bugs.webkit.org/show_bug.cgi?id=58099
2264
2265         Add chromium-gpu-linux-x86_64 to fix assert.
2266
2267         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2268
2269 2011-04-08  Alpha Lam  <hclam@chromium.org>
2270
2271         Unreviewed, rolling out r83335.
2272         http://trac.webkit.org/changeset/83335
2273         https://bugs.webkit.org/show_bug.cgi?id=53556
2274
2275         GTK and QT bots are broken
2276
2277         * Scripts/build-webkit:
2278
2279 2011-04-07  Anna Cavender  <annacc@chromium.org>
2280
2281         Reviewed by Eric Carlson.
2282
2283         Setup ENABLE(TRACK) feature define
2284         https://bugs.webkit.org/show_bug.cgi?id=53556
2285
2286         * Scripts/build-webkit:
2287
2288 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
2289
2290         Reviewed by Adam Roben.
2291
2292         new-run-webkit-tests: configure a NRWT test bot for Mac SL
2293         https://bugs.webkit.org/show_bug.cgi?id=58114
2294
2295         This change removes the old new-run-webkit-tests entry and
2296         updates it for a new test-only bot.
2297
2298         * BuildSlaveSupport/build.webkit.org-config/config.json:
2299
2300 2011-04-08  Dominic Cooney  <dominicc@google.com>
2301
2302         Reviewed by Adam Roben.
2303
2304         Make layoutTestController.shadowRoot return null, not undefined,
2305         when its argument is invalid.
2306         https://bugs.webkit.org/show_bug.cgi?id=58121
2307
2308         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2309         (LayoutTestController::shadowRoot):
2310         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2311         (WTR::LayoutTestController::shadowRoot):
2312
2313 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
2314
2315         Reviewed by Adam Roben.
2316
2317         Locate NSTD.EXE in 64-bit Windows
2318         https://bugs.webkit.org/show_bug.cgi?id=57847
2319
2320         * Scripts/old-run-webkit-tests:
2321
2322 2011-04-08  Adam Roben  <aroben@apple.com>
2323
2324         Qt build fix
2325
2326         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
2327
2328 2011-04-07  Adam Roben  <aroben@apple.com>
2329
2330         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
2331
2332         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
2333         plugin
2334
2335         Reviewed by Anders Carlsson.
2336
2337         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2338         (pluginLogWithArguments): Moved code to format and log the message here...
2339         (pluginLog): ...from here.
2340
2341         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
2342
2343         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2344         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
2345
2346         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
2347
2348         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
2349         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
2350         to begin.
2351         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
2352         constructor.
2353         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
2354         can be used to invoke our setWillBeDestroyed function.
2355         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
2356         anything unexpected happens).
2357         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
2358         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
2359         NPP_SetWindow was *not* called during destruction.
2360         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
2361         method, setWillBeDestroyed.
2362         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
2363         object.
2364
2365         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2366         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2367         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2368         * GNUmakefile.am:
2369         Added new test.
2370
2371         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
2372         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
2373
2374 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
2375
2376         Reviewed by Martin Robinson.
2377
2378         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
2379         https://bugs.webkit.org/show_bug.cgi?id=58039
2380
2381         Implement missing functions in GTK's DRT.
2382
2383         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2384         (AccessibilityUIElement::increment): Implemented.
2385         (AccessibilityUIElement::decrement): Implemented.
2386
2387 2011-04-08  Dominic Cooney  <dominicc@google.com>
2388
2389         Reviewed by Kent Tamura.
2390
2391         Make WK2 layoutTestController.shadowRoot return undefined, not
2392         null, when its argument is not an element.
2393         https://bugs.webkit.org/show_bug.cgi?id=58121
2394
2395         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2396         (WTR::LayoutTestController::shadowRoot):
2397
2398 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
2399
2400         Reviewed by Mihai Parparita.
2401
2402         Change reference port for Mac GPU baselines from
2403         Leopard to SnowLeopard, XP to Win7, and Linux-x86
2404         to Linux x86-64.
2405
2406         https://bugs.webkit.org/show_bug.cgi?id=58099
2407
2408         * Scripts/webkitpy/layout_tests/port/chromium.py:
2409
2410 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
2411
2412         Revert ENABLE_TRACK patch due to compile failures.
2413
2414         * Scripts/build-webkit:
2415
2416 2011-04-07  Tony Chang  <tony@chromium.org>
2417
2418         Reviewed by Eric Seidel.
2419
2420         update DRT to embed checksums in png files
2421         https://bugs.webkit.org/show_bug.cgi?id=57871
2422
2423         We insert the bytes for the comment in printPNG rather than at encode
2424         time because each platform does its own PNG encoding (either using CG
2425         or cairo).  Putting this in pringPNG avoids having to duplicate this
2426         code, although it's not as clean as doing it at encoding time.
2427
2428         We insert the comment right after the IHDR chunk of the PNG.
2429
2430         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2431         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
2432         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
2433         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
2434         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
2435         * DumpRenderTree/PixelDumpSupport.cpp:
2436         (dumpWebViewAsPixelsAndCompareWithExpected):
2437         (convertChecksumToPNGComment): Generate the bytes to insert.
2438         (printPNG): Insert the png comment before the first IDAT section.
2439         * DumpRenderTree/PixelDumpSupport.h:
2440         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
2441         (printPNG):
2442         (dumpBitmap):
2443         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2444         (printPNG):
2445         (dumpBitmap):
2446         * DumpRenderTree/win/DumpRenderTree.vcproj:
2447         * GNUmakefile.am:
2448
2449 2011-04-07  Jeff Miller  <jeffm@apple.com>
2450
2451         Reviewed by Adam Roben.
2452
2453         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
2454         https://bugs.webkit.org/show_bug.cgi?id=58058
2455
2456         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2457         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
2458
2459 2011-04-07  Chang Shu  <cshu@webkit.org>
2460
2461         Reviewed by Darin Adler.
2462
2463         WebKitTestRunner needs layoutTestController.isPageBoxVisible
2464         https://bugs.webkit.org/show_bug.cgi?id=42695
2465
2466         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2467         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2468         (WTR::LayoutTestController::isPageBoxVisible):
2469         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2470
2471 2011-04-07  Adam Roben  <aroben@apple.com>
2472
2473         Build fix
2474
2475         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
2476
2477 2011-04-07  Adam Roben  <aroben@apple.com>
2478
2479         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
2480
2481         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
2482         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
2483         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
2484         be overridden by subclasses to provide extra URLs before we call up to the base class (after
2485         which adding more URLs is no longer possible).
2486
2487         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
2488         bot results page
2489
2490         Reviewed by John Sullivan.
2491
2492         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2493         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
2494         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
2495         method is never called for MasterShellCommands.
2496         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
2497         with this method (which is).
2498
2499 2011-04-07  Adam Roben  <aroben@apple.com>
2500
2501         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
2502
2503         This matches how most of our other build steps work, so is good just for improving
2504         consistency between build steps. It should also make it possible for
2505         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
2506         trying to do this in finished() after we had called up to the base class, but that was
2507         apparently too late to add more URLs.)
2508
2509         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
2510         results page
2511
2512         Reviewed by John Sullivan.
2513
2514         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2515         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
2516         call setText to get the right text to show up for this step. This matches how most of our
2517         other build steps work.
2518         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
2519         This is how most of our other build steps work.
2520         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
2521         function, to match the base class.
2522
2523 2011-04-07  Adam Barth  <abarth@webkit.org>
2524
2525         Reviewed by Maciej Stachowiak.
2526
2527         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
2528         https://bugs.webkit.org/show_bug.cgi?id=58022
2529
2530         Previously, we were ignoring the args variable!  This patch fixes the
2531         regression introduced in http://trac.webkit.org/changeset/82771.
2532
2533         * Scripts/webkitpy/tool/commands/download_unittest.py:
2534         * Scripts/webkitpy/tool/mocktool.py:
2535         * Scripts/webkitpy/tool/steps/checkstyle.py:
2536
2537 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
2538
2539         Reviewed by Adam Barth.
2540
2541         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
2542         https://bugs.webkit.org/show_bug.cgi?id=58017
2543
2544         * Scripts/webkitpy/common/checkout/scm.py:
2545         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2546
2547 2011-04-06  Chang Shu  <cshu@webkit.org>
2548
2549         Reviewed by Darin Adler.
2550
2551         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
2552         https://bugs.webkit.org/show_bug.cgi?id=57984
2553
2554         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2555         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2556         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
2557         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2558
2559 2011-04-06  Chris Rogers  <crogers@google.com>
2560
2561         Reviewed by Tony Chang.
2562
2563         Add web audio support to DumpRenderTree (mac port)
2564         https://bugs.webkit.org/show_bug.cgi?id=57969
2565
2566         * DumpRenderTree/LayoutTestController.cpp:
2567         (LayoutTestController::LayoutTestController):
2568         (setEncodedAudioDataCallback):
2569         (LayoutTestController::staticFunctions):
2570         * DumpRenderTree/LayoutTestController.h:
2571         (LayoutTestController::dumpAsAudio):
2572         (LayoutTestController::setDumpAsAudio):
2573         (LayoutTestController::encodedAudioData):
2574         (LayoutTestController::setEncodedAudioData):
2575         * DumpRenderTree/mac/DumpRenderTree.mm:
2576         (dumpAudio):
2577         (dump):
2578
2579 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
2580
2581         Reviewed by Kenneth Rohde Christiansen.
2582
2583         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
2584         https://bugs.webkit.org/show_bug.cgi?id=56086
2585
2586         Add the missing method.
2587
2588         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2589         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
2590         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2591         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2592         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2593
2594 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
2595
2596         Reviewed by David Levin.
2597
2598         Add QUOTA build flag for unified quota API
2599         https://bugs.webkit.org/show_bug.cgi?id=57918
2600
2601         * Scripts/build-webkit: Added QUOTA build flag
2602
2603 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
2604
2605         Reviewed by Tony Chang.
2606
2607         Adjust the apple webkit port's default timeout to match
2608         old-run-webkit-tests at 35 seconds.
2609
2610         https://bugs.webkit.org/show_bug.cgi?id=37738
2611
2612         * Scripts/webkitpy/layout_tests/port/mac.py:
2613
2614 2011-04-06  Scott Cameron  <sccameron@rim.com>
2615
2616         Reviewed by Eric Seidel.
2617
2618         Remove global variable $httpdPath and replace with the return value of
2619         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
2620         https://bugs.webkit.org/show_bug.cgi?id=53499
2621
2622         * Scripts/run-iexploder-tests:
2623         * Scripts/webkitperl/httpd.pm:
2624
2625 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
2626
2627         Reviewed by Darin Adler.
2628
2629         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
2630         
2631         https://bugs.webkit.org/show_bug.cgi?id=27551
2632         
2633         * DumpRenderTree/config.h:
2634         * WebKitAPITest/config.h:
2635         * WebKitTestRunner/config.h:
2636
2637 2011-04-06  Tony Chang  <tony@chromium.org>
2638
2639         Reviewed by Darin Adler.
2640
2641         teach run-webkit-tests to read checksums from png files
2642         https://bugs.webkit.org/show_bug.cgi?id=57993
2643
2644         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
2645           no .checksum and look for the checksum in there.
2646
2647 2011-04-06  David Dorwin  <ddorwin@chromium.org>
2648
2649         Reviewed by David Levin.
2650
2651         Enable fullscreen layout tests for Chromium
2652         https://bugs.webkit.org/show_bug.cgi?id=55726
2653
2654         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
2655
2656         * DumpRenderTree/chromium/WebPreferences.cpp:
2657         (WebPreferences::applyTo):
2658
2659 2011-04-06  Adam Roben  <aroben@apple.com>
2660
2661         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
2662
2663         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
2664
2665         Reviewed by David Kilzer.
2666
2667         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2668         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
2669         build's results directory here...
2670         (ExtractTestResults.finished): ...from here.
2671         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
2672         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
2673         leaks" link to point to Leaks Viewer for this build.
2674         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
2675         but it seemed good to add for consistency with BuildAndTestFactory.
2676         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
2677         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
2678         that we'll get a "view leaks" link.
2679
2680 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
2681
2682         Reviewed by Eric Seidel.
2683
2684         [Gtk] plugins/set-status.html fails
2685         https://bugs.webkit.org/show_bug.cgi?id=57844
2686
2687         Allow an empty status text to be dumped.
2688
2689         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2690         (webViewStatusBarTextChanged):
2691
2692 2011-04-06  Chang Shu  <cshu@webkit.org>
2693
2694         Reviewed by Darin Adler.
2695
2696         WebKitTestRunner needs layoutTestController.pageNumberForElementById
2697         https://bugs.webkit.org/show_bug.cgi?id=42329
2698
2699         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2700         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2701         (WTR::LayoutTestController::pageNumberForElementById):
2702         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2703
2704 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
2705
2706         Reviewed by Martin Robinson.
2707
2708         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
2709         https://bugs.webkit.org/show_bug.cgi?id=57932
2710
2711         Some Layout tests have invalid URIs that do not generate valid
2712         SoupURI instances. Do not try to free those NULL SoupURIs.
2713
2714         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2715         (willSendRequestCallback):
2716
2717 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
2718
2719         Reviewed by Andreas Kling.
2720
2721         ORWT shouldn't generate diff files for tests without expected files
2722         https://bugs.webkit.org/show_bug.cgi?id=57846
2723
2724         * Scripts/old-run-webkit-tests:
2725
2726 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
2727
2728         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
2729         to deps.
2730
2731         * wx/install-unix-extras:
2732
2733 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2734
2735         Unreviewed, rolling out r82978, r82999, and r83001.
2736         http://trac.webkit.org/changeset/82978
2737         http://trac.webkit.org/changeset/82999
2738         http://trac.webkit.org/changeset/83001
2739         https://bugs.webkit.org/show_bug.cgi?id=57913
2740
2741         Does not work in Python 2.5 (Requested by abarth on #webkit).
2742
2743         * Scripts/webkitpy/common/system/executive.py:
2744         * Scripts/webkitpy/common/system/executive_unittest.py:
2745
2746 2011-04-05  Chang Shu  <cshu@webkit.org>
2747
2748         Reviewed by Darin Adler.
2749
2750         WebKitTestRunner needs layoutTestController.numberOfPages
2751         https://bugs.webkit.org/show_bug.cgi?id=42694
2752
2753         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2754         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2755         (WTR::LayoutTestController::numberOfPages):
2756         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2757
2758 2011-04-05  Tony Chang  <tony@chromium.org>
2759
2760         Reviewed by Mihai Parparita.
2761
2762         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
2763         https://bugs.webkit.org/show_bug.cgi?id=57889
2764
2765         * Scripts/webkitpy/layout_tests/port/chromium.py:
2766         * Scripts/webkitpy/layout_tests/port/test.py:
2767         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2768
2769 2011-04-05  Adam Barth  <abarth@webkit.org>
2770
2771         Silly with statement, from the future!
2772
2773         * Scripts/webkitpy/common/system/executive.py:
2774
2775 2011-04-05  Adam Barth  <abarth@webkit.org>
2776
2777         Reviewed by Tony Chang.
2778
2779         Don't use Exception.message because it's deprecated
2780         https://bugs.webkit.org/show_bug.cgi?id=57892
2781
2782         Suppress the warning for now.  When we move to Python 3, we might need
2783         to something more dramatic.
2784
2785         * Scripts/webkitpy/common/system/executive.py:
2786
2787 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
2788
2789         Reviewed by Ojan Vafai.
2790
2791         Add builders.js to dashboard file list
2792         https://bugs.webkit.org/show_bug.cgi?id=57899
2793
2794         Add file added by http://crrev.com/80538 to dashboard file list.
2795
2796         * TestResultServer/handlers/dashboardhandler.py:
2797
2798 2011-04-05  MORITA Hajime  <morrita@google.com>
2799
2800         Reviewed by Adam Barth.
2801
2802         webkit-patch should print git's stderr when git svn dcommit fail
2803         http://webkit.org/b/57861
2804
2805         * Scripts/webkitpy/common/checkout/scm.py:
2806
2807 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
2808
2809         Reviewed by Tony Chang.
2810
2811         Add --baseline-search-path to NRWT
2812         https://bugs.webkit.org/show_bug.cgi?id=56233
2813         
2814         Add NRWT option to specify additional directories to look for baselines
2815         (will be used by hardware GPU bots which will have local per-bot
2816         expectations for some tests)
2817
2818         * Scripts/webkitpy/common/system/filesystem_mock.py:
2819         * Scripts/webkitpy/layout_tests/port/base.py:
2820         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2821         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2822
2823 2011-04-05  Adam Roben  <aroben@apple.com>
2824
2825         Strip off /results.html from results URLs before trying to load leaks files from them
2826
2827         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
2828         files, rather than pointing to the directory that contains them. This is more convenient for
2829         people browsing build.webkit.org, but confused Leaks Viewer.
2830
2831         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
2832         list don't work
2833
2834         Reviewed by Joseph Pecoraro.
2835
2836         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2837         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
2838
2839 2011-04-05  Carol Szabo  <carol@webkit.org>
2840
2841         Unreviewed.
2842
2843         Updated my info in committers.py
2844
2845         Scripts\webkitpy\common\config\committers.py 
2846
2847 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
2848
2849         Reviewed by Laszlo Gombos.
2850
2851         [Qt] Make WebKitLibraries optional for building QtWebKit
2852         https://bugs.webkit.org/show_bug.cgi?id=57542
2853
2854         * Scripts/build-webkit:
2855
2856 2011-04-05  Chang Shu  <cshu@webkit.org>
2857
2858         Reviewed by Laszlo Gombos.
2859
2860         [Qt] MiniBrowser defaultUrl does not work
2861         https://bugs.webkit.org/show_bug.cgi?id=57021
2862
2863         Match the behavior and coding of MiniBrowser to QtTestBrowser.
2864         * MiniBrowser/qt/main.cpp:
2865         (main):
2866
2867 2011-04-05  Jade Han  <jade.han@nokia.com>
2868
2869         Reviewed by Laszlo Gombos.
2870
2871         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
2872         https://bugs.webkit.org/show_bug.cgi?id=54977
2873
2874         This change is a preparation to enable building webkit2 for Symbian.
2875         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
2876
2877         * Tools.pro:
2878
2879 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
2880
2881         Reviewed by Andreas Kling.
2882
2883         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
2884         https://bugs.webkit.org/show_bug.cgi?id=57832
2885
2886         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
2887
2888         * MiniBrowser/qt/UrlLoader.cpp:
2889         (UrlLoader::UrlLoader):
2890
2891 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
2892
2893         [Qt] Linux Release minimal build fix after r82919.
2894
2895         * MiniBrowser/qt/BrowserWindow.cpp:
2896         (BrowserWindow::loadURLListFromFile):
2897         * QtTestBrowser/launcherwindow.cpp:
2898         (LauncherWindow::loadURLListFromFile):
2899
2900 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
2901
2902         Reviewed by Andreas Kling.
2903
2904         [Qt] Make URL loader accessible from testbrowser's menus
2905         https://bugs.webkit.org/show_bug.cgi?id=57823
2906
2907         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
2908
2909         * MiniBrowser/qt/BrowserWindow.cpp:
2910         (BrowserWindow::BrowserWindow):
2911         (BrowserWindow::loadURLListFromFile):
2912         (BrowserWindow::~BrowserWindow):
2913         * MiniBrowser/qt/BrowserWindow.h:
2914         * QtTestBrowser/launcherwindow.cpp:
2915         (LauncherWindow::LauncherWindow):
2916         (LauncherWindow::~LauncherWindow):
2917         (LauncherWindow::createChrome):
2918         (LauncherWindow::loadURLListFromFile):
2919         * QtTestBrowser/launcherwindow.h:
2920
2921 2011-04-04  Sam Weinig  <sam@webkit.org>
2922
2923         Reviewed by Brian Weinstein.
2924
2925         Remove duplicate API from WKContext
2926         <rdar://problem/8727879>
2927         https://bugs.webkit.org/show_bug.cgi?id=57815
2928
2929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2930         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
2931         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2932         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
2933
2934 2011-04-04  Tony Chang  <tony@chromium.org>
2935
2936         Reviewed by Ojan Vafai.
2937
2938         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
2939         https://bugs.webkit.org/show_bug.cgi?id=57783
2940
2941         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2942         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2943
2944 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
2945
2946         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
2947         from WebKitBuild.
2948
2949         * Scripts/webkitdirs.pm:
2950
2951 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
2952
2953         Reviewed by Gustavo Noronha Silva.
2954
2955         [GTK] WebGL support
2956         https://bugs.webkit.org/show_bug.cgi?id=31517
2957
2958         Add support to the DRT for turning on WebGL when a layout tests requests it.
2959
2960         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2961         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
2962
2963 2011-04-04  Chang Shu  <cshu@webkit.org>
2964
2965         Reviewed by Darin Adler.
2966
2967         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
2968         https://bugs.webkit.org/show_bug.cgi?id=57572
2969
2970         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2971         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2972         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
2973         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2974
2975 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
2976
2977         Reviewed by Csaba Osztrogonác.
2978
2979         [Qt] DumpRenderTree breaks compilation in some uClibc environments
2980         https://bugs.webkit.org/show_bug.cgi?id=57602
2981
2982         * DumpRenderTree/qt/main.cpp:
2983         (get_backtrace):
2984
2985 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
2986
2987         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
2988
2989         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2990         (LayoutTestController::shadowRoot):
2991
2992 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
2993
2994         Unreviewed, fix exception in rebaseline tool.
2995
2996         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2997
2998 2011-04-02  Beth Dakin  <bdakin@apple.com>
2999
3000         Rubber-stamped by Geoff Garen.
3001
3002         For Dan!
3003         * DumpRenderTree/mac/DumpRenderTree.mm:
3004         (resetWebViewToConsistentStateBeforeTesting):
3005
3006 2011-04-02  Beth Dakin  <bdakin@apple.com>
3007
3008         Rubber-stamped by Geoff Garen.
3009
3010         Need to reset the scale, much like zoom.
3011         * DumpRenderTree/mac/DumpRenderTree.mm:
3012         (resetWebViewToConsistentStateBeforeTesting):
3013
3014 2011-04-02  Sam Weinig  <sam@webkit.org>
3015
3016         Reviewed by Beth Dakin.
3017
3018         https://bugs.webkit.org/show_bug.cgi?id=57605
3019         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
3020         getClientRects()
3021         -and corresponding-
3022         <rdar://problem/9194541>
3023
3024         Add DRT support for the scaleWebView SPI.
3025         * DumpRenderTree/mac/EventSendingController.mm:
3026         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3027         (+[EventSendingController webScriptNameForSelector:]):
3028         (-[EventSendingController scalePageBy:atX:andY:]):
3029         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3030         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3031         (WTR::EventSendingController::scalePageBy):
3032         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3033         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3034         (WTR::InjectedBundlePage::reset):
3035
3036 2011-04-02  Dominic Cooney  <dominicc@google.com>
3037
3038         Reviewed by Martin Robinson.
3039
3040         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
3041         https://bugs.webkit.org/show_bug.cgi?id=57551
3042
3043         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3044         (LayoutTestController::shadowRoot):
3045
3046 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
3047
3048         Reviewed by Eric Seidel.
3049
3050         Remove AbstractStep._run_script and move script names to ports.py
3051         https://bugs.webkit.org/show_bug.cgi?id=57704
3052
3053         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
3054
3055         * Scripts/webkitpy/common/config/ports.py:
3056         * Scripts/webkitpy/tool/commands/download_unittest.py:
3057         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3058         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3059         * Scripts/webkitpy/tool/steps/abstractstep.py:
3060         * Scripts/webkitpy/tool/steps/checkstyle.py:
3061         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3062         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
3063         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3064
3065 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
3066
3067         Reviewed by Eric Seidel.
3068
3069         Emulate shebang on Win32
3070         https://bugs.webkit.org/show_bug.cgi?id=55927
3071
3072         Scripts on Windows work only if they are called with the explicit interpreter.
3073         Read the first line of scripts to detect the correct executable.
3074
3075         * Scripts/webkitpy/common/config/ports.py:
3076         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
3077         * Scripts/webkitpy/common/system/executive_unittest.py:
3078
3079 2011-04-01  Adam Barth  <abarth@webkit.org>
3080
3081         Reviewed by Eric Seidel.
3082
3083         apos entities shouldn't show up in ChangeLogs when using webkit-patch
3084         https://bugs.webkit.org/show_bug.cgi?id=57692
3085
3086         Previously, we were using BeautifulSoup to process XML from
3087         bugs.webkit.org, but that's incorrect.  We should be using
3088         BeautifulStoneSoup to process the XML.  We were getting the &apos;
3089         entity wrong because &apos; is an XML entity but not an HTML entity.
3090
3091         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3092         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3093
3094 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3095
3096         Unreviewed, rolling out r82721.
3097         http://trac.webkit.org/changeset/82721
3098         https://bugs.webkit.org/show_bug.cgi?id=57687
3099
3100         This patch introduced assertion failures on the GTK+ bots.
3101         (Requested by mrobinson on #webkit).
3102
3103         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3104         (LayoutTestController::shadowRoot):
3105
3106 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
3107
3108         Unreviewed buildfix.
3109
3110         [Qt][WK2] Build Webkit2 using "-2" option on Qt
3111         https://bugs.webkit.org/show_bug.cgi?id=55074
3112
3113         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
3114         (The isWK2() function removes it from @ARGV, but not from @options.)
3115
3116 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
3117
3118         Reviewed by Csaba Osztrogonác.
3119
3120         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
3121         https://bugs.webkit.org/show_bug.cgi?id=57666
3122
3123         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
3124
3125 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
3126
3127         Reviewed by Adam Barth.
3128
3129         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
3130
3131         We apparently never implemented the code to skip tests based on
3132         what was compiled into DRT. Also, change the logic used to skip
3133         platform directories to match what old-run-webkit-tests does: 
3134         skip every test not in a directory in the baseline search path.
3135
3136         https://bugs.webkit.org/show_bug.cgi?id=57662
3137
3138         * Scripts/webkitpy/layout_tests/port/mac.py:
3139         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3140         * Scripts/webkitpy/layout_tests/port/webkit.py:
3141
3142 2011-03-29  Mark Rowe  <mrowe@apple.com>
3143
3144         Reviewed by Jon Honeycutt.
3145
3146         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
3147
3148         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
3149
3150         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3151         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3152         * Scripts/webkitpy/layout_tests/port/mac.py:
3153         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3154
3155 2011-04-01  Chang Shu  <cshu@webkit.org>
3156
3157         Reviewed by Csaba Osztrogonác.
3158
3159         [Qt][WK2] Build Webkit2 using "-2" option on Qt
3160         https://bugs.webkit.org/show_bug.cgi?id=55074
3161
3162         * Scripts/build-webkit:
3163
3164 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
3165
3166         Reviewed by Tony Chang.
3167
3168         new-run-webkit-tests: remove spurious port version override in webkit.py
3169         base.py provides a default implementation so this is just
3170         breaking things.
3171
3172         https://bugs.webkit.org/show_bug.cgi?id=57667
3173
3174         * Scripts/webkitpy/layout_tests/port/webkit.py:
3175         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3176
3177 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
3178
3179         Reviewed by Adam Roben.
3180
3181         Make view results on waterfall direct link to results.html
3182         https://bugs.webkit.org/show_bug.cgi?id=57671
3183
3184         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
3185         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
3186
3187 2011-04-01  Sam Weinig  <sam@webkit.org>
3188
3189         Fix windows build.
3190
3191         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
3192         (TestWebKitAPI::TEST):
3193         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
3194         (TestWebKitAPI::flushMessages):
3195
3196 2011-04-01  Sam Weinig  <sam@webkit.org>
3197
3198         Reviewed by Adam Roben.
3199
3200         Add adoptWK to WKRetainPtr.h
3201         https://bugs.webkit.org/show_bug.cgi?id=57670
3202
3203         * TestWebKitAPI/PlatformUtilities.h:
3204         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
3205         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3206         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
3207         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
3208         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
3209         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3210         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
3211         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3212         (TestWebKitAPI::createSessionStateContainingFormData):
3213         * WebKitTestRunner/StringFunctions.h:
3214         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
3215
3216 2011-04-01  Sam Weinig  <sam@webkit.org>
3217
3218         Reviewed by Adam Roben.
3219
3220         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
3221
3222         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3223         (WTR::LayoutTestController::shadowRoot):
3224         Make judicious use of adoptWK().
3225
3226 2011-04-01  Sam Weinig  <sam@webkit.org>
3227
3228         Reviewed by Timothy Hatcher.
3229
3230         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
3231
3232         * Scripts/extract-localizable-strings:
3233
3234 2011-04-01  Anders Carlsson  <andersca@apple.com>
3235
3236         Reviewed by Sam Weinig.
3237
3238         Shockwave plug-in doesn't accept mouse events
3239         https://bugs.webkit.org/show_bug.cgi?id=57653
3240         <rdar://problem/8483273>
3241
3242         Add a plug-in test.
3243
3244         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3245         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3246         (PluginTest::indicateTestFailure):
3247         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
3248
3249         (PluginTest::NPN_ConvertPoint):
3250         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3251         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
3252         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3253         Call indicateTestFailure.
3254
3255         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
3256         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
3257         (ConvertPoint::ConvertPoint):
3258         (ConvertPoint::testConvert):
3259         (ConvertPoint::NPP_New):
3260
3261 2011-04-01  Dominic Cooney  <dominicc@google.com>
3262
3263         Reviewed by Martin Robinson.
3264
3265         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
3266         https://bugs.webkit.org/show_bug.cgi?id=57551
3267
3268         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3269         (LayoutTestController::shadowRoot):
3270
3271 2011-04-01  Sam Weinig  <sam@webkit.org>
3272
3273         Reviewed by Anders Carlsson.
3274
3275         WebKitTestRunner needs layoutTestController.shadowRoot
3276         https://bugs.webkit.org/show_bug.cgi?id=57661
3277
3278         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3279         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3280         (WTR::LayoutTestController::shadowRoot):
3281         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3282         Implement layoutTestController.shadowRoot for WebKit2.
3283
3284 2011-04-01  Chang Shu  <cshu@webkit.org>
3285
3286         Reviewed by Darin Adler.
3287
3288         WebKitTestRunner needs layoutTestController.setDatabaseQuota
3289         https://bugs.webkit.org/show_bug.cgi?id=57568
3290
3291         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3292         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3293         (WTR::LayoutTestController::setDatabaseQuota):
3294         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3295
3296 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
3297
3298         Reviewed by Tony Chang.
3299
3300         This patch completes the cleanup of
3301         rebaseline-chromium-webkit-tests to work with all of the
3302         variants of a platform (we can now rebaseline gpu- and non-gpu
3303         files at the same time).
3304
3305         When the rebaselining is complete, any lines declared as
3306         REBASELINE in the expectations file that matches a test that was
3307         actually rebaselined will be deleted, even if only one of the
3308         variants was actually rebaselined. This may cause odd problems,
3309         but is better than where we're at today.
3310
3311         This change removes the -g flag and deprecates -w. The -g flag is gone
3312         because GPU baselines are handled just like any other variant.
3313         The -w flag is deprecated because this tool now only works
3314         against the canaries, since that's the only place we have a full
3315         set of bots. It will be trivial to change this to
3316         build.webkit.org if we decide that's where we want them to be.
3317
3318         Also, this patch deletes a lot of cruft that is no longer needed
3319         in the test_expectations code and the port-specific code.
3320
3321         https://bugs.webkit.org/show_bug.cgi?id=55191
3322
3323         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3324         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3325         * Scripts/webkitpy/layout_tests/port/base.py:
3326         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3327         * Scripts/webkitpy/layout_tests/port/chromium.py:
3328         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3329         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3330         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3331         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3332         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3333         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3334         * Scripts/webkitpy/layout_tests/port/mac.py:
3335         * Scripts/webkitpy/layout_tests/port/test.py:
3336         * Scripts/webkitpy/layout_tests/port/webkit.py:
3337         * Scripts/webkitpy/layout_tests/port/win.py:
3338         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3339         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3340
3341 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
3342
3343         Reviewed by Adam Barth.
3344
3345         rebaseline-chromium-webkit-tests does not work correctly with
3346         version-specific baselines. This patch updates the tool to use
3347         all of the version-specific bots on the canaries, and will now
3348         attempt to rebaseline all of the versions by default, although
3349         it will not update both GPU and CPU versions.
3350         
3351         Also, it will no longer modify the test_expectations.txt file
3352         *at all*. You will have to manually delete the REBASELINE lines
3353         after running the tool and determining that it did what you
3354         wanted it to do. This should be fixed in a separate bug - see
3355         webkit bug #55191.
3356
3357         https://bugs.webkit.org/show_bug.cgi?id=55608
3358
3359         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3360         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3361         * Scripts/webkitpy/layout_tests/port/chromium.py:
3362         * Scripts/webkitpy/layout_tests/port/test.py:
3363         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3364         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3365
3366 2011-03-31  Tony Chang  <tony@chromium.org>
3367
3368         Reviewed by Ojan Vafai.
3369
3370         [chromium] update the rebaseline tool to know about pngs with checksums
3371         https://bugs.webkit.org/show_bug.cgi?id=57481
3372
3373         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
3374         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3375
3376 2011-04-01  Adam Roben  <aroben@apple.com>
3377
3378         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
3379
3380         Previously, we were getting the revision of the first revision that triggered a build.
3381         Choosing the last revision would have been more accurate. But got_revision is what is used
3382         everywhere else on build.webkit.org, and should work even when there were no changes that
3383         triggered a build (e.g., if someone clicked the Force Build button).
3384
3385         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
3386         recent builds list
3387
3388         Reviewed by Anders Carlsson.
3389
3390         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3391         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
3392         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
3393
3394         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
3395         (Array.prototype.first): Added this helper function to return the first element in an array
3396         that matches the given predicate, or null if no such element exists.
3397
3398 2011-03-31  Adam Roben  <aroben@apple.com>
3399
3400         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
3401
3402         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
3403
3404         Reviewed by Darin Adler.
3405
3406         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3407         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
3408         URL on its own line.
3409
3410         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3411         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
3412         progression, and added a new test that uses a short bug URL while I was at it.
3413
3414 2011-04-01  Adam Roben  <aroben@apple.com>
3415
3416         Mark .vcproj/.vsprops/.sln files as being Windows-only
3417
3418         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
3419
3420         Reviewed by Anders Carlsson.
3421
3422         * Scripts/webkitpy/common/config/build.py:
3423         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
3424         directories as Windows-only.
3425
3426         * Scripts/webkitpy/common/config/build_unittest.py:
3427         (ShoulBuildTest): Added test cases for the above.
3428
3429 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
3430
3431         Reviewed by Laszlo Gombos.
3432
3433         [Qt] Build MiniBrowser for Symbian
3434         https://bugs.webkit.org/show_bug.cgi?id=56319
3435
3436         Have MiniBrowser reference it's own copy of useragentlist.txt instead
3437         of copying QtTestBrowser's.
3438         Remove Tools/MiniBrowser/DerivedSources.pro
3439         This reduces complexity in the Tools scripts due to Symbian limitations.
3440
3441         * DerivedSources.pro:
3442         * MiniBrowser/DerivedSources.pro: Removed.
3443         * MiniBrowser/MiniBrowser.qrc:
3444         * MiniBrowser/qt/MiniBrowser.pro:
3445         * Scripts/webkitdirs.pm:
3446
3447 2011-03-31  Chang Shu  <cshu@webkit.org>
3448
3449         Reviewed by Darin Adler.
3450
3451         WebKitTestRunner needs layoutTestController.clearAllDatabases
3452         https://bugs.webkit.org/show_bug.cgi?id=42540
3453
3454         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3455         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3456         (WTR::InjectedBundle::beginTesting):
3457         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3458         (WTR::LayoutTestController::clearAllDatabases):
3459         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3460
3461 2011-03-31  Chang Shu  <cshu@webkit.org>
3462
3463         Reviewed by Darin Adler.
3464
3465         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
3466         https://bugs.webkit.org/show_bug.cgi?id=42692
3467
3468         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3469
3470 2011-03-31  Darin Adler  <darin@apple.com>
3471
3472         Reviewed by Sam Weinig.
3473
3474         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
3475         https://bugs.webkit.org/show_bug.cgi?id=57573
3476
3477         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3478         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
3479         Removed fake definitions of keyDown and contextClick.
3480
3481         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3482         (WTR::operator==): Added. So we can compare two WKPoint structs.
3483         (WTR::parseModifier): Added.
3484         (WTR::parseModifierArray): Added.
3485         (WTR::EventSendingController::EventSendingController): Initialize the
3486         new data members.
3487         (WTR::EventSendingController::mouseDown): Added. Calls
3488         WKBundlePageSimulateMouseDown.
3489         (WTR::EventSendingController::mouseUp): Added. Calls
3490         WKBundlePageSimulateMouseUp.
3491         (WTR::EventSendingController::mouseMoveTo): Added. Calls
3492         WKBundlePageSimulateMouseMotion.
3493         (WTR::EventSendingController::leapForward): Added.
3494         (WTR::EventSendingController::updateClickCount): Added. Used by the
3495         mouseDown/Up functions to create a click count.
3496
3497         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
3498         for the changes above.
3499
3500 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
3501
3502         Reviewed by Martin Robinson.
3503
3504         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
3505         https://bugs.webkit.org/show_bug.cgi?id=57362
3506
3507         Do not generate DRT output if willSendRequestReturnsNull is set.
3508
3509         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3510         (willSendRequestCallback):
3511
3512 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
3513
3514         Reviewed by Martin Robinson.
3515
3516         Implement MiniBrowser for Gtk port.
3517         https://bugs.webkit.org/show_bug.cgi?id=48512
3518
3519         Initial implementation of the Gtk MiniBrowser.
3520
3521         * MiniBrowser/gtk/GNUmakefile.am: Added.
3522         * MiniBrowser/gtk/main.c: Added.
3523         (activateUriEntryCallback):
3524         (destroyCallback):
3525         (goBackCallback):
3526         (goForwardCallback):
3527         (createToolbar):
3528         (createWebView):
3529         (createWindow):
3530         (argumentToURL):
3531         (main):
3532
3533 2011-03-30  Dominic Cooney  <dominicc@google.com>
3534
3535         Reviewed by Dimitri Glazkov.
3536
3537         Adds layoutTestController.shadowRoot accessor to Mac DRT.
3538         https://bugs.webkit.org/show_bug.cgi?id=57415
3539
3540         * DumpRenderTree/LayoutTestController.cpp:
3541         (shadowRootCallback):
3542         (LayoutTestController::staticFunctions):
3543         * DumpRenderTree/LayoutTestController.h:
3544         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3545         (LayoutTestController::shadowRoot):
3546         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3547         (LayoutTestController::shadowRoot):
3548
3549 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
3550
3551         Reviewed by Chris Marrin.
3552
3553         Update fast/canvas tests to avoid dumping the render tree when possible
3554         https://bugs.webkit.org/show_bug.cgi?id=57493
3555
3556         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
3557           accelerated drawing and accelerated drawing for canvas
3558
3559 2011-03-30  Adam Roben  <aroben@apple.com>
3560
3561         Stop ignoring leaks in CGGradientCreateWithColorStops
3562
3563         Fixes <rdar://problem/7888547>.
3564
3565         Rubber-stamped by John Sullivan.
3566
3567         * Scripts/old-run-webkit-tests:
3568         (countAndPrintLeaks): Removed some code to ignore those leaks.
3569
3570 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
3571
3572         Reviewed by Alexey Proskuryakov.
3573
3574         Add some dynamic annotations to JavaScriptCore/wtf
3575         https://bugs.webkit.org/show_bug.cgi?id=53747
3576
3577         By using these annotations we can improve the precision of finding
3578         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
3579         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
3580
3581         These files don't add new functionality, so don't need extra tests.
3582
3583         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
3584
3585 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
3586
3587         Reviewed by Adam Roben.
3588
3589         Share most vsprops between Release and Production builds in releaseproduction.vsprops
3590         https://bugs.webkit.org/show_bug.cgi?id=57508
3591
3592         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
3593         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
3594         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
3595         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
3596         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
3597         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
3598         * DumpRenderTree/win/ImageDiffProduction.vsprops:
3599         * DumpRenderTree/win/ImageDiffRelease.vsprops:
3600         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
3601         * FindSafari/FindSafariProduction.vsprops:
3602         * FindSafari/FindSafariRelease.vsprops:
3603         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
3604         * FindSafari/FindSafariReleasePGO.vsprops:
3605         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
3606         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
3607         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
3608         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
3609         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
3610         * WebKitAPITest/WebKitAPITestProduction.vsprops:
3611         * WebKitAPITest/WebKitAPITestRelease.vsprops:
3612         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
3613         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
3614         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
3615         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
3616         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
3617         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
3618         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
3619         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
3620         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
3621         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
3622         * WinLauncher/WinLauncherProduction.vsprops:
3623         * WinLauncher/WinLauncherRelease.vsprops:
3624         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
3625         * record-memory-win/record-memory-winProduction.vsprops:
3626         * record-memory-win/record-memory-winRelease.vsprops:
3627         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
3628
3629 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
3630
3631         Reviewed by Adam Roben.
3632
3633         Update Windows production build logic for new production configurations
3634         https://bugs.webkit.org/show_bug.cgi?id=57494
3635
3636         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
3637         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
3638         * DumpRenderTree/win/ImageDiffProduction.vsprops:
3639         * FindSafari/FindSafariProduction.vsprops:
3640         * FindSafari/FindSafariReleasePGO.vsprops:
3641         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
3642         * WebKitAPITest/WebKitAPITestProduction.vsprops:
3643         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
3644         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
3645         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
3646         * WinLauncher/WinLauncherProduction.vsprops:
3647         * record-memory-win/record-memory-winProduction.vsprops:
3648
3649 2011-03-30  Robert Hogan  <robert@webkit.org>
3650
3651         Reviewed by Antonio Gomes.
3652
3653         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
3654         Unskip http/tests/navigation/go-back-to-error-page.html
3655
3656         Also add the location of DumpRenderTreeSupportQt.h
3657         to DRT's include paths.
3658
3659         https://bugs.webkit.org/show_bug.cgi?id=52614
3660
3661         * DumpRenderTree/qt/DumpRenderTree.pro:
3662         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3663         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3664         * DumpRenderTree/qt/GCControllerQt.cpp:
3665         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3666         (LayoutTestController::queueLoadHTMLString):
3667         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3668         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
3669         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3670         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
3671         (LoadAlternateHTMLStringItem::invoke):
3672         * DumpRenderTree/qt/WorkQueueItemQt.h:
3673         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
3674         * QtTestBrowser/QtTestBrowser.pro:
3675         * QtTestBrowser/launcherwindow.h:
3676
3677 2011-03-30  Adam Barth  <abarth@webkit.org>
3678
3679         Reviewed by Adam Roben.
3680
3681         SheriffBot rollouts take too long
3682         https://bugs.webkit.org/show_bug.cgi?id=57498
3683
3684         We used to build before landing rollouts via the commit-queue to
3685         prevent further breakage, but now that our individual commit-queue
3686         machines are slower, building takes too long.  I can't remember the
3687         last time a rollout broke compile.  It seems like just landing the
3688         patch is the better trade-off.
3689
3690         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3691         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3692
3693 2011-03-30  Adam Barth  <abarth@webkit.org>
3694
3695         Remove platform/chromium-mac-snowleopard
3696         https://bugs.webkit.org/show_bug.cgi?id=57486
3697
3698         This directory no longer exists, so we can remove it from the fallback
3699         chain.
3700