[CSS Shaders] Implement transform parameter animations for CSS Custom Filters
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-12  Xan Lopez  <xlopez@igalia.com>
2
3         [GTK] We attempt to rebase documentation even if it's not present
4         https://bugs.webkit.org/show_bug.cgi?id=96553
5
6         Reviewed by Martin Robinson.
7
8         Do not make the documentation rebase step fatal. This allows make
9         install to succeed when there's no documentation generated.
10
11         * gtk/generate-gtkdoc:
12
13 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
14
15         Respect WEBKITOUTPUTDIR when running EFL tests
16         https://bugs.webkit.org/show_bug.cgi?id=96528
17
18         Reviewed by Dirk Pranke.
19
20         Expose user set WEBKITOUTPUTDIR to the web process.
21
22         * Scripts/webkitpy/layout_tests/port/driver.py:
23         (Driver._start): Add WEBKITOUTPUTDIR to the environment
24         of the web process and its potential jhbuild wrapper.
25
26 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
27
28         webkitdirs: fix uname version handling for cygwin
29         https://bugs.webkit.org/show_bug.cgi?id=96436
30
31         Reviewed by Jon Honeycutt.
32
33         Newer versions of cygwin embed an additional version string
34         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
35         Update the code to handle that.
36
37         * Scripts/webkitdirs.pm:
38         (setupAppleWinEnv):
39
40 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
41
42         Regression(r128338): Broke Windows build
43         https://bugs.webkit.org/show_bug.cgi?id=96537
44
45         Unreviewed build fix.
46
47         Fix Apple-Win build by allocating array dynamically
48         since its size is not constant.
49
50         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
51         (WTR::stringArrayToJS):
52
53 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
54
55         [chromium] Add a virtual test suite for fast/hidpi
56         https://bugs.webkit.org/show_bug.cgi?id=90192
57
58         Reviewed by Dirk Pranke.
59
60         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
61         on the hardware accelerated path as the software path.
62
63         * DumpRenderTree/chromium/WebPreferences.cpp:
64         (WebPreferences::applyTo):
65         * Scripts/webkitpy/layout_tests/port/chromium.py:
66         (ChromiumPort.virtual_test_suites):
67
68 2012-09-12  Adam Klein  <adamk@chromium.org>
69
70         [chromium] Add content_browsertests to the flakiness dashboard
71         https://bugs.webkit.org/show_bug.cgi?id=96535
72
73         Reviewed by Ojan Vafai.
74
75         * TestResultServer/static-dashboards/dashboard_base.js:
76
77 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
78
79         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
80         https://bugs.webkit.org/show_bug.cgi?id=96496
81
82         Reviewed by Kenneth Rohde Christiansen.
83
84         Add implementation for originsWithApplicationCache to
85         WebKitTestRunner.
86
87         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
88         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
89         (WTR::stringArrayToJS):
90         (WTR):
91         (WTR::TestRunner::originsWithApplicationCache):
92         * WebKitTestRunner/InjectedBundle/TestRunner.h:
93         (TestRunner):
94
95 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
96
97         Fix Qt/Windows build with Python3
98         https://bugs.webkit.org/show_bug.cgi?id=96473
99
100         Reviewed by Csaba Osztrogonác.
101
102         In Python 3 print is a real function, so we must use parentheses around
103         the function parameters. This is backwards compatible with Python 2.
104
105         * Scripts/generate-win32-export-forwards:
106
107 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
108
109         Unreviewed trivial build fix for Qt/Windows after bug #96358.
110
111         As pointed out by Kevin, we should inject the "set PATH=..." statement
112         to add the GnuWin32 directory only if that directory actually exists.
113
114         * qmake/mkspecs/features/default_post.prf:
115
116 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
117
118         [EFL] [WK2] Memory leaks in TestControllerEfl
119         https://bugs.webkit.org/show_bug.cgi?id=96525
120
121         Reviewed by Kenneth Rohde Christiansen.
122
123         Fix memory leaks in EFL's TestRunner code by adopting an allocation
124         of WKString created with WKStringCreateWithUTF8CString().
125
126         * WebKitTestRunner/efl/TestControllerEfl.cpp:
127         (WTR::TestController::initializeInjectedBundlePath):
128         (WTR::TestController::initializeTestPluginDirectory):
129
130 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
131
132         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
133         https://bugs.webkit.org/show_bug.cgi?id=96374
134
135         Reviewed by Kenneth Rohde Christiansen.
136
137         Implement support for dumpApplicationCacheDelegateCallbacks
138         and disallowIncreaseForApplicationCacheQuota in
139         WebKitTestRunner and properly dump the information
140         expected by the tests.
141
142         If the application cache quota is reached for a given
143         security origin, WebKitTestRunner will reset the quota
144         to its default value, unless intructed not to via
145         disallowIncreaseForApplicationCacheQuota().
146
147         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
148         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
149         (WTR::InjectedBundlePage::InjectedBundlePage):
150         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
151         (WTR):
152         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
153         (InjectedBundlePage):
154         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
155         (WTR::TestRunner::TestRunner):
156         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
157         (WTR):
158         * WebKitTestRunner/InjectedBundle/TestRunner.h:
159         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
160         (TestRunner):
161         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
162         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
163
164 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
165
166         [chromium] remove deprecated and unused sets import from chromium_android driver
167         https://bugs.webkit.org/show_bug.cgi?id=96485
168
169         Reviewed by Dirk Pranke.
170
171         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
172
173 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
174
175         Flakiness dashboard doesn't recognize new Chromium Android test builder
176         https://bugs.webkit.org/show_bug.cgi?id=96523
177
178         Reviewed by Ojan Vafai.
179
180         Properly return 'ANDROID' as the Chromium platform for Android builders.
181
182         * TestResultServer/static-dashboards/flakiness_dashboard.js:
183         (chromiumPlatform):
184         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
185         (test):
186
187 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
188
189         [Qt] Build on Windows requires bison/flex in PATH
190         https://bugs.webkit.org/show_bug.cgi?id=96358
191
192         Reviewed by Tor Arne Vestbø.
193
194         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
195         and Linux that is rarely a problem given how easily available the tools are. On Windows however
196         a separate installation of various GNU tools is required as the operating system doesn't come with
197         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
198         the gnuwin32 directory of the qt5.git top-level repository.
199
200         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
201
202         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
203         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
204         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
205         updated with the new tool.
206
207         * Scripts/webkitdirs.pm:
208         (checkRequiredSystemConfig):
209         * qmake/mkspecs/features/default_post.prf:
210
211 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
212
213         [Qt] Update build-jsc after r128174
214
215         Reviewed by Ossy.
216
217         * Scripts/build-jsc:
218
219 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
220
221         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
222
223         By hard-coding the names of the targets we defined we ended up just
224         redefining the previous target when using addStrictSubdirOrderBetween
225         more than once in a single project file.
226
227         We now embed the two base targets into the target names.
228
229         Reviewed by Simon Hausmann.
230
231         * qmake/mkspecs/features/functions.prf:
232
233 2012-09-12  Philippe Liard  <pliard@google.com>
234
235         Depend on {base,net} GYP targets rather than {base,net}_java.
236         https://bugs.webkit.org/show_bug.cgi?id=95690
237
238         Reviewed by Adam Barth.
239
240         {base,net}_java became 'private' targets on the Chromium side that
241         clients should not depend on (see
242         https://chromiumcodereview.appspot.com/10913083/).
243         This removes a bunch of trailing white spaces additionally in
244         TestWebkitAPI.gyp (which includes non-trailing white space changes).
245
246         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
247         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
248
249 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
250
251         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
252         https://bugs.webkit.org/show_bug.cgi?id=96494
253
254         Reviewed by Tor Arne Vestbø.
255
256         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
257         plugin process feature if we don't have NPAPI.
258
259         * qmake/mkspecs/features/features.prf:
260
261 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
262
263         Unreviewed, rolling out r128280.
264         http://trac.webkit.org/changeset/128280
265         https://bugs.webkit.org/show_bug.cgi?id=96498
266
267         it broke compilation on windows debug bot (Requested by loislo
268         on #webkit).
269
270         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
271         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
272         (WTR::InjectedBundlePage::InjectedBundlePage):
273         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
274         (InjectedBundlePage):
275         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
276         (WTR::TestRunner::TestRunner):
277         * WebKitTestRunner/InjectedBundle/TestRunner.h:
278         (TestRunner):
279
280 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
281
282         [Qt] Make it possible to build with "make release" and "make debug" on Windows
283         https://bugs.webkit.org/show_bug.cgi?id=96488
284
285         Reviewed by Tor Arne Vestbø.
286
287         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
288         because there are no such targets. We want the generated sources to be independent from release
289         or debug build configurations, so it is sufficient to provide fake debug and release targets that
290         redirect to the same general-purpose target (first) of creating the derived sources.
291
292         * qmake/mkspecs/features/default_post.prf:
293
294 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
295
296         [EFL] Make DumpRenderTree smarter at finding the fonts
297         http://webkit.org/b/96281
298
299         Reviewed by Gyuyoung Kim.
300
301         Respect WEBKITOUTPUTDIR and expand the font dir from it.
302         Use CString consistently.
303
304         * DumpRenderTree/efl/FontManagement.cpp:
305         (buildPath):
306         (getCoreFontFiles):
307         (addFontDirectory):
308         (addFontFiles):
309         (getCustomBuildDir):
310         (getPlatformFontsPath):
311         (addFontsToEnvironment):
312
313 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
314
315         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
316         https://bugs.webkit.org/show_bug.cgi?id=96374
317
318         Reviewed by Kenneth Rohde Christiansen.
319
320         Implement support for dumpApplicationCacheDelegateCallbacks
321         and disallowIncreaseForApplicationCacheQuota in
322         WebKitTestRunner and properly dump the information
323         expected by the tests.
324
325         If the application cache quota is reached for a given
326         security origin, WebKitTestRunner will reset the quota
327         to its default value, unless intructed not to via
328         disallowIncreaseForApplicationCacheQuota().
329
330         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
331         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
332         (WTR::InjectedBundlePage::InjectedBundlePage):
333         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
334         (WTR):
335         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
336         (InjectedBundlePage):
337         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
338         (WTR::TestRunner::TestRunner):
339         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
340         (WTR):
341         * WebKitTestRunner/InjectedBundle/TestRunner.h:
342         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
343         (TestRunner):
344         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
345         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
346
347 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
348
349         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
350         https://bugs.webkit.org/show_bug.cgi?id=96388
351
352         Reviewed by Kenneth Rohde Christiansen.
353
354         Exported TestRunner.workerThreadCount as readonly attribute.
355
356         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
357         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
358         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
359         (WTR):
360         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
361         (TestRunner):
362
363 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
364
365         [chromium] Consume a user gesture when creating a new view.
366         https://bugs.webkit.org/show_bug.cgi?id=96373
367
368         Reviewed by Adam Barth.
369
370         * DumpRenderTree/chromium/WebViewHost.cpp:
371         (WebViewHost::createView):
372
373 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
374
375         [WK2][WTR] Some of TestRunner special options are not reset before testing
376         https://bugs.webkit.org/show_bug.cgi?id=96384
377
378         Reviewed by Kenneth Rohde Christiansen.
379
380         Now values of the following special options are reset:
381         void setAcceptsEditing(in boolean value);
382         void setCloseRemainingWindowsWhenComplete(in boolean value);
383         void setXSSAuditorEnabled(in boolean value);
384         void setAllowFileAccessFromFileURLs(in boolean value);
385         void setPluginsEnabled(in boolean value);
386         void setPopupBlockingEnabled(in boolean value);
387
388         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
389         (WTR::InjectedBundle::beginTesting):
390
391 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
392
393         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
394         https://bugs.webkit.org/show_bug.cgi?id=96273
395
396         Reviewed by Gyuyoung Kim.
397
398         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
399         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
400
401         * WebKitTestRunner/CMakeLists.txt:
402
403 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
404
405         [chromium] rename webkit_resources
406         https://bugs.webkit.org/show_bug.cgi?id=95874
407
408         Reviewed by James Robinson.
409
410         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
411
412 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
413
414         [chromium] don't include content shell builders in the garden-o-matic view
415         https://bugs.webkit.org/show_bug.cgi?id=96418
416
417         Reviewed by James Robinson.
418
419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
420
421 2012-09-11  Adam Klein  <adamk@chromium.org>
422
423         Garden-o-matic should ignore a wider variety of warnings in buildbot json
424         https://bugs.webkit.org/show_bug.cgi?id=96411
425
426         Reviewed by Adam Barth.
427
428         Previously only the exact string "warning" was treated as a warning
429         result. This patch treats any string with "warning" as a substring
430         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
431
432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
433         (.):
434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
435
436 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
437
438         Restore original value of mock scrollbars enabled in InternalSettings
439         https://bugs.webkit.org/show_bug.cgi?id=87680
440
441         Reviewed by Adam Barth.
442
443         Added backup support for mock scrollbars state in
444         InternalSettings::Backup, and removed support for these
445         from Qt's DumpRenderTree.
446
447         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
448         (WebCore::WebPage::resetSettings):
449         * DumpRenderTree/qt/TestRunnerQt.cpp:
450         (TestRunner::setFrameFlatteningEnabled):
451         * DumpRenderTree/qt/TestRunnerQt.h:
452         (TestRunner):
453
454 2012-09-11  Dan Bernstein  <mitz@apple.com>
455
456         Fixed a bug where kill-old-processes failed to kill clang++.
457
458         Rubber-stamped by Alexey Proskuryakov.
459
460         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
461         where it is passed as a regular expression to killall.
462
463 2012-09-11  Philippe Liard  <pliard@google.com>
464
465         Make sure that md5sum is not setup on non-Chromium Android platforms.
466         https://bugs.webkit.org/show_bug.cgi?id=96393
467
468         Reviewed by Adam Barth.
469
470         Previously md5sum was setup in ChromiumAndroidDriver's constructor
471         which is also invoked on non-Chromium Android platforms. The following patch
472         moves this logic to _startup_test() which is guaranteed to be invoked
473         only on Android.
474
475         This also updates the prompt unit test in chromium_android_unittest.py.
476
477         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
478         (ChromiumAndroidDriver.__init__):
479         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
480         (ChromiumAndroidDriver._setup_test):
481
482 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
483
484         [EFL] Rewrite the EFL-related Find modules
485         https://bugs.webkit.org/show_bug.cgi?id=95237
486
487         Reviewed by Kenneth Rohde Christiansen.
488
489         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
490         property and include all the Enlightenment Foundation Libraries
491         required by the target.
492         * EWebLauncher/CMakeLists.txt: Ditto.
493         * MiniBrowser/efl/CMakeLists.txt: Ditto.
494         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
495         now that they are not added implicitly.
496         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
497         property.
498         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
499         property and include all the Enlightenment Foundation Libraries
500         required by the target.
501
502 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
503
504         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
505         https://bugs.webkit.org/show_bug.cgi?id=96379
506
507         Reviewed by Kenneth Rohde Christiansen.
508
509         Add implementation for setApplicationCacheOriginQuota
510         to WebKitTestRunner.
511
512         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
513         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
514         (WTR::TestRunner::setApplicationCacheOriginQuota):
515         (WTR):
516         * WebKitTestRunner/InjectedBundle/TestRunner.h:
517         (TestRunner):
518
519 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
520
521         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
522         https://bugs.webkit.org/show_bug.cgi?id=91988
523
524         Reviewed by Kenneth Rohde Christiansen.
525
526         Regular key events generated by Qt for the tab key fill both
527         keyCode and keyText, so we should do the same for our fake events.
528
529         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
530         (WTR::EventSenderProxy::keyDown):
531
532 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
533
534         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
535         https://bugs.webkit.org/show_bug.cgi?id=96269
536
537         Reviewed by Kenneth Rohde Christiansen.
538
539         Exported missing testRunner.setSpatialNavigationEnabled() method.
540
541         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
542         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
543         (WTR::InjectedBundle::beginTesting):
544         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
545         (WTR::TestRunner::setSpatialNavigationEnabled):
546         (WTR):
547         * WebKitTestRunner/InjectedBundle/TestRunner.h:
548         (TestRunner):
549
550 2012-09-11  Philippe Liard  <pliard@chromium.org>
551
552         Support LayoutTests on non-rooted devices for Chromium Android.
553         https://bugs.webkit.org/show_bug.cgi?id=95346
554
555         Reviewed by Dirk Pranke.
556
557         We were requiring root permissions to sync resource files with the
558         device by comparing host and device files' timestamp after we
559         synchronized the device and host clocks.
560         We now rely on md5sum provided by Chromium to handle data files
561         synchronization.
562
563         * Scripts/webkitpy/layout_tests/port/chromium.py:
564         (ChromiumPort._check_driver_build_up_to_date):
565         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
566         (ChromiumAndroidDriver.__init__):
567         (ChromiumAndroidDriver._setup_test):
568         (ChromiumAndroidDriver._push_executable):
569         (ChromiumAndroidDriver._push_test_resources):
570         (ChromiumAndroidDriver._read_prompt):
571
572 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
573
574         [Qt] Fix output paths on Windows
575
576         Reviewed by Tor Arne Vestbø.
577
578         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
579         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
580         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
581         incorrect here and instead for the calculation we should use forward slashes.
582
583         * qmake/mkspecs/features/default_pre.prf:
584
585 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
586
587         [Qt] Fix passing of defines from the build system
588
589         We explicitly have to pass -DENABLE_FOO=0 for every single feature
590         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
591         will add it's own defaults if the features are not defined.
592
593         At some point we might want to run a configure-test to inspect what
594         Platform.h will do, so we can sync up the build system's view of
595         the feature-defines with the compile-time situation.
596
597         Reviewed by Simon Hausmann.
598
599         * qmake/mkspecs/features/functions.prf:
600
601 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
602
603         [Qt] Fix --qt option to build-webkit
604
605         Reviewed by Ossy.
606
607         * Scripts/webkitdirs.pm:
608         (buildQMakeProjects):
609
610 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
611
612         [Qt] Add a configure step to the Qt build system
613
614         This allows building the Qt port using just 'qmake WebKit.pro'. Using
615         the build-webkit script is still supported, and will add slightly more
616         logic to the build, such as detecting the need for clean or incremental
617         builds.
618
619         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
620         all things related to configuring the build, such as use/have/enable flags,
621         and these are translated to defines in default_post. Project files should
622         no longer check contains(DEFINES,...) to detect features, but use the new
623         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
624         options have been translated into WEBKIT_CONFIG options as well, and can
625         be checked using build?().
626
627         Reviewed by Simon Hausmann.
628
629         * DumpRenderTree/qt/DumpRenderTree.pro:
630         * MiniBrowser/qt/MiniBrowser.pro:
631         * QtTestBrowser/QtTestBrowser.pro:
632         * Scripts/build-webkit:
633         * Scripts/webkitdirs.pm:
634         (qtFeatureDefaults):
635         (buildQMakeProjects):
636         * Tools.pro:
637         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
638         * WebKitTestRunner/InjectedBundle/Target.pri:
639         * WebKitTestRunner/Target.pri:
640         * qmake/.qmake.cache: Added.
641         * qmake/configure.pri: Removed.
642         * qmake/configure.pro: Removed.
643         * qmake/dump-features: Added.
644         * qmake/mkspecs/features/configure.prf: Added.
645         * qmake/mkspecs/features/default_post.prf:
646         * qmake/mkspecs/features/default_pre.prf:
647         * qmake/mkspecs/features/features.prf:
648         * qmake/mkspecs/features/features.pri:
649         * qmake/mkspecs/features/functions.prf:
650         * qmake/mkspecs/features/gprof.prf:
651         * qmake/mkspecs/features/mac/default_pre.prf:
652         * qmake/mkspecs/features/win32/default_pre.prf:
653
654 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
655
656         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
657         https://bugs.webkit.org/show_bug.cgi?id=96372
658
659         Reviewed by Kenneth Rohde Christiansen.
660
661         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
662
663         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
664         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
665         (WTR::TestRunner::clearApplicationCacheForOrigin):
666         (WTR):
667         * WebKitTestRunner/InjectedBundle/TestRunner.h:
668         (TestRunner):
669
670 2012-09-11  Peter Beverloo  <peter@chromium.org>
671
672         Don't ignore .pak files when making an archive for Android
673         https://bugs.webkit.org/show_bug.cgi?id=96375
674
675         Reviewed by Jochen Eisinger.
676
677         The .pak files do need to be pushed to the device, which is currently
678         preventing the layout test runner from correctly pushing all files.
679
680         * BuildSlaveSupport/built-product-archive:
681         (archiveBuiltProduct):
682
683 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
684
685         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
686         https://bugs.webkit.org/show_bug.cgi?id=96256
687
688         Reviewed by Kenneth Rohde Christiansen.
689
690         Exported TestRunner::setMinimumTimerInterval() method.
691
692         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
693         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
694         (WTR::InjectedBundle::beginTesting):
695         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
696         (WTR::TestRunner::setMinimumTimerInterval):
697         (WTR):
698         * WebKitTestRunner/InjectedBundle/TestRunner.h:
699         (TestRunner):
700
701 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
702
703         MediaStream API: add RTCPeerConnection::onnegotiationneeded
704         https://bugs.webkit.org/show_bug.cgi?id=96097
705
706         Reviewed by Adam Barth.
707
708         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
709         (MockWebRTCPeerConnectionHandler::addStream):
710         (MockWebRTCPeerConnectionHandler::removeStream):
711
712 2012-09-11  Peter Beverloo  <peter@chromium.org>
713
714         Recognize the "--chromium-android" argument in run-webkit-tests
715         https://bugs.webkit.org/show_bug.cgi?id=96369
716
717         Reviewed by Jochen Eisinger.
718
719         Chromium for the Android platform cannot determine the platform based on
720         the host itself, so we'll use the --chromium-android argument as the build
721         master passes to run-webkit-tests. Make sure the layout test runner
722         can pick the right port when doing so.
723
724         * Scripts/run-webkit-tests:
725         * Scripts/webkitpy/layout_tests/port/factory.py:
726         (port_options):
727
728 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
729
730         [QT] Fix build with newer qmake from Qt 5
731
732         Rubber-stamped by Tor Arne Vestbø.
733
734         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
735         it with the use of QT_HOST_DATA/mkspecs.
736         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
737
738         * Scripts/webkitdirs.pm:
739         (builtDylibPathForName):
740         (qtMakeCommand):
741
742 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
743
744         [Qt] Remove Qt 4 syncqt, no longer needed
745
746         Reviewed by Simon Hausmann.
747
748         * qmake/syncqt-4.8: Removed.
749
750 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
751
752         [Qt][WK2] Fix the build with recent Qt5
753         https://bugs.webkit.org/show_bug.cgi?id=96283
754
755         Reviewed by Simon Hausmann.
756
757         We should not use deprecated Qt API because doing that results
758         in build failure since all the deprecated API was disabled
759         in qtbase (https://codereview.qt-project.org/#change,24890).
760
761         * DumpRenderTree/qt/main.cpp:
762         (main):
763         * MiniBrowser/qt/MiniBrowserApplication.cpp:
764         (MiniBrowserApplication::notify):
765         * MiniBrowser/qt/raw/View.cpp:
766         (View::exposeEvent):
767         (main):
768
769 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
770
771         WTR needs an implementation of applicationCacheDiskUsageForOrigin
772         https://bugs.webkit.org/show_bug.cgi?id=87188
773
774         Reviewed by Kenneth Rohde Christiansen.
775
776         Add implementation for applicationCacheDiskUsageForOrigin()
777         in WebKitTestRunner.
778
779         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
780         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
781         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
782         (WTR):
783         * WebKitTestRunner/InjectedBundle/TestRunner.h:
784         (TestRunner):
785
786 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
787
788         Properly expose <legend> elements to ATs
789         https://bugs.webkit.org/show_bug.cgi?id=84137
790
791         Reviewed by Chris Fleizach.
792
793         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
794         the expected platform role, ATK_ROLE_LABEL. Also established the needed
795         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
796
797         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
798         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
799
800 2012-09-10  Jer Noble  <jer.noble@apple.com>
801
802         Unreviewed; rolling out r128081.
803         http://trac.webkit.org/changeset/128081
804         https://bugs.webkit.org/show_bug.cgi?id=96134
805
806         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
807
808         * DumpRenderTree/TestRunner.cpp:
809         (TestRunner::TestRunner):
810         (TestRunner::staticFunctions):
811         * DumpRenderTree/TestRunner.h:
812         (TestRunner):
813         * DumpRenderTree/mac/FrameLoadDelegate.mm:
814         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
815         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
816         (WTR::InjectedBundlePage::InjectedBundlePage):
817         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
818         (InjectedBundlePage):
819         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
820         (WTR::TestRunner::TestRunner):
821         * WebKitTestRunner/InjectedBundle/TestRunner.h:
822         (TestRunner):
823
824 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
825
826         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
827         https://bugs.webkit.org/show_bug.cgi?id=96205
828
829         Reviewed by Tony Chang.
830
831         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
832         internally, which means that it would support only 1 TestExpectations file per port. This
833         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
834         and efl-wk1 -> efl).
835
836         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
837         instead so that all the ports TestExpectations are recognized. The ports are also
838         constructed twice, with "webkit_test_runner" option set to True and False so that we
839         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
840
841         * Scripts/webkitpy/style/checkers/test_expectations.py:
842         (TestExpectationsChecker._determine_port_from_expectations_path):
843         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
844         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
845
846 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
847
848         [WTR] Generated source files should include config.h
849         https://bugs.webkit.org/show_bug.cgi?id=96254
850
851         Reviewed by Benjamin Poulain.
852
853         Current coding style has encouraged to include config.h at the first position,
854         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
855         this rule.
856         Therefore, this patch added it.
857
858         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
859         (_generateImplementationFile):
860
861 2012-09-10  Rick Byers  <rbyers@chromium.org>
862
863         Add handling of new GestureTapCancel in DRT
864         
865         https://bugs.webkit.org/show_bug.cgi?id=96183
866
867         Reviewed by Adam Barth.
868
869         * DumpRenderTree/chromium/TestWebPlugin.cpp:
870         (TestWebPlugin::handleInputEvent):
871
872 2012-09-10  Brady Eidson  <beidson@apple.com>
873
874         Javascript in foreground tabs should not wait synchronously for plug-ins to load
875         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
876
877         Reviewed by Geoff Garen.
878
879         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
880
881         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
882         (PluginObject):
883         (SlowNPPNew::PluginObject::PluginObject):
884         (SlowNPPNew::PluginObject::~PluginObject):
885         (SlowNPPNew::PluginObject::hasProperty):
886         (SlowNPPNew::PluginObject::getProperty):
887         (SlowNPPNew::NPP_GetValue):
888         (SlowNPPNew):
889
890 2012-09-10  Tim Horton  <timothy_horton@apple.com>
891
892         WKTR often reports an unresponsive WebProcess on Mac bots
893         https://bugs.webkit.org/show_bug.cgi?id=95906
894
895         Reviewed by Dan Bernstein.
896
897         Attempt to work around resource contention issues by increasing the NRWT
898         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
899
900         * Scripts/webkitpy/layout_tests/port/base.py:
901         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
902         * WebKitTestRunner/TestController.cpp:
903         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
904
905 2012-09-07  Jer Noble  <jer.noble@apple.com>
906
907         <audio> and <video> should send Do Not Track when appropriate
908         https://bugs.webkit.org/show_bug.cgi?id=96134
909
910         Reviewed by Eric Carlson.
911
912         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
913         WTR. Add FrameLoaderClient client methods for retrieving that value.
914
915         * DumpRenderTree/TestRunner.cpp:
916         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
917         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
918         * DumpRenderTree/TestRunner.h:
919         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
920         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
921         * DumpRenderTree/mac/FrameLoadDelegate.mm:
922         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
923             Pass the question on to the TestRunner.
924         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
925         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
926         (WTR::InjectedBundlePage::InjectedBundlePage):
927             Add the setShouldSendDoNotTrackHTTPHeader client function.
928         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
929             Pass the question on to the TestRunner.
930         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
931         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
932         * WebKitTestRunner/InjectedBundle/TestRunner.h:
933         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
934         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
935
936 2012-09-10  Ojan Vafai  <ojan@chromium.org>
937
938         Make EFL bots work on the flakiness dashboard
939         https://bugs.webkit.org/show_bug.cgi?id=96164
940
941         Reviewed by Tony Chang.
942
943         Also, update outdated unittests that had started failing.
944
945         * TestResultServer/static-dashboards/builders.js:
946         (isWebkitTestRunner):
947         * TestResultServer/static-dashboards/flakiness_dashboard.js:
948         (nonChromiumPlatform):
949         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
950         (test):
951
952 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
953
954         [chromium] MediaStream API: Remove the Descriptor postfix
955         https://bugs.webkit.org/show_bug.cgi?id=96268
956
957         Reviewed by Adam Barth.
958
959         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
960         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
961
962         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
963         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
964         (MockWebRTCPeerConnectionHandler::createOffer):
965         (MockWebRTCPeerConnectionHandler::createAnswer):
966         (MockWebRTCPeerConnectionHandler::setLocalDescription):
967         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
968         (MockWebRTCPeerConnectionHandler::localDescription):
969         (MockWebRTCPeerConnectionHandler::remoteDescription):
970         (MockWebRTCPeerConnectionHandler::addICECandidate):
971         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
972         (MockWebRTCPeerConnectionHandler):
973
974 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
975
976         [Gtk] failure to build jhbuild dependencies with cups 1.6
977         https://bugs.webkit.org/show_bug.cgi?id=95991
978
979         Reviewed by Gustavo Noronha Silva.
980
981         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
982         building with cups >= 1.6 [GNOME #670373].
983
984         * gtk/jhbuild.modules:
985
986 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
987
988         [EFL][DRT] Encoding issue in printed console messages
989         https://bugs.webkit.org/show_bug.cgi?id=96263
990
991         Reviewed by Kenneth Rohde Christiansen.
992
993         Correctly handle CONSOLE messages that contain non-ascii
994         characters in EFL's DRT. We need to use String::fromUTF8()
995         to construct a WTF::String from a raw string.
996
997         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
998         (onConsoleMessage):
999
1000 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1001
1002         [WK2][WTR] User style sheet location should be reset before each test
1003         https://bugs.webkit.org/show_bug.cgi?id=96262
1004
1005         Reviewed by Kenneth Rohde Christiansen.
1006
1007         User style sheet location is reset before each test now.
1008
1009         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1010         (WTR::InjectedBundle::beginTesting):
1011
1012 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
1013
1014         Fix build of WTR with Qt on Windows
1015         https://bugs.webkit.org/show_bug.cgi?id=96249
1016
1017         Reviewed by Kenneth Rohde Christiansen.
1018
1019         Windows loves to define min and max as macros, which beautifully
1020         clashes in many places where min and max are used as variable or method
1021         names. It can be convinced not to do this when min and max are already
1022         define as macros (expanding to themselves). We have this kind of
1023         workaround in config.h files all over WebKit and as it turns out when
1024         building WTR with Qt on Windows we do end up with such a clash. Therefore
1025         we need the same workaround.
1026
1027         * WebKitTestRunner/config.h:
1028
1029 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
1030
1031         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
1032         https://bugs.webkit.org/show_bug.cgi?id=95936
1033
1034         Reviewed by Kenneth Rohde Christiansen.
1035
1036         Enable interactive form validation setting in WebKitTestRunner as
1037         we are currently doing in DumpRenderTree. This is needed for some
1038         tests to pass.
1039
1040         * WebKitTestRunner/TestController.cpp:
1041         (WTR::TestController::resetStateToConsistentValues):
1042
1043 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
1044
1045         Clean up the code in XvfbDriver
1046         https://bugs.webkit.org/show_bug.cgi?id=96202
1047
1048         Reviewed by Philippe Normand.
1049
1050         Changes:
1051         - Remove unneeded imports,
1052         - assign the _lock_file member variable when the display number is determined,
1053         - no need for parentheses around a single string format argument,
1054         - use FileSystem.exists method when checking if lock file is present as it
1055         makes the intention much more clearer.
1056
1057         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1058         (XvfbDriver._start):
1059         (XvfbDriver.stop):
1060
1061 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
1062
1063         Make the String initialization on the function side of String::number()
1064         https://bugs.webkit.org/show_bug.cgi?id=95940
1065
1066         Reviewed by Benjamin Poulain.
1067
1068         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
1069         (testBoundaries):
1070         (testNumbers):
1071
1072 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
1073
1074         [WK2] expose element rect for color input type
1075         https://bugs.webkit.org/show_bug.cgi?id=91664
1076
1077         Reviewed by Simon Hausmann.
1078
1079         Update the QML logic in MiniBrowser to take advantage of this.
1080         The picker size is now hardcoded and we try to place it below the
1081         input element if possible.
1082
1083         * MiniBrowser/qt/qml/ColorChooser.qml:
1084
1085 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
1086
1087         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
1088         https://bugs.webkit.org/show_bug.cgi?id=95329
1089
1090         Reviewed by Kenneth Rohde Christiansen.
1091
1092         Explicitely disable TabToLinks setting in WebKitTestRunner.
1093         Tests override the "WebKitTabToLinksPreferenceKey" preference
1094         to enable it.
1095
1096         * WebKitTestRunner/TestController.cpp:
1097         (WTR::TestController::resetStateToConsistentValues):
1098
1099 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
1100
1101         webkit.py gdb pretty printer can't print CString
1102         https://bugs.webkit.org/show_bug.cgi?id=96068
1103
1104         Reviewed by Tony Chang.
1105
1106         Update WTFCStringPrinter to follow r126191.
1107
1108         * gdb/webkit.py:
1109         (WTFCStringPrinter.to_string):
1110
1111 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
1112
1113         Rename the ustring() accessor to string()
1114         https://bugs.webkit.org/show_bug.cgi?id=95919
1115
1116         Reviewed by Geoffrey Garen.
1117
1118         Update EFL's DRT.
1119
1120         Fix some string conversion that have been made useless
1121         with recent changes.
1122
1123         * DumpRenderTree/efl/EventSender.cpp:
1124         (keyPadNameFromJSValue):
1125         (keyNameFromJSValue):
1126         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1127         (TestRunner::queueLoad):
1128         (TestRunner::addOriginAccessWhitelistEntry):
1129         (TestRunner::removeOriginAccessWhitelistEntry):
1130         (TestRunner::setUserStyleSheetLocation):
1131         (TestRunner::setValueForUser):
1132         (TestRunner::elementDoesAutoCompleteForElementWithId):
1133         (TestRunner::execCommand):
1134         (TestRunner::findString):
1135         (TestRunner::isCommandEnabled):
1136         (TestRunner::clearApplicationCacheForOrigin):
1137         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1138         (TestRunner::pauseAnimationAtTimeOnElementWithId):
1139         (TestRunner::pauseTransitionAtTimeOnElementWithId):
1140         (toInt):
1141         (TestRunner::overridePreference):
1142         (TestRunner::addUserScript):
1143         (TestRunner::addUserStyleSheet):
1144         (TestRunner::evaluateInWebInspector):
1145         (TestRunner::evaluateScriptInIsolatedWorld):
1146         (TestRunner::setTextDirection):
1147         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
1148         (LoadItem::invoke):
1149         (LoadHTMLStringItem::invoke):
1150         (ScriptItem::invoke):
1151
1152 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
1153
1154         Extend third-party storage blocking API to optionally allow blocking all storage
1155         https://bugs.webkit.org/show_bug.cgi?id=95915
1156
1157         Reviewed by Brady Eidson.
1158
1159         Modified API test to use new revised API.
1160
1161         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1162         (TestWebKitAPI::TEST):
1163
1164 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
1165
1166         AX: WebCore accessibility roles should be cross-platform
1167         https://bugs.webkit.org/show_bug.cgi?id=94870
1168
1169         Reviewed by Chris Fleizach.
1170
1171         Add debug strings to Chromium for new accessibility roles.
1172
1173         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1174         (roleToString):
1175
1176 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
1177
1178         AX: Chromium needs access to canvasHasFallbackContent
1179         https://bugs.webkit.org/show_bug.cgi?id=96124
1180
1181         Reviewed by Chris Fleizach.
1182
1183         Distinguish between canvas roles with and without fallback
1184         content on Chromium.
1185
1186         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1187         (getRole):
1188
1189 2012-09-07  Ojan Vafai  <ojan@chromium.org>
1190
1191         Handle non-existant TestExpectations files gracefully
1192         https://bugs.webkit.org/show_bug.cgi?id=96149
1193
1194         Reviewed by Eric Seidel.
1195
1196         Even when we get rid of Skipped files, we shouldn't have each port
1197         require a TestExpectations file for each platform if it doesn't
1198         need one.
1199
1200         * Scripts/webkitpy/layout_tests/port/base.py:
1201         (Port.expectations_dict):
1202         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1203         (PortTest.test_nonexistant_expectations):
1204
1205 2012-09-07  Tony Chang  <tony@chromium.org>
1206
1207         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
1208         https://bugs.webkit.org/show_bug.cgi?id=96136
1209
1210         Reviewed by Ojan Vafai.
1211
1212         When we renamed the file to TestExpectations, it was no longer considered a text file so
1213         it was no longer being checked. Since then, test_expectations_overrides() has been removed
1214         from the port object, so I've removed that from the check. I'm not sure what it was
1215         supposed to do.
1216
1217         * Scripts/webkitpy/style/checker.py:
1218         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
1219         * Scripts/webkitpy/style/checkers/test_expectations.py:
1220         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
1221         (TestExpectationsChecker.check): Remove overrides param.
1222         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1223         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
1224
1225 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
1226
1227         [EFL] Use same default minimum logical font size in DRT and WTR
1228         https://bugs.webkit.org/show_bug.cgi?id=96116
1229
1230         Reviewed by Martin Robinson.
1231
1232         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1233         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
1234         logical font size to 9 to match the value used in WTR.
1235         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1236         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
1237         logical font size to 9 (default value in WK2)
1238
1239 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
1240
1241         MediaStream API: add RTCPeerConnection::createAnswer
1242         https://bugs.webkit.org/show_bug.cgi?id=96092
1243
1244         Reviewed by Adam Barth.
1245
1246         Expanding and enhancing MockWebRTCPeerConnectionHandler.
1247
1248         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1249         (MockWebRTCPeerConnectionHandler::createOffer):
1250         (MockWebRTCPeerConnectionHandler::createAnswer):
1251         (MockWebRTCPeerConnectionHandler::setLocalDescription):
1252         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
1253         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1254         (MockWebRTCPeerConnectionHandler):
1255
1256 2012-09-07  Dean Jackson  <dino@apple.com>
1257
1258         Unreviewed changes to watchlist.
1259
1260         - Add new WebGL and Filters definitions
1261         - Add myself to OpenGL bugs
1262
1263         * Scripts/webkitpy/common/config/watchlist:
1264
1265 2012-09-07  Peter Beverloo  <peter@chromium.org>
1266
1267         Actually trigger the Android Tester
1268         https://bugs.webkit.org/show_bug.cgi?id=96118
1269
1270         Reviewed by Adam Barth.
1271
1272         * BuildSlaveSupport/build.webkit.org-config/config.json:
1273
1274 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
1275
1276         New time input needs accessibility
1277         https://bugs.webkit.org/show_bug.cgi?id=96032
1278
1279         Reviewed by Chris Fleizach.
1280
1281         Add support for valueDescription for testing.
1282
1283         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1284         (getValueDescription):
1285         (AccessibilityUIElement::AccessibilityUIElement):
1286         (AccessibilityUIElement::valueDescriptionGetterCallback):
1287         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
1288         (AccessibilityUIElement):
1289
1290 2012-09-07  Peter Beverloo  <peter@chromium.org>
1291
1292         Add the google-android-tests build slave to the master's config
1293         https://bugs.webkit.org/show_bug.cgi?id=96113
1294
1295         Reviewed by Csaba Osztrogonác.
1296
1297         * BuildSlaveSupport/build.webkit.org-config/config.json:
1298
1299 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1300
1301         [WK2] [EFL] Set theme for WebKit2 API test runner
1302         https://bugs.webkit.org/show_bug.cgi?id=96100
1303
1304         Reviewed by Kenneth Rohde Christiansen.
1305
1306         Set the theme generated by the build for the WebKit2 API test runner.
1307
1308         * TestWebKitAPI/PlatformEfl.cmake:
1309         * TestWebKitAPI/efl/PlatformWebView.cpp:
1310         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1311
1312 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
1313
1314         Unreviewed. Add Gábor Ballabás as contributor.
1315
1316         * Scripts/webkitpy/common/config/committers.py:
1317
1318 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
1319
1320         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
1321         https://bugs.webkit.org/show_bug.cgi?id=96078
1322
1323         Reviewed by Tor Arne Vestbø.
1324
1325         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
1326
1327         * qmake/mkspecs/features/default_pre.prf:
1328
1329 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
1330
1331         [EFL] Add TestExpectations file for efl-wk1
1332         https://bugs.webkit.org/show_bug.cgi?id=96019
1333
1334         Reviewed by Gyuyoung Kim.
1335
1336         Update TestExpectations cascading for EFL port
1337         so that we use efl-wk1 -> efl search paths
1338         for WebKit1 EFL.
1339
1340         * Scripts/webkitpy/layout_tests/port/efl.py:
1341         (EflPort._search_paths):
1342
1343 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
1344
1345         [NRWT] XvfbDriver should stop the Xvfb more aggressively
1346         https://bugs.webkit.org/show_bug.cgi?id=95097
1347
1348         Reviewed by Dirk Pranke.
1349
1350         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
1351         terminating the process does not always work as expected, leading to timeouts
1352         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
1353         as it's not removed by the killed Xvfb process.
1354
1355         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
1356         is tested in different circumstances - whether pixel tests are enabled or not,
1357         with an arbitrary worker number or with an Xorg process already running on the system.
1358         The stopping of the driver is tested by checking that the Xvfb process is truly killed
1359         and then set to None.
1360
1361         * BuildSlaveSupport/kill-old-processes:
1362         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
1363         is left running, potentially clogging up a display at a certain position.
1364         * Scripts/webkitpy/common/system/executive_mock.py:
1365         (MockExecutive.__init__):
1366         The _running_pids is now a dictionary with process names as keys and pids
1367         as values.
1368         (MockExecutive.check_running_pid):
1369         Check whether the passed-in pid is in the _running_pids dictionary's values.
1370         (MockExecutive):
1371         (MockExecutive.running_pids):
1372         This method returns the list of all the process pids of which the name passes
1373         through the process_name_filter.
1374         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1375         Use the Executive object of the port's host to check for running pids and open
1376         new subprocesses or kill them throughout the class.
1377         (XvfbDriver._start):
1378         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
1379         start the server process after it's created.
1380         (XvfbDriver.stop):
1381         Now kills the Xvfb process instead of terminating it and waiting for it to close.
1382         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
1383         (XvfbDriverTest):
1384         (XvfbDriverTest.make_driver):
1385         (XvfbDriverTest.assertDriverStartSuccessful):
1386         (XvfbDriverTest.test_start_no_pixel_tests):
1387         (XvfbDriverTest.test_start_pixel_tests):
1388         (XvfbDriverTest.test_start_arbitrary_worker_number):
1389         (XvfbDriverTest.test_start_existing_xorg_process):
1390         (XvfbDriverTest.test_stop):
1391         (XvfbDriverTest.test_stop.FakeXvfbProcess):
1392
1393 2012-09-06  Peter Beverloo  <peter@chromium.org>
1394
1395         Introduce the Chromium Android Release (Tests) bot
1396         https://bugs.webkit.org/show_bug.cgi?id=95980
1397
1398         Reviewed by Adam Barth.
1399
1400         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
1401         which will be running layout tests on actual Android devices. Right now,
1402         four Galaxy Nexus phones are attached.
1403
1404         * BuildSlaveSupport/build.webkit.org-config/config.json:
1405
1406 2012-09-06  James Robinson  <jamesr@chromium.org>
1407
1408         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
1409         https://bugs.webkit.org/show_bug.cgi?id=96007
1410
1411         Reviewed by Adrienne Walker.
1412
1413         Fixes initialization / settings code to use WebCompositorSupport.
1414
1415         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1416         (main):
1417         * DumpRenderTree/chromium/TestShell.cpp:
1418         (TestShell::initialize):
1419         (TestShell::setPerTilePaintingEnabled):
1420
1421 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
1422
1423         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
1424         https://bugs.webkit.org/show_bug.cgi?id=95995
1425
1426         Reviewed by Kenneth Rohde Christiansen.
1427
1428         Provide proper implementation for PlatformWebView::windowFrame()
1429         in EFL's WebKitTestRunner.
1430
1431         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1432         (WTR::PlatformWebView::windowFrame):
1433
1434 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
1435
1436         Fix WTF.Lrint on 32-bit platforms
1437         https://bugs.webkit.org/show_bug.cgi?id=96003
1438
1439         Reviewed by Benjamin Poulain.
1440
1441         Fixed failing WTF.Lrint test on 32-bit platforms.
1442
1443         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1444         (TestWebKitAPI::TEST):
1445
1446 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
1447
1448         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
1449         https://bugs.webkit.org/show_bug.cgi?id=95839
1450
1451         Reviewed by Adam Barth.
1452
1453         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
1454         up the task definitions a bit. There was no need to have them in the header file.
1455
1456         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1457         (RTCSessionDescriptionRequestSuccededTask):
1458         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
1459         (RTCSessionDescriptionRequestFailedTask):
1460         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
1461         (RTCVoidRequestTask):
1462         (RTCVoidRequestTask::RTCVoidRequestTask):
1463         (MockWebRTCPeerConnectionHandler::createOffer):
1464         (MockWebRTCPeerConnectionHandler::setLocalDescription):
1465         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
1466         (MockWebRTCPeerConnectionHandler::localDescription):
1467         (MockWebRTCPeerConnectionHandler::remoteDescription):
1468         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1469         (MockWebRTCPeerConnectionHandler):
1470
1471 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
1472
1473         [Qt] Fix build on Mac OS X 10.6
1474         https://bugs.webkit.org/show_bug.cgi?id=95200
1475
1476         Reviewed by Tor Arne Vestbø.
1477
1478         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
1479         10.7 and newer.
1480
1481         * qmake/mkspecs/features/features.prf:
1482
1483 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
1484
1485         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
1486         https://bugs.webkit.org/show_bug.cgi?id=95973
1487
1488         Reviewed by Kenneth Rohde Christiansen.
1489
1490         Correctly map "addSelectionKey" to "Control" modifier
1491         in WKTR's EventSender on other OSes than Mac OS X,
1492         instead of mapping it to the "Meta" modifier.
1493
1494         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1495         (WTR::parseModifier):
1496
1497 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
1498
1499         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
1500         https://bugs.webkit.org/show_bug.cgi?id=95710
1501
1502         Reviewed by Dirk Pranke.
1503
1504         The stdout / stderr output can be None so make sure
1505         we won't raise an exception in this case.
1506
1507         * Scripts/webkitpy/layout_tests/port/driver.py:
1508         (Driver.run_test):
1509
1510 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
1511
1512         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
1513         https://bugs.webkit.org/show_bug.cgi?id=95849
1514
1515         Reviewed by Kenneth Rohde Christiansen.
1516
1517         Sanitize URLs passed by the user as program
1518         argument or typed in the URL bar in order to
1519         be more tolerant.
1520
1521         * EWebLauncher/CMakeLists.txt:
1522         * EWebLauncher/main.c:
1523         (main):
1524         * EWebLauncher/url_bar.c:
1525         (_url_bar_url_get_with_protocol):
1526         (on_urlbar_key_down):
1527         * EWebLauncher/url_utils.c: Added.
1528         (has_scheme):
1529         (url_from_user_input): Add utility function to construct a
1530         URL from user input.
1531         * EWebLauncher/url_utils.h: Added.
1532         * MiniBrowser/efl/CMakeLists.txt:
1533         * MiniBrowser/efl/main.c:
1534         (main):
1535
1536 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
1537
1538         [Qt] Various small Windows / MSVC build fixes
1539         https://bugs.webkit.org/show_bug.cgi?id=95934
1540
1541         Reviewed by Kenneth Rohde Christiansen.
1542
1543         setFocus takes a boolean as argument: Don't try to implicitly convert
1544         an enum to a boolean, MSVC doesn't like that. The intent here is to
1545         enable focus, so just pass true.
1546
1547         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1548         (WTR::PlatformWebView::focus):
1549
1550 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
1551
1552         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
1553         https://bugs.webkit.org/show_bug.cgi?id=95965
1554
1555         Reviewed by Tor Arne Vestbø.
1556
1557         Add ANGLE as a static library module to the Qt WebKit build system.
1558
1559         * qmake/mkspecs/features/default_post.prf:
1560         * qmake/mkspecs/modules/angle.prf: Added.
1561
1562 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
1563
1564         [WK2] Make [Qt]ViewportHandler cross platform
1565         https://bugs.webkit.org/show_bug.cgi?id=91257
1566
1567         Reviewed by Kenneth Rohde Christiansen.
1568
1569         Remove initial scale from viewport info item since it is
1570         set to -1 after applied thus it does not hold any valuable
1571         information.
1572
1573         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
1574
1575 2012-09-05  Tony Chang  <tony@chromium.org>
1576
1577         [chromium] Remove dependency on webkit_user_agent
1578         https://bugs.webkit.org/show_bug.cgi?id=95886
1579
1580         Reviewed by Adam Barth.
1581
1582         The code isn't used by DumpRenderTree.
1583
1584         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1585
1586 2012-09-05  Rick Byers  <rbyers@chromium.org>
1587
1588         Update chromium DumpRenderTree for new WebGestureEvent fields
1589         https://bugs.webkit.org/show_bug.cgi?id=95573
1590
1591         Reviewed by James Robinson.
1592
1593         Update EventSender to write gesture details into the appropriate
1594         type-specific WebGestureEvent fields.
1595         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
1596         (EventSender::gestureEvent):
1597         (EventSender::gestureFlingStart):
1598
1599 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
1600
1601         NRWT lies about the number of tests that it's skipping when used with --repeat-each
1602         https://bugs.webkit.org/show_bug.cgi?id=95789
1603
1604         Reviewed by Ojan Vafai.
1605
1606         Fix miscalculation in log message.
1607
1608         * Scripts/webkitpy/layout_tests/views/printing.py:
1609         (Printer.print_found):
1610
1611 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
1612
1613         Unreviewed, rolling out r127612, r127660, and r127664.
1614         http://trac.webkit.org/changeset/127612
1615         http://trac.webkit.org/changeset/127660
1616         http://trac.webkit.org/changeset/127664
1617         https://bugs.webkit.org/show_bug.cgi?id=95920
1618
1619         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1620         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
1621         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
1622         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
1623         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
1624         (MockWebRTCPeerConnectionHandler::createOffer):
1625         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1626         (MockWebRTCPeerConnectionHandler):
1627         (SuccessCallbackTask):
1628         (FailureCallbackTask):
1629
1630 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1631
1632         Ignore-metrics includes scroll offsets.
1633         https://bugs.webkit.org/show_bug.cgi?id=95845
1634
1635         Reviewed by Dirk Pranke.
1636
1637         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
1638
1639         * Scripts/old-run-webkit-tests:
1640         (stripMetrics):
1641         * Scripts/webkitpy/layout_tests/port/driver.py:
1642         (DriverOutput):
1643
1644 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
1645
1646         Unreviewed test fix.
1647
1648         Including a plugin source file into the build that was added in r127595.
1649
1650         * GNUmakefile.am:
1651
1652 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
1653
1654         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
1655         https://bugs.webkit.org/show_bug.cgi?id=95839
1656
1657         Reviewed by Adam Barth.
1658
1659         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
1660         up the task definitions a bit. There was no need to have them in the header file.
1661
1662         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1663         (RTCSessionDescriptionRequestSuccededTask):
1664         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
1665         (RTCSessionDescriptionRequestFailedTask):
1666         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
1667         (RTCVoidRequestTask):
1668         (RTCVoidRequestTask::RTCVoidRequestTask):
1669         (MockWebRTCPeerConnectionHandler::createOffer):
1670         (MockWebRTCPeerConnectionHandler::setLocalDescription):
1671         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
1672         (MockWebRTCPeerConnectionHandler::localDescription):
1673         (MockWebRTCPeerConnectionHandler::remoteDescription):
1674         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1675         (MockWebRTCPeerConnectionHandler):
1676
1677 2012-09-05  Kangil Han  <kangil.han@samsung.com>
1678
1679         [EFL] Remove '+=' usage in String
1680         https://bugs.webkit.org/show_bug.cgi?id=95808
1681
1682         Reviewed by Benjamin Poulain.
1683
1684         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
1685
1686         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1687         (descriptionSuitableForTestResult):
1688
1689 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
1690
1691         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
1692         https://bugs.webkit.org/show_bug.cgi?id=95842
1693
1694         Reviewed by Kenneth Rohde Christiansen.
1695
1696         Provide proper implementation for TestRunner::pathToLocalResource()
1697         in EFL WKTR, identical to the one for DumpRenderTree.
1698
1699         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
1700         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
1701         are found my WebKitTestRunner.
1702
1703         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1704         (WTR::TestRunner::pathToLocalResource):
1705
1706 2012-09-05  Brady Eidson  <beidson@apple.com>
1707
1708         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
1709         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
1710
1711         Reviewed by Andy Estes.
1712
1713         Add a plug-in that always fails to initialize:
1714         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
1715         (NPPNewFails):
1716         (NPPNewFails::NPPNewFails):
1717         (NPPNewFails::NPP_New):
1718
1719         Add it to all the project files:
1720         * DumpRenderTree/DumpRenderTree.gypi:
1721         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1722         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1723         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1724         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1725
1726 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1727
1728         [Qt] Fix makefile race condition between derived sources and target
1729
1730         r121966 removed too much of the old qmake logic, including the rule
1731         that ensured that qmake_all would not trigger dual runs of qmake --
1732         one of the derived sources -qmake-all rule, and one for making the
1733         derived sources.
1734
1735         We now follow a similar pattern as before, by introducing a custom
1736         target that explicitly depends on the derived sources' qmake-all before
1737         doing a manual run of make. That ensures a single qmake run for the derived
1738         sources.
1739
1740         https://bugs.webkit.org/show_bug.cgi?id=93847
1741
1742         Reviewed by Csaba Osztrogonác.
1743
1744         * qmake/mkspecs/features/functions.prf:
1745
1746 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
1747
1748         WKTR doesn't implement dumpWillCacheResponse()
1749         https://bugs.webkit.org/show_bug.cgi?id=94607
1750
1751         Reviewed by Kenneth Rohde Christiansen.
1752
1753         Define shouldCacheResponse() callback in resource
1754         load client and provide implementation for
1755         dumpWillCacheResponse() in WebKitTestRunner.
1756
1757         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1758         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1759         (WTR::InjectedBundlePage::InjectedBundlePage):
1760         (WTR::InjectedBundlePage::shouldCacheResponse):
1761         (WTR):
1762         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1763         (InjectedBundlePage):
1764         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1765         (WTR::TestRunner::TestRunner):
1766         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1767         (WTR::TestRunner::dumpWillCacheResponse):
1768         (WTR::TestRunner::shouldDumpWillCacheResponse):
1769         (TestRunner):
1770
1771 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
1772
1773         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
1774         https://bugs.webkit.org/show_bug.cgi?id=92735
1775
1776         Reviewed by Hajime Morita.
1777
1778         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
1779
1780         * DumpRenderTree/TestRunner.cpp:
1781         (TestRunner::staticFunctions):
1782         * DumpRenderTree/TestRunner.h:
1783         (TestRunner):
1784         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1785         (TestRunner::addUserStyleSheet):
1786         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1787         (DRTTestRunner::DRTTestRunner):
1788         (DRTTestRunner::hasCustomPageSizeStyle):
1789         * DumpRenderTree/chromium/DRTTestRunner.h:
1790         (DRTTestRunner):
1791         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1792         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1793         * DumpRenderTree/mac/TestRunnerMac.mm:
1794         * DumpRenderTree/qt/TestRunnerQt.cpp:
1795         (TestRunner::evaluateScriptInIsolatedWorld):
1796         * DumpRenderTree/qt/TestRunnerQt.h:
1797         (TestRunner):
1798         * DumpRenderTree/win/TestRunnerWin.cpp:
1799         * DumpRenderTree/wx/TestRunnerWx.cpp:
1800         (TestRunner::abortModal):
1801         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1802         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1803         (WTR):
1804         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1805         (TestRunner):
1806
1807 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
1808
1809         [Qt] Automate the use of AllInOne files in the Qt build
1810         https://bugs.webkit.org/show_bug.cgi?id=95837
1811
1812         Reviewed by Tor Arne Vestbø.
1813
1814         New feature file that implements the all-in-one file automation by
1815         adding the requested all-in-one files to SOURCES and removing the files
1816         it includes from SOURCES.
1817
1818         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
1819
1820 2012-09-04  Tim Horton  <timothy_horton@apple.com>
1821
1822         Have NRWT log more output when crash logs are missing
1823         https://bugs.webkit.org/show_bug.cgi?id=95814
1824
1825         Reviewed by Dan Bernstein.
1826
1827         Log the stderr and stdout of the test, in order to provide slightly more
1828         context when the WebProcess times out while running tests.
1829
1830         * Scripts/webkitpy/layout_tests/port/driver.py:
1831         (Driver.run_test):
1832
1833 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
1834
1835         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
1836         https://bugs.webkit.org/show_bug.cgi?id=95770
1837
1838         Reviewed by Adam Barth.
1839
1840         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1841         (ChromiumAndroidDriver.__init__):
1842         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
1843         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
1844         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
1845         (ChromiumAndroidDriver._push_executable):
1846         (ChromiumAndroidDriver._push_fonts):
1847         (ChromiumAndroidDriver._push_test_resources):
1848         (ChromiumAndroidDriver._run_adb_command):
1849         (ChromiumAndroidDriver._get_last_stacktrace):
1850         (ChromiumAndroidDriver._get_crash_log):
1851         (ChromiumAndroidDriver._start):
1852         (ChromiumAndroidDriver._start_once):
1853         (ChromiumAndroidDriver._start_once.deadlock_detector):
1854         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1855         (ChromiumAndroidDriverTest.test_get_crash_log):
1856
1857 2012-09-04  Satish Sampath  <satish@chromium.org>
1858
1859         Run git commands within the checkout directory
1860         https://bugs.webkit.org/show_bug.cgi?id=95742
1861
1862         Reviewed by Eric Seidel.
1863
1864         git commands run from scm/git.py are sometimes run with cwd set to the
1865         checkout_root and other times with whatever directory was the default cwd.
1866         Instead all these should run with the checkout root set as the cwd
1867         (except where we explicitly need a different path)
1868
1869         * Scripts/webkitpy/common/checkout/scm/git.py:
1870         (Git._run_git):
1871         (Git.find_checkout_root):
1872         (Git.discard_local_commits):
1873         (Git.local_commits):
1874         (Git.working_directory_is_clean):
1875         (Git.clean_working_directory):
1876         (Git.add_list):
1877         (Git.delete_list):
1878         (Git.exists):
1879         (Git._current_branch):
1880         (Git._changes_files_for_commit):
1881         (Git.revisions_changing_file):
1882         (Git.svn_revision):
1883         (Git._run_git_svn_find_rev):
1884         (Git.contents_at_revision):
1885         (Git.diff_for_file):
1886         (Git.show_head):
1887         (Git.committer_email_for_revision):
1888         (Git.apply_reverse_diff):
1889         (Git.revert_files):
1890         (Git.commit_with_message):
1891         (Git._commit_on_branch):
1892         (Git.svn_commit_log):
1893         (Git.last_svn_commit_log):
1894         (Git.svn_blame):
1895         (Git._branch_ref_exists):
1896         (Git.delete_branch):
1897         (Git.remote_merge_base):
1898         (Git.commit_locally_with_message):
1899         (Git.push_local_commits_to_server):
1900         (Git.commit_ids_from_commitish_arguments):
1901         (Git.commit_message_for_local_commit):
1902         (Git.files_changed_summary_for_commit):
1903
1904 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
1905
1906         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
1907         https://bugs.webkit.org/show_bug.cgi?id=95734
1908
1909         Reviewed by Adam Barth.
1910
1911         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1912         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
1913         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
1914         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
1915         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
1916         (MockWebRTCPeerConnectionHandler::createOffer):
1917         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1918         (MockWebRTCPeerConnectionHandler):
1919         (MockWebRTCPeerConnectionHandler::taskList):
1920         (SuccessCallbackTask):
1921         (FailureCallbackTask):
1922
1923 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
1924
1925         [Chromium-Android] Output time and thread info in crash log
1926         https://bugs.webkit.org/show_bug.cgi?id=95768
1927
1928         Reviewed by Adam Barth.
1929
1930         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1931         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
1932
1933 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
1934
1935         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
1936         https://bugs.webkit.org/show_bug.cgi?id=95721
1937
1938         Reviewed by Adam Barth.
1939
1940         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
1941         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
1942         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
1943         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
1944         (MockWebMediaStreamCenter):
1945
1946 2012-09-04  Tony Chang  <tony@chromium.org>
1947
1948         Elide test names when running new-run-webkit-tests
1949         https://bugs.webkit.org/show_bug.cgi?id=95626
1950
1951         Reviewed by Dirk Pranke.
1952
1953         When the test name exceeds the number of terminal columns, it leaves
1954         text on the screen. Avoid this by eliding the test name when running
1955         tests. This is similar to what ninja does when compiling.
1956
1957         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1958         (MeteredStream):
1959         (MeteredStream.number_of_columns): Helper method to get number of
1960         terminal columns. Won't work on Win32 python, but meh.
1961         * Scripts/webkitpy/layout_tests/views/printing.py:
1962         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
1963         because stderr appears to be ascii only.
1964         (Printer.print_started_test): Route through _test_status_line.
1965         (Printer.print_finished_test): Route through _test_status_line.
1966         (Printer._print_test_trace): Route through _test_status_line.
1967         (Printer._print_baseline): Route through _test_status_line.
1968         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1969         (test_test_status_line): Test for _test_status_line.
1970
1971 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
1972
1973         [GTK] Print API missing documentation when generating gtkdoc
1974         https://bugs.webkit.org/show_bug.cgi?id=95703
1975
1976         Reviewed by Carlos Garcia Campos.
1977
1978         Print out API missing documentation when generating gtkdoc. This makes it
1979         easier to fix documentation errors.
1980
1981         * gtk/generate-gtkdoc:
1982         (print_missing_api): Added.
1983         (generate_doc): Inline the rebase step, since it now reports an error
1984         when you try to rebase without generating documentation first.
1985         * gtk/gtkdoc.py:
1986         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
1987         generating documentation first to enable a small cleanup at the caller.
1988         (GTKDoc.api_missing_documentation): Added.
1989
1990 2012-09-04  Vincent Scheib  <scheib@chromium.org>
1991
1992         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
1993         https://bugs.webkit.org/show_bug.cgi?id=95628
1994
1995         Reviewed by James Robinson.
1996
1997         Future tests need the ability to respond asynchronously that
1998         pointer lock requests have been accepted or rejected. This patch
1999         adds the following:
2000             testRunner.setPointerLockWillRespondAsynchronously();
2001             testRunner.didAcquirePointerLock();
2002             testRunner.didNotAcquirePointerLock();
2003
2004         Tested in existing test:
2005             pointerlockchange-pointerlockerror-events.html
2006
2007         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2008         (DRTTestRunner::DRTTestRunner):
2009         (DRTTestRunner::didAcquirePointerLock):
2010         (DRTTestRunner::didNotAcquirePointerLock):
2011         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
2012         * DumpRenderTree/chromium/DRTTestRunner.h:
2013         (DRTTestRunner):
2014         * DumpRenderTree/chromium/WebViewHost.cpp:
2015         (WebViewHost::requestPointerLock):
2016         (WebViewHost::didAcquirePointerLock):
2017         (WebViewHost::didNotAcquirePointerLock):
2018         * DumpRenderTree/chromium/WebViewHost.h:
2019         (WebViewHost):
2020         (WebViewHost::setPointerLockWillRespondAsynchronously):
2021
2022 2012-09-04  Ojan Vafai  <ojan@chromium.org>
2023
2024         Move content shell bots to their own builder group
2025         https://bugs.webkit.org/show_bug.cgi?id=95765
2026
2027         Reviewed by Adam Barth.
2028
2029         In their current state of instability, they add too much noise. Once they get more stable,
2030         we can add them back to the regular group or just have them replace the other bots.
2031
2032         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
2033
2034         * TestResultServer/static-dashboards/builders.js:
2035         (isWebkitTestRunner):
2036         (isChromiumContentShellTestRunner):
2037         (isChromiumWebkitTipOfTreeTestRunner):
2038         (loadBuildersList):
2039
2040 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
2041
2042         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
2043         https://bugs.webkit.org/show_bug.cgi?id=95689
2044
2045         Reviewed by Kenneth Rohde Christiansen.
2046
2047         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
2048         So, there are bugs that key events are always generated in url bar although
2049         the user clicked the web view.
2050
2051         This patch recovers the focus of the web view when left button is pressed and
2052         adds for MiniBrowser to toggle the focus when middle button is pressed
2053         like EWebLauncher already did.
2054
2055         * EWebLauncher/main.c:
2056         (on_mouse_down):
2057         * MiniBrowser/efl/main.c:
2058         (on_mouse_down):
2059         (browserCreate):
2060
2061 2012-09-03  Tao Bai  <michaelbai@chromium.org>
2062
2063         Added ANDROID_GDBSERVER definition for Ant
2064         https://bugs.webkit.org/show_bug.cgi?id=95265
2065
2066         Reviewed by Adam Barth.
2067
2068         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
2069         is only used for finding the gdbserver.
2070
2071         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2072         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2073
2074 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
2075
2076         MediaStream API: Add Ice-related functionality to RTCPeerConnection
2077         https://bugs.webkit.org/show_bug.cgi?id=95565
2078
2079         Reviewed by Adam Barth.
2080
2081         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2082         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
2083         (MockWebRTCPeerConnectionHandler::updateICE):
2084         (MockWebRTCPeerConnectionHandler::addICECandidate):
2085         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2086         (MockWebRTCPeerConnectionHandler):
2087
2088 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
2089
2090         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
2091         https://bugs.webkit.org/show_bug.cgi?id=95670
2092
2093         Reviewed by Kenneth Rohde Christiansen.
2094
2095         Fix layout issues related to the URL bar in Minibrowser
2096         and EWebLauncher when the window is resized.
2097
2098         The URL bar was not resized accordingly and the Web
2099         page was moved behing the URL bar, hiding part of it.
2100
2101         * EWebLauncher/main.c:
2102         (on_ecore_evas_resize):
2103         (closeWindow):
2104         * EWebLauncher/url_bar.c:
2105         (url_bar_width_set):
2106         (url_bar_add):
2107         * EWebLauncher/url_bar.h:
2108         * MiniBrowser/efl/main.c:
2109         (on_ecore_evas_resize):
2110         (main):
2111
2112 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
2113
2114         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
2115         https://bugs.webkit.org/show_bug.cgi?id=95605
2116
2117         Reviewed by Dirk Pranke.
2118
2119         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
2120
2121         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2122         (ChromiumAndroidPort.check_sys_deps):
2123         (ChromiumAndroidPort.expectations_files):
2124         (ChromiumAndroidPort.clean_up_test_run):
2125
2126 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
2127
2128         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
2129         https://bugs.webkit.org/show_bug.cgi?id=95180
2130
2131         Reviewed by Chris Fleizach.
2132
2133         The bug that was fixed stood in the way of fully implementing stringValue().
2134         Testing that the bug is fixed requires stringValue() to be fully implemented
2135         and object replacement characters to be printable.
2136
2137         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2138         (replaceCharactersForResults): New method which turns object replacement
2139         characters into "<obj>" so that the characters can be properly shown in
2140         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
2141         accessible text of a single object in the accessible tree doesn't mess up
2142         the readibility of the results.
2143         (AccessibilityUIElement::stringValue): Remove the code that immediately
2144         returned upon encountering an object of ATK_ROLE_PANEL and call the new
2145         replaceCharactersForResults() prior to returning the accessible string
2146         value.
2147
2148 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
2149
2150         MediaStream API: Add MediaStream management to RTCPeerConnection
2151         https://bugs.webkit.org/show_bug.cgi?id=95543
2152
2153         Reviewed by Adam Barth.
2154
2155         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
2156
2157         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2158         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
2159         (MockWebRTCPeerConnectionHandler::addStream):
2160         (MockWebRTCPeerConnectionHandler::removeStream):
2161         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2162         (MockWebRTCPeerConnectionHandler):
2163
2164 2012-08-31  Tony Chang  <tony@chromium.org>
2165
2166         Remove ENABLE_CSS3_FLEXBOX compile time flag
2167         https://bugs.webkit.org/show_bug.cgi?id=95382
2168
2169         Reviewed by Ojan Vafai.
2170
2171         Everyone is already enabling this by default and the spec has stablized.
2172
2173         * Scripts/webkitperl/FeatureList.pm:
2174         * qmake/mkspecs/features/features.pri:
2175
2176 2012-08-31  Pratik Solanki  <psolanki@apple.com>
2177
2178         objc_msgSend and IMP should be cast appropriately before using
2179         https://bugs.webkit.org/show_bug.cgi?id=95242
2180
2181         Reviewed by Benjamin Poulain.
2182
2183         Fix for older compilers. Pass id as the return type to the template
2184         instead of relying on default type.
2185
2186         * DumpRenderTree/mac/DumpRenderTree.mm:
2187         (drt_NSFontManager_availableFontFamilies):
2188         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2189         (WTR::wtr_NSFontManager_availableFontFamilies):
2190
2191 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
2192
2193         nrwt: use scm instead of calling svn directly to get the revision in json results generator
2194         https://bugs.webkit.org/show_bug.cgi?id=89616
2195
2196         Reviewed by Eric Seidel.
2197
2198         Add the new 'executive' optional function argument to the SCM.in_working_directory
2199         class method. This way we get to reuse an Executive instance which is necessary in testing
2200         when we're operating with a mock version of the object.
2201
2202         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
2203         the SCMDetector with the generator's FileSystem and Executive instances.
2204
2205         * Scripts/webkitpy/common/checkout/scm/detection.py:
2206         (SCMDetector.detect_scm_system):
2207         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2208         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
2209         Executive output and test it against expected output.
2210         * Scripts/webkitpy/common/checkout/scm/git.py:
2211         (Git.in_working_directory):
2212         * Scripts/webkitpy/common/checkout/scm/scm.py:
2213         (SCM.in_working_directory):
2214         * Scripts/webkitpy/common/checkout/scm/svn.py:
2215         (SVN.in_working_directory):
2216         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2217         (JSONResultsGeneratorBase.__init__):
2218         (JSONResultsGeneratorBase._get_svn_revision):
2219
2220 2012-08-31  Jon Lee  <jonlee@apple.com>
2221
2222         [Tests] Add basic tests to http/tests/notifications
2223         https://bugs.webkit.org/show_bug.cgi?id=95493
2224         <rdar://problem/12209303>
2225
2226         Reviewed by Alexey Proskuryakov.
2227
2228         Add permission request support for WTR.
2229
2230         * WebKitTestRunner/TestController.cpp:
2231         (WTR::TestController::initialize):
2232         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
2233         * WebKitTestRunner/TestController.h:
2234         (TestController):
2235
2236 2012-08-31  Jon Lee  <jonlee@apple.com>
2237
2238         [DRT] Make simulating a web click on a notification a queued task
2239         https://bugs.webkit.org/show_bug.cgi?id=95546
2240         <rdar://problem/12214170>
2241
2242         Reviewed by Alexey Proskuryakov.
2243
2244         Making the web click happen asynchronously better mimics user interaction with the platform.
2245
2246         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
2247         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
2248         not set.
2249         * DumpRenderTree/mac/DumpRenderTree.mm:
2250         (dump): Assert that the flag is not set.
2251         * DumpRenderTree/mac/TestRunnerMac.mm:
2252         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
2253         notification. In the case where the block gets executed after the flag has been unset, we avoid
2254         performing the click.
2255
2256 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
2257
2258         [Qt] ImageDiff output is not in the expected form if image dimensions differ
2259         https://bugs.webkit.org/show_bug.cgi?id=95575
2260
2261         Reviewed by Csaba Osztrogonác.
2262
2263         Output 100% difference in the case of differing image dimensions so
2264         the test harness knows that we won't produce any output further.
2265         This matches the behavior of other ports.
2266
2267         * DumpRenderTree/qt/ImageDiff.cpp:
2268         (main):
2269
2270 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
2271
2272         Unreviewed, rolling out r127261.
2273         http://trac.webkit.org/changeset/127261
2274         https://bugs.webkit.org/show_bug.cgi?id=95572
2275
2276         This patch depends on other build fixes (see blockers of bug
2277         95466) which should land first (Requested by milian on
2278         #webkit).
2279
2280         * qmake/mkspecs/features/features.prf:
2281
2282 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
2283
2284         [Qt] Support WebKit2/QML on QNX
2285         https://bugs.webkit.org/show_bug.cgi?id=95466
2286
2287         Reviewed by Noam Rosenthal.
2288
2289         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
2290         this should finally work now.
2291
2292         * qmake/mkspecs/features/features.prf:
2293
2294 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
2295
2296         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
2297         https://bugs.webkit.org/show_bug.cgi?id=95400
2298
2299         Reviewed by Dirk Pranke.
2300
2301         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
2302
2303         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2304         (ChromiumAndroidPort.skipped_layout_tests):
2305
2306 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
2307
2308         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
2309         https://bugs.webkit.org/show_bug.cgi?id=95499
2310
2311         Unreviewed. One more fix to avoid trying to run the empty string.
2312
2313         * Scripts/webkitdirs.pm:
2314         (buildAutotoolsProject):
2315
2316 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
2317
2318         Unreviewed, rolling out r127171.
2319         http://trac.webkit.org/changeset/127171
2320         https://bugs.webkit.org/show_bug.cgi?id=95505
2321
2322         testRunner does not need dumpWebNotificationCallbacks().
2323         (Requested by jonlee on #webkit).
2324
2325         * DumpRenderTree/TestRunner.cpp:
2326         (TestRunner::TestRunner):
2327         (TestRunner::staticFunctions):
2328         * DumpRenderTree/TestRunner.h:
2329         (TestRunner):
2330         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2331         (-[MockWebNotificationProvider webView:didShowNotification:]):
2332         (-[MockWebNotificationProvider webView:didClickNotification:]):
2333         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
2334         * DumpRenderTree/mac/UIDelegate.mm:
2335         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
2336
2337 2012-08-30  Pratik Solanki  <psolanki@apple.com>
2338
2339         objc_msgSend and IMP should be cast appropriately before using
2340         https://bugs.webkit.org/show_bug.cgi?id=95242
2341
2342         Reviewed by Benjamin Poulain.
2343
2344         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
2345         to a function pointer with right types when calling objc_msgSend and an
2346         IMP method directly.
2347
2348         * DumpRenderTree/mac/DumpRenderTree.mm:
2349         (drt_NSFontManager_availableFontFamilies):
2350         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2351         (WTR::wtr_NSFontManager_availableFontFamilies):
2352
2353 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
2354
2355         Replace JSC::UString by WTF::String
2356         https://bugs.webkit.org/show_bug.cgi?id=95271
2357
2358         Reviewed by Geoffrey Garen.
2359
2360         Get rid of UString.
2361
2362         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2363         * gdb/webkit.py:
2364         (WTFStringPrinter.to_string):
2365         (JSCIdentifierPrinter.to_string):
2366         (JSCJSStringPrinter.to_string):
2367         (add_pretty_printers):
2368
2369 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
2370
2371         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
2372         https://bugs.webkit.org/show_bug.cgi?id=95495
2373
2374         Reviewed by Ojan Vafai.
2375
2376         This is a follow-on to bug 95370 that adds in support for
2377         platform/wk2/TestExpectations and
2378         platform/{mac,win}-$version/TestExpectations.
2379
2380         * Scripts/webkitpy/layout_tests/port/apple.py:
2381         (ApplePort.expectations_files):
2382         * Scripts/webkitpy/layout_tests/port/base.py:
2383         (Port._skipped_file_search_paths):
2384         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2385         (MacTest.test_expectations_files):
2386         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2387         (MockDRTPortTest.make_port):
2388         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2389         (WinPortTest.test_expectations_files):
2390
2391 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
2392
2393         executive.run_in_parallel() hangs if given nothing to do
2394         https://bugs.webkit.org/show_bug.cgi?id=95387
2395
2396         Reviewed by Ojan Vafai.
2397
2398         Check to make sure that Executive.run_in_parallel() requires
2399         a non-empty list of commands to execute; passing an empty list
2400         seems surely like a programming error.
2401
2402         * Scripts/webkitpy/common/system/executive.py:
2403         (Executive.run_in_parallel):
2404         * Scripts/webkitpy/common/system/executive_unittest.py:
2405         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
2406
2407 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
2408
2409         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
2410         https://bugs.webkit.org/show_bug.cgi?id=94746
2411
2412         Reviewed by Ojan Vafai.
2413
2414         Add an assertion to diff_image() to check that we are passing
2415         tolerance=0 explicitly when diffing ref test results.
2416
2417         * Scripts/webkitpy/layout_tests/port/test.py:
2418         (TestPort.diff_image):
2419
2420 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
2421
2422         NRWT should look in mac-wk2 for a TestExpecations file
2423         https://bugs.webkit.org/show_bug.cgi?id=95370
2424
2425         Reviewed by Ojan Vafai.
2426
2427         Adds support for mac-wk2 and win-wk2 to expectations_files()
2428         for the apple mac and apple win ports.
2429         
2430         * Scripts/webkitpy/layout_tests/port/apple.py:
2431         (ApplePort.expectations_files):
2432         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2433         (MacTest.test_expectations_files):
2434         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2435         (WinTest.test_expectations_files):
2436         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2437         (PortTestCase.test_expectations_files):
2438
2439 2012-08-30  Jon Lee  <jonlee@apple.com>
2440
2441         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
2442         https://bugs.webkit.org/show_bug.cgi?id=95232
2443         <rdar://problem/12190776>
2444
2445         Reviewed by Alexey Proskuryakov.
2446
2447         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
2448
2449         * DumpRenderTree/TestRunner.cpp:
2450         (TestRunner::TestRunner):
2451         (dumpWebNotificationCallbacksCallback):
2452         (TestRunner::staticFunctions):
2453         * DumpRenderTree/TestRunner.h:
2454         (TestRunner):
2455         (TestRunner::dumpWebNotificationCallbacks):
2456         (TestRunner::setDumpWebNotificationCallbacks):
2457         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2458         (-[WebNotification _drt_descriptionSuitableForTestResult]):
2459         (-[MockWebNotificationProvider webView:didShowNotification:]):
2460         (-[MockWebNotificationProvider webView:didClickNotification:]):
2461         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
2462         * DumpRenderTree/mac/UIDelegate.mm:
2463         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
2464
2465 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
2466
2467         MediaStream API: Introduce MediaConstraints
2468         https://bugs.webkit.org/show_bug.cgi?id=95198
2469
2470         Reviewed by Adam Barth.
2471
2472         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
2473
2474         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2475         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
2476         (isSupportedConstraint):
2477         (isValidConstraint):
2478         (MockWebRTCPeerConnectionHandler::initialize):
2479         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2480         (MockWebRTCPeerConnectionHandler):
2481
2482 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2483
2484         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
2485         https://bugs.webkit.org/show_bug.cgi?id=95454
2486
2487         Reviewed by Kenneth Rohde Christiansen.
2488
2489         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
2490
2491         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2492         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2493
2494 2012-08-30  Leo Yang  <leoyang@rim.com>
2495
2496         Update my email address.
2497
2498         Not reviewed.
2499
2500         * Scripts/webkitpy/common/config/committers.py:
2501
2502 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
2503
2504         [NRWT] Add support for recognizing arbitrary process names in crash lines
2505         https://bugs.webkit.org/show_bug.cgi?id=95435
2506
2507         Reviewed by Adam Barth.
2508
2509         When running layout tests in the chromium port using the content shell,
2510         we want to be able to report sub-process crashes as well.
2511
2512         * Scripts/webkitpy/layout_tests/port/driver.py:
2513         (Driver._check_for_driver_crash):
2514         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2515         (DriverTest.test_check_for_driver_crash):
2516
2517 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
2518
2519         Random test-webkitpy failures on the buildbot
2520         https://bugs.webkit.org/show_bug.cgi?id=95096
2521
2522         Reviewed by Dirk Pranke.
2523
2524         Suppress occasional errors when running test-webkitpy on GTK builders
2525         by running these tests serially. The 64-bit Release builder is especially
2526         prone to these as it can run up to 24 tests in parallel.
2527
2528         Despite the tests not being run in parallel, the testing only lasts a handful
2529         of seconds more, so this is a worthy trade-off to avoid unnecessary
2530         false-alarm redness on the GTK builders.
2531
2532         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2533         (RunPythonTests.start):
2534
2535 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
2536
2537         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
2538         https://bugs.webkit.org/show_bug.cgi?id=95380
2539
2540         Reviewed by Michael Saboff.
2541
2542         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2543         Add very basic tests for String::ascii(). This covers the case of null strings that caused
2544         the crash.
2545
2546 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
2547
2548         AX: Canvas should have a distinct role
2549         https://bugs.webkit.org/show_bug.cgi?id=95248
2550
2551         Reviewed by Chris Fleizach.
2552
2553         Add support for canvas accessibility role.
2554
2555         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2556         (roleToString):
2557
2558 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
2559
2560         [Gtk] Process Gtk 3.4 smooth scroll events properly
2561         https://bugs.webkit.org/show_bug.cgi?id=88070
2562
2563         Added continousMouseScrollBy support in WebKitTestRunner, and added
2564         implementation for gtk, and stub for Qt, mac and EFL.
2565
2566         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
2567         scroll for emulating multi-tick mouseScrollBy events.
2568
2569         Reviewed by Martin Robinson.
2570
2571         * DumpRenderTree/gtk/EventSender.cpp:
2572         (mouseScrollByCallback):
2573         (continuousMouseScrollByCallback):
2574         * WebKitTestRunner/EventSenderProxy.h:
2575         (EventSenderProxy):
2576         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2577         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2578         (WTR::EventSendingController::mouseScrollBy):
2579         (WTR):
2580         (WTR::EventSendingController::continuousMouseScrollBy):
2581         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2582         (EventSendingController):
2583         * WebKitTestRunner/TestController.cpp:
2584         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2585         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2586         (WTR):
2587         (WTR::EventSenderProxy::mouseScrollBy):
2588         (WTR::EventSenderProxy::continuousMouseScrollBy):
2589         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2590         (WTR):
2591         (WTR::EventSenderProxy::continuousMouseScrollBy):
2592         * WebKitTestRunner/mac/EventSenderProxy.mm:
2593         (WTR::EventSenderProxy::continuousScrollBy):
2594         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2595         (WTR::EventSenderProxy::continuousMouseScrollBy):
2596         (WTR):
2597
2598 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
2599
2600         [chromium] Support high DIP pixel tests with DumpRenderTree
2601         https://bugs.webkit.org/show_bug.cgi?id=94935
2602
2603         Reviewed by James Robinson.
2604
2605         Adding device scale factor into the drt image dumping code
2606
2607         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2608         (DRTTestRunner::reset):
2609         (DRTTestRunner::setBackingScaleFactor):
2610         * DumpRenderTree/chromium/WebViewHost.cpp:
2611         (WebViewHost::setDeviceScaleFactor):
2612         (WebViewHost::paintInvalidatedRegion):
2613         (WebViewHost::canvas):
2614         * DumpRenderTree/chromium/WebViewHost.h:
2615         (WebViewHost):
2616
2617 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
2618
2619         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
2620         https://bugs.webkit.org/show_bug.cgi?id=95177
2621
2622         Reviewed by Dirk Pranke.
2623
2624         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
2625
2626         * Scripts/webkitpy/common/checkout/scm/git.py:
2627
2628 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
2629
2630         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
2631         https://bugs.webkit.org/show_bug.cgi?id=95222
2632
2633         Reviewed by Adam Barth.
2634
2635         The code we had to remove REBASELINE lines from the
2636         TestExpectations files did not handle multiple files (in a
2637         cascade) correctly; we weren't limiting lines to a particular
2638         file correctly in without_rebaseline_modifier(). This patch
2639         fixes that and corrects the tests (which weren't correct and
2640         didn't cover things very well).
2641
2642         Note also that the webkit-patch rebaseline-commands are still
2643         using the include_overrides=False option in a couple places;
2644         this is never correct or needed at this point. This patch fixes
2645         the usage for webkit-patch rebaseline-expectations, but I still
2646         need to fix rebaseline-test-internal, which I will do in a
2647         separate patch (see bug 95268).
2648
2649         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2650         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
2651         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2652         (RebaseliningTest.assertRemove):
2653         (RebaseliningTest.test_remove):
2654         * Scripts/webkitpy/tool/commands/rebaseline.py:
2655         (RebaselineExpectations._update_expectations_files):
2656
2657 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
2658
2659         webkit-patch rebaseline-expectations hangs
2660         https://bugs.webkit.org/show_bug.cgi?id=95243
2661
2662         Reviewed by Tony Chang.
2663
2664         Don't try to run no commands in parallel; report an error
2665         instead that we didn't find any tests to rebaseline.
2666
2667         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
2668
2669         * Scripts/webkitpy/tool/commands/rebaseline.py:
2670         (RebaselineExpectations.execute):
2671         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2672         (_assert_command):
2673         (test_rebaseline_expectations_noop):
2674
2675 2012-08-29  Brady Eidson  <beidson@apple.com>
2676
2677         REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
2678         <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
2679
2680         Reviewed by Sam Weinig.
2681
2682         Add a test plug-in that calls back into the page with info on the NPWindow passed
2683         in to NPP_SetWindow.
2684
2685         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2686         * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
2687         (LogNPPSetWindow):
2688         (LogNPPSetWindow::LogNPPSetWindow):
2689         (LogNPPSetWindow::NPP_SetWindow):
2690
2691 2012-08-29  Jon Lee  <jonlee@apple.com>
2692
2693         [Mac] Basic DRT support for web notifications
2694         https://bugs.webkit.org/show_bug.cgi?id=79492
2695         <rdar://problem/10357639>
2696
2697         Reviewed by Alexey Proskuryakov.
2698
2699         This patch implements the stubs for web notification support on DRT. Assume that when
2700         Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
2701         overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
2702
2703         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
2704         * DumpRenderTree/mac/DumpRenderTree.mm:
2705         (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
2706         web view.
2707         (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
2708
2709         * DumpRenderTree/mac/TestRunnerMac.mm:
2710         (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
2711         (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
2712         (TestRunner::removeAllWebNotificationPermissions):
2713         (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
2714         simulate the click. This is similar to how WTR performs the click.
2715         * DumpRenderTree/mac/UIDelegate.mm:
2716         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
2717         user allows web notifications.
2718
2719         * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
2720         a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
2721         * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
2722         (+[MockWebNotificationProvider shared]): The provider is a singleton.
2723         (-[MockWebNotificationProvider init]): Instantiate the permissions map.
2724         (-[MockWebNotificationProvider registerWebView:]):
2725         (-[MockWebNotificationProvider unregisterWebView:]):
2726         (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
2727         notification did show.
2728         (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
2729         (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
2730         (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
2731         (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
2732         (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
2733         (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
2734         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
2735         (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
2736         (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
2737         (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
2738         (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
2739
2740 2012-08-29  Rob Buis  <rbuis@rim.com>
2741
2742         [BlackBerry] Adjust wtf include header style
2743         https://bugs.webkit.org/show_bug.cgi?id=95368
2744
2745         Reviewed by Yong Li.
2746
2747         Switch to #include <wtf/...> like the other ports.
2748
2749         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2750         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
2751         * DumpRenderTree/blackberry/PNGImageEncoder.h:
2752         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2753         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
2754         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
2755
2756 2012-08-29  Roger Fong  <roger_fong@apple.com>
2757
2758         Update cygwin-downloader.zip to match modified downloader script.
2759         https://bugs.webkit.org/show_bug.cgi?id=76936
2760
2761         Rubber Stamped by Jon Honeycutt.
2762
2763         cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
2764         Updating zip to reflect changes.
2765
2766         * CygwinDownloader/cygwin-downloader.zip:
2767
2768 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
2769
2770         Stylechecker warns about comparison to zero when comparing to 0.5
2771         https://bugs.webkit.org/show_bug.cgi?id=94913
2772
2773         Reviewed by Dirk Pranke.
2774
2775         According to the python documentation, \W is the character group with all
2776         non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
2777         to [^\w]. We need to exclude the dot "." as well, so that floating point
2778         values do not trigger this warning. Adding a unit test that shows the problem.
2779
2780         * Scripts/webkitpy/style/checkers/cpp.py:
2781         (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
2782         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2783         (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
2784
2785 2012-08-29  Jon Lee  <jonlee@apple.com>
2786
2787         WTR build fixes.
2788
2789         * WebKitTestRunner/CMakeLists.txt:
2790         * WebKitTestRunner/GNUmakefile.am:
2791         * WebKitTestRunner/Target.pri:
2792         * WebKitTestRunner/WebNotificationProvider.cpp:
2793         (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
2794         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2795
2796 2012-08-29  Jon Lee  <jonlee@apple.com>
2797
2798         [WK2] Basic WTR support for web notifications
2799         https://bugs.webkit.org/show_bug.cgi?id=95154
2800         <rdar://problem/12184492>
2801
2802         Reviewed by Alexey Proskuryakov.
2803
2804         Implement WTR support, without platform event output (bug 95233).
2805
2806         Legacy APIs will not be supported, since many of the tests are skipped
2807         on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
2808         tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
2809         the tests to http/tests/notifications.
2810
2811         Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
2812         require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
2813         be invoked from the UIProcess.
2814
2815         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2816         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2817         (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
2818         (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
2819         notification's internal ID.
2820         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2821         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2822         (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
2823         (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
2824         (WTR::TestRunner::removeAllWebNotificationPermissions):
2825         (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
2826         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2827
2828         Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
2829         class.
2830         * WebKitTestRunner/TestInvocation.cpp:
2831         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
2832         TestInvocation forwards that request to the TestController.
2833         * WebKitTestRunner/TestController.cpp:
2834         (WTR::TestController::initialize): Set the provider.
2835         (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
2836         (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
2837         * WebKitTestRunner/TestController.h: Holds an instance to the provider.
2838
2839         The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
2840         of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
2841         * WebKitTestRunner/WebNotificationProvider.h: Added.
2842         * WebKitTestRunner/WebNotificationProvider.cpp: Added.
2843         (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
2844         the notification got shown.
2845         (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
2846         got closed.
2847         (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
2848         (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
2849         (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
2850         permissions. For testing purposes, we always want this set to be empty.
2851         (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
2852         (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
2853
2854         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
2855
2856 2012-08-29  Kamil Blank  <k.blank@samsung.com>
2857
2858         [EFL] Add setting API for allow universal/file access from file URLs.
2859         https://bugs.webkit.org/show_bug.cgi?id=83121
2860
2861         Reviewed by Eric Seidel.
2862
2863         Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
2864
2865         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2866         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2867         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2868         (TestRunner::setAllowUniversalAccessFromFileURLs):
2869         (TestRunner::setAllowFileAccessFromFileURLs):
2870
2871 2012-08-29  Jon Lee  <jonlee@apple.com>
2872
2873         Update TestRunner API for web notifications
2874         https://bugs.webkit.org/show_bug.cgi?id=95093
2875         <rdar://problem/12179649>
2876
2877         Reviewed by Alexey Proskuryakov.
2878
2879         As it turns out the patch for this accidentally got squashed into the commit for
2880         bug 95099 (r126909). This amendment patch adds some comments about the renaming
2881         of the older TestRunner API for web notifications.
2882
2883         * DumpRenderTree/TestRunner.h:
2884         (TestRunner):
2885
2886 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2887
2888         Unreviewed, rolling out r126972.
2889         http://trac.webkit.org/changeset/126972
2890         https://bugs.webkit.org/show_bug.cgi?id=95349
2891
2892         accessibility/canvas-description-and-role.html has been
2893         failing consistently on several bots and Dominic needs some
2894         time to investigate why (Requested by jchaffraix on #webkit).
2895
2896         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2897         (roleToString):
2898
2899 2012-08-29  Raphael Kubo da Costa  <rakuco@webkit.org>
2900
2901         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
2902         https://bugs.webkit.org/show_bug.cgi?id=84707
2903
2904         Reviewed by Gustavo Noronha Silva.
2905
2906         Most of the warnings have been fixed now that FindCairo.cmake and
2907         FindGLIB.cmake have been rewritten. The remaining one, related to
2908         FindFontconfig.cmake, shows up when building on a 64-bit
2909         Debian-based systems.
2910
2911         jhbuild installs libraries into lib64/ by default on 64-bit Linux
2912         installations, while CMake does not look for libraries in lib64/
2913         when /etc/debian_version exists on the system. The FIND_LIBRARY()
2914         would then sometimes end up using the system installation instead of
2915         the jhbuild one, causing mismatches and, when pkg-config is not used
2916         at all, failing to find libraries altogether.
2917
2918         * efl/jhbuildrc: Set the CMAKE_LIBRARY_PATH environment variable
2919         when use_lib64 is set to force CMake to look into lib64/ regardless
2920         of the presence of /etc/debian_version.
2921
2922 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
2923
2924         The 2d.imageData.object.round canvas test is failing
2925         https://bugs.webkit.org/show_bug.cgi?id=40272
2926
2927         Reviewed by Benjamin Poulain.
2928
2929         Updating patch to address Benjamin's review comments.
2930         Adding a WTF test to test lrint implementation.
2931
2932         * TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
2933         * TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
2934         * TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
2935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
2936         * TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
2937         (TestWebKitAPI):
2938         (TestWebKitAPI::TEST):
2939         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.
2940
2941 2012-08-29  Florin Malita  <fmalita@chromium.org>
2942
2943         Unreviewed, updating Kelly Norton's email address at his request.
2944
2945         * Scripts/webkitpy/common/config/committers.py:
2946
2947 2012-08-29  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2948
2949         [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files
2950         https://bugs.webkit.org/show_bug.cgi?id=93723
2951
2952         Reviewed by Dirk Pranke.
2953
2954         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2955         (TestExpectationParser.expectation_for_skipped_test):
2956         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2957         (SkippedTests.test_skipped_entry_dont_exist):
2958
2959 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2960
2961         Unreviewed, rolling out r120113.
2962         http://trac.webkit.org/changeset/120113
2963         https://bugs.webkit.org/show_bug.cgi?id=95320
2964
2965         Wrong fix for the problem, experimentally rolling it out for
2966         bug 95237. (Requested by rakuco on #webkit).
2967
2968         * efl/jhbuildrc:
2969
2970 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
2971
2972         AX: Canvas should have a distinct role
2973         https://bugs.webkit.org/show_bug.cgi?id=95248
2974
2975         Reviewed by Chris Fleizach.
2976
2977         Add support for canvas accessibility role.
2978
2979         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2980         (roleToString):
2981
2982 2012-08-28  Eric Seidel  <eric@webkit.org>
2983
2984         cr-ews bot doesn't set CWD correctly when zipping layout test results
2985         https://bugs.webkit.org/show_bug.cgi?id=91265
2986
2987         Reviewed by Kenneth Russell.
2988
2989         This should make the zips slightly less cumbersome to deal with.
2990
2991         * Scripts/webkitpy/common/system/workspace.py:
2992         (Workspace.create_zip):
2993         * Scripts/webkitpy/common/system/workspace_unittest.py:
2994         (WorkspaceTest.test_create_zip):
2995         (WorkspaceTest.test_create_zip_exception):
2996
2997 2012-08-28  Benjamin Poulain  <benjamin@webkit.org>
2998
2999         Fix the Commiters script
3000
3001         Unreviewed.
3002
3003         Remove Roger Fong from the Contributor list, he appears in the Commiter list since r126949.
3004
3005         * Scripts/webkitpy/common/config/committers.py:
3006
3007 2012-08-28  Roger Fong  <roger_fong@apple.com>
3008
3009         Unreviewed. Adding myself to committers list.
3010
3011         * Scripts/webkitpy/common/config/committers.py:
3012
3013 2012-08-28  Roger Fong  <roger_fong@apple.com>
3014
3015         Add minires to list of required cygwin install packages.
3016         https://bugs.webkit.org/show_bug.cgi?id=76936
3017
3018         Reviewed by Tim Horton.
3019
3020         * CygwinDownloader/cygwin-downloader.py:
3021
3022 2012-08-28  Xianzhu Wang  <wangxianzhu@chromium.org>
3023
3024         [Chromium-Android] Upstream layout test expectations (Part 2)
3025         https://bugs.webkit.org/show_bug.cgi?id=95212
3026
3027         Reviewed by Adam Barth.
3028
3029         - Now run both gpu path and non-gpu path of 2d canvas layout tests
3030         because both are used in chromium-android.
3031
3032         - Exclude all webgl tests because webgl is not enabled yet.
3033
3034         - Removed 'win' from the baseline fallback list. This was a mistake.
3035
3036         - Moved some small directories to TestExpectations from skipped_layout_tests().
3037
3038         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3039         (ChromiumAndroidPort):
3040         (ChromiumAndroidPort.skipped_layout_tests):
3041
3042 2012-08-28  Joanmarie Diggs  <jdiggs@igalia.com>
3043
3044         Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
3045         https://bugs.webkit.org/show_bug.cgi?id=95185
3046
3047         Reviewed by Chris Fleizach.
3048
3049         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3050         (AccessibilityUIElement::titleUIElement): Implemented
3051         Gets the ATK_RELATION_LABELLED_BY target.
3052         (AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
3053         Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
3054         bug 95180 is fixed.
3055
3056 2012-08-28  Dominic Mazzoni  <dmazzoni@google.com>
3057
3058         AX: Crash due to object getting deleted inside updateBackingStore
3059         https://bugs.webkit.org/show_bug.cgi?id=94619
3060
3061         Reviewed by Chris Fleizach.
3062
3063         Change isValid to !isDetached after deleting isValid from
3064         chromium WebAccessibilityObject as being redundant.
3065
3066         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3067         (AccessibilityUIElement::isValidGetterCallback):
3068
3069 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
3070
3071         Unreviewed, rolling out r126914.
3072         http://trac.webkit.org/changeset/126914
3073         https://bugs.webkit.org/show_bug.cgi?id=95239
3074
3075         it breaks everything and fixes nothing (Requested by pizlo on
3076         #webkit).
3077
3078         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3079         (MockWebSpeechInputController::addMockRecognitionResult):
3080         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3081         (NotificationPresenter::simulateClick):
3082         (NotificationPresenter::show):
3083         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
3084         (CppBoundClass::~CppBoundClass):
3085         (CppBoundClass::invoke):
3086         (CppBoundClass::getProperty):
3087         (CppBoundClass::setProperty):
3088         (CppBoundClass::bindCallback):
3089         (CppBoundClass::bindProperty):
3090         * DumpRenderTree/chromium/WebPreferences.cpp:
3091         (applyFontMap):
3092         * DumpRenderTree/chromium/WebViewHost.cpp:
3093         (WebViewHost::printResourceDescription):
3094         * DumpRenderTree/mac/TestRunnerMac.mm:
3095         (worldIDForWorld):
3096         (TestRunner::evaluateScriptInIsolatedWorld):
3097         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3098         (AccessibilityController::~AccessibilityController):
3099         (AccessibilityController::winNotificationReceived):
3100         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3101         (ResourceLoadDelegate::descriptionSuitableForTestResult):
3102         * DumpRenderTree/win/TestRunnerWin.cpp:
3103         (worldIDForWorld):
3104         (TestRunner::evaluateScriptInIsolatedWorld):
3105         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
3106         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
3107         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3108         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
3109         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3110         (WTR::TestRunner::worldIDForWorld):
3111         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3112
3113 2012-08-28  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3114
3115         Rename first/second to key/value in HashMap iterators
3116         https://bugs.webkit.org/show_bug.cgi?id=82784
3117
3118         Reviewed by Eric Seidel.
3119
3120         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3121         (MockWebSpeechInputController::addMockRecognitionResult):
3122         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3123         (NotificationPresenter::simulateClick):
3124         (NotificationPresenter::show):
3125         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
3126         (CppBoundClass::~CppBoundClass):
3127         (CppBoundClass::invoke):
3128         (CppBoundClass::getProperty):
3129         (CppBoundClass::setProperty):
3130         (CppBoundClass::bindCallback):
3131         (CppBoundClass::bindProperty):
3132         * DumpRenderTree/chromium/WebPreferences.cpp:
3133         (applyFontMap):
3134         * DumpRenderTree/chromium/WebViewHost.cpp:
3135         (WebViewHost::printResourceDescription):
3136         * DumpRenderTree/mac/TestRunnerMac.mm:
3137         (worldIDForWorld):
3138         (TestRunner::evaluateScriptInIsolatedWorld):
3139         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3140         (AccessibilityController::~AccessibilityController):
3141         (AccessibilityController::winNotificationReceived):
3142         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3143         (ResourceLoadDelegate::descriptionSuitableForTestResult):
3144         * DumpRenderTree/win/TestRunnerWin.cpp:
3145         (worldIDForWorld):
3146         (TestRunner::evaluateScriptInIsolatedWorld):
3147         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
3148         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
3149         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3150         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
3151         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3152         (WTR::TestRunner::worldIDForWorld):
3153         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3154
3155 2012-08-27  Jon Lee  <jonlee@apple.com>
3156
3157         Update TestRunner API for web notifications
3158         https://bugs.webkit.org/show_bug.cgi?id=95093
3159         <rdar://problem/12179649>
3160
3161         Reviewed by Jessie Berlin.
3162
3163         This is work toward providing Mac support for web notifications in DRT and WTR (77969).
3164
3165         Some of the legacy APIs are less than ideal, and not tenable with the WTR infrastructure.
3166         This first patch renames the TestRunner calls to use the term "web notifications" instead of
3167         "desktop notifications", deprecates a couple API calls that are not used by anyone, and adds
3168         additional calls that will be used in the tests that test the standard API.
3169
3170         * DumpRenderTree/TestRunner.h:
3171         (TestRunner): For consistency, rename a couple member variables. Remove unused checkDesktopNotificationPermission()
3172         and areDesktopNotificationPermissionRequestsIgnored(). Remove origin mapping since each port implements its own solution.
3173         * DumpRenderTree/TestRunner.cpp: Push grantWebNotificationPermission() to individual ports.
3174         (TestRunner::TestRunner):
3175         (ignoreLegacyWebNotificationPermissionRequestsCallback): Renamed.
3176         (simulateLegacyWebNotificationClickCallback): Renamed.
3177         (grantWebNotificationPermissionCallback): Renamed.
3178         (denyWebNotificationPermissionCallback): Added.
3179         (removeAllWebNotificationPermissionsCallback): Added.
3180         (simulateWebNotificationClickCallback): Added.
3181         (TestRunner::staticFunctions):
3182         (TestRunner::ignoreLegacyWebNotificationPermissionRequests):
3183
3184         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3185         (DRTTestRunner::DRTTestRunner): Added bindings for new APIs.
3186         (DRTTestRunner::grantWebNotificationPermission):
3187         (DRTTestRunner::denyWebNotificationPermission): Stub.
3188         (DRTTestRunner::removeAllWebNotificationPermissions): Stub.
3189         (DRTTestRunner::simulateWebNotificationClick): Stub.
3190         (DRTTestRunner::simulateLegacyWebNotificationClick):
3191         * DumpRenderTree/chromium/DRTTestRunner.h:
3192         (DRTTestRunner):
3193
3194         Added stubs.
3195         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3196         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3197         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3198         * DumpRenderTree/mac/TestRunnerMac.mm: Later patch will contain implementation of this API.
3199         * DumpRenderTree/qt/TestRunnerQt.cpp: Added Qt-based stubs.
3200         * DumpRenderTree/win/TestRunnerWin.cpp:
3201
3202 2012-08-28  Szilard Ledan  <szledan@inf.u-szeged.hu>
3203
3204         [webkit-patch] gets stuck into an infinite loop if bugzilla doesn't respond in time.
3205         https://bugs.webkit.org/show_bug.cgi?id=94700
3206
3207         Reviewed by Eric Seidel.
3208
3209         Interrupting download with a timeout would be a possible solution.
3210         I imported the socket module and used the setdefaulttimeout() method.
3211         Fixing it is important, because EWS bots need to be restarted regularly
3212         because of this bug.
3213
3214         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3215         (Bugzilla._get_browser):
3216         (Bugzilla.setdefaulttimeout):
3217
3218 2012-08-28  Gabor Rapcsanyi  <rgabor@webkit.org>
3219
3220         [Qt] Keep QT_QPA_PLATFORM_PLUGIN_PATH environment variable in NRWT
3221         https://bugs.webkit.org/show_bug.cgi?id=95194
3222
3223         Reviewed by Simon Hausmann.
3224
3225         * Scripts/webkitpy/layout_tests/port/qt.py:
3226         (QtPort.setup_environ_for_server):
3227
3228 2012-08-28  Andras Becsi  <andras.becsi@nokia.com>
3229
3230         [watchlist] Unreviewed, subscribe to Qt bugs.
3231
3232         * Scripts/webkitpy/common/config/watchlist:
3233
3234 2012-08-28  Simon Hausmann  <simon.hausmann@nokia.com>
3235
3236         [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
3237         https://bugs.webkit.org/show_bug.cgi?id=95054
3238
3239         Reviewed by Eric Seidel.
3240
3241         Enable CSS_IMAGE_SET for the Qt build.
3242
3243         * qmake/mkspecs/features/features.pri:
3244
3245 2012-08-27  Csaba Osztrogonác  <ossy@webkit.org>
3246
3247         [Qt] Enable CSS sticky position
3248         https://bugs.webkit.org/show_bug.cgi?id=95172
3249
3250         Reviewed by Simon Hausmann.
3251
3252         * qmake/mkspecs/features/features.pri:
3253
3254 2012-08-27  Zan Dobersek  <zandobersek@gmail.com>
3255
3256         [GTK] Memory cache should be cleared in between test runs
3257         https://bugs.webkit.org/show_bug.cgi?id=95105
3258
3259         Reviewed by Martin Robinson.
3260
3261         Call the new DumpRenderTreeSupportGtk helper method after every test
3262         to clear the memory cache.
3263
3264         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3265         (runTest):
3266
3267 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3268
3269         Unreviewed, rolling out r126836.
3270         http://trac.webkit.org/changeset/126836
3271         https://bugs.webkit.org/show_bug.cgi?id=95163
3272
3273         Broke all Apple ports, EFL, and Qt. (Requested by tkent on
3274         #webkit).
3275
3276         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3277         (MockWebSpeechInputController::addMockRecognitionResult):
3278         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3279         (NotificationPresenter::simulateClick):
3280         (NotificationPresenter::show):
3281         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
3282         (CppBoundClass::~CppBoundClass):
3283         (CppBoundClass::invoke):
3284         (CppBoundClass::getProperty):
3285         (CppBoundClass::setProperty):
3286         (CppBoundClass::bindCallback):
3287         (CppBoundClass::bindProperty):
3288         * DumpRenderTree/chromium/WebPreferences.cpp:
3289         (applyFontMap):
3290         * DumpRenderTree/chromium/WebViewHost.cpp:
3291         (WebViewHost::printResourceDescription):
3292         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3293         (AccessibilityController::~AccessibilityController):
3294         (AccessibilityController::winNotificationReceived):
3295         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3296         (ResourceLoadDelegate::descriptionSuitableForTestResult):
3297         * DumpRenderTree/win/TestRunnerWin.cpp:
3298         (worldIDForWorld):
3299         (TestRunner::evaluateScriptInIsolatedWorld):
3300         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
3301         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
3302         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3303         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
3304         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3305         (WTR::TestRunner::worldIDForWorld):
3306         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3307
3308 2012-08-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3309
3310         Rename first/second to key/value in HashMap iterators
3311         https://bugs.webkit.org/show_bug.cgi?id=82784
3312
3313         Reviewed by Eric Seidel.
3314
3315         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3316         (MockWebSpeechInputController::addMockRecognitionResult):
3317         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3318         (NotificationPresenter::simulateClick):
3319         (NotificationPresenter::show):
3320         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
3321         (CppBoundClass::~CppBoundClass):
3322         (CppBoundClass::invoke):
3323         (CppBoundClass::getProperty):
3324         (CppBoundClass::setProperty):
3325         (CppBoundClass::bindCallback):
3326         (CppBoundClass::bindProperty):
3327         * DumpRenderTree/chromium/WebPreferences.cpp:
3328         (applyFontMap):
3329         * DumpRenderTree/chromium/WebViewHost.cpp:
3330         (WebViewHost::printResourceDescription):
3331         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3332         (AccessibilityController::~AccessibilityController):
3333         (AccessibilityController::winNotificationReceived):
3334         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3335         (ResourceLoadDelegate::descriptionSuitableForTestResult):
3336         * DumpRenderTree/win/TestRunnerWin.cpp:
3337         (worldIDForWorld):
3338         (TestRunner::evaluateScriptInIsolatedWorld):
3339         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
3340         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
3341         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3342         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
3343         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3344         (WTR::TestRunner::worldIDForWorld):
3345         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3346
3347 2012-08-24  James Robinson  <jamesr@chromium.org>
3348
3349         WebGL should not flip textures on presentation if contents are unchanged
3350         https://bugs.webkit.org/show_bug.cgi?id=94961
3351
3352         Reviewed by Kenneth Russell.
3353
3354         Run some compositing webgl tests in threaded mode to catch regressions specific to that mode.
3355
3356         * Scripts/webkitpy/layout_tests/port/chromium.py:
3357         (ChromiumPort.virtual_test_suites):
3358
3359 2012-08-27  Gavin Peters  <gavinp@chromium.org>
3360
3361         [webkit-patch] Don't crash chrome-channels command when a previously unknown platform shows up.
3362         https://bugs.webkit.org/show_bug.cgi?id=95104
3363
3364         Reviewed by Adam Barth.
3365
3366         Today I found out this command was broken by the new iOS platform showing up on omahaproxy. Now the webkit-patch chrome-channels command gracefully handles new, previously unknown platforms. Also, it prints iOS in the proper mixed case.
3367
3368         * Scripts/webkitpy/common/net/omahaproxy.py:
3369         (OmahaProxy):
3370         (OmahaProxy.get_revisions):
3371         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
3372         (OmahaProxyTest):
3373         (OmahaProxyTest.test_get_revisions):
3374
3375 2012-08-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3376
3377         [EFL][WK2] Free Url_Bar on program exit
3378         https://bugs.webkit.org/show_bug.cgi?id=95086
3379
3380         Reviewed by Eric Seidel.
3381
3382         Fix a memory leak by freeing the Url_Bar on program exit.
3383
3384         * MiniBrowser/efl/main.c:
3385         (main): Call url_bar_del() to free the Url_Bar.
3386
3387 2012-08-27  James Robinson  <jamesr@chromium.org>
3388
3389         [chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
3390         https://bugs.webkit.org/show_bug.cgi?id=95115
3391
3392         Reviewed by Adam Barth.
3393
3394         Use VCSUtils utility function to check if webkit_unit_tests terminates normally so we generate a non-zero exit
3395         code if the unit tests crash.
3396
3397         * Scripts/run-chromium-webkit-unit-tests:
3398
3399 2012-08-27  Benjamin Poulain  <benjamin@webkit.org>
3400
3401         Add ECMAScript Number to String conversion to WTF::String
3402         https://bugs.webkit.org/show_bug.cgi?id=95016
3403
3404         Reviewed by Geoffrey Garen.
3405
3406         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3407         (TestWebKitAPI::testNumberToStringECMAScript):
3408         (TestWebKitAPI): Add tests for String's ECMAString number conversion.
3409
3410 2012-08-27  Philippe Normand  <pnormand@igalia.com>
3411
3412         [GStreamer][Qt] WebAudio support
3413         https://bugs.webkit.org/show_bug.cgi?id=94806
3414
3415         Reviewed by Simon Hausmann.
3416
3417         * MiniBrowser/qt/qml/BrowserWindow.qml: Enable WebAudio support.
3418
3419 2012-08-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3420
3421         Rename RegisterProtocolHandler API to NavigatorContentUtils
3422         https://bugs.webkit.org/show_bug.cgi?id=94920
3423
3424         Reviewed by Adam Barth.
3425
3426         Renamed 'register-protocol-handler' feature to 'navigator-content-utils'.
3427
3428         * Scripts/webkitperl/FeatureList.pm:
3429         * qmake/mkspecs/features/features.pri:
3430
3431 2012-08-24  Benjamin Poulain  <bpoulain@apple.com>
3432
3433         Unify Number to StringImpl conversion
3434         https://bugs.webkit.org/show_bug.cgi?id=94879
3435
3436         Reviewed by Geoffrey Garen.
3437
3438         Add testing for the new IntegerToStringConversion.
3439
3440         * TestWebKitAPI/CMakeLists.txt:
3441         * TestWebKitAPI/GNUmakefile.am:
3442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3443         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp: Added.
3444
3445 2012-08-23  James Robinson  <jamesr@chromium.org>
3446
3447         [chromium] Convert WebLayerTreeView interface into pure virtual
3448         https://bugs.webkit.org/show_bug.cgi?id=94866
3449
3450         Reviewed by Adrienne Walker.
3451
3452         Updates DumpRenderTree's WebViewHost to vend a WebCompositorOutputSurface so DumpRenderTree can run compositing
3453         tests.
3454
3455         * DumpRenderTree/DumpRenderTree.gypi:
3456         * DumpRenderTree/chromium/WebViewHost.cpp:
3457         (WebViewHost::createOutputSurface):
3458         * DumpRenderTree/chromium/WebViewHost.h:
3459         (WebViewHost):
3460         * DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
3461         (WebKit):
3462         (WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
3463         (WebKit::WebViewHostOutputSurface::~WebViewHostOutputSurface):
3464         (WebKit::WebViewHostOutputSurface::bindToClient):
3465         (WebKit::WebViewHostOutputSurface::capabilities):
3466         (WebKit::WebViewHostOutputSurface::context3D):
3467         (WebKit::WebViewHostOutputSurface::sendFrameToParentCompositor):
3468         * DumpRenderTree/chromium/WebViewHostOutputSurface.h: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
3469         (WebKit):
3470         (WebViewHostOutputSurface):
3471
3472 2012-08-24  Xianzhu Wang  <wangxianzhu@chromium.org>
3473
3474         [Chromium-Android] Many 'Unexpected EOF ...' when a test crashes
3475         https://bugs.webkit.org/show_bug.cgi?id=94865
3476
3477         Reviewed by Dirk Pranke.
3478
3479         Android detects crash of test by checking if the return value of read() is None.
3480         Added a parameter 'treat_no_data_as_crash' to let ServerProcess know the special requirement of Android.
3481         If set, ServerProcess will set _crashed unconditionaly when there is no data.
3482
3483         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3484         (ChromiumAndroidPort.__init__):
3485         (ChromiumAndroidPort):
3486         (ChromiumAndroidPort._android_server_process_constructor):
3487         (ChromiumAndroidDriver._start_once):
3488         * Scripts/webkitpy/layout_tests/port/server_process.py:
3489         (ServerProcess.__init__):
3490         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3491
3492 2012-08-24  Arnaud Renevier  <a.renevier@sisa.samsung.com>
3493
3494         build-webkit --gtk fails with Can't exec ""
3495         https://bugs.webkit.org/show_bug.cgi?id=94944
3496
3497         Reviewed by Martin Robinson.
3498
3499         When jhbuild wrapper is not needed, do unshift a blank string to build
3500         arguments.
3501
3502         * Scripts/webkitdirs.pm:
3503         (runAutogenForAutotoolsProjectIfNecessary):
3504
3505 2012-08-24  Tommy Widenflycht  <tommyw@google.com>
3506
3507         MediaStream API: Add readyState functionality to RTCPeerConnection
3508         https://bugs.webkit.org/show_bug.cgi?id=94813
3509
3510         Reviewed by Adam Barth.
3511
3512         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3513         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3514         (MockWebRTCPeerConnectionHandler::stop):
3515         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3516         (MockWebRTCPeerConnectionHandler):
3517
3518 2012-08-24  Michael Brüning  <michaelbruening@gmail.com>
3519
3520         Unreviewed. Adding myself to committers list.
3521
3522         Also updated email information.
3523
3524         * Scripts/webkitpy/common/config/committers.py:
3525
3526 2012-08-24  Michael Brüning  <michaelbruening@gmail.com>
3527
3528         [Qt][WK2] Make viewport related experimental.test properties encapsulated.
3529         https://bugs.webkit.org/show_bug.cgi?id=88320
3530
3531         Reviewed by Kenneth Rohde Christiansen.
3532
3533         Changed the access to the viewport attributes to use the viewport object that is introduced by this change.
3534
3535         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3536
3537 2012-08-23  Dirk Pranke  <dpranke@chromium.org>
3538
3539         leak detection broken after r126247 on mac
3540         https://bugs.webkit.org/show_bug.cgi?id=94893
3541
3542         Unreviewed, build fix.
3543
3544         Adds is_snowleopard(), is_lion back() in for the mac port. We'll
3545         probably need an is_mountainlion() or equivalent at some point,
3546         I'm guessing (but I've deleted the leopard code).
3547
3548         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
3549         (LeakDetector._callstacks_to_exclude_from_leaks):
3550         * Scripts/webkitpy/layout_tests/port/mac.py:
3551         (MacPort):
3552         (MacPort.is_snowleopard):
3553         (MacPort.is_lion):
3554
3555 2012-08-23  Julien Chaffraix  <jchaffraix@webkit.org>
3556
3557         [Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests
3558         https://bugs.webkit.org/show_bug.cgi?id=94871
3559
3560         Reviewed by Benjamin Poulain.
3561
3562         * TestWebKitAPI/TestWebKitAPI.gypi:
3563         Added the missing files to Chromium's build system.
3564
3565 2012-08-23  Raphael Kubo da Costa  <rakuco@webkit.org>
3566
3567         [watchlist] Unreviewed, subscribe to WebKit2-EFL bugs.
3568
3569         * Scripts/webkitpy/common/config/watchlist:
3570
3571 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
3572
3573         Replay tests take forever to load
3574         https://bugs.webkit.org/show_bug.cgi?id=94764
3575
3576         Reviewed by Adam Barth.
3577
3578         Don't load about:blank at the beginning. This appears to clog the DRT.
3579
3580         * Scripts/webkitpy/performance_tests/perftest.py:
3581         (ReplayPerfTest.run_single):
3582         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3583         (TestReplayPerfTest.test_run_single):
3584         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
3585
3586 2012-08-23  Kenneth Russell  <kbr@google.com>
3587
3588         Unreviewed, rolling out r126497.
3589         http://trac.webkit.org/changeset/126497
3590         https://bugs.webkit.org/show_bug.cgi?id=94764
3591
3592         Caused webkitpy-test step to start failing.
3593
3594         * Scripts/webkitpy/performance_tests/perftest.py:
3595         (ReplayPerfTest.run_single):
3596
3597 2012-08-23  Emil A Eklund  <eae@chromium.org>
3598
3599         Add saturation arithmetic support to FractionalLayoutUnit
3600         https://bugs.webkit.org/show_bug.cgi?id=94364
3601
3602         Reviewed by Benjamin Poulain.
3603
3604         Add test for new saturatedArithmetic functions.
3605
3606         * TestWebKitAPI/CMakeLists.txt:
3607         * TestWebKitAPI/GNUmakefile.am:
3608         * TestWebKitAPI/TestWebKitAPI.gypi:
3609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3610         * TestWebKitAPI/Tests/WTF/SaturatedArithmeticOperations.cpp: Added.
3611         (TestWebKitAPI):
3612         (TestWebKitAPI::TEST):
3613         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3614
3615 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
3616
3617         Replay tests take forever to load
3618         https://bugs.webkit.org/show_bug.cgi?id=94764
3619
3620         Reviewed by Adam Barth.
3621
3622         Don't load about:blank at the beginning. This appears to clog the DRT.
3623
3624         * Scripts/webkitpy/performance_tests/perftest.py:
3625         (ReplayPerfTest.run_single):
3626
3627 2012-08-23  Wei Jia  <wjia@chromium.org>
3628
3629         create different WebKit::WebMediaPlayer based on URL
3630         https://bugs.webkit.org/show_bug.cgi?id=91301
3631
3632         Reviewed by Adam Barth.
3633
3634         Pass URL to createMediaPlayer. This corresponds to change in base
3635         class WebKit::WebFrameClient.
3636
3637         * DumpRenderTree/chromium/WebViewHost.cpp:
3638         (WebViewHost::createMediaPlayer): add URL as additional argument.
3639         * DumpRenderTree/chromium/WebViewHost.h:
3640         (WebViewHost):
3641
3642 2012-08-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3643
3644         Unreviewed, upgrade gyuyoung to reviewer.
3645         http://lists.webkit.org/pipermail/webkit-dev/2012-August/022004.html
3646
3647         * Scripts/webkitpy/common/config/committers.py:
3648
3649 2012-08-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3650
3651         REGRESSION(r126306): it broke the plugin process
3652         https://bugs.webkit.org/show_bug.cgi?id=94797
3653
3654         Reviewed by Xan Lopez.
3655
3656         * GNUmakefile.am:
3657
3658 2012-08-23  Ryuan Choi  <ryuan.choi@samsung.com>
3659
3660         [EFL] Add url bar to EWebLauncher and MiniBrowser/Efl.
3661         https://bugs.webkit.org/show_bug.cgi?id=63966
3662
3663         Reviewed by Kenneth Rohde Christiansen.
3664
3665    &n