Unreviewed, rolling out r219024.
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2
3         Unreviewed, rolling out r219024.
4
5         This patch cause 3 didferent test to fail.
6
7         Reverted changeset:
8
9         "REGRESSION(r215096) Queries of URLs with non-special schemes
10         should not percent-encode single quotes"
11         https://bugs.webkit.org/show_bug.cgi?id=174051
12         http://trac.webkit.org/changeset/219024
13
14 2017-07-03  Chris Dumez  <cdumez@apple.com>
15
16         Drop ResourceLoadStatisticsStore's statisticsLock
17         https://bugs.webkit.org/show_bug.cgi?id=174080
18
19         Reviewed by Brent Fulgham.
20
21         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
22
23         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
24         (WTR::TestController::isStatisticsPrevalentResource):
25         (WTR::TestController::isStatisticsHasHadUserInteraction):
26         (WTR::TestController::isStatisticsGrandfathered):
27
28 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
29
30         Pasting single words copied to UIPasteboard inserts URLs in editable areas
31         https://bugs.webkit.org/show_bug.cgi?id=174082
32         <rdar://problem/33046992>
33
34         Reviewed by Tim Horton.
35
36         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
37
38         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
39         (TestWebKitAPI::setUpWebViewForPasteboardTests):
40         (TestWebKitAPI::TEST):
41
42 2017-07-02  Brady Eidson  <beidson@apple.com>
43
44         Add API test for all parts of WebKit1 API related to favicons.
45         https://bugs.webkit.org/show_bug.cgi?id=174069
46
47         Reviewed by Andy Estes.
48
49         These two API tests cover all WebKit1 API related to icons.
50         
51         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
52         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
53         (mainResourceData):
54         (defaultFaviconData):
55         (customFaviconData):
56         (imageFromData):
57         (+[IconLoadingProtocol canInitWithRequest:]):
58         (+[IconLoadingProtocol canonicalRequestForRequest:]):
59         (-[IconLoadingProtocol startLoading]):
60         (-[IconLoadingProtocol stopLoading]):
61         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
62         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
63         (TestWebKitAPI::TEST):
64
65 2017-07-01  Dan Bernstein  <mitz@apple.com>
66
67         [iOS] Remove code only needed when building for iOS 9.x
68         https://bugs.webkit.org/show_bug.cgi?id=174068
69
70         Reviewed by Tim Horton.
71
72         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
73         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
74         (WTR::initializeWebViewConfiguration):
75         * WebKitTestRunner/ios/HIDEventGenerator.mm:
76         (-[HIDEventGenerator _createIOHIDEventType:]):
77
78 2017-07-01  Brady Eidson  <beidson@apple.com>
79
80         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
81         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
82
83         Reviewed by Alex Christensen.
84
85         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
86
87 2017-07-01  Dan Bernstein  <mitz@apple.com>
88
89         [macOS] Remove code only needed when building for OS X Yosemite
90         https://bugs.webkit.org/show_bug.cgi?id=174067
91
92         Reviewed by Tim Horton.
93
94         * DumpRenderTree/mac/Configurations/Base.xcconfig:
95         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
96         * DumpRenderTree/mac/DumpRenderTree.mm:
97         (setDefaultsToConsistentValuesForTesting):
98         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
99         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
100         * MiniBrowser/Configurations/Base.xcconfig:
101         * MiniBrowser/Configurations/DebugRelease.xcconfig:
102         * TestWebKitAPI/Configurations/Base.xcconfig:
103         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
104         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
105         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
106         (TestWebKitAPI::TEST_F):
107         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
108         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
109         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
110         (TestWebKitAPI::TEST_F):
111         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
112         (TestWebKitAPI::TEST):
113         * WebKitTestRunner/Configurations/Base.xcconfig:
114         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
115         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
116         (WTR::InjectedBundle::platformInitialize):
117         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
118         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
119
120 2017-07-01  Chris Dumez  <cdumez@apple.com>
121
122         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
123         https://bugs.webkit.org/show_bug.cgi?id=174060
124
125         Reviewed by Brent Fulgham.
126
127         Port WebKitTestRunner over to the new Cocoa SPI.
128
129         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
130         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
131         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
132         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
133         no-ops since this code runs in the WebContent process, not the
134         UIProcess.
135
136         * WebKitTestRunner/TestController.cpp:
137         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
138
139 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
140
141         Unreviewed mac build fix.
142
143         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
144         (TestWebKitAPI::TEST):
145
146 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
147
148         Add API to get WKActivatedElementInfo
149         https://bugs.webkit.org/show_bug.cgi?id=174001
150         <rdar://problem/29165518>
151         
152         Tests for now SPI to get activatedElementInfo.
153
154         Reviewed by Tim Horton.
155
156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
157         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
158         (TestWebKitAPI::TEST):
159
160 2017-06-30  Chris Dumez  <cdumez@apple.com>
161
162         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
163         https://bugs.webkit.org/show_bug.cgi?id=174038
164
165         Reviewed by Brent Fulgham.
166
167         Fix typo in API name.
168
169         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
170         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
171         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
172         * WebKitTestRunner/InjectedBundle/TestRunner.h:
173         * WebKitTestRunner/TestController.cpp:
174         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
175         * WebKitTestRunner/TestController.h:
176         * WebKitTestRunner/TestInvocation.cpp:
177         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
178
179 2017-06-30  Alex Christensen  <achristensen@webkit.org>
180
181         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
182         https://bugs.webkit.org/show_bug.cgi?id=174051
183         <rdar://problem/33002846>
184
185         Reviewed by Tim Horton.
186
187         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
188         (TestWebKitAPI::TEST_F):
189
190 2017-06-30  Daniel Bates  <dabates@apple.com>
191
192         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
193         https://bugs.webkit.org/show_bug.cgi?id=165160
194         <rdar://problem/29451999>
195
196         Reviewed by Brady Eidson.
197
198         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
199         for navigations and window creation.
200
201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
202         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
203         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
204         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
205         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
206         (TEST):
207
208 2017-06-29  Jer Noble  <jer.noble@apple.com>
209
210         Make Legacy EME API controlled by RuntimeEnabled setting.
211         https://bugs.webkit.org/show_bug.cgi?id=173994
212
213         Reviewed by Sam Weinig.
214
215         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
216
217 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
218
219         Follow-up fix for r218996
220
221         Unreviewed infrastructure fix.
222
223         Repeated calls to 'ios_version' make the log noisy, memoize the function.
224
225         * Scripts/webkitpy/port/ios_simulator.py:
226         (IOSSimulatorPort): Memoize ios_version().
227
228 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
229
230         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
231         https://bugs.webkit.org/show_bug.cgi?id=174017
232         <rdar://problem/32959782>
233
234         Reviewed by Simon Fraser.
235
236         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
237         changes, the caret would appear outside of the iframe.
238
239         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
240         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
241         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
242         (checkDragCaretRectIsContainedInRect):
243         (TestWebKitAPI::TEST):
244         * TestWebKitAPI/ios/DataInteractionSimulator.h:
245         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
246         (-[DataInteractionSimulator _resetSimulatedState]):
247         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
248         (-[DataInteractionSimulator _advanceProgress]):
249         (-[DataInteractionSimulator lastKnownDragCaretRect]):
250
251 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
252
253         Add support for different versions of iOS when loading test expectations
254         https://bugs.webkit.org/show_bug.cgi?id=173774
255         <rdar://problem/32951132>
256
257         Rubber-stamped by Aakash Jain.
258
259         When running layout tests, we should support multiple version of iOS the same way we do Mac.
260
261         * Scripts/webkitpy/port/ios.py:
262         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
263         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
264         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
265         * Scripts/webkitpy/port/ios_device.py:
266         (IOSDevicePort.ios_version): Ask connected devices for implementation.
267         * Scripts/webkitpy/port/ios_device_unittest.py:
268         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
269         (IOSDeviceTest.test_baseline_searchpath): Ditto.
270         (IOSDeviceTest.test_expectations_ordering): Ditto.
271         * Scripts/webkitpy/port/ios_simulator.py:
272         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
273         ask the platform.
274
275 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
276
277         Fontconfig build breaks with glibc 2.15+
278         https://bugs.webkit.org/show_bug.cgi?id=174019
279
280         Reviewed by Carlos Alberto Lopez Perez.
281
282         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
283
284         * wpe/jhbuild.modules:
285         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
286
287 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
288
289         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
290         https://bugs.webkit.org/show_bug.cgi?id=174010
291         <rdar://problem/32597802>
292
293         Reviewed by Tim Horton.
294
295         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
296         snapshot fails for any reason.
297
298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
299         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
300         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
301         (TestWebKitAPI::TEST):
302
303 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
304
305         AX: Cannot call setValue() on contenteditable or ARIA text controls
306         https://bugs.webkit.org/show_bug.cgi?id=173520
307
308         Reviewed by Ryosuke Niwa.
309
310         Add setValue() method to WKTR (already existed in DRT).
311
312         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
313         (WTR::AccessibilityUIElement::setValue):
314         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
315         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
316         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
317         (WTR::AccessibilityUIElement::setValue):
318
319 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
320
321         getBoundingClientRect returns wrong value for combination of page zoom and scroll
322         https://bugs.webkit.org/show_bug.cgi?id=173841
323         rdar://problem/32983841
324
325         Reviewed by Dean Jackson.
326
327         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
328         always did text zooming.
329
330         * MiniBrowser/mac/WK1BrowserWindowController.m:
331         (-[WK1BrowserWindowController zoomIn:]):
332         (-[WK1BrowserWindowController zoomOut:]):
333         (-[WK1BrowserWindowController canResetZoom]):
334         (-[WK1BrowserWindowController resetZoom:]):
335
336 2017-06-29  John Wilander  <wilander@apple.com>
337
338         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
339         https://bugs.webkit.org/show_bug.cgi?id=173940
340         <rdar://problem/33018125>
341
342         Reviewed by Brent Fulgham.
343
344         This change allows the TestController to turn off
345         regular resource load statistics telemetry submission
346         and to manually control when telemetry is calculated
347         and submitted.
348
349         * WebKitTestRunner/TestController.cpp:
350         (WTR::TestController::initialize):
351             Turns off automatic resource load statistics telemetry submission.
352
353 2017-06-29  Commit Queue  <commit-queue@webkit.org>
354
355         Unreviewed, rolling out r218512.
356         https://bugs.webkit.org/show_bug.cgi?id=173981
357
358         "It changes the behavior of the JS API's JSEvaluateScript
359         which breaks TurboTax" (Requested by saamyjoon on #webkit).
360
361         Reverted changeset:
362
363         "test262: Completion values for control flow do not match the
364         spec"
365         https://bugs.webkit.org/show_bug.cgi?id=171265
366         http://trac.webkit.org/changeset/218512
367
368 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
369
370         Add WebKitSystemInterface for iOS 11
371         https://bugs.webkit.org/show_bug.cgi?id=173936
372
373         Reviewed by Lucas Forschler.
374
375         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
376
377 2017-06-28  Keith Miller  <keith_miller@apple.com>
378
379         VMTraps has some races
380         https://bugs.webkit.org/show_bug.cgi?id=173941
381
382         Reviewed by Michael Saboff.
383
384         Add new testing mode for testing the Watchdog with our stress
385         tests.
386
387         * Scripts/run-jsc-stress-tests:
388
389 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
390
391         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
392         https://bugs.webkit.org/show_bug.cgi?id=173877
393
394         Reviewed by Brady Eidson.
395
396         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
397         the next tests.
398
399         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
400         (testGetFavicon):
401
402 2017-06-28  Tim Horton  <timothy_horton@apple.com>
403
404         MobileSafari was constantly using 10-15% CPU viewing a PDF
405         https://bugs.webkit.org/show_bug.cgi?id=173944
406         <rdar://problem/33039910>
407
408         Reviewed by Simon Fraser.
409
410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
411         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
412         Add a test that we ever call the stable presentation update callback
413         when we have a WKPDFView up, instead of infinitely looping.
414
415 2017-06-28  Alex Christensen  <achristensen@webkit.org>
416
417         Prevent displaying URLs with small capital letters
418         https://bugs.webkit.org/show_bug.cgi?id=173949
419         <rdar://problem/32952058>
420
421         Reviewed by Brent Fulgham.
422
423         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
424         (TestWebKitAPI::TEST):
425
426 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
427
428         Unreviewed test fix.
429
430         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
431
432         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
433
434 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
435
436         Teach ResourceLoadStatistics to recognize changes in the file system
437         https://bugs.webkit.org/show_bug.cgi?id=173800
438         <rdar://problem/32937842>
439
440         Reviewed by Chris Dumez.
441
442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
443         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
444         (TestWebKitAPI::FileMonitorTest::tempFilePath):
445         (TestWebKitAPI::handleFileModification):
446         (TestWebKitAPI::handleFileDeletion):
447         (TestWebKitAPI::resetTestState):
448         (TestWebKitAPI::TEST_F):
449
450 2017-06-28  Brady Eidson  <beidson@apple.com>
451
452         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
453         https://bugs.webkit.org/show_bug.cgi?id=173874
454
455         Reviewed by Alex Christensen.
456
457         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
458
459 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
460
461         Unreviewed, adding Don Olmstead to contributors.json
462
463         * Scripts/webkitpy/common/config/contributors.json:
464
465 2017-06-28  Alex Christensen  <achristensen@webkit.org>
466
467         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
468         https://bugs.webkit.org/show_bug.cgi?id=173886
469         <rdar://problem/32543191>
470
471         Reviewed by Andy Estes.
472
473         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
474         (ParsedRange::ParsedRange):
475         (-[TestSchemeHandler initWithVideoData:]):
476         (-[TestSchemeHandler webView:startURLSchemeTask:]):
477         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
478         (TEST):
479
480 2017-06-27  JF Bastien  <jfbastien@apple.com>
481
482         WebAssembly: running out of executable memory should throw OoM
483         https://bugs.webkit.org/show_bug.cgi?id=171537
484         <rdar://problem/32963338>
485
486         Reviewed by Saam Barati.
487
488         * Scripts/run-jsc-stress-tests: add a configuration which runs the
489         tests under limited executable memory and avoids non-WebAssembly
490         code generation so that we more reliably run out of executable
491         memory in WebAssembly.
492
493 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
494
495         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
496         https://bugs.webkit.org/show_bug.cgi?id=173854
497         <rdar://problem/32236827>
498
499         Reviewed by Ryosuke Niwa and Tim Horton.
500
501         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
502
503         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
504         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
505         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
506         (TestWebKitAPI::TEST):
507
508 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
509
510         [PAL] Add symbol export macros for PAL
511         https://bugs.webkit.org/show_bug.cgi?id=171519
512
513         Reviewed by Konstantin Tokarev.
514
515         * DumpRenderTree/config.h:
516         * TestWebKitAPI/CMakeLists.txt:
517         * TestWebKitAPI/config.h:
518         * WebKitTestRunner/config.h:
519
520 2017-06-27  John Wilander  <wilander@apple.com>
521
522         Resource Load Statistics: Add telemetry
523         https://bugs.webkit.org/show_bug.cgi?id=173499
524         <rdar://problem/32826094>
525
526         Reviewed by Brent Fulgham.
527
528         Adds three new testRunner functions:
529         - installStatisticsDidRunTelemetryCallback()
530         - statisticsFireTelemetryHandler()
531         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
532
533         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
534         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
535         (WTR::InjectedBundle::didReceiveMessageToPage):
536         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
537         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
538         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
539         (WTR::TestRunner::statisticsFireTelemetryHandler):
540         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
541         * WebKitTestRunner/InjectedBundle/TestRunner.h:
542         * WebKitTestRunner/TestController.cpp:
543         (WTR::TestController::resetStateToConsistentValues):
544         (WTR::TestController::statisticsFireTelemetryHandler):
545         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
546         * WebKitTestRunner/TestController.h:
547         * WebKitTestRunner/TestInvocation.cpp:
548         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
549
550 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
551
552         Add missing includes to fix compilation error on FreeBSD
553         https://bugs.webkit.org/show_bug.cgi?id=172919
554
555         Reviewed by Mark Lam.
556
557         * ImageDiff/cairo/PlatformImageCairo.cpp:
558
559 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
560
561         Unreviewed, rolling out r218783.
562
563         Causing accessibility/mac/setting-attributes-is-
564         asynchronous.html to crash consistently on mac-wk2 Debug
565
566         Reverted changeset:
567
568         "AX: Cannot call setValue() on contenteditable or ARIA text
569         controls"
570         https://bugs.webkit.org/show_bug.cgi?id=173520
571         http://trac.webkit.org/changeset/218783
572
573 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
574
575         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
576         https://bugs.webkit.org/show_bug.cgi?id=173825
577
578         Reviewed by Saam Barati.
579
580         * DumpRenderTree/JavaScriptThreading.cpp:
581         (runJavaScriptThread):
582         (startJavaScriptThreads):
583         * DumpRenderTree/mac/DumpRenderTree.mm:
584         (runThread):
585         (runPthread):
586         (testThreadIdentifierMap):
587
588 2017-06-26  David Kilzer  <ddkilzer@apple.com>
589
590         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
591         <https://webkit.org/b/173837>
592
593         Reviewed by Geoffrey Garen.
594
595         The clang static analyzer can't reason about objects that are
596         assigned to a delegate as +1 retained, and then released
597         later in a different method when the delegate is cleared.
598
599         Instead, use a common idiom where the object setting the
600         delegate retains it as an instance variable on initialization.
601         Then the same object clears the delegate and releases its
602         instance variable during teardown.
603
604         Also add EXPECT_TRUE() tests to make sure the delegate objects
605         match before teardown.
606
607         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
608         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
609         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
610         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
611         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
612         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
613
614 2017-06-26  David Kilzer  <ddkilzer@apple.com>
615
616         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
617         <https://webkit.org/b/173836>
618
619         Reviewed by Brady Eidson.
620
621         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
622         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
623         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
624         objects in this test.
625
626 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
627
628         [ATK] Add support for aria-details and aria-errormessage
629         https://bugs.webkit.org/show_bug.cgi?id=172588
630
631         Reviewed by Chris Fleizach.
632
633         Add additional methods to test ARIA properties which are exposed via
634         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
635         to versions which support the details and error-message relation types.
636
637         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
638         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
639         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
640         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
641         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
642         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
643         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
644         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
645         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
646         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
647         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
648         * gtk/jhbuild.modules:
649
650 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
651
652         Unreviewed. Add libfii to GTK+ install dependencies script.
653
654         * gtk/install-dependencies:
655
656 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
657
658         Unreviewed, rolling out r215190.
659
660         Broke product select element on GNOME Bugzilla
661
662         Reverted changeset:
663
664         "[GTK] Misplaced right click menu on web page due to
665         deprecated gtk_menu_popup()"
666         https://bugs.webkit.org/show_bug.cgi?id=170553
667         http://trac.webkit.org/changeset/215190
668
669 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
670
671         Remove Reflect.enumerate
672         https://bugs.webkit.org/show_bug.cgi?id=173806
673
674         Reviewed by Yusuke Suzuki.
675
676         * Scripts/run-jsc-stress-tests:
677
678 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
679
680         AX: Cannot call setValue() on contenteditable or ARIA text controls
681         https://bugs.webkit.org/show_bug.cgi?id=173520
682
683         Reviewed by Ryosuke Niwa.
684
685         Add setValue() method to WKTR (already existed in DRT).
686
687         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
688         (WTR::AccessibilityUIElement::setValue):
689         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
690         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
691         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
692         (WTR::AccessibilityUIElement::setValue):
693
694 2017-06-23  Keith Miller  <keith_miller@apple.com>
695
696         Switch VMTraps to use halt instructions rather than breakpoint instructions
697         https://bugs.webkit.org/show_bug.cgi?id=173677
698
699         Reviewed by JF Bastien.
700
701         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
702         (TEST):
703
704 2017-06-23  Youenn Fablet  <youenn@apple.com>
705
706         Set getUserMedia permission to true by default on WTR
707         https://bugs.webkit.org/show_bug.cgi?id=173610
708
709         Reviewed by Alex Christensen.
710
711         Adding a way to reset the getUserMedia permission to pending.
712
713         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
714         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
715         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
716         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
717         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
718         (WTR::TestRunner::setUserMediaPermissionAsUnset):
719         * WebKitTestRunner/InjectedBundle/TestRunner.h:
720         * WebKitTestRunner/TestController.cpp:
721         (WTR::TestController::resetStateToConsistentValues):
722         (WTR::TestController::setUserMediaPermissionAsUnset):
723         * WebKitTestRunner/TestController.h:
724         * WebKitTestRunner/TestInvocation.cpp:
725         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
726
727 2017-06-23  Alex Christensen  <achristensen@webkit.org>
728
729         Add SPI to WKURLSchemeTask for redirection
730         https://bugs.webkit.org/show_bug.cgi?id=173730
731
732         Reviewed by Brady Eidson.
733
734         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
735         (-[SchemeHandler webView:startURLSchemeTask:]):
736         (-[SchemeHandler webView:stopURLSchemeTask:]):
737         (TEST):
738         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
739         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
740         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
741         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
742         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
743
744 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
745
746         [WPE] Use JSC API to send script messages from web extension in tests
747         https://bugs.webkit.org/show_bug.cgi?id=173757
748
749         Reviewed by Žan Doberšek.
750
751         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
752         to run postMessage().
753
754         Fixes: /wpe/WebKitSecurityManager/file-xhr
755                /wpe/WebKitConsoleMessage/console-api
756                /wpe/WebKitConsoleMessage/js-exception
757                /wpe/WebKitConsoleMessage/network-error
758                /wpe/WebKitConsoleMessage/security-error
759
760         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
761         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
762         (beforeAll): Ditto.
763         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
764         (testWebContextSecurityFileXHR): Ditto.
765         (beforeAll): Ditto.
766         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
767         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
768         (pageCreatedCallback): Remove ifdefs.
769
770 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
771
772         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
773
774         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
775         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
776         doesn't exist yet in WPE.
777
778         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
779         (testWebViewJavaScriptDialogs):
780         (testWebViewWindowProperties):
781
782 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
783
784         [GTK] Upgrade pixman and cairo in jhbuild
785         https://bugs.webkit.org/show_bug.cgi?id=173710
786
787         Reviewed by Carlos Alberto Lopez Perez.
788
789         * gtk/jhbuild.modules:
790
791 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
792
793         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
794         https://bugs.webkit.org/show_bug.cgi?id=173711
795
796         Reviewed by Carlos Alberto Lopez Perez.
797
798         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
799         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
800
801         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
802         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
803
804 2017-06-22  David Kilzer  <ddkilzer@apple.com>
805
806         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
807         <https://webkit.org/b/173721>
808
809         Reviewed by Joseph Pecoraro.
810
811         Use RetainPtr<> to create NSMutableDictionary and NSNumber
812         objects to fix leaks and to avoid the autoreleasepool.
813
814         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
815         (TEST):
816
817 2017-06-22  Matt Lewis  <jlewis3@apple.com>
818
819         Unreviewed, rolling out r218633.
820
821         The test is failing frequently on Sierra Debug and Windows
822
823         Reverted changeset:
824
825         "AX: Cannot call setValue() on contenteditable or ARIA text
826         controls"
827         https://bugs.webkit.org/show_bug.cgi?id=173520
828         http://trac.webkit.org/changeset/218633
829
830 2017-06-22  David Kilzer  <ddkilzer@apple.com>
831
832         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
833         <https://webkit.org/b/173690>
834
835         Reviewed by Chris Dumez.
836
837         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
838         ownership of malloc()-ed memory, then frees it when it's
839         released.  These tests were passing global variables into the
840         method, which is not malloc()-ed memory, which violates the API
841         contract.
842
843         The fix is to switch to use
844         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
845         NO for the last argument.
846
847         Caught by the clang static analyzer.
848
849         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
850         (TEST):
851         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
852         (TEST):
853
854 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
855
856         [GTK] Upgrade Harfbuzz to version 1.4.2
857         https://bugs.webkit.org/show_bug.cgi?id=173592
858
859         Reviewed by Carlos Alberto Lopez Perez.
860
861         * gtk/jhbuild.modules:
862
863 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
864
865         [WPE] Update WPEBackend-mesa
866         https://bugs.webkit.org/show_bug.cgi?id=173705
867
868         Reviewed by Carlos Alberto Lopez Perez.
869
870         A crash has been fixed, needed for unit tests to work.
871
872         * wpe/jhbuild.modules:
873
874 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
875
876         Remove unused coordinated graphics C API
877         https://bugs.webkit.org/show_bug.cgi?id=173706
878
879         Reviewed by Žan Doberšek.
880
881         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
882         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
883         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
884         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
885         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
886         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
887
888 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
889
890         [WPE] Build glib API tests
891         https://bugs.webkit.org/show_bug.cgi?id=173702
892
893         Reviewed by Žan Doberšek.
894
895         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
896         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
897         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
898         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
899         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
900         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
901         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
902         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
903         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
904         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
905         and implement the missing features.
906
907         * CMakeLists.txt:
908         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
909         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
910         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
911         (testAutomationSessionRequestSession):
912         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
913         (testWebKitWebViewSessionState):
914         (testWebKitWebViewSessionStateWithFormData):
915         (testWebKitWebViewNavigationAfterSessionRestore):
916         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
917         (beforeAll):
918         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
919         (testCookieManagerEphemeral):
920         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
921         (testBlobDownload):
922         (beforeAll):
923         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
924         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
925         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
926         (testProcessPerWebView):
927         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
928         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
929         (testWebViewCreateNavigationData):
930         (testWebViewJavaScriptDialogs):
931         (testWebViewWindowProperties):
932         (testWebViewMouseTarget):
933         (testWebViewGeolocationPermissionRequests):
934         (testWebViewUserMediaPermissionRequests):
935         (testWebViewAudioOnlyUserMediaPermissionRequests):
936         (testWebViewFileChooserRequest):
937         (beforeAll):
938         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
939         (beforeAll):
940         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
941         (testPrivateBrowsing):
942         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
943         (testFindControllerHide):
944         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
945         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
946         (testWebKitSettings):
947         (beforeAll):
948         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
949         (testWebViewNewWithUserContentManager):
950         (beforeAll):
951         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
952         (testWebContextEphemeral):
953         (testWebContextProxySettings):
954         (beforeAll):
955         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
956         (testWebViewWebContext):
957         (testWebViewWebContextLifetime):
958         (testWebViewEphemeral):
959         (testWebViewSettings):
960         (testWebViewCanShowMIMEType):
961         (testWebViewPageVisibility):
962         (testWebViewIsPlayingAudio):
963         (beforeAll):
964         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
965         (testWebsiteDataEphemeral):
966         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
967         (documentLoadedCallback):
968         (pageCreatedCallback):
969         (methodCallCallback):
970         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
971         * TestWebKitAPI/glib/CMakeLists.txt:
972         * TestWebKitAPI/glib/PlatformGTK.cmake:
973         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
974         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
975         (main):
976         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
977         (Test::adoptView):
978         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
979         (WebKitTestBus::run):
980         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
981         (WebViewTest::~WebViewTest):
982         (WebViewTest::initializeWebView):
983         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
984         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
985         (WebViewTest::platformDestroy):
986         (WebViewTest::platformInitializeWebView):
987         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
988         (WebViewTest::resizeView):
989         (WebViewTest::hideView):
990         (parentWindowMapped):
991         (WebViewTest::showInWindow):
992         (WebViewTest::showInWindowAndWaitUntilMapped):
993         (WebViewTest::mouseMoveTo):
994         (WebViewTest::clickMouseButton):
995         (WebViewTest::emitPopupMenuSignal):
996         (WebViewTest::keyStroke):
997         (WebViewTest::doMouseButtonEvent):
998         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
999         (WebViewTest::platformDestroy):
1000         (WebViewTest::platformInitializeWebView):
1001         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
1002         (WebViewTest::resizeView):
1003         (WebViewTest::hideView):
1004         (WebViewTest::mouseMoveTo):
1005         (WebViewTest::clickMouseButton):
1006         (WebViewTest::keyStroke):
1007
1008 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1009
1010         [GTK] Move WebKit2 GLib API tests to glib directories
1011         https://bugs.webkit.org/show_bug.cgi?id=173642
1012
1013         Reviewed by Žan Doberšek.
1014
1015         * CMakeLists.txt:
1016         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
1017         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
1018         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
1019         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
1020         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
1021         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
1022         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
1023         (testWebKitConsoleMessageNetworkError):
1024         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
1025         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
1026         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
1027         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
1028         (testLoadFromGResource):
1029         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
1030         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
1031         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
1032         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
1033         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
1034         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
1035         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
1036         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
1037         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
1038         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
1039         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
1040         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
1041         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
1042         (testWebViewRunJavaScript):
1043         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
1044         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
1045         (registerGResource):
1046         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
1047         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
1048         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
1049         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
1050         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
1051         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
1052         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
1053         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
1054         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
1055         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
1056         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
1057         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
1058         * TestWebKitAPI/glib/CMakeLists.txt: Added.
1059         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
1060         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
1061         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
1062         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
1063         (registerGResource):
1064         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
1065         (Test::getResourcesDir):
1066         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
1067         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
1068         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
1069         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
1070         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
1071         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
1072
1073 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1074
1075         [WPE] Add initial web extensions API
1076         https://bugs.webkit.org/show_bug.cgi?id=173640
1077
1078         Reviewed by Žan Doberšek.
1079
1080         Add style checker exceptions for WPE web extensions API files.
1081
1082         * Scripts/webkitpy/style/checker.py:
1083
1084 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1085
1086         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
1087         https://bugs.webkit.org/show_bug.cgi?id=173659
1088         <rdar://problem/32879788>
1089
1090         Reviewed by Tim Horton.
1091
1092         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
1093
1094         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
1095
1096         Augment this test page to log dragend and dragstart events on the drag source as well.
1097
1098         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1099         (checkStringArraysAreEqual):
1100         (TestWebKitAPI::TEST):
1101
1102 2017-06-21  Antoine Quint  <graouts@apple.com>
1103
1104         Ensure DRT always logs rAF suspension debugging code
1105         https://bugs.webkit.org/show_bug.cgi?id=173681
1106
1107         Reviewed by Tim "Mr. T" Horton.
1108
1109         * DumpRenderTree/mac/DumpRenderTree.mm:
1110         (resetWebPreferencesToConsistentValues):
1111
1112 2017-06-21  Chris Dumez  <cdumez@apple.com>
1113
1114         Allow constructing a WTF:Function from a function pointer
1115         https://bugs.webkit.org/show_bug.cgi?id=173660
1116
1117         Reviewed by Alex Christensen.
1118
1119         Add API test coverage.
1120
1121         * TestWebKitAPI/Tests/WTF/Function.cpp:
1122         (TestWebKitAPI::returnThree):
1123         (TestWebKitAPI::returnFour):
1124         (TestWebKitAPI::returnPassedValue):
1125         (TestWebKitAPI::TEST):
1126
1127 2017-06-21  Antoine Quint  <graouts@apple.com>
1128
1129         Add logging to identify when the Page suspends scripted animations
1130         https://bugs.webkit.org/show_bug.cgi?id=173626
1131
1132         Reviewed by Tim Horton.
1133
1134         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
1135
1136         * DumpRenderTree/mac/DumpRenderTree.mm:
1137         (resetWebPreferencesToConsistentValues):
1138
1139 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
1140
1141         AX: Cannot call setValue() on contenteditable or ARIA text controls
1142         https://bugs.webkit.org/show_bug.cgi?id=173520
1143
1144         Reviewed by Ryosuke Niwa.
1145
1146         Add setValue() method to WKTR (already existed in DRT).
1147
1148         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1149         (WTR::AccessibilityUIElement::setValue):
1150         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1151         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1152         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1153         (WTR::AccessibilityUIElement::setValue):
1154
1155 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
1156
1157         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
1158         as one of the dependencies required to build the product.
1159
1160         Rubber-stamped by Carlos Garcia Campos.
1161
1162         * gtk/install-dependencies:
1163         * wpe/install-dependencies:
1164
1165 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
1166
1167         Disable font variations on macOS Sierra and iOS 10
1168         https://bugs.webkit.org/show_bug.cgi?id=173618
1169         <rdar://problem/32879164>
1170
1171         Reviewed by Jon Lee.
1172
1173         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1174
1175 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1176
1177         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
1178         https://bugs.webkit.org/show_bug.cgi?id=173578
1179         <rdar://problem/32825028>
1180
1181         Reviewed by Tim Horton.
1182
1183         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
1184         a custom popover does not cause dragging to fail when the popover is presented.
1185
1186         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1187         (-[DataInteractionSimulator _advanceProgress]):
1188
1189 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1190
1191         [WPE] Add initial implementation of glib API
1192         https://bugs.webkit.org/show_bug.cgi?id=173546
1193
1194         Reviewed by Žan Doberšek.
1195
1196         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
1197         include WPE glib API files.
1198
1199         * Scripts/webkitperl/FeatureList.pm:
1200         * Scripts/webkitpy/style/checker.py:
1201         * Scripts/webkitpy/style/checkers/cpp.py:
1202         (check_identifier_name_in_declaration):
1203
1204 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1205
1206         [GTK] Upgrade to ICU to version 57.1
1207         https://bugs.webkit.org/show_bug.cgi?id=173538
1208
1209         Reviewed by Žan Doberšek.
1210
1211         * gtk/jhbuild.modules:
1212
1213 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1214
1215         [GTK] Remove unneeded modules from the jhbuild
1216         https://bugs.webkit.org/show_bug.cgi?id=170540
1217
1218         Reviewed by Michael Catanzaro.
1219
1220         We are building libxslt and libffi that we don't really need to build from sources.
1221
1222         * gtk/jhbuild.modules:
1223
1224 2017-06-19  Frederic Wang  <fwang@igalia.com>
1225
1226         [Mac] Add an experimental feature setting for async frame scrolling
1227         https://bugs.webkit.org/show_bug.cgi?id=173359
1228
1229         Reviewed by Simon Fraser.
1230
1231         * DumpRenderTree/mac/DumpRenderTree.mm:
1232         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
1233         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
1234         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1235         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
1236
1237 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
1238
1239         Unreviewed, adding myself to contributors.json
1240
1241         * Scripts/webkitpy/common/config/contributors.json:
1242
1243 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
1244
1245         test262: Completion values for control flow do not match the spec
1246         https://bugs.webkit.org/show_bug.cgi?id=171265
1247
1248         Reviewed by Saam Barati.
1249
1250         * Scripts/run-jsc-stress-tests:
1251         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
1252
1253 2017-06-19  Zalan Bujtas  <zalan@apple.com>
1254
1255         Opening certain mails brings up a mail that grows indefinitely.
1256         https://bugs.webkit.org/show_bug.cgi?id=173562
1257         <rdar://problem/32766579>
1258
1259         Reviewed by Tim Horton.
1260
1261         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1262         (TEST):
1263
1264 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1265
1266         [iOS DnD] Support .zip archives for file uploads via drag and drop
1267         https://bugs.webkit.org/show_bug.cgi?id=173511
1268         <rdar://problem/32521025>
1269
1270         Reviewed by Tim Horton.
1271
1272         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
1273         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
1274
1275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1276         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
1277         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1278         (testZIPArchive):
1279         (TestWebKitAPI::TEST):
1280
1281 2017-06-18  Darin Adler  <darin@apple.com>
1282
1283         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
1284         https://bugs.webkit.org/show_bug.cgi?id=173526
1285
1286         Reviewed by Sam Weinig.
1287
1288         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
1289         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1290
1291         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
1292         tests for assignment before destruction ones.
1293
1294         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
1295         as a function, so it can be used in WTF::Function tests.
1296
1297         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
1298         Added tests for swap and for assignment before deref.
1299
1300         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
1301         to inline everything. Also removed the unnecessary clearing of the log every time
1302         the DerivedRefLogger constructor is called.
1303         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
1304
1305         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
1306         Added tests for assignment before deref and similar for releaseNonNull.
1307
1308 2017-06-19  Sam Weinig  <sam@webkit.org>
1309
1310         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
1311         https://bugs.webkit.org/show_bug.cgi?id=173513
1312
1313         Reviewed by Alex Christensen.
1314
1315         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1316         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1317         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
1318
1319 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
1320
1321         [Win] fast/dom/assign-to-window-status.html is flaky.
1322         https://bugs.webkit.org/show_bug.cgi?id=173512
1323
1324         Reviewed by Alex Christensen.
1325
1326         We should not dump status callbacks when test is done.
1327
1328         * DumpRenderTree/win/UIDelegate.cpp:
1329         (UIDelegate::setStatusText):
1330
1331 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1332
1333         [WPE][JHBuild] Update WPEBackend-mesa
1334         https://bugs.webkit.org/show_bug.cgi?id=173433
1335
1336         Unreviewed.
1337
1338         Update WPEBackend-mesa back (like it was done originally in r218344)
1339         after fixing the issue with the DISPLAY environment variables that
1340         caused the crashes.
1341
1342         * wpe/jhbuild.modules:
1343
1344 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1345
1346         Rename unit test file after r218482
1347         https://bugs.webkit.org/show_bug.cgi?id=173483
1348
1349         Unreviewed.
1350
1351         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
1352
1353 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1354
1355         Unreviewed. Fix wrong style checker condition added in r218487.
1356
1357         * Scripts/webkitpy/style/checkers/cpp.py:
1358         (check_identifier_name_in_declaration):
1359
1360 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
1361
1362         Missing <functional> includes make builds fail with GCC 7.x
1363         https://bugs.webkit.org/show_bug.cgi?id=173544
1364
1365         Unreviewed gardening.
1366
1367         Fix compilation with GCC 7.
1368
1369         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1370         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1371
1372 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1373
1374         [GTK] Move GTK+ API files that could be shared to glib dirs
1375         https://bugs.webkit.org/show_bug.cgi?id=173545
1376
1377         Reviewed by Žan Doberšek.
1378
1379         Update paths of GTK+ API in watchlist and style checker.
1380
1381         * Scripts/webkitpy/common/config/watchlist:
1382         * Scripts/webkitpy/style/checker.py:
1383         * Scripts/webkitpy/style/checkers/cpp.py:
1384         (check_identifier_name_in_declaration):
1385
1386 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1387
1388         Port setup_environ_for_server should not set environment variables related with the driver.
1389         https://bugs.webkit.org/show_bug.cgi?id=173483
1390
1391         Reviewed by Carlos Garcia Campos.
1392
1393         The port setup_environ_for_server() should not set environment variables
1394         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
1395         This varibles should be only set on the driver setup_environ_for_test().
1396
1397         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
1398         into the test environment even when running the tests with a driver
1399         that is not the Xorg or Xvfb one.
1400
1401         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
1402         (Port.to.setup_environ_for_server):
1403         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
1404         (Driver._setup_environ_for_driver):
1405         * Scripts/webkitpy/port/driver_unittest.py:
1406         (DriverTest.test_setup_environ_for_test):
1407         (DriverTest):
1408         (DriverTest.test_setup_environ_base_vars):
1409         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
1410         (GtkPort.setup_environ_for_server):
1411         * Scripts/webkitpy/port/wayland_unittest.py: Added.
1412         (WaylandDriverTest):
1413         (WaylandDriverTest.make_driver):
1414         (WaylandDriverTest.make_environment):
1415         (WaylandDriverTest.test_checkdriver):
1416         (WaylandDriverTest.test_environment_needed_variables):
1417         (WaylandDriverTest.test_environment_forbidden_variables):
1418         (WaylandDriverTest.test_environment_optional_variables):
1419         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
1420         (WaylandDriver.check_driver):
1421         (WaylandDriver._setup_environ_for_test):
1422         * Scripts/webkitpy/port/xorgdriver.py:
1423         (XorgDriver.check_driver):
1424         (XorgDriver._setup_environ_for_test):
1425         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
1426         (XorgDriverTest):
1427         (XorgDriverTest.make_driver):
1428         (XorgDriverTest.make_environment):
1429         (XorgDriverTest.test_checkdriver):
1430         (XorgDriverTest.test_environment_needed_variables):
1431         (XorgDriverTest.test_environment_forbidden_variables):
1432         (XorgDriverTest.test_environment_optional_variables):
1433         * Scripts/webkitpy/port/xvfbdriver.py:
1434         (XvfbDriver._setup_environ_for_test):
1435         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1436         (XvfbDriverTest.assertDriverStartSuccessful):
1437
1438
1439 2017-05-14 Frederic Wang  <fwang@igalia.com>
1440
1441         Add heuristic to avoid flattening "fullscreen" iframes
1442         https://bugs.webkit.org/show_bug.cgi?id=171914
1443
1444         Reviewed by Simon Fraser.
1445
1446         * DumpRenderTree/mac/DumpRenderTree.mm:
1447         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
1448
1449 2017-06-18  Chris Dumez  <cdumez@apple.com>
1450
1451         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
1452         https://bugs.webkit.org/show_bug.cgi?id=173522
1453         <rdar://problem/31185739>
1454
1455         Reviewed by Darin Adler.
1456
1457         Add API test for re-entering Function's assignment operators.
1458
1459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1460         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
1461         (TestWebKitAPI::TestObject::TestObject):
1462         (TestWebKitAPI::TestObject::~TestObject):
1463         (TestWebKitAPI::TestObject::operator()):
1464         (TestWebKitAPI::TEST):
1465
1466 2017-06-16  Dan Bernstein  <mitz@apple.com>
1467
1468         [Cocoa] Some declarations have missing or incorrect availability attributes
1469         https://bugs.webkit.org/show_bug.cgi?id=173508
1470
1471         Reviewed by Tim Horton.
1472
1473         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
1474         (TestWebKitAPI::TEST): Updated for renames.
1475
1476 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1477
1478         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
1479         https://bugs.webkit.org/show_bug.cgi?id=173366
1480         <rdar://problem/32767014>
1481
1482         Reviewed by Tim Horton.
1483
1484         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
1485         change in behavior.
1486
1487         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1489         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
1490         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
1491         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
1492         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
1493         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
1494         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
1495         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
1496         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
1497         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
1498         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
1499         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
1500         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
1501         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1502         (-[MockDragDropSession initWithItems:location:window:]):
1503         (-[MockDragDropSession allowsMoveOperation]):
1504         (-[MockDragDropSession isRestrictedToDraggingApplication]):
1505         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
1506         (-[MockDragDropSession canLoadObjectsOfClass:]):
1507         (-[MockDragDropSession canLoadObjectsOfClasses:]):
1508         (-[MockDragDropSession items]):
1509         (-[MockDragDropSession setItems:]):
1510         (-[MockDragDropSession locationInView:]):
1511         (-[MockDataOperationSession initWithProviders:location:window:]):
1512         (-[MockDataOperationSession session]):
1513         (-[MockDataOperationSession isLocal]):
1514         (-[MockDataOperationSession progress]):
1515         (-[MockDataOperationSession setProgressIndicatorStyle:]):
1516         (-[MockDataOperationSession progressIndicatorStyle]):
1517         (-[MockDataOperationSession operationMask]):
1518         (-[MockDataOperationSession localDragSession]):
1519         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
1520         (-[MockDataOperationSession canCreateItemsOfClass:]):
1521         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
1522         (-[MockDataInteractionSession initWithWindow:]):
1523         (-[MockDataInteractionSession localOperationMask]):
1524         (-[MockDataInteractionSession externalOperationMask]):
1525         (-[MockDataInteractionSession session]):
1526         (-[DataInteractionSimulator _advanceProgress]):
1527
1528 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1529
1530         Show punycode to user if a URL has dotless i or j followed by diacritic dot
1531         https://bugs.webkit.org/show_bug.cgi?id=173431
1532
1533         Reviewed by Darin Adler.
1534
1535         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1536         (TestWebKitAPI::TEST):
1537
1538 2017-06-16  Chris Dumez  <cdumez@apple.com>
1539
1540         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
1541         https://bugs.webkit.org/show_bug.cgi?id=173472
1542         <rdar://problem/28858817>
1543
1544         Reviewed by Brady Eidson.
1545
1546         Add API test coverage.
1547
1548         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1549         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
1550         (TEST):
1551
1552 2017-06-16  Brady Eidson  <beidson@apple.com>
1553
1554         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
1555         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
1556
1557         Reviewed by Daniel Bates.
1558
1559         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
1560
1561 2017-06-16  Chris Dumez  <cdumez@apple.com>
1562
1563         DRT fails to reset page visibility between tests
1564         https://bugs.webkit.org/show_bug.cgi?id=173485
1565
1566         Reviewed by Alexey Proskuryakov.
1567
1568         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
1569         Fix this to address flakiness.
1570
1571         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
1572         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
1573         The test became flaky without the DRT change and was no longer flaky with the DRT
1574         change.
1575
1576         WebKitTestRunner already does this.
1577
1578         * DumpRenderTree/mac/DumpRenderTree.mm:
1579         (resetWebViewToConsistentStateBeforeTesting):
1580
1581 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1582
1583         Implement basic authentication in MiniBrowser
1584         https://bugs.webkit.org/show_bug.cgi?id=173443
1585
1586         Reviewed by Tim Horton.
1587
1588         * MiniBrowser/mac/WK2BrowserWindowController.m:
1589         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
1590
1591 2017-06-16  Jer Noble  <jer.noble@apple.com>
1592
1593         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1594         https://bugs.webkit.org/show_bug.cgi?id=173398
1595         <rdar://problem/32592961>
1596
1597         Reviewed by Eric Carlson.
1598
1599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1600         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1601         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1602         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1603         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1604         (TestWebKitAPI::TEST):
1605         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1606
1607 2017-06-16  Matt Lewis  <jlewis3@apple.com>
1608
1609         Unreviewed, rolling out r218375.
1610
1611         The API test MediaStreamTrackDetached is still timing out
1612         after the patch
1613
1614         Reverted changeset:
1615
1616         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1617         reports no recording to WebKit clients"
1618         https://bugs.webkit.org/show_bug.cgi?id=173398
1619         http://trac.webkit.org/changeset/218375
1620
1621 2017-06-15  Jer Noble  <jer.noble@apple.com>
1622
1623         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1624         https://bugs.webkit.org/show_bug.cgi?id=173398
1625         <rdar://problem/32592961>
1626
1627         Reviewed by Eric Carlson.
1628
1629         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1630         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1631         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1632         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1633         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1634         (TestWebKitAPI::TEST):
1635         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1636
1637 2017-06-15  Matt Lewis  <jlewis3@apple.com>
1638
1639         Unreviewed, rolling out r218365.
1640
1641         The revision caused API timeouts on all builds.
1642
1643         Reverted changeset:
1644
1645         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1646         reports no recording to WebKit clients"
1647         https://bugs.webkit.org/show_bug.cgi?id=173398
1648         http://trac.webkit.org/changeset/218365
1649
1650 2017-06-15  Jer Noble  <jer.noble@apple.com>
1651
1652         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1653         https://bugs.webkit.org/show_bug.cgi?id=173398
1654         <rdar://problem/32592961>
1655
1656         Reviewed by Eric Carlson.
1657
1658         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1659         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1660         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1661         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1662         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1663         (TestWebKitAPI::TEST):
1664         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1665
1666 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1667
1668         REGRESSION(r218344): [WPE] Thousands of layout test crashes
1669         https://bugs.webkit.org/show_bug.cgi?id=173433
1670
1671         Unreviewed.
1672
1673         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
1674
1675 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1676
1677         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
1678         https://bugs.webkit.org/show_bug.cgi?id=173061
1679
1680         Reviewed by Žan Doberšek.
1681
1682         Launch dyz <https://github.com/Igalia/dyz> with the script
1683         run-minibrowser for the wpe port. It is now built as part of the
1684         WPE dependencies with JHBuild.
1685
1686         * Scripts/run-minibrowser:
1687         * Scripts/webkitdirs.pm:
1688         (launcherPath):
1689         (launcherName):
1690         * wpe/install-dependencies: Luajit is needed for building dyz.
1691         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
1692
1693 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1694
1695         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
1696         https://bugs.webkit.org/show_bug.cgi?id=173338
1697         <rdar://problem/32777720>
1698
1699         Reviewed by Tim Horton.
1700
1701         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
1702         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
1703         these remaining items on drop.
1704
1705         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1706         (TestWebKitAPI::TEST):
1707         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1708         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1709
1710         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
1711
1712         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
1713
1714 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
1715
1716         [Win] Crash in accessibility layout test.
1717         https://bugs.webkit.org/show_bug.cgi?id=173401
1718
1719         Reviewed by Brent Fulgham.
1720
1721         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
1722         member will be automatically released when the _variant_t object goes out of scope if the vt member
1723         does not equal VT_UNKNOWN | VT_BYREF.
1724         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
1725
1726         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1727         (AccessibilityUIElement::titleUIElement):
1728
1729 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1730
1731         [GTK] Add API to allow overriding popup menus
1732         https://bugs.webkit.org/show_bug.cgi?id=172905
1733
1734         Reviewed by Michael Catanzaro.
1735
1736         Add a unit test to check the new API.
1737
1738         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1739         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
1740         (OptionMenuTest::OptionMenuTest):
1741         (OptionMenuTest::~OptionMenuTest):
1742         (OptionMenuTest::destroyMenu):
1743         (OptionMenuTest::showOptionMenuCallback):
1744         (OptionMenuTest::menuCloseCallback):
1745         (OptionMenuTest::showOptionMenu):
1746         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
1747         (OptionMenuTest::close):
1748         (OptionMenuTest::activateItem):
1749         (OptionMenuTest::selectItem):
1750         (testOptionMenuSimple):
1751         (testOptionMenuGroups):
1752         (testOptionMenuActivate):
1753         (testOptionMenuSelect):
1754         (beforeAll):
1755         (afterAll):
1756
1757 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
1758
1759         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
1760         https://bugs.webkit.org/show_bug.cgi?id=173399
1761
1762         Reviewed by Per Arne Vollan.
1763
1764         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
1765         Curl port needs to do nothing because libcurl doesn't have disk cache.
1766
1767         * DumpRenderTree/win/DumpRenderTree.cpp:
1768         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
1769         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
1770
1771 2017-06-14  Tomas Popela  <tpopela@redhat.com>
1772
1773         [GTK] integer expression expected if running Tools/gtk/install-dependencies
1774         https://bugs.webkit.org/show_bug.cgi?id=173356
1775
1776         Reviewed by Michael Catanzaro.
1777
1778         Use the correct operator to compare the strings.
1779
1780         * gtk/install-dependencies:
1781
1782 2017-06-14  Commit Queue  <commit-queue@webkit.org>
1783
1784         Unreviewed, rolling out r218285.
1785         https://bugs.webkit.org/show_bug.cgi?id=173391
1786
1787         API test fails on iOS (Requested by alexchristensen on
1788         #webkit).
1789
1790         Reverted changeset:
1791
1792         "Add SPI for immediate injection of user scripts"
1793         https://bugs.webkit.org/show_bug.cgi?id=173342
1794         http://trac.webkit.org/changeset/218285
1795
1796 2017-06-14  Chris Dumez  <cdumez@apple.com>
1797
1798         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
1799         https://bugs.webkit.org/show_bug.cgi?id=173384
1800         <rdar://problem/32723779>
1801
1802         Reviewed by Dan Bernstein.
1803
1804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1805         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
1806         Add API test coverage.
1807
1808         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1809         (TestWebKitAPI::Util::sleep):
1810         Update implementation of Util::sleep() so that we actually run the run loop.
1811         Otherwise, we don't process events while sleeping.
1812
1813 2017-06-14  Alex Christensen  <achristensen@webkit.org>
1814
1815         Add SPI for immediate injection of user scripts
1816         https://bugs.webkit.org/show_bug.cgi?id=173342
1817         <rdar://problem/29202285>
1818
1819         Reviewed by Brady Eidson.
1820
1821         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1822         (waitForMessage):
1823         (TEST):
1824
1825 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
1826
1827         Add WPE to the flakiness dashboard
1828         https://bugs.webkit.org/show_bug.cgi?id=173365
1829
1830         Reviewed by Carlos Alberto Lopez Perez.
1831
1832         * TestResultServer/static-dashboards/builders.jsonp:
1833         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1834         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1835         (resetGlobals):
1836         * TestResultServer/static-dashboards/loader_unittests.js:
1837
1838 2017-06-14  Brady Eidson  <beidson@apple.com>
1839
1840         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
1841         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
1842
1843         Reviewed by Alex Christensen.
1844
1845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1846         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
1847         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
1848         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
1849         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
1850         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
1851         (TEST):
1852
1853 2017-06-14  Tim Horton  <timothy_horton@apple.com>
1854
1855         WKContentViewEditingActions API test always fails
1856         https://bugs.webkit.org/show_bug.cgi?id=173374
1857
1858         Reviewed by Wenson Hsieh.
1859
1860         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
1861         (TEST):
1862         selectAll isn't working, because canPerformAction for selectAll returns NO
1863         if selectionIsNone (which is true in the non-contenteditable case).
1864         Instead, make use of r218180's test page, which knows how to select itself.
1865         Also, reset the pasteboard at the beginning of the test to reduce confusion
1866         (I landed the test broken because my simulator had the correct text
1867         stuck in its pasteboard).
1868
1869 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
1870
1871         Configure screen scale for running layout tests on plus devices
1872         https://bugs.webkit.org/show_bug.cgi?id=173319
1873
1874         Reviewed by Tim Horton.
1875
1876         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
1877         * DumpRenderTree/mac/DumpRenderTree.mm:
1878         (dumpRenderTree): Set screen scale to 2.0.
1879         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
1880         add _setScale for UIScreen.
1881         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
1882         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
1883         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
1884         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
1885         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
1886         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
1887         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
1888         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
1889         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
1890         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
1891
1892 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
1893
1894         Add iOS 11 support to the bot watcher's dashboard
1895         https://bugs.webkit.org/show_bug.cgi?id=173369
1896
1897         Reviewed by Lucas Forschler.
1898
1899         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
1900         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
1901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
1902         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
1903         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1904         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1905
1906 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1907
1908         [GTK][WPE] Raise the timeout values for layout tests
1909         https://bugs.webkit.org/show_bug.cgi?id=173368
1910
1911         Reviewed by Carlos Garcia Campos.
1912
1913         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
1914         When running under valgrind a 10x multiplier is applied.
1915
1916         * Scripts/webkitpy/port/gtk.py:
1917         (GtkPort.default_timeout_ms):
1918         * Scripts/webkitpy/port/gtk_unittest.py:
1919         (GtkPortTest.test_default_timeout_ms):
1920         * Scripts/webkitpy/port/wpe.py:
1921         (WPEPort.default_timeout_ms):
1922         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
1923         (WPEPortTest):
1924         (WPEPortTest.make_port):
1925         (WPEPortTest.test_default_timeout_ms):
1926         (WPEPortTest.test_get_crash_log):
1927
1928 2017-06-14  Alex Christensen  <achristensen@webkit.org>
1929
1930         Test persistent WKHTTPCookieStorages on iOS.
1931         https://bugs.webkit.org/show_bug.cgi?id=173284
1932
1933         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1934         (TEST):
1935         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
1936
1937 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
1938
1939         [Win] DRT should not use disk cache.
1940         https://bugs.webkit.org/show_bug.cgi?id=173361
1941
1942         Reviewed by Darin Adler.
1943
1944         Like on macOS/iOS, DRT on Windows should only use memory cache.
1945
1946         * DumpRenderTree/win/DumpRenderTree.cpp:
1947         (setDefaultsToConsistentValuesForTesting):
1948         (prepareConsistentTestingEnvironment):
1949
1950 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
1951
1952         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
1953         https://bugs.webkit.org/show_bug.cgi?id=171668
1954
1955         Reviewed by Jer Noble.
1956
1957         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
1958         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
1959         Infinity when the double value passed as argument is greater than 2^64.
1960
1961         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
1962         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
1963         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
1964         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
1965         method. No behavior change for rational MediaTime.
1966
1967         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
1968         (TestWebKitAPI::TEST):
1969
1970 2017-06-13  Alex Christensen  <achristensen@webkit.org>
1971
1972         Test persistent WKHTTPCookieStorages on iOS
1973         https://bugs.webkit.org/show_bug.cgi?id=173284
1974         <rdar://problem/32260156>
1975
1976         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1977         (TEST):
1978
1979 2017-06-13  Matt Rajca  <mrajca@apple.com>
1980
1981         WebsitePolicies: let clients select specific autoplay quirks
1982         https://bugs.webkit.org/show_bug.cgi?id=173343
1983
1984         Reviewed by Alex Christensen.
1985
1986         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1987         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1988         (TEST): Updated tests.
1989
1990 2017-06-13  Daniel Bates  <dabates@apple.com>
1991
1992         Implement W3C Secure Contexts Draft Specification
1993         https://bugs.webkit.org/show_bug.cgi?id=158121
1994         <rdar://problem/26012994>
1995
1996         Reviewed by Brent Fulgham.
1997
1998         Part 4
1999
2000         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
2001         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
2002         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
2003
2004         * DumpRenderTree/TestOptions.h:
2005         * DumpRenderTree/TestOptions.mm:
2006         (TestOptions::TestOptions):
2007         * DumpRenderTree/mac/DumpRenderTree.mm:
2008         (setWebPreferencesForTestOptions):
2009         * DumpRenderTree/win/DumpRenderTree.cpp:
2010         (enableExperimentalFeatures):
2011         * WebKitTestRunner/TestController.cpp:
2012         (WTR::TestController::resetPreferencesToConsistentValues):
2013         (WTR::updateTestOptionsFromTestHeader):
2014         * WebKitTestRunner/TestOptions.h:
2015         (WTR::TestOptions::hasSameInitializationOptions):
2016
2017 2017-06-13  Alex Christensen  <achristensen@webkit.org>
2018
2019         Test persistent WKHTTPCookieStorages on iOS
2020         https://bugs.webkit.org/show_bug.cgi?id=173284
2021         <rdar://problem/32260156>
2022
2023         Reviewed by Alexey Proskuryakov.
2024
2025         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2026         (TEST):
2027
2028 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2029
2030         [GTK] Blob download doesn't work
2031         https://bugs.webkit.org/show_bug.cgi?id=172442
2032
2033         Reviewed by Carlos Alberto Lopez Perez.
2034
2035         Add a unit test to check blob downloads.
2036
2037         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2038         (testBlobDownload):
2039         (beforeAll):
2040
2041 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2042
2043         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
2044         https://bugs.webkit.org/show_bug.cgi?id=173316
2045
2046         Reviewed by Alex Christensen.
2047
2048         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
2049
2050         * gtk/manifest.txt.in:
2051
2052 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2053
2054         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
2055         https://bugs.webkit.org/show_bug.cgi?id=173315
2056
2057         Reviewed by Darin Adler.
2058
2059         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
2060         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
2061         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
2062         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
2063         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
2064         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
2065         WKGeolocationManagerRef is not destroyed.
2066
2067         * WebKitTestRunner/GeolocationProviderMock.cpp:
2068         (WTR::GeolocationProviderMock::GeolocationProviderMock):
2069         * WebKitTestRunner/GeolocationProviderMock.h:
2070
2071 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2072
2073         Unable to paste text that was copied from a page into the universal search field
2074         https://bugs.webkit.org/show_bug.cgi?id=173293
2075         <rdar://problem/32440918>
2076
2077         Reviewed by Ryosuke Niwa.
2078
2079         Adds 2 new unit tests for copying plain and rich selected web content.
2080         See WebCore and WebKit ChangeLogs for more detail.
2081
2082         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2083         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
2084         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
2085         (TestWebKitAPI::dataForPasteboardType):
2086         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2087         (TestWebKitAPI::TEST):
2088
2089 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
2090
2091         AX: [ATK] Implement missing AtkRelation types
2092         https://bugs.webkit.org/show_bug.cgi?id=155494
2093
2094         Reviewed by Darin Adler.
2095
2096         Add additional methods to test ARIA properties which are exposed via
2097         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
2098
2099         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2100         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
2101         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
2102         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
2103         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
2104         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
2105         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
2106         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
2107         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2108         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2109         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2110         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
2111         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
2112         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
2113         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
2114         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
2115         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
2116         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
2117
2118 2017-06-12  Daniel Bates  <dabates@apple.com>
2119
2120         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
2121         https://bugs.webkit.org/show_bug.cgi?id=173286
2122         <rdar://problem/32726102>
2123
2124         Reviewed by Brent Fulgham.
2125
2126         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2127         (TestWebKitAPI::TEST_F):
2128
2129 2017-06-12  Lucas Forschler  <lforschler@apple.com>
2130
2131         <rdar://problem/32683422>
2132         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
2133
2134         Reviewed by Conrad Schultz.
2135
2136         * Scripts/copy-webkitlibraries-to-product-directory:
2137
2138 2017-06-12  Tim Horton  <timothy_horton@apple.com>
2139
2140         [iOS] Cmd-C doesn't copy text from WKWebView
2141         https://bugs.webkit.org/show_bug.cgi?id=173277
2142         <rdar://problem/32396742>
2143
2144         Reviewed by Dan Bernstein.
2145
2146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2147         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
2148         Add a test ensuring that -copy on WKContentView will cause text to be copied.
2149
2150 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
2151
2152         [WebCrypto] Remove experimental feature flag of SubtleCrypto
2153         https://bugs.webkit.org/show_bug.cgi?id=173197
2154         <rdar://problem/32688148>
2155
2156         Reviewed by Brent Fulgham.
2157
2158         * DumpRenderTree/mac/DumpRenderTree.mm:
2159         (enableExperimentalFeatures):
2160         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2161         (WTR::InjectedBundle::beginTesting):
2162         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2163         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
2164         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2165
2166 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2167
2168         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
2169         https://bugs.webkit.org/show_bug.cgi?id=173238
2170         <rdar://problem/31943370>
2171
2172         Reviewed by Ryosuke Niwa and Tim Horton.
2173
2174         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
2175         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
2176         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
2177
2178         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2179         (TestWebKitAPI::TEST):
2180         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2181         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2182         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
2183         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
2184
2185 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2186
2187         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
2188         https://bugs.webkit.org/show_bug.cgi?id=173225
2189         <rdar://problem/32713144>
2190
2191         Reviewed by Tim Horton.
2192
2193         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
2194         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
2195
2196         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2197         (TestWebKitAPI::TEST):
2198
2199 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
2200
2201         Return correct process names for iOS on-device testing
2202         https://bugs.webkit.org/show_bug.cgi?id=173263
2203
2204         Reviewed by Alex Christensen.
2205
2206         When running tests on iOS devices, process names do not end with '.Development'
2207         as they do on Mac and iOS simulator.
2208
2209         * WebKitTestRunner/TestController.cpp:
2210         (WTR::TestController::webProcessName): Return correct process name without '.Development'
2211         for iOS on-device testing.
2212         (WTR::TestController::networkProcessName): Ditto.
2213         (WTR::TestController::databaseProcessName): Ditto.
2214
2215 2017-06-12  Chris Dumez  <cdumez@apple.com>
2216
2217         Regression(r217867): Legacy SessionHistoryEntryData format should not change
2218         https://bugs.webkit.org/show_bug.cgi?id=173267
2219         <rdar://problem/32701257>
2220
2221         Reviewed by Simon Fraser.
2222
2223         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
2224         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
2225         though as this covers the crash that r217867 was fixing.
2226
2227         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
2228         (TestWebKitAPI::createSessionStateData):
2229         (TestWebKitAPI::TEST):
2230         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
2231
2232 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2233
2234         [GTK] Stop dismissing menus attached to the web view for every injected event
2235         https://bugs.webkit.org/show_bug.cgi?id=172708
2236
2237         Reviewed by Alex Christensen.
2238
2239         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
2240         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
2241         events while the menu is open.
2242
2243         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2244         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
2245         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2246         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
2247
2248 2017-06-12  Miguel Gomez  <magomez@igalia.com>
2249
2250         [GTK][WPE] Enable GStreamer GL on development builds
2251         https://bugs.webkit.org/show_bug.cgi?id=173248
2252
2253         Enable GStreamer GL for GTK and WPE.
2254
2255         Reviewed by Carlos Garcia Campos.
2256
2257         * Scripts/webkitperl/FeatureList.pm:
2258
2259 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2260
2261         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
2262
2263         Notifications are no longer cleared on page navigation.
2264
2265         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2266         (testWebViewNotification):
2267
2268 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2269
2270         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
2271
2272         DBus interface and object path names were updated in r217831.
2273
2274         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
2275
2276 2017-06-10  Dan Bernstein  <mitz@apple.com>
2277
2278         Reverted r218056 because it made the IDE reindex constantly.
2279
2280         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2281         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2282         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
2283         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2284         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
2285         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2286         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2287         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2288
2289 2017-06-10  Dan Bernstein  <mitz@apple.com>
2290
2291         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
2292         https://bugs.webkit.org/show_bug.cgi?id=173223
2293
2294         Reviewed by Sam Weinig.
2295
2296         The rebuilds were happening due to a difference in the compiler options that the IDE and
2297         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
2298         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
2299         specify an appropriate path in CLANG_INDEX_STORE_PATH.
2300
2301         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2302         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2303         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
2304         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2305         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
2306         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2307         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2308         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2309
2310 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
2311
2312         webkitpy: Reduce polling in ServerProcess
2313         https://bugs.webkit.org/show_bug.cgi?id=173116
2314
2315         Reviewed by Ryosuke Niwa.
2316
2317         We should be smarter about polling. We do not need to poll every time a line is read from
2318         stdout and stderr since lines are usually read from cached data. We should only poll
2319         when extracting that cached data from stdout and stderr.
2320
2321         * Scripts/webkitpy/port/driver.py:
2322         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
2323         and on ServerProcess to poll the process if not data is available in stdout and stderr.
2324         * Scripts/webkitpy/port/driver_unittest.py:
2325         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
2326         ServerProcess.
2327         * Scripts/webkitpy/port/server_process.py:
2328         (ServerProcess._read): Allow for data to be read from _output even if the process has
2329         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
2330         * Scripts/webkitpy/port/server_process_mock.py:
2331         (MockServerProcess): Add number_of_times_polled.
2332         (MockServerProcess.poll): Increment number_of_times_polled.
2333         (MockServerProcess.has_crashed): Poll before returning crash state.
2334         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
2335         just like a ServerProcess would.
2336         (MockServerProcess.read_stdout): Ditto.
2337         * Scripts/webkitpy/port/server_process_unittest.py:
2338         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
2339         process from ending before stdout and stderr are read. This is the reason this test was flakey.
2340         (TestServerProcess):
2341         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
2342         the processes is polled.
2343         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
2344         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
2345
2346 2017-06-10  Andy Estes  <aestes@apple.com>
2347
2348         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
2349         https://bugs.webkit.org/show_bug.cgi?id=173190
2350         <rdar://problem/31360659>
2351
2352         Reviewed by Brady Eidson.
2353         
2354         Added a release assert that tries to create a proper test failure if the web process crashes.
2355
2356         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2357         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
2358
2359 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2360
2361         [iOS DnD] Add a hook to perform two-step drops in editable content
2362         https://bugs.webkit.org/show_bug.cgi?id=172992
2363         <rdar://problem/32590174>
2364
2365         Reviewed by Tim Horton.
2366
2367         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
2368         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
2369                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
2370
2371         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
2372         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2373         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
2374
2375         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
2376         be overridden. Currently, this is overridden to just return true.
2377
2378         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2379         (TestWebKitAPI::TEST):
2380         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2381         (WTR::InjectedBundlePage::InjectedBundlePage):
2382
2383 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2384
2385         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
2386         https://bugs.webkit.org/show_bug.cgi?id=173103
2387
2388         Reviewed by Xabier Rodriguez-Calvar.
2389
2390         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
2391         when building the WPE port through build-webkit.
2392
2393 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2394
2395         [WPE] Enable MEDIA_SOURCE for build-webkit builds
2396         https://bugs.webkit.org/show_bug.cgi?id=173136
2397
2398         Reviewed by Xabier Rodriguez-Calvar.
2399
2400         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
2401
2402 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2403
2404         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
2405         https://bugs.webkit.org/show_bug.cgi?id=173098
2406
2407         Reviewed by Žan Doberšek.
2408
2409         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
2410         assuming that all tests containing forms define ids for the form elements like
2411         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
2412
2413         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2414         (formControlsAssociatedCallback):
2415
2416 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
2417
2418         webkitpy: Run sample/spindump on iOS devices
2419         https://bugs.webkit.org/show_bug.cgi?id=171881
2420         <rdar://problem/32084602>
2421
2422         Reviewed by Daniel Bates.
2423
2424         * Scripts/webkitpy/port/darwin.py:
2425         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
2426         requires sudo to run spindump.
2427         * Scripts/webkitpy/port/ios_device.py:
2428         (IOSDevicePort.look_for_new_samples): Deleted.
2429         (IOSDevicePort.sample_process): Deleted.
2430         * Scripts/webkitpy/port/ios_device_unittest.py:
2431         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
2432         (IOSDeviceTest.test_spindump):
2433         (IOSDeviceTest.test_sample_process):
2434         (IOSDeviceTest.test_sample_process_exception):
2435         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2436         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
2437
2438 2017-06-08  Keith Miller  <keith_miller@apple.com>
2439
2440         WebAssembly: We should only create wrappers for functions that can be exported
2441         https://bugs.webkit.org/show_bug.cgi?id=173088
2442
2443         Reviewed by Saam Barati.
2444
2445         Add quick mode for wasm tests.
2446
2447         * Scripts/run-jsc-stress-tests:
2448
2449 2017-06-08  Darin Adler  <darin@apple.com>
2450
2451         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
2452         https://bugs.webkit.org/show_bug.cgi?id=173106
2453
2454         Reviewed by Sam Weinig.
2455
2456         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
2457         destroyed last.
2458         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
2459         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
2460
2461 2017-06-07  Dan Bernstein  <mitz@apple.com>
2462
2463         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
2464         https://bugs.webkit.org/show_bug.cgi?id=173086
2465
2466         Reviewed by Andy Estes.
2467
2468         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2469         (TEST):
2470
2471 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
2472
2473         Add High Sierra support to WebKit tools
2474         https://bugs.webkit.org/show_bug.cgi?id=173080
2475
2476         Rubber-stamped by Daniel Bates.
2477
2478         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
2479         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
2480         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2481         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2482         Added dashboard support.
2483
2484         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2485         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2486         Trigger the right build queues on check-in.
2487
2488         * Scripts/webkitpy/common/system/platforminfo.py:
2489         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2490         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2491         * Scripts/webkitpy/port/mac.py:
2492         * Scripts/webkitpy/port/mac_unittest.py:
2493         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2494         Added cases for Sierra, and updated tests for new baseline search paths.
2495
2496 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
2497
2498         Unreviewed, rolling out r217902.
2499
2500         This change appears to have caused imported/w3c/web-platform-
2501         tests/fetch/api/cors tests to fail on El Capitan.
2502
2503         Reverted changeset:
2504
2505         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
2506         https://bugs.webkit.org/show_bug.cgi?id=172930
2507         http://trac.webkit.org/changeset/217902
2508
2509 2017-06-07  Daniel Bates  <dabates@apple.com>
2510
2511         Teach run-webkit-tests how to run HTTPS Web Platform Tests
2512         https://bugs.webkit.org/show_bug.cgi?id=172930
2513         <rdar://problem/32570201>
2514
2515         Reviewed by Youenn Fablet.
2516
2517         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
2518         that is conditioned on the page being delivered over a secure protocol. One example of such
2519         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
2520
2521         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
2522         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
2523         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
2524
2525         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2526         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
2527         to the Web Platform Tests HTTPS server.
2528         * Scripts/webkitpy/port/base.py:
2529         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
2530         * Scripts/webkitpy/port/driver.py:
2531         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
2532         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
2533         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
2534         indicate that they should be considered private instance variables.
2535         (Driver.is_web_platform_test): Update code for renamed instance variables.
2536         (Driver):
2537         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
2538         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
2539         determine the base URL to use to access the test.
2540         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
2541         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
2542
2543 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
2544
2545         Support removal of authentication data through the Website data store API.
2546         https://bugs.webkit.org/show_bug.cgi?id=171217
2547
2548         Reviewed by Brady Eidson.
2549
2550         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2551         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2552         (WTR::InjectedBundle::didReceiveMessageToPage):
2553         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2554         (WTR::TestRunner::removeAllSessionCredentials):
2555         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
2556         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2557         * WebKitTestRunner/TestController.h:
2558         * WebKitTestRunner/TestInvocation.cpp:
2559         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2560         (WTR::TestInvocation::didRemoveAllSessionCredentials):
2561         * WebKitTestRunner/TestInvocation.h:
2562         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2563         (WTR::TestController::removeAllSessionCredentials):
2564
2565 2017-06-07  Charlie Turner  <cturner@igalia.com>
2566
2567         Add Charlie Turner as contributor
2568         https://bugs.webkit.org/show_bug.cgi?id=173055
2569
2570         Reviewed by Carlos Alberto Lopez Perez.
2571
2572         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
2573         of webkit-patch upload, which reordered some fields and removed a newline.
2574
2575         * Scripts/webkitpy/common/config/contributors.json:
2576
2577 2017-06-06  Chris Dumez  <cdumez@apple.com>
2578
2579         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
2580         https://bugs.webkit.org/show_bug.cgi?id=173033
2581         <rdar://problem/32591099>
2582
2583         Reviewed by Simon Fraser.
2584
2585         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
2586         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
2587
2588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2589         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
2590         (TestWebKitAPI::didFinishLoadForFrame):
2591         (TestWebKitAPI::setPageLoaderClient):
2592         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
2593         (TestWebKitAPI::TEST):
2594
2595 2017-06-06  Andy Estes  <aestes@apple.com>
2596
2597         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
2598         https://bugs.webkit.org/show_bug.cgi?id=172849
2599         <rdar://problem/32567454>
2600
2601         Reviewed by Darin Adler.
2602
2603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2604         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
2605         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2606         (TestWebKitAPI::TEST):
2607
2608 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
2609
2610         [preload] Conditional support for media preloading and align media `as` values.
2611         https://bugs.webkit.org/show_bug.cgi?id=172501
2612
2613         Reviewed by Dean Jackson.
2614
2615         Turn on media preloading preference for tests.
2616
2617         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
2618         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
2619         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
2620
2621 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2622
2623         webkitpy: Return correct process names from SimulatorProcess
2624         https://bugs.webkit.org/show_bug.cgi?id=172940
2625
2626         Reviewed by Aakash Jain.
2627
2628         * Scripts/webkitpy/port/darwin.py:
2629         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
2630         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
2631         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
2632         * Scripts/webkitpy/port/driver.py:
2633         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
2634         _server_process.name() will not return the correct process name for iOS.
2635         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
2636         (Driver._read_block): Ditto.
2637         * Scripts/webkitpy/port/driver_unittest.py:
2638         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
2639         process_name() instead of name().
2640         * Scripts/webkitpy/port/server_process.py:
2641         (ServerProcess._start): Use process_name() instead of name().
2642         (ServerProcess.stop): Ditto.
2643         (ServerProcess.name): Deleted.
2644         * Scripts/webkitpy/port/simulator_process.py:
2645         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2646
2647 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
2648
2649         test-webkitpy: stop forking unsafely from within a spawned process
2650         https://bugs.webkit.org/show_bug.cgi?id=172774
2651
2652         Reviewed by Darin Adler.
2653
2654         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2655         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
2656         it's going to be used.
2657         (Builder.force_build):
2658
2659 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2660
2661         webkitpy: Process crash-logs for iOS devices
2662         https://bugs.webkit.org/show_bug.cgi?id=171976
2663         <rdar://problem/32134551>
2664
2665         Reviewed by David Kilzer.
2666
2667         When running layout tests on an iOS device, crash logs should be processed.
2668         Implement crash log searching and parsing for iOS devices.
2669
2670         * Scripts/webkitpy/common/system/crashlogs.py:
2671         (CrashLogs): Moved process regular expression for Darwin to class variable.
2672         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
2673         (CrashLogs.find_newest_log): Add iOS as a potential platform.
2674         (CrashLogs.find_all_logs): Ditto.
2675         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
2676         Do not assume that a Darwin crash log starts with the process.
2677         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
2678         shared code for parsing Darwin crash logs.
2679         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
2680         object so that crash logs already on the system before testing are not parsed.
2681         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
2682         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
2683         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
2684         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2685         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
2686         * Scripts/webkitpy/common/system/systemhost.py:
2687         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2688         systems is just the crashlog, use this behavior by default.
2689         * Scripts/webkitpy/common/system/systemhost_mock.py:
2690         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2691         systems is just the crashlog, use this behavior by default.
2692         * Scripts/webkitpy/port/apple.py:
2693         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
2694         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
2695         the system before testing begins
2696         * Scripts/webkitpy/port/base.py:
2697         (Port._get_crash_log): Pass optional target host when getting crash logs.
2698         * Scripts/webkitpy/port/darwin.py:
2699         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
2700         CrashLogs object.
2701         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2702         logs to be skipped to CrashLogs object.
2703         * Scripts/webkitpy/port/darwin_testcase.py:
2704         (DarwinTest.test_get_crash_log): Removed unused local function.
2705         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
2706         * Scripts/webkitpy/port/device.py:
2707         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
2708         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
2709         * Scripts/webkitpy/port/driver.py:
2710         (Driver._get_crash_log): Pass optional target host when getting crash logs.
2711         * Scripts/webkitpy/port/gtk.py:
2712         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
2713         * Scripts/webkitpy/port/ios.py: Ditto.
2714         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
2715         to be skipped for each host.
2716         * Scripts/webkitpy/port/ios_device.py:
2717         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
2718         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
2719         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
2720         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
2721         host is specified. Else, search all connected devices for the specified crash-log.
2722         (IOSDevicePort.look_for_new_crash_logs): Deleted.
2723         * Scripts/webkitpy/port/ios_device_unittest.py:
2724         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
2725         (IOSDeviceTest.test_get_crash_log): Ditto.
2726         * Scripts/webkitpy/port/simulator_process.py:
2727         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2728         * Scripts/webkitpy/port/win.py:
2729         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2730         logs to be skipped to CrashLogs object.
2731         * Scripts/webkitpy/port/wpe.py:
2732         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
2733
2734 2017-06-06  David Kilzer  <ddkilzer@apple.com>
2735
2736         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
2737         <https://webkit.org/b/172804>
2738
2739         Reviewed by Darin Adler.
2740
2741         WTF_ATTRIBUTE_PRINTF() only works outside the current
2742         compilation unit if it's on the declaration, not the
2743         implementation, of a function or class method.
2744
2745         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2746         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2747         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2748         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2749         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
2750         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2751         - Remove redundant CRASH() macro definition.  Use the one from
2752           <wtf/Assertions.h> instead.
2753
2754 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
2755
2756         Move Resource Timing / User Timing from experimental features into main preferences
2757         https://bugs.webkit.org/show_bug.cgi?id=172950
2758
2759         Reviewed by Darin Adler.
2760
2761         * DumpRenderTree/mac/DumpRenderTree.mm:
2762         (enableExperimentalFeatures):
2763         (resetWebPreferencesToConsistentValues):
2764         * DumpRenderTree/win/DumpRenderTree.cpp:
2765         (enableExperimentalFeatures):
2766         (resetWebPreferencesToConsistentValues):
2767         * WebKitTestRunner/TestController.cpp:
2768         (WTR::TestController::resetPreferencesToConsistentValues):
2769         Move out no longer experimental features to the main list.
2770
2771 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2772
2773         [WPE] Add an install-dependencies script
2774         https://bugs.webkit.org/show_bug.cgi?id=172948
2775
2776         Reviewed by Žan Doberšek.
2777
2778         It is based on the gtk/install-dependencies script.
2779         Includes support for Debian based distrubutions, Fedora and Arch.
2780         It has been tested on a minimal Debian 9 chroot.
2781
2782         * wpe/install-dependencies: Added.
2783
2784 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2785
2786         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
2787         https://bugs.webkit.org/show_bug.cgi?id=172891
2788         <rdar://problem/32204540>
2789
2790         Reviewed by Darin Adler.
2791
2792         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
2793         contenteditable. See WebCore ChangeLog for more details.
2794
2795         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2796         (TestWebKitAPI::TEST):
2797
2798 2017-06-05  Daniel Bates  <dabates@apple.com>
2799
2800         webkitpy: Abstract Executive class
2801         https://bugs.webkit.org/show_bug.cgi?id=172928
2802         <rdar://problem/32569531>
2803
2804         Reviewed by Ryosuke Niwa.
2805
2806         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
2807         This will make it straightforward to create additional derived classes that
2808         adhere to the same interface, say for iOS on-device testing.
2809
2810         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
2811         (AbstractExecutive):
2812         (AbstractExecutive.run_and_throw_if_fail):
2813         (AbstractExecutive.cpu_count):
2814         (AbstractExecutive.interpreter_for_script):
2815         (AbstractExecutive.shell_command_for_script):
2816         (AbstractExecutive.kill_process):
2817         (AbstractExecutive.check_running_pid):
2818         (AbstractExecutive.running_pids):
2819         (AbstractExecutive.wait_newest):
2820         (AbstractExecutive.wait_limited):
2821         (AbstractExecutive.interrupt):
2822         (AbstractExecutive.default_error_handler):
2823         (AbstractExecutive.ignore_error):
2824         (AbstractExecutive._stringify_args):
2825         (AbstractExecutive.command_for_printing):
2826         (AbstractExecutive.run_command):
2827         (AbstractExecutive.popen):
2828         (AbstractExecutive.run_in_parallel):
2829         * Scripts/webkitpy/common/system/executive.py:
2830         (Executive):
2831         (Executive.cpu_count):
2832         (Executive.running_pids):
2833         (Executive.kill_all):
2834         (Executive._compute_stdin):
2835         (Executive.interpreter_for_script): Deleted.
2836         (Executive.shell_command_for_script): Deleted.
2837         (Executive.wait_newest): Deleted.
2838         (Executive.wait_limited): Deleted.
2839         (Executive.default_error_handler): Deleted.
2840         (Executive.ignore_error): Deleted.
2841         (Executive.command_for_printing): Deleted.
2842
2843 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
2844
2845         webkitpy: Add iOS to platform
2846         https://bugs.webkit.org/show_bug.cgi?id=172931
2847
2848         Reviewed by Daniel Bates.
2849
2850         * Scripts/webkitpy/common/system/platforminfo.py:
2851         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
2852         (PlatformInfo.is_ios): Added.
2853         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
2854         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2855         (MockPlatformInfo.is_ios): Added.
2856
2857 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2858
2859         [WPE][JHBuild] Switch github repository from git:// to https://
2860         https://bugs.webkit.org/show_bug.cgi?id=172921
2861
2862         Reviewed by Alex Christensen.
2863
2864         * wpe/jhbuild.modules:
2865
2866 2017-06-05  Tim Horton  <timothy_horton@apple.com>
2867
2868         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
2869         https://bugs.webkit.org/show_bug.cgi?id=172887
2870         <rdar://problem/32546061>
2871
2872         Reviewed by Sam Weinig.
2873
2874         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2875         (WTR::UIScriptController::applyAutocorrection):
2876         applyAutocorrection can call its completion handler synchronously,
2877         which makes UIScriptController unhappy (see bug 172884).
2878
2879 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
2880
2881         webkitpy: Add contextmanager to disable logging for a block
2882         https://bugs.webkit.org/show_bug.cgi?id=172876
2883
2884         Reviewed by Daniel Bates.
2885
2886         Add a context manager which will use an OutputCapture object to capture logging
2887         in a block and hold it in a variable.
2888
2889         * Scripts/webkitpy/common/system/outputcapture.py:
2890         (OutputCaptureScope):
2891         (OutputCaptureScope.__init__): Construct with OutputCapture object.
2892         (OutputCaptureScope.__enter__): Begin capturing output. 
2893         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
2894         output and retain the resulting log.
2895         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
2896         (OutputCaptureTest.test_output_capture_scope): Added.
2897
2898 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2899
2900         Cleanup FrameView::autoSizeIfEnabled.
2901         https://bugs.webkit.org/show_bug.cgi?id=172889
2902         <rdar://problem/32550783>
2903
2904         Reviewed by Tim Horton.
2905
2906         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2907         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
2908         (TEST):
2909
2910 2017-06-02  Chris Dumez  <cdumez@apple.com>
2911
2912         ResourceLoadStatistics are not using unique paths during test runs
2913         https://bugs.webkit.org/show_bug.cgi?id=172861
2914         <rdar://problem/32442251>
2915
2916         Reviewed by Darin Adler.
2917
2918         Make sure WebKitTestRunner sets a temporary path for saving resource
2919         load statistics.
2920
2921         * WebKitTestRunner/TestController.cpp:
2922         (WTR::TestController::generateContextConfiguration):
2923
2924 2017-06-02  Brady Eidson  <beidson@apple.com>
2925
2926         Prevent scheme handlers from handling all built-in URL schemes.
2927         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
2928
2929         Reviewed by Andy Estes.
2930
2931         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2932
2933 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
2934
2935         [JSCOnly] Build static jsc.exe on Windows
2936         https://bugs.webkit.org/show_bug.cgi?id=172833
2937
2938         Reviewed by Konstantin Tokarev.
2939
2940         * CMakeLists.txt:
2941         * Scripts/build-jsc:
2942
2943 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2944
2945         Disable ViewportSizeForViewportUnits tests on iOS.
2946         https://bugs.webkit.org/show_bug.cgi?id=172872
2947
2948         Reviewed by Tim Horton.
2949
2950         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
2951
2952 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2953
2954         Allow clients to override viewport size for CSS viewport units.
2955         https://bugs.webkit.org/show_bug.cgi?id=172838
2956         <rdar://problem/32523441>
2957
2958         Reviewed by Tim Horton.
2959
2960         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2961         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
2962         (TEST):
2963
2964 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
2965
2966         Get <chrono> out of StdLibExtras.h
2967         https://bugs.webkit.org/show_bug.cgi?id=172744
2968
2969         Reviewed by Zalan Bujtas.
2970
2971         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2972
2973 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
2974
2975         [WPE] Enable SUBTLE_CRYPTO
2976         https://bugs.webkit.org/show_bug.cgi?id=172756
2977
2978         Reviewed by Michael Catanzaro.
2979
2980         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
2981         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
2982         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
2983         exhausting entropy when running the crypto layout tests.
2984
2985 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2986
2987         [GTK] Bump GTK+ and its dependencies in jhbuild
2988         https://bugs.webkit.org/show_bug.cgi?id=171918
2989
2990         Reviewed by Carlos Alberto Lopez Perez.
2991
2992         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2993         (WTR::initializeGtkSettings):
2994         * gtk/jhbuild.modules:
2995         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
2996         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
2997
2998 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2999
3000         [GTK] Bump wayland and weston in jhbuild
3001         https://bugs.webkit.org/show_bug.cgi?id=171921
3002
3003         Reviewed by Carlos Alberto Lopez Perez.
3004
3005         * gtk/jhbuild.modules:
3006         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
3007
3008 2017-06-01  Andy Estes  <aestes@apple.com>
3009
3010         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
3011         https://bugs.webkit.org/show_bug.cgi?id=172828
3012
3013         Reviewed by Beth Dakin.
3014
3015         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3016
3017 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
3018
3019         webkitpy: Remove unneeded simulator teardown
3020         https://bugs.webkit.org/show_bug.cgi?id=171891
3021
3022         Reviewed by Aakash Jain.
3023
3024         * Scripts/webkitpy/port/ios_simulator.py:
3025         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
3026         for communication between Python and WebKitTestRunner/DumpRenderTree.
3027
3028 2017-06-01  Keith Miller  <keith_miller@apple.com>
3029
3030         Undo rollout in r217638 with bug fix
3031         https://bugs.webkit.org/show_bug.cgi?id=172824
3032
3033         Unreviewed, reland patch with unused set_state code removed.
3034
3035         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3036         (runThreadMessageTest):
3037         (TEST):
3038
3039 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
3040
3041         webkitpy: Do not send 0 or -1 as a pid to kill_process
3042         https://bugs.webkit.org/show_bug.cgi?id=172818
3043
3044         Reviewed by Darin Adler.
3045
3046         Sending a signal to process 0 will result in all processes in the group receiving 
3047         the signal. Sending a signal to process -1 will result in all non-system processes
3048         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
3049         should consider these cases
3050
3051         * Scripts/webkitpy/common/system/executive.py:
3052         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
3053         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
3054         never be running, although os.kill may succeed.
3055         * Scripts/webkitpy/port/simulator_process.py:
3056         (SimulatorProcess.stop): Do not kill process if it is undefined.
3057
3058 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
3059
3060         JSC EWS bot does not run on WTF only patches
3061         https://bugs.webkit.org/show_bug.cgi?id=172777
3062         rdar://problem/32495975
3063
3064         Reviewed by Aakash Jain.
3065
3066         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
3067         (CheckPatchRelevance): Add a missing comma.
3068
3069 2017-05-31  Commit Queue  <commit-queue@webkit.org>
3070
3071         Unreviewed, rolling out r217611 and r217631.
3072         https://bugs.webkit.org/show_bug.cgi?id=172785
3073
3074         "caused wasm-hashset-many.html to become flaky." (Requested by
3075         keith_miller on #webkit).
3076
3077         Reverted changesets:
3078
3079         "Reland r216808, underlying lldb bug has been fixed."
3080         https://bugs.webkit.org/show_bug.cgi?id=172759
3081         http://trac.webkit.org/changeset/217611
3082
3083         "Use dispatch queues for mach exceptions"
3084         https://bugs.webkit.org/show_bug.cgi?id=172775
3085         http://trac.webkit.org/changeset/217631
3086
3087 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
3088
3089         EWS bots should reboot themselves more frequently
3090         https://bugs.webkit.org/show_bug.cgi?id=172402
3091
3092         Reviewed by Alexey Proskuryakov.
3093
3094         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
3095
3096         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
3097
3098 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
3099
3100         Reallocate hardware for iOS bots.
3101         https://bugs.webkit.org/show_bug.cgi?id=172657
3102
3103         Reviewed by Alexey Proskuryakov.
3104
3105         * BuildSlaveSupport/build.webkit.org-config/config.json:
3106
3107 2017-05-31  Andy Estes  <aestes@apple.com>
3108
3109         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
3110         https://bugs.webkit.org/show_bug.cgi?id=172366
3111
3112         Reviewed by Daniel Bates.
3113
3114         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3115
3116 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
3117
3118         Unreviewed, add Jiewen Tan as a reviewer
3119
3120         * Scripts/webkitpy/common/config/contributors.json:
3121
3122 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
3123
3124         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
3125         https://bugs.webkit.org/show_bug.cgi?id=172770
3126
3127         Reviewed by Michael Catanzaro.
3128
3129         * MiniBrowser/gtk/BrowserWindow.c:
3130         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
3131         which caused the body of the if-clause to be accidentally empty.
3132
3133 2017-05-31  Keith Miller  <keith_miller@apple.com>
3134
3135         Reland r216808, underlying lldb bug has been fixed.
3136         https://bugs.webkit.org/show_bug.cgi?id=172759
3137
3138         Unreviewed, relanding old patch. See: rdar://problem/31183352
3139
3140         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3141         (runThreadMessageTest):
3142         (TEST):
3143
3144 2017-05-31  Matt Lewis  <jlewis3@apple.com>
3145
3146         Unreviewed, rolling out r217603.
3147
3148         This patch broke the internal builds.
3149
3150         Reverted changeset:
3151
3152         "Get <chrono> out of StdLibExtras.h"
3153         https://bugs.webkit.org/show_bug.cgi?id=172744
3154         http://trac.webkit.org/changeset/217603
3155
3156 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
3157
3158         Make ResourceLoadStatistics testing more reliable
3159         https://bugs.webkit.org/show_bug.cgi?id=172730
3160         <rdar://problem/32028373>
3161
3162         Reviewed by Andy Estes.
3163
3164         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
3165         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
3166
3167         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3168         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3169
3170 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3171
3172         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
3173         https://bugs.webkit.org/show_bug.cgi?id=172757
3174
3175         Reviewed by Xabier Rodriguez-Calvar.
3176
3177         When needed, add the jhbuild wrapper at the beginning of the array
3178         that will be invoked to execute the run-jsc-stress-test or testapi
3179         commands.
3180
3181         * Scripts/run-javascriptcore-tests:
3182         (runJSCStressTests):
3183         * Scripts/webkitdirs.pm:
3184         (shouldUseJhbuild):
3185
3186 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
3187
3188         Get <chrono> out of StdLibExtras.h
3189         https://bugs.webkit.org/show_bug.cgi?id=172744
3190
3191         Reviewed by Saam Barati.
3192
3193         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3194
3195 2017-05-30  Tim Horton  <timothy_horton@apple.com>
3196
3197         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
3198         https://bugs.webkit.org/show_bug.cgi?id=172735
3199         <rdar://problem/32015977>
3200
3201         Reviewed by Enrica Casucci.
3202
3203         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3204         (WTR::UIScriptController::applyAutocorrection):
3205         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3206         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3207         (WTR::UIScriptController::applyAutocorrection):
3208         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3209         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3210         (WTR::UIScriptController::applyAutocorrection):
3211         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
3212         because I don't know how to tap the button in the autocorrection bar from a test.
3213
3214 2017-05-30  Daniel Bates  <dabates@apple.com>
3215
3216         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
3217         https://bugs.webkit.org/show_bug.cgi?id=172671
3218
3219         Reviewed by Alex Christensen.
3220
3221         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
3222         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
3223
3224         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
3225         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
3226         to trigger a navigation to test it.
3227         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
3228         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
3229
3230 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
3231
3232         webkitpy: Start servers before setting-up for testing
3233         https://bugs.webkit.org/show_bug.cgi?id=172176
3234         <rdar://problem/32225538>
3235
3236         Reviewed by Alexey Proskuryakov.
3237
3238         On-device testing requires that servers are started before ports set-up their
3239         test environments.
3240
3241         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3242         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
3243         Servers are unconditionally stopped on exit.
3244         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
3245         Manager now stops servers.
3246         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
3247         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
3248         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3249         (Manager.__init__): Delay construction of the test runner until we can determine
3250         if servers need to be started.
3251         (Manager.run): Determine if servers need to be started and construct the test runner.
3252         Shut servers down when the test run is finished.
3253         (Manager._run_tests): Move the determination of servers to run into Manager.run.
3254         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3255         (is_wpt_server_running): Server is not running if no config is found.
3256         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
3257         (PyWebSocket.is_running): Check if this WebSocket server is running.
3258         * Scripts/webkitpy/port/base.py:
3259         (Port.__init__): Define secure WebSocket server.
3260         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
3261
3262 2017-05-30  Daniel Bates  <dabates@apple.com>
3263
3264         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
3265         https://bugs.webkit.org/show_bug.cgi?id=172603
3266         <rdar://problem/32471306>
3267
3268         Reviewed by Brady Eidson.
3269
3270         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
3271         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
3272         unloading is initiated for a page that registered a onbeforeunload handler.
3273
3274         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
3275         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
3276         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
3277
3278         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
3279         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
3280         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
3281         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
3282
3283         * MiniBrowser/mac/WK2BrowserWindowController.m:
3284         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3285         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
3286         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
3287         (sawDialog):
3288         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3289         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3290         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3291
3292 2017-05-30  Alex Christensen  <achristensen@webkit.org>
3293
3294         Update libwebrtc configuration
3295         https://bugs.webkit.org/show_bug.cgi?id=172727
3296
3297         Reviewed by Geoffrey Garen.
3298
3299         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3300
3301 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
3302
3303         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
3304         https://bugs.webkit.org/show_bug.cgi?id=172702
3305
3306         Reviewed by Alex Christensen.
3307
3308         EGL PlatformDisplay needs to be shut down before existing a
3309         program on Windows.
3310
3311         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
3312         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
3313         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3314         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
3315
3316 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
3317
3318         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
3319         https://bugs.webkit.org/show_bug.cgi?id=172709
3320
3321         Reviewed by Brent Fulgham.
3322
3323         Exit fullscreen mode after a fullscreen test.
3324
3325         * DumpRenderTree/win/DumpRenderTree.cpp:
3326         (resetWebViewToConsistentStateBeforeTesting):
3327
3328 2017-05-30  Antti Koivisto  <antti@apple.com>
3329
3330         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
3331         https://bugs.webkit.org/show_bug.cgi?id=172713
3332
3333         Reviewed by Zalan Bujtas.
3334
3335         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3336         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
3337
3338             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
3339             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
3340             because on Mac WK1 it may get invoked from middle of a layout.
3341
3342             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
3343
3344 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3345
3346         Add a WPE EWS queue
3347         https://bugs.webkit.org/show_bug.cgi?id=172693
3348
3349         Reviewed by Carlos Garcia Campos.
3350
3351         * QueueStatusServer/config/queues.py:
3352         * QueueStatusServer/model/queues.py: Capitalize the name of the
3353         port on the tooltip of the bubbles. Do the same for the GTK port.
3354         (Queue.display_name):
3355         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
3356         for the GTK+ EWS also. Set for both ports as watcher the alias
3357         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
3358         * Scripts/webkitpy/common/config/ports.py:
3359         (DeprecatedPort.port):
3360         (WpePort):
3361         (WpePort.build_webkit_command):
3362         (WpePort.run_webkit_tests_command):
3363         * Scripts/webkitpy/common/config/ports_unittest.py:
3364         (DeprecatedPortTest):
3365         (DeprecatedPortTest.test_wpe_port):
3366         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3367         (test_ews_name):
3368
3369 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
3370
3371         Unreviewed. Bumping the WPEBackend-mesa dependency version.
3372
3373         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
3374         priorities for IPC communication.
3375
3376 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
3377
3378         [JSC] Map and Set constructors should have fast path for cloning
3379         https://bugs.webkit.org/show_bug.cgi?id=172413
3380
3381         Reviewed by Saam Barati.
3382
3383         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3384         (TestWebKitAPI::TEST):
3385
3386 2017-05-27  Zalan Bujtas  <zalan@apple.com>
3387
3388         enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
3389         https://bugs.webkit.org/show_bug.cgi?id=172676
3390
3391         Reviewed by Simon Fraser.
3392
3393         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
3394         (TestWebKitAPI::TEST):
3395
3396 2017-05-26  Zalan Bujtas  <zalan@apple.com>
3397
3398         TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
3399         https://bugs.webkit.org/show_bug.cgi?id=172674
3400
3401         Reviewed by Simon Fraser.
3402
3403         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
3404         (TestWebKitAPI::TEST):
3405
3406 2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3407
3408         Add test resources back into TestWebKitAPI Copy Resources phase
3409
3410         Rubber-stamped by Beth Dakin.
3411
3412         Add two files back into the Copy Resources phase after they were unintentionally
3413         removed in r217447 and r217496.
3414
3415         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3416
3417 2017-05-26  Beth Dakin  <bdakin@apple.com>
3418
3419         Media documents inside iframes should not get controls in the TouchBar unless the 
3420         video is playing
3421         https://bugs.webkit.org/show_bug.cgi?id=172620
3422         -and corresponding-
3423         rdar://problem/32165477
3424
3425         Reviewed by Jon Lee.
3426
3427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3428         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3429         (TestWebKitAPI::TEST):
3430         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
3431
3432 2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>
3433
3434         _WKUserStyleSheet and WKUserScript leak string data
3435         https://bugs.webkit.org/show_bug.cgi?id=172583
3436         <rdar://problem/32395209>
3437
3438         Reviewed by Sam Weinig.
3439
3440         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3441         We should not have been adopting an autoreleased object.
3442
3443 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
3444
3445         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
3446         https://bugs.webkit.org/show_bug.cgi?id=172554
3447         <rdar://problem/31247133>
3448
3449         Reviewed by Simon Fraser.
3450
3451         Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
3452         simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
3453         leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
3454         we should just tear down and rebuild the window whenever we need a layer-backed WebView.
3455         We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
3456         codepath.
3457
3458         * DumpRenderTree/TestOptions.h:
3459         * DumpRenderTree/TestOptions.mm:
3460         (TestOptions::TestOptions):
3461         (TestOptions::webViewIsCompatibleWithOptions):
3462         * DumpRenderTree/mac/DumpRenderTree.mm:
3463         (shouldIgnoreWebCoreNodeLeaks):
3464         (allowedFontFamilySet):
3465         (-[DRTMockScroller rectForPart:]):
3466         (-[DRTMockScroller drawKnob]):
3467         (-[DRTMockScroller drawRect:]):
3468         (createWebViewAndOffscreenWindow):
3469         (initializeGlobalsFromCommandLineOptions):
3470         (prepareConsistentTestingEnvironment):
3471         (dumpRenderTree):
3472         (dumpAudio):
3473         (dumpHistoryItem):
3474         (dumpBackForwardListForWebView):
3475         (resetWebViewToConsistentStateBeforeTesting):
3476         (WebThreadLockAfterDelegateCallbacksHaveCompleted):
3477         (runTest):
3478
3479 2017-05-25  Sam Weinig  <sam@webkit.org>
3480
3481         [WebIDL] Use the term 'operation' more consistently
3482         https://bugs.webkit.org/show_bug.cgi?id=172601
3483
3484         Reviewed by Chris Dumez.
3485
3486         We were using the term 'operation', a WebIDL term for function-like
3487         constructs, inconsistently in the code generator. Now, when we use
3488         'operation' when referring to the IDL concept (usually the object the
3489         parser produces) and 'function' when referring to code being generated.
3490
3491         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3492         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3493
3494 2017-05-25  Jer Noble  <jer.noble@apple.com>
3495
3496         Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.
3497
3498         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
3499
3500 2017-05-25  Jer Noble  <jer.noble@apple.com>
3501
3502         System sleeps while playing to wireless target, ending stream.
3503         https://bugs.webkit.org/show_bug.cgi?id=172541
3504
3505         Reviewed by Eric Carlson.
3506
3507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3508         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
3509         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
3510         (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
3511         (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3512         (TestWebKitAPI::simulateKeyDown):
3513         (TestWebKitAPI::hasAssertionType):
3514         (TestWebKitAPI::TEST):
3515
3516 2017-05-25  Commit Queue  <commit-queue@webkit.org>
3517
3518         Unreviewed, rolling out r217423 and r217424.
3519         https://bugs.webkit.org/show_bug.cgi?id=172607
3520
3521         These caused an api failure on all testers. (Requested by
3522         mlewis13 on #webkit).
3523
3524         Reverted changesets:
3525
3526         "REGRESSION (r216977): 4 leaks introduced in new
3527         WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
3528         https://bugs.webkit.org/show_bug.cgi?id=172558
3529         http://trac.webkit.org/changeset/217423
3530
3531         "REGRESSION (r217423): Fix last-second typo in 'auto'"
3532         http://trac.webkit.org/changeset/217424
3533
3534 2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>
3535
3536         [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
3537         https://bugs.webkit.org/show_bug.cgi?id=172355
3538
3539         Reviewed by Chris Fleizach.
3540
3541         Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
3542         versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
3543         releases which support the new platform footnote accessibility role.
3544
3545         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3546         * gtk/jhbuild.modules:
3547
3548 2017-05-25  David Kilzer  <ddkilzer@apple.com>
3549
3550         REGRESSION (r217423): Fix last-second typo in 'auto'
3551
3552         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3553         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.
3554
3555 2017-05-24  David Kilzer  <ddkilzer@apple.com>
3556
3557         REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
3558         <https://webkit.org/b/172558>
3559
3560         Reviewed by Sam Weinig.
3561
3562         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3563         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.
3564
3565 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
3566
3567         [CMake] Consolidate CMake code related to Cairo
3568         https://bugs.webkit.org/show_bug.cgi?id=172568
3569
3570         Reviewed by Alex Christensen.
3571
3572         * DumpRenderTree/config.h:
3573         * TestWebKitAPI/config.h:
3574
3575 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3576
3577         Plumb additional image metadata to item providers when beginning data interaction on an image
3578         https://bugs.webkit.org/show_bug.cgi?id=172536
3579         <rdar://problem/32371300>
3580
3581         Reviewed by Beth Dakin.
3582
3583         Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
3584         source item providers.
3585
3586         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3587         (checkSuggestedNameAndEstimatedSize):
3588         (TestWebKitAPI::TEST):
3589
3590 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
3591
3592         [Win] Create unique network storage session for each DRT.
3593         https://bugs.webkit.org/show_bug.cgi?id=172540
3594
3595         Reviewed by Brent Fulgham.
3596
3597         During layout testing, each DRT instance should have its own network storage session.
3598
3599         * DumpRenderTree/win/DumpRenderTree.cpp:
3600         (prepareConsistentTestingEnvironment):
3601
3602 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3603
3604         Respect image UTIs when writing to item providers when beginning data interaction on an image
3605         https://bugs.webkit.org/show_bug.cgi?id=172436
3606         <rdar://problem/31786569>
3607
3608         Reviewed by Beth Dakin.
3609
3610         Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
3611         details.
3612
3613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3614         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
3615         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.
3616
3617         Create a new test page containing a GIF and a file input.
3618
3619         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3620         (checkTypeIdentifierIsRegisteredAtIndex):
3621         (TestWebKitAPI::TEST):