2fc97351d2189a62265a9b46b130ca7f14ef8934
[WebKit-https.git] / Tools / ChangeLog
1 2015-08-27  Nan Wang  <n_wang@apple.com>
2
3         AX: Fix accessibility/select-element-at-index.html test
4         https://bugs.webkit.org/show_bug.cgi?id=148516
5
6         Reviewed by Chris Fleizach.
7
8         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
9
10         * DumpRenderTree/AccessibilityUIElement.cpp:
11         (setSelectedChildCallback):
12         (setSelectedChildAtIndexCallback):
13         (removeSelectionAtIndexCallback):
14         (elementAtPointCallback):
15         (sentenceAtOffsetCallback):
16         (stringForSelectionCallback):
17         (AccessibilityUIElement::getJSClass):
18         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
19         (AccessibilityUIElement::setSelectedChild):
20         (AccessibilityUIElement::setSelectedChildAtIndex):
21         (AccessibilityUIElement::removeSelectionAtIndex):
22         (AccessibilityUIElement::accessibilityValue):
23         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
24         (WTR::AccessibilityUIElement::wordAtOffset):
25         (WTR::AccessibilityUIElement::lineAtOffset):
26         (WTR::AccessibilityUIElement::sentenceAtOffset):
27         (WTR::AccessibilityUIElement::isSelectable):
28         (WTR::AccessibilityUIElement::isMultiSelectable):
29         (WTR::AccessibilityUIElement::setSelectedChild):
30         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
31         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
32         (WTR::AccessibilityUIElement::selectedChildrenCount):
33         (WTR::AccessibilityUIElement::selectedChildAtIndex):
34         (WTR::AccessibilityUIElement::isExpanded):
35         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
36         (WTR::AccessibilityUIElement::setSelectedChild):
37         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
38         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
39         (WTR::AccessibilityUIElement::accessibilityValue):
40
41 2015-08-27  Alex Christensen  <achristensen@webkit.org>
42
43         Build fix after r188982
44
45         * MiniBrowser/win/CMakeLists.txt:
46         The directory structure changed in the move.
47
48 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
49
50         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
51
52         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
53
54         * gtk/install-dependencies:
55
56 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
57
58         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
59
60         * Scripts/run-gtk-tests:
61         (TestRunner):
62
63 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
64
65         Fix GTK+ WTR crashes in initializeMainRunLoop()
66
67         Rubber-stamped by Žan Doberšek.
68
69         Initialize threading and main thread before
70         RunLoop::initializeMainRunLoop(), since the GLib implementation of
71         the RunLoop uses isMainThread() to decide whether to create a new
72         GMainContext or use the default one. Also use RunLoop::run() and
73         ::stop() instead of gtk_main/quit.
74
75         * WebKitTestRunner/TestController.cpp:
76         (WTR::TestController::initialize):
77         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
78         (WTR::TestController::notifyDone):
79         (WTR::TestController::platformRunUntil):
80
81 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
82
83         Unreviewed, further shorten a test that times out because it's very long
84         running.
85
86         I've locally run these tests on repeat for 24 hours and found no genuine
87         failures, like deadlocks. So, the timeouts are probably because the test
88         machine is slow and debug is slow. We should just run this test for fewer
89         iterations.
90
91         * TestWebKitAPI/Tests/WTF/Lock.cpp:
92         (TestWebKitAPI::TEST):
93
94 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
95
96         Unreviewed build fix attempt on EFL
97
98         * WebKitTestRunner/PlatformEfl.cmake:
99
100 2015-08-26  Alex Christensen  <achristensen@webkit.org>
101
102         Build fix after r188982
103
104         * MiniBrowser/win/CMakeLists.txt:
105         Find .rc files in correct directory.
106
107 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
108
109         [EFL] Bump cairo version to 1.14.2
110         https://bugs.webkit.org/show_bug.cgi?id=148474
111
112         Reviewed by Csaba Osztrogonác.
113
114         * efl/jhbuild.modules:
115
116 2015-08-26  Andy Estes  <aestes@apple.com>
117
118         Crash when following a Google search link to Twitter with Limit Adult Content enabled
119         https://bugs.webkit.org/show_bug.cgi?id=147651
120
121         Rubber-stamped by Brady Eidson.
122
123         Taught TestRunner how to decide the navigation policy after a delay.
124
125         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
126         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
127         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
128         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
129         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
130         * WebKitTestRunner/InjectedBundle/TestRunner.h:
131         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
132         * WebKitTestRunner/TestController.cpp:
133         (WTR::TestController::initialize):
134         (WTR::TestController::resetStateToConsistentValues):
135         (WTR::TestController::decidePolicyForNavigationAction):
136         * WebKitTestRunner/TestController.h:
137         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
138         * WebKitTestRunner/TestInvocation.cpp:
139         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
140
141 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
142
143         [Win] Rename 'WinLauncher' to 'MiniBrowser'
144         https://bugs.webkit.org/show_bug.cgi?id=148485
145
146         Reviewed by Alex Christensen
147
148         Move the WinLauncher project and source files to a subdirectory
149         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
150         source code and project files.
151         
152         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
153         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
154         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
155         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
156         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
157         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
158         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
159         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
160         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
161         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
162         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
163         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
164         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
165         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
166         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
167         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
168         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
169         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
170         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
171         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
172         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
173         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
174         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
175         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
176         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
177         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
178         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
179         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
180         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
181         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
182         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
183         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
184         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
185         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
186         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
187         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
188         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
189         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
190         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
191         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
192         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
193         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
194         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
195         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
196         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
197         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
198         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
199         * MiniBrowser/win: Copied from WinLauncher.
200         * MiniBrowser/win/Common.cpp:
201         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
202         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
203         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
204         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
205         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
206         * MiniBrowser/win/PageLoadTestClient.cpp:
207         * MiniBrowser/win/PageLoadTestClient.h:
208         * MiniBrowser/win/ResourceLoadDelegate.cpp:
209         * MiniBrowser/win/ResourceLoadDelegate.h:
210         * MiniBrowser/win/WinLauncher.cpp: Removed.
211         * MiniBrowser/win/WinLauncher.h: Removed.
212         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
213         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
214         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
215         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
216         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
217         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
218         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
219         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
220         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
221         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
222         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
223         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
224         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
225         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
226         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
227         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
228         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
229         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
230         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
231         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
232         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
233         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
234         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
235         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
236         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
237         * MiniBrowser/win/WinLauncherReplace.h: Removed.
238         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
239         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
240         * MiniBrowser/win/WinMain.cpp:
241         * WinLauncher: Removed.
242         * WinLauncher/AccessibilityDelegate.cpp: Removed.
243         * WinLauncher/AccessibilityDelegate.h: Removed.
244         * WinLauncher/CMakeLists.txt: Removed.
245         * WinLauncher/Common.cpp: Removed.
246         * WinLauncher/DOMDefaultImpl.cpp: Removed.
247         * WinLauncher/DOMDefaultImpl.h: Removed.
248         * WinLauncher/PageLoadTestClient.cpp: Removed.
249         * WinLauncher/PageLoadTestClient.h: Removed.
250         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
251         * WinLauncher/PrintWebUIDelegate.h: Removed.
252         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
253         * WinLauncher/ResourceLoadDelegate.h: Removed.
254         * WinLauncher/WebDownloadDelegate.cpp: Removed.
255         * WinLauncher/WebDownloadDelegate.h: Removed.
256         * WinLauncher/WinLauncher.cpp: Removed.
257         * WinLauncher/WinLauncher.h: Removed.
258         * WinLauncher/WinLauncher.vcxproj: Removed.
259         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
260         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
261         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
262         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
263         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
264         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
265         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
266         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
267         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
268         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
269         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
270         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
271         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
272         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
273         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
274         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
275         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
276         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
277         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
278         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
279         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
280         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
281         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
282         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
283         * WinLauncher/WinLauncherReplace.h: Removed.
284         * WinLauncher/WinLauncherWebHost.cpp: Removed.
285         * WinLauncher/WinLauncherWebHost.h: Removed.
286         * WinLauncher/WinMain.cpp: Removed.
287         * WinLauncher/resource.h: Removed.
288         * WinLauncher/stdafx.cpp: Removed.
289         * WinLauncher/stdafx.h: Removed.
290         * win/AssembleBuildLogs/AssembleLogs.cmd:
291
292 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
293
294         [Win] Simplify menu handling code in WinLauncher
295         https://bugs.webkit.org/show_bug.cgi?id=148461
296
297         Reviewed by Zalan Bujtas.
298
299         Revise 'ToggleMenuItem' to return a boolean value indicating if
300         it handled the message. Revise WndProc to use this to decide if it
301         should pass the message on to the default handler, rather than
302         duplicating the logic in both places.
303         
304         * WinLauncher/Common.cpp:
305         (ToggleMenuItem): Return true if the menu item message was handled.
306         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
307         the message tothe default handler.
308
309 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
310
311         Remove unused code after r188948
312         https://bugs.webkit.org/show_bug.cgi?id=148467
313
314         Reviewed by Gyuyoung Kim.
315
316         * WebKitTestRunner/TestController.cpp:
317         (WTR::TestController::platformPreferences): Deleted.
318
319 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
320
321         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
322         https://bugs.webkit.org/show_bug.cgi?id=148377
323
324         Reviewed by Carlos Garcia Campos.
325
326         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
327         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
328         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
329         EFL and GTK at the moment.
330
331         * WebKitTestRunner/TestController.cpp:
332         (WTR::TestController::platformWillRunTest):
333         * WebKitTestRunner/efl/TestControllerEfl.cpp:
334         (WTR::TestController::platformPreferences):
335         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
336         (WTR::TestController::platformPreferences):
337
338 2015-08-25  Nan Wang  <n_wang@apple.com>
339
340         AX: Enable accessibility/aria-controls.html test for mac
341         https://bugs.webkit.org/show_bug.cgi?id=148458
342
343         Reviewed by Chris Fleizach.
344
345         Implemented ariaControlsElementAtIndex(unsigned index).
346
347         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
348         (AccessibilityUIElement::ariaControlsElementAtIndex):
349         (AccessibilityUIElement::disclosedRowAtIndex):
350         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
351         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
352
353 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
354
355         Remove python tests for PassRefPtr 
356         https://bugs.webkit.org/show_bug.cgi?id=148463
357
358         Reviewed by Andy Estes.
359
360         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
361
362         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
363         (PassPtrTest): Deleted.
364         (PassPtrTest.assert_pass_ptr_check): Deleted.
365         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
366         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
367         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
368         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
369         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
370         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
371
372 2015-08-25  Andy Estes  <aestes@apple.com>
373
374         [iOS] run-webkit-tests fails if watchOS SDK is installed
375         https://bugs.webkit.org/show_bug.cgi?id=148453
376
377         Reviewed by David Kilzer.
378
379         * Scripts/webkitpy/xcode/simulator.py:
380         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
381         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
382
383 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
384
385         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
386         https://bugs.webkit.org/show_bug.cgi?id=148197
387         rdar://problem/22334382
388
389         Reviewed by Daniel Bates.
390
391         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
392         * Scripts/webkitpy/port/ios.py:
393         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
394         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
395         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
396         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
397         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
398
399 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
400
401         Remove PassRefPtr style check rule
402         https://bugs.webkit.org/show_bug.cgi?id=148432
403
404         Reviewed by Andreas Kling.
405
406         PassRefPtr is being removed. Thus style rule needs to be removed as well.
407
408         * Scripts/webkitpy/style/checkers/cpp.py:
409         (_check_parameter_name_against_text): Deleted.
410         (check_function_definition_and_pass_ptr): Deleted.
411         (check_function_definition): Deleted.
412         (check_pass_ptr_usage): Deleted.
413         (process_line): Deleted.
414         (CppChecker): Deleted.
415
416 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
417
418         [Win] Expose "Inverted Colors" option in WinLauncher
419         https://bugs.webkit.org/show_bug.cgi?id=148451
420
421         Reviewed by Tim Horton.
422
423         Add the ability to toggle the "Inverted Colors" preference
424         in WinLauncher.
425         
426         * WinLauncher/Common.cpp:
427         (ToggleMenuItem): Toggle the feature when the menu item
428         is selected.
429         (WndProc): Recognize the new menu option.
430         * WinLauncher/WinLauncher.cpp:
431         (WinLauncher::setToDefaultPreferences): Launch with "Invert
432         Colors" turned off.
433         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
434         entry for "Invert Colors".
435         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
436
437 2015-08-25  Nan Wang  <n_wang@apple.com>
438
439         [Mac] accessibility/document-attributes.html fails
440         https://bugs.webkit.org/show_bug.cgi?id=116636
441
442         Reviewed by Chris Fleizach.
443
444         Implemented documentURI() and documentEncoding().
445
446         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
447         (AccessibilityUIElement::documentEncoding):
448         (AccessibilityUIElement::documentURI):
449         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
450         (WTR::AccessibilityUIElement::documentEncoding):
451         (WTR::AccessibilityUIElement::documentURI):
452
453 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
454
455         [Win] Unreviewed test gardening.
456
457         Fix another case where the logging string is constructed using the variable 'frame',
458         but the method argument is not given a name. This causes the global 'frame' value to
459         be used, producing incorrect output.
460
461         * DumpRenderTree/win/FrameLoadDelegate.cpp:
462         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
463         argument.
464
465 2015-08-24  Tim Horton  <timothy_horton@apple.com>
466
467         (Finally...) get rid of WKViewIOS
468         https://bugs.webkit.org/show_bug.cgi?id=148404
469
470         Reviewed by Anders Carlsson.
471
472         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
473         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
474         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
475         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
476         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
477         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
478         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
479         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
480         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
481         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
482         Mark tests that use WKBrowsingContextController as Mac-only.
483
484         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
485         (WTR::AccessibilityController::addNotificationListener):
486         * WebKitTestRunner/ios/mainIOS.mm:
487         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
488         Import UIKit instead of depending on WKView.h to do so.
489
490 2015-08-24  Jason Marcell  <jmarcell@apple.com>
491
492         Add support to dashboard for displaying Git SHA's as revisions.
493         https://bugs.webkit.org/show_bug.cgi?id=148387
494
495         Reviewed by Daniel Bates.
496
497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
498         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
499         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
500         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
502         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
503
504 2015-08-24  Andy Estes  <aestes@apple.com>
505
506         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
507
508         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
509
510 2015-08-23  Andy Estes  <aestes@apple.com>
511
512         Addressed a missed piece of review feedback from r188851.
513
514         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
515
516 2015-08-23  Andy Estes  <aestes@apple.com>
517
518         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
519         https://bugs.webkit.org/show_bug.cgi?id=147872
520         rdar://problem/22044000
521
522         Reviewed by Dan Bernstein.
523         
524         Added an API test.
525
526         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
528         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
529         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
530         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
531         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
532         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
533         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
534         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
535         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
536         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
537
538 2015-08-23  Andy Estes  <aestes@apple.com>
539
540         Fixed the 32-bit Mac build after r188844.
541
542         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
543         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
544
545 2015-08-22  Andy Estes  <aestes@apple.com>
546
547         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
548         https://bugs.webkit.org/show_bug.cgi?id=148317
549
550         Reviewed by Dan Bernstein.
551
552         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
553         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
554         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
555         when creating WKWebViews.
556
557         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
558         added a new API test for bundle parameters.
559
560         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
561         named its executable TestWebKitAPI.bundle.
562         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
564         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
565         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
566         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
567         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
568         bundle parameter and asked for an initial notification.
569         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
570         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
571         mirror its value in the main frame's JSContext.
572         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
573         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
574         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
575         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
576         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
577         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
578         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
579         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
580         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
581         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
582
583 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
584
585         URTBF after r188828.
586
587         * WebKitTestRunner/PlatformWebView.h:
588
589 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
590
591         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
592         https://bugs.webkit.org/show_bug.cgi?id=148356
593
594         Reviewed by Darin Adler.
595
596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
597         (BuildbotCombinedQueueView.prototype.update):
598
599 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
600
601         build.webkit.org/dashboard: Respect step's hidden flag
602         https://bugs.webkit.org/show_bug.cgi?id=148357
603
604         Reviewed by Darin Adler.
605
606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
607         (BuildbotIteration.prototype._parseData):
608
609 2015-08-23  Nan Wang  <n_wang@apple.com>
610
611         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
612         https://bugs.webkit.org/show_bug.cgi?id=148328
613
614         Reviewed by Darin Adler.
615
616         We should only expose stringValue() when value attribute is set.
617
618         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
619         (AccessibilityUIElement::stringValue):
620         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
621         (WTR::AccessibilityUIElement::stringValue):
622
623 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
624
625         Remove style checking rule regarding OwnPtr and PassOwnPtr
626         https://bugs.webkit.org/show_bug.cgi?id=148360
627
628         Reviewed by Darin Adler.
629
630         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
631         Removed it.
632
633         * Scripts/do-webcore-rename:
634         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
635         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
636         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
637         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
638         (WebKitStyleTest.test_names): Deleted.
639
640 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
641
642         WebKitTestRunner should use WKWebView on OS X and iOS
643         https://bugs.webkit.org/show_bug.cgi?id=143743
644         <rdar://problem/16947123>
645
646         Reviewed by Anders Carlsson.
647         Patch by Enrica Casucci and myself.
648
649         * WebKitTestRunner/PlatformWebView.h:
650         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
651         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
652         instead of WKContext and WKPageGroup.
653
654         Remove the unused, always-true windowSnapshotEnabled().
655         While technically some platforms don't have window snapshotting,
656         they just return null instead of implementing windowSnapshotEnabled().
657
658         * WebKitTestRunner/TestController.h:
659         * WebKitTestRunner/TestController.cpp:
660         (WTR::TestController::createOtherPage):
661         (WTR::TestController::initialize):
662         (WTR::TestController::createWebViewWithOptions):
663         Delegate to the various platforms for creating PlatformWebView instances,
664         for creating WKContexts, and for accessing WKPreferences,
665         so that they can do special things (like, use WKWebView instead!).
666
667         (WTR::TestController::resetPreferencesToConsistentValues):
668         Make explicit WebKitTestRunner's desired default for two preferences
669         which have differing defaults between the antique and modern API,
670         for consistency's sake.
671
672         (WTR::TestController::resetStateToConsistentValues):
673         Add platformResetStateToConsistentValues.
674
675         * WebKitTestRunner/TestInvocation.cpp:
676         (WTR::TestInvocation::dumpResults):
677         Adjust to the aforementioned removal of windowSnapshotEnabled().
678
679         * WebKitTestRunner/ios/TestControllerCocoa.mm:
680         (WTR::TestController::platformResetStateToConsistentValues):
681         (WTR::TestController::platformPreferences):
682         (WTR::TestController::platformCreateWebView):
683         (WTR::TestController::platformCreateOtherPage):
684         (WTR::TestController::platformInitializeConfiguration):
685         Implement the new platform functions for the Modern WebKit2 API,
686         in a new TestControllerCocoa file that is shared between iOS and Mac.
687         
688         For platformMaybeCreateContext, use the trick that we know we can cast
689         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
690         WKWebView's configuration.
691
692         Ditto for WKPreferencesRef and WKPreferences.
693
694         Remove user content filters on the WKWebView's userContentController.
695
696         * WebKitTestRunner/mac/TestControllerMac.mm:
697         * WebKitTestRunner/ios/TestControllerIOS.mm:
698         Move code into TestControllerCocoa.
699
700         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
701         (WTR::InjectedBundle::beginTesting):
702         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
703         (WTR::TestRunner::addUserScript):
704         (WTR::TestRunner::addUserStyleSheet):
705         Adopt WKBundlePage API for user scripts/sheets.
706
707         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
708         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
709         Make and keep a WKWebView instead of a WKView.
710         
711         * WebKitTestRunner/mac/EventSenderProxy.mm:
712         (WTR::EventSenderProxy::mouseUp):
713         (WTR::EventSenderProxy::mouseMoveTo):
714         Reach inside the WKWebView to the WKView when dispatching events.
715         This is fairly ugly and we should come up with a better solution.
716         Also, fix some flipping and style errors.
717
718 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
719
720         Unreviewed, attempt to fix GTK build after r188718
721
722         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
723         (WTR::PlatformWebView::PlatformWebView):
724
725 2015-08-21  Commit Queue  <commit-queue@webkit.org>
726
727         Unreviewed, rolling out r188807, r188813, and r188815.
728         https://bugs.webkit.org/show_bug.cgi?id=148349
729
730         lots of 32-bit build problems, better to resolve separately
731         and try again (Requested by thorton on #webkit).
732
733         Reverted changesets:
734
735         "WebKitTestRunner should use WKWebView on OS X and iOS"
736         https://bugs.webkit.org/show_bug.cgi?id=143743
737         http://trac.webkit.org/changeset/188807
738
739         "Stop building WebKitTestRunner for 32-bit platforms"
740         https://bugs.webkit.org/show_bug.cgi?id=143743
741         http://trac.webkit.org/changeset/188813
742
743         "Stop building WebKitTestRunner for 32-bit platforms"
744         https://bugs.webkit.org/show_bug.cgi?id=143743
745         http://trac.webkit.org/changeset/188815
746
747 2015-08-21  Tim Horton  <timothy_horton@apple.com>
748
749         Stop building WebKitTestRunner for 32-bit platforms
750         https://bugs.webkit.org/show_bug.cgi?id=143743
751         <rdar://problem/16947123>
752
753         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
754         This is a restriction on the valid set, not the desired set.
755
756 2015-08-21  Jason Marcell  <jmarcell@apple.com>
757
758         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
759         to work with these new objects.
760         https://bugs.webkit.org/show_bug.cgi?id=148188
761
762         Reviewed by Daniel Bates.
763
764         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
765         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
767         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
768         (repository, "branch name")-pair.
769         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
770         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
771         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
772         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
773         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
774         objects which represent a (repository, "branch name")-pair.
775         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
776         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
777         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
778         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
779         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
780         BuildbotQueue.branch to BuildbotQueue.branches.
781         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
782         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
783
784 2015-08-21  Tim Horton  <timothy_horton@apple.com>
785
786         Stop building WebKitTestRunner for 32-bit platforms
787         https://bugs.webkit.org/show_bug.cgi?id=143743
788         <rdar://problem/16947123>
789
790         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
791         WKWebView is not available on 32-bit OS X.
792
793 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
794
795         [Win] Unreviewed test correction after r188709.
796
797         I removed a function argument that happened to be mirrored by a global
798         value with the same name. This prevented a compile error, but testing
799         showed that the wrong value was being used in the function.
800
801         * DumpRenderTree/win/FrameLoadDelegate.cpp:
802         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
803         back
804
805 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
806
807         WebKitTestRunner should use WKWebView on OS X and iOS
808         https://bugs.webkit.org/show_bug.cgi?id=143743
809         <rdar://problem/16947123>
810
811         Reviewed by Anders Carlsson.
812         Patch by Enrica Casucci and myself.
813
814         * WebKitTestRunner/PlatformWebView.h:
815         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
816         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
817         instead of WKContext and WKPageGroup.
818
819         Remove the unused, always-true windowSnapshotEnabled().
820         While technically some platforms don't have window snapshotting,
821         they just return null instead of implementing windowSnapshotEnabled().
822
823         * WebKitTestRunner/TestController.h:
824         * WebKitTestRunner/TestController.cpp:
825         (WTR::TestController::createOtherPage):
826         (WTR::TestController::initialize):
827         (WTR::TestController::createWebViewWithOptions):
828         Delegate to the various platforms for creating PlatformWebView instances,
829         for creating WKContexts, and for accessing WKPreferences,
830         so that they can do special things (like, use WKWebView instead!).
831
832         (WTR::TestController::resetPreferencesToConsistentValues):
833         Make explicit WebKitTestRunner's desired default for two preferences
834         which have differing defaults between the antique and modern API,
835         for consistency's sake.
836
837         (WTR::TestController::resetStateToConsistentValues):
838         Add platformResetStateToConsistentValues.
839
840         * WebKitTestRunner/TestInvocation.cpp:
841         (WTR::TestInvocation::dumpResults):
842         Adjust to the aforementioned removal of windowSnapshotEnabled().
843
844         * WebKitTestRunner/ios/TestControllerCocoa.mm:
845         (WTR::TestController::platformResetStateToConsistentValues):
846         (WTR::TestController::platformPreferences):
847         (WTR::TestController::platformCreateWebView):
848         (WTR::TestController::platformCreateOtherPage):
849         (WTR::TestController::platformInitializeConfiguration):
850         Implement the new platform functions for the Modern WebKit2 API,
851         in a new TestControllerCocoa file that is shared between iOS and Mac.
852         
853         For platformMaybeCreateContext, use the trick that we know we can cast
854         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
855         WKWebView's configuration.
856
857         Ditto for WKPreferencesRef and WKPreferences.
858
859         Remove user content filters on the WKWebView's userContentController.
860
861         * WebKitTestRunner/mac/TestControllerMac.mm:
862         * WebKitTestRunner/ios/TestControllerIOS.mm:
863         Move code into TestControllerCocoa.
864
865         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
866         (WTR::InjectedBundle::beginTesting):
867         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
868         (WTR::TestRunner::addUserScript):
869         (WTR::TestRunner::addUserStyleSheet):
870         Adopt WKBundlePage API for user scripts/sheets.
871
872         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
873         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
874         Make and keep a WKWebView instead of a WKView.
875         
876         * WebKitTestRunner/mac/EventSenderProxy.mm:
877         (WTR::EventSenderProxy::mouseUp):
878         (WTR::EventSenderProxy::mouseMoveTo):
879         Reach inside the WKWebView to the WKView when dispatching events.
880         This is fairly ugly and we should come up with a better solution.
881         Also, fix some flipping and style errors.
882
883 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
884
885         Improve how UI events are dispatched by WebKitTestRunner
886         https://bugs.webkit.org/show_bug.cgi?id=148326
887
888         Reviewed by Anders Carlsson.
889
890         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
891         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
892         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
893         asynchronous (and really, it has always been for the most part).
894
895         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
896         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
897         (WTR::EventSendingController::mouseUp): Ditto.
898         (WTR::EventSendingController::mouseMoveTo): Ditto.
899         (WTR::EventSendingController::mouseForceDown): Ditto.
900         (WTR::EventSendingController::mouseForceUp): Ditto.
901         (WTR::EventSendingController::mouseForceChanged): Ditto.
902         (WTR::EventSendingController::leapForward): Ditto.
903         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
904         (WTR::EventSendingController::keyDown): Ditto.
905         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
906         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
907         to be done in custom WebKit2 code for test wheel event handling.
908         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
909         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
910         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
911         (WTR::EventSendingController::addTouchPoint): Ditto.
912         (WTR::EventSendingController::updateTouchPoint): Ditto.
913         (WTR::EventSendingController::setTouchModifier): Ditto.
914         (WTR::EventSendingController::setTouchPointRadius): Ditto.
915         (WTR::EventSendingController::touchStart): Ditto.
916         (WTR::EventSendingController::touchMove): Ditto.
917         (WTR::EventSendingController::touchEnd): Ditto.
918         (WTR::EventSendingController::touchCancel): Ditto.
919         (WTR::EventSendingController::clearTouchPoints): Ditto.
920         (WTR::EventSendingController::releaseTouchPoint): Ditto.
921         (WTR::EventSendingController::cancelTouchPoint): Ditto.
922
923         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
924         (WTR::InjectedBundle::postSetWindowIsKey):
925         (WTR::InjectedBundle::postSimulateWebNotificationClick):
926         (WTR::InjectedBundle::isGeolocationProviderActive):
927         (WTR::InjectedBundle::shouldProcessWorkQueue):
928         Updated for WKBundlePagePostSynchronousMessage renaming.
929
930         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
931         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
932
933         * WebKitTestRunner/TestController.cpp:
934         (WTR::TestController::initialize): Allow handling the new test style messages.
935         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
936         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
937         (WTR::TestController::didReceiveMessageFromInjectedBundle):
938         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
939         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
940
941         * WebKitTestRunner/mac/EventSenderProxy.mm:
942         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
943         (WTR::EventSenderProxy::keyDown): Ditto.
944         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
945         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
946
947 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
948
949         Skip no-llint tests that fail due to running out of executable memory after r188969
950         https://bugs.webkit.org/show_bug.cgi?id=148273
951
952         Reviewed by Michael Saboff.
953
954         * Scripts/run-jsc-stress-tests:
955
956 2015-08-21  Nan Wang  <n_wang@apple.com>
957
958         [Mac] accessibility/selection-states.html fails
959         https://bugs.webkit.org/show_bug.cgi?id=116637
960
961         Reviewed by Chris Fleizach.
962
963         Implemented isSelectable() and isMultiSelectable().
964
965         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
966         (AccessibilityUIElement::isSelectable):
967         (AccessibilityUIElement::isMultiSelectable):
968         (AccessibilityUIElement::isSelectedOptionActive):
969         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
970         (WTR::AccessibilityUIElement::isSelectable):
971         (WTR::AccessibilityUIElement::isMultiSelectable):
972         (WTR::AccessibilityUIElement::isVisible):
973
974 2015-08-21  Jason Marcell  <jmarcell@apple.com>
975
976         Fix iteration over repositories on bot watcher's dashboard.
977
978         Reviewed by Alexey Proskuryakov.
979
980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
981         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
982
983 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
984
985         [EFL] Revise PlatformWebView ctor according to r188718
986         https://bugs.webkit.org/show_bug.cgi?id=148282
987
988         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
989         instead of WKContextRef and WKPageGroupRef respectively.
990
991         Reviewed by Gyuyoung Kim.
992
993         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
994         (WTR::PlatformWebView::PlatformWebView):
995
996 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
997
998         Unreviewed, changed Devin Rousso's email.
999
1000         * Scripts/webkitpy/common/config/contributors.json:
1001
1002 2015-08-20  Anders Carlsson  <andersca@apple.com>
1003
1004         Use WKPageConfigurationRef in WebKitTestRunner
1005         https://bugs.webkit.org/show_bug.cgi?id=147996
1006
1007         Reviewed by Tim Horton.
1008
1009         * WebKitTestRunner/TestController.cpp:
1010         (WTR::TestController::createOtherPage):
1011         (WTR::TestController::initialize):
1012         (WTR::TestController::createWebViewWithOptions):
1013         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1014         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
1015         (WTR::PlatformWebView::PlatformWebView):
1016         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
1017
1018 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
1019
1020         [Win] Update Windows tools for revised MIDL interfaces
1021         https://bugs.webkit.org/show_bug.cgi?id=148249
1022
1023         Reviewed by Dean Jackson.
1024
1025         This is a follow-up to Bug 148001.
1026
1027         Revise the testing software to use compatible signatures and
1028         implementations to match the requirements of the IDL generated
1029         with the SAL annotations.
1030
1031         * DumpRenderTree/win/DRTDataObject.cpp:
1032         * DumpRenderTree/win/DRTDataObject.h:
1033         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1034         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1035         * DumpRenderTree/win/DRTDropSource.cpp:
1036         * DumpRenderTree/win/DRTDropSource.h:
1037         * DumpRenderTree/win/DumpRenderTree.cpp:
1038         * DumpRenderTree/win/EditingDelegate.cpp:
1039         * DumpRenderTree/win/EditingDelegate.h:
1040         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1041         * DumpRenderTree/win/FrameLoadDelegate.h:
1042         * DumpRenderTree/win/HistoryDelegate.cpp:
1043         * DumpRenderTree/win/HistoryDelegate.h:
1044         * DumpRenderTree/win/PolicyDelegate.cpp:
1045         * DumpRenderTree/win/PolicyDelegate.h:
1046         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1047         * DumpRenderTree/win/ResourceLoadDelegate.h:
1048         * DumpRenderTree/win/TestRunnerWin.cpp:
1049         * DumpRenderTree/win/UIDelegate.cpp:
1050         * DumpRenderTree/win/UIDelegate.h:
1051         * WinLauncher/AccessibilityDelegate.cpp:
1052         * WinLauncher/AccessibilityDelegate.h:
1053         * WinLauncher/Common.cpp:
1054         * WinLauncher/DOMDefaultImpl.cpp:
1055         * WinLauncher/DOMDefaultImpl.h:
1056         * WinLauncher/PageLoadTestClient.cpp:
1057         * WinLauncher/PageLoadTestClient.h:
1058         * WinLauncher/PrintWebUIDelegate.cpp:
1059         * WinLauncher/PrintWebUIDelegate.h:
1060         * WinLauncher/ResourceLoadDelegate.cpp:
1061         * WinLauncher/ResourceLoadDelegate.h:
1062         * WinLauncher/WebDownloadDelegate.cpp:
1063         * WinLauncher/WebDownloadDelegate.h:
1064         * WinLauncher/WinLauncherWebHost.cpp:
1065         * WinLauncher/WinLauncherWebHost.h:
1066         * WinLauncher/WinMain.cpp:
1067         * win/DLLLauncher/DLLLauncherMain.cpp:
1068
1069 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
1070
1071         Unreviewed, shorten a test that runs too long and times out.
1072
1073         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1074         (TestWebKitAPI::TEST):
1075
1076 2015-08-20  Alex Christensen  <achristensen@webkit.org>
1077
1078         Clean up CMake build after r188673
1079         https://bugs.webkit.org/show_bug.cgi?id=148234
1080
1081         Reviewed by Tim Horton.
1082
1083         * DumpRenderTree/PlatformWin.cmake:
1084         * TestWebKitAPI/CMakeLists.txt:
1085         * TestWebKitAPI/PlatformWin.cmake:
1086         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
1087         gtest needs to be a static library on Windows to not crash.
1088
1089 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1090
1091         CMake Windows build should not include files directly from other Source directories
1092         https://bugs.webkit.org/show_bug.cgi?id=148198
1093
1094         Reviewed by Brent Fulgham.
1095
1096         * DumpRenderTree/DumpRenderTreePrefix.h:
1097         Include cmakeconfig.h to properly define all enabled features.
1098         * DumpRenderTree/PlatformWin.cmake:
1099         * TestWebKitAPI/PlatformWin.cmake:
1100
1101 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1102
1103         Build TestWTF on Mac with CMake.
1104         https://bugs.webkit.org/show_bug.cgi?id=147972
1105
1106         Reviewed by Tim Horton.
1107
1108         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
1109         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
1110
1111         * TestWebKitAPI/CMakeLists.txt:
1112         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
1113         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
1114         * TestWebKitAPI/PlatformMac.cmake: Added.
1115         * TestWebKitAPI/config.h:
1116         Postpone some build fixes until WebKit builds completely on Mac with CMake.
1117
1118 2015-08-19  Brian Burg  <bburg@apple.com>
1119
1120         Unreviewed, add Aleksandr Skachkov to the list of contributors.
1121
1122         * Scripts/webkitpy/common/config/contributors.json:
1123
1124 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1125
1126         REGRESSION(r188548): [GTK] Build broken.
1127         https://bugs.webkit.org/show_bug.cgi?id=148154
1128
1129         Reviewed by Martin Robinson.
1130
1131         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1132         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1133         Even if we don't need to add/override any settings in ViewOptions,
1134         we need to define this as an empty function to make it build.
1135
1136 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1137
1138         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
1139         https://bugs.webkit.org/show_bug.cgi?id=148073
1140
1141         Reviewed by Alexey Proskuryakov.
1142
1143         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
1144         (TestWebKitAPI::TEST):
1145
1146 2015-08-18  Anders Carlsson  <andersca@apple.com>
1147
1148         Fix test failure fallout from r188602 by using a V5 page ui client struct.
1149
1150         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1151         (TestWebKitAPI::setUpClients):
1152
1153 2015-08-18  Brian Burg  <bburg@apple.com>
1154
1155         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1156         https://bugs.webkit.org/show_bug.cgi?id=147955
1157
1158         Reviewed by Timothy Hatcher.
1159
1160         To enable sharing of common test code between protocol and model tests,
1161         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1162
1163         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1164         protocol-test.js uses to load the inspector frontend stub into its iframe
1165         from an arbitrary local file URL.
1166
1167         * DumpRenderTree/TestRunner.cpp:
1168         (getInspectorTestStubURLCallback):
1169         (TestRunner::staticValues):
1170         * DumpRenderTree/TestRunner.h:
1171         * DumpRenderTree/mac/TestRunnerMac.mm:
1172         (SOFT_LINK_STAGED_FRAMEWORK):
1173         (TestRunner::inspectorTestStubURL):
1174         * DumpRenderTree/win/TestRunnerWin.cpp:
1175         (TestRunner::inspectorTestStubURL):
1176         * WebKitTestRunner/Configurations/Base.xcconfig:
1177         Since WebKitTestRunner now includes WebCore private headers, also search
1178         for the WebCore framework inside the WebKit umbrella framework.
1179
1180         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1181         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1182         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1183         (WTR::TestRunner::inspectorTestStubURL):
1184         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1185         (WTR::TestRunner::inspectorTestStubURL):
1186         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1187         (WTR::TestRunner::inspectorTestStubURL):
1188
1189 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
1190
1191         Unreviewed, fix GTK build.
1192
1193         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1194         (TestWebKitAPI::TEST):
1195
1196 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
1197
1198         Replace all remaining uses of WTF::Mutex with WTF::Lock
1199         https://bugs.webkit.org/show_bug.cgi?id=148089
1200
1201         Reviewed by Geoffrey Garen.
1202
1203         * DumpRenderTree/JavaScriptThreading.cpp:
1204         (javaScriptThreadsMutex):
1205         (runJavaScriptThread):
1206         (startJavaScriptThreads):
1207         (stopJavaScriptThreads):
1208         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
1209         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1210         (TestWebKitAPI::TEST):
1211         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1212         (TestWebKitAPI::TEST):
1213
1214 2015-08-17  Commit Queue  <commit-queue@webkit.org>
1215
1216         Unreviewed, rolling out r188539, r188544, r188552, and
1217         r188564.
1218         https://bugs.webkit.org/show_bug.cgi?id=148122
1219
1220         Broke tests and some build styles (Requested by ap on
1221         #webkit).
1222
1223         Reverted changesets:
1224
1225         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
1226         bundle"
1227         https://bugs.webkit.org/show_bug.cgi?id=147955
1228         http://trac.webkit.org/changeset/188539
1229
1230         "Web Inspector: split TestStub.js into multiple files and
1231         modernize it"
1232         https://bugs.webkit.org/show_bug.cgi?id=148077
1233         http://trac.webkit.org/changeset/188544
1234
1235         "Web Inspector: InspectorTest should be a subclass of
1236         TestHarness"
1237         https://bugs.webkit.org/show_bug.cgi?id=148079
1238         http://trac.webkit.org/changeset/188552
1239
1240         "Unreviewed internal build fix attempt after r188539."
1241         http://trac.webkit.org/changeset/188564
1242
1243 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1244
1245         [OS X] Remove support for composite fonts
1246         https://bugs.webkit.org/show_bug.cgi?id=147920
1247
1248         Reviewed by Dan Bernstein.
1249
1250         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1251         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
1252         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1253         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1254         * DumpRenderTree/mac/DumpRenderTree.mm:
1255         (allowedFontFamilySet): Deleted.
1256         (activateTestingFonts): Deleted.
1257         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1258         (WTR::allowedFontFamilySet): Deleted.
1259         (WTR::activateFonts): Deleted.
1260         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1261         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
1262         * WebKitTestRunner/mac/TestControllerMac.mm:
1263         (WTR::allowedFontFamilySet): Deleted.
1264
1265 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
1266
1267         Unreviewed internal build fix attempt after r188539.
1268
1269         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1270
1271 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1272
1273         Fix the build
1274
1275         Unreviewed.
1276
1277         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1278
1279 2015-08-17  Alex Christensen  <achristensen@webkit.org>
1280
1281         Build Debug Suffix on Windows with CMake
1282         https://bugs.webkit.org/show_bug.cgi?id=148083
1283
1284         Reviewed by Brent Fulgham.
1285
1286         * TestWebKitAPI/CMakeLists.txt:
1287         * TestWebKitAPI/PlatformWin.cmake:
1288         Add DEBUG_SUFFIX
1289
1290 2015-08-17  Anders Carlsson  <andersca@apple.com>
1291
1292         Simplify how PlatformWebViews are created when view options change
1293         https://bugs.webkit.org/show_bug.cgi?id=148093
1294
1295         Reviewed by Sam Weinig.
1296
1297         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
1298
1299         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
1300         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
1301         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
1302
1303         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
1304
1305         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
1306         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
1307
1308         * WebKitTestRunner/TestController.cpp:
1309         (WTR::TestController::ensureViewSupportsOptionsForTest):
1310         (WTR::shouldUseFixedLayout):
1311         (WTR::TestController::viewOptionsForTest):
1312         (WTR::TestController::updateWebViewSizeForTest):
1313         (WTR::TestController::updateWindowScaleForTest):
1314         (WTR::TestController::configureViewForTest):
1315         (WTR::TestController::initialize): Deleted.
1316         (WTR::TestController::ensureViewSupportsOptions): Deleted.
1317         (WTR::TestController::updateLayoutTypeForTest): Deleted.
1318         (WTR::TestController::platformConfigureViewForTest): Deleted.
1319         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
1320         (WTR::TestController::run): Deleted.
1321         * WebKitTestRunner/TestController.h:
1322         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1323         (WTR::shouldUseFixedLayout):
1324         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1325         (WTR::TestController::platformConfigureViewForTest):
1326         (WTR::TestController::platformResetPreferencesToConsistentValues):
1327         * WebKitTestRunner/ios/TestControllerIOS.mm:
1328         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1329         * WebKitTestRunner/mac/TestControllerMac.mm:
1330         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1331         (WTR::TestController::platformConfigureViewForTest):
1332
1333 2015-08-17  Sam Weinig  <sam@webkit.org>
1334
1335         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
1336         https://bugs.webkit.org/show_bug.cgi?id=148097
1337
1338         Reviewed by Anders Carlsson.
1339
1340         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
1341         Add tests for WebsiteDataStores in the WKPageConfiguration.
1342
1343 2015-08-17  Brian Burg  <bburg@apple.com>
1344
1345         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1346         https://bugs.webkit.org/show_bug.cgi?id=147955
1347
1348         Reviewed by Timothy Hatcher.
1349
1350         To enable sharing of common test code between protocol and model tests,
1351         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1352
1353         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1354         protocol-test.js uses to load the inspector frontend stub into its iframe
1355         from an arbitrary local file URL.
1356
1357         * DumpRenderTree/TestRunner.cpp:
1358         (getInspectorTestStubURLCallback):
1359         (TestRunner::staticValues):
1360         * DumpRenderTree/TestRunner.h:
1361         * DumpRenderTree/mac/TestRunnerMac.mm:
1362         (SOFT_LINK_STAGED_FRAMEWORK):
1363         (TestRunner::inspectorTestStubURL):
1364         * DumpRenderTree/win/TestRunnerWin.cpp:
1365         (TestRunner::inspectorTestStubURL):
1366         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1367         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1368         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1369         (WTR::TestRunner::inspectorTestStubURL):
1370         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1371         (WTR::TestRunner::inspectorTestStubURL):
1372         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1373         (WTR::TestRunner::inspectorTestStubURL):
1374
1375 2015-08-17  Saam barati  <sbarati@apple.com>
1376
1377         Change email address from saambarati1@gmail.com to sbarati@apple.com
1378
1379         * Scripts/webkitpy/common/config/contributors.json:
1380
1381 2015-08-17  Jason Marcell  <jmarcell@apple.com>
1382
1383         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
1384         repositories other than "openSource" and "internal".
1385         https://bugs.webkit.org/show_bug.cgi?id=147961
1386
1387         Reviewed by Daniel Bates.
1388
1389         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1390         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
1391         generically with repositories other than "openSource" and "internal".
1392
1393 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
1394
1395         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
1396         https://bugs.webkit.org/show_bug.cgi?id=148081
1397
1398         Reviewed by Tim Horton.
1399
1400         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1401         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1402
1403 2015-08-11  Andy Estes  <aestes@apple.com>
1404
1405         [Cocoa] Add redirect support to CustomProtocolManager
1406         https://bugs.webkit.org/show_bug.cgi?id=147871
1407
1408         Reviewed by Dan Bernstein.
1409
1410         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
1411
1412         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1413         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
1414         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
1415         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1416         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
1417         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
1418         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
1419         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
1420         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
1421         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1422         (TestWebKitAPI::TEST): Unregistered TestProtocol.
1423         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
1424         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
1425         (-[TestProtocol startLoading]): Taught to handle redirect responses.
1426
1427 2015-08-13  Andy Estes  <aestes@apple.com>
1428
1429         [Cocoa] Downloads do not start if policy decision is made asynchronously
1430         https://bugs.webkit.org/show_bug.cgi?id=147985
1431
1432         Reviewed by Brady Eidson.
1433
1434         Added a new API test.
1435
1436         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1437         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1438         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
1439         (TEST):
1440
1441 2015-08-14  Commit Queue  <commit-queue@webkit.org>
1442
1443         Unreviewed, rolling out r187357.
1444         https://bugs.webkit.org/show_bug.cgi?id=148032
1445
1446         webkit-patch generates incorrect patches that cannot be
1447         applied (Requested by dydz on #webkit).
1448
1449         Reverted changeset:
1450
1451         "Call fixChangeLogPatch when generating patches from webkit-
1452         patch"
1453         https://bugs.webkit.org/show_bug.cgi?id=147248
1454         http://trac.webkit.org/changeset/187357
1455
1456 2015-08-14  Jason Marcell  <jmarcell@apple.com>
1457
1458         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
1459         other than "openSource" and "internal".
1460         https://bugs.webkit.org/show_bug.cgi?id=147938
1461
1462         Reviewed by Daniel Bates.
1463
1464         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1465         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
1466         repositories other than "openSource" and "internal".
1467
1468 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
1469
1470         Unreviewed, shorten another test that is timing out.
1471
1472         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1473         (TestWebKitAPI::TEST):
1474
1475 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
1476
1477         AppScale: Assertion hit when hovering a webkit-queue bubble
1478         https://bugs.webkit.org/show_bug.cgi?id=147997
1479
1480         Reviewed by Alexey Proskuryakov.
1481
1482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1483         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
1484
1485 2015-08-13  Lucas Forschler  <lforschler@apple.com>
1486
1487         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
1488         
1489         Unreviewed.
1490         
1491         * Scripts/copy-webkitlibraries-to-product-directory:
1492
1493 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
1494
1495         Run benchmark customized Dromaeo should not assume there is an internet connection.
1496         https://bugs.webkit.org/show_bug.cgi?id=147995
1497
1498         Reviewed by Ryosuke Niwa.
1499
1500         Add several dependency js libs to local.
1501
1502         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
1503
1504 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1505
1506         WTF should have a compact Condition object to use with Lock
1507         https://bugs.webkit.org/show_bug.cgi?id=147986
1508
1509         Reviewed by Geoffrey Garen.
1510
1511         Add a test for WTF::Condition.
1512
1513         * TestWebKitAPI/CMakeLists.txt:
1514         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1515         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1516         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
1517         (TestWebKitAPI::TEST):
1518         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1519         (TestWebKitAPI::runLockTest): Change the name of the thread.
1520
1521 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1522
1523         Unreviewed, shorten another test. It's timing out in debug on some bot.
1524
1525         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1526         (TestWebKitAPI::TEST):
1527
1528 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
1529
1530         WTF::Lock should not suffer from the thundering herd
1531         https://bugs.webkit.org/show_bug.cgi?id=147947
1532
1533         Reviewed by Geoffrey Garen.
1534
1535         Add testing that checks that locks return to a pristine state after contention is over.
1536
1537         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1538         (TestWebKitAPI::LockInspector::isFullyReset):
1539         (TestWebKitAPI::runLockTest):
1540         (TestWebKitAPI::TEST):
1541
1542 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
1543
1544         Benchmarks supported by run_benchmark script should not assume we have internet access.
1545         https://bugs.webkit.org/show_bug.cgi?id=147959
1546
1547         Reviewed by Ryosuke Niwa.
1548
1549         For JSBench we should not request jquery.min.js from google through the internet.
1550
1551         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
1552
1553 2015-08-12  Jason Marcell  <jmarcell@apple.com>
1554
1555         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
1556         other than "openSource" and "internal".
1557         https://bugs.webkit.org/show_bug.cgi?id=147796
1558
1559         Reviewed by Daniel Bates.
1560
1561         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1562         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
1563         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
1564         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
1565         and another assertion that, if the previousIteration is non-null, the given repository is in
1566         previousIteration.revision.
1567         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
1568         with repositories other than "openSource" and "internal". Also added an assertion that the returned
1569         fragment has at least one child node.
1570
1571 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
1572
1573         Add a tool that dumps class and struct member layout, showing padding
1574         https://bugs.webkit.org/show_bug.cgi?id=147898
1575
1576         Reviewed by Zalan Bujtas.
1577         
1578         This 'dump-class-layout' script uses the lldb Python bindings to collect data
1579         about data member layout, and displays it.
1580         
1581         Sample output:
1582
1583               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
1584               +0 < 56>     WebCore::URL m_value;
1585               +0 <  8>         WTF::String m_string;
1586               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
1587               +0 <  8>                 WTF::StringImpl * m_ptr;
1588               +8 <  1>         bool:1 m_isValid;
1589               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
1590               +9 <  3>         <PADDING>
1591              +12 <  4>         int m_schemeEnd;
1592              +16 <  4>         int m_userStart;
1593              +20 <  4>         int m_userEnd;
1594              +24 <  4>         int m_passwordEnd;
1595              +28 <  4>         int m_hostEnd;
1596              +32 <  4>         int m_portEnd;
1597              +36 <  4>         int m_pathAfterLastSlash;
1598              +40 <  4>         int m_pathEnd;
1599              +44 <  4>         int m_queryEnd;
1600              +48 <  4>         int m_fragmentEnd;
1601              +52 <  4>         <PADDING>
1602              +52 <  4>     <PADDING>
1603              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
1604              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
1605             Total byte size: 72
1606             Total pad bytes: 11
1607             Padding percentage: 15.28 %
1608
1609         * Scripts/dump-class-layout: Added.
1610         (webkit_build_dir):
1611         (developer_dir):
1612         (import_lldb):
1613         (find_build_directory):
1614         (verify_type):
1615         (verify_type_recursive):
1616         (dump_class):
1617         (main):
1618         (main.or):
1619
1620 2015-08-12  Alex Christensen  <achristensen@webkit.org>
1621
1622         Fix Debug CMake builds on Windows
1623         https://bugs.webkit.org/show_bug.cgi?id=147940
1624
1625         Reviewed by Chris Dumez.
1626
1627         * DumpRenderTree/PlatformWin.cmake:
1628         * TestWebKitAPI/PlatformWin.cmake:
1629         The BitmapImage test is not enabled on the AppleWin port.
1630         * WinLauncher/CMakeLists.txt:
1631         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
1632
1633 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1634
1635         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
1636
1637         In r188125 I added a way to mark tests as slow to use a longer
1638         timeout. But it seems it was not enough for
1639         WTF_Lock.ContendedShortSection, so let's try again with a longer
1640         timeout now.
1641
1642         * Scripts/run-gtk-tests:
1643         (TestRunner._run_google_test):
1644
1645 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1646
1647         Allow --debug option in run-jsc
1648         https://bugs.webkit.org/show_bug.cgi?id=147923
1649
1650         Reviewed by Csaba Osztrogonác.
1651
1652         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
1653
1654         * Scripts/run-jsc:
1655
1656 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1657
1658         Fix test after build fix in r188286.
1659         https://bugs.webkit.org/show_bug.cgi?id=147907
1660
1661         Reviewed by Anders Carlsson.
1662
1663         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1664         sleep_for can now be used, but we need to include <thread>
1665
1666 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1667
1668         Always use a byte-sized lock implementation
1669         https://bugs.webkit.org/show_bug.cgi?id=147908
1670
1671         Reviewed by Geoffrey Garen.
1672
1673         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
1674         now tests of Lock.
1675
1676         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1677         (TestWebKitAPI::runLockTest):
1678         (TestWebKitAPI::TEST):
1679
1680 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
1681
1682         Make ASan build not depend on asan.xcconfig
1683         https://bugs.webkit.org/show_bug.cgi?id=147840
1684         rdar://problem/21093702
1685
1686         Reviewed by Daniel Bates.
1687
1688         * asan/asan.xcconfig:
1689         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
1690         are now marked in source code.
1691
1692 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1693
1694         Unreviewed, shorten another test since it timed out.
1695
1696         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1697         (TestWebKitAPI::TEST):
1698
1699 2015-08-11  Mark Lam  <mark.lam@apple.com>
1700
1701         Fix names of Lock tests: should be "Contended", not "Contented".
1702         https://bugs.webkit.org/show_bug.cgi?id=147905
1703
1704         Reviewed by Saam Barati.
1705
1706         We're testing the behavior of lock contention (i.e. when threads contend), not
1707         whether the locks are happy (contented).
1708
1709         * Scripts/run-gtk-tests:
1710         (TestRunner):
1711         (TestRunner.__init__): Deleted.
1712         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1713         (TestWebKitAPI::runLockTest):
1714         (TestWebKitAPI::TEST):
1715
1716 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1717
1718         Update WinCairoRequirements to VS2015.
1719
1720         * Scripts/update-webkit-wincairo-libs:
1721         Update WinCairoRequirements location.
1722
1723 2015-08-11  Jason Marcell  <jmarcell@apple.com>
1724
1725         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
1726         for internalTrac.
1727         https://bugs.webkit.org/show_bug.cgi?id=147805
1728
1729         Reviewed by Daniel Bates.
1730
1731         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1732         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
1733         Dashboard.Repository.Internal.trac for internalTrac.
1734         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
1735         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
1736         respectively.
1737         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
1738         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
1739         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
1740         internalTrac.
1741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
1743         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1744         (Analyzer): Ditto.
1745         (Analyzer.prototype.analyze): Ditto.
1746
1747 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1748
1749         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
1750
1751         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1752         (TestWebKitAPI::TEST):
1753
1754 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
1755
1756         [Win] Switch Windows build to Visual Studio 2015
1757         https://bugs.webkit.org/show_bug.cgi?id=147887
1758         <rdar://problem/22235098>
1759
1760         Reviewed by Alex Christensen.
1761
1762         Update Visual Studio project file settings to use the current Visual
1763         Studio and compiler. Continue targeting binaries to run on our minimum
1764         supported configuration of Windows 7.
1765
1766         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1767         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1768         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1769         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1770         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1771         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
1772         prefer the newer MSBuild included in Visual Studio 2015.
1773         (visualStudioInstallDir):
1774         (msBuildInstallDir):
1775         (visualStudioVersion):
1776         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1777         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1778         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1779         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1780         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1781         * win/record-memory/record-memory.vcxproj:
1782
1783 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1784
1785         Another speculative build fix after r188280.
1786
1787         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1788         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
1789         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
1790
1791 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1792
1793         Unreviewed build fix after r188280.
1794
1795         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1796         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
1797
1798 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
1799
1800         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
1801         https://bugs.webkit.org/show_bug.cgi?id=147665
1802
1803         Reviewed by Mark Lam.
1804
1805         * TestWebKitAPI/CMakeLists.txt:
1806         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1808         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1809         (TestWebKitAPI::TEST):
1810         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
1811         (TestWebKitAPI::TEST):
1812
1813 2015-08-11  Brian Burg  <bburg@apple.com>
1814
1815         webkit-patch should not explode when $EDITOR is set incorrectly
1816         https://bugs.webkit.org/show_bug.cgi?id=147884
1817
1818         Reviewed by Darin Adler.
1819
1820         If $EDITOR doesn't exist, log a warning and continue.
1821
1822         * Scripts/webkitpy/common/system/user.py: 
1823         (User.edit):
1824         (User.edit_changelog):
1825
1826 2015-08-11  Dan Bernstein  <mitz@apple.com>
1827
1828         Reverted r188255, because it turned out that delegates do nonot need this information.
1829
1830         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1831         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
1832
1833 2015-08-11  Dan Bernstein  <mitz@apple.com>
1834
1835         [Cocoa] The UI delegate can't tell if printing was user-initiated
1836         https://bugs.webkit.org/show_bug.cgi?id=147869
1837
1838         Reviewed by Sam Weinig.
1839
1840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1841         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
1842         (-[PrintFrameController webView:didFinishNavigation:]):
1843         (-[PrintFrameController _webView:printFrame:userInitiated:]):
1844         (TEST):
1845
1846 2015-08-10  Alex Christensen  <achristensen@webkit.org>
1847
1848         Another build fix after r188239.
1849
1850         * TestWebKitAPI/PlatformWin.cmake:
1851         Link with more libraries.
1852         * WinLauncher/CMakeLists.txt:
1853         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
1854
1855 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
1856
1857         Build fix after r188237.
1858
1859         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1860         (BenchmarkBuilder.__enter__):
1861
1862 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
1863
1864         Update ReadMe and correct the way to use abstract abstract class.
1865         https://bugs.webkit.org/show_bug.cgi?id=147860
1866
1867         Reviewed by Ryosuke Niwa.
1868
1869         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
1870         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
1871
1872         * Scripts/webkitpy/benchmark_runner/README.md:
1873         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1874         (BrowserDriver):
1875         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1876         (OSXBrowserDriver.restore_env):
1877         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1878         (HTTPServerDriver):
1879         (HTTPServerDriver.set_device_id):
1880         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1881         (SimpleHTTPServerDriver.get_return_code):
1882         (SimpleHTTPServerDriver):
1883         (SimpleHTTPServerDriver.set_device_id):
1884
1885 2015-08-10  Alex Christensen  <achristensen@webkit.org>
1886
1887         Build TestWebKitAPI with CMake on Windows
1888         https://bugs.webkit.org/show_bug.cgi?id=147851
1889
1890         Reviewed by Chris Dumez.
1891
1892         * CMakeLists.txt:
1893         * TestWebKitAPI/CMakeLists.txt:
1894         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
1895         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
1896         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
1897         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
1898         * TestWebKitAPI/PlatformEfl.cmake:
1899         * TestWebKitAPI/PlatformGTK.cmake:
1900         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
1901         I did this without changing the directory structure of the existing EFL and GTK builds.
1902         * TestWebKitAPI/PlatformWin.cmake: Added.
1903         * TestWebKitAPI/win/main.cpp:
1904         (main):
1905         (dllLauncherEntryPoint):
1906         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
1907         * WinLauncher/CMakeLists.txt:
1908         AppleWin port needs /NODEFAULTLIB:MSVCRT.
1909
1910 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
1911
1912         Make cleanup more robust and minor code cleaning in run benchmark script.
1913         https://bugs.webkit.org/show_bug.cgi?id=147800
1914
1915         Reviewed by Ryosuke Niwa.
1916
1917         Use 'finnaly' block to make sure cleanup code is always executed.
1918
1919         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1920         (built_benchmark):
1921         (built_benchmark.__init__):
1922         (built_benchmark.__enter__):
1923         (built_benchmark.__exit__):
1924         (test_environment):
1925         (test_environment.__init__):
1926         (test_environment.__enter__):
1927         (test_environment.__exit__):
1928         (BenchmarkRunner.__init__):
1929         (BenchmarkRunner.execute):
1930         (BenchmarkRunner._dump):
1931         (BenchmarkRunner._wrap):
1932         (BenchmarkRunner): Deleted.
1933         (BenchmarkRunner._cleanup): Deleted.
1934         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1935         (BrowserDriver.close_browsers):
1936         (BrowserDriver):
1937         (BrowserDriver.restore_env):
1938         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1939         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
1940
1941 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1942
1943         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
1944         https://bugs.webkit.org/show_bug.cgi?id=146414
1945
1946         Reviewed by Darin Adler.
1947
1948         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1949         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
1950
1951 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1952
1953         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
1954         https://bugs.webkit.org/show_bug.cgi?id=147727
1955
1956         Reviewed by Sergio Villar Senin.
1957
1958         I think it was not this test in particular, but
1959         /webkit2/WebKitWebView/custom-charset that is affecting the
1960         others. This is because changing the encoding reloads the page,
1961         but we don't wait for the page to be reloaded, so when the test
1962         finishes and other test starts the web process is still reloading
1963         the page.
1964
1965         * Scripts/run-gtk-tests:
1966         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
1967         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1968         (testWebViewCustomCharset): Wait until page is reloaded after
1969         changing the charset.
1970
1971 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1972
1973         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
1974
1975         It's timing out in the bots. My guess is that there's no installer
1976         installed in the bots and gst_install_plugins_supported() returns
1977         false, so we don't even get a permission request because no
1978         installer will be launched.
1979
1980         * Scripts/run-gtk-tests:
1981         (TestRunner):
1982
1983 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1984
1985         [GTK] Another build fix after r188157.
1986
1987         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1988         (WTR::PlatformWebView::viewSupportsOptions):
1989         Name all the things correctly!
1990
1991 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1992
1993         [EFL, GTK] Build fix after r188176.
1994
1995         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1996         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
1997
1998 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1999
2000         [GTK] Speculative build fix after r188157.
2001
2002         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2003         (WTR::PlatformWebView::PlatformWebView):
2004         Update parameter list.
2005
2006 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2007
2008         Build more testing binaries with CMake on Windows
2009         https://bugs.webkit.org/show_bug.cgi?id=147799
2010
2011         Reviewed by Brent Fulgham.
2012
2013         * DumpRenderTree/CMakeLists.txt:
2014         Build TestNetscapePlugin.
2015         * DumpRenderTree/PlatformWin.cmake:
2016         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
2017         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
2018         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
2019         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
2020         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
2021         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
2022         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
2023         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
2024         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
2025
2026 2015-08-07  Jason Marcell  <jmarcell@apple.com>
2027
2028         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
2029         https://bugs.webkit.org/show_bug.cgi?id=147667
2030
2031         Reviewed by Daniel Bates.
2032
2033         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2034         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
2035         other than "openSource" and "internal".
2036         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2038         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
2039         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2041         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2042         (sortedPlatforms): Deleted.
2043         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2044         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2045         (sortedPlatforms): Deleted.
2046         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2047         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
2048         and sorts them by this property returning the new sorted array.
2049
2050 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
2051
2052         Lightweight locks should be adaptive
2053         https://bugs.webkit.org/show_bug.cgi?id=147545
2054
2055         Reviewed by Geoffrey Garen.
2056
2057         * TestWebKitAPI/CMakeLists.txt:
2058         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2060         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
2061         (TestWebKitAPI::runLockTest):
2062         (TestWebKitAPI::TEST):
2063
2064 2015-08-07  Anders Carlsson  <andersca@apple.com>
2065
2066         Fix a tyop.
2067
2068         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2069         (WTR::PlatformWebView::viewSupportsOptions):
2070
2071 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
2072
2073         Update AppEngine app version numbers to the latest commit.
2074
2075         * QueueStatusServer/app.yaml:
2076         * TestResultServer/app.yaml:
2077
2078 2015-08-07  Anders Carlsson  <andersca@apple.com>
2079
2080         Simplify WKTR's view options
2081         https://bugs.webkit.org/show_bug.cgi?id=147791
2082
2083         Reviewed by Sam Weinig.
2084
2085         Instead of using a WKDictionaryRef, just use a struct for the options.
2086
2087         * WebKitTestRunner/PlatformWebView.h:
2088         (WTR::PlatformWebView::options):
2089         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2090         * WebKitTestRunner/TestController.cpp:
2091         (WTR::TestController::initialize):
2092         (WTR::TestController::createWebViewWithOptions):
2093         (WTR::TestController::ensureViewSupportsOptions):
2094         (WTR::TestController::updateLayoutTypeForTest):
2095         * WebKitTestRunner/TestController.h:
2096         * WebKitTestRunner/ViewOptions.h: Added.
2097         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2098         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2099         (WTR::PlatformWebView::PlatformWebView):
2100         (WTR::PlatformWebView::viewSupportsOptions):
2101         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2102         (WTR::PlatformWebView::viewSupportsOptions):
2103         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2104         (WTR::PlatformWebView::viewSupportsOptions):
2105         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2106         (WTR::PlatformWebView::PlatformWebView):
2107         (WTR::PlatformWebView::viewSupportsOptions):
2108         * WebKitTestRunner/mac/TestControllerMac.mm:
2109         (WTR::TestController::platformConfigureViewForTest):
2110
2111 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
2112
2113         Running tests for a long time results in some tests running very slowly (throttling)
2114         https://bugs.webkit.org/show_bug.cgi?id=147718
2115
2116         Reviewed by Chris Dumez.
2117
2118         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
2119         Although COCOA ports default this setting to be disabled in WebKit1,
2120         we should make both test harnesses disable the setting for consistency.
2121
2122         * DumpRenderTree/mac/DumpRenderTree.mm:
2123         (resetWebPreferencesToConsistentValues):
2124
2125 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2126
2127         Use a specific version of Speedometer in run-benchmark
2128         https://bugs.webkit.org/show_bug.cgi?id=147769
2129
2130         Reviewed by Chris Dumez.
2131
2132         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
2133
2134         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2135
2136 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2137
2138         twisted_http_server.py should support --port
2139         https://bugs.webkit.org/show_bug.cgi?id=147771
2140
2141         Reviewed by Chris Dumez.
2142
2143         Added the option. This makes the script more useful on its own.
2144
2145         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2146
2147 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2148
2149         [GTK] WTF unit tests are timing out in the bots
2150         https://bugs.webkit.org/show_bug.cgi?id=147777
2151
2152         Reviewed by Filip Pizlo.
2153
2154         Add a way to mark google unit tests as slow and add
2155         WTF_Lock.ContentedShortSection to the list. In case of slow test
2156         we use the double of the given timeout for that particular test.
2157
2158         * Scripts/run-gtk-tests:
2159         (TestRunner):
2160         (TestRunner._run_google_test):
2161
2162 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2163
2164         [GTK] run-gtk-tests should not stop when a google test case fails
2165         https://bugs.webkit.org/show_bug.cgi?id=147778
2166
2167         Reviewed by Philippe Normand.
2168
2169         For glib based tests we run the test runner with the -k option,
2170         but for google tests we are aborting as soon as we find a failure.
2171
2172         * Scripts/run-gtk-tests:
2173         (TestRunner._run_google_test_suite): Use a global return code that
2174         is set to 1 when any test has failed.
2175
2176 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2177
2178         [GStreamer] Do not automatically show PackageKit codec installation notifications
2179         https://bugs.webkit.org/show_bug.cgi?id=135973
2180
2181         Reviewed by Philippe Normand.
2182
2183         Handle the missing media plugins installation permission request
2184         in MiniBrowser and add a test case for the new API.
2185
2186         * MiniBrowser/gtk/BrowserWindow.c:
2187         (webViewDecidePermissionRequest):
2188         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2189         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2190         (permissionRequestCallback):
2191         (testInstallMissingPluginsPermissionRequest):
2192         (beforeAll):
2193         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2194         (methodCallCallback):
2195
2196 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
2197
2198         Running tests for a long time results in some tests running very slowly (throttling)
2199         https://bugs.webkit.org/show_bug.cgi?id=147718
2200
2201         Reviewed by Alexey Proskuryakov.
2202
2203         * WebKitTestRunner/TestController.cpp:
2204         (WTR::TestController::resetPreferencesToConsistentValues):
2205         Ensure throttling settings are disabled for tests for all ports, as
2206         COCOA ports default to having these setting enabled. Note, there is
2207         still other timer throttling not covered by these setting.
2208
2209 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2210
2211         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
2212         https://bugs.webkit.org/show_bug.cgi?id=147752
2213
2214         Reviewed by Chris Dumez.
2215
2216         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
2217
2218         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
2219         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
2220
2221         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
2222         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
2223         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
2224         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
2225         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
2226         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2227         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
2228         HTTPServerDriverFactory taking the platform name as an argument.
2229         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
2230         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
2231         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
2232         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2233         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
2234         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
2235         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
2236         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2237         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
2238         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
2239         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
2240         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
2241         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2242         (HTTPServerDriver): Replaced name by platforms.
2243         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2244         (SimpleHTTPServerDriver): Ditto.
2245         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2246         (parse_args): Removed --http-server-driver option.
2247         (start): Ditto.
2248
2249 2015-08-06  Chris Dumez  <cdumez@apple.com>
2250
2251         Toggle GPS state based on page visibility to save battery
2252         https://bugs.webkit.org/show_bug.cgi?id=147685
2253
2254         Reviewed by Benjamin Poulain.
2255
2256         Add testRunner.isGeolocationProviderActive() test support function.
2257
2258         * DumpRenderTree/TestRunner.cpp:
2259         (isGeolocationProviderActiveCallback):
2260         (TestRunner::staticFunctions):
2261         * DumpRenderTree/TestRunner.h:
2262         * DumpRenderTree/mac/MockGeolocationProvider.h:
2263         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2264         (-[MockGeolocationProvider isActive]):
2265         * DumpRenderTree/mac/TestRunnerMac.mm:
2266         (TestRunner::isGeolocationProviderActive):
2267         * DumpRenderTree/win/TestRunnerWin.cpp:
2268         (TestRunner::isGeolocationProviderActive):
2269         * WebKitTestRunner/GeolocationProviderMock.h:
2270         (WTR::GeolocationProviderMock::isActive):
2271         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2272         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2273         (WTR::InjectedBundle::isGeolocationProviderActive):
2274         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2275         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2276         (WTR::TestRunner::isGeolocationProviderActive):
2277         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2278         * WebKitTestRunner/TestController.cpp:
2279         (WTR::TestController::isGeolocationProviderActive):
2280         * WebKitTestRunner/TestController.h:
2281         * WebKitTestRunner/TestInvocation.cpp:
2282         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2283
2284 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2285
2286         Automate JSBench with run-benchmark
2287         https://bugs.webkit.org/show_bug.cgi?id=147716
2288
2289         Reviewed by Chris Dumez.
2290
2291         Added JSBench plan to run-benchmark.
2292
2293         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2294         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
2295         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
2296         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
2297         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
2298         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
2299         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
2300         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
2301         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
2302         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
2303         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
2304         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2305         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
2306         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
2307         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
2308         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2309
2310 2015-08-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2311
2312         Pass-through the undefined options in run-jsc
2313         https://bugs.webkit.org/show_bug.cgi?id=147717
2314
2315         Undefined options in run-jsc is just passed to the actual jsc shell.
2316         We can execute `Tools/Scripts/run-jsc -d`.
2317
2318         Reviewed by Csaba Osztrogonác.
2319
2320         * Scripts/run-jsc:
2321
2322 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2323
2324         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
2325
2326         It's flaky.
2327
2328         * Scripts/run-gtk-tests:
2329         (TestRunner):
2330
2331 2015-08-06  Csaba Osztrogonác  <ossy@webkit.org>
2332
2333         [EFL] Bump EFL version to 1.15.0
2334         https://bugs.webkit.org/show_bug.cgi?id=147450
2335
2336         Reviewed by Gyuyoung Kim.
2337
2338         * efl/jhbuild.modules:
2339
2340 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2341
2342         Unreviewed. Unksip TestContextMenu GTK+ API test.
2343
2344         This has been skipped for a long time, and it's very
2345         unconvenient. It has never failed for me locally, so let's try
2346         again to see if it works in the bots. I'll skip it again if it
2347         keeps failing.
2348
2349         * Scripts/run-gtk-tests:
2350         (TestRunner):
2351
2352 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
2353
2354         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
2355
2356         * DumpRenderTree/JavaScriptThreading.cpp:
2357         (javaScriptThreadsMutex):
2358         (runJavaScriptThread):
2359         (startJavaScriptThreads):
2360         (stopJavaScriptThreads):
2361         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2362         (TestWebKitAPI::TEST):
2363         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2364         (TestWebKitAPI::TEST):
2365
2366 2015-08-05  Alex Christensen  <achristensen@webkit.org>
2367
2368         Build DumpRenderTree with CMake.
2369         https://bugs.webkit.org/show_bug.cgi?id=147519
2370
2371         Reviewed by Brent Fulgham.
2372
2373         * CMakeLists.txt:
2374         Build the DumpRenderTree directory now that it builds successfully.
2375         * DumpRenderTree/CMakeLists.txt:
2376         Added missing source file and don't link with WebCore.lib.
2377         * DumpRenderTree/PlatformWin.cmake:
2378         Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp. 
2379         * WinLauncher/CMakeLists.txt:
2380         We need libcmt now that we are not linking with WebCore.lib.
2381
2382 2015-08-05  Alexey Proskuryakov  <ap@apple.com>
2383
2384         AppScale: Use https URLs for subresources and links
2385         https://bugs.webkit.org/show_bug.cgi?id=147686
2386
2387         Reviewed by Ryosuke Niwa.
2388
2389         * QueueStatusServer/filters/webkit_extras.py:
2390         * TestResultServer/static-dashboards/dashboard_base.js:
2391         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2392         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2393         * TestResultServer/static-dashboards/treemap.js:
2394         * TestResultServer/static-dashboards/ui.js:
2395
2396 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
2397
2398         Rename Mutex to DeprecatedMutex
2399         https://bugs.webkit.org/show_bug.cgi?id=147675
2400
2401         Reviewed by Geoffrey Garen.
2402
2403         * DumpRenderTree/JavaScriptThreading.cpp:
2404         (javaScriptThreadsMutex):
2405         (runJavaScriptThread):
2406         (startJavaScriptThreads):
2407         (stopJavaScriptThreads):
2408         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2409         (TestWebKitAPI::TEST):
2410         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2411         (TestWebKitAPI::TEST):
2412
2413 2015-08-05  Timothy Hatcher  <timothy@apple.com>
2414
2415         Update the WebKit nightly icon
2416         https://bugs.webkit.org/show_bug.cgi?id=147684
2417
2418         Reviewed by Sam Weinig.
2419
2420         * WebKitLauncher/webkit.icns: Replaced.
2421
2422 2015-08-05  Daniel Bates  <dabates@apple.com>
2423
2424         REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
2425         https://bugs.webkit.org/show_bug.cgi?id=147678
2426         <rdar://problem/21827815>
2427
2428         Reviewed by Brady Eidson.
2429
2430         Add a test to ensure that we restore the "should open external URLs" policy on
2431         page reload after the web content process crashes.
2432
2433         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2434         * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
2435         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2436         (TEST):
2437
2438 2015-08-04  Hunseop Jeong  <hs85.jeong@samsung.com>
2439
2440         [EFL] Editing tests have been broken since r186694
2441         https://bugs.webkit.org/show_bug.cgi?id=146888
2442
2443         Reviewed by Brent Fulgham.
2444
2445         Restored some codes for the context click on GTK+ and EFL port.
2446
2447         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2448         (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
2449
2450 2015-08-04  Dewei Zhu  <dewei_zhu@apple.com>
2451
2452         Install twisted package for http server when necessary.
2453         https://bugs.webkit.org/show_bug.cgi?id=147082
2454
2455         Reviewed by Ryosuke Niwa.
2456
2457         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2458         * Scripts/webkitpy/thirdparty/__init__.py:
2459         (AutoinstallImportHook.find_module):
2460         (AutoinstallImportHook._install_twisted):
2461
2462 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2463
2464         [Win] Update Apple Windows build for VS2015
2465         https://bugs.webkit.org/show_bug.cgi?id=147653
2466
2467         Reviewed by Dean Jackson.
2468
2469         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with
2470         something older than VS2015, define snprintf as _snprintf.
2471         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2472         Remove unneeded macro definition for snprintf.
2473         * Scripts/webkitpy/common/system/platforminfo.py:
2474         (PlatformInfo._determine_win_version): Recognize Windows 10.
2475         * Scripts/webkitpy/port/win.py:
2476         (WinPort): Ditto.
2477         * Scripts/webkitpy/port/win_unittest.py:
2478         (WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
2479         (WinPortTest._assert_version): Ditto.
2480
2481 2015-08-04  Brian Burg  <bburg@apple.com>
2482
2483         Unreviewed, update email addresses in contributors.json and watchlist.
2484
2485         * Scripts/webkitpy/common/config/contributors.json:
2486         * Scripts/webkitpy/common/config/watchlist:
2487
2488 2015-08-04  Alexey Proskuryakov  <ap@apple.com>
2489
2490         Implement NPAPI redirect handling
2491         https://bugs.webkit.org/show_bug.cgi?id=138675
2492         rdar://problem/15779101
2493
2494         Patch by Jeffrey Pfau, updated and tweaked by me.
2495
2496         Reviewed by Anders Carlsson.
2497
2498         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2499         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2500         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2501         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2502         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2503         (PluginTest::NPP_URLNotify):
2504         (PluginTest::NPP_URLRedirectNotify):
2505         (PluginTest::NPP_GetValue):
2506         (PluginTest::NPN_GetURLNotify):
2507         (PluginTest::NPN_PostURLNotify):
2508         (PluginTest::NPN_GetValue):
2509         (PluginTest::NPN_ReleaseVariantValue):
2510         (PluginTest::NPN_URLRedirectResponse):
2511         (PluginTest::NPN_ConvertPoint):
2512         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2513         * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.
2514         (URLRedirect::URLRedirect):
2515         (URLRedirect::ScriptableObject::hasMethod):
2516         (URLRedirect::ScriptableObject::get):
2517         (URLRedirect::ScriptableObject::serviceAsync):
2518         (URLRedirect::ScriptableObject::invoke):
2519         (URLRedirect::NPP_GetValue):
2520         (URLRedirect::NPP_URLNotify):
2521         (URLRedirect::NPP_URLRedirectNotify):
2522         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2523         (NP_GetEntryPoints):
2524         (NPP_URLNotify):
2525         (NPP_URLRedirectNotify):
2526         (NPP_GetValue):
2527
2528 2015-08-04  Tim Horton  <timothy_horton@apple.com>
2529
2530         Move Matt Daiter to committers.
2531
2532         * Scripts/webkitpy/common/config/contributors.json:
2533
2534 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2535
2536         [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
2537         https://bugs.webkit.org/show_bug.cgi?id=147636
2538
2539         Reviewed by Alex Christensen.
2540         
2541         We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
2542         Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
2543         on EWS machines)
2544
2545         * Scripts/build-webkit:
2546
2547 2015-08-04  Jason Marcell  <jmarcell@apple.com>
2548
2549         Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
2550         https://bugs.webkit.org/show_bug.cgi?id=147280
2551
2552         Reviewed by Daniel Bates.
2553
2554         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2555         (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
2556         Refactored _parseData to handle repositories more generically.
2557         (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.
2558         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2559         (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
2560         "opensourceRevision" and "internalRevision".
2561         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2563         (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
2564         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2565         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
2566         parameter to more generic "repository" string parameter. Added "trac" parameter in order to
2567         specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
2568         and "internalRevision".
2569         (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
2570         instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
2571         "opensourceRevision" and "internalRevision".
2572         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding
2573         constants for internal and opensource repositories.
2574         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2575         (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
2576         instead of "opensourceRevision" and "internalRevision".
2577         (Analyzer.prototype._countPercentageOfGreen): Ditto.
2578         (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
2579         (Analyzer.prototype._countTimes): Ditto.
2580         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2581         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.
2582
2583 2015-08-04  Mark Lam  <mark.lam@apple.com>
2584
2585         Removed a local debugging line I accidentally left in from a previous commit.
2586
2587         Not Reviewed.
2588
2589         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2590
2591 2015-08-04  Mark Lam  <mark.lam@apple.com>
2592
2593         Unreviewed. Make Saam Barati a WebKit reviewer.
2594
2595         * Scripts/webkitpy/common/config/contributors.json:
2596
2597 2015-08-04  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2598
2599         Unreviewed, updated Streams API watchlist.
2600
2601         * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
2602
2603 2015-08-03  Csaba Osztrogonác  <ossy@webkit.org>
2604
2605         [CMake] Add an option to build AllInOne files
2606         https://bugs.webkit.org/show_bug.cgi?id=102647
2607
2608         Reviewed by Alex Christensen.
2609
2610         * Scripts/webkitperl/FeatureList.pm:
2611
2612 2015-08-03  Alexey Proskuryakov  <ap@apple.com>
2613
2614         AppScale: Add required indices
2615         https://bugs.webkit.org/show_bug.cgi?id=147593
2616
2617         Reviewed by Tim Horton.
2618
2619         * QueueStatusServer/index.yaml:
2620
2621 2015-08-03  Filip Pizlo  <fpizlo@apple.com>
2622
2623         Check in LLVM 3.6.2 binary drops for El Capitan
2624         https://bugs.webkit.org/show_bug.cgi?id=147582
2625
2626         Reviewed by Alexey Proskuryakov.
2627         
2628         Recognize 10.11 and use the right drops.
2629
2630         * Scripts/copy-webkitlibraries-to-product-directory:
2631
2632 2015-08-03  Alex Christensen  <achristensen@webkit.org>
2633
2634         [Win] Build fix after r187733.
2635
2636         * WinLauncher/PageLoadTestClient.cpp:
2637         (PageLoadTestClient::dumpRunStatistics):
2638         wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.
2639
2640 2015-08-02  Benjamin Poulain  <bpoulain@apple.com>
2641
2642         Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
2643         https://bugs.webkit.org/show_bug.cgi?id=118455
2644
2645         Reviewed by Filip Pizlo.
2646
2647         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2648         (TestWebKitAPI::TEST):
2649
2650 2015-07-31  Alex Christensen  <achristensen@webkit.org>
2651
2652         Prepare for VS2015
2653         https://bugs.webkit.org/show_bug.cgi?id=146579
2654
2655         Reviewed by Jon Honeycutt.
2656
2657         * WinLauncher/stdafx.h:
2658         Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
2659
2660 2015-07-31  Csaba Osztrogonác  <ossy@webkit.org>
2661
2662         [EFL] Fix pixman build on ARM with GCC 4.9.3
2663         https://bugs.webkit.org/show_bug.cgi?id=147224
2664
2665         Reviewed by Gyuyoung Kim.
2666
2667         * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
2668
2669 2015-07-30  Anders Carlsson  <andersca@apple.com>
2670
2671         Add support for window.open to WK1BrowserWindowController
2672         https://bugs.webkit.org/show_bug.cgi?id=147474
2673
2674         Reviewed by Dan Bernstein.
2675
2676         * MiniBrowser/mac/WK1BrowserWindowController.m:
2677         (-[WK1BrowserWindowController awakeFromNib]):
2678         Set javaScriptCanOpenWindowsAutomatically to YES. 
2679         If this becomes a nuisance, we can always add a menu item to toggle this.
2680
2681         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2682         Implement this UI delegate method.
2683
2684 2015-07-30  Anders Carlsson  <andersca@apple.com>
2685
2686         Undo stray commit.
2687
2688         * MiniBrowser/mac/WK1BrowserWindowController.m:
2689         (-[WK1BrowserWindowController awakeFromNib]):
2690         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2691
2692 2015-07-29  Dean Jackson  <dino@apple.com>
2693
2694         Don't use (Details) when exposing SPI
2695         https://bugs.webkit.org/show_bug.cgi?id=147426
2696         <rdar://problem/22062407>
2697
2698         Reviewed by Dan Bernstein.
2699
2700         If we are declaring the interface without any implementation,
2701         we should use class extensions.
2702
2703         * DumpRenderTree/mac/DumpRenderTree.mm:
2704         * DumpRenderTree/mac/EventSendingController.mm:
2705         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2706         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2707         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2708         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2709         * WebKitTestRunner/mac/TestControllerMac.mm:
2710
2711 2015-07-30  Aakash Jain  <aakash_jain@apple.com>
2712
2713         Replace Google App Engine with AppScale
2714         https://bugs.webkit.org/show_bug.cgi?id=147178
2715
2716         Reviewed by Daniel Bates.
2717
2718         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2719         (RunWebKitTests):
2720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2725         (.):
2726         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2727         (BubbleQueueServer):
2728         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
2729         (TestHistory):
2730         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2731         * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
2732         * TestResultServer/app.yaml: Ditto
2733         * Scripts/webkitpy/common/config/urls.py:
2734         * TestResultServer/main.py:
2735         * TestResultServer/static-dashboards/dashboard_base.js:
2736         * TestResultServer/static-dashboards/loader.js:
2737
2738 2015-07-30  Joonghun Park  <jh718.park@samsung.com>
2739
2740         [EFL] Enable IndexedDB based on DatabaseProcess
2741         https://bugs.webkit.org/show_bug.cgi?id=147221
2742
2743         Reviewed by Csaba Osztrogonác.
2744
2745         * Scripts/webkitperl/FeatureList.pm:
2746
2747 2015-07-30  Alex Christensen  <achristensen@webkit.org>
2748
2749         Build AppleWin port with CMake
2750         https://bugs.webkit.org/show_bug.cgi?id=147385
2751
2752         Reviewed by Martin Robinson.
2753
2754         * WinLauncher/CMakeLists.txt:
2755         Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
2756
2757 2015-07-29  Andy VanWagoner  <thetalecrafter@gmail.com>
2758
2759         Implement basic types for ECMAScript Internationalization API
2760         https://bugs.webkit.org/show_bug.cgi?id=146926
2761
2762         Reviewed by Benjamin Poulain.
2763
2764         Enable flag now that the basic objects are in place.
2765
2766         * Scripts/webkitperl/FeatureList.pm: Enabled INTL
2767
2768 2015-07-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2769
2770         [GTK] Add API to set the maximum number of web processes per WebKitWebContext
2771         https://bugs.webkit.org/show_bug.cgi?id=147108
2772
2773         Reviewed by Gustavo Noronha Silva.
2774
2775         Add test case to check the web process limit.
2776
2777         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2778         (testWebProcessLimit):
2779         (beforeAll):
2780
2781 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2782
2783         [GTK] Missing casts in BrowserWindow.c
2784         https://bugs.webkit.org/show_bug.cgi?id=147395
2785
2786         Reviewed by Carlos Garcia Campos.
2787
2788         * MiniBrowser/gtk/BrowserWindow.c:
2789         (browserWindowSetupEditorToolbar):
2790
2791 2015-07-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2792
2793         [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false"
2794         https://bugs.webkit.org/show_bug.cgi?id=147350
2795
2796         Reviewed by Sam Weinig.
2797
2798         * Scripts/webkitperl/FeatureList.pm:
2799
2800 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2801
2802         [Freetype] Always allow font matching for strong aliases
2803         https://bugs.webkit.org/show_bug.cgi?id=147057
2804
2805         Reviewed by Martin Robinson.
2806
2807         Create family aliases needed for the new layout tests.
2808
2809         * WebKitTestRunner/gtk/fonts/fonts.conf:
2810
2811 2015-07-28  Alexey Proskuryakov  <ap@apple.com>
2812
2813         webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
2814         https://bugs.webkit.org/show_bug.cgi?id=147359
2815
2816         Reviewed by Ryosuke Niwa.
2817
2818         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2819         (NewCommitBot.begin_work_queue):
2820         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2821         (SheriffBot.begin_work_queue):
2822
2823 2015-07-27  Alex Christensen  <achristensen@webkit.org>
2824
2825         Use Ninja on Windows.
2826         https://bugs.webkit.org/show_bug.cgi?id=147228
2827
2828         Reviewed by Martin Robinson.
2829
2830         * WinLauncher/CMakeLists.txt:
2831         WinLauncherLib must make WinLauncher.dll, not WinLauncherLib.dll.
2832         * Scripts/build-webkit:
2833         Use Ninja to build WinCairo by default, but fall back to Visual Studio if Ninja is not on the system.
2834
2835 2015-07-24  Jon Honeycutt  <jhoneycutt@apple.com>
2836
2837         Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't
2838         highlight after being tapped to style a selection"
2839         https://bugs.webkit.org/show_bug.cgi?id=147278
2840
2841         Reviewed by Ryosuke Niwa.
2842
2843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2844
2845         * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added.
2846         (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]):
2847         (TestWebKitAPI::TEST):
2848         Load a page with the string "Hello, world!", then select "world" and
2849         underline it. Test that the typing attributes for the current selection
2850         include the underline attribute.
2851
2852 2015-07-24  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2853
2854         Unreviewed, updated my nick name in contributors.json
2855
2856         * Scripts/webkitpy/common/config/contributors.json:
2857
2858 2015-07-24  Chris Fleizach  <cfleizach@apple.com>
2859
2860         AX: scrollable elements do not allow 3-finger swipe
2861         https://bugs.webkit.org/show_bug.cgi?id=141893
2862
2863         Reviewed by Mario Sanchez Prada.
2864
2865         Support global notification listeners for iOS code.
2866         Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
2867         Implement scrollUp/Down/Left/Right.
2868
2869         * DumpRenderTree/AccessibilityController.h:
2870         * DumpRenderTree/AccessibilityUIElement.cpp:
2871         (increaseTextSelectionCallback):
2872         (scrollPageUpCallback):
2873         (scrollPageDownCallback):
2874         (scrollPageLeftCallback):
2875         (scrollPageRightCallback):
2876         (decreaseTextSelectionCallback):
2877         (getElementTextLengthCallback):
2878         (AccessibilityUIElement::getJSClass):
2879         * DumpRenderTree/AccessibilityUIElement.h:
2880         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2881         (AccessibilityController::~AccessibilityController):
2882         (AccessibilityController::elementAtPoint):
2883         (AccessibilityController::addNotificationListener):
2884         (AccessibilityController::platformResetToConsistentState):
2885         (AccessibilityController::removeNotificationListener):
2886         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2887         (AccessibilityUIElement::AccessibilityUIElement):
2888         (AccessibilityUIElement::subrole):
2889         (AccessibilityUIElement::scrollPageUp):
2890         (AccessibilityUIElement::scrollPageDown):
2891         (AccessibilityUIElement::scrollPageLeft):
2892         (AccessibilityUIElement::scrollPageRight):
2893         (AccessibilityUIElement::roleDescription):
2894         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2895         (-[AccessibilityNotificationHandler _notificationReceived:]):
2896         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2897         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2898         (WTR::AccessibilityUIElement::linkedElement):
2899         (WTR::AccessibilityUIElement::headerElementAtIndex):
2900         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2901         (WTR::AccessibilityUIElement::scrollPageUp):
2902         (WTR::AccessibilityUIElement::scrollPageDown):
2903         (WTR::AccessibilityUIElement::scrollPageLeft):
2904         (WTR::AccessibilityUIElement::scrollPageRight):
2905         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2906         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2907         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2908         (WTR::AccessibilityController::addNotificationListener):
2909         (WTR::AccessibilityController::removeNotificationListener):
2910         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2911         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2912         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2913         (WTR::AccessibilityUIElement::scrollPageUp):
2914         (WTR::AccessibilityUIElement::scrollPageDown):
2915         (WTR::AccessibilityUIElement::scrollPageLeft):
2916         (WTR::AccessibilityUIElement::scrollPageRight):
2917         (WTR::AccessibilityUIElement::increaseTextSelection):
2918
2919 2015-07-24  Brent Fulgham  <bfulgham@apple.com>
2920
2921         [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
2922         https://bugs.webkit.org/show_bug.cgi?id=147279
2923         <rdar://problem/21990767>
2924
2925         Reviewed by Dean Jackson.
2926
2927         * DumpRenderTree/win/TestRunnerWin.cpp:
2928         (TestRunner::addUserScript):
2929         (TestRunner::addUserStyleSheet):
2930         (TestRunner::setDeveloperExtrasEnabled):
2931
2932 2015-07-24  Basile Clement  <basile_clement@apple.com>
2933
2934         Call fixChangeLogPatch when generating patches from webkit-patch
2935         https://bugs.webkit.org/show_bug.cgi?id=147248
2936
2937         Reviewed by Geoffrey Garen.
2938
2939         When two consecutive patches are from the same author, diff tools
2940         create wrong-looking diffs for ChangeLog files where the apparent added
2941         author is actually the previous patch's author line, making it awkward
2942         to read - and things only get worse when committing a patch and a
2943         followup fix for the same bug shortly after.
2944
2945         We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
2946         this, which we use in perl scripts (svn-create-patch et al). But it is
2947         not used by webkit-patch, which is a python script, and thus creates
2948         "bad" diffs.
2949
2950         In the long term, we should probably port fixChangeLogPatch to python -
2951         but in the short term, let's make webkit-patch call perl to run
2952         fixChangeLogPatch. We are already making various external calls there
2953         anyway.
2954
2955         * Scripts/webkitpy/common/checkout/scm/git.py:
2956         (Git.create_patch):
2957         * Scripts/webkitpy/common/checkout/scm/scm.py:
2958         (SCM.fix_changelog_patch):
2959         * Scripts/webkitpy/common/checkout/scm/svn.py:
2960         (SVN.create_patch):
2961
2962 2015-07-24  Dean Johnson  <dean_johnson@apple.com>
2963
2964         commit-queue flags in webkit-patch are confusing
2965         https://bugs.webkit.org/show_bug.cgi?id=88694
2966
2967         Reviewed by Csaba Osztrogonác.
2968
2969         * Scripts/webkitpy/tool/steps/options.py:
2970         (Options): Updated help string to be more descriptive.
2971
2972 2015-07-23  Brent Fulgham  <bfulgham@apple.com>
2973
2974         [Win] Implement proper High DPI support features
2975         https://bugs.webkit.org/show_bug.cgi?id=146335
2976         <rdar://problem/21558269>
2977
2978         Reviewed by Alex Christensen.
2979
2980         Update WinLauncher to take device scaling factor into account.
2981
2982         * WinLauncher/Common.cpp:
2983         (resizeSubViews): Make sure toolbars and URL bar are properly sized and using
2984         a valid font.
2985         (computeFullDesktopFrame): Handle high DPI desktops.
2986         (WndProc): Make comments more precise.
2987         * WinLauncher/WinLauncher.cpp:
2988         (WinLauncher::init): Determine device scale factor at launch.
2989         (WinLauncher::updateDeviceScaleFactor): Added.
2990         * WinLauncher/WinLauncher.h:
2991         * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
2992         * WinLauncher/WinMain.cpp: Size interface based on scaling factor.
2993         (wWinMain): Ditto.
2994         * win/DLLLauncher/DLLLauncherMain.cpp:
2995         (wWinMain): Tell Windows we understand high DPI.
2996
2997 2015-07-23  Alex Christensen  <achristensen@webkit.org>
2998
2999         [Win] Unreviewed build fix after r187169.
3000
3001         * Scripts/build-webkit:
3002         Correctly find WebKit.sln.
3003
3004 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3005
3006         [GTK] Add API to allow executing editing commands that require an argument
3007         https://bugs.webkit.org/show_bug.cgi?id=146781
3008
3009         Reviewed by Gustavo Noronha Silva.
3010
3011         Add buttons to insert image/link to the MiniBrowser edit toolbar,
3012         and test cases for insert image/link commands too.
3013
3014         * MiniBrowser/gtk/BrowserWindow.c:
3015         (insertImageCommandCallback):
3016         (insertLinkCommandCallback):
3017         (browserWindowSetupEditorToolbar):
3018         (browserWindowConstructed):
3019         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3020         (testWebViewEditorInsertImage):
3021         (testWebViewEditorCreateLink):
3022         (beforeAll):
3023
3024 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3025
3026         Unregistering and re-registering a user message handler does not work
3027         https://bugs.webkit.org/show_bug.cgi?id=138142
3028
3029         Reviewed by Martin Robinson.
3030
3031         This has probably been fixed in r184846, enable the test case
3032         blocked on it.
3033
3034         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3035         (testUserContentManagerScriptMessageReceived):
3036
3037 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
3038
3039         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
3040         https://bugs.webkit.org/show_bug.cgi?id=147212
3041
3042         Reviewed by Filip Pizlo.
3043
3044         * Scripts/webkitperl/FeatureList.pm:
3045
3046 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
3047
3048         Add --ios-simulator to run-api-tests --help.
3049
3050         Rubber-stamped by Dan Bates.
3051
3052         * Scripts/run-api-tests:
3053
3054 2015-07-22  Jason Marcell  <jmarcell@apple.com>
3055
3056         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
3057         https://bugs.webkit.org/show_bug.cgi?id=147043
3058
3059         Reviewed by Daniel Bates and Alexey Proskuryakov.
3060
3061         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3062         (Buildbot.prototype._normalizeQueueInfo):
3063         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
3064         in cases where the queue.branch property is not set and the queue is not a combined queue.
3065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3066         (BuildbotCombinedQueueView):
3067         Ensuring uniformity of repository branches within a combined queue.
3068         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3069         (WebKitBuildbot.prototype.get defaultBranches):
3070         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
3071         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
3072         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
3073         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
3074         implement defaultBranches so that a person can either update the definition of the sub-queue or
3075         implement defaultBranches in the derived Buildbot class they are using.
3076
3077 2015-07-22  Alex Christensen  <achristensen@webkit.org>
3078
3079         Switch WinCairo build to use CMake.
3080         https://bugs.webkit.org/show_bug.cgi?id=147169
3081
3082         Reviewed by Brent Fulgham.
3083
3084         * Scripts/build-webkit:
3085         * Scripts/webkitdirs.pm:
3086         (determineConfiguration):
3087         (determineArchitecture):
3088         (determinePassedConfiguration):
3089         (passedConfiguration):
3090         (jhbuildWrapperPrefixIfNeeded):
3091         (generateBuildSystemFromCMakeProject):
3092         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
3093
3094 2015-07-22  Alex Christensen  <achristensen@webkit.org>
3095
3096         Fix quirks in CMake build on Mac and Windows
3097         https://bugs.webkit.org/show_bug.cgi?id=147174
3098
3099         Reviewed by Gyuyoung Kim.
3100
3101         * CMakeLists.txt:
3102         Don't build DumpRenderTree with CMake for now (until we get that working).
3103         * WinLauncher/CMakeLists.txt:
3104         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
3105
3106 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3107
3108         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
3109         https://bugs.webkit.org/show_bug.cgi?id=147146
3110
3111         Reviewed by Darin Adler.
3112
3113         * Scripts/webkitpy/style/checkers/cpp.py:
3114         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
3115         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3116         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
3117
3118 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
3119
3120         Fixed VM pool allocation should have a reserve for allocations that cannot fail
3121         https://bugs.webkit.org/show_bug.cgi?id=147154
3122         rdar://problem/21847618
3123
3124         Reviewed by Geoffrey Garen.
3125         
3126         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
3127         mitigations work, these should all pass. Prior to this patch there were >20 failures.
3128
3129         * Scripts/run-jsc-stress-tests:
3130
3131 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3132
3133         [GTK] Add API to be notified about editor state changes
3134         https://bugs.webkit.org/show_bug.cgi?id=145875
3135
3136         Reviewed by Gustavo Noronha Silva.
3137
3138         Update the typing attributes toggle buttons state according to the
3139         editor state in MiniBrowser, and add a test case to the
3140         WebViewEditor unit tests.
3141
3142         * MiniBrowser/gtk/BrowserWindow.c:
3143         (browserWindowEditingCommandToggleButtonSetActive):
3144         (typingAttributesChanged):
3145         (browserWindowSetupEditorToolbar):
3146         (browserWindowConstructed):
3147         (browser_window_init):
3148         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3149         (testWebViewEditorEditorStateTypingAttributes):
3150         (beforeAll):
3151
3152 2015-07-20  Tomas Popela  <tpopela@redhat.com>
3153
3154         [GTK] Add selection-changed signal to the WebKit2 API
3155         https://bugs.webkit.org/show_bug.cgi?id=137116
3156
3157         Reviewed by Carlos Garcia Campos.
3158
3159         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
3160         (namely the selection-changed signal).
3161
3162         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3163         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
3164         (WebKitWebEditorTest::create):
3165         (WebKitWebEditorTest::selectionChangedCallback):
3166         (WebKitWebEditorTest::testSelectionSelectAll):
3167         (WebKitWebEditorTest::testSelectionCollapse):
3168         (WebKitWebEditorTest::testSelectionModifyMove):
3169         (WebKitWebEditorTest::testSelectionModifyExtend):
3170         (WebKitWebEditorTest::testSelectionUnselect):
3171         (registerTests):
3172         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
3173         (testWebKitWebEditorSelectionChanged):
3174         (beforeAll):
3175         (afterAll):
3176
3177 2015-07-20  Alex Christensen  <achristensen@webkit.org>
3178
3179         Resurrect CMake build on Windows.
3180         https://bugs.webkit.org/show_bug.cgi?id=147083
3181
3182         Reviewed by Gyuyoung Kim.
3183
3184         * DumpRenderTree/CMakeLists.txt:
3185         * DumpRenderTree/PlatformWin.cmake: Added.
3186         * WinLauncher/CMakeLists.txt:
3187
3188 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3189
3190         [GTK] Enable seccomp filter API tests
3191         https://bugs.webkit.org/show_bug.cgi?id=140071
3192
3193         Reviewed by Žan Doberšek.
3194
3195         These tests will now be run by the run-gtk-tests script.
3196
3197         * TestWebKitAPI/PlatformGTK.cmake:
3198
3199 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3200
3201         [GTK] Add seccomp filters support
3202         https://bugs.webkit.org/show_bug.cgi?id=110014
3203
3204         Reviewed by Žan Doberšek.
3205
3206         Add libseccomp to jhbuild modulesets.
3207
3208         * gtk/jhbuild.modules:
3209
3210 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
3211
3212         MiniBrowser window title is just "Window" when page has no <title>
3213         https://bugs.webkit.org/show_bug.cgi?id=147076
3214
3215         Reviewed by Tim Horton.
3216         
3217         Make MiniBrowser windows show the filename from the URL if we never get a title changed
3218         notification.
3219
3220         * MiniBrowser/mac/WK1BrowserWindowController.m:
3221         (-[WK1BrowserWindowController updateTitle:]):
3222         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
3223         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
3224         * MiniBrowser/mac/WK2BrowserWindowController.m:
3225         (-[WK2BrowserWindowController updateTitle:]):
3226         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3227         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3228
3229 2015-07-17  Andy Estes  <aestes@apple.com>
3230
3231         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
3232         https://bugs.webkit.org/show_bug.cgi?id=147044
3233         rdar://problem/21567820
3234
3235         Reviewed by Brady Eidson.
3236
3237         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3238         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
3239         This matches the behavior of DumpRenderTree.
3240
3241 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
3242
3243         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
3244         https://bugs.webkit.org/show_bug.cgi?id=147032
3245
3246         Reviewed by Alex Christensen.
3247
3248         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3249         Test that the useless terms are eliminated by counting
3250         the number of NFA nodes generated.
3251
3252 2015-07-17  Dan Bernstein  <mitz@apple.com>
3253
3254         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
3255         https://bugs.webkit.org/show_bug.cgi?id=147040
3256
3257         Reviewed by Dean Jackson.
3258
3259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3260         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
3261         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
3262         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
3263         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3264         (TEST):
3265
3266 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
3267
3268         webkit-patch uses incorrect credentials from keychain to login until account lockout
3269         https://bugs.webkit.org/show_bug.cgi?id=146923
3270
3271         Reviewed by Daniel Bates.
3272
3273         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
3274         provide incorrect credentials then ask for them to be saved to the keychain
3275         webkit-patch will then use those incorrect credentials until 5 total attempts
3276         have been made to log in. This will lock the user out of Bugzilla for a
3277         half hour.
3278
3279         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3280         (Bugzilla.authenticate): Added argument to read_credentials() that
3281         passes in whether or not to use stored credentials.
3282         * Scripts/webkitpy/common/net/credentials.py:
3283         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
3284         that specifies whether or not to use credentials stored on the system. If it
3285         does, we do not auto-fill credentials since either the credentials caused
3286         the failure, or they weren't used in the first place so there is no reason
3287         to try and use them again if a failure happened.
3288         * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
3289         use_stored_credentials argument.
3290         (test_do_not_use_stored_credentials): Added unit test to make sure functions that
3291         retrieve username/password information from the local system (environment, Git, keychain,
3292         keyring) are never called. It also tests that we get back our mocked username and password.
3293         (test_do_not_use_stored_credentials.MockKeyring): Mock keyring
3294         (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
3295         (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
3296         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
3297         is never called.
3298         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
3299         (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
3300         (test_do_not_use_stored_credentials.FakeUser): Mock the User class
3301         (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
3302         (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
3303         against.
3304
3305 2015-07-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3306
3307         Unreviewed, remove my redundant email information.
3308
3309         * Scripts/webkitpy/common/config/contributors.json:
3310
3311 2015-07-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3312
3313         Unreviewed. Add Hyungwook Lee as a committer.
3314
3315         * Scripts/webkitpy/common/config/contributors.json:
3316
3317 2015-07-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3318
3319         Added myself to the list of contributors.
3320
3321         Reviewed by Brent Fulgham.
3322
3323         * Scripts/webkitpy/common/config/contributors.json:
3324
3325 2015-07-16  Alex Christensen  <achristensen@webkit.org>
3326
3327         [Content Extensions] Cache domain actions
3328         https://bugs.webkit.org/show_bug.cgi?id=146817
3329
3330         Reviewed by Benjamin Poulain.
3331
3332         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3333         (TestWebKitAPI::TEST_F):
3334         Test if-domain and unless-domain with multiple load types.
3335
3336 2015-07-16  Benjamin Poulain  <bpoulain@apple.com>
3337
3338         [Content extensions] Combine suffixes when generating NFAs
3339         https://bugs.webkit.org/show_bug.cgi?id=146961
3340
3341         Reviewed by Alex Christensen.
3342
3343         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3344         (TestWebKitAPI::compareContents):
3345         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3346
3347 2015-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3348
3349         [GTK] Input method filter is always enabled when the view is focused
3350         https://bugs.webkit.org/show_bug.cgi?id=146965
3351
3352         Reviewed by Martin Robinson.
3353
3354         Use setEnabled() instead of notifyFocusedIn() to enable input methods.
3355
3356         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
3357         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
3358
3359 2015-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3360
3361         [EFL] Bump libseccomp version to 2.2.3
3362         https://bugs.webkit.org/show_bug.cgi?id=146980
3363
3364         Reviewed by Gyuyoung Kim.
3365
3366         * efl/jhbuild.modules:
3367
3368 2015-07-15  Brent Fulgham  <bfulgham@apple.com>
3369
3370         [Win] Maintain consistent COM Interfaces
3371         https://bugs.webkit.org/show_bug.cgi?id=146983
3372         <rdar://problem/21822278>
3373
3374         Reviewed by Dean Jackson.
3375
3376         Update DumpRenderTree and WinLauncher to use the properly
3377         versioned COM interface objects.
3378
3379         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3380         (AccessibilityController::rootElement):
3381         * DumpRenderTree/win/DumpRenderTree.cpp:
3382         (resetWebPreferencesToConsistentValues):
3383         (resetWebViewToConsistentStateBeforeTesting):
3384         (runTest):
3385         (createWebViewAndOffscreenWindow):
3386         * DumpRenderTree/win/EditingDelegate.cpp:
3387         (EditingDelegate::QueryInterface):
3388         (EditingDelegate::shouldEndEditingInDOMRange):
3389         (EditingDelegate::shouldInsertNode):
3390         * DumpRenderTree/win/EditingDelegate.h:
3391         * DumpRenderTree/win/EventSender.cpp:
3392         (scalePageByCallback):
3393         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3394         (FrameLoadDelegate::didCommitLoadForFrame):
3395         * DumpRenderTree/win/TestRunnerWin.cpp:
3396         (TestRunner::callShouldCloseOnWebView):
3397         (TestRunner::applicationCacheDiskUsageForOrigin):
3398         (TestRunner::clearApplicationCacheForOrigin):
3399         (TestRunner::setDefersLoading):
3400         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3401         (TestRunner::setTabKeyCyclesThroughElements):
3402         (TestRunner::setValueForUser):
3403         (TestRunner::dispatchPendingLoadRequests):
3404         (TestRunner::setWindowIsKey):
3405         (TestRunner::execCommand):
3406         (TestRunner::addOriginAccessWhitelistEntry):
3407         (TestRunner::removeOriginAccessWhitelistEntry):
3408         (TestRunner::addUserScript):
3409         (TestRunner::addUserStyleSheet):
3410         (TestRunner::showWebInspector):
3411         (TestRunner::closeWebInspector):
3412         (TestRunner::evaluateInWebInspector):
3413         (TestRunner::setSerializeHTTPLoads):
3414         * DumpRenderTree/win/TextInputControllerWin.cpp:
3415         (TextInputController::setMarkedText):
3416         (TextInputController::hasMarkedText):
3417         (TextInputController::unmarkText):
3418         (TextInputController::markedRange):
3419         (TextInputController::insertText):
3420         (TextInputController::firstRectForCharacterRange):
3421         (TextInputController::selectedRange):
3422         * DumpRenderTree/win/UIDelegate.h:
3423         (UIDelegate::unused2):
3424         (UIDelegate::unused3):
3425         (UIDelegate::webViewScrolled):
3426         (UIDelegate::webViewShouldInterruptJavaScript):
3427         (UIDelegate::webViewReceivedFocus):
3428         (UIDelegate::unused4): Deleted.
3429         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3430         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
3431         * WinLauncher/PageLoadTestClient.cpp:
3432         (PageLoadTestClient::didStartProvisionalLoad):
3433         * WinLauncher/WinLauncher.cpp:
3434         (WinLauncher::init):
3435         * WinLauncher/WinLauncher.h:
3436         * WinLauncher/WinLauncherWebHost.cpp:
3437         (WinLauncherWebHost::didFinishLoadForFrame):
3438         (WinLauncherWebHost::didFirstLayoutInFrame):
3439         * WinLauncher/WinLauncherWebHost.h:
3440
3441 2015-07-15  Dean Johnson  <dean_johnson@apple.com>
3442
3443         Many test failures in scm_unittest.py
3444         https://bugs.webkit.org/show_bug.cgi?id=143967
3445
3446         Reviewed by Daniel Bates. 
3447
3448         * Scripts/webkitpy/common/checkout/scm/detection.py:
3449         (SCMDetector.detect_scm_system): Paths with symlinks are now resolved to
3450         absolute canonical file paths. Two mutually exclusive issues cause this
3451         to be a problem.
3452             1) Python's os.path.relpath() function does not return correct relative
3453             paths between two filepaths that point to the same file, if symlinks are
3454             involved.
3455                 On Mac, /tmp points to /private/tmp
3456                 ex. os.path.relpath('/tmp', '/private/tmp')
3457                     returns '../../tmp'
3458             What we want is actually just '.'
3459             2) Git does not allow file paths to trace outside of
3460             the Git repository. This means that if you have a repository in
3461             /tmp and you refer to that repository when invoking a git command as
3462             ../tmp, Git will produce errors about working outside of the repository.
3463         * Scripts/webkitpy/common/checkout/scm/git.py: Over time Git has changed
3464         its default behavior and such, needed to be updated.
3465         (Git.changed_files): '--' was added into the command so that patch_directories
3466         were taken as positional arguments.
3467         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Changed tests and setup 
3468         in the GitSVNTest class to more closely emulate the version of Git that the tests
3469         assumed a system had. Also fixed a small side-effect from the absolute canonical
3470         path fix in SCMDetector.detect_scm_system
3471         (SVNTestRepository.setup): A relative filepath was previously passed as the
3472         checkout root to SCMDetector.detect_scm_system, but is now cleaned to
3473         an absolute canonical path before being passed in. The failing test
3474         was a "sanity check" that the svn.checkout_root and scm.checkout_root
3475         were the same.
3476         (GitSVNTest._setup_git_checkout):
3477             1) Added "--prefix ''" option to `git clone` since Git changed its default
3478             behavior in version 2.0.
3479             2) The branch master was renamed to trunk to more closely emulate what
3480             tests expected when they were written. 
3481         (GitSVNTest.test_changed_files_local_plus_working_copy): Two of the three
3482         original tests failed because the tests expected the trunk branch
3483         to produce its parent's commit, whereas Git merely provides the HEAD commit
3484         for a given branch (trunk in this case). Based on other tests written
3485         in the same commit, it appears these tests were failing from the point they
3486         were written.
3487
3488 2015-07-14  Anders Carlsson  <andersca@apple.com>
3489
3490         Assertions.h should include ExportMacros.h
3491         https://bugs.webkit.org/show_bug.cgi?id=146948
3492
3493         Reviewed by Tim Horton.
3494
3495         Remove now unneeded WTF_EXPORT_PRIVATE define.
3496
3497         * DumpRenderTree/cg/ImageDiffCG.cpp:
3498
3499 2015-07-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3500
3501         [GTK] [Wayland] Build by default the X11 and Wayland targets.
3502         https://bugs.webkit.org/show_bug.cgi?id=146057
3503
3504         Reviewed by Carlos Garcia Campos.
3505
3506         * gtk/install-dependencies:
3507
3508 2015-07-10  Brent Fulgham  <bfulgham@apple.com>
3509
3510         [Mac] Unable to dismiss context menu during test runs
3511         https://bugs.webkit.org/show_bug.cgi?id=146836
3512
3513         Reviewed by Tim Horton.
3514
3515         Since Context Menus are modal, the test system would block on the displayed context menu,
3516         causing tests to fail. Instead, we should do what WK1 was doing, which is to perform the
3517         mouse click and generate the menu contents, but not ask AppKit to display it.
3518
3519         Drive-by fix: We did not handle 'escape' key presses. This is also fixed.
3520
3521         * DumpRenderTree/mac/EventSendingController.mm:
3522         (-[EventSendingController keyDown:withModifiers:withLocation:]): Handle the 'escape' character.
3523         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3524         (WTR::EventSendingController::mouseMoveTo): Keep track of the current mouse position.
3525         (WTR::EventSendingController::contextClick): Don't emit an actual context menu invocation and then
3526         copy the menu items. Instead, use WKBundlePageCopyContentMenuAtPointInWindow to do all the same
3527         work without actually calling on AppKit to display the menu.
3528         ask WebCore to do all the work EXCEPT displaying the menu.
3529         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3530         * WebKitTestRunner/mac/EventSenderProxy.mm:
3531         (WTR::EventSenderProxy::keyDown): Handle the 'escape' character.
3532
3533 2015-07-09  Filip Pizlo  <fpizlo@apple.com>
3534
3535         It should be possible to run the OSR exit fuzzer
3536         https://bugs.webkit.org/show_bug.cgi?id=146814
3537
3538         Reviewed by Mark Lam.
3539         
3540         This runs a test command to detect how many static OSR exit sites it had, and then for
3541         each exit site, it triggers three exits (earliest opportunity, last opportunity, some
3542         middle opportunity), plus a mode where the check always exits. This is an exhaustive
3543         search, so in the future it'll be very appropriate for cases where we have a simple test
3544         and we want to see what happens when you eventually exit in this test.
3545         
3546         Right now this isn't hooked into any specific tests, but I've done some spot checks on it
3547         and it seems to do the right thing.
3548
3549         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz: Added.
3550         (fail):
3551
3552 2015-07-10  Alex Christensen  <achristensen@webkit.org>
3553
3554         Add tests for r186649
3555         https://bugs.webkit.org/show_bug.cgi?id=146821
3556
3557         Reviewed by Darin Adler.
3558
3559         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3560         (TestWebKitAPI::TEST_F):
3561         (TestWebKitAPI::compareContents):
3562         (TestWebKitAPI::expectedIndex):
3563         Add some larger tests to test large jumps.
3564
3565 2015-07-09  Dewei Zhu  <dewei_zhu@apple.com>
3566
3567         Quick fix for run_benchmark script that AppKit.NSRunningApplication does not work properly
3568         https://bugs.webkit.org/show_bug.cgi?id=146820
3569
3570         Reviewed by Ryosuke Niwa.
3571
3572         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3573         (OSXBrowserDriver):
3574         (OSXBrowserDriver.close_browsers):
3575         (OSXBrowserDriver._terminiate_processes):
3576         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3577         (OSXChromeDriver):
3578         (OSXChromeCanaryDriver):
3579         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3580         (OSXFirefoxDriver):
3581         (OSXFirefoxNightlyDriver):
3582         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3583         (OSXSafariDriver):
3584
3585 2015-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3586
3587         [GTK] pango should be included in the default jhbuild moduleset
3588         https://bugs.webkit.org/show_bug.cgi?id=146683
3589
3590         Reviewed by Martin Robinson.
3591
3592         Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when
3593         compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and
3594         fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild
3595         moduleset or else upgrade fontconfig to a recent unstable release (knowing that we will have
3596         the same problem again the next time pango wants to use a new fontconfig feature), or remove
3597         fontconfig (which would make it hard to keep tests working). On the balance, adding pango is
3598         best.
3599
3600         * gtk/jhbuild-optional.modules: Remove pango
3601         * gtk/jhbuild.modules: Add pango and update to latest 1.36.8
3602
3603 2015-07-09  Devin Rousso  <drousso@apple.com>
3604
3605         Unreviewed.  Added myself as a committer.
3606
3607         * Scripts/webkitpy/common/config/contributors.json:
3608
3609 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
3610
3611         Add a way to set the default URL from Minibrowser UI
3612         https://bugs.webkit.org/show_bug.cgi?id=146780
3613
3614         Reviewed by Simon Fraser.
3615
3616         * MiniBrowser/mac/AppDelegate.m:
3617         (-[BrowserAppDelegate didChangeSettings]):
3618         * MiniBrowser/mac/BrowserWindowController.h:
3619         * MiniBrowser/mac/BrowserWindowController.m:
3620         (-[BrowserWindowController fetch:]):
3621         (-[BrowserWindowController reload:]):
3622         (-[BrowserWindowController forceRepaint:]):
3623         (-[BrowserWindowController goBack:]):
3624         (-[BrowserWindowController goForward:]):
3625         (-[BrowserWindowController showHideWebView:]):
3626         (-[BrowserWindowController removeReinsertWebView:]):
3627         (-[BrowserWindowController zoomIn:]):
3628         (-[BrowserWindowController zoomOut:]):
3629         (-[BrowserWindowController resetZoom:]):
3630         (-[BrowserWindowController canZoomIn]):
3631         (-[BrowserWindowController canZoomOut]):
3632         (-[BrowserWindowController canResetZoom]):
3633         (-[BrowserWindowController toggleZoomMode:]):
3634         (-[BrowserWindowController setScale:]):
3635         (-[BrowserWindowController toggleShrinkToFit:]):
3636         (-[BrowserWindowController dumpSourceToConsole:]):
3637         (-[BrowserWindowController find:]):
3638         (-[BrowserWindowController didChangeSettings]):
3639         (-[BrowserWindowController currentURL]):
3640         Get rid of the BrowserController protocol. It was a bad idea and confused
3641         Interface Builder more than I thought possible.
3642
3643         * MiniBrowser/mac/SettingsController.m:
3644         (-[SettingsController _populateMenu]):
3645         (-[SettingsController setDefaultURLToCurrentURL:]):
3646         If we have a BrowserWindowController, grab its URL and set the relevant default.
3647
3648         * MiniBrowser/mac/WK1BrowserWindowController.h:
3649         * MiniBrowser/mac/WK1BrowserWindowController.m:
3650         (-[WK1BrowserWindowController currentURL]):
3651         * MiniBrowser/mac/WK2BrowserWindowController.h:
3652         * MiniBrowser/mac/WK2BrowserWindowController.m:
3653         (-[WK2BrowserWindowController currentURL]):
3654         Retrieve the current URL from the WKView/WebView.
3655
3656 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
3657
3658         Increase MiniBrowser location bar maximum width
3659         https://bugs.webkit.org/show_bug.cgi?id=146779
3660
3661         Reviewed by Simon Fraser.
3662
3663         * MiniBrowser/mac/BrowserWindow.xib:
3664         Have an enormous maximum width on the location bar, so that it doesn't
3665         stop expanding with the window at 800px.
3666
3667 2015-07-08  Brady Eidson  <beidson@apple.com>
3668
3669         Crash calling [WebView close] in didFinishLoadForFrame callback.
3670         <rdar://problem/21690765> and https://bugs.webkit.org/show_bug.cgi?id=146773
3671
3672         Reviewed by David Kilzer.
3673
3674         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3675         
3676         * TestWebKitAPI/Tests/mac/WebViewCloseInsideDidFinishLoadForFrame.mm: Added.
3677         (-[WebViewCloseFrameLoadDelegate webView:didFinishLoadForFrame:]):
3678         (TestWebKitAPI::TEST):
3679
3680 2015-07-08  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3681
3682         Fix ASSERTION FAILED: !m_pendingNavigationID in WebPage::reload().
3683         https://bugs.webkit.org/show_bug.cgi?id=146546
3684
3685         Reviewed by Darin Adler.
3686
3687         We did't reset pendingNavigationID value when request url is empty.
3688         Hence we need to ignore ASSERT check in this case.
3689
3690         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3691         (TestWebKitAPI::TEST):
3692
3693 2015-07-08  Benjamin Poulain  <bpoulain@apple.com>
3694
3695         [Content Extensions] Fuse undistinguishable actions as much as possible
3696         https://bugs.webkit.org/show_bug.cgi?id=146762
3697
3698         Reviewed by Alex Christensen.
3699
3700         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3701         Test that combinations and flags still work as expected.
3702
3703 2015-07-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3704
3705         [GTK] [Wayland] Allow building and testing the Wayland target with the default JHBuild moduleset.
3706         https://bugs.webkit.org/show_bug.cgi?id=146056
3707
3708         Reviewed by Martin Robinson.
3709
3710         * gtk/install-dependencies: libepoxy is now required for building GTK+.
3711         * gtk/jhbuild-wayland.modules: Removed. Not longer needed.
3712         * gtk/jhbuild.modules: Upgrade GTK+ (3.16.4) and required dependencies for building:
3713         Cairo (1.14.2), Gdk-Pixbuf (2.30.8) and GLib (2.44.1).
3714         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Removed. Not longer needed.
3715         Cairo removed support for LTO on (1.14). Upstream commit: c7ff9bb.
3716         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Removed. Not longer needed.
3717         GTK+ merged this patch on GTK+-3.10. Upstream commit: 8d83d98.
3718
3719 2015-07-06  Matt Rajca  <mrajca@apple.com>
3720
3721         Media Session: propagate metadata changes to UI clients
3722         https://bugs.webkit.org/show_bug.cgi?id=146660
3723
3724         Reviewed by Tim Horton.
3725
3726         * WebKitTestRunner/TestController.cpp: Build fixes for updated PageUIClient.
3727         (WTR::TestController::createOtherPage):
3728         (WTR::TestController::createWebViewWithOptions):
3729
3730 2015-07-07  Brady Eidson  <beidson@apple.com>
3731
3732         HTTP Auth cached after disabling private browsing/reset.
3733         <rdar://problem/8293055> and https://bugs.webkit.org/show_bug.cgi?id=146654
3734
3735         Reviewed by Tim Horton.
3736
3737         * DumpRenderTree/mac/DumpRenderTree.mm:
3738         (resetWebViewToConsistentStateBeforeTesting): Clear in-memory credentials in between test runs.
3739
3740 2015-07-06  Alex Christensen  <achristensen@webkit.org>
3741
3742         [Content Extensions] Remove memory page reporting
3743         https://bugs.webkit.org/show_bug.cgi?id=146659
3744
3745         Reviewed by Benjamin Poulain.
3746
3747         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3748         (TestWebKitAPI::TEST_F):
3749
3750 2015-07-06  Benjamin Poulain  <benjamin@webkit.org>
3751
3752         [Content Extensions] Make the DFA transitions ranges instead of characters
3753         https://bugs.webkit.org/show_bug.cgi?id=146575
3754
3755         Reviewed by Alex Christensen.
3756
3757         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3758         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3759         Since the minimizer is perfect, we get the minimal solution now,
3760         which is really cool!
3761
3762 2015-07-06  Brady Eidson  <beidson@apple.com>
3763
3764         ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads.
3765         <rdar://problem/21640050> and https://bugs.webkit.org/show_bug.cgi?id=146563
3766
3767         Reviewed by Geoff Garen.
3768
3769         * WebKitTestRunner/TestInvocation.cpp:
3770         (WTR::TestInvocation::invoke): For testing purposes, all pages should start with the 
3771           ShouldOpenExternalURLsPolicy set to "ShouldNotAllow"
3772
3773 2015-07-06  Daniel Bates  <dabates@apple.com>
3774
3775         Unreviewed, rolling out r170639.
3776
3777         Broke using webkit-patch apply-attachment to apply an
3778         attachment from a security bug. The patch incorrectly assumed
3779         that Bugzilla returns a non-HTTP 200 status code in its HTTP
3780         response when authentication is required.
3781
3782         Reverted changeset:
3783
3784         "webkit-patch apply-from-bug / apply-attachment should not ask
3785         for credentials if none are required"
3786         https://bugs.webkit.org/show_bug.cgi?id=40095
3787         http://trac.webkit.org/changeset/170639
3788
3789 2015-07-04  Chris Dumez  <cdumez@apple.com>
3790
3791         Drop RefPtr::clear() method
3792         https://bugs.webkit.org/show_bug.cgi?id=146556
3793
3794         Reviewed by Brady Eidson.
3795
3796         Drop RefPtr::clear() method in favor of "= nullptr;" pattern.
3797
3798 2015-07-03  Dan Bernstein  <mitz@apple.com>
3799
3800         Fixed the iOS build.
3801
3802         * DumpRenderTree/mac/EventSendingController.mm:
3803         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3804         (+[EventSendingController webScriptNameForSelector:]):
3805
3806 2015-07-03  Dan Bernstein  <mitz@apple.com>
3807
3808         [Xcode] Update some build settings as recommended by Xcode 7
3809         https://bugs.webkit.org/show_bug.cgi?id=146597
3810
3811         Reviewed by Sam Weinig.
3812
3813         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
3814
3815         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
3816         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
3817         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
3818         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
3819         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
3820
3821         * DumpRenderTree/mac/EventSendingController.mm:
3822         (+[EventSendingController webScriptNameForSelector:]): Removed check for setDragMode:,
3823         which was removed in r19101.
3824
3825         * DumpRenderTree/mac/TextInputController.m:
3826         (-[TextInputController interpretKeyEvents:withSender:]): Suppressed -Wundeclared-selector
3827         around used of a selector not that is not declared anywhere.
3828
3829         * MiniBrowser/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS.
3830
3831         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
3832
3833         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
3834         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
3835         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
3836         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
3837         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
3838
3839         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
3840
3841 2015-07-02  Daniel Bates  <dabates@apple.com>
3842
3843         [iOS] Add WebKitSystemInterface for iOS 8.4
3844         https://bugs.webkit.org/show_bug.cgi?id=146548
3845
3846         Rubber-stamped by Zalan Bujtas.
3847
3848         * Scripts/copy-webkitlibraries-to-product-directory:
3849
3850 2015-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3851
3852         [GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18
3853         https://bugs.webkit.org/show_bug.cgi?id=146234
3854
3855         Reviewed by Sergio Villar Senin.
3856
3857         Enable the WebSQL directory test that was disabled because of this bug.
3858
3859         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3860         (testWebContextConfiguration):
3861
3862 2015-07-01  Matthew Daiter  <mdaiter@apple.com>
3863
3864         Enabled MEDIA_STREAM flag
3865         https://bugs.webkit.org/show_bug.cgi?id=145947
3866         <rdar://problem/21365829>
3867         
3868         Reviewed by Eric Carlson.
3869
3870         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3871
3872 2015-06-30  Martin Robinson  <mrobinson@igalia.com>
3873
3874         [GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936
3875         https://bugs.webkit.org/show_bug.cgi?id=144828
3876
3877         Reviewed by Carlos Garcia Campos.
3878
3879         * WebKitTestRunner/gtk/main.cpp:
3880         (main): Use the new WKTextChecker API to set the spell checking languages
3881         when the process is starting up.
3882
3883 2015-06-30  Andy VanWagoner  <thetalecrafter@gmail.com>
3884
3885         Implement ECMAScript Internationalization API
3886         https://bugs.webkit.org/show_bug.cgi?id=90906
3887
3888         Reviewed by Benjamin Poulain.
3889
3890         * Scripts/webkitperl/FeatureList.pm: add ENABLE_INTL flag
3891
3892 2015-06-30  Jonathan Davis  <jond@apple.com>
3893
3894         Unreviewed. Added myself as a committer.
3895
3896         * Scripts/webkitpy/common/config/contributors.json:
3897
3898 2015-06-30  Brent Fulgham  <bfulgham@apple.com>
3899
3900         Unreviewed build fix.
3901
3902         * Scripts/update-webkit-dependency: Try to build even if we cannot connect
3903         to developer.apple.com to get update libraries.
3904
3905 2015-06-29  Jake Nielsen  <jacob_nielsen@apple.com>
3906
3907         Add timeout in run-webkit-tests for launching the simulator
3908         https://bugs.webkit.org/show_bug.cgi?id=146371
3909
3910         Reviewed by Darin Adler.
3911
3912         Adds a default 5-minute timeout using the timeout class in webkitpy.benchmark_runner.utils
3913         for the otherwise infinitely patient wait_until_device_is_in_state method.
3914
3915         * Scripts/webkitpy/xcode/simulator.py:
3916         (Simulator.DeviceState):
3917         (Simulator):
3918         (Simulator.wait_until_device_is_in_state):
3919         (Simulator.device_state):
3920
3921 2015-06-29  Benjamin Poulain  <benjamin@webkit.org>
3922
3923         Make the NFA transitions range-based
3924         https://bugs.webkit.org/show_bug.cgi?id=146338
3925
3926         Reviewed by Alex Christensen.
3927
3928         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3929         Test some new interesting cases.
3930
3931 2015-06-28  Dan Bernstein  <mitz@apple.com>
3932
3933         [Xcode] Use the same environment for command-line and IDE builds
3934         https://bugs.webkit.org/show_bug.cgi?id=146401
3935
3936         Reviewed by Anders Carlsson.
3937
3938         * Scripts/webkitdirs.pm:
3939         (XcodeOptions): Set the UseSanitizedBuildSystemEnvironment user default to YES, which makes
3940         xcodebuild use the same environment Xcode uses.
3941
3942 2015-06-28  Dan Bernstein  <mitz@apple.com>
3943
3944         REGRESSION (r185915): Source-incompatible change in WKPageUIClient
3945         https://bugs.webkit.org/show_bug.cgi?id=146396
3946
3947         Reviewed by Anders Carlsson.
3948
3949         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3950         (TestWebKitAPI::runJavaScriptAlert): Removed _deprecatedForUseWithV0 suffix from the name.
3951         (TestWebKitAPI::TEST): Updated for renames.
3952         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3953         (runJavaScriptAlert): Removed suffix.
3954         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): Updated.
3955         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3956         (runJavaScriptAlert): Removed suffix.
3957         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView): Updated.
3958
3959 2015-06-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3960
3961         [GTK][SOUP] Implement WebCore::PublicSuffix for soup and enable PUBLIC_SUFFIX_LIST for GTK+
3962         https://bugs.webkit.org/show_bug.cgi?id=146318
3963
3964         Reviewed by Sergio Villar Senin.
3965
3966         Copy mac PublicSuffix test to the common directory and add it to
3967         the GTK+ build.
3968
3969         * TestWebKitAPI/PlatformGTK.cmake:
3970         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp: Added.
3971         (TestWebKitAPI::TEST_F):
3972
3973 2015-06-26  Per Arne Vollan  <peavo@outlook.com>
3974
3975         WinLauncher fails to download files.
3976         https://bugs.webkit.org/show_bug.cgi?id=146242
3977
3978         Reviewed by Alex Christensen.
3979
3980         Added WinLauncher download delegate.
3981
3982         * WinLauncher/Common.cpp:
3983         * WinLauncher/WebDownloadDelegate.cpp: Added.
3984         (WebDownloadDelegate::WebDownloadDelegate):
3985         (WebDownloadDelegate::~WebDownloadDelegate):
3986         (WebDownloadDelegate::QueryInterface):
3987         (WebDownloadDelegate::AddRef):
3988         (WebDownloadDelegate::Release):
3989         (WebDownloadDelegate::decideDestinationWithSuggestedFilename):
3990         (WebDownloadDelegate::didCancelAuthenticationChallenge):
3991         (WebDownloadDelegate::didCreateDestination):
3992         (WebDownloadDelegate::didFailWithError):
3993         (WebDownloadDelegate::didReceiveAuthenticationChallenge):
3994         (WebDownloadDelegate::didReceiveDataOfLength):
3995         (WebDownloadDelegate::didReceiveResponse):
3996         (WebDownloadDelegate::shouldDecodeSourceDataOfMIMEType):
3997         (WebDownloadDelegate::willResumeWithResponse):
3998         (WebDownloadDelegate::willSendRequest):
3999         (WebDownloadDelegate::didBegin):
4000         (WebDownloadDelegate::didFinish):
4001         * WinLauncher/WebDownloadDelegate.h: Added.
4002         * WinLauncher/WinLauncher.cpp:
4003         (WinLauncher::setAccessibilityDelegate):
4004         (WinLauncher::setResourceLoadDelegate):
4005         (WinLauncher::setDownloadDelegate):
4006         (WinLauncher::mainFrame):
4007         * WinLauncher/WinLauncher.h:
4008         (WinLauncher::standardPreferences):
4009         (WinLauncher::privatePreferences):
4010         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
4011         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
4012         * WinLauncher/WinMain.cpp:
4013         (wWinMain):
4014
4015 2015-06-26  Csaba Osztrogonác  <ossy@webkit.org>
4016
4017         [EFL] Bump libseccomp version to 2.2.1
4018         https://bugs.webkit.org/show_bug.cgi?id=146341
4019
4020         Reviewed by Gyuyoung Kim.
4021
4022         * efl/jhbuild.modules:
4023         * efl/jhbuildrc: Enabled libseccomp build on AArch64.
4024         * efl/patches/libseccomp-pick-up-CC.patch: Removed, we don't need it anymore.
4025
4026 2015-06-25  Alex Christensen  <achristensen@webkit.org>
4027
4028         [Content Extensions] Add a way to match a domain but not subdomains
4029         https://bugs.webkit.org/show_bug.cgi?id=146241
4030         rdar://problem/21557754
4031
4032         Reviewed by Darin Adler.
4033
4034         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4035         (TestWebKitAPI::TEST_F):
4036         Update subdomain test because of changed behavior and add test for new '*' functionality.
4037
4038 2015-06-25  Jaehun Lim  <ljaehun.lim@samsung.com>
4039
4040         Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes.
4041         https://bugs.webkit.org/show_bug.cgi?id=146308
4042
4043         Reviewed by Csaba Osztrogonác.
4044
4045         ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536.
4046
4047         * Scripts/webkitperl/FeatureList.pm:
4048
4049 2015-06-25  Carlos Garcia Campos  <cgarcia@igalia.com>
4050
4051         [GTK] Add initial WebKitWebsiteDataManager API for process configuration options
4052         https://bugs.webkit.org/show_bug.cgi?id=146149
4053
4054         Reviewed by Sergio Villar Senin.
4055
4056         Update unit tests to use WebKitWebsiteDataManager.
4057
4058         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
4059         (testWebContextConfiguration):
4060         (serverCallback):
4061         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
4062         (Test::Test): Use WebKitWebsiteDataManager and set all possible
4063         values to ensure unit tests don't write outside the temporary directory.
4064         (Test::~Test): Explicitly reset the web context to ensure its
4065         objects are released before the leaks check.
4066         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
4067         (WebViewTest::wait): Fix the GSource used, since we are receiving
4068         a double in seconds, but using g_timeout_add_seconds() that
4069         expects an unsigned in seconds. Use GMainLoopSource to correctly
4070         handle the value and simplify the code.
4071
4072 2015-06-24  Jason Marcell  <jmarcell@apple.com>
4073
4074         Work towards: Add status of Safari projects on iOS Dashboard on build-safari
4075         https://bugs.webkit.org/show_bug.cgi?id=146126
4076         <rdar://problem/18226291>
4077
4078         Reviewed by Alexey Proskuryakov.
4079
4080         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
4081         (documentReady): Using combined queues to display iOS projects
4082
4083 2015-06-24  Doug Russell  <d_russell@apple.com>
4084
4085         Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject 
4086         when posting a selection notification when on the border between two accessibilityObjects
4087         https://bugs.webkit.org/show_bug.cgi?id=146177
4088
4089         Reviewed by Darin Adler.
4090
4091         Add support for mapping WebCore Accessibility types into JSValueRef types
4092         so they can be used in tests.
4093
4094         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
4095         (webAccessibilityObjectWrapperClass):
4096         (-[AccessibilityNotificationHandler startObserving]):
4097         (makeValueRefForValue):
4098         (makeArrayRefForArray):
4099         (makeObjectRefForDictionary):
4100         (-[AccessibilityNotificationHandler _notificationReceived:]):
4101         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
4102         (webAccessibilityObjectWrapperClass):
4103         (-[AccessibilityNotificationHandler startObserving]):
4104         (makeValueRefForValue):
4105         (makeArrayRefForArray):
4106         (makeObjectRefForDictionary):
4107         (-[AccessibilityNotificationHandler _notificationReceived:]):
4108
4109 2015-06-24  Zalan Bujtas  <zalan@apple.com>
4110
4111         Subpixel rendering: roundToDevicePixel() snaps to wrong value.
4112         https://bugs.webkit.org/show_bug.cgi?id=146273
4113         rdar://problem/18509840
4114
4115         Reviewed by Simon Fraser.
4116
4117         Due to the floating point approximate representation, we can't always produce
4118         the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication
4119         and by changing the rounding in roundToDevicePixel() from float to double.
4120
4121         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
4122         (TestWebKitAPI::TEST):
4123
4124 2015-06-24  Brady Eidson  <beidson@apple.com>
4125
4126         Update JavaScript dialog delegates to include a WKSecurityOriginRef argument.
4127         <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249
4128
4129         Reviewed by Alex Christensen.
4130
4131         - Update WKTR to the new client structure.
4132         - Update existing TestWebKitAPI tests to either use the new client structure or
4133           assign the old function signature to the updated variable name.
4134         - Include a new test.
4135
4136         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4137
4138         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
4139         (TestWebKitAPI::runJavaScriptAlert):
4140
4141         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
4142         (TestWebKitAPI::TEST):
4143
4144         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
4145         (TestWebKitAPI::analyzeDialogArguments):
4146         (TestWebKitAPI::runJavaScriptAlert):
4147         (TestWebKitAPI::runJavaScriptConfirm):
4148         (TestWebKitAPI::runJavaScriptPrompt):
4149         (TestWebKitAPI::createNewPage):
4150         (TestWebKitAPI::TEST):
4151
4152         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
4153         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
4154
4155         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
4156         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
4157
4158         * WebKitTestRunner/TestController.cpp:
4159         (WTR::TestController::createOtherPage):
4160         (WTR::TestController::createWebViewWithOptions):
4161
4162 2015-06-23  Dewei Zhu  <dewei_zhu@apple.com>
4163
4164         Refactoring benchmark runner script to follow pep8 code style.
4165         https://bugs.webkit.org/show_bug.cgi?id=146264
4166
4167         Reviewed by Ryosuke Niwa.
4168
4169         Refactor benchmark runner script to follow pep8 code style.
4170
4171         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
4172         (GenericBenchmarkBuilder.prepare):
4173         (GenericBenchmarkBuilder._run_create_script):
4174         (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir):
4175         (GenericBenchmarkBuilder._fetch_remote_archive):
4176         (GenericBenchmarkBuilder):
4177         (GenericBenchmarkBuilder._checkout_with_subversion):
4178         (GenericBenchmarkBuilder._apply_patch):
4179         (GenericBenchmarkBuilder.clean):
4180         (GenericBenchmarkBuilder._runCreateScript): Deleted.
4181         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted.
4182         (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted.
4183         (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted.
4184         (GenericBenchmarkBuilder._applyPatch): Deleted.
4185         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
4186         (BenchmarkRunner.__init__):
4187         (BenchmarkRunner._find_plan_file):
4188         (BenchmarkRunner.execute):
4189         (BenchmarkRunner._cleanup):
4190         (BenchmarkRunner._dump):
4191         (BenchmarkRunner._wrap):
4192         (BenchmarkRunner._merge):
4193         (BenchmarkRunner._show_results):
4194         (BenchmarkRunner._findPlanFile): Deleted.
4195         (BenchmarkRunner.cleanup): Deleted.
4196         (BenchmarkRunner.dump): Deleted.
4197         (BenchmarkRunner.wrap): Deleted.
4198         (BenchmarkRunner.merge): Deleted.
4199         (BenchmarkRunner.show_results): Deleted.
4200         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
4201         (BrowserDriver.prepare_env):
4202         (BrowserDriver.launch_url):
4203         (BrowserDriver.close_browsers):
4204         (BrowserDriver.prepareEnv): Deleted.
4205         (BrowserDriver.launchUrl): Deleted.
4206         (BrowserDriver.closeBrowser): Deleted.
4207         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
4208         (OSXBrowserDriver):
4209         (OSXBrowserDriver.prepare_env):
4210         (OSXBrowserDriver.close_browsers):
4211         (OSXBrowserDriver._launch_process):
4212         (OSXBrowserDriver._terminiate_processes):
4213         (OSXBrowserDriver._launch_process_with_caffinate):
4214         (OSXBrowserDriver._screen_size):
4215         (OSXBrowserDriver.prepareEnv): Deleted.
4216         (OSXBrowserDriver.closeBrowsers): Deleted.
4217         (OSXBrowserDriver.launchProcess): Deleted.
4218         (OSXBrowserDriver.terminateProcesses): Deleted.
4219         (OSXBrowserDriver.launchProcessWithCaffinate): Deleted.
4220         (OSXBrowserDriver.screenSize): Deleted.
4221         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
4222         (OSXChromeDriver):
4223         (OSXChromeDriver.launch_url):
4224         (OSXChromeCanaryDriver):
4225         (OSXChromeCanaryDriver.launch_url):
4226         (OSXChromeDriver.launchUrl): Deleted.
4227         (OSXChromeCanaryDriver.launchUrl): Deleted.
4228         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
4229         (OSXFirefoxDriver):
4230         (OSXFirefoxDriver.launch_url):
4231         (OSXFirefoxNightlyDriver):
4232         (OSXFirefoxNightlyDriver.launch_url):
4233         (OSXFirefoxDriver.launchUrl): Deleted.
4234         (OSXFirefoxNightlyDriver.launchUrl): Deleted.
4235         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
4236         (OSXSafariDriver):
4237         (OSXSafariDriver.prepare_env):
4238         (OSXSafariDriver.launch_url):
4239         (OSXSafariDriver.close_browsers):
4240         (OSXSafariDriver._maximize_window):
4241         (OSXSafariDriver.prepareEnv): Deleted.
4242         (OSXSafariDriver.launchUrl): Delete