2f8ac06dc038f06a22f9c96058607ed09e255a73
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         REGRESSION(r222507): Composition highlight doesn't render when using IME
4         https://bugs.webkit.org/show_bug.cgi?id=181485
5         <rdar://problem/35896516>
6
7         Reviewed by Ryosuke Niwa.
8
9         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
10         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
11         allow rendering composition backgrounds (see InlineTextBox::paint).
12
13         * DumpRenderTree/ios/TextInputControllerIOS.m:
14         (+[TextInputController isSelectorExcludedFromWebScript:]):
15         (+[TextInputController webScriptNameForSelector:]):
16         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
17         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
18         * DumpRenderTree/mac/TextInputControllerMac.m:
19         (+[TextInputController isSelectorExcludedFromWebScript:]):
20         (+[TextInputController webScriptNameForSelector:]):
21         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
22         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
23         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
24         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
25         (WTR::TextInputController::setMarkedText):
26         * WebKitTestRunner/InjectedBundle/TextInputController.h:
27
28 2018-01-10  JF Bastien  <jfbastien@apple.com>
29
30         Poison small JSObject derivatives which only contain pointers
31         https://bugs.webkit.org/show_bug.cgi?id=181483
32         <rdar://problem/36407127>
33
34         Reviewed by Mark Lam.
35
36         Test the new move-assign and move-copy from unique_ptr, as well as
37         nullptr_t ctors.
38
39         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
40         (TestWebKitAPI::TEST):
41         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
42         (TestWebKitAPI::TEST):
43         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
44         (TestWebKitAPI::TEST):
45
46 2018-01-10  Chris Dumez  <cdumez@apple.com>
47
48         Multiple http/wpt/beacon/contentextensions/ test are flaky.
49         https://bugs.webkit.org/show_bug.cgi?id=179256
50         <rdar://problem/35401978>
51
52         Reviewed by Alex Christensen.
53
54         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
55         instance gets its own folder to avoid conflicts and flakiness.
56
57         * WebKitTestRunner/mac/TestControllerMac.mm:
58         (WTR::TestController::platformConfigureViewForTest):
59
60 2018-01-10  Tim Horton  <timothy_horton@apple.com>
61
62         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
63         https://bugs.webkit.org/show_bug.cgi?id=181269
64         <rdar://problem/35110344>
65
66         Reviewed by Simon Fraser.
67
68         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
69         (WTR::UIScriptController::beginBackSwipe):
70         (WTR::UIScriptController::completeBackSwipe):
71         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
72         (WTR::UIScriptController::beginBackSwipe):
73         (WTR::UIScriptController::completeBackSwipe):
74         (WTR::UIScriptController::overridePreference):
75         (WTR::UIScriptController::replaceTextAtRange):
76         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
77         (WTR::PlatformWebView::setNavigationGesturesEnabled):
78         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
79         (WTR::UIScriptController::beginBackSwipe):
80         (WTR::UIScriptController::completeBackSwipe):
81         Implement beginBackSwipe and completeBackSwipe on iOS (they already
82         exist on Mac) in terms of the new WKWebView testing SPI.
83
84 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
85
86         REGRESSION (r226715): ignore WARNING output in linter tests
87         https://bugs.webkit.org/show_bug.cgi?id=181486
88         <rdar://problem/36408847>
89
90         Reviewed by Aakash Jain.
91
92         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
93
94         * Scripts/webkitpy/common/system/outputcapture.py:
95         (OutputCapture.__init__): Pass logging level to be captured.
96         * Scripts/webkitpy/style/main_unittest.py:
97         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
98         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
99         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
100         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
101         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
102         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
103         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
104         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
105
106 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
107
108         Add a JSCOnly MIPS buildbot
109         https://bugs.webkit.org/show_bug.cgi?id=181487
110
111         Reviewed by Michael Catanzaro.
112
113         Add the new bot configs definitions for the master and update the unit tests.
114
115         * BuildSlaveSupport/build.webkit.org-config/config.json:
116         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
117
118 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
119
120         REGRESSION (r226715): don't re-check number of simulators in child processes
121         https://bugs.webkit.org/show_bug.cgi?id=181484
122         <rdar://problem/36407151>
123
124         Reviewed by Aakash Jain.
125
126         * Scripts/webkitpy/port/ios_simulator.py:
127         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
128         are already initialized.
129
130 2018-01-10  Commit Queue  <commit-queue@webkit.org>
131
132         Unreviewed, rolling out r226667 and r226673.
133         https://bugs.webkit.org/show_bug.cgi?id=181488
134
135         This caused a flaky crash. (Requested by mlewis13 on #webkit).
136
137         Reverted changesets:
138
139         "CodeBlocks should be in IsoSubspaces"
140         https://bugs.webkit.org/show_bug.cgi?id=180884
141         https://trac.webkit.org/changeset/226667
142
143         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
144         https://bugs.webkit.org/show_bug.cgi?id=180884
145         https://trac.webkit.org/changeset/226673
146
147 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
148
149         Follow-up fix to r226715
150         https://bugs.webkit.org/show_bug.cgi?id=180555
151         <rdar://problem/36131381>
152
153         Unreviewed infrastructure fix.
154
155         * Scripts/webkitpy/xcode/new_simulated_device.py:
156         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
157         of delete.
158
159 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
160
161         webkitpy: Refactor simulator code (Part 2)
162         https://bugs.webkit.org/show_bug.cgi?id=180555
163         <rdar://problem/36131381>
164
165         Reviewed by Aakash Jain.
166
167         The patch leverages the SimulatedDeviceManager when running layout tests.
168         This patch is primarily code removal, since much of the IOSSimulatorPort
169         was dedicated to managing simulators. The removed code is either now owned by the
170         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
171         boot multiple simulators which was made obsolete in Xcode 9.
172
173         * Scripts/webkitpy/layout_tests/controllers/manager.py:
174         (Manager._custom_device_for_test.in): Device names now have spaces in them,
175         strip those spaces.
176         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
177         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
178         * Scripts/webkitpy/port/ios.py:
179         (IOSPort.__init__): The _current_device idiom is no longer required since the
180         SimulatedDeviceManager keeps track of any previously booted devices.
181         (IOSPort.target_host): Even when only a single device is used, it will be accessed
182         through the array of managed devices.
183         (IOSPort.using_multiple_devices): Deleted.
184         * Scripts/webkitpy/port/ios_device.py:
185         (IOSDevicePort.using_multiple_devices): Deleted.
186         * Scripts/webkitpy/port/ios_simulator.py:
187         (IOSSimulatorPort): Remove constants required to manage simulators, change device
188         class strings so they can be parsed by the DeviceType class.
189         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
190         the number of simulators currently booted, the number of child processes specified
191         and the maximum number of simulators supported by this system.
192         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
193         devices owned by the SimulatedDeviceManager.
194         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
195         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
196         the maximum number of supported simulators on this system.
197         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
198         request for each child process and send this list to the SimulatedDeviceManager to
199         initialize the devices.
200         (IOSSimulatorPort.clean_up_test_run):
201         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
202         specified version of iOS.
203         (IOSSimulatorPort.reset_preferences):
204         (IOSSimulatorPort.simulator_runtime): Deleted.
205         (IOSSimulatorPort.simulator_device_type): Deleted.
206         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
207         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
208         (IOSSimulatorPort._create_simulators): Deleted.
209         (IOSSimulatorPort._quit_ios_simulator): Deleted.
210         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
211         (IOSSimulatorPort.using_multiple_devices): Deleted.
212         (IOSSimulatorPort._create_device): Deleted.
213         (IOSSimulatorPort.get_simulator_path): Deleted.
214         (IOSSimulatorPort._createSimulatorApps): Deleted.
215         (IOSSimulatorPort._createSimulatorApp): Deleted.
216         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
217         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
218         maximum number of simulators run on this system.
219         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
220         * Scripts/webkitpy/xcode/new_simulated_device.py:
221         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
222
223 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
224
225         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
226         https://bugs.webkit.org/show_bug.cgi?id=181474
227
228         Reviewed by Carlos Alberto Lopez Perez.
229
230         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
231         name as the name.
232
233         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
234         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
235         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
236
237 2018-01-09  Andy Estes  <aestes@apple.com>
238
239         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
240         https://bugs.webkit.org/show_bug.cgi?id=181459
241
242         Reviewed by Dan Bernstein.
243
244         * ImageDiff/cg/Configurations/Base.xcconfig:
245
246 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
247
248         font-display:fallback can cause a visual flash (which is supposed to be impossible)
249         https://bugs.webkit.org/show_bug.cgi?id=181374
250
251         Reviewed by Simon Fraser.
252
253         The test requires Palatino.
254
255         * DumpRenderTree/mac/DumpRenderTree.mm:
256         (allowedFontFamilySet):
257         * WebKitTestRunner/mac/TestControllerMac.mm:
258         (WTR::allowedFontFamilySet):
259
260 2018-01-09  Saam Barati  <sbarati@apple.com>
261
262         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
263         https://bugs.webkit.org/show_bug.cgi?id=181449
264
265         Reviewed by JF Bastien.
266
267         This allows me to Cmd+f in my terminal to search for things without
268         having the results become misaligned.
269
270         * Scripts/display-profiler-output:
271
272 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
273
274         [webkitpy] PlatformInfo should have default argument for casual use
275         https://bugs.webkit.org/show_bug.cgi?id=180827
276
277         Reviewed by David Kilzer.
278
279         PlatformInfo should be the only way to check platform specific thing instead
280         of sys.platform or other various checks. If there is something you want to check,
281         it should be placed in PlatformInfo.
282
283         Currently to instantiate PlatformInfo, it requires arguments, which is usually
284         sys, platform and Executive(). They are straight forward and should be handled
285         by default arguments. Then we can instantiate PlatformInfo more casual.
286
287         * Scripts/webkitpy/common/system/platforminfo.py:
288         (PlatformInfo): Use relative module path import
289         (PlatformInfo.__init__):
290         (PlatformInfo.executive): Lazy instantiation of Executive()
291         (PlatformInfo.total_bytes_memory): Accessing via above property
292         (PlatformInfo.xcode_sdk_version): Ditto
293         (PlatformInfo.xcode_simctl_list): Ditto
294         (PlatformInfo.xcode_version): Ditto
295         (PlatformInfo._win_version_str): Ditto
296         * Scripts/webkitpy/common/system/systemhost.py:
297         (SystemHost.__init__):
298         * Scripts/webkitpy/common/system/user.py:
299         (User.__init__):
300
301 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
302
303         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
304         https://bugs.webkit.org/show_bug.cgi?id=176443
305
306         Reviewed by Darin Adler.
307
308         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
309         (TEST):
310
311 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
312
313         check-webkit-style: Verify syntax for WK_API_AVAILABLE
314         https://bugs.webkit.org/show_bug.cgi?id=181394
315
316         Reviewed by Darin Adler.
317
318         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
319         as the second parameter instead of ios(WK_IOS_TBA). This generally
320         builds for iOS on EWS but not when using the public SDK. See r224057,
321         r223207 and r226211 for example. This patch adds a basic style check
322         for that macro to prevent this kind of mistake.
323
324         * Scripts/webkitpy/style/checkers/cpp.py:
325         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
326         (check_style): Run new style check.
327         (CppChecker): Add build type for the new style check.
328         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
329         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
330
331 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
332
333         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
334         https://bugs.webkit.org/show_bug.cgi?id=181420
335         <rdar://problem/36365827>
336
337         Reviewed by Alex Christensen.
338
339         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
340         of corresponding _WKAttachments.
341
342         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
343         (TestWebKitAPI::TEST):
344
345 2018-01-08  Alex Christensen  <achristensen@webkit.org>
346
347         Add WKNavigationDelegate SPI exposing WebProcess crash reason
348         https://bugs.webkit.org/show_bug.cgi?id=181410
349         <rdar://problem/36167199>
350
351         Reviewed by Wenson Hsieh.
352
353         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
354         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
355         (TEST):
356
357 2018-01-08  Alex Christensen  <achristensen@webkit.org>
358
359         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
360         https://bugs.webkit.org/show_bug.cgi?id=181408
361         <rdar://problem/35884960>
362
363         Reviewed by Tim Horton.
364
365         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
366         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
367
368 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
369
370         [Attachment Support] Expose file name and content type of WKAttachment
371         https://bugs.webkit.org/show_bug.cgi?id=181390
372         <rdar://problem/36336837>
373
374         Reviewed by Tim Horton.
375
376         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
377
378         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
379         (-[_WKAttachment synchronouslyRequestInfo:]):
380         (-[_WKAttachment synchronouslyRequestData:]):
381
382         Reimplement this in terms of -synchronouslyRequestInfo:.
383
384         (-[_WKAttachment expectRequestedDataToBe:]):
385         (TestWebKitAPI::TEST):
386
387 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
388
389         Copying, pasting, and then deleting an attachment element breaks attachment data requests
390         https://bugs.webkit.org/show_bug.cgi?id=181365
391         <rdar://problem/36340647>
392
393         Reviewed by Tim Horton.
394
395         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
396         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
397         detail.
398
399         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
400         (TestWebKitAPI::TEST):
401
402 2018-01-08  Youenn Fablet  <youenn@apple.com>
403
404         navigator.onLine does not work inside service workers
405         https://bugs.webkit.org/show_bug.cgi?id=181079
406         <rdar://problem/36178606>
407
408         Reviewed by Darin Adler.
409
410         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
411         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
412
413 2018-01-07  Saam Barati  <sbarati@apple.com>
414
415         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
416         https://bugs.webkit.org/show_bug.cgi?id=181372
417
418         Reviewed by Filip Pizlo.
419
420         Adding these sorting modes makes it easier to analyze functions
421         that recompile a lot and exit a lot.
422
423         * Scripts/display-profiler-output:
424
425 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
426
427         Unreviewed, remove my Cisco email from contributors.json
428
429         * Scripts/webkitpy/common/config/contributors.json:
430
431 2018-01-05  JF Bastien  <jfbastien@apple.com>
432
433         WebAssembly: poison JS object's secrets
434         https://bugs.webkit.org/show_bug.cgi?id=181339
435         <rdar://problem/36325001>
436
437         Reviewed by Mark Lam.
438
439         Update tests for swap(Poisoned<k, T>, T*)
440
441         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
442         (TestWebKitAPI::TEST):
443         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
444         (TestWebKitAPI::TEST):
445         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
446         (TestWebKitAPI::TEST):
447
448 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
449
450         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
451         https://bugs.webkit.org/show_bug.cgi?id=181359
452
453         Reviewed by Tim Horton.
454
455         Ensure that these tests still pass using older SDKs.
456
457         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
458         (TestWebKitAPI::TEST):
459
460 2018-01-05  Alex Christensen  <achristensen@webkit.org>
461
462         Rebase API test after r226469
463         https://bugs.webkit.org/show_bug.cgi?id=181308
464
465         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
466         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
467         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
468
469 2018-01-05  Alex Christensen  <achristensen@webkit.org>
470
471         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
472         https://bugs.webkit.org/show_bug.cgi?id=181217
473
474         Reviewed by Tim Horton.
475
476         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
477         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
478         (TEST):
479
480 2018-01-05  Alex Christensen  <achristensen@webkit.org>
481
482         Add WKBundleFrameCreateFrameHandle
483         https://bugs.webkit.org/show_bug.cgi?id=181232
484         <rdar://problem/35926696>
485
486         Reviewed by Tim Horton.
487
488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
489         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
490         (mouseDidMoveOverElement):
491         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
492         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
493         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
494         (TEST):
495
496 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
497
498         iOS: Build fix after r226432.
499         
500         Unreviewed. Stop duplicating speakAs symbols for iOS.
501
502         * DumpRenderTree/AccessibilityUIElement.cpp:
503         (AccessibilityUIElement::speakAs):
504
505 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
506
507         Unreviewed, added myself as WebKit reviewer
508
509         * Scripts/webkitpy/common/config/contributors.json:
510
511 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
512
513         WPE: Build fix after r226432.
514
515         Unreviewed. Rename ::speak() to ::speakAs().
516         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
517         (WTR::AccessibilityUIElement::speakAs):
518         (WTR::AccessibilityUIElement::speak): Deleted.
519
520 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
521
522         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
523         https://bugs.webkit.org/show_bug.cgi?id=180361
524
525         Reviewed by Zalan Bujtas.
526
527         * DumpRenderTree/AccessibilityUIElement.cpp:
528         (speakAsCallback):
529         (AccessibilityUIElement::speakAs):
530         (AccessibilityUIElement::getJSClass):
531         (speakCallback): Deleted.
532         (AccessibilityUIElement::speak): Deleted.
533         * DumpRenderTree/AccessibilityUIElement.h:
534         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
535         (AccessibilityUIElement::speakAs):
536         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
537         (AccessibilityUIElement::speakAs):
538         (AccessibilityUIElement::speak): Deleted.
539         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
540         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
541         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
542         (WTR::AccessibilityUIElement::speakAs):
543         (WTR::AccessibilityUIElement::speak): Deleted.
544         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
545         (WTR::AccessibilityUIElement::speakAs):
546         (WTR::AccessibilityUIElement::speak): Deleted.
547
548 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
549
550         REGRESSION (r226395): test-webkitperl test expectations incorrect
551         https://bugs.webkit.org/show_bug.cgi?id=181307
552         <rdar://problem/36306558>
553
554         Rubber-stamped by Aakash Jain.
555
556         r226395 added two lines towards the beginning of
557         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
558         numbers in the test expectations need to update.
559
560         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
561
562 2018-01-04  Tim Horton  <timothy_horton@apple.com>
563
564         WKWebView loses minimum layout size overrides that happen while the process is terminated
565         https://bugs.webkit.org/show_bug.cgi?id=181306
566         <rdar://problem/34398288>
567
568         Reviewed by Dan Bernstein.
569
570         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
571         (TEST):
572         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
573         while the process is terminated results in the page getting the correct
574         minimum layout size.
575
576 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
577
578         [MediaStream] Add Mock screen capture source
579         https://bugs.webkit.org/show_bug.cgi?id=181291
580         <rdar://problem/36298164>
581
582         Reviewed by Dean Jackson.
583
584         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
585         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
586         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
587
588 2018-01-04  Lucas Forschler  <lforschler@apple.com>
589
590         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
591
592         Reviewed by Ling Ho.
593
594         * BuildSlaveSupport/build.webkit.org-config/steps.py:
595
596 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
597
598         [Attachment Support] Create attachment elements when dropping files on iOS
599         https://bugs.webkit.org/show_bug.cgi?id=181192
600         <rdar://problem/36280945>
601
602         Reviewed by Tim Horton.
603
604         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
605         switch is enabled. See below for more details.
606
607         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
608         (-[NSItemProvider registerData:type:]):
609         (platformCopyPNG):
610         (TestWebKitAPI::TEST):
611         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
612
613         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
614         source item provider when dragging rich text *without* attachments, so this should have been a check for just
615         kUTTypeRTF instead.
616
617         (TestWebKitAPI::TEST):
618
619         Tests a few cases of inserting attachment elements via drop:
620         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
621             Instead of inserting the contents as inline web content, this should generate attachment elements.
622         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
623             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
624             back to inserting the content as an attachment.
625         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
626             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
627             or at the end).
628
629         * TestWebKitAPI/cocoa/TestWKWebView.h:
630         * TestWebKitAPI/cocoa/TestWKWebView.mm:
631         (-[TestWKWebView objectByEvaluatingJavaScript:]):
632
633         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
634         -stringByEvaluatingJavaScript to just turn around and call this.
635
636         (-[TestWKWebView stringByEvaluatingJavaScript:]):
637
638 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
639
640         Replace hard-coded paths in shebangs with #!/usr/bin/env
641         https://bugs.webkit.org/show_bug.cgi?id=181040
642
643         Reviewed by Alex Christensen.
644
645         * BuildSlaveSupport/build-launcher-app:
646         * BuildSlaveSupport/build-launcher-dmg:
647         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
648         * BuildSlaveSupport/built-product-archive:
649         * BuildSlaveSupport/clean-build:
650         * BuildSlaveSupport/delete-stale-build-files:
651         * BuildSlaveSupport/download-built-product:
652         * BuildSlaveSupport/gtk/buildbot/log/run:
653         * BuildSlaveSupport/gtk/buildbot/run:
654         * BuildSlaveSupport/gtk/pulseaudio/run:
655         * BuildSlaveSupport/kill-old-processes:
656         * BuildSlaveSupport/test-result-archive:
657         * BuildSlaveSupport/win/kill-old-processes:
658         * Scripts/SpacingHeuristics.pm:
659         * Scripts/add-include:
660         * Scripts/build-api-tests:
661         * Scripts/build-dumprendertree:
662         * Scripts/build-imagediff:
663         * Scripts/build-jsc:
664         * Scripts/build-webkit:
665         * Scripts/build-webkittestrunner:
666         * Scripts/check-Xcode-source-file-types:
667         * Scripts/check-dom-results:
668         * Scripts/check-for-exit-time-destructors:
669         * Scripts/check-for-global-initializers:
670         * Scripts/check-for-inappropriate-objc-class-names:
671         * Scripts/check-for-weak-vtables-and-externals:
672         * Scripts/clean-header-guards:
673         * Scripts/compare-timing-files:
674         * Scripts/configure-xcode-for-ios-development:
675         * Scripts/copy-webkitlibraries-to-product-directory:
676         * Scripts/create-exports:
677         * Scripts/debug-minibrowser:
678         * Scripts/debug-safari:
679         * Scripts/debug-test-runner:
680         * Scripts/do-file-rename:
681         * Scripts/do-webcore-rename:
682         * Scripts/dump-webkit-tests-run:
683         * Scripts/ensure-valid-python:
684         * Scripts/execAppWithEnv:
685         * Scripts/extract-localizable-js-strings:
686         * Scripts/filter-build-webkit:
687         * Scripts/find-extra-includes:
688         * Scripts/fix-blink-patch:
689         * Scripts/generate-coverage-data:
690         * Scripts/git-add-reviewer:
691         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
692         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
693         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
694         * Scripts/make-new-script-test:
695         * Scripts/make-script-test-wrappers:
696         * Scripts/package-root:
697         * Scripts/parse-malloc-history:
698         * Scripts/report-include-statistics:
699         * Scripts/resolve-ChangeLogs:
700         * Scripts/run-api-tests:
701         * Scripts/run-bindings-tests:
702         * Scripts/run-content-extension-tester:
703         * Scripts/run-iexploder-tests:
704         * Scripts/run-javascriptcore-tests:
705         * Scripts/run-jsc:
706         * Scripts/run-leaks:
707         * Scripts/run-mangleme-tests:
708         * Scripts/run-minibrowser:
709         * Scripts/run-pageloadtest:
710         * Scripts/run-regexp-tests:
711         * Scripts/run-safari:
712         * Scripts/run-sunspider:
713         * Scripts/run-test-runner:
714         * Scripts/run-webkit-app:
715         * Scripts/run-webkit-httpd:
716         * Scripts/run-webkit-websocketserver:
717         * Scripts/set-webkit-configuration:
718         * Scripts/show-pretty-diff:
719         * Scripts/sort-Xcode-project-file:
720         * Scripts/split-file-by-class:
721         * Scripts/sunspider-compare-results:
722         * Scripts/svn-apply:
723         * Scripts/svn-unapply:
724         * Scripts/test-webkit-scripts:
725         * Scripts/test-webkitperl:
726         * Scripts/update-iexploder-cssproperties:
727         * Scripts/update-javascriptcore-test-results:
728         * Scripts/update-webkit:
729         * Scripts/update-webkit-auxiliary-libs:
730         * Scripts/update-webkit-dependency:
731         * Scripts/update-webkit-libs-jhbuild:
732         * Scripts/update-webkit-localizable-strings:
733         * Scripts/update-webkit-support-libs:
734         * Scripts/update-webkitgtk-libs:
735         * Scripts/update-webkitwpe-libs:
736         * Scripts/webkit-build-directory:
737         * Scripts/webkitperl/LoadAsModule.pm:
738         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
739         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
740         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
741         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
742         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
743         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
744         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
745         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
746         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
747         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
748         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
749         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
750         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
751         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
752         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
753         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
754         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
755         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
756         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
757         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
758         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
759         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
760         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
761         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
762         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
763         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
764         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
765         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
766         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
767         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
768         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
769         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
770         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
771         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
772         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
773         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
774         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
775         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
776         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
777         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
778         * ccache/ccache-clang:
779         * ccache/ccache-clang++:
780         * ccache/ccache-wrapper:
781         * gtk/install-dependencies:
782         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
783         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
784         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
785         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
786         * iExploder/iexploder-1.3.2/tools/showtest.rb:
787         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
788         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
789         * iExploder/iexploder-1.7.2/src/webserver.rb:
790         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
791         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
792         * wpe/install-dependencies:
793
794 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
795
796         filter-build-webkit filters out useful compiler error lines
797         https://bugs.webkit.org/show_bug.cgi?id=179864
798
799         Reviewed by Tim Horton.
800
801         Don't filter out lines that contain information about build errors by always showing lines
802         after a line that contains "note:" or "error:".
803
804         * Scripts/filter-build-webkit:
805         (shouldShowSubsequentLine):
806         (shouldIgnoreLine):
807
808 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
809
810         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
811         https://bugs.webkit.org/show_bug.cgi?id=173915
812
813         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
814         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
815         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
816         empty string in this case.
817
818         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
819         (emitFormSubmissionEvent):
820
821 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
822
823         [GTK] Add web process API to detect when form is submitted via JavaScript
824         https://bugs.webkit.org/show_bug.cgi?id=173915
825
826         Reviewed by Carlos Garcia Campos.
827
828         Test it.
829
830         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
831         (FormSubmissionTest::FormSubmissionTest):
832         (FormSubmissionTest::~FormSubmissionTest):
833         (FormSubmissionTest::testFormSubmissionResult):
834         (FormSubmissionTest::willSendDOMEventCallback):
835         (FormSubmissionTest::willCompleteCallback):
836         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
837         (testWebExtensionFormSubmissionSteps):
838         (beforeAll):
839         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
840         (DelayedSignal::DelayedSignal):
841         (emitFormSubmissionEvent):
842         (handleFormSubmissionCallback):
843         (willSubmitFormCallback):
844         (pageCreatedCallback):
845
846 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
847
848         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
849         https://bugs.webkit.org/show_bug.cgi?id=181251
850
851         * Scripts/run-gtk-tests:
852         (GtkTestRunner):
853
854 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
855
856         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
857         https://bugs.webkit.org/show_bug.cgi?id=181136
858
859         * Scripts/run-gtk-tests:
860         (GtkTestRunner):
861
862 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
863
864         [macOS, iOS] Adopt new secure coding APIs in WebKit
865         https://bugs.webkit.org/show_bug.cgi?id=181085
866         <rdar://problem/34837397>
867
868         Reviewed by Tim Horton.
869
870         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
871         capable of supporting NSSecureCoding, so pass through the current coding routines.
872
873         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
874         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
875         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
876         routines if necessary.
877         (TEST): Updated for NSSecureCoding.
878         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
879         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
880
881 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
882
883         Remove std::chrono completely
884         https://bugs.webkit.org/show_bug.cgi?id=181186
885
886         Reviewed by Alex Christensen.
887
888         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
889         (WTR::TestController::platformRunUntil):
890
891 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
892
893         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
894         https://bugs.webkit.org/show_bug.cgi?id=181231
895
896         Reviewed by Alex Christensen.
897
898         Implement TestController APIs needed by ResourceLoadStatistics tests.
899
900         * WebKitTestRunner/TestController.cpp:
901         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
902         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
903
904 2018-01-02  Tim Horton  <timothy_horton@apple.com>
905
906         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
907         https://bugs.webkit.org/show_bug.cgi?id=181219
908
909         Reviewed by Wenson Hsieh.
910
911         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
912
913 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
914
915         Add a WebAuthentication runtime feature flag
916         https://bugs.webkit.org/show_bug.cgi?id=181220
917         <rdar://problem/36055305>
918
919         Reviewed by Brent Fulgham.
920
921         Renames the CredentialManagement runtime feature flag into WebAuthentication.
922
923         * DumpRenderTree/TestOptions.h:
924         * DumpRenderTree/TestOptions.mm:
925         (TestOptions::TestOptions):
926         * DumpRenderTree/mac/DumpRenderTree.mm:
927         (enableExperimentalFeatures):
928         (setWebPreferencesForTestOptions):
929         * WebKitTestRunner/TestController.cpp:
930         (WTR::TestController::resetPreferencesToConsistentValues):
931         (WTR::updateTestOptionsFromTestHeader):
932         * WebKitTestRunner/TestOptions.h:
933         (WTR::TestOptions::hasSameInitializationOptions const):
934
935 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
936
937         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
938         https://bugs.webkit.org/show_bug.cgi?id=181143
939         <rdar://problem/36200381>
940
941         Reviewed by Tim Horton.
942
943         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
944         attachment elements are enabled.
945
946         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
947         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
948         (TestWebKitAPI::TEST):
949
950 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
951
952         Update Credential Management API for WebAuthentication
953         https://bugs.webkit.org/show_bug.cgi?id=181082
954         <rdar://problem/36055239>
955
956         Reviewed by Brent Fulgham.
957
958         Enable Credential Management API for testing.
959
960         * DumpRenderTree/TestOptions.h:
961         * WebKitTestRunner/TestOptions.h:
962
963 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
964
965         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
966         https://bugs.webkit.org/show_bug.cgi?id=168194
967
968         Reviewed by Carlos Garcia Campos.
969
970         Fix an assertion and unskip the test. The order that form controls are associated is not
971         guaranteed.
972
973         * Scripts/run-gtk-tests:
974         (GtkTestRunner):
975         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
976         (didAssociateFormControlsCallback):
977
978 2018-01-02  Alex Christensen  <achristensen@webkit.org>
979
980         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
981         https://bugs.webkit.org/show_bug.cgi?id=180897
982         <rdar://problem/35535328>
983
984         Reviewed by Brent Fulgham.
985
986         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
987
988         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
989         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
990         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
991         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
992         (websiteDataStoreTestWebView):
993         (TEST):
994
995 == Rolled over to ChangeLog-2018-01-01 ==