1 2014-06-17 Tim Horton <timothy_horton@apple.com>
3 MiniBrowser should show Web Content process pids in the window title
4 https://bugs.webkit.org/show_bug.cgi?id=134016
6 Reviewed by Sam Weinig.
8 * MiniBrowser/mac/WK2BrowserWindowController.m:
9 (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
11 2014-06-17 Carlos Alberto Lopez Perez <clopez@igalia.com>
13 [GTK] Fix the handling of resize events after r169505.
14 https://bugs.webkit.org/show_bug.cgi?id=133517
16 Reviewed by Martin Robinson.
18 * Scripts/webkitpy/port/xvfbdriver.py:
19 (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
20 The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
21 need at least 900x640 pixels to pass.
22 * Scripts/webkitpy/port/xvfbdriver_unittest.py:
23 (XvfbDriverTest.test_start_no_pixel_tests): Update resolution.
24 (XvfbDriverTest.test_start_pixel_tests): Update resolution.
25 (XvfbDriverTest.test_start_arbitrary_worker_number): Update resolution.
26 (XvfbDriverTest.test_start_next_worker): Update resolution.
27 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
28 (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
29 be requested over the main widget instead of the window.
30 (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
32 (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
33 (WTR::PlatformWebView::setWindowFrame): Set the size and position
34 of the Window and the web view.
36 2014-06-17 Matthew Mirman <mmirman@apple.com>
38 Unreviewed. Added myself to list of contributors.
40 * Scripts/webkitpy/common/config/contributors.json: Added myself.
42 2014-06-17 Commit Queue <commit-queue@webkit.org>
44 Unreviewed, rolling out r170058.
45 https://bugs.webkit.org/show_bug.cgi?id=133993
47 Caused 4 webkitpy failures on the bots (Requested by bradee-oh
52 "[GTK] Fix the handling of resize events after r169505."
53 https://bugs.webkit.org/show_bug.cgi?id=133517
54 http://trac.webkit.org/changeset/170058
56 2014-06-17 Rebecca Hauck <rhauck@adobe.com>
58 Update import-w3c-tests to reflect current W3C test repo directory structure
59 https://bugs.webkit.org/show_bug.cgi?id=133460
61 Reviewed by Bem Jones-Bey.
63 Removed all references to test status, which are no longer reflected in the
64 directory names in the W3C CSS test repo. No tests are required for this
65 change, the existing tests pass.
67 * Scripts/webkitpy/w3c/test_importer.py:
69 (TestImporter.__init__):
70 (TestImporter.find_importable_tests):
71 (TestImporter.setup_destination_directory):
72 (TestImporter.write_import_log):
73 (TestImporter.update_test_status): Deleted.
75 2014-06-17 Carlos Alberto Lopez Perez <clopez@igalia.com>
77 [GTK] Fix the handling of resize events after r169505.
78 https://bugs.webkit.org/show_bug.cgi?id=133517
80 Reviewed by Martin Robinson.
82 * Scripts/webkitpy/port/xvfbdriver.py:
83 (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
84 The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
85 need at least 900x640 pixels to pass.
86 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
87 (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
88 be requested over the main widget instead of the window.
89 (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
91 (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
92 (WTR::PlatformWebView::setWindowFrame): Set the size and position
93 of the Window and the web view.
95 2014-06-17 Dan Bernstein <mitz@apple.com>
97 String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference
98 https://bugs.webkit.org/show_bug.cgi?id=133968
100 Reviewed by Anders Carlsson.
102 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
103 (TestWebKitAPI::TEST): Added a test that an isolated copy of an rvalue reference doesn’t
104 share an impl() with the original.
106 2014-06-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
108 [EFL][WK2] Skip failing EFL API tests
109 https://bugs.webkit.org/show_bug.cgi?id=133981
111 Reviewed by Csaba Osztrogonác.
113 UserMessage, WillLoad and test_ewk2_view have been failed since r169784.
115 * TestWebKitAPI/PlatformEfl.cmake:
117 2014-06-16 Ryuan Choi <ryuan.choi@samsung.com>
119 [EFL][WK2] Remove workaround for icon display bug in MiniBrowser
120 https://bugs.webkit.org/show_bug.cgi?id=133962
122 Reviewed by Gyuyoung Kim.
124 Since we bumped EFL to 1.9, this workaround is unnecessary.
126 * MiniBrowser/efl/main.c:
127 (update_view_favicon):
129 2014-06-16 Gwang Yoon Hwang <yoon@igalia.com>
131 [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
132 https://bugs.webkit.org/show_bug.cgi?id=131472
134 Reviewed by Martin Robinson.
136 This patch reapplies r167510 with fixes to add llvm as a dependency for llvmpipe.
138 * Scripts/webkitpy/port/xvfbdriver.py:
139 (XvfbDriver._start): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
140 when running WebKitTestRunner with the Xvfb driver.
141 * gtk/install-dependencies: Add LLVM as a dependency to build llvmpipe.
142 * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
144 * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
145 how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
146 calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
149 2014-06-16 Tanay C <tanay.c@samsung.com>
151 Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
152 https://bugs.webkit.org/show_bug.cgi?id=133792
154 Reviewed by Gyuyoung Kim.
156 * MiniBrowser/efl/main.c: replaced the deprecated API's with the latest ones
157 (show_file_entry_dialog):
160 2014-06-16 Mario Sanchez Prada <mario.prada@samsung.com>
162 [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard
163 https://bugs.webkit.org/show_bug.cgi?id=133512
165 Reviewed by Chris Fleizach.
167 Added support for connecting to AtkSelection's 'selection-changed'
168 signal, and print it out as AXSelectedChildrenChanged in the tests.
170 Also removed some dead code, that became useless after r169487.
172 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
173 (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated.
175 2014-06-15 Ryuan Choi <ryuan.choi@samsung.com>
177 [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
178 https://bugs.webkit.org/show_bug.cgi?id=133841
180 Reviewed by Gyuyoung Kim.
182 * MiniBrowser/efl/main.c:
185 2014-06-15 Dan Bernstein <mitz@apple.com>
187 Set the svn:ignore property on an Xcode project to ignore user and workspace data.
189 * jsc-cli/jsc-cli.xcodeproj: Added property svn:ignore.
191 2014-06-15 Anders Carlsson <andersca@apple.com>
195 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
196 (callRunJavaScriptBlockAndRelease):
197 (runJavaScriptInMainFrame):
200 2014-06-13 Xabier Rodriguez Calvar <calvaris@igalia.com>
202 Create MSE and EME watchlist
203 https://bugs.webkit.org/show_bug.cgi?id=133810
205 Reviewed by Eric Carlson.
207 * Scripts/webkitpy/common/config/watchlist: Create MSEEME
208 definition and add Eric Carlson and myself to it.
210 2014-06-12 Carlos Garcia Campos <cgarcia@igalia.com>
212 [GTK] Remove all deprecated API from GObject DOM bindings
213 https://bugs.webkit.org/show_bug.cgi?id=133728
215 Reviewed by Martin Robinson.
218 (WebKitDOMDocGenerator): Remove all deleted classes from the list.
219 (WebKitDOMDocGeneratorSections.__init__): Fix a typo in member initialization.
221 2014-06-12 Simon Fraser <simon.fraser@apple.com>
223 [iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
224 https://bugs.webkit.org/show_bug.cgi?id=133835
226 Reviewed by Tim Horton.
228 Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
230 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
231 (-[WebKitTestRunnerWindow initWithFrame:]):
232 (-[WebKitTestRunnerWindow setFrame:]):
234 2014-06-12 Carlos Alberto Lopez Perez <clopez@igalia.com>
236 [GTK] Performance tests should be always ran with WKTR.
237 https://bugs.webkit.org/show_bug.cgi?id=133780
239 Reviewed by Ryosuke Niwa.
241 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
242 (PerfTestsRunner.__init__): Enable webkit_test_runner when port
245 2014-06-12 Sergio Villar Senin <svillar@igalia.com>
247 [GTK] REGRESSION: application name is not correctly appended to the UA
248 https://bugs.webkit.org/show_bug.cgi?id=133793
250 Reviewed by Carlos Garcia Campos.
252 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
253 (testWebKitSettingsUserAgent):
255 2014-06-12 Sergio Villar Senin <svillar@igalia.com>
257 [GTK] Unsupported browser in www.icloud.com
258 https://bugs.webkit.org/show_bug.cgi?id=133403
260 Reviewed by Martin Robinson.
262 * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
263 (TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
264 quirk that was removed.
266 2014-06-11 Simon Fraser <simon.fraser@apple.com>
268 [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
269 https://bugs.webkit.org/show_bug.cgi?id=133779
271 Reviewed by Benjamin Poulain.
273 Tell the WebPage to use the testing viewport configuration from the injected bundle.
275 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
276 (WTR::InjectedBundle::didReceiveMessage): Code cleanup.
277 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
278 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
281 2014-06-11 Simon Fraser <simon.fraser@apple.com>
283 WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
284 https://bugs.webkit.org/show_bug.cgi?id=133770
286 Reviewed by Anders Carlsson.
288 Push the per-test view configuration up to TestController, so that platforms
289 can modify the behavior. This also allows platform-specific changes (e.g.
290 for threaded scrolling) to made without #ifefs.
292 * WebKitTestRunner/TestController.cpp:
293 (WTR::TestController::updateWebViewSizeForTest):
294 (WTR::TestController::updateWindowScaleForTest):
295 (WTR::shouldUseFixedLayout):
296 (WTR::TestController::updateLayoutTypeForTest):
297 (WTR::TestController::platformConfigureViewForTest):
298 (WTR::TestController::configureViewForTest):
299 * WebKitTestRunner/TestController.h:
300 * WebKitTestRunner/TestInvocation.cpp:
301 (WTR::TestInvocation::invoke):
302 (WTR::sizeWebViewForCurrentTest): Deleted.
303 (WTR::changeWindowScaleIfNeeded): Deleted.
304 (WTR::shouldUseThreadedScrolling): Deleted.
305 (WTR::updateThreadedScrollingForCurrentTest): Deleted.
306 (WTR::shouldUseFixedLayout): Deleted.
307 (WTR::updateLayoutType): Deleted.
308 * WebKitTestRunner/TestInvocation.h:
309 (WTR::TestInvocation::pathOrURL):
310 * WebKitTestRunner/ios/TestControllerIOS.mm:
311 (WTR::shouldMakeViewportFlexible):
312 (WTR::TestController::platformConfigureViewForTest):
313 * WebKitTestRunner/mac/TestControllerMac.mm:
314 (WTR::shouldUseThreadedScrolling):
315 (WTR::TestController::platformConfigureViewForTest):
317 2014-06-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
319 [EFL] Add dependencies packages to efl install-dependencies file
320 https://bugs.webkit.org/show_bug.cgi?id=133720
322 Reviewed by Csaba Osztrogonác.
324 After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
325 install doxygen and libssl-dev because efl 1.9 depends on those libraries.
327 * efl/install-dependencies:
329 2014-06-11 Zoltan Horvath <zoltan@webkit.org>
331 Unreviewed. Moving myself to the list of reviewers.
333 * Scripts/webkitpy/common/config/contributors.json:
335 2014-06-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
337 [EFL] Drop to maintain EFL 32bit release bot
338 https://bugs.webkit.org/show_bug.cgi?id=133710
340 Reviewed by Csaba Osztrogonác.
342 * BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
344 2014-06-11 Carlos Garcia Campos <cgarcia@igalia.com>
346 [GTK] Use a different user agent string depending on the site
347 https://bugs.webkit.org/show_bug.cgi?id=132681
349 Reviewed by Anders Carlsson.
351 Add a unit test to check user agent quirks.
353 * TestWebKitAPI/PlatformGTK.cmake:
354 * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
355 (TestWebKitAPI::TEST):
356 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
357 (testWebKitSettings): Site specific quirks setting is now enabled
360 2014-06-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
362 Unreviewed, update my list of email addresses in contributors.json.
364 * Scripts/webkitpy/common/config/contributors.json:
366 2014-06-10 Simon Fraser <simon.fraser@apple.com>
368 Always switch to an sRGB screen color profile when running tests
369 https://bugs.webkit.org/show_bug.cgi?id=133712
371 Reviewed by Tim Horton.
373 Switch the screen color profile to sRGB when running tests, because even ref
374 tests need the screen to use the correct color profile.
376 * DumpRenderTree/mac/LayoutTestHelper.m:
377 (installLayoutTestColorProfile):
378 * Scripts/webkitpy/port/mac.py:
379 (MacPort.start_helper):
381 2014-06-10 Martin Hodovan <mhodovan@partner.samsung.com>
383 [EFL] Bump EFL libraries to 1.9
384 https://bugs.webkit.org/show_bug.cgi?id=125479
386 Reviewed by Gyuyoung Kim.
388 Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
389 and László Langó <llango.u-szeged@partner.samsung.com>.
391 * ImageDiff/CMakeLists.txt:
392 * MiniBrowser/efl/CMakeLists.txt:
393 * efl/install-dependencies:
394 * efl/jhbuild.modules:
397 2014-06-10 David Farler <dfarler@apple.com>
399 old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
400 https://bugs.webkit.org/show_bug.cgi?id=133663
402 Reviewed by David Kilzer.
404 * Scripts/old-run-webkit-tests:
405 (installAndLaunchDumpToolAppUsingNotification):
406 - Remove obsolete notification keys
407 - Key off of mandatory device UDID (a UUID)
408 - Create a device on demand via CoreSimulator if necessary
409 -- Grab the UDID from the created device plist.
410 * Scripts/webkitdirs.pm:
411 (iOSSimulatorDevicesPath): Added
412 (iOSSimulatorDevices): Added
413 (createiOSSimulatorDevice): Added
414 (deleteiOSSimulatorDevice): Added
416 2014-06-10 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
418 [GTK][gtkdoc] remove -Wcast-align
419 https://bugs.webkit.org/show_bug.cgi?id=133640
421 Apparently gcc warns that GParamSpec is not castable to
422 GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
423 though ARM hackers claim that those only need 4byte alignment. As long as gcc
424 behaves that way, this warning is not very useful, also they break the Debian
427 This patch appends the compiler flag -Wno-align-cast for the gtkdoc
428 scanner compilation, thus the compiler ignores the previous
431 Reviewed by Martin Robinson.
433 * gtk/generate-gtkdoc:
434 (get_generator_for_config):
436 2014-06-09 Alexey Proskuryakov <ap@apple.com>
438 Disable button animations in regression tests
439 https://bugs.webkit.org/show_bug.cgi?id=133647
440 <rdar://problem/16677530>
442 Reviewed by Tim Horton.
444 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
445 (WTR::InjectedBundle::platformInitialize):
447 2014-06-09 Simon Fraser <simon.fraser@apple.com>
449 Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
450 https://bugs.webkit.org/show_bug.cgi?id=133650
452 Reviewed by Tim Horton.
454 No point checking for a Windows-style path in Cocoa code.
456 * WebKitTestRunner/TestInvocation.cpp:
457 (WTR::shouldUseThreadedScrolling):
459 2014-06-09 Simon Fraser <simon.fraser@apple.com>
461 Fix more latched scrolling test flakiness and slowness
462 https://bugs.webkit.org/show_bug.cgi?id=133601
464 Reviewed by Brent Fulgham.
466 Latched scrolling tests were flakey for two reasons. First, the EventSender
467 wheel events were async from the web to the UI process, and the resulting
468 synthetic events also async from the UI to the web process. Make them sync
471 Secondly, the timer-based scrolling tree commit could result in the scrolling
472 tree (specifically the frame node's notion of the scrollable area and content
473 size) not being updated before the scrolling thread starts getting wheel events.
474 Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
476 Finally remove all the now-unnecessary timeouts from the tests.
478 * WebKitTestRunner/mac/EventSenderProxy.mm:
479 (WTR::EventSenderProxy::mouseMoveTo):
480 (WTR::EventSenderProxy::mouseScrollBy):
481 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
483 2014-06-09 Andrzej Badowski <a.badowski@samsung.com>
485 [EFL] Add parameter to MiniBrowser to disable web security
486 https://bugs.webkit.org/show_bug.cgi?id=121095
488 Reviewed by Gyuyoung Kim.
490 -w (--web-security) commandline allows to disable/enable web security (enabled by default).
491 The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
492 resources from other domains (cross-domain requests) such as access map location on another server.
493 Another possibility is to launch in a webkit browser local file tests that will refer to the links
494 in the http website loaded in an iframe. It will not be possible without deactivation of web security.
496 * MiniBrowser/efl/main.c:
500 2014-06-06 Simon Fraser <simon.fraser@apple.com>
504 * WebKitTestRunner/mac/EventSenderProxy.mm:
505 (WTR::EventSenderProxy::mouseMoveTo):
506 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
508 2014-06-06 Simon Fraser <simon.fraser@apple.com>
510 Fix builds on 10.8; -firstObject isn't declared on NSArray there.
512 * DumpRenderTree/mac/DumpRenderTree.mm:
513 (createWebViewAndOffscreenWindow):
514 * DumpRenderTree/mac/EventSendingController.mm:
515 (-[EventSendingController mouseScrollByX:andY:continuously:]):
516 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
517 * WebKitTestRunner/mac/EventSenderProxy.mm:
518 (WTR::EventSenderProxy::mouseScrollBy):
519 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
521 2014-06-06 Simon Fraser <simon.fraser@apple.com>
523 Latched scrolling tests are flakey on Mavericks
524 https://bugs.webkit.org/show_bug.cgi?id=133578
525 <rdar://problem/17180591>
527 Reviewed by Brent Fulgham.
529 The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
530 be wrong on machines with more than one screen. This is because we use
531 [NSScreen mainScreen] when computing the global coordinates of the events, but
532 [NSScreen mainScreen] returns the screen with the key window, not the first screen.
534 So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
535 add comments clarifying why the coordinate math works (which is not obvious given
536 the events have no target window).
538 Some scrolling tests also dispatched events outside the 800x600 test window, so
539 fix those tests, and add logging that will appear in test output when this happens.
541 * DumpRenderTree/mac/DumpRenderTree.mm:
542 (createWebViewAndOffscreenWindow):
543 * DumpRenderTree/mac/EventSendingController.mm:
544 (-[EventSendingController mouseScrollByX:andY:continuously:]):
545 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
546 * WebKitTestRunner/mac/EventSenderProxy.mm:
547 (WTR::EventSenderProxy::mouseMoveTo):
548 (WTR::EventSenderProxy::mouseScrollBy):
549 (WTR::EventSenderProxy::continuousMouseScrollBy):
550 (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
552 2014-06-05 Carlos Alberto Lopez Perez <clopez@igalia.com>
554 [GTK] run-perf-tests should run the tests inside the jhbuild shell.
555 https://bugs.webkit.org/show_bug.cgi?id=133533
557 Reviewed by Carlos Garcia Campos.
559 * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
560 (run): Remove the jhbuild-wrapper wrapper from here. It should be
561 on Scripts/webkitpy/port/gtk.py.
562 * Scripts/webkitpy/port/base.py:
563 (Port.set_option): Add a set_option(name, value) function to set
564 the optparse parameter "name" to the value "value", even if the
565 parameter "name" is already initialized.
566 * Scripts/webkitpy/port/gtk.py:
567 (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
568 If another wrapper is specified via the option "-l --wrapper=x",
569 then prepend the jhbuild-wrapper to the one specified.
571 2014-06-04 David Farler <dfarler@apple.com>
573 Build ASan WebKit for iOS Simulator
574 https://bugs.webkit.org/show_bug.cgi?id=133489
576 Reviewed by Darin Adler.
578 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
579 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
580 - Add missing ASan LDFLAGS.
581 * asan/asan.xcconfig:
582 - Split compiler-rt linker flags for OS X and iOS Simulator
584 2014-06-03 Yoav Weiss <yoav@yoav.ws>
586 Add myself (yoav@yoav.ws) to contributors.json
587 https://bugs.webkit.org/show_bug.cgi?id=133492
589 * Scripts/webkitpy/common/config/contributors.json:
591 2014-06-03 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
593 REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
594 https://bugs.webkit.org/show_bug.cgi?id=133149
596 Reviewed by Csaba Osztrogonác.
598 * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
600 2014-06-02 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
602 Add a verbose flag to binding tests
603 https://bugs.webkit.org/show_bug.cgi?id=122303
605 Reviewed by Csaba Osztrogonác.
608 - Add a verbose keyword argument to the BindingsTests constructor,
609 - Add --no-verbose option to the run-bindigs-test.
610 Verbose mode, which is on by default, prints positive results to stdout as before.
611 When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
613 Original patch from Matthew Hanson <matthew_hanson@apple.com>
615 * Scripts/run-bindings-tests:
617 * Scripts/webkitpy/bindings/main.py:
618 (BindingsTests.__init__):
619 (BindingsTests.detect_changes):
621 2014-06-01 Ryosuke Niwa <rniwa@webkit.org>
623 Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
624 https://bugs.webkit.org/show_bug.cgi?id=133455
626 Reviewed by Timothy Hatcher.
628 Since the perf. dashboard doesn't support following renamed benchmarks,
629 keep reporting Speedometer results as DoYouEvenBench results.
631 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
632 (_generate_results_dict):
634 2014-05-31 Darin Adler <darin@apple.com>
636 Viewport percentage tests that resize the viewport are flaky
637 https://bugs.webkit.org/show_bug.cgi?id=133351
639 Reviewed by Anders Carlsson.
641 * DumpRenderTree/mac/DumpRenderTree.mm:
642 (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
643 happens to be stored in the UI delegate object. This is part of resetting the
646 * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
647 a frame rectangle. The size is stored in the size of the web view itself.
648 * DumpRenderTree/mac/UIDelegate.mm:
649 (-[UIDelegate resetWindowOrigin]): Added.
650 (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
651 old version would store the frame, but not resize the web view!
652 (-[UIDelegate webViewFrame:]): Get the size from the web view.
654 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
655 (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
657 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
658 (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
661 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
662 (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
663 window gets resized too, not just the web view.
664 (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
666 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
667 (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
668 window gets resized too, not just the web view.
669 (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
671 2014-05-30 Michael Saboff <msaboff@apple.com>
673 Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
674 https://bugs.webkit.org/show_bug.cgi?id=133409
676 Reviewed by Filip Pizlo.
678 Handle creating a tarball the same way as running remote when processing
679 paths in prepareBundle.
681 * Scripts/run-jsc-stress-tests:
683 2014-05-30 Mario Sanchez Prada <mario.prada@samsung.com>
685 [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
686 https://bugs.webkit.org/show_bug.cgi?id=132280
688 Reviewed by Chris Fleizach.
690 Remove implementation of logAccessibilityEvents() for ATK based
691 ports, as this has proved to be a flaky method of checking that
692 ATK events are being properly emitted. Instead, it's better to use
693 the addNotificationListener() functions and provide a JS callback
694 to check that the right events are being emmitted from the tests.
696 * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
697 (WTR::AccessibilityController::logAccessibilityEvents): Replaced
698 with dummy implementation.
699 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
700 (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
702 2014-05-30 Mario Sanchez Prada <mario.prada@samsung.com>
704 [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
705 https://bugs.webkit.org/show_bug.cgi?id=132280
707 Rubber stamped by Carlos Garcia Campos.
709 Fix two small issues with previous patch (r169483), that caused some tests to break.
711 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
712 (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
714 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
715 (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
717 2014-05-30 Jarek Czekalski <jarekczek@poczta.onet.pl>
719 [ATK] Added new accessibility signal: text-caret-moved.
720 Make AccessibilityUIElement.setSelectedTextRange work
721 as atk_text_set_caret_offset when given offset == 0.
722 https://bugs.webkit.org/show_bug.cgi?id=132527
724 Reviewed by Mario Sanchez Prada.
726 text-caret-moved signal in accessibilityController is needed to
727 implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
728 as LayoutTests. Add the signal to the controller.
730 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
731 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
732 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
733 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
734 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
735 (setSelectedTextRange): Change return type to bool.
736 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
737 (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
738 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
739 (axObjectEventListener): Add notification name AXTextCaretMoved, allow
740 for extra arguments passed to handler and use it for text-caret-moved offset.
741 (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
742 Connect callback to new listener for ATK:AtkText:text-caret-moved.
743 Refactor so that failures be reported.
744 Initialize atk interfaces before trying to connect to them, see
745 https://bugzilla.gnome.org/show_bug.cgi?id=729922
746 (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
747 Simplify code by using a vector in place of dozen variables.
748 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
749 Comment about not synchronizing with accessibilityController.
751 2014-05-29 Carlos Alberto Lopez Perez <clopez@igalia.com>
753 [GTK] Add a WebKit2 Performance bot.
754 https://bugs.webkit.org/show_bug.cgi?id=132862
756 Reviewed by Csaba Osztrogonác.
758 This adds a GTK WebKit2 perf bot.
760 * BuildSlaveSupport/build.webkit.org-config/config.json:
762 2014-05-29 Dan Bernstein <mitz@apple.com>
764 Fixed the WebKitTestRunner build after r169452.
766 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
767 (WTR::InjectedBundle::initialize):
769 2014-05-28 Gwang Yoon Hwang <yoon@igalia.com>
771 Unreviewed. Update my email addresses in contributors.json.
773 * Scripts/webkitpy/common/config/contributors.json:
775 2014-05-27 Jon Honeycutt <jhoneycutt@apple.com>
777 Need an API test for bug #133193 (r169315)
778 <https://bugs.webkit.org/show_bug.cgi?id=133324>
780 This adds an API test that ensures that calling "stop loading" during a
781 "did fail provisional load" callback doesn't crash.
783 Reviewed by Andy Estes.
785 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
786 Add new files to project.
788 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
789 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
790 If the message is the "test done" message, record that.
791 (TestWebKitAPI::setInjectedBundleClient):
792 Register a function for the "did receive message from injected bundle"
794 (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
795 Assert that we received the message from the injected bundle, and set
796 'done' to finish the test.
797 (TestWebKitAPI::TEST):
798 Create a WebView, register a page loader client for the "did fail
799 provisional load" callback, and load a non-existent resource.
801 * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
802 (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
803 (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
804 Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
805 provisional load failed.
806 (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
807 Register a page loader client for the "did fail provisional load"
809 (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
810 Call WKBundlePageStopLoading() during the callback. This not crashing
811 is what we're ensuring with this test.
813 2014-05-28 Carlos Garcia Campos <cgarcia@igalia.com>
815 [GTK] Make it possible to build with FTL enabled
816 https://bugs.webkit.org/show_bug.cgi?id=133219
818 Reviewed by Philippe Normand.
820 * gtk/jhbuild-optional.modules: Add llvm from svn and build the
821 same revision than mac.
823 2014-05-27 Michael Saboff <msaboff@apple.com>
825 REGRESSION(r169265): sh: line 0: cd: ../.vm
826 https://bugs.webkit.org/show_bug.cgi?id=133242
828 Rubber stamped by Oliver Hunt.
830 Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
831 array since the command may contain character escapes that don't work with the
832 array form of system().
834 * Scripts/run-jsc-stress-tests:
836 2014-05-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
838 [EFL] Change download url of freetype6
839 https://bugs.webkit.org/show_bug.cgi?id=133303
841 Reviewed by Csaba Osztrogonác.
843 freetype6 tarball isn't downloaded in Korea. So, we need to
844 change the url for now.
846 * efl/jhbuild.modules:
848 2014-05-27 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
851 https://bugs.webkit.org/show_bug.cgi?id=132863
853 Reviewed by Csaba Osztrogonác.
855 * Scripts/webkitperl/FeatureList.pm:
857 2014-05-27 Alberto Garcia <berto@igalia.com>
859 Remove leftover comment from r165182.
861 Rubber stamped by Carlos Garcia Campos.
863 * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
865 2014-05-26 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
867 [EFL] Add LLVM as optional jhbuild module for FTL developers
868 https://bugs.webkit.org/show_bug.cgi?id=133216
870 Reviewed by Gyuyoung Kim.
872 * efl/jhbuild.modules:
874 2014-05-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
876 Fix test failures on python test
877 https://bugs.webkit.org/show_bug.cgi?id=133297
879 Reviewed by Dirk Schulze.
881 2 tests are failing because of unbounded local variable reference in test_importer.py.
883 * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
884 (TestImporter.import_tests):
886 2014-05-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
888 [GTK] GObject DOM bindings API break test fails in the tests bots
889 https://bugs.webkit.org/show_bug.cgi?id=133211
891 Reviewed by Martin Robinson.
893 When generating the built product archive on platform GTK, we need
894 to copy also the file gtkdoc-webkitdom.cfg and the directory
895 DerivedSources/webkitdom.
897 * BuildSlaveSupport/built-product-archive:
898 (archiveBuiltProduct):
900 2014-05-26 Commit Queue <commit-queue@webkit.org>
902 Unreviewed, rolling out r169122.
903 https://bugs.webkit.org/show_bug.cgi?id=133288
905 Broke CJK font fallback (Requested by ap on #webkit).
909 "[Mac] WebProcess doesn't follow localization of UI process
910 when run as a service"
911 https://bugs.webkit.org/show_bug.cgi?id=133126
912 http://trac.webkit.org/changeset/169122
914 2014-05-26 Carlos Garcia Campos <cgarcia@igalia.com>
916 [GTK] WebProcess leaked when closing pages with network process enabled
917 https://bugs.webkit.org/show_bug.cgi?id=129684
919 Reviewed by Anders Carlsson.
921 Enable the test to check that web processes finish when the web
924 * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
926 2014-05-26 Carlos Garcia Campos <cgarcia@igalia.com>
928 REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
929 https://bugs.webkit.org/show_bug.cgi?id=133279
931 Reviewed by Philippe Normand.
933 generator.saw_warnings is only set by GTKDoc::generate(), so it
934 should only be used after generate.
936 * gtk/generate-gtkdoc:
937 (generate_documentation_for_config): Do not check
938 generator.saw_warnings again, simply return the value returned by
939 generate_doc() which is generator.saw_warnings. When rebasing,
940 returns always False since there aren't warnings.
942 2014-05-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
944 W3C test importer should catch exceptions coming from HTML/CSS conversion
945 https://bugs.webkit.org/show_bug.cgi?id=133176
947 Reviewed by Darin Adler.
949 Exceptions raised when converting HTML/CSS are caught.
950 Files for which conversion failed are still copied to the target directory.
951 Each individual conversion failure is logged.
952 Total conversion failure number is logged at the end of the import process.
954 * Scripts/webkitpy/w3c/test_importer.py:
955 (TestImporter.import_tests):
957 2014-05-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
959 [GTK] Allow to run the tests on the native X display.
960 https://bugs.webkit.org/show_bug.cgi?id=133157
962 Reviewed by Benjamin Poulain.
964 This adds a new driver (xorgdriver) that runs the tests on the
965 X display referenced by the environment variable DISPLAY.
967 This new driver will be activated only if the environment variable
968 USE_NATIVE_XDISPLAY is defined. This can be used both for layout
969 tests and performance tests.
971 This patch also makes the script run-perf-tests to check the
972 system dependencies before starting the tests. Previously this
973 was not checked, and if the system dependencies were not met,
974 the script tried to execute the tests anyway, causing massive
975 failures. For example, if you had Xvfb not installed and you
976 wanted to use the Xvfb driver (the default on GTK and EFL),
977 run-perf-tests would not abort.
979 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
980 (PerfTestsRunner._parse_args): Check the system dependencies of
981 the driver before starting the tests.
982 * Scripts/webkitpy/port/driver.py:
983 (Driver): Implement generic check_driver method.
984 (Driver.check_driver):
985 (Driver.check_driver.implementation):
986 * Scripts/webkitpy/port/gtk.py:
987 (GtkPort._driver_class): Check for environment variable
988 USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
989 * Scripts/webkitpy/port/xorgdriver.py: Added.
990 (XorgDriver): Implement Xorg driver.
991 (XorgDriver.check_driver):
994 2014-05-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
996 REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
997 https://bugs.webkit.org/show_bug.cgi?id=133215
999 Reviewed by Csaba Osztrogonác.
1001 This reverts r166798.
1003 * BuildSlaveSupport/kill-old-processes:
1006 2014-05-26 Michał Pakuła vel Rutka <m.pakula@samsung.com>
1008 [EFL] Turn on ENABLE_CSS_FILTERS in build script
1009 https://bugs.webkit.org/show_bug.cgi?id=133278
1011 Reviewed by Gyuyoung Kim.
1013 * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
1015 2014-05-26 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1017 run-javascriptcore-tests warning fix on non Mac platforms
1018 https://bugs.webkit.org/show_bug.cgi?id=133260
1020 Reviewed by Darin Adler.
1022 * Scripts/webkitdirs.pm:
1023 (argumentsForConfiguration):
1025 2014-05-23 Michael Saboff <msaboff@apple.com>
1027 REGRESSION(r169265): sh: line 0: cd: ../.vm
1028 https://bugs.webkit.org/show_bug.cgi?id=133242
1030 Rubber stamped by Geoffrey Garen.
1032 Added missing shell escapes '\' required as part of previous fix.
1034 * Scripts/run-jsc-stress-tests:
1036 2014-05-23 Ryosuke Niwa <rniwa@webkit.org>
1038 Revert the erroneous change committed in r169286.
1040 * Scripts/webkitpy/performance_tests/perftest.py:
1041 (PerfTest._run_with_driver):
1043 2014-05-23 Geoffrey Garen <ggaren@apple.com>
1045 run-perf-tests should ignore whitespace lines when snarfing test output
1046 https://bugs.webkit.org/show_bug.cgi?id=133238
1048 Reviewed by Ryosuke Niwa.
1050 Required for PerformanceTests/Canvas/terrain.html.
1052 * Scripts/webkitpy/performance_tests/perftest.py:
1053 (PerfTest._run_with_driver):
1056 2014-05-23 Michael Saboff <msaboff@apple.com>
1058 REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
1059 https://bugs.webkit.org/show_bug.cgi?id=133223
1061 Reviewed by Geoffrey Garen.
1063 Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
1064 string before calling IO.popen() to work with older versions of ruby.
1065 Changed the remote path in runShellTestRunner to quote the command
1066 string we want to run via ssh so that it will work correctly with array
1067 to string conversion needed for popen.
1069 * Scripts/run-jsc-stress-tests:
1071 2014-05-23 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
1073 Remove 'css-shaders' option from the build-webkit
1074 https://bugs.webkit.org/show_bug.cgi?id=133212
1076 Reviewed by Daniel Bates.
1078 Original CSS shaders removed in r162644.
1080 * Scripts/webkitperl/FeatureList.pm:
1082 2014-05-23 Carlos Garcia Campos <cgarcia@igalia.com>
1084 [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
1085 https://bugs.webkit.org/show_bug.cgi?id=133209
1087 Reviewed by Sergio Villar Senin.
1089 Return FAILURE when the command failed to run.
1091 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1092 (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
1094 2014-05-23 Alberto Garcia <berto@igalia.com>
1096 [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
1097 https://bugs.webkit.org/show_bug.cgi?id=133210
1099 Reviewed by Carlos Garcia Campos.
1101 * gtk/install-dependencies:
1103 2014-05-22 Benjamin Poulain <bpoulain@apple.com>
1105 Add Yusuke Suzuki to the list of contributors (for real)
1109 * Scripts/webkitpy/common/config/contributors.json:
1111 2014-05-22 Benjamin Poulain <bpoulain@apple.com>
1113 Add Yusuke Suzuki to the list of contributors
1115 * Scripts/webkitpy/common/config/contributors.json:
1117 2014-05-22 Michael Saboff <msaboff@apple.com>
1119 Eliminate n/total progress update from run-jsc-stress-tests output to file
1120 https://bugs.webkit.org/show_bug.cgi?id=133191
1122 Reviewed by Geoffrey Garen.
1124 Changed progressMeter setting to be based on stdout being a tty instead of
1125 stdin. Unified the processing of output from the shell runner to match the
1126 same processing as is used by the makefile runner. As part of this, the
1127 shell runner script was simplified. It now forwards the output of each
1128 test_script just like the Makefile and doesn't provide its own progress.
1130 * Scripts/jsc-stress-test-helpers/shell-runner.sh:
1131 * Scripts/run-jsc-stress-tests:
1133 2014-05-22 Michael Saboff <msaboff@apple.com>
1135 Add option to run-jsc-stress-tests to use installed jsc
1136 https://bugs.webkit.org/show_bug.cgi?id=133102
1138 Reviewed by Geoffrey Garen.
1140 Added --no-copy option to not copy a JavaScriptCore framework, but use the one
1141 provied with the --jsc option.
1143 * Scripts/run-jsc-stress-tests:
1145 2014-05-21 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
1147 [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
1148 https://bugs.webkit.org/show_bug.cgi?id=132907
1150 Reviewed by Gyuyoung Kim.
1152 We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
1153 in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
1155 * efl/install-dependencies:
1157 2014-05-21 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1159 REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
1160 https://bugs.webkit.org/show_bug.cgi?id=133145
1162 Reviewed by Csaba Osztrogonác.
1164 * Scripts/run-jsc-stress-tests:
1166 2014-05-20 Alexey Proskuryakov <ap@apple.com>
1168 [Mac] WebProcess doesn't follow localization of UI process when run as a service
1169 https://bugs.webkit.org/show_bug.cgi?id=133126
1170 <rdar://problem/13396515>
1171 <rdar://problem/16561084>
1173 Reviewed by Sam Weinig and Tim Horton.
1175 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1176 (WTR::InjectedBundle::platformInitialize): It was too late to override language
1177 here, and it's not necessary any more. Keeping the code for older OS versions in
1178 case it did have effect in some code paths.
1180 2014-05-19 David Farler <dfarler@apple.com>
1182 Move WebKitTestRunner to std::unique_ptr
1183 https://bugs.webkit.org/show_bug.cgi?id=133081
1185 Reviewed by Daniel Bates.
1187 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1188 (WTR::InjectedBundle::didCreatePage):
1189 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1190 * WebKitTestRunner/TestController.cpp:
1191 (WTR::TestController::initialize):
1192 (WTR::TestController::createWebViewWithOptions):
1193 (WTR::TestController::resetStateToConsistentValues):
1194 (WTR::TestController::runTest):
1195 * WebKitTestRunner/TestController.h:
1196 * WebKitTestRunner/TestInvocation.cpp:
1197 * WebKitTestRunner/TestInvocation.h:
1198 * WebKitTestRunner/WorkQueueManager.cpp:
1199 (WTR::WorkQueueManager::processWorkQueue):
1200 (WTR::WorkQueueManager::enqueue):
1201 * WebKitTestRunner/WorkQueueManager.h:
1203 2014-05-20 Carlos Garcia Campos <cgarcia@igalia.com>
1205 [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
1206 https://bugs.webkit.org/show_bug.cgi?id=133119
1208 Reviewed by Sergio Villar Senin.
1210 Check that redirect response parameter of
1211 WebKitWebPage::send-request signal is NULL when not redirecting
1212 and a valid WebKitURIResponse object when redirecting.
1214 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1215 (testWebResourceSendRequest):
1217 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1218 (sendRequestCallback):
1220 2014-05-20 Carlos Garcia Campos <cgarcia@igalia.com>
1222 REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
1223 https://bugs.webkit.org/show_bug.cgi?id=133117
1225 Reviewed by Philippe Normand.
1227 Bring back missing tests to the build.
1229 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1231 2014-05-19 Filip Pizlo <fpizlo@apple.com>
1233 Take care of some ARM64 test failures
1234 https://bugs.webkit.org/show_bug.cgi?id=133090
1236 Reviewed by Geoffrey Garen.
1238 * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
1240 2014-05-19 David Kilzer <ddkilzer@apple.com>
1242 [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
1243 <http://webkit.org/b/133089>
1245 Reviewed by Darin Adler.
1247 * Scripts/webkitdirs.pm:
1248 (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
1249 specified on the command line, we would remove the '--sdk'
1250 arguments, but leave '--sim', potentially passing it along to
1251 xcodebuild causing a build failure. This happens when
1252 'old-run-webkit-tests --release --sim' invokes
1253 build-dumprendertree when DumpRenderTree hasn't been built yet.
1255 2014-05-19 David Farler <dfarler@apple.com>
1257 Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
1258 https://bugs.webkit.org/show_bug.cgi?id=133086
1260 Reviewed by Daniel Bates.
1262 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1264 2014-05-19 David Kilzer <ddkilzer@apple.com>
1266 REGRESSION (r169042): Fix run-api-tests on Mountain Lion
1267 <http://webkit.org/b/132954>
1269 * Scripts/webkitdirs.pm:
1270 (sharedCommandLineOptionsUsage): Remove the prototype for the
1271 subroutine. Older perls don't like the "+@" syntax.
1273 2014-05-19 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1275 run-javascriptcore-tests should sort the list of failing stress tests
1276 https://bugs.webkit.org/show_bug.cgi?id=132989
1278 Reviewed by Csaba Osztrogonác.
1280 * Scripts/run-javascriptcore-tests:
1282 2014-05-19 David Kilzer <ddkilzer@apple.com>
1284 webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
1285 <http://webkit.org/b/132954>
1287 Reviewed by Darin Adler.
1289 Extract code into setupMacWebKitEnvironment() for setting up
1290 common environment variables so it may be shared. Sets
1291 __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
1292 using guardmalloc to some scripts.
1294 Also adds support for parsing shared (common) command-line
1295 switches, initially just -g|--guard-malloc.
1297 * Scripts/bisect-builds: Add -g|--guard-malloc support by using
1298 sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1299 (mountAndRunNightly): Call setupMacWebKitEnvironment(). Use a
1300 local copy of %ENV when launching Safari so we don't have to
1303 * Scripts/run-api-tests: Add -g|--guard-malloc support by using
1304 sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
1305 Check result of GetOptions() to catch invalid command-line
1307 (runTest): Use a local copy of %ENV when running tests so we
1308 don't have to restore variables.
1309 (prepareEnvironmentForRunningTestTool): Call
1310 setupMacWebKitEnvironment().
1312 * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
1313 using sharedCommandLineOptions() and
1314 sharedCommandLineOptionsUsage(). Call
1315 setupMacWebKitEnvironment().
1317 * Scripts/webkitdirs.pm:
1318 (sharedCommandLineOptions): Return array of common switches to
1319 pass to Getopt::Long::GetOptions().
1320 (sharedCommandLineOptionsUsage): Return formatted string of
1321 common switches for printing usage help text.
1322 (setUpGuardMallocIfNeeded): Support using '-g' for enabling
1324 (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
1325 (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
1326 and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
1327 (runMacWebKitApp): Call setupMacWebKitEnvironment(). Use a
1328 local copy of %ENV when launching Safari so we don't have to
1330 (execMacWebKitAppForDebugging): Call
1331 setupMacWebKitEnvironment().
1333 2014-05-18 Rik Cabanier <cabanier@adobe.com>
1335 support for navigator.hardwareConcurrency
1336 https://bugs.webkit.org/show_bug.cgi?id=132588
1338 Reviewed by Filip Pizlo.
1340 * Scripts/webkitperl/FeatureList.pm:
1342 2014-05-18 Anders Carlsson <andersca@apple.com>
1344 Implement Navigations for all methods declared returning one
1345 https://bugs.webkit.org/show_bug.cgi?id=133048
1346 <rdar://problem/16830064>
1348 Reviewed by Sam Weinig.
1350 * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1353 * MiniBrowser/mac/WK2BrowserWindowController.m:
1354 (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
1355 (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
1356 (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
1357 (-[WK2BrowserWindowController webView:didCommitNavigation:]):
1358 (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
1359 (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
1360 Print out the navigations.
1362 2014-05-17 Zalan Bujtas <zalan@apple.com>
1364 Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
1365 https://bugs.webkit.org/show_bug.cgi?id=133029
1367 Reviewed by Simon Fraser.
1369 Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
1370 toggling it on a WK2 window needs restart.
1371 Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
1372 the WebPreferences just to support this temporary toggle.
1374 * MiniBrowser/mac/BrowserWindowController.h:
1375 * MiniBrowser/mac/MainMenu.xib:
1376 * MiniBrowser/mac/WK1BrowserWindowController.m:
1377 (-[WK1BrowserWindowController validateMenuItem:]):
1378 (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1379 (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1380 * MiniBrowser/mac/WK2BrowserWindowController.m:
1381 (-[WK2BrowserWindowController validateMenuItem:]):
1382 (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
1383 (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
1385 2014-05-17 Anders Carlsson <andersca@apple.com>
1387 Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
1388 https://bugs.webkit.org/show_bug.cgi?id=133033
1389 <rdar://problem/16830143>
1391 Reviewed by Sam Weinig.
1393 Set up the WebSQL and IndexedDB directories.
1395 * WebKitTestRunner/TestController.cpp:
1396 (WTR::TestController::initialize):
1398 2014-05-16 Martin Hock <mhock@apple.com>
1400 MemoryCache::addImageToCache should return the result of add().
1401 https://bugs.webkit.org/show_bug.cgi?id=132928
1402 <rdar://problem/16651547>
1404 Reviewed by Alexey Proskuryakov.
1406 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1407 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1408 * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
1409 (TestWebKitAPI::TEST):
1411 2014-05-15 David Farler <dfarler@apple.com>
1413 old-run-webkit-tests: allow specifying a simulator app path
1414 https://bugs.webkit.org/show_bug.cgi?id=132975
1416 Reviewed by Anders Carlsson.
1418 * Scripts/old-run-webkit-tests:
1419 (openIPhoneSimulator):
1420 Add new --simulator-app command line parameter for specifying the
1421 absolute path to the simulator app to launch before starting a
1424 2014-05-16 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1426 [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
1427 https://bugs.webkit.org/show_bug.cgi?id=131363
1429 Reviewed by Csaba Osztrogonác.
1431 * Scripts/webkitpy/common/checkout/checkout_mock.py:
1432 * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1434 * Scripts/webkitpy/tool/commands/download_unittest.py:
1435 (test_create_rollout_multiple_revision_with_one_resolved):
1436 (test_create_rollout_multiple_resolved):
1437 (test_rollout_two_revisions):
1438 (test_rollout_multiple_revisions):
1439 (test_rollout_multiple_revisions_with_a_missing_bug_id):
1440 * Scripts/webkitpy/tool/steps/createbug.py:
1442 * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1443 (ReopenBugAfterRollout.run):
1445 2014-05-16 Martin Hodovan <mhodovan.u-szeged@partner.samsung.com>
1447 [WK2] Change the remaining framework includes from WebKit2 to WebKit
1448 https://bugs.webkit.org/show_bug.cgi?id=132956
1450 Reviewed by Sam Weinig.
1452 * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
1453 * MiniBrowser/mac/AppDelegate.m:
1454 * MiniBrowser/mac/WK2BrowserWindowController.m:
1455 * TestWebKitAPI/InjectedBundleController.h:
1456 * TestWebKitAPI/InjectedBundleMain.cpp:
1457 * TestWebKitAPI/JavaScriptTest.cpp:
1458 * TestWebKitAPI/PlatformUtilities.h:
1459 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1460 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1461 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1462 * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1463 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1464 (TestWebKitAPI::TEST):
1465 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1466 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
1467 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1468 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1469 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1470 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1471 * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1472 * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1473 * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1474 * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1475 * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1476 * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1477 * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1478 * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1479 * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1480 * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1481 * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1482 * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1483 * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1484 * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1485 * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1486 * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
1487 * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1488 * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1489 * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1490 * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1491 * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1492 * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1493 * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1494 * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
1495 * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1496 * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1497 * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1498 * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1499 * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1500 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1501 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1502 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
1503 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1504 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
1505 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1506 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
1507 * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
1508 * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1509 * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1510 * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1511 * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1512 * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1513 * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1514 * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1515 * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1516 * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1517 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1518 * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1519 * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1520 * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1521 * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1522 * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1523 * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1524 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1525 * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1526 * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1527 * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1528 * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1529 * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1530 * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1531 * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
1532 * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1533 * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1534 * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
1535 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1536 * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1537 * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1538 * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1539 * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1540 * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1541 * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1542 * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1543 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1544 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1545 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1546 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1547 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1548 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1549 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1550 * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1551 * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1552 * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1553 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1554 * TestWebKitAPI/config.h:
1555 * TestWebKitAPI/efl/PlatformWebView.cpp:
1556 * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1557 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1558 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1559 * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1560 * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1561 * WebKitTestRunner/EventSenderProxy.h:
1562 * WebKitTestRunner/GeolocationProviderMock.cpp:
1563 * WebKitTestRunner/GeolocationProviderMock.h:
1564 * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1565 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1566 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1567 * WebKitTestRunner/InjectedBundle/GCController.cpp:
1568 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1569 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1570 * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1571 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1572 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1573 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1574 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1575 * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
1576 * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1577 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1578 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1579 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1580 * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1581 * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
1582 * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1583 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1584 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1585 * WebKitTestRunner/PlatformWebView.h:
1586 * WebKitTestRunner/StringFunctions.h:
1587 * WebKitTestRunner/TestController.cpp:
1588 * WebKitTestRunner/TestController.h:
1589 * WebKitTestRunner/TestInvocation.cpp:
1590 * WebKitTestRunner/TestInvocation.h:
1591 * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1592 * WebKitTestRunner/WebNotificationProvider.cpp:
1593 * WebKitTestRunner/WebNotificationProvider.h:
1594 * WebKitTestRunner/WorkQueueManager.cpp:
1595 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1596 * WebKitTestRunner/cg/TestInvocationCG.cpp:
1597 * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1598 * WebKitTestRunner/config.h:
1599 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1600 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1601 * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1602 * WebKitTestRunner/ios/TestControllerIOS.mm:
1603 * WebKitTestRunner/mac/EventSenderProxy.mm:
1604 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1605 * WebKitTestRunner/mac/TestControllerMac.mm:
1607 2014-05-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1609 [EFL][WK2] Skip failing unit tests
1610 https://bugs.webkit.org/show_bug.cgi?id=132979
1612 Reviewed by Daniel Bates.
1614 * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
1616 2014-05-15 David Kilzer <ddkilzer@apple.com>
1618 [iOS] Support TestWebKitAPI in the iOS Simulator
1619 <http://webkit.org/b/129535>
1620 <rdar://problem/16203529>
1622 Reviewed by Daniel Bates.
1624 * Scripts/run-api-tests:
1627 - Extract common arguments into local variable.
1628 - Use xcrun to find the sim tool in order to invoke
1629 TestWebKitAPI properly in the iOS Simulator.
1631 * Scripts/webkitdirs.pm:
1632 (argumentsForConfiguration): Set --device or --sim as
1633 appropriate to fix buildTestTool() in run-api-tests.
1635 2014-05-15 Tim Horton <timothy_horton@apple.com>
1637 Fix a logging typo in copy-webkitlibraries-to-product-directory
1639 Reviewed by Dean Jackson.
1641 * Scripts/copy-webkitlibraries-to-product-directory:
1643 2014-05-15 David Kilzer <ddkilzer@apple.com>
1645 TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
1646 <http://webkit.org/b/132959>
1648 Reviewed by Dan Bernstein.
1650 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1651 Cocoa directory to project and move URLExtras.mm into it.
1652 * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
1654 2014-05-15 Carlos Garcia Campos <cgarcia@igalia.com>
1656 [GTK] Compile all installed resources as GResources
1657 https://bugs.webkit.org/show_bug.cgi?id=131099
1659 Reviewed by Philippe Normand.
1661 * Scripts/webkitpy/port/gtk.py:
1662 (GtkPort.setup_environ_for_server): Removed now unneeded
1663 AUDIO_RESOURCES_PATH env var.
1665 2014-05-14 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
1667 Remove CSS_STICKY_POSITION guards
1668 https://bugs.webkit.org/show_bug.cgi?id=132676
1670 Reviewed by Simon Fraser.
1672 * Scripts/webkitperl/FeatureList.pm:
1674 2014-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
1676 REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
1677 https://bugs.webkit.org/show_bug.cgi?id=132686
1679 Reviewed by Philippe Normand.
1681 Bring back InputMethodFilter test to the build and compile it into
1682 a single binary TestWebCore with the other WebCore tests. Also
1683 move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
1685 * Scripts/run-gtk-tests:
1686 (TestRunner): Remove WebCoreGtk from the list of test directories.
1687 * TestWebKitAPI/PlatformGTK.cmake:
1688 * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
1690 2014-05-14 Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com>
1692 [EFL] Make XVFBDriver optional
1693 https://bugs.webkit.org/show_bug.cgi?id=131036
1695 Reviewed by Gyuyoung Kim.
1697 * Scripts/webkitpy/port/efl.py:
1698 (EflPort._driver_class):
1700 2014-05-13 Carlos Alberto Lopez Perez <clopez@igalia.com>
1702 Flakiness dashboard contains outdated list of bots on builders.jsonp
1703 https://bugs.webkit.org/show_bug.cgi?id=132874
1705 Reviewed by Darin Adler.
1707 * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
1708 file by changing to the directory Tools/TestResultServer and executing
1709 the script generate_builders_json.py
1711 2014-05-11 Anders Carlsson <andersca@apple.com>
1713 Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
1714 https://bugs.webkit.org/show_bug.cgi?id=132809
1716 Reviewed by Dan Bernstein.
1718 * WebKitTestRunner/TestController.cpp:
1719 (WTR::TestController::initialize):
1720 Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
1722 2014-05-12 Carlos Garcia Campos <cgarcia@igalia.com>
1724 REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
1725 https://bugs.webkit.org/show_bug.cgi?id=132739
1727 Reviewed Anders Carlsson.
1729 * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
1731 * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
1733 2014-05-11 Anders Carlsson <andersca@apple.com>
1735 Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
1736 https://bugs.webkit.org/show_bug.cgi?id=132806
1738 Reviewed by Beth Dakin.
1740 Migrate to WKContextConfiguration.
1742 * WebKitTestRunner/TestController.cpp:
1743 (WTR::TestController::initialize):
1745 2014-05-10 Carlos Garcia Campos <cgarcia@igalia.com>
1747 REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
1748 https://bugs.webkit.org/show_bug.cgi?id=132685
1750 Reviewed by Martin Robinson.
1752 Use a single TestWebKit2 binary for all WebKit2 C API tests.
1754 * TestWebKitAPI/PlatformGTK.cmake:
1756 2014-05-09 Benjamin Poulain <benjamin@webkit.org>
1758 [iOS] Switch geolocation to an explicit authorization query model
1759 https://bugs.webkit.org/show_bug.cgi?id=132717
1761 Reviewed by Sam Weinig.
1763 * DumpRenderTree/mac/MockGeolocationProvider.mm:
1764 (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
1765 (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
1767 2014-05-09 David Farler <dfarler@apple.com>
1769 com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
1770 https://bugs.webkit.org/show_bug.cgi?id=132718
1772 Reviewed by David Kilzer.
1774 The simulator may not be able to look up runtimes by SDK paths
1775 and instead will map SDK versions to runtimes instead. In
1776 com.apple.iphonesimulator.startSession notifications,
1777 'runtimeIdentifier' (SDK version string) is preferred over
1778 'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
1779 when creating a new DRT or WKTR simulator session.
1781 IPhoneSimulatorNotification.pm filters out keys for this
1782 notification's userInfo with a hard-coded list. There's no harm
1783 in including extra key-value pairs in an NSNotification userInfo
1784 dictionary anyway and the simulator may again change its
1785 userInfo schema for this notification.
1787 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
1788 (postStartSessionNotification):
1789 * Scripts/old-run-webkit-tests:
1790 (installAndLaunchDumpToolAppUsingNotification):
1792 2014-05-09 Anders Carlsson <andersca@apple.com>
1796 * Scripts/build-webkit:
1797 WebKit2 should always be built for OS X and iOS.
1799 2014-05-09 Anders Carlsson <andersca@apple.com>
1801 Follow-up build fix.
1803 * Scripts/build-webkit:
1804 WebKit2 should no longer be built before WebKit.
1806 2014-05-09 Anders Carlsson <andersca@apple.com>
1808 Rename WebKit2.framework to WebKit.framework
1809 https://bugs.webkit.org/show_bug.cgi?id=132743
1810 <rdar://problem/15920046>
1812 Reviewed by Dan Bernstein.
1814 * Scripts/check-for-inappropriate-files-in-framework:
1815 Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
1816 Change WebKit2 to WebKit.
1818 * Scripts/check-for-webkit-framework-include-consistency:
1819 Change WebKit to WebKitLegacy.
1821 2014-05-09 Manuel Rego Casasnovas <rego@igalia.com>
1823 Remove GTK+ WK1 EWS from build.webkit.org/dashboard
1824 https://bugs.webkit.org/show_bug.cgi?id=132732
1826 Reviewed by Alexey Proskuryakov.
1828 GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
1830 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1831 (EWS): Remove GTK+ WK1 EWS.
1833 2014-05-09 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1835 Add new u-szeged contributors.
1837 Reviewed by Csaba Osztrogonác.
1839 * Scripts/webkitpy/common/config/contributors.json:
1841 2014-05-09 Carlos Garcia Campos <cgarcia@igalia.com>
1843 REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
1844 https://bugs.webkit.org/show_bug.cgi?id=132736
1846 Reviewed by Philippe Normand.
1848 There are two problems, the path returned by common.library_build_path() is wrong when
1849 common.binary_build_path() has previously been called, and the test is still looking for
1850 the .la instead of .so
1852 * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1853 (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
1854 of .la as extension of the injected bundle library.
1856 (binary_build_path): Remove unused global variable and add a new
1857 one for binary_build_dir instead of sharing the same global
1858 variable for library_build_path and binary_build_path.
1860 2014-05-08 Praveen R Jadhav <praveen.j@samsung.com>
1862 [EFL] Enable MEDIA_STREAM for EFL port
1863 https://bugs.webkit.org/show_bug.cgi?id=132648
1865 Reviewed by Gyuyoung Kim.
1867 Script modified to enable MEDIA_STREAM for EFL build.
1869 * Scripts/webkitperl/FeatureList.pm:
1871 2014-05-08 David Farler <dfarler@apple.com>
1873 old-run-webkit-tests: update strings for simulator devices and app name
1874 https://bugs.webkit.org/show_bug.cgi?id=132687
1876 Reviewed by Darin Adler.
1878 iPhone Retina (4-inch) -> iPhone 5
1879 iPhone Retina (4-inch 64-bit) -> iPhone 5s
1881 * Scripts/old-run-webkit-tests:
1882 (installAndLaunchDumpToolAppUsingNotification):
1883 (openIPhoneSimulator):
1884 (quitIPhoneSimulator):
1885 quit iOS Simulator, not iPhone Simulator.
1887 2014-05-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
1889 REGRESSION(r168471): Update the builder names on the scheduler list.
1890 https://bugs.webkit.org/show_bug.cgi?id=132699
1892 Reviewed by Martin Robinson.
1894 On r168471 I missed to update the builder names for the GTK build
1895 bots on the AnyBranchScheduler type scheduler list of bots.
1897 * BuildSlaveSupport/build.webkit.org-config/config.json:
1899 2014-05-08 Brady Eidson <beidson@apple.com>
1901 "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
1902 <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
1904 Reviewed by Tim Horton.
1906 * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
1907 (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
1909 2014-05-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
1911 REGRESSION(r168471): Duplicate builddirs broke the build master.
1912 https://bugs.webkit.org/show_bug.cgi?id=132688
1914 Reviewed by Carlos Garcia Campos.
1916 Rename the builddirs of the new GTK bots introduced on r168471 to
1917 be unique. Otherwise the master will break.
1919 * BuildSlaveSupport/build.webkit.org-config/config.json:
1921 2014-05-08 Carlos Garcia Campos <cgarcia@igalia.com>
1923 [GTK] webkitdom script assumes mkdir only fails because the directory already exists
1924 https://bugs.webkit.org/show_bug.cgi?id=132674
1926 Reviewed by Philippe Normand.
1928 Only ignore mkdir failure when exception is raised because the
1929 file already exists and it's a directory.
1934 2014-05-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
1936 [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
1937 https://bugs.webkit.org/show_bug.cgi?id=131358
1939 Reviewed by Carlos Garcia Campos.
1941 Current 64-bit GTK build bots (Release and Debug) not only test
1942 the build, but run all tests. Split each one of the bots in
1943 BuildOnly and TestWebKit2.
1945 This will allow us to have a better overview of the status of
1948 Original patch from Sergio Villar Senin <svillar@igalia.com>
1950 * BuildSlaveSupport/build.webkit.org-config/config.json:
1951 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1952 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1954 * Scripts/webkitpy/port/builders.py:
1955 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1956 (TestRebaselineTest.test_baseline_directory):
1957 * TestResultServer/static-dashboards/builders.jsonp:
1958 * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1960 * TestResultServer/static-dashboards/loader_unittests.js:
1962 2014-05-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1964 [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
1965 https://bugs.webkit.org/show_bug.cgi?id=126022
1967 Reviewed by Benjamin Poulain.
1969 Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
1971 Added an unit test case to check if scroll position and scale are restored properly.
1973 * TestWebKitAPI/PlatformEfl.cmake:
1974 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
1975 (TestWebKitAPI::didFinishLoadForFrame):
1976 (TestWebKitAPI::didChangeContentsPosition):
1977 (TestWebKitAPI::TEST):
1978 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
1979 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
1981 2014-05-07 Simon Fraser <simon.fraser@apple.com>
1983 WebKit1 is flashy when compositing layers come and go
1984 https://bugs.webkit.org/show_bug.cgi?id=132655
1985 <rdar://problem/16830981&16788846>
1987 Reviewed by Sam Weinig.
1989 Revert the change from r166117.
1991 * DumpRenderTree/mac/DumpRenderTree.mm:
1994 2014-05-07 Chris Fleizach <cfleizach@apple.com>
1996 AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
1997 https://bugs.webkit.org/show_bug.cgi?id=132622
1999 Reviewed by Mario Sanchez Prada.
2001 * DumpRenderTree/AccessibilityUIElement.cpp:
2002 (selectTextWithCriteriaCallback):
2004 * DumpRenderTree/AccessibilityUIElement.h:
2005 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2006 (AccessibilityUIElement::selectTextWithCriteria):
2007 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2008 (AccessibilityUIElement::selectTextWithCriteria):
2009 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2010 (selectTextParameterizedAttributeForCriteria):
2011 (AccessibilityUIElement::selectTextWithCriteria):
2012 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2013 (AccessibilityUIElement::selectTextWithCriteria):
2014 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2015 (WTR::AccessibilityUIElement::selectTextWithCriteria):
2016 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2017 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2018 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2019 (WTR::AccessibilityUIElement::selectTextWithCriteria):
2020 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2021 (WTR::AccessibilityUIElement::selectTextWithCriteria):
2022 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2023 (WTR::selectTextParameterizedAttributeForCriteria):
2024 (WTR::AccessibilityUIElement::selectTextWithCriteria):
2026 2014-05-07 Carlos Garcia Campos <cgarcia@igalia.com>
2028 [SOUP] TLSErrors do not cause page load to fail when not ignored
2029 https://bugs.webkit.org/show_bug.cgi?id=121548
2031 Reviewed by Sergio Villar Senin.
2033 Add unit tests to check that the load fails with TLS errors in
2034 case of a redirection.
2036 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2037 (testTLSErrorsRedirect):
2038 (httpsServerCallback):
2041 2014-05-07 Manuel Rego Casasnovas <rego@igalia.com>
2043 [CSS Grid Layout] Remove runtime feature
2044 https://bugs.webkit.org/show_bug.cgi?id=132382
2046 Reviewed by Benjamin Poulain.
2048 Remove cssGridLayoutEnabled setting usage.
2050 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2051 (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2052 * DumpRenderTree/efl/TestRunnerEfl.cpp:
2053 (TestRunner::overridePreference):
2054 * DumpRenderTree/mac/DumpRenderTree.mm:
2055 (resetWebPreferencesToConsistentValues):
2057 2014-05-06 David Kilzer <ddkilzer@apple.com>
2059 Add Makefile targets for copying static libraries (LLVM and WKSI)
2060 <http://webkit.org/b/132619>
2062 Reviewed by Mark Rowe.
2064 * Scripts/copy-webkitlibraries-to-product-directory: Set a
2065 sensible default for product directory if not specified on
2066 either the command-line or in the environment (by Xcode) by
2067 calling productDir() in webkitdirs.pm.
2069 2014-05-06 Brady Eidson <beidson@apple.com>
2071 Add WK2 SPI to prevent the previous back/forward item from remaining in the list
2072 <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
2074 Reviewed by Sam Weinig.
2076 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2078 * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
2079 (TestWebKitAPI::itemURLLastComponentIsString):
2080 (TestWebKitAPI::didFinishLoadForFrame):
2081 (TestWebKitAPI::willGoToBackForwardListItem):
2082 (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
2083 (TestWebKitAPI::setPageLoaderClient):
2084 (TestWebKitAPI::TEST):
2085 * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
2086 * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
2088 * WebKitTestRunner/TestController.cpp:
2089 (WTR::TestController::createWebViewWithOptions): Update for new client layout.
2091 2014-05-06 Darin Adler <darin@apple.com>
2093 Try to fix iOS build.
2095 * DumpRenderTree/mac/TestRunnerMac.mm:
2096 (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
2097 Updated since I changed testRunner into a pointer instead of a reference.
2098 Updated argument names to avoid conflict with field names.
2099 (-[APITestDelegateIPhone run]): Ditto.
2100 (-[APITestDelegateIPhone _cleanUp]): Ditto.
2102 2014-05-06 Commit Queue <commit-queue@webkit.org>
2104 Unreviewed, rolling out r168304.
2105 https://bugs.webkit.org/show_bug.cgi?id=132607
2107 Broke the build (Requested by KaL on #webkit).
2111 "[GTK][CMake] Unable to do make install"
2112 https://bugs.webkit.org/show_bug.cgi?id=130188
2113 http://trac.webkit.org/changeset/168304
2115 2014-05-04 Darin Adler <darin@apple.com>
2117 RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
2118 https://bugs.webkit.org/show_bug.cgi?id=80222
2120 Reviewed by Alexey Proskuryakov.
2122 * DumpRenderTree/mac/TestRunnerMac.mm:
2123 (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
2124 do more work here so we don't use RetainPtr local variables.
2125 (-[APITestDelegateIPhone dealloc]): Added.
2126 (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
2127 created. Updated for changes to member names and types.
2128 (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
2129 updated for changes to member names and types. Changed to two word spelling.
2130 (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
2131 name of _cleanUp method.
2132 (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
2134 (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
2136 2014-05-05 Benjamin Poulain <benjamin@webkit.org>
2138 Clean up Image Document and tweak the layout and viewport
2139 https://bugs.webkit.org/show_bug.cgi?id=132552
2141 Reviewed by Anders Carlsson.
2143 * DumpRenderTree/mac/DumpRenderTree.mm:
2144 (resetWebPreferencesToConsistentValues):
2145 Update the default settings to have something consistent with WebKit2.
2147 2014-05-05 Martin Robinson <mrobinson@igalia.com>
2149 [GTK][CMake] Unable to do make install
2150 https://bugs.webkit.org/show_bug.cgi?id=130188
2152 Reviewed by Carlos Garcia Campos.
2154 * Scripts/webkitdirs.pm:
2155 (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
2156 will give an early signal that a change has broken the documentation.
2158 2014-05-05 Pratik Solanki <psolanki@apple.com>
2160 Update framework locations in package-root
2161 https://bugs.webkit.org/show_bug.cgi?id=132571
2163 Reviewed by Simon Fraser.
2165 * Scripts/package-root:
2167 2014-05-05 Ryuan Choi <ryuan.choi@samsung.com>
2169 [EFL][WK2] Refactor favicon database APIs
2170 https://bugs.webkit.org/show_bug.cgi?id=132519
2172 Reviewed by Gyuyoung Kim.
2174 * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
2175 (update_view_favicon):
2176 (on_icon_changed_cb):
2180 (on_view_favicon_changed): Deleted.
2182 2014-05-02 Mark Rowe <mrowe@apple.com>
2184 <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
2186 Reviewed by Dan Bernstein.
2188 * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
2189 when determining which LLVM archive to extract.
2191 2014-05-02 Jeremy Jones <jeremyj@apple.com>
2193 Add Jeremy as a committer.
2194 https://bugs.webkit.org/show_bug.cgi?id=132492
2196 Reviewed by Jer Noble.
2198 Add myself as a committer.
2200 * Scripts/webkitpy/common/config/contributors.json:
2202 2014-05-02 Jeremy Jones <jeremyj@apple.com>
2204 Add Jeremy as a committer.
2205 https://bugs.webkit.org/show_bug.cgi?id=132492
2207 Reviewed by Jer Noble.
2209 Add Jeremy Jones to the committers file.
2211 * Scripts/webkitpy/common/config/contributors.json:
2213 2014-05-02 Brian J. Burg <burg@cs.washington.edu>
2215 Hard to figure out how to run a single test with run-api-tests
2216 https://bugs.webkit.org/show_bug.cgi?id=116332
2218 Reviewed by Alexey Proskuryakov.
2220 * Scripts/run-api-tests: add two examples to the help message.
2222 2014-05-02 Simon Fraser <simon.fraser@apple.com>
2224 Fix several memory leaks found by code inspection
2225 https://bugs.webkit.org/show_bug.cgi?id=132472
2227 Reviewed by Geoffrey Garen.
2231 * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
2232 (TestWebKitAPI::TEST):
2233 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2234 (WTR::InjectedBundlePage::willSendRequestForFrame):
2235 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2236 (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2238 2014-05-02 Filip Pizlo <fpizlo@apple.com>
2240 DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
2241 https://bugs.webkit.org/show_bug.cgi?id=132446
2243 Reviewed by Mark Hahnenberg.
2245 Test the FTL by default now that it's enabled by default.
2247 * Scripts/run-javascriptcore-tests:
2249 2014-05-01 Ryuan Choi <ryuan.choi@samsung.com>
2251 [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
2252 https://bugs.webkit.org/show_bug.cgi?id=132240
2254 Reviewed by Anders Carlsson.
2256 Removed ewk_view_setting_tiled_backingstore related code.
2258 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2259 (DumpRenderTreeChrome::createView):
2260 (shouldUseTiledBackingStore): Deleted.
2261 * EWebLauncher/main.c:
2263 (parseUserArguments):
2265 2014-05-01 Anders Carlsson <andersca@apple.com>
2267 window.testRunner.keepWebHistory() should update the UI process state
2268 https://bugs.webkit.org/show_bug.cgi?id=132440
2270 Reviewed by Dan Bernstein.
2272 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2273 (WTR::InjectedBundle::postSetAddsVisitedLinks):
2274 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2275 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2276 (WTR::TestRunner::keepWebHistory):
2277 * WebKitTestRunner/TestInvocation.cpp:
2278 (WTR::TestInvocation::invoke):
2279 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2281 2014-05-01 David Kilzer <ddkilzer@apple.com>
2283 Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
2284 <http://webkit.org/b/132432>
2286 Reviewed by Tim Horton.
2288 * Scripts/webkitperl/FeatureList.pm: Remove support for
2289 --plugin-proxy-for-video switch.
2291 2014-04-30 Carlos Alberto Lopez Perez <clopez@igalia.com>
2293 Kernel sysctl interface hw.activecpu don't exists on Linux.
2294 https://bugs.webkit.org/show_bug.cgi?id=132286
2296 Reviewed by Filip Pizlo.
2298 * Scripts/run-jsc-stress-tests: Redirect stderr to null when
2299 calling sysctl over hw.activecpu
2301 2014-04-30 Anders Carlsson <andersca@apple.com>
2303 Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
2304 https://bugs.webkit.org/show_bug.cgi?id=132399
2305 <rdar://problem/15920046>
2307 Reviewed by Dan Bernstein.
2309 * Scripts/check-for-webkit-framework-include-consistency:
2310 Allos WAK headers in WebKitLegacy as well as WebKit.
2312 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2313 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2314 Update header imports.
2316 2014-04-30 Simon Fraser <simon.fraser@apple.com>
2318 [iOS WK2] Add test URL to crash reports for the UI process, clean up project
2319 https://bugs.webkit.org/show_bug.cgi?id=131954
2321 Reviewed by Darin Adler.
2323 WebKitTestRunner was adding application-specific information to crash reports
2324 to log the test path, but only in the web process. Fix it to also do this
2325 for the UI process, for both iOS and OS X.
2327 Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
2330 Factored crash reprorter-related code into CrashReporterInfo, and call it from
2331 a new TestController::platformWillRunTest() function on Mac and iOS.
2333 Also remove Xcode-added unit test junk from the project.
2335 * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2336 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
2337 * WebKitTestRunner/TestController.cpp:
2338 (WTR::TestController::runTest):
2339 * WebKitTestRunner/TestController.h:
2340 * WebKitTestRunner/TestInvocation.cpp:
2341 (WTR::TestInvocation::url):
2342 * WebKitTestRunner/TestInvocation.h:
2343 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2344 * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
2345 * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
2346 * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
2347 * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
2348 * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
2349 (WTR::testPathFromURL):
2350 (WTR::setCrashReportApplicationSpecificInformationToURL):
2351 * WebKitTestRunner/efl/TestControllerEfl.cpp:
2352 (WTR::TestController::platformWillRunTest):
2353 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2354 (WTR::TestController::platformWillRunTest):
2355 * WebKitTestRunner/ios/TestControllerIOS.mm:
2356 (WTR::TestController::platformWillRunTest):
2357 (WTR::TestController::setHidden):
2358 * WebKitTestRunner/mac/TestControllerMac.mm:
2359 (WTR::TestController::platformWillRunTest):
2361 2014-04-30 Simon Fraser <simon.fraser@apple.com>
2363 Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
2365 Reviewed by Tim Horton.
2367 * DumpRenderTree/mac/DumpRenderTree.mm:
2368 (resetWebPreferencesToConsistentValues):
2369 (prepareConsistentTestingEnvironment):
2371 2014-04-30 Anders Carlsson <andersca@apple.com>
2373 check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
2374 https://bugs.webkit.org/show_bug.cgi?id=132397
2376 Reviewed by Dan Bernstein.
2378 * Scripts/check-for-inappropriate-macros-in-external-headers:
2380 2014-04-29 Martin Robinson <mrobinson@igalia.com>
2382 [GTK] Make it easier to run CMake for downstreams
2383 https://bugs.webkit.org/show_bug.cgi?id=132370
2385 Reviewed by Carlos Garcia Campos.
2387 * Scripts/webkitdirs.pm:
2388 (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
2391 2014-04-29 Stephanie Lewis <slewis@apple.com>
2393 <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
2395 Rubber stamped by Jessie Berlin.
2397 JSON.pm was removed from our tools setup.
2399 * Scripts/generate-coverage-data:
2401 2014-04-29 Filip Pizlo <fpizlo@apple.com>
2403 Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
2404 https://bugs.webkit.org/show_bug.cgi?id=112840
2406 Rubber stamped by Geoffrey Garen.
2408 * Scripts/build-jsc: Enable it on Mac.
2409 * Scripts/build-webkit: Enable it on Mac.
2410 * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
2412 2014-04-28 Sam Weinig <sam@webkit.org>
2414 REGRESSION (r167751): svn-create-patch is very slow
2415 https://bugs.webkit.org/show_bug.cgi?id=132300
2417 Reviewed by Alexey Proskuryakov.
2419 * Scripts/svn-create-patch:
2420 Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
2421 by calling `svn-create-patch --style`.
2423 2014-04-29 Enrique Ocaña González <eocanha@igalia.com>
2425 Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
2426 https://bugs.webkit.org/show_bug.cgi?id=132190
2428 Reviewed by Gustavo Noronha Silva.
2430 * Scripts/webkitdirs.pm:
2431 (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
2432 if ninja is in the path.
2433 (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
2434 to the previous ninja generator if not.
2436 2014-04-29 Jozsef Berta <jberta.u-szeged@partner.samsung.com>
2438 check-webkit-style should understand --git-index
2439 https://bugs.webkit.org/show_bug.cgi?id=125364
2441 Reviewed by Csaba Osztrogonác.
2443 * Scripts/webkitpy/common/checkout/scm/git.py:
2444 (Git.create_patch): The command now supports the --cached option.
2445 * Scripts/webkitpy/style/main.py:
2446 (CheckWebKitStyle.main): Passing the --git-index option.
2447 * Scripts/webkitpy/style/optparser.py:
2448 (CommandOptionValues.__init__): The git-index option is switched off by default.
2449 (CommandOptionValues.__eq__): Equality check for the new option.
2450 (ArgumentParser._create_option_parser):Adding the --git-index option
2451 (ArgumentParser.parse):
2452 * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
2453 (CommandOptionValuesTest.test_init):
2454 (CommandOptionValuesTest.test_eq):
2456 2014-04-28 Michael Saboff <msaboff@apple.com>
2458 Crash in platform/mac/accessibility/table-visible-rows.html
2459 https://bugs.webkit.org/show_bug.cgi?id=132146
2461 Reviewed by Filip Pizlo.
2463 Instead of creating a local JSValueRef array on the stack and passing that to
2464 JSObjectMakeArray(), changed to create an empty JSArray and then populate the
2465 values using the JSObjectSetPropertyAtIndex() API.
2467 * DumpRenderTree/AccessibilityUIElement.cpp:
2468 (elementsForRangeCallback):
2469 (convertElementsToObjectArray):
2470 * DumpRenderTree/mac/TestRunnerMac.mm:
2472 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2473 (WTR::EventSendingController::contextClick):
2474 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2475 (WTR::stringArrayToJS):
2476 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2477 (WTR::convertElementsToObjectArray):
2479 2014-04-28 Filip Pizlo <fpizlo@apple.com>
2481 Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
2482 "no-cjit" runs force the old-school threshold.
2484 Rubber stamped by Mark Hahnenberg.
2486 * Scripts/run-jsc-stress-tests:
2488 2014-04-28 Carlos Alberto Lopez Perez <clopez@igalia.com>
2490 [GTK] install-dependencies should also install ruby-json and ruby-highline
2491 https://bugs.webkit.org/show_bug.cgi?id=132292
2493 Reviewed by Philippe Normand.
2495 * gtk/install-dependencies: Install ruby json and highline packages.
2497 2014-04-27 Joonghun Park <jh718.park@samsung.com>
2499 [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
2500 https://bugs.webkit.org/show_bug.cgi?id=132176
2502 Reviewed by Gyuyoung Kim.
2504 EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
2505 and turn off indexedDB feature until the sqlite implementation is introduced.
2507 * Scripts/webkitperl/FeatureList.pm:
2509 2014-04-25 James Craig <jcraig@apple.com>
2511 Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
2512 https://bugs.webkit.org/show_bug.cgi?id=132209
2514 Reviewed by Daniel Bates.
2516 Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
2517 Run check-webkit-style before generating changelogs to avoid additional spurious errors.
2519 * Scripts/prepare-ChangeLog:
2522 2014-04-25 Michael Saboff <msaboff@apple.com>
2524 Crash in platform/mac/accessibility/table-visible-rows.html
2525 https://bugs.webkit.org/show_bug.cgi?id=132146
2527 Reviewed by Mark Lam.
2529 Changed to use a local JSValueRef array temporary instead of a
2530 std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
2531 JSValues are visited during garbage collection when the stack is scanned. Otherwise,
2532 the temporary values could be collected.
2534 * DumpRenderTree/AccessibilityUIElement.cpp:
2535 (convertElementsToObjectArray):
2536 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2537 (WTR::EventSendingController::contextClick):
2538 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2539 (WTR::convertElementsToObjectArray):
2541 2014-04-24 Eduardo Lima Mitev <elima@igalia.com>
2543 Unreviewed GTK gardening
2545 * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
2548 2014-04-24 László Langó <llango.u-szeged@partner.samsung.com>
2550 prepare-ChangeLog reports as deleted methods that has not been removed.
2551 https://bugs.webkit.org/show_bug.cgi?id=131733
2553 Reviewed by Ryosuke Niwa.
2555 * Scripts/prepare-ChangeLog:
2556 (originalFile): Set merge base to origin/master by default.
2558 2014-04-23 James Craig <jcraig@apple.com>
2560 prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
2561 https://bugs.webkit.org/show_bug.cgi?id=131115
2563 Reviewed by Daniel Bates.
2565 Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
2567 * Scripts/commit-log-editor: Added --no-style.
2568 * Scripts/prepare-ChangeLog: Primary patch.
2569 (main): Primary patch.
2570 (createPatchCommand): Added --no-style.
2571 * Scripts/svn-create-patch: Primary patch.
2572 * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
2573 * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
2574 (SVN.create_patch): Added --no-style.
2576 2014-04-23 Anders Carlsson <andersca@apple.com>
2578 Try to fix iOS build.
2580 * DumpRenderTree/mac/DumpRenderTree.mm:
2582 2014-04-23 Alexey Proskuryakov <ap@apple.com>
2584 Eliminate internals.setMockScrollbarsEnabled()
2585 https://bugs.webkit.org/show_bug.cgi?id=132085
2587 Reviewed by Tim Horton.
2589 * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
2590 No need to reset the preference, there is no way it can change.
2592 2014-04-23 James Craig <jcraig@apple.com>
2594 Unreviewed. Moving myself from Contributors to Committers list.
2596 * Scripts/webkitpy/common/config/contributors.json:
2598 2014-04-23 Tim Horton <timothy_horton@apple.com>
2600 Mock scrollbars don't always work in DumpRenderTree
2601 https://bugs.webkit.org/show_bug.cgi?id=132082
2603 Reviewed by Alexey Proskuryakov.
2605 * DumpRenderTree/mac/DumpRenderTree.mm:
2606 (prepareConsistentTestingEnvironment):
2607 Set the mock scrollbar setting before creating the WebView, as this setting
2608 cannot be dynamically changed, so any scrollbars that are created during
2609 WebView initialization and are not replaced before snapshotting will end
2610 up being platform scrollbars instead of mock ones.
2611 WebKitTestRunner already sets this preference before creating WKViews,
2612 so we're just matching its behavior.
2614 2014-04-23 Carlos Garcia Campos <cgarcia@igalia.com>
2616 [GTK] ShadowRoot API was removed in r164131
2617 https://bugs.webkit.org/show_bug.cgi?id=132059
2619 Reviewed by Gustavo Noronha Silva.
2621 Add WebKitDOMShadowRoot to the list of deleted classes to generate
2625 (WebKitDOMDocGenerator):
2627 2014-04-23 Lorenzo Tilve <ltilve@igalia.com>
2629 [GTK] run-webkit-tests script is failing to invoke run-launcher
2630 https://bugs.webkit.org/show_bug.cgi?id=132051
2632 Reviewed by Philippe Normand.
2634 After the WK1 support was dropped, if run-webkit-tests is executed
2635 without --no-show-results parameter, the launcher is being called
2636 using a -2 parameter that is it causing the run-launcher to break.
2638 * Scripts/webkitpy/port/gtk.py:
2639 (GtkPort.show_results_html_file):
2641 2014-04-22 Tim Horton <timothy_horton@apple.com>
2643 DumpRenderTree generates black snapshots on some platforms
2644 https://bugs.webkit.org/show_bug.cgi?id=132029
2645 <rdar://problem/16679363>
2647 Reviewed by Simon Fraser.
2649 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2650 (createBitmapContextFromWebView):
2651 DRT checks with the WebView to determine whether it can use the window's
2652 backing store directly or (because of compositing) needs to take a WindowServer
2653 snapshot. However, on some platforms and in some situations, the window can
2654 be layer backed without the WebView necessarily currently being composited.
2655 We should check with the window in addition to the WebView before going
2656 ahead and using its backing store.
2658 2014-04-22 Tim Horton <timothy_horton@apple.com>
2660 DumpRenderTree generates white snapshots on some platforms
2661 https://bugs.webkit.org/show_bug.cgi?id=132026
2662 <rdar://problem/16679363>
2664 Reviewed by Simon Fraser.
2666 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2667 Link DRT against QuartzCore.
2669 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2670 (createBitmapContextFromWebView):
2671 Force CoreAnimation to synchronously update layers in a more explicit
2672 way that doesn't depend on AppKit behavior. This is very similar to what
2673 WebKitTestRunner does (indirectly) during its force repaint.
2675 2014-04-22 Brent Fulgham <bfulgham@apple.com>
2677 [Win] Support Python 2.7 in Cygwin
2678 https://bugs.webkit.org/show_bug.cgi?id=132023
2680 Reviewed by Michael Saboff.
2682 * Scripts/webkitdirs.pm:
2683 (checkInstalledTools): Remove check for Python 2.7, since
2684 it now works properly.
2686 2014-04-22 Filip Pizlo <fpizlo@apple.com>
2688 Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2689 https://bugs.webkit.org/show_bug.cgi?id=130867
2690 <rdar://problem/16432456>
2692 Reviewed by Mark Hahnenberg.
2694 * Scripts/build-webkit:
2695 * Scripts/copy-webkitlibraries-to-product-directory:
2697 2014-04-22 Gustavo Noronha Silva <gns@gnome.org>
2699 [GTK] Fails to build documentation when output is redirected
2700 https://bugs.webkit.org/show_bug.cgi?id=131178
2702 Reviewed by Martin Robinson.
2704 * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
2705 explicitly to avoid encoding issues when they are redirected.
2707 2014-04-22 ChangSeok Oh <changseok.oh@collabora.com>
2709 [GTK] YCM choose a newer compile_commands.json in between Release or Debug
2710 https://bugs.webkit.org/show_bug.cgi?id=131911
2712 Reviewed by Martin Robinson.
2714 common.get_build_path returns release path even though Debug configuration
2715 is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
2717 * gtk/ycm_extra_conf.py:
2718 (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
2721 2014-04-21 Brent Fulgham <bfulgham@apple.com>
2723 Unreviewed build fix.
2725 * DumpRenderTree/mac/EventSendingController.mm:
2726 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2727 Correct a typo that prevented tests from working properly.
2729 2014-04-21 Martin Robinson <mrobinson@igalia.com>
2731 [GTK] Should have the ability to output composited contents during layout testing
2732 https://bugs.webkit.org/show_bug.cgi?id=131864
2734 Reviewed by Philippe Normand.
2736 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2737 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
2738 to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
2739 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2740 (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
2742 2014-04-21 Sam Weinig <sam@webkit.org>
2744 Attempt to fix the tests.
2746 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2747 (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2748 Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
2750 2014-04-21 Filip Pizlo <fpizlo@apple.com>
2752 Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
2753 being the same as a "quick run", which is meant for genuinely slow tests).
2755 * Scripts/run-jsc-stress-tests:
2757 2014-04-21 Darin Adler <darin@apple.com>
2759 Add HashSet::takeAny
2760 https://bugs.webkit.org/show_bug.cgi?id=131928
2762 Reviewed by Benjamin Poulain.
2764 * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
2766 2014-04-20 Dan Bernstein <mitz@apple.com>
2768 Fixed a test timing out after r167572.
2770 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2771 (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
2772 -webView:didFinishLoadingNavigation:.
2774 2014-04-20 Commit Queue <commit-queue@webkit.org>
2776 Unreviewed, rolling out r167510.
2777 https://bugs.webkit.org/show_bug.cgi?id=131915
2779 broke GTK Debug bot (Requested by philn on #webkit).
2783 "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
2784 it when running layout tests"
2785 https://bugs.webkit.org/show_bug.cgi?id=131472
2786 http://trac.webkit.org/changeset/167510
2788 2014-04-18 Martin Robinson <mrobinson@igalia.com>
2790 [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2791 https://bugs.webkit.org/show_bug.cgi?id=131472
2793 Reviewed by Philippe Normand.
2795 * Scripts/webkitpy/port/gtk.py:
2796 (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2797 when running WebKitTestRunner with run-webkit-tests.
2798 * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
2800 * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
2801 how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
2802 calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
2805 2014-04-18 Alexey Proskuryakov <ap@apple.com>
2807 DownloadDecideDestinationCrash API test uses an incorrect value for path
2808 https://bugs.webkit.org/show_bug.cgi?id=131845
2809 <rdar://problem/15925560>
2811 Reviewed by Enrica Casucci.
2813 * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2814 (TestWebKitAPI::decideDestinationWithSuggestedFilename):
2816 2014-04-17 Alexey Proskuryakov <ap@apple.com>
2818 [Mac] AttributedStringTest API tests fail with async text input
2819 https://bugs.webkit.org/show_bug.cgi?id=131833
2821 Reviewed by Enrica Casucci.
2823 Don't run sync NSTextInputClient tests where we don't implement these calls.
2825 * TestWebKitAPI/Tests/mac/AttributedString.mm:
2826 (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2827 (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
2828 (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2829 (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
2830 (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
2831 (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
2833 2014-04-18 Philippe Normand <pnormand@igalia.com>
2835 Remove NETWORK_INFO support
2836 https://bugs.webkit.org/show_bug.cgi?id=131841
2838 Reviewed by Gyuyoung Kim.
2840 * Scripts/webkitperl/FeatureList.pm:
2842 2014-04-17 ChangSeok Oh <changseok.oh@collabora.com>
2844 [GTK] YouCompleteMe doesn't work for cmake build system.
2845 https://bugs.webkit.org/show_bug.cgi?id=131591
2847 Reviewed by Martin Robinson.
2849 Add cmake build system support for YouCompleteMe. It should work regardless of
2850 using make or ninja. In addition, autotools related code is removed since it's
2851 not used anymore in WebKit.
2853 * Scripts/webkitdirs.pm:
2854 (generateBuildSystemFromCMakeProject):
2855 * gtk/ycm_extra_conf.py:
2856 (transform_relative_paths_to_absolute_paths):
2859 2014-04-17 Anders Carlsson <andersca@apple.com>
2863 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2864 (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2865 (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2867 2014-04-17 Anders Carlsson <andersca@apple.com>
2869 Remove unused API enums
2870 https://bugs.webkit.org/show_bug.cgi?id=131836
2872 Reviewed by Tim Horton.
2874 * MiniBrowser/mac/WK2BrowserWindowController.m:
2875 (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2877 2014-04-16 Brent Fulgham <bfulgham@apple.com>
2879 [Win] A few final cleanups to the DataObject classes.
2880 https://bugs.webkit.org/show_bug.cgi?id=131784
2882 Reviewed by Anders Carlsson.
2884 * DumpRenderTree/win/DRTDataObject.cpp:
2885 (DRTDataObject::clearData): Use 'last()' method.
2886 * DumpRenderTree/win/UIDelegate.cpp:
2887 (DRTUndoStack::pop): Use 'takeLast()' method.
2889 2014-04-17 Andres Gomez <agomez@igalia.com>
2891 [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
2892 https://bugs.webkit.org/show_bug.cgi?id=131365
2894 Reviewed by Brent Fulgham.
2896 The cygwin installer is now downloading the wanted versions for
2897 the local installation given to the setup wizard.
2899 * CygwinDownloader/cygwin-downloader.py:
2900 * CygwinDownloader/cygwin-downloader.zip:
2902 2014-04-17 Adrian Perez de Castro <aperez@igalia.com>
2904 [GTK] Make run-webkit-tests always use WKTR
2905 https://bugs.webkit.org/show_bug.cgi?id=131737
2907 Reviewed by Darin Adler.
2909 Now that the GTK+ port only has support for WebKit2, instruct
2910 run-webkit-tests to always use WKTR. This avoids needing to pass
2911 flag "-2" every time.
2913 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2914 (_set_up_derived_options): Always set webkit_test_runner when
2915 the platform is GTK+.
2917 2014-04-17 Brendan Long <b.long@cablelabs.com>
2919 [Gtk] Install ninja-build in Tools/gtk/install-dependencies
2920 https://bugs.webkit.org/show_bug.cgi?id=131760
2922 Reviewed by Philippe Normand.
2924 * gtk/install-dependencies: Install ninja-build when it's available.
2926 2014-04-16 peavo@outlook.com <peavo@outlook.com>
2928 [Win] run-javascriptcore-tests fails to run.
2929 https://bugs.webkit.org/show_bug.cgi?id=131761
2931 Reviewed by Brent Fulgham.
2933 * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
2935 2014-04-16 Andres Gomez <agomez@igalia.com>
2937 [Win] Pass default parameters to cygwin setup wizard
2938 https://bugs.webkit.org/show_bug.cgi?id=131361
2940 Reviewed by Brent Fulgham.
2942 Added some parameters to the cygwin setup wizard so the user
2943 doesn't really have to do any interaction.
2945 * CygwinDownloader/cygwin-downloader.py:
2946 * CygwinDownloader/cygwin-downloader.zip:
2948 2014-04-15 Brent Fulgham <bfulgham@apple.com>
2950 [Win] Eliminate use of deleteAllValues in Windows Files
2951 https://bugs.webkit.org/show_bug.cgi?id=131631
2953 Reviewed by Darin Adler.
2955 Switch to std::unique_ptr for memory lifetime. Get rid of
2956 deleteAllValues now that it is no longer needed. Use ranged
2957 for loops where possible.
2959 * DumpRenderTree/win/DRTDataObject.cpp:
2960 (WCEnumFormatEtc::WCEnumFormatEtc):
2961 (DRTDataObject::~DRTDataObject):
2962 (DRTDataObject::GetData):
2963 (DRTDataObject::QueryGetData):
2964 (DRTDataObject::SetData):
2965 (DRTDataObject::clearData):
2966 * DumpRenderTree/win/DRTDataObject.h:
2967 * DumpRenderTree/win/UIDelegate.cpp:
2968 (DRTUndoObject::DRTUndoObject):
2969 (DRTUndoObject::~DRTUndoObject):
2970 (DRTUndoStack::~DRTUndoStack):
2971 (DRTUndoStack::clear):
2972 (DRTUndoStack::pop):
2973 (DRTUndoManager::DRTUndoManager):
2974 (DRTUndoManager::redo):
2975 (DRTUndoManager::undo):
2976 (UIDelegate::UIDelegate):
2977 (UIDelegate::resetUndoManager):
2978 * DumpRenderTree/win/UIDelegate.h:
2980 2014-04-16 Carlos Alberto Lopez Perez <clopez@igalia.com>
2982 [GTK] Unreviewed GTK gardening.
2984 Update list of skipped unit tests:
2986 Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
2988 Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
2989 and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
2991 * Scripts/run-gtk-tests:
2994 2014-04-16 Tim Horton <timothy_horton@apple.com>
2996 check-webkit-style doesn't check code style in .mm or .m files
2997 https://bugs.webkit.org/show_bug.cgi?id=131708
2999 Reviewed by Darin Adler.
3001 * Scripts/webkitpy/style/checker.py:
3002 * Scripts/webkitpy/style/checker_unittest.py:
3003 (CheckerDispatcherDispatchTest.test_cpp_paths):
3004 (CheckerDispatcherDispatchTest.test_text_paths):
3005 Check .mm and .m files as C++.
3007 * Scripts/webkitpy/style/checkers/cpp.py:
3009 Add an override for our ordinary "missing spaces around =" for @synthesize,
3010 which should look like "@synthesize propertyName=_varName;"
3012 Add an override for "missing space before {" for blocks' "^{".
3014 Don't follow the "extra space before [" rule for Objective-C, because
3015 it breaks this rule in a multitude of ways because of method calls.
3018 Don't complain about { not being on the end of the previous line if
3019 the previous line starts with "- (" or "+ (", which would indicate a
3020 Objective-C method definition.
3022 2014-04-16 Darin Adler <darin@apple.com>
3024 Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
3025 https://bugs.webkit.org/show_bug.cgi?id=131735
3027 Reviewed by Alexey Proskuryakov.
3029 * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
3030 Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
3031 is on the right. This can be confusing since our JavaScript test framework does it the opposite
3032 way, but gtest works better this way.
3034 2014-04-15 Hyowon Kim <hw1008.kim@samsung.com>
3036 [EFL] Fix problems with the pixel dump.
3037 https://bugs.webkit.org/show_bug.cgi?id=131265
3039 Reviewed by Gyuyoung Kim.
3041 Painting and compositing paths of WebKit-EFL were totally modified from r166768.
3042 However pixel dump codes still call deprecated functions like ewk_view_paint(),
3043 which causes that nothing is drawn.
3045 This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
3046 One of new functions is AcceleratedCompositingContext::extractImageData(),
3047 which replaces deprecated function calls. Besides the extractImageData() is invoked by
3048 ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
3050 * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3051 (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
3053 2014-04-15 Filip Pizlo <fpizlo@apple.com>
3055 Update LLVM export scrpt to handle the build directory being different from the
3058 Rubber stamped by Geoffrey Garen.
3060 * Scripts/export-llvm-build:
3062 2014-04-15 Ryosuke Niwa <rniwa@webkit.org>
3064 Update the hyperlink to waterfall views of perf bots on build.webkit.org
3065 https://bugs.webkit.org/show_bug.cgi?id=131695
3067 Reviewed by Antti Koivisto.
3071 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3073 2014-04-15 Carlos Garcia Campos <cgarcia@igalia.com>
3075 [GTK] Reduce the binary size by compressing the text based web inspector resources
3076 https://bugs.webkit.org/show_bug.cgi?id=121545
3078 Reviewed by Gustavo Noronha Silva.
3080 Compress text based files when compiling inspector resources. It
3081 reduces the binary size in 3MB.
3083 * gtk/generate-inspector-gresource-manifest.py:
3084 (find_all_files_in_directory):
3087 2014-04-14 Alexey Proskuryakov <ap@apple.com>
3089 Remove Gtk WebKit1 tester.
3091 Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
3092 results over and over as fast as it could.
3094 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3097 2014-04-14 Alexey Proskuryakov <ap@apple.com>
3099 Wrong link for webkitpy tests results in dashboard popover
3100 https://bugs.webkit.org/show_bug.cgi?id=131664
3102 Reviewed by Timothy Hatcher.
3104 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3105 (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
3108 2014-04-14 Alexey Proskuryakov <ap@apple.com>
3110 Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
3112 I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
3114 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3115 (CommitMessageForThisCommitTest):
3117 2014-04-14 Jozsef Berta <jberta.u-szeged@partner.samsung.com>
3119 Fix commit-log-editor bug revealed by r165447
3120 https://bugs.webkit.org/show_bug.cgi?id=130676
3122 Reviewed by Csaba Osztrogonác.
3124 * Scripts/commit-log-editor:
3125 (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
3126 Add \n before the first block too, because the longest common prefix now ends with only one newline.
3127 (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
3128 now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
3130 2014-04-13 Darin Adler <darin@apple.com>
3132 userVisibleString should not try to "encode" host names
3133 https://bugs.webkit.org/show_bug.cgi?id=131587
3134 rdar://problem/14686849
3136 Reviewed by Alexey Proskuryakov.
3138 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
3140 * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
3141 Coverage is tiny at this point; we could add a lot more cases!
3143 2014-04-13 Jaehun Lim <ljaehun.lim@samsung.com>
3145 Use #include instead of #import
3146 https://bugs.webkit.org/show_bug.cgi?id=131604
3148 Reviewed by Darin Adler.
3150 Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
3152 * TestWebKitAPI/Tests/WTF/StringView.cpp:
3154 2014-04-12 Filip Pizlo <fpizlo@apple.com>
3156 Make slow-stress tests run faster by running fewer VM variants.
3158 Rubber stamped by Geoffrey Garen.
3160 * Scripts/run-javascriptcore-tests:
3161 * Scripts/run-jsc-stress-tests:
3163 2014-04-10 Zan Dobersek <zdobersek@igalia.com>
3165 [CMake] Add missing WTF unit tests
3166 https://bugs.webkit.org/show_bug.cgi?id=131459
3168 Reviewed by Martin Robinson.
3170 * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
3171 that should be compiled into the TestWTF binary.
3173 2014-04-10 Brendan Long <b.long@cablelabs.com>
3175 [Gtk] run-launcher doesn't work by default
3176 https://bugs.webkit.org/show_bug.cgi?id=131494
3178 Reviewed by Philippe Normand.
3180 * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
3181 * Scripts/webkitdirs.pm:
3182 (launcherName): Same.
3183 * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
3185 (get_build_path.is_valid_build_directory): Same.
3186 * gtk/manifest.txt: Same.
3188 2014-04-09 Commit Queue <commit-queue@webkit.org>
3190 Unreviewed, rolling out r167046.
3191 https://bugs.webkit.org/show_bug.cgi?id=131479
3193 Caused 300+ failures on Mavericks WK1 tester (Requested by ap
3198 "Remove "System Font" from whitelisted DRT fonts and char
3200 https://bugs.webkit.org/show_bug.cgi?id=131411
3201 http://trac.webkit.org/changeset/167046
3203 2014-04-09 Myles C. Maxfield <mmaxfield@apple.com>
3205 Remove "System Font" from whitelisted DRT fonts and char width calculations
3206 https://bugs.webkit.org/show_bug.cgi?id=131411
3208 Reviewed by Tim Horton.
3210 Covered by existing tests.
3212 * DumpRenderTree/mac/DumpRenderTree.mm:
3213 (allowedFontFamilySet):
3215 2014-04-09 Myles C. Maxfield <mmaxfield@apple.com>
3217 systemHiddenFontFamilySet in DRT is unnecessary
3218 https://bugs.webkit.org/show_bug.cgi?id=131414
3220 Reviewed by Tim Horton.
3222 It doesn't seem to affect test results on my machine.
3224 * DumpRenderTree/mac/DumpRenderTree.mm:
3225 (drt_NSFontManager_availableFonts):
3226 (systemHiddenFontFamilySet): Deleted.
3228 2014-04-09 Brent Fulgham <bfulgham@apple.com>
3230 [Win] Unreviewed test fix: Don't double-release BSTR.
3232 * DumpRenderTree/win/DumpRenderTree.cpp:
3233 (dump): Remove unneeded call to SysFreeString now that we are
3234 using _bstr_t for this variable.
3236 2014-04-09 Brent Fulgham <bfulgham@apple.com>
3238 [Win] Various DumpRenderTree Fixes.
3239 https://bugs.webkit.org/show_bug.cgi?id=131446.
3241 Reviewed by Tim Horton.
3243 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3244 (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3245 (AccessibilityUIElement::description): Ditto.
3246 (AccessibilityUIElement::helpText): Ditto.
3247 (AccessibilityUIElement::intValue): Ditto.
3248 (AccessibilityUIElement::isPressActionSupported): Ditto.
3249 (AccessibilityUIElement::accessibilityValue): Ditto.
3250 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3251 (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3252 (DRTDesktopNotificationPresenter::AddRef): Ditto.
3253 (DRTDesktopNotificationPresenter::Release): Ditto.
3254 (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3255 (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
3256 (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
3257 (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
3258 (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
3259 * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3260 * DumpRenderTree/win/DumpRenderTree.cpp:
3261 (dumpFrameScrollPosition): Ditto.
3262 (dumpFramesAsText): Ditto.
3263 (compareHistoryItems): Ditto.
3264 (dumpHistoryItem): Ditto.
3266 (resetDefaultsToConsistentValues): Ditto.
3267 (resetWebViewToConsistentStateBeforeTesting): Ditto.
3269 (createWebViewAndOffscreenWindow): Ditto.
3270 * DumpRenderTree/win/EditingDelegate.cpp:
3271 (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3272 (EditingDelegate::AddRef): Ditto.
3273 (EditingDelegate::Release): Ditto.
3274 (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
3275 (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
3276 (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
3277 (EditingDelegate::shouldInsertNode): Ditto.
3278 (EditingDelegate::shouldInsertText): Ditto.
3279 (EditingDelegate::shouldDeleteDOMRange): Ditto.
3280 (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
3281 (EditingDelegate::shouldApplyStyle): Ditto.
3282 (EditingDelegate::shouldChangeTypingStyle): Ditto.
3283 (EditingDelegate::doPlatformCommand): Ditto.
3284 (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3285 (EditingDelegate::webViewDidChange): Ditto.
3286 (EditingDelegate::webViewDidEndEditing): Ditto.
3287 (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
3288 (EditingDelegate::webViewDidChangeSelection): Ditto.
3289 (EditingDelegate::checkSpellingOfString): Ditto.
3290 * DumpRenderTree/win/FrameLoadDelegate.cpp:
3291 (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3292 (FrameLoadDelegate::FrameLoadDelegate): Ditto.
3293 (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3294 (FrameLoadDelegate::AddRef): Ditto.
3295 (FrameLoadDelegate::Release): Ditto.
3296 (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3297 (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
3298 (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
3299 (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
3300 (FrameLoadDelegate::didReceiveTitle): Ditto.
3301 (FrameLoadDelegate::didChangeIcons): Ditto.
3302 (delegatesWithDelayedWork): Ditto.
3303 (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
3304 (FrameLoadDelegate::didFailLoadWithError): Ditto.
3305 (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
3306 (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
3307 (FrameLoadDelegate::willCloseFrame): Ditto.
3308 (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
3309 (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
3310 (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
3311 (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
3312 (FrameLoadDelegate::didRunInsecureContent): Ditto.
3313 * DumpRenderTree/win/FrameLoadDelegate.h:
3314 * DumpRenderTree/win/HistoryDelegate.cpp:
3315 (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3316 (HistoryDelegate::updateHistoryTitle): Ditto.
3317 (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
3318 * DumpRenderTree/win/PolicyDelegate.cpp:
3320 (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3321 (PolicyDelegate::AddRef): Ditto.
3322 (PolicyDelegate::Release): Ditto.
3323 (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3324 (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
3325 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3326 (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3327 (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3328 (ResourceLoadDelegate::AddRef): Ditto.
3329 (ResourceLoadDelegate::Release): Ditto.
3330 (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3331 (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
3332 (ResourceLoadDelegate::willSendRequest): Ditto.
3333 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
3334 (ResourceLoadDelegate::didReceiveResponse): Ditto.
3335 (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
3336 (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
3337 * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
3338 (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3339 (TestRunner::setUserStyleSheetLocation): Ditto.
3340 (TestRunner::execCommand): Ditto.
3341 (TestRunner::overridePreference): Ditto.
3342 (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
3343 * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
3344 (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3345 (TextInputController::insertText): Ditto.
3346 * DumpRenderTree/win/UIDelegate.cpp:
3347 (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
3348 (UIDelegate::AddRef): Ditto.
3349 (UIDelegate::Release): Ditto.
3350 (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3351 (UIDelegate::trackCustomPopupMenu): Ditto.
3352 (UIDelegate::registerUndoWithTarget): Ditto.
3353 (UIDelegate::removeAllActionsWithTarget): Ditto.
3354 (UIDelegate::setActionTitle): Ditto.
3355 (UIDelegate::undo): Ditto.
3356 (UIDelegate::redo): Ditto.
3357 (UIDelegate::canUndo): Ditto.
3358 (UIDelegate::canRedo): Ditto.
3359 (UIDelegate::printFrame): Ditto.
3360 (UIDelegate::ftpDirectoryTemplatePath): Ditto.
3361 (UIDelegate::webViewHeaderHeight): Ditto.
3362 (UIDelegate::webViewFooterHeight): Ditto.
3363 (UIDelegate::drawHeaderInRect): Ditto.
3364 (UIDelegate::drawFooterInRect): Ditto.
3365 (UIDelegate::webViewPrintingMarginRect): Ditto.
3366 (UIDelegate::canRunModal): Ditto.
3367 (UIDelegate::createModalDialog): Ditto.
3368 (UIDelegate::runModal): Ditto.
3369 (UIDelegate::isMenuBarVisible): Ditto.
3370 (UIDelegate::setMenuBarVisible): Ditto.
3371 (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
3372 (UIDelegate::paintCustomScrollbar): Ditto.
3373 (UIDelegate::paintCustomScrollCorner): Ditto.
3374 (UIDelegate::setFrame): Ditto.
3375 (UIDelegate::webViewFrame): Ditto.
3376 (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
3377 (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
3378 (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
3379 (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
3380 (UIDelegate::webViewAddMessageToConsole): Ditto.
3381 (UIDelegate::doDragDrop): Ditto.
3382 (UIDelegate::webViewGetDlgCode): Ditto.
3383 (UIDelegate::createWebViewWithRequest): Ditto.
3384 (UIDelegate::webViewClose): Ditto.
3385 (UIDelegate::webViewFocus): Ditto.
3386 (UIDelegate::webViewUnfocus): Ditto.
3387 (UIDelegate::webViewPainted): Ditto.
3388 (UIDelegate::exceededDatabaseQuota): Ditto.
3389 (UIDelegate::embeddedViewWithArguments): Ditto.
3390 (UIDelegate::webViewClosing): Ditto.
3391 (UIDelegate::webViewSetCursor): Ditto.
3392 (UIDelegate::webViewDidInvalidate): Ditto.
3393 (UIDelegate::setStatusText): Ditto.
3394 (UIDelegate::desktopNotificationsDelegate): Ditto.
3395 (UIDelegate::drawBackground): Ditto.
3396 (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
3397 (UIDelegate::didPressMissingPluginButton): Ditto.
3398 * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
3399 (LoadItem::invoke): Switch to _bstr_t. Use JSStringCreateWithBSTR.
3400 (LoadHTMLStringItem::invoke): Ditto.
3401 (ScriptItem::invoke): Ditto.
3403 2014-04-09 Gergo Balogh <gbalogh.u-szeged@partner.samsung.com>
3405 Stylechecker: False positive on inline asm code.
3406 https://bugs.webkit.org/show_bug.cgi?id=130570
3408 Reviewed by Csaba Osztrogonác.
3410 Disable stylechecking in asm blocks.
3412 * Scripts/webkitpy/style/checkers/cpp.py:
3415 (_InlineASMState.__init__):
3416 (_InlineASMState.process_line):
3417 (_InlineASMState.isInside):
3419 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3420 (WebKitStyleTest.test_member_initialization_list):
3422 2014-04-09 Carlos Garcia Campos <cgarcia@igalia.com>
3424 [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
3425 https://bugs.webkit.org/show_bug.cgi?id=131029
3427 Reviewed by Philippe Normand.
3429 Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
3430 tests and remove the getWebKit1TestResoucesDir() method.
3432 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3433 (testDownloadLocalFile): Use Test::getResourcesDir().
3434 (testDownloadLocalFileError): Ditto.
3435 (serverCallback): Ditto.
3436 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3437 (serverCallback): Ditto.
3438 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3439 (httpServerCallback): Ditto.
3440 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3441 (serverCallback): Ditto.
3442 * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
3443 * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
3444 * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3445 (Test::getWebKit1TestResoucesDir): Deleted.
3447 2014-04-09 Alexey Proskuryakov <ap@apple.com>
3449 [WK2] HTTP authentication regression tests fail
3450 https://bugs.webkit.org/show_bug.cgi?id=81627
3451 <rdar://problem/11079296>
3453 Reviewed by Anders Carlsson.
3455 * WebKitTestRunner/TestController.h:
3456 * WebKitTestRunner/TestController.cpp:
3457 (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
3458 to pageLoaderClient structure.
3459 (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
3460 for password based authentication (we do get server trust challenges on some tests,
3461 which WKTR can't handle).
3462 When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
3463 calls won't be made, at least on CFNetwork based platforms.
3464 (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
3465 to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
3466 make sense to associate auth requests with individual resources - there can be
3467 multiple resources loading at once from the same protection space, so WebKit1 API
3468 that had a resource identifier was inherently racy.
3470 2014-04-09 Ryuan Choi <ryuan.choi@samsung.com>
3472 [EFL] Change font path for DumpRenderTree and WebKitTestRunner
3473 https://bugs.webkit.org/show_bug.cgi?id=131427
3475 Reviewed by Gyuyoung Kim.
3477 Since r166973, font path was changed.
3479 * DumpRenderTree/PlatformEfl.cmake:
3480 * WebKitTestRunner/PlatformEfl.cmake:
3482 2014-04-08 Geoffrey Garen <ggaren@apple.com>
3484 Fix the build-jsc build
3485 https://bugs.webkit.org/show_bug.cgi?id=131410
3487 Reviewed by Michael Saboff.
3489 * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
3492 2014-04-08 Martin Robinson <mrobinson@igalia.com>
3494 [GTK] Remove WebKit1 unit tests
3495 https://bugs.webkit.org/show_bug.cgi?id=131359
3497 Reviewed by Anders Carlsson.
3499 Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
3500 entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
3501 they were inadvertently left in http://trac.webkit.org/changeset/166504.
3503 * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
3504 * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
3505 * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
3506 * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
3507 * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
3508 * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
3509 * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
3510 * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
3511 * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
3512 * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
3513 * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
3514 * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
3515 * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
3516 * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
3517 * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
3518 * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
3519 * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
3520 * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
3521 * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
3522 * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
3523 * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
3524 * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
3525 * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
3526 * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
3527 * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
3528 * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
3529 * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
3530 * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
3531 * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
3532 * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
3533 * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
3534 * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
3535 * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
3536 * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
3537 * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
3538 * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
3539 * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
3540 * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
3542 2014-04-08 Brent Fulgham <bfulgham@apple.com>
3544 Unreviewed gardening (Take 2): Prevent users from attempting
3545 to build with known invalid cURL.
3547 * Scripts/webkitdirs.pm:
3548 (checkInstalledTools): Check for 7.34.0 (the broken version), not
3549 7.33.0 (the known good version).
3551 2014-04-08 Martin Robinson <mrobinson@igalia.com>
3553 [GTK] Remove DumpRenderTree and GtkLauncher
3554 https://bugs.webkit.org/show_bug.cgi?id=131373
3556 Reviewed by Andreas Kling.
3558 Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
3559 no longer necessary now that WebKit1 GTK+ will be removed.
3562 * DumpRenderTree/PlatformGTK.cmake: Removed.
3563 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
3564 * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
3565 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
3566 * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
3567 * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
3568 * DumpRenderTree/gtk/EventSender.cpp: Removed.
3569 * DumpRenderTree/gtk/EventSender.h: Removed.
3570 * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
3571 * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
3572 * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
3573 * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
3574 * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
3575 * DumpRenderTree/gtk/TextInputController.cpp: Removed.
3576 * DumpRenderTree/gtk/TextInputController.h: Removed.
3577 * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
3578 * GtkLauncher/CMakeLists.txt: Removed.
3579 * GtkLauncher/LauncherInspectorWindow.c: Removed.
3580 * GtkLauncher/LauncherInspectorWindow.h: Removed.
3581 * GtkLauncher/main.c: Removed.
3582 * GtkLauncher/simple.svg: Removed.
3583 * GtkLauncher/text.html: Removed.
3584 * WebKitTestRunner/PlatformGTK.cmake:
3585 * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
3586 * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
3587 * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
3589 2014-04-08 Mark Rowe <mrowe@apple.com>
3591 XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
3592 <https://webkit.org/b/131388> / <rdar://problem/16291687>
3594 Reviewed by Alexey Proskuryakov.
3596 * Scripts/webkitdirs.pm:
3597 (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
3598 (execMacWebKitAppForDebugging): Ditto.
3600 2014-04-08 Geoffrey Garen <ggaren@apple.com>
3602 Build bmalloc on iOS too
3603 https://bugs.webkit.org/show_bug.cgi?id=131381
3605 Reviewed by Andreas Kling.
3607 * Scripts/build-webkit:
3609 2014-04-08 Brent Fulgham <bfulgham@apple.com>
3611 Unreviewed gardening: Prevent users from attempting
3612 to build with known invalid cURL.
3614 * Scripts/webkitdirs.pm:
3615 (checkInstalledTools): Block build attempts with bad
3618 2014-04-07 Geoffrey Garen <ggaren@apple.com>
3620 Build bmalloc on Mac
3621 https://bugs.webkit.org/show_bug.cgi?id=131333
3623 Reviewed by Mark Rowe.
3625 * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
3626 (Note: Just testing Mac is not good enough because in this
3627 script 'Mac' means 'Mac or iOS'.)
3629 2014-03-30 Filip Pizlo <fpizlo@apple.com>
3631 Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
3632 https://bugs.webkit.org/show_bug.cgi?id=130951
3634 Reviewed by Geoffrey Garen.
3636 * Scripts/run-javascriptcore-tests:
3638 2014-04-06 Darin Adler <darin@apple.com>
3640 Rework CSS calc logic, fixing some reference count mistakes in Length
3641 https://bugs.webkit.org/show_bug.cgi?id=131280
3643 Reviewed by Andreas Kling.
3645 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
3646 * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
3648 2014-04-04 Brian J. Burg <burg@cs.washington.edu>