2c4794d51fccbf536937500f001d71bd4ad939af
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-11  Kalev Lember  <kalevlember@gmail.com>
2
3         [GTK] Windows build failure after r136056
4         https://bugs.webkit.org/show_bug.cgi?id=114121
5
6         Reviewed by Martin Robinson.
7
8         * TestWebKitAPI/config.h: Make sure defines are correct for other
9         Windows ports than apple-win.
10
11 2013-04-11  Ojan Vafai  <ojan@chromium.org>
12
13         Remove myself from watchlists.
14         * Scripts/webkitpy/common/config/watchlist:
15
16 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
17
18         Build fix. Don't hard-code queues.webkit.org at least during the transition.
19
20         * QueueStatusServer/templates/statusbubble.html:
21
22 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
23
24         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
25         https://bugs.webkit.org/show_bug.cgi?id=114397
26
27         Reviewed by Benjamin Poulain.
28
29         Reland the patch since Alan appears to have finished the migration.
30
31         * Scripts/webkitpy/common/net/statusserver.py:
32         (StatusServer):
33
34 2013-04-11  Brian Holt  <brian.holt@samsung.com>
35
36         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
37         https://bugs.webkit.org/show_bug.cgi?id=76796
38
39         Reviewed by Chris Fleizach.
40
41         Make the Gtk window for the DRT a toplevel so that it gets the
42         focus from the window manager when the test starts.
43
44         * DumpRenderTree/gtk/DumpRenderTree.cpp:
45         (main):
46
47 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
48
49         Use CSS4 image-rendering to determing image scaling quality
50         https://bugs.webkit.org/show_bug.cgi?id=113405
51
52         Reviewed by Simon Fraser.
53
54         Introduce new flag to enable experimental support for CSS4 Images.
55
56         * Scripts/webkitperl/FeatureList.pm:
57
58 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
59
60         Remove code for Chromium from wkbuild.py
61         https://bugs.webkit.org/show_bug.cgi?id=114423
62
63         Reviewed by Benjamin Poulain.
64
65         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
66         (_should_file_trigger_build):
67         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
68         (ShouldBuildTest):
69
70 2013-04-11  Philippe Normand  <pnormand@igalia.com>
71
72         Unreviewed, update my IRC nickname.
73
74         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
75
76 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
77
78         Remove the rest of Chromium code from webkitpy
79         https://bugs.webkit.org/show_bug.cgi?id=114420
80
81         Reviewed by Benjamin Poulain.
82
83         * Scripts/webkitpy/common/config/urls.py:
84         (view_revision_url):
85         * Scripts/webkitpy/common/host.py:
86         (Host._engage_awesome_locale_hacks):
87         (Host.initialize_scm):
88         (Host):
89         * Scripts/webkitpy/common/host_mock.py:
90         (MockHost.__init__):
91         (MockHost.checkout):
92         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
93         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
94         (JSONResultsGeneratorBase._insert_generic_metadata):
95         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
96         (TestExpectationParser._tokenize_line):
97         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
98         (ExpectationSyntaxTests.test_bare_name_and_bugs):
99         (ExpectationSyntaxTests.test_warnings):
100         * Scripts/webkitpy/layout_tests/port/base.py:
101         (Port.skips_perf_test):
102         (Port.path_to_test_expectations_file):
103         (Port._port_flag_for_scripts):
104         * Scripts/webkitpy/style/checkers/cpp.py:
105         (check_function_definition):
106         (check_include_line):
107         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
108         (OrderOfIncludesTest.test_check_wtf_includes):
109         (WebKitStyleTest.test_webkit_export_check):
110         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
111         (TestExpectationsTestCase.test_valid_expectations):
112         * Scripts/webkitpy/tool/bot/irc_command.py:
113         (Rollout.execute):
114         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
115         (IRCCommandTest.test_whois):
116         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
117         (IRCBotTest.test_help):
118         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
119         (SheriffBotTest.test_command_aliases):
120
121 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
122
123         roll-chromium-deps doesn't roll DEPS
124         https://bugs.webkit.org/show_bug.cgi?id=114421
125
126         Reviewed by Antti Koivisto.
127
128         Roll DEPS. Rolling DEPS. Rolled DEPS.
129
130         * Scripts/webkitpy/tool/bot/irc_command.py:
131         (RollChromiumDEPS.execute):
132
133 2013-04-11  Glenn Adams  <glenn@skynav.com>
134
135         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
136         https://bugs.webkit.org/show_bug.cgi?id=114418
137
138         Reviewed by Ryosuke Niwa.
139
140         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
141         (MockSCM.add): Remove optional remove_exit_code argument.
142         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
143         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
144         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
145         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
146
147 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
148
149         Fix roll-chromium-deps and hi.
150
151         * Scripts/webkitpy/tool/bot/irc_command.py:
152         (Hi.execute):
153         (RollChromiumDEPS.execute):
154
155 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
156
157         Remove webkitpy code to roll Chromium DEPS
158         https://bugs.webkit.org/show_bug.cgi?id=114415
159
160         Reviewed by Benjamin Poulain.
161
162         Removed the code to roll Chromium DEPS in WebKit.
163
164         * Scripts/webkitpy/common/checkout/checkout.py:
165         (Checkout.bug_id_for_this_commit):
166         * Scripts/webkitpy/common/checkout/checkout_mock.py:
167         (MockCheckout.commit_message_for_this_commit):
168         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
169         (CheckoutTest.test_suggested_reviewers):
170         * Scripts/webkitpy/common/checkout/deps.py: Removed.
171         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
172         * Scripts/webkitpy/tool/bot/irc_command.py:
173         (RollChromiumDEPS): Teach webkitbot a sense of humor.
174         (RollChromiumDEPS.execute):
175         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
176         (IRCCommandTest.test_create_bug):
177         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
178         (IRCBotTest.test_revert):
179         * Scripts/webkitpy/tool/bot/sheriff.py:
180         (Sheriff.post_rollout_patch):
181         * Scripts/webkitpy/tool/commands/__init__.py:
182         * Scripts/webkitpy/tool/commands/roll.py: Removed.
183         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
184         * Scripts/webkitpy/tool/steps/__init__.py:
185         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
186         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
187         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
188
189 2013-04-11  Glenn Adams  <glenn@skynav.com>
190
191         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
192         https://bugs.webkit.org/show_bug.cgi?id=114386
193
194         Reviewed by Benjamin Poulain.
195
196         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
197         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
198         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
199         by default and to return exit code 1 if a file/dir had already been added.
200
201         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
202         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
203         * Scripts/webkitpy/common/checkout/scm/svn.py:
204         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
205
206 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
207
208         Unreviewed.
209
210         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
211
212 2013-04-10  Glenn Adams  <glenn@skynav.com>
213
214         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
215         https://bugs.webkit.org/show_bug.cgi?id=114410
216
217         Reviewed by Ryosuke Niwa.
218
219         * Scripts/webkitpy/common/checkout/scm/git.py:
220         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
221         * Scripts/webkitpy/common/checkout/scm/scm.py:
222         (SCM.add): Remove optional return_exit_code argument.
223         (SCM.add_list): Remove optional return_exit_code argument.
224         * Scripts/webkitpy/common/checkout/scm/svn.py:
225         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
226
227 2013-04-10  Eric Seidel  <eric@webkit.org>
228
229         Remove myself from the watchlists, I'm getting too much bug mail. :)
230
231         * Scripts/webkitpy/common/config/watchlist:
232
233 2013-04-10  Commit Queue  <rniwa@webkit.org>
234
235         Unreviewed, rolling out r148158.
236         http://trac.webkit.org/changeset/148158
237         https://bugs.webkit.org/show_bug.cgi?id=114405
238
239         We need to migrate status data (Requested by rniwa on
240         #webkit).
241
242         * Scripts/webkitpy/common/net/statusserver.py:
243         (StatusServer):
244
245 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
246
247         Mass remove all the empty directories
248
249         Rubberstamped by Ryosuke Niwa.
250
251         * BuildSlaveSupport/gtk/crashmon/log: Removed.
252         * BuildSlaveSupport/gtk/xvfb/log: Removed.
253         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
254         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
255         * MiniBrowser/gtk/WebBundle: Removed.
256         * MiniBrowser/win: Removed.
257         * QtTestPlatformPlugin/mac: Removed.
258         * Scripts/webkitpy/tool/bot/testdata: Removed.
259         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
260         * efl/ImageDiff: Removed.
261         * iExploder/htdocs: Removed.
262         * iExploder/iexploder-1.7.2/output: Removed.
263         * iExploder/tools: Removed.
264         * qmake/config.tests/libexecdir: Removed.
265         * qmake/config.tests/libjpeg: Removed.
266         * qmake/config.tests/libpng: Removed.
267
268 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
269
270         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
271         https://bugs.webkit.org/show_bug.cgi?id=114397
272
273         Reviewed by Benjamin Poulain.
274
275         * Scripts/webkitpy/common/net/statusserver.py:
276         (StatusServer):
277
278 2013-04-10  Adam Barth  <abarth@webkit.org>
279
280         Remove abarth from watchlists
281         https://bugs.webkit.org/show_bug.cgi?id=114390
282
283         Reviewed by Ryosuke Niwa.
284
285         I'm trying to cut down on the amount of bugmail I get so that I'll have
286         more of a chance to notice a piece of bugmail directed at me.
287
288         * Scripts/webkitpy/common/config/watchlist:
289
290 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
291
292         webkit-test-results.appspot.com loads the dashboard for Chromium by default
293         https://bugs.webkit.org/show_bug.cgi?id=114381
294
295         Reviewed by Benjamin Poulain.
296
297         Changed the defaults.
298
299         * TestResultServer/static-dashboards/builders.js:
300         * TestResultServer/static-dashboards/dashboard_base.js:
301         (currentBuilderGroupCategory):
302
303 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
304
305         Remove Chromium EWS bots from the queue status server
306         https://bugs.webkit.org/show_bug.cgi?id=113988
307
308         Reviewed by Benjamin Poulain.
309
310         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
311
312         * QueueStatusServer/app.yaml:
313         * QueueStatusServer/config/queues.py:
314         * QueueStatusServer/model/queues.py:
315         (Queue.short_name):
316         (Queue.display_name):
317         * QueueStatusServer/model/queues_unittest.py:
318         (QueueTest.test_short_name):
319         (QueueTest.test_display_name):
320         (QueueTest.test_name_with_underscores):
321         * QueueStatusServer/templates/activebots.html:
322
323 2013-04-10  Ojan Vafai  <ojan@chromium.org>
324
325         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
326         https://bugs.webkit.org/show_bug.cgi?id=114370
327
328         Reviewed by Ryosuke Niwa.
329
330         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
331         Unfortunately, there's no way to test this until this is committed and there is
332         a master restart.
333
334         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
336         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
338         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
339         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
340         * TestResultServer/generate_builders_json.py:
341         * TestResultServer/static-dashboards/dashboard_base.js:
342         * TestResultServer/static-dashboards/loader.js:
343
344 2013-04-10  Glenn Adams  <glenn@skynav.com>
345
346         [Qt] Fix regression to test-webkitpy.
347         https://bugs.webkit.org/show_bug.cgi?id=114368
348
349         Reviewed by Ryosuke Niwa.
350
351         * Scripts/webkitpy/layout_tests/port/factory.py:
352         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
353         (PortFactory.get): Remove obsolete chromium port related code.
354         * Scripts/webkitpy/layout_tests/port/mac.py:
355         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
356
357 2013-04-10  Anders Carlsson  <andersca@apple.com>
358
359         Remove unneeded headers from FrameLoader.h
360         https://bugs.webkit.org/show_bug.cgi?id=114223
361
362         Reviewed by Geoffrey Garen.
363
364         Add back headers implicitly included by other headers.
365
366         * WebKitTestRunner/WorkQueueManager.cpp:
367
368 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
369
370         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
371         https://bugs.webkit.org/show_bug.cgi?id=114365
372
373         Reviewed by Martin Robinson.
374
375         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
376         The patch addresses crashes in the tally_event_reply method. It is already committed into the
377         at-spi2-atk source tree and will be available with the next stable release, after which the
378         patch should be removed and the dependency version bumped.
379
380         * gtk/jhbuild.modules:
381         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
382
383 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
384
385         [WinCairo] Unreviewed build fix. Correct DropBox download link.
386
387         * Scripts/update-webkit-wincairo-libs: Revise download URL to
388         match change in DropBox server behavior.
389
390 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
391
392         Removed an annoying message from svn-create-patch
393         https://bugs.webkit.org/show_bug.cgi?id=114332
394
395         Reviewed by Alexey Proskuryakov.
396
397         I see this message basically every time I write a patch, so it must not
398         be true.
399
400         * Scripts/svn-create-patch:
401         (generateDiff):
402
403 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
404
405         [GTK] Add support for Page Visibility
406         https://bugs.webkit.org/show_bug.cgi?id=97324
407
408         Reviewed by Sam Weinig.
409
410         Implemented test runner API for page visibility layout tests.
411
412         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
413         (TestRunner::resetPageVisibility):
414         (TestRunner::setPageVisibility):
415         * Scripts/webkitperl/FeatureList.pm:
416
417 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
418
419         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
420         https://bugs.webkit.org/show_bug.cgi?id=114342
421
422         Reviewed by Gyuyoung Kim.
423
424         Commit 148033 only added an implementation for the Mac port, which made
425         other ports fail most tests since loading the injected bundle failed
426         with a missing symbol.
427
428         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
429         (WTR::AccessibilityUIElement::pathDescription):
430
431 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
432
433         [EFL] Add spell checking option to MiniBrowser
434         https://bugs.webkit.org/show_bug.cgi?id=114282
435
436         Reviewed by Ryosuke Niwa.
437
438         Spell checking is enabled by adding a flag (t/text-checking)
439         with launching MiniBrowser.
440
441         * MiniBrowser/efl/main.c:
442         (window_create):
443         (elm_main):
444
445 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
446
447         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
448         https://bugs.webkit.org/show_bug.cgi?id=113281
449
450         Reviewed by Darin Adler.
451
452         * Scripts/run-gtk-tests:
453         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
454
455 2013-04-09  Glenn Adams  <glenn@skynav.com>
456
457         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
458
459         Unreviewed.
460
461         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
462         (RunTest.test_build_check):
463
464 2013-04-09  Glenn Adams  <glenn@skynav.com>
465
466         [webkitpy] Remove chromium ports.
467         https://bugs.webkit.org/show_bug.cgi?id=114326
468
469         Reviewed by Dirk Pranke.
470
471         As a side effect, also:
472
473         - remove chromium builders from webkitpy.layout_tests.port.builders
474         - remove chromium builders from rebaseline
475         - rewrite chromium dependent tests in rebaseline_unittest
476         - remove chromium platform from garden-o-matic
477         - select apple platform as default platform in garden-o-matic
478         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
479
480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
481         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
482         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
483         (BaselineOptimizerTest.test_move_baselines):
484         (BaselineOptimizerTest.test_efl):
485         (BaselineOptimizerTest.test_no_add_mac_future):
486         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
487         (BaselineOptimizerTest.test_common_directory_includes_root):
488         (BaselineOptimizerTest.test_complex_shadowing):
489         (BaselineOptimizerTest.test_virtual_ports_filtered):
490         * Scripts/webkitpy/layout_tests/port/builders.py:
491         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
492         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
493         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
494         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
495         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
496         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
497         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
498         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
499         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
500         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
501         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
502         * Scripts/webkitpy/layout_tests/port/factory.py:
503         (platform_options):
504         (PortFactory):
505         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
506         (FactoryTest.test_qt):
507         (FactoryTest.test_get_from_builder_name):
508         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
509         (RunTest.test_build_check):
510         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
511         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
512         * Scripts/webkitpy/tool/commands/rebaseline.py:
513         (Rebaseline._builders_to_pull_from):
514         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
515         (_BaseTestCase):
516         (_BaseTestCase.setUp):
517         (TestRebaselineTest.setUp):
518         (TestRebaselineTest.test_baseline_directory):
519         (test_rebaseline_updates_expectations_file):
520         (test_rebaseline_does_not_include_overrides):
521         (test_rebaseline_test):
522         (test_rebaseline_test_and_print_scm_changes):
523         (test_rebaseline_and_copy_test):
524         (test_rebaseline_and_copy_test_no_existing_result):
525         (test_rebaseline_and_copy_test_with_lion_result):
526         (test_rebaseline_and_copy_no_overwrite_test):
527         (TestRebaselineExpectations.test_rebaseline_expectations):
528
529 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
530
531         newcommitbot (WKR) requires a subversion checkout
532         https://bugs.webkit.org/show_bug.cgi?id=114309
533
534         Reviewed by Benjamin Poulain.
535
536         Directly talk to the subversion server instead of relying on a local checkout.
537         This allows us to run WKR off of a git clone.
538
539         * Scripts/webkitpy/tool/commands/newcommitbot.py:
540         (NewCommitBot.next_work_item):
541         (NewCommitBot.process_work_item):
542
543 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
544
545         webkitbot refers to sheriffbot in help
546         https://bugs.webkit.org/show_bug.cgi?id=114307
547
548         Reviewed by Benjamin Poulain.
549
550         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
551
552         * Scripts/webkitpy/tool/bot/irc_command.py:
553         (Help):
554         (Help.execute):
555         (RollChromiumDEPS.execute):
556         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
557         (IRCBotTest.test_help):
558         * Scripts/webkitpy/tool/bot/sheriff.py:
559         (Sheriff.name):
560
561 2013-04-06  Roger Fong  <roger_fong@apple.com>
562
563         Kill old processes between runs on WinEWS bots.
564         Temporarily disable tests to let bots catch up again.
565
566         * EWSTools/start-queue-win.sh:
567         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
568         (WinEWS):
569
570 2013-04-09  Glenn Adams  <glenn@skynav.com>
571
572         [webkitpy] Remove chromium deprecated port support.
573         https://bugs.webkit.org/show_bug.cgi?id=114228
574
575         Reviewed by Ryosuke Niwa.
576
577         * Scripts/webkitpy/common/config/ports.py:
578         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
579         (ChromiumPort): Removed.
580         (ChromiumAndroidPort): Removed.
581         (ChromiumXVFBPort): Removed.
582         * Scripts/webkitpy/common/config/ports_unittest.py:
583         (DeprecatedPortTest.test_chromium_port): Removed.
584         (DeprecatedPortTest.test_chromium_android_port): Removed.
585         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
586         * Scripts/webkitpy/tool/steps/update_unittest.py:
587         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
588         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
589
590 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
591
592         AX: The bounding paths should be made available through accessibility
593         https://bugs.webkit.org/show_bug.cgi?id=113817
594
595         Reviewed by David Kilzer.
596
597         Add a pathDescription property for testing so that it's possible
598         to verify that a path is being returned correctly.
599
600         * DumpRenderTree/AccessibilityUIElement.cpp:
601         (getPathDescriptionCallback):
602         (AccessibilityUIElement::pathDescription):
603         (AccessibilityUIElement::getJSClass):
604         * DumpRenderTree/AccessibilityUIElement.h:
605         (AccessibilityUIElement):
606         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
607         (_CGPathEnumerationIteration):
608         (AccessibilityUIElement::pathDescription):
609         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
610         (AccessibilityUIElement::pathDescription):
611         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
612         (WTR::AccessibilityUIElement::pathDescription):
613         (WTR):
614         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
615         (AccessibilityUIElement):
616         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
617         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
618         (WTR::AccessibilityUIElement::pathDescription):
619         (WTR):
620
621 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
622
623         [EFL] Declare TEST_THEME_DIR in a single place.
624         https://bugs.webkit.org/show_bug.cgi?id=114285
625
626         Reviewed by Anders Carlsson.
627
628         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
629
630         * DumpRenderTree/efl/CMakeLists.txt:
631         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
632         (DumpRenderTreeChrome::createView):
633         (DumpRenderTreeChrome::createInspectorView):
634         (DumpRenderTreeChrome::initialize):
635         (DumpRenderTreeChrome::onDownloadRequest):
636         * EWebLauncher/CMakeLists.txt:
637         * EWebLauncher/main.c:
638         (findThemePath):
639         * EWebLauncher/url_bar.c:
640         (url_bar_add):
641         * MiniBrowser/efl/CMakeLists.txt:
642         * MiniBrowser/efl/main.c:
643         (window_create):
644         * TestWebKitAPI/PlatformEfl.cmake:
645         * TestWebKitAPI/efl/PlatformWebView.cpp:
646         (TestWebKitAPI::PlatformWebView::PlatformWebView):
647         * WebKitTestRunner/PlatformEfl.cmake:
648         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
649         (WTR::PlatformWebView::PlatformWebView):
650
651 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
652
653         [GTK][AC] upversion of clutter and its dependecy
654         https://bugs.webkit.org/show_bug.cgi?id=114016
655
656         Reviewed by Gustavo Noronha Silva.
657
658         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
659
660         * gtk/jhbuild-optional.modules:
661
662 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
663
664         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
665         https://bugs.webkit.org/show_bug.cgi?id=89875
666
667         Reviewed by Maciej Stachowiak.
668
669         Add unit tests to verify if the handling of the open, openat, creat syscall
670         is being done right. We check if the Read/Write/ReadAndWrite permissions
671         are respected, if the canonical path is being resolved and if
672         the permissions are falling back to the topmost parent directory with a
673         policy set when the directory being opened has no policy.
674
675         We also test if any attempt of blocking SIGSYS is silently ignored.
676         SIGSYS cannot be blocked because in it's handler is where we hook
677         syscalls to the broker process.
678
679         Also added libseccomp to EFL's jhbuild to make the life of developers
680         willing to help easier.
681
682         * Scripts/webkitperl/FeatureList.pm:
683         * TestWebKitAPI/PlatformEfl.cmake:
684         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
685         (TestWebKitAPI):
686         (SeccompEnvironment):
687         (TestWebKitAPI::SeccompEnvironment::SetUp):
688         (TestWebKitAPI::SeccompEnvironment::TearDown):
689         (TestWebKitAPI::dummyHandler):
690         (TestWebKitAPI::TEST):
691         (TestWebKitAPI::stressTest):
692         * efl/jhbuild.modules:
693         * qmake/mkspecs/features/features.pri:
694
695 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
696
697         REGRESSION: Autocorrection doesn't work in DumpRenderTree
698         https://bugs.webkit.org/show_bug.cgi?id=113846
699
700         Reviewed by Alexey Proskuryakov.
701
702         The problem was that we were replacing NSSpellCheck's dictionary with our own
703         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
704
705         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
706         and "would" respectively in DumpRenderTree.
707
708         * DumpRenderTree/mac/DumpRenderTree.mm:
709         (resetDefaultsToConsistentValues):
710
711 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
712
713         Remove the gyp files for Tools
714         https://bugs.webkit.org/show_bug.cgi?id=114248
715
716         Reviewed by Ryosuke Niwa.
717
718         * DumpRenderTree/DumpRenderTree.gyp: Removed.
719         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
720         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
721         * DumpRenderTree/DumpRenderTree.gypi: Removed.
722         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
723         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
724         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
725         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
726
727 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
728
729         WKR (new-commit-bot) is too slow
730         https://bugs.webkit.org/show_bug.cgi?id=110087
731
732         Reviewed by Geoffrey Garen.
733
734         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
735         Just run "svn log -r <revision>" instead to cut down the delay.
736
737         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
738
739         * Scripts/webkitpy/tool/commands/newcommitbot.py:
740         (NewCommitBot):
741         (NewCommitBot.next_work_item):
742         (NewCommitBot._is_empty_log):
743         (NewCommitBot._update_checkout):
744
745 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
746
747         Build fix. Can't remove appendCustomBuildFlags.
748
749         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
750         (appendCustomBuildFlags):
751
752 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
753
754         Remove Chromium builders from build.webkit.org
755         https://bugs.webkit.org/show_bug.cgi?id=113990
756
757         Reviewed by Benjamin Poulain.
758
759         Removed.
760
761         * BuildSlaveSupport/build.webkit.org-config/config.json:
762         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
763         (InstallGtkDependencies):
764         (RunUnitTests.start):
765         (RunWebKit2Tests.start):
766         (Factory.__init__):
767         (unitTestsSupported):
768         (TestFactory.__init__):
769         (BuildAndTestFactory.__init__):
770         (BuildAndPerfTestFactory.__init__):
771         (BuildAndPerfTestWebKit2Factory.__init__):
772         (DownloadAndPerfTestFactory.__init__):
773         (loadBuilderConfig):
774         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
775
776 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
777
778         Remove HTML Notification
779         https://bugs.webkit.org/show_bug.cgi?id=114231
780
781         Reviewed by Ryosuke Niwa.
782
783         * qmake/mkspecs/features/features.pri:
784
785 2013-04-08  Glenn Adams  <glenn@skynav.com>
786
787         Remove chromium EWS support, and fix broken test.
788         https://bugs.webkit.org/show_bug.cgi?id=114221
789
790         Reviewed by Ryosuke Niwa.
791
792         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
793         (AbstractChromiumEWS): Removed.
794         (ChromiumLinuxEWS): Removed.
795         (ChromiumLinuxDebugEWS): Removed.
796         (ChromiumWindowsEWS): Removed.
797         (ChromiumAndroidEWS): Removed.
798         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
799         (EarlyWarningSystemTest): Fix misspelled class name.
800         (test_ewses): Fix entry point name to ensure test is run.
801
802 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
803
804         [WIN] Remove WebKit2 source code
805         https://bugs.webkit.org/show_bug.cgi?id=114096
806
807         Reviewed by Anders Carlsson.
808
809         Remove the windows specific parts of the MiniBrowser.
810
811         * MiniBrowser/MiniBrowser.vcproj: Removed.
812         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
813         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
814         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
815         * MiniBrowser/win/BrowserView.cpp: Removed.
816         * MiniBrowser/win/BrowserView.h: Removed.
817         * MiniBrowser/win/BrowserWindow.cpp: Removed.
818         * MiniBrowser/win/BrowserWindow.h: Removed.
819         * MiniBrowser/win/MiniBrowser.cpp: Removed.
820         * MiniBrowser/win/MiniBrowser.h: Removed.
821         * MiniBrowser/win/MiniBrowser.rc: Removed.
822         * MiniBrowser/win/main.cpp: Removed.
823         * MiniBrowser/win/resource.h: Removed.
824         * MiniBrowser/win/stdafx.cpp: Removed.
825         * MiniBrowser/win/stdafx.h: Removed.
826
827 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
828
829         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
830
831         * Scripts/webkitpy/common/config/irc.py:
832
833 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
834
835         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
836         https://bugs.webkit.org/show_bug.cgi?id=113139
837
838         Reviewed by Anders Carlsson.
839
840         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
841         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
842         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
843         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
844         (ToStringAndValueOfObject):
845         (ToStringAndValueOfObject::ToStringAndValueOfObject):
846         (ScriptableObject):
847         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
848         (ToStringAndValueOfObject::ScriptableObject::invoke):
849         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
850         (ToStringAndValueOfObject::NPP_GetValue):
851         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
852         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
853         * GNUmakefile.am:
854
855 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
856
857         [GTK] Bump gnome-themes-standard to 3.6.0
858         https://bugs.webkit.org/show_bug.cgi?id=114155
859
860         Reviewed by Martin Robinson.
861
862         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
863         dependency of gnome-themes-standard accordingly.
864
865 2013-04-08  David Levin  <levin@chromium.org>
866
867         Remove my watchlist entries.
868         https://bugs.webkit.org/show_bug.cgi?id=114180
869
870         Reviewed by Adam Barth.
871
872         * Scripts/webkitpy/common/config/committers.py:
873         * Scripts/webkitpy/common/config/watchlist:
874
875 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
876
877         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
878         https://bugs.webkit.org/show_bug.cgi?id=114161
879
880         Reviewed by Gyuyoung Kim.
881
882         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
883         as it is crashing due to Bug 111074.
884
885         * TestWebKitAPI/PlatformEfl.cmake:
886
887 2013-04-07  David Kilzer  <ddkilzer@apple.com>
888
889         Remove the rest of SVG_DOM_OBJC_BINDINGS
890         <http://webkit.org/b/114112>
891
892         Reviewed by Geoffrey Garen.
893
894         * Scripts/webkitperl/FeatureList.pm:
895         - Remove --svg-dom-objc-bindings switch.
896         * qmake/mkspecs/features/features.pri:
897         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
898
899 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
900
901         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
902         https://bugs.webkit.org/show_bug.cgi?id=114089
903
904         Reviewed by Chris Fleizach.
905
906         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
907         * DumpRenderTree/AccessibilityController.cpp:
908         * DumpRenderTree/AccessibilityUIElement.cpp:
909         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
910         (DumpRenderTreeChrome::DumpRenderTreeChrome):
911         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
912         (DumpRenderTreeChrome):
913
914 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
915
916         Build fix after r147857, remove remaining USE(JSC) guards.
917
918         Unreviewed.
919
920         * DumpRenderTree/config.h:
921         * TestWebKitAPI/config.h:
922         * WebKitTestRunner/config.h:
923
924 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
925
926         Rename sheriffbot to webkitbot
927         https://bugs.webkit.org/show_bug.cgi?id=114109
928
929         Reviewed by Benjamin Poulain.
930
931         Renamed since sheriffbot will be used in Blink.
932
933         * Scripts/webkitpy/tool/commands/sheriffbot.py:
934         (SheriffBot):
935         (SheriffBot.begin_work_queue):
936
937 2013-04-06  Oliver Hunt  <oliver@apple.com>
938
939         Unify the many and varied stack trace mechanisms, and make the result sane.
940         https://bugs.webkit.org/show_bug.cgi?id=114072
941
942         Reviewed by Filip Pizlo.
943
944         The commandline jsc executable no longer requires arguments, so
945         I've made run-jsc work without them.
946
947         * Scripts/run-jsc:
948
949 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
950
951         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
952         https://bugs.webkit.org/show_bug.cgi?id=114086
953
954         Reviewed by Tim Horton.
955
956         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
957
958 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
959
960         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
961         https://bugs.webkit.org/show_bug.cgi?id=114083
962
963         Reviewed by Ryosuke Niwa.
964
965         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
966         in TestWebKitAPI and WebKitTestRunner.
967
968         * TestWebKitAPI/config.h:
969         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
970         (TestWebKitAPI::InjectedBundleController::platformInitialize):
971         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
972         (WTR::InjectedBundle::platformInitialize):
973
974 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
975
976         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
977         https://bugs.webkit.org/show_bug.cgi?id=114094
978
979         Reviewed by Anders Carlsson.
980
981         * Scripts/run-jsc:
982
983 2013-04-05  Ojan Vafai  <ojan@chromium.org>
984
985         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
986         https://bugs.webkit.org/show_bug.cgi?id=114080
987
988         Reviewed by Ryosuke Niwa.
989
990         This way, the WebKit and Blink dashboard code can change as appropriate without
991         needing to consider the other project's needs. This still doesn't update the
992         buildbots to upload to the new location, or the dashboard code to pull the
993         results.json files from the new location, but it at least allows for changing the
994         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
995
996         * TestResultServer/app.yaml:
997
998 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
999
1000         Re-enable testing on the commit queue
1001         https://bugs.webkit.org/show_bug.cgi?id=114078
1002
1003         Reviewed by Darin Adler.
1004
1005         Re-enabled the feature and the associated tests.
1006
1007         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1008         (CommitQueueTask.run):
1009         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1010         (CommitQueueTaskTest._run_through_task):
1011         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1012         (CommitQueueTest._mock_test_result):
1013
1014 2013-04-05  Oliver Hunt  <oliver@apple.com>
1015
1016         Unify the many and varied stack trace mechanisms, and make the result sane.
1017         https://bugs.webkit.org/show_bug.cgi?id=114072
1018
1019         Reviewed by Filip Pizlo.
1020
1021         The commandline jsc executable no longer requires arguments, so
1022         I've made run-jsc work without them.
1023
1024         * Scripts/run-jsc:
1025
1026 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1027
1028         AX: Make SVG Group containers accessible elements
1029         https://bugs.webkit.org/show_bug.cgi?id=113939
1030
1031         Reviewed by Simon Fraser.
1032
1033         Implement axController.elementAtPoint for iOS.
1034         Implement a correct version of clickPoint for iOS.
1035
1036         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1037         (AccessibilityController::elementAtPoint):
1038         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1039         (AccessibilityUIElement::clickPointX):
1040         (AccessibilityUIElement::clickPointY):
1041
1042 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1043
1044         Unreviewed, rolling out r147773 and r147774.
1045         http://trac.webkit.org/changeset/147773
1046         http://trac.webkit.org/changeset/147774
1047         https://bugs.webkit.org/show_bug.cgi?id=114056
1048
1049         Causing some exceptions on AppEngine I don't understand
1050         (Requested by rniwa on #webkit).
1051
1052         * QueueStatusServer/config/queues.py:
1053         * QueueStatusServer/model/queues.py:
1054         (Queue.short_name):
1055         (Queue.display_name):
1056         * QueueStatusServer/model/queues_unittest.py:
1057         (QueueTest.test_short_name):
1058         (QueueTest.test_display_name):
1059         (QueueTest.test_name_with_underscores):
1060
1061 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
1062
1063         Fixed run-bindings-tests by removing V8
1064         https://bugs.webkit.org/show_bug.cgi?id=114053
1065
1066         Reviewed by Benjamin Poulain.
1067
1068         * Scripts/run-bindings-tests:
1069         (main):
1070
1071 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1072
1073         Build fix.
1074
1075         * QueueStatusServer/model/queues.py:
1076         (Queue.short_name):
1077         (Queue.display_name):
1078
1079 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1080
1081         Remove Chromium EWS bots from the queue status server
1082         https://bugs.webkit.org/show_bug.cgi?id=113988
1083
1084         Reviewed by Benjamin Poulain.
1085
1086         Removed Chromium EWS bots.
1087
1088         * QueueStatusServer/config/queues.py:
1089         * QueueStatusServer/model/queues.py:
1090         (Queue.short_name):
1091         (Queue.display_name):
1092         * QueueStatusServer/model/queues_unittest.py:
1093         (QueueTest.test_short_name):
1094         (QueueTest.test_display_name):
1095         (QueueTest.test_name_with_underscores):
1096
1097 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1098
1099         [EFL] Enable indexed database
1100         https://bugs.webkit.org/show_bug.cgi?id=107248
1101
1102         Reviewed by Alexis Menard.
1103
1104         * Scripts/webkitperl/FeatureList.pm:
1105
1106 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
1107
1108         Remove vestiges of Chromium bits from watchlists.
1109         https://bugs.webkit.org/show_bug.cgi?id=114047
1110
1111         Reviewed by Ryosuke Niwa.
1112
1113         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
1114
1115 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1116
1117         Add James Craig to the contributors list.
1118
1119         * Scripts/webkitpy/common/config/committers.py:
1120
1121 2013-04-04  Kent Tamura  <tkent@chromium.org>
1122
1123         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1124
1125         * Scripts/webkitpy/common/config/watchlist:
1126
1127 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1128
1129         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1130         https://bugs.webkit.org/show_bug.cgi?id=113997
1131
1132         Reviewed by Ryosuke Niwa.
1133
1134         Disable the tests until Ryosuke gets the time and hardware to have
1135         a testing commit-queue.
1136
1137         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1138         (CommitQueueTaskTest):
1139         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1140         (CommitQueueTest):
1141
1142 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1143
1144         Remove Chromium builders from build.webkit.org
1145         https://bugs.webkit.org/show_bug.cgi?id=113990
1146
1147         Reviewed by Benjamin Poulain.
1148
1149         Land the part to disable triggering of Chromium builders first so that we may start
1150         deleting more Chromium code that breaks the update step.
1151
1152         * BuildSlaveSupport/build.webkit.org-config/config.json:
1153
1154 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1155
1156         Remove Chromium's DumpRenderTree
1157         https://bugs.webkit.org/show_bug.cgi?id=113989
1158
1159         Reviewed by Kent Tamura.
1160
1161         On second thought, let's not go to Camelot. It is a silly place.
1162
1163         * DumpRenderTree/mac/DumpRenderTree.mm:
1164         (resetDefaultsToConsistentValues):
1165
1166 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1167
1168         Nixed the defunct chromium folder from DumpRenderTree
1169         https://bugs.webkit.org/show_bug.cgi?id=113993
1170
1171         Reviewed by Ryosuke Niwa.
1172
1173         * DumpRenderTree/chromium: Removed.
1174         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1175         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1176         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1177         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1178         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1179         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1180         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1181         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1182         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1183         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1184         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1185         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1186         * DumpRenderTree/chromium/Task.cpp: Removed.
1187         * DumpRenderTree/chromium/Task.h: Removed.
1188         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1189         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1190         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1191         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1192         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1193         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1194         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1195         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1196         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1197         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1198         * DumpRenderTree/chromium/TestRunner: Removed.
1199         * DumpRenderTree/chromium/TestRunner/public: Removed.
1200         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1201         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1202         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1203         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1204         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1205         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1206         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1207         * DumpRenderTree/chromium/TestRunner/src: Removed.
1208         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1209         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1210         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1211         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1212         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1213         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1214         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1215         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1216         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1217         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1218         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1219         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1220         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1221         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1222         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1223         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1224         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1225         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1226         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1227         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1228         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1229         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1230         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1231         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1232         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1233         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1234         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1235         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1236         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1237         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1238         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1239         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1240         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1241         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1242         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1243         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1244         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1245         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1246         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1247         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1248         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1249         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1250         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1251         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1252         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1253         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1254         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1255         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1256         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1257         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1258         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1259         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1260         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1261         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1262         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1263         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1264         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1265         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1266         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1267         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1268         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1269         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1270         * DumpRenderTree/chromium/TestShell.h: Removed.
1271         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1272         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1273         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1274         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1275         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1276         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1277         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1278         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1279         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1280         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1281         * DumpRenderTree/chromium/config.h: Removed.
1282         * DumpRenderTree/chromium/fonts.conf: Removed.
1283
1284 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1285
1286         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1287
1288         Rubber stamped by Benjamin Poulain.
1289
1290         * RebaselineQueueServer: Removed.
1291         * RebaselineQueueServer/app.yaml: Removed.
1292         * RebaselineQueueServer/handlers: Removed.
1293         * RebaselineQueueServer/handlers/__init__.py: Removed.
1294         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1295         * RebaselineQueueServer/handlers/pages.py: Removed.
1296         * RebaselineQueueServer/index.yaml: Removed.
1297         * RebaselineQueueServer/main.py: Removed.
1298         * RebaselineQueueServer/model: Removed.
1299         * RebaselineQueueServer/model/__init__.py: Removed.
1300         * RebaselineQueueServer/model/queueentry.py: Removed.
1301         * RebaselineQueueServer/static: Removed.
1302         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1303         * RebaselineQueueServer/static/styles.css: Removed.
1304         * RebaselineQueueServer/templates: Removed.
1305         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1306         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1307         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1308         * RebaselineQueueServer/templates/home.html: Removed.
1309
1310 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1311
1312         Fix setup-commit-queue and temporarily disable testing on commit-queue
1313         https://bugs.webkit.org/show_bug.cgi?id=113979
1314
1315         Reviewed by Benjamin Poulain.
1316
1317         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1318         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1319
1320         * EWSTools/setup-commit-queue.sh:
1321         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1322         (CommitQueueTask.run):
1323
1324 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1325
1326         temporarily make flakiness dashboard work again webkit.org bots
1327         https://bugs.webkit.org/show_bug.cgi?id=113972
1328
1329         Reviewed by Ojan Vafai.
1330
1331         This patch disables the chromium.org layout test bots TestExpectations
1332         parsing temporarily until we can work out the right way to split into
1333         two instances for webkit.org and chromium.org and figure out which
1334         code to delete where :).
1335
1336         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1337
1338 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1339
1340         Fix webkitpy tests after r147678.
1341
1342         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1343         (CommitQueueTest.test_commit_queue):
1344         (test_manual_reject_during_processing):
1345
1346 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1347
1348         The commit queue should use Mac MountainLion port
1349         https://bugs.webkit.org/show_bug.cgi?id=113971
1350
1351         Reviewed by Lucas Forschler.
1352
1353         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1354         * Scripts/webkitpy/tool/commands/queues.py:
1355         (CommitQueue):
1356
1357 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1358
1359         turn off running tests on chromium linux EWS bots
1360         https://bugs.webkit.org/show_bug.cgi?id=113959
1361
1362         Reviewed by Geoffrey Garen.
1363
1364         Now that the Chromium port is no longer being maintained
1365         there's little point in running the tests. Soon we should
1366         just shut this bot off altogether.
1367
1368         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1369         (ChromiumLinuxEWS):
1370
1371 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1372
1373         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1374
1375         * Scripts/webkitpy/common/config/watchlist:
1376
1377 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1378
1379         Indentation fix to get webkit-patch working again after r147625
1380
1381         Unreviewed.
1382
1383         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1384         (MacEWS):
1385         (MacWK2EWS):
1386
1387 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1388
1389         Turn tests back on for Mac WK1/WK2 EWS.
1390         
1391         Unreviewed.
1392         
1393         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1394         (MacEWS):
1395         (MacWK2EWS):
1396
1397 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1398
1399         [GTK][WK2] MiniBrowser custom URI scheme support
1400         https://bugs.webkit.org/show_bug.cgi?id=112419
1401
1402         Reviewed by Carlos Garcia Campos.
1403
1404         Add support for about URIs in MiniBrowser. An example about page is show
1405         with URI "about:minibrowser", the rest of the cases it will show a
1406         proper message explaining that the about page didn't exist.
1407
1408         Internally it uses "minibrowser-about" prefix instead of "about", but
1409         from the user point of view it works with "about" prefix.
1410
1411         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1412         (getInternalURI): Method to convert URIs from "about" prefix to
1413         "minibrowser-about".
1414         (getExternalURI): Opposite method.
1415         (webViewURIChanged): Use "about" prefix to show the URI to users.
1416         (webViewEnterFullScreen): Ditto.
1417         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1418         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1419         (aboutURISchemeRequestCallback): Callback to manage about calls.
1420         (main): Register the URI scheme to manage about URIs.
1421
1422 2013-04-03  Roger Fong  <roger_fong@apple.com>
1423
1424         Re-enable WinEWS tests.
1425
1426         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1427         (WinEWS):
1428
1429 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1430
1431         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1432         https://bugs.webkit.org/show_bug.cgi?id=113883
1433
1434         Reviewed by Martin Robinson.
1435
1436         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1437         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1438         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1439
1440 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1441
1442         [GTK] Include Pango in jhbuild-optional.modules
1443         https://bugs.webkit.org/show_bug.cgi?id=113878
1444
1445         Reviewed by Martin Robinson.
1446
1447         Since r147547 Pango 1.32.0 is required. Including the module in the
1448         JHBuild optional moduleset.
1449
1450         * gtk/jhbuild-optional.modules: Add Pango module.
1451
1452 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1453
1454         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1455         https://bugs.webkit.org/show_bug.cgi?id=113864
1456
1457         Moving setDefersLoading from TestRunnerQt to TestRunner
1458         requires access to the non-Qt TestRunner.
1459         As long as we instantiate both TestRunner and TestRunnerQt,
1460         we need a separate getter for the non-Qt TestRunner instance.
1461
1462         Reviewed by Simon Hausmann.
1463
1464         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1465         (WebPage::resetSettings):
1466         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1467         (DumpRenderTree::jscTestRunner):
1468         * DumpRenderTree/qt/TestRunnerQt.cpp:
1469         (TestRunner::setDefersLoading):
1470             Moving setDefersLoading from TestRunnerQt
1471             to TestRunner.
1472         * DumpRenderTree/qt/TestRunnerQt.h:
1473         (TestRunnerQt):
1474
1475 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1476
1477         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1478         https://bugs.webkit.org/show_bug.cgi?id=104779
1479
1480         Reviewed by Carlos Garcia Campos.
1481
1482         * Scripts/run-gtk-tests:
1483         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1484         passing in current trunk.
1485
1486 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1487
1488         Fix HAVE(QTTESTSUPPORT) logic
1489
1490         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1491         resulting in HAVE(QTTESTSUPPORT) never being true.
1492         Move that logic down in sanitizeFeatures.
1493
1494         Rubber-stamped by Tor Arne Vestbø.
1495
1496         * qmake/mkspecs/features/features.prf:
1497
1498 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1499
1500         [GTK] Bump required versions of some dependencies
1501         https://bugs.webkit.org/show_bug.cgi?id=113282
1502
1503         Reviewed by Martin Robinson.
1504
1505         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1506
1507 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1508
1509         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1510         https://bugs.webkit.org/show_bug.cgi?id=113809
1511
1512         Reviewed by Philippe Normand.
1513
1514         Newer Linux kernels have removed some deprecated macros from v4l2
1515         headers, causing gst-plugins-good's build to break. We don't need it
1516         right now, so just disable it.
1517
1518         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1519
1520 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1521
1522         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1523         https://bugs.webkit.org/show_bug.cgi?id=113535
1524
1525         Reviewed by Simon Hausmann.
1526
1527         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1528
1529         * qmake/mkspecs/features/features.prf:
1530
1531 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1532
1533         [Qt] Move logic of simple forwarding functions to TestRunner.
1534         https://bugs.webkit.org/show_bug.cgi?id=113863
1535
1536         Reviewed by Simon Hausmann.
1537
1538         * DumpRenderTree/qt/TestRunnerQt.cpp:
1539         (TestRunner::setTextDirection):
1540         (TestRunner::goBack):
1541         (TestRunner::evaluateScriptInIsolatedWorld):
1542         (TestRunner::addUserStyleSheet):
1543         * DumpRenderTree/qt/TestRunnerQt.h:
1544         (TestRunnerQt):
1545
1546 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1547
1548         [Qt] Disable media support using QuickTime if deployment target != SDK
1549
1550         We link to a single libWebKitSystemInterface static lib, so unless the
1551         deployment target matches the SDK let's not pretend like we'll be able
1552         to run on anything lower than the SDK version.
1553
1554         Reviewed by Simon Hausmann.
1555
1556         * qmake/mkspecs/features/features.prf:
1557
1558 2013-04-02  James Craig  <james@cookiecrook.com>
1559
1560         AXRoleDescripton for DL is "list"; should be "description list"
1561         https://bugs.webkit.org/show_bug.cgi?id=111665
1562
1563         Reviewed by Chris Fleizach.
1564
1565         Defining the role and description strings.
1566
1567         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1568
1569 2013-04-02  Roger Fong  <roger_fong@apple.com>
1570
1571         Unreviewed. Disable running tests on Win EWS queue.
1572
1573         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1574         (WinEWS):
1575
1576 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1577
1578         Disable running tests on the MAC WK2 EWS queue.
1579         
1580         Unreviewed.
1581         
1582         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1583         (MacWK2EWS):
1584
1585 2013-04-02  Julie Parent  <jparent@chromium.org>
1586
1587         Dashboard refactor: Move dashboard specific history related features to History.
1588         https://bugs.webkit.org/show_bug.cgi?id=113717
1589
1590         Reviewed by Ojan Vafai.
1591         
1592         Each dashboard now creates its own History object, with a custom
1593         configuration. This changes from just overriding global functions
1594         to passing in callbacks for generatePage, handleValidHashParameter,
1595         and handleQueryParameterChange. Same with passing in defaultStateValues
1596         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1597         variables.
1598         
1599         All functions related to these features are now (mostly) private
1600         function on History. 
1601         
1602         Loader no longer needs a loadingComplete callback, since it can just
1603         initialize the history object itself.
1604
1605         * TestResultServer/static-dashboards/aggregate_results.js:
1606         (handleValidHashParameter):
1607         * TestResultServer/static-dashboards/dashboard_base.js:
1608         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1609         (generatePage):
1610         (.switch.return):
1611         (handleQueryParameterChange):
1612         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1613         (resetGlobals):
1614         * TestResultServer/static-dashboards/history.js:
1615         (.):
1616         * TestResultServer/static-dashboards/loader.js:
1617         (.):
1618         * TestResultServer/static-dashboards/loader_unittests.js:
1619         * TestResultServer/static-dashboards/timeline_explorer.js:
1620         (generatePage):
1621         (initCurrentBuilderTestResults):
1622         * TestResultServer/static-dashboards/treemap.js:
1623         (generatePage):
1624         (.switch.return):
1625         (handleQueryParameterChange):
1626
1627 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1628
1629         Unreviewed, rolling out r147401.
1630         http://trac.webkit.org/changeset/147401
1631         https://bugs.webkit.org/show_bug.cgi?id=113767
1632
1633         The patch makes it extremely hard to set up the dependencies
1634         properly on the GTK builders (Requested by zdobersek on
1635         #webkit).
1636
1637         * gtk/jhbuild.modules:
1638
1639 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1640
1641         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1642         https://bugs.webkit.org/show_bug.cgi?id=113382
1643
1644         Reviewed by Gyuyoung Kim.
1645
1646         Do not show the empty tooltip box if the text is null.
1647
1648         * MiniBrowser/efl/main.c:
1649         (popup_menu_populate):
1650
1651 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1652
1653         [GTK] Bump required versions of some dependencies
1654         https://bugs.webkit.org/show_bug.cgi?id=113282
1655
1656         Reviewed by Martin Robinson.
1657
1658         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1659
1660 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1661
1662         Unreviewed, rolling out r147319.
1663         http://trac.webkit.org/changeset/147319
1664         https://bugs.webkit.org/show_bug.cgi?id=113707
1665
1666         The unit test is still failing on the buildbot (Requested by
1667         zdobersek on #webkit).
1668
1669         * Scripts/run-gtk-tests:
1670         (TestRunner):
1671
1672 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1673
1674         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1675         https://bugs.webkit.org/show_bug.cgi?id=104779
1676
1677         Reviewed by Carlos Garcia Campos.
1678
1679         * Scripts/run-gtk-tests:
1680         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1681         passing in current trunk.
1682
1683 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1684
1685         Unreviewed, rolling out r147289.
1686         http://trac.webkit.org/changeset/147289
1687         https://bugs.webkit.org/show_bug.cgi?id=113678
1688
1689         broke Win7 (dbg) build (Requested by shinyak|gardener on
1690         #webkit).
1691
1692         * DumpRenderTree/DumpRenderTree.gypi:
1693         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1694         (WebTestRunner):
1695         (WebUserMediaClientMock):
1696         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1697         (WebTestRunner::WebUserMediaClientMock::taskList):
1698         * Scripts/webkitpy/style/checkers/cpp.py:
1699         (check_function_definition):
1700
1701 2013-03-31  Adam Barth  <abarth@webkit.org>
1702
1703         configure-svn-config.sh fails
1704         https://codereview.chromium.org/13392007/
1705
1706         Reviewed by Eric Seidel.
1707
1708         This script was trying to use "svn checkout" to dowload a file from
1709         svn.webkit.org, but "svn checkout" only works with directories.
1710         Instead, we should use "svn export".
1711
1712         * EWSTools/configure-svn-config.sh:
1713
1714 2013-03-31  Wei Jia  <wjia@chromium.org>
1715
1716         Allow WebUserMediaClientMock to be used by client
1717         https://bugs.webkit.org/show_bug.cgi?id=113633
1718
1719         Reviewed by Adam Barth.
1720
1721         Export WebUserMediaClientMock.
1722         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1723
1724         * DumpRenderTree/DumpRenderTree.gypi:
1725         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1726         (WebUserMediaClientMock):
1727         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1728         * Scripts/webkitpy/style/checkers/cpp.py:
1729         (check_function_definition):
1730
1731 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1732
1733         Expose FeatureObserver data to WebKit clients
1734         https://bugs.webkit.org/show_bug.cgi?id=113613
1735
1736         Reviewed by Sam Weinig.
1737
1738         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1739         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1740
1741 2013-03-29  Greg Hughes  <ghughes@apple.com>
1742
1743         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1744         https://bugs.webkit.org/show_bug.cgi?id=112276
1745
1746         Reviewed by Chris Fleizach.
1747
1748         Added support to test accessibility search predicates with multiple keys.  
1749
1750         * DumpRenderTree/AccessibilityUIElement.cpp:
1751         (uiElementForSearchPredicateCallback):
1752         * DumpRenderTree/AccessibilityUIElement.h:
1753         (AccessibilityUIElement):
1754         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1755         (AccessibilityUIElement::uiElementForSearchPredicate):
1756         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1757         (AccessibilityUIElement::uiElementForSearchPredicate):
1758         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1759         (AccessibilityUIElement::uiElementForSearchPredicate):
1760         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1761         (AccessibilityUIElement::uiElementForSearchPredicate):
1762         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1763         (AccessibilityUIElement::uiElementForSearchPredicate):
1764         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1765         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1766         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1767         (AccessibilityUIElement):
1768         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1769         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1770         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1771         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1772         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1773
1774 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1775
1776         Fix a typo in r147147 to fix Mac EWS.
1777
1778         * Scripts/webkitpy/tool/commands/queues.py:
1779         (PatchProcessingQueue._new_port_name_from_old):
1780
1781 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1782
1783         [EFL] Build break with latest EFL libraries after r146265
1784         https://bugs.webkit.org/show_bug.cgi?id=113558
1785
1786         Unreviewed build fix.
1787
1788         * TestWebKitAPI/PlatformWebView.h:
1789         * WebKitTestRunner/PlatformWebView.h:
1790
1791 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1792
1793         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1794
1795         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1796         in libgcrypt build.
1797
1798 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1799
1800         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1801
1802         Unreviewed.
1803
1804         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1805         (MacEWS):
1806
1807 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1808
1809         Use the right OS name on Mac EWS instead of mac-future.
1810
1811         Rubber-stamped by Dirk Pranke.
1812
1813         * Scripts/webkitpy/tool/commands/queues.py:
1814         (PatchProcessingQueue._new_port_name_from_old):
1815         (PatchProcessingQueue.begin_work_queue):
1816         (PatchProcessingQueue._upload_results_archive_for_patch):
1817
1818 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1819
1820         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1821         https://bugs.webkit.org/show_bug.cgi?id=112546
1822
1823         Reviewed by Martin Robinson.
1824
1825         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1826         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1827
1828 2013-03-28  Ming Xie  <mxie@blackberry.com>
1829
1830         [BlackBerry] Committer Email Updates
1831         https://bugs.webkit.org/show_bug.cgi?id=113435
1832
1833         Reviewed by Rob Buis.
1834
1835         Add the @blackberry.com email address for all our BlackBerry
1836         WebKit committers. This is the first step for our email address
1837         migration.
1838
1839         * Scripts/webkitpy/common/config/committers.py:
1840
1841 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1842
1843         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1844         https://bugs.webkit.org/show_bug.cgi?id=113508
1845
1846         Reviewed by Martin Robinson.
1847
1848         Prevent the GStreamer plugin scanner to load system-wide
1849         plugins. Only the ones built in JHBuild should be loaded and used
1850         at runtime.
1851
1852         * efl/jhbuildrc:
1853         * gtk/jhbuildrc:
1854
1855 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1856
1857         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1858         https://bugs.webkit.org/show_bug.cgi?id=113386
1859
1860         Reviewed by Carlos Garcia Campos.
1861
1862         * Scripts/webkitdirs.pm:
1863         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1864         version to 3.0. Reflect this change so the builtDylibPathForName
1865         function doesn't fail to report the library as found.
1866
1867 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1868
1869         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1870         https://bugs.webkit.org/show_bug.cgi?id=113484
1871
1872         Unreviewed build fix.
1873
1874         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1875
1876         * TestWebKitAPI/CMakeLists.txt:
1877         * WebKitTestRunner/CMakeLists.txt:
1878
1879 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1880
1881         Revision for the internal jhbuild is too old
1882         https://bugs.webkit.org/show_bug.cgi?id=113324
1883
1884         Reviewed by Martin Robinson.
1885
1886         Update the minimum required version to a point where jhbuild won't
1887         fail installing packages when trying to remove a symlink to a directory.
1888
1889         * jhbuild/jhbuild-wrapper: Updated revision.
1890
1891 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1892
1893         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1894         https://bugs.webkit.org/show_bug.cgi?id=113203
1895
1896         Reviewed by Philippe Normand.
1897
1898         We build our libsoup without GNOME support. gst-plugins-good does separate
1899         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1900         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1901         build failures as the headers of those diverge. We do not use souphttpsrc, so
1902         disable it when building gst-plugins-good.
1903
1904         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1905
1906 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1907
1908         Build fix after r146852. Please another reference to the Lion leaks builder.
1909
1910         * BuildSlaveSupport/build.webkit.org-config/config.json:
1911
1912 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1913
1914         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1915         https://bugs.webkit.org/show_bug.cgi?id=113421
1916
1917         Reviewed by Dirk Pranke.
1918
1919         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1920         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1921         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1922         in the GTK-specific TestExpectations files.
1923
1924         To avoid this only enable the warnings only when not using WKTR.
1925
1926         * Scripts/webkitpy/layout_tests/port/gtk.py:
1927         (GtkPort.warn_if_bug_missing_in_test_expectations):
1928
1929 2013-03-27  Antti Koivisto  <antti@apple.com>
1930
1931         Fix Zalan's email.
1932
1933         * Scripts/webkitpy/common/config/committers.py:
1934
1935 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1936
1937         master.cfg cleanup
1938         https://bugs.webkit.org/show_bug.cgi?id=113195
1939
1940         Reviewed by Ryosuke Niwa.
1941
1942         * BuildSlaveSupport/build.webkit.org-config/config.json:
1943         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1944
1945 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1946
1947         master.cfg fine-tuning for Qt Mountain Lion Release bot
1948         https://bugs.webkit.org/show_bug.cgi?id=113191
1949
1950         Reviewed by Ryosuke Niwa.
1951
1952         * BuildSlaveSupport/build.webkit.org-config/config.json:
1953           - Rename the slave due to its location change.
1954           - Update the platform of the slave.
1955         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1956         (RunQtAPITests): Enable running WK2 API tests on Qt.
1957         (RunQtAPITests.start):
1958         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1959         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1960
1961 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1962
1963         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1964         https://bugs.webkit.org/show_bug.cgi?id=113403
1965
1966         Reviewed by Kenneth Rohde Christiansen.
1967
1968         As of Evas 1.7.5, when Wayland is detected on the system, support for
1969         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1970         The code, however, seems to depend on a few other flags which must be
1971         explicitly enabled.
1972
1973         If those additional GL-related options are passed, we end up
1974         having issues on the WebKit side, so disable Wayland support for
1975         now.
1976
1977         * efl/jhbuild.modules:
1978
1979 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1980
1981         Unreviewed, rolling out r146864.
1982         http://trac.webkit.org/changeset/146864
1983         https://bugs.webkit.org/show_bug.cgi?id=113391
1984
1985         causes crashes on Wk2 EFL release bot (Requested by drott on
1986         #webkit).
1987
1988         * Scripts/webkitperl/FeatureList.pm:
1989
1990 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1991
1992         [jhbuild] Correctly specify an alternate number of make jobs.
1993         https://bugs.webkit.org/show_bug.cgi?id=113396
1994
1995         Reviewed by Philippe Normand.
1996
1997         So far, we were using the `MAKEFLAGS' environment variable to pass the
1998         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1999         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
2000
2001         We now behave more closely to the rest of the WebKit tools by first
2002         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
2003         not set, just letting jhbuild itself figure out how many jobs to use.
2004
2005         * efl/jhbuildrc:
2006         * gtk/jhbuildrc:
2007
2008 2013-03-27  Zeno Albisser  <zeno@webkit.org>
2009
2010         [Qt] Remove Qt specific WorkQueueItem definitions.
2011         https://bugs.webkit.org/show_bug.cgi?id=112891
2012
2013         This patch is preparation work for removing
2014         WorkQueue related code from TestRunnerQt and
2015         replacing it with generic TestRunner code.
2016
2017         Reviewed by Benjamin Poulain.
2018
2019         * DumpRenderTree/qt/TestRunnerQt.cpp:
2020         (TestRunnerQt::queueBackNavigation):
2021         (TestRunnerQt::queueForwardNavigation):
2022         (TestRunnerQt::queueLoadHTMLString):
2023         (TestRunnerQt::queueReload):
2024         (TestRunnerQt::queueLoadingScript):
2025         (TestRunnerQt::queueNonLoadingScript):
2026         (TestRunner::queueLoad):
2027         * DumpRenderTree/qt/TestRunnerQt.h:
2028         (TestRunnerQt):
2029         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2030         (LoadItem::invoke):
2031         (LoadHTMLStringItem::invoke):
2032         (LoadAlternateHTMLStringItem::invoke):
2033         (ReloadItem::invoke):
2034         (ScriptItem::invoke):
2035         (BackForwardItem::invoke):
2036         * DumpRenderTree/qt/WorkQueueItemQt.h:
2037         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2038         (LoadAlternateHTMLStringItem):
2039
2040 2013-03-26  Julie Parent  <jparent@chromium.org>
2041
2042         Flakiness dashboard: simplify logic around which tests to show.
2043         https://bugs.webkit.org/show_bug.cgi?id=113250
2044
2045         Reviewed by Ojan Vafai.
2046         
2047         The different filters for showing results are only used for layout
2048         tests, otherwise, we show everything.
2049         
2050         Change the defaults to false (what layout tests used), and only
2051         look at the values when viewing layout tests.
2052
2053         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2054         (htmlForTestsWithExpectationsButNoFailures):
2055         (shouldHideTest):
2056
2057 2013-03-26  Isaac Levy  <ilevy@google.com>
2058
2059         Update bots on test-results.appspot
2060         https://bugs.webkit.org/show_bug.cgi?id=113333
2061
2062         Reviewed by Ojan Vafai.
2063
2064         * TestResultServer/static-dashboards/builders.jsonp:
2065
2066 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2067
2068         Unreviewed GTK gardening.
2069
2070         * Scripts/run-gtk-tests:
2071         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
2072
2073 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2074
2075         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
2076         https://bugs.webkit.org/show_bug.cgi?id=113287
2077
2078         Reviewed by Jocelyn Turcotte.
2079
2080         * Scripts/run-qtwebkit-tests:
2081         (Options.__init__):
2082
2083 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2084
2085         [EFL] Enable IndexedDB by default
2086         https://bugs.webkit.org/show_bug.cgi?id=107248
2087
2088         Reviewed by Laszlo Gombos.
2089
2090         * Scripts/webkitperl/FeatureList.pm:
2091         Enable IndexedDB by default on EFL.
2092
2093 2013-03-26  Alan Cutter  <alancutter@chromium.org>
2094
2095         Sheriffbot should explain rollout failures in a human readable form.
2096         https://bugs.webkit.org/show_bug.cgi?id=107092
2097
2098         Reviewed by Ryosuke Niwa.
2099
2100         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
2101
2102         * Scripts/webkitpy/tool/bot/irc_command.py:
2103         (Rollout._check_diff_failure):
2104         (Rollout.execute):
2105         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2106         (IRCCommandTest.test_rollout):
2107
2108 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2109
2110         Unreviewed GTK gardening.
2111
2112         * Scripts/run-gtk-tests:
2113         (TestRunner): Skipping a failing unit test after r146518.
2114
2115 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2116
2117         Remove Lion leaks builder
2118         https://bugs.webkit.org/show_bug.cgi?id=113252
2119
2120         Reviewed by Andreas Kling.
2121
2122         Removed.
2123
2124         * BuildSlaveSupport/build.webkit.org-config/config.json:
2125
2126 2013-03-25  Kent Tamura  <tkent@chromium.org>
2127
2128         Rename ENABLE_INPUT_TYPE_DATETIME
2129         https://bugs.webkit.org/show_bug.cgi?id=113254
2130
2131         Reviewed by Kentaro Hara.
2132
2133         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2134         Actually I'd like to remove the code, but we shouldn't remove it yet
2135         because we shipped products with it on some platforms.
2136
2137         * Scripts/webkitperl/FeatureList.pm:
2138         * qmake/mkspecs/features/features.pri:
2139
2140 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2141
2142         Remove one more line that was intended to be removed in r146657.
2143
2144         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2145         (summarize_results):
2146
2147 2013-03-25  Roger Fong  <roger_fong@apple.com>
2148
2149         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2150         Re-enable WinEWS tests.
2151
2152         * Scripts/webkitpy/common/config/ports.py:
2153         (WinPort.run_bindings_tests_command):
2154         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2155         (WinEWS):
2156
2157 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2158
2159         Unreviewed, rolling out r146793.
2160         http://trac.webkit.org/changeset/146793
2161         https://bugs.webkit.org/show_bug.cgi?id=113248
2162
2163         Fix did not work (Requested by rfong on #webkit).
2164
2165         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2166         (WinEWS):
2167
2168 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2169
2170         REGRESSION(r146657): Test failures reported incorrectly
2171         https://bugs.webkit.org/show_bug.cgi?id=113223
2172
2173         Reviewed by Dirk Pranke.
2174
2175         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2176
2177         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2178         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2179
2180         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2181         (Manager.run):
2182
2183         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2184         (RunDetails.__init__):
2185         (summarize_results): Remove the line I intended to remove in r146657.
2186
2187         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2188         (logging_run): Return details instead of the exit code.
2189         (run_and_capture): Ditto.
2190
2191         (RunTest.test_full_results_html):
2192         (RunTest.test_hung_thread):
2193         (RunTest.test_no_tests_found):
2194         (RunTest.test_no_tests_found_2):
2195         (RunTest.test_repeat_each_iterations_num_tests):
2196         (RunTest.test_run_singly_actually_runs_tests):
2197         (RunTest.test_test_list):
2198         (RunTest.test_missing_and_unexpected_results):
2199         (RunTest.test_pixel_test_directories):
2200         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2201         (RunTest.test_crash_with_stderr):
2202         (RunTest.test_no_image_failure_with_image_diff):
2203         (RunTest.test_crash_log):
2204         (RunTest.test_exit_after_n_failures_upload):
2205         (RunTest.test_results_directory_absolute):
2206         (RunTest.test_results_directory_relative):
2207         (RunTest.test_retrying_and_flaky_tests):
2208         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2209         (RunTest.test_retrying_uses_retries_directory):
2210         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2211         (RunTest.test_output_diffs):
2212         (EndToEndTest.test_reftest_with_two_notrefs):
2213         (RebaselineTest.test_reset_results):
2214         (RebaselineTest.test_missing_results):
2215         (RebaselineTest.test_new_baseline):
2216
2217         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2218         (BuildBotPrinter.print_results):
2219         (BuildBotPrinter.print_unexpected_results):
2220         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2221         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2222
2223 2013-03-25  Julie Parent  <jparent@chromium.org>
2224
2225         Dashboard refactor: Move cross dashboard history related code into history.js.
2226         https://bugs.webkit.org/show_bug.cgi?id=113104
2227
2228         Reviewed by Ojan Vafai.
2229
2230         All functions relating to cross dashboard behavior move from being
2231         globals to methods on the history.History object. Names stay the same,
2232         except many are made private, ones that should have been constants now
2233         are, and the long standing TODO to change "currentState" to 
2234         dashboardSpecificState is done.
2235         
2236         We now create a global history object in dashboard_base, as an 
2237         intermediate measure.  Once the dashboard specific code is
2238         added to history, each DB will need to create its own, and this
2239         global will be eliminated.
2240         
2241         * TestResultServer/static-dashboards/aggregate_results.js:
2242         (handleValidHashParameter):
2243         (htmlForBuilder):
2244         (rawValuesHTML):
2245         * TestResultServer/static-dashboards/dashboard_base.js:
2246         (parseDashboardSpecificParameters):
2247         (defaultValue):
2248         (currentBuilderGroupCategory):
2249         (currentBuilderGroupName):
2250         (handleLocationChange):
2251         (expectationsMap):
2252         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2253         (generatePage):
2254         (.switch.return):
2255         (platformAndBuildType):
2256         (individualTests):
2257         (substringList):
2258         (processMissingAndExtraExpectations):
2259         (pathToFailureLog):
2260         (showPopupForBuild):
2261         (htmlForTestsWithExpectationsButNoFailures):
2262         (shouldHideTest):
2263         (isCrossBuilderView):
2264         (tableHeaders):
2265         (htmlForSingleTestRow):
2266         (htmlForTableColumnHeader):
2267         (generatePageForExpectationsUpdate):
2268         (handleUpdate):
2269         (nextUpdate):
2270         (setUpdateIndex):
2271         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2272         (.appendExpectationsItem):
2273         (loadExpectations):
2274         (.dummyNode.onload):
2275         (loadExpectationsLayoutTests):
2276         (appendExpectations):
2277         (htmlForNavBar):
2278         (checkBoxToToggleState):
2279         (linkHTMLToToggleState):
2280         (generatePageForBuilder):
2281         (isInvalidKeyForCrossBuilderView):
2282         (handleQueryParameterChange):
2283         (showLegend):
2284         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2285         (resetGlobals):
2286         (test):
2287         * TestResultServer/static-dashboards/history.js:
2288         (.):
2289         * TestResultServer/static-dashboards/history_unittests.js:
2290         * TestResultServer/static-dashboards/loader.js:
2291         (.):
2292         * TestResultServer/static-dashboards/loader_unittests.js:
2293         * TestResultServer/static-dashboards/timeline_explorer.js:
2294         (generatePage):
2295         (initCurrentBuilderTestResults):
2296         (selectBuild):
2297         (showResultsDelta):
2298         * TestResultServer/static-dashboards/treemap.js:
2299         (generatePage):
2300         (.switch.return):
2301         (handleFocus):
2302         * TestResultServer/static-dashboards/ui.js:
2303
2304 2013-03-25  Roger Fong  <roger_fong@apple.com>
2305
2306         Unreviewed. Enable WinEWS tests again.
2307
2308         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2309         (WinEWS):
2310
2311 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2312
2313         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2314         https://bugs.webkit.org/show_bug.cgi?id=112166
2315
2316         HarfBuzz 0.9.14 merged my patch for icu detection without
2317         pkg-config files, as needed by for example Ubuntu 12.04.
2318         This obsoletes our local workaround. Removed it for GTK and EFL.
2319
2320         Reviewed by Martin Robinson.
2321
2322         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2323         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2324         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2325         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2326
2327 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2328
2329         Unreviewed.  Move self from contributor to committer list.
2330
2331         * Scripts/webkitpy/common/config/committers.py:
2332
2333 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2334
2335         EWS should use a human readable port name when uploading layout test archives
2336         https://bugs.webkit.org/show_bug.cgi?id=113099
2337
2338         Reviewed by Dirk Pranke.
2339
2340         Use new port's object's name() method to report human readable port names.
2341         This will also help us resolving the bug to apply layout test results posted by EWS.
2342
2343         * Scripts/webkitpy/tool/bot/botinfo.py:
2344         (BotInfo.__init__): Take port's name.
2345         (BotInfo.summary_text):
2346
2347         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2348         (BotInfoTest.test_summary_text):
2349
2350         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2351         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2352
2353         * Scripts/webkitpy/tool/commands/queues.py:
2354         (PatchProcessingQueue.__init__): Initialize self._port.
2355         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2356         and use that for the attachment filename and the comment posted.
2357
2358         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2359         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2360         "mac-snowleopard" as expected for TestPort.
2361
2362 2013-03-22  Roger Fong  <roger_fong@apple.com>
2363
2364         Unreviewed. Turn off EWS test on Win again.
2365         The battle continues.
2366
2367         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2368         (WinEWS):
2369
2370 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2371
2372         NRWT: Enable pixel tests when retrying tests
2373         https://bugs.webkit.org/show_bug.cgi?id=112898
2374
2375         Reviewed by Dirk Pranke.
2376
2377         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2378         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2379         if we've forced pixel tests in the retry.
2380         (Manager._run_tests):
2381         (Manager._clean_up_run): Fixed the capitalizations.
2382         (Manager._force_pixel_tests_if_needed): Added.
2383
2384         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2385         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2386         'image_diff_percent' if it doesn't already exist.
2387
2388         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2389         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2390         treat this as a regular regression instead of a flakiness.
2391
2392         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2393         run had image diffs.
2394
2395         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2396         (summarized_results):
2397
2398         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2399         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2400         Also removed some dead code.
2401
2402         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2403         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2404         is set and pixel_tests_enabled is set to false.
2405         (EndToEndTest.test_reftest_with_two_notrefs):
2406
2407 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2408
2409         Make it possible to run layout tests on Retina MBP
2410         https://bugs.webkit.org/show_bug.cgi?id=93673
2411
2412         Reviewed by Ryosuke Niwa.
2413
2414         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2415         windows on 2x machines still run at 1x.
2416
2417         * DumpRenderTree/mac/DumpRenderTree.mm:
2418         (createWebViewAndOffscreenWindow):
2419         Reset the window resolution to 1x on creation.
2420         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2421         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2422         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2423         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2424         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2425         (WTR::PlatformWebView::PlatformWebView):
2426         Add NSWindow details, reset the window resolution to 1x on creation.
2427
2428 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2429
2430         Leak bots shouldn't build
2431         https://bugs.webkit.org/show_bug.cgi?id=112774
2432
2433         Reviewed by Simon Fraser.
2434
2435         Since leak bots use regular debug builds, there is no need to build on these bots.
2436         Simply downloading builds will dramatically improve the cycle time of these bots.
2437
2438         * BuildSlaveSupport/build.webkit.org-config/config.json:
2439         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2440         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2441         TestFactory instead of BuildAndTestFactory.
2442
2443 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2444
2445         [Qt] Fix the TestWebKitAPI build
2446         https://bugs.webkit.org/show_bug.cgi?id=113044
2447
2448         Reviewed by Tor Arne Vestbø.
2449
2450         The generate-forwarding-headers script would only be run
2451         after the targets in InjectedBundle.pri since the second
2452         addStrictSubdirOrderBetween call in
2453         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2454         the derived_sources -> injected_bundle order in SUBDIRS.
2455
2456         Fix it by only moving the dependent target at the end of
2457         SUBDIRS, don't touch its dependency.
2458
2459         * qmake/mkspecs/features/functions.prf:
2460
2461 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2462
2463         [EFL][WK2] View is not focused when fullscreen mode toggled
2464         https://bugs.webkit.org/show_bug.cgi?id=113009
2465
2466         Reviewed by Laszlo Gombos.
2467
2468         Set focus on view when fullscreen mode enabled/disabled
2469         by FullScreen API.
2470
2471         * MiniBrowser/efl/main.c:
2472         (on_fullscreen_accept):
2473         (on_fullscreen_deny):
2474
2475 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2476
2477         nrwt is no longer saving retry results in the retries/ subdirectory
2478         https://bugs.webkit.org/show_bug.cgi?id=112995
2479
2480         Reviewed by Ojan Vafai.
2481
2482         I think this has been broken a long time, unfortunately. This
2483         patch should fix that.
2484
2485         In order to do so, I had to pass the directory to use from
2486         the Worker object through the SingleTestWriter to the
2487         TestResultWriter. While I was plumbing that through, I rationalized
2488         the order of the parameter arguments a bit ...
2489
2490         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2491         (Worker._run_single_test):
2492         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2493         (run_single_test):
2494         (SingleTestRunner.__init__):
2495         (SingleTestRunner._run_compare_test):
2496         (SingleTestRunner._run_rebaseline):
2497         (SingleTestRunner._run_reftest):
2498         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2499         (write_test_result):
2500         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2501         (TestResultWriterTest.test_reftest_diff_image):
2502         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2503         (RunTest.test_retrying_uses_retries_directory):
2504
2505 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2506
2507         JSC profiler should have an at-a-glance report of the success of DFG optimization
2508         https://bugs.webkit.org/show_bug.cgi?id=112988
2509
2510         Reviewed by Geoffrey Garen.
2511
2512         * Scripts/display-profiler-output:
2513
2514 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2515
2516         [chromium] Linux ASAN WebKit canary is running out of memory
2517         https://bugs.webkit.org/show_bug.cgi?id=112978
2518
2519         Reviewed by Tony Chang.
2520
2521         Running the AddressSanitizer on a crash takes a lot of
2522         memory, so we should serialize access to it to avoid running
2523         out of memory on a machine.
2524
2525         * Scripts/webkitpy/layout_tests/port/chromium.py:
2526         (ChromiumPort._get_crash_log):
2527         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2528         (HttpLock.__init__):
2529         (HttpLock.wait_for_httpd_lock):
2530
2531 2013-03-21  Min Qin  <qinmin@chromium.org>
2532
2533         Cleanup android media layout test code
2534         https://bugs.webkit.org/show_bug.cgi?id=112944
2535
2536         Reviewed by Adam Barth.
2537
2538         Chromium change: https://codereview.chromium.org/12892010/
2539         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2540         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2541         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2542         Instead, we should switch to use content shell for layout tests.
2543
2544         * DumpRenderTree/chromium/TestShell.cpp:
2545         (TestShell::resetTestController):
2546
2547 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2548
2549         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2550         https://bugs.webkit.org/show_bug.cgi?id=112953
2551
2552         Reviewed by Tony Chang.
2553
2554         When I created the DumpRenderTree_resources target in r144863 I
2555         forgot to declare the needed dependencies on the other resource
2556         targets. Due to a quirk of ordering, this appears to have been fine
2557         w/ ninja but not w/ Xcode (which is still being used on the chromium
2558         mac valgrind bots). Declaring the dependencies fixes the build
2559         failures.
2560
2561         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2562
2563 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2564
2565         [WinCairo] Correct assert in Empty BitmapImage Test.
2566         https://bugs.webkit.org/show_bug.cgi?id=112934
2567
2568         Reviewed by Tim Horton.
2569
2570         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2571         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2572         to avoid ref counting assertion when leaving test scope.
2573
2574 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2575
2576         [GTK] generate-feature-defines-files is incompatible with Python3
2577         https://bugs.webkit.org/show_bug.cgi?id=112956
2578
2579         Reviewed by Martin Robinson.
2580
2581         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2582         method on the dictionary objects when iterating through said dictionaries.
2583
2584         * gtk/generate-feature-defines-files:
2585         (write_feature_defines_header):
2586         (write_flattened_feature_defines_file):
2587
2588 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2589
2590         kill-old-processes spits out error messages on Mac
2591         https://bugs.webkit.org/show_bug.cgi?id=112878
2592
2593         Reviewed by Jessie Berlin.
2594
2595         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2596         included in the list of options grep --help shows.
2597
2598         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2599
2600         * BuildSlaveSupport/kill-old-processes:
2601         (main):
2602
2603 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2604
2605         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2606         https://bugs.webkit.org/show_bug.cgi?id=112597
2607
2608         Reviewed by Xan Lopez.
2609
2610         These were introduced for the Chromium port in r105295. We need
2611         dummy implementations in order to compile the BlackBerry port.
2612
2613         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2614         (AccessibilityUIElement::scrollToMakeVisible):
2615         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2616         (AccessibilityUIElement::scrollToGlobalPoint):
2617
2618 2013-03-21  Roger Fong  <roger_fong@apple.com>
2619
2620         Re-enable WinEWS tests following r146376.
2621
2622         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2623         (WinEWS):
2624
2625 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2626
2627         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2628
2629         * Scripts/webkitpy/common/config/committers.py:
2630
2631 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2632
2633         [GTK] Missing atk in install-dependencies script
2634         https://bugs.webkit.org/show_bug.cgi?id=112272
2635
2636         Reviewed by Gustavo Noronha Silva.
2637
2638         * gtk/install-dependencies: Add missing atk dependency.
2639
2640 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2641
2642         [GTK] Missing backslash in install-dependencies script
2643         https://bugs.webkit.org/show_bug.cgi?id=112907
2644
2645         Reviewed by Philippe Normand.
2646
2647         * gtk/install-dependencies: Add missing backslash to dependencies
2648         list.
2649
2650 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2651
2652         EWS bots have stopped uploading results to bugzilla
2653         https://bugs.webkit.org/show_bug.cgi?id=101091
2654
2655         Reviewed by Adam Barth.
2656
2657         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2658         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2659         this relative file path resoled to a file inside a non-existent directory for "zip".
2660
2661         Fixed the bug by resolving both test results directory and zip archive paths in
2662         LayoutTestResultsReader.archive.
2663
2664         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2665         in the future.
2666
2667         * Scripts/webkitpy/common/system/filesystem_mock.py:
2668         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2669
2670         * Scripts/webkitpy/common/system/workspace.py:
2671         (Workspace.create_zip): Log the source path when "zip" failed.
2672
2673         * Scripts/webkitpy/common/system/workspace_mock.py:
2674         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2675
2676         * Scripts/webkitpy/common/system/workspace_unittest.py:
2677         (WorkspaceTest.test_create_zip_exception): Test that.
2678
2679         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2680         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2681         This is the actual bug fix.
2682
2683         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2684         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2685
2686 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2687
2688         [chromium] move WebThemeEngine implementations to TestRunner library
2689         https://bugs.webkit.org/show_bug.cgi?id=112751
2690
2691         Reviewed by Adam Barth.
2692
2693         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2694         * DumpRenderTree/DumpRenderTree.gypi:
2695         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2696         (WebKit):
2697         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2698         (WebTestRunner::TestInterfaces::themeEngine):
2699         (WebTestRunner):
2700         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2701         (WebKit):
2702         (TestInterfaces):
2703         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2704         (WebTestRunner::WebTestInterfaces::themeEngine):
2705         (WebTestRunner):
2706         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2707         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2708         (WebTestRunner):
2709         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2710         (WebTestRunner::WebTestThemeControlWin::box):
2711         (WebTestRunner::WebTestThemeControlWin::line):
2712         (WebTestRunner::WebTestThemeControlWin::triangle):
2713         (WebTestRunner::WebTestThemeControlWin::roundRect):
2714         (WebTestRunner::WebTestThemeControlWin::oval):
2715         (WebTestRunner::WebTestThemeControlWin::circle):
2716         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2717         (WebTestRunner::WebTestThemeControlWin::markState):
2718         (WebTestRunner::WebTestThemeControlWin::draw):
2719         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2720         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2721         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2722         (WebTestRunner):
2723         (WebTestThemeControlWin):
2724         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2725         (WebTestRunner):
2726         (WebTestThemeEngineMac):
2727         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2728         (+[FakeActiveWindow alwaysActiveWindow]):
2729         (+[FakeActiveWindow alwaysInactiveWindow]):
2730         (-[FakeActiveWindow initWithActiveControls:]):
2731         (-[FakeActiveWindow _hasActiveControls]):
2732         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2733         (WebTestRunner):
2734         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2735         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2736         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2737         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2738         (WebTestRunner):
2739         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2740         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2741         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2742         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2743         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2744         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2745         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2746         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2747         (WebTestRunner::WebTestThemeEngineWin::getSize):
2748         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2749         (WebTestRunner):
2750         (WebTestThemeEngineWin):
2751         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2752         * DumpRenderTree/chromium/TestShell.cpp:
2753         (TestShell::initialize):
2754         * DumpRenderTree/chromium/TestShell.h:
2755         (WebKit):
2756         * DumpRenderTree/chromium/TestShellMac.mm:
2757         (platformInit):
2758         * DumpRenderTree/chromium/TestShellWin.cpp:
2759         (platformInit):
2760         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2761
2762 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2763
2764         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2765
2766         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2767         New property sheet that does not link against CoreFoundation and
2768         CFNetwork.
2769         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2770         Use new TestWebKitAPICommonWinCairo property sheet.
2771         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2772         Ditto.
2773
2774 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2775
2776         [WinCairo] Unreviewed build fix for VS2010.
2777
2778         Had to add WinCairo-specific property sheets to deal with some
2779         library and path differences with the main Apple port.
2780
2781         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2782         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2783         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2784         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2785         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2786         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2787
2788 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2789
2790         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2791         https://bugs.webkit.org/show_bug.cgi?id=112849
2792
2793         Reviewed by Sam Weinig.
2794
2795         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2796         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2797         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2798
2799 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2800
2801         [WinCairo] Build WebKit Tools under VS2010
2802         https://bugs.webkit.org/show_bug.cgi?id=112821
2803
2804         Reviewed by Tim Horton.
2805
2806         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2807         Add WinCairo-specific build target.
2808         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2809         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2810         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2811         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2812         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2813         Add WinCairo-specific build target.
2814         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2815         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2816         Add WinCairo-specific build target.
2817         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2818         WinCairo-specific build target.
2819         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2820         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2821         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2822         specific build target.
2823         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2824         WinCairo-specific build target.
2825         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2826         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2827         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2828
2829 2013-03-20  Roger Fong  <roger_fong@apple.com>
2830
2831         API test gardening AppleWin port.
2832
2833         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2834
2835         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2836         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2837
2838 2013-03-20  Roger Fong  <roger_fong@apple.com>
2839
2840         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2841
2842         * EWSTools/start-queue-win.sh:
2843
2844 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2845
2846         Unreviewed, add myself to committers.py.
2847
2848 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2849
2850         Unreviewed. Adding another email for me.
2851
2852         * Scripts/webkitpy/common/config/committers.py:
2853
2854 2013-03-20  Justin Novosad  <junov@google.com>
2855
2856         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2857         https://bugs.webkit.org/show_bug.cgi?id=112605
2858
2859         Reviewed by James Robinson.
2860
2861         Deleting all the code that was used for propagating and supporting
2862         the Chromium setting for disabling deferred 2d canvas rendering.
2863
2864         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2865         (main):
2866         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2867         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2868         (WebTestRunner::WebPreferences::reset):
2869         (WebTestRunner::WebPreferences::applyTo):
2870         * DumpRenderTree/chromium/TestShell.cpp:
2871         (TestShell::TestShell):
2872         (TestShell::resetWebSettings):
2873         (TestShell::runFileTest):
2874         * DumpRenderTree/chromium/TestShell.h:
2875         (TestShell):
2876
2877 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2878
2879         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2880         https://bugs.webkit.org/show_bug.cgi?id=112699.
2881
2882         Reviewed by Adam Barth.
2883
2884         * Scripts/webkitpy/layout_tests/port/qt.py:
2885         (QtPort._search_paths):
2886         (QtPort._port_specific_expectations_files):
2887         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2888         (QtPortTest):
2889         (QtPortTest._assert_search_path):
2890         (QtPortTest._assert_expectations_files):
2891
2892 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2893
2894         [Qt] Enable kerning by default
2895         https://bugs.webkit.org/show_bug.cgi?id=112704
2896
2897         Reviewed by Jocelyn Turcotte.
2898
2899         Disable kerning by default, since some reference test expectations
2900         expect kerning to be default off.
2901
2902         * DumpRenderTree/qt/TestRunnerQt.cpp:
2903         (TestRunnerQt::reset):
2904         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2905         (WTR::activateFonts):
2906
2907 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2908
2909         [Qt] Remove empty function stubs from TestRunnerQt.
2910         https://bugs.webkit.org/show_bug.cgi?id=112799
2911
2912         We are reducing the code in TestRunnerQt step by step,
2913         in order to finally replace all of it with the generic
2914         TestRunner implementation.
2915         This patch removes several simple function stubs that
2916         currently do not implement any actual functionality.
2917
2918         Reviewed by Kenneth Rohde Christiansen.
2919
2920         * DumpRenderTree/qt/TestRunnerQt.cpp:
2921         * DumpRenderTree/qt/TestRunnerQt.h:
2922         (TestRunnerQt):
2923
2924 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2925
2926         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2927         https://bugs.webkit.org/show_bug.cgi?id=112687
2928
2929         Reviewed by Kenneth Rohde Christiansen.
2930
2931         Hide the SearchBar by default on window creation.
2932
2933         * MiniBrowser/efl/main.c:
2934         (window_create):
2935
2936 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2937
2938         Unreviewed, rolling out r146304.
2939         http://trac.webkit.org/changeset/146304
2940         https://bugs.webkit.org/show_bug.cgi?id=112788
2941
2942         to many expectations to update (Requested by antonm on
2943         #webkit).
2944
2945         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2946         * DumpRenderTree/DumpRenderTree.gypi:
2947         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2948         (WebKit):
2949         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2950         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2951         (TestInterfaces):
2952         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2953         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2954         * DumpRenderTree/chromium/TestShell.cpp:
2955         (TestShell::initialize):
2956         * DumpRenderTree/chromium/TestShell.h:
2957         (WebKit):
2958         * DumpRenderTree/chromium/TestShellMac.mm:
2959         (platformInit):
2960         * DumpRenderTree/chromium/TestShellWin.cpp:
2961         (platformInit):
2962         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2963         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2964         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2965         (WebThemeControlDRTWin::box):
2966         (WebThemeControlDRTWin::line):
2967         (WebThemeControlDRTWin::triangle):
2968         (WebThemeControlDRTWin::roundRect):
2969         (WebThemeControlDRTWin::oval):
2970         (WebThemeControlDRTWin::circle):
2971         (WebThemeControlDRTWin::nestedBoxes):
2972         (WebThemeControlDRTWin::markState):
2973         (WebThemeControlDRTWin::draw):
2974         (WebThemeControlDRTWin::drawTextField):
2975         (WebThemeControlDRTWin::drawProgressBar):
2976         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2977         (WebThemeControlDRTWin):
2978         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2979         (WebThemeEngineDRTMac):
2980         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2981         (+[FakeActiveWindow alwaysActiveWindow]):
2982         (+[FakeActiveWindow alwaysInactiveWindow]):
2983         (-[FakeActiveWindow initWithActiveControls:]):
2984         (-[FakeActiveWindow _hasActiveControls]):
2985         (WebThemeEngineDRTMac::paintScrollbarThumb):
2986         (stateToHIEnableState):
2987         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2988         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2989         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2990         (webRectToSkIRect):
2991         (drawControl):
2992         (drawTextField):
2993         (drawProgressBar):
2994         (WebThemeEngineDRTWin::paintButton):
2995         (WebThemeEngineDRTWin::paintMenuList):
2996         (WebThemeEngineDRTWin::paintScrollbarArrow):
2997         (WebThemeEngineDRTWin::paintScrollbarThumb):
2998         (WebThemeEngineDRTWin::paintScrollbarTrack):
2999         (WebThemeEngineDRTWin::paintSpinButton):
3000         (WebThemeEngineDRTWin::paintTextField):
3001         (WebThemeEngineDRTWin::paintTrackbar):
3002         (WebThemeEngineDRTWin::paintProgressBar):
3003         (WebThemeEngineDRTWin::getSize):
3004         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3005         (WebThemeEngineDRTWin):
3006         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3007
3008 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3009
3010         [Qt] Support -webkit-font-smoothing
3011         https://bugs.webkit.org/show_bug.cgi?id=106009
3012
3013         Reviewed by Jocelyn Turcotte.
3014
3015         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
3016
3017         * DumpRenderTree/qt/TestRunnerQt.cpp:
3018         (TestRunnerQt::reset):
3019
3020 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
3021
3022         [GTK] accessibility/aria-scrollbar-role.html is failing
3023         https://bugs.webkit.org/show_bug.cgi?id=98358
3024
3025         Reviewed by Martin Robinson.
3026
3027         Adds support for checking accessibility object's orientation.
3028         Orientation is checked by retrieving proper state of accessibility object.
3029
3030         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3031         (checkElementState):
3032         (AccessibilityUIElement::orientation):
3033         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3034         (WTR::AccessibilityUIElement::orientation):
3035
3036 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3037
3038         [chromium] move WebThemeEngine implementations to TestRunner library
3039         https://bugs.webkit.org/show_bug.cgi?id=112751
3040
3041         Reviewed by Adam Barth.
3042
3043         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3044         * DumpRenderTree/DumpRenderTree.gypi:
3045         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3046         (WebKit):
3047         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3048         (WebTestRunner::TestInterfaces::themeEngine):
3049         (WebTestRunner):
3050         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3051         (WebKit):
3052         (TestInterfaces):
3053         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3054         (WebTestRunner::WebTestInterfaces::themeEngine):
3055         (WebTestRunner):
3056         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3057         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3058         (WebTestRunner):
3059         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3060         (WebTestRunner::WebTestThemeControlWin::box):
3061         (WebTestRunner::WebTestThemeControlWin::line):
3062         (WebTestRunner::WebTestThemeControlWin::triangle):
3063         (WebTestRunner::WebTestThemeControlWin::roundRect):
3064         (WebTestRunner::WebTestThemeControlWin::oval):
3065         (WebTestRunner::WebTestThemeControlWin::circle):
3066         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3067         (WebTestRunner::WebTestThemeControlWin::markState):
3068         (WebTestRunner::WebTestThemeControlWin::draw):
3069         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3070         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3071         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3072         (WebTestRunner):
3073         (WebTestThemeControlWin):
3074         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3075         (WebTestRunner):
3076         (WebTestThemeEngineMac):
3077         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3078         (+[FakeActiveWindow alwaysActiveWindow]):
3079         (+[FakeActiveWindow alwaysInactiveWindow]):
3080         (-[FakeActiveWindow initWithActiveControls:]):
3081         (-[FakeActiveWindow _hasActiveControls]):
3082         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3083         (WebTestRunner):
3084         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3085         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3086         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3087         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3088         (WebTestRunner):
3089         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3090         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3091         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3092         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3093         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3094         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3095         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3096         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3097         (WebTestRunner::WebTestThemeEngineWin::getSize):
3098         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3099         (WebTestRunner):
3100         (WebTestThemeEngineWin):
3101         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3102         * DumpRenderTree/chromium/TestShell.cpp:
3103         (TestShell::initialize):
3104         * DumpRenderTree/chromium/TestShell.h:
3105         (WebKit):
3106         * DumpRenderTree/chromium/TestShellMac.mm:
3107         (platformInit):
3108         * DumpRenderTree/chromium/TestShellWin.cpp:
3109         (platformInit):
3110         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3111
3112 2013-03-19  Tony Chang  <tony@chromium.org>
3113
3114         Move testRunner.setTouchDragDropEnabled to internals.settings
3115         https://bugs.webkit.org/show_bug.cgi?id=112739
3116
3117         Reviewed by Adam Barth.
3118
3119         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3120         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
3121         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3122         (TestRunner): Remove unnecessary code.
3123         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3124         (WebTestRunner::WebPreferences::reset):
3125         (WebTestRunner::WebPreferences::applyTo): Always set to false.
3126
3127 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
3128
3129         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3130         https://bugs.webkit.org/show_bug.cgi?id=112754
3131
3132         Reviewed by Darin Fisher.
3133
3134         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3135         now that it's always defined.
3136
3137         * DumpRenderTree/chromium/WebViewHost.cpp:
3138         * DumpRenderTree/chromium/WebViewHost.h:
3139         (WebViewHost):
3140
3141 2013-03-19  Kenneth Russell  <kbr@google.com>
3142
3143         Unreviewed, rolling out r146290.
3144         http://trac.webkit.org/changeset/146290
3145         https://bugs.webkit.org/show_bug.cgi?id=112751
3146
3147         Broke Chromium Mac build.
3148
3149         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3150         * DumpRenderTree/DumpRenderTree.gypi:
3151         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3152         (WebKit):
3153         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3154         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3155         (TestInterfaces):
3156         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3157         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3158         * DumpRenderTree/chromium/TestShell.cpp:
3159         (TestShell::initialize):
3160         * DumpRenderTree/chromium/TestShell.h:
3161         (WebKit):
3162         * DumpRenderTree/chromium/TestShellMac.mm:
3163         (platformInit):
3164         * DumpRenderTree/chromium/TestShellWin.cpp:
3165         (platformInit):
3166         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3167         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3168         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3169         (WebThemeControlDRTWin::box):
3170         (WebThemeControlDRTWin::line):
3171         (WebThemeControlDRTWin::triangle):
3172         (WebThemeControlDRTWin::roundRect):
3173         (WebThemeControlDRTWin::oval):
3174         (WebThemeControlDRTWin::circle):
3175         (WebThemeControlDRTWin::nestedBoxes):
3176         (WebThemeControlDRTWin::markState):
3177         (WebThemeControlDRTWin::draw):
3178         (WebThemeControlDRTWin::drawTextField):
3179         (WebThemeControlDRTWin::drawProgressBar):
3180         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3181         (WebThemeControlDRTWin):
3182         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3183         (WebThemeEngineDRTMac):
3184         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3185         (+[FakeActiveWindow alwaysActiveWindow]):
3186         (+[FakeActiveWindow alwaysInactiveWindow]):
3187         (-[FakeActiveWindow initWithActiveControls:]):
3188         (-[FakeActiveWindow _hasActiveControls]):
3189         (WebThemeEngineDRTMac::paintScrollbarThumb):
3190         (stateToHIEnableState):
3191         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3192         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3193         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3194         (webRectToSkIRect):
3195         (drawControl):
3196         (drawTextField):
3197         (drawProgressBar):
3198         (WebThemeEngineDRTWin::paintButton):
3199         (WebThemeEngineDRTWin::paintMenuList):
3200         (WebThemeEngineDRTWin::paintScrollbarArrow):
3201         (WebThemeEngineDRTWin::paintScrollbarThumb):
3202         (WebThemeEngineDRTWin::paintScrollbarTrack):
3203         (WebThemeEngineDRTWin::paintSpinButton):
3204         (WebThemeEngineDRTWin::paintTextField):
3205         (WebThemeEngineDRTWin::paintTrackbar):
3206         (WebThemeEngineDRTWin::paintProgressBar):
3207         (WebThemeEngineDRTWin::getSize):
3208         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3209         (WebThemeEngineDRTWin):
3210         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3211
3212 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
3213
3214         [EFL] canvas-fallback-content.html is failing
3215         https://bugs.webkit.org/show_bug.cgi?id=111998
3216
3217         Reviewed by Chris Fleizach.
3218
3219         Adds support for getting platform name.
3220
3221         * DumpRenderTree/TestRunner.cpp:
3222         (TestRunner::staticValues):
3223         * DumpRenderTree/TestRunner.h:
3224         (TestRunner):
3225         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3226         (TestRunner::platformName):
3227
3228 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3229
3230         [chromium] move WebThemeEngine implementations to TestRunner library
3231         https://bugs.webkit.org/show_bug.cgi?id=112751
3232
3233         Reviewed by Adam Barth.
3234
3235         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3236         * DumpRenderTree/DumpRenderTree.gypi:
3237         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3238         (WebKit):
3239         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3240         (WebTestRunner::TestInterfaces::themeEngine):
3241         (WebTestRunner):
3242         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3243         (WebKit):
3244         (TestInterfaces):
3245         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3246         (WebTestRunner::WebTestInterfaces::themeEngine):
3247         (WebTestRunner):
3248         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3249         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3250         (WebTestRunner):
3251         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3252         (WebTestRunner::WebTestThemeControlWin::box):
3253         (WebTestRunner::WebTestThemeControlWin::line):
3254         (WebTestRunner::WebTestThemeControlWin::triangle):
3255         (WebTestRunner::WebTestThemeControlWin::roundRect):
3256         (WebTestRunner::WebTestThemeControlWin::oval):
3257         (WebTestRunner::WebTestThemeControlWin::circle):
3258         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3259         (WebTestRunner::WebTestThemeControlWin::markState):
3260         (WebTestRunner::WebTestThemeControlWin::draw):
3261         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3262         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3263         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3264         (WebTestRunner):
3265         (WebTestThemeControlWin):
3266         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3267         (WebTestRunner):
3268         (WebTestThemeEngineMac):
3269         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3270         (+[FakeActiveWindow alwaysActiveWindow]):
3271         (+[FakeActiveWindow alwaysInactiveWindow]):
3272         (-[FakeActiveWindow initWithActiveControls:]):
3273         (-[FakeActiveWindow _hasActiveControls]):
3274         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3275         (WebTestRunner):
3276         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3277         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3278         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3279         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3280         (WebTestRunner):
3281         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3282         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3283         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3284         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3285         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3286         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3287         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3288         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3289         (WebTestRunner::WebTestThemeEngineWin::getSize):
3290         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3291         (WebTestRunner):
3292         (WebTestThemeEngineWin):
3293         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3294         * DumpRenderTree/chromium/TestShell.cpp:
3295         (TestShell::initialize):
3296         * DumpRenderTree/chromium/TestShell.h:
3297         (WebKit):
3298         * DumpRenderTree/chromium/TestShellMac.mm:
3299         (platformInit):
3300         * DumpRenderTree/chromium/TestShellWin.cpp:
3301         (platformInit):
3302         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3303
3304 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3305
3306         [EFL][WK2] Separate WebView further from EwkView
3307         https://bugs.webkit.org/show_bug.cgi?id=111591
3308
3309         Reviewed by Caio Marcelo de Oliveira Filho.
3310
3311         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3312         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3313         since we can afford it having EWKViewGetWKView() private API to access WKView.
3314
3315         * TestWebKitAPI/PlatformWebView.h:
3316         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3317         (TestWebKitAPI::TEST):
3318         * TestWebKitAPI/efl/PlatformWebView.cpp:
3319         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3320         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3321         (TestWebKitAPI::PlatformWebView::resizeTo):
3322         (TestWebKitAPI::PlatformWebView::page):
3323         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3324         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3325         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3326         * WebKitTestRunner/PlatformWebView.h:
3327         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3328         (WTR::EventSenderProxy::dispatchEvent):
3329         (WTR::EventSenderProxy::keyDown):
3330         (WTR::EventSenderProxy::sendTouchEvent):
3331         (WTR::EventSenderProxy::setTouchModifier):
3332         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3333         (WTR::PlatformWebView::PlatformWebView):
3334         (WTR::PlatformWebView::~PlatformWebView):
3335         (WTR::PlatformWebView::resizeTo):
3336         (WTR::PlatformWebView::page):
3337         (WTR::PlatformWebView::focus):
3338         (WTR::PlatformWebView::windowSnapshotImage):
3339
3340 2013-03-19  Roger Fong  <roger_fong@apple.com>
3341
3342         Changes to VS2010 project files should only trigger builds on Windows bots.
3343         https://bugs.webkit.org/show_bug.cgi?id=112731
3344
3345         Reviewed by Timothy Horton.
3346
3347         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3348         (_should_file_trigger_build):
3349
3350 2013-03-19  Roger Fong  <roger_fong@apple.com>
3351
3352         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3353
3354         * Scripts/webkitpy/tool/steps/runtests.py:
3355         (RunTests.run):
3356         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3357         (RunTestsTest.test_webkit_run_unit_tests):
3358
3359 2013-03-19  Julie Parent  <jparent@chromium.org>
3360
3361         Dashboards: Introduce history namespace and unit tests.
3362         https://bugs.webkit.org/show_bug.cgi?id=112645
3363
3364         Reviewed by Ojan Vafai.
3365         
3366         Laying the framework for introducing the new history object and
3367         namespace.  This moves only static functions into the history
3368         namespace, and moves corresponding unit tests into seperate
3369         unit test file.
3370
3371         * TestResultServer/static-dashboards/aggregate_results.html:
3372         * TestResultServer/static-dashboards/dashboard_base.js:
3373         (parseCrossDashboardParameters):
3374         (parseDashboardSpecificParameters):
3375         (parseParameters):
3376         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3377         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3378         (.switch.return):
3379         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3380         * TestResultServer/static-dashboards/history.js: Added.
3381         * TestResultServer/static-dashboards/history_unittests.js: Added.
3382         * TestResultServer/static-dashboards/loader.js:
3383         (.):
3384         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3385         * TestResultServer/static-dashboards/run-unittests.html:
3386         * TestResultServer/static-dashboards/timeline_explorer.html:
3387         * TestResultServer/static-dashboards/timeline_explorer.js:
3388         * TestResultServer/static-dashboards/treemap.html:
3389         * TestResultServer/static-dashboards/treemap.js:
3390         (.switch.return):
3391         * TestResultServer/static-dashboards/ui.js:
3392
3393 2013-03-19  Daniel Bates  <dbates@webkit.org>
3394
3395         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3396         https://bugs.webkit.org/show_bug.cgi?id=112732
3397
3398         Reviewed by Eric Seidel.
3399
3400         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3401         of an existing file cannot be applied.
3402
3403         In particular, svn-{apply, unapply} compensate for differences in line endings
3404         by converting the line endings in a diff to match the line endings in the target
3405         file. The diff(1) command precedes the last line of a diff that adds a newline
3406         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3407         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3408         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3409         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3410         the newline characters in this special character sequence to match the line endings
3411         in the target file.
3412
3413         * Scripts/VCSUtils.pm:
3414         (parseDiff):
3415         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3416         Added tests:
3417             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3418             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3419             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3420             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3421         (escapeNewLineCharacters): Added.
3422         (toMacLineEndings): Added.
3423
3424 2013-03-19  James Robinson  <jamesr@chromium.org>
3425
3426         [chromium] Remove compositor settings that don't go through WebKit
3427         https://bugs.webkit.org/show_bug.cgi?id=112718
3428
3429         Reviewed by Adam Barth.
3430
3431         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3432         (main):
3433         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3434         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3435         (WebTestRunner::WebPreferences::reset):
3436         (WebTestRunner::WebPreferences::applyTo):
3437         * DumpRenderTree/chromium/TestShell.cpp:
3438         (TestShell::TestShell):
3439         (TestShell::resetWebSettings):
3440         * DumpRenderTree/chromium/TestShell.h:
3441         (TestShell):
3442
3443 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3444
3445         Unreviewed, rolling out r146101.
3446         https://bugs.webkit.org/show_bug.cgi?id=111884
3447
3448         re-enable custom freetype on asan; this needs to be on
3449         now that the bot is running lucid.
3450
3451         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3452
3453 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3454
3455         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3456         https://bugs.webkit.org/show_bug.cgi?id=112365
3457
3458         Reviewed by Benjamin Poulain.
3459
3460         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3461         harcoding it in wtf/Platform.h
3462
3463         * Scripts/webkitperl/FeatureList.pm:
3464
3465 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3466
3467         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3468         https://bugs.webkit.org/show_bug.cgi?id=94782
3469
3470         Based on patch by Csaba Osztrogonác.
3471         Reviewed by Jocelyn Turcotte.
3472
3473         The diff image is generated with bright red indicating errors, but letting the base image
3474         shine through so the context of the error-pixel can be identified.
3475
3476         * DumpRenderTree/qt/ImageDiff.cpp:
3477         (main):
3478
3479 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3480
3481         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3482
3483         Rubber-stamped by Csaba Osztrogonác.
3484
3485         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3486         since the latter might not cover the former.
3487
3488         * QtTestBrowser/launcherwindow.cpp:
3489         (LauncherWindow::print):
3490
3491 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3492
3493         Style tweeks to default.css.
3494         
3495         Rubber-stamped by David Kilzer.
3496         
3497         Give visited links a different color to other links, so you can
3498         see which builds you've viewed.
3499         
3500         Make the <small> text less tiny.
3501
3502         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3503         (small):
3504         (a:link,a:visited,a:active):
3505         (a:visited):
3506
3507 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3508
3509         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3510         https://bugs.webkit.org/show_bug.cgi?id=112494
3511
3512         Reviewed by Dirk Pranke.
3513
3514         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3515         Also merged two pairs of methods to cleanup the code.
3516
3517         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3518         (PerfTestsRunner.run): Merged _upload_and_show_results.
3519         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3520
3521 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3522
3523         [chromium] build xdisplaycheck when building DRT
3524         https://bugs.webkit.org/show_bug.cgi?id=112636
3525
3526         Reviewed by Tony Chang.
3527
3528         It appears that we need xdisplaycheck to be built in order for
3529         Xvfb to be started correctly on the bots, and DRT was missing
3530         a dependency on it. This may be the cause of the ASAN bot not
3531         starting up properly (it only builds DRT).
3532
3533         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3534
3535 2013-03-18  David Levin  <levin@chromium.org>
3536
3537         Implement icon change notification dump for Chromium's test shell.
3538         https://bugs.webkit.org/show_bug.cgi?id=112614
3539
3540         This was previously implemented for some other platforms in r58111
3541         and r116547.
3542
3543         In r122806, fast/dom/icon-url-property.html stopped using it, but
3544         it is useful for tests, so I plan to re-add it to that test again.
3545
3546         Reviewed by Jochen Eisinger.
3547
3548         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3549         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3550          icon change notifications from WebKit may be logged in test output.
3551         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3552         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3553         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3554         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3555         (WebTestRunner):
3556         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3557         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3558         (TestRunner):
3559         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3560         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3561         (WebTestRunner):
3562         * DumpRenderTree/chromium/WebViewHost.cpp:
3563         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3564         * DumpRenderTree/chromium/WebViewHost.h:
3565         (WebViewHost):
3566
3567 2013-03-18  Julie Parent  <jparent@chromium.org>
3568
3569         Cleanup: Move js for treemap and aggregate_results into own js files.
3570         https://bugs.webkit.org/show_bug.cgi?id=112618
3571
3572         Reviewed by Dirk Pranke.
3573         
3574         No functional changes, just moving the code into separate js file
3575         rather than inlined in the html, so we can test it, make it more
3576         modular, etc.  Other dashboard types are already done this way.
3577
3578         * TestResultServer/static-dashboards/aggregate_results.html:
3579         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3580         (generatePage):
3581         (handleValidHashParameter):
3582         (htmlForBuilder):
3583         (rawValuesHTML):
3584         (chartHTML):
3585         (filteredValues):
3586         (chart):
3587         (htmlForRevisionRows):
3588         (wrapHTMLInTable):
3589         (htmlForSummaryTable):
3590         (valuesPerExpectation):
3591         (htmlForTestType):
3592         (htmlForTableRow):
3593         (extendedEncode):
3594         * TestResultServer/static-dashboards/treemap.html:
3595         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3596         (humanReadableTime):
3597         (convertToWebTreemapFormat):
3598         (reverseSortByAverage):
3599         (generatePage):
3600         (focusPath):
3601         (.switch.return):
3602         (handleQueryParameterChange):
3603         (extractName):
3604         (fullName):
3605         (handleFocus.):
3606         (handleFocus):
3607
3608 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3609
3610         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3611         https://bugs.webkit.org/show_bug.cgi?id=112622
3612
3613         Reviewed by Dirk Pranke.
3614
3615         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3616         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3617
3618 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3619
3620         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3621         https://bugs.webkit.org/show_bug.cgi?id=112619
3622
3623         Reviewed by Dirk Pranke.
3624
3625         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3626         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3627
3628         * Scripts/webkitpy/layout_tests/port/gtk.py:
3629         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3630         Port._webkit_baseline_path method.
3631         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3632         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3633         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3634         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3635         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3636         that are expected based on the builder name.
3637
3638 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3639
3640         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3641         https://bugs.webkit.org/show_bug.cgi?id=112571
3642
3643         Reviewed by Adam Barth.
3644
3645         Update function declarations for new WebFileSystemType enum. (All
3646         changes are behind an #ifdef so we can sync required changes in embedders.)
3647
3648         * DumpRenderTree/chromium/WebViewHost.cpp:
3649         (WebViewHost::openFileSystem):
3650         (WebViewHost::deleteFileSystem):
3651         * DumpRenderTree/chromium/WebViewHost.h:
3652         (WebViewHost):
3653
3654 2013-03-18  Julie Parent  <jparent@chromium.org>
3655
3656         Cleanup: Move timeline_exporer js out of html file into js.
3657         https://bugs.webkit.org/show_bug.cgi?id=112188
3658
3659         Reviewed by Dirk Pranke.
3660         
3661         Moves the javascript out of the html file and into a new js file.
3662         This follows the format of flakiness_dashboard.{html|js}.
3663         
3664         Also moves code from dashboard_base that is used only by this one
3665         dashboard, and makes it private to the dashboard.
3666
3667         * TestResultServer/static-dashboards/dashboard_base.js:
3668         * TestResultServer/static-dashboards/timeline_explorer.html:
3669         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3670         (generatePage):
3671         (initCurrentBuilderTestResults):
3672         (shouldShowWebKitRevisionsOnly):
3673         (updateTimelineForBuilder.):
3674         (updateTimelineForBuilder):
3675         (selectBuild):
3676         (updateBuildIndicator):
3677         (.addRow):
3678         (.addNumberRow):
3679         (.inspectorNode.getElementsByTagName.0.onclick):
3680         (.inspectorNode.getElementsByTagName.1.onclick):
3681         (.inspectorNode.getElementsByTagName.2.onclick):
3682         (updateBuildInspector):
3683         (showResultsDelta):
3684         (decompressResults.addFlakyDelta):
3685         (decompressResults):
3686
3687 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3688
3689         Unreviewed, rolling out r145272.
3690         http://trac.webkit.org/changeset/145272
3691         https://bugs.webkit.org/show_bug.cgi?id=111884
3692
3693         Turns out the ASAN build is still broken; possibly there's
3694         something still setting LD_LIBRARY_PATH, or possibly there's
3695         something else wrong. In the meantime, we need it to work again.
3696
3697         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3698
3699 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3700
3701         delete-stale-build-files is too aggressive
3702         https://bugs.webkit.org/show_bug.cgi?id=112595
3703
3704         Reviewed by Tim Horton.
3705
3706         It appears that whitelisting file extensions to keep is not a good idea.
3707         Blacklist files to delete instead, and only delete .o files for now.
3708         We can add more file extensions as needed.
3709
3710         * BuildSlaveSupport/delete-stale-build-files:
3711
3712 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3713
3714         Disable accessibility notifications after each test
3715         https://bugs.webkit.org/show_bug.cgi?id=112579
3716
3717         Reviewed by Tim Horton.
3718         
3719         In WebKitTestRunner, if any tests triggered accessibility notifications,
3720         the global notification handler would thereafter be active, and fire
3721         notifications for all subsequent tests.
3722         
3723         Fix by implementing AccessibilityController::resetToConsistentState() for
3724         Mac, and using it to clear the global notification handler.
3725
3726         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3727         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3728         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3729         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3730         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3731         (e.g. because of -autorelease).
3732         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3733         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3734         if there is one.
3735         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3736         Add -stopObserving
3737         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3738         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3739         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3740         center.
3741
3742 2013-03-18  Dana Jansens  <danakj@chromium.org>
3743
3744         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3745         https://bugs.webkit.org/show_bug.cgi?id=112392
3746
3747         Reviewed by James Robinson.
3748
3749         Removes the command line flag option from DRT.
3750
3751         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3752         (main):
3753
3754 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3755
3756         [GTK] plugins/plugin-clip-subframe.html is failing
3757         https://bugs.webkit.org/show_bug.cgi?id=112570
3758
3759         Reviewed by Martin Robinson.
3760
3761         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3762
3763 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3764
3765         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3766         https://bugs.webkit.org/show_bug.cgi?id=112442
3767
3768         Reviewed by Gustavo Noronha Silva.
3769
3770         * GtkLauncher/main.c:
3771         (reloadCb):
3772         (createToolbar):
3773         (createWindow):
3774
3775 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3776
3777         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3778         https://bugs.webkit.org/show_bug.cgi?id=112205
3779
3780         Disable this API test until Geoff can fix it.
3781
3782         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3783         (TestWebKitAPI::TEST):
3784
3785 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3786
3787         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3788         https://bugs.webkit.org/show_bug.cgi?id=112478
3789
3790         Reviewed by Tony Chang.
3791
3792         There is nothing that ensures that the log messages from the plugin
3793         come in before the layout test finished loading.
3794
3795         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3796         (PassDifferentNPPStruct::NPP_SetWindow):
3797         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3798         (NPP_SetWindow):
3799
3800 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3801
3802         Have the mac port support per_test_timeout in webkitpy
3803         https://bugs.webkit.org/show_bug.cgi?id=112466
3804
3805         Reviewed by Dirk Pranke.
3806         
3807         Both WTR and DRT handle --timeout arguments, so we can
3808         have the scripts pass the timeout values down to the tools.
3809
3810         * Scripts/webkitpy/layout_tests/port/mac.py:
3811         (MacPort.supports_per_test_timeout):
3812
3813 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3814
3815         Remove setAsynchronousSpellCheckingEnabled from test runners
3816         https://bugs.webkit.org/show_bug.cgi?id=112362
3817
3818         Reviewed by Tony Chang.
3819
3820         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3821         in internals.settings, so all ports can share it.
3822
3823         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3824         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3825         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3826         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3827         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3828         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3829         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3830         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3831         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3832         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3833         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3834         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3835
3836 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3837
3838         Fix the stupid unit tests.
3839
3840         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3841         (test_sample_process):
3842
3843 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3844
3845         Collect samples for unresponsive web processes
3846         https://bugs.webkit.org/show_bug.cgi?id=112409
3847
3848         Reviewed by Tim Horton.
3849         
3850         When we detect that a subprocess was unresponsive, run the 'sample'
3851         tool on that process, for the Mac port.
3852         
3853         The sample will be linked to from the results.html page, next
3854         to the crash log link.
3855
3856         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3857         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3858         look for samples on disk.
3859         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3860         (TestResultWriter):
3861         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3862         -sample.txt files, and have it copy their contents to a new file
3863         next to the test that spawned them (as we do for crash logs).
3864         * Scripts/webkitpy/layout_tests/port/base.py:
3865         (Port.look_for_new_samples): Base class does nothing for sampling.
3866         * Scripts/webkitpy/layout_tests/port/driver.py:
3867         (Driver._check_for_driver_crash): Kick off a sample if we detected
3868         that the subprocess was unresponsive.
3869         * Scripts/webkitpy/layout_tests/port/mac.py:
3870         (MacPort.sample_file_path): Utility to generate the file path
3871         to the generated sample files at the top level of layout-test-results.
3872         (MacPort.look_for_new_crash_logs): Fix typo
3873         (MacPort.look_for_new_samples): New function to find sample files.
3874         (MacPort.sample_process): Use the utility function to get the file path.
3875
3876 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3877
3878         [Qt] Remove simple getters and setters from TestRunnerQt
3879         https://bugs.webkit.org/show_bug.cgi?id=112343
3880
3881         Reviewed by Benjamin Poulain.
3882
3883         The removed functions and boolean members
3884         are being replaced by the implementations in the
3885         generic TestRunner.h.
3886
3887         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3888         (DumpRenderTree::dumpFrameScrollPosition):
3889         (DumpRenderTree::dumpFramesAsText):
3890         (DumpRenderTree::dump):
3891         (DumpRenderTree::titleChanged):
3892         (DumpRenderTree::dumpDatabaseQuota):
3893         (DumpRenderTree::dumpApplicationCacheQuota):
3894         (DumpRenderTree::statusBarMessage):
3895         (DumpRenderTree::createWindow):
3896         * DumpRenderTree/qt/TestRunnerQt.cpp:
3897         (TestRunnerQt::reset):
3898         * DumpRenderTree/qt/TestRunnerQt.h:
3899         (TestRunnerQt):
3900
3901 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3902
3903         Update the link on build.webkit.org to refer to perf.webkit.org
3904         https://bugs.webkit.org/show_bug.cgi?id=112416
3905
3906         Reviewed by Philip Rogers.
3907
3908         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3909
3910         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3911
3912 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3913
3914         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3915         https://bugs.webkit.org/show_bug.cgi?id=112394
3916
3917         Reviewed by Philippe Normand.
3918
3919         * GtkLauncher/main.c:
3920         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3921
3922 2013-03-14  Andreas Kling  <akling@apple.com>
3923
3924         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3925         <http://webkit.org/b/111815>
3926         <rdar://problem/13380145>
3927
3928         Reviewed by Anders Carlsson.
3929
3930         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3931         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3932         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3933
3934         * WebKitTestRunner/PlatformWebView.h:
3935         (PlatformWebView):
3936         * WebKitTestRunner/TestController.cpp:
3937         (WTR::TestController::createOtherPage):
3938         (WTR::TestController::createWebViewWithOptions):
3939         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3940         (WTR::PlatformWebView::didInitializeClients):
3941
3942 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3943
3944         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3945         https://bugs.webkit.org/show_bug.cgi?id=112122
3946
3947         Reviewed by Kenneth Rohde Christiansen.
3948
3949         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3950
3951         * MiniBrowser/efl/main.c:
3952         (_Browser_Window):
3953         (search_box_show):
3954         (search_box_hide):
3955         (on_key_down):
3956         (on_url_changed):
3957         (on_search_field_aborted):
3958         (on_search_field_activated):
3959         (on_search_field_clicked):
3960         (on_search_backward_button_clicked):
3961         (on_search_forward_button_clicked):
3962         (window_create):
3963
3964 2013-03-14  Julie Parent  <jparent@chromium.org>
3965
3966         Cleanup: Remove g_resourceLoader.
3967         https://bugs.webkit.org/show_bug.cgi?id=112305
3968
3969         Reviewed by Dirk Pranke.
3970         
3971         Removing another global.
3972         
3973         Now, each dashboard creates its own loader, rather than having
3974         a general global one.
3975         
3976         Remove usage of g_resourceLoader.isLoadingComplete from 
3977         handleLocationChange by ensuring that handleLocationChange is
3978         never called before the loader is done.  It was called in two
3979         places before: 1 was from the callback when the loader is done,
3980         so that was obviously true, and the other was from onhashchange,
3981         where it would just return rather than running.  Instead, lets
3982         only register the onhashchange handler once the loader is
3983         setup, so the check is no longer necessary.
3984         
3985         Remove isLoadingComplete since it is now unused.
3986         
3987         Callback for loader is now initializeHistory, rather than just
3988         handleLocationChange which will set up the hashchange handler now.
3989         This will all eventually be moving to a new History object.
3990
3991         * TestResultServer/static-dashboards/aggregate_results.html:
3992         * TestResultServer/static-dashboards/dashboard_base.js:
3993         (handleLocationChange):
3994         (intializeHistory):
3995         (decompressResults):
3996         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3997         (generatePage):
3998         * TestResultServer/static-dashboards/loader.js:
3999         (.):
4000         * TestResultServer/static-dashboards/loader_unittests.js:
4001         * TestResultServer/static-dashboards/timeline_explorer.html:
4002         * TestResultServer/static-dashboards/treemap.html:
4003
4004 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
4005
4006         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
4007         https://bugs.webkit.org/show_bug.cgi?id=109404
4008
4009         Reviewed by Tony Chang.
4010
4011         Removes all the code related to smartInsertDeleteEnabled and
4012         selectTrailingWhitespaceEnabled settings as they will be managed from
4013         internals from now on.
4014
4015         * DumpRenderTree/TestRunner.cpp:
4016         (TestRunner::staticFunctions):
4017         * DumpRenderTree/TestRunner.h:
4018         (TestRunner):
4019         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4020         (WebKit):
4021         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
4022         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
4023         (DumpRenderTree):
4024         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4025         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4026         (WebTestRunner::WebTestProxy::didStopLoading):
4027         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4028         (WebTestRunner::TestRunner::TestRunner):
4029         (WebTestRunner::TestRunner::reset):
4030         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4031         (TestRunner):
4032         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
4033         (WebTestRunner::WebPreferences::applyTo): Set default values for
4034         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
4035         Chromium DRT default values are different from Chromium browser.
4036         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4037         * DumpRenderTree/chromium/WebViewHost.cpp:
4038         * DumpRenderTree/chromium/WebViewHost.h:
4039         (WebViewHost):
4040         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4041         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4042         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4043         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4044         (resetDefaultsToConsistentValues):
4045         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4046         * DumpRenderTree/mac/DumpRenderTree.mm:
4047         (resetWebViewToConsistentStateBeforeTesting):
4048         * DumpRenderTree/mac/TestRunnerMac.mm:
4049         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4050         (WebCore::WebPage::resetSettings):
4051         * DumpRenderTree/qt/TestRunnerQt.cpp:
4052         * DumpRenderTree/qt/TestRunnerQt.h:
4053         (TestRunnerQt):
4054         * DumpRenderTree/win/DumpRenderTree.cpp:
4055         (resetWebViewToConsistentStateBeforeTesting):
4056         * DumpRenderTree/win/TestRunnerWin.cpp:
4057         * DumpRenderTree/wx/TestRunnerWx.cpp:
4058
4059 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4060
4061         [Qt] Disable DRT on Windows
4062
4063         Reviewed by Jocelyn Turcotte.
4064
4065         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
4066
4067         * qmake/mkspecs/features/configure.prf:
4068
4069 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
4070
4071         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
4072         https://bugs.webkit.org/show_bug.cgi?id=110728
4073
4074         Reviewed by Gyuyoung Kim.
4075
4076         Use the page group to create the view object.
4077
4078         * MiniBrowser/efl/main.c:
4079         (window_create):
4080
4081 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4082
4083         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
4084
4085         Reviewed by Tor Arne Vestbø.
4086
4087         The mock versions of these web facing features should be instantiated when
4088         running in DumpRenderTree only. In order for them to work, no extra Qt modules
4089         such as QtLocation are actually needed.
4090
4091         This patch decouples enabling device orientation/motion and geolocation from
4092         the underlying Qt modules and makes them available in developer builds
4093         (!production_build) and backed by mock backends when running in drt.
4094
4095         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
4096         developers the web facing features are always enabled (although requests will
4097         time out) and the mock backends are enabled inside DRT, allowing for the layout
4098         tests to run with less dependencies.
4099
4100         In addition this also enables the mock device motion client, which was
4101         previously never instantiated.
4102
4103         * qmake/mkspecs/features/features.prf:
4104
4105 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4106
4107         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
4108         https://bugs.webkit.org/show_bug.cgi?id=112340
4109
4110         Reviewed by Simon Hausmann.
4111
4112         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4113         (DumpRenderTree::dump):
4114             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
4115         (DumpRenderTree::dumpApplicationCacheQuota):
4116         * DumpRenderTree/qt/TestRunnerQt.cpp:
4117         (TestRunnerQt::reset):
4118         * DumpRenderTree/qt/TestRunnerQt.h:
4119         (TestRunnerQt):
4120
4121 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4122
4123         [Qt] Port DRT to use TestRunner::dumpAsText()
4124         https://bugs.webkit.org/show_bug.cgi?id=112260
4125
4126         Reviewed by Benjamin Poulain.
4127
4128         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4129         (WebCore::DumpRenderTree::open):
4130         (WebCore::methodNameStringForFailedTest):
4131             Change parameter from type TestRunnerQt* to TestRunner*.
4132         (WebCore::DumpRenderTree::dump):
4133             TestRunnerQt::shouldDumpPixels() always returned true in our case.
4134             Instead we should rely on TestRunner::generatePixelResults().
4135         * DumpRenderTree/qt/TestRunnerQt.cpp:
4136         (TestRunnerQt::reset):
4137         * DumpRenderTree/qt/TestRunnerQt.h:
4138         (TestRunnerQt):
4139
4140 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
4141
4142         Implement FontLoader interface
4143         https://bugs.webkit.org/show_bug.cgi?id=98395
4144
4145         Reviewed by Eric Seidel.
4146
4147         Enable FontLoadEvents runtime flag for TestShell.
4148
4149         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4150         (WebTestRunner::TestInterfaces::TestInterfaces):
4151
4152 2013-03-13  Julie Parent  <jparent@chromium.org>
4153
4154         CLeanup: remove unnecessary call to parseParameters.
4155         https://bugs.webkit.org/show_bug.cgi?id=112309
4156
4157         Reviewed by Ojan Vafai.
4158         
4159         We call parseCrossDashboardParameters when the dashboard initially
4160         loads to set the state required for loadBuildersList, and then we
4161         call it again once we are fully done with loading, so there is no
4162         reason to call it in the middle of the loading process here.
4163
4164         * TestResultServer/static-dashboards/loader.js:
4165         (.):
4166
4167 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
4168
4169         Unreviewed. Now I'm a reviewer :)
4170
4171         * Scripts/webkitpy/common/config/committers.py:
4172
4173 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
4174
4175         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
4176         https://bugs.webkit.org/show_bug.cgi?id=112277
4177
4178         Reviewed by Adam Barth.
4179
4180         * Scripts/webkitperl/FeatureList.pm:
4181         * qmake/mkspecs/features/features.pri:
4182
4183 2013-03-13  Adam Barth  <abarth@webkit.org>
4184
4185         run-perf-tests should support content_shell
4186         https://bugs.webkit.org/show_bug.cgi?id=112291
4187
4188         Reviewed by Eric Seidel.
4189
4190         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4191         (PerfTestsRunner._parse_args):
4192
4193 2013-03-13  Oliver Hunt  <oliver@apple.com>
4194
4195         Simplify Checked<> multiplication
4196         https://bugs.webkit.org/show_bug.cgi?id=112286
4197
4198         Reviewed by James Robinson.
4199
4200         Add tests for multiplication by zero and max to ensure we don't
4201         mess them up should we ever make changes to Checked<> in future.
4202
4203         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4204         (TestWebKitAPI):
4205
4206 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4207
4208         [Qt] Unreviewed prospective Windows build fix
4209
4210         Do the usual thing, include the moc generated code in the .cpp file instead
4211         of compiling it standalone, to ensure that config.h is included, too, and
4212         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
4213
4214         * DumpRenderTree/qt/EventSenderQt.cpp:
4215
4216 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4217
4218         [Qt] Port TestRunner::findString to shared interface
4219         https://bugs.webkit.org/show_bug.cgi?id=112147
4220
4221         Reviewed by Jocelyn Turcotte.
4222
4223         This patch also removes DumpRenderTree and some other helper classes from
4224         the WebCore namespace, to which they do not really belong.
4225
4226         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4227         (main):
4228         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4229         (DumpRenderTree::DumpRenderTree):
4230         (DumpRenderTree::~DumpRenderTree):
4231         (DumpRenderTree::instance):
4232         (DumpRenderTree::setShouldTimeout):
4233         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4234         (DumpRenderTree):
4235         * DumpRenderTree/qt/EventSenderQt.cpp:
4236         (EventSender::contextClick):
4237         (EventSender::sendEvent):
4238         (EventSender::postEvent):
4239         * DumpRenderTree/qt/EventSenderQt.h:
4240         (EventSender::isGraphicsBased):
4241         * DumpRenderTree/qt/TestRunnerQt.cpp:
4242         (TestRunnerQt::TestRunnerQt):
4243         (TestRunner::findString):
4244         (TestRunnerQt::setMockDeviceOrientation):
4245         (TestRunnerQt::setGeolocationPermission):
4246         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
4247         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
4248         (TestRunnerQt::setMockGeolocationPosition):
4249         * DumpRenderTree/qt/TestRunnerQt.h:
4250         (TestRunnerQt):
4251
4252 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
4253
4254         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
4255         https://bugs.webkit.org/show_bug.cgi?id=112129
4256
4257         Reviewed by Adam Barth.
4258
4259         Following Chromium
4260         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
4261         this is being renamed to better explain what it does.
4262
4263         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4264
4265 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4266
4267         [Qt] Unreviewed trivial typo fix
4268
4269         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
4270         TextRunner.h. Thanks Zeno :)
4271
4272 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
4273
4274         [Qt] Prepare DRT for transition to shared TestRunner interface
4275         https://bugs.webkit.org/show_bug.cgi?id=112144
4276
4277         Reviewed by Benjamin Poulain.
4278
4279         Prepare Qt's DRT for a transition from the QObject based TestRunner to
4280         the JSC C API based one.
4281
4282         This is impplemented by instantiating the QObject based testRunner in
4283         the global object, then instantiating the JSC C based TestRunner
4284         separately and placing it "behind" the QObject based testRunner through
4285         injection of the individual functions through proxies. (prototype
4286         chaining doesn't work due to the this object and Function.prototype.bind
4287         doesn't work due to the native function)
4288
4289         This allows for porting over method by method by removing the method
4290         from the QObject TestRunnerQt and implementing it in the JSC C based
4291         TestRunner.
4292
4293         In order for this to link and run dummy implementations of all the
4294         necessary TestRunner functions are provided.
4295
4296         * DumpRenderTree/qt/DumpRenderTree.pro:
4297         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4298         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4299         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4300         (WebCore::DumpRenderTree::initJSObjects):
4301         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4302         (DumpRenderTree):
4303         * DumpRenderTree/qt/TestRunnerQt.cpp:
4304         (TestRunner::~TestRunner):
4305         (TestRunner::addDisallowedURL):
4306         (TestRunner::queueLoad):
4307         (TestRunner::removeAllVisitedLinks):
4308         (TestRunner::setAcceptsEditing):
4309         (TestRunner::simulateLegacyWebNotificationClick):
4310         (TestRunner::setWindowIsKey):
4311         (TestRunner::setAlwaysAcceptCookies):
4312         (TestRunner::addOriginAccessWhitelistEntry):
4313         (TestRunner::setWebViewEditable):
4314         (TestRunner::clearAllApplicationCaches):
4315         (TestRunner::setTextDirection):
4316         (TestRunner::notifyDone):