2c1a3b20afe2a198c58b5f8e8596508615f153a3
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-25  Jonathan Bedard  <jbedard@apple.com>
2
3         Follow-up Internal build fix for r221187
4         https://bugs.webkit.org/show_bug.cgi?id=175960
5         <rdar://problem/34069264>
6
7         Unreviewed build fix.
8
9         * TestWebKitAPI/ios/DataInteractionSimulator.h: Move UIItemProvider declaration
10         into #if block.
11
12 2017-08-25  Don Olmstead  <don.olmstead@sony.com>
13
14         [WinCairo] Use GitHub releases for WinCairoRequirements
15         https://bugs.webkit.org/show_bug.cgi?id=175972
16
17         Reviewed by Brent Fulgham.
18
19         * Scripts/build-webkit:
20         (cMakeArgsFromFeatures): Deleted.
21         (writeCongrats): Deleted.
22         * Scripts/download-latest-github-release.py:
23         (Status):
24         (parse_args):
25         (main):
26         * Scripts/update-webkit-wincairo-libs.py: Renamed from Tools/Scripts/update-webkit-wincairo-libs.
27
28 2017-08-25  Jonathan Bedard  <jbedard@apple.com>
29
30         Fix build breakage with Public iOS 11 SDK
31         https://bugs.webkit.org/show_bug.cgi?id=175960
32         <rdar://problem/34069264>
33
34         Reviewed by Wenson Hsieh.
35
36         * TestWebKitAPI/ios/DataInteractionSimulator.h: Add UIItemProvider declaration.
37
38 2017-08-24  Chris Dumez  <cdumez@apple.com>
39
40         [Directory Upload] Add basic support for input.webkitdirectory
41         https://bugs.webkit.org/show_bug.cgi?id=175950
42         <rdar://problem/33951915>
43
44         Reviewed by Geoffrey Garen.
45
46         * DumpRenderTree/mac/DumpRenderTree.mm:
47         (resetWebPreferencesToConsistentValues):
48         * WebKitTestRunner/TestController.cpp:
49         (WTR::TestController::resetPreferencesToConsistentValues):
50         Enable Directory Upload feature for testing, given that it is currently disabled by default.
51
52         (WTR::runOpenPanel):
53         Print additional text when directories are allowed to extend testing coverage.
54
55 2017-08-24  Alex Christensen  <achristensen@webkit.org>
56
57         Add WKUIDelegatePrivate equivalent of WKPageUIClient's handleAutoplayEvent
58         https://bugs.webkit.org/show_bug.cgi?id=175965
59         <rdar://problem/29270035>
60
61         Reviewed by Tim Horton.
62
63         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
64         (TEST):
65         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
66         (-[AutoplayPoliciesDelegate _webView:handleAutoplayEvent:withFlags:]):
67         (TEST):
68         (handleAutoplayEvent): Deleted.
69
70 2017-08-24  Alex Christensen  <achristensen@webkit.org>
71
72         didNotHandleWheelEvent test times out
73         https://bugs.webkit.org/show_bug.cgi?id=175967
74
75         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
76         Skip the test until WebCore's wheel event handling is reliable enough to test.
77
78 2017-08-24  Jonathan Bedard  <jbedard@apple.com>
79
80         Update configure-xcode-for-ios-development for iOS 11
81         https://bugs.webkit.org/show_bug.cgi?id=173937
82         <rdar://problem/33038924>
83
84         Reviewed by Daniel Bates.
85
86         Xcode 9 has removed the following headers from the iOS 11 Simulator SDK:
87                 /usr/include/crt_externs.h
88                 /usr/include/mach/mach_types.defs
89                 /usr/include/mach/machine/machine_types.defs
90                 /usr/include/mach/std_types.defs
91                 /usr/include/objc/objc-class.h
92                 /usr/include/objc/objc-runtime.h
93                 /usr/include/objc/Protocol.h
94                 /usr/include/readline/history.h
95                 /usr/include/readline/readline.h
96         To solve this problem, configure-xcode-for-ios-development copies these headers
97         from the active macOS SDK into the iOS Simulator SDK.
98
99         * Scripts/configure-xcode-for-ios-development:
100         (copyMissingHeadersFromSDKToSDKIfNeeded): Copy all missing header from one SDK
101         into another if those headers do not exist in the destination SDK.
102         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Deleted.
103
104 2017-08-24  Alex Christensen  <achristensen@webkit.org>
105
106         Add WKUIDelegatePrivate callback corresponding to PageUIClient's didNotHandleWheelEvent
107         https://bugs.webkit.org/show_bug.cgi?id=175957
108         <rdar://problem/29270035>
109
110         Reviewed by Geoffrey Garen.
111
112         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
113         (synthesizeWheelEvents):
114         (-[WheelDelegate _webView:didNotHandleWheelEvent:]):
115         (-[WheelDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
116         (TEST):
117
118 2017-08-24  Tim Horton  <timothy_horton@apple.com>
119
120         Layout size override changes during in-flight animated resize are dropped on the floor forever
121         https://bugs.webkit.org/show_bug.cgi?id=175916
122         <rdar://problem/33887295>
123
124         Reviewed by Beth Dakin.
125
126         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
127         (TEST):
128         Add a test ensuring that override layout size changes
129         during an animated resize actually take effect.
130
131 2017-08-23  Matt Lewis  <jlewis3@apple.com>
132
133         Disabled VideoControlsManagerMultipleVideosSwitchControlledVideoWhenScrolling.
134         https://bugs.webkit.org/show_bug.cgi?id=175909
135
136         Unreviewed test gardening.
137
138         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
139         (TestWebKitAPI::TEST):
140
141 2017-08-24  Don Olmstead  <don.olmstead@sony.com>
142
143         [CMake] Use find_package for SQLite
144         https://bugs.webkit.org/show_bug.cgi?id=175803
145
146         Reviewed by Konstantin Tokarev.
147
148         * TestWebKitAPI/PlatformWin.cmake:
149
150 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
151
152         Leaking CARenderServerBuffer in PlatformWebView::windowSnapshotImage()
153         https://bugs.webkit.org/show_bug.cgi?id=175905
154
155         Reviewed by Tim Horton.
156
157         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
158         (WTR::PlatformWebView::windowSnapshotImage): Pass CARenderServerBuffer to CGDataProviderCreateWithData
159         so that the buffer can be destroyed.
160
161 2017-08-23  Alex Christensen  <achristensen@webkit.org>
162
163         Add WKUIDelegatePrivate callbacks corresponding to WKPageUIClient's takeFocus, focus, and unfocus
164         https://bugs.webkit.org/show_bug.cgi?id=175896
165
166         Reviewed by Tim Horton.
167
168         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
169         (-[UITestDelegate _showWebView:]):
170         (TEST):
171         (tabEvent):
172         (synthesizeTab):
173         (-[FocusDelegate _webView:takeFocus:]):
174         (-[FocusDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
175         (-[UITestDelegate _webViewShow:]): Deleted.
176
177 2017-08-23  Eric Carlson  <eric.carlson@apple.com>
178
179         Platform code should be able to safely log in release builds
180         https://bugs.webkit.org/show_bug.cgi?id=175854
181         <rdar://problem/34022930>
182
183         Reviewed by Jer Noble.
184
185         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
186         (TestWebKitAPI::TEST_F):
187
188 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
189
190         Access expectations path through apple_additions
191         https://bugs.webkit.org/show_bug.cgi?id=174800
192         <rdar://problem/33498899>
193
194         Unreviewed follow-up fix for r221087.
195
196         * Scripts/webkitpy/port/ios.py:
197         (IOSPort._apple_additions_path): Use iOS mapping instead of Mac mapping.
198
199 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
200
201         Access expectations path through apple_additions
202         https://bugs.webkit.org/show_bug.cgi?id=174800
203         <rdar://problem/33498899>
204
205         Reviewed by David Kilzer.
206
207         Follow-up fix. Mapping of operating system names was done incorrectly.
208
209         * Scripts/webkitpy/port/ios.py:
210         (IOSPort._apple_additions_path): Correctly find the operating system to be replaced.
211         * Scripts/webkitpy/port/ios_device_unittest.py:
212         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Add test for operating
213         system name replacement.
214         * Scripts/webkitpy/port/ios_simulator_unittest.py:
215         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Add test for operating
216         system name replacement.
217         * Scripts/webkitpy/port/mac.py: Correctly find the operating system to be replaced.
218         (MacPort._apple_additions_path):
219         * Scripts/webkitpy/port/mac_unittest.py:
220         (MacTest.test_layout_test_searchpath_with_apple_additions): Add test for operating system
221         name replacement.
222         * Scripts/webkitpy/port/port_testcase.py:
223         (bind_mock_apple_additions.MockAppleAdditions.ios_os_name): Change the passed name so that
224         operating system name replacement can be tested.
225         (bind_mock_apple_additions.MockAppleAdditions.mac_os_name): Ditto.
226
227 2017-08-23  Jonathan Bedard  <jbedard@apple.com>
228
229         Access expectations path through apple_additions
230         https://bugs.webkit.org/show_bug.cgi?id=174800
231         <rdar://problem/33498899>
232
233         Reviewed by Alexey Proskuryakov.
234
235         When external test expectations are imported through additional-platform-directory, they will
236         over-write any WebKit expectations. Access some expectations from apple_additions to correct
237         these precedence issues.
238
239         * Scripts/webkitpy/port/ios.py:
240         (IOSPort._apple_additions_path): Convert test expectation directory to a path
241         coming from apple_additions.
242         (IOSPort.default_baseline_search_path): Alternate between WebKit path and apple_additions
243         path for layout test expectations.
244         * Scripts/webkitpy/port/ios_device_unittest.py:
245         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
246         * Scripts/webkitpy/port/ios_simulator_unittest.py:
247         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
248         * Scripts/webkitpy/port/mac.py:
249         (MacPort._apple_additions_path): Convert test expectation directory to a path
250         coming from apple_additions.
251         (MacPort.default_baseline_search_path): Alternate between WebKit path and apple_additions
252         path for layout test expectations.
253         * Scripts/webkitpy/port/mac_unittest.py:
254         (MacTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
255         * Scripts/webkitpy/port/port_testcase.py:
256         (bind_mock_apple_additions): Added to create mock apple_additions for a block.
257         (bind_mock_apple_additions.MockAppleAdditions): Contains apple_addition stubs for testing.
258         * Scripts/webkitpy/port/win.py:
259         (WinPort.default_baseline_search_path): Include apple_additions test expectation for Windows.
260
261 2017-08-22  Zan Dobersek  <zdobersek@igalia.com>
262
263         Unreviewed. The WPE port should build TestWebKitAPI with the same
264         compiler flags as the GTK+ port, disabling a few flags that are
265         sprouting a lot of warning output.
266
267         * TestWebKitAPI/PlatformWPE.cmake:
268
269 2017-08-20  Wenson Hsieh  <wenson_hsieh@apple.com>
270
271         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
272         https://bugs.webkit.org/show_bug.cgi?id=175116
273         <rdar://problem/28279301>
274
275         Reviewed by Darin Adler and Ryosuke Niwa.
276
277         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
278         EditorStateTests run on both iOS and Mac.
279
280         * TestWebKitAPI/EditingTestHarness.h: Added.
281         * TestWebKitAPI/EditingTestHarness.mm: Added.
282
283         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
284         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
285         the state of the latest observed EditorState.
286
287         (-[EditingTestHarness initWithWebView:]):
288         (-[EditingTestHarness dealloc]):
289         (-[EditingTestHarness webView]):
290         (-[EditingTestHarness latestEditorState]):
291         (-[EditingTestHarness editorStateHistory]):
292         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
293         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
294         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
295         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
296         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
297         (-[EditingTestHarness toggleBold]):
298         (-[EditingTestHarness toggleItalic]):
299         (-[EditingTestHarness toggleUnderline]):
300         (-[EditingTestHarness setForegroundColor:]):
301         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
302         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
303         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
304         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
305         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
306         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
307         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
308
309         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
310         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
311         keys and values.
312
313         (-[EditingTestHarness latestEditorStateContains:]):
314         (-[EditingTestHarness _webView:editorStateDidChange:]):
315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
316         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
317         (TestWebKitAPI::setUpEditorStateTestHarness):
318         (TestWebKitAPI::TEST):
319         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
320
321 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
322
323         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
324         https://bugs.webkit.org/show_bug.cgi?id=175370
325         <rdar://problem/33799806>
326
327         Reviewed by Ryosuke Niwa.
328
329         Tweaks API tests that involve editing to wait for a presentation update before checking against UI process-side
330         information sent via EditorState updates. This allows any EditorState update scheduled by the test to propagate
331         to the UI process.
332
333         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
334         (-[CandidateTestWebView typeString:inputMessage:]):
335         (+[CandidateTestWebView setUpWithFrame:testPage:]):
336         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
337         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
338         (TestWebKitAPI::AcceptsFirstMouse::runTest):
339         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
340         * TestWebKitAPI/cocoa/TestWKWebView.h:
341         * TestWebKitAPI/cocoa/TestWKWebView.mm:
342         (-[TestWKWebView waitForNextPresentationUpdate]):
343
344         Add a new helper method to spin until the next presentation update.
345
346         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
347         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
348         (TestWebKitAPI::WebKitAgnosticTest::waitForNextPresentationUpdate):
349
350 2017-08-22  Alex Christensen  <achristensen@webkit.org>
351
352         Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
353         https://bugs.webkit.org/show_bug.cgi?id=175797
354         <rdar://problem/29270035>
355
356         Reviewed by Geoffrey Garen.
357
358         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
359         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.
360         (-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
361         (-[UITestDelegate _showPage:]):
362         (-[UITestDelegate webView:startURLSchemeTask:]):
363         (-[UITestDelegate webView:stopURLSchemeTask:]):
364         (TEST):
365
366 2017-08-22  Devin Rousso  <webkit@devinrousso.com>
367
368         Unreviewed, change my IRC nick.
369
370         * Scripts/webkitpy/common/config/contributors.json:
371
372 2017-08-22  Matt Lewis  <jlewis3@apple.com>
373
374         Unreviewed, rolling out r221026.
375
376         This caused a consistent API failure on iOS Simulator.
377
378         Reverted changeset:
379
380         "Add UIDelegatePrivate SPI corresponding to
381         WKPageUIClient.showPage"
382         https://bugs.webkit.org/show_bug.cgi?id=175797
383         http://trac.webkit.org/changeset/221026
384
385 2017-08-22  Alex Christensen  <achristensen@webkit.org>
386
387         Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
388         https://bugs.webkit.org/show_bug.cgi?id=175797
389         <rdar://problem/29270035>
390
391         Reviewed by Geoffrey Garen.
392
393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
394         * TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.
395         (-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
396         (-[UITestDelegate _showPage:]):
397         (-[UITestDelegate webView:startURLSchemeTask:]):
398         (-[UITestDelegate webView:stopURLSchemeTask:]):
399         (TEST):
400
401 2017-08-22  Jonathan Bedard  <jbedard@apple.com>
402
403         Fix leak-checking for iOS Simulators
404         https://bugs.webkit.org/show_bug.cgi?id=175735
405
406         Reviewed by David Kilzer.
407
408         Follow-up fix to r220942. _proc may be undefined.
409
410         * Scripts/webkitpy/port/server_process.py:
411         (ServerProcess._wait_for_stop): Handle case where _proc is undefined.
412
413 2017-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
414
415         [GTK][WPE] install-dependencies should install the required gstreamer packages needed for production builds.
416         https://bugs.webkit.org/show_bug.cgi?id=175822
417
418         Reviewed by Xabier Rodriguez-Calvar.
419
420         * gtk/install-dependencies: Add the bad plugins to the list.
421         * wpe/install-dependencies: Add all the gst related packages (copied from GTK listing).
422
423 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
424
425         DataInteractionTests.ExternalSourceAttributedStringToContentEditable hits a debug assertion
426         https://bugs.webkit.org/show_bug.cgi?id=175787
427         <rdar://problem/33996612>
428
429         Reviewed by Wenson Hsieh.
430
431         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
432         (TestWebKitAPI::TEST):
433
434 2017-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
435
436         Typo in "webkit-patch land"
437         https://bugs.webkit.org/show_bug.cgi?id=175788
438
439         Reviewed by Tim Horton.
440
441         * Scripts/webkitpy/tool/steps/commit.py:
442         (Commit._commit_warning):
443
444 2017-08-20  Sam Weinig  <sam@webkit.org>
445
446         StringView could use a function to strip leading/trailing characters without allocation
447         https://bugs.webkit.org/show_bug.cgi?id=175757
448
449         Reviewed by Darin Adler.
450
451         * TestWebKitAPI/Tests/WTF/StringView.cpp:
452         Add tests for StringView::stripLeadingAndTrailingMatchedCharacters().
453
454 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
455
456         [PAL] Move spi/mac directory into PAL
457         https://bugs.webkit.org/show_bug.cgi?id=175649
458
459         Reviewed by Myles C. Maxfield.
460
461         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
462
463 2017-08-21  Per Arne Vollan  <pvollan@apple.com>
464
465         [Win] DRT should only allow any https certificate for localhost.
466         https://bugs.webkit.org/show_bug.cgi?id=175147
467
468         Reviewed by Brent Fulgham.
469
470         Add check to make sure only localhost requests allow any https certificate.
471
472         * DumpRenderTree/win/DumpRenderTree.cpp:
473         (runTest):
474
475 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
476
477         Add WTFLogChannel level to allow runtime log filtering
478         https://bugs.webkit.org/show_bug.cgi?id=175731
479         <rdar://problem/33967234>
480
481         Unreviewed build fix.
482
483         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
484         (TestWebKitAPI::LoggingTest::output): Disable testing output by default because it 
485         fails on some of the bots.
486
487 2017-08-21  Eric Carlson  <eric.carlson@apple.com>
488
489         Add WTFLogChannel level to allow runtime log filtering
490         https://bugs.webkit.org/show_bug.cgi?id=175731
491         <rdar://problem/33967234>
492
493         Reviewed by Jer Noble.
494
495         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
496         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
497         (TestWebKitAPI::LoggingTest::output):
498         (TestWebKitAPI::TEST_F):
499
500 2017-08-19  Wenson Hsieh  <wenson_hsieh@apple.com>
501
502         [iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
503         https://bugs.webkit.org/show_bug.cgi?id=175509
504         <rdar://problem/33728169>
505
506         Reviewed by Ryosuke Niwa.
507
508         Removes ExternalSourceAttributedStringToContentEditable and adds
509         ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
510         text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
511         original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
512         debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
513         that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
514         other style attribute, such as color, carries over from the NSAttributedString to the DOM.
515
516         Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.
517
518         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
519         (TestWebKitAPI::TEST):
520
521 2017-08-18  Ryan Haddad  <ryanhaddad@apple.com>
522
523         Unreviewed, rolling out r220938.
524
525         The API tests added with this change are failing.
526
527         Reverted changeset:
528
529         "Add WTFLogChannel level to allow runtime log filtering"
530         https://bugs.webkit.org/show_bug.cgi?id=175731
531         http://trac.webkit.org/changeset/220938
532
533 2017-08-18  Devin Rousso  <webkit@devinrousso.com>
534
535         Unreviewed, change my email.
536
537         * Scripts/webkitpy/common/config/contributors.json:
538
539 2017-08-18  Jonathan Bedard  <jbedard@apple.com>
540
541         Fix leak-checking for iOS Simulators
542         https://bugs.webkit.org/show_bug.cgi?id=175735
543
544         Reviewed by Darin Adler.
545
546         If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
547         Simulator (or device) because the process will have already been killed by the time we
548         check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.
549
550         * Scripts/webkitpy/port/server_process.py:
551         (ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
552         (ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
553         and SimulatorProcess.
554         * Scripts/webkitpy/port/simulator_process.py:
555         (SimulatorProcess.stop): Before closing the process, check for leaks.
556
557 2017-08-18  Eric Carlson  <eric.carlson@apple.com>
558
559         Add WTFLogChannel level to allow runtime log filtering
560         https://bugs.webkit.org/show_bug.cgi?id=175731
561         <rdar://problem/33967234>
562
563         Reviewed by Jer Noble.
564
565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
566         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
567         (TestWebKitAPI::LoggingTest::output):
568         (TestWebKitAPI::TEST_F):
569
570 2017-08-18  Alexey Proskuryakov  <ap@apple.com>
571
572         Add Dean Johnson to contributors.json for Bugzilla autocomplete.
573
574         * Scripts/webkitpy/common/config/contributors.json:
575
576 2017-08-18  Ross Kirsling  <ross.kirsling@sony.com>
577
578         [Tools] Add script to download a GitHub release
579         https://bugs.webkit.org/show_bug.cgi?id=175279
580
581         Reviewed by Brent Fulgham.
582
583         * Scripts/download-latest-github-release.py: Added.
584
585 2017-08-18  Commit Queue  <commit-queue@webkit.org>
586
587         Unreviewed, rolling out r220854.
588         https://bugs.webkit.org/show_bug.cgi?id=175716
589
590         I'm not sure we really need this (Requested by KaL on
591         #webkit).
592
593         Reverted changeset:
594
595         "[GTK][WPE] Add NTLM authentication enabled API"
596         https://bugs.webkit.org/show_bug.cgi?id=122952
597         http://trac.webkit.org/changeset/220854
598
599 2017-08-17  Michael Catanzaro  <mcatanzaro@igalia.com>
600
601         [GTK] Make TestContextMenu work on Fedora
602         https://bugs.webkit.org/show_bug.cgi?id=175708
603
604         Reviewed by Carlos Garcia Campos.
605
606         TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
607         and my student last summer who was trying to work on a context menu API. It's trying to load
608         an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
609         entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
610         don't care to investigate. Let's switch it to WebM so I can move on.
611
612         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
613         (prepareContextMenuTestView):
614         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
615         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.
616
617 2017-08-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
618
619         check-webkit-style shouldn't check spacing in #elif preprocessor lines
620         https://bugs.webkit.org/show_bug.cgi?id=175652
621
622         Reviewed by Alex Christensen.
623
624         * Scripts/webkitpy/style/checkers/cpp.py:
625         (check_spacing):
626         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
627         (CppStyleTest.test_spacing_for_binary_ops):
628
629 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
630
631         Fix the build on other platforms after r220865
632         https://bugs.webkit.org/show_bug.cgi?id=175683
633
634         Reviewed by Tim Horton.
635
636         Check __IPHONE_OS_VERSION_MAX_ALLOWED instead of __IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
637         availability is determined by SDK version rather than deployment version.
638
639         * TestWebKitAPI/ios/UIKitSPI.h:
640
641 2017-08-17  Andreas Kling  <akling@apple.com>
642
643         Disable CSS regions at compile time
644         https://bugs.webkit.org/show_bug.cgi?id=175630
645
646         Reviewed by Antti Koivisto.
647
648         * Scripts/webkitperl/FeatureList.pm:
649         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
650
651 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
652
653         Unreviewed, try to fix the internal iOS 10 build after r220865.
654
655         * TestWebKitAPI/ios/UIKitSPI.h:
656
657         On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
658         extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
659         this compiler guard.
660
661 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
662
663         [iOS] Respect type fidelities when copying image elements to the pasteboard
664         https://bugs.webkit.org/show_bug.cgi?id=175638
665         <rdar://problem/26556043>
666
667         Reviewed by Ryosuke Niwa.
668
669         Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
670         contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
671         used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.
672
673         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
674         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
675         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
676         (TestWebKitAPI::TEST):
677         (TestWebKitAPI::presentActionSheetAndChooseAction):
678         (-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
679         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
680         (checkEstimatedSize):
681         (checkSuggestedNameAndEstimatedSize):
682
683         Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.
684
685         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
686         (TestWebKitAPI::TEST):
687         * TestWebKitAPI/ios/DataInteractionSimulator.h:
688         * TestWebKitAPI/ios/UIKitSPI.h: Added.
689
690 2017-08-17  Jonathan Bedard  <jbedard@apple.com>
691
692         Recursively create resource load statistics folder for testing
693         https://bugs.webkit.org/show_bug.cgi?id=175676
694
695         Reviewed by Brady Eidson.
696
697         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
698         (WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.
699
700 2017-08-17  Carlos Garcia Campos  <cgarcia@igalia.com>
701
702         [GTK][WPE] Add NTLM authentication enabled API
703         https://bugs.webkit.org/show_bug.cgi?id=122952
704
705         Reviewed by Michael Catanzaro.
706
707         Add a test case to check we can enable/disable NTLM.
708
709         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
710         (testWebViewAuthenticationNTLM):
711         (beforeAll):
712
713 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
714
715         [PAL] Move spi/ios and spi/win directories into PAL
716         https://bugs.webkit.org/show_bug.cgi?id=175171
717
718         Reviewed by Antti Koivisto.
719
720         * DumpRenderTree/mac/EventSendingController.mm:
721
722 2017-08-16  Andy Estes  <aestes@apple.com>
723
724         [Payment Request] Add an ENABLE flag and an experimental feature preference
725         https://bugs.webkit.org/show_bug.cgi?id=175622
726
727         Reviewed by Tim Horton.
728
729         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
730         * WebKitTestRunner/TestController.cpp:
731         (WTR::TestController::resetPreferencesToConsistentValues):
732
733 2017-08-15  Aakash Jain  <aakash_jain@apple.com>
734
735         undefined URL in PopoverTracker for failed step
736         https://bugs.webkit.org/show_bug.cgi?id=175593
737         <rdar://problem/33898769>
738
739         Reviewed by Daniel Bates.
740
741         This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
742         does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.
743
744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
745         (BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
746         (BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.
747         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
748         (BuildbotTestResults): Accept URL in constructor.
749
750 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
751
752         Remove Proximity Events and related code
753         https://bugs.webkit.org/show_bug.cgi?id=175545
754
755         Reviewed by Daniel Bates.
756
757         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
758         and other related code.
759
760         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
761
762 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
763
764         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
765         https://bugs.webkit.org/show_bug.cgi?id=175504
766
767         Reviewed by Sam Weinig.
768
769         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
770
771 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
772
773         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
774         https://bugs.webkit.org/show_bug.cgi?id=175557
775
776         Reviewed by Jon Lee.
777         
778         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
779
780         * DumpRenderTree/TestRunner.cpp:
781         (TestRunner::staticFunctions):
782         (setViewModeMediaFeatureCallback): Deleted.
783         * DumpRenderTree/TestRunner.h:
784         * DumpRenderTree/mac/TestRunnerMac.mm:
785         (TestRunner::setViewModeMediaFeature): Deleted.
786         * DumpRenderTree/win/TestRunnerWin.cpp:
787         (TestRunner::setViewModeMediaFeature): Deleted.
788         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
789
790 2017-08-14  Andy Estes  <aestes@apple.com>
791
792         REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
793         https://bugs.webkit.org/show_bug.cgi?id=175548
794         <rdar://problem/33866206>
795
796         Reviewed by Brady Eidson.
797
798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
799         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.
800         (TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().
801
802 2017-08-14  Youenn Fablet  <youenn@apple.com>
803
804         WPT server should be able to do logging even if its output folder is not created at launch time
805         https://bugs.webkit.org/show_bug.cgi?id=175543
806
807         Reviewed by Alexey Proskuryakov.
808
809         Removing no longer used stdout/stderr member variables.
810         Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.
811
812         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
813         (WebPlatformTestServer.__init__):
814         (WebPlatformTestServer._prepare_config):
815         (WebPlatformTestServer._spawn_process):
816         (WebPlatformTestServer._stop_running_server):
817
818 2017-08-14  Daniel Bates  <dabates@apple.com>
819
820         webkit-patch: Passing --no-review should submit patch to EWS by default
821         https://bugs.webkit.org/show_bug.cgi?id=148899
822
823         Reviewed by David Kilzer.
824
825         Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
826         the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
827         to these commands to not submit a non-reviewed patch(es) for EWS analysis.
828
829         Frequently I want to post a draft of a patch without review to have the EWS bots process
830         it to catch build and test breakage before I clean it up and post it for formal review.
831         Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
832         patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
833         We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.
834
835         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
836         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
837         parse the attachment id from the response page after adding an attachment to the bug.
838         (Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
839         HTTP response after uploading the patch.
840         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
841         (MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.
842         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
843         (test__parse_attachment_id_from_add_patch_to_bug_response): Added.
844         * Scripts/webkitpy/tool/commands/upload.py:
845         (Upload): Add step SubmitToEWS to the list of steps when uploading a patch. 
846         (PostCommits.__init__): Add --no-ews option to the list of applicable option flags for
847         this command.
848         (PostCommits.execute): Submit the patch to EWS, if applicable.
849         * Scripts/webkitpy/tool/commands/upload_unittest.py:
850         (test_upload): Set options.ews to False as the upload command expects this option
851         to be specified.
852         (test_upload_with_no_review_and_ews): Added.
853         * Scripts/webkitpy/tool/steps/__init__.py: Import module SubmitToEWS.
854         * Scripts/webkitpy/tool/steps/options.py:
855         (Options): Added command line option --no-ews (defaults: False - submit to EWS).
856         * Scripts/webkitpy/tool/steps/postdiff.py:
857         (PostDiff.options): Add --no-ews option to the list of applicable option flags for
858         this command.
859         (PostDiff.run): Submit the patch to EWS, if applicable.
860         * Scripts/webkitpy/tool/steps/submittoews.py: Added.
861         (SubmitToEWS):
862         (SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
863         (SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.
864
865 2017-08-14  Ryan Haddad  <ryanhaddad@apple.com>
866
867         Disable two flaky VideoControlsManager API tests.
868
869         Unreviewed test gardening.
870
871         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
872         (TestWebKitAPI::TEST):
873
874 2017-08-14  Tim Horton  <timothy_horton@apple.com>
875
876         Only create directory and sandbox extension handle for storage directories if they are set
877         https://bugs.webkit.org/show_bug.cgi?id=175522
878
879         Reviewed by Brady Eidson.
880
881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
882         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.
883         (TEST):
884         Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
885         doesn't log anything to stderr.
886
887 2017-08-14  Jonathan Bedard  <jbedard@apple.com>
888
889         sub-categorize Sandbox violation logs
890         https://bugs.webkit.org/show_bug.cgi?id=175536
891         <rdar://problem/33834416>
892
893         Reviewed by David Kilzer.
894
895         * Scripts/webkitpy/common/system/crashlogs.py:
896         (CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
897         a Sandbox violation.
898         (CrashLogs._find_all_logs_darwin): Update comment.
899         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
900         (make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing. 
901         (CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
902         (CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
903         (CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.
904         * Scripts/webkitpy/port/darwin.py:
905         (DarwinPort._merge_crash_logs): Handle Sandbox violation case.
906
907 2017-08-14  Daniel Bates  <dabates@apple.com>
908
909         Add Automator service to copy permalink to Clipboard
910         https://bugs.webkit.org/show_bug.cgi?id=170978
911
912         Reviewed by Joseph Pecoraro.
913
914         It is helpful to reference using a hyperlink a particular line of code when having
915         a discussion on IRC or in a bug. You can get such a link by navigating to the file
916         in the Trac Browse Source viewer and selecting the line your are interested in.
917         I found myself doing this often enough that I wrote an Automator service to do it
918         for me.
919
920         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
921
922         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
923         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
924         * CopyPermalink/README: Added.
925
926 2017-08-14  Chris Dumez  <cdumez@apple.com>
927
928         Address flakiness related to download tests
929         https://bugs.webkit.org/show_bug.cgi?id=175338
930         <rdar://problem/33865119>
931
932         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
933         between tests.
934
935         * WebKitTestRunner/TestController.cpp:
936         (WTR::TestController::resetStateToConsistentValues):
937
938 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
939
940         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
941         https://bugs.webkit.org/show_bug.cgi?id=175474
942         <rdar://problem/33844628>
943
944         Reviewed by Wenson Hsieh.
945
946         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
947
948         * DumpRenderTree/mac/DumpRenderTree.mm:
949         (resetWebPreferencesToConsistentValues):
950         * WebKitTestRunner/TestController.cpp:
951         (WTR::TestController::resetPreferencesToConsistentValues):
952
953 2017-08-12  Chris Dumez  <cdumez@apple.com>
954
955         Address flakiness related to download tests
956         https://bugs.webkit.org/show_bug.cgi?id=175338
957
958         Reviewed by Ryosuke Niwa.
959
960         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
961           is actually queried when a download completes. Previously, this would be
962           identical to a call to testRunner.waitUntilDone() because any download
963           completion would call testRunner.notifyDone().
964         - Disable logging of download callbacks by default and add a
965           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
966           enable such logging.
967
968         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
969         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
970         (WTR::InjectedBundle::didReceiveMessageToPage):
971         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
972         (WTR::TestRunner::setShouldLogDownloadCallbacks):
973         * WebKitTestRunner/InjectedBundle/TestRunner.h:
974         * WebKitTestRunner/TestController.cpp:
975         (WTR::TestController::downloadDidStart):
976         (WTR::TestController::decideDestinationWithSuggestedFilename):
977         (WTR::TestController::downloadDidFinish):
978         (WTR::TestController::downloadDidFail):
979         (WTR::TestController::downloadDidCancel):
980         * WebKitTestRunner/TestController.h:
981         (WTR::TestController::setShouldLogDownloadCallbacks):
982         * WebKitTestRunner/TestInvocation.cpp:
983         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
984
985 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
986
987         Create mock ITP data in testing to prevent grandfathering
988         https://bugs.webkit.org/show_bug.cgi?id=174720
989
990         Unreviewed follow-up fix for r220604.
991
992         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
993         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
994
995 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
996
997         Create mock ITP data in testing to prevent grandfathering
998         https://bugs.webkit.org/show_bug.cgi?id=174720
999         <rdar://problem/33457779>
1000
1001         Reviewed by Brent Fulgham.
1002
1003         We don't need to be triggering grandfathering when each test runner starts. On Mac,
1004         this may launch plugins which can cause layout tests to fail later if the test
1005         runner does not shut-down before the plugins unload.
1006
1007         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
1008         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1009         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
1010         prevent grandfathering from being triggered.
1011         * WebKitTestRunner/ios/TestControllerIOS.mm:
1012         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
1013         * WebKitTestRunner/mac/TestControllerMac.mm:
1014         (WTR::TestController::platformInitialize): Ditto.
1015
1016 2017-08-11  Sam Weinig  <sam@webkit.org>
1017
1018         WTF::Function does not allow for reference / non-default constructible return types
1019         https://bugs.webkit.org/show_bug.cgi?id=175244
1020         <rdar://problem/33801582>
1021
1022         Reviewed by Chris Dumez.
1023
1024         * TestWebKitAPI/Tests/WTF/Function.cpp:
1025         (TestWebKitAPI::TEST):
1026
1027 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1028
1029         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
1030         https://bugs.webkit.org/show_bug.cgi?id=175378
1031
1032         Reviewed by Sergio Villar Senin.
1033
1034         Add two test cases to check proxy authentication.
1035
1036         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1037         (Tunnel::Tunnel):
1038         (Tunnel::~Tunnel):
1039         (Tunnel::connect):
1040         (Tunnel::connected):
1041         (serverCallback):
1042         (ProxyAuthenticationTest::ProxyAuthenticationTest):
1043         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
1044         (ProxyAuthenticationTest::proxyServerPortAsString):
1045         (testWebViewAuthenticationProxy):
1046         (testWebViewAuthenticationProxyHTTPS):
1047         (beforeAll):
1048
1049 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1050
1051         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
1052         https://bugs.webkit.org/show_bug.cgi?id=175428
1053
1054         Both ports share the GStreamer code as multimedia backend and till
1055         not so long they were using different versions. Now they do use
1056         the same versions and it does not make any sense anymore (and
1057         neither had sense before) to have differences in the modulesets.
1058
1059         In this patch I created a GStreamer moduleset and referenced it
1060         from both GTK+'s and WPE's. GStreamer patches were also moved there.
1061
1062         Reviewed by Žan Doberšek.
1063
1064         * gstreamer/jhbuild.modules: Added.
1065         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
1066         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
1067         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
1068         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
1069         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
1070         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
1071         * gtk/jhbuild.modules:
1072         * wpe/jhbuild.modules:
1073         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
1074         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
1075         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1076         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1077         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
1078
1079 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
1080
1081         Unreviewed, adding Ross Kirsling to contributors.json
1082
1083         * Scripts/webkitpy/common/config/contributors.json:
1084
1085 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
1086
1087         Unreviewed, attempt to fix build failure with VC2017
1088
1089         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1090         (TEST):
1091
1092 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
1093
1094         Unreviewed, suppress warnings on GCC
1095
1096         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1097         (TestWebKitAPI::CheckedArithmeticTester::run):
1098
1099 2017-08-10  Dan Bernstein  <mitz@apple.com>
1100
1101         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
1102         https://bugs.webkit.org/show_bug.cgi?id=173223
1103
1104         Reviewed by Tim Horton.
1105
1106         The rebuilds were happening due to a difference in the compiler options that the IDE and
1107         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
1108         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
1109         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
1110         Advanced when a Custom Absolute path is selected.
1111
1112         * Scripts/webkitdirs.pm:
1113         (determineBaseProductDir):
1114
1115 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
1116
1117         Run more WTF tests
1118         https://bugs.webkit.org/show_bug.cgi?id=174970
1119
1120         Reviewed by Michael Catanzaro.
1121
1122         Some of WTF tests are not executed in non Apple ports while they are generic ones.
1123         This patch adds these tests to non-Apple port TestWebKitAPI.
1124         Currently, we do not add Signals.cpp since it depends on signal functionality.
1125
1126         * TestWebKitAPI/CMakeLists.txt:
1127         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1128         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1129         (isHigherPriority):
1130         (TEST):
1131         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
1132         (TEST):
1133         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1134         (TEST):
1135
1136 2017-08-10  obinna obike  <oobike@apple.com>
1137
1138         Remove obsolete link from webkit-queues status page
1139         https://bugs.webkit.org/show_bug.cgi?id=175337
1140
1141         Reviewed by Aakash Jain.
1142
1143         * QueueStatusServer/templates/recentstatus.html:
1144         Removed the link to the ews-watcher server.
1145
1146 2017-08-10  Brian Burg  <bburg@apple.com>
1147
1148         WKPreferences should conform to NSCopying
1149         https://bugs.webkit.org/show_bug.cgi?id=175303
1150         <rdar://problem/33764939>
1151
1152         Reviewed by Dan Bernstein.
1153
1154         Add unit test to make sure a WKPreference and its copy are
1155         not aliased to each other or affect each other's properties.
1156
1157         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1158         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
1159         (TEST):
1160
1161 2017-08-10  Tim Horton  <timothy_horton@apple.com>
1162
1163         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
1164         https://bugs.webkit.org/show_bug.cgi?id=175436
1165         <rdar://problem/33667497>
1166
1167         Reviewed by Simon Fraser.
1168
1169         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1170         (TestWebKitAPI::TEST_F):
1171
1172 2017-08-10  Lucas Forschler  <lforschler@apple.com>
1173
1174         Fix duplicated code in r220534.
1175
1176         Unreviewed cleanup.
1177
1178         * Scripts/bisect-builds:
1179
1180 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
1181
1182         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
1183         https://bugs.webkit.org/show_bug.cgi?id=175344
1184         <rdar://problem/28507240>
1185
1186         Reviewed by Alexey Proskuryakov.
1187
1188         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
1189         Finally enable the existing tests for iOS.
1190
1191         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
1192         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1194         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
1195
1196 2017-08-10  Lucas Forschler  <lforschler@apple.com>
1197
1198         Write a tool to bisect WebKit builds
1199         https://bugs.webkit.org/show_bug.cgi?id=174596
1200
1201         Reviewed by Dean Johnson and Kocsen Chung.
1202
1203         * Scripts/bisect-builds: Added.
1204         (bisect_builds): main bisection algorithm
1205         (download_archive):download an archive from S3 using existing tools
1206         (extract_archive):extract an archive using existing tools
1207         (find_le):Find rightmost value less than or equal to x
1208         (find_ge):Find leftmost item greater than or equal to x
1209         (get_api_url):generate url for the rest api/database
1210         (get_indices_from_revisions):convert revisions to list indexes for bisection
1211         (get_sorted_revisions):retrieve sorted revision list
1212         (get_s3_location_for_revision):calculate the S3 archive storage location
1213         (parse_args):parse command line arguments
1214         (pick_next_build):compute the next build to bisect
1215         (prompt_did_reproduce):prompt user for direction for bisection
1216         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
1217         (test_archive):Platform specific logic to test downloaded archive
1218         (minified_platforms):return a list of minified platforms in the database
1219         (unminified_platforms):return a list of full platforms in the database
1220         (is_supported_platform):check if platform is supported
1221         (validate_options):validate command line options
1222         (main):
1223
1224 2017-08-10  Lucas Forschler  <lforschler@apple.com>
1225
1226         Remove bisect-builds script.
1227         https://bugs.webkit.org/show_bug.cgi?id=175433
1228         
1229         Reviewed by Aakash Jain.
1230
1231         * Scripts/bisect-builds: Removed.
1232
1233 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1234
1235         Remove ENABLE_GAMEPAD_DEPRECATED
1236         https://bugs.webkit.org/show_bug.cgi?id=175361
1237
1238         Reviewed by Carlos Garcia Campos.
1239
1240         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1241
1242 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1243
1244         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
1245         https://bugs.webkit.org/show_bug.cgi?id=175426
1246
1247         Reviewed by Carlos Garcia Campos.
1248
1249         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
1250
1251 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
1252
1253         Add Ms2ger as contributor.
1254         https://bugs.webkit.org/show_bug.cgi?id=175325
1255
1256         Reviewed by Carlos Alberto Lopez Perez.
1257
1258         * Scripts/webkitpy/common/config/contributors.json:
1259
1260 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
1261
1262         Fix run-benchmark after r220483.
1263         https://bugs.webkit.org/show_bug.cgi?id=175415
1264         <rdar://problem/33803003>
1265
1266         Reviewed by Ryosuke Niwa.
1267
1268         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
1269
1270         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
1271         (WebServerBenchmarkRunner._run_one_test):
1272
1273 2017-08-09  Chris Dumez  <cdumez@apple.com>
1274
1275         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
1276         https://bugs.webkit.org/show_bug.cgi?id=175401
1277
1278         Reviewed by Brady Eidson.
1279
1280         * DumpRenderTree/mac/DumpRenderTree.mm:
1281         (enableExperimentalFeatures):
1282
1283 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1284
1285         [PAL] Move spi/cocoa and spi/cg directories into PAL
1286         https://bugs.webkit.org/show_bug.cgi?id=175175
1287
1288         Reviewed by Myles C. Maxfield.
1289
1290         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1291         * DumpRenderTree/mac/DumpRenderTree.mm:
1292         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
1293         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1294
1295         * Scripts/webkitpy/style/checker.py:
1296         * Scripts/webkitpy/style/checker_unittest.py:
1297         (GlobalVariablesTest.test_path_rules_specifier):
1298
1299         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
1300
1301         * Scripts/webkitpy/style/checkers/cpp.py:
1302         (check_braces):
1303         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1304         (WebKitStyleTest.test_braces.CF_OPTIONS):
1305         (WebKitStyleTest.test_braces):
1306
1307         Prevent CF_OPTIONS() from being handled as funtion definition.
1308
1309 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
1310
1311         [WTF] Move TextStream into WTF
1312         https://bugs.webkit.org/show_bug.cgi?id=175211
1313
1314         Reviewed by Myles C. Maxfield.
1315
1316         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1317
1318 2017-08-09  Andy Estes  <aestes@apple.com>
1319
1320         Part 3 of: Rename DatabaseProcess to StorageProcess
1321         https://bugs.webkit.org/show_bug.cgi?id=175034
1322
1323         Reviewed by Brady Eidson.
1324
1325         * WebKitTestRunner/TestController.cpp:
1326         (WTR::TestController::databaseProcessName): Updated to return
1327         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
1328
1329 2017-08-09  Commit Queue  <commit-queue@webkit.org>
1330
1331         Unreviewed, rolling out r220466, r220477, and r220487.
1332         https://bugs.webkit.org/show_bug.cgi?id=175411
1333
1334         This change broke existing API tests and follow up fixes did
1335         not resolve all the issues. (Requested by ryanhaddad on
1336         #webkit).
1337
1338         Reverted changesets:
1339
1340         https://bugs.webkit.org/show_bug.cgi?id=175244
1341         http://trac.webkit.org/changeset/220466
1342
1343         "WTF::Function does not allow for reference / non-default
1344         constructible return types"
1345         https://bugs.webkit.org/show_bug.cgi?id=175244
1346         http://trac.webkit.org/changeset/220477
1347
1348         https://bugs.webkit.org/show_bug.cgi?id=175244
1349         http://trac.webkit.org/changeset/220487
1350
1351 2017-08-09  Sam Weinig  <sam@webkit.org>
1352
1353         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
1354
1355         Remove one addition of null Function test.
1356
1357 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
1358
1359         Allow nested timeouts in webkitpy
1360         https://bugs.webkit.org/show_bug.cgi?id=175390
1361         <rdar://problem/33803003>
1362
1363         Reviewed by David Kilzer.
1364
1365         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
1366         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
1367         the executive to detect and recover from any issues connecting with devices.
1368
1369         * Scripts/webkitpy/benchmark_runner/utils.py:
1370         (TimeoutError): Deleted.
1371         (timeout): Deleted.
1372         * Scripts/webkitpy/common/timeout_context.py: Added.
1373         (Timeout): A timeout context designed to be nested.
1374         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
1375         (Timeout.TimeoutData.__init__):
1376         (Timeout.default_handler): Timeout handler used if none is specified.
1377         (Timeout.current): Access data about the most urgent timeout.
1378         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
1379         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
1380         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
1381         urgent timeout data.
1382         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
1383         most urgent timeout data, if such data exists.
1384         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
1385         (TimeoutContextTests):
1386         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
1387         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
1388         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
1389         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
1390         over a less urgent outer timeout.
1391         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
1392         over a less urgent inner timeout.
1393         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
1394         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
1395         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
1396         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
1397         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
1398         * Scripts/webkitpy/port/simulator_process.py:
1399         (SimulatorProcess._start): Use Timeout class.
1400         * Scripts/webkitpy/xcode/simulated_device.py:
1401         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
1402         (SimulatedDevice.launch_app): Ditto.
1403         (SimulatedDevice.launch_app._install_timeout): Deleted.
1404         * Scripts/webkitpy/xcode/simulator.py:
1405         (Simulator.wait_until_device_is_booted):Use Timeout class.
1406         (Simulator.wait_until_device_is_in_state): Ditto.
1407
1408 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1409
1410         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
1411         https://bugs.webkit.org/show_bug.cgi?id=175392
1412         <rdar://problem/33783207>
1413
1414         Reviewed by Tim Horton and Megan Gardner.
1415
1416         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
1417
1418         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1419
1420 2017-08-09  Sam Weinig  <sam@webkit.org>
1421
1422         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
1423
1424         * TestWebKitAPI/Tests/WTF/Function.cpp:
1425         Remove tests of null Functions, as they are no longer supported.
1426
1427 2017-08-09  Daniel Bates  <dabates@apple.com>
1428
1429         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
1430         https://bugs.webkit.org/show_bug.cgi?id=175247
1431         <rdar://problem/33679804>
1432
1433         Reviewed by Brady Eidson.
1434
1435         Add tests for redirects.
1436
1437         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1438         (TEST):
1439         * TestWebKitAPI/cocoa/TestProtocol.mm:
1440         (createRedirectURL):
1441         (-[TestProtocol startLoading]):
1442
1443 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1444
1445         Unreviewed, rolling out r220393.
1446
1447         This patch regresses the performance of WebPage::editorState.
1448
1449         Reverted changeset:
1450
1451         "[iOS WK2] WKWebView schedules nonstop layout after pressing
1452         cmb+b,i,u inside a contenteditable div"
1453         https://bugs.webkit.org/show_bug.cgi?id=175116
1454         http://trac.webkit.org/changeset/220393
1455
1456 2017-08-08  obinna obike  <oobike@apple.com>
1457
1458         Created Individual EWS Pages
1459         https://bugs.webkit.org/show_bug.cgi?id=174477
1460
1461         Reviewed by Aakash Jain.
1462
1463         Created individual pages for each EWS. Changed the link within each status bubble
1464         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
1465
1466         * QueueStatusServer/handlers/patch.py:
1467         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
1468         * QueueStatusServer/handlers/statusbubble.py:
1469         (StatusBubble._build_bubble): Updated url for specific EWS.
1470         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
1471         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
1472         all ews queues.
1473         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
1474         takes you directly to the individual ews page.
1475
1476 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
1477
1478         Separate jsc stress test script writer from run-jsc-stress-tests
1479         https://bugs.webkit.org/show_bug.cgi?id=175216
1480
1481         Reviewed by Mark Lam.
1482
1483         * Scripts/run-jsc-stress-tests:
1484         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
1485
1486 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1487
1488         Unreviewed, fix Ubuntu LTS build
1489         https://bugs.webkit.org/show_bug.cgi?id=174490
1490
1491         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1492
1493 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1494
1495         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
1496         https://bugs.webkit.org/show_bug.cgi?id=175302
1497         <rdar://problem/33762116>
1498
1499         Reviewed by Tim Horton.
1500
1501         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
1502         See WebKit ChangeLog for more details.
1503
1504         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1505         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
1506         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
1507         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
1508         (-[SlowTextInputContext handleEvent:completionHandler:]):
1509         (-[SlowInputWebView inputContext]):
1510         (-[SlowInputWebView _web_superInputContext]):
1511         (TEST):
1512
1513 2017-08-08  John Wilander  <wilander@apple.com>
1514
1515         Resource Load Statistics: Clear web processes' state on history removal
1516         https://bugs.webkit.org/show_bug.cgi?id=175271
1517         <rdar://problem/33756560>
1518
1519         Reviewed by Chris Dumez.
1520
1521         Test infrastructure for asynchronous tests of website data
1522         removal for _WKWebsiteDataTypeResourceLoadStatistics.
1523
1524         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1525         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1526         (WTR::InjectedBundle::didReceiveMessageToPage):
1527         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1528         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1529         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
1530         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1531         * WebKitTestRunner/TestController.cpp:
1532         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1533         * WebKitTestRunner/TestController.h:
1534         * WebKitTestRunner/TestInvocation.cpp:
1535         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1536         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
1537         * WebKitTestRunner/TestInvocation.h:
1538         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1539         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1540
1541 2017-08-08  Alicia Boya García  <aboya@igalia.com>
1542
1543         Add Alicia Boya García as contributor
1544         https://bugs.webkit.org/show_bug.cgi?id=175326
1545
1546         Reviewed by Michael Catanzaro.
1547
1548         * Scripts/webkitpy/common/config/contributors.json:
1549
1550 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1551
1552         [CMake] Properly test if compiler supports compiler flags
1553         https://bugs.webkit.org/show_bug.cgi?id=174490
1554
1555         Reviewed by Konstantin Tokarev.
1556
1557         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1558         * MiniBrowser/gtk/CMakeLists.txt:
1559         * TestRunnerShared/Bindings/JSWrapper.cpp:
1560         (WTR::JSWrapper::initialize):
1561         * TestWebKitAPI/CMakeLists.txt:
1562         * TestWebKitAPI/PlatformGTK.cmake:
1563         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1564         (TestWebKitAPI::CheckedArithmeticTester::run):
1565         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1566         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1567         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1568         (formControlsAssociatedCallback):
1569         * TestWebKitAPI/glib/CMakeLists.txt:
1570         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1571         (Test::getResourcesDir):
1572         * WebKitTestRunner/CMakeLists.txt:
1573         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1574         (WTR::menuItemClickCallback):
1575         (WTR::staticConvertMenuItemToType):
1576         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1577         (WTR::TestRunner::setUseDashboardCompatibilityMode):
1578         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1579         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1580         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1581         (WTR::AccessibilityUIElement::helpText const):
1582         (WTR::AccessibilityUIElement::attributedStringForRange):
1583         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1584         (WTR::EventSenderProxy::updateTouchPoint):
1585         (WTR::EventSenderProxy::releaseTouchPoint):
1586
1587 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1588
1589         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
1590         https://bugs.webkit.org/show_bug.cgi?id=175116
1591         <rdar://problem/28279301>
1592
1593         Reviewed by Darin Adler and Ryosuke Niwa.
1594
1595         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
1596         EditorStateTests run on both iOS and Mac.
1597
1598         * TestWebKitAPI/EditingTestHarness.h: Added.
1599         * TestWebKitAPI/EditingTestHarness.mm: Added.
1600
1601         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
1602         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
1603         the state of the latest observed EditorState.
1604
1605         (-[EditingTestHarness initWithWebView:]):
1606         (-[EditingTestHarness dealloc]):
1607         (-[EditingTestHarness webView]):
1608         (-[EditingTestHarness latestEditorState]):
1609         (-[EditingTestHarness editorStateHistory]):
1610         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
1611         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
1612         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
1613         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
1614         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
1615         (-[EditingTestHarness toggleBold]):
1616         (-[EditingTestHarness toggleItalic]):
1617         (-[EditingTestHarness toggleUnderline]):
1618         (-[EditingTestHarness setForegroundColor:]):
1619         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
1620         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
1621         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
1622         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
1623         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
1624         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
1625         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
1626
1627         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
1628         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
1629         keys and values.
1630
1631         (-[EditingTestHarness latestEditorStateContains:]):
1632         (-[EditingTestHarness _webView:editorStateDidChange:]):
1633         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1634         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
1635         (TestWebKitAPI::setUpEditorStateTestHarness):
1636         (TestWebKitAPI::TEST):
1637         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
1638
1639 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
1640
1641         Prevent domain from being set to a TLD
1642         https://bugs.webkit.org/show_bug.cgi?id=175226
1643         <rdar://problem/11079948>
1644
1645         Reviewed by Chris Dumez.
1646
1647         Extend the public suffix tests to include cases used by the
1648         Public Domain 'Public Suffix List'.
1649
1650         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
1651         (TestWebKitAPI::TEST):
1652
1653 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
1654
1655         [XCode] webkit-patch should run sort-Xcode-project-file
1656         https://bugs.webkit.org/show_bug.cgi?id=174036
1657         <rdar://problem/33732709>
1658
1659         Reviewed by Simon Fraser.
1660
1661         * Scripts/webkitpy/common/config/ports.py:
1662         * Scripts/webkitpy/tool/commands/download.py:
1663         * Scripts/webkitpy/tool/commands/download_unittest.py:
1664         * Scripts/webkitpy/tool/commands/upload.py:
1665         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1666         * Scripts/webkitpy/tool/steps/__init__.py:
1667         * Scripts/webkitpy/tool/steps/options.py:
1668         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1669
1670 2017-08-07  Devin Rousso  <drousso@apple.com>
1671
1672         Web Inspector: Preview Canvas path when viewing a recording
1673         https://bugs.webkit.org/show_bug.cgi?id=174967
1674
1675         Reviewed by Brian Burg.
1676
1677         * DumpRenderTree/TestOptions.h:
1678         * DumpRenderTree/TestOptions.mm:
1679         (TestOptions::TestOptions):
1680         * DumpRenderTree/mac/DumpRenderTree.mm:
1681         (setWebPreferencesForTestOptions):
1682         * WebKitTestRunner/TestController.cpp:
1683         (WTR::TestController::resetPreferencesToConsistentValues):
1684         (WTR::updateTestOptionsFromTestHeader):
1685         * WebKitTestRunner/TestOptions.h:
1686         (WTR::TestOptions::hasSameInitializationOptions const):
1687         Add plumbing for new InspectorAdditions runtime flag.
1688
1689 2017-08-07  obinna obike  <oobike@apple.com>
1690
1691         Sorted EWS Queues on Patch page
1692         https://bugs.webkit.org/show_bug.cgi?id=173667
1693
1694         Reviewed by Aakash Jain.
1695
1696         * QueueStatusServer/handlers/patch.py:
1697         (Patch.get): Sorted queue_status.
1698         * QueueStatusServer/templates/patch.html:
1699         Changed queue_status.items to queue_status because it's a list.
1700
1701 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1702
1703         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
1704         https://bugs.webkit.org/show_bug.cgi?id=175286
1705
1706         Reviewed by Myles C. Maxfield.
1707
1708         * Scripts/webkitpy/style/checkers/cpp.py:
1709         (check_braces):
1710         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1711         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
1712         (WebKitStyleTest.test_braces):
1713         (WebKitStyleTest.test_braces.NS_OPTIONS):
1714
1715 2017-08-07  Brian Burg  <bburg@apple.com>
1716
1717         Remove CANVAS_PATH compilation guard
1718         https://bugs.webkit.org/show_bug.cgi?id=175207
1719
1720         Reviewed by Sam Weinig.
1721
1722         * Scripts/webkitperl/FeatureList.pm:
1723         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1724
1725 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
1726
1727         [Win] Use Visual Studio 2017 if installed.
1728         https://bugs.webkit.org/show_bug.cgi?id=175188
1729
1730         Reviewed by Sam Weinig.
1731
1732         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
1733
1734         * Scripts/webkitdirs.pm:
1735         (visualStudioInstallDir):
1736         (msBuildInstallDir):
1737
1738 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1739
1740         [GTK][WPE] Add API to provide browser information required by automation
1741         https://bugs.webkit.org/show_bug.cgi?id=175130
1742
1743         Reviewed by Michael Catanzaro.
1744
1745         * MiniBrowser/gtk/main.c:
1746         (automationStartedCallback): Set browser information when a new automation session is started.
1747         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1748         (testAutomationSessionApplicationInfo):
1749         (beforeAll):
1750
1751 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
1752
1753         Unreviewed, rolling out r220295.
1754
1755         This change introduced 4 errors in webkitpy tests.
1756
1757         Reverted changeset:
1758
1759         "[XCode] webkit-patch should run sort-Xcode-project-file"
1760         https://bugs.webkit.org/show_bug.cgi?id=174036
1761         http://trac.webkit.org/changeset/220295
1762
1763 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1764
1765         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
1766
1767         Unreviewed test gardening.
1768
1769         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1770         (TestWebKitAPI::TEST):
1771
1772 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
1773
1774         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
1775         https://bugs.webkit.org/show_bug.cgi?id=175083
1776
1777         Reviewed by Oliver Hunt.
1778         
1779         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
1780         to wait for VM destructions to finish before running the next test. This makes it easier to 
1781         understand leaks results from workers tests, and leads to fewer reported leaks.
1782
1783         * DumpRenderTree/mac/DumpRenderTree.mm:
1784         (runTest):
1785
1786 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1787
1788         check-webkit-style: fix path-specific rules for WebKit2 rename
1789         https://bugs.webkit.org/show_bug.cgi?id=175182
1790
1791         Reviewed by David Kilzer.
1792
1793         * Scripts/webkitpy/style/checker.py:
1794
1795 2017-08-04  Youenn Fablet  <youenn@apple.com>
1796
1797         [Cache API] Add Cache and CacheStorage IDL definitions
1798         https://bugs.webkit.org/show_bug.cgi?id=175201
1799
1800         Reviewed by Brady Eidson.
1801
1802         * DumpRenderTree/mac/DumpRenderTree.mm:
1803         (enableExperimentalFeatures):
1804         (resetWebPreferencesToConsistentValues):
1805         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1806         (WTR::InjectedBundle::beginTesting):
1807         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1808         (WTR::TestRunner::setCacheAPIEnabled):
1809         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1810
1811 2017-08-04  John Wilander  <wilander@apple.com>
1812
1813         Resource Load Statistics: Report user interaction immediately, but only when needed
1814         https://bugs.webkit.org/show_bug.cgi?id=175090
1815         <rdar://problem/33685546>
1816
1817         Reviewed by Chris Dumez.
1818
1819         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1820         (WTR::InjectedBundle::beginTesting):
1821             Now calls WebCore::ResourceLoadObserver::clearState().
1822
1823 2017-08-04  Tim Horton  <timothy_horton@apple.com>
1824
1825         Add an API test for r220286
1826         https://bugs.webkit.org/show_bug.cgi?id=175206
1827
1828         Reviewed by Simon Fraser.
1829
1830         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1831         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
1832         (createAnimatedResizeWebView):
1833         (TEST):
1834         Add a test to ensure that we don't call
1835         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
1836         animated resize.
1837
1838 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
1839
1840         [XCode] webkit-patch should run sort-Xcode-project-file
1841         https://bugs.webkit.org/show_bug.cgi?id=174036
1842
1843         Reviewed by Simon Fraser.
1844
1845         * Scripts/webkitpy/common/config/ports.py:
1846         * Scripts/webkitpy/tool/commands/download.py:
1847         * Scripts/webkitpy/tool/commands/upload.py:
1848         * Scripts/webkitpy/tool/steps/__init__.py:
1849         * Scripts/webkitpy/tool/steps/options.py:
1850         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1851
1852 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1853
1854         REGRESSION(r219857): run-benchmark --allplans broken
1855         https://bugs.webkit.org/show_bug.cgi?id=175186
1856
1857         Reviewed by Saam Barati.
1858
1859         r219857 forgot to update also the calls to BenchmarkRunner() that
1860         is done when the script is run with --allplans.
1861
1862         To fix this (and avoid future issues like this), let's factorize
1863         the calls to the benchhmark runner in a run_benchmark_plan()
1864         function.
1865
1866         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1867         (run_benchmark_plan):
1868         (start):
1869
1870 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
1871
1872         Dashboard bubbles sometimes show failure count instead of crash count
1873         https://bugs.webkit.org/show_bug.cgi?id=175157
1874         <rdar://problem/33709009>
1875
1876         Reviewed by Alexey Proskuryakov.
1877
1878         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1879         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
1880
1881 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
1882
1883         Add tests for NeverDestroyed
1884         https://bugs.webkit.org/show_bug.cgi?id=175146
1885
1886         Reviewed by Darin Adler.
1887
1888         * CMakeLists.txt:
1889         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1890         New files and sort.
1891
1892         * TestWebKitAPI/Tests/WTF/Logger.h:
1893         * TestWebKitAPI/Tests/WTF/Logger.cpp:
1894         (TestWebKitAPI::log):
1895         (TestWebKitAPI::takeLogStr):
1896         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1897         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
1898         (TestWebKitAPI::log): Deleted.
1899         (TestWebKitAPI::takeLogStr): Deleted.
1900         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
1901
1902         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
1903         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
1904         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
1905         (TestWebKitAPI::LifecycleLogger::operator=):
1906         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
1907         (TestWebKitAPI::LifecycleLogger::setName):
1908         (TestWebKitAPI::TEST):
1909         Add a class that logs construction / assignment / modifications.
1910
1911         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
1912         (TestWebKitAPI::TEST):
1913         (TestWebKitAPI::list):
1914         Test construction behavior is as expected both directly and using makeNeverDestroyed.
1915
1916 2017-08-04  Lucas Forschler  <lforschler@apple.com>
1917
1918         minification logic is not implemented for ios builds
1919         <rdar://problem/33726561>
1920
1921         Reviewed by Dean Johnson
1922
1923         * BuildSlaveSupport/built-product-archive:
1924         (minifyDirectory): refactor minifySource -> minifyDirectory
1925         (archiveBuiltProduct): add ios minification logic
1926         (minifySource): Deleted.
1927
1928 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1929
1930         Unreviewed, rolling out r220271.
1931
1932         Rolling out due to Layout Test failing on iOS Simulator.
1933
1934         Reverted changeset:
1935
1936         "Remove STREAMS_API compilation guard"
1937         https://bugs.webkit.org/show_bug.cgi?id=175165
1938         http://trac.webkit.org/changeset/220271
1939
1940 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1941
1942         Unreviewed, rolling out r220268.
1943
1944         This change caused assertion failures on macOS and iOS Debug
1945         WK2.
1946
1947         Reverted changeset:
1948
1949         "Resource Load Statistics: Report user interaction
1950         immediately, but only when needed"
1951         https://bugs.webkit.org/show_bug.cgi?id=175090
1952         http://trac.webkit.org/changeset/220268
1953
1954 2017-08-04  Youenn Fablet  <youenn@apple.com>
1955
1956         Remove STREAMS_API compilation guard
1957         https://bugs.webkit.org/show_bug.cgi?id=175165
1958
1959         Reviewed by Darin Adler.
1960
1961         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1962
1963 2017-08-04  John Wilander  <wilander@apple.com>
1964
1965         Resource Load Statistics: Report user interaction immediately, but only when needed
1966         https://bugs.webkit.org/show_bug.cgi?id=175090
1967         <rdar://problem/33685546>
1968
1969         Reviewed by Chris Dumez.
1970
1971         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1972         (WTR::InjectedBundle::beginTesting):
1973             Now calls WebCore::ResourceLoadObserver::clearState().
1974
1975 2017-08-03  Brian Burg  <bburg@apple.com>
1976
1977         Remove ENABLE(WEB_SOCKET) guards
1978         https://bugs.webkit.org/show_bug.cgi?id=167044
1979
1980         Reviewed by Joseph Pecoraro.
1981
1982         * Scripts/webkitperl/FeatureList.pm:
1983         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1984
1985 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1986
1987         REGRESSION(r219850): run-benchmark script broken on Linux
1988         https://bugs.webkit.org/show_bug.cgi?id=175126
1989
1990         Reviewed by Stephanie Lewis.
1991
1992         The run-benchmark script dynamically generates the list of supported
1993         browsers and platforms (currently Linux and OSX) by loading all
1994         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
1995         and getting the browser_name and platform variables from the
1996         classes defined there.
1997
1998         This means that this classes should not raise an exception when
1999         loaded on other platforms or otherwise they will broke the whole
2000         script. Its fine if they raise an exception when executing any of
2001         the methods they implement, but not when just loading/importing
2002         the class.
2003
2004         Move the argument variable definitions that call on the platform
2005         specific OSXBrowserDriver._screen_size() function from beeing
2006         variables that are evaluated when loading the file, to be functions
2007         that are only evaluated when the actual functionality needs to be
2008         executed.
2009
2010         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2011         (OSXChromeDriver.launch_url):
2012         (OSXChromeCanaryDriver.launch_url):
2013         (create_args):
2014         (create_chrome_options):
2015         (create_window_size_arg):
2016         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2017         (OSXFirefoxDriver.launch_url):
2018         (OSXFirefoxNightlyDriver.launch_url):
2019         (OSXFirefoxNightlyDriver.launch_driver):
2020         (create_args):
2021
2022 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
2023
2024         [PAL] Move spi/cf directory into PAL
2025         https://bugs.webkit.org/show_bug.cgi?id=175057
2026
2027         Reviewed by Antti Koivisto.
2028
2029         * Scripts/webkitpy/style/checker.py:
2030         * Scripts/webkitpy/style/checker_unittest.py:
2031         (GlobalVariablesTest.test_path_rules_specifier):
2032
2033         Ignore "readability/naming/underscores" style errors for sources
2034         under the WebCore/PAL/pal/spi directory.
2035
2036         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
2037
2038 2017-08-03  Youenn Fablet  <youenn@apple.com>
2039
2040         Remove FETCH_API compilation guard
2041         https://bugs.webkit.org/show_bug.cgi?id=175154
2042
2043         Reviewed by Chris Dumez.
2044
2045         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2046
2047 2017-08-03  Lucas Forschler  <lforschler@apple.com>
2048
2049         Enable archive minification on iOS builds
2050         https://bugs.webkit.org/show_bug.cgi?id=174718
2051         
2052         Reviewed by Aakash Jain.
2053
2054         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2055         (BuildFactory.__init__):
2056
2057 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2058
2059         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
2060         https://bugs.webkit.org/show_bug.cgi?id=175140
2061
2062         Reviewed by Alexey Proskuryakov.
2063
2064         We are having lately issues with JSC tests causing problems on
2065         the GTK+ and WPE bots due to the high amount of memory some tests
2066         need to run.
2067
2068         The best thing we can do now is to workaround this by disabling
2069         all the tests marked as memoryLimited on the GTK and WPE bots.
2070         We may revise this on the future.
2071
2072         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2073         (RunJavaScriptCoreTests.start):
2074
2075 2017-08-03  Brady Eidson  <beidson@apple.com>
2076
2077         Add SW IDLs and stub out basic functionality.
2078         https://bugs.webkit.org/show_bug.cgi?id=175115
2079
2080         Reviewed by Chris Dumez.
2081
2082         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2083
2084         * Scripts/webkitpy/bindings/main.py:
2085
2086 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
2087
2088         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
2089         https://bugs.webkit.org/show_bug.cgi?id=159510
2090
2091         Reviewed by Daniel Bates.
2092
2093         Allow any https certificate when running tests.
2094
2095         * DumpRenderTree/win/DumpRenderTree.cpp:
2096         (runTest):
2097
2098 2017-08-02  Youenn Fablet  <youenn@apple.com>
2099
2100         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
2101         https://bugs.webkit.org/show_bug.cgi?id=175089
2102
2103         Reviewed by Chris Dumez.
2104
2105         * DumpRenderTree/TestOptions.mm:
2106         (TestOptions::TestOptions): Using absolutePath if available.
2107         * DumpRenderTree/mac/DumpRenderTree.mm:
2108         (computeTestURL): Removing http/tests/ specific URL computation.
2109         * Scripts/webkitpy/port/driver.py:
2110         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
2111
2112 2017-08-02  Lucas Forschler  <lforschler@apple.com>
2113
2114         download-built-product should allow for a proxy option
2115         https://bugs.webkit.org/show_bug.cgi?id=174875
2116
2117         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
2118
2119         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2120         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
2121         
2122
2123 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
2124
2125         check-webkit-style: deleting lines in a file runs the linter on the whole file
2126         https://bugs.webkit.org/show_bug.cgi?id=175078
2127
2128         Reviewed by David Kilzer.
2129
2130         Deleting lines in a file should not cause linter errors to be blamed on the patch.
2131         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
2132
2133         * Scripts/webkitpy/style/checkers/test_expectations.py:
2134         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
2135         * Scripts/webkitpy/style/main_unittest.py:
2136         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
2137         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
2138         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
2139
2140 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
2141
2142         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
2143         https://bugs.webkit.org/show_bug.cgi?id=175075
2144
2145         Reviewed by David Kilzer.
2146
2147         We have no way of handling text files with illegal unicode characters. Allow the callers of
2148         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
2149         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
2150
2151         * Scripts/webkitpy/common/system/filesystem.py:
2152         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
2153         (FileSystem.write_text_file): Ditto.
2154         * Scripts/webkitpy/common/system/filesystem_mock.py:
2155         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
2156         (MockFileSystem.write_text_file): Ditto.
2157         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2158         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
2159         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
2160
2161 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
2162
2163         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
2164         https://bugs.webkit.org/show_bug.cgi?id=175072
2165
2166         Reviewed by Alexey Proskuryakov.
2167
2168         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2169         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
2170
2171 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2172
2173         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
2174         https://bugs.webkit.org/show_bug.cgi?id=175019
2175
2176         Reviewed by Darin Adler.
2177
2178         * TestWebKitAPI/CMakeLists.txt:
2179
2180 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
2181
2182         Enabling uploading archives to S3
2183         https://bugs.webkit.org/show_bug.cgi?id=174198
2184
2185         Unreviewed unit test fix after r219235.
2186
2187         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2188
2189 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
2190
2191         Fix JSCOnly ARM buildbots after r220047
2192         https://bugs.webkit.org/show_bug.cgi?id=174993
2193
2194         Unreviewed fix after r220087.
2195
2196         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2197         (BuildAndRemoteJSCTestsFactory.__init__):
2198
2199 2017-08-01  Chris Dumez  <cdumez@apple.com>
2200
2201         Add initial support for navigator.sendBeacon
2202         https://bugs.webkit.org/show_bug.cgi?id=175007
2203         <rdar://problem/33547728>
2204
2205         Reviewed by Sam Weinig.
2206
2207         Enable the Beacon API at runtime in the context of layout tests since the
2208         feature is currently disabled by default.
2209
2210         * DumpRenderTree/mac/DumpRenderTree.mm:
2211         (enableExperimentalFeatures):
2212         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2213         (WTR::InjectedBundle::beginTesting):
2214         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2215         (WTR::TestRunner::setModernMediaControlsEnabled):
2216         (WTR::TestRunner::setBeaconAPIEnabled):
2217         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2218
2219 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
2220
2221         Update Bot Watcher's Dashboard for Buildbot 0.9
2222         https://bugs.webkit.org/show_bug.cgi?id=174777
2223
2224         Reviewed by Daniel Bates.
2225
2226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2227         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
2228         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
2229         in a dictionary.
2230         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
2231         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
2232         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2233         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
2234         (parseRevisionProperty): Ditto.
2235         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
2236         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
2237         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
2238         have changed in Buildbot 0.9.
2239         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
2240         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
2241         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
2242         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
2243         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
2244         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
2245         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
2246         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
2247         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
2248         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
2249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2250         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
2251         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
2252         (BuildbotQueue.prototype.get overviewURL): Ditto.
2253         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
2254         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
2255         Buildbot 0.8 or 0.9.
2256         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
2257         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
2258         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
2259         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
2260         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
2261         Therefore we are fetching information for fixed number of build. 
2262         Also iterating the loop incrementally since the build data is already reverse sorted.
2263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2264         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
2265         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
2266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2267         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
2268
2269 2017-08-01  Devin Rousso  <drousso@apple.com>
2270
2271         Web Inspector: simplify WebInspector with WI
2272         https://bugs.webkit.org/show_bug.cgi?id=175058
2273
2274         Reviewed by Joseph Pecoraro.
2275
2276         * Scripts/check-inspector-strings:
2277         (extract_ui_strings):
2278         * Scripts/extract-localizable-js-strings:
2279
2280 2017-08-01  Youenn Fablet  <youenn@apple.com>
2281
2282         Layout tests with 'https' suffix should be run over HTTPS
2283         https://bugs.webkit.org/show_bug.cgi?id=174992
2284
2285         Reviewed by Chris Dumez.
2286
2287         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
2288         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
2289         Covered by corresponding unit tests.
2290
2291         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
2292         (run_server):
2293         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2294         (base_http_url):
2295         (base_https_url):
2296         (base_url): Deleted.
2297         * Scripts/webkitpy/port/base.py:
2298         (Port.to.web_platform_test_server_base_http_url):
2299         (Port.to):
2300         (Port.to.web_platform_test_server_base_https_url):
2301         (Port.to.web_platform_test_server_base_url): Deleted.
2302         * Scripts/webkitpy/port/driver.py:
2303         (Driver.__init__):
2304         (Driver.wpt_test_path_to_uri):
2305         (Driver):
2306         (Driver.http_test_path_to_uri):
2307         (Driver.test_to_uri):
2308         (Driver.uri_to_test):
2309         * Scripts/webkitpy/port/driver_unittest.py:
2310         (DriverTest.test_test_to_uri):
2311         (DriverTest.test_uri_to_test):
2312
2313 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
2314
2315         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
2316         https://bugs.webkit.org/show_bug.cgi?id=173998
2317
2318         Reviewed by Darin Adler.
2319
2320         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
2321         detect mistakes in backward compatibility in the future when we change it.
2322
2323         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
2324         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
2325         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
2326         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
2327         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
2328         internal key data slot.
2329
2330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2331         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
2332         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
2333         (getNextMessage):
2334         (TEST):
2335         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
2336         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
2337         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
2338         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
2339         These are the pre-baked databases.
2340         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
2341         This is the actual test that do all the reads and comparisons.
2342         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
2343         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
2344         IndexedDB new stuffs. Then it can be used to bake the database again.
2345
2346 2017-08-01  Brady Eidson  <beidson@apple.com>
2347
2348         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
2349         https://bugs.webkit.org/show_bug.cgi?id=175030
2350
2351         Reviewed by Andy Estes.
2352
2353         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2354         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
2355
2356 2017-08-01  Brady Eidson  <beidson@apple.com>
2357
2358         Part 2 of: Rename DatabaseProcess to StorageProcess.
2359         https://bugs.webkit.org/show_bug.cgi?id=174880
2360
2361         Reviewed by Andy Estes.
2362
2363         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2364         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
2365         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2366         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2367         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2368         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2369         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2370         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2371
2372 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
2373
2374         Fix JSCOnly ARM buildbots after r220047
2375         https://bugs.webkit.org/show_bug.cgi?id=174993
2376
2377         Reviewed by Saam Barati.
2378
2379         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2380         (BuildAndRemoteJSCTestsFactory.__init__):
2381
2382 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2383
2384         [WTF] Introduce Private Symbols
2385         https://bugs.webkit.org/show_bug.cgi?id=174935
2386
2387         Reviewed by Darin Adler.
2388
2389         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2390         (TestWebKitAPI::TEST):
2391
2392 2017-07-30  Darin Adler  <darin@apple.com>
2393
2394         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
2395         https://bugs.webkit.org/show_bug.cgi?id=130653
2396
2397         Reviewed by Antti Koivisto.
2398
2399         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2400         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
2401         when calling frameDidChangeLocation.
2402         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
2403         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
2404         thus causing mysterious failures of a couple of tests. There are two remaining issues:
2405         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
2406         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
2407         same logic flaw that causes "top loading frame" to get set to one of the subframes in
2408         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
2409         loading, subframe starts loading. It would be good to clean that up some day, but for now
2410         this patch makes the two work identically rather than changing both.
2411         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
2412
2413 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2414
2415         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
2416         https://bugs.webkit.org/show_bug.cgi?id=174963
2417
2418         Reviewed by Darin Adler.
2419
2420         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
2421         RetainPtr<>. This patch changes them to all use auto.
2422
2423         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2424         (TestWebKitAPI::TEST):
2425
2426 2017-07-30  Brady Eidson  <beidson@apple.com>
2427
2428         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
2429         https://bugs.webkit.org/show_bug.cgi?id=174958
2430
2431         Reviewed by Darin Adler.
2432
2433         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2434         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
2435         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
2436         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
2437         (runUntilTasksInFlight):
2438         (TEST):
2439
2440 2017-07-28  Commit Queue  <commit-queue@webkit.org>
2441
2442         Unreviewed, rolling out r219990.
2443         https://bugs.webkit.org/show_bug.cgi?id=174961
2444
2445         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
2446         estes on #webkit).
2447
2448         Reverted changeset:
2449
2450         "Part 2 of: Rename DatabaseProcess to StorageProcess."
2451         https://bugs.webkit.org/show_bug.cgi?id=174880
2452         http://trac.webkit.org/changeset/219990
2453
2454 2017-07-28  Brady Eidson  <beidson@apple.com>
2455
2456         API tests that use URLSchemeHandler are failing.
2457         https://bugs.webkit.org/show_bug.cgi?id=174950
2458
2459         Reviewed by Alex Christensen.
2460
2461         Fix the NoMIMEType test to be correct.
2462
2463         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2464         (-[SchemeHandler initWithData:mimeType:]):
2465         (-[SchemeHandler webView:startURLSchemeTask:]):
2466         (TEST):
2467
2468 2017-07-28  Daniel Bates  <dabates@apple.com>
2469
2470         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
2471         https://bugs.webkit.org/show_bug.cgi?id=174876
2472
2473         Reviewed by Alex Christensen.
2474
2475         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
2476         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
2477         they provide a more direct way to test the platform abstraction.
2478
2479         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
2480
2481         * Scripts/prepare-ChangeLog:
2482         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
2483         of the current working directory.
2484
2485 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
2486
2487         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2488         https://bugs.webkit.org/show_bug.cgi?id=174930
2489
2490         Unreviewed test fix.
2491
2492         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
2493
2494         * Scripts/prepare-ChangeLog:
2495         (get_function_line_ranges_for_cpp):
2496
2497 2017-07-28  JF Bastien  <jfbastien@apple.com>
2498
2499         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2500         https://bugs.webkit.org/show_bug.cgi?id=174930
2501
2502         Reviewed by Daniel Bates.
2503
2504         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
2505         here also teach it about const and volatile overloads. I didn't do
2506         reference and rvalue reference overloads because we don't really
2507         use them, and the current parser throws away those characters and
2508         it doesn't seem worth making it more complex.
2509
2510         * Scripts/prepare-ChangeLog:
2511         (get_function_line_ranges_for_cpp):
2512         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2513         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
2514         (Foo::Arrow::arrow):
2515         (Foo::Arrow::otherArrow):
2516         (Foo::Arrow::otherArrow const):
2517         (Foo::Arrow::otherArrow volatile):
2518         (Foo::Arrow::otherArrow const volatile):
2519
2520 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
2521
2522         [GTK] Building with ENABLE_VIDEO=OFF fails
2523         https://bugs.webkit.org/show_bug.cgi?id=174940
2524
2525         Reviewed by Alex Christensen.
2526
2527         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
2528         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
2529
2530         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2531         (methodCallCallback): Add missing USE(GSTREAMER) guard.
2532
2533 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
2534
2535         [WPE] Implement EventSenderProxy in WTR
2536         https://bugs.webkit.org/show_bug.cgi?id=173419
2537
2538         Reviewed by Žan Doberšek.
2539
2540         Add the implementation of EventSenderProxy to the WTR. This
2541         allows us to extend the coverage of the test suite in WKWPE.
2542
2543         * WebKitTestRunner/EventSenderProxy.h:
2544         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
2545         libxkbcommon needed to deal with key events.
2546         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2547         (WTR::EventSenderProxy::EventSenderProxy):
2548         (WTR::senderButtonToWPEButton):
2549         (WTR::EventSenderProxy::mouseDown):
2550         (WTR::EventSenderProxy::mouseUp):
2551         (WTR::EventSenderProxy::mouseMoveTo):
2552         (WTR::EventSenderProxy::mouseScrollBy):
2553         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2554         (WTR::EventSenderProxy::leapForward):
2555         (WTR::wkEventModifiersToWPE):
2556         (WTR::getXKBKeySymForKeyRef):
2557         (WTR::EventSenderProxy::keyDown):
2558         (WTR::EventSenderProxy::addTouchPoint):
2559         (WTR::EventSenderProxy::updateTouchPoint):
2560         (WTR::EventSenderProxy::setTouchModifier):
2561         (WTR::EventSenderProxy::setTouchPointRadius):
2562         (WTR::EventSenderProxy::getUpdatedTouchEvents):
2563         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
2564         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2565         (WTR::EventSenderProxy::touchStart):
2566         (WTR::EventSenderProxy::touchMove):
2567         (WTR::EventSenderProxy::touchEnd):
2568         (WTR::EventSenderProxy::touchCancel):
2569         (WTR::EventSenderProxy::clearTouchPoints):
2570         (WTR::EventSenderProxy::releaseTouchPoint):
2571         (WTR::EventSenderProxy::cancelTouchPoint):
2572
2573 2017-07-27  Brady Eidson  <beidson@apple.com>
2574
2575         Part 2 of: Rename DatabaseProcess to StorageProcess.
2576         https://bugs.webkit.org/show_bug.cgi?id=174880
2577
2578         Reviewed by Andy Estes.
2579
2580         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2581         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
2582         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2583         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2584         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2585         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2586         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2587         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2588
2589 2017-07-26  Mark Lam  <mark.lam@apple.com>
2590
2591         Add ability to only run specific tests in run-javascriptcore-tests.
2592         https://bugs.webkit.org/show_bug.cgi?id=174884
2593
2594         Reviewed by Saam Barati.
2595
2596         For example, if we only want to run testapi, we can do so as follows:
2597             $ run-javascriptcore-tests --testapi
2598
2599         Previously, specifying --testapi effectively does nothing because we run all tests
2600         by default.  Only --no-testapi had the effect of disabling the test set.  This
2601         old behavior for --testapi is not very useful or meaningful.  We're now changing
2602         it to mean that we will only run that test.
2603
2604         With this change, we can also run more than one set of tests.  For example, if we
2605         only want to run testmasm and testair, we can do so as follows:
2606             $ run-javascriptcore-tests --testmasm --testair
2607
2608         By default, if no specific test option is specified, run-javascriptcore-tests will
2609         run all tests.
2610
2611         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
2612         the mozilla tests (--mozilla-tests) even though both are run via the lower level
2613         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
2614         the other set will not run.  For example, the following only runs the mozilla tests:
2615             $ run-javascriptcore-tests --mozilla-tests
2616
2617         Note also that --jit-stress-tests is not for choosing a different set of tests.
2618         Instead, it is used for determining whether we run JIT'ed test configurations
2619         on the jsc stress tests and mozilla tests.  As a result, specifying
2620         --jit-stress-tests will not omit other tests.  For example, the following still
2621         runs all tests:
2622             $ run-javascriptcore-tests --jit-stress-tests
2623
2624         * Scripts/run-javascriptcore-tests:
2625         (defaultStringForTestState):
2626         (enableTestOrNot):
2627         (runJSCStressTests):
2628
2629 2017-07-26  Mark Lam  <mark.lam@apple.com>
2630
2631         Make run-javascriptcore-test run testair, testb3, and testmasm.
2632         https://bugs.webkit.org/show_bug.cgi?id=174837
2633         <rdar://problem/33522927>
2634
2635         Reviewed by Saam Barati and Filip Pizlo.
2636
2637         1. Refactors code for running testapi so that we can use it to run other tests.
2638         2. Added running of testmasm, testair, testb3.
2639
2640         Note: the existing testapi invocation code does not support remote invocation of
2641         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
2642         and testb3 also do not support remote invocation.  If we wish to add remote
2643         invocation support, we should do that in a separate patch.
2644
2645         * Scripts/run-javascriptcore-tests:
2646         (testPath):
2647         (runTest):
2648         (testapiPath): Deleted.
2649
2650 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
2651
2652         Remove duplicate code from Buildbot.js in dashboard
2653         https://bugs.webkit.org/show_bug.cgi?id=174870
2654
2655         Reviewed by Daniel Bates.
2656
2657         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2658         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
2659         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
2660         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
2661         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
2662
2663 2017-07-26  Brady Eidson  <beidson@apple.com>
2664
2665         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
2666         https://bugs.webkit.org/show_bug.cgi?id=174851
2667
2668         Reviewed by Chris Dumez.
2669
2670         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2671         (TEST):
2672
2673 2017-07-26  Brian Burg  <bburg@apple.com>
2674
2675         Remove WEB_TIMING feature flag
2676         https://bugs.webkit.org/show_bug.cgi?id=174795
2677
2678         Reviewed by Alex Christensen.
2679
2680         * Scripts/webkitperl/FeatureList.pm:
2681         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2682
2683 2017-07-26  Chris Dumez  <cdumez@apple.com>
2684
2685         Pressing the Escape key should not be a valid user gesture to enter fullscreen
2686         https://bugs.webkit.org/show_bug.cgi?id=174864
2687         <rdar://problem/33009088>
2688
2689         Reviewed by Geoffrey Garen.
2690
2691         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
2692         WKTR.
2693
2694         * DumpRenderTree/mac/EventSendingController.mm:
2695         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2696
2697 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2698
2699         Unreviewed, added Romain Bellessort to contributors.json.
2700
2701         * Scripts/webkitpy/common/config/contributors.json:
2702
2703 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
2704
2705         [WPE] WebGL2 support
2706         https://bugs.webkit.org/show_bug.cgi?id=174249
2707
2708         Reviewed by Alex Christensen.
2709
2710         * Scripts/webkitperl/FeatureList.pm:
2711         Enable WebGL2 for WPE when building through build-webkit.
2712
2713 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2714
2715         Unreviewed. Fix GTK distcheck.
2716
2717         * gtk/make-dist.py:
2718         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
2719
2720 2017-07-25  Brady Eidson  <beidson@apple.com>
2721
2722         ResourceLoadStatistics grandfathering happens much too often.
2723         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
2724
2725         Reviewed by Chris Dumez.
2726
2727         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2728         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
2729         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
2730         (TEST):
2731
2732 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
2733
2734         Fix autoinstaller failing on autoinstall_everything
2735         https://bugs.webkit.org/show_bug.cgi?id=174830
2736
2737         Reviewed by Joseph Pecoraro.
2738
2739         * Scripts/webkitpy/thirdparty/__init__.py:
2740         (AutoinstallImportHook.find_module):
2741         (AutoinstallImportHook.install_chromedriver):
2742         (AutoinstallImportHook.install_geckodriver):
2743         (AutoinstallImportHook._install_chromedriver): Deleted.
2744         (AutoinstallImportHook._install_geckodriver): Deleted.
2745
2746 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
2747
2748         Replace --runtime with something for both ios-simulator and ios-device
2749         https://bugs.webkit.org/show_bug.cgi?id=173775
2750         <rdar://problem/32952164>
2751
2752         Reviewed by Aakash Jain.
2753
2754         Add --version flag for both iOS simulator and iOS device.
2755
2756         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2757         (parse_args): Add --version flag and move --no-install.
2758         * Scripts/webkitpy/port/factory.py:
2759         (platform_options): Move --no-intall to run_webkit_tests.py.
2760         * Scripts/webkitpy/port/ios.py:
2761         (IOSPort):
2762         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
2763         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
2764         * Scripts/webkitpy/port/ios_device.py:
2765         (IOSDevicePort.ios_version): Consult --version flag before checking connected
2766         devices for iOS version.
2767         * Scripts/webkitpy/port/ios_device_unittest.py:
2768         (IOSDeviceTest.make_port): Set --version option so that we can generate test
2769         expectation paths without devices connected.
2770         (IOSDeviceTest.test_additional_platform_directory): Deleted.
2771         (IOSDeviceTest.test_baseline_searchpath): Deleted.
2772         (IOSDeviceTest.test_expectations_ordering): Deleted.
2773         * Scripts/webkitpy/port/ios_simulator.py:
2774         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
2775         flag to specify a runtime.
2776         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
2777         flag and then use the default runtime.
2778
2779 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2780
2781         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
2782         https://bugs.webkit.org/show_bug.cgi?id=174815
2783
2784         Reviewed by Carlos Alberto Lopez Perez.
2785
2786         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
2787         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
2788         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
2789         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
2790         think), probably because of a newer CMake version.
2791
2792         * CMakeLists.txt:
2793         * TestWebKitAPI/CMakeLists.txt:
2794         * TestWebKitAPI/PlatformGTK.cmake:
2795
2796 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2797
2798         Fix BenchmarkRunner to only import selenium when needed
2799         https://bugs.webkit.org/show_bug.cgi?id=174808
2800
2801         Reviewed by Stephanie Lewis.
2802
2803         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2804         (LinuxChromeDriver.launch_driver):
2805         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2806         (LinuxFirefoxDriver.launch_driver):
2807         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2808         (OSXChromeDriver.launch_driver):
2809         (OSXChromeCanaryDriver.launch_driver):
2810         (create_chrome_options):
2811         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2812         (OSXFirefoxDriver.launch_driver):
2813         (OSXFirefoxNightlyDriver.launch_driver):
2814         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2815         (OSXSafariDriver.launch_driver):
2816         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2817         (WebDriverBenchmarkRunner._run_one_test):
2818
2819 2017-07-23  Darin Adler  <darin@apple.com>
2820
2821         More NeverDestroyed and related cleanup
2822         https://bugs.webkit.org/show_bug.cgi?id=174745
2823
2824         Reviewed by Alex Christensen.
2825
2826         * DumpRenderTree/JavaScriptThreading.cpp:
2827         (javaScriptThreadsMutex): Use NeverDestroyed instead of
2828         DEPRECATED_DEFINE_STATIC_LOCAL.
2829         (javaScriptThreads): Ditto.
2830
2831 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2832
2833         Subclass Benchmark Runner script for WebDriver support
2834         https://bugs.webkit.org/show_bug.cgi?id=174390
2835
2836         Reviewed by Dewei Zhu, Stephanie Lewis.
2837
2838         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
2839
2840         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2841         (BenchmarkBuilder.__init__):
2842         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2843         (BenchmarkRunner.__init__):
2844         (BenchmarkRunner._find_plan_file):
2845         (BenchmarkRunner._run_one_test.and):
2846         (BenchmarkRunner.execute):
2847         (BenchmarkRunner._get_result): Deleted.
2848         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2849         (parse_args):
2850         (start):
2851         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
2852         (WebDriverBenchmarkRunner):
2853         (WebDriverBenchmarkRunner._get_result):
2854         (WebDriverBenchmarkRunner._run_one_test):
2855         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
2856         (WebServerBenchmarkRunner):
2857         (WebServerBenchmarkRunner.__init__):
2858         (WebServerBenchmarkRunner._get_result):
2859         (WebServerBenchmarkRunner._run_one_test):
2860
2861 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2862
2863         Add BenchmarkRunner patches with WebDriver support for each testing plan
2864         https://bugs.webkit.org/show_bug.cgi?id=174443
2865
2866         Reviewed by Dewei Zhu, Stephanie Lewis.
2867
2868         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2869         (BenchmarkBuilder.__enter__):
2870         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
2871         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
2872         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
2873         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
2874         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
2875         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
2876         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
2877         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
2878         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
2879         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
2880         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2881         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
2882         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
2883         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
2884         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
2885         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
2886         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
2887         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2888         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
2889         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
2890         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
2891         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2892         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2893         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
2894         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
2895         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
2896         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2897         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
2898         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
2899         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2900         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
2901         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2902         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2903
2904 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2905
2906         Add functions to autoinstaller needed for Benchmark Runner script
2907         https://bugs.webkit.org/show_bug.cgi?id=174331
2908
2909         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
2910
2911         Adds autoinstaller functions to install selenium and webdriver binaries
2912         which will be used by the browser driver part of Benchmark Runner.
2913
2914         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2915         (BrowserDriver.restore_env):
2916         (BrowserDriver):
2917         (BrowserDriver.get_webdriver_binary_path):
2918         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2919         (LinuxChromeDriver.launch_driver):
2920         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2921         (LinuxFirefoxDriver.launch_driver):
2922         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2923         (OSXChromeDriver.launch_driver):
2924         (OSXChromeCanaryDriver.launch_driver):
2925         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2926         (OSXFirefoxDriver.launch_driver):
2927         (OSXFirefoxNightlyDriver.launch_driver):
2928         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2929         * Scripts/webkitpy/benchmark_runner/utils.py:
2930         (get_driver_binary_path):
2931         * Scripts/webkitpy/common/system/autoinstall.py:
2932         (AutoInstaller._unzip):
2933         * Scripts/webkitpy/thirdparty/__init__.py:
2934         (AutoinstallImportHook.find_module):
2935         (AutoinstallImportHook._install_selenium):
2936         (AutoinstallImportHook):
2937         (AutoinstallImportHook._install_chromedriver):
2938         (AutoinstallImportHook._install_geckodriver):
2939         (AutoinstallImportHook.get_latest_pypi_url):
2940         (AutoinstallImportHook.install_binary):
2941         (autoinstall_everything):
2942         (get_driver_filename):
2943         (get_os_info):
2944
2945 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2946
2947         Add WebDriver support in browser driver part of BenchmarkRunner
2948         https://bugs.webkit.org/show_bug.cgi?id=174445
2949
2950         Reviewed by Stephanie Lewis.
2951
2952         Adds a launch_driver function to each BrowserDriver subclass. This
2953         function sets up the arguments for the webdriver and launches the
2954         webdriver specific to that browser.
2955
2956         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2957         (BrowserDriver.launch_webdriver):
2958         (BrowserDriver):
2959         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2960         (LinuxBrowserDriver.launch_webdriver):
2961         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2962         (LinuxChromeDriver.launch_url):
2963         (LinuxChromeDriver):
2964         (LinuxChromeDriver.launch_driver):
2965         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
2966         (EpiphanyBrowserDriver.launch_url):
2967         (EpiphanyBrowserDriver):
2968         (EpiphanyBrowserDriver.launch_driver):
2969         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2970         (LinuxFirefoxDriver):
2971         (LinuxFirefoxDriver.launch_url):
2972         (LinuxFirefoxDriver.launch_driver):
2973         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
2974         (GTKMiniBrowserDriver.launch_url):
2975         (GTKMiniBrowserDriver):
2976         (GTKMiniBrowserDriver.launch_driver):
2977         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2978         (OSXBrowserDriver._launch_webdriver):
2979         (OSXBrowserDriver):
2980         (OSXBrowserDriver._screen_size):
2981         (OSXBrowserDriver._insert_url):
2982         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2983         (OSXChromeDriver):
2984         (OSXChromeDriver.launch_url):
2985         (OSXChromeDriver.launch_driver):
2986         (OSXChromeCanaryDriver):
2987         (OSXChromeCanaryDriver.launch_url):
2988         (OSXChromeCanaryDriver.launch_driver):
2989         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2990         (OSXFirefoxDriver):
2991         (OSXFirefoxDriver.launch_url):
2992         (OSXFirefoxDriver.launch_driver):
2993         (OSXFirefoxNightlyDriver):
2994         (OSXFirefoxNightlyDriver.launch_url):
2995         (OSXFirefoxNightlyDriver.launch_driver):
2996         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2997         (OSXSafariDriver.launch_driver):
2998
2999 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3000
3001         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
3002         https://bugs.webkit.org/show_bug.cgi?id=174793
3003
3004         Reviewed by Tim Horton.
3005
3006         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
3007         down. Without r219765, this test will dereference null and crash.
3008
3009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3010         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
3011         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
3012         (TEST):
3013
3014 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3015
3016         [Win] Implement Authentication dialog in MiniBrowser
3017         https://bugs.webkit.org/show_bug.cgi?id=174662
3018
3019         Reviewed by Alex Christensen.
3020
3021         * MiniBrowser/win/Common.cpp:
3022         (CustomUserAgent):
3023         (DisplayAuthDialog):
3024         (AuthDialogProc):
3025         * MiniBrowser/win/MiniBrowserLib.rc:
3026         * MiniBrowser/win/MiniBrowserLibResource.h:
3027         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3028         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3029
3030 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
3031
3032         Handle case where line_numbers is None instead of an array of line numbers
3033         https://bugs.webkit.org/show_bug.cgi?id=174775
3034
3035         Reviewed by Aakash Jain.
3036
3037         Added files set line_numbers to None in process_file.
3038
3039         * Scripts/webkitpy/style/filereader.py:
3040         (TextFileReader.process_file): Handle case where line_number is set to None.
3041         * Scripts/webkitpy/style/main_unittest.py:
3042         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
3043
3044 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
3045
3046         [WPE] Add libepoxy to the Jhbuild moduleset
3047         https://bugs.webkit.org/show_bug.cgi?id=174711
3048
3049         Reviewed by Carlos Alberto Lopez Perez.
3050
3051         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
3052
3053 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
3054
3055         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
3056         https://bugs.webkit.org/show_bug.cgi?id=174780
3057
3058         Reviewed by Carlos Garcia Campos.
3059
3060         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
3061         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
3062         in case the eglplatform.h header doesn't provide that macro. This replicates
3063         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
3064
3065 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3066
3067         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
3068         https://bugs.webkit.org/show_bug.cgi?id=174758
3069
3070         Reviewed by Dan Bernstein.
3071
3072         Migrate position-information-related unit tests from the PositionInformationTests suite to
3073         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
3074
3075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3076         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
3077         (TestWebKitAPI::checkElementTypeAndBoundingRect):
3078         (TestWebKitAPI::TEST):
3079         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
3080         * TestWebKitAPI/cocoa/TestWKWebView.h:
3081         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3082         (-[TestWKWebView activatedElementAtPosition:]):
3083
3084 2017-07-22  Chris Dumez  <cdumez@apple.com>
3085
3086         REGRESSION(r204565): WKObject is broken
3087         https://bugs.webkit.org/show_bug.cgi?id=174736
3088         <rdar://problem/33246169>
3089
3090         Reviewed by Dan Bernstein.
3091
3092         Add API test that used to crash.
3093
3094         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
3095         (TestWebKitAPI::TEST):
3096
3097 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
3098
3099         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
3100         https://bugs.webkit.org/show_bug.cgi?id=174705
3101
3102         Reviewed by Mark Lam.
3103
3104         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
3105         (TestWebKitAPI::testThreadGroup):
3106         (TestWebKitAPI::TEST):
3107
3108 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
3109
3110         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
3111         https://bugs.webkit.org/show_bug.cgi?id=174724
3112
3113         Reviewed by Aakash Jain.
3114
3115         * Scripts/webkitpy/port/ios_simulator.py:
3116         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
3117         simulator. Errors here should be treated the same as no simulators found.
3118
3119 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
3120
3121         [CMake] Add an option to stop build after generating project files
3122         https://bugs.webkit.org/show_bug.cgi?id=174664
3123
3124         Reviewed by Konstantin Tokarev.
3125
3126         Add "--generate-project-only" to stop build after generating project files.
3127
3128         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
3129         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
3130         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
3131         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
3132         (isGenerateProjectOnly): ditto
3133
3134 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
3135
3136         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
3137         https://bugs.webkit.org/show_bug.cgi?id=174501
3138
3139         Reviewed by Darin Adler.
3140
3141         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3142         (TestWebKitAPI::TEST):
3143
3144 2017-07-20  David Quesada  <david_quesada@apple.com>
3145
3146         Add SPI to notify WKNavigationDelegate about client redirects
3147         https://bugs.webkit.org/show_bug.cgi?id=174680
3148         rdar://problem/33184886
3149
3150         Reviewed by Brady Eidson.
3151
3152         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3153         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
3154         (TEST):
3155         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
3156
3157 2017-07-20  Brady Eidson  <beidson@apple.com>
3158
3159         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
3160         https://bugs.webkit.org/show_bug.cgi?id=174685
3161
3162         Reviewed by Andy Estes.
3163
3164         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3165         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
3166
3167 2017-07-20  Brady Eidson  <beidson@apple.com>
3168
3169         Deprecate WebIconDatabase in WebKitLegacy/mac.
3170         https://bugs.webkit.org/show_bug.cgi?id=174607
3171
3172         Reviewed by Alex Christensen.
3173
3174         * DumpRenderTree/mac/TestRunnerMac.mm:
3175
3176 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
3177
3178         lint-test-expectations should be run during style checking
3179         https://bugs.webkit.org/show_bug.cgi?id=173559
3180         <rdar://problem/32854941>
3181
3182         Reviewed by Aakash Jain.
3183
3184         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3185         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
3186         prevents identifying errors on specific lines in a file.
3187         * Scripts/webkitpy/style/main_unittest.py:
3188         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
3189         case where a linter error is in the file modified, but the line modified is not related to
3190         the linter error.
3191
3192 2017-07-20  Brady Eidson  <beidson@apple.com>
3193
3194         Remove WebIconDatabase from WebKitLegacy/win.
3195         https://bugs.webkit.org/show_bug.cgi?id=174608
3196
3197         Reviewed by Alex Christensen.
3198
3199         * DumpRenderTree/win/DumpRenderTree.cpp:
3200         (main):
3201         * DumpRenderTree/win/TestRunnerWin.cpp:
3202         (TestRunner::setIconDatabaseEnabled):
3203
3204 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
3205
3206         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
3207         https://bugs.webkit.org/show_bug.cgi?id=174671
3208
3209         Reviewed by Carlos Garcia Campos.
3210
3211         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
3212         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
3213         priority for this source in order to have it dispatched on the same
3214         priority as the other WebKit-controlled GSource objects.
3215
3216 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
3217
3218         lint-test-expectations should be run during style checking
3219         https://bugs.webkit.org/show_bug.cgi?id=173559
3220         <rdar://problem/32854941>
3221
3222         Reviewed by Daniel Bates.
3223
3224         Follow up fix addressing style and a few minor bugs.
3225
3226         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3227         (TestExpectationParser.__init__): Use lambda x: x instead of str
3228         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
3229         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
3230         reduce the calls of _shorten_filename, fix minor bug in appending the current
3231         expectation's line number instead of the previous ones, clarify treatment of None
3232         in file-to-line-number mapping.
3233         (TestExpectations._report_warnings): Collapse call.
3234         * Scripts/webkitpy/style/checkers/test_expectations.py:
3235         (TestExpectationsChecker.lint_test_expectations):
3236         * Scripts/webkitpy/style/filereader.py: Re-write comment.
3237         (TextFileReader.process_file): Add comment explaining treatment of None in
3238         file-to-line-number mapping.
3239         (TextFileReader.delete_file): Collapse call.
3240
3241 2017-07-19  Chris Dumez  <cdumez@apple.com>
3242
3243         Unreviewed attempt to fix API test failure after r219663.
3244
3245         The test was hard-coding an exception string and the string has changed slightly
3246         in r219663.
3247
3248         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3249         (TEST):
3250
3251 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
3252
3253         Don't write file URLs to iOS Pasteboard
3254         https://bugs.webkit.org/show_bug.cgi?id=174647
3255         <rdar://problem/33199730>
3256
3257         Reviewed by Wenson Hsieh.
3258
3259         Updating tests to reflect the lack of file URLs for images.
3260
3261         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3262         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
3263         (checkEstimatedSize):
3264         (TestWebKitAPI::TEST):
3265
3266 2017-07-19  Brady Eidson  <beidson@apple.com>
3267
3268         iBooks sometimes crashes when closing a book.
3269         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
3270
3271         Reviewed by Oliver Hunt.
3272
3273         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3274         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
3275         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
3276         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
3277         (TestWebKitAPI::TEST):
3278
3279         Add a "spin the runloop X number of times" utility:
3280         * TestWebKitAPI/Utilities.h:
3281         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3282         (TestWebKitAPI::Util::spinRunLoop):
3283
3284 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
3285
3286         lint-test-expectations should be run during style checking
3287         https://bugs.webkit.org/show_bug.cgi?id=173559
3288         <rdar://problem/32854941>
3289
3290         Reviewed by David Kilzer.
3291
3292         Running the test expectation linter requires reading both files and lines not in the
3293         patch because, for example, deletion of a test can cause a lint failure even though
3294         no test expectations where modified. This means that the linter will occasionally warn
3295         about lines which were not changed in a given patch but whose error is related to a
3296         change made in that patch.
3297
3298         * Scripts/webkitpy/common/system/filesystem_mock.py:
3299         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
3300         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3301         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
3302         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
3303         content, description of the error and the name of the associated test.
3304         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
3305         (TestExpectationParser.__init__): Pass shorten_filename function to
3306         TestExpectationsParser to add a deleted file to the related_files dictionary.
3307         (TestExpectationParser._check_test_exists): If the test does not exist, add the
3308         missing path to the related_files dictionary.
3309         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
3310         files and line numbers related to this test expectation line. This will allow
3311         tracking linter errors in the style checker occurring across multiple files.
3312         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
3313         lines to related_files dictionary.
3314         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
3315         (TestExpectations._report_warnings): Construct warning object instead of string
3316         when adding to warnings list.
3317         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
3318         clean-up log.
3319         * Scripts/webkitpy/style/checker.py:
3320         (ProcessorBase.do_association_check): Add required function for processor classes.
3321         (StyleProcessor):
3322         (StyleProcessor.do_association_check): Run the TestExpectations linter when
3323         checking for errors between associated files.
3324         * Scripts/webkitpy/style/checkers/test_expectations.py:
3325         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
3326         (TestExpectationsChecker):
3327         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
3328         of modified files, the current working directory and the host, determine if the linter
3329         warning is associated with the changes.
3330         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
3331         style checker.
3332         * Scripts/webkitpy/style/filereader.py:
3333         (TextFileReader):
3334         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
3335         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
3336         (TextFileReader.process_file): Track both the number of files changed and which lines
3337         in those files were changed.
3338         (TextFileReader.do_association_check): Run the processor's association check on all
3339         modified or deleted files processed by TextFileReader.
3340         (TextFileReader.delete_file): Track deleted files in _files dictionary.
3341         (TextFileReader.count_delete_only_file): Deleted.
3342         * Scripts/webkitpy/style/filereader_unittest.py:
3343         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
3344         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
3345         * Scripts/webkitpy/style/main.py:
3346         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
3347         explicitly run the association check on the file reader.
3348         * Scripts/webkitpy/style/main_unittest.py:
3349         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
3350         embedded in the style checker.
3351         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
3352         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
3353         construct the TextFileReader object with a StyleProcessor used to run style checks on
3354         specific files.
3355         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
3356         testing the test expectation linter inside the style checker. This host must contain a
3357         mock file system with the basic structure of test expectations.
3358         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
3359         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
3360         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
3361         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
3362         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
3363         * Scripts/webkitpy/style/patchreader.py:
3364         (PatchReader.check): Specify which file was deleted, run the association check.
3365         * Scripts/webkitpy/style/patchreader_unittest.py:
3366         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
3367         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
3368         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
3369
3370 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3371
3372         [WTF] Implement WTF::ThreadGroup
3373         https://bugs.webkit.org/show_bug.cgi?id=174081
3374
3375         Reviewed by Mark Lam.
3376
3377         Add WTF::ThreadGroup tests.
3378
3379         * TestWebKitAPI/CMakeLists.txt:
3380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3381         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
3382         (TestWebKitAPI::testThreadGroup):
3383         (TestWebKitAPI::TEST):
3384
3385 2017-07-18  Andy Estes  <aestes@apple.com>
3386
3387         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3388         https://bugs.webkit.org/show_bug.cgi?id=174631
3389
3390         Reviewed by Tim Horton.
3391
3392         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3393         * MiniBrowser/Configurations/Base.xcconfig:
3394         * MobileMiniBrowser/Configurations/Base.xcconfig:
3395         * TestWebKitAPI/Configurations/Base.xcconfig:
3396         * WebKitTestRunner/Configurations/Base.xcconfig:
3397
3398 2017-07-18  Andy Estes  <aestes@apple.com>
3399
3400         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3401         https://bugs.webkit.org/show_bug.cgi?id=174631
3402
3403         Reviewed by Sam Weinig.
3404
3405         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3406         * MiniBrowser/Configurations/Base.xcconfig:
3407         * MobileMiniBrowser/Configurations/Base.xcconfig:
3408         * TestWebKitAPI/Configurations/Base.xcconfig:
3409         * WebKitTestRunner/Configurations/Base.xcconfig:
3410
3411 2017-07-18  Daniel Bates  <dabates@apple.com>
3412
3413         lldb: Add type summary for StringView
3414         https://bugs.webkit.org/show_bug.cgi?id=174637
3415
3416         Reviewed by Sam Weinig.
3417
3418         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
3419         StringView object will print output that has the form:
3420
3421             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
3422               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
3423               m_length = 2
3424               m_is8Bit = true
3425               m_underlyingString = 0x0000614000000a90
3426             }
3427
3428         * lldb/lldb_webkit.py:
3429         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
3430         (WTFStringView_SummaryProvider):
3431         (WTFStringViewProvider):
3432         (WTFStringViewProvider.__init__):
3433         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
3434         (WTFStringViewProvider.get_length): Access field StringView.m_length.
3435         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
3436         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
3437
3438 2017-07-18  Andy Estes  <aestes@apple.com>
3439
3440         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3441         https://bugs.webkit.org/show_bug.cgi?id=174631
3442
3443         Reviewed by Dan Bernstein.
3444
3445         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3446         * MiniBrowser/Configurations/Base.xcconfig:
3447         * MobileMiniBrowser/Configurations/Base.xcconfig:
3448         * TestWebKitAPI/Configurations/Base.xcconfig:
3449         * WebKitTestRunner/Configurations/Base.xcconfig:
3450
3451 2017-07-18  Devin Rousso  <drousso@apple.com>
3452
3453         Web Inspector: Add memoryCost to Inspector Protocol objects
3454         https://bugs.webkit.org/show_bug.cgi?id=174478
3455
3456         Reviewed by Joseph Pecoraro.
3457
3458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3459         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
3460         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
3461         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
3462         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
3463         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
3464         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
3465         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
3466         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
3467         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
3468         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
3469         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
3470         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
3471         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
3472         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
3473         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
3474         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
3475
3476 2017-07-18  Andy Estes  <aestes@apple.com>
3477
3478         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3479         https://bugs.webkit.org/show_bug.cgi?id=174631
3480
3481         Reviewed by Darin Adler.
3482
3483         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3484         * MiniBrowser/Configurations/Base.xcconfig:
3485         * MobileMiniBrowser/Configurations/Base.xcconfig:
3486         * TestWebKitAPI/Configurations/Base.xcconfig:
3487         * WebKitTestRunner/Configurations/Base.xcconfig:
3488
3489 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3490
3491         Unreviewed, fix the iOS build.
3492
3493         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
3494
3495         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3496         (TestWebKitAPI::TEST):
3497
3498 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3499
3500         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
3501         https://bugs.webkit.org/show_bug.cgi?id=174585
3502         <rdar://problem/33302541>
3503
3504         Reviewed by Tim Horton.
3505
3506         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
3507         being dragged when initiating a drag.
3508
3509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3510         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
3511         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3512         (TestWebKitAPI::TEST):
3513         * TestWebKitAPI/cocoa/TestWKWebView.h:
3514
3515         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
3516
3517         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3518         (-[TestWKWebView synchronouslyLoadHTMLString:]):
3519
3520 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3521
3522         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
3523         https://bugs.webkit.org/show_bug.cgi?id=174547
3524
3525         Reviewed by Alex Christensen.
3526
3527         * DumpRenderTree/PlatformWin.cmake:
3528         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3529
3530 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3531
3532         Update style checker to deal with "final"
3533         https://bugs.webkit.org/show_bug.cgi?id=174528
3534
3535         Reviewed by Alex Christensen.
3536         
3537         check-webkit-style shouldn't complain about an open brace to start a
3538         line after a function definition with "final" or "const final".
3539
3540         * Scripts/webkitpy/style/checkers/cpp.py:
3541         (check_braces):
3542         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3543         (CppStyleTest.test_brace_at_begin_of_line):
3544
3545 2017-07-17  Alex Christensen  <achristensen@webkit.org>
3546
3547         Modernize content extension code
3548         https://bugs.webkit.org/show_bug.cgi?id=174588
3549
3550         Reviewed by Sam Weinig.
3551
3552         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3553         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3554         (TestWebKitAPI::testRequest):
3555         (TestWebKitAPI::makeBackend):
3556         (TestWebKitAPI::TEST_F):
3557
3558 2017-07-17  Brady Eidson  <beidson@apple.com>
3559
3560         WKHTTPCookieStore observing only works on the default cookie store.
3561         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
3562
3563         Reviewed by Sam Weinig.
3564
3565         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3566         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
3567           called for the default store, a non-persistent store, and a custom store.
3568         (TEST):
3569
3570 2017-07-16  Sam Weinig  <sam@webkit.org>
3571
3572         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
3573         https://bugs.webkit.org/show_bug.cgi?id=174575
3574
3575         Reviewed by Brady Eidson.
3576
3577         * Scripts/svn-create-patch:
3578         (findModificationType):
3579         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
3580         default value of "unknown".
3581
3582         (generateFileList):
3583         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
3584         for untracked, which matches our old behavior.
3585
3586 2017-07-17  Charlie Turner  <cturner@igalia.com>
3587
3588         Add some missing build dependencies on Fedora
3589         https://bugs.webkit.org/show_bug.cgi?id=174578
3590
3591         Unreviewed dependency update.
3592
3593         * gtk/install-dependencies:
3594
3595 2017-07-16  Brady Eidson  <beidson@apple.com>
3596
3597         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
3598         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
3599
3600         Reviewed by Tim Horton.
3601
3602         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3603         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
3604         (TEST):
3605
3606 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
3607
3608         [GTK] Sort inspector GResource manifest to ensure reproducible builds
3609         https://bugs.webkit.org/show_bug.cgi?id=174540
3610
3611         Reviewed by Michael Catanzaro.
3612
3613         * gtk/generate-inspector-gresource-manifest.py:
3614         (get_filenames): sort list of input files
3615
3616 2017-07-15  Brady Eidson  <beidson@apple.com>
3617
3618         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
3619         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
3620
3621         Reviewed by Tim Horton.
3622
3623         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3624         (TEST): Make this test more reliable by clearing everything beforehand.
3625
3626 2017-07-15  David Kilzer  <ddkilzer@apple.com>
3627
3628         Make it possible to extend check-webkit-style with Apple-internal checkers
3629         <https://webkit.org/b/174464>
3630         <rdar://problem/25564402>
3631
3632         Reviewed by Darin Adler.
3633
3634         * Scripts/webkitpy/style/checker.py: Import apple_additions.
3635         (_all_categories): Add categories from apple_additions() if it
3636         exists.
3637         (CheckerDispatcher._create_checker): Create python checker
3638         from apple_additions() if it exists.
3639
3640 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3641
3642         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
3643         https://bugs.webkit.org/show_bug.cgi?id=174539
3644         <rdar://problem/33307395>
3645
3646         Reviewed by Darin Adler.
3647
3648         Adds a new unit test suite to cover action sheet popover presentation.
3649
3650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3651         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
3652         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
3653         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
3654
3655         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
3656
3657         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
3658         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3659
3660         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
3661
3662         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3663         (TestWebKitAPI::TEST):
3664
3665 2017-07-15  Sam Weinig  <sam@webkit.org>
3666
3667         [Scripts] Make svn-create-patch work better when called in sub directories
3668         https://bugs.webkit.org/show_bug.cgi?id=174551
3669
3670         Reviewed by Darin Adler.
3671
3672         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
3673           by ensuring that the prefix is applied as is done in generateDiff.
3674         - Silence output of explanatory lines from svn stat (" > move to ...")
3675           that show up in STDERR when running svn-create-patch.
3676         - Add verbose logging that I found useful while debugging this issue.
3677
3678         * Scripts/svn-create-patch:
3679         (findBaseUrl):
3680         (findMimeType):
3681         (findSourceFileAndRevision):
3682         (generateDiff):
3683         (generateFileList):
3684         (manufacturePatchForAdditionWithHistory):
3685
3686 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
3687
3688         Unreviewed build fix after r219537.
3689
3690         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3691
3692 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3693
3694         Add iOS 11 SPI
3695         https://bugs.webkit.org/show_bug.cgi?id=174430
3696         <rdar://problem/33269288>
3697
3698         Reviewed by Tim Horton.
3699
3700         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
3701         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
3702         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
3703
3704 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3705
3706         Failing to install on iPad simulators
3707         https://bugs.webkit.org/show_bug.cgi?id=174532
3708         <rdar://problem/33328347>
3709
3710         Reviewed by Stephanie Lewis.
3711
3712         * Scripts/webkitpy/xcode/simulated_device.py:
3713         (SimulatedDevice.install_app): Place install command in retry try-except block.
3714
3715 2017-07-14  Jeff Miller  <jeffm@apple.com>
3716
3717         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3718         https://bugs.webkit.org/show_bug.cgi?id=174524
3719
3720         Reviewed by Sam Weinig.
3721
3722         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
3723         (TEST):
3724         Renamed TestParameter to TestParameter1.
3725         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3726
3727         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3728         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3729         Observe changes for two bundle parameters.
3730
3731         (-[BundleParametersPlugIn dealloc]):
3732         Remove observers for two bundle parameters.
3733
3734 2017-07-14  Commit Queue  <commit-queue@webkit.org>
3735
3736         Unreviewed, rolling out r219510.
3737         https://bugs.webkit.org/show_bug.cgi?id=174525
3738
3739         Need to revert length() == 0 check for null string (Requested
3740         by yusukesuzuki on #webkit).
3741
3742         Reverted changeset:
3743
3744         "[WTF] Newly added AtomicStringImpl should use BufferInternal
3745         static string if StringImpl is static"
3746         https://bugs.webkit.org/show_bug.cgi?id=174501
3747         http://trac.webkit.org/changeset/219510
3748
3749 2017-07-14  Jer Noble  <jer.noble@apple.com>
3750
3751         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
3752         https://bugs.webkit.org/show_bug.cgi?id=174514
3753
3754         Reviewed by Sam Weinig.
3755
3756         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
3757         (TestWebKitAPI::TEST_F):
3758
3759 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3760
3761         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
3762         https://bugs.webkit.org/show_bug.cgi?id=174501
3763
3764         Reviewed by Darin Adler.
3765
3766         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3767         (TestWebKitAPI::TEST):
3768
3769 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3770
3771         Bring mac expectations in-line with other platforms
3772         https://bugs.webkit.org/show_bug.cgi?id=174472
3773         <rdar://problem/33297388>
3774
3775         Reviewed by David Kilzer.
3776
3777         The override order for Mac test expectations does not conform to the pattern used by iOS,
3778         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
3779
3780             platform/mac-wk2
3781             platform/wk2
3782             platform/mac-elcapitan
3783             platform/mac-sierra
3784             generic
3785
3786         After this change, El Capitan's baseline search path looks like this:
3787
3788             platform/mac-sierra-wk2
3789             platform/mac-sierra
3790             platform/mac-wk2
3791             platform/wk2
3792             generic
3793
3794         * Scripts/webkitpy/port/mac.py:
3795         (MacPort.__init__): If a specific version is specified in the port name, use that
3796         as the os version.
3797         (MacPort.default_baseline_search_path): Expectation search paths should work the
3798         same way they do on other ports. Port + version overrides port, port overrides generic
3799         and wk1/wk2 should override expectations for the two combined.
3800         * Scripts/webkitpy/port/mac_unittest.py:
3801         (MacTest.test_tests_for_other_platforms): Deleted.
3802         (MacTest._assert_search_path): Deleted.
3803         (MacTest.test_baseline_search_path): Deleted.
3804         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3805         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
3806         (test_rebaseline_test_and_print_scm_changes): Ditto.
3807         (test_rebaseline_and_copy_test): Ditto.
3808         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
3809         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
3810         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
3811
3812 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3813
3814         Fix style checker unit test
3815
3816         Unreviewed WebKit2 => WebKit fixup.
3817
3818         * Scripts/webkitpy/style/checker_unittest.py:
3819         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3820
3821 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3822
3823         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
3824
3825         Unreviewed build fix.
3826
3827         r219492 missed one hunk from its partial revert of r219489.
3828         This patch reverts that hunk.
3829
3830         * TestWebKitAPI/CMakeLists.txt:
3831
3832 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3833
3834         Use the old WebKit/WebKit2 targets for CMake builds.
3835
3836         Unreviewed build fix.
3837
3838         We can update the target names to match the Framework names in a future patch.
3839         This is a partial revert of r219489.
3840
3841         * TestWebKitAPI/CMakeLists.txt:
3842         WebKitLegacy => WebKit
3843         WebKit => WebKit2
3844
3845 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3846
3847         Fix TestWebKit API.
3848         https://bugs.webkit.org/show_bug.cgi?id=174164
3849         rdar://problem/33137595
3850
3851         Reviewed by Dan Bernstein.
3852
3853         * TestWebKitAPI/CMakeLists.txt:
3854         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3855         * TestWebKitAPI/PlatformGTK.cmake:
3856
3857 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3858
3859         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
3860         https://bugs.webkit.org/show_bug.cgi?id=174164
3861         rdar://problem/33137595
3862
3863         Reviewed by Dan Bernstein.
3864
3865         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3866         (ShouldBuildTest):
3867         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3868         * Scripts/build-webkit:
3869         * Scripts/do-file-rename:
3870         * Scripts/do-webcore-rename:
3871         * Scripts/update-webkit-localizable-strings:
3872         * Scripts/webkitpy/common/config/watchlist:
3873         * Scripts/webkitpy/style/checker.py:
3874         * Scripts/webkitpy/style/checkers/featuredefines.py:
3875         * gtk/make-dist.py:
3876         (ensure_version_if_possible):
3877         * gtk/manifest.txt.in:
3878
3879 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
3880
3881         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
3882         https://bugs.webkit.org/show_bug.cgi?id=174162
3883         rdar://problem/33137594
3884
3885         Reviewed by Dan Bernstein.
3886
3887         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
3888
3889         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3890         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3891         * EWSTools/configure-clang-linux.sh:
3892         * Scripts/build-webkit:
3893         * Scripts/do-file-rename:
3894         * Scripts/do-webcore-rename:
3895         * Scripts/update-webkit-localizable-strings:
3896         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3897         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3898         * Scripts/webkitpy/style/checkers/featuredefines.py:
3899         * gtk/manifest.txt.in:
3900
3901 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
3902
3903         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
3904         https://bugs.webkit.org/show_bug.cgi?id=174438
3905         <rdar://problem/33277112>
3906
3907         Reviewed by Aakash Jain.
3908
3909         Given a patch, this will convert the changes from the path to the new directory structure.
3910
3911         * Scripts/rebase-patch-after-webkit-move: Added.
3912         (append_source): Append 'Source' to the provided path.
3913         (is_editable_line): Return true if a line the script expects to modify.
3914         (needs_rebase): Return if a line needs to be rebased based on it's content.
3915         (rebase_line): Rebase the provided line.
3916         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
3917         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
3918         were provided.
3919
3920 2017-07-12  Nan Wang  <n_wang@apple.com>
3921
3922         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3923         https://bugs.webkit.org/show_bug.cgi?id=174393
3924         <rdar://problem/33248006>
3925
3926         Reviewed by Chris Fleizach.
3927
3928         * DumpRenderTree/AccessibilityUIElement.cpp:
3929         (textMarkerRangeMatchesTextNearMarkersCallback):
3930         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3931         (AccessibilityUIElement::getJSClass):
3932         * DumpRenderTree/AccessibilityUIElement.h:
3933         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3934         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3935         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3936         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3937         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3938         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3939         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3940         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3941
3942 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3943
3944         Unreviewed, rolling out r219409.
3945
3946         The revision caused the Windows builds to fail.
3947
3948         Reverted changeset:
3949
3950         "AX: [iOS] Implement a way to retrieve a text marker range
3951         with desired text that is closest to a position"
3952         https://bugs.webkit.org/show_bug.cgi?id=174393
3953         http://trac.webkit.org/changeset/219409
3954
3955 2017-07-12  Nan Wang  <n_wang@apple.com>
3956
3957         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3958         https://bugs.webkit.org/show_bug.cgi?id=174393
3959         <rdar://problem/33248006>
3960
3961         Reviewed by Chris Fleizach.
3962
3963         * DumpRenderTree/AccessibilityUIElement.cpp:
3964         (textMarkerRangeMatchesTextNearMarkersCallback):
3965         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3966         (AccessibilityUIElement::getJSClass):
3967         * DumpRenderTree/AccessibilityUIElement.h:
3968         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3969         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3970         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3971         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3972         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3973         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3974         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3975         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3976
3977 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
3978
3979         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
3980         https://bugs.webkit.org/show_bug.cgi?id=174197
3981
3982         Reviewed by Darin Adler.
3983
3984         This bit me the first time I tried to submit a patch to WebKit, and still I have
3985         to manually edit the ChangeLog every time I use the script.
3986
3987         This generates a more convenient and standard ChangeLog entry.
3988
3989         * Scripts/prepare-ChangeLog:
3990         (generateNewChangeLogs):
3991
3992 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3993
3994         Unreviewed, rolling out r219401.
3995
3996         This revision rolled out the previous patch, but after talking
3997         with reviewer, a rebaseline is what was needed.Rolling back in
3998         before rebaseline.
3999
4000         Reverted changeset:
4001
4002         "Unreviewed, rolling out r219379."
4003         https://bugs.webkit.org/show_bug.cgi?id=174400
4004         http://trac.webkit.org/changeset/219401
4005
4006 2017-07-12  Matt Lewis  <jlewis3@apple.com>
4007
4008         Unreviewed, rolling out r219379.
4009
4010         This revision caused a consistent failure in the test
4011         fast/dom/Window/property-access-on-cached-window-after-frame-
4012         removed.html.
4013
4014         Reverted changeset:
4015
4016         "Remove NAVIGATOR_HWCONCURRENCY"
4017         https://bugs.webkit.org/show_bug.cgi?id=174400
4018         http://trac.webkit.org/changeset/219379
4019
4020 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
4021
4022         [WPE] Use libepoxy
4023         https://bugs.webkit.org/show_bug.cgi?id=172104
4024
4025         Reviewed by Michael Catanzaro.
4026
4027         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
4028         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
4029
4030 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
4031
4032         [GTK][WPE] Align Jhbuild patches for GStreamer packages
4033         https://bugs.webkit.org/show_bug.cgi?id=174363
4034
4035         Reviewed by Michael Catanzaro.
4036
4037         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
4038         between the GTK+ and WPE port. There's no reason for the two ports to apply
4039         different patches over same versions of GStreamer releases.
4040
4041         This aligns the two ports on this specific issue. Next we'll look into
4042         creating a single GStreamer-specific Jhbuild moduleset that will allow us
4043         to keep these patches in a single place, avoiding duplicate files.
4044
4045         * gtk/jhbuild.modules:
4046         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
4047         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
4048         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
4049         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
4050
4051 2017-07-11  Dean Jackson  <dino@apple.com>
4052
4053         Remove NAVIGATOR_HWCONCURRENCY
4054         https://bugs.webkit.org/show_bug.cgi?id=174400
4055
4056         Reviewed by Sam Weinig.
4057
4058         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4059
4060 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
4061
4062         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
4063         https://bugs.webkit.org/show_bug.cgi?id=174239
4064
4065         Reviewed by Brady Eidson.
4066
4067         Create windows with specific features set and make sure those are properly reflected in the
4068         WKWindowFeatures object.
4069
4070         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
4071         (resetToConsistentState):
4072         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
4073         (TEST):
4074
4075 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
4076
4077         Do not duplicate files when deleting directories with svn 1.9
4078         https://bugs.webkit.org/show_bug.cgi?id=174339
4079         <rdar://problem/33226781>
4080
4081         Reviewed by David Kilzer.
4082
4083         * Scripts/svn-create-patch:
4084         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
4085         (generateFileList): Determine which files are deleted because they are part of a
4086         directory being deleted.
4087
4088 2017-07-11  Dean Jackson  <dino@apple.com>
4089
4090         Rolling out r219372.
4091
4092         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4093
4094 2017-07-11  Dean Jackson  <dino@apple.com>
4095
4096         Remove NAVIGATOR_HWCONCURRENCY
4097         https://bugs.webkit.org/show_bug.cgi?id=174400
4098
4099         Reviewed by Sam Weinig.
4100
4101         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4102
4103 2017-07-11  Lucas Forschler  <lforschler@apple.com>
4104
4105         Teach build workers to fetch archives from S3.
4106         https://bugs.webkit.org/show_bug.cgi?id=174384
4107
4108         Reviewed by Aakash Jain.
4109
4110         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4111         (DownloadBuiltProduct):
4112
4113 2017-07-11  Lucas Forschler  <lforschler@apple.com>
4114
4115         Configure buildbot to transfer all archives to S3.
4116         Previously this was Mac only, but it's time to expand!
4117         https://bugs.webkit.org/show_bug.cgi?id=174378
4118         
4119         Reviewed by Aakash Jain.
4120
4121         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4122         (BuildFactory.__init__):
4123
4124 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
4125
4126         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
4127         https://bugs.webkit.org/show_bug.cgi?id=174350
4128
4129         Reviewed by Xabier Rodriguez-Calvar.
4130
4131         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
4132         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
4133         patches are removed. The patches for gst-plugins-good are updated, removing
4134         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
4135         rtpbin elements that will help with the EMEv3 development.
4136
4137         * wpe/jhbuild.modules:
4138         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
4139         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
4140         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
4141         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
4142         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
4143         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
4144         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
4145         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
4146         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
4147
4148 2017-07-10  John Wilander  <wilander@apple.com>
4149
4150         Resource Load Statistics: Prune statistics in orders of importance
4151         https://bugs.webkit.org/show_bug.cgi?id=174215
4152         <rdar://problem/33164403>
4153
4154         Reviewed by Chris Dumez.
4155
4156         Nest infrastructure. Adds these functions:
4157         1. testRunner.setStatisticsLastSeen()
4158         2. setStatisticsMaxStatisticsEntries()
4159         3. setStatisticsPruneEntriesDownTo()
4160
4161         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4162         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4163         (WTR::TestRunner::setStatisticsLastSeen):
4164         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
4165         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
4166         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4167         * WebKitTestRunner/TestController.cpp:
4168         (WTR::TestController::setStatisticsLastSeen):
4169         (WTR::TestController::setMaxStatisticsEntries):
4170         (WTR::TestController::setPruneEntriesDownTo):
4171         * WebKitTestRunner/TestController.h:
4172         * WebKitTestRunner/TestInvocation.cpp:
4173         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4174         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4175         (WTR::TestController::setStatisticsLastSeen):
4176         (WTR::TestController::setStatisticsMaxStatisticsEntries):
4177         (WTR::TestController::setStatisticsPruneEntriesDownTo):
4178
4179 2017-07-03  Brian Burg  <bburg@apple.com>
4180
4181         Web Replay: remove some unused code
4182         https://bugs.webkit.org/show_bug.cgi?id=173903
4183
4184         Rubber-stamped by Joseph Pecoraro.
4185
4186         * Scripts/run-input-generator-tests: Removed.
4187         * Scripts/webkitpy/replay/__init__.py: Removed.
4188         * Scripts/webkitpy/replay/main.py: Removed.
4189
4190 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
4191
4192         [WPE] Fix layout test baseline and TestExpectations hierarchy
4193         https://bugs.webkit.org/show_bug.cgi?id=174092
4194
4195         Reviewed by Michael Catanzaro.
4196
4197         Like for the GTK+ port, override the default_baseline_search_path() and
4198         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
4199         Both methods operate on a short list of search paths that defaults to 'wpe' and
4200         'wk2', along with any other user-specified platform directory.
4201
4202         The test_expectations_file_position() method is overridden for testing purposes,
4203         and relevant unit tests are added.
4204
4205         * Scripts/webkitpy/port/wpe.py:
4206         (WPEPort._search_paths):
4207         (WPEPort):
4208         (WPEPort.default_baseline_search_path):
4209         (WPEPort._port_specific_expectations_files):
4210         (WPEPort.test_expectations_file_position):
4211         * Scripts/webkitpy/port/wpe_unittest.py:
4212         (WPEPortTest.test_default_baseline_search_path):
4213         (WPEPortTest):
4214         (WPEPortTest.test_port_specific_expectations_files):
4215
4216 2017-07-10  Chris Dumez  <cdumez@apple.com>
4217
4218         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
4219         https://bugs.webkit.org/show_bug.cgi?id=174301
4220
4221         Reviewed by Brent Fulgham.
4222
4223         Rename some of the testRunner API for clarity and to better match what it calls
4224         internally.
4225
4226         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4227         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4228         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
4229         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
4230         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4231         * WebKitTestRunner/TestController.cpp:
4232         (WTR::TestController::statisticsUpdateCookiePartitioning):
4233         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
4234         * WebKitTestRunner/TestController.h:
4235         * WebKitTestRunner/TestInvocation.cpp:
4236         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4237         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4238         (WTR::TestController::statisticsUpdateCookiePartitioning):
4239         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
4240
4241 2017-07-10  Charlie Turner  <cturner@igalia.com>
4242
4243         [GStreamer] Live twitch.tv videos do not play
4244         https://bugs.webkit.org/show_bug.cgi?id=174222
4245
4246         Reviewed by Michael Catanzaro.
4247
4248         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
4249         fixes videos not playing on twitch.tv.
4250
4251         * gtk/jhbuild.modules:
4252
4253 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
4254
4255         Add WebGL2 configuration option to build-webkit
4256         https://bugs.webkit.org/show_bug.cgi?id=174251
4257
4258         Reviewed by Michael Catanzaro.
4259
4260         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
4261         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
4262         is marked as enabled for the Apple Cocoa ports.
4263
4264 2017-07-08  Chris Dumez  <cdumez@apple.com>
4265
4266         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
4267     &n