Some build fixes for WKR and webkitbot.
[WebKit-https.git] / Tools / ChangeLog
1 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Some build fixes for WKR and webkitbot.
4
5         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
6         (IRCBotTest.test_help):
7         * Scripts/webkitpy/tool/commands/newcommitbot.py:
8         (Agent):
9         (Agent.__init__):
10         (Agent.name):
11         (NewCommitBot):
12         (NewCommitBot.begin_work_queue):
13         (NewCommitBot.next_work_item):
14         * Scripts/webkitpy/tool/commands/sheriffbot.py:
15         (SheriffBot):
16
17 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
18
19         Teach webkitbot and WKR how to respond to yt?
20         https://bugs.webkit.org/show_bug.cgi?id=116775
21
22         Reviewed by Andreas Kling.
23
24         * Scripts/webkitpy/tool/bot/irc_command.py:
25         (Hi): Fixed the usage string.
26         (Hi.execute): Made it more generic so that it works in WKR.
27         (YouThere): Added.
28         (YouThere.execute): Added.
29         * Scripts/webkitpy/tool/commands/newcommitbot.py:
30
31 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
32
33         Try to fix the EFL build.
34         
35         * DumpRenderTree/efl/TestRunnerEfl.cpp:
36         (TestRunner::setPageVisibility):
37
38 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
39
40         Unprefix Page Visibility API
41         https://bugs.webkit.org/show_bug.cgi?id=102340
42
43         Reviewed by Tim Horton.
44         
45         Rename "preview" state to "unloaded" state, and adjust the tests
46         to test for it.
47
48         * DumpRenderTree/mac/TestRunnerMac.mm:
49         (TestRunner::setPageVisibility):
50         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
51         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
52         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
53         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
54         (TestWebKitAPI::didRunStep4InStateUnloaded):
55         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
56         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
57         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
58         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
59         (WTR::TestRunner::setPageVisibility):
60
61 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
62
63         Unreviewed build fix. Don't use new NRWT logic needed
64         by Windows yet. Activate (and fix test) when we cut over.
65
66         * Scripts/webkitpy/port/driver.py:
67         (Driver._setup_environ_for_driver):
68         (Driver._start):
69
70 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
71
72         [Windows] Expose database storage and cache locations via preferences.
73         https://bugs.webkit.org/show_bug.cgi?id=116729
74
75         Reviewed by Tim Horton.
76
77         Update DumpRenderTree to use CFPreferences to control where WebKit
78         stores its local databases, URL caches, etc.
79
80         * DumpRenderTree/win/DumpRenderTree.cpp:
81         (libraryPathForDumpRenderTree): Added.
82         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
83         * Scripts/webkitpy/port/base.py:
84         (Port._driver_tempdir): Added (to allow port-specific overload).
85         (Port._driver_tempdir_for_environment): Ditto
86         * Scripts/webkitpy/port/driver.py:
87         (Driver._setup_environ_for_driver): Use new overload to set
88         environment variable.
89         (Driver._start): Use new overload for temp directory location.
90         * Scripts/webkitpy/port/win.py:
91         (WinPort._driver_tempdir_for_environment): New overload to supply
92         Windows path to DumpRenderTree environment (while still using
93         cygwin paths for internal operations.
94
95 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
96
97         Remove custom code for webkitAudioContext global constructor getter
98         https://bugs.webkit.org/show_bug.cgi?id=116530
99
100         Reviewed by Geoffrey Garen.
101
102         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
103         WebAudio feature instead of public ewk_view API since that API was
104         removed.
105
106         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
107         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
108         * DumpRenderTree/efl/TestRunnerEfl.cpp:
109         (TestRunner::overridePreference):
110
111 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
112
113         Make team.html have each contributor's area of expertise
114         https://bugs.webkit.org/show_bug.cgi?id=116737
115
116         Reviewed by Benjamin Poulain.
117
118         * Scripts/webkitpy/common/config/contributors.json:
119         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
120         
121         Changed formatting of the file because the lines are getting way to
122         long, and I generated this, so it's easier if the formatting of the
123         file is regular.
124
125 2013-05-24  Simon Pena  <simon.pena@samsung.com>
126
127         Update WTF::Vector pretty printers
128         https://bugs.webkit.org/show_bug.cgi?id=116719
129
130         Reviewed by Anders Carlsson.
131
132         After r148891, WTF::Vector pretty printers were left outdated, as
133         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
134         one as a member. This patch updates the pretty printers so they work
135         again. 
136
137         * gdb/webkit.py:
138         (WTFVectorPrinter.children):
139         (WTFVectorPrinter.to_string):
140
141 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
142
143         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
144         https://bugs.webkit.org/show_bug.cgi?id=116710
145
146         Reviewed by Mark Rowe.
147
148         * DumpRenderTree/mac/DumpRenderTree.mm:
149         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
150
151 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
152
153         Add missing dependencies to deps script.
154
155         [GTK] Missing packages in install-dependencies script.
156         https://bugs.webkit.org/show_bug.cgi?id=116632
157
158         Reviewed by Martin Robinson.
159
160         * gtk/install-dependencies:
161
162 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
163
164         [Windows] Unreviewed change for NRWT support.
165
166         * Scripts/webkitpy/port/win.py:
167         (WinPort.default_child_processes): Added a default implementation
168         that limits NRWT to a single instance.
169
170 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
171
172         Remove meaningless "test_uses_apache" from Python test cases.
173         https://bugs.webkit.org/show_bug.cgi?id=38756
174
175         Reviewed by Ryosuke Niwa.
176
177         * Scripts/webkitpy/port/port_testcase.py:
178         (PortTestCase.test_driver_cmd_line): Remove the meaningless
179         "test_uses_apache" test case from the Python test infrastructure.
180         It was hard-coded to true, even though not all ports use
181         Apache.
182
183 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
184
185         [Windows] Update new-run-webkit-tests for Windows port.
186         https://bugs.webkit.org/show_bug.cgi?id=38756
187
188         Reviewed by Ryosuke Niwa.
189
190         * Scripts/new-run-webkit-httpd:
191         (run): Switch from 'chromium' to 'win'
192         * Scripts/webkitpy/port/win.py:
193         (WinPort): Add support methods for lighttpd server.
194         (WinPort._uses_apache):
195         (WinPort._path_to_lighttpd):
196         (WinPort._path_to_lighttpd_modules):
197         (WinPort._path_to_lighttpd_php):
198
199 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
200
201         Make default bug links in buildbot clickable
202         https://bugs.webkit.org/show_bug.cgi?id=116673
203
204         Reviewed by Ryosuke Niwa.
205
206         Use changecommentlink of html.WebStatus to make the links clickable.
207
208         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
209
210 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
211
212         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
213         https://bugs.webkit.org/show_bug.cgi?id=116595
214
215         Temporarily skip this test.
216
217         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
218         (TestWebKitAPI::TEST):
219
220 2013-05-22  Alex Christensen  <achristensen@apple.com>
221
222         Unreviewed.  Added myself to contributors.json.
223
224         * Scripts/webkitpy/common/config/contributors.json:
225         Added myself.
226
227 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
228
229         [EFL][WK2] Add sub menus to MiniBrowser
230         https://bugs.webkit.org/show_bug.cgi?id=114728
231
232         Reviewed by Christophe Dumez.
233
234         Elementary Ctxpopup widget API does not provide support for submenu item.
235         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
236         Elementary Menu widget.
237
238         * MiniBrowser/efl/main.c:
239         (_Browser_Window):
240         (on_window_resize):
241         (window_free):
242         (context_menu_item_selected_cb):
243         (context_menu_populate):
244         (on_context_menu_show):
245         (on_context_menu_hide):
246         (window_create):
247
248 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
249
250         [EFL] Add command line option to MiniBrowser to set cookies policy.
251         https://bugs.webkit.org/show_bug.cgi?id=115028
252
253         Reviewed by Christophe Dumez.
254
255         Add command line option to MiniBrowser EFL to set cookies policy:
256         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
257         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
258
259         * MiniBrowser/efl/main.c:
260         (elm_main):
261
262 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
263
264         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
265         https://bugs.webkit.org/show_bug.cgi?id=116585
266
267         Reviewed by Alexey Proskuryakov.
268
269         willLoadURLRequest and willLoadDataRequest require the API version 6.
270
271         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
272
273 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
274
275         REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
276         https://bugs.webkit.org/show_bug.cgi?id=116516
277
278         Reviewed by Alexey Proskuryakov.
279
280         Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
281
282         * DumpRenderTree/mac/DumpRenderTree.mm:
283         (createWebViewAndOffscreenWindow): Match the ordering.
284         (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
285
286 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
287
288         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
289         https://bugs.webkit.org/show_bug.cgi?id=116568
290
291         Reviewed by Anders Carlsson.
292
293         * WebKitTestRunner/WebNotificationProvider.cpp:
294         (WTR::WebNotificationProvider::~WebNotificationProvider):
295         * WebKitTestRunner/WebNotificationProvider.h:
296         When the provider is destroyed, it should no longer be registered with the manager.
297
298         * WebKitTestRunner/GeolocationProviderMock.cpp:
299         (WTR::GeolocationProviderMock::~GeolocationProviderMock):
300         * WebKitTestRunner/GeolocationProviderMock.h:
301         I wasn't seeing a crash here, but this code has the same issue as notification
302         provider, so applying the same fix.
303
304         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
305         Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
306         destructor having fixed the above.
307
308 2013-05-21  Commit Queue  <commit-queue@webkit.org>
309
310         Unreviewed, rolling out r150386 and r150397.
311         http://trac.webkit.org/changeset/150386
312         http://trac.webkit.org/changeset/150397
313         https://bugs.webkit.org/show_bug.cgi?id=116572
314
315         Broke a test; Alex is going to try again later. (Requested by
316         thorton on #webkit).
317
318         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
319         (WTR::pathSuitableForTestResult):
320         (WTR::dumpRequestDescriptionSuitableForTestResult):
321         (WTR::dumpResponseDescriptionSuitableForTestResult):
322         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
323         (WTR::InjectedBundlePage::didInitiateLoadForResource):
324         (WTR::InjectedBundlePage::willSendRequestForFrame):
325         (WTR::InjectedBundlePage::didReceiveResponseForResource):
326         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
327         (InjectedBundlePage):
328
329 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
330
331         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
332
333         * Scripts/webkitpy/tool/commands/suggestnominations.py:
334         (AbstractCommitLogCommand._recent_commit_messages):
335
336 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
337
338         [GTK] [CMake] Add support for building WebKit2
339         https://bugs.webkit.org/show_bug.cgi?id=116372
340
341         Reviewed by Gustavo Noronha Silva.
342
343         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
344         * MiniBrowser/gtk/CMakeLists.txt: Added.
345
346 2013-05-21  Jessie Berlin  <jberlin@apple.com>
347
348         Revert r149635, it was too optimistic.
349
350         Rubber-stamped by Andreas Kling.
351
352         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
353         #ifdefs in WebCore code outside of WebCore/platform.
354
355         * Scripts/webkitpy/style/checkers/cpp.py:
356         (check_invalid_increment):
357         (process_line):
358         (CppChecker):
359         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
360         (CppStyleTest.test_plain_integral_bitfields):
361
362 2013-05-21  Jer Noble  <jer.noble@apple.com>
363
364         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
365
366         * lldb/lldb_webkit.py:
367         (WTFVectorProvider.num_children):
368         (WTFVectorProvider.get_child_index):
369         (WTFVectorProvider.get_child_at_index):
370         (WTFVectorProvider.update):
371
372 2013-05-21  Jessie Berlin  <jberlin@apple.com>
373
374         Expose a way to know when forms are added to a page or when form controls are added to a form
375         in the injected bundle
376         https://bugs.webkit.org/show_bug.cgi?id=116334
377
378         Reviewed by Alexey Proskuryakov.
379
380         Add tests for the new callbacks.
381
382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
383         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
384
385         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
386         (TestWebKitAPI::nullJavaScriptCallback):
387         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
388         being passed in for the callback.
389         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
390         After receiving the message that didAssociateFormControls callback was invoked from adding
391         the form in the onload handler, tell the page to add a password field to the form, which
392         should also invoke didAssociateFormControls callback.
393         (TestWebKitAPI::setInjectedBundleClient):
394         Register to receive messages.
395         (TestWebKitAPI::TEST):
396         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
397         been invoked for both adding the form and for adding a password field to the form.
398
399         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
400         (TestWebKitAPI::shouldNotifyOnFormChanges):
401         Return true so the didAssociateFormControls callback is invoked.
402         (TestWebKitAPI::didAssociateFormControls):
403         Tell the UI process.
404         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
405         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
406         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
407
408         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
409         Add a form in response to the onload event. Add a button that will add the password field
410         for manual testing.
411
412 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
413
414         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
415         https://bugs.webkit.org/show_bug.cgi?id=106341
416
417         Reviewed by Martin Robinson.
418
419         Adds support for retrieving accessibility element at exact point.
420
421         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
422         (WTR::AccessibilityUIElement::elementAtPoint):
423
424 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
425
426         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
427         https://bugs.webkit.org/show_bug.cgi?id=112913
428
429         Reviewed by Martin Robinson.
430
431         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
432         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
433         so the leak appears.
434
435         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
436         (WTR):
437         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
438         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
439         (WTR::AccessibilityController::rootElement):
440         (WTR):
441         (WTR::AccessibilityController::focusedElement):
442         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
443         (WTR::checkElementState):
444         (WTR::indexRangeInTable):
445         (WTR::alterCurrentValue):
446         (WTR::AccessibilityUIElement::getChildren):
447         (WTR::AccessibilityUIElement::getChildrenWithRange):
448         (WTR::AccessibilityUIElement::childrenCount):
449         (WTR::AccessibilityUIElement::indexOfChild):
450         (WTR::AccessibilityUIElement::titleUIElement):
451         (WTR::AccessibilityUIElement::parentElement):
452         (WTR::AccessibilityUIElement::allAttributes):
453         (WTR::AccessibilityUIElement::role):
454         (WTR::AccessibilityUIElement::title):
455         (WTR::AccessibilityUIElement::description):
456         (WTR::AccessibilityUIElement::orientation):
457         (WTR::AccessibilityUIElement::stringValue):
458         (WTR::AccessibilityUIElement::language):
459         (WTR::AccessibilityUIElement::x):
460         (WTR::AccessibilityUIElement::y):
461         (WTR::AccessibilityUIElement::width):
462         (WTR::AccessibilityUIElement::height):
463         (WTR::AccessibilityUIElement::intValue):
464         (WTR::AccessibilityUIElement::minValue):
465         (WTR::AccessibilityUIElement::maxValue):
466         (WTR::AccessibilityUIElement::isEnabled):
467         (WTR::AccessibilityUIElement::isFocused):
468         (WTR::AccessibilityUIElement::isSelected):
469         (WTR::AccessibilityUIElement::isExpanded):
470         (WTR::AccessibilityUIElement::isChecked):
471         (WTR::AccessibilityUIElement::rowCount):
472         (WTR::AccessibilityUIElement::columnCount):
473         (WTR::AccessibilityUIElement::rowIndexRange):
474         (WTR::AccessibilityUIElement::columnIndexRange):
475         (WTR::AccessibilityUIElement::cellForColumnAndRow):
476         (WTR::AccessibilityUIElement::increment):
477         (WTR::AccessibilityUIElement::decrement):
478         (WTR::AccessibilityUIElement::press):
479         (WTR::AccessibilityUIElement::documentEncoding):
480         (WTR::AccessibilityUIElement::documentURI):
481         (WTR::AccessibilityUIElement::isFocusable):
482         (WTR::AccessibilityUIElement::isSelectable):
483         (WTR::AccessibilityUIElement::isMultiSelectable):
484         (WTR::AccessibilityUIElement::isVisible):
485
486 2013-05-20  Lucas Forschler  <lforschler@apple.com>
487
488     Rollout 150398.
489     
490 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
491
492         [GTK] Fix concatenations of string literals that are not C++11-compliant
493         https://bugs.webkit.org/show_bug.cgi?id=116449
494
495         Reviewed by Martin Robinson.
496
497         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
498         is simply a matter of separating the string and the string literal that are being concatenated with a space.
499
500         * ImageDiff/gtk/ImageDiff.cpp:
501         (printImage):
502
503 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
504
505         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
506         https://bugs.webkit.org/show_bug.cgi?id=116450
507
508         Reviewed by Martin Robinson.
509
510         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
511         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
512         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
513         TestWebKitAPI programs when compiling them.
514
515         * TestWebKitAPI/GNUmakefile.am:
516
517 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
518
519         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
520         https://bugs.webkit.org/show_bug.cgi?id=116492
521
522         Reviewed by Dirk Pranke.
523
524         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
525
526         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
527         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
528         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
529         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
530         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
531         to memory pressure on the machine.
532
533         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
534         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
535         for a subsequent patch just to make things easier to follow.
536
537         * Scripts/webkitpy/port/driver.py:
538         (DriverProxy.__init__):
539         (DriverProxy.run_test):
540         (DriverProxy.has_crashed):
541         (DriverProxy.stop):
542
543 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
544
545         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
546         https://bugs.webkit.org/show_bug.cgi?id=116423
547
548         Reviewed by Ryosuke Niwa.
549
550         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
551
552         * BuildSlaveSupport/build.webkit.org-config/config.json:
553
554 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
555
556         Remove remaining link-prerender code
557         https://bugs.webkit.org/show_bug.cgi?id=116429
558
559         Reviewed by Darin Adler.
560
561         Link prerendering code was removed in r150356.
562
563         * Scripts/webkitperl/FeatureList.pm:
564         * qmake/mkspecs/features/features.pri:
565
566 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
567
568         commit-queue should check for oops in changelog entries
569         https://bugs.webkit.org/show_bug.cgi?id=116395
570
571         Reviewed by Martin Robinson.
572
573         Make changelog validation fail when it contains oops!.
574
575         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
576         (CommitQueueTask._validate_changelog):
577         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
578         (CommitQueueTaskTest._run_through_task):
579         * Scripts/webkitpy/tool/commands/queues_unittest.py:
580         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
581         (ValidateChangeLogs.options):
582         (ValidateChangeLogs._check_changelog_diff):
583         (ValidateChangeLogs._changelog_contains_oops):
584         (ValidateChangeLogs.run):
585         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
586         (ValidateChangeLogsTest._assert_start_line_produces_output):
587         (ValidateChangeLogsTest.test_check_changelog_diff):
588         (ValidateChangeLogsTest):
589         (ValidateChangeLogsTest.test_changelog_contains_oops):
590
591 2013-05-20  Jessie Berlin  <jberlin@apple.com>
592
593         Expose a way to know when forms are added to a page or when form controls are added to a form
594         in the injected bundle
595         https://bugs.webkit.org/show_bug.cgi?id=116334
596
597         Reviewed by Alexey Proskuryakov.
598
599         Add tests for the new callbacks.
600
601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
602         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
603
604         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
605         (TestWebKitAPI::nullJavaScriptCallback):
606         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
607         being passed in for the callback.
608         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
609         After receiving the message that didAssociateFormControls callback was invoked from adding
610         the form in the onload handler, tell the page to add a password field to the form, which
611         should also invoke didAssociateFormControls callback.
612         (TestWebKitAPI::setInjectedBundleClient):
613         Register to receive messages.
614         (TestWebKitAPI::TEST):
615         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
616         been invoked for both adding the form and for adding a password field to the form.
617
618         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
619         (TestWebKitAPI::shouldNotifyOnFormChanges):
620         Return true so the didAssociateFormControls callback is invoked.
621         (TestWebKitAPI::didAssociateFormControls):
622         Tell the UI process.
623         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
624         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
625         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
626
627         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
628         Add a form in response to the onload event. Add a button that will add the password field
629         for manual testing.
630
631 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
632
633         [EFL][JHBUILD] Make sure eet is built before evas
634         https://bugs.webkit.org/show_bug.cgi?id=116440
635
636         Reviewed by Gyuyoung Kim.
637
638         Mark eet as a dependency of evas since evas requires eet to enable some of its
639         functionality.
640
641         * efl/jhbuild.modules:
642
643 2013-05-20  Alex Christensen  <achristensen@apple.com>
644
645         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
646         https://bugs.webkit.org/show_bug.cgi?id=116125
647
648         Reviewed by Tim Horton.
649
650         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
651         (WTR::pathSuitableForTestResult):
652         Changed string operations to match _drt_descriptionSuitableForTestResult.
653         (WTR::dumpRequestDescriptionSuitableForTestResult):
654         (WTR::dumpResponseDescriptionSuitableForTestResult):
655         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
656         (WTR::InjectedBundlePage::didInitiateLoadForResource):
657         (WTR::InjectedBundlePage::willSendRequestForFrame):
658         (WTR::InjectedBundlePage::didReceiveResponseForResource):
659         Pass the main frame's URL to pathSuitableForTestResult.
660         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
661         Added WKBundlePageRef to willPerformClientRedirectForFrame.
662
663 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
664
665         fix w3c test importer unit tests after r150324
666         https://bugs.webkit.org/show_bug.cgi?id=116459
667
668         Reviewed by Ryosuke Niwa.
669
670         This patch fixes the unit tests to not actually call out to
671         'hg' (by using a mock executive) and also changes the real
672         directory we crawl from Source/WebCore/css to
673         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
674         still change this to a mock filesystem, but that's a separate change.
675
676         * Scripts/webkitpy/w3c/test_importer.py:
677         (main):
678         (TestImporter.__init__):
679         (TestImporter.load_changeset):
680         * Scripts/webkitpy/w3c/test_importer_unittest.py:
681         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
682         (TestImporterTest.test_import_dir_with_no_tests):
683
684 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
685
686         Unreviewed EFL build fix.
687
688         Fix linking errors due to undefined symbols on Ubuntu 13.04.
689
690         * DumpRenderTree/efl/CMakeLists.txt:
691         * EWebLauncher/CMakeLists.txt:
692         * MiniBrowser/efl/CMakeLists.txt:
693
694 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
695
696         [EFL] Reenabled INDEXED_DATABASE after r150344
697         https://bugs.webkit.org/show_bug.cgi?id=116430
698
699         Reviewed by Gyuyoung Kim.
700
701         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
702         build was fixed in r150344.
703
704         * Scripts/webkitperl/FeatureList.pm:
705
706 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
707
708         [EFL] init/shutdown should be paired in EWebLauncher
709         https://bugs.webkit.org/show_bug.cgi?id=116427
710
711         Reviewed by Christophe Dumez.
712
713         Added ecore_file_shutdown() for cleanup of ecore_file.
714         Removed edje_init and ecore_evas_init because it was in ewk_init().
715
716         * EWebLauncher/main.c:
717         (main):
718
719 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
720
721         [EFL] Add command line option to MiniBrowser to set user agent
722         https://bugs.webkit.org/show_bug.cgi?id=116387
723
724         Reviewed by Christophe Dumez.
725
726         We need this option to compare the rendering differences according to different user agents.
727
728         * MiniBrowser/efl/main.c:
729         (window_create):
730         (elm_main):
731
732 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
733
734         Unreviewed, addressing test-webkitpy failures after r150317.
735
736         * Scripts/webkitpy/w3c/test_converter.py:
737         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
738
739 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
740
741         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
742         https://bugs.webkit.org/show_bug.cgi?id=114554
743
744         Reviewed by Gyuyoung Kim.
745
746         Using variables as target names is very uncommon in CMake.
747         The usual way to specify the name of the resulting binary
748         is to set the OUTPUT_NAME target property.
749
750         * DumpRenderTree/efl/CMakeLists.txt:
751         * EWebLauncher/CMakeLists.txt:
752         * ImageDiff/CMakeLists.txt:
753         * MiniBrowser/efl/CMakeLists.txt:
754         * TestWebKitAPI/CMakeLists.txt:
755         * WebKitTestRunner/CMakeLists.txt:
756         * WebKitTestRunner/PlatformEfl.cmake:
757         * WinCELauncher/CMakeLists.txt:
758
759 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
760
761         Unreviewed EFL build fix.
762
763         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
764         WK2 build after r150305.
765
766         * Scripts/webkitperl/FeatureList.pm:
767
768 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
769
770         [GTK] Parallel build fails if gtk-doc is enabled
771         https://bugs.webkit.org/show_bug.cgi?id=116227
772
773         Reviewed by Martin Robinson.
774
775         * GNUmakefile.am:
776         Don't use the 'all' target to generate the documentation.
777         The prerequisites of this target must be files that need to be
778         built _before_ the actual compilation of WebKit starts. Since the
779         documentation depends on WebKit being built first, this means in
780         practice that the code will be built in parallel with the
781         generation of its dependencies, potentially making the build fail.
782
783 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
784
785         Don't run hg.
786
787         * Scripts/webkitpy/w3c/test_importer_unittest.py:
788         (TestImporterTest):
789
790 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
791
792         Create a script to import W3C tests
793         https://bugs.webkit.org/show_bug.cgi?id=111513
794
795         Reviewed by Ryosuke Niwa.
796
797         This patch attempts to re-land the 'import-w3c-tests'
798         script and accompanying modules.  The tests and code have
799         been cleaned up so that we do not log anything to stdout/stderr
800         while running the tests (thanks to outputcapture) and do not
801         write into the source tree while running the tests, and much
802         but not all of the code has been converted over to using the webkitpy
803
804         * Scripts/import-w3c-tests: Added.
805         * Scripts/webkitpy/w3c/__init__.py: Added.
806         * Scripts/webkitpy/w3c/test_converter.py: Added.
807         (W3CTestConverter):
808         (W3CTestConverter.__init__):
809         (W3CTestConverter.path_from_webkit_root):
810         (W3CTestConverter.read_webkit_prefixed_css_property_list):
811         (W3CTestConverter.convert_for_webkit):
812         (W3CTestConverter.convert_css):
813         (W3CTestConverter.convert_html):
814         (W3CTestConverter.convert_testharness_paths):
815         (W3CTestConverter.convert_prefixed_properties):
816         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
817         (W3CTestConverter.replace_tag):
818         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
819         (W3CTestConverterTest):
820         (W3CTestConverterTest.fake_dir_path):
821         (W3CTestConverterTest.test_read_prefixed_property_list):
822         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
823         (test_convert_for_webkit_harness_only):
824         (test_convert_for_webkit_properties_only):
825         (test_convert_for_webkit_harness_and_properties):
826         (test_convert_test_harness_paths):
827         (test_convert_prefixed_properties):
828         (verify_conversion_happened):
829         (verify_no_conversion_happened):
830         (verify_test_harness_paths):
831         (verify_prefixed_properties):
832         (generate_test_content):
833         * Scripts/webkitpy/w3c/test_importer.py: Added.
834         (main):
835         (parse_args):
836         (validate_import_directory):
837         (TestImporter):
838         (TestImporter.__init__):
839         (TestImporter.path_from_webkit_root):
840         (TestImporter.do_import):
841         (TestImporter.load_changeset):
842         (TestImporter.find_importable_tests):
843         (TestImporter.import_tests):
844         (TestImporter.setup_destination_directory):
845         (TestImporter.update_test_status):
846         (TestImporter.remove_deleted_files):
847         (TestImporter.write_import_log):
848         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
849         (TestImporterTest):
850         (TestImporterTest.test_import_dir_with_no_tests):
851         * Scripts/webkitpy/w3c/test_parser.py: Added.
852         (TestParser):
853         (TestParser.__init__):
854         (TestParser.load_file):
855         (TestParser.analyze_test):
856         (TestParser.reference_links_of_type):
857         (TestParser.is_jstest):
858         (TestParser.support_files):
859         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
860         (TestParserTest):
861         (TestParserTest.test_analyze_test_reftest_one_match):
862         (test_analyze_test_reftest_multiple_matches):
863         (test_analyze_test_reftest_match_and_mismatch):
864         (test_analyze_test_reftest_with_ref_support_Files):
865         (test_analyze_jstest):
866         (test_analyze_pixel_test_all_true):
867         (test_analyze_pixel_test_all_false):
868         (test_analyze_non_html_file):
869
870 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
871
872         Leaks builders exit early frequently
873         https://bugs.webkit.org/show_bug.cgi?id=116355
874
875         Reviewed by Stephanie Lewis.
876
877         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
878         we tolerate from 20 to 50.
879
880         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
881         (RunWebKitTests.start):
882         * Scripts/webkitpy/port/mac.py:
883         (MacPort.default_child_processes):
884
885 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
886
887         Remove chrome-channels command from the webkit-patch
888         https://bugs.webkit.org/show_bug.cgi?id=116303
889
890         Reviewed by Ryosuke Niwa.
891
892         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
893         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
894         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
895         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
896         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
897         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
898
899 2013-05-17  David Kilzer  <ddkilzer@apple.com>
900
901         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
902         Part 3 of 3: <http://webkit.org/b/116247>
903
904         Reviewed by Benjamin Poulain.
905
906         * Scripts/filter-build-webkit: Change while() loop to for() loop
907         to track $previousLine, then pass $previousLine into
908         shouldIgnoreLine().
909         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
910         line that begins with four spaces if the previous line is a
911         linker error message.
912         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
913         - Add "Ignored: " to test descriptions to document expected
914           behavior.
915         - Add comment blocks for various groups of tests.
916         - Expand "Build settings" tests since we're changing the code in
917           shouldIgnoreLine() that ignores those lines.
918         - Add tests for undefined symbols error message.
919         (description): Add.  Extract from global code.
920
921 2013-05-17  David Kilzer  <ddkilzer@apple.com>
922
923         Add tests for shouldIgnoreLine() in filter-build-webkit
924         Part 2 of 3: <http://webkit.org/b/116247>
925
926         Reviewed by Benjamin Poulain.
927
928         * Scripts/filter-build-webkit:
929         (shouldIgnoreLine): Add.  Extract code from global scope into
930         subroutine to make it testable.
931         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
932         Tests shouldIgnoreLine() using output from a real build
933         transcript.
934
935 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
936
937         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
938         https://bugs.webkit.org/show_bug.cgi?id=116341
939
940         Reviewed by Brady Eidson.
941
942         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
943
944 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
945
946         [Windows] Don't use pdevenv when building with VS2010.
947         https://bugs.webkit.org/show_bug.cgi?id=116338.
948
949         Reviewed by Adam Roben.
950
951         * Scripts/webkitdirs.pm:
952         (setupCygwinEnv): Check if we are using VS2005, and only use
953         the 'pdevenv' hack if we are. Otherwise, just build with
954         our standard project since it uses VS2010+'s native
955         parallel building features.
956
957 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
958
959         Unreviewed. Disable accelerated compositing until we figure out why it does not work
960         properly in the 64 bits release bot.
961
962         * DumpRenderTree/gtk/DumpRenderTree.cpp:
963         (resetDefaultsToConsistentValues):
964
965 2013-05-17  David Kilzer  <ddkilzer@apple.com>
966
967         Make filter-build-webkit testable using LoadAsModule
968         Part 1 of 3: <http://webkit.org/b/116247>
969
970         Reviewed by Benjamin Poulain.
971
972         * Scripts/filter-build-webkit: Change global variables that are
973         used in subroutines from 'my' to 'our' to make it possible to
974         evaluate the script in a package context in LoadAsModule.pm.
975
976 2013-05-14  Sam Weinig  <sam@webkit.org>
977
978         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
979         https://bugs.webkit.org/show_bug.cgi?id=116132
980
981         Reviewed by Anders Carlsson.
982
983         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
984         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
985
986         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
987         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
988         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
989         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
990
991 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
992
993         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
994         https://bugs.webkit.org/show_bug.cgi?id=114781
995
996         Reviewed by Christophe Dumez.
997
998         Add run_before_unload_confirm and
999         Print the log message with "CONFIRM NAVIGATION: " in console.
1000
1001         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1002         (onBeforeUnloadConfirm):
1003         (drtViewAdd):
1004
1005 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
1006
1007         Fix Analyze ChangeLog's entry processing
1008         https://bugs.webkit.org/show_bug.cgi?id=116219
1009
1010         Reviewed by Ryosuke Niwa.
1011
1012         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1013         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
1014
1015 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
1016
1017         [Qt] UrlLoader::loadNext is broken in MiniBrowser
1018         https://bugs.webkit.org/show_bug.cgi?id=116099
1019
1020         Reviewed by Jocelyn Turcotte.
1021
1022         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
1023         are not available any more. So, UrlLoader::loadNext was broken
1024         because it failed to connect to those signals.
1025
1026         * MiniBrowser/qt/UrlLoader.cpp:
1027         (UrlLoader::UrlLoader):
1028         (UrlLoader::loadingChanged):
1029         * MiniBrowser/qt/UrlLoader.h:
1030         (UrlLoader):
1031
1032 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
1033
1034         [WebSocket] Update pywebsocket to r760
1035         https://bugs.webkit.org/show_bug.cgi?id=115863
1036
1037         Reviewed by Alexey Proskuryakov.
1038
1039         Version r760 supports a newer draft of message compression.
1040         We need this update to finish the permessage compression patch in
1041         bug 98840. This patch also fixes failing unit tests after the update.
1042
1043         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
1044         (StreamBase._read):
1045         (StreamBase._read.of):
1046         (StreamBase._write):
1047         (StreamBase.receive_bytes):
1048         (StreamBase._read_until):
1049         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
1050         (parse_frame):
1051         (StreamOptions.__init__):
1052         (Stream.__init__):
1053         (Stream._receive_frame_as_frame_object):
1054         (Stream._get_message_from_frame):
1055         (Stream._process_close_message):
1056         (Stream.close_connection):
1057         (Stream.get_last_received_opcode):
1058         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
1059         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
1060         (Dispatcher.do_extra_handshake):
1061         (Dispatcher.transfer_data):
1062         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
1063         (ExtensionProcessorInterface.__init__):
1064         (ExtensionProcessorInterface.request):
1065         (ExtensionProcessorInterface):
1066         (ExtensionProcessorInterface.name):
1067         (ExtensionProcessorInterface.check_consistency_with_other_processors):
1068         (ExtensionProcessorInterface.set_active):
1069         (ExtensionProcessorInterface.is_active):
1070         (ExtensionProcessorInterface._get_extension_response_internal):
1071         (ExtensionProcessorInterface.get_extension_response):
1072         (ExtensionProcessorInterface._setup_stream_options_internal):
1073         (ExtensionProcessorInterface.setup_stream_options):
1074         (_log_outgoing_compression_ratio):
1075         (_log_incoming_compression_ratio):
1076         (_parse_window_bits):
1077         (_AverageRatioCalculator):
1078         (_AverageRatioCalculator.__init__):
1079         (_AverageRatioCalculator.add_original_bytes):
1080         (_AverageRatioCalculator.add_result_bytes):
1081         (_AverageRatioCalculator.get_average_ratio):
1082         (DeflateFrameExtensionProcessor):
1083         (DeflateFrameExtensionProcessor.__init__):
1084         (DeflateFrameExtensionProcessor._get_extension_response_internal):
1085         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
1086         (DeflateFrameExtensionProcessor._outgoing_filter):
1087         (DeflateFrameExtensionProcessor._incoming_filter):
1088         (CompressionExtensionProcessorBase.for):
1089         (CompressionExtensionProcessorBase.__init__):
1090         (CompressionExtensionProcessorBase._get_extension_response_internal):
1091         (CompressionExtensionProcessorBase._setup_stream_options_internal):
1092         (PerFrameCompressExtensionProcessor):
1093         (PerMessageDeflateExtensionProcessor):
1094         (PerMessageDeflateExtensionProcessor.__init__):
1095         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
1096         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
1097         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
1098         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
1099         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
1100         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
1101         (PerMessageDeflateExtensionProcessor.set_bfinal):
1102         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
1103         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
1104         (_PerMessageDeflateFramer):
1105         (_PerMessageDeflateFramer.__init__):
1106         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
1107         (_PerMessageDeflateFramer._process_incoming_message):
1108         (_PerMessageDeflateFramer._process_outgoing_message):
1109         (_PerMessageDeflateFramer.setup_stream_options):
1110         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
1111         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
1112         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
1113         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
1114         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
1115         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
1116         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
1117         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
1118         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
1119         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
1120         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
1121         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
1122         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
1123         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
1124         (PerMessageCompressExtensionProcessor):
1125         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
1126         (MuxExtensionProcessor.__init__):
1127         (MuxExtensionProcessor.check_consistency_with_other_processors):
1128         (MuxExtensionProcessor):
1129         (MuxExtensionProcessor._get_extension_response_internal):
1130         (MuxExtensionProcessor._setup_stream_options_internal):
1131         (MuxExtensionProcessor.set_quota):
1132         (MuxExtensionProcessor.quota):
1133         (MuxExtensionProcessor.set_extensions):
1134         (MuxExtensionProcessor.extensions):
1135         (is_compression_extension):
1136         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
1137         (validate_subprotocol):
1138         (parse_host_header):
1139         (format_header):
1140         (check_request_line):
1141         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
1142         (Handshaker.do_handshake):
1143         (Handshaker._create_handshake_response):
1144         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
1145         (_validate_subprotocol):
1146         (_check_header_lines):
1147         (_build_location):
1148         (Handshaker.do_handshake):
1149         (Handshaker._set_subprotocol):
1150         (Handshaker._set_location):
1151         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
1152         (_create_dispatcher):
1153         (headerparserhandler):
1154         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
1155         (_create_add_channel_response):
1156         (_create_drop_channel):
1157         (_create_flow_control):
1158         (_create_new_channel_slot):
1159         (_create_fallback_new_channel_slot):
1160         (_MuxFramePayloadParser._read_number):
1161         (_MuxFramePayloadParser._read_size_and_contents):
1162         (_MuxFramePayloadParser._read_flow_control):
1163         (_MuxFramePayloadParser._read_new_channel_slot):
1164         (_LogicalConnection.__init__):
1165         (_LogicalConnection.write):
1166         (_LogicalConnection.on_write_data_done):
1167         (_LogicalConnection):
1168         (_LogicalConnection.on_writer_done):
1169         (_InnerMessage):
1170         (_InnerMessage.__init__):
1171         (_InnerMessageBuilder):
1172         (_InnerMessageBuilder.that):
1173         (_InnerMessageBuilder.__init__):
1174         (_InnerMessageBuilder._handle_first):
1175         (_InnerMessageBuilder._process_first_fragmented_control):
1176         (_InnerMessageBuilder._process_first_fragmented_message):
1177         (_InnerMessageBuilder._handle_fragmented_control):
1178         (_InnerMessageBuilder._reassemble_fragmented_control):
1179         (_InnerMessageBuilder._handle_fragmented_message):
1180         (_InnerMessageBuilder._reassemble_fragmented_message):
1181         (_InnerMessageBuilder.build):
1182         (_LogicalStream.__init__):
1183         (_LogicalStream._create_inner_frame):
1184         (_LogicalStream._write_inner_frame):
1185         (_LogicalStream.replenish_send_quota):
1186         (_LogicalStream.send_message):
1187         (_LogicalStream._receive_frame):
1188         (_LogicalStream._get_message_from_frame):
1189         (_LogicalStream.stop_sending):
1190         (_PhysicalConnectionWriter.__init__):
1191         (_PhysicalConnectionWriter._write_data):
1192         (_PhysicalConnectionWriter.run):
1193         (_PhysicalConnectionWriter.stop):
1194         (_Worker.run):
1195         (_MuxHandshaker.__init__):
1196         (_MuxHandshaker._create_stream):
1197         (_MuxHandshaker._create_handshake_response):
1198         (_HandshakeDeltaBase.create_headers):
1199         (_MuxHandler.start):
1200         (_MuxHandler.wait_until_done):
1201         (_MuxHandler.notify_write_data_done):
1202         (_MuxHandler._process_drop_channel):
1203         (_MuxHandler._process_logical_frame):
1204         (_MuxHandler.notify_reader_done):
1205         (_MuxHandler):
1206         (_MuxHandler.notify_writer_done):
1207         (_MuxHandler.fail_physical_connection):
1208         (_MuxHandler.fail_logical_channel):
1209         (use_mux):
1210         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
1211         (_StandaloneRequest.get_uri):
1212         (_StandaloneRequest.get_unparsed_uri):
1213         (_StandaloneRequest):
1214         (_StandaloneRequest.is_https):
1215         (_import_ssl):
1216         (_import_pyopenssl):
1217         (_StandaloneSSLConnection.for):
1218         (_StandaloneSSLConnection):
1219         (_StandaloneSSLConnection.__getattribute__):
1220         (_StandaloneSSLConnection.__setattr__):
1221         (_StandaloneSSLConnection.makefile):
1222         (_StandaloneSSLConnection.shutdown):
1223         (_StandaloneSSLConnection.recv):
1224         (WebSocketServer.__init__):
1225         (WebSocketServer._create_sockets):
1226         (WebSocketServer.handle_error):
1227         (WebSocketServer.get_request):
1228         (WebSocketServer.get_request.default_callback):
1229         (WebSocketRequestHandler.parse_request):
1230         (_build_option_parser):
1231         (_main):
1232         (_main.if):
1233         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
1234         (RepeatedXorMasker.__init__):
1235         (RepeatedXorMasker._mask_using_swig):
1236         (RepeatedXorMasker):
1237         (RepeatedXorMasker._mask_using_array):
1238         (_Deflater.compress_and_finish):
1239         (_RFC1979Deflater.filter):
1240         (DeflateSocket.send):
1241
1242 2013-05-16  Jonathan Liu  <net147@gmail.com>
1243
1244         Fix testing if program exists in PATH
1245         https://bugs.webkit.org/show_bug.cgi?id=116216
1246
1247         Reviewed by Jocelyn Turcotte.
1248
1249         functions.prf incorrectly uses win_cmd_shell to test whether to
1250         add .exe to the executable name when checking if it exists in
1251         the PATH environment variable. This works correctly when
1252         building using Windows Command Prompt but not under MSYS shell.
1253
1254         To resolve this, check the win32 platform scope instead of
1255         win_cmd_shell so that it correctly adds .exe to the executable
1256         name on Windows regardless of the shell used when testing if
1257         it exists in PATH.
1258
1259         * qmake/mkspecs/features/functions.prf:
1260
1261 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
1262
1263         Fix the hard-coded names of EWS bots that run tests.
1264
1265         * Scripts/webkitpy/tool/commands/queues.py:
1266         (CommitQueue.did_pass_testing_ews):
1267
1268 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1269
1270         [GTK] Build Xvfb with jhbuild
1271         https://bugs.webkit.org/show_bug.cgi?id=115907
1272
1273         Reviewed by Martin Robinson.
1274
1275         Build our own Xvfb so that we can avoid problems with the system Xvfb
1276         relying on symbols not present in our jhbuilt libraries such as pixman,
1277         and also to ensure we have the fix for a GLX module crasher.
1278
1279         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1280         (resetDefaultsToConsistentValues): enable accelerated compositing.
1281         * gtk/install-dependencies: list packages required for building Xvfb.
1282         * gtk/jhbuild.modules: add xserver as a jhbuild module.
1283         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
1284         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
1285         initializing the GLX module for Xvfb.
1286
1287 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1288
1289         [jhbuild] Should remove the sources directory as well when cleaning
1290         https://bugs.webkit.org/show_bug.cgi?id=116229
1291
1292         Reviewed by Martin Robinson.
1293
1294         * Scripts/update-webkit-libs-jhbuild:
1295         (cleanJhbuild): remove the Source directory as well when cleaning.
1296
1297 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
1298
1299         [EFL] Remove Intel Wk2 Buildbots from Master
1300         https://bugs.webkit.org/show_bug.cgi?id=116149
1301
1302         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
1303         since Gyuyoung Kim from Samsung plans to take over and maintain it.
1304
1305         Reviewed by Benjamin Poulain.
1306
1307         * BuildSlaveSupport/build.webkit.org-config/config.json:
1308
1309 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
1310
1311         [Windows] Update various build tools to understand VS2010 environment.
1312         https://bugs.webkit.org/show_bug.cgi?id=116169.
1313
1314         Reviewed by Anders Carlsson.
1315
1316         * Scripts/build-api-tests: Identify VS2010 environment.
1317         * Scripts/build-dumprendertree: Ditto.
1318         * Scripts/build-webkit: Ditto.
1319         * Scripts/webkitdirs.pm:
1320         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
1321         range of acceptable SDK's.
1322
1323 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
1324
1325         Allow http tests on Arch Linux
1326         https://bugs.webkit.org/show_bug.cgi?id=116155
1327
1328         Reviewed by Ryosuke Niwa.
1329
1330         * Scripts/webkitpy/port/base.py:
1331         (Port._is_arch_based): Added check for /etc/arch-release file.
1332         (Port._apache_config_file_name_for_platform): Call the check.
1333         * Scripts/webkitpy/port/port_testcase.py:
1334         (test_linux_distro_detection): Testcase added.
1335
1336 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
1337
1338         Remove a leftover v8 file from the watchlist
1339         https://bugs.webkit.org/show_bug.cgi?id=116158
1340
1341         Reviewed by Csaba Osztrogonác.
1342
1343         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
1344
1345 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
1346
1347         [GTK] Fails to build while generating gtkdoc
1348         https://bugs.webkit.org/show_bug.cgi?id=115612
1349
1350         Reviewed by Philippe Normand.
1351
1352         Fix typo in the prerequisites of docs-build.stamp.
1353
1354         * GNUmakefile.am:
1355
1356 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
1357
1358         Unreviewed, fixing the current test-webkitpy failure.
1359
1360         * Scripts/webkitpy/port/mac_unittest.py:
1361         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
1362         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
1363
1364 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
1365
1366         Fix build after r150090.
1367         https://bugs.webkit.org/show_bug.cgi?id=116129
1368
1369         Unreviewed build fix after r150090.
1370
1371         * WebKitTestRunner/TestInvocation.cpp:
1372         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1373
1374 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1375
1376         [Windows, others] Unreviewed build fix after r150090.
1377
1378         * DumpRenderTree/TestRunner.cpp:
1379         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
1380         doesn't exist on other platforms.
1381
1382 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
1383
1384         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
1385         https://bugs.webkit.org/show_bug.cgi?id=115889
1386
1387         Reviewed by Benjamin Poulain.
1388
1389         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1390         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1391
1392 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1393
1394         [Windows] Identify proper run environment for scripts.
1395         https://bugs.webkit.org/show_bug.cgi?id=116114
1396
1397         Reviewed by David Kilzer.
1398
1399         Determine (based on Visual Studio version) which path to use for
1400         executables (bin versus bin32).
1401
1402         * Scripts/webkitdirs.pm:
1403         (determineVisualStudioInstallDir): Added.
1404         (determineVisualStudioVersion): Added.
1405         (determineConfigurationProductDir): Modified to choose proper bin
1406         or bin32 directory.
1407         (visualStudioVersion): Added
1408         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
1409
1410 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1411
1412         [Mac] Add tests for secure event input
1413         https://bugs.webkit.org/show_bug.cgi?id=116121
1414
1415         Reviewed by Mark Rowe.
1416
1417         * DumpRenderTree/TestRunner.cpp:
1418         (getSecureEventInputIsEnabledCallback):
1419         (TestRunner::staticValues):
1420         Expose an accessor for current secure event input state.
1421
1422         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1423         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1424         (WTR::TestRunner::secureEventInputIsEnabled):
1425         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1426         * WebKitTestRunner/TestInvocation.cpp:
1427         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1428         Expose an accessor for current secure event input state. This has to be done in
1429         UI process, as this is where it's changed by WebKit.
1430
1431 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
1432
1433         [Mac] Add a testing shim for secure event input functions
1434         https://bugs.webkit.org/show_bug.cgi?id=116122
1435
1436         Reviewed by Mark Rowe.
1437
1438         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
1439         Inject WebCore testing shim library to override system framework functions.
1440
1441 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1442
1443         [Windows] Switch to embedded manifest commands for launcher executables.
1444         https://bugs.webkit.org/show_bug.cgi?id=116109
1445
1446         Reviewed by Darin Adler.
1447
1448         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
1449         now-unused WinLauncher.exe.manifest file.
1450         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1451         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
1452         when building with VS2010 or newer.
1453
1454 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
1455
1456         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
1457         https://bugs.webkit.org/show_bug.cgi?id=116079
1458
1459         Reviewed by David Kilzer.
1460
1461         * Scripts/old-run-webkit-tests:
1462         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
1463
1464 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
1465
1466         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
1467         https://bugs.webkit.org/show_bug.cgi?id=115921
1468
1469         Reviewed by Gustavo Noronha Silva.
1470
1471         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
1472         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
1473
1474 2013-05-13  Alex Christensen  <achristensen@apple.com>
1475
1476         Added testRunner.setPrinting.
1477         https://bugs.webkit.org/show_bug.cgi?id=42693
1478         rdar://problem/8213845
1479
1480         Reviewed by Darin Adler.
1481
1482         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1483         Added setPrinting JavaScript function.
1484         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1485         (WTR::InjectedBundlePage::dump):
1486         Dump the external representation for printing if setPrinting has been called.
1487         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1488         (WTR::TestRunner::isPrinting): Added.
1489         (WTR::TestRunner::setPrinting): Added.
1490         Added and initialized m_isPrinting member boolean.
1491
1492 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
1493
1494         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
1495         https://bugs.webkit.org/show_bug.cgi?id=116016
1496
1497         Reviewed by Dirk Pranke.
1498
1499         Same fix as in the upstream style checker, but without hg support.
1500         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
1501
1502         * Scripts/webkitpy/style/checkers/cpp.py:
1503         (FileInfo.repository_name):
1504
1505 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
1506
1507         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
1508         https://bugs.webkit.org/show_bug.cgi?id=115918
1509
1510         Reviewed by Gustavo Noronha Silva.
1511
1512         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
1513         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
1514         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
1515         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
1516         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
1517         problems.
1518
1519         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
1520         These are then used as dependencies for the archive creation rule as well as the list from which the archive
1521         file paths are constructed and then used to dump the member files from these archives. The member files are
1522         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
1523         successfully link.
1524
1525         * TestWebKitAPI/GNUmakefile.am:
1526
1527 2013-05-13  Anders Carlsson  <andersca@apple.com>
1528
1529         Remove UnusedParam.h
1530         https://bugs.webkit.org/show_bug.cgi?id=116029
1531
1532         Reviewed by Andreas Kling.
1533
1534         Stop including UnusedParam.h.
1535
1536         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1537         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1538
1539 2013-05-12  Commit Queue  <commit-queue@webkit.org>
1540
1541         Unreviewed, rolling out r149955.
1542         http://trac.webkit.org/changeset/149955
1543         https://bugs.webkit.org/show_bug.cgi?id=115990
1544
1545         Broke lots of tests (Requested by smfr on #webkit).
1546
1547         * Scripts/webkitpy/port/mac.py:
1548
1549 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1550
1551         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
1552         https://bugs.webkit.org/show_bug.cgi?id=115914
1553
1554         Reviewed by Martin Robinson.
1555
1556         * GtkLauncher/main.c:
1557         (createToolbar):
1558         * MiniBrowser/gtk/BrowserWindow.c:
1559         (_BrowserWindow):
1560         (browserWindowSetStatusText):
1561         (fullScreenMessageTimeoutCallback):
1562         (webViewEnterFullScreen):
1563         (webViewLeaveFullScreen):
1564         (browserWindowFinalize):
1565         (browserWindowConstructed):
1566         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1567         (WTR::EventSenderProxy::mouseScrollBy):
1568         (WTR::EventSenderProxy::continuousMouseScrollBy):
1569
1570 2013-05-11  Anders Carlsson  <andersca@apple.com>
1571
1572         Crash when terminating a process that has not been fully launched
1573         https://bugs.webkit.org/show_bug.cgi?id=115962
1574         <rdar://problem/13660916>
1575
1576         Reviewed by Andreas Kling.
1577
1578         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
1579         before the process has had a chance to be fully launched.
1580
1581         * TestWebKitAPI/GNUmakefile.am:
1582         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1583         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
1584         (TestWebKitAPI):
1585         (TestWebKitAPI::didFinishLoadForFrame):
1586         (TestWebKitAPI::TEST):
1587         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1588
1589 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
1590
1591         Remove Mac OS X Leopard (10.5) support
1592         https://bugs.webkit.org/show_bug.cgi?id=107964
1593
1594         Reviewed by Ryosuke Niwa.
1595
1596         Removed the code for 10.5 and removed if-def for 10.6.
1597
1598         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1599         (convertMIMEType):
1600         (createXMLStringFromWebArchiveData):
1601         * DumpRenderTree/mac/TestRunnerMac.mm:
1602         (TestRunner::authenticateSession):
1603         (TestRunner::setTextDirection):
1604         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1605         (convertMIMEType):
1606         (createXMLStringFromWebArchiveData):
1607
1608 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
1609
1610         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
1611         https://bugs.webkit.org/show_bug.cgi?id=115935
1612
1613         Reviewed by Jer Noble.
1614
1615         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
1616         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
1617         to the new manifest file.
1618         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1619
1620 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
1621
1622         Fix some compiler warnings (miscellaneous)
1623         https://bugs.webkit.org/show_bug.cgi?id=80790
1624
1625         Reviewed by Rob Buis.
1626
1627         Fix the following warnings for BlackBerry:
1628         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
1629         used as truth value [-Wparentheses].
1630
1631         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1632         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1633
1634 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1635
1636         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
1637         https://bugs.webkit.org/show_bug.cgi?id=115928
1638
1639         Reviewed by Kenneth Rohde Christiansen.
1640
1641         WKViewSetThemePath was moved to WKViewEfl.h.
1642
1643         * TestWebKitAPI/efl/PlatformWebView.cpp:
1644
1645 2013-05-10  Andreas Kling  <akling@apple.com>
1646
1647         I accidentally the Java testing.
1648
1649         * Scripts/webkitpy/port/mac.py:
1650
1651 2013-05-10  Brian Holt  <brian.holt@samsung.com>
1652
1653         [GTK] Module Cairo fails to build under jhbuild
1654         https://bugs.webkit.org/show_bug.cgi?id=115854
1655
1656         Reviewed by Martin Robinson.
1657
1658         Make cairo depend on glib in jhbuild.modules.
1659
1660         * gtk/jhbuild.modules:
1661
1662 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1663
1664         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
1665         https://bugs.webkit.org/show_bug.cgi?id=115904
1666
1667         Reviewed by Martin Robinson.
1668
1669         * ImageDiff/gtk/ImageDiff.cpp:
1670         (main):
1671
1672 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
1673
1674         Add my new address to contributors.json. (Unreviewed)
1675
1676         * Scripts/webkitpy/common/config/contributors.json:
1677
1678 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1679
1680         Unreviewed. Move myself to the reviewers list.
1681
1682         * Scripts/webkitpy/common/config/contributors.json:
1683
1684 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1685
1686         Unreviewed. Add my email to a few watchlists.
1687
1688         * Scripts/webkitpy/common/config/watchlist:
1689
1690 2013-05-10  Simon Pena  <simon.pena@samsung.com>
1691
1692         Unicode support missing from string representation of Contributors in committers.py
1693         https://bugs.webkit.org/show_bug.cgi?id=115859
1694
1695         Reviewed by Darin Adler.
1696
1697         Contributors, in committers.py, provided a string representation in __str__ which
1698         didn't support unicode characters, so printing a contributor would fail in that case.
1699         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
1700         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
1701
1702         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
1703         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
1704         representation.
1705         (Contributor.__str__):
1706         (Contributor):
1707         (Contributor.__unicode__):
1708         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
1709         a contributor with unicode characters can be represented as a string.
1710         (CommittersTest):
1711         (CommittersTest.test_contributor_encoding):
1712
1713 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1714
1715         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
1716         https://bugs.webkit.org/show_bug.cgi?id=92371
1717
1718         Reviewed by Brent Fulgham.
1719
1720         Use JavaScriptThreading.cpp where the same functionality is
1721         implemented too. This reduces the dependency on the pthread
1722         library. Also replace assert() with WebKit ASSERT().
1723
1724         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1725         * DumpRenderTree/win/DumpRenderTree.cpp:
1726         (dumpHistoryItem):
1727         (dumpBackForwardList):
1728         * DumpRenderTree/win/DumpRenderTree.vcproj:
1729
1730 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
1731
1732         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
1733         https://bugs.webkit.org/show_bug.cgi?id=92505
1734
1735         Reviewed by Brent Fulgham.
1736
1737         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1738         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
1739         (javaScriptThreadsMutex):
1740         (javaScriptThreads):
1741         (runJavaScriptThread):
1742         (startJavaScriptThreads):
1743         (stopJavaScriptThreads):
1744         * DumpRenderTree/pthreads: Removed.
1745         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
1746
1747 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1748
1749         Unreviewed. Update Simon Pena email on his behalf.
1750
1751         * Scripts/webkitpy/common/config/contributors.json:
1752
1753 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1754
1755         Add support for [NoInterfaceObject] Web IDL extended attribute
1756         https://bugs.webkit.org/show_bug.cgi?id=115714
1757
1758         Reviewed by Kentaro Hara.
1759
1760         Update BindingsTests.generate_supplemental_dependency() to pass an
1761         additional windowConstructorsFile argument to preprocess-idls.pl.
1762
1763         * Scripts/webkitpy/bindings/main.py:
1764         (BindingsTests.generate_supplemental_dependency):
1765         (BindingsTests.main):
1766
1767 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
1768
1769         [GTK][AC] Buildfix after r149694
1770         https://bugs.webkit.org/show_bug.cgi?id=115797
1771
1772         Reviewed by Gustavo Noronha Silva.
1773
1774         Add CLUTTER_LIBS for linking TestWebCore.
1775
1776         * TestWebKitAPI/GNUmakefile.am:
1777
1778 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1779
1780         [EFL] Remove unnecessary pkgs in EFL jhbuild
1781         https://bugs.webkit.org/show_bug.cgi?id=114908
1782
1783         Reviewed by Laszlo Gombos.
1784
1785         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
1786         handle them using jhbuild. We can reduce build time when using --update-efl.
1787
1788         * efl/jhbuild.modules:
1789
1790 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
1791
1792         [EFL] Disable SHADOW DOM feature in FeatureList.pm
1793         https://bugs.webkit.org/show_bug.cgi?id=115834
1794
1795         Reviewed by Gyuyoung Kim.
1796
1797         * Scripts/webkitperl/FeatureList.pm:
1798
1799 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1800
1801         Add Scheduler for Mac MtnLion 32bit Release builder.
1802         
1803         Unreviewed.
1804         
1805         * BuildSlaveSupport/build.webkit.org-config/config.json:
1806
1807 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
1808
1809         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
1810         https://bugs.webkit.org/show_bug.cgi?id=115808
1811
1812         Reviewed by Darin Adler.
1813
1814         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
1815         was left outdated after r127191, when the m_string member was changed
1816         from UString to String. This patch calls the right pretty printer for it.
1817
1818         * gdb/webkit.py:
1819         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
1820         WTFImplPrettyPrinter.
1821
1822 2013-05-08  Andy Estes  <aestes@apple.com>
1823
1824         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
1825         https://bugs.webkit.org/show_bug.cgi?id=115790
1826
1827         Reviewed by Alexey Proskuryakov.
1828
1829         Added two API tests:
1830
1831         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
1832         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
1833
1834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1835         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
1836         (TestWebKitAPI):
1837         (TestWebKitAPI::TEST):
1838         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
1839         (TestWebKitAPI):
1840         (TestWebKitAPI::decidePolicyForNavigationAction):
1841         (CustomProtocolInvalidSchemeTest):
1842         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
1843
1844 2013-05-08  Lucas Forschler  <lforschler@apple.com>
1845
1846         Teach buildbot how to compile 32-bit on Mac.
1847
1848         Reviewed by Ryosuke Niwa.
1849
1850         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1851         (CompileWebKit.start):
1852         (ExtractTestResultsAndLeaks):
1853
1854 2013-05-08  Eli Fidler  <efidler@blackberry.com>
1855
1856         [BlackBerry] Fix usage of BlackBerry::Platform::String
1857         https://bugs.webkit.org/show_bug.cgi?id=115781
1858
1859         Reviewed by Rob Buis.
1860
1861         BlackBerry PRs 304193 and 327181
1862         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
1863
1864         We currently have a problem where we're passing UTF-8 encoded data into
1865         the char* constructors of BlackBerry::Platform::String. This means the string
1866         thinks its data is not UTF-8.
1867
1868         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1869         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1870         (BlackBerry::WebKit::dumpHistoryItem):
1871         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1872         (TestRunner::setUserStyleSheetLocation):
1873         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1874         (LoadHTMLStringItem::invoke):
1875
1876 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
1877
1878         Tools: add new BlackBerry include dirs.
1879         https://bugs.webkit.org/show_bug.cgi?id=115514
1880
1881         Reviewed by Rob Buis.
1882
1883         iType include dirs are missing, and HarfBuzz needs to be fixed.
1884
1885         * Scripts/webkitdirs.pm:
1886         (blackberryCMakeArguments):
1887
1888 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
1889
1890         [GTK] Plumb the Automake build system for the Battery Status API feature
1891         https://bugs.webkit.org/show_bug.cgi?id=115718
1892
1893         Reviewed by Martin Robinson.
1894
1895         * Scripts/webkitdirs.pm:
1896         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
1897         through the --(enable|disable)-battery-status flag passed to configure.
1898
1899 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
1900
1901         new-run-webkit-websocketserver doesn't work after Chromium removal
1902         https://bugs.webkit.org/show_bug.cgi?id=115816
1903
1904         Reviewed by Joseph Pecoraro.
1905
1906         Fix the bug by instantiating the correct port object.
1907
1908         * Scripts/new-run-webkit-websocketserver:
1909         (main):
1910
1911 2013-05-07  Lucas Forschler  <lforschler@apple.com>
1912
1913         Configure buildbot for 32bit builder.
1914         https://bugs.webkit.org/show_bug.cgi?id=115769
1915         
1916         Reviewed by Ryosuke Niwa.
1917
1918         * BuildSlaveSupport/build.webkit.org-config/config.json:
1919
1920 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
1921
1922         Unreviewed. Update to show my apple.com address.
1923
1924         * Scripts/webkitpy/common/config/contributors.json: Added
1925         my apple.com e-mail address.
1926
1927 2013-05-08  David Kilzer  <ddkilzer@apple.com>
1928
1929         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
1930
1931         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1932         (concatenateAttributeAndValue): Switch to appendVector().
1933
1934 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1935
1936         [Qt][WTR] Fix the build on Mac after r149692
1937
1938         Unreviewed build fix.
1939
1940         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1941         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1942
1943 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1944
1945         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
1946         to the watchlist for Accessibility.
1947
1948         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
1949         * Scripts/webkitpy/common/config/watchlist: Added myself.
1950
1951 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
1952
1953         [Qt] Build fails with clang
1954         https://bugs.webkit.org/show_bug.cgi?id=115741
1955
1956         Reviewed by Benjamin Poulain.
1957
1958         Since r149112 std::move is used in AtomicString for compilers that
1959         support rvalue references and this requires a standard library
1960         implementing c++11 move semantics.
1961         We only explicitely require c++11 for WebKit2, but since clang supports
1962         rvalue references the build of subtargets using AtomicString fails because
1963         of missing std::move.
1964         It is safe to add CONFIG += c++11 for the whole project when using clang
1965         since we explicitely disable c++11 for ANGLE that had probems with libc++.
1966
1967         * qmake/mkspecs/features/unix/default_pre.prf:
1968
1969 2013-05-08  Darin Adler  <darin@apple.com>
1970
1971         Fix one more place that needed to use adoptCF/NS
1972         https://bugs.webkit.org/show_bug.cgi?id=115778
1973
1974         Reviewed by Benjamin Poulain.
1975
1976         Not sure why I missed this code last time, but found a bit more code that needs
1977         to switch to the newer style adoptCF/NS.
1978
1979         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1980         (convertWebResourceDataToString): Use adoptCF.
1981         (convertWebResourceResponseToDictionary): Ditto.
1982         (createXMLStringFromWebArchiveData): Ditto.
1983         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
1984         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
1985
1986 2013-05-08  Commit Queue  <commit-queue@webkit.org>
1987
1988         Unreviewed, rolling out r149271.
1989         http://trac.webkit.org/changeset/149271
1990         https://bugs.webkit.org/show_bug.cgi?id=115780
1991
1992         The mangled symbols are now enforced through LDFLAGS
1993         (Requested by zdobersek on #webkit).
1994
1995         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1996
1997 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
1998
1999         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
2000         https://bugs.webkit.org/show_bug.cgi?id=115636
2001
2002         Reviewed by Ryosuke Niwa.
2003
2004         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2005         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
2006         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
2007         while Chromium-specific, can't be removed just yet as there's more code that uses it.
2008
2009 2013-05-06  Darin Adler  <darin@apple.com>
2010
2011         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
2012         https://bugs.webkit.org/show_bug.cgi?id=115657
2013
2014         Reviewed by Sam Weinig.
2015
2016         This is similar to my last set of changes, but covers code that I missed with
2017         global replace using the Safari Xcode workspace.
2018
2019         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2020         (convertWebResourceDataToString):
2021         (convertWebResourceResponseToDictionary):
2022         (createXMLStringFromWebArchiveData):
2023         * DumpRenderTree/cg/ImageDiffCG.cpp:
2024         (createImageFromStdin):
2025         (createDifferenceImage):
2026         (main):
2027         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2028         (printPNG):
2029         (dumpBitmap):
2030         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2031         (BitmapContext::BitmapContext):
2032         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2033         (-[MockWebNotificationProvider init]):
2034         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2035         (createBitmapContext):
2036         * DumpRenderTree/mac/TestRunnerMac.mm:
2037         (TestRunner::addDisallowedURL):
2038         (TestRunner::applicationCacheDiskUsageForOrigin):
2039         (TestRunner::localStorageDiskUsageForOrigin):
2040         (TestRunner::clearApplicationCacheForOrigin):
2041         (TestRunner::deleteLocalStorageForOrigin):
2042         (TestRunner::copyDecodedHostName):
2043         (TestRunner::copyEncodedHostName):
2044         (TestRunner::queueLoad):
2045         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2046         (TestRunner::setMockGeolocationPositionUnavailableError):
2047         (TestRunner::setUserStyleSheetLocation):
2048         (TestRunner::setValueForUser):
2049         (TestRunner::overridePreference):
2050         (TestRunner::setPersistentUserStyleSheetLocation):
2051         (TestRunner::execCommand):
2052         (TestRunner::findString):
2053         (TestRunner::isCommandEnabled):
2054         (TestRunner::addOriginAccessWhitelistEntry):
2055         (TestRunner::removeOriginAccessWhitelistEntry):
2056         (TestRunner::addUserScript):
2057         (TestRunner::addUserStyleSheet):
2058         (TestRunner::evaluateInWebInspector):
2059         (TestRunner::evaluateScriptInIsolatedWorld):
2060         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2061         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
2062         (TestRunner::authenticateSession):
2063         (TestRunner::grantWebNotificationPermission):
2064         (TestRunner::denyWebNotificationPermission):
2065         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2066         (createCFURLResponseFromResponseData):
2067         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2068         (LoadItem::invoke):
2069         (LoadHTMLStringItem::invoke):
2070         (ScriptItem::invoke):
2071         * DumpRenderTree/win/DumpRenderTree.cpp:
2072         (substringFromIndex):
2073         (urlSuitableForTestResult):
2074         (lastPathComponent):
2075         (sharedCFURLCache):
2076         * DumpRenderTree/win/ImageDiffCairo.cpp:
2077         (createImageFromStdin):
2078         (main):
2079         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2080         (createBitmapContextFromWebView):
2081         * DumpRenderTree/win/TestRunnerWin.cpp:
2082         (TestRunner::setUserStyleSheetLocation):
2083         (TestRunner::setPersistentUserStyleSheetLocation):
2084         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2085         (TestWebKitAPI::TEST):
2086         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2087         (TestWebKitAPI::TEST):
2088         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2089         (TestWebKitAPI::TEST):
2090         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2091         (TestWebKitAPI::TEST):
2092         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2093         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2094         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
2095         (TestWebKitAPI::createWindow):
2096         (TestWebKitAPI::TEST):
2097         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2098         (TestWebKitAPI::TEST):
2099         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
2100         (TestWebKitAPI::AcceptsFirstMouse::runTest):
2101         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2102         (TestWebKitAPI::TEST):
2103         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
2104         (TestWebKitAPI::TEST):
2105         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
2106         (TestWebKitAPI::TEST):
2107         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2108         (TestWebKitAPI::TEST):
2109         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
2110         (TestWebKitAPI::TEST):
2111         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2112         (TestWebKitAPI::TEST):
2113         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
2114         (TestWebKitAPI::TEST):
2115         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2116         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
2117         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2118         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
2119         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
2120         (TestWebKitAPI::TEST):
2121         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
2122         (TestWebKitAPI::TEST):
2123         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2124         (TestWebKitAPI::TEST):
2125         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
2126         (TestWebKitAPI::TEST):
2127         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
2128         (TestWebKitAPI::TEST):
2129         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2130         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2131         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2132         (TestWebKitAPI::TEST):
2133         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2134         (TestWebKitAPI::TEST):
2135         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
2136         (TestWebKitAPI::TEST):
2137         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2138         (TestWebKitAPI::TEST):
2139         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
2140         (TestWebKitAPI::TEST):
2141         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
2142         (TestWebKitAPI::TEST):
2143         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
2144         (TestWebKitAPI::TEST):
2145         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2146         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2147         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2148         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
2149         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2150         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
2151         (WTR::testPathFromURL):
2152         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2153         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2154         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2155         (WTR::createCGContextFromImage):
2156         (WTR::dumpBitmap):
2157         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2158         * WebKitTestRunner/mac/EventSenderProxy.mm:
2159         (WTR::EventSenderProxy::mouseScrollBy):
2160         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2161         (WTR::PlatformWebView::windowSnapshotImage):
2162         * WebKitTestRunner/win/TestControllerWin.cpp:
2163         (WTR::TestController::initializeTestPluginDirectory):
2164         Use adoptCF and adoptNS.
2165
2166 2013-05-07  Alex Christensen  <achristensen@apple.com>
2167
2168         Fix a memory leak introduced in r149692
2169         https://bugs.webkit.org/show_bug.cgi?id=115766
2170
2171         Reviewed by Mark Rowe.
2172
2173         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
2174         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
2175
2176         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2177         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2178         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
2179
2180 2013-05-07  Darin Adler  <darin@apple.com>
2181
2182         [Win] Fix storage leak in Windows DumpRenderTree
2183         https://bugs.webkit.org/show_bug.cgi?id=115651
2184
2185         Reviewed by Sam Weinig.
2186
2187         * DumpRenderTree/win/DumpRenderTree.cpp:
2188         (lastPathComponent): Added a missing call to adoptCF.
2189
2190 2013-05-07  Alex Christensen  <achristensen@apple.com>
2191
2192         fixed a memory leak introduced by bug 42324 by using a RetainPtr
2193         https://bugs.webkit.org/show_bug.cgi?id=115760
2194
2195         Reviewed by Tim Horton.
2196
2197         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2198         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2199         fixed memory leak, added UNUSED_PARAM macros
2200
2201 2013-05-07  Alex Christensen  <achristensen@apple.com>
2202
2203         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
2204         https://bugs.webkit.org/show_bug.cgi?id=42324
2205         <rdar://problem/8193633>
2206
2207         Reviewed by Tim Horton.
2208
2209         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2210         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
2211         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2212         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2213         Added dumpDOMAsWebArchive code that is called when dumping.        
2214         (WTR::InjectedBundlePage::dump):
2215         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
2216         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2217         (InjectedBundlePage):
2218         Added dumpDOMAsWebArchive declaration.
2219         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
2220         (WTR::TestRunner::dumpDOMAsWebArchive):
2221         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
2222         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2223         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
2224         * Tools/WebKitTestRunner/cf: Added.
2225         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
2226         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
2227         (convertMIMEType):
2228         (convertWebResourceDataToString):
2229         (normalizeHTTPResponseHeaderFields):
2230         (normalizeWebResourceURL):
2231         (convertWebResourceResponseToDictionary):
2232         (compareResourceURLs):
2233         (createXMLStringFromWebArchiveData):
2234         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
2235         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
2236         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
2237         Copied from Tools/DumpRenderTree/mac for used functions.
2238         (createCFURLResponseFromResponseData):
2239         (supportedNonImageMIMETypes):
2240
2241 2013-05-07  Alex Christensen  <achristensen@apple.com>
2242
2243         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
2244         https://bugs.webkit.org/show_bug.cgi?id=115745
2245
2246         Reviewed by Tim Horton.
2247
2248         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2249         (compareResourceURLs):
2250         Updated style.
2251
2252 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
2253
2254         Add an 'isReadOnly' member to IDL parse tree structure
2255         https://bugs.webkit.org/show_bug.cgi?id=115704
2256
2257         Reviewed by Kentaro Hara.
2258
2259         Use newly added isReadOnly attribute.
2260
2261         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2262         (_generateHeaderFile):
2263         (_generateImplementationFile):
2264         (_staticValuesGetterImplementation):
2265
2266 2013-05-07  Anders Carlsson  <andersca@apple.com>
2267
2268         Remove AlwaysInline.h from WTF
2269         https://bugs.webkit.org/show_bug.cgi?id=115727
2270
2271         Reviewed by Brent Fulgham.
2272
2273         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
2274         to keep AlwaysInline.h around anymore.
2275
2276         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2277         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2278
2279 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
2280
2281         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
2282         https://bugs.webkit.org/show_bug.cgi?id=114808
2283
2284         Reviewed by Jocelyn Turcotte.
2285
2286         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
2287         (https://codereview.qt-project.org/#change,54234)
2288
2289         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2290         (WTR::WrapperWindow::handleStatusChanged):
2291
2292 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2293
2294         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
2295
2296         * Scripts/webkitpy/common/config/watchlist:
2297
2298 2013-05-06  Kangil Han  <kangil.han@samsung.com>
2299
2300         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
2301         https://bugs.webkit.org/show_bug.cgi?id=115645
2302
2303         Reviewed by Gyuyoung Kim.
2304
2305         To run performance tests in wk1, we need --no-timeout option implementation.
2306         So adopt it from gtk+ port.
2307
2308         * DumpRenderTree/efl/DumpRenderTree.cpp:
2309         (shouldSetWaitToDumpWatchdog):
2310         (parseCommandLineOptions):
2311         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
2312         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2313         (TestRunner::setWaitToDump):
2314
2315 2013-05-06  Commit Queue  <commit-queue@webkit.org>
2316
2317         Unreviewed, rolling out r149547.
2318         http://trac.webkit.org/changeset/149547
2319         https://bugs.webkit.org/show_bug.cgi?id=115682
2320
2321         Added unittests that fail on bots and spits out text into
2322         stdout (Requested by rniwa on #webkit).
2323
2324         * Scripts/import-w3c-tests: Removed.
2325         * Scripts/webkitpy/w3c/__init__.py: Removed.
2326         * Scripts/webkitpy/w3c/test_converter.py: Removed.
2327         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
2328         * Scripts/webkitpy/w3c/test_importer.py: Removed.
2329         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
2330         * Scripts/webkitpy/w3c/test_parser.py: Removed.
2331         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
2332
2333 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
2334
2335         [jhbuild] bump jhbuild version to take advantage of new improvements
2336         https://bugs.webkit.org/show_bug.cgi?id=115558
2337
2338         Reviewed by Martin Robinson.
2339
2340         One of the important improvements is jhbuild no longer fetches git
2341         repositories if they are already at the expected revision, which should
2342         make the EWS bots more robust to git servers unavailability.
2343
2344         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
2345
2346 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
2347
2348         [GTK] Add webkit_uri_scheme_request_finish_error
2349         https://bugs.webkit.org/show_bug.cgi?id=94316
2350
2351         Reviewed by Anders Carlsson.
2352
2353         * MiniBrowser/gtk/main.c:
2354         (miniBrowserErrorQuark): Add function to create a global quark for
2355         MiniBrowser.
2356         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
2357         function webkit_uri_scheme_request_finish_error().
2358
2359 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
2360
2361         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
2362         https://bugs.webkit.org/show_bug.cgi?id=113808
2363
2364         Reviewed by Rob Buis.
2365
2366         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
2367         to true for BlackBerry.
2368
2369         * Scripts/webkitperl/FeatureList.pm:
2370
2371 2013-05-06  Jessie Berlin  <jberlin@apple.com>
2372
2373         check-webkit-style should complain about a layering violation if platform-specific guards are
2374         used in WebCore outside of the platform directory
2375         https://bugs.webkit.org/show_bug.cgi?id=115567
2376
2377         Reviewed by Benjamin Poulain.
2378
2379         * Scripts/webkitpy/style/checkers/cpp.py:
2380         (check_for_webcore_platform_layering_violation):
2381         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
2382         (process_line):
2383         Add the check_for_webcore_platform_layering_violation.
2384         (CppChecker):
2385         List the new check.
2386
2387         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2388         (CppStyleTest.test_webcore_platform_layering_violation):
2389         Add tests.
2390
2391 2013-05-06  David Kilzer  <ddkilzer@apple.com>
2392
2393         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
2394         <http://webkit.org/b/115667>
2395
2396         Reviewed by Dirk Pranke.
2397
2398         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2399         (Bugzilla._check_create_bug_response): Update regex to work with
2400         Bugzilla 3.2.3 and 4.2.5.
2401         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2402         (test__check_create_bug_response): Add new test that covers both
2403         old and new <title> variations.
2404
2405 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2406
2407         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
2408         https://bugs.webkit.org/show_bug.cgi?id=115661
2409
2410         Reviewed by Ryosuke Niwa.
2411
2412         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
2413         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
2414         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
2415
2416         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2417         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2418
2419 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2420
2421         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
2422         https://bugs.webkit.org/show_bug.cgi?id=114603
2423
2424         Reviewed by Ryosuke Niwa.
2425
2426         * TestResultServer/generate_builders_json.py:
2427         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
2428         to represent these to be 'layout-test', for backwards compatibility.
2429         (main): Remove all the build.chromium.org masters.
2430         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
2431         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2432         (GenerateBuildersJsonTest):
2433         (GenerateBuildersJsonTest.test_generate_json_data):
2434         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
2435         test-running builders from the webkit.org master.
2436
2437 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2438
2439         [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
2440         https://bugs.webkit.org/show_bug.cgi?id=114988
2441
2442         Reviewed by Ryosuke Niwa.
2443
2444         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
2445         and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
2446         * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
2447         mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
2448         once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
2449
2450 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2451
2452         [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
2453         https://bugs.webkit.org/show_bug.cgi?id=114954
2454
2455         Reviewed by Ryosuke Niwa.
2456
2457         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2458         (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
2459         modifier unions in the list of modifiers.
2460         (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
2461         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
2462
2463 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
2464
2465         [Flakiness Dashboard] Simplify builder-name-based platform recognition
2466         https://bugs.webkit.org/show_bug.cgi?id=114957
2467
2468         Reviewed by Ryosuke Niwa.
2469
2470         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2471         (determineBuilderPlatform): Renamed from nonChromiumPlatform.
2472         (chromiumPlatform): Removed, unnecessary.
2473         (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
2474         to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
2475         the builder operates with debug builds, no webkit.org builders are named this way.
2476         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2477         (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
2478
2479 2013-05-06  Andy Estes  <aestes@apple.com>
2480
2481         Added two files I neglected to commit in r149589.
2482
2483         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2484         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2485
2486 2013-05-04  Andy Estes  <aestes@apple.com>
2487
2488         REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
2489         https://bugs.webkit.org/show_bug.cgi?id=115609
2490
2491         Reviewed by Oliver Hunt.
2492
2493         Added an API test.
2494
2495         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2496         * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2497         (+[TestDelegate shared]):
2498         (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2499         (-[TestDelegate webView:createWebViewWithRequest:]):
2500         (TestWebKitAPI):
2501         (TestWebKitAPI::TEST):
2502         * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2503
2504 2013-05-06  Antoine Quint  <graouts@apple.com>
2505
2506         Manage the presentation of the snapshotted plug-in using JavaScript
2507         https://bugs.webkit.org/show_bug.cgi?id=115548
2508
2509         Reviewed by Dean Jackson.
2510
2511         Take into account the new plugInExtraScript method added to support
2512         the injection of a JS file from the chrome client to customize the
2513         rendering of a snapshotted plug-in's shadow tree.
2514
2515         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2516         (WTR::InjectedBundlePage::InjectedBundlePage):
2517
2518 2013-05-05  Anders Carlsson  <andersca@apple.com>
2519
2520         Remove the Vector::append overload that takes a Vector
2521         https://bugs.webkit.org/show_bug.cgi?id=115535
2522
2523         Reviewed by Andreas Kling.
2524
2525         Use Vector::appendVector instead.
2526
2527         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2528         (concatenateAttributeAndValue):
2529         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2530         (WTR::concatenateAttributeAndValue):
2531
2532 2013-05-04  Sam Weinig  <sam@webkit.org>
2533
2534         REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
2535         <rdar://problem/13702008>
2536         https://bugs.webkit.org/show_bug.cgi?id=115607
2537
2538         Reviewed by Benjamin Poulain.
2539
2540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2541         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
2542         (TestWebKitAPI::didFinishLoadForFrame):
2543         (TestWebKitAPI::TEST):
2544         Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
2545
2546 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2547
2548         Unreviewed.
2549
2550         * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
2551
2552 2013-05-04  Mihnea Ovidenie  <mihnea@adobe.com>
2553
2554         Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
2555
2556         * Scripts/webkitpy/common/config/contributors.json:
2557
2558 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2559
2560         [GTK] Catch select.error exceptions in parse_output_lines
2561         https://bugs.webkit.org/show_bug.cgi?id=115253
2562
2563         Reviewed by Gustavo Noronha Silva.
2564
2565         Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
2566         output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
2567         builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
2568         error code and the error message) and the loop is re-entered.
2569
2570         * gtk/common.py:
2571         (parse_output_lines):
2572
2573 2013-05-04  Zan Dobersek  <zdobersek@igalia.com>
2574
2575         [GTK] Set up the TestWebCore in TestWebKitAPI
2576         https://bugs.webkit.org/show_bug.cgi?id=115237
2577
2578         Reviewed by Gustavo Noronha Silva.
2579
2580         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2581         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2582         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2583         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2584         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2585
2586         * TestWebKitAPI/GNUmakefile.am:
2587
2588 2013-05-03  Rebecca Hauck  <rhauck@adobe.com>
2589
2590         Create a script to import W3C tests
2591         https://bugs.webkit.org/show_bug.cgi?id=111513
2592
2593         Reviewed by Dirk Pranke.
2594
2595         Script to automate the import of W3C tests into WebKit. 
2596         For the full description of how it works, see the comments
2597         at the top of test_importer.py.
2598
2599         * Scripts/import-w3c-tests: Added.
2600         * Scripts/webkitpy/w3c/__init__.py: Added.
2601         * Scripts/webkitpy/w3c/test_converter.py: Added.
2602         (TestConverter):
2603         (TestConverter.__init__):
2604         (TestConverter.load_prefixed_prop_list):
2605         (TestConverter.load_file):
2606         (TestConverter.convert_for_webkit):
2607         (TestConverter.convert_testharness_paths):
2608         (TestConverter.convert_prefixed_properties):
2609         (TestConverter.scrub_unprefixed_props):
2610         (TestConverter.replace_tag):
2611         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2612         (TestConverterTest):
2613         (TestConverterTest.testLoadPrefixedPropList):
2614         (TestConverterTest.test_convertForWebkitNothingToConvert):
2615         (test_convertForWebkitHarnessOnly):
2616         (test_convertForWebkitPropsOnly):
2617         (test_convertForWebkitHarnessAndProps):
2618         (test_convertTestHarnessPaths):
2619         (test_convertPrefixedProperties):
2620         (verifyTestHarnessPaths):
2621         (verifyPrefixedProperties):
2622         (generateTestContent):
2623         * Scripts/webkitpy/w3c/test_importer.py: Added.
2624         (main):
2625         (parse_args):
2626         (validate_import_directory):
2627         (TestImporter):
2628         (TestImporter.__init__):
2629         (TestImporter.do_import):
2630         (TestImporter.get_changeset):
2631         (TestImporter.scan_source_directory):
2632         (TestImporter.import_tests):
2633         (TestImporter.setup_destination_directory):
2634         (TestImporter.get_test_status):
2635         (TestImporter.remove_deleted_files):
2636         (TestImporter.write_import_log):
2637         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2638         (TestImporterTest):
2639         (TestImporterTest.test_ImportDirWithNoTests):
2640         * Scripts/webkitpy/w3c/test_parser.py: Added.
2641         (TestParser):
2642         (TestParser.__init__):
2643         (TestParser.load_file):
2644         (TestParser.analyze_test):
2645         (TestParser.get_reftests):
2646         (TestParser.is_jstest):
2647         (TestParser.get_support_files):
2648         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2649         (TestParserTest):
2650         (TestParserTest.test_analyzeTestReftestOneMatch):
2651         (test_analyzeTestReftestMultipleMatches):
2652         (test_analyzeTestReftestMatchAndMismatch):
2653         (test_analyzeTestReftestWithRefSupportFiles):
2654         (test_analyzeJSTest):
2655         (test_analyzePixelTestAllTrue):
2656         (test_analyzePixelTestAllFalse):
2657         (test_analyzeNonHTMLFile):
2658
2659 2013-05-03  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2660
2661         Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
2662
2663         * Scripts/webkitpy/common/config/contributors.json:
2664
2665 2013-05-02  Nico Weber  <thakis@chromium.org>
2666
2667         Remove a stale script file.
2668         https://bugs.webkit.org/show_bug.cgi?id=115521
2669
2670         Reviewed by Anders Carlsson.
2671
2672         This script was added in
2673         https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
2674         Bakefile system that was removed in
2675         https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
2676         script just asserts when it's run and is useless.
2677
2678         * Scripts/update-sources-list.py: Removed.
2679
2680 2013-05-01  Glenn Adams  <glenn@skynav.com>
2681
2682         [webkitpy] Need abstract base class for commands that analyze commit logs
2683         https://bugs.webkit.org/show_bug.cgi?id=115391
2684
2685         Reviewed by Benjamin Poulain.
2686
2687         Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
2688         in preparation for adding two new commands that will reuse this functionality along with
2689         suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
2690         https://bugs.webkit.org/show_bug.cgi?id=115388.
2691
2692         No new tests as this patch does not change existing functionality or behavior.
2693
2694         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2695         (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
2696         (AbstractCommitLogCommand.__init__):
2697         (AbstractCommitLogCommand._init_options):
2698         (AbstractCommitLogCommand._parse_commit_message):
2699         (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
2700         (SuggestNominations.__init__): 
2701         (SuggestNominations._init_options):
2702
2703 2013-05-01  Seokju Kwon  <seokju.kwon@gmail.com>
2704
2705         Web Inspector: Fix check-inspector-strings script and fix localized strings
2706         https://bugs.webkit.org/show_bug.cgi?id=115495
2707
2708         Reviewed by Joseph Pecoraro.
2709
2710         * Scripts/check-inspector-strings:
2711
2712 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2713
2714         [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
2715         https://bugs.webkit.org/show_bug.cgi?id=115470
2716
2717         Reviewed by Martin Robinson.
2718
2719         In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
2720         not building either of the IOS, Windows or GTK-WK1 platforms.
2721
2722         Up until now the header was included for everything but the IOS and Windows platforms due to
2723         an incorrectly stated condition regarding the GTK platform.
2724
2725         * TestWebKitAPI/config.h:
2726
2727 2013-05-01  Zan Dobersek  <zdobersek@igalia.com>
2728
2729         [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
2730         https://bugs.webkit.org/show_bug.cgi?id=115469
2731
2732         Reviewed by Martin Robinson.
2733
2734         Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
2735         for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
2736         for the WebKit2 tests and the injected bundle required by them.
2737
2738         This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
2739         tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
2740         under the WebKit2 code).
2741
2742         The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
2743         while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
2744         TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
2745
2746         * TestWebKitAPI/GNUmakefile.am:
2747
2748 2013-04-30  Glenn Adams  <glenn@skynav.com>
2749
2750         Unreviewed. Add myself to watchlist entries.
2751
2752         * Scripts/webkitpy/common/config/watchlist:
2753
2754 2013-04-30  Glenn Adams  <glenn@skynav.com>
2755
2756         [webkitpy] suggest-nominations doesn't count all qualified patches
2757         https://bugs.webkit.org/show_bug.cgi?id=115285
2758
2759         Reviewed by Benjamin Poulain.
2760
2761         Fix commit analysis so that patches made by an existing committer are counted towards reviewer
2762         nomination. Improve commit log parsing.
2763
2764         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2765         (CommitLogError):
2766         (CommitLogError.__init__):
2767         (CommitLogMissingReviewer):
2768         (CommitLogMissingReviewer.__init__):
2769         (SuggestNominations):
2770         (SuggestNominations.__init__):
2771         (SuggestNominations._recent_commit_messages):
2772         (SuggestNominations._author_name_from_email):
2773         (SuggestNominations._contributor_from_email):
2774         (SuggestNominations._parse_commit_message):
2775         (SuggestNominations._count_commit):
2776         (SuggestNominations._count_recent_patches):
2777         (SuggestNominations._collect_nominations):
2778         (SuggestNominations._print_nominations):
2779         (SuggestNominations.execute):
2780         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2781         (_make_options):
2782         (test_recent_commit_messages):
2783         (test_basic):
2784
2785 2013-04-30  Commit Queue  <rniwa@webkit.org>
2786
2787         Unreviewed, rolling out r149309.
2788         http://trac.webkit.org/changeset/149309
2789         https://bugs.webkit.org/show_bug.cgi?id=115430
2790
2791         The patch does not build on WK1-only builds of the GTK port
2792         (Requested by zdobersek on #webkit).
2793
2794         * TestWebKitAPI/GNUmakefile.am:
2795
2796 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2797
2798         Stop using "in" keyword in IDL files
2799         https://bugs.webkit.org/show_bug.cgi?id=115418
2800
2801         Reviewed by Kentaro Hara.
2802
2803         Remove "in" keyword from IDL files as this is no longer part of the Web
2804         IDL specification.
2805
2806         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2807         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2808         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2809         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2810         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2811         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
2812         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2813         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2814
2815 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2816
2817         [EFL] Enable scaled cursors
2818         https://bugs.webkit.org/show_bug.cgi?id=106242
2819
2820         Reviewed by Gyuyoung Kim.
2821
2822         Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
2823
2824         * Scripts/webkitperl/FeatureList.pm:
2825
2826 2013-04-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2827
2828         Replace "Optional" extended attribute by proper Web IDL "optional" keyword
2829         https://bugs.webkit.org/show_bug.cgi?id=115380
2830
2831         Reviewed by Kentaro Hara.
2832
2833         Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
2834         keyword.
2835
2836         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2837         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2838
2839 2013-04-30  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2840
2841         Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
2842         https://bugs.webkit.org/show_bug.cgi?id=114684
2843
2844         Reviewed by Simon Hausmann.
2845
2846         Remove the ANGLE requirement for USE(3D_GRAPHICS).
2847         This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
2848
2849         * qmake/mkspecs/features/features.prf:
2850
2851 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2852
2853         [GTK] Disable Shadow DOM feature
2854         https://bugs.webkit.org/show_bug.cgi?id=115374
2855
2856         Reviewed by Martin Robinson.
2857
2858         Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
2859
2860         * Scripts/webkitperl/FeatureList.pm:
2861
2862 2013-04-29  Glenn Adams  <glenn@skynav.com>
2863
2864         [webkitpy] Add missing contributor email addresses
2865         https://bugs.webkit.org/show_bug.cgi?id=115394
2866
2867         Reviewed by Ryosuke Niwa.
2868
2869         * Scripts/webkitpy/common/config/contributors.json:
2870
2871 2013-04-29  Alberto Garcia  <agarcia@igalia.com>
2872
2873         Remove all remaining Skia code
2874         https://bugs.webkit.org/show_bug.cgi?id=115263
2875
2876         Reviewed by Benjamin Poulain.
2877
2878         Remove all remaining references to Skia.
2879
2880         * Scripts/webkitdirs.pm:
2881         (blackberryCMakeArguments):
2882         * Scripts/webkitpy/common/config/contributionareas.py:
2883         * Scripts/webkitpy/common/config/watchlist:
2884
2885 2013-04-29  Seokju Kwon  <seokju.kwon@gmail.com>
2886
2887         Get rid of unused options in Tools/Scripts/webkit-build-directory
2888         https://bugs.webkit.org/show_bug.cgi?id=115383
2889
2890         Reviewed by Darin Adler.
2891
2892         * Scripts/webkit-build-directory:
2893
2894 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2895
2896         [WK2][Mac] Test with NetworkProcess enabled.
2897
2898         Fix the build for non-Mac.
2899
2900         * WebKitTestRunner/TestController.cpp:
2901         (WTR::TestController::initialize):
2902
2903 2013-04-29  Alexey Proskuryakov  <ap@apple.com>
2904
2905         [WK2][Mac] Test with NetworkProcess enabled.
2906
2907         Reviewed by Sam Weinig.
2908
2909         * WebKitTestRunner/TestController.cpp:
2910         (WTR::TestController::initialize):
2911
2912 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2913
2914         [GTK] Set up the TestWebCore in TestWebKitAPI
2915         https://bugs.webkit.org/show_bug.cgi?id=115237
2916
2917         Reviewed by Gustavo Noronha Silva.
2918
2919         Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2920         Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2921         a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2922         either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2923         shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2924
2925         * TestWebKitAPI/GNUmakefile.am:
2926
2927 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2928
2929         [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
2930         https://bugs.webkit.org/show_bug.cgi?id=115236
2931
2932         Reviewed by Gustavo Noronha Silva.
2933
2934         Set up the TestJavaScriptCore unit test program, consisting of the unit tests
2935         under the TestWebKitAPI/Tests/JavaScriptCore directory.
2936
2937         * TestWebKitAPI/GNUmakefile.am:
2938
2939 2013-04-29  Zan Dobersek  <zdobersek@igalia.com>
2940
2941         [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
2942         https://bugs.webkit.org/show_bug.cgi?id=115323
2943
2944         Reviewed by Philippe Normand.
2945
2946         Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
2947         Its presence enforces linkers to output mangled symbols when reporting linking failures
2948         due to unresolved references. People trying to fix the build can then simply copy
2949         the printed mangled symbol into the symbols.filter file instead of doing a manual build
2950         or connecting to the builders to discover the mangled version of the missing symbol.
2951
2952         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2953
2954 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2955
2956         Remove Chromium code from Tools/BuildSlaveSupport
2957         https://bugs.webkit.org/show_bug.cgi?id=115325
2958
2959         Reviewed by Benjamin Poulain.
2960
2961         Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
2962         covering archiving test results and built products.
2963
2964         * BuildSlaveSupport/built-product-archive:
2965         (archiveBuiltProduct):
2966         (extractBuiltProduct):
2967         * BuildSlaveSupport/chromium/output-android-device-status: Removed.
2968         * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
2969         * BuildSlaveSupport/test-result-archive:
2970         (archiveTestResults):
2971
2972 2013-04-28  Seokju Kwon  <seokju.kwon@gmail.com>
2973
2974         Remove support for Chromium from webkitdirs.pm
2975         https://bugs.webkit.org/show_bug.cgi?id=115338
2976
2977         Reviewed by Darin Adler.
2978
2979         * Scripts/webkitdirs.pm:
2980         (determineBaseProductDir):
2981         (argumentsForConfiguration):
2982         (builtDylibPathForName):
2983         (determineIsQt):
2984         (isAppleWebKit):
2985
2986 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
2987
2988         Rename TestRunner's setAudioData to setAudioResult
2989         https://bugs.webkit.org/show_bug.cgi?id=115326
2990
2991         Reviewed by Darin Adler.
2992
2993         Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
2994         than the previous one. The change is a simple rename, there's no change in the method's functionality. The
2995         affected tests are adjusted accordingly.
2996
2997         * DumpRenderTree/qt/TestRunnerQt.cpp:
2998         (TestRunnerQt::setAudioResult):
2999         * DumpRenderTree/qt/TestRunnerQt.h:
3000         (TestRunnerQt):
3001         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3002         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3003         (WTR::TestRunner::setAudioResult):
3004         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3005         (TestRunner):
3006
3007 2013-04-28  Zan Dobersek  <zdobersek@igalia.com>
3008
3009         [WKTR] Tests dumping audio data shouldn't dump pixels
3010         https://bugs.webkit.org/show_bug.cgi?id=115270
3011
3012         Reviewed by Benjamin Poulain.
3013
3014         Prevent dumping the pixel output when Web Audio tests are dumping output data
3015         as the testing output. Pixel output in these tests has no real meaning and is
3016         as such unnecessary.
3017
3018         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3019         (WTR::TestRunner::setAudioData):
3020
3021 2013-04-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3022
3023         [EFL] Unreviewed Intel bots fix after r149231.
3024
3025         * efl/jhbuild.modules: Disable the libxml Python bindings since the
3026         bots don't have Python's development files installed. libxml should
3027         detect this kind of thing better.
3028
3029 2013-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
3030
3031         [EFL] Build break using jhbuild on ubuntu 13.04
3032         https://bugs.webkit.org/show_bug.cgi?id=115225
3033
3034         Reviewed by Gyuyoung Kim.
3035
3036         libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
3037         libxml 2.9.0 has a bug to make regression which r138422 mentioned.
3038         So this patch bumped libxml version to 2.9.1.
3039
3040         * efl/jhbuild.modules:
3041
3042 2013-04-26  Jeffrey Pfau  <jpfau@apple.com>
3043
3044         delete-stale-build-files does not clear .d files
3045         http://bugs.webkit.org/show_bug.cgi?id=115293
3046
3047         Reviewed by Ryosuke Niwa.
3048
3049         * BuildSlaveSupport/delete-stale-build-files:
3050         (main): Add .d to the file type list
3051
3052 2013-04-26  Roger Fong  <roger_fong@apple.com>
3053
3054         Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
3055         Make the DebugSuffix configuration use _debug dependencies.
3056
3057         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3058         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
3059         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
3060         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
3061         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3062         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3063         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
3064         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
3065         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
3066         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3067         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
3068         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
3069         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3070         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3071         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3072         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
3073         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
3074         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
3075         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3076         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
3077         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
3078         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
3079         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3080         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
3081         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3082         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
3083         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
3084         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3085         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
3086         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
3087         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
3088         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
3089         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3090         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
3091         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3092         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3093         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3094         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
3095         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3096         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
3097         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3098         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3099         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3100         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
3101         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
3102         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3103         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
3104         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
3105         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
3106         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3107         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
3108         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3109         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3110         * win/AssembleBuildLogs/AssembleLogs.cmd:
3111         * win/record-memory/record-memory.vcxproj:
3112         * win/record-memory/record-memoryDebug.props:
3113         * win/record-memory/record-memoryDebugWinCairo.props:
3114         * win/record-memory/record-memoryProduction.props:
3115         * win/record-memory/record-memoryRelease.props:
3116         * win/record-memory/record-memoryReleaseWinCairo.props:
3117
3118 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
3119
3120         [GTK] Clean up the TestWebKitAPI GNUmakefile.am
3121         https://bugs.webkit.org/show_bug.cgi?id=115233
3122
3123         Reviewed by Martin Robinson.
3124
3125         Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
3126         WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
3127         Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
3128         Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
3129         be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
3130
3131         * TestWebKitAPI/GNUmakefile.am:
3132
3133 2013-04-25  Andy Estes  <aestes@apple.com>
3134
3135         [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
3136         https://bugs.webkit.org/show_bug.cgi?id=115223
3137
3138         Reviewed by Darin Adler.
3139
3140         Added an API test.
3141
3142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3143         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
3144         (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
3145         when it loads a request with a custom protocol.
3146         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
3147         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
3148         NSURLProtocol subclass to TestProtocol.{h, mm} and did some
3149         miscellaneous cleanup.
3150         * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
3151         * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
3152         (+[TestProtocol canInitWithRequest:]):
3153         (+[TestProtocol canonicalRequestForRequest:]):
3154         (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
3155         (+[TestProtocol scheme]):
3156         (-[TestProtocol startLoading]):
3157         (-[TestProtocol stopLoading]):
3158
3159 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
3160
3161         Remove the remaining Skia #ifdefs
3162         https://bugs.webkit.org/show_bug.cgi?id=114886
3163
3164         Reviewed by Benjamin Poulain.
3165
3166         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3167         (createBitmapContextFromWebView): Remove Skia #ifdef references.
3168
3169 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
3170
3171         [BlackBerry] Clean up load interface in WebPage
3172         https://bugs.webkit.org/show_bug.cgi?id=113267
3173
3174         Reviewed by Rob Buis.
3175
3176         Update DumpRenderTree with change of load() interface in WebPage.
3177         RIM Bug# 315535, internally reviewed by Joe Mason.
3178
3179         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3180         (BlackBerry::WebKit::DumpRenderTree::runTest):
3181
3182 2013-04-26  Zan Dobersek  <zdobersek@igalia.com>
3183
3184         Remove the HeapGraphSerializer unit test
3185         https://bugs.webkit.org/show_bug.cgi?id=115231
3186
3187         Reviewed by Andreas Kling.
3188
3189         Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
3190         specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
3191
3192         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
3193
3194 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3195
3196         Remove support for Chromium from build/update scripts
3197         https://bugs.webkit.org/show_bug.cgi?id=115218
3198
3199         Reviewed by Darin Adler.
3200
3201         * Scripts/build-webkit:
3202         (writeCongrats):
3203         * Scripts/update-webkit:
3204
3205 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3206
3207         Remove support for Chromium from api-test
3208         https://bugs.webkit.org/show_bug.cgi?id=115211
3209
3210         Reviewed by Dirk Pranke.
3211
3212         * Scripts/build-api-tests:
3213         * Scripts/run-api-tests:
3214         (isSupportedPlatform):
3215
3216 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3217
3218         Get rid of Chromium in build-dumprendertree
3219         https://bugs.webkit.org/show_bug.cgi?id=115212
3220
3221         Reviewed by Dirk Pranke.
3222
3223         * Scripts/build-dumprendertree:
3224
3225 2013-04-25  Alexey Proskuryakov  <ap@apple.com>
3226
3227         Pass relatedPage when creating a page in WebKitTestRunner
3228         https://bugs.webkit.org/show_bug.cgi?id=115206
3229
3230         Reviewed by Geoffrey Garen.
3231
3232         To make sure that window.open() opens in the same process even when using multiple processes.
3233
3234         * WebKitTestRunner/PlatformWebView.h:
3235         * WebKitTestRunner/TestController.cpp:
3236         (WTR::TestController::createOtherPage):
3237         (WTR::TestController::createWebViewWithOptions):
3238         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3239         (WTR::PlatformWebView::PlatformWebView):
3240         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3241         (WTR::PlatformWebView::PlatformWebView):
3242         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3243         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
3244         (WTR::PlatformWebView::PlatformWebView):
3245         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3246         (WTR::PlatformWebView::PlatformWebView):
3247         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3248         (WTR::PlatformWebView::PlatformWebView):
3249
3250 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3251
3252         Fix autocompletion for Benjamin. The Bugzilla email address must come first.
3253
3254         * Scripts/webkitpy/common/config/contributors.json:
3255
3256 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3257
3258         Build fix. Forgot to merge args.
3259
3260         * Scripts/webkitpy/tool/bot/irc_command.py:
3261         (Hi.execute):
3262
3263 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
3264
3265         webkitbot should recognize its own nickname in greetings.
3266         https://bugs.webkit.org/show_bug.cgi?id=115196
3267
3268         Reviewed by Andreas Kling.
3269
3270         Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
3271
3272         * Scripts/webkitpy/tool/bot/irc_command.py:
3273         (Hi.execute):
3274
3275 2013-04-25  Xavier Castano  <xcastanho@igalia.com>
3276
3277         [GTK] Tools/gtk/install-dependencies added ragel dependency
3278         https://bugs.webkit.org/show_bug.cgi?id=115163
3279
3280         Reviewed by Xan Lopez.
3281
3282         The install-dependencies script was missing a dependency on ragel
3283         which is expected when building HarfBuzz.
3284
3285         * gtk/install-dependencies: Added a dependency on ragel for both
3286         apt and yum.
3287
3288 2013-04-25  Eduardo Lima Mitev  <elima@igalia.com>
3289
3290         [GTK] Remove pango from optional jhbuild dependencies
3291         https://bugs.webkit.org/show_bug.cgi?id=115162
3292
3293         Reviewed by Martin Robinson.
3294
3295         Pango is not needed since revision r148293 that lowers the pango
3296         dependency to 1.30, which is available in most distributions.
3297
3298         * gtk/jhbuild-optional.modules: Removes description of pango module.
3299
3300 2013-04-25  Seokju Kwon  <seokju.kwon@gmail.com>
3301
3302         Remove Chromium-specific cases from FeatureList.pm
3303         https://bugs.webkit.org/show_bug.cgi?id=115169
3304
3305         Reviewed by Andreas Kling.
3306
3307         * Scripts/webkitperl/FeatureList.pm:
3308
3309 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
3310
3311         Remove checking chromium from run-webkit-tests
3312         https://bugs.webkit.org/show_bug.cgi?id=115139
3313
3314         Reviewed by Benjamin Poulain.
3315
3316         * Scripts/run-webkit-tests:
3317         (useNewRunWebKitTests):
3318
3319 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
3320
3321         Pixel tests in SVG are all broken in WK2
3322         https://bugs.webkit.org/show_bug.cgi?id=114218
3323
3324         Reviewed by Darin Adler.
3325         
3326         Window snapshots in WebKitTestRunner on Mac are window-sized
3327         (800x600), which is wrong for the W3C SVG tests that require a
3328         480x360 snapshot.
3329         
3330         Fix by resizing the window, as well as the web view in
3331         PlatformWebView::resizeTo() so that window snapshots are correctly
3332         sized.
3333         
3334         Also do some drive-by cleanup of the window size constants in both
3335         DRT and WTR to remove magic numbers, and make the code more similar.
3336         
3337         * DumpRenderTree/TestRunner.cpp:
3338         (TestRunner::setShouldPaintBrokenImage):
3339         * DumpRenderTree/TestRunner.h:
3340         * DumpRenderTree/efl/DumpRenderTree.cpp:
3341         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3342         (webInspectorShowWindow):
3343         * DumpRenderTree/mac/DumpRenderTree.mm:
3344         (createWebViewAndOffscreenWindow):
3345         (sizeWebViewForCurrentTest):
3346         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3347         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3348         (createPagedBitmapContext):
3349         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3350         (DumpRenderTree::DumpRenderTree):
3351         (DumpRenderTree::open):
3352         * DumpRenderTree/qt/TestRunnerQt.cpp:
3353         * DumpRenderTree/qt/TestRunnerQt.h:
3354         * DumpRenderTree/win/DumpRenderTree.cpp:
3355         (sizeWebViewForCurrentTest):
3356         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3357         * WebKitTestRunner/TestController.cpp:
3358         (WTR::TestController::resetStateToConsistentValues):
3359         * WebKitTestRunner/TestController.h:
3360         * WebKitTestRunner/TestInvocation.cpp:
3361         (WTR::sizeWebViewForCurrentTest):
3362         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3363         (WTR::PlatformWebView::PlatformWebView):
3364         (WTR::PlatformWebView::resizeTo):
3365
3366 2013-04-24  Byungwoo Lee  <bw80.lee@samsung.com>
3367
3368         [EFL] Fix build error after r148963.
3369         https://bugs.webkit.org/show_bug.cgi?id=115126
3370
3371         Reviewed by Laszlo Gombos.
3372
3373         Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
3374
3375         * TestWebKitAPI/PlatformEfl.cmake:
3376
3377 2013-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3378
3379         [GTK] Use stamp files for generate-forwarding-headers makefile rules
3380         https://bugs.webkit.org/show_bug.cgi?id=115118
3381
3382         Reviewed by Martin Robinson.
3383
3384         Use a stamp file for the TestWebKitAPI and WebKitTestRunner
3385         forwarding generator rules and don't call it for soup since there
3386         aren't soup directories in TestWebKitAPI and WebKitTestRunner.
3387
3388         * TestWebKitAPI/GNUmakefile.am:
3389         * WebKitTestRunner/GNUmakefile.am:
3390
3391 2013-04-24  Simon Pena  <simon.pena@samsung.com>
3392
3393         [GTK] Update build dependencies
3394         https://bugs.webkit.org/show_bug.cgi?id=115111
3395
3396         Reviewed by Martin Robinson.
3397
3398         The install-dependencies script was missing a dependency on EGL,
3399         which is expected when building Cairo.
3400
3401         * gtk/install-dependencies: Added a dependency on libegl1-mesa
3402         for both apt and yum.
3403
3404 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
3405
3406         Remove the Chromium-specific helper from run_webkit_tests.py
3407         https://bugs.webkit.org/show_bug.cgi?id=114996
3408
3409         Reviewed by Dirk Pranke.
3410
3411         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3412         (parse_args):
3413
3414 2013-04-24  Sergio Correia  <sergio.correia@openbossa.org>
3415
3416         [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
3417         https://bugs.webkit.org/show_bug.cgi?id=114850
3418
3419         Reviewed by Andreas Kling.
3420
3421         Revision r148312 fixed WebPageProxy cleanup and also changed the process
3422         termination semantics when requested by the user so that a client is not
3423         notified of a crash anymore, since there was no crash anyway.
3424
3425         That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
3426         relied on being notified of a crash after calling WKPageTerminate(). As
3427         a result of not being notified of such non-existent crash, the test would
3428         timeout right after making the terminate call.
3429
3430         This patch adds an InjectedBundle to be used for simulating a crash, by
3431         calling abort() upon receiving a "Crash" message, and thus we are able to
3432         keep testing the crash callback.
3433
3434         This patch also re-enables the WKViewClientWebProcessCallbacks test, which
3435         had been disabled in revisions r148858 and r148855, since it was failing.
3436
3437         * TestWebKitAPI/PlatformEfl.cmake:
3438         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3439         (TestWebKitAPI::TEST):
3440         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
3441         (TestWebKitAPI):
3442         (WKViewClientWebProcessCallbacksTest):
3443         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
3444         (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
3445
3446 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3447
3448         [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
3449         https://bugs.webkit.org/show_bug.cgi?id=115095
3450
3451         Reviewed by Antonio Gomes.
3452
3453         Use different subfolders under DumpRenderTree Temp folder for every
3454         functionality (icon database, cache, localstorage, ...). This makes
3455         sure there is no conflict between the functionalities.
3456
3457         In EFL's case, libsoup cache was causing problems for the icon
3458         database if sharing the same folder.
3459
3460         * WebKitTestRunner/TestController.cpp:
3461         (WTR::TestController::initialize):
3462
3463 == Rolled over to ChangeLog-2013-04-24 ==