[webkit-patch] Use identifiers when posting to bugzilla
[WebKit-https.git] / Tools / ChangeLog
1 2021-02-12  Jonathan Bedard  <jbedard@apple.com>
2
3         [webkit-patch] Use identifiers when posting to bugzilla
4         https://bugs.webkit.org/show_bug.cgi?id=221724
5         <rdar://problem/74209525>
6
7         Rubber-stamped by Aakash Jain.
8
9         * Scripts/webkitpy/common/config/urls.py:
10         (view_identifier_url): Return commits.webkit.org identifier link.
11         * Scripts/webkitpy/tool/commands/download_unittest.py:
12         (DownloadCommandsTest.mock_svn_remote): Return a mock context for a remote Svn instance.
13         * Scripts/webkitpy/tool/commands/upload_unittest.py:
14         * Scripts/webkitpy/tool/comments.py:
15         (bug_comment_from_svn_revision): Query remote Subversion server to construct identifier link.
16         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
17         (CloseBugForLandDiffTest.test_empty_state): Mock context for a remote Svn instance.
18         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
19
20 2021-02-11  Alex Christensen  <achristensen@webkit.org>
21
22         Make WebKitLegacy.CrossPartitionFileSchemeAccess stop timing out on EWS bots
23         https://bugs.webkit.org/show_bug.cgi?id=206956
24
25         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm:
26         This test times out sometimes, but only on bots. Let's kick the can down the road.
27
28 2021-02-11  Alex Christensen  <achristensen@webkit.org>
29
30         Unreviewed, reverting r272603.
31
32         Broke test, has room for improvement
33
34         Reverted changeset:
35
36         "Synthesize range responses if needed in WebCoreNSURLSession"
37         https://bugs.webkit.org/show_bug.cgi?id=221072
38         https://trac.webkit.org/changeset/272603
39
40 2021-02-11  Don Olmstead  <don.olmstead@sony.com>
41
42         [Python-3] Update pylint version
43         https://bugs.webkit.org/show_bug.cgi?id=221785
44
45         Reviewed by Jonathan Bedard.
46
47         Update pylint on Python 3 to version 2.6.0 which supports >=3.5.
48         
49         Update pylint on Python 2.7 to the last 0.x version, 0.28.0. The logilab packages are
50         specific to this version only so they are moved into the block. 
51
52         * Scripts/webkitpy/__init__.py:
53
54 2021-02-11  Jonathan Bedard  <jbedard@apple.com>
55
56         [run-webkit-tests] Update PHP module configuration
57         https://bugs.webkit.org/show_bug.cgi?id=221776
58         <rdar://problem/74248860>
59
60         Reviewed by Alexey Proskuryakov.
61
62         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
63         (LayoutTestApacheHttpd.__init__): Optionally exclude PHP init directory.
64         * Scripts/webkitpy/port/base.py:
65         (Port._darwin_php_version): Add -x version.
66
67 2021-02-11  Lauro Moura  <lmoura@igalia.com>
68
69         [WPE] Fix WPEQt tests after r272707
70         https://bugs.webkit.org/show_bug.cgi?id=220681
71
72         Reviewed by Carlos Garcia Campos.
73
74         Setting the title became async, so we must wait for it to be
75         processed.
76
77         Same patch as r271578, reapplying after original change was reapplied
78         in r272707.
79
80         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp:
81         (TestLoad::main):
82         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp:
83         (TestLoadHtml::main):
84         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp:
85         (TestLoadRequest::main):
86         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp:
87         (TestRunJavaScript::main):
88
89 2021-02-11  Jonathan Bedard  <jbedard@apple.com>
90
91         [webkitpy] Use commits.webkit.org instead of trac
92         https://bugs.webkit.org/show_bug.cgi?id=221764
93         <rdar://problem/74242815>
94
95         Reviewed by Aakash Jain.
96
97         * Scripts/webkitpy/common/config/urls.py:
98         (view_revision_url): 
99         * Scripts/webkitpy/tool/commands/download_unittest.py:
100         * Scripts/webkitpy/tool/commands/upload_unittest.py:
101         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
102         (CloseBugForLandDiffTest.test_empty_state):
103         * Scripts/webkitpy/tool/steps/commit_unittest.py:
104         (CommitTest._test_check_test_expectations):
105         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
106         (UpdateChangeLogsForRevertTest):
107
108 2021-02-11  Aakash Jain  <aakash_jain@apple.com>
109
110         build.webkit.org should display commit identifier in builds
111         https://bugs.webkit.org/show_bug.cgi?id=221730
112
113         Reviewed by Jonathan Bedard.
114
115         * CISupport/build-webkit-org/steps.py:
116         (ExtractTestResults.finished):
117         (ShowIdentifier): build-step to show commit identifier.
118         (ShowIdentifier.__init__):
119         (ShowIdentifier.start):
120         (ShowIdentifier.evaluateCommand):
121         (ShowIdentifier.getLastBuildStepByName):
122         (ShowIdentifier.url_for_identifier):
123         (ShowIdentifier.getResultSummary): Display custom failure message.
124         (ShowIdentifier.hideStepIf): Hide this step if successful.
125         * CISupport/build-webkit-org/steps_unittest.py:
126         (BuildStepMixinAdditions.executedSteps): filter wasn't working as expected with python 3, replaced 
127         with list comprehension.
128         (TestShowIdentifier): Added unit-tests.
129         (TestShowIdentifier.test_success):
130         (TestShowIdentifier.test_failure):
131         * CISupport/build-webkit-org/factories.py: Added ShowIdentifier build step.
132
133 2021-02-11  Aakash Jain  <aakash_jain@apple.com>
134
135         JSC EWSes should be triggered by change in any jsc file
136         https://bugs.webkit.org/show_bug.cgi?id=221756
137
138         Reviewed by Jonathan Bedard.
139
140         * CISupport/ews-build/steps.py:
141         (CheckPatchRelevance): Used generic jsc regex.
142         * CISupport/ews-build/steps_unittest.py: Made the unit-tests more generic by using for loop to check multiple filenames.
143
144 2021-02-11  Youenn Fablet  <youenn@apple.com>
145
146         [MacOS] Enable Audio Capture in GPUProcess by default
147         https://bugs.webkit.org/show_bug.cgi?id=221400
148
149         Reviewed by Eric Carlson.
150
151         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
152         (-[GetUserMediaRepromptTestView haveStream:]):
153         Increase timeout since capture might require spinning GPUProcess.
154
155 2021-02-11  Lauro Moura  <lmoura@igalia.com>
156
157         [Flatpak SDK] Fix env forwarding for older flatpak versions
158         https://bugs.webkit.org/show_bug.cgi?id=221757
159
160         Rubber-stamped by Philippe Normand.
161
162         Older flatpak versions (pre 1.10) might not have been patched for the
163         envvar CVE that triggered the new behavior and would still be
164         receiving the environment through envvars instead of the --args file
165         descriptor.
166
167         * flatpak/webkit-bwrap:
168
169 2021-02-11  Don Olmstead  <don.olmstead@sony.com>
170
171         [CMake] WEBKIT_EXECUTABLE can incorrectly link framework
172         https://bugs.webkit.org/show_bug.cgi?id=221703
173
174         Reviewed by Michael Catanzaro.
175
176         GTK compiles JavaScriptCore as a SHARED library but the symbols from WTF are not being
177         properly exposed from it. Workaround this by linking WTF directly until GTK turns on
178         hidden visibility and properly exports symbols.
179
180         * TestWebKitAPI/CMakeLists.txt:
181         * TestWebKitAPI/PlatformGTK.cmake:
182
183 2021-02-11  Lauro Moura  <lmoura@igalia.com>
184
185         [Flatpak SDK] Support multiple builds running at the same time
186         https://bugs.webkit.org/show_bug.cgi?id=221711
187
188         Reviewed by Philippe Normand.
189
190         Instead of writing the environment to a file, read the --setenv
191         arguments from the --args file descriptor passed to webkit-bwrap like
192         bwrap itself would do.
193
194         * flatpak/flatpakutils.py: Do not write the env file anymore
195         (WebkitFlatpak.run_in_sandbox):
196         * flatpak/webkit-bwrap: Read the environment from the args file
197         descriptor.
198
199 2021-02-10  Wenson Hsieh  <wenson_hsieh@apple.com>
200
201         [Webpage translation] Add support for the -_translate: action on WKContentView
202         https://bugs.webkit.org/show_bug.cgi?id=221713
203         <rdar://problem/73902020>
204
205         Reviewed by Tim Horton.
206
207         Add an API test to exercise `-canPerformAction:withSender:` with the new action.
208
209         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
210
211 2021-02-10  Rob Buis  <rbuis@igalia.com>
212
213         Use event loop to set title
214         https://bugs.webkit.org/show_bug.cgi?id=218496
215
216         Reviewed by Darin Adler.
217
218         Adapt unit tests to wait for title change tasks
219         to be processed.
220
221         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
222         (TestWebKitAPI::didChangeTitle):
223         (TestWebKitAPI::TEST):
224         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
225         (TEST):
226         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
227         (testWebViewAuthenticationFailure):
228         (testWebViewAuthenticationNoCredential):
229         (testWebViewAuthenticationSuccess):
230         (testWebViewAuthenticationEmptyRealm):
231         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
232         (testBackForwardListNavigation):
233         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
234         (testWebViewTitle):
235         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
236         (testLoadFailedWithTLSErrors):
237         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
238         (testWebKitSettingsJavaScriptMarkup):
239         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
240         (testWebViewTitleChange):
241
242 2021-02-10  Jiewen Tan  <jiewen_tan@apple.com>
243
244         [WebAuthn] Produce ClientDataJSON in the SPI
245         https://bugs.webkit.org/show_bug.cgi?id=221623
246         <rdar://problem/71509394>
247
248         Reviewed by Brent Fulgham.
249
250         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
251         (TestWebKitAPI::TEST):
252
253 2021-02-10  Ruben Turcios  <rubent_22@apple.com>
254
255         Adding self to contributor.json file. 
256
257         * Scripts/webkitpy/common/config/contributors.json:
258
259 2021-02-10  Ryan Haddad  <ryanhaddad@apple.com>
260
261         Unreviewed, reverting r272507.
262
263         Caused TestWebKitAPI.WebKit.OnDeviceChangeCrash to become a
264         flaky timeout
265
266         Reverted changeset:
267
268         "[MacOS] Enable Audio Capture in GPUProcess by default"
269         https://bugs.webkit.org/show_bug.cgi?id=221400
270         https://trac.webkit.org/changeset/272507
271
272 2021-02-10  Aakash Jain  <aakash_jain@apple.com>
273
274         [build.webkit.org] Remove code specific to old Buildbot
275         https://bugs.webkit.org/show_bug.cgi?id=221558
276
277         Reviewed by Jonathan Bedard.
278
279         * CISupport/build-webkit-org/buildbot.tac:
280         * CISupport/build-webkit-org/loadConfig.py:
281         * CISupport/build-webkit-org/loadConfig_unittest.py:
282         * CISupport/build-webkit-org/master.cfg: Removed.
283         * CISupport/build-webkit-org/steps.py:
284         (TestWithFailureCount.getText): Deleted.
285         (TestWithFailureCount.getText2): Deleted.
286         (CompileWebKit.createSummary): Deleted.
287         (RunWebKitTests._parseRunWebKitTestsOutput): Deleted.
288         (RunWebKitTests.commandComplete): Deleted.
289         (RunWebKitTests.getText): Deleted.
290         (RunWebKitTests.getText2): Deleted.
291         (ExtractTestResults.start): Deleted.
292         * CISupport/ews-build/steps.py:
293         * CISupport/ews-build/steps_unittest.py:
294
295 2021-02-10  Wenson Hsieh  <wenson_hsieh@apple.com>
296
297         Use HAVE(PEPPER_UI_CORE) instead of PLATFORM(WATCHOS) to guard code that uses PepperUICore
298         https://bugs.webkit.org/show_bug.cgi?id=221679
299
300         Reviewed by Tim Horton.
301
302         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
303         (isQuickboardViewController):
304
305 2021-02-10  Aakash Jain  <aakash_jain@apple.com>
306
307         [ews] Remove old build.webkit.org unit-tests
308         https://bugs.webkit.org/show_bug.cgi?id=221678
309
310         Reviewed by Jonathan Bedard.
311
312         * CISupport/ews-build/factories.py:
313         (ServicesFactory.__init__):
314         * CISupport/ews-build/factories_unittest.py:
315         (TestTestsFactory.test_services_factory):
316         * CISupport/ews-build/steps.py:
317         (ReRunWebKitPerlTests.evaluateCommand):
318         (RunBuildWebKitOrgOldUnitTests): Deleted.
319         (RunBuildWebKitOrgOldUnitTests.__init__): Deleted.
320         (RunBuildWebKitOrgOldUnitTests.getResultSummary): Deleted.
321         * CISupport/ews-build/steps_unittest.py:
322         (TestRunBuildWebKitOrgUnitTests.test_failure):
323         (TestRunBuildWebKitOrgOldUnitTests): Deleted.
324         (TestRunBuildWebKitOrgOldUnitTests.setUp): Deleted.
325         (TestRunBuildWebKitOrgOldUnitTests.tearDown): Deleted.
326         (TestRunBuildWebKitOrgOldUnitTests.test_success): Deleted.
327         (TestRunBuildWebKitOrgOldUnitTests.test_failure): Deleted.
328
329 2021-02-10  Patrick Griffis  <pgriffis@igalia.com>
330
331         Update status in contributors.json
332
333         Unreviewed.
334
335         * Scripts/webkitpy/common/config/contributors.json:
336
337 2021-02-10  Wenson Hsieh  <wenson_hsieh@apple.com>
338
339         [watchOS] Adopt PUICQuickboardController for text input
340         https://bugs.webkit.org/show_bug.cgi?id=221649
341
342         Reviewed by Tim Horton.
343
344         Make some small tweaks to WebKitTestRunner in support of using `PUICQuickboardController` for text input.
345
346         * WebKitTestRunner/Configurations/Base.xcconfig:
347         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
348
349         Adjust the test harness on watchOS to link against PepperUICore, so that we can reference the
350         `PUICQuickboardViewController` and `PUICQuickboardRemoteViewController` classes below.
351
352         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
353         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
354         (isQuickboardViewController):
355         (-[TestRunnerWKWebView _didPresentViewController:]):
356
357         Override `-presentViewController:animated:completion:` on the view controller below, and call this new method
358         on the `TestRunnerWKWebView` when a view controller is finished presenting. We need to do this to ensure that
359         the input view presentation callbacks continue to work after adopting `PUICQuickboardController`; see WebKit
360         ChangeLog for more details.
361
362         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
363         (-[PlatformWebViewController presentViewController:animated:completion:]):
364
365 2021-02-10  Aakash Jain  <aakash_jain@apple.com>
366
367         [ews] Add build-step to run build.webkit.org new unit-tests
368         https://bugs.webkit.org/show_bug.cgi?id=219454
369
370         Reviewed by Jonathan Bedard.
371
372         * CISupport/ews-build/steps.py:
373         (RunBuildWebKitOrgOldUnitTests): Renamed.
374         (RunBuildWebKitOrgUnitTests): Build step to run build.webkit.org new unit-tests.
375         * CISupport/ews-build/steps_unittest.py: Added unit-tests.
376         * CISupport/ews-build/factories.py:
377         (ServicesFactory.__init__): Added the new build-step, also change the step order slightly.
378         * CISupport/ews-build/factories_unittest.py:
379
380 2021-02-10  Brent Fulgham  <bfulgham@apple.com>
381
382         Create stub methods to support finer-grained control over loading
383         https://bugs.webkit.org/show_bug.cgi?id=221430
384         <rdar://problem/73999547>
385
386         Reviewed by Geoffrey Garen.
387
388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
389         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm: Added.
390         (TEST):
391
392 2021-02-10  Lauro Moura  <lmoura@igalia.com>
393
394         [GTK] Gardening TestResources failures after r272636
395
396         Unreviewed test gardening.
397
398         * TestWebKitAPI/glib/TestExpectations.json:
399
400 2021-02-10  Kimmo Kinnunen  <kkinnunen@apple.com>
401
402         RemoteGraphicsContextGLProxy should support losing the context and should lose the context on timeouts
403         https://bugs.webkit.org/show_bug.cgi?id=221396
404
405         Reviewed by Simon Fraser.
406
407         Generate calls to lose the context on timeouts.
408
409         Generate the send calls as calls to the helper functions to send the
410         messages. The helper functions will provide the non-changing arguments.
411
412         Move few messages to be implemented by hand.
413
414         * Scripts/generate-gpup-webgl:
415
416 2021-02-06  Philippe Normand  <pnormand@igalia.com>
417
418         [WPE] Optionally build Cog as external project and replacement for MiniBrowser
419         https://bugs.webkit.org/show_bug.cgi?id=221518
420
421         Reviewed by Adrian Perez de Castro.
422
423         By passing `-DENABLE_COG=ON` during the WPE build, the Cog browser is now built as an
424         external project. The repository is cloned in Tools/wpe/cog and the code can be edited
425         there.
426
427         The run-minibrowser --wpe script will now first try to execute cog and fallback to
428         MiniBrowser if it wasn't found. Cog is also a MiniBrowser, but with some additional
429         features, see https://github.com/Igalia/cog for more informations.
430
431         * PlatformWPE.cmake: Configure Cog as an external project in developer builds.
432         * Scripts/webkitpy/port/wpe.py:
433         (WPEPort.run_minibrowser): First check for cog, fallback to MiniBrowser if not found.
434         * flatpak/flatpakutils.py:
435         (WebkitFlatpak.run_in_sandbox): Set pkg-config path to lookup libraries in the WebKit's
436         build directory as well.
437
438 2021-02-09  Devin Rousso  <drousso@apple.com>
439
440         [iOS] Add support for the language/subtitle tracks button using `UIMenu`
441         https://bugs.webkit.org/show_bug.cgi?id=221594
442         <rdar://problem/74129129>
443
444         Reviewed by Eric Carlson and Wenson Hsieh.
445
446         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
447         (WTR::UIScriptControllerIOS::rectForMenuAction const):
448         In addition to looking at the active `UICalloutBar` (if it exists), walk the view hierarchy
449         looking for any `UILabel` that contains the given text and use that as the rect to tap.
450         While this isn't the most confident/consistent approach, UIKit doesn't have anything like
451         `UICalloutBar` for contextmenu interactions, and this is only used inside WKTR (which has no
452         other UI outside than the page), so it's expected that callers know what they're doing.
453
454 2021-02-09  Chris Dumez  <cdumez@apple.com>
455
456         Rename SecurityOrigin's canAccess() to isSameOriginDomain() to match HTML specification naming
457         https://bugs.webkit.org/show_bug.cgi?id=221630
458
459         Reviewed by Geoffrey Garen.
460
461         Rename SecurityOrigin's canAccess() to isSameOriginDomain() to match HTML specification naming:
462         - https://html.spec.whatwg.org/#same-origin-domain
463
464         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
465         (TestWebKitAPI::TEST_F):
466
467 2021-02-09  Alex Christensen  <achristensen@webkit.org>
468
469         Fix Catalina build.
470         https://bugs.webkit.org/show_bug.cgi?id=221431
471
472         * TestWebKitAPI/Tests/WebKitCocoa/MediaSession.mm:
473         (TestWebKitAPI::TEST_F):
474
475 2021-02-09  Alex Christensen  <achristensen@webkit.org>
476
477         Synthesize range responses if needed in WebCoreNSURLSession
478         https://bugs.webkit.org/show_bug.cgi?id=221072
479
480         Reviewed by Geoff Garen.
481
482         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
483         (TestWebKitAPI::TEST):
484         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
485         (TestWebKitAPI::clientCertServer):
486         * TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
487         (TestWebKitAPI::testVideoBytes):
488         (TestWebKitAPI::runVideoTest):
489         (TestWebKitAPI::TEST):
490         * TestWebKitAPI/cocoa/HTTPServer.h:
491         (TestWebKitAPI::HTTPResponse::HTTPResponse):
492         (TestWebKitAPI::HTTPServer::HTTPResponse::HTTPResponse): Deleted.
493         * TestWebKitAPI/cocoa/HTTPServer.mm:
494         (TestWebKitAPI::HTTPServer::RequestData::RequestData):
495         (TestWebKitAPI::appendToVector):
496         (TestWebKitAPI::HTTPServer::parsePath):
497         (TestWebKitAPI::HTTPServer::respondToRequests):
498         (TestWebKitAPI::HTTPResponse::bodyFromString):
499         (TestWebKitAPI::HTTPResponse::serialize):
500
501 2021-02-09  Aditya Keerthi  <akeerthi@apple.com>
502
503         [iOS][FCR] Use UIColorPickerViewController for color inputs
504         https://bugs.webkit.org/show_bug.cgi?id=221572
505         <rdar://problem/72183130>
506
507         Reviewed by Sam Weinig.
508
509         Added UIScriptController hooks to simulate selecting a color on the
510         new color picker.
511
512         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
513         * TestRunnerShared/UIScriptContext/UIScriptController.h:
514         (WTR::UIScriptController::setSelectedColorForColorPicker):
515         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
516         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
517         (WTR::UIScriptControllerIOS::setSelectedColorForColorPicker):
518
519 2021-02-09  Jonathan Bedard  <jbedard@apple.com>
520
521         [webkitscmpy] Correctly parse branch commits
522         https://bugs.webkit.org/show_bug.cgi?id=221609
523         <rdar://problem/74142906>
524
525         Rubber-stamped by Aakash Jain.
526
527         * Scripts/libraries/webkitscmpy/setup.py: Bump version.
528         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
529         * Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
530         (Git.commit): Only respect the last revision in a commit message.
531         * Scripts/libraries/webkitscmpy/webkitscmpy/mocks/git-repo.json: Make one commit similar
532         to a cherry-pick.
533         * Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
534         (GitHub.commit): Only respect the last revision in a commit message.
535         * Scripts/libraries/webkitscmpy/webkitscmpy/test/find_unittest.py:
536         (TestFind.test_hash): Change commit being tested since original commit would
537         resolve a revision.
538
539 2021-02-09  Daniel Kolesa  <dkolesa@igalia.com>
540
541         Allow icecream toolchain override in flatpakutils
542         https://bugs.webkit.org/show_bug.cgi?id=221605
543
544         Reviewed by Philippe Normand.
545
546         This allows the user to specify a custom icecream toolchain.
547         Usually you will not want to do this, but it is useful e.g. when
548         you have a machine in your cluster that does not have a compiler
549         in the SDK. You can either force the whole version string by using
550         ICECC_VERSION_OVERRIDE, or append to the original string with
551         ICECC_VERSION_APPEND.
552
553         * flatpak/flatpakutils.py:
554         (WebkitFlatpak.run_in_sandbox):
555
556 2021-02-09  Lauro Moura  <lmoura@igalia.com>
557
558         [GLIB] Geolocation API tests are flaky timeout instead of failure
559
560         Unreviewed test gardening.
561
562         * TestWebKitAPI/glib/TestExpectations.json:
563
564 2021-02-09  Philippe Normand  <pnormand@igalia.com>
565
566         [GLib] Permission request API for MediaKeySystem access support
567         https://bugs.webkit.org/show_bug.cgi?id=221199
568
569         Reviewed by Carlos Garcia Campos.
570
571         Added basic support for MediaKeySystem permission request to the GTK MiniBrowser, and a GLib
572         API unit-test as well.
573
574         * MiniBrowser/gtk/BrowserTab.c:
575         (permissionRequestDialogResponse):
576         (decidePermissionRequest):
577         (browser_tab_class_init):
578         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
579         (testWebViewMediaKeySystemPermissionRequests):
580         (beforeAll):
581         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
582         (WebViewTest::initializeWebView):
583
584 2021-02-09  Philippe Normand  <pnormand@igalia.com>
585
586         Permission request API for MediaKeySystem access support
587         https://bugs.webkit.org/show_bug.cgi?id=221187
588
589         Reviewed by Jer Noble.
590
591         Add support for setting the permission request response from the TestRunner, for usage within layout tests.
592
593         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
594         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
595         (WTR::TestRunner::setIsMediaKeySystemPermissionGranted):
596         * WebKitTestRunner/InjectedBundle/TestRunner.h:
597         * WebKitTestRunner/TestController.cpp:
598         (WTR::decidePolicyForMediaKeySystemPermissionRequest):
599         (WTR::TestController::completeMediaKeySystemPermissionCheck):
600         (WTR::TestController::setIsMediaKeySystemPermissionGranted):
601         (WTR::TestController::createWebViewWithOptions):
602         * WebKitTestRunner/TestController.h:
603         * WebKitTestRunner/TestInvocation.cpp:
604         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
605
606 2021-02-09  Manuel Rego Casasnovas  <rego@igalia.com>
607
608         Allow sending modifier keys in test_driver.send_keys()
609         https://bugs.webkit.org/show_bug.cgi?id=221466
610
611         Reviewed by Carlos Garcia Campos.
612
613         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
614         (WTR::getGDKKeySymForKeyRef): Add support for meta key.
615
616 2021-02-08  Sam Sneddon  <gsnedders@apple.com>
617
618         Move layout_test_runner.Worker._update_test_input to LayoutTestRunner
619         https://bugs.webkit.org/show_bug.cgi?id=221577
620
621         Reviewed by Jonathan Bedard.
622
623         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
624         (LayoutTestRunner.run_tests):
625         (LayoutTestRunner._update_test_input):
626         (Worker.handle):
627         (Worker._run_test):
628         (Worker._update_test_input): Deleted.
629         * Scripts/webkitpy/layout_tests/controllers/manager.py:
630         (Manager._run_tests):
631
632 2021-02-08  Stephanie Lewis  <slewis@apple.com>
633
634         <rdar://problem/70402593> Motionmark failed to start webserver
635
636         Reviewed by Dewei Zhu.
637
638         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
639         (BenchmarkBuilder.__enter__):
640
641 2021-02-08  Commit Queue  <commit-queue@webkit.org>
642
643         Unreviewed, reverting r272485.
644         https://bugs.webkit.org/show_bug.cgi?id=221588
645
646         Required revisions were reversed
647
648         Reverted changeset:
649
650         "[GLib] Permission request API for MediaKeySystem access
651         support"
652         https://bugs.webkit.org/show_bug.cgi?id=221199
653         https://trac.webkit.org/changeset/272485
654
655 2021-02-08  Eric Carlson  <eric.carlson@apple.com>
656
657         [Mac] Connect MediaSession with MediaRemote and NowPlaying
658         https://bugs.webkit.org/show_bug.cgi?id=221431
659         <rdar://problem/74000363>
660
661         Unreviewed build fix for macOS Catalina.
662
663         * TestWebKitAPI/Tests/WebKitCocoa/MediaSession.mm:
664         (TestWebKitAPI::TEST_F): Add compile guards for Catalina.
665
666 2021-02-08  Commit Queue  <commit-queue@webkit.org>
667
668         Unreviewed, reverting r272480, r272481, and r272500.
669         https://bugs.webkit.org/show_bug.cgi?id=221586
670
671         Caused assertion failure seen with EME tests
672
673         Reverted changesets:
674
675         "Permission request API for MediaKeySystem access support"
676         https://bugs.webkit.org/show_bug.cgi?id=221187
677         https://trac.webkit.org/changeset/272480
678
679         "Unreviewed, build fix after r272480"
680         https://trac.webkit.org/changeset/272481
681
682         "Permission request API for MediaKeySystem access support"
683         https://bugs.webkit.org/show_bug.cgi?id=221187
684         https://trac.webkit.org/changeset/272500
685
686 2021-02-08  Aakash Jain  <aakash_jain@apple.com>
687
688         [build.webkit.org] Add HTML file that translates a builder name and number pair to a valid Buildbot URL
689         https://bugs.webkit.org/show_bug.cgi?id=221579
690
691         Reviewed by Ryosuke Niwa.
692
693         * CISupport/build-webkit-org/public_html/builders: Added.
694         * CISupport/build-webkit-org/public_html/builders/index.html: Added.
695
696 2021-02-08  Youenn Fablet  <youenn@apple.com>
697
698         [MacOS] Enable Audio Capture in GPUProcess by default
699         https://bugs.webkit.org/show_bug.cgi?id=221400
700
701         Reviewed by Eric Carlson.
702
703         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
704         (-[GetUserMediaRepromptTestView haveStream:]):
705         Increase timeout since capture might require spinning GPUProcess.
706
707 2021-02-08  Youenn Fablet  <youenn@apple.com>
708
709         NetworkRTCSocketCocoa extractDataMessages should not read too much data
710         https://bugs.webkit.org/show_bug.cgi?id=221544
711
712         Reviewed by Eric Carlson.
713
714         * TestWebKitAPI/Tests/WebCore/STUNMessageParsingTest.cpp: Added.
715         (TestWebKitAPI::TEST):
716         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
717
718 2021-02-08  Alicia Boya García  <aboya@igalia.com>
719
720         Add ConsoleMessage::toString()
721         https://bugs.webkit.org/show_bug.cgi?id=221539
722
723         Reviewed by Eric Carlson.
724
725         Added unit tests.
726
727         * TestWebKitAPI/Tests/JavaScriptCore/InspectorConsoleMessage.cpp:
728         (TestWebKitAPI::TEST):
729
730 2021-02-08  Sam Weinig  <weinig@apple.com>
731
732         Update sRGB <-> XYZ conversion matrix values to match values in latest spec
733         https://bugs.webkit.org/show_bug.cgi?id=221533
734
735         Reviewed by Alex Christensen.
736
737         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
738         (TestWebKitAPI::TEST):
739         Update values to values in P3 <-> sRGB conversion test and update to
740         use EXPECT_FLOAT_EQ so the values can be seen in the output when thigs
741         fail.
742
743 2021-02-08  Lauro Moura  <lmoura@igalia.com>
744
745         [GLIB] Gardening geolocation API test flakiness
746
747         Unreviewed test gardening.
748
749         Failing regularly, likely due to the same geolocation API limitation.
750
751         * TestWebKitAPI/glib/TestExpectations.json:
752
753 2021-02-08  Andres Gonzalez  <andresg_22@apple.com>
754
755         Add support for aria-sort change notifications.
756         https://bugs.webkit.org/show_bug.cgi?id=221495
757
758         Reviewed by Chris Fleizach.
759
760         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
761         (WTR::AccessibilityUIElement::sortDirection const):
762         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
763         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
764         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
765         (WTR::AccessibilityUIElement::sortDirection const):
766         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
767         (WTR::AccessibilityUIElement::currentStateValue const):
768         (WTR::AccessibilityUIElement::sortDirection const):
769
770 2021-02-08  Philippe Normand  <pnormand@igalia.com>
771
772         [GLib] Permission request API for MediaKeySystem access support
773         https://bugs.webkit.org/show_bug.cgi?id=221199
774
775         Reviewed by Carlos Garcia Campos.
776
777         Added basic support for MediaKeySystem permission request to the GTK MiniBrowser, and a GLib
778         API unit-test as well.
779
780         * MiniBrowser/gtk/BrowserTab.c:
781         (permissionRequestDialogResponse):
782         (decidePermissionRequest):
783         (browser_tab_class_init):
784         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
785         (testWebViewMediaKeySystemPermissionRequests):
786         (beforeAll):
787         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
788         (WebViewTest::initializeWebView):
789
790 2021-02-08  Alicia Boya García  <aboya@igalia.com>
791
792         ConsoleMessage: Don't encode string JSONLogValue's as JSON
793         https://bugs.webkit.org/show_bug.cgi?id=221421
794
795         Reviewed by Eric Carlson.
796
797         Added API tests to check for the output of message() when constructing
798         ConsoleMessage objects with JSONLogValue's.
799
800         This includes changes contributed by Philippe Normand enabling
801         JavaScriptCore tests which were previously disabled in WebKitGTK and
802         making them compile again.
803
804         * TestWebKitAPI/CMakeLists.txt:
805         * TestWebKitAPI/Tests/WebKit/InspectorConsoleMessage.cpp: Added.
806         (TestWebKitAPI::TEST):
807
808 2021-02-08  Philippe Normand  <pnormand@igalia.com>
809
810         Permission request API for MediaKeySystem access support
811         https://bugs.webkit.org/show_bug.cgi?id=221187
812
813         Reviewed by Jer Noble.
814
815         Add support for setting the permission request response from the TestRunner, for usage within layout tests.
816
817         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
818         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
819         (WTR::TestRunner::setIsMediaKeySystemPermissionGranted):
820         * WebKitTestRunner/InjectedBundle/TestRunner.h:
821         * WebKitTestRunner/TestController.cpp:
822         (WTR::decidePolicyForMediaKeySystemPermissionRequest):
823         (WTR::TestController::completeMediaKeySystemPermissionCheck):
824         (WTR::TestController::setIsMediaKeySystemPermissionGranted):
825         (WTR::TestController::createWebViewWithOptions):
826         * WebKitTestRunner/TestController.h:
827         * WebKitTestRunner/TestInvocation.cpp:
828         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
829
830 2021-02-07  Sam Weinig  <weinig@apple.com>
831
832         Remove more special cases from color conversion
833         https://bugs.webkit.org/show_bug.cgi?id=221519
834
835         Reviewed by Antti Koivisto.
836
837         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
838         (TestWebKitAPI::TEST):
839         Replace convertTo<> component type conversion to general convertColor<>.
840
841 2021-02-06  Alex Christensen  <achristensen@webkit.org>
842
843         Non-special URLs should have an opaque origin
844         https://bugs.webkit.org/show_bug.cgi?id=162254
845
846         Reviewed by Geoff Garen.
847
848         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
849
850 2021-02-06  Aakash Jain  <aakash_jain@apple.com>
851
852         [build.webkit.org] Switch bot watchers dashboard to use new buildbot
853         https://bugs.webkit.org/show_bug.cgi?id=221493
854
855         Reviewed by Alexey Proskuryakov.
856
857         * CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
858         (WebKitBuildbot):
859
860 2021-02-05  Eric Carlson  <eric.carlson@apple.com>
861
862         [Mac] Disable MediaSessionTest API tests
863         https://bugs.webkit.org/show_bug.cgi?id=221514
864         <rdar://74048912>
865
866         Unreviewed, disable tests that don't play well with other media tests running
867         at the same time.
868
869         * TestWebKitAPI/Tests/WebKitCocoa/MediaSession.mm:
870         (TestWebKitAPI::TEST_F):
871
872 2021-02-05  Aakash Jain  <aakash_jain@apple.com>
873
874         [ews] Do not display identifier in status bubble tooltips
875         https://bugs.webkit.org/show_bug.cgi?id=221513
876
877         Unreviewed infrastucture fix.
878
879         * CISupport/ews-app/ews/views/statusbubble.py:
880
881 2021-02-05  Sihui Liu  <sihui_liu@appe.com>
882
883         REGRESSION(r272337): crash under WebCore::SpeechRecognizer::setInactive()
884         https://bugs.webkit.org/show_bug.cgi?id=221451
885
886         Reviewed by Youenn Fablet.
887
888         * TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:
889         (TestWebKitAPI::TEST):
890
891 2021-02-05  Eric Carlson  <eric.carlson@apple.com>
892
893         [Mac] Connect MediaSession with MediaRemote and NowPlaying
894         https://bugs.webkit.org/show_bug.cgi?id=221431
895         <rdar://problem/74000363>
896
897         Reviewed by Jer Noble.
898
899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
900         * TestWebKitAPI/Tests/WebKitCocoa/MediaSession.mm: Added.
901         (TestWebKitAPI::MediaSessionTest::webView):
902         (TestWebKitAPI::MediaSessionTest::webViewPid):
903         (TestWebKitAPI::MediaSessionTest::getNowPlayingClient):
904         (TestWebKitAPI::MediaSessionTest::getNowPlayingClientPid):
905         (TestWebKitAPI::MediaSessionTest::loadPageAndBecomeNowPlaying):
906         (TestWebKitAPI::MediaSessionTest::runScriptWithUserGesture):
907         (TestWebKitAPI::MediaSessionTest::play):
908         (TestWebKitAPI::MediaSessionTest::pause):
909         (TestWebKitAPI::MediaSessionTest::sendMediaRemoteCommand):
910         (TestWebKitAPI::MediaSessionTest::sendMediaRemoteSeekCommand):
911         (TestWebKitAPI::MediaSessionTest::listenForEventMessages):
912         (TestWebKitAPI::MediaSessionTest::eventListenerWasCalled):
913         (TestWebKitAPI::MediaSessionTest::waitForEventListenerToBeCalled):
914         (TestWebKitAPI::MediaSessionTest::listenForSessionHandlerMessages):
915         (TestWebKitAPI::MediaSessionTest::sessionHandlerWasCalled):
916         (TestWebKitAPI::MediaSessionTest::waitForSessionHandlerToBeCalled):
917         (TestWebKitAPI::MediaSessionTest::getSupportedCommands):
918         (TestWebKitAPI::TEST_F):
919         * TestWebKitAPI/Tests/WebKitCocoa/media-remote.html: Added.
920
921 2021-02-05  Sam Weinig  <weinig@apple.com>
922
923         Generalize color conversion code to reduce number of overloads required
924         https://bugs.webkit.org/show_bug.cgi?id=221443
925
926         Reviewed by Darin Adler.
927
928         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
929         (TestWebKitAPI::TEST):
930         Update tests to use convertColor<>.
931
932 2021-02-05  Aakash Jain  <aakash_jain@apple.com>
933
934         [ews] commit-queue should use commits.webkit.org url instead of trac url
935         https://bugs.webkit.org/show_bug.cgi?id=221476
936
937         Reviewed by Jonathan Bedard.
938
939         * CISupport/ews-build/steps.py:
940         (PushCommitToWebKitRepo.url_for_revision):
941         * CISupport/ews-build/steps_unittest.py:
942
943 2021-02-05  Lauro Moura  <lmoura@igalia.com>
944
945         [Flatpak SDK] Print stderr when coredumpctl fails
946         https://bugs.webkit.org/show_bug.cgi?id=221448
947
948         Reviewed by Philippe Normand.
949
950         * flatpak/flatpakutils.py:
951         (WebkitFlatpak.run_gdb):
952
953 2021-02-05  Chris Dumez  <cdumez@apple.com>
954
955         [GPUProcess][iOS] Audio is lost after media playback recovers from the GPUProcess crash
956         https://bugs.webkit.org/show_bug.cgi?id=221305
957         <rdar://problem/73904864>
958
959         Reviewed by Eric Carlson.
960
961         Unskip API test checks on iOS now that they are passing.
962
963         * TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
964         (TEST):
965
966 2021-02-05  Alicia Boya García  <aboya@igalia.com>
967
968         [GTK] run-gtk-tests: Support running individual tests for GTest test suites
969         https://bugs.webkit.org/show_bug.cgi?id=221050
970
971         Reviewed by Adrian Perez de Castro.
972
973         run-gtk-tests accepts any number of optional `-p` arguments to run
974         only certain tests. Unfortunately, this feature is only currently
975         implemented for glib tests suites.
976
977         This patch adds support for this feature with gtest suites as well.
978
979         * glib/api_test_runner.py:
980         (TestRunner._run_google_test_suite):
981         (TestRunner._run_test):
982
983 2021-02-04  Aakash Jain  <aakash_jain@apple.com>
984
985         [build.webkit.org] Update dashboard links for layout test results
986         https://bugs.webkit.org/show_bug.cgi?id=221280
987
988         Reviewed by Jonathan Bedard.
989
990         * CISupport/build-webkit-org/public_html/dashboard/Scripts/Buildbot.js:
991         (Buildbot): Set baseURLForResults.
992         (Buildbot.prototype.layoutTestResultsDirectoryURLForIteration): Use baseURLForResults if available.
993         * CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
994         (WebKitBuildbot): Pass baseURLForResults appropriately.
995
996 2021-02-04  Jonathan Bedard  <jbedard@apple.com>
997
998         [Python-3] Change shebang in test-webkitpy (Part-2)
999         https://bugs.webkit.org/show_bug.cgi?id=221415
1000         <rdar://problem/73986503>
1001
1002         Reviewed by Michael Catanzaro.
1003
1004         * CISupport/build-webkit-org/steps.py:
1005         (RunWebKitPyTests): Run test-webkitpy with Python 3.
1006         * Scripts/test-webkitpy: Change shebang.
1007         * Scripts/test-webkitpy-python3: Removed.
1008
1009 2021-02-04  Jonathan Bedard  <jbedard@apple.com>
1010
1011         [Python-3] Change shebang in git-webkit (Follow-up fix)
1012         https://bugs.webkit.org/show_bug.cgi?id=221412
1013         <rdar://problem/73983881>
1014
1015         Unreviewed follow-up fix.
1016
1017         * Scripts/libraries/webkitcorepy/webkitcorepy/subprocess_utils.py:
1018         (run): Python 3.6 does not support capture_output in subprocess.run()
1019
1020 2021-02-04  Jonathan Bedard  <jbedard@apple.com>
1021
1022         [Python-3] Change shebang in test-webkitpy (Part-1)
1023         https://bugs.webkit.org/show_bug.cgi?id=221415
1024         <rdar://problem/73986503>
1025
1026         Reviewed by Michael Catanzaro.
1027
1028         * Scripts/test-webkitpy-python2: Added.
1029
1030 2021-02-04  Jonathan Bedard  <jbedard@apple.com>
1031
1032         [Python-3] Change shebang in git-webkit (Part 2)
1033         https://bugs.webkit.org/show_bug.cgi?id=221412
1034         <rdar://problem/73983881>
1035
1036         Reviewed by Michael Catanzaro.
1037
1038         * CISupport/ews-build/steps.py:
1039         (ShowIdentifier.start): Invoke git-webkit with Python 3.
1040         * CISupport/ews-build/steps_unittest.py:
1041
1042 2021-02-04  Alex Christensen  <achristensen@webkit.org>
1043
1044         Don't launch a network process when registering URL schemes
1045         https://bugs.webkit.org/show_bug.cgi?id=221427
1046
1047         Reviewed by Chris Dumez.
1048
1049         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
1050         (TEST):
1051
1052 2021-02-04  Jonathan Bedard  <jbedard@apple.com>
1053
1054         [Python-3] Change shebang in check-webkit-style
1055         https://bugs.webkit.org/show_bug.cgi?id=221420
1056         <rdar://problem/73990232>
1057
1058         Reviewed by Michael Catanzaro.
1059
1060         * CISupport/ews-build/steps.py:
1061         (CheckStyle): Invoke check-webkit-style with python3.
1062         * CISupport/ews-build/steps_unittest.py:
1063         (TestCheckStyle.test_success_internal): Invoke check-webkit-style with python3.
1064         (TestCheckStyle.test_failure_unknown_try_codebase): Ditto.
1065         (TestCheckStyle.test_failures_with_style_issues): Ditto.
1066         (test_failures_no_style_issues): Ditto.
1067         (test_failures_no_changes): Ditto.
1068         * Scripts/check-webkit-style: Change python shebang to Python 3.
1069
1070 2021-02-04  Jonathan Bedard  <jbedard@apple.com>
1071
1072         [Python-3] Change shebang in git-webkit
1073         https://bugs.webkit.org/show_bug.cgi?id=221412
1074         <rdar://problem/73983881>
1075
1076         Reviewed by Stephanie Lewis.
1077
1078         * Scripts/git-webkit: Change python shebang to python3.
1079         * Scripts/libraries/webkitscmpy/git-webkit: Ditto.
1080         * Scripts/libraries/webkitscmpy/webkitscmpy/program/canonicalize/committer.py: Ditto.
1081         * Scripts/libraries/webkitscmpy/webkitscmpy/program/canonicalize/message.py: Ditto.
1082
1083 2021-02-04  Alex Christensen  <achristensen@apple.com>
1084
1085         REGRESSION(r267763) Network process launches earlier than before
1086         https://bugs.webkit.org/show_bug.cgi?id=221384
1087         <rdar://problem/73507706>
1088
1089         Reviewed by Chris Dumez.
1090
1091         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
1092         (TEST):
1093
1094 2021-02-04  Philippe Normand  <pnormand@igalia.com>
1095
1096         [GStreamer] Misc Thunder nitpicks
1097         https://bugs.webkit.org/show_bug.cgi?id=221398
1098
1099         Reviewed by Xabier Rodriguez-Calvar.
1100
1101         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1102         (TestWebKitAPI::TEST): Add test for Netflix WPE/GTK UA quirk.
1103
1104 2021-02-04  Aditya Keerthi  <akeerthi@apple.com>
1105
1106         [macOS] Selecting a date on datetime-local inputs unexpectedly adds second and millisecond fields
1107         https://bugs.webkit.org/show_bug.cgi?id=221350
1108         <rdar://problem/73943517>
1109
1110         Reviewed by Devin Rousso.
1111
1112         Added a method to UIScriptController to simulate selecting a date using
1113         the presented date picker.
1114
1115         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1116         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1117         (WTR::UIScriptController::chooseDateTimePickerValue):
1118         * WebKitTestRunner/mac/UIScriptControllerMac.h:
1119         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1120         (WTR::UIScriptControllerMac::chooseDateTimePickerValue):
1121
1122 2021-02-04  Eleni Maria Stea  <estea@igalia.com>
1123
1124         Modifications to Tools/wpe/install-dependencies
1125         https://bugs.webkit.org/show_bug.cgi?id=221254
1126
1127         Reviewed by Adrian Perez de Castro.
1128
1129         * wpe/install-dependencies: python-psutil is replaced with
1130         python3-psutil that is present in Debian/Ubuntu/Raspbian. libegl-mesa0
1131         is added in the dependencies list as it's required for libegl1-mesa-dev
1132         to be installed.
1133
1134
1135 2021-02-03  Jiewen Tan  <jiewen_tan@apple.com>
1136
1137         [WebAuthn] Allow one user gesture free prompt for each navigation
1138         https://bugs.webkit.org/show_bug.cgi?id=220897
1139         <rdar://problem/73541303>
1140
1141         Reviewed by Brent Fulgham.
1142
1143         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1144         (TestWebKitAPI::TEST):
1145
1146 2021-02-03  Devin Rousso  <drousso@apple.com>
1147
1148         [iOS] delay `+[BKSMousePointerService sharedInstance]` so that it doesn't impact launch perf
1149         https://bugs.webkit.org/show_bug.cgi?id=221298
1150
1151         Reviewed by Geoffrey Garen.
1152
1153         * TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:
1154         (iOSMouseSupport.MouseInitiallyDisconnected):
1155         (iOSMouseSupport.MouseInitiallyConnected):
1156         (iOSMouseSupport.MouseLaterDisconnected):
1157         (iOSMouseSupport.MouseLaterConnected):
1158
1159 2021-02-03  Alex Christensen  <achristensen@webkit.org>
1160
1161         Flaky API Test: TestWebKitAPI.WebKitLegacy.CrossPartitionFileSchemeAccess
1162         https://bugs.webkit.org/show_bug.cgi?id=206956
1163
1164         Reviewed by Alexey Proskuryakov.
1165
1166         createPartition is timing out on the bots but not locally.
1167         Don't hide the output of hdiutil so we can see what is happening on the bots.
1168
1169         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm:
1170         (createPartition):
1171
1172 2021-02-03  Ryan Haddad  <ryanhaddad@apple.com>
1173
1174         Replace Apple-Catalina-Release-JSC-Tests bot due to hardware failure
1175         https://bugs.webkit.org/show_bug.cgi?id=221315
1176
1177         Reviewed by Alexey Proskuryakov.
1178
1179         * CISupport/build-webkit-org/config.json: Replace bot157 with bot610.
1180
1181 2021-02-03  Antoine Quint  <graouts@webkit.org>
1182
1183         Add a loader for <model> resources
1184         https://bugs.webkit.org/show_bug.cgi?id=221255
1185
1186         Reviewed by Youenn Fablet.
1187
1188         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1189         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
1190
1191 2021-02-03  Ryan Haddad  <ryanhaddad@apple.com>
1192
1193         Big Sur test262 queues failing download-built-product step
1194         https://bugs.webkit.org/show_bug.cgi?id=221314
1195
1196         Reviewed by Aakash Jain.
1197
1198         * CISupport/build-webkit-org/config.json: Since we are building both x86
1199         and arm64 on Big Sur, we need to both architectures to be listed in the
1200         config so that the test262 bots can find the archives.
1201
1202 2021-02-03  Youenn Fablet  <youenn@apple.com>
1203
1204         Enable webrtc video capture in GPUProcess for iOS WebKitTestRunner
1205         https://bugs.webkit.org/show_bug.cgi?id=220966
1206
1207         Reviewed by Eric Carlson.
1208
1209         * WebKitTestRunner/TestOptions.cpp:
1210
1211 2021-02-02  Ryan Haddad  <ryanhaddad@apple.com>
1212
1213         Update Test262 bot to Big Sur
1214         https://bugs.webkit.org/show_bug.cgi?id=218844
1215
1216         Unreviewed infrastructure fix.
1217
1218         * CISupport/build-webkit-org/config.json: Remove an old trigger.
1219         * CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
1220         (WebKitBuildbot): Fix typo in queue name.
1221
1222 2021-02-02  Matt Lewis  <jlewis3@apple.com>
1223
1224         Remove Apple macOS Mojave queues
1225         https://bugs.webkit.org/show_bug.cgi?id=221211
1226
1227         Reviewed by Aakash Jain.
1228
1229         * CISupport/build-webkit-org/config.json:
1230         * CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js:
1231         * CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
1232         (WebKitBuildbot):
1233         * CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css:
1234         (table.queue-grid tr.platform.macos-mojave img.logo): Deleted.
1235         
1236 2021-02-02  Don Olmstead  <don.olmstead@sony.com>
1237
1238         [webkitcorepy] Autoinstaller can fail on packages containing write protected files
1239         https://bugs.webkit.org/show_bug.cgi?id=221266
1240
1241         Reviewed by Jonathan Bedard.
1242
1243         The autoinstaller extracts an archive containing the package to a temporary directory and
1244         then installs it from there. If the autoinstaller attempts to extract the archive again into
1245         the same temporary directory it can fail if there was a write protected file. The extraction
1246         will fail and the installer cannot continue until the temporary directory is cleared.
1247
1248         To prevent this the permissions for each file/directory in the tarball is manually set.
1249
1250         This was originally observed with the logilab-common package which ships with a test containing
1251         a write protected file.
1252
1253         * Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
1254         (Package.Archive.unpack):
1255
1256 2021-02-02  Aakash Jain  <aakash_jain@apple.com>
1257
1258         [ews] Commit queue failure message should indicate that cq+ flag can be set again
1259         https://bugs.webkit.org/show_bug.cgi?id=221269
1260
1261         Reviewed by Jonathan Bedard.
1262
1263         * CISupport/ews-build/steps.py:
1264         (PushCommitToWebKitRepo.comment_text_for_bug):
1265         * CISupport/ews-build/steps_unittest.py:
1266
1267 2021-02-02  Don Olmstead  <don.olmstead@sony.com>
1268
1269         [webkitpy] WinPort.delete_sem_locks is cygwin specific
1270         https://bugs.webkit.org/show_bug.cgi?id=221277
1271
1272         Reviewed by Jonathan Bedard.
1273
1274         WinPort.delete_sem_locks does `rm -rf /dev/shm/sem.*` which is only relavent when
1275         running cygwin. Just put a test for cygwin around the command invocation.
1276
1277         * Scripts/webkitpy/port/win.py:
1278         (WinPort.delete_sem_locks):
1279
1280 2021-02-02  Alex Christensen  <achristensen@webkit.org>
1281
1282         Adopt UIEventAttribution instead of _UIEventAttribution
1283         https://bugs.webkit.org/show_bug.cgi?id=220683
1284
1285         Reviewed by John Wilander.
1286
1287         * TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:
1288         (-[MockEventAttribution initWithReportEndpoint:destinationURL:]):
1289         (TestWebKitAPI::TEST):
1290         (-[MockEventAttribution initWithReportEndpoint:attributeOn:]): Deleted.
1291
1292 2021-02-02  Aakash Jain  <aakash_jain@apple.com>
1293
1294         [build.webkit.org] unzip layout-test-results in background
1295         https://bugs.webkit.org/show_bug.cgi?id=221263
1296
1297         Reviewed by Jonathan Bedard.
1298
1299         * CISupport/build-webkit-org/steps.py:
1300         (ExtractTestResults.__init__):
1301
1302 2021-02-02  Aakash Jain  <aakash_jain@apple.com>
1303
1304         ews isn't retrying builds when kill-old-processes fails
1305         https://bugs.webkit.org/show_bug.cgi?id=221235
1306
1307         Reviewed by Jonathan Bedard.
1308
1309         * CISupport/ews-build/steps.py:
1310         (KillOldProcesses.__init__): Increased timeout to 2 minutes.
1311         (KillOldProcesses.evaluateCommand): Used rc since self.results is None at this step.
1312         * CISupport/ews-build/steps_unittest.py: Updated unit-tests.
1313
1314 2021-02-02  Youenn Fablet  <youenn@apple.com>
1315
1316         Recover WebRTC codecs in case of GPUProcess crash
1317         https://bugs.webkit.org/show_bug.cgi?id=221138
1318
1319         Reviewed by Eric Carlson.
1320
1321         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
1322         (TestWebKitAPI::TEST):
1323         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1324
1325 2021-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1326
1327         [GTK][WPE] Migrate WebKitTestServer to libsoup 2.48 API
1328         https://bugs.webkit.org/show_bug.cgi?id=219160
1329         <rdar://problem/71620310>
1330
1331         Reviewed by Michael Catanzaro.
1332
1333         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1334         (serverCallback):
1335         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1336         (serverCallback):
1337         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1338         (serverCallback):
1339         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1340         (WebKitTestServer::WebKitTestServer):
1341         (WebKitTestServer::run):
1342         (WebKitTestServer::port const):
1343         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
1344
1345 2021-02-01  Ryan Haddad  <ryanhaddad@apple.com>
1346
1347         Update Test262 bot to Big Sur
1348         https://bugs.webkit.org/show_bug.cgi?id=218844
1349
1350         Reviewed by Yusuke Suzuki.
1351
1352         * CISupport/build-webkit-org/config.json:
1353         * CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
1354         (WebKitBuildbot):
1355         * CISupport/build-webkit-org/steps_unittest_old.py:
1356
1357 2021-02-01  Jiewen Tan  <jiewen_tan@apple.com>
1358
1359         [WebAuthn] Optimize _WKWebAuthenticationPanelDelegate for native API
1360         https://bugs.webkit.org/show_bug.cgi?id=221125
1361         <rdar://problem/71509141>
1362
1363         Reviewed by Brent Fulgham.
1364
1365         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1366         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
1367         (-[TestWebAuthenticationPanelDelegate panel:requestLAContextForUserVerificationWithCompletionHandler:]):
1368         (TestWebKitAPI::WebCore::reset):
1369         (TestWebKitAPI::TEST):
1370
1371 2021-02-01  Don Olmstead  <don.olmstead@sony.com>
1372
1373         [webkitscmpy] Use shutil to find scm executable paths
1374         https://bugs.webkit.org/show_bug.cgi?id=221220
1375
1376         Reviewed by Jonathan Bedard.
1377
1378         Using /usr/bin/which is not a cross platform way to determine the path to an executable.
1379         In Python 3 shutil gailed a which function which provides the same functionality as the
1380         which executable and works on Windows.
1381
1382         Added the whichcraft library which is a backport of shutil.which to Python 2.7. If
1383         Python 3 is available it just uses shutil directly. The library can be dropped once Python
1384         2.7 support is jettisoned.
1385
1386         * Scripts/libraries/webkitscmpy/setup.py:
1387         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:
1388         * Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:
1389         (Scm.executable):
1390         * Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
1391         * Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/svn.py:
1392
1393 2021-02-01  Jonathan Bedard  <jbedard@apple.com>
1394
1395         [webkitcorepy] Support machines without Unix signal handling
1396         https://bugs.webkit.org/show_bug.cgi?id=221150
1397         <rdar://problem/73769605>
1398
1399         Rubber-stamped by Aakash Jain.
1400
1401         * Scripts/libraries/webkitcorepy/setup.py: Bump version.
1402         * Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
1403         * Scripts/libraries/webkitcorepy/webkitcorepy/mocks/popen.py:
1404         (PopenBase):
1405         (PopenBase.send_signal): Handle undefined signal variables.
1406         (PopenBase.terminate):
1407         (PopenBase.kill):
1408         * Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:
1409         (Process.handler): Handle undefined signal variable.
1410         (Process.main): Ditto.
1411         * Scripts/libraries/webkitcorepy/webkitcorepy/timeout.py:
1412         (Timeout): Timeout class should own SIGALRM.
1413         (Timeout.DisableAlarm.__enter__): Do not disable alarm if alarm is not available.
1414         (Timeout.check): Pass SIGALRM owned by Timeout object.
1415         (Timeout.bind): Do not disable alarm if alarm is not available, use SIGALRM owned by the Timeout object.
1416         (Timeout.bind.handler): Ditto.
1417         (Timeout.sleep): Use SIGALRM owned by the Timeout object.
1418
1419 2021-02-01  Alicia Boya García  <aboya@igalia.com>
1420
1421         autoinstall.py: Don't use an XML parser to parse HTML
1422         https://bugs.webkit.org/show_bug.cgi?id=221162
1423
1424         Reviewed by Jonathan Bedard.
1425
1426         Very recently autoinstall.py started failing becagse the page returned
1427         by https://pypi.org/simple/fasteners/ now contains a <meta> tag, which
1428         is not parseable as XML without the trailing slash.
1429
1430         Despite what an initial fix in r272041 stated, this is not caused by
1431         invalid HTML: <meta> tags are not required to have an ending slash to
1432         be standards compliant in any version of HTML.
1433
1434         This patch replaces that code to use an HTML parser instead of an XML
1435         parser, making it more robust.
1436
1437         * Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
1438         (SimplyPypiIndexPageParser):
1439         (SimplyPypiIndexPageParser.__init__):
1440         (SimplyPypiIndexPageParser.handle_starttag):
1441         (SimplyPypiIndexPageParser.handle_data):
1442         (SimplyPypiIndexPageParser.handle_endtag):
1443         (SimplyPypiIndexPageParser.parse):
1444         (Package.archives):
1445
1446 2021-02-01  Sihui Liu  <sihui_liu@appe.com>
1447
1448         Use user media permission prompt for speech recognition
1449         https://bugs.webkit.org/show_bug.cgi?id=221082
1450         rdar://problem/73372499
1451
1452         Reviewed by Youenn Fablet.
1453
1454         * TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:
1455         (-[SpeechRecognitionUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
1456
1457 2021-02-01  Aakash Jain  <aakash_jain@apple.com>
1458
1459         [build.webkit.org] is_test_mode_enabled should default to True
1460         https://bugs.webkit.org/show_bug.cgi?id=221208
1461
1462         Reviewed by Jonathan Bedard.
1463
1464         * CISupport/build-webkit-org/master_buildbot2.cfg:
1465
1466 2021-02-01  Yusuke Suzuki  <ysuzuki@apple.com>
1467
1468         [JSC] Add @ in Error.stack if URL exists
1469         https://bugs.webkit.org/show_bug.cgi?id=221184
1470
1471         Reviewed by Keith Miller.
1472
1473         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1474         (testJSCExceptions):
1475
1476 2021-01-29  Don Olmstead  <don.olmstead@sony.com>
1477
1478         [webkitpy] Thread.isAlive was renamed to Thread.is_alive
1479         https://bugs.webkit.org/show_bug.cgi?id=221160
1480
1481         Reviewed by Jonathan Bedard.
1482
1483         Python 2.6 added threading.Thread.is_alive which aliased isAlive. In Python 3.x only
1484         threading.Thread.is_alive is available so use that instead. 
1485
1486         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1487         (Worker._run_test_in_another_thread):
1488
1489 2021-01-29  Myles C. Maxfield  <mmaxfield@apple.com>
1490
1491         Upgrade motionmark1.1.plan to r272044
1492         https://bugs.webkit.org/show_bug.cgi?id=221148
1493
1494         Reviewed by Said Abou-Hallawa.
1495
1496         r272044 is attempting to address extreme variance in the test.
1497
1498         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan:
1499
1500 2021-01-29  Dmitry Bezhetskov  <dbezhetskov@igalia.com>
1501
1502         [WASM-References] Enable reference types by default
1503         https://bugs.webkit.org/show_bug.cgi?id=220890
1504
1505         Reviewed by Yusuke Suzuki.
1506
1507         Enable wasm reference types by default.
1508
1509         * Scripts/run-jsc-stress-tests:
1510
1511 2021-01-29  Andres Gonzalez  <andresg_22@apple.com>
1512
1513         Support for aria-current state changed notifications.
1514         https://bugs.webkit.org/show_bug.cgi?id=221074
1515
1516         Reviewed by Chris Fleizach.
1517
1518         Added AccessibilityUIElement::domIdentifier and currentStateValue used
1519         in LayoutTests/accessibility/aria-current-state-changed-notification.html.
1520
1521         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1522         (WTR::AccessibilityUIElement::domIdentifier const): Non-Cocoa implementation.
1523         (WTR::AccessibilityUIElement::currentStateValue const): Non-Cocoa implementation.
1524         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1525         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1526         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1527         (WTR::AccessibilityUIElement::domIdentifier const):
1528         (WTR::AccessibilityUIElement::stringAttributeValue):
1529         (WTR::AccessibilityUIElement::currentStateValue const):
1530         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1531         (WTR::AccessibilityUIElement::domIdentifier const):
1532         (WTR::AccessibilityUIElement::currentStateValue const):
1533
1534 2021-01-29  David Kilzer  <ddkilzer@apple.com>
1535
1536         check-webkit-style: warn about WTF::BlockPtr use in JavaScriptCore until ARC is enabled
1537         <https://webkit.org/b/221108>
1538         <rdar://problem/73726640>
1539
1540         Reviewed by Joseph Pecoraro.
1541
1542         * Scripts/webkitpy/style/checkers/cpp.py:
1543         (_is_javascriptcore_file): Add.
1544         - Extract code to reuse from
1545           check_identifier_name_in_declaration().
1546         (check_include_line):
1547         (check_language):
1548         - Add check for use of WTF::BlockPtr.
1549         (check_identifier_name_in_declaration):
1550         - Use _is_javascriptcore_file().
1551         (CppChecker):
1552         - Add 'security/javascriptcore_wtf_blockptr' to list of
1553           checkers.
1554         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1555         (CppStyleTestBase.perform_language_rules_check):
1556         - Add 'security/javascriptcore_wtf_blockptr' to list of
1557           checkers for testing header includes.
1558         (OrderOfIncludesTest.test_check_wtf_blockptr_usage_in_javascriptcore):
1559         - Add test to detect use of WTF::BlockPtr in JavaScriptCore.
1560
1561 2021-01-29  Angelos Oikonomopoulos  <angelos@igalia.com>
1562
1563         [JSC] Implement --artifact-exec-wrapper
1564         https://bugs.webkit.org/show_bug.cgi?id=220924
1565
1566         Reviewed by Carlos Alberto Lopez Perez.
1567
1568         Add an option to specify a wrapper for executing the built
1569         artifacts for JSC (i.e. jsc, testmasm, ...). This is useful when
1570         crossbuilding, to be able to specify the ELF interpreter and
1571         LD_LIBRARY_PATH for the built executables (and only those; the
1572         scripts may well execute native binaries that shouldn't be
1573         wrapped). It's not needed when running the tests on the remotes
1574         (as generate-bundle will take care of all that), but helps
1575         e.g. when running 32-bit ARM binaries on a 64-bit host and not
1576         using the system compiler/libraries.
1577
1578         This patch also simplifies the bytecode cache helper by switching
1579         the argument order and changes a couple of uses of pathToVM to
1580         vmCommand for consistency. It should be noted that
1581         --artifact-exec-wrapper is not compatible with
1582         --force-architecture. That shouldn't be a problem as (a) the use
1583         cases of the two flags don't seem to overlap and (b) the exec
1584         wrapper can subsume the functionality of --force-architecture.
1585
1586         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1587         * Scripts/run-javascriptcore-tests:
1588         (runTest):
1589         (runJSCStressTests):
1590         * Scripts/run-jsc-stress-tests:
1591
1592 2021-01-29  Youenn Fablet  <youenn@apple.com>
1593
1594         [MacOS] Enable WebKitTestRunner audio and video capture in GPUProcess
1595         https://bugs.webkit.org/show_bug.cgi?id=221035
1596
1597         Reviewed by Eric Carlson.
1598
1599         Remove the default TestOptions values and instead on MacOS rely on capture in GPUProcess.
1600         On iOS, capture ill still happen inprocess for the time being.
1601
1602         * WebKitTestRunner/TestOptions.cpp:
1603         (WTR::TestOptions::defaults):
1604
1605 2021-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1606
1607         [SOUP] Use a GInputStream to set the request body in preparation for libsoup3
1608         https://bugs.webkit.org/show_bug.cgi?id=221034
1609
1610         Reviewed by Adrian Perez de Castro.
1611
1612         Add WebKitFormDataInputStream as an exception for some style checker rules.
1613
1614         * Scripts/webkitpy/style/checker.py:
1615
1616 2021-01-28  Lauro Moura  <lmoura@igalia.com>
1617
1618         [GLIB] Gardening API release passes and some debug crashes
1619
1620         Unreviewed test gardening.
1621
1622         Many debug crashes still to be listed.
1623
1624         * TestWebKitAPI/glib/TestExpectations.json:
1625
1626 2021-01-28  Myles C. Maxfield  <mmaxfield@apple.com>
1627
1628         Minor cleanup in CSSFontFaceSetClient
1629         https://bugs.webkit.org/show_bug.cgi?id=221019
1630
1631         Reviewed by Ryosuke Niwa.
1632
1633         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1634         (TestWebKitAPI::MultipleInheritanceDerived::meowCalled const):
1635         (TestWebKitAPI::MultipleInheritanceDerived::woofCalled const):
1636         (TestWebKitAPI::TEST):
1637
1638 2021-01-28  Jonathan Bedard  <jbedard@apple.com>
1639
1640         [webkitcrepy] Handle case where pypi serves invalid html
1641         https://bugs.webkit.org/show_bug.cgi?id=221111
1642         <rdar://problem/73728580>
1643
1644         Reviewed by David Kilzer.
1645
1646         * Scripts/libraries/webkitcorepy/setup.py: Bump version number.
1647         * Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
1648         * Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
1649         (Package.archives): Remove possibly invalid <meta> tag from html.
1650
1651 2021-01-28  Aakash Jain  <aakash_jain@apple.com>
1652
1653         [build.webkit.org] Remove dead code for TestWebKit1LeaksFactory
1654         https://bugs.webkit.org/show_bug.cgi?id=221090
1655
1656         Reviewed by Jonathan Bedard.
1657
1658         * CISupport/build-webkit-org/factories.py:
1659         (BuildAndJSCTestsFactory.__init__):
1660         (TestWebKit1LeaksFactory): Deleted.
1661         (TestWebKit1LeaksFactory.__init__): Deleted.
1662         * CISupport/build-webkit-org/steps.py:
1663         (ExtractTestResults.finished):
1664         (ExtractTestResultsAndLeaks): Deleted.
1665         (ExtractTestResultsAndLeaks.addCustomURLs): Deleted.
1666
1667 2021-01-28  Matt Lewis  <jlewis3@apple.com>
1668
1669         Move Mac EWS to macOS Catalina.
1670         https://bugs.webkit.org/show_bug.cgi?id=220818
1671         
1672
1673         Reviewed by Aakash Jain.
1674
1675         * CISupport/ews-build/config.json:
1676         * CISupport/ews-build/factories_unittest.py:
1677         (TestBuildFactory.test_generic_build_factory):
1678         (TestBuildFactory.test_macos_build_factory):
1679         (TestCommitQueueFactory.test_commit_queue_factory):
1680         (TestLayoutTestsFactory.test_macos_wk1_release_factory):
1681         (TestLayoutTestsFactory.test_macos_wk1_debug_factory):
1682         (TestLayoutTestsFactory.test_macos_wk2_factory):
1683         * CISupport/ews-build/steps_unittest.py:
1684         (TestAnalyzeCompileWebKitResults.test_filter_logs_containing_error_with_no_error):
1685
1686 2021-01-28  Lauro Moura  <lmoura@igalia.com>
1687
1688         [Flatpak SDK] Flatpak environment JSON is prematurely deleted with flatpak-spawn calls
1689         https://bugs.webkit.org/show_bug.cgi?id=221070
1690
1691         Reviewed by Philippe Normand.
1692
1693         To avoid nested webkit-flatpak calls overwriting/deleting whe
1694         environment file, only create if there is no such file and only delete
1695         in the same process that created it.
1696
1697         This approach has the drawback of limiting nested calls changing the
1698         variable values and a file undeleted after a crash might avoid the
1699         next normal invocation creating it.
1700
1701         * flatpak/flatpakutils.py:
1702         (WebkitFlatpak.run_in_sandbox):
1703
1704 2021-01-28  Alicia Boya García  <aboya@igalia.com>
1705
1706         [GTK] run-gtk-tests: Ensure correct count when subtests are specified
1707         https://bugs.webkit.org/show_bug.cgi?id=221049
1708
1709         Reviewed by Adrian Perez de Castro.
1710
1711         Currently the code of run-gtk-tests adds the number of skipped tests
1712         to the count of total tests. That computation failed to take into
1713         account the case where specific subtests are run (by means of passing
1714         the -p argument), instead of the full test suite.
1715
1716         This patch fixes that, only adding to "total tests" those skipped
1717         subtests that were also specified with the -p argument when using that
1718         mode.
1719
1720         * glib/api_test_runner.py:
1721         (TestRunner.run_tests):
1722
1723 2021-01-28  Lauro Moura  <lmoura@igalia.com>
1724
1725         [Flatpak SDK] Avoid "Invalid byte sequence in conversion input" errors and other encoding issues
1726         https://bugs.webkit.org/show_bug.cgi?id=221068
1727
1728         Reviewed by Philippe Normand.
1729
1730         * flatpak/flatpakutils.py:
1731         (WebkitFlatpak.execute_command): Decode the arguments before printing.
1732         (WebkitFlatpak.run_in_sandbox): Avoid iterating mutating dict and
1733         export LANG.
1734         * flatpak/webkit-bwrap: Ignore LANG as it's exported by
1735         flatpakutils.py.
1736
1737 2021-01-27  Aakash Jain  <aakash_jain@apple.com>
1738
1739         [build.webkit.org] Add basic authentication
1740         https://bugs.webkit.org/show_bug.cgi?id=221052
1741
1742         Reviewed by Jonathan Bedard.
1743
1744         * CISupport/build-webkit-org/master_buildbot2.cfg:
1745
1746 2021-01-27  Kate Cheney  <katherine_cheney@apple.com>
1747
1748         WKWebView closeAllMediaPresentations API does not have a completion handler
1749         https://bugs.webkit.org/show_bug.cgi?id=220741
1750         <rdar://problem/73045904>
1751
1752         Reviewed by Youenn Fablet.
1753
1754         Update API tests to use the new completion handler. Move from using JS
1755         to a new SPI to check for inline video to avoid flakiness because the
1756         JS value is async and may not be completed by the time
1757         didExitFullscreen() is called.
1758
1759         Add a new case for multiple sequential calls to
1760         closeAllMediaPresentations.
1761
1762         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
1763         (TEST):
1764
1765 2021-01-27  Devin Rousso  <drousso@apple.com>
1766
1767         [iOS] expose existing macOS-only `-[WKWebView _pageExtendedBackgroundColor]` SPI
1768         https://bugs.webkit.org/show_bug.cgi?id=221015
1769         <rdar://problem/73636453>
1770
1771         Reviewed by Tim Horton.
1772
1773         * TestWebKitAPI/Tests/WebKitCocoa/PageExtendedBackgroundColor.mm: Added.
1774         (TEST.PageExtendedBackgroundColor.OnLoad):
1775         (TEST.PageExtendedBackgroundColor.MultipleTags):
1776         (-[WKWebViewPageExtendedBackgroundColorObserver initWithWebView:]):
1777         (-[WKWebViewPageExtendedBackgroundColorObserver observeValueForKeyPath:ofObject:change:context:]):
1778         (TEST.PageExtendedBackgroundColor.KVO):
1779
1780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1781
1782 2021-01-27  Alicia Boya García  <aboya@igalia.com>
1783
1784         [GTK] run-gtk-tests: Crashing and non-existent tests should not count as a pass
1785         https://bugs.webkit.org/show_bug.cgi?id=220863
1786
1787         Reviewed by Michael Catanzaro.
1788
1789         The current implementation doesn't account for test binaries that have
1790         not emitted any subtests. This is the case when a test binary doesn't
1791         exist or it crashes.
1792
1793         Also, in the latter case, the stderr of the crashed processes was not
1794         being outputted to the user, masking a crashing test binary as a
1795         passing test.
1796
1797         This patch fixes both issues: It adds several warning prints when
1798         binaries can't be run or fail to add any subtest, emitting the stderr
1799         generated by the failing or crashing binary.
1800
1801         * glib/api_test_runner.py:
1802         (TestRunner._run_test):
1803         (TestRunner.run_tests):
1804         * glib/glib_test_runner.py:
1805         (GLibTestRunner.run):
1806
1807 2021-01-27  Youenn Fablet  <youenn@apple.com>
1808
1809         Enable GPU WebRTC codecs in WebKitTestRunner
1810         https://bugs.webkit.org/show_bug.cgi?id=220936
1811
1812         Reviewed by Eric Carlson.
1813
1814         * WebKitTestRunner/TestController.cpp:
1815         (WTR::TestController::resetPreferencesToConsistentValues):
1816
1817 2021-01-27  Philippe Normand  <pnormand@igalia.com>
1818
1819         REGRESSION(r271634): keyring still failing to retrieve secrets
1820         https://bugs.webkit.org/show_bug.cgi?id=221029
1821
1822         Reviewed by Sergio Villar Senin.
1823
1824         * Scripts/libraries/webkitscmpy/setup.py: Reduce version number duplication by reusing the
1825         Version object declared in the package.
1826         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version and downgrade to
1827         usable keyring version (in Linux at least).
1828
1829 2021-01-27  Commit Queue  <commit-queue@webkit.org>
1830
1831         Unreviewed, reverting r271940.
1832         https://bugs.webkit.org/show_bug.cgi?id=221040
1833
1834         Some tests are failing on bots
1835
1836         Reverted changeset:
1837
1838         "[MacOS] Enable NSURLSession WebSocket code path in
1839         WebKitTestRunner"
1840         https://bugs.webkit.org/show_bug.cgi?id=220973
1841         https://trac.webkit.org/changeset/271940
1842
1843 2021-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1844
1845         [GTK] Test /webkit/WebKitSettings/webkit-settings is failing since r271354
1846         https://bugs.webkit.org/show_bug.cgi?id=221033
1847
1848         Reviewed by Adrian Perez de Castro.
1849
1850         Since r271354 the font values set in WebKitSettings are always the same you get no matter what the current DPI
1851         is. The scaling factor is applied to the font size without actually changing the setting.
1852
1853         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1854         (testWebKitSettings): Update the test to check the correct behavior.
1855         * TestWebKitAPI/glib/TestExpectations.json: Remove expectation for the test.
1856
1857 2021-01-27  Youenn Fablet  <youenn@apple.com>
1858
1859         [MacOS] Enable NSURLSession WebSocket code path in WebKitTestRunner
1860         https://bugs.webkit.org/show_bug.cgi?id=220973
1861
1862         Reviewed by Darin Adler.
1863
1864         Enable NSURLSession WebSocket code path in MacOS.
1865
1866         * WebKitTestRunner/TestController.cpp:
1867         (WTR::TestController::resetPreferencesToConsistentValues):
1868
1869 2021-01-27  Philippe Normand  <pnormand@igalia.com> and Lauro Moura  <lmoura@igalia.com>
1870
1871         [Flatpak SDK] Flatpak 1.10 environment variable issues
1872         https://bugs.webkit.org/show_bug.cgi?id=220781
1873
1874         Reviewed by Adrian Perez de Castro.
1875
1876         Flatpak no longer passes its env variables to bwrap, so the workaround is now to serialize
1877         it on-disk in a JSON file and load it from our webkit-bwrap script.
1878
1879         * flatpak/flatpakutils.py:
1880         (WebkitFlatpak.run_in_sandbox):
1881         * flatpak/webkit-bwrap:
1882
1883 2021-01-26  Sihui Liu  <sihui_liu@appe.com>
1884
1885         Mute audio capture for speech recognition based on shouldInterruptAudioOnPageVisibilityChange when page is invisible
1886         https://bugs.webkit.org/show_bug.cgi?id=220960
1887
1888         Reviewed by Youenn Fablet.
1889
1890         * TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:
1891         (TestWebKitAPI::TEST):
1892         * TestWebKitAPI/Tests/WebKitCocoa/speechrecognition-basic.html:
1893
1894 2021-01-26  Devin Rousso  <drousso@apple.com>
1895
1896         Expose the value of `<meta name="theme-color" content="...">` as SPI
1897         https://bugs.webkit.org/show_bug.cgi?id=220944
1898         <rdar://problem/72198083>
1899
1900         Reviewed by Tim Horton.
1901
1902         * TestWebKitAPI/Tests/WebKitCocoa/HTMLMetaThemeColor.mm: Added.
1903         (TEST.HTMLMetaThemeColor.OnLoad):
1904         (TEST.HTMLMetaThemeColor.MultipleTags):
1905         (-[WKWebViewThemeColorObserver initWithWebView:]):
1906         (-[WKWebViewThemeColorObserver observeValueForKeyPath:ofObject:change:context:]):
1907         (TEST.HTMLMetaThemeColor.KVO):
1908
1909         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1910
1911 2021-01-26  Lauro Moura  <lmoura@igalia.com>
1912
1913         [GLIB] API tests fail to report harness failures
1914         https://bugs.webkit.org/show_bug.cgi?id=220938
1915
1916         Reviewed by Carlos Garcia Campos.
1917
1918         The GLibTestRunner class parses the stdout of the child test program to
1919         detect failures and crashes using GLib's g_test_* protocol, but the
1920         setup and teardown of each suite/program is done manually in the
1921         beforeAll/afterAll functions. Their output/status need to be checked
1922         separately by the runner scripts.
1923
1924         This commit checks if a failure happens before any test is run (a
1925         beforeAll failure) and if there is still pending stderr output not
1926         processed by g_test_run (an afterAll failure).
1927
1928         * glib/glib_test_runner.py:
1929         (GLibTestRunner.run):
1930
1931 2021-01-26  Commit Queue  <commit-queue@webkit.org>
1932
1933         Unreviewed, reverting r271578.
1934         https://bugs.webkit.org/show_bug.cgi?id=221003
1935
1936         Title changes reverted made WPEQt tests fail
1937
1938         Reverted changeset:
1939
1940         "[WPE] Fix WPEQt tests after r271514"
1941         https://bugs.webkit.org/show_bug.cgi?id=220681
1942         https://trac.webkit.org/changeset/271578
1943
1944 2021-01-26  Angelos Oikonomopoulos  <angelos@igalia.com>
1945
1946         [JSC] Do not specify remote file location to the JSConly bots
1947         https://bugs.webkit.org/show_bug.cgi?id=220923
1948
1949         Reviewed by Carlos Alberto Lopez Perez.
1950
1951         There is no need to treat JSC buildbots that use remotes any
1952         different. The worker side needs to supply the remote
1953         configuration file in any case and it can also specify
1954         --remote-config-file in TEST_JSC_ARGS.
1955
1956         What's more, letting the worker be in control makes it easier to
1957         implement changes without having to request upstream configuration
1958         changes (or, worse, temporarily overriding the configuration
1959         recorded in config.json).
1960
1961         * CISupport/build-webkit-org/config.json:
1962         * CISupport/build-webkit-org/factories.py:
1963         (BuildAndJSCTestsFactory):
1964         (BuildAndJSCTestsFactory.__init__):
1965         * CISupport/build-webkit-org/steps.py:
1966         (RunJavaScriptCoreTests.countFailures):
1967
1968 2021-01-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1969
1970         [SOUP] Stop using SoupRequest API to load files in preparation for libsoup3
1971         https://bugs.webkit.org/show_bug.cgi?id=220509
1972
1973         Reviewed by Adrian Perez de Castro.
1974
1975         Add WebKitDirectoryInputStream.cpp as exception for style checker.
1976
1977         * Scripts/webkitpy/style/checker.py:
1978
1979 2021-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1980
1981         Unreviewed, reverting r271514 and r271549
1982
1983         Made TestWebKitAPI.WebKit.PrintFrame flaky
1984
1985         Reverted changeset:
1986
1987         "Use event loop to set title"
1988         https://bugs.webkit.org/show_bug.cgi?id=218496
1989         https://trac.webkit.org/changeset/271514
1990
1991 2021-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1992
1993         ASSERT NOT REACHED in WebCore::DisplayList::isDrawingItem
1994         https://bugs.webkit.org/show_bug.cgi?id=220948
1995         <rdar://problem/73588734>
1996
1997         Reviewed by Tim Horton.
1998
1999         The API test `DisplayListTests.OutOfLineItemDecodingFailure` was intended to read from the display list copy
2000         rather than the original list, in order to exercise the (intentional) decoding failure.
2001
2002         Instead, this test erroneously attempts to read from the original display list (which, importantly, doesn't have
2003         a reading client) and ends up exercising the decoding failure anyways, but additionally hits a debug assertion
2004         in the process. Simply fix this by reading out of the correct display list (and rename the original display list
2005         in the process to make the test more clear).
2006
2007         * TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:
2008         (TestWebKitAPI::TEST)
2009
2010 2021-01-25  Aakash Jain  <aakash_jain@apple.com>
2011
2012         Changes to commit-log-editor should trigger webkitpy EWS tests
2013         https://bugs.webkit.org/show_bug.cgi?id=220953
2014
2015         Reviewed by Jonathan Bedard.
2016
2017         * CISupport/ews-build/steps.py:
2018         (CheckPatchRelevance): Added commit-log-editor to list of relevant files for webkitpy ews.
2019         * CISupport/ews-build/steps_unittest.py: Improved unit-test to check for various file-names.
2020
2021 2021-01-25  Jonathan Bedard  <jbedard@apple.com>
2022
2023         [run-webkit-tests] Support python layout tests
2024         https://bugs.webkit.org/show_bug.cgi?id=220749
2025         <rdar://problem/73375271>
2026
2027         Reviewed by Alexey Proskuryakov.
2028
2029         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2030         (LayoutTestFinder._real_tests): Exclude "tools" directories.
2031         (LayoutTestFinder._is_test_file): Special case for web socket's *_wsh.py files.
2032         (LayoutTestFinder._is_w3c_resource_file): Exclude w3c Python files.
2033
2034 2021-01-25  Ryan Haddad  <ryanhaddad@apple.com>
2035
2036         Unreviewed, reverting r271805.
2037
2038         Appears to have broken generation of changed files/functions
2039         in commit logs
2040
2041         Reverted changeset:
2042
2043         "The generated commit message have a directory label at the
2044         first line rather than the bug's title if ChangeLogs have
2045         different bug titles"
2046         https://bugs.webkit.org/show_bug.cgi?id=220822
2047         https://trac.webkit.org/changeset/271805
2048
2049 2021-01-25  Alex Christensen  <achristensen@webkit.org>
2050
2051         ASSERTION FAILED: This HTTPServer does not know how to respond to a request for /Ahem.svg
2052         https://bugs.webkit.org/show_bug.cgi?id=220949
2053
2054         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2055         (TEST):
2056         A path in the test I added in r271770 was missing a / at the beginning of a path.
2057         It passes before and after this change, but it doesn't assert after it.
2058
2059 2021-01-25  Aakash Jain  <aakash_jain@apple.com>
2060
2061         [ews] Commit Queue should retry the build when update-working-directory step fails
2062         https://bugs.webkit.org/show_bug.cgi?id=220836
2063
2064         Reviewed by Jonathan Bedard.
2065
2066         * CISupport/ews-build/steps.py:
2067         (UpdateWorkingDirectory):
2068         (UpdateWorkingDirectory.getResultSummary): Provide better failure message.
2069         (UpdateWorkingDirectory.evaluateCommand): Retry the build when this step fails.
2070         * CISupport/ews-build/steps_unittest.py:
2071
2072 2021-01-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2073
2074         The generated commit message have a directory label at the first line rather than the bug's title if ChangeLogs have different bug titles
2075         https://bugs.webkit.org/show_bug.cgi?id=220822
2076
2077         Reviewed by Darin Adler.
2078
2079         commit-log-editor generates the default commit message by
2080         collecting all ChangeLog entries and merging them with prepending
2081         directory lables. If it finds out a common prefix for all entries,
2082         it removes the prefix from entries and hoists the prefix as the
2083         beginning of the commit message. This step removes duplicated
2084         lines of the bug title, the bug URL, the reviewed-by line, and the
2085         descriptions.
2086
2087         If such prefix is not found, i.e. ChangeLog entries has different
2088         bug titles, it simply merges all entries with directory labels. As
2089         the result, the generated commit message has the directory label
2090         at the first line. This is not desirable. The first line of the
2091         commit message should be the bug title.
2092
2093         This patch yanks the first line of the first entry as the common
2094         prefix in the case.
2095
2096         * Scripts/commit-log-editor:
2097         (createCommitMessage):
2098         (removeLongestCommonPrefixEndingInNewline):
2099
2100 2021-01-25  Lauro Moura  <lmoura@igalia.com>
2101
2102         [GLIB] Gardening API failures after r271794
2103
2104         Unreviewed test gardening.
2105
2106         Looks like these failures flew under the radar by not actually being
2107         run by run-gtk/wpe-tests, and were uncovered by r271794.
2108
2109         Marking them as failure to allow the EWS to run normally while they're
2110         fixed.
2111
2112         * TestWebKitAPI/glib/TestExpectations.json:
2113
2114 2021-01-25  Aakash Jain  <aakash_jain@apple.com>
2115
2116         [build.webkit.org] Download the build archive from master when download from S3 fails
2117         https://bugs.webkit.org/show_bug.cgi?id=220932
2118
2119         Reviewed by Jonathan Bedard.
2120
2121         * CISupport/build-webkit-org/steps.py:
2122         (DownloadBuiltProduct):
2123         (DownloadBuiltProduct.evaluateCommand): If this fails, run DownloadBuiltProductFromMaster.
2124         (DownloadBuiltProductFromMaster): Build step to download archive from master using buildbot FileDownload class.
2125         (DownloadBuiltProductFromMaster.__init__):
2126         (DownloadBuiltProductFromMaster.getResultSummary): Custom failure message.
2127
2128 2021-01-25  Aakash Jain  <aakash_jain@apple.com>
2129
2130         layout-test results shouldn't be hosted on build.webkit.org server
2131         https://bugs.webkit.org/show_bug.cgi?id=220864
2132
2133         Reviewed by Jonathan Bedard.
2134
2135         * CISupport/build-webkit-org/steps.py:
2136         (ExtractTestResults.resultDirectoryURL):
2137
2138 2021-01-25  John Wilander  <wilander@apple.com>
2139
2140         PCM: Use different well-known locations for triggering and reporting attribution
2141         https://bugs.webkit.org/show_bug.cgi?id=220902
2142         <rdar://problem/73550632>
2143
2144         Reviewed by Brent Fulgham.
2145
2146         The discussion in W3C Privacy CG concluded that we should use distinct
2147         well-known URL paths for websites triggering attribution and for the
2148         browser reporting attribution
2149         (https://github.com/privacycg/private-click-measurement/issues/59).
2150
2151         This patch changes the one location to these two:
2152         /.well-known/private-click-measurement/trigger-attribution
2153         /.well-known/private-click-measurement/report-attribution
2154
2155         * TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp:
2156         (TestWebKitAPI::TEST):
2157         * TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:
2158         (TestWebKitAPI::TEST):
2159
2160 2021-01-25  Razvan Caliman  <rcaliman@apple.com>
2161
2162         Add Razvan Caliman to contributors.json
2163         https://bugs.webkit.org/show_bug.cgi?id=220921
2164
2165         Reviewed by Timothy Hatcher.
2166
2167         * Scripts/webkitpy/common/config/contributors.json:
2168
2169 2021-01-25  Commit Queue  <commit-queue@webkit.org>
2170
2171         Unreviewed, reverting r270074 and r270170.
2172         https://bugs.webkit.org/show_bug.cgi?id=220922
2173
2174         Broke all GLib unit tests using a SoupServer
2175
2176         Reverted changesets:
2177
2178         "[GTK] Migrate WebKitTestServer to libsoup 2.48 API"
2179         https://bugs.webkit.org/show_bug.cgi?id=219160
2180         https://trac.webkit.org/changeset/270074
2181
2182         "[GTK] Allow WebKitTestServer to run non-loopback addresses
2183         for API tests"
2184         https://bugs.webkit.org/show_bug.cgi?id=219257
2185         https://trac.webkit.org/changeset/270170
2186
2187 2021-01-25  Kimmo Kinnunen  <kkinnunen@apple.com>
2188
2189         DumpRenderTree behaves differently to WebKitTestRunner wrt integrated/discrete GPU behavior
2190         https://bugs.webkit.org/show_bug.cgi?id=220852
2191
2192         Reviewed by Alexey Proskuryakov.
2193
2194         Mark DumpRenderTree as supporting graphics switching. This lets
2195         --prefer-integrated-gpu work as intended and compatible with WebKitTestRunner.
2196
2197         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2198         * DumpRenderTree/mac/Info.plist: Added.
2199
2200 2021-01-25  Chris Fleizach  <cfleizach@apple.com>
2201
2202         AX: iOS: VO: Web: Column Names Not Announced
2203         https://bugs.webkit.org/show_bug.cgi?id=220829
2204         <rdar://problem/73469037>
2205
2206         Reviewed by Zalan Bujtas.
2207
2208         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2209         (WTR::AccessibilityUIElement::isInTable const):
2210         (WTR::AccessibilityUIElement::isInLandmark const):
2211         (WTR::AccessibilityUIElement::isInList const):
2212         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2213         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2214         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2215         (WTR::AccessibilityUIElement::isInTable const):
2216         (WTR::AccessibilityUIElement::isInLandmark const):
2217         (WTR::AccessibilityUIElement::isInList const):
2218
2219 2021-01-25  Alicia Boya García  <aboya@igalia.com>
2220
2221         [GTK] run-gtk-tests: Use sys.exit(1) instead of return 1
2222         https://bugs.webkit.org/show_bug.cgi?id=220860
2223
2224         Reviewed by Philippe Normand.
2225
2226         Several parts of the code in api_test_runner.py returned 1 on failure.
2227         While common for main() functions, this is bad in functions that are
2228         expected to return something else than an exit code, and lets the
2229         program run after the error. sys.exit(1) should be used in those cases
2230         instead.
2231
2232         * glib/api_test_runner.py:
2233         (TestRunner._get_tests_from_google_test_suite):
2234         (TestRunner.run_tests):
2235
2236 2021-01-24  Simon Fraser  <simon.fraser@apple.com>
2237
2238         [iOS WK2] theverge.com - rubber band scrolling at the top of the page causes an abrupt jump
2239         https://bugs.webkit.org/show_bug.cgi?id=220886
2240         <rdar://71177566>
2241
2242         Reviewed by Sam Weinig.
2243
2244         Add test infrastructure to allow UIScriptController::scrollToOffset() and
2245         UIScriptController::immediateScrollToOffset() to take an options argument with
2246         a 'unconstrained' property, which allows scrolling to unstable offset to simulate
2247         rubberbanding.
2248
2249         * DumpRenderTree/ios/UIScriptControllerIOS.h:
2250         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2251         (WTR::contentOffsetBoundedIfNecessary):
2252         (WTR::UIScriptControllerIOS::scrollToOffset):
2253         (WTR::UIScriptControllerIOS::immediateScrollToOffset):
2254         (WTR::contentOffsetBoundedInValidRange): Deleted.
2255         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2256         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2257         (WTR::UIScriptController::scrollToOffset):
2258         (WTR::UIScriptController::immediateScrollToOffset):
2259         * TestRunnerShared/UIScriptContext/UIScriptControllerShared.cpp:
2260         (WTR::toScrollToOptions):
2261         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
2262         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2263         (WTR::contentOffsetBoundedIfNecessary):
2264         (WTR::UIScriptControllerIOS::scrollToOffset):
2265         (WTR::UIScriptControllerIOS::immediateScrollToOffset):
2266         (WTR::contentOffsetBoundedInValidRange): Deleted.
2267
2268 2021-01-23  Xan Lopez  <xan@igalia.com>
2269
2270         [JSC] Allow to build WebAssembly without B3
2271         https://bugs.webkit.org/show_bug.cgi?id=220365
2272
2273         Reviewed by Yusuke Suzuki.
2274
2275         * Scripts/webkitperl/FeatureList.pm: add WebAssembly B3 JIT option.
2276
2277 2021-01-22  Alex Christensen  <achristensen@webkit.org>
2278
2279         REGRESSION(r266148) Cancelling a navigation in decidePolicyForNavigationAction should not suspend the previous document's font loading timer
2280         https://bugs.webkit.org/show_bug.cgi?id=220882
2281         <rdar://problem/71634501>
2282
2283         Reviewed by Brady Eidson.
2284
2285         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2286         (TEST):
2287
2288 2021-01-22  Jonathan Bedard  <jbedard@apple.com>
2289
2290         [webkitscmpy] Add GitHub credentials (Follow-up fix)
2291         https://bugs.webkit.org/show_bug.cgi?id=220562
2292         <rdar://problem/73063457>
2293
2294         Reviewed by Aakash Jain.
2295
2296         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Change xmldict version.
2297
2298 2021-01-22  W.D. Xiong  <w_xiong@apple.com>
2299
2300         Update run-benchmark to work with Python3
2301         https://bugs.webkit.org/show_bug.cgi?id=220878
2302
2303         Reviewed by Jonathan Bedard.
2304
2305         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2306         (SimpleHTTPServerDriver._find_http_server_port): Convert byte output to string before parsing regex
2307
2308 2021-01-22  Lauro Moura  <lmoura@igalia.com>
2309
2310         [webkitpy][GTK] Xvfb driver fails to start with python3
2311         https://bugs.webkit.org/show_bug.cgi?id=220870
2312
2313         Reviewed by Jonathan Bedard.
2314
2315         Python2 and Python3 differ in how they handle file descriptor inheritance
2316         and Popen's close_fds default value.
2317
2318         In Python2, os.pipe creates the fds with the inheritable flag set, and
2319         Popen's close_fds defaults to True.
2320
2321         In Python3, os.pipe creates the fds non-inheritable, requiring a call
2322         to os.set_inheritable to enable it. Also, Popen's close_fds defaults
2323         to False, closing all file descriptors except stdin, stdout and stderr.
2324
2325         With this commit, Python3 is able to launch the Xvfb driver for
2326         run-webdriver-tests, but is still failing later with some pytest issue
2327         to be tracked in another bug.
2328
2329         * Scripts/webkitpy/port/xvfbdriver.py:
2330         (XvfbDriver._xvfb_pipe): Make the write_fd inheritable if in py3.
2331         (XvfbDriver._xvfb_read_display_id): Encode for py3 bytes compatibility.
2332         (XvfbDriver._xvfb_run): Tell popen to keep the file descriptors open.
2333
2334 2021-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2335
2336         DisplayList::Replayer should stop replay and inform clients after encountering an invalid item
2337         https://bugs.webkit.org/show_bug.cgi?id=220867
2338
2339         Reviewed by Chris Dumez.
2340
2341         * TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp:
2342
2343         Adjust a few API tests, since the item handle in the `DisplayList` iterator is now optional.
2344
2345         * TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:
2346
2347         Add a couple of new API tests to exercise display list item decoding and validation failures.
2348
2349 2021-01-22  Kimmo Kinnunen  <kkinnunen@apple.com>
2350
2351         Retried tests are run without --prefer-integrated-gpu
2352         https://bugs.webkit.org/show_bug.cgi?id=220845
2353
2354         Reviewed by Jonathan Bedard.
2355
2356         Run the test helper with --prefer-integrated-gpu also for retried tests, if
2357         user originally passed --prefer-integrated-gpu to run-webkit-tests.
2358
2359         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2360         (Manager._set_up_run):
2361         (Manager._force_pixel_tests_if_needed):
2362
2363 2021-01-22  Jonathan Bedard  <jbedard@apple.com>
2364
2365         [webkitscmpy] Map alternative default branch names
2366         https://bugs.webkit.org/show_bug.cgi?id=220865
2367         <rdar://problem/73502370>
2368
2369         Reviewed by Aakash Jain.
2370
2371         As WebKit transitions from Subversion to Git, our default branch is changing from
2372         trunk to main. This change allow identifiers with 'main' in them to work in Subversion checkouts.
2373
2374         * Scripts/libraries/webkitscmpy/setup.py: Bump version.
2375         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
2376         * Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
2377         (Git.find): Map set of common default branches to this repository's default branch.
2378         * Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
2379         (GitHub.find): Map set of common default branches to this repository's default branch.
2380         * Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py:
2381         (ScmBase.find): Map set of common default branches to this repository's default branch.
2382         * Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
2383         (TestGit.test_alternative_default_branch):
2384         (TestGitHub.test_alternative_default_branch):
2385         * Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:
2386         (TestLocalSvn.test_alternative_default_branch):
2387         (TestRemoteSvn.test_alternative_default_branch):
2388
2389 2021-01-22  Lauro Moura  <lmoura@igalia.com>
2390
2391         [WebDriver] Add info about importing tests
2392         https://bugs.webkit.org/show_bug.cgi?id=220786
2393
2394         Reviewed by Carlos Garcia Campos.
2395
2396         * Scripts/import-webdriver-tests: Replace optparse with argparse and
2397         refer to the tests README.md
2398         (Importer.import_tests):
2399
2400 2021-01-21  Aakash Jain  <aakash_jain@apple.com>
2401
2402         [ews] Use github instead of svn.webkit.org to fetch contributors.json
2403         https://bugs.webkit.org/show_bug.cgi?id=220808
2404
2405         Reviewed by Jonathan Bedard.
2406
2407         * CISupport/ews-build/steps.py:
2408         (ValidateCommiterAndReviewer): Changed url to github.
2409         (ValidateCommiterAndReviewer.load_contributors_from_github): Renamed.
2410         (ValidateCommiterAndReviewer.load_contributors):
2411
2412 2021-01-21  Aakash Jain  <aakash_jain@apple.com>
2413
2414         Update setup-commit-queue.sh for github repo
2415         https://bugs.webkit.org/show_bug.cgi?id=220750
2416
2417         Reviewed by Jonathan Bedard.
2418
2419         * EWSTools/setup-commit-queue.sh:
2420
2421 2021-01-21  Aditya Keerthi  <akeerthi@apple.com>
2422
2423         Unreviewed, reverting r271691.
2424         https://bugs.webkit.org/show_bug.cgi?id=220812
2425
2426         Introduced crash, and failing API tests.
2427
2428         Reverted changeset:
2429
2430         "[macOS] Titlebar separator doesn't show when WKWebView is scrolled"
2431         https://bugs.webkit.org/show_bug.cgi?id=220633
2432         https://trac.webkit.org/changeset/271691
2433
2434 2021-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2435
2436         Remove ENABLE_USERSELECT_ALL macro which is enabled for all ports
2437         https://bugs.webkit.org/show_bug.cgi?id=100424
2438
2439         Reviewed by Don Olmstead.
2440
2441         * Scripts/webkitperl/FeatureList.pm:
2442
2443 2021-01-21  Jonathan Bedard  <jbedard@apple.com>
2444
2445         [webkitscmpy] Handle machines that cannot import keyring
2446         https://bugs.webkit.org/show_bug.cgi?id=220800
2447         <rdar://problem/73454666>
2448
2449         Reviewed by Aakash Jain.
2450
2451         * Scripts/libraries/webkitscmpy/setup.py: Bump version.
2452         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
2453         * Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
2454         (GitHub.credentials): Make keyring optional.
2455
2456 2021-01-21  Sam Weinig  <weinig@apple.com>
2457
2458         Rework color clamping logic to be more consistent and clear
2459         https://bugs.webkit.org/show_bug.cgi?id=220716
2460
2461         Reviewed by Simon Fraser.
2462
2463         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
2464         (TestWebKitAPI::TEST):
2465         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
2466         (TestWebKitAPI::TEST):
2467         Update tests to use new convertTo<> functions.
2468
2469 2021-01-21  Michael Catanzaro  <mcatanzaro@gnome.org>
2470
2471         autoinstall python-secretstorage
2472         https://bugs.webkit.org/show_bug.cgi?id=220796
2473
2474         Reviewed by Jonathan Bedard.
2475
2476         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:
2477         * gtk/install-dependencies:
2478         * wpe/install-dependencies:
2479
2480 2021-01-21  Angelos Oikonomopoulos  <angelos@igalia.com>
2481
2482         [webkitcorepy] Don't import six at the top level
2483         https://bugs.webkit.org/show_bug.cgi?id=220795
2484
2485         Reviewed by Aakash Jain.
2486
2487         Instead, do the import after the module has been loaded, when
2488         AutoInstall has been set up properly. Fixes a regression after
2489         1d342a5067e22ac8069ff3ff337b2d58e1d06517, where task_pool.py uses
2490         the six module without it being installed.
2491
2492         * Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:
2493         (ChildException.__call__):
2494         (TaskPool.__exit__):
2495
2496 2021-01-21  Aditya Keerthi  <akeerthi@apple.com>
2497
2498         [macOS] Titlebar separator doesn't show when WKWebView is scrolled
2499         https://bugs.webkit.org/show_bug.cgi?id=220633
2500         <rdar://problem/71094055>
2501
2502         Reviewed by Tim Horton.
2503
2504         Added API tests to verify that the delegate implementation returns the
2505         correct value for `hasScrolledContentsUnderTitlebar` depending on
2506         the view's scroll position, visibility, and frame.
2507
2508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2509         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
2510         * TestWebKitAPI/Tests/mac/WKWebViewTitlebarSeparatorTests.mm: Added.
2511         (-[TitlebarSeparatorTestWKWebView initWithFrame:configuration:]):
2512         (-[TitlebarSeparatorTestWKWebView separatorTrackingAdapter]):
2513         (BackForwardCache):
2514         (ChangeTitlebarAdjacency):
2515         (ChangeViewVisibility):
2516         (NavigationResetsTitlebarAppearance):
2517         (ScrollWithTitlebarAdjacency):
2518         (ScrollWithoutTitlebarAdjacency):
2519
2520 2021-01-20  Jonathan Bedard  <jbedard@apple.com>
2521
2522         [webkitscmpy] Gracefully handle missing keyring backend
2523         https://bugs.webkit.org/show_bug.cgi?id=220784
2524
2525         Reviewed by Yusuke Suzuki.
2526
2527         * Scripts/libraries/webkitscmpy/setup.py: Bump version.
2528         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
2529         * Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
2530         (GitHub.credentials): Handle RuntimeErrors from keyring.
2531
2532 2021-01-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2533
2534         [macOS] Include an origin identifier when writing promised image data to the drag pasteboard
2535         https://bugs.webkit.org/show_bug.cgi?id=220782
2536
2537         Reviewed by Megan Gardner.
2538
2539         Make a slight adjustment to an existing API test, to verify that custom pasteboard data is serialized when
2540         dragging an image element.
2541
2542         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
2543
2544 2021-01-20  Jonathan Bedard  <jbedard@apple.com>
2545
2546         [webkitcorepy] Add TaskPool
2547         https://bugs.webkit.org/show_bug.cgi?id=220547
2548         <rdar://problem/73043887>
2549
2550         Reviewed by Dewei Zhu.
2551
2552         The TaskPool object is a Python 3.8 compatible multiprocessing tool. Notable features are forwarding stdout,
2553         stderr and logging to the parent process, exception propagation between processes, and graceful clean-up when
2554         exceptions in the parent process are encountered
2555
2556         * Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version, add tblib.
2557         * Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py: Added.
2558         (Message): Base class for message passed between processes.
2559         (Task): Message including function and arguments to that function.
2560         (Result): Return value of a task passed to the parent process.
2561         (Log): Pass log message from child process to parent process.
2562         (Print): Pass stdout or stderr line from child process to parent process.
2563         (State): Notify parent process that the child process has changed state.
2564         (ChildException): Pass exception and stack trace from
2565         (BiDirectionalQueue): Pair for multiprocess queues allowing for messages to be passed between processes.
2566         (Process): Scoping class managing child-process logic.
2567         (Process.LogHandler): Logging handler that passes log lines from the child process to it's parent.
2568         (Process.Stream): Writable stream which passes content from the child process to the standard out or error
2569         of that process's parent.
2570         (Process.handler): SIGTERM should prevent future processing but allow currently in-flight tasks to complete.
2571         (Process.main): Entry-point to child process.
2572         (TaskPool): Managing allocation of tasks to child processes and clean up those child processes.
2573         (TaskPool.Exception): Exception owned by TaskPool object.
2574         (TaskPool.__init__):
2575         (TaskPool.__enter__):
2576         (TaskPool.do): Pass task to child processes.
2577         (TaskPool.wait): Wait until all processes are completed.
2578         (TaskPool.__exit__): Teardown all child processes.
2579         * Scripts/libraries/webkitcorepy/webkitcorepy/tests/task_pool_unittest.py: Added.
2580         (setup):
2581         (teardown):
2582         (action):
2583         (log):
2584         (wait):
2585         (exception):
2586         (TaskPoolUnittest):
2587         (TaskPoolUnittest.test_single):
2588         (TaskPoolUnittest.test_multiple):
2589         (TaskPoolUnittest.test_callback):
2590         (TaskPoolUnittest.test_exception):
2591         (TaskPoolUnittest.test_setup):
2592         (TaskPoolUnittest.test_teardown):
2593         (TaskPoolUnittest.test_invalid_shutdown):
2594
2595 2021-01-20  Aakash Jain  <aakash_jain@apple.com>
2596
2597         EWS should display commit identifier in builds
2598         https://bugs.webkit.org/show_bug.cgi?id=220769
2599
2600         Reviewed by Jonathan Bedard.
2601
2602         * CISupport/ews-build/factories.py:
2603         (Factory.__init__): Added ShowIdentifier build step.
2604         (StyleFactory.__init__):
2605         (WatchListFactory.__init__):
2606         (CommitQueueFactory.__init__):
2607         * CISupport/ews-build/steps.py:
2608         (ShowIdentifier): build-step to show commit identifier.
2609         (ShowIdentifier.start):
2610         (ShowIdentifier.evaluateCommand):
2611         (ShowIdentifier.getLastBuildStepByName):
2612         (ShowIdentifier.url_for_identifier):
2613         (ShowIdentifier.getResultSummary): Display custom failure message.
2614         (ShowIdentifier.hideStepIf): Hide this step if successful.
2615         * CISupport/ews-build/steps_unittest.py: Added unit-tests.
2616         * CISupport/ews-build/factories_unittest.py:
2617
2618 2021-01-20  Youenn Fablet  <youenn@apple.com>
2619
2620         Two pages in the same process should not be able to play media stream backed video elements at the same time
2621         https://bugs.webkit.org/show_bug.cgi?id=220504
2622
2623         Reviewed by Eric Carlson.
2624
2625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2626         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
2627         (TestWebKitAPI::TEST):
2628         * TestWebKitAPI/Tests/WebKit/getUserMedia2.html: Added.
2629
2630 2021-01-20  Kate Cheney  <katherine_cheney@apple.com>
2631
2632         Safari says "Blocked Plug-in" instead showing a PDF
2633         https://bugs.webkit.org/show_bug.cgi?id=220665
2634         <rdar://problem/64372944>
2635
2636         Reviewed by Darin Adler.
2637
2638         API test coverage.
2639
2640         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
2641         (TEST):
2642
2643 2021-01-20  Jonathan Bedard  <jbedard@apple.com>
2644
2645         [webkitcorepy] Support alternative default pypi url on macOS (Follow-up fix)
2646         https://bugs.webkit.org/show_bug.cgi?id=220744
2647         <rdar://problem/73369338>
2648
2649         Unreviewed follow-up fix.
2650
2651         * Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
2652         (_default_pypi_index): Ensure that "simple" is excluded from the pypi url.
2653
2654 2021-01-20  Youenn Fablet  <youenn@apple.com>
2655
2656         A DOMWindow should not be reused if its JSDOMWindow has been created
2657         https://bugs.webkit.org/show_bug.cgi?id=220658
2658         <rdar://problem/70335075>
2659
2660         Reviewed by Geoffrey Garen.
2661
2662         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2663
2664 2021-01-20  Youenn Fablet  <youenn@apple.com>
2665
2666         On page close, make sure to notify of capture state immediately
2667         https://bugs.webkit.org/show_bug.cgi?id=220588
2668
2669         Reviewed by Geoffrey Garen.
2670
2671         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
2672         (TestWebKitAPI::TEST):
2673
2674 2021-01-19  Sihui Liu  <sihui_liu@appe.com>
2675
2676         Update media state for active speech recognition as it uses audio capture
2677         https://bugs.webkit.org/show_bug.cgi?id=220667
2678
2679         Reviewed by Youenn Fablet.
2680
2681         * TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:
2682         (-[SpeechRecognitionUIDelegate _webView:mediaCaptureStateDidChange:]):
2683         (TestWebKitAPI::TEST):
2684         (-[SpeechRecognitionPermissionUIDelegate _webView:requestSpeechRecognitionPermissionForOrigin:decisionHandler:]): Deleted.
2685         (-[SpeechRecognitionPermissionUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]): Deleted.
2686         (-[SpeechRecognitionPermissionUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]): Deleted.
2687         (-[SpeechRecognitionPermissionUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): Deleted.
2688
2689 2021-01-19  Michael Catanzaro  <mcatanzaro@gnome.org>
2690
2691         REGRESSION(r271506): webkit-patch keyring integration is broken on Linux
2692         https://bugs.webkit.org/show_bug.cgi?id=220736
2693
2694         Reviewed by Jonathan Bedard.
2695
2696         r271506 updated python-keyring to the last version to support python2, but unfortunately
2697         this version seems to be somehow incompatible with python-secretstorage, which is required
2698         for system keyring support on Linux. This bug is fixed in newer versions of python-keyring
2699         that do not support python2, but we still support python2, so we cannot upgrade. I've tested
2700         several versions of python-keyring and found that version 11.1.0 is the most recent version
2701         that supports python2 and works properly on Linux, so let's stick with that until we are
2702         ready to give up on python2.
2703
2704         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:
2705
2706 2021-01-19  Jonathan Bedard  <jbedard@apple.com>
2707
2708         [webkitcorepy] Support alternative default pypi url on macOS
2709         https://bugs.webkit.org/show_bug.cgi?id=220744
2710         <rdar://problem/73369338>
2711
2712         Reviewed by Aakash Jain.
2713
2714         * Scripts/libraries/webkitcorepy/setup.py: Bump version.
2715         * Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
2716         * Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
2717         (_default_pypi_index): Pull default pypi index from pip.conf, if available.
2718         (AutoInstall): Set index based on result of _default_pypi_index.
2719
2720 2021-01-19  Jonathan Bedard  <jbedard@apple.com>
2721
2722         [commit-queue] Cache credentials for https instead of http
2723         https://bugs.webkit.org/show_bug.cgi?id=220746
2724         <rdar://problem/73369984>
2725
2726         Reviewed by Aakash Jain.
2727
2728         * EWSTools/configure-svn-auth.sh:
2729
2730 2021-01-19  Commit Queue  <commit-queue@webkit.org>
2731
2732         Unreviewed, reverting r271606.
2733         https://bugs.webkit.org/show_bug.cgi?id=220747
2734
2735         Didn't work properly
2736
2737         Reverted changeset:
2738
2739         "[update-webkit] Do not automatically use git svn rebase"
2740         https://bugs.webkit.org/show_bug.cgi?id=220739
2741         https://trac.webkit.org/changeset/271606
2742
2743 2021-01-19  Jonathan Bedard  <jbedard@apple.com>
2744
2745         [update-webkit] Do not automatically use git svn rebase
2746         https://bugs.webkit.org/show_bug.cgi?id=220739
2747         <rdar://problem/73365632>
2748
2749         Rubber-stamped by Aakash Jain.
2750
2751         git svn rebase is an expensive operation, it is also usually the wrong operation
2752         when your git checkout is already being automatically populated from Subversion
2753
2754         * Scripts/webkitdirs.pm:
2755         (runGitUpdate): Replace `git svn rebase` with `git svn fetch`.
2756
2757 2021-01-19  Jonathan Bedard  <jbedard@apple.com>
2758
2759         [webkitpy] Support generating patch with main as the default branch
2760         https://bugs.webkit.org/show_bug.cgi?id=220737
2761         <rdar://problem/73362104>
2762
2763         Reviewed by Dewei Zhu.
2764
2765         * Scripts/webkitpy/common/checkout/scm/git.py:
2766         (Git.remote_branch_ref): Support 
2767
2768 2021-01-19  Jonathan Bedard  <jbedard@apple.com>
2769
2770         [GitHub] Use github.com as the source of truth for EWS
2771         https://bugs.webkit.org/show_bug.cgi?id=220479
2772         <rdar://problem/72941463>
2773
2774         Reviewed by Aakash Jain.
2775
2776         * CISupport/ews-build/steps.py:
2777         (CheckOutSource.__init__): Use GitHub.com instead of git.webkit.org.
2778
2779 2021-01-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2780
2781         [Win][DumpRenderTree] ASSERT(!m_channel) failed in WebSocket::contextDestroyed
2782         https://bugs.webkit.org/show_bug.cgi?id=220450
2783
2784         Reviewed by Per Arne Vollan.
2785
2786         WebSocket::failAsynchronously() posts a deferred task calling
2787         WebSocket::stop() by using callOnMainThread, but the task was not
2788         executed soon because DumpRenderTree stopped running the run loop
2789         after finishing the test.
2790
2791         DumpRenderTree's run loop should dispatch all deferred tasks
2792         before finishing the current test. Deffer setting the variable
2793         'done' by posting a application message.
2794
2795         * DumpRenderTree/win/DumpRenderTree.cpp: Define a application message WM_DRT_TEST_DONE.
2796         (DumpRenderTreeWndProc): Set 'done' in the case of WM_DRT_TEST_DONE.
2797         (dump): Post WM_DRT_TEST_DONE.
2798
2799 2021-01-18  Lauro Moura  <lmoura@igalia.com>
2800
2801         [WPE] Fix WPEQt tests after r271514
2802         https://bugs.webkit.org/show_bug.cgi?id=220681
2803
2804         Reviewed by Carlos Garcia Campos.
2805
2806         Setting the title became async, so we must wait for it to be
2807         processed.
2808
2809         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp:
2810         (TestLoad::main):
2811         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp:
2812         (TestLoadHtml::main):
2813         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp:
2814         (TestLoadRequest::main):
2815         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp:
2816         (TestRunJavaScript::main):
2817
2818 2021-01-17  Jonathan Bedard  <jbedard@apple.com>
2819
2820         [webkitscmpy] Add GitHub credentials (Follow-up fix)
2821         https://bugs.webkit.org/show_bug.cgi?id=220562
2822         <rdar://problem/73063457>
2823
2824         Unreviewed follow-up fix.
2825
2826         * Scripts/webkitpy/__init__.py: Ensure that webkitscmpy's dependencies are auto installed.
2827
2828 2021-01-15  Alexey Proskuryakov  <ap@apple.com>
2829
2830         Build fixes with newer clang
2831         https://bugs.webkit.org/show_bug.cgi?id=220679
2832
2833         Reviewed by Mark Lam.
2834
2835         * DumpRenderTree/mac/LayoutTestHelper.m:
2836         (lockDownDiscreteGraphics):
2837         (addSleepAssertions):
2838         Added "static" to functions without prototypes.
2839
2840 2021-01-15  Jonathan Bedard  <jbedard@apple.com>
2841
2842         [webkitscmpy] Cache credentials from keychain
2843         https://bugs.webkit.org/show_bug.cgi?id=220671
2844         <rdar://problem/73262349>
2845
2846         Reviewed by Dewei Zhu.
2847
2848         * Scripts/libraries/webkitscmpy/setup.py: Bump version.
2849         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
2850         * Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
2851         (GitHub.credentials): Cache credentials from keychain even when not specified by the user.
2852
2853 2021-01-15  Jonathan Bedard  <jbedard@apple.com>
2854
2855         [webkitscmpy] Make UI parsing for parent commits more flexible
2856         https://bugs.webkit.org/show_bug.cgi?id=220661
2857         <rdar://problem/73256932>
2858
2859         Reviewed by Dewei Zhu.
2860
2861         * Scripts/libraries/webkitscmpy/setup.py: Bump version.
2862         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
2863         * Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
2864         (GitHub.__init__): Handle commit links in the UI using both 'commits/' URLs and 'tree-commit/'.
2865
2866 2021-01-15  Philippe Normand  <pnormand@igalia.com>
2867
2868         [GStreamer] Clean-up the TextSink
2869         https://bugs.webkit.org/show_bug.cgi?id=220651
2870
2871         Reviewed by Xabier Rodriguez-Calvar.
2872
2873         * Scripts/webkitpy/style/checker.py: Add GStreamer TextSink implementation to GObject
2874         classes allow-list.
2875
2876 2021-01-15  Rob Buis  <rbuis@igalia.com>
2877
2878         Use event loop to set title
2879         https://bugs.webkit.org/show_bug.cgi?id=218496
2880
2881         Reviewed by Ryosuke Niwa.
2882
2883         Adapt unit tests to wait for title change tasks
2884         to be processed.
2885
2886         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
2887         (TestWebKitAPI::didChangeTitle):
2888         (TestWebKitAPI::TEST):
2889         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2890         (TEST):
2891
2892 2021-01-15  Philippe Normand  <pnormand@igalia.com>
2893
2894         [GStreamer] Clean-up the TextCombiner
2895         https://bugs.webkit.org/show_bug.cgi?id=220463
2896
2897         Reviewed by Xabier Rodriguez-Calvar.
2898
2899         * Scripts/webkitpy/style/checker.py: Add GStreamer TextCombiner implementation to GObject
2900         classes allow-list.
2901
2902 2021-01-14  Aditya Keerthi  <akeerthi@apple.com>
2903
2904         [Cocoa] Strip DataDetectors links when copying content to the pasteboard
2905         https://bugs.webkit.org/show_bug.cgi?id=220526
2906         <rdar://problem/71045590>
2907
2908         Reviewed by Ryosuke Niwa.
2909
2910         Added API tests to verify DataDetectors links are not preserved when
2911         copying/pasting WebArchives and rich text.
2912
2913         * TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm:
2914         (StripsDataDetectorsLinks):
2915         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
2916         (StripsDataDetectorsLinks):
2917
2918 2021-01-14  Jonathan Bedard  <jbedard@apple.com>
2919
2920         [webkitscmpy] Add GitHub credentials
2921         https://bugs.webkit.org/show_bug.cgi?id=220562
2922         <rdar://problem/73063457>
2923
2924         Reviewed by Dewei Zhu.
2925
2926         * Scripts/libraries/webkitscmpy/setup.py: Bump version.
2927         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version, add keyring.
2928         * Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:
2929         (GitHub):
2930         (GitHub.__enter__): Set username and token in environment.
2931         (GitHub.__exit__): Unset username and token in environment.
2932         * Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
2933         (GitHub.__init__):
2934         (GitHub.credentials): Search for credentials in both environment and keyring before
2935         prompting user.
2936         (GitHub.request): Use GitHub credentials, if they are available.
2937         * Scripts/webkitpy/__init__.py: Move keyring to webkitscmpy.
2938         * Scripts/webkitpy/common/net/credentials.py: New version of keyring prints output when
2939         Imported, suppress this output.
2940
2941 2021-01-14  Alex Christensen  <achristensen@webkit.org>
2942
2943         Add dotless j and small N to unicode lookalike character list
2944         https://bugs.webkit.org/show_bug.cgi?id=220632
2945         <rdar://problem/72101901>
2946
2947         Reviewed by David Kilzer.
2948
2949         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2950         (TestWebKitAPI::TEST):
2951
2952 2021-01-14  Aakash Jain  <aakash_jain@apple.com>
2953
2954         EWS should correctly identify the OS for Big Sur dot releases
2955         https://bugs.webkit.org/show_bug.cgi?id=220622
2956
2957         Reviewed by Jonathan Bedard.
2958
2959         * CISupport/ews-build/steps.py:
2960         (PrintConfiguration.convert_build_to_os_name): Change 11.0 to 11 since we use startswith() for matching.
2961
2962 2021-01-13  Tim Horton  <timothy_horton@apple.com>
2963
2964         REGRESSION (r266634): Messages crashes sometimes while scrolling around and playing YouTube videos
2965         https://bugs.webkit.org/show_bug.cgi?id=220602
2966         <rdar://problem/70402593>
2967
2968         Reviewed by Wenson Hsieh.
2969
2970         * TestWebKitAPI/PlatformWebView.h:
2971         Mark PlatformWebView noncopyable, since it is effectively noncopyable
2972         (at least, the macOS implementation will overrelease the view if you
2973         copy it, whoops).
2974
2975         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2976         (TestWebKitAPI::TEST):
2977         Add a matching dispatch_async, or this test fails.
2978
2979 2021-01-13  Alex Christensen  <achristensen@webkit.org>
2980
2981         Remove deprecated script and stylesheet SPI, replaced with more inclusively-named SPI
2982         https://bugs.webkit.org/show_bug.cgi?id=214937
2983
2984         Fix iOS build after r271457.
2985
2986         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
2987         (TEST):
2988
2989 2021-01-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2990
2991         [macOS] "Correct Spelling Automatically" menu items are inconsistent when autocorrect="off"
2992         https://bugs.webkit.org/show_bug.cgi?id=220598
2993         <rdar://problem/71713611>
2994
2995         Reviewed by Tim Horton.
2996
2997         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2998         * TestWebKitAPI/Tests/mac/DisableAutomaticSpellingCorrection.mm: Added.
2999
3000         Add a new API test to verify that the `NSMenuItem` for toggling automatic spelling correction is invalid when
3001         editing inside a form control with autocorrect="off".
3002
3003         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3004         (WTR::getMenuItemEnabledCallback):
3005
3006         Add the readonly `enabled` JS property on context menu items. See the new layout test,
3007         editing/mac/spelling/disable-automatic-spelling-correction-context-menu-item.html, for more information.
3008
3009 2021-01-13  Jonathan Bedard  <jbedard@apple.com>
3010
3011         [webkitscmpy] Handle single commit touching multiple branches
3012         https://bugs.webkit.org/show_bug.cgi?id=220601
3013         <rdar://problem/73165609>
3014
3015         Reviewed by Stephanie Lewis.
3016
3017         In WebKit's history, there are a few cases of commits that touch multiple branches (like
3018         https://trac.webkit.org/changeset/92419/webkit). These types of commits are not correct,
3019         but we need to handle them if they are in the history of a branch.
3020
3021         * Scripts/libraries/webkitscmpy/setup.py: Bump version.
3022         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
3023         * Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
3024         (Svn._cache_revisions): Branches only intersect trunk when two sequential commits are from trunk.
3025         (Svn.commit): Support case where no commit time can be found.
3026         * Scripts/libraries/webkitscmpy/webkitscmpy/remote/svn.py:
3027         (Svn._cache_revisions): Branches only intersect trunk when two sequential commits are from trunk.
3028         (Svn.commit): Support case where no commit time can be found.
3029
3030 2021-01-13  Aakash Jain  <aakash_jain@apple.com>
3031
3032         [build.webkit.org] Use PostgreSQL for new build.webkit.org database
3033         https://bugs.webkit.org/show_bug.cgi?id=220589
3034
3035         Reviewed by Jonathan Bedard.
3036
3037         * CISupport/build-webkit-org/master_buildbot2.cfg:
3038
3039 2021-01-13  Sam Sneddon  <gsnedders@apple.com>
3040
3041         Avoid over-aggressive clearing of *.pyc files running webkitpy tests
3042         https://bugs.webkit.org/show_bug.cgi?id=220594
3043
3044         Reviewed by Darin Adler.
3045
3046         * Scripts/webkitpy/test/finder.py:
3047         (source_from_cache): Added fallback for PY2
3048         (_DirectoryTree.clean): Change to use imported/fallback source_from_cache
3049
3050 2021-01-13  Diego Pino Garcia  <dpino@igalia.com>
3051
3052         [buildbot] WebKitGTK(GTK4) isn't triggered after a binary build
3053         https://bugs.webkit.org/show_bug.cgi?id=220586
3054
3055         Reviewed by Aakash Jain.
3056
3057         r269945 added a new WebKitGTK (GTK4) post-commit bot that runs several test suites
3058         (layout-test, api-tests and webdriver-tests). The bot was expected to run after
3059         every binary build, however that wasn't happening because the bot wasn't set as
3060         triggerable.
3061
3062         * CISupport/build-webkit-org/config.json:
3063
3064 2021-01-12  Angelos Oikonomopoulos  <angelos@igalia.com>
3065
3066         Implement serial tests for the ruby test writer
3067         https://bugs.webkit.org/show_bug.cgi?id=220360
3068
3069         Reviewed by Yusuke Suzuki.
3070
3071         This is a verbatim copy of the implementation in the default writer.
3072
3073         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
3074
3075 2021-01-12  Tetsuharu Ohzeki  <tetsuharu.ohzeki@gmail.com>
3076
3077         Invoke ccache properly on macOS aarch64
3078         https://bugs.webkit.org/show_bug.cgi?id=220497
3079
3080         Reviewed by Darin Adler.
3081
3082         For macOS aarch64, the current homebrew recommends to install homebrew to `/opt/homebrew`.
3083         https://docs.brew.sh/Installation
3084
3085         This patch adds it to the list which `ccache-wrapper` searches.
3086
3087         * ccache/ccache-wrapper:
3088
3089 2021-01-12  BJ Burg  <bburg@apple.com>
3090
3091         [Cocoa] Web Inspector: move browser domain activation methods back to WKWebView and UIDelegate
3092         https://bugs.webkit.org/show_bug.cgi?id=220480
3093
3094         Reviewed by Devin Rousso.
3095
3096         * TestWebKitAPI/Tests/WebKitCocoa/WKInspectorDelegate.mm:
3097         (-[UIDelegate _webViewDidEnableInspectorBrowserDomain:]):
3098         (-[UIDelegate _webViewDidDisableInspectorBrowserDomain:]):
3099         (-[InspectorDelegate inspectorDidEnableBrowserDomain:]): Deleted.
3100         (-[InspectorDelegate inspectorDidDisableBrowserDomain:]): Deleted.
3101         Adapt to new location for delegate methods.
3102
3103 2021-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3104
3105         REGRESSION (r265044): [macOS] Safari autocorrects text when typing in login field on amazon.com
3106         https://bugs.webkit.org/show_bug.cgi?id=220556
3107         <rdar://problem/71602937>
3108
3109         Reviewed by Darin Adler.
3110
3111         Add an API test that uses WebKit C API (`WKBundleNodeHandleSetHTMLInputElementSpellcheckEnabled`) to disable or
3112         enable spellchecking on input elements.
3113
3114         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3115         * TestWebKitAPI/Tests/WebKitCocoa/DisableSpellcheck.mm: Added.
3116         * TestWebKitAPI/Tests/WebKitCocoa/DisableSpellcheckPlugIn.mm: Added.
3117         (-[DisableSpellcheckPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3118         (-[DisableSpellcheckPlugIn webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3119         (-[DisableSpellcheckPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
3120
3121 2021-01-12  Aakash Jain  <aakash_jain@apple.com>
3122
3123         [build.webkit.org] Update force schedulers as per new buildbot
3124         https://bugs.webkit.org/show_bug.cgi?id=220544
3125
3126         Reviewed by Jonathan Bedard.
3127
3128         * CISupport/build-webkit-org/loadConfig.py:
3129         (loadBuilderConfig):
3130
3131 2021-01-11  Lauro Moura  <lmoura@igalia.com>
3132
3133         [WPE] Gardening API test crash
3134
3135         Unreviewed test gardening.
3136
3137         * TestWebKitAPI/glib/TestExpectations.json:
3138
3139 2021-01-11  Sihui Liu  <sihui_liu@appe.com>
3140
3141         Make SpeechRecognition permission error more informative
3142         https://bugs.webkit.org/show_bug.cgi?id=220436
3143
3144         Reviewed by Youenn Fablet.
3145
3146         * TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:
3147         (TestWebKitAPI::TEST):
3148
3149 2021-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3150
3151         ASSERTION FAILED: !event || event.type == NSEventTypeLeftMouseDown || event.type == NSEventTypeRightMouseDown || event.type == NSEventTypeOtherMouseDown
3152         https://bugs.webkit.org/show_bug.cgi?id=220520
3153         <rdar://problem/73007898>
3154
3155         Reviewed by Tim Horton.
3156
3157         Fix the assertion by synthesizing a "mouse down" event instead of "mouse entered".
3158
3159         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
3160         (TestWebKitAPI::TEST):
3161
3162 2021-01-11  BJ Burg  <bburg@apple.com>
3163
3164         Unreviewed, update my contributor information.
3165
3166         * Scripts/webkitpy/common/config/contributors.json:
3167
3168 2021-01-11  Youenn Fablet  <youenn@apple.com>
3169
3170         WebProcessPool::establishWorkerContextConnectionToNetworkProcess should make sure to remove the selected process from the cache
3171         https://bugs.webkit.org/show_bug.cgi?id=220503
3172
3173         Reviewed by Darin Adler.
3174
3175         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3176
3177 2021-01-11  Aakash Jain  <aakash_jain@apple.com>
3178
3179         [build.webkit.org] Stop using deprecated addFactoryArguments method
3180         https://bugs.webkit.org/show_bug.cgi?id=220513
3181
3182         Reviewed by Jonathan Bedard.
3183
3184         * CISupport/build-webkit-org/steps.py:
3185
3186 2021-01-11  Aakash Jain  <aakash_jain@apple.com>
3187
3188         [ews] Add python 3 support - part 1
3189         https://bugs.webkit.org/show_bug.cgi?id=220510
3190
3191         Reviewed by Jonathan Bedard.
3192
3193         * CISupport/ews-build/email_unittest.py:
3194         * CISupport/ews-build/loadConfig.py:
3195         * CISupport/ews-build/loadConfig_unittest.py:
3196
3197 2021-01-11  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
3198
3199         [PlayStation] Add MiniBrowser
3200         https://bugs.webkit.org/show_bug.cgi?id=220359
3201
3202         Reviewed by Don Olmstead.
3203
3204         Add PlayStation MiniBrowser sources and CMakeLists.txt.
3205
3206         * MiniBrowser/playstation/CMakeLists.txt: Added.
3207         * MiniBrowser/playstation/ImageButton.cpp: Added.
3208         * MiniBrowser/playstation/ImageButton.h: Added.
3209         * MiniBrowser/playstation/MainWindow.cpp: Added.
3210         * MiniBrowser/playstation/MainWindow.h: Added.
3211         * MiniBrowser/playstation/StringUtils.h: Added.
3212         * MiniBrowser/playstation/TitleBar.cpp: Added.
3213         * MiniBrowser/playstation/TitleBar.h: Added.
3214         * MiniBrowser/playstation/ToolkittenUtils.h: Added.
3215         * MiniBrowser/playstation/URLBar.cpp: Added.
3216         * MiniBrowser/playstation/URLBar.h: Added.
3217         * MiniBrowser/playstation/WebContext.cpp: Added.
3218         * MiniBrowser/playstation/WebContext.h: Added.
3219         * MiniBrowser/playstation/WebViewWindow.cpp: Added.
3220         * MiniBrowser/playstation/WebViewWindow.h: Added.
3221         * MiniBrowser/playstation/main.cpp: Added.
3222         (loadLibraryOrExit):
3223         (initialize):
3224         (ApplicationClient::updateApplication):
3225         (main):
3226         * PlatformPlayStation.cmake: Added.
3227
3228 2021-01-09  Lauro Moura  <lmoura@igalia.com>
3229
3230         [GStreamer] Build failure with gst-build: Missing gst/audio/audio.h
3231         https://bugs.webkit.org/show_bug.cgi?id=220494
3232
3233         Reviewed by Philippe Normand.
3234
3235         Make the tests include the audio headers for gst/audio/audio. It is
3236         included in TestUIClient through WebPreferences -> IPC::Decoder ->
3237         SharedBuffer -> GStreamerCommon.
3238
3239         * TestWebKitAPI/glib/CMakeLists.txt:
3240
3241 2021-01-08  Jonathan Bedard  <jbedard@apple.com>
3242
3243         [webkitscmpy] Provide command to automatically configure git-svn
3244         https://bugs.webkit.org/show_bug.cgi?id=220442
3245         <rdar://problem/72908233>
3246
3247         Reviewed by Yusuke Suzuki.
3248
3249         Add commands to update repository and connect a git repository to a subversion repository.
3250
3251         * Scripts/git-webkit: Define subversion URL.
3252         * Scripts/libraries/webkitscmpy/setup.py: Bump version.
3253         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
3254         * Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
3255         (Git.pull): Add function to update repository with the remote.
3256         * Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:
3257         (Scm.pull): Add function to update repository with the remote.
3258         * Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
3259         (Svn.__init__): Suppress exception when metadata cache is invalid.
3260         (Svn.pull): Add function to update repository with the remote.
3261         * Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
3262         (Git): Use tabs in git config, add 'git svn fetch' and 'git pull' commands.
3263         * Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/svn.py:
3264         (Svn.__init__): Add 'svn up' command.
3265         * Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py:
3266         (main): Add Pull and SetupGitSvn commands.
3267         * Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:
3268         (Command.parser): Support use of the default parser.
3269         * Scripts/libraries/webkitscmpy/webkitscmpy/program/pull.py: Added.
3270         (Pull): Update the current repository from its remote.
3271         * Scripts/libraries/webkitscmpy/webkitscmpy/program/setup_git_svn.py: Added.
3272         (SetupGitSvn): Add command which populates the .git config file with information
3273         linking to a subversion repository.
3274         * Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_git_svn_unittest.py: Added.
3275         (TestSetupGitSvn):
3276         (TestSetupGitSvn.test_svn):
3277         (TestSetupGitSvn.test_empty):
3278         (TestSetupGitSvn.test_add):
3279
3280 2021-01-08  Jer Noble  <jer.noble@apple.com>
3281
3282         Unreviewed test gardening. Attempting to diagnose failing PiP API tests by enabling more logging 
3283         during the test run, to be collected after a failed test.
3284
3285         * DumpRenderTree/DumpRenderTree.xcodeproj/xcshareddata/xcschemes/DumpRenderTree.xcscheme:
3286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
3287         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
3288         (TestWebKitAPI::TEST):
3289         * TestWebKitAPI/Tests/WebKitCocoa/ExitPiPOnSuspendVideoElement.mm:
3290         (TestWebKitAPI::TEST):
3291         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
3292         (TEST):
3293
3294 2021-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3295
3296         [macOS] -[WKWebView acceptsFirstMouse:] sometimes crashes in IPC::Connection::createSyncMessageEncoder
3297         https://bugs.webkit.org/show_bug.cgi?id=220469
3298         <rdar://problem/72319199>
3299
3300         Reviewed by Chris Dumez.
3301
3302         Add an API test that exercises the crash by calling into `-acceptsFirstMouse:` during web process launch.
3303
3304         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
3305         (TestWebKitAPI::TEST):
3306
3307 2021-01-08  Sihui Liu  <sihui_liu@appe.com>
3308
3309         Stop using MediaRecorder in API test WebKit2.SpeechRecognitionErrorWhenStartingAudioCaptureOnDifferentPage
3310         https://bugs.webkit.org/show_bug.cgi?id=220347
3311
3312         Reviewed by Youenn Fablet.
3313
3314         Because MediaRecorder (with real backend) is only supported in some recent MacOS versions now.
3315
3316         * TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:
3317         (TestWebKitAPI::TEST):
3318         * TestWebKitAPI/Tests/WebKitCocoa/speechrecognition-basic.html:
3319
3320 2021-01-08  Jonathan Bedard  <jbedard@apple.com>
3321
3322         [webkitcorepy] Add standard mechanism for packaging pip packages (work-around)
3323         https://bugs.webkit.org/show_bug.cgi?id=220468
3324         <rdar://problem/72935720>
3325
3326         Reviewed by Stephanie Lewis.
3327
3328         Temporary change to make these packages easier to pip install.
3329
3330         * Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py: Bump version.
3331         * Scripts/libraries/resultsdbpy/setup.py: Use string instead of version object.
3332         * Scripts/libraries/webkitcorepy/setup.py: Ditto.
3333         * Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version.
3334         * Scripts/libraries/webkitflaskpy/setup.py: Use string instead of version object.
3335         * Scripts/libraries/webkitflaskpy/webkitflaskpy/__init__.py: Bump version.
3336         * Scripts/libraries/webkitscmpy/setup.py: Use string instead of version object.
3337         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version.
3338
3339 2021-01-08  Chris Dumez  <cdumez@apple.com>
3340
3341         Make it safe to re-enter HashMap::clear()
3342         https://bugs.webkit.org/show_bug.cgi?id=220445
3343
3344         Reviewed by Geoffrey Garen.
3345
3346         Add API test coverage.
3347
3348         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3349         (TestWebKitAPI::TEST):
3350
3351 2021-01-08  Chris Lord  <clord@igalia.com>
3352
3353         [WPE] Enable smooth-motion and kinetic scrolling on touchpads
3354         https://bugs.webkit.org/show_bug.cgi?id=219942
3355
3356         Reviewed by Žan Doberšek.
3357
3358         * wpe/backends/WindowViewBackend.cpp:
3359         Update to Wayland protocol 5 and interpret axis stop, discrete and
3360         smooth axis motion events.
3361
3362 2021-01-07  Paulo Matos  <pmatos@igalia.com>
3363
3364         Fix mktemp call for busybox mktemp
3365         https://bugs.webkit.org/show_bug.cgi?id=220422
3366
3367         Reviewed by Alexey Proskuryakov.
3368
3369         Busybox mktemp requires the template to have 6 Xs.
3370         GNU mktemp doesn't care so use 6 Xs in order to ensure this will work if busybox mktemp is installed.
3371
3372         * Scripts/run-jsc-stress-tests:
3373
3374 2021-01-07  Jonathan Bedard  <jbedard@apple.com>
3375
3376         [webkitscmpy] Split program into separate files (Follow-up fix)
3377         https://bugs.webkit.org/show_bug.cgi?id=220369
3378         <rdar://problem/72856906>
3379
3380         Unreviewed follow-up fix.
3381
3382         * Scripts/libraries/webkitscmpy/setup.py: Add program to directories to export.
3383
3384 2021-01-07  Ryosuke Niwa  <rniwa@webkit.org>
3385
3386         compare-results should be able to compare PLUM3 results
3387         https://bugs.webkit.org/show_bug.cgi?id=220443
3388
3389         Reviewed by Simon Fraser.
3390
3391         Added the support to compare PLUM3 results.
3392
3393         * Scripts/compare-results:
3394         (plum3Breakdown): Added.
3395         (detectPLUM3): Added.
3396         (PLUM3Results): Added.
3397         (detectBenchmark): Detect PLUM3.
3398         (biggerIsBetter): PLUM3 is a smaller-is-better benchmark.
3399         (main): Added PLUM3.
3400
3401 2021-01-07  Jonathan Bedard  <jbedard@apple.com>
3402
3403         [webkitscmpy] Split program into separate files
3404         https://bugs.webkit.org/show_bug.cgi?id=220369
3405         <rdar://problem/72856906>
3406
3407         Reviewed by Dewei Zhu.
3408
3409         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version.
3410         * Scripts/libraries/webkitscmpy/webkitscmpy/canonicalize: Move to webkitscmpy/program/canonicalize.
3411         * Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: Update imports.
3412         * Scripts/libraries/webkitscmpy/webkitscmpy/program: Moved from webkitscmpy/program.py.
3413         * Scripts/libraries/webkitscmpy/webkitscmpy/program.py: Moved to webkitscmpy/program.
3414         * Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py: Moved from webkitscmpy/program.py.
3415         * Scripts/libraries/webkitscmpy/webkitscmpy/program/canonicalize: Moved from webkitscmpy/canonicalize.
3416         * Scripts/libraries/webkitscmpy/webkitscmpy/program/canonicalize/committer.py: Ditto.
3417         * Scripts/libraries/webkitscmpy/webkitscmpy/program/canonicalize/message.py: Ditto.
3418         * Scripts/libraries/webkitscmpy/webkitscmpy/program/checkout.py: Moved from webkitscmpy/program.py.
3419         * Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py: Moved from webkitscmpy/program.py.
3420         * Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py: Moved from webkitscmpy/program.py.
3421
3422 2021-01-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3423
3424         Text fields should not be translated while typing
3425         https://bugs.webkit.org/show_bug.cgi?id=220431
3426         <rdar://problem/71724918>
3427
3428         Reviewed by Tim Horton.
3429
3430         Add an API test that modifies text in two input fields (by executing an edit command, and then by
3431         programmatically setting the value attribute). The test verifies that only the latter (programmatic) value
3432         change propagates a text manipulation update to the client layer.
3433
3434         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3435         (TestWebKitAPI::TEST):
3436
3437 2021-01-07  Jonathan Bedard  <JonWBedard@gmail.com>
3438
3439         [webkitscmpy] Use .git/config to verify if repository is git-svn
3440         https://bugs.webkit.org/show_bug.cgi?id=220427
3441         <rdar://problem/72899735>
3442
3443         Reviewed by Dewei Zhu.
3444
3445         * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version number.
3446         * Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
3447         (Git.is_svn): Use .git/config to verify if a repository is git-svn.
3448         * Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
3449         (Git): Populate .git/config if the provided path is writeable.
3450         * Scripts/libraries/webkitscmpy/webkitscmpy/test/find_unittest.py:
3451         (TestFind.test_revision_git_svn): Use a temporary directory so files
3452         can be written.
3453         * Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
3454         (TestGit.test_scm_type): Use a temporary directory so files can be written.
3455         (TestGit.test_info): Ditto.
3456         (TestGit.test_commit_revision): Ditto.
3457
3458 2021-01-07  Chris Dumez  <cdumez@apple.com>
3459
3460         [GPUProcess] Implement GPUProcess crash recovery for MediaElementAudioSourceNode
3461         https://bugs.webkit.org/show_bug.cgi?id=220391
3462
3463         Reviewed by Geoffrey Garen.
3464
3465         Add API test coverage.
3466
3467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3468         * TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
3469         (TEST):
3470         * TestWebKitAPI/Tests/WebKitCocoa/webaudio-createMediaElementSource.html: Added.
3471
3472 2021-01-07  Sam Sneddon  <gsnedders@apple.com>
3473
3474         LayoutTestFinder should be in charge of finding layout tests
3475         https://bugs.webkit.org/show_bug.cgi?id=220025
3476
3477         Reviewed by Jonathan Bedard.
3478
3479         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3480         (_is_reference_html_file): Formerly Port.is_reference_html_file
3481         (_has_supported_extension): Formerly Port._has_supported_extension
3482         (LayoutTestFinder.__init__): Define self._w3c_resource_files
3483         (LayoutTestFinder.find_tests): Change to call within the class
3484         (LayoutTestFinder.find_tests_by_path): Formerly Port.tests
3485         (LayoutTestFinder._expanded_paths): Formerly Port._expanded_paths
3486         (LayoutTestFinder._real_tests): Formerly Port._real_tests
3487         (LayoutTestFinder._is_test_file): Formerly Port._is_test_file
3488         (LayoutTestFinder._is_w3c_resource_file): Formerly Port._is_w3c_resource_file
3489         (LayoutTestFinder.find_touched_tests): Update for the above
3490         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3491         (MockLayoutTestFinder):
3492         (MockLayoutTestFinder._real_tests): Move this from the former MockPort.tests
3493         (LayoutTestFinderTests.make_finder): Similar to the make_port in base_unittest.py
3494         (LayoutTestFinderTests.touched_files): Adjust for MockLayoutTestFinder
3495         (LayoutTestFinderTests):
3496         (LayoutTestFinderTests.test_is_reference_html_file): Add test to check references are subset of tests
3497         (LayoutTestFinderTests.test_find_no_paths_specified): Formerly PortTest.test_find_no_paths_specified
3498         (LayoutTestFinderTests.test_find_one_test): Formerly PortTest.test_find_one_test
3499         (LayoutTestFinderTests.test_find_glob): Formerly PortTest.test_find_glob
3500         (LayoutTestFinderTests.test_find_with_skipped_directories): Formerly PortTest.test_find_with_skipped_directories
3501         (LayoutTestFinderTests.test_find_with_skipped_directories_2): Formerly PortTest.test_find_with_skipped_directories_2
3502         (LayoutTestFinderTests.test_is_test_file): Formerly PortTest.test_is_test_file
3503         (LayoutTestFinderTests.test_is_w3c_resource_file): Formerly PortTest.test_is_w3c_resource_file
3504         (test_touched_but_skipped_test): Adjust for MockLayoutTestFinder
3505         (MockPort): Deleted.
3506         (LayoutTestFinderTests.test_touched_test): Deleted.
3507         (LayoutTestFinderTests.test_expected_touched_test): Deleted.
3508         (LayoutTestFinderTests.test_platform_expected_touched_test): Deleted.
3509         (LayoutTestFinderTests.test_platform_duplicate_touched_test): Deleted.
3510         (LayoutTestFinderTests.test_touched_but_skipped_test): Deleted.
3511         * Scripts/webkitpy/layout_tests/models/test_input.py:
3512         (TestInput.__init__): Remove unused reference_files and should_run_pixel_tests
3513         (TestInput.__repr__): Remove unused should_run_pixel_tests
3514         * Scripts/webkitpy/port/base.py:
3515         (Port.tests): Deleted.
3516         (Port._expanded_paths): Deleted.
3517         (Port._real_tests): Deleted.
3518         (Port.is_w3c_resource_file): Deleted.
3519         (Port.is_reference_html_file): Deleted.
3520         (Port._has_supported_extension): Deleted.
3521         (Port._is_test_file): Deleted.
3522         * Scripts/webkitpy/port/base_unittest.py:
3523         (PortTest.test_find_no_paths_specified): Deleted.
3524         (PortTest.test_find_one_test): Deleted.
3525         (PortTest.test_find_glob): Deleted.
3526         (PortTest.test_find_with_skipped_directories): Deleted.
3527         (PortTest.test_find_with_skipped_directories_2): Deleted.
3528         (PortTest.test_is_test_file): Deleted.
3529         (PortTest.test_is_reference_html_file): Deleted.
3530         (PortTest.test_tests): Deleted.
3531         (PortTest.test_is_w3c_resource_file): Deleted.
3532         (test_jhbuild_wrapper): Deleted.
3533         (test_ref_tests_platform_directory): Deleted.
3534         (test_commits_for_upload): Deleted.
3535         * Scripts/webkitpy/port/factory.py:
3536         (PortFactory): Remove mock_drt
3537         * Scripts/webkitpy/port/mock_drt.py: Removed.
3538         * Scripts/webkitpy/port/mock_drt_unittest.py: Removed.
3539         * Scripts/webkitpy/tool/commands/queries.py:
3540         (PrintExpectations.execute): Adjust for Port.tests moving to LayoutTestFinder
3541         (PrintBaselines.execute): Adjust for Port._real_tests moving to LayoutTestFinder
3542
3543 2021-01-07  Sihui Liu  <sihui_liu@appe.com>
3544
3545         ASSERTION FAILED: !m_messageReceiverMapCount under WebKit::SpeechRecognitionServer::~SpeechRecognitionServer()
3546         https://bugs.webkit.org/show_bug.cgi?id=220404
3547
3548         Reviewed by Youenn Fablet.
3549
3550         * TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:
3551         (-[SpeechRecognitionPermissionUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3552         (-[SpeechRecognitionNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3553         (-[SpeechRecognitionNavigationDelegate webView:didFinishNavigation:]):
3554         (TestWebKitAPI::TEST):
3555
3556 2021-01-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3557
3558         [GTK] Build failures with GTK4 3.99.5.1
3559         https://bugs.webkit.org/show_bug.cgi?id=219844
3560
3561         Reviewed by Philippe Normand.
3562
3563         * MiniBrowser/gtk/BrowserSearchBox.c:
3564         (browserSearchBoxSizeAllocate):
3565         * MiniBrowser/gtk/BrowserWindow.c:
3566         (webViewReadyToShow):
3567         * MiniBrowser/gtk/CMakeLists.txt:
3568
3569 2021-01-06  Katherine Cheney  <katherine_cheney@apple.com>
3570
3571         Storage access prompt does not appear on MiniBrowser
3572         https://bugs.webkit.org/show_bug.cgi?id=220379
3573         <rdar://problem/72861088>
3574
3575         Reviewed by Darin Adler.
3576
3577         ITP should be on-by-default in MiniBrowser.
3578
3579         * MiniBrowser/mac/SettingsController.m:
3580         (-[SettingsController initWithMenu:]):
3581
3582 2021-01-06  Alexey Proskuryakov  <ap@apple.com>
3583
3584         Assorted fixes for bisect-builds
3585         https://bugs.webkit.org/show_bug.cgi?id=220158
3586
3587         Reviewed by Jonathan Bedard.
3588
3589         Switched to Python 3.
3590         Many trivial Python style changes.
3591         Simplified arguments, and cleaned up output.
3592         Switched from run-safari to run-minibrowser on macOS, as run-safari currently
3593         doesn't work on regular macOS installations.
3594
3595         * Scripts/bisect-builds: 
3596         (QueueDescriptor): New class that holds a description of a queue, or a "platform",
3597         as coming from a string like mac-catalina or mac-catalina-x86_64-release. Used for
3598         matching arguments to an existing archive directory on the server.
3599         (trac_link): Added. The tool now prints a trac link for seeing where the regression
3600         was introduced.
3601         (bisect_builds): Fixed arithmetic mistakes. Got rid of an unnecessary while-true loop,
3602         as the function was already recursive.
3603         (host_platform_name): The script now defaults to current platform, so -p argument
3604         is mostly to select simulator.
3605         (main): Moved code from "if __name__ == '__main__'" block into main function for
3606         consistency.
3607
3608 2021-01-06  Alex Christensen  <achristensen@webkit.org>
3609
3610         Add SPI to determine whether a regex is supported in WKContentRuleList
3611         https://bugs.webkit.org/show_bug.cgi?id=220095
3612
3613         Reviewed by Tim Horton.
3614
3615         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3616         (TEST):
3617
3618 2021-01-06  Sihui Liu  <sihui_liu@appe.com>
3619
3620         Stop speech recognition if page becomes invisible
3621         https://bugs.webkit.org/show_bug.cgi?id=220073
3622         <rdar://problem/72710704>
3623
3624         Reviewed by Youenn Fablet.
3625
3626         * TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm: updated 
3627         WebKit2.SpeechRecognitionErrorWhenStartingAudioCaptureOnDifferentPage for updated behavior.
3628         (TestWebKitAPI::TEST):
3629         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3630         (-[TestWKWebView _setUpTestWindow:]): set the origin of host window to be the origin of frame of TestWKWebView.
3631
3632 2021-01-06  Jonathan Bedard <jbedard@apple.com>
3633
3634         [webkitscmpy] Add command to canonicalize unpushed commits (Follow-up fix)
3635         https://bugs.webkit.org/show_bug.cgi?id=219982
3636         <rdar://problem/72427536>
3637
3638         Reviewed by Aakash Jain.
3639
3640         * Scripts/libraries/webkitscmpy/webkitscmpy/canonicalize/__init__.py:
3641         (Canonicalize.main): git filter-branch requires the repository root.
3642
3643 2021-01-06  Lauro Moura  <lmoura@igalia.com>
3644
3645         [Flatpak SDK] coredumpctl invocation when using a local SDK repo fallbacks to the remote repo
3646         https://bugs.webkit.org/show_bug.cgi?id=219934
3647
3648         Reviewed by Philippe Normand.
3649
3650         Some commands run in flatpak may end up calling other commands on the
3651         host through flatpak-spawn that would enter the flatpak environment
3652         again. One such command happens when getting crash logs, which invokes
3653         webkit-flatpak with --gdb-stack-trace.
3654
3655         Before this commit, the WEBKIT_FLATPAK_USER_DIR is not forwarded,
3656         making flatpakutils.py to download the regular UserFlatpak SDK instead
3657         of using the one in the mentioned variable.
3658
3659         * Scripts/webkitpy/port/linux_get_crash_log.py:
3660         (GDBCrashLogGenerator._get_trace_from_flatpak):
3661
3662 2021-01-05  Aditya Keerthi  <akeerthi@apple.com>
3663
3664         REGRESSION (r261157): Crash in WKSelectPopover when running as iPhone app on iPad
3665         https://bugs.webkit.org/show_bug.cgi?id=220065
3666         <rdar://problem/71932792>
3667
3668         Reviewed by Darin Adler.
3669
3670         Added an API test to exercise the previously crashing, and now fixed,
3671         codepath. Note that the test will trivially pass on iPhones, since the
3672         crash only occurs on iPads. See below for an explanation of how the
3673         test functions on iPads.
3674
3675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3676         * TestWebKitAPI/Tests/ios/UserInterfaceIdiomUpdate.mm: Added.
3677         (TestWebKitAPI::TEST):