[Win CMake] Fix incremental build after r188673
[WebKit-https.git] / Tools / ChangeLog
1 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2
3         [Win CMake] Fix incremental build after r188673
4         https://bugs.webkit.org/show_bug.cgi?id=148539
5
6         Reviewed by Brent Fulgham.
7
8         * TestWebKitAPI/PlatformWin.cmake:
9         Copy forwarding headers from WebCore before building in case that was not yet done.
10         It used to be done when running CMake, but now it's a build step.
11
12 2015-08-27  Nan Wang  <n_wang@apple.com>
13
14         AX: Fix accessibility/select-element-at-index.html test
15         https://bugs.webkit.org/show_bug.cgi?id=148516
16
17         Reviewed by Chris Fleizach.
18
19         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
20
21         * DumpRenderTree/AccessibilityUIElement.cpp:
22         (setSelectedChildCallback):
23         (setSelectedChildAtIndexCallback):
24         (removeSelectionAtIndexCallback):
25         (elementAtPointCallback):
26         (sentenceAtOffsetCallback):
27         (stringForSelectionCallback):
28         (AccessibilityUIElement::getJSClass):
29         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
30         (AccessibilityUIElement::setSelectedChild):
31         (AccessibilityUIElement::setSelectedChildAtIndex):
32         (AccessibilityUIElement::removeSelectionAtIndex):
33         (AccessibilityUIElement::accessibilityValue):
34         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
35         (WTR::AccessibilityUIElement::wordAtOffset):
36         (WTR::AccessibilityUIElement::lineAtOffset):
37         (WTR::AccessibilityUIElement::sentenceAtOffset):
38         (WTR::AccessibilityUIElement::isSelectable):
39         (WTR::AccessibilityUIElement::isMultiSelectable):
40         (WTR::AccessibilityUIElement::setSelectedChild):
41         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
42         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
43         (WTR::AccessibilityUIElement::selectedChildrenCount):
44         (WTR::AccessibilityUIElement::selectedChildAtIndex):
45         (WTR::AccessibilityUIElement::isExpanded):
46         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
47         (WTR::AccessibilityUIElement::setSelectedChild):
48         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
49         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
50         (WTR::AccessibilityUIElement::accessibilityValue):
51
52 2015-08-27  Alex Christensen  <achristensen@webkit.org>
53
54         Build fix after r188982
55
56         * MiniBrowser/win/CMakeLists.txt:
57         The directory structure changed in the move.
58
59 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
60
61         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
62
63         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
64
65         * gtk/install-dependencies:
66
67 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
68
69         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
70
71         * Scripts/run-gtk-tests:
72         (TestRunner):
73
74 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
75
76         Fix GTK+ WTR crashes in initializeMainRunLoop()
77
78         Rubber-stamped by Žan Doberšek.
79
80         Initialize threading and main thread before
81         RunLoop::initializeMainRunLoop(), since the GLib implementation of
82         the RunLoop uses isMainThread() to decide whether to create a new
83         GMainContext or use the default one. Also use RunLoop::run() and
84         ::stop() instead of gtk_main/quit.
85
86         * WebKitTestRunner/TestController.cpp:
87         (WTR::TestController::initialize):
88         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
89         (WTR::TestController::notifyDone):
90         (WTR::TestController::platformRunUntil):
91
92 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
93
94         Unreviewed, further shorten a test that times out because it's very long
95         running.
96
97         I've locally run these tests on repeat for 24 hours and found no genuine
98         failures, like deadlocks. So, the timeouts are probably because the test
99         machine is slow and debug is slow. We should just run this test for fewer
100         iterations.
101
102         * TestWebKitAPI/Tests/WTF/Lock.cpp:
103         (TestWebKitAPI::TEST):
104
105 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
106
107         Unreviewed build fix attempt on EFL
108
109         * WebKitTestRunner/PlatformEfl.cmake:
110
111 2015-08-26  Alex Christensen  <achristensen@webkit.org>
112
113         Build fix after r188982
114
115         * MiniBrowser/win/CMakeLists.txt:
116         Find .rc files in correct directory.
117
118 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
119
120         [EFL] Bump cairo version to 1.14.2
121         https://bugs.webkit.org/show_bug.cgi?id=148474
122
123         Reviewed by Csaba Osztrogonác.
124
125         * efl/jhbuild.modules:
126
127 2015-08-26  Andy Estes  <aestes@apple.com>
128
129         Crash when following a Google search link to Twitter with Limit Adult Content enabled
130         https://bugs.webkit.org/show_bug.cgi?id=147651
131
132         Rubber-stamped by Brady Eidson.
133
134         Taught TestRunner how to decide the navigation policy after a delay.
135
136         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
137         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
138         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
139         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
140         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
141         * WebKitTestRunner/InjectedBundle/TestRunner.h:
142         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
143         * WebKitTestRunner/TestController.cpp:
144         (WTR::TestController::initialize):
145         (WTR::TestController::resetStateToConsistentValues):
146         (WTR::TestController::decidePolicyForNavigationAction):
147         * WebKitTestRunner/TestController.h:
148         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
149         * WebKitTestRunner/TestInvocation.cpp:
150         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
151
152 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
153
154         [Win] Rename 'WinLauncher' to 'MiniBrowser'
155         https://bugs.webkit.org/show_bug.cgi?id=148485
156
157         Reviewed by Alex Christensen
158
159         Move the WinLauncher project and source files to a subdirectory
160         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
161         source code and project files.
162         
163         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
164         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
165         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
166         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
167         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
168         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
169         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
170         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
171         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
172         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
173         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
174         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
175         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
176         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
177         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
178         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
179         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
180         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
181         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
182         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
183         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
184         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
185         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
186         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
187         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
188         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
189         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
190         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
191         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
192         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
193         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
194         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
195         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
196         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
197         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
198         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
199         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
200         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
201         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
202         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
203         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
204         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
205         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
206         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
207         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
208         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
209         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
210         * MiniBrowser/win: Copied from WinLauncher.
211         * MiniBrowser/win/Common.cpp:
212         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
213         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
214         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
215         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
216         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
217         * MiniBrowser/win/PageLoadTestClient.cpp:
218         * MiniBrowser/win/PageLoadTestClient.h:
219         * MiniBrowser/win/ResourceLoadDelegate.cpp:
220         * MiniBrowser/win/ResourceLoadDelegate.h:
221         * MiniBrowser/win/WinLauncher.cpp: Removed.
222         * MiniBrowser/win/WinLauncher.h: Removed.
223         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
224         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
225         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
226         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
227         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
228         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
229         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
230         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
231         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
232         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
233         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
234         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
235         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
236         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
237         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
238         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
239         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
240         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
241         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
242         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
243         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
244         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
245         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
246         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
247         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
248         * MiniBrowser/win/WinLauncherReplace.h: Removed.
249         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
250         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
251         * MiniBrowser/win/WinMain.cpp:
252         * WinLauncher: Removed.
253         * WinLauncher/AccessibilityDelegate.cpp: Removed.
254         * WinLauncher/AccessibilityDelegate.h: Removed.
255         * WinLauncher/CMakeLists.txt: Removed.
256         * WinLauncher/Common.cpp: Removed.
257         * WinLauncher/DOMDefaultImpl.cpp: Removed.
258         * WinLauncher/DOMDefaultImpl.h: Removed.
259         * WinLauncher/PageLoadTestClient.cpp: Removed.
260         * WinLauncher/PageLoadTestClient.h: Removed.
261         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
262         * WinLauncher/PrintWebUIDelegate.h: Removed.
263         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
264         * WinLauncher/ResourceLoadDelegate.h: Removed.
265         * WinLauncher/WebDownloadDelegate.cpp: Removed.
266         * WinLauncher/WebDownloadDelegate.h: Removed.
267         * WinLauncher/WinLauncher.cpp: Removed.
268         * WinLauncher/WinLauncher.h: Removed.
269         * WinLauncher/WinLauncher.vcxproj: Removed.
270         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
271         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
272         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
273         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
274         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
275         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
276         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
277         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
278         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
279         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
280         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
281         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
282         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
283         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
284         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
285         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
286         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
287         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
288         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
289         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
290         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
291         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
292         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
293         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
294         * WinLauncher/WinLauncherReplace.h: Removed.
295         * WinLauncher/WinLauncherWebHost.cpp: Removed.
296         * WinLauncher/WinLauncherWebHost.h: Removed.
297         * WinLauncher/WinMain.cpp: Removed.
298         * WinLauncher/resource.h: Removed.
299         * WinLauncher/stdafx.cpp: Removed.
300         * WinLauncher/stdafx.h: Removed.
301         * win/AssembleBuildLogs/AssembleLogs.cmd:
302
303 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
304
305         [Win] Simplify menu handling code in WinLauncher
306         https://bugs.webkit.org/show_bug.cgi?id=148461
307
308         Reviewed by Zalan Bujtas.
309
310         Revise 'ToggleMenuItem' to return a boolean value indicating if
311         it handled the message. Revise WndProc to use this to decide if it
312         should pass the message on to the default handler, rather than
313         duplicating the logic in both places.
314         
315         * WinLauncher/Common.cpp:
316         (ToggleMenuItem): Return true if the menu item message was handled.
317         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
318         the message tothe default handler.
319
320 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
321
322         Remove unused code after r188948
323         https://bugs.webkit.org/show_bug.cgi?id=148467
324
325         Reviewed by Gyuyoung Kim.
326
327         * WebKitTestRunner/TestController.cpp:
328         (WTR::TestController::platformPreferences): Deleted.
329
330 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
331
332         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
333         https://bugs.webkit.org/show_bug.cgi?id=148377
334
335         Reviewed by Carlos Garcia Campos.
336
337         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
338         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
339         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
340         EFL and GTK at the moment.
341
342         * WebKitTestRunner/TestController.cpp:
343         (WTR::TestController::platformWillRunTest):
344         * WebKitTestRunner/efl/TestControllerEfl.cpp:
345         (WTR::TestController::platformPreferences):
346         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
347         (WTR::TestController::platformPreferences):
348
349 2015-08-25  Nan Wang  <n_wang@apple.com>
350
351         AX: Enable accessibility/aria-controls.html test for mac
352         https://bugs.webkit.org/show_bug.cgi?id=148458
353
354         Reviewed by Chris Fleizach.
355
356         Implemented ariaControlsElementAtIndex(unsigned index).
357
358         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
359         (AccessibilityUIElement::ariaControlsElementAtIndex):
360         (AccessibilityUIElement::disclosedRowAtIndex):
361         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
362         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
363
364 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
365
366         Remove python tests for PassRefPtr 
367         https://bugs.webkit.org/show_bug.cgi?id=148463
368
369         Reviewed by Andy Estes.
370
371         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
372
373         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
374         (PassPtrTest): Deleted.
375         (PassPtrTest.assert_pass_ptr_check): Deleted.
376         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
377         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
378         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
379         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
380         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
381         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
382
383 2015-08-25  Andy Estes  <aestes@apple.com>
384
385         [iOS] run-webkit-tests fails if watchOS SDK is installed
386         https://bugs.webkit.org/show_bug.cgi?id=148453
387
388         Reviewed by David Kilzer.
389
390         * Scripts/webkitpy/xcode/simulator.py:
391         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
392         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
393
394 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
395
396         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
397         https://bugs.webkit.org/show_bug.cgi?id=148197
398         rdar://problem/22334382
399
400         Reviewed by Daniel Bates.
401
402         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
403         * Scripts/webkitpy/port/ios.py:
404         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
405         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
406         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
407         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
408         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
409
410 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
411
412         Remove PassRefPtr style check rule
413         https://bugs.webkit.org/show_bug.cgi?id=148432
414
415         Reviewed by Andreas Kling.
416
417         PassRefPtr is being removed. Thus style rule needs to be removed as well.
418
419         * Scripts/webkitpy/style/checkers/cpp.py:
420         (_check_parameter_name_against_text): Deleted.
421         (check_function_definition_and_pass_ptr): Deleted.
422         (check_function_definition): Deleted.
423         (check_pass_ptr_usage): Deleted.
424         (process_line): Deleted.
425         (CppChecker): Deleted.
426
427 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
428
429         [Win] Expose "Inverted Colors" option in WinLauncher
430         https://bugs.webkit.org/show_bug.cgi?id=148451
431
432         Reviewed by Tim Horton.
433
434         Add the ability to toggle the "Inverted Colors" preference
435         in WinLauncher.
436         
437         * WinLauncher/Common.cpp:
438         (ToggleMenuItem): Toggle the feature when the menu item
439         is selected.
440         (WndProc): Recognize the new menu option.
441         * WinLauncher/WinLauncher.cpp:
442         (WinLauncher::setToDefaultPreferences): Launch with "Invert
443         Colors" turned off.
444         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
445         entry for "Invert Colors".
446         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
447
448 2015-08-25  Nan Wang  <n_wang@apple.com>
449
450         [Mac] accessibility/document-attributes.html fails
451         https://bugs.webkit.org/show_bug.cgi?id=116636
452
453         Reviewed by Chris Fleizach.
454
455         Implemented documentURI() and documentEncoding().
456
457         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
458         (AccessibilityUIElement::documentEncoding):
459         (AccessibilityUIElement::documentURI):
460         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
461         (WTR::AccessibilityUIElement::documentEncoding):
462         (WTR::AccessibilityUIElement::documentURI):
463
464 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
465
466         [Win] Unreviewed test gardening.
467
468         Fix another case where the logging string is constructed using the variable 'frame',
469         but the method argument is not given a name. This causes the global 'frame' value to
470         be used, producing incorrect output.
471
472         * DumpRenderTree/win/FrameLoadDelegate.cpp:
473         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
474         argument.
475
476 2015-08-24  Tim Horton  <timothy_horton@apple.com>
477
478         (Finally...) get rid of WKViewIOS
479         https://bugs.webkit.org/show_bug.cgi?id=148404
480
481         Reviewed by Anders Carlsson.
482
483         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
484         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
485         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
486         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
487         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
488         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
489         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
490         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
491         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
492         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
493         Mark tests that use WKBrowsingContextController as Mac-only.
494
495         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
496         (WTR::AccessibilityController::addNotificationListener):
497         * WebKitTestRunner/ios/mainIOS.mm:
498         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
499         Import UIKit instead of depending on WKView.h to do so.
500
501 2015-08-24  Jason Marcell  <jmarcell@apple.com>
502
503         Add support to dashboard for displaying Git SHA's as revisions.
504         https://bugs.webkit.org/show_bug.cgi?id=148387
505
506         Reviewed by Daniel Bates.
507
508         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
509         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
510         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
511         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
512         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
513         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
514
515 2015-08-24  Andy Estes  <aestes@apple.com>
516
517         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
518
519         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
520
521 2015-08-23  Andy Estes  <aestes@apple.com>
522
523         Addressed a missed piece of review feedback from r188851.
524
525         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
526
527 2015-08-23  Andy Estes  <aestes@apple.com>
528
529         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
530         https://bugs.webkit.org/show_bug.cgi?id=147872
531         rdar://problem/22044000
532
533         Reviewed by Dan Bernstein.
534         
535         Added an API test.
536
537         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
539         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
540         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
541         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
542         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
543         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
544         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
545         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
546         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
547         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
548
549 2015-08-23  Andy Estes  <aestes@apple.com>
550
551         Fixed the 32-bit Mac build after r188844.
552
553         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
554         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
555
556 2015-08-22  Andy Estes  <aestes@apple.com>
557
558         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
559         https://bugs.webkit.org/show_bug.cgi?id=148317
560
561         Reviewed by Dan Bernstein.
562
563         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
564         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
565         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
566         when creating WKWebViews.
567
568         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
569         added a new API test for bundle parameters.
570
571         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
572         named its executable TestWebKitAPI.bundle.
573         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
575         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
576         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
577         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
578         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
579         bundle parameter and asked for an initial notification.
580         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
581         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
582         mirror its value in the main frame's JSContext.
583         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
584         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
585         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
586         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
587         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
588         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
589         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
590         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
591         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
592         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
593
594 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
595
596         URTBF after r188828.
597
598         * WebKitTestRunner/PlatformWebView.h:
599
600 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
601
602         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
603         https://bugs.webkit.org/show_bug.cgi?id=148356
604
605         Reviewed by Darin Adler.
606
607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
608         (BuildbotCombinedQueueView.prototype.update):
609
610 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
611
612         build.webkit.org/dashboard: Respect step's hidden flag
613         https://bugs.webkit.org/show_bug.cgi?id=148357
614
615         Reviewed by Darin Adler.
616
617         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
618         (BuildbotIteration.prototype._parseData):
619
620 2015-08-23  Nan Wang  <n_wang@apple.com>
621
622         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
623         https://bugs.webkit.org/show_bug.cgi?id=148328
624
625         Reviewed by Darin Adler.
626
627         We should only expose stringValue() when value attribute is set.
628
629         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
630         (AccessibilityUIElement::stringValue):
631         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
632         (WTR::AccessibilityUIElement::stringValue):
633
634 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
635
636         Remove style checking rule regarding OwnPtr and PassOwnPtr
637         https://bugs.webkit.org/show_bug.cgi?id=148360
638
639         Reviewed by Darin Adler.
640
641         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
642         Removed it.
643
644         * Scripts/do-webcore-rename:
645         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
646         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
647         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
648         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
649         (WebKitStyleTest.test_names): Deleted.
650
651 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
652
653         WebKitTestRunner should use WKWebView on OS X and iOS
654         https://bugs.webkit.org/show_bug.cgi?id=143743
655         <rdar://problem/16947123>
656
657         Reviewed by Anders Carlsson.
658         Patch by Enrica Casucci and myself.
659
660         * WebKitTestRunner/PlatformWebView.h:
661         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
662         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
663         instead of WKContext and WKPageGroup.
664
665         Remove the unused, always-true windowSnapshotEnabled().
666         While technically some platforms don't have window snapshotting,
667         they just return null instead of implementing windowSnapshotEnabled().
668
669         * WebKitTestRunner/TestController.h:
670         * WebKitTestRunner/TestController.cpp:
671         (WTR::TestController::createOtherPage):
672         (WTR::TestController::initialize):
673         (WTR::TestController::createWebViewWithOptions):
674         Delegate to the various platforms for creating PlatformWebView instances,
675         for creating WKContexts, and for accessing WKPreferences,
676         so that they can do special things (like, use WKWebView instead!).
677
678         (WTR::TestController::resetPreferencesToConsistentValues):
679         Make explicit WebKitTestRunner's desired default for two preferences
680         which have differing defaults between the antique and modern API,
681         for consistency's sake.
682
683         (WTR::TestController::resetStateToConsistentValues):
684         Add platformResetStateToConsistentValues.
685
686         * WebKitTestRunner/TestInvocation.cpp:
687         (WTR::TestInvocation::dumpResults):
688         Adjust to the aforementioned removal of windowSnapshotEnabled().
689
690         * WebKitTestRunner/ios/TestControllerCocoa.mm:
691         (WTR::TestController::platformResetStateToConsistentValues):
692         (WTR::TestController::platformPreferences):
693         (WTR::TestController::platformCreateWebView):
694         (WTR::TestController::platformCreateOtherPage):
695         (WTR::TestController::platformInitializeConfiguration):
696         Implement the new platform functions for the Modern WebKit2 API,
697         in a new TestControllerCocoa file that is shared between iOS and Mac.
698         
699         For platformMaybeCreateContext, use the trick that we know we can cast
700         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
701         WKWebView's configuration.
702
703         Ditto for WKPreferencesRef and WKPreferences.
704
705         Remove user content filters on the WKWebView's userContentController.
706
707         * WebKitTestRunner/mac/TestControllerMac.mm:
708         * WebKitTestRunner/ios/TestControllerIOS.mm:
709         Move code into TestControllerCocoa.
710
711         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
712         (WTR::InjectedBundle::beginTesting):
713         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
714         (WTR::TestRunner::addUserScript):
715         (WTR::TestRunner::addUserStyleSheet):
716         Adopt WKBundlePage API for user scripts/sheets.
717
718         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
719         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
720         Make and keep a WKWebView instead of a WKView.
721         
722         * WebKitTestRunner/mac/EventSenderProxy.mm:
723         (WTR::EventSenderProxy::mouseUp):
724         (WTR::EventSenderProxy::mouseMoveTo):
725         Reach inside the WKWebView to the WKView when dispatching events.
726         This is fairly ugly and we should come up with a better solution.
727         Also, fix some flipping and style errors.
728
729 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
730
731         Unreviewed, attempt to fix GTK build after r188718
732
733         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
734         (WTR::PlatformWebView::PlatformWebView):
735
736 2015-08-21  Commit Queue  <commit-queue@webkit.org>
737
738         Unreviewed, rolling out r188807, r188813, and r188815.
739         https://bugs.webkit.org/show_bug.cgi?id=148349
740
741         lots of 32-bit build problems, better to resolve separately
742         and try again (Requested by thorton on #webkit).
743
744         Reverted changesets:
745
746         "WebKitTestRunner should use WKWebView on OS X and iOS"
747         https://bugs.webkit.org/show_bug.cgi?id=143743
748         http://trac.webkit.org/changeset/188807
749
750         "Stop building WebKitTestRunner for 32-bit platforms"
751         https://bugs.webkit.org/show_bug.cgi?id=143743
752         http://trac.webkit.org/changeset/188813
753
754         "Stop building WebKitTestRunner for 32-bit platforms"
755         https://bugs.webkit.org/show_bug.cgi?id=143743
756         http://trac.webkit.org/changeset/188815
757
758 2015-08-21  Tim Horton  <timothy_horton@apple.com>
759
760         Stop building WebKitTestRunner for 32-bit platforms
761         https://bugs.webkit.org/show_bug.cgi?id=143743
762         <rdar://problem/16947123>
763
764         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
765         This is a restriction on the valid set, not the desired set.
766
767 2015-08-21  Jason Marcell  <jmarcell@apple.com>
768
769         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
770         to work with these new objects.
771         https://bugs.webkit.org/show_bug.cgi?id=148188
772
773         Reviewed by Daniel Bates.
774
775         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
776         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
777         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
778         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
779         (repository, "branch name")-pair.
780         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
781         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
782         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
783         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
784         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
785         objects which represent a (repository, "branch name")-pair.
786         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
787         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
788         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
789         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
790         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
791         BuildbotQueue.branch to BuildbotQueue.branches.
792         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
793         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
794
795 2015-08-21  Tim Horton  <timothy_horton@apple.com>
796
797         Stop building WebKitTestRunner for 32-bit platforms
798         https://bugs.webkit.org/show_bug.cgi?id=143743
799         <rdar://problem/16947123>
800
801         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
802         WKWebView is not available on 32-bit OS X.
803
804 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
805
806         [Win] Unreviewed test correction after r188709.
807
808         I removed a function argument that happened to be mirrored by a global
809         value with the same name. This prevented a compile error, but testing
810         showed that the wrong value was being used in the function.
811
812         * DumpRenderTree/win/FrameLoadDelegate.cpp:
813         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
814         back
815
816 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
817
818         WebKitTestRunner should use WKWebView on OS X and iOS
819         https://bugs.webkit.org/show_bug.cgi?id=143743
820         <rdar://problem/16947123>
821
822         Reviewed by Anders Carlsson.
823         Patch by Enrica Casucci and myself.
824
825         * WebKitTestRunner/PlatformWebView.h:
826         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
827         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
828         instead of WKContext and WKPageGroup.
829
830         Remove the unused, always-true windowSnapshotEnabled().
831         While technically some platforms don't have window snapshotting,
832         they just return null instead of implementing windowSnapshotEnabled().
833
834         * WebKitTestRunner/TestController.h:
835         * WebKitTestRunner/TestController.cpp:
836         (WTR::TestController::createOtherPage):
837         (WTR::TestController::initialize):
838         (WTR::TestController::createWebViewWithOptions):
839         Delegate to the various platforms for creating PlatformWebView instances,
840         for creating WKContexts, and for accessing WKPreferences,
841         so that they can do special things (like, use WKWebView instead!).
842
843         (WTR::TestController::resetPreferencesToConsistentValues):
844         Make explicit WebKitTestRunner's desired default for two preferences
845         which have differing defaults between the antique and modern API,
846         for consistency's sake.
847
848         (WTR::TestController::resetStateToConsistentValues):
849         Add platformResetStateToConsistentValues.
850
851         * WebKitTestRunner/TestInvocation.cpp:
852         (WTR::TestInvocation::dumpResults):
853         Adjust to the aforementioned removal of windowSnapshotEnabled().
854
855         * WebKitTestRunner/ios/TestControllerCocoa.mm:
856         (WTR::TestController::platformResetStateToConsistentValues):
857         (WTR::TestController::platformPreferences):
858         (WTR::TestController::platformCreateWebView):
859         (WTR::TestController::platformCreateOtherPage):
860         (WTR::TestController::platformInitializeConfiguration):
861         Implement the new platform functions for the Modern WebKit2 API,
862         in a new TestControllerCocoa file that is shared between iOS and Mac.
863         
864         For platformMaybeCreateContext, use the trick that we know we can cast
865         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
866         WKWebView's configuration.
867
868         Ditto for WKPreferencesRef and WKPreferences.
869
870         Remove user content filters on the WKWebView's userContentController.
871
872         * WebKitTestRunner/mac/TestControllerMac.mm:
873         * WebKitTestRunner/ios/TestControllerIOS.mm:
874         Move code into TestControllerCocoa.
875
876         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
877         (WTR::InjectedBundle::beginTesting):
878         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
879         (WTR::TestRunner::addUserScript):
880         (WTR::TestRunner::addUserStyleSheet):
881         Adopt WKBundlePage API for user scripts/sheets.
882
883         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
884         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
885         Make and keep a WKWebView instead of a WKView.
886         
887         * WebKitTestRunner/mac/EventSenderProxy.mm:
888         (WTR::EventSenderProxy::mouseUp):
889         (WTR::EventSenderProxy::mouseMoveTo):
890         Reach inside the WKWebView to the WKView when dispatching events.
891         This is fairly ugly and we should come up with a better solution.
892         Also, fix some flipping and style errors.
893
894 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
895
896         Improve how UI events are dispatched by WebKitTestRunner
897         https://bugs.webkit.org/show_bug.cgi?id=148326
898
899         Reviewed by Anders Carlsson.
900
901         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
902         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
903         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
904         asynchronous (and really, it has always been for the most part).
905
906         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
907         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
908         (WTR::EventSendingController::mouseUp): Ditto.
909         (WTR::EventSendingController::mouseMoveTo): Ditto.
910         (WTR::EventSendingController::mouseForceDown): Ditto.
911         (WTR::EventSendingController::mouseForceUp): Ditto.
912         (WTR::EventSendingController::mouseForceChanged): Ditto.
913         (WTR::EventSendingController::leapForward): Ditto.
914         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
915         (WTR::EventSendingController::keyDown): Ditto.
916         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
917         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
918         to be done in custom WebKit2 code for test wheel event handling.
919         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
920         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
921         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
922         (WTR::EventSendingController::addTouchPoint): Ditto.
923         (WTR::EventSendingController::updateTouchPoint): Ditto.
924         (WTR::EventSendingController::setTouchModifier): Ditto.
925         (WTR::EventSendingController::setTouchPointRadius): Ditto.
926         (WTR::EventSendingController::touchStart): Ditto.
927         (WTR::EventSendingController::touchMove): Ditto.
928         (WTR::EventSendingController::touchEnd): Ditto.
929         (WTR::EventSendingController::touchCancel): Ditto.
930         (WTR::EventSendingController::clearTouchPoints): Ditto.
931         (WTR::EventSendingController::releaseTouchPoint): Ditto.
932         (WTR::EventSendingController::cancelTouchPoint): Ditto.
933
934         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
935         (WTR::InjectedBundle::postSetWindowIsKey):
936         (WTR::InjectedBundle::postSimulateWebNotificationClick):
937         (WTR::InjectedBundle::isGeolocationProviderActive):
938         (WTR::InjectedBundle::shouldProcessWorkQueue):
939         Updated for WKBundlePagePostSynchronousMessage renaming.
940
941         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
942         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
943
944         * WebKitTestRunner/TestController.cpp:
945         (WTR::TestController::initialize): Allow handling the new test style messages.
946         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
947         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
948         (WTR::TestController::didReceiveMessageFromInjectedBundle):
949         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
950         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
951
952         * WebKitTestRunner/mac/EventSenderProxy.mm:
953         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
954         (WTR::EventSenderProxy::keyDown): Ditto.
955         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
956         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
957
958 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
959
960         Skip no-llint tests that fail due to running out of executable memory after r188969
961         https://bugs.webkit.org/show_bug.cgi?id=148273
962
963         Reviewed by Michael Saboff.
964
965         * Scripts/run-jsc-stress-tests:
966
967 2015-08-21  Nan Wang  <n_wang@apple.com>
968
969         [Mac] accessibility/selection-states.html fails
970         https://bugs.webkit.org/show_bug.cgi?id=116637
971
972         Reviewed by Chris Fleizach.
973
974         Implemented isSelectable() and isMultiSelectable().
975
976         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
977         (AccessibilityUIElement::isSelectable):
978         (AccessibilityUIElement::isMultiSelectable):
979         (AccessibilityUIElement::isSelectedOptionActive):
980         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
981         (WTR::AccessibilityUIElement::isSelectable):
982         (WTR::AccessibilityUIElement::isMultiSelectable):
983         (WTR::AccessibilityUIElement::isVisible):
984
985 2015-08-21  Jason Marcell  <jmarcell@apple.com>
986
987         Fix iteration over repositories on bot watcher's dashboard.
988
989         Reviewed by Alexey Proskuryakov.
990
991         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
992         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
993
994 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
995
996         [EFL] Revise PlatformWebView ctor according to r188718
997         https://bugs.webkit.org/show_bug.cgi?id=148282
998
999         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
1000         instead of WKContextRef and WKPageGroupRef respectively.
1001
1002         Reviewed by Gyuyoung Kim.
1003
1004         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1005         (WTR::PlatformWebView::PlatformWebView):
1006
1007 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
1008
1009         Unreviewed, changed Devin Rousso's email.
1010
1011         * Scripts/webkitpy/common/config/contributors.json:
1012
1013 2015-08-20  Anders Carlsson  <andersca@apple.com>
1014
1015         Use WKPageConfigurationRef in WebKitTestRunner
1016         https://bugs.webkit.org/show_bug.cgi?id=147996
1017
1018         Reviewed by Tim Horton.
1019
1020         * WebKitTestRunner/TestController.cpp:
1021         (WTR::TestController::createOtherPage):
1022         (WTR::TestController::initialize):
1023         (WTR::TestController::createWebViewWithOptions):
1024         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1025         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
1026         (WTR::PlatformWebView::PlatformWebView):
1027         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
1028
1029 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
1030
1031         [Win] Update Windows tools for revised MIDL interfaces
1032         https://bugs.webkit.org/show_bug.cgi?id=148249
1033
1034         Reviewed by Dean Jackson.
1035
1036         This is a follow-up to Bug 148001.
1037
1038         Revise the testing software to use compatible signatures and
1039         implementations to match the requirements of the IDL generated
1040         with the SAL annotations.
1041
1042         * DumpRenderTree/win/DRTDataObject.cpp:
1043         * DumpRenderTree/win/DRTDataObject.h:
1044         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1045         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1046         * DumpRenderTree/win/DRTDropSource.cpp:
1047         * DumpRenderTree/win/DRTDropSource.h:
1048         * DumpRenderTree/win/DumpRenderTree.cpp:
1049         * DumpRenderTree/win/EditingDelegate.cpp:
1050         * DumpRenderTree/win/EditingDelegate.h:
1051         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1052         * DumpRenderTree/win/FrameLoadDelegate.h:
1053         * DumpRenderTree/win/HistoryDelegate.cpp:
1054         * DumpRenderTree/win/HistoryDelegate.h:
1055         * DumpRenderTree/win/PolicyDelegate.cpp:
1056         * DumpRenderTree/win/PolicyDelegate.h:
1057         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1058         * DumpRenderTree/win/ResourceLoadDelegate.h:
1059         * DumpRenderTree/win/TestRunnerWin.cpp:
1060         * DumpRenderTree/win/UIDelegate.cpp:
1061         * DumpRenderTree/win/UIDelegate.h:
1062         * WinLauncher/AccessibilityDelegate.cpp:
1063         * WinLauncher/AccessibilityDelegate.h:
1064         * WinLauncher/Common.cpp:
1065         * WinLauncher/DOMDefaultImpl.cpp:
1066         * WinLauncher/DOMDefaultImpl.h:
1067         * WinLauncher/PageLoadTestClient.cpp:
1068         * WinLauncher/PageLoadTestClient.h:
1069         * WinLauncher/PrintWebUIDelegate.cpp:
1070         * WinLauncher/PrintWebUIDelegate.h:
1071         * WinLauncher/ResourceLoadDelegate.cpp:
1072         * WinLauncher/ResourceLoadDelegate.h:
1073         * WinLauncher/WebDownloadDelegate.cpp:
1074         * WinLauncher/WebDownloadDelegate.h:
1075         * WinLauncher/WinLauncherWebHost.cpp:
1076         * WinLauncher/WinLauncherWebHost.h:
1077         * WinLauncher/WinMain.cpp:
1078         * win/DLLLauncher/DLLLauncherMain.cpp:
1079
1080 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
1081
1082         Unreviewed, shorten a test that runs too long and times out.
1083
1084         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1085         (TestWebKitAPI::TEST):
1086
1087 2015-08-20  Alex Christensen  <achristensen@webkit.org>
1088
1089         Clean up CMake build after r188673
1090         https://bugs.webkit.org/show_bug.cgi?id=148234
1091
1092         Reviewed by Tim Horton.
1093
1094         * DumpRenderTree/PlatformWin.cmake:
1095         * TestWebKitAPI/CMakeLists.txt:
1096         * TestWebKitAPI/PlatformWin.cmake:
1097         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
1098         gtest needs to be a static library on Windows to not crash.
1099
1100 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1101
1102         CMake Windows build should not include files directly from other Source directories
1103         https://bugs.webkit.org/show_bug.cgi?id=148198
1104
1105         Reviewed by Brent Fulgham.
1106
1107         * DumpRenderTree/DumpRenderTreePrefix.h:
1108         Include cmakeconfig.h to properly define all enabled features.
1109         * DumpRenderTree/PlatformWin.cmake:
1110         * TestWebKitAPI/PlatformWin.cmake:
1111
1112 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1113
1114         Build TestWTF on Mac with CMake.
1115         https://bugs.webkit.org/show_bug.cgi?id=147972
1116
1117         Reviewed by Tim Horton.
1118
1119         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
1120         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
1121
1122         * TestWebKitAPI/CMakeLists.txt:
1123         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
1124         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
1125         * TestWebKitAPI/PlatformMac.cmake: Added.
1126         * TestWebKitAPI/config.h:
1127         Postpone some build fixes until WebKit builds completely on Mac with CMake.
1128
1129 2015-08-19  Brian Burg  <bburg@apple.com>
1130
1131         Unreviewed, add Aleksandr Skachkov to the list of contributors.
1132
1133         * Scripts/webkitpy/common/config/contributors.json:
1134
1135 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1136
1137         REGRESSION(r188548): [GTK] Build broken.
1138         https://bugs.webkit.org/show_bug.cgi?id=148154
1139
1140         Reviewed by Martin Robinson.
1141
1142         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1143         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1144         Even if we don't need to add/override any settings in ViewOptions,
1145         we need to define this as an empty function to make it build.
1146
1147 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1148
1149         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
1150         https://bugs.webkit.org/show_bug.cgi?id=148073
1151
1152         Reviewed by Alexey Proskuryakov.
1153
1154         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
1155         (TestWebKitAPI::TEST):
1156
1157 2015-08-18  Anders Carlsson  <andersca@apple.com>
1158
1159         Fix test failure fallout from r188602 by using a V5 page ui client struct.
1160
1161         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1162         (TestWebKitAPI::setUpClients):
1163
1164 2015-08-18  Brian Burg  <bburg@apple.com>
1165
1166         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1167         https://bugs.webkit.org/show_bug.cgi?id=147955
1168
1169         Reviewed by Timothy Hatcher.
1170
1171         To enable sharing of common test code between protocol and model tests,
1172         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1173
1174         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1175         protocol-test.js uses to load the inspector frontend stub into its iframe
1176         from an arbitrary local file URL.
1177
1178         * DumpRenderTree/TestRunner.cpp:
1179         (getInspectorTestStubURLCallback):
1180         (TestRunner::staticValues):
1181         * DumpRenderTree/TestRunner.h:
1182         * DumpRenderTree/mac/TestRunnerMac.mm:
1183         (SOFT_LINK_STAGED_FRAMEWORK):
1184         (TestRunner::inspectorTestStubURL):
1185         * DumpRenderTree/win/TestRunnerWin.cpp:
1186         (TestRunner::inspectorTestStubURL):
1187         * WebKitTestRunner/Configurations/Base.xcconfig:
1188         Since WebKitTestRunner now includes WebCore private headers, also search
1189         for the WebCore framework inside the WebKit umbrella framework.
1190
1191         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1192         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1193         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1194         (WTR::TestRunner::inspectorTestStubURL):
1195         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1196         (WTR::TestRunner::inspectorTestStubURL):
1197         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1198         (WTR::TestRunner::inspectorTestStubURL):
1199
1200 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
1201
1202         Unreviewed, fix GTK build.
1203
1204         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1205         (TestWebKitAPI::TEST):
1206
1207 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
1208
1209         Replace all remaining uses of WTF::Mutex with WTF::Lock
1210         https://bugs.webkit.org/show_bug.cgi?id=148089
1211
1212         Reviewed by Geoffrey Garen.
1213
1214         * DumpRenderTree/JavaScriptThreading.cpp:
1215         (javaScriptThreadsMutex):
1216         (runJavaScriptThread):
1217         (startJavaScriptThreads):
1218         (stopJavaScriptThreads):
1219         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
1220         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1221         (TestWebKitAPI::TEST):
1222         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1223         (TestWebKitAPI::TEST):
1224
1225 2015-08-17  Commit Queue  <commit-queue@webkit.org>
1226
1227         Unreviewed, rolling out r188539, r188544, r188552, and
1228         r188564.
1229         https://bugs.webkit.org/show_bug.cgi?id=148122
1230
1231         Broke tests and some build styles (Requested by ap on
1232         #webkit).
1233
1234         Reverted changesets:
1235
1236         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
1237         bundle"
1238         https://bugs.webkit.org/show_bug.cgi?id=147955
1239         http://trac.webkit.org/changeset/188539
1240
1241         "Web Inspector: split TestStub.js into multiple files and
1242         modernize it"
1243         https://bugs.webkit.org/show_bug.cgi?id=148077
1244         http://trac.webkit.org/changeset/188544
1245
1246         "Web Inspector: InspectorTest should be a subclass of
1247         TestHarness"
1248         https://bugs.webkit.org/show_bug.cgi?id=148079
1249         http://trac.webkit.org/changeset/188552
1250
1251         "Unreviewed internal build fix attempt after r188539."
1252         http://trac.webkit.org/changeset/188564
1253
1254 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1255
1256         [OS X] Remove support for composite fonts
1257         https://bugs.webkit.org/show_bug.cgi?id=147920
1258
1259         Reviewed by Dan Bernstein.
1260
1261         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1262         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
1263         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1264         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1265         * DumpRenderTree/mac/DumpRenderTree.mm:
1266         (allowedFontFamilySet): Deleted.
1267         (activateTestingFonts): Deleted.
1268         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1269         (WTR::allowedFontFamilySet): Deleted.
1270         (WTR::activateFonts): Deleted.
1271         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1272         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
1273         * WebKitTestRunner/mac/TestControllerMac.mm:
1274         (WTR::allowedFontFamilySet): Deleted.
1275
1276 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
1277
1278         Unreviewed internal build fix attempt after r188539.
1279
1280         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1281
1282 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1283
1284         Fix the build
1285
1286         Unreviewed.
1287
1288         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1289
1290 2015-08-17  Alex Christensen  <achristensen@webkit.org>
1291
1292         Build Debug Suffix on Windows with CMake
1293         https://bugs.webkit.org/show_bug.cgi?id=148083
1294
1295         Reviewed by Brent Fulgham.
1296
1297         * TestWebKitAPI/CMakeLists.txt:
1298         * TestWebKitAPI/PlatformWin.cmake:
1299         Add DEBUG_SUFFIX
1300
1301 2015-08-17  Anders Carlsson  <andersca@apple.com>
1302
1303         Simplify how PlatformWebViews are created when view options change
1304         https://bugs.webkit.org/show_bug.cgi?id=148093
1305
1306         Reviewed by Sam Weinig.
1307
1308         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
1309
1310         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
1311         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
1312         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
1313
1314         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
1315
1316         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
1317         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
1318
1319         * WebKitTestRunner/TestController.cpp:
1320         (WTR::TestController::ensureViewSupportsOptionsForTest):
1321         (WTR::shouldUseFixedLayout):
1322         (WTR::TestController::viewOptionsForTest):
1323         (WTR::TestController::updateWebViewSizeForTest):
1324         (WTR::TestController::updateWindowScaleForTest):
1325         (WTR::TestController::configureViewForTest):
1326         (WTR::TestController::initialize): Deleted.
1327         (WTR::TestController::ensureViewSupportsOptions): Deleted.
1328         (WTR::TestController::updateLayoutTypeForTest): Deleted.
1329         (WTR::TestController::platformConfigureViewForTest): Deleted.
1330         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
1331         (WTR::TestController::run): Deleted.
1332         * WebKitTestRunner/TestController.h:
1333         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1334         (WTR::shouldUseFixedLayout):
1335         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1336         (WTR::TestController::platformConfigureViewForTest):
1337         (WTR::TestController::platformResetPreferencesToConsistentValues):
1338         * WebKitTestRunner/ios/TestControllerIOS.mm:
1339         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1340         * WebKitTestRunner/mac/TestControllerMac.mm:
1341         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1342         (WTR::TestController::platformConfigureViewForTest):
1343
1344 2015-08-17  Sam Weinig  <sam@webkit.org>
1345
1346         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
1347         https://bugs.webkit.org/show_bug.cgi?id=148097
1348
1349         Reviewed by Anders Carlsson.
1350
1351         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
1352         Add tests for WebsiteDataStores in the WKPageConfiguration.
1353
1354 2015-08-17  Brian Burg  <bburg@apple.com>
1355
1356         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1357         https://bugs.webkit.org/show_bug.cgi?id=147955
1358
1359         Reviewed by Timothy Hatcher.
1360
1361         To enable sharing of common test code between protocol and model tests,
1362         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1363
1364         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1365         protocol-test.js uses to load the inspector frontend stub into its iframe
1366         from an arbitrary local file URL.
1367
1368         * DumpRenderTree/TestRunner.cpp:
1369         (getInspectorTestStubURLCallback):
1370         (TestRunner::staticValues):
1371         * DumpRenderTree/TestRunner.h:
1372         * DumpRenderTree/mac/TestRunnerMac.mm:
1373         (SOFT_LINK_STAGED_FRAMEWORK):
1374         (TestRunner::inspectorTestStubURL):
1375         * DumpRenderTree/win/TestRunnerWin.cpp:
1376         (TestRunner::inspectorTestStubURL):
1377         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1378         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1379         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1380         (WTR::TestRunner::inspectorTestStubURL):
1381         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1382         (WTR::TestRunner::inspectorTestStubURL):
1383         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1384         (WTR::TestRunner::inspectorTestStubURL):
1385
1386 2015-08-17  Saam barati  <sbarati@apple.com>
1387
1388         Change email address from saambarati1@gmail.com to sbarati@apple.com
1389
1390         * Scripts/webkitpy/common/config/contributors.json:
1391
1392 2015-08-17  Jason Marcell  <jmarcell@apple.com>
1393
1394         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
1395         repositories other than "openSource" and "internal".
1396         https://bugs.webkit.org/show_bug.cgi?id=147961
1397
1398         Reviewed by Daniel Bates.
1399
1400         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1401         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
1402         generically with repositories other than "openSource" and "internal".
1403
1404 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
1405
1406         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
1407         https://bugs.webkit.org/show_bug.cgi?id=148081
1408
1409         Reviewed by Tim Horton.
1410
1411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1412         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1413
1414 2015-08-11  Andy Estes  <aestes@apple.com>
1415
1416         [Cocoa] Add redirect support to CustomProtocolManager
1417         https://bugs.webkit.org/show_bug.cgi?id=147871
1418
1419         Reviewed by Dan Bernstein.
1420
1421         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
1422
1423         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1424         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
1425         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
1426         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1427         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
1428         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
1429         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
1430         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
1431         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
1432         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1433         (TestWebKitAPI::TEST): Unregistered TestProtocol.
1434         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
1435         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
1436         (-[TestProtocol startLoading]): Taught to handle redirect responses.
1437
1438 2015-08-13  Andy Estes  <aestes@apple.com>
1439
1440         [Cocoa] Downloads do not start if policy decision is made asynchronously
1441         https://bugs.webkit.org/show_bug.cgi?id=147985
1442
1443         Reviewed by Brady Eidson.
1444
1445         Added a new API test.
1446
1447         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1448         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1449         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
1450         (TEST):
1451
1452 2015-08-14  Commit Queue  <commit-queue@webkit.org>
1453
1454         Unreviewed, rolling out r187357.
1455         https://bugs.webkit.org/show_bug.cgi?id=148032
1456
1457         webkit-patch generates incorrect patches that cannot be
1458         applied (Requested by dydz on #webkit).
1459
1460         Reverted changeset:
1461
1462         "Call fixChangeLogPatch when generating patches from webkit-
1463         patch"
1464         https://bugs.webkit.org/show_bug.cgi?id=147248
1465         http://trac.webkit.org/changeset/187357
1466
1467 2015-08-14  Jason Marcell  <jmarcell@apple.com>
1468
1469         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
1470         other than "openSource" and "internal".
1471         https://bugs.webkit.org/show_bug.cgi?id=147938
1472
1473         Reviewed by Daniel Bates.
1474
1475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1476         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
1477         repositories other than "openSource" and "internal".
1478
1479 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
1480
1481         Unreviewed, shorten another test that is timing out.
1482
1483         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1484         (TestWebKitAPI::TEST):
1485
1486 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
1487
1488         AppScale: Assertion hit when hovering a webkit-queue bubble
1489         https://bugs.webkit.org/show_bug.cgi?id=147997
1490
1491         Reviewed by Alexey Proskuryakov.
1492
1493         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1494         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
1495
1496 2015-08-13  Lucas Forschler  <lforschler@apple.com>
1497
1498         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
1499         
1500         Unreviewed.
1501         
1502         * Scripts/copy-webkitlibraries-to-product-directory:
1503
1504 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
1505
1506         Run benchmark customized Dromaeo should not assume there is an internet connection.
1507         https://bugs.webkit.org/show_bug.cgi?id=147995
1508
1509         Reviewed by Ryosuke Niwa.
1510
1511         Add several dependency js libs to local.
1512
1513         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
1514
1515 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1516
1517         WTF should have a compact Condition object to use with Lock
1518         https://bugs.webkit.org/show_bug.cgi?id=147986
1519
1520         Reviewed by Geoffrey Garen.
1521
1522         Add a test for WTF::Condition.
1523
1524         * TestWebKitAPI/CMakeLists.txt:
1525         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1526         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1527         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
1528         (TestWebKitAPI::TEST):
1529         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1530         (TestWebKitAPI::runLockTest): Change the name of the thread.
1531
1532 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1533
1534         Unreviewed, shorten another test. It's timing out in debug on some bot.
1535
1536         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1537         (TestWebKitAPI::TEST):
1538
1539 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
1540
1541         WTF::Lock should not suffer from the thundering herd
1542         https://bugs.webkit.org/show_bug.cgi?id=147947
1543
1544         Reviewed by Geoffrey Garen.
1545
1546         Add testing that checks that locks return to a pristine state after contention is over.
1547
1548         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1549         (TestWebKitAPI::LockInspector::isFullyReset):
1550         (TestWebKitAPI::runLockTest):
1551         (TestWebKitAPI::TEST):
1552
1553 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
1554
1555         Benchmarks supported by run_benchmark script should not assume we have internet access.
1556         https://bugs.webkit.org/show_bug.cgi?id=147959
1557
1558         Reviewed by Ryosuke Niwa.
1559
1560         For JSBench we should not request jquery.min.js from google through the internet.
1561
1562         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
1563
1564 2015-08-12  Jason Marcell  <jmarcell@apple.com>
1565
1566         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
1567         other than "openSource" and "internal".
1568         https://bugs.webkit.org/show_bug.cgi?id=147796
1569
1570         Reviewed by Daniel Bates.
1571
1572         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1573         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
1574         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
1575         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
1576         and another assertion that, if the previousIteration is non-null, the given repository is in
1577         previousIteration.revision.
1578         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
1579         with repositories other than "openSource" and "internal". Also added an assertion that the returned
1580         fragment has at least one child node.
1581
1582 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
1583
1584         Add a tool that dumps class and struct member layout, showing padding
1585         https://bugs.webkit.org/show_bug.cgi?id=147898
1586
1587         Reviewed by Zalan Bujtas.
1588         
1589         This 'dump-class-layout' script uses the lldb Python bindings to collect data
1590         about data member layout, and displays it.
1591         
1592         Sample output:
1593
1594               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
1595               +0 < 56>     WebCore::URL m_value;
1596               +0 <  8>         WTF::String m_string;
1597               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
1598               +0 <  8>                 WTF::StringImpl * m_ptr;
1599               +8 <  1>         bool:1 m_isValid;
1600               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
1601               +9 <  3>         <PADDING>
1602              +12 <  4>         int m_schemeEnd;
1603              +16 <  4>         int m_userStart;
1604              +20 <  4>         int m_userEnd;
1605              +24 <  4>         int m_passwordEnd;
1606              +28 <  4>         int m_hostEnd;
1607              +32 <  4>         int m_portEnd;
1608              +36 <  4>         int m_pathAfterLastSlash;
1609              +40 <  4>         int m_pathEnd;
1610              +44 <  4>         int m_queryEnd;
1611              +48 <  4>         int m_fragmentEnd;
1612              +52 <  4>         <PADDING>
1613              +52 <  4>     <PADDING>
1614              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
1615              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
1616             Total byte size: 72
1617             Total pad bytes: 11
1618             Padding percentage: 15.28 %
1619
1620         * Scripts/dump-class-layout: Added.
1621         (webkit_build_dir):
1622         (developer_dir):
1623         (import_lldb):
1624         (find_build_directory):
1625         (verify_type):
1626         (verify_type_recursive):
1627         (dump_class):
1628         (main):
1629         (main.or):
1630
1631 2015-08-12  Alex Christensen  <achristensen@webkit.org>
1632
1633         Fix Debug CMake builds on Windows
1634         https://bugs.webkit.org/show_bug.cgi?id=147940
1635
1636         Reviewed by Chris Dumez.
1637
1638         * DumpRenderTree/PlatformWin.cmake:
1639         * TestWebKitAPI/PlatformWin.cmake:
1640         The BitmapImage test is not enabled on the AppleWin port.
1641         * WinLauncher/CMakeLists.txt:
1642         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
1643
1644 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1645
1646         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
1647
1648         In r188125 I added a way to mark tests as slow to use a longer
1649         timeout. But it seems it was not enough for
1650         WTF_Lock.ContendedShortSection, so let's try again with a longer
1651         timeout now.
1652
1653         * Scripts/run-gtk-tests:
1654         (TestRunner._run_google_test):
1655
1656 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1657
1658         Allow --debug option in run-jsc
1659         https://bugs.webkit.org/show_bug.cgi?id=147923
1660
1661         Reviewed by Csaba Osztrogonác.
1662
1663         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
1664
1665         * Scripts/run-jsc:
1666
1667 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1668
1669         Fix test after build fix in r188286.
1670         https://bugs.webkit.org/show_bug.cgi?id=147907
1671
1672         Reviewed by Anders Carlsson.
1673
1674         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1675         sleep_for can now be used, but we need to include <thread>
1676
1677 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1678
1679         Always use a byte-sized lock implementation
1680         https://bugs.webkit.org/show_bug.cgi?id=147908
1681
1682         Reviewed by Geoffrey Garen.
1683
1684         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
1685         now tests of Lock.
1686
1687         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1688         (TestWebKitAPI::runLockTest):
1689         (TestWebKitAPI::TEST):
1690
1691 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
1692
1693         Make ASan build not depend on asan.xcconfig
1694         https://bugs.webkit.org/show_bug.cgi?id=147840
1695         rdar://problem/21093702
1696
1697         Reviewed by Daniel Bates.
1698
1699         * asan/asan.xcconfig:
1700         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
1701         are now marked in source code.
1702
1703 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1704
1705         Unreviewed, shorten another test since it timed out.
1706
1707         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1708         (TestWebKitAPI::TEST):
1709
1710 2015-08-11  Mark Lam  <mark.lam@apple.com>
1711
1712         Fix names of Lock tests: should be "Contended", not "Contented".
1713         https://bugs.webkit.org/show_bug.cgi?id=147905
1714
1715         Reviewed by Saam Barati.
1716
1717         We're testing the behavior of lock contention (i.e. when threads contend), not
1718         whether the locks are happy (contented).
1719
1720         * Scripts/run-gtk-tests:
1721         (TestRunner):
1722         (TestRunner.__init__): Deleted.
1723         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1724         (TestWebKitAPI::runLockTest):
1725         (TestWebKitAPI::TEST):
1726
1727 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1728
1729         Update WinCairoRequirements to VS2015.
1730
1731         * Scripts/update-webkit-wincairo-libs:
1732         Update WinCairoRequirements location.
1733
1734 2015-08-11  Jason Marcell  <jmarcell@apple.com>
1735
1736         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
1737         for internalTrac.
1738         https://bugs.webkit.org/show_bug.cgi?id=147805
1739
1740         Reviewed by Daniel Bates.
1741
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1743         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
1744         Dashboard.Repository.Internal.trac for internalTrac.
1745         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
1746         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
1747         respectively.
1748         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
1749         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
1750         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
1751         internalTrac.
1752         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
1753         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
1754         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1755         (Analyzer): Ditto.
1756         (Analyzer.prototype.analyze): Ditto.
1757
1758 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1759
1760         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
1761
1762         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1763         (TestWebKitAPI::TEST):
1764
1765 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
1766
1767         [Win] Switch Windows build to Visual Studio 2015
1768         https://bugs.webkit.org/show_bug.cgi?id=147887
1769         <rdar://problem/22235098>
1770
1771         Reviewed by Alex Christensen.
1772
1773         Update Visual Studio project file settings to use the current Visual
1774         Studio and compiler. Continue targeting binaries to run on our minimum
1775         supported configuration of Windows 7.
1776
1777         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1778         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1779         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1780         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1781         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1782         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
1783         prefer the newer MSBuild included in Visual Studio 2015.
1784         (visualStudioInstallDir):
1785         (msBuildInstallDir):
1786         (visualStudioVersion):
1787         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1788         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1789         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1790         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1791         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1792         * win/record-memory/record-memory.vcxproj:
1793
1794 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1795
1796         Another speculative build fix after r188280.
1797
1798         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1799         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
1800         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
1801
1802 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1803
1804         Unreviewed build fix after r188280.
1805
1806         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1807         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
1808
1809 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
1810
1811         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
1812         https://bugs.webkit.org/show_bug.cgi?id=147665
1813
1814         Reviewed by Mark Lam.
1815
1816         * TestWebKitAPI/CMakeLists.txt:
1817         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1819         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1820         (TestWebKitAPI::TEST):
1821         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
1822         (TestWebKitAPI::TEST):
1823
1824 2015-08-11  Brian Burg  <bburg@apple.com>
1825
1826         webkit-patch should not explode when $EDITOR is set incorrectly
1827         https://bugs.webkit.org/show_bug.cgi?id=147884
1828
1829         Reviewed by Darin Adler.
1830
1831         If $EDITOR doesn't exist, log a warning and continue.
1832
1833         * Scripts/webkitpy/common/system/user.py: 
1834         (User.edit):
1835         (User.edit_changelog):
1836
1837 2015-08-11  Dan Bernstein  <mitz@apple.com>
1838
1839         Reverted r188255, because it turned out that delegates do nonot need this information.
1840
1841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1842         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
1843
1844 2015-08-11  Dan Bernstein  <mitz@apple.com>
1845
1846         [Cocoa] The UI delegate can't tell if printing was user-initiated
1847         https://bugs.webkit.org/show_bug.cgi?id=147869
1848
1849         Reviewed by Sam Weinig.
1850
1851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1852         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
1853         (-[PrintFrameController webView:didFinishNavigation:]):
1854         (-[PrintFrameController _webView:printFrame:userInitiated:]):
1855         (TEST):
1856
1857 2015-08-10  Alex Christensen  <achristensen@webkit.org>
1858
1859         Another build fix after r188239.
1860
1861         * TestWebKitAPI/PlatformWin.cmake:
1862         Link with more libraries.
1863         * WinLauncher/CMakeLists.txt:
1864         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
1865
1866 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
1867
1868         Build fix after r188237.
1869
1870         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1871         (BenchmarkBuilder.__enter__):
1872
1873 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
1874
1875         Update ReadMe and correct the way to use abstract abstract class.
1876         https://bugs.webkit.org/show_bug.cgi?id=147860
1877
1878         Reviewed by Ryosuke Niwa.
1879
1880         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
1881         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
1882
1883         * Scripts/webkitpy/benchmark_runner/README.md:
1884         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1885         (BrowserDriver):
1886         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1887         (OSXBrowserDriver.restore_env):
1888         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1889         (HTTPServerDriver):
1890         (HTTPServerDriver.set_device_id):
1891         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1892         (SimpleHTTPServerDriver.get_return_code):
1893         (SimpleHTTPServerDriver):
1894         (SimpleHTTPServerDriver.set_device_id):
1895
1896 2015-08-10  Alex Christensen  <achristensen@webkit.org>
1897
1898         Build TestWebKitAPI with CMake on Windows
1899         https://bugs.webkit.org/show_bug.cgi?id=147851
1900
1901         Reviewed by Chris Dumez.
1902
1903         * CMakeLists.txt:
1904         * TestWebKitAPI/CMakeLists.txt:
1905         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
1906         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
1907         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
1908         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
1909         * TestWebKitAPI/PlatformEfl.cmake:
1910         * TestWebKitAPI/PlatformGTK.cmake:
1911         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
1912         I did this without changing the directory structure of the existing EFL and GTK builds.
1913         * TestWebKitAPI/PlatformWin.cmake: Added.
1914         * TestWebKitAPI/win/main.cpp:
1915         (main):
1916         (dllLauncherEntryPoint):
1917         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
1918         * WinLauncher/CMakeLists.txt:
1919         AppleWin port needs /NODEFAULTLIB:MSVCRT.
1920
1921 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
1922
1923         Make cleanup more robust and minor code cleaning in run benchmark script.
1924         https://bugs.webkit.org/show_bug.cgi?id=147800
1925
1926         Reviewed by Ryosuke Niwa.
1927
1928         Use 'finnaly' block to make sure cleanup code is always executed.
1929
1930         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1931         (built_benchmark):
1932         (built_benchmark.__init__):
1933         (built_benchmark.__enter__):
1934         (built_benchmark.__exit__):
1935         (test_environment):
1936         (test_environment.__init__):
1937         (test_environment.__enter__):
1938         (test_environment.__exit__):
1939         (BenchmarkRunner.__init__):
1940         (BenchmarkRunner.execute):
1941         (BenchmarkRunner._dump):
1942         (BenchmarkRunner._wrap):
1943         (BenchmarkRunner): Deleted.
1944         (BenchmarkRunner._cleanup): Deleted.
1945         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1946         (BrowserDriver.close_browsers):
1947         (BrowserDriver):
1948         (BrowserDriver.restore_env):
1949         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1950         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
1951
1952 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1953
1954         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
1955         https://bugs.webkit.org/show_bug.cgi?id=146414
1956
1957         Reviewed by Darin Adler.
1958
1959         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1960         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
1961
1962 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1963
1964         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
1965         https://bugs.webkit.org/show_bug.cgi?id=147727
1966
1967         Reviewed by Sergio Villar Senin.
1968
1969         I think it was not this test in particular, but
1970         /webkit2/WebKitWebView/custom-charset that is affecting the
1971         others. This is because changing the encoding reloads the page,
1972         but we don't wait for the page to be reloaded, so when the test
1973         finishes and other test starts the web process is still reloading
1974         the page.
1975
1976         * Scripts/run-gtk-tests:
1977         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
1978         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1979         (testWebViewCustomCharset): Wait until page is reloaded after
1980         changing the charset.
1981
1982 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1983
1984         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
1985
1986         It's timing out in the bots. My guess is that there's no installer
1987         installed in the bots and gst_install_plugins_supported() returns
1988         false, so we don't even get a permission request because no
1989         installer will be launched.
1990
1991         * Scripts/run-gtk-tests:
1992         (TestRunner):
1993
1994 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1995
1996         [GTK] Another build fix after r188157.
1997
1998         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1999         (WTR::PlatformWebView::viewSupportsOptions):
2000         Name all the things correctly!
2001
2002 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2003
2004         [EFL, GTK] Build fix after r188176.
2005
2006         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2007         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
2008
2009 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2010
2011         [GTK] Speculative build fix after r188157.
2012
2013         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2014         (WTR::PlatformWebView::PlatformWebView):
2015         Update parameter list.
2016
2017 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2018
2019         Build more testing binaries with CMake on Windows
2020         https://bugs.webkit.org/show_bug.cgi?id=147799
2021
2022         Reviewed by Brent Fulgham.
2023
2024         * DumpRenderTree/CMakeLists.txt:
2025         Build TestNetscapePlugin.
2026         * DumpRenderTree/PlatformWin.cmake:
2027         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
2028         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
2029         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
2030         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
2031         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
2032         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
2033         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
2034         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
2035         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
2036
2037 2015-08-07  Jason Marcell  <jmarcell@apple.com>
2038
2039         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
2040         https://bugs.webkit.org/show_bug.cgi?id=147667
2041
2042         Reviewed by Daniel Bates.
2043
2044         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2045         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
2046         other than "openSource" and "internal".
2047         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2048         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2049         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
2050         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
2051         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2052         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2053         (sortedPlatforms): Deleted.
2054         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2055         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2056         (sortedPlatforms): Deleted.
2057         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2058         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
2059         and sorts them by this property returning the new sorted array.
2060
2061 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
2062
2063         Lightweight locks should be adaptive
2064         https://bugs.webkit.org/show_bug.cgi?id=147545
2065
2066         Reviewed by Geoffrey Garen.
2067
2068         * TestWebKitAPI/CMakeLists.txt:
2069         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2071         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
2072         (TestWebKitAPI::runLockTest):
2073         (TestWebKitAPI::TEST):
2074
2075 2015-08-07  Anders Carlsson  <andersca@apple.com>
2076
2077         Fix a tyop.
2078
2079         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2080         (WTR::PlatformWebView::viewSupportsOptions):
2081
2082 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
2083
2084         Update AppEngine app version numbers to the latest commit.
2085
2086         * QueueStatusServer/app.yaml:
2087         * TestResultServer/app.yaml:
2088
2089 2015-08-07  Anders Carlsson  <andersca@apple.com>
2090
2091         Simplify WKTR's view options
2092         https://bugs.webkit.org/show_bug.cgi?id=147791
2093
2094         Reviewed by Sam Weinig.
2095
2096         Instead of using a WKDictionaryRef, just use a struct for the options.
2097
2098         * WebKitTestRunner/PlatformWebView.h:
2099         (WTR::PlatformWebView::options):
2100         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2101         * WebKitTestRunner/TestController.cpp:
2102         (WTR::TestController::initialize):
2103         (WTR::TestController::createWebViewWithOptions):
2104         (WTR::TestController::ensureViewSupportsOptions):
2105         (WTR::TestController::updateLayoutTypeForTest):
2106         * WebKitTestRunner/TestController.h:
2107         * WebKitTestRunner/ViewOptions.h: Added.
2108         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2109         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2110         (WTR::PlatformWebView::PlatformWebView):
2111         (WTR::PlatformWebView::viewSupportsOptions):
2112         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2113         (WTR::PlatformWebView::viewSupportsOptions):
2114         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2115         (WTR::PlatformWebView::viewSupportsOptions):
2116         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2117         (WTR::PlatformWebView::PlatformWebView):
2118         (WTR::PlatformWebView::viewSupportsOptions):
2119         * WebKitTestRunner/mac/TestControllerMac.mm:
2120         (WTR::TestController::platformConfigureViewForTest):
2121
2122 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
2123
2124         Running tests for a long time results in some tests running very slowly (throttling)
2125         https://bugs.webkit.org/show_bug.cgi?id=147718
2126
2127         Reviewed by Chris Dumez.
2128
2129         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
2130         Although COCOA ports default this setting to be disabled in WebKit1,
2131         we should make both test harnesses disable the setting for consistency.
2132
2133         * DumpRenderTree/mac/DumpRenderTree.mm:
2134         (resetWebPreferencesToConsistentValues):
2135
2136 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2137
2138         Use a specific version of Speedometer in run-benchmark
2139         https://bugs.webkit.org/show_bug.cgi?id=147769
2140
2141         Reviewed by Chris Dumez.
2142
2143         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
2144
2145         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2146
2147 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2148
2149         twisted_http_server.py should support --port
2150         https://bugs.webkit.org/show_bug.cgi?id=147771
2151
2152         Reviewed by Chris Dumez.
2153
2154         Added the option. This makes the script more useful on its own.
2155
2156         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2157
2158 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2159
2160         [GTK] WTF unit tests are timing out in the bots
2161         https://bugs.webkit.org/show_bug.cgi?id=147777
2162
2163         Reviewed by Filip Pizlo.
2164
2165         Add a way to mark google unit tests as slow and add
2166         WTF_Lock.ContentedShortSection to the list. In case of slow test
2167         we use the double of the given timeout for that particular test.
2168
2169         * Scripts/run-gtk-tests:
2170         (TestRunner):
2171         (TestRunner._run_google_test):
2172
2173 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2174
2175         [GTK] run-gtk-tests should not stop when a google test case fails
2176         https://bugs.webkit.org/show_bug.cgi?id=147778
2177
2178         Reviewed by Philippe Normand.
2179
2180         For glib based tests we run the test runner with the -k option,
2181         but for google tests we are aborting as soon as we find a failure.
2182
2183         * Scripts/run-gtk-tests:
2184         (TestRunner._run_google_test_suite): Use a global return code that
2185         is set to 1 when any test has failed.
2186
2187 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2188
2189         [GStreamer] Do not automatically show PackageKit codec installation notifications
2190         https://bugs.webkit.org/show_bug.cgi?id=135973
2191
2192         Reviewed by Philippe Normand.
2193
2194         Handle the missing media plugins installation permission request
2195         in MiniBrowser and add a test case for the new API.
2196
2197         * MiniBrowser/gtk/BrowserWindow.c:
2198         (webViewDecidePermissionRequest):
2199         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2200         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2201         (permissionRequestCallback):
2202         (testInstallMissingPluginsPermissionRequest):
2203         (beforeAll):
2204         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2205         (methodCallCallback):
2206
2207 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
2208
2209         Running tests for a long time results in some tests running very slowly (throttling)
2210         https://bugs.webkit.org/show_bug.cgi?id=147718
2211
2212         Reviewed by Alexey Proskuryakov.
2213
2214         * WebKitTestRunner/TestController.cpp:
2215         (WTR::TestController::resetPreferencesToConsistentValues):
2216         Ensure throttling settings are disabled for tests for all ports, as
2217         COCOA ports default to having these setting enabled. Note, there is
2218         still other timer throttling not covered by these setting.
2219
2220 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2221
2222         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
2223         https://bugs.webkit.org/show_bug.cgi?id=147752
2224
2225         Reviewed by Chris Dumez.
2226
2227         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
2228
2229         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
2230         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
2231
2232         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
2233         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
2234         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
2235         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
2236         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
2237         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2238         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
2239         HTTPServerDriverFactory taking the platform name as an argument.
2240         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
2241         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
2242         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
2243         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2244         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
2245         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
2246         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
2247         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2248         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
2249         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
2250         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
2251         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
2252         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2253         (HTTPServerDriver): Replaced name by platforms.
2254         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2255         (SimpleHTTPServerDriver): Ditto.
2256         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2257         (parse_args): Removed --http-server-driver option.
2258         (start): Ditto.
2259
2260 2015-08-06  Chris Dumez  <cdumez@apple.com>
2261
2262         Toggle GPS state based on page visibility to save battery
2263         https://bugs.webkit.org/show_bug.cgi?id=147685
2264
2265         Reviewed by Benjamin Poulain.
2266
2267         Add testRunner.isGeolocationProviderActive() test support function.
2268
2269         * DumpRenderTree/TestRunner.cpp:
2270         (isGeolocationProviderActiveCallback):
2271         (TestRunner::staticFunctions):
2272         * DumpRenderTree/TestRunner.h:
2273         * DumpRenderTree/mac/MockGeolocationProvider.h:
2274         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2275         (-[MockGeolocationProvider isActive]):
2276         * DumpRenderTree/mac/TestRunnerMac.mm:
2277         (TestRunner::isGeolocationProviderActive):
2278         * DumpRenderTree/win/TestRunnerWin.cpp:
2279         (TestRunner::isGeolocationProviderActive):
2280         * WebKitTestRunner/GeolocationProviderMock.h:
2281         (WTR::GeolocationProviderMock::isActive):
2282         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2283         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2284         (WTR::InjectedBundle::isGeolocationProviderActive):
2285         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2286         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2287         (WTR::TestRunner::isGeolocationProviderActive):
2288         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2289         * WebKitTestRunner/TestController.cpp:
2290         (WTR::TestController::isGeolocationProviderActive):
2291         * WebKitTestRunner/TestController.h:
2292         * WebKitTestRunner/TestInvocation.cpp:
2293         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2294
2295 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2296
2297         Automate JSBench with run-benchmark
2298         https://bugs.webkit.org/show_bug.cgi?id=147716
2299
2300         Reviewed by Chris Dumez.
2301
2302         Added JSBench plan to run-benchmark.
2303
2304         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2305         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
2306         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
2307         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
2308         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
2309         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
2310         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
2311         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
2312         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
2313         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
2314         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
2315         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2316         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
2317         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
2318         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
2319         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2320
2321 2015-08-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2322
2323         Pass-through the undefined options in run-jsc
2324         https://bugs.webkit.org/show_bug.cgi?id=147717
2325
2326         Undefined options in run-jsc is just passed to the actual jsc shell.
2327         We can execute `Tools/Scripts/run-jsc -d`.
2328
2329         Reviewed by Csaba Osztrogonác.
2330
2331         * Scripts/run-jsc:
2332
2333 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2334
2335         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
2336
2337         It's flaky.
2338
2339         * Scripts/run-gtk-tests:
2340         (TestRunner):
2341
2342 2015-08-06  Csaba Osztrogonác  <ossy@webkit.org>
2343
2344         [EFL] Bump EFL version to 1.15.0
2345         https://bugs.webkit.org/show_bug.cgi?id=147450
2346
2347         Reviewed by Gyuyoung Kim.
2348
2349         * efl/jhbuild.modules:
2350
2351 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2352
2353         Unreviewed. Unksip TestContextMenu GTK+ API test.
2354
2355         This has been skipped for a long time, and it's very
2356         unconvenient. It has never failed for me locally, so let's try
2357         again to see if it works in the bots. I'll skip it again if it
2358         keeps failing.
2359
2360         * Scripts/run-gtk-tests:
2361         (TestRunner):
2362
2363 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
2364
2365         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
2366
2367         * DumpRenderTree/JavaScriptThreading.cpp:
2368         (javaScriptThreadsMutex):
2369         (runJavaScriptThread):
2370         (startJavaScriptThreads):
2371         (stopJavaScriptThreads):
2372         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2373         (TestWebKitAPI::TEST):
2374         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2375         (TestWebKitAPI::TEST):
2376
2377 2015-08-05  Alex Christensen  <achristensen@webkit.org>
2378
2379         Build DumpRenderTree with CMake.
2380         https://bugs.webkit.org/show_bug.cgi?id=147519
2381
2382         Reviewed by Brent Fulgham.
2383
2384         * CMakeLists.txt:
2385         Build the DumpRenderTree directory now that it builds successfully.
2386         * DumpRenderTree/CMakeLists.txt:
2387         Added missing source file and don't link with WebCore.lib.
2388         * DumpRenderTree/PlatformWin.cmake:
2389         Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp. 
2390         * WinLauncher/CMakeLists.txt:
2391         We need libcmt now that we are not linking with WebCore.lib.
2392
2393 2015-08-05  Alexey Proskuryakov  <ap@apple.com>
2394
2395         AppScale: Use https URLs for subresources and links
2396         https://bugs.webkit.org/show_bug.cgi?id=147686
2397
2398         Reviewed by Ryosuke Niwa.
2399
2400         * QueueStatusServer/filters/webkit_extras.py:
2401         * TestResultServer/static-dashboards/dashboard_base.js:
2402         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2403         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2404         * TestResultServer/static-dashboards/treemap.js:
2405         * TestResultServer/static-dashboards/ui.js:
2406
2407 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
2408
2409         Rename Mutex to DeprecatedMutex
2410         https://bugs.webkit.org/show_bug.cgi?id=147675
2411
2412         Reviewed by Geoffrey Garen.
2413
2414         * DumpRenderTree/JavaScriptThreading.cpp:
2415         (javaScriptThreadsMutex):
2416         (runJavaScriptThread):
2417         (startJavaScriptThreads):
2418         (stopJavaScriptThreads):
2419         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2420         (TestWebKitAPI::TEST):
2421         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2422         (TestWebKitAPI::TEST):
2423
2424 2015-08-05  Timothy Hatcher  <timothy@apple.com>
2425
2426         Update the WebKit nightly icon
2427         https://bugs.webkit.org/show_bug.cgi?id=147684
2428
2429         Reviewed by Sam Weinig.
2430
2431         * WebKitLauncher/webkit.icns: Replaced.
2432
2433 2015-08-05  Daniel Bates  <dabates@apple.com>
2434
2435         REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
2436         https://bugs.webkit.org/show_bug.cgi?id=147678
2437         <rdar://problem/21827815>
2438
2439         Reviewed by Brady Eidson.
2440
2441         Add a test to ensure that we restore the "should open external URLs" policy on
2442         page reload after the web content process crashes.
2443
2444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2445         * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
2446         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2447         (TEST):
2448
2449 2015-08-04  Hunseop Jeong  <hs85.jeong@samsung.com>
2450
2451         [EFL] Editing tests have been broken since r186694
2452         https://bugs.webkit.org/show_bug.cgi?id=146888
2453
2454         Reviewed by Brent Fulgham.
2455
2456         Restored some codes for the context click on GTK+ and EFL port.
2457
2458         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2459         (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
2460
2461 2015-08-04  Dewei Zhu  <dewei_zhu@apple.com>
2462
2463         Install twisted package for http server when necessary.
2464         https://bugs.webkit.org/show_bug.cgi?id=147082
2465
2466         Reviewed by Ryosuke Niwa.
2467
2468         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2469         * Scripts/webkitpy/thirdparty/__init__.py:
2470         (AutoinstallImportHook.find_module):
2471         (AutoinstallImportHook._install_twisted):
2472
2473 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2474
2475         [Win] Update Apple Windows build for VS2015
2476         https://bugs.webkit.org/show_bug.cgi?id=147653
2477
2478         Reviewed by Dean Jackson.
2479
2480         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with
2481         something older than VS2015, define snprintf as _snprintf.
2482         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2483         Remove unneeded macro definition for snprintf.
2484         * Scripts/webkitpy/common/system/platforminfo.py:
2485         (PlatformInfo._determine_win_version): Recognize Windows 10.
2486         * Scripts/webkitpy/port/win.py:
2487         (WinPort): Ditto.
2488         * Scripts/webkitpy/port/win_unittest.py:
2489         (WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
2490         (WinPortTest._assert_version): Ditto.
2491
2492 2015-08-04  Brian Burg  <bburg@apple.com>
2493
2494         Unreviewed, update email addresses in contributors.json and watchlist.
2495
2496         * Scripts/webkitpy/common/config/contributors.json:
2497         * Scripts/webkitpy/common/config/watchlist:
2498
2499 2015-08-04  Alexey Proskuryakov  <ap@apple.com>
2500
2501         Implement NPAPI redirect handling
2502         https://bugs.webkit.org/show_bug.cgi?id=138675
2503         rdar://problem/15779101
2504
2505         Patch by Jeffrey Pfau, updated and tweaked by me.
2506
2507         Reviewed by Anders Carlsson.
2508
2509         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2510         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2511         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2512         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2513         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2514         (PluginTest::NPP_URLNotify):
2515         (PluginTest::NPP_URLRedirectNotify):
2516         (PluginTest::NPP_GetValue):
2517         (PluginTest::NPN_GetURLNotify):
2518         (PluginTest::NPN_PostURLNotify):
2519         (PluginTest::NPN_GetValue):
2520         (PluginTest::NPN_ReleaseVariantValue):
2521         (PluginTest::NPN_URLRedirectResponse):
2522         (PluginTest::NPN_ConvertPoint):
2523         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2524         * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.
2525         (URLRedirect::URLRedirect):
2526         (URLRedirect::ScriptableObject::hasMethod):
2527         (URLRedirect::ScriptableObject::get):
2528         (URLRedirect::ScriptableObject::serviceAsync):
2529         (URLRedirect::ScriptableObject::invoke):
2530         (URLRedirect::NPP_GetValue):
2531         (URLRedirect::NPP_URLNotify):
2532         (URLRedirect::NPP_URLRedirectNotify):
2533         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2534         (NP_GetEntryPoints):
2535         (NPP_URLNotify):
2536         (NPP_URLRedirectNotify):
2537         (NPP_GetValue):
2538
2539 2015-08-04  Tim Horton  <timothy_horton@apple.com>
2540
2541         Move Matt Daiter to committers.
2542
2543         * Scripts/webkitpy/common/config/contributors.json:
2544
2545 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2546
2547         [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
2548         https://bugs.webkit.org/show_bug.cgi?id=147636
2549
2550         Reviewed by Alex Christensen.
2551         
2552         We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
2553         Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
2554         on EWS machines)
2555
2556         * Scripts/build-webkit:
2557
2558 2015-08-04  Jason Marcell  <jmarcell@apple.com>
2559
2560         Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
2561         https://bugs.webkit.org/show_bug.cgi?id=147280
2562
2563         Reviewed by Daniel Bates.
2564
2565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2566         (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
2567         Refactored _parseData to handle repositories more generically.
2568         (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.
2569         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2570         (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
2571         "opensourceRevision" and "internalRevision".
2572         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2573         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2574         (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
2575         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2576         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
2577         parameter to more generic "repository" string parameter. Added "trac" parameter in order to
2578         specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
2579         and "internalRevision".
2580         (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
2581         instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
2582         "opensourceRevision" and "internalRevision".
2583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding
2584         constants for internal and opensource repositories.
2585         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2586         (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
2587         instead of "opensourceRevision" and "internalRevision".
2588         (Analyzer.prototype._countPercentageOfGreen): Ditto.
2589         (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
2590         (Analyzer.prototype._countTimes): Ditto.
2591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2592         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.
2593
2594 2015-08-04  Mark Lam  <mark.lam@apple.com>
2595
2596         Removed a local debugging line I accidentally left in from a previous commit.
2597
2598         Not Reviewed.
2599
2600         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2601
2602 2015-08-04  Mark Lam  <mark.lam@apple.com>
2603
2604         Unreviewed. Make Saam Barati a WebKit reviewer.
2605
2606         * Scripts/webkitpy/common/config/contributors.json:
2607
2608 2015-08-04  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2609
2610         Unreviewed, updated Streams API watchlist.
2611
2612         * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
2613
2614 2015-08-03  Csaba Osztrogonác  <ossy@webkit.org>
2615
2616         [CMake] Add an option to build AllInOne files
2617         https://bugs.webkit.org/show_bug.cgi?id=102647
2618
2619         Reviewed by Alex Christensen.
2620
2621         * Scripts/webkitperl/FeatureList.pm:
2622
2623 2015-08-03  Alexey Proskuryakov  <ap@apple.com>
2624
2625         AppScale: Add required indices
2626         https://bugs.webkit.org/show_bug.cgi?id=147593
2627
2628         Reviewed by Tim Horton.
2629
2630         * QueueStatusServer/index.yaml:
2631
2632 2015-08-03  Filip Pizlo  <fpizlo@apple.com>
2633
2634         Check in LLVM 3.6.2 binary drops for El Capitan
2635         https://bugs.webkit.org/show_bug.cgi?id=147582
2636
2637         Reviewed by Alexey Proskuryakov.
2638         
2639         Recognize 10.11 and use the right drops.
2640
2641         * Scripts/copy-webkitlibraries-to-product-directory:
2642
2643 2015-08-03  Alex Christensen  <achristensen@webkit.org>
2644
2645         [Win] Build fix after r187733.
2646
2647         * WinLauncher/PageLoadTestClient.cpp:
2648         (PageLoadTestClient::dumpRunStatistics):
2649         wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.
2650
2651 2015-08-02  Benjamin Poulain  <bpoulain@apple.com>
2652
2653         Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
2654         https://bugs.webkit.org/show_bug.cgi?id=118455
2655
2656         Reviewed by Filip Pizlo.
2657
2658         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2659         (TestWebKitAPI::TEST):
2660
2661 2015-07-31  Alex Christensen  <achristensen@webkit.org>
2662
2663         Prepare for VS2015
2664         https://bugs.webkit.org/show_bug.cgi?id=146579
2665
2666         Reviewed by Jon Honeycutt.
2667
2668         * WinLauncher/stdafx.h:
2669         Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
2670
2671 2015-07-31  Csaba Osztrogonác  <ossy@webkit.org>
2672
2673         [EFL] Fix pixman build on ARM with GCC 4.9.3
2674         https://bugs.webkit.org/show_bug.cgi?id=147224
2675
2676         Reviewed by Gyuyoung Kim.
2677
2678         * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
2679
2680 2015-07-30  Anders Carlsson  <andersca@apple.com>
2681
2682         Add support for window.open to WK1BrowserWindowController
2683         https://bugs.webkit.org/show_bug.cgi?id=147474
2684
2685         Reviewed by Dan Bernstein.
2686
2687         * MiniBrowser/mac/WK1BrowserWindowController.m:
2688         (-[WK1BrowserWindowController awakeFromNib]):
2689         Set javaScriptCanOpenWindowsAutomatically to YES. 
2690         If this becomes a nuisance, we can always add a menu item to toggle this.
2691
2692         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2693         Implement this UI delegate method.
2694
2695 2015-07-30  Anders Carlsson  <andersca@apple.com>
2696
2697         Undo stray commit.
2698
2699         * MiniBrowser/mac/WK1BrowserWindowController.m:
2700         (-[WK1BrowserWindowController awakeFromNib]):
2701         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2702
2703 2015-07-29  Dean Jackson  <dino@apple.com>
2704
2705         Don't use (Details) when exposing SPI
2706         https://bugs.webkit.org/show_bug.cgi?id=147426
2707         <rdar://problem/22062407>
2708
2709         Reviewed by Dan Bernstein.
2710
2711         If we are declaring the interface without any implementation,
2712         we should use class extensions.
2713
2714         * DumpRenderTree/mac/DumpRenderTree.mm:
2715         * DumpRenderTree/mac/EventSendingController.mm:
2716         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2717         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2718         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2719         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2720         * WebKitTestRunner/mac/TestControllerMac.mm:
2721
2722 2015-07-30  Aakash Jain  <aakash_jain@apple.com>
2723
2724         Replace Google App Engine with AppScale
2725         https://bugs.webkit.org/show_bug.cgi?id=147178
2726
2727         Reviewed by Daniel Bates.
2728
2729         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2730         (RunWebKitTests):
2731         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2732         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2733         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2735         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2736         (.):
2737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2738         (BubbleQueueServer):
2739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
2740         (TestHistory):
2741         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2742         * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
2743         * TestResultServer/app.yaml: Ditto
2744         * Scripts/webkitpy/common/config/urls.py:
2745         * TestResultServer/main.py:
2746         * TestResultServer/static-dashboards/dashboard_base.js:
2747         * TestResultServer/static-dashboards/loader.js:
2748
2749 2015-07-30  Joonghun Park  <jh718.park@samsung.com>
2750
2751         [EFL] Enable IndexedDB based on DatabaseProcess
2752         https://bugs.webkit.org/show_bug.cgi?id=147221
2753
2754         Reviewed by Csaba Osztrogonác.
2755
2756         * Scripts/webkitperl/FeatureList.pm:
2757
2758 2015-07-30  Alex Christensen  <achristensen@webkit.org>
2759
2760         Build AppleWin port with CMake
2761         https://bugs.webkit.org/show_bug.cgi?id=147385
2762
2763         Reviewed by Martin Robinson.
2764
2765         * WinLauncher/CMakeLists.txt:
2766         Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
2767
2768 2015-07-29  Andy VanWagoner  <thetalecrafter@gmail.com>
2769
2770         Implement basic types for ECMAScript Internationalization API
2771         https://bugs.webkit.org/show_bug.cgi?id=146926
2772
2773         Reviewed by Benjamin Poulain.
2774
2775         Enable flag now that the basic objects are in place.
2776
2777         * Scripts/webkitperl/FeatureList.pm: Enabled INTL
2778
2779 2015-07-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2780
2781         [GTK] Add API to set the maximum number of web processes per WebKitWebContext
2782         https://bugs.webkit.org/show_bug.cgi?id=147108
2783
2784         Reviewed by Gustavo Noronha Silva.
2785
2786         Add test case to check the web process limit.
2787
2788         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2789         (testWebProcessLimit):
2790         (beforeAll):
2791
2792 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2793
2794         [GTK] Missing casts in BrowserWindow.c
2795         https://bugs.webkit.org/show_bug.cgi?id=147395
2796
2797         Reviewed by Carlos Garcia Campos.
2798
2799         * MiniBrowser/gtk/BrowserWindow.c:
2800         (browserWindowSetupEditorToolbar):
2801
2802 2015-07-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2803
2804         [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false"
2805         https://bugs.webkit.org/show_bug.cgi?id=147350
2806
2807         Reviewed by Sam Weinig.
2808
2809         * Scripts/webkitperl/FeatureList.pm:
2810
2811 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2812
2813         [Freetype] Always allow font matching for strong aliases
2814         https://bugs.webkit.org/show_bug.cgi?id=147057
2815
2816         Reviewed by Martin Robinson.
2817
2818         Create family aliases needed for the new layout tests.
2819
2820         * WebKitTestRunner/gtk/fonts/fonts.conf:
2821
2822 2015-07-28  Alexey Proskuryakov  <ap@apple.com>
2823
2824         webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
2825         https://bugs.webkit.org/show_bug.cgi?id=147359
2826
2827         Reviewed by Ryosuke Niwa.
2828
2829         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2830         (NewCommitBot.begin_work_queue):
2831         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2832         (SheriffBot.begin_work_queue):
2833
2834 2015-07-27  Alex Christensen  <achristensen@webkit.org>
2835
2836         Use Ninja on Windows.
2837         https://bugs.webkit.org/show_bug.cgi?id=147228
2838
2839         Reviewed by Martin Robinson.
2840
2841         * WinLauncher/CMakeLists.txt:
2842         WinLauncherLib must make WinLauncher.dll, not WinLauncherLib.dll.
2843         * Scripts/build-webkit:
2844         Use Ninja to build WinCairo by default, but fall back to Visual Studio if Ninja is not on the system.
2845
2846 2015-07-24  Jon Honeycutt  <jhoneycutt@apple.com>
2847
2848         Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't
2849         highlight after being tapped to style a selection"
2850         https://bugs.webkit.org/show_bug.cgi?id=147278
2851
2852         Reviewed by Ryosuke Niwa.
2853
2854         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2855
2856         * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added.
2857         (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]):
2858         (TestWebKitAPI::TEST):
2859         Load a page with the string "Hello, world!", then select "world" and
2860         underline it. Test that the typing attributes for the current selection
2861         include the underline attribute.
2862
2863 2015-07-24  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2864
2865         Unreviewed, updated my nick name in contributors.json
2866
2867         * Scripts/webkitpy/common/config/contributors.json:
2868
2869 2015-07-24  Chris Fleizach  <cfleizach@apple.com>
2870
2871         AX: scrollable elements do not allow 3-finger swipe
2872         https://bugs.webkit.org/show_bug.cgi?id=141893
2873
2874         Reviewed by Mario Sanchez Prada.
2875
2876         Support global notification listeners for iOS code.
2877         Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
2878         Implement scrollUp/Down/Left/Right.
2879
2880         * DumpRenderTree/AccessibilityController.h:
2881         * DumpRenderTree/AccessibilityUIElement.cpp:
2882         (increaseTextSelectionCallback):
2883         (scrollPageUpCallback):
2884         (scrollPageDownCallback):
2885         (scrollPageLeftCallback):
2886         (scrollPageRightCallback):
2887         (decreaseTextSelectionCallback):
2888         (getElementTextLengthCallback):
2889         (AccessibilityUIElement::getJSClass):
2890         * DumpRenderTree/AccessibilityUIElement.h:
2891         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2892         (AccessibilityController::~AccessibilityController):
2893         (AccessibilityController::elementAtPoint):
2894         (AccessibilityController::addNotificationListener):
2895         (AccessibilityController::platformResetToConsistentState):
2896         (AccessibilityController::removeNotificationListener):
2897         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2898         (AccessibilityUIElement::AccessibilityUIElement):
2899         (AccessibilityUIElement::subrole):
2900         (AccessibilityUIElement::scrollPageUp):
2901         (AccessibilityUIElement::scrollPageDown):
2902         (AccessibilityUIElement::scrollPageLeft):
2903         (AccessibilityUIElement::scrollPageRight):
2904         (AccessibilityUIElement::roleDescription):
2905         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2906         (-[AccessibilityNotificationHandler _notificationReceived:]):
2907         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2908         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2909         (WTR::AccessibilityUIElement::linkedElement):
2910         (WTR::AccessibilityUIElement::headerElementAtIndex):
2911         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2912         (WTR::AccessibilityUIElement::scrollPageUp):
2913         (WTR::AccessibilityUIElement::scrollPageDown):
2914         (WTR::AccessibilityUIElement::scrollPageLeft):
2915         (WTR::AccessibilityUIElement::scrollPageRight):
2916         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2917         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2918         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2919         (WTR::AccessibilityController::addNotificationListener):
2920         (WTR::AccessibilityController::removeNotificationListener):
2921         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2922         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2923         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2924         (WTR::AccessibilityUIElement::scrollPageUp):
2925         (WTR::AccessibilityUIElement::scrollPageDown):
2926         (WTR::AccessibilityUIElement::scrollPageLeft):
2927         (WTR::AccessibilityUIElement::scrollPageRight):
2928         (WTR::AccessibilityUIElement::increaseTextSelection):
2929
2930 2015-07-24  Brent Fulgham  <bfulgham@apple.com>
2931
2932         [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
2933         https://bugs.webkit.org/show_bug.cgi?id=147279
2934         <rdar://problem/21990767>
2935
2936         Reviewed by Dean Jackson.
2937
2938         * DumpRenderTree/win/TestRunnerWin.cpp:
2939         (TestRunner::addUserScript):
2940         (TestRunner::addUserStyleSheet):
2941         (TestRunner::setDeveloperExtrasEnabled):
2942
2943 2015-07-24  Basile Clement  <basile_clement@apple.com>
2944
2945         Call fixChangeLogPatch when generating patches from webkit-patch
2946         https://bugs.webkit.org/show_bug.cgi?id=147248
2947
2948         Reviewed by Geoffrey Garen.
2949
2950         When two consecutive patches are from the same author, diff tools
2951         create wrong-looking diffs for ChangeLog files where the apparent added
2952         author is actually the previous patch's author line, making it awkward
2953         to read - and things only get worse when committing a patch and a
2954         followup fix for the same bug shortly after.
2955
2956         We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
2957         this, which we use in perl scripts (svn-create-patch et al). But it is
2958         not used by webkit-patch, which is a python script, and thus creates
2959         "bad" diffs.
2960
2961         In the long term, we should probably port fixChangeLogPatch to python -
2962         but in the short term, let's make webkit-patch call perl to run
2963         fixChangeLogPatch. We are already making various external calls there
2964         anyway.
2965
2966         * Scripts/webkitpy/common/checkout/scm/git.py:
2967         (Git.create_patch):
2968         * Scripts/webkitpy/common/checkout/scm/scm.py:
2969         (SCM.fix_changelog_patch):
2970         * Scripts/webkitpy/common/checkout/scm/svn.py:
2971         (SVN.create_patch):
2972
2973 2015-07-24  Dean Johnson  <dean_johnson@apple.com>
2974
2975         commit-queue flags in webkit-patch are confusing
2976         https://bugs.webkit.org/show_bug.cgi?id=88694
2977
2978         Reviewed by Csaba Osztrogonác.
2979
2980         * Scripts/webkitpy/tool/steps/options.py:
2981         (Options): Updated help string to be more descriptive.
2982
2983 2015-07-23  Brent Fulgham  <bfulgham@apple.com>
2984
2985         [Win] Implement proper High DPI support features
2986         https://bugs.webkit.org/show_bug.cgi?id=146335
2987         <rdar://problem/21558269>
2988
2989         Reviewed by Alex Christensen.
2990
2991         Update WinLauncher to take device scaling factor into account.
2992
2993         * WinLauncher/Common.cpp:
2994         (resizeSubViews): Make sure toolbars and URL bar are properly sized and using
2995         a valid font.
2996         (computeFullDesktopFrame): Handle high DPI desktops.
2997         (WndProc): Make comments more precise.
2998         * WinLauncher/WinLauncher.cpp:
2999         (WinLauncher::init): Determine device scale factor at launch.
3000         (WinLauncher::updateDeviceScaleFactor): Added.
3001         * WinLauncher/WinLauncher.h:
3002         * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
3003         * WinLauncher/WinMain.cpp: Size interface based on scaling factor.
3004         (wWinMain): Ditto.
3005         * win/DLLLauncher/DLLLauncherMain.cpp:
3006         (wWinMain): Tell Windows we understand high DPI.
3007
3008 2015-07-23  Alex Christensen  <achristensen@webkit.org>
3009
3010         [Win] Unreviewed build fix after r187169.
3011
3012         * Scripts/build-webkit:
3013         Correctly find WebKit.sln.
3014
3015 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3016
3017         [GTK] Add API to allow executing editing commands that require an argument
3018         https://bugs.webkit.org/show_bug.cgi?id=146781
3019
3020         Reviewed by Gustavo Noronha Silva.
3021
3022         Add buttons to insert image/link to the MiniBrowser edit toolbar,
3023         and test cases for insert image/link commands too.
3024
3025         * MiniBrowser/gtk/BrowserWindow.c:
3026         (insertImageCommandCallback):
3027         (insertLinkCommandCallback):
3028         (browserWindowSetupEditorToolbar):
3029         (browserWindowConstructed):
3030         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3031         (testWebViewEditorInsertImage):
3032         (testWebViewEditorCreateLink):
3033         (beforeAll):
3034
3035 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3036
3037         Unregistering and re-registering a user message handler does not work
3038         https://bugs.webkit.org/show_bug.cgi?id=138142
3039
3040         Reviewed by Martin Robinson.
3041
3042         This has probably been fixed in r184846, enable the test case
3043         blocked on it.
3044
3045         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3046         (testUserContentManagerScriptMessageReceived):
3047
3048 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
3049
3050         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
3051         https://bugs.webkit.org/show_bug.cgi?id=147212
3052
3053         Reviewed by Filip Pizlo.
3054
3055         * Scripts/webkitperl/FeatureList.pm:
3056
3057 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
3058
3059         Add --ios-simulator to run-api-tests --help.
3060
3061         Rubber-stamped by Dan Bates.
3062
3063         * Scripts/run-api-tests:
3064
3065 2015-07-22  Jason Marcell  <jmarcell@apple.com>
3066
3067         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
3068         https://bugs.webkit.org/show_bug.cgi?id=147043
3069
3070         Reviewed by Daniel Bates and Alexey Proskuryakov.
3071
3072         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3073         (Buildbot.prototype._normalizeQueueInfo):
3074         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
3075         in cases where the queue.branch property is not set and the queue is not a combined queue.
3076         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3077         (BuildbotCombinedQueueView):
3078         Ensuring uniformity of repository branches within a combined queue.
3079         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3080         (WebKitBuildbot.prototype.get defaultBranches):
3081         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
3082         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
3083         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
3084         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
3085         implement defaultBranches so that a person can either update the definition of the sub-queue or
3086         implement defaultBranches in the derived Buildbot class they are using.
3087
3088 2015-07-22  Alex Christensen  <achristensen@webkit.org>
3089
3090         Switch WinCairo build to use CMake.
3091         https://bugs.webkit.org/show_bug.cgi?id=147169
3092
3093         Reviewed by Brent Fulgham.
3094
3095         * Scripts/build-webkit:
3096         * Scripts/webkitdirs.pm:
3097         (determineConfiguration):
3098         (determineArchitecture):
3099         (determinePassedConfiguration):
3100         (passedConfiguration):
3101         (jhbuildWrapperPrefixIfNeeded):
3102         (generateBuildSystemFromCMakeProject):
3103         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
3104
3105 2015-07-22  Alex Christensen  <achristensen@webkit.org>
3106
3107         Fix quirks in CMake build on Mac and Windows
3108         https://bugs.webkit.org/show_bug.cgi?id=147174
3109
3110         Reviewed by Gyuyoung Kim.
3111
3112         * CMakeLists.txt:
3113         Don't build DumpRenderTree with CMake for now (until we get that working).
3114         * WinLauncher/CMakeLists.txt:
3115         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
3116
3117 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3118
3119         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
3120         https://bugs.webkit.org/show_bug.cgi?id=147146
3121
3122         Reviewed by Darin Adler.
3123
3124         * Scripts/webkitpy/style/checkers/cpp.py:
3125         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
3126         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3127         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
3128
3129 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
3130
3131         Fixed VM pool allocation should have a reserve for allocations that cannot fail
3132         https://bugs.webkit.org/show_bug.cgi?id=147154
3133         rdar://problem/21847618
3134
3135         Reviewed by Geoffrey Garen.
3136         
3137         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
3138         mitigations work, these should all pass. Prior to this patch there were >20 failures.
3139
3140         * Scripts/run-jsc-stress-tests:
3141
3142 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3143
3144         [GTK] Add API to be notified about editor state changes
3145         https://bugs.webkit.org/show_bug.cgi?id=145875
3146
3147         Reviewed by Gustavo Noronha Silva.
3148
3149         Update the typing attributes toggle buttons state according to the
3150         editor state in MiniBrowser, and add a test case to the
3151         WebViewEditor unit tests.
3152
3153         * MiniBrowser/gtk/BrowserWindow.c:
3154         (browserWindowEditingCommandToggleButtonSetActive):
3155         (typingAttributesChanged):
3156         (browserWindowSetupEditorToolbar):
3157         (browserWindowConstructed):
3158         (browser_window_init):
3159         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3160         (testWebViewEditorEditorStateTypingAttributes):
3161         (beforeAll):
3162
3163 2015-07-20  Tomas Popela  <tpopela@redhat.com>
3164
3165         [GTK] Add selection-changed signal to the WebKit2 API
3166         https://bugs.webkit.org/show_bug.cgi?id=137116
3167
3168         Reviewed by Carlos Garcia Campos.
3169
3170         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
3171         (namely the selection-changed signal).
3172
3173         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3174         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
3175         (WebKitWebEditorTest::create):
3176         (WebKitWebEditorTest::selectionChangedCallback):
3177         (WebKitWebEditorTest::testSelectionSelectAll):
3178         (WebKitWebEditorTest::testSelectionCollapse):
3179         (WebKitWebEditorTest::testSelectionModifyMove):
3180         (WebKitWebEditorTest::testSelectionModifyExtend):
3181         (WebKitWebEditorTest::testSelectionUnselect):
3182         (registerTests):
3183         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
3184         (testWebKitWebEditorSelectionChanged):
3185         (beforeAll):
3186         (afterAll):
3187
3188 2015-07-20  Alex Christensen  <achristensen@webkit.org>
3189
3190         Resurrect CMake build on Windows.
3191         https://bugs.webkit.org/show_bug.cgi?id=147083
3192
3193         Reviewed by Gyuyoung Kim.
3194
3195         * DumpRenderTree/CMakeLists.txt:
3196         * DumpRenderTree/PlatformWin.cmake: Added.
3197         * WinLauncher/CMakeLists.txt:
3198
3199 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3200
3201         [GTK] Enable seccomp filter API tests
3202         https://bugs.webkit.org/show_bug.cgi?id=140071
3203
3204         Reviewed by Žan Doberšek.
3205
3206         These tests will now be run by the run-gtk-tests script.
3207
3208         * TestWebKitAPI/PlatformGTK.cmake:
3209
3210 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3211
3212         [GTK] Add seccomp filters support
3213         https://bugs.webkit.org/show_bug.cgi?id=110014
3214
3215         Reviewed by Žan Doberšek.
3216
3217         Add libseccomp to jhbuild modulesets.
3218
3219         * gtk/jhbuild.modules:
3220
3221 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
3222
3223         MiniBrowser window title is just "Window" when page has no <title>
3224         https://bugs.webkit.org/show_bug.cgi?id=147076
3225
3226         Reviewed by Tim Horton.
3227         
3228         Make MiniBrowser windows show the filename from the URL if we never get a title changed
3229         notification.
3230
3231         * MiniBrowser/mac/WK1BrowserWindowController.m:
3232         (-[WK1BrowserWindowController updateTitle:]):
3233         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
3234         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
3235         * MiniBrowser/mac/WK2BrowserWindowController.m:
3236         (-[WK2BrowserWindowController updateTitle:]):
3237         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3238         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3239
3240 2015-07-17  Andy Estes  <aestes@apple.com>
3241
3242         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
3243         https://bugs.webkit.org/show_bug.cgi?id=147044
3244         rdar://problem/21567820
3245
3246         Reviewed by Brady Eidson.
3247
3248         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3249         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
3250         This matches the behavior of DumpRenderTree.
3251
3252 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
3253
3254         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
3255         https://bugs.webkit.org/show_bug.cgi?id=147032
3256
3257         Reviewed by Alex Christensen.
3258
3259         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3260         Test that the useless terms are eliminated by counting
3261         the number of NFA nodes generated.
3262
3263 2015-07-17  Dan Bernstein  <mitz@apple.com>
3264
3265         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
3266         https://bugs.webkit.org/show_bug.cgi?id=147040
3267
3268         Reviewed by Dean Jackson.
3269
3270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3271         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
3272         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
3273         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
3274         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3275         (TEST):
3276
3277 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
3278
3279         webkit-patch uses incorrect credentials from keychain to login until account lockout
3280         https://bugs.webkit.org/show_bug.cgi?id=146923
3281
3282         Reviewed by Daniel Bates.
3283
3284         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
3285         provide incorrect credentials then ask for them to be saved to the keychain
3286         webkit-patch will then use those incorrect credentials until 5 total attempts
3287         have been made to log in. This will lock the user out of Bugzilla for a
3288         half hour.
3289
3290         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3291         (Bugzilla.authenticate): Added argument to read_credentials() that
3292         passes in whether or not to use stored credentials.
3293         * Scripts/webkitpy/common/net/credentials.py:
3294         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
3295         that specifies whether or not to use credentials stored on the system. If it
3296         does, we do not auto-fill credentials since either the credentials caused
3297         the failure, or they weren't used in the first place so there is no reason
3298         to try and use them again if a failure happened.
3299         * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
3300         use_stored_credentials argument.
3301         (test_do_not_use_stored_credentials): Added unit test to make sure functions that
3302         retrieve username/password information from the local system (environment, Git, keychain,
3303         keyring) are never called. It also tests that we get back our mocked username and password.
3304         (test_do_not_use_stored_credentials.MockKeyring): Mock keyring
3305         (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
3306         (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
3307         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
3308         is never called.
3309         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
3310         (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
3311         (test_do_not_use_stored_credentials.FakeUser): Mock the User class
3312         (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
3313         (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
3314         against.
3315
3316 2015-07-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3317
3318         Unreviewed, remove my redundant email information.
3319
3320         * Scripts/webkitpy/common/config/contributors.json:
3321
3322 2015-07-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3323
3324         Unreviewed. Add Hyungwook Lee as a committer.
3325
3326         * Scripts/webkitpy/common/config/contributors.json:
3327
3328 2015-07-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3329
3330         Added myself to the list of contributors.
3331
3332         Reviewed by Brent Fulgham.
3333
3334         * Scripts/webkitpy/common/config/contributors.json:
3335
3336 2015-07-16  Alex Christensen  <achristensen@webkit.org>
3337
3338         [Content Extensions] Cache domain actions
3339         https://bugs.webkit.org/show_bug.cgi?id=146817
3340
3341         Reviewed by Benjamin Poulain.
3342
3343         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3344         (TestWebKitAPI::TEST_F):
3345         Test if-domain and unless-domain with multiple load types.
3346
3347 2015-07-16  Benjamin Poulain  <bpoulain@apple.com>
3348
3349         [Content extensions] Combine suffixes when generating NFAs
3350         https://bugs.webkit.org/show_bug.cgi?id=146961
3351
3352         Reviewed by Alex Christensen.
3353
3354         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3355         (TestWebKitAPI::compareContents):
3356         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3357
3358 2015-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3359
3360         [GTK] Input method filter is always enabled when the view is focused
3361         https://bugs.webkit.org/show_bug.cgi?id=146965
3362
3363         Reviewed by Martin Robinson.
3364
3365         Use setEnabled() instead of notifyFocusedIn() to enable input methods.
3366
3367         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
3368         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
3369
3370 2015-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3371
3372         [EFL] Bump libseccomp version to 2.2.3
3373         https://bugs.webkit.org/show_bug.cgi?id=146980
3374
3375         Reviewed by Gyuyoung Kim.
3376
3377         * efl/jhbuild.modules:
3378
3379 2015-07-15  Brent Fulgham  <bfulgham@apple.com>
3380
3381         [Win] Maintain consistent COM Interfaces
3382         https://bugs.webkit.org/show_bug.cgi?id=146983
3383         <rdar://problem/21822278>
3384
3385         Reviewed by Dean Jackson.
3386
3387         Update DumpRenderTree and WinLauncher to use the properly
3388         versioned COM interface objects.
3389
3390         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3391         (AccessibilityController::rootElement):
3392         * DumpRenderTree/win/DumpRenderTree.cpp:
3393         (resetWebPreferencesToConsistentValues):
3394         (resetWebViewToConsistentStateBeforeTesting):
3395         (runTest):
3396         (createWebViewAndOffscreenWindow):
3397         * DumpRenderTree/win/EditingDelegate.cpp:
3398         (EditingDelegate::QueryInterface):
3399         (EditingDelegate::shouldEndEditingInDOMRange):
3400         (EditingDelegate::shouldInsertNode):
3401         * DumpRenderTree/win/EditingDelegate.h:
3402         * DumpRenderTree/win/EventSender.cpp:
3403         (scalePageByCallback):
3404         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3405         (FrameLoadDelegate::didCommitLoadForFrame):
3406         * DumpRenderTree/win/TestRunnerWin.cpp:
3407         (TestRunner::callShouldCloseOnWebView):
3408         (TestRunner::applicationCacheDiskUsageForOrigin):
3409         (TestRunner::clearApplicationCacheForOrigin):
3410         (TestRunner::setDefersLoading):
3411         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3412         (TestRunner::setTabKeyCyclesThroughElements):
3413         (TestRunner::setValueForUser):
3414         (TestRunner::dispatchPendingLoadRequests):
3415         (TestRunner::setWindowIsKey):
3416         (TestRunner::execCommand):
3417         (TestRunner::addOriginAccessWhitelistEntry):
3418         (TestRunner::removeOriginAccessWhitelistEntry):
3419         (TestRunner::addUserScript):
3420         (TestRunner::addUserStyleSheet):
3421         (TestRunner::showWebInspector):
3422         (TestRunner::closeWebInspector):
3423         (TestRunner::evaluateInWebInspector):
3424         (TestRunner::setSerializeHTTPLoads):
3425         * DumpRenderTree/win/TextInputControllerWin.cpp:
3426         (TextInputController::setMarkedText):
3427         (TextInputController::hasMarkedText):
3428         (TextInputController::unmarkText):
3429         (TextInputController::markedRange):
3430         (TextInputController::insertText):
3431         (TextInputController::firstRectForCharacterRange):
3432         (TextInputController::selectedRange):
3433         * DumpRenderTree/win/UIDelegate.h:
3434         (UIDelegate::unused2):
3435         (UIDelegate::unused3):
3436         (UIDelegate::webViewScrolled):
3437         (UIDelegate::webViewShouldInterruptJavaScript):
3438         (UIDelegate::webViewReceivedFocus):
3439         (UIDelegate::unused4): Deleted.
3440         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3441         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
3442         * WinLauncher/PageLoadTestClient.cpp:
3443         (PageLoadTestClient::didStartProvisionalLoad):
3444         * WinLauncher/WinLauncher.cpp:
3445         (WinLauncher::init):
3446         * WinLauncher/WinLauncher.h:
3447         * WinLauncher/WinLauncherWebHost.cpp:
3448         (WinLauncherWebHost::didFinishLoadForFrame):
3449         (WinLauncherWebHost::didFirstLayoutInFrame):
3450         * WinLauncher/WinLauncherWebHost.h:
3451
3452 2015-07-15  Dean Johnson  <dean_johnson@apple.com>
3453
3454         Many test failures in scm_unittest.py
3455         https://bugs.webkit.org/show_bug.cgi?id=143967
3456
3457         Reviewed by Daniel Bates. 
3458
3459         * Scripts/webkitpy/common/checkout/scm/detection.py:
3460         (SCMDetector.detect_scm_system): Paths with symlinks are now resolved to
3461         absolute canonical file paths. Two mutually exclusive issues cause this
3462         to be a problem.
3463             1) Python's os.path.relpath() function does not return correct relative
3464             paths between two filepaths that point to the same file, if symlinks are
3465             involved.
3466                 On Mac, /tmp points to /private/tmp
3467                 ex. os.path.relpath('/tmp', '/private/tmp')
3468                     returns '../../tmp'
3469             What we want is actually just '.'
3470             2) Git does not allow file paths to trace outside of
3471             the Git repository. This means that if you have a repository in
3472             /tmp and you refer to that repository when invoking a git command as
3473             ../tmp, Git will produce errors about working outside of the repository.
3474         * Scripts/webkitpy/common/checkout/scm/git.py: Over time Git has changed
3475         its default behavior and such, needed to be updated.
3476         (Git.changed_files): '--' was added into the command so that patch_directories
3477         were taken as positional arguments.
3478         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Changed tests and setup 
3479         in the GitSVNTest class to more closely emulate the version of Git that the tests
3480         assumed a system had. Also fixed a small side-effect from the absolute canonical
3481         path fix in SCMDetector.detect_scm_system
3482         (SVNTestRepository.setup): A relative filepath was previously passed as the
3483         checkout root to SCMDetector.detect_scm_system, but is now cleaned to
3484         an absolute canonical path before being passed in. The failing test
3485         was a "sanity check" that the svn.checkout_root and scm.checkout_root
3486         were the same.
3487         (GitSVNTest._setup_git_checkout):
3488             1) Added "--prefix ''" option to `git clone` since Git changed its default
3489             behavior in version 2.0.
3490             2) The branch master was renamed to trunk to more closely emulate what
3491             tests expected when they were written. 
3492         (GitSVNTest.test_changed_files_local_plus_working_copy): Two of the three
3493         original tests failed because the tests expected the trunk branch
3494         to produce its parent's commit, whereas Git merely provides the HEAD commit
3495         for a given branch (trunk in this case). Based on other tests written
3496         in the same commit, it appears these tests were failing from the point they
3497         were written.
3498
3499 2015-07-14  Anders Carlsson  <andersca@apple.com>
3500
3501         Assertions.h should include ExportMacros.h
3502         https://bugs.webkit.org/show_bug.cgi?id=146948
3503
3504         Reviewed by Tim Horton.
3505
3506         Remove now unneeded WTF_EXPORT_PRIVATE define.
3507
3508         * DumpRenderTree/cg/ImageDiffCG.cpp:
3509
3510 2015-07-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3511
3512         [GTK] [Wayland] Build by default the X11 and Wayland targets.
3513         https://bugs.webkit.org/show_bug.cgi?id=146057
3514
3515         Reviewed by Carlos Garcia Campos.
3516
3517         * gtk/install-dependencies:
3518
3519 2015-07-10  Brent Fulgham  <bfulgham@apple.com>
3520
3521         [Mac] Unable to dismiss context menu during test runs
3522         https://bugs.webkit.org/show_bug.cgi?id=146836
3523
3524         Reviewed by Tim Horton.
3525
3526         Since Context Menus are modal, the test system would block on the displayed context menu,
3527         causing tests to fail. Instead, we should do what WK1 was doing, which is to perform the
3528         mouse click and generate the menu contents, but not ask AppKit to display it.
3529
3530         Drive-by fix: We did not handle 'escape' key presses. This is also fixed.
3531
3532         * DumpRenderTree/mac/EventSendingController.mm:
3533         (-[EventSendingController keyDown:withModifiers:withLocation:]): Handle the 'escape' character.
3534         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3535         (WTR::EventSendingController::mouseMoveTo): Keep track of the current mouse position.
3536         (WTR::EventSendingController::contextClick): Don't emit an actual context menu invocation and then
3537         copy the menu items. Instead, use WKBundlePageCopyContentMenuAtPointInWindow to do all the same
3538         work without actually calling on AppKit to display the menu.
3539         ask WebCore to do all the work EXCEPT displaying the menu.
3540         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3541         * WebKitTestRunner/mac/EventSenderProxy.mm:
3542         (WTR::EventSenderProxy::keyDown): Handle the 'escape' character.
3543
3544 2015-07-09  Filip Pizlo  <fpizlo@apple.com>
3545
3546         It should be possible to run the OSR exit fuzzer
3547         https://bugs.webkit.org/show_bug.cgi?id=146814
3548
3549         Reviewed by Mark Lam.
3550         
3551         This runs a test command to detect how many static OSR exit sites it had, and then for
3552         each exit site, it triggers three exits (earliest opportunity, last opportunity, some
3553         middle opportunity), plus a mode where the check always exits. This is an exhaustive
3554         search, so in the future it'll be very appropriate for cases where we have a simple test
3555         and we want to see what happens when you eventually exit in this test.
3556         
3557         Right now this isn't hooked into any specific tests, but I've done some spot checks on it
3558         and it seems to do the right thing.
3559
3560         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz: Added.
3561         (fail):
3562
3563 2015-07-10  Alex Christensen  <achristensen@webkit.org>
3564
3565         Add tests for r186649
3566         https://bugs.webkit.org/show_bug.cgi?id=146821
3567
3568         Reviewed by Darin Adler.
3569
3570         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3571         (TestWebKitAPI::TEST_F):
3572         (TestWebKitAPI::compareContents):
3573         (TestWebKitAPI::expectedIndex):
3574         Add some larger tests to test large jumps.
3575
3576 2015-07-09  Dewei Zhu  <dewei_zhu@apple.com>
3577
3578         Quick fix for run_benchmark script that AppKit.NSRunningApplication does not work properly
3579         https://bugs.webkit.org/show_bug.cgi?id=146820
3580
3581         Reviewed by Ryosuke Niwa.
3582
3583         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3584         (OSXBrowserDriver):
3585         (OSXBrowserDri