<rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage...
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-05  Dan Bernstein  <mitz@apple.com>
2
3         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
4         https://bugs.webkit.org/show_bug.cgi?id=77823
5
6         Reviewed by Anders Carlsson.
7
8         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
9         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
10
11 2012-02-04  Dan Bernstein  <mitz@apple.com>
12
13         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
14         https://bugs.webkit.org/show_bug.cgi?id=77822
15
16         Reviewed by Sam Weinig.
17
18         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
19         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
20
21 2012-02-04  Sam Weinig  <sam@webkit.org>
22
23         Add ability to send WKURLRequests in WebKit2 API user messages
24         https://bugs.webkit.org/show_bug.cgi?id=77819
25
26         Reviewed by Anders Carlsson.
27
28         Add testing for round-tripping WKTypes from the UIProcess,
29         to the WebProcess, and back.
30
31         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
32           More can easily be added.
33
34         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
35         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
36         (TestWebKitAPI):
37         (WebKit2UserMessageRoundTripTest):
38         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
39         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
40         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
41         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
42         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
43         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
44         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
45         (TestWebKitAPI::TEST_F):
46         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
47         (TestWebKitAPI):
48         (UserMessageTest):
49         (TestWebKitAPI::UserMessageTest::UserMessageTest):
50         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
51         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
52         (TestWebKitAPI::PlatformWebView::resizeTo):
53         (TestWebKitAPI):
54         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
55         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
56
57 2012-02-04  Dan Bernstein  <mitz@apple.com>
58
59         <rdar://problem/10772406> WKPreferences instances cannot be copied
60         https://bugs.webkit.org/show_bug.cgi?id=77816
61
62         Reviewed by Sam Weinig.
63
64         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
65         (TestWebKitAPI::TEST):
66
67 2012-02-04  Adam Barth  <abarth@webkit.org>
68
69         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
70         https://bugs.webkit.org/show_bug.cgi?id=77802
71
72         Reviewed by Eric Seidel.
73
74         This patch refactors our directory grouping code into base.js where it
75         can be shared between failures.js and notifications.js.  It then adds
76         an Examine action to each group of failures that triggers the "results"
77         view.
78
79         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
80         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
81         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
82         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
83         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
84         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
85
86 2012-02-04  Ojan Vafai  <ojan@chromium.org>
87
88         check-webkit-style is throwing an exception
89         https://bugs.webkit.org/show_bug.cgi?id=77744
90
91         Reviewed by David Levin.
92
93         If the test_list is None, then we don't need to check for unsupported
94         feature tests to skip.
95
96         * Scripts/webkitpy/layout_tests/port/webkit.py:
97         (WebKitPort._has_test_in_directories):
98         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
99         (test_skipped_tests_for_unsupported_features_empty_test_list):
100
101 2012-02-03  Adam Barth  <abarth@webkit.org>
102
103         List of all failures in garden-o-matic should actually list all the failures
104         https://bugs.webkit.org/show_bug.cgi?id=77796
105
106         Reviewed by Eric Seidel.
107
108         This patch wires a bit more data into the new "All Failures" tab.  I've
109         also iterated on how we enable this experimental feature.  The tab is
110         still just a dumb list, but we'll make it smarter.
111
112         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
113         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
114         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
115         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
116
117 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
118
119         Windows build fix after r106692.
120
121         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
122         (PortTest.test_reference_files):
123
124 2012-02-03  Beth Dakin  <bdakin@apple.com>
125
126         https://bugs.webkit.org/show_bug.cgi?id=77782
127         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than 
128         once on some pages with frames
129         -and corresponding-
130         <rdar://problem/10798474>
131
132         Reviewed by Sam Weinig.
133
134         One new test.
135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
136         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
137         (TestWebKitAPI):
138         (TestWebKitAPI::didForceRepaint):
139         (TestWebKitAPI::didFinishLoadForFrame):
140         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
141         (TestWebKitAPI::setPageLoaderClient):
142         (TestWebKitAPI::TEST):
143         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
144         (TestWebKitAPI):
145         (NewFirstVisuallyNonEmptyLayoutFramesTest):
146         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
147         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
148         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
149
150 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
151
152         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
153         https://bugs.webkit.org/show_bug.cgi?id=77781
154
155         Reviewed by Eric Seidel.
156
157         This change fixes a couple of issues discovered while debugging
158         test-webkitpy; both calling exit() instead of sys.exit() --
159         which is discouraged in program code instead of the interpreter
160         -- and a particular usage of outputcapture were stdin to get whacked
161         and preventing debugging.
162        
163         This change introduces a couple of common _exit() methods that
164         will standardize how webkit-patch exit's, in case we need to do
165         something different in the future.
166
167         * Scripts/webkitpy/common/system/deprecated_logging.py:
168         (error):
169         * Scripts/webkitpy/common/system/outputcapture.py:
170         (OutputCapture.assert_outputs):
171         * Scripts/webkitpy/tool/bot/queueengine.py:
172         (QueueEngine.exit_after_handled_error):
173         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
174         (AbstractSequencedCommand.execute):
175         * Scripts/webkitpy/tool/commands/queues.py:
176         (StyleQueue.handle_script_error):
177         * Scripts/webkitpy/tool/commands/upload.py:
178         (MarkBugFixed.execute):
179         * Scripts/webkitpy/tool/multicommandtool.py:
180         (Command._exit):
181         * Scripts/webkitpy/tool/steps/abstractstep.py:
182         (AbstractStep._exit):
183         * Scripts/webkitpy/tool/steps/checkstyle.py:
184         (CheckStyle.run):
185         * Scripts/webkitpy/tool/steps/commit.py:
186         (Commit._check_test_expectations):
187         * Scripts/webkitpy/tool/steps/confirmdiff.py:
188         (ConfirmDiff.run):
189
190 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
191
192         Perf bot build fix.
193
194         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
195         (PerfTestsRunner._generate_json):
196
197 2012-02-03  Adam Barth  <abarth@webkit.org>
198
199         Add a blank "Expected Failures" tab to garden-o-matic
200         https://bugs.webkit.org/show_bug.cgi?id=77793
201
202         Reviewed by Eric Seidel.
203
204         This tab will help us explore and manage our expected failures.  The
205         tab is hidden by default via a new "experimental features" flag.
206
207         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
211         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
212         (#unexpected):
213         (#onebar.partytime #unexpected):
214
215 2012-02-03  Lucas Forschler  <lforschler@apple.com>
216
217         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
218         https://bugs.webkit.org/show_bug.cgi?id=77785
219
220         Fix the build bots.
221         
222         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
223
224         * Scripts/update-webkit-support-libs:
225         (downloadExpectedVersionNumber):
226
227 2012-02-03  Lucas Forschler  <lforschler@apple.com>
228
229         Add a Mac Lion Performance bot.
230         https://bugs.webkit.org/show_bug.cgi?id=77765
231
232         Reviewed by Adam Roben.
233
234         This will update the master configuration in the following ways:
235             Add a new performance slave (apple-xseve-11)
236             Add a new Factory to download a build and run perf tests.
237             
238         * BuildSlaveSupport/build.webkit.org-config/config.json:
239         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
240         (DownloadAndPerfTestFactory):
241         (DownloadAndPerfTestFactory.__init__):
242
243 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
244
245         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
246         https://bugs.webkit.org/show_bug.cgi?id=77752
247
248         Reviewed by James Robinson.
249
250         Delete unneeded file accidentally checked in in r106481.
251
252         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
253
254 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
255
256         Ref Tests should support plain SVG files
257         https://bugs.webkit.org/show_bug.cgi?id=77685
258
259         Reviewed by Tony Chang.
260
261         Don't assume reference files always use .html as the extension.
262         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
263
264         Also fix various bugs in MockFileSystem and TestPort.
265
266         * Scripts/webkitpy/common/system/filesystem_mock.py:
267         (MockFileSystem.isdir):
268         * Scripts/webkitpy/layout_tests/port/base.py:
269         (Port.reference_files):
270         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
271         (PortTest.test_is_test_file):
272         (PortTest.test_reference_files):
273         * Scripts/webkitpy/layout_tests/port/test.py:
274         (TestInstance.__init__):
275
276 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
277
278         perf-o-matic should store chromium svn revision
279         https://bugs.webkit.org/show_bug.cgi?id=77725
280
281         Reviewed by Dirk Pranke.
282
283         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
284         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
285         is implemented in terms of newly added svn_revision.
286
287         * Scripts/webkitpy/common/checkout/scm/git.py:
288         (Git.svn_revision):
289         * Scripts/webkitpy/common/checkout/scm/scm.py:
290         (SCM.head_svn_revision):
291         (SCM):
292         (SCM.svn_revision):
293         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
294         (MockSCM.svn_revision):
295         * Scripts/webkitpy/common/checkout/scm/svn.py:
296         (SVN.svn_revision):
297         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
298         (JSONLayoutResultsGenerator.__init__):
299         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
300         (JSONResultsGeneratorBase._insert_generic_metadata):
301         * Scripts/webkitpy/layout_tests/port/base.py:
302         (Port.repository_paths):
303         * Scripts/webkitpy/layout_tests/port/chromium.py:
304         (ChromiumPort.repository_paths):
305         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
306         (PerfTestsRunner._generate_json):
307         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
308         (test_run_test_set_with_json_output):
309         (test_run_test_set_with_json_source):
310         (test_run_test_set_with_multiple_repositories):
311
312 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
313
314         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
315         https://bugs.webkit.org/show_bug.cgi?id=77632
316
317         Reviewed by Kenneth Rohde Christiansen.
318
319         * MiniBrowser/qt/BrowserWindow.cpp:
320         (BrowserWindow::BrowserWindow):
321         * MiniBrowser/qt/MiniBrowserApplication.cpp:
322         (MiniBrowserApplication::sendTouchEvent):
323         (MiniBrowserApplication::handleUserOptions):
324         * MiniBrowser/qt/MiniBrowserApplication.h:
325         (WindowOptions):
326         (WindowOptions::WindowOptions):
327         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
328         (WTR::PlatformWebView::PlatformWebView):
329         * WebKitTestRunner/qt/main.cpp:
330         (main):
331         * qmake/mkspecs/features/default_post.prf:
332
333 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
334
335         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
336         https://bugs.webkit.org/show_bug.cgi?id=77723
337
338         Reviewed by Tor Arne Vestbø.
339
340         * Tools.pro: Compile WTR again on all platforms with WK2.
341
342 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
343
344         Ensure that inspector disabled build works
345         https://bugs.webkit.org/show_bug.cgi?id=77604
346
347         Reviewed by Tor Arne Vestbø.
348
349         * qmake/mkspecs/features/features.prf:
350
351 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
352
353         [chromium] add support for --makeargs to the ninja-based build
354         https://bugs.webkit.org/show_bug.cgi?id=77688
355
356         Reviewed by Adam Barth.
357
358         * Scripts/webkitdirs.pm:
359         (buildChromiumNinja):
360
361 2012-02-02  Eric Seidel  <eric@webkit.org>
362
363         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
364         https://bugs.webkit.org/show_bug.cgi?id=75145
365
366         Reviewed by Dirk Pranke.
367
368         * Scripts/webkitpy/layout_tests/port/mac.py:
369         (MacPort.default_child_processes):
370         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
371         (test_operating_system):
372         (test_default_child_processes):
373
374 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
375
376        nrwt shouldn't blow up when there are errors in test_expectations.txt
377        https://bugs.webkit.org/show_bug.cgi?id=73603
378
379        Reviewed by Ojan Vafai.
380
381        This change removes the distinction between 'errors' and 'warnings'
382        in the test expectations parser. Now, any problem is a
383        'warning', and if we are linting the file, warnings become fatal (errors).
384
385         This will allow a normal run-webkit-tests run to proceed even if
386         there are bad lines.
387
388         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
389         (ParseError.__init__):
390         (ParseError.__str__):
391         (ParseError.__repr__):
392         (TestExpectationSerializer.to_string):
393         (TestExpectationParser._parse_modifiers):
394         (TestExpectationParser._parse_expectations):
395         (TestExpectationParser._check_modifiers_against_expectations):
396         (TestExpectationParser._tokenize):
397         (TestExpectationLine.__init__):
398         (TestExpectationLine.is_invalid):
399         (TestExpectationsModel.add_expectation_line):
400         (TestExpectationsModel._already_seen_better_match):
401         (TestExpectations.__init__):
402         (TestExpectations._report_warnings):
403         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
404         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
405         (assert_bad_expectations):
406         (test_parse_warning):
407         (test_overrides__duplicate):
408         (ExpectationSyntaxTests.test_missing_expectation):
409         (ExpectationSyntaxTests.test_missing_colon):
410         (ExpectationSyntaxTests.test_too_many_colons):
411         (ExpectationSyntaxTests.test_too_many_equals_signs):
412         (ExpectationSyntaxTests.test_unrecognized_expectation):
413         (SemanticTests.test_bug_format):
414         (SemanticTests.test_bad_bugid):
415         (SemanticTests.test_slow_and_timeout):
416         (test_ambiguous):
417         (test_more_modifiers):
418         (test_order_in_file):
419         (test_macro_overrides):
420         (RebaseliningTest.assertRemove):
421         (TestExpectationParserTests.test_tokenize_blank):
422         (TestExpectationParserTests.test_tokenize_missing_colon):
423         (TestExpectationParserTests.test_tokenize_extra_colon):
424         (TestExpectationParserTests.test_tokenize_empty_comment):
425         (TestExpectationParserTests.test_tokenize_comment):
426         (TestExpectationParserTests.test_tokenize_missing_equal):
427         (TestExpectationParserTests.test_tokenize_extra_equal):
428         (TestExpectationParserTests.test_tokenize_valid):
429         (TestExpectationParserTests.test_tokenize_valid_with_comment):
430         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
431         (TestExpectationSerializerTests.test_unparsed_to_string):
432         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
433         (lint):
434         * Scripts/webkitpy/style/checkers/test_expectations.py:
435         (TestExpectationsChecker.check_test_expectations):
436
437 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
438
439         Unreviewed, rolling out r106543.
440         http://trac.webkit.org/changeset/106543
441         https://bugs.webkit.org/show_bug.cgi?id=77671
442
443         Made tests less stable (Requested by rniwa on #webkit).
444
445         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
446         (PerfTestsRunner):
447         (PerfTestsRunner.__init__):
448         (PerfTestsRunner._run_tests_set):
449         (PerfTestsRunner._run_single_test):
450         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
451         (MainTest.TestDriver.run_test):
452         (run_test):
453
454 2012-02-02  Beth Dakin  <bdakin@apple.com>
455
456         https://bugs.webkit.org/show_bug.cgi?id=77664
457         Add API tests for didNewFirstVisuallyNonEmptyLayout
458
459         Reviewed by Darin Adler.
460
461         Two new tests.
462         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
463         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
464         (TestWebKitAPI):
465         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
466         (TestWebKitAPI::setPageLoaderClient):
467         (TestWebKitAPI::TEST):
468         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
469         (TestWebKitAPI):
470         (TestWebKitAPI::didForceRepaint):
471         (TestWebKitAPI::didFinishLoadForFrame):
472         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
473         (TestWebKitAPI::setPageLoaderClient):
474         (TestWebKitAPI::TEST):
475         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
476         (TestWebKitAPI):
477         (NewFirstVisuallyNonEmptyLayoutFailsTest):
478         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
479         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
480         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
481         (TestWebKitAPI):
482         (NewFirstVisuallyNonEmptyLayoutTest):
483         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
484         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
485
486 2012-02-02  Michael Saboff  <msaboff@apple.com>
487
488         Add Michael Saboff to reviewers list.
489
490         Rubber-stamped by Gavin Barraclough.
491
492         * Scripts/webkitpy/common/config/committers.py:
493
494 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
495
496         Add myself as a committer
497
498         Unreviewed
499
500         * Scripts/webkitpy/common/config/committers.py:
501
502 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
503
504         [PerformanceTests] tests have dependencies
505         https://bugs.webkit.org/show_bug.cgi?id=77506
506
507         Reviewed by Hajime Morita.
508
509         Load an initialization page before each test after starting a DRT so that
510         warming up DRT won't affect the performance test results.
511
512         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
513         (PerfTestsRunner):
514         (PerfTestsRunner.__init__):
515         (PerfTestsRunner._run_tests_set):
516         (PerfTestsRunner._run_single_test):
517         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
518         (MainTest.TestDriver.run_test):
519         (test_initial_page_loaded):
520         (test_initial_page_loaded.run_test):
521
522 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
523
524         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
525
526         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
527         (PerfTestsRunner._run_tests_set):
528         (PerfTestsRunner._run_single_test):
529         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
530         (create_runner):
531         (test_run_passing_test):
532         (test_run_silent_test):
533         (test_run_failed_test):
534         (test_run_tonguey_test):
535         (test_run_timeout_test):
536         (test_run_crash_test):
537         (test_run_test_set_kills_drt_per_run):
538         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
539         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
540         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
541
542 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
543
544         Webkit generate-coverage-data script needs update to use new test script
545         https://bugs.webkit.org/show_bug.cgi?id=77597
546
547         Reviewed by Dirk Schulze.
548
549         * Scripts/generate-coverage-data:
550
551 2012-02-01  Adam Barth  <abarth@webkit.org>
552
553         Update the tests to show that the mac-ews processes patches from
554         non-committers.
555
556         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
557         (EarlyWarningSytemTest.test_committer_only_ewses):
558         (EarlyWarningSytemTest.test_builder_ewses):
559
560 2012-02-01  Adam Barth  <abarth@webkit.org>
561
562         Mac-ews logs are huge
563         https://bugs.webkit.org/show_bug.cgi?id=77045
564
565         Reviewed by Eric Seidel.
566
567         In order to get the cr-linux-ews bot to run tests on EC2, we created
568         the chromium-xvfb port, which contained a number of tweaks to the
569         Chromium port's behavior.  This patch refactors those tweaks so they
570         can be shared with the mac-ews, mostly by moving them into the
571         non-interactive mode of RunTests.
572
573         * Scripts/webkitpy/common/config/ports.py:
574         (WebKitPort):
575         (WebKitPort.layout_tests_results_path):
576         (ChromiumPort.run_javascriptcore_tests_command):
577         (ChromiumXVFBPort):
578         (ChromiumXVFBPort.run_webkit_tests_command):
579         * Scripts/webkitpy/common/config/ports_mock.py:
580         (MockPort):
581         (MockPort.layout_tests_results_path):
582         * Scripts/webkitpy/common/config/ports_unittest.py:
583         (WebKitPortTest.test_chromium_xvfb_port):
584         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
585         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
586         * Scripts/webkitpy/tool/commands/queues_unittest.py:
587         (CommitQueueTest.test_commit_queue):
588         (test_rollout):
589         (test_manual_reject_during_processing):
590         * Scripts/webkitpy/tool/steps/runtests.py:
591         (RunTests.run):
592         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
593         (RunTestsTest.test_no_unit_tests):
594         * Scripts/webkitpy/tool/steps/steps_unittest.py:
595         (StepsTest.test_runtests_args):
596
597 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
598
599         Roll out r106442. It made some tests more stable but others less stable.
600
601         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
602         (PerfTestsRunner._run_tests_set):
603         (PerfTestsRunner._run_single_test):
604         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
605         (create_runner):
606         (test_run_passing_test):
607         (test_run_silent_test):
608         (test_run_failed_test):
609         (test_run_tonguey_test):
610         (test_run_timeout_test):
611         (test_run_crash_test):
612         (test_run_test_set):
613
614 2012-02-01  Lucas Forschler  <lforschler@apple.com>
615
616         Enable EWS for non-contributers.
617         https://bugs.webkit.org/show_bug.cgi?id=77576
618         
619         Reviewed by Adam Barth.
620
621         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
622         (MacEWS):
623
624 2012-02-01  Beth Dakin  <bdakin@apple.com>
625
626         https://bugs.webkit.org/show_bug.cgi?id=77383
627         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
628         -and corresponding-
629         <rdar://problem/10709560>
630
631         Reviewed by Sam Weinig.
632
633         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
634         for.
635         * MiniBrowser/mac/BrowserWindowController.m:
636         (-[BrowserWindowController awakeFromNib]):
637         * WebKitTestRunner/TestController.cpp:
638         (WTR::TestController::initialize):
639
640 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
641
642         TestWebKitAPI isn't being built on chromium bots any more
643         https://bugs.webkit.org/show_bug.cgi?id=77563
644
645         Reviewed by Dimitri Glazkov.
646
647         I accidentally dropped it in the refactoring in r105449.
648
649         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
650
651 2012-02-01  Hans Wennborg  <hans@chromium.org>
652
653         Rename WebSpeechInputResult::set() to assign()
654         https://bugs.webkit.org/show_bug.cgi?id=77540
655
656         Reviewed by Darin Fisher.
657
658         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
659         (MockWebSpeechInputController::addMockRecognitionResult):
660         (MockWebSpeechInputController::speechTaskFired):
661
662 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
663
664         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
665         https://bugs.webkit.org/show_bug.cgi?id=77542
666
667         Reviewed by Martin Robinson.
668
669         * gtk/generate-gtkdoc: Check first whether there's
670         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
671         instead.
672         (get_webkit2_options): Return just the options since the
673         pkg_config_path doesn't depend on options
674         (get_webkit1_options): Ditto.
675         (generate_doc): Helper function to create a generator and generate
676         documentation for the given pkg-config file with the given options.
677         * gtk/gtkdoc.py:
678         (GTKDoc.__init__): Don't use ** for args parameter, since it's
679         used as a dict and never expanded.
680         (PkgConfigGTKDoc.__init__): Ditto.
681
682 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
683
684         [GTK] API documentation is not installed even when building with --enable-gtk-doc
685         https://bugs.webkit.org/show_bug.cgi?id=77094
686
687         Reviewed by Martin Robinson.
688
689         * GNUmakefile.am: Add install-data-local and uninstall-local rules
690         to install/uninstall WebKit1 and WebKit2 API documentation.
691
692 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
693
694         Unreviewed, rolling out r106460.
695         http://trac.webkit.org/changeset/106460
696         https://bugs.webkit.org/show_bug.cgi?id=77552
697
698         It break unit tests if WEBKIT_TESTFONTS isn't defined.
699         (Requested by Ossy on #webkit).
700
701         * Scripts/webkitpy/layout_tests/port/qt.py:
702
703 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
704
705         [Qt] Automatic clean build feature always do clean build with --no-webkit2
706         https://bugs.webkit.org/show_bug.cgi?id=74519
707
708         Reviewed by Tor Arne Vestbø.
709
710         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
711
712         * qmake/mkspecs/features/features.prf:
713
714 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
715
716         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
717         https://bugs.webkit.org/show_bug.cgi?id=77466
718
719         Reviewed by Kenneth Rohde Christiansen.
720
721         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
722         is set or if we should raise an error.
723
724         * Scripts/webkitpy/layout_tests/port/qt.py:
725         (QtPort.setup_environ_for_server):
726
727 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
728
729         Reviewed by Martin Robinson.
730
731         [GTK] Improve FrameLoader signals. Resource loading
732         https://bugs.webkit.org/show_bug.cgi?id=49543
733
734         Support for the new loader signals in DRT.
735
736         * DumpRenderTree/gtk/DumpRenderTree.cpp:
737         (urlPath):
738         (willSendRequestCallback):
739         (urlSuitableForTestResult):
740         (descriptionSuitableForTestResult):
741         (didReceiveResponse):
742         (didFinishLoading):
743         (didFailLoadingWithError):
744         (createWebView):
745
746 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
747
748         run-perf-tests should restart DRT for each test
749         https://bugs.webkit.org/show_bug.cgi?id=77506
750
751         Reviewed by Adam Barth.
752
753         Always restart DRT when running performance tests in order to minimize the dependency between tests.
754
755         * Scripts/webkitpy/layout_tests/port/chromium.py:
756         (ChromiumDriver.stop):
757         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
758         (PerfTestsRunner._run_tests_set):
759         (PerfTestsRunner._run_single_test):
760         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
761         (create_runner):
762         (test_run_passing_test):
763         (test_run_silent_test):
764         (test_run_failed_test):
765         (test_run_tonguey_test):
766         (test_run_timeout_test):
767         (test_run_crash_test):
768         (test_run_test_set_kills_drt_per_run):
769         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
770         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
771         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
772
773 2012-01-31  Hans Wennborg  <hans@chromium.org>
774
775         Speech Input: Report speech element rect relative to window rather than frame
776         https://bugs.webkit.org/show_bug.cgi?id=76443
777
778         Reviewed by Darin Fisher.
779
780         Update LayoutTestController to allow for retrieving the speech
781         element's position used in a request.
782
783         In Chromium this is handled by the MockWebSpeechInputController;
784         adding stubs for the other implementations.
785
786         * DumpRenderTree/LayoutTestController.cpp:
787         (setMockSpeechInputDumpRectCallback):
788         (LayoutTestController::staticFunctions):
789         * DumpRenderTree/LayoutTestController.h:
790         (LayoutTestController):
791         * DumpRenderTree/chromium/LayoutTestController.cpp:
792         (LayoutTestController::LayoutTestController):
793         (LayoutTestController::setMockSpeechInputDumpRect):
794         * DumpRenderTree/chromium/LayoutTestController.h:
795         (LayoutTestController):
796         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
797         (MockWebSpeechInputController::setDumpRect):
798         (MockWebSpeechInputController::clearResults):
799         (MockWebSpeechInputController::startRecognition):
800         (MockWebSpeechInputController::MockWebSpeechInputController):
801         (makeRectResult):
802         (MockWebSpeechInputController::speechTaskFired):
803         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
804         (MockWebSpeechInputController):
805         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
806         (LayoutTestController::setMockSpeechInputDumpRect):
807         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
808         (LayoutTestController::setMockSpeechInputDumpRect):
809         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
810         (LayoutTestController::setMockSpeechInputDumpRect):
811         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
812         (LayoutTestController::setMockSpeechInputDumpRect):
813         * DumpRenderTree/qt/LayoutTestControllerQt.h:
814         (LayoutTestController):
815         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
816         (LayoutTestController::setMockSpeechInputDumpRect):
817         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
818         (LayoutTestController::setMockSpeechInputDumpRect):
819
820 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
821
822         [EFL] Add basic DRT/Efl implementation to support viewport test.
823         https://bugs.webkit.org/show_bug.cgi?id=77320
824
825         Reviewed by Andreas Kling.
826
827         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
828         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
829
830 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
831
832         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
833         https://bugs.webkit.org/show_bug.cgi?id=77473
834         <rdar://problem/10751357>
835
836         Reviewed by Darin Adler.
837
838         * DumpRenderTree/mac/EventSendingController.mm:
839         (-[EventSendingController keyDown:withModifiers:withLocation:]):
840         * WebKitTestRunner/mac/EventSenderProxy.mm:
841         (WTR::EventSenderProxy::keyDown):
842         Added a new special keyDown value to test this.
843
844 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
845
846         nrwt: fix the mock port to work with DriverProxy, reftests
847         https://bugs.webkit.org/show_bug.cgi?id=77170
848
849         Reviewed by Eric Seidel.
850
851         The DryrunPort used for benchmarking and testing NRWT has been
852         broken since we added the DriverProxy code. It isn't really
853         needed any more, so I've removed it.
854
855         The MockDRT port was also broken by DriverProxy, and moreover,
856         never worked w/ reftests. Since we don't exercise this module in
857         the unit tests, the code had also bitrotted some. I have cleaned
858         it up and made it use DriverInput and DriverOutput for
859         consistency.
860
861         * Scripts/webkitpy/layout_tests/port/dryrun.py:
862         (DryRunPort.__init__):
863         (DryRunPort):
864         (DryRunPort.real_name):
865         (DryRunPort.create_driver):
866         (DryRunPort.driver_cmd_line):
867         (DryRunPort._driver_class):
868         (DryrunDriver):
869         (DryrunDriver.run_test):
870         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
871         (MockDRTPort.create_driver):
872         (MockChromiumDRT.run_one_test):
873
874 2012-01-31  Ojan Vafai  <ojan@chromium.org>
875
876         run-webkit-tests calls out to webkit-build-directory twice
877         https://bugs.webkit.org/show_bug.cgi?id=77248
878
879         Reviewed by Dirk Pranke.
880
881         * Scripts/webkit-build-directory:
882         If called with no arguments, print out both the top-level directory and the 
883         configuration directory
884
885         * Scripts/webkitpy/layout_tests/port/config.py:
886         (Config.build_directory):
887         When called with no arguments, get and cache both the top-level and configuration directories.
888
889         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
890         (main):
891         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
892         (ConfigTest.assert_configuration):
893         (ConfigTest.test_build_directory.mock_webkit_build_directory):
894         (ConfigTest.test_build_directory):
895         (ConfigTest.test_default_configuration__notfound):
896         * Scripts/webkitpy/layout_tests/port/webkit.py:
897         (WebKitPort._build_path):
898         Cache the build directory in the options object so that other users
899         of the options object don't need to call out to webkit-build-directory.
900         Also, properly support the existing --build-directory argument.
901
902 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
903
904         Bump up the timeout for performance tests since DOM/DOMTable.html
905         and Parser/html5-full-render.html are timing out on the bot.
906
907         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
908         (PerfTestsRunner._parse_args):
909
910 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
911
912         Fix the update_webgl_conformance_tests.py script in order to enable it
913         to detect the SCM being used correctly.
914         https://bugs.webkit.org/show_bug.cgi?id=77462
915
916         Reviewed by Kenneth Russell.
917
918         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
919         (default_out_dir):
920
921 2012-01-31  Eric Seidel  <eric@webkit.org>
922
923         webkit-patch apply-from-bug should work regardless of your CWD
924         https://bugs.webkit.org/show_bug.cgi?id=77482
925
926         Reviewed by Adam Barth.
927
928         webkit-patch only ever works with patches made from the root
929         directory.  We should pass the CWD to svn-apply in the case
930         where we're running not from the webkit root.  I believe
931         this used to work in the past and regressed.
932
933         * Scripts/webkitpy/common/checkout/checkout.py:
934         (Checkout.apply_patch):
935         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
936         (CheckoutTest.test_apply_patch):
937
938 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
939
940         Unreviewed, rolling out r106302.
941         http://trac.webkit.org/changeset/106302
942         https://bugs.webkit.org/show_bug.cgi?id=77472
943
944         Broke building DRT before running the tests (Requested by ojan
945         on #webkit).
946
947         * Scripts/webkit-build-directory:
948         * Scripts/webkitpy/layout_tests/port/config.py:
949         (Config.build_directory):
950         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
951         (main):
952         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
953         (ConfigTest.assert_configuration):
954         (ConfigTest.test_build_directory.mock_webkit_build_directory):
955         (ConfigTest.test_build_directory):
956         (ConfigTest.test_default_configuration__notfound):
957         * Scripts/webkitpy/layout_tests/port/webkit.py:
958         (WebKitPort._build_path):
959
960 2012-01-31  Antoine Labour  <piman@chromium.org>
961
962         Merge WebGraphicsContext3D creation and initialization, and move it to
963         WebViewClient.
964         https://bugs.webkit.org/show_bug.cgi?id=76593
965
966         Reviewed by Darin Fisher.
967
968         * DumpRenderTree/chromium/TestWebPlugin.cpp:
969         (TestWebPlugin::TestWebPlugin):
970         (TestWebPlugin::initialize):
971         * DumpRenderTree/chromium/TestWebPlugin.h:
972         * DumpRenderTree/chromium/WebViewHost.cpp:
973         (WebViewHost::createGraphicsContext3D):
974         (WebViewHost::createPlugin):
975         * DumpRenderTree/chromium/WebViewHost.h:
976
977 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
978
979         [GTK] build-webkit warning.
980         https://bugs.webkit.org/show_bug.cgi?id=77411
981
982         Reviewed by Philippe Normand.
983
984         * Scripts/webkitdirs.pm:
985         (isCrossCompilation):
986
987 2012-01-31  Dan Bernstein  <mitz@apple.com>
988
989         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
990
991         Reviewed by Anders Carlsson.
992
993         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
994
995 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
996
997         If the QTDIR environment variable is set, the build system fails to compile WinCairo
998         https://bugs.webkit.org/show_bug.cgi?id=77112
999
1000         Reviewed by Daniel Bates.
1001
1002         * Scripts/webkitdirs.pm:
1003         (determineIsQt):
1004
1005 2012-01-31  Adam Roben  <aroben@apple.com>
1006
1007         Only call -typingAttributes on WebViews, not WebHTMLViews
1008
1009         Looks like this case was just missed in r105908.
1010
1011         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
1012
1013         Reviewed by Antti Koivisto.
1014
1015         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
1016         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
1017         earlier.
1018
1019 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1020
1021         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
1022         https://bugs.webkit.org/show_bug.cgi?id=77221
1023
1024         Reviewed by Kenneth Rohde Christiansen.
1025
1026         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
1027
1028         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1029         (MiniBrowserApplication::sendTouchEvent):
1030
1031 2012-01-26  Hans Wennborg  <hans@chromium.org>
1032
1033         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
1034         https://bugs.webkit.org/show_bug.cgi?id=77083
1035
1036         Reviewed by Darin Fisher.
1037
1038         Add MockWebSpeechInputController which provides a mock implementation
1039         of the WebSpeechInputController interface, and use that in
1040         DumpRenderTree.
1041
1042         * DumpRenderTree/DumpRenderTree.gypi:
1043         * DumpRenderTree/chromium/LayoutTestController.cpp:
1044         (LayoutTestController::addMockSpeechInputResult):
1045         * DumpRenderTree/chromium/LayoutTestController.h:
1046         ():
1047         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
1048         (MockWebSpeechInputController::create):
1049         (MockWebSpeechInputController::addMockRecognitionResult):
1050         (MockWebSpeechInputController::clearResults):
1051         (MockWebSpeechInputController::startRecognition):
1052         (MockWebSpeechInputController::cancelRecognition):
1053         (MockWebSpeechInputController::stopRecording):
1054         (MockWebSpeechInputController::MockWebSpeechInputController):
1055         (MockWebSpeechInputController::speechTaskFired):
1056         (MockWebSpeechInputController::SpeechTask::SpeechTask):
1057         (MockWebSpeechInputController::SpeechTask::stop):
1058         (MockWebSpeechInputController::SpeechTask::runIfValid):
1059         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
1060         (WebKit):
1061         (MockWebSpeechInputController):
1062         (MockWebSpeechInputController::taskList):
1063         (SpeechTask):
1064         * DumpRenderTree/chromium/TestShell.cpp:
1065         * DumpRenderTree/chromium/WebViewHost.cpp:
1066         (WebViewHost::speechInputController):
1067         * DumpRenderTree/chromium/WebViewHost.h:
1068         (WebKit):
1069         (WebViewHost::speechInputControllerMock):
1070         (WebViewHost):
1071         ():
1072
1073 2012-01-31  Hajime Morrita  <morrita@chromium.org>
1074
1075         [PerformanceTests] Add landing html for Dromaeo dom-query test
1076         https://bugs.webkit.org/show_bug.cgi?id=77329
1077
1078         Reviewed by Ryosuke Niwa.
1079
1080         Added some more ignorable output patterns to allow warnings
1081         from a third party test suite.
1082
1083         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1084         (PerfTestsRunner):
1085         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
1086
1087 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
1088
1089         [wx] Unreviewed. Update download URLs to new domain.
1090         
1091         * waf/build/build_utils.py:
1092         (update_wx_deps):
1093
1094 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
1095
1096         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
1097         to the list of build directories.
1098         
1099         * waf/build/settings.py:
1100
1101 2012-01-30  Kentaro Hara  <haraken@chromium.org>
1102
1103         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
1104         output an empty method name (i.e. "()")
1105         https://bugs.webkit.org/show_bug.cgi?id=77336
1106
1107         Reviewed by Darin Adler.
1108
1109         r105797 tried to detect a change outside methods, but it causes a bug that
1110         prepare-ChangeLog can output an empty method name, like this:
1111
1112             * foo/bar/baz.cpp:
1113             (method1):
1114             ():
1115             (method2):
1116
1117         This is because the cpp parser in prepare-ChangeLog cannot distinguish
1118         '{' as the beginning of a method with '{' as the beginning of an array definition
1119         at the top level.
1120
1121             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
1122
1123             void func() { // This '{' is the beginning of a method.
1124                 ...;
1125             }
1126
1127         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
1128
1129         * Scripts/prepare-ChangeLog:
1130         (get_function_line_ranges_for_cpp): Modified as described above.
1131         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
1132         an empty method name. Ideally this should not happen but may happen, since the
1133         parsers are not perfect.
1134         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
1135         (NameSpace7):
1136         (NameSpace8):
1137         (Class109):
1138         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1139
1140 2012-01-30  Ojan Vafai  <ojan@chromium.org>
1141
1142         run-webkit-tests calls out to webkit-build-directory twice
1143         https://bugs.webkit.org/show_bug.cgi?id=77248
1144
1145         Reviewed by Dirk Pranke.
1146
1147         This reduces to calls to webkit-build-directory to one call and
1148         saves 500ms for run-webkit-tests over a single file.
1149
1150         * Scripts/webkit-build-directory:
1151         If called with no arguments, print out both the top-level directory and the 
1152         configuration directory.
1153
1154         * Scripts/webkit-build-directory:
1155         * Scripts/webkitpy/layout_tests/port/config.py:
1156         (Config.build_directory):
1157         When called with no arguments, get and cache both the top-level and configuration directories.
1158
1159         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
1160         (main):
1161         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1162         (ConfigTest.assert_configuration):
1163         (ConfigTest.test_build_directory.mock_webkit_build_directory):
1164         (ConfigTest.test_build_directory):
1165         (ConfigTest.test_default_configuration__notfound):
1166         * Scripts/webkitpy/layout_tests/port/webkit.py:
1167         (WebKitPort._build_path):
1168         Cache the root directory in the options object so that other users
1169         of the options object don't need to call out to webkit-build-directory.
1170
1171 2012-01-30  Ojan Vafai  <ojan@chromium.org>
1172
1173         Parsing test_expecations.txt + Skipped lists takes too long
1174         https://bugs.webkit.org/show_bug.cgi?id=77059
1175
1176         Reviewed by Dirk Pranke.
1177
1178         This saves ~100ms on the Apple Mac port.
1179         -memoize a bunch of path methods.
1180         -Avoid doing multiple disk accesses per line.
1181         -Parse the skipped list directly instead of turning it into a test_expecations.txt
1182         formatting string and parsing that.
1183
1184         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1185         (TestExpectationParser):
1186         (TestExpectationParser.expectation_for_skipped_test):
1187         (TestExpectationParser._parse_line):
1188         (TestExpectationParser._collect_matching_tests):
1189         (TestExpectations.__init__):
1190         (TestExpectations._add_skipped_tests):
1191         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1192         (test_add_skipped_tests):
1193         (test_add_skipped_tests_duplicate):
1194         * Scripts/webkitpy/layout_tests/port/base.py:
1195         (Port):
1196         (Port.test_isfile):
1197         (Port.normalize_test_name):
1198         (Port.layout_tests_dir):
1199         (Port.abspath_for_test):
1200         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1201
1202 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
1203
1204         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
1205         
1206         * Scripts/webkitpy/common/config/watchlist:
1207
1208 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
1209
1210         Unreviewed build fix following bug#76855
1211
1212         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1213         ():
1214         (TestWebKitAPI::TEST_F):
1215
1216 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1217
1218         [Qt] WKTR: Use a software rendering pipiline when running tests.
1219         https://bugs.webkit.org/show_bug.cgi?id=76708
1220
1221         Reviewed by Kenneth Rohde Christiansen.
1222
1223         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1224         (WTR::WrapperWindow::WrapperWindow):
1225         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
1226
1227 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1228
1229         [Qt] Store build config immediately instead of waiting for a successfull build
1230
1231         Otherwise we will not pick up changes to the config if the build is aborted,
1232         for example due to build errors or if the user pressed Ctrl+Z. We now write
1233         the new config before starting a build, but still defer to write the SVN
1234         revision once the build completes successfully.
1235
1236         Reviewed by Ossy.
1237
1238         * Scripts/webkitdirs.pm:
1239         (buildQMakeProjects):
1240
1241 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
1242
1243         [Qt] Add "New Window" button to the Qt MiniBrowser
1244         https://bugs.webkit.org/show_bug.cgi?id=77281
1245
1246         Reviewed by Tor Arne Vestbø.
1247
1248         * MiniBrowser/qt/BrowserWindow.cpp:
1249         (BrowserWindow::BrowserWindow):
1250         * MiniBrowser/qt/MiniBrowser.qrc:
1251         * MiniBrowser/qt/icons/plus.png: Added.
1252         * MiniBrowser/qt/qml/BrowserWindow.qml:
1253
1254 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
1255
1256         Unreviewed rolling out r106222.
1257
1258         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1259         (SingleTestRunner.__init__):
1260         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1261         (Worker.handle_test_list):
1262         * Scripts/webkitpy/layout_tests/models/test_input.py:
1263         (TestInput.__init__):
1264         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1265         (_set_up_derived_options):
1266         (parse_args):
1267         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1268         (MainTest.test_repeat_each):
1269         * WebKitTestRunner/TestInvocation.cpp:
1270         (WTR::TestInvocation::setIsPixelTest):
1271
1272 2012-01-30  Hans Wennborg  <hans@chromium.org>
1273
1274         Unreviewed, rolling out r106219.
1275         http://trac.webkit.org/changeset/106219
1276         https://bugs.webkit.org/show_bug.cgi?id=77083
1277
1278         This broke Chromium's test_shell.
1279
1280         * DumpRenderTree/DumpRenderTree.gypi:
1281         * DumpRenderTree/chromium/LayoutTestController.cpp:
1282         (LayoutTestController::addMockSpeechInputResult):
1283         * DumpRenderTree/chromium/LayoutTestController.h:
1284         (WebKit):
1285         (LayoutTestController):
1286         ():
1287         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
1288         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
1289         * DumpRenderTree/chromium/TestShell.cpp:
1290         * DumpRenderTree/chromium/WebViewHost.cpp:
1291         (WebViewHost::speechInputController):
1292         * DumpRenderTree/chromium/WebViewHost.h:
1293         (WebKit):
1294         (WebViewHost::speechInputControllerMock):
1295         (WebViewHost):
1296         ():
1297
1298 2012-01-26  Hans Wennborg  <hans@chromium.org>
1299
1300         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
1301         https://bugs.webkit.org/show_bug.cgi?id=77083
1302
1303         Reviewed by Darin Fisher.
1304
1305         Add MockWebSpeechInputController which provides a mock implementation
1306         of the WebSpeechInputController interface, and use that in
1307         DumpRenderTree.
1308
1309         * DumpRenderTree/DumpRenderTree.gypi:
1310         * DumpRenderTree/chromium/LayoutTestController.cpp:
1311         (LayoutTestController::addMockSpeechInputResult):
1312         * DumpRenderTree/chromium/LayoutTestController.h:
1313         ():
1314         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
1315         (MockWebSpeechInputController::create):
1316         (MockWebSpeechInputController::addMockRecognitionResult):
1317         (MockWebSpeechInputController::clearResults):
1318         (MockWebSpeechInputController::startRecognition):
1319         (MockWebSpeechInputController::cancelRecognition):
1320         (MockWebSpeechInputController::stopRecording):
1321         (MockWebSpeechInputController::MockWebSpeechInputController):
1322         (MockWebSpeechInputController::speechTaskFired):
1323         (MockWebSpeechInputController::SpeechTask::SpeechTask):
1324         (MockWebSpeechInputController::SpeechTask::stop):
1325         (MockWebSpeechInputController::SpeechTask::runIfValid):
1326         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
1327         (WebKit):
1328         (MockWebSpeechInputController):
1329         (MockWebSpeechInputController::taskList):
1330         (SpeechTask):
1331         * DumpRenderTree/chromium/TestShell.cpp:
1332         * DumpRenderTree/chromium/WebViewHost.cpp:
1333         (WebViewHost::speechInputController):
1334         * DumpRenderTree/chromium/WebViewHost.h:
1335         (WebKit):
1336         (WebViewHost::speechInputControllerMock):
1337         (WebViewHost):
1338         ():
1339
1340 2012-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1341
1342         Unreviewed, rolling out r106109.
1343         http://trac.webkit.org/changeset/106109
1344         https://bugs.webkit.org/show_bug.cgi?id=77302
1345
1346         It made tests crash (Requested by Ossy_weekend on #webkit).
1347
1348         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1349         (WTR::WrapperWindow::WrapperWindow):
1350         (WTR::PlatformWebView::PlatformWebView):
1351
1352 2012-01-28  Nico Weber  <thakis@chromium.org>
1353
1354         [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
1355         https://bugs.webkit.org/show_bug.cgi?id=77243
1356
1357         Reviewed by Adam Barth.
1358
1359         * Scripts/update-webkit:
1360         * Scripts/webkitdirs.pm:
1361         (isChromiumNinja):
1362         (determineIsChromiumNinja):
1363         (buildChromiumNinja):
1364         (buildChromium):
1365
1366 2012-01-27  Kentaro Hara  <haraken@chromium.org>
1367
1368         The cpp parser of prepare-ChangeLog treats if(...) {} as a method
1369         https://bugs.webkit.org/show_bug.cgi?id=77241
1370
1371         Reviewed by Ryosuke Niwa.
1372
1373         The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
1374         in a method in some namespace or class is treated as a method.
1375         This patch fixes the bug.
1376
1377             class C {
1378                 void func()
1379                 {
1380                     if (1) {    // This should not be treated as a method.
1381                     }
1382                 }
1383             };
1384
1385         * Scripts/prepare-ChangeLog:
1386         (get_function_line_ranges_for_cpp):
1387         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1388         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
1389         (Class108):
1390         (Class108::func35):
1391
1392 2012-01-27  Enrica Casucci  <enrica@apple.com>
1393
1394         Followup to http://trac.webkit.org/changeset/106171.
1395         Dan Bernstein pointed out correctly that I should
1396         have used copy instead of initWithString.
1397
1398         Reviewed by Dan Bernstein.
1399
1400         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1401         (-[LocalPasteboard initWithName:]):
1402
1403 2012-01-27  Enrica Casucci  <enrica@apple.com>
1404
1405         DRT pasteboard object should return the correct pasteboard name.
1406         https://bugs.webkit.org/show_bug.cgi?id=77260
1407         
1408         Currently the name property always returns nil.
1409         Adding a memeber variable to store the pasteboard name and return its
1410         value from the name method instead of returning nil always.
1411
1412         Reviewed by Dan Bernstein.
1413
1414         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1415         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1416         (-[LocalPasteboard initWithName:]):
1417         (-[LocalPasteboard name]):
1418
1419 2012-01-27  Martin Robinson  <mrobinson@igalia.com>
1420
1421         [GTK] [WK2] Implement the policy client
1422         https://bugs.webkit.org/show_bug.cgi?id=76343
1423
1424         Reviewed by Gustavo Noronha Silva.
1425
1426         * gtk/generate-gtkdoc:
1427         (get_webkit2_options): Update the list of skipped source files to include all clients.
1428
1429 2012-01-27  Ada Chan  <adachan@apple.com>
1430
1431         Add test for WKBundleFrameGetParentFrame().
1432         https://bugs.webkit.org/show_bug.cgi?id=77161
1433
1434         Reviewed by Anders Carlsson.
1435
1436         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
1437         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
1438         (TestWebKitAPI):
1439         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
1440         (TestWebKitAPI::setInjectedBundleClient):
1441         (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
1442         Make sure the check is successful.
1443         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
1444         (TestWebKitAPI):
1445         (ParentFrameTest):
1446         (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
1447         (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
1448         If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
1449         to the test controller.
1450         (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
1451
1452 2012-01-27  Zan Dobersek  <zandobersek@gmail.com>
1453
1454         [Gtk] DumpRenderTree lacks --no-timeout command line option
1455         https://bugs.webkit.org/show_bug.cgi?id=77196
1456
1457         Reviewed by Martin Robinson.
1458
1459         Add the --no-timeout command line option and reorganize
1460         watchdog code to make running DumpRenderTree without
1461         timeout possible.
1462
1463         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1464         (setWaitToDumpWatchdog):
1465         (shouldSetWaitToDumpWatchdog):
1466         (initializeGlobalsFromCommandLineOptions):
1467         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1468         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1469         (waitToDumpWatchdogFired):
1470         (LayoutTestController::setWaitToDump):
1471
1472 2012-01-27  Andras Becsi  <andras.becsi@nokia.com>
1473
1474         [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
1475         https://bugs.webkit.org/show_bug.cgi?id=77122
1476
1477         Reviewed by Kenneth Rohde Christiansen.
1478
1479         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1480         (MiniBrowserApplication::MiniBrowserApplication):
1481
1482 2012-01-27  Zeno Albisser  <zeno@webkit.org>
1483
1484         [Qt][Mac] Build fails after adding ICU support (r105997).
1485         https://bugs.webkit.org/show_bug.cgi?id=77118
1486
1487         Define WTF_USE_ICU_UNICODE if we are on mac.
1488
1489         Reviewed by Tor Arne Vestbø.
1490
1491         * qmake/mkspecs/features/features.prf:
1492
1493 2012-01-27  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
1494
1495         Update committers.py with new contributors.
1496         https://bugs.webkit.org/show_bug.cgi?id=77207
1497
1498         I added six new contributors into committers.py:
1499
1500         - Adam Kallai
1501         - Balazs Ankes
1502         - Janos Badics
1503         - Nandor Huszka
1504         - Roland Takacs
1505         - Szilard Ledan-Muntean
1506
1507         * Scripts/webkitpy/common/config/committers.py:
1508
1509 2012-01-27  Vsevolod Vlasov  <vsevik@chromium.org>
1510
1511         Add Vsevolod Vlasov to reviewers list.
1512
1513         Reviewed by Pavel Feldman.
1514
1515         * Scripts/webkitpy/common/config/committers.py:
1516
1517 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1518
1519         [Qt] WKTR: Use a software rendering pipiline when running tests.
1520         https://bugs.webkit.org/show_bug.cgi?id=76708
1521
1522         Reviewed by Kenneth Rohde Christiansen.
1523
1524         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1525         (WTR::WrapperWindow::WrapperWindow):
1526         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
1527
1528 2012-01-26  Kevin Ollivier  <kevino@theolliviers.com>
1529
1530         [wx] Unreviewed. Build fix, add WebCore/testing/js
1531         to the list of source directories we build.
1532
1533         * waf/build/settings.py:
1534
1535 2012-01-26  Filip Pizlo  <fpizlo@apple.com>
1536
1537         Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
1538         https://bugs.webkit.org/show_bug.cgi?id=77177
1539
1540         Reviewed by Jon Honeycutt.
1541
1542         * Scripts/commit-log-editor:
1543
1544 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1545
1546         Decrease sleep time when killing server_process on Mac.
1547         https://bugs.webkit.org/show_bug.cgi?id=77169
1548
1549         Reviewed by Eric Seidel.
1550
1551         This shaves another ~70ms off single test runtime.
1552
1553         * Scripts/webkitpy/layout_tests/port/server_process.py:
1554         (ServerProcess.stop):
1555
1556 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1557
1558         Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
1559         https://bugs.webkit.org/show_bug.cgi?id=77164
1560
1561         Reviewed by Dirk Pranke.
1562
1563         http://trac.webkit.org/changeset/106035 depends on builder_name being
1564         falsey by default. There's other code that requires it to be iterable
1565         by default. So, make it be the empty string.
1566
1567         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1568         (parse_args):
1569
1570 2012-01-26  Ryosuke Niwa  <rniwa@webkit.org>
1571
1572         run-perf-test should include relative file paths in test names
1573         https://bugs.webkit.org/show_bug.cgi?id=77144
1574
1575         Reviewed by Adam Birth.
1576
1577         Include all directory names in the test name separated by "/".
1578         e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
1579
1580         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1581         (PerfTestsRunner):
1582         (PerfTestsRunner._process_parser_test_result):
1583         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1584         (test_run_test_set_with_json_output):
1585         (test_run_test_set_with_json_source):
1586
1587 2012-01-26  Dirk Pranke  <dpranke@chromium.org>
1588
1589         webkitpy: re-land cleanup of test scaffolding
1590         https://bugs.webkit.org/show_bug.cgi?id=77153
1591
1592         Reviewed by Eric Seidel.
1593
1594         This is an attempt to reland the change in bug 76973 / 
1595         r105935. My earlier attempt to manipulate PYTHONPATH
1596         seems to only work some of the time, for reasons that
1597         elude me. Directly adding Tools/Scripts to sys.path from
1598         inside the test script appears to work (more?) reliably.
1599
1600         Also, it seemed like the files didn't actually get deleted
1601         the last time; I don't know why.
1602
1603         * Scripts/test-webkitpy:
1604         * Scripts/webkitpy/common/system/executive_unittest.py:
1605         (command_line):
1606         (ExecutiveTest):
1607         (ExecutiveTest.test_run_command_args_type):
1608         (ExecutiveTest.test_run_command_with_unicode):
1609         (ExecutiveTest.test_running_pids):
1610         (main):
1611         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1612         * Scripts/webkitpy/test/cat.py: Removed.
1613         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1614         * Scripts/webkitpy/test/echo.py: Removed.
1615         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1616
1617 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1618
1619         run-webkit-tests calls "nm" when it doesn't need to
1620         https://bugs.webkit.org/show_bug.cgi?id=77143
1621
1622         Reviewed by Dirk Pranke.
1623
1624         If we are not running any test that can be skipped by checking
1625         the DRT feature list or looking at the list of symbols, avoid calling
1626         out to DRT or calling "nm".
1627
1628         This saves ~700ms on my Mac Pro. In cases where you still have to call out
1629         to "nm" it's only a couple ms slower.
1630
1631         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1632         (TestExpectations.__init__):
1633         * Scripts/webkitpy/layout_tests/port/base.py:
1634         (Port.skipped_tests):
1635         * Scripts/webkitpy/layout_tests/port/webkit.py:
1636         (WebKitPort._should_check_for_missing_features):
1637         (WebKitPort):
1638         (WebKitPort._should_check_for_missing_symbols):
1639         (WebKitPort._skipped_tests_for_unsupported_features):
1640         (WebKitPort.skipped_layout_tests):
1641         (WebKitPort.skipped_tests):
1642         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1643         (WebKitPortTest.test_skipped_directories_for_symbols):
1644         (test_skipped_directories_for_features):
1645         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
1646         (test_skipped_layout_tests):
1647
1648 2012-01-26  Benjamin Poulain  <bpoulain@apple.com>
1649
1650         Support a suffix on ChangeLog filenames based on a configuration file
1651         https://bugs.webkit.org/show_bug.cgi?id=76956
1652
1653         Reviewed by Kentaro Hara.
1654
1655         Modify the tools used to generate, edit and resolve ChangeLogs to support
1656         the addition of a suffix to the ChangeLog filename.
1657
1658         This patch makes it easier to support alternate ChangeLog files in branches.
1659
1660         * Scripts/VCSUtils.pm:
1661         (changeLogSuffix):
1662         (changeLogFileName):
1663         * Scripts/commit-log-editor:
1664         * Scripts/prepare-ChangeLog:
1665         (getLatestChangeLogs):
1666         (generateNewChangeLogs):
1667         (generateFileList):
1668         * Scripts/resolve-ChangeLogs:
1669         (findChangeLog):
1670
1671 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1672
1673         Unreviewed, rolling out r106038.
1674         http://trac.webkit.org/changeset/106038
1675         https://bugs.webkit.org/show_bug.cgi?id=77142
1676
1677         Caused a bunch of skipped tests to not be skipped. (Requested
1678         by ojan on #webkit).
1679
1680         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1681         (TestExpectationParser):
1682         (TestExpectationParser.parse):
1683         (TestExpectationParser._parse_line):
1684         (TestExpectationParser._collect_matching_tests):
1685         (TestExpectations.__init__):
1686         (TestExpectations._add_skipped_tests):
1687         * Scripts/webkitpy/layout_tests/port/base.py:
1688         (Port.test_dirs):
1689         (Port.normalize_test_name):
1690         (Port.update_baseline):
1691         (Port.layout_tests_dir):
1692         (Port.relative_perf_test_filename):
1693         (Port.abspath_for_test):
1694
1695 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1696
1697         Parsing test_expecations.txt + Skipped lists takes too long
1698         https://bugs.webkit.org/show_bug.cgi?id=77059
1699
1700         Reviewed by Dirk Pranke.
1701
1702         This saves ~100ms on the Apple Mac port.
1703         -memoize a bunch of path methods.
1704         -Avoid doing multiple disk accesses per line.
1705         -Parse the skipped list directly instead of turning it into a test_expecations.txt
1706         formatting string and parsing that.
1707
1708         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1709         (TestExpectationParser):
1710         (TestExpectationParser.parse_skipped_tests):
1711         (TestExpectationParser._parse_line):
1712         (TestExpectationParser._collect_matching_tests):
1713         (TestExpectations.__init__):
1714         (TestExpectations._add_skipped_tests):
1715         * Scripts/webkitpy/layout_tests/port/base.py:
1716         (Port):
1717         (Port.test_isfile):
1718         (Port.normalize_test_name):
1719         (Port.layout_tests_dir):
1720         (Port.abspath_for_test):
1721
1722 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1723
1724         Only store the SVN revision in the summarized results if we're on a builder
1725         https://bugs.webkit.org/show_bug.cgi?id=76976
1726
1727         Reviewed by Dirk Pranke.
1728
1729         This shaves another ~130ms off the single test run-webkit-tests runtime.
1730
1731         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1732         (summarize_results):
1733         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1734         (ResultSummaryTest.get_result):
1735         (ResultSummaryTest):
1736         (ResultSummaryTest.get_result_summary):
1737         (ResultSummaryTest.get_unexpected_results):
1738         (ResultSummaryTest.test_no_svn_revision):
1739         (ResultSummaryTest.test_svn_revision):
1740         * Scripts/webkitpy/layout_tests/port/base.py:
1741         (Port.use_trac_links_in_results_html):
1742
1743 2012-01-26  Luciano Wolf  <luciano.wolf@openbossa.org>
1744
1745         [Qt][WK2] fast/loader tests failed after r94178
1746         https://bugs.webkit.org/show_bug.cgi?id=67388
1747
1748         Reviewed by Simon Hausmann.
1749
1750         Applying the same fix used for Qt-WebKit1 from bug #67254 -
1751         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1752         https://bugs.webkit.org/show_bug.cgi?id=67254
1753         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
1754         derived from the running location of DumpRenderTree binary.
1755
1756         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1757         (WTR::LayoutTestController::pathToLocalResource):
1758
1759 2012-01-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1760
1761         Implement overridePreference for boolean preferences in WebKitTestRunner
1762         https://bugs.webkit.org/show_bug.cgi?id=77033
1763
1764         Reviewed by Alexey Proskuryakov.
1765
1766         For now overridePreference supports boolean values.
1767
1768         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1769         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1770         (WTR::LayoutTestController::setXSSAuditorEnabled):
1771         (WTR::LayoutTestController::overridePreference):
1772         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1773         * WebKitTestRunner/TestController.cpp:
1774         (WTR::TestController::resetStateToConsistentValues): Reset the overrides
1775         explicitly and properly disable the use of PageCache when resetting the
1776         state. Tests that use PageCache can now enable it via overridePreference.
1777
1778 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
1779
1780         [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
1781         https://bugs.webkit.org/show_bug.cgi?id=77100
1782
1783         Reviewed by Simon Hausmann.
1784
1785         This patch makes the MiniBrowser read multiple URL's from the command
1786         line such that there will be one browser window opened for each URL.
1787
1788         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1789         (MiniBrowserApplication::handleUserOptions):
1790
1791 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
1792
1793         [Qt] The Qt MiniBrowser crashes when given multiple URL's
1794         https://bugs.webkit.org/show_bug.cgi?id=77009
1795
1796         Reviewed by Simon Hausmann.
1797
1798         This patch fixes a crash in BrowserWindow::newWindow() where a
1799         BrowserWindow-object is constructed with a 0 pointer as the
1800         WindowOptions parameter which leads to a crash.
1801
1802         * MiniBrowser/qt/BrowserWindow.cpp:
1803         (BrowserWindow::BrowserWindow):
1804         (BrowserWindow::newWindow):
1805         * MiniBrowser/qt/BrowserWindow.h:
1806
1807 2012-01-26  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1808
1809         [Qt] Use ICU if available
1810         https://bugs.webkit.org/show_bug.cgi?id=76821
1811
1812         Reviewed by Simon Hausmann.
1813
1814         Adding unicode defines for a Qt 5 based build.
1815
1816         * qmake/mkspecs/features/features.prf:
1817
1818 2012-01-26  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1819
1820         [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
1821         https://bugs.webkit.org/show_bug.cgi?id=42545
1822
1823         Reviewed by Zoltan Herczeg.
1824
1825         Implement the setGeolocationPermission method.
1826
1827         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1828         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1829         (WTR::LayoutTestController::setGeolocationPermission):
1830         (WTR):
1831         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1832         (LayoutTestController):
1833
1834 2012-01-26  Balazs Kelemen  <kbalazs@webkit.org>
1835
1836         [NRWT] Support --ignore-metrics
1837         https://bugs.webkit.org/show_bug.cgi?id=76278
1838
1839         Reviewed by Tony Chang.
1840
1841         Port the feature from ORWT.
1842
1843         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1844         (SingleTestRunner._run_compare_test):
1845         * Scripts/webkitpy/layout_tests/port/driver.py:
1846         (DriverOutput):
1847         (DriverOutput.strip_metrics):
1848         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1849         (DriverOutputTest):
1850         (DriverOutputTest.test_strip_metrics):
1851         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1852         (_set_up_derived_options):
1853         (parse_args):
1854
1855 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1856
1857         Unreviewed, rolling out r105935 and r105954.
1858         http://trac.webkit.org/changeset/105935
1859         http://trac.webkit.org/changeset/105954
1860         https://bugs.webkit.org/show_bug.cgi?id=77080
1861
1862         test-webkitpy is still broken (Requested by abarth on
1863         #webkit).
1864
1865         * Scripts/test-webkitpy:
1866         * Scripts/webkitpy/common/system/executive_unittest.py:
1867         (never_ending_command):
1868         (ExecutiveTest.test_run_command_args_type):
1869         (ExecutiveTest.test_run_command_with_unicode):
1870         (ExecutiveTest.test_running_pids):
1871         * Scripts/webkitpy/common/system/fileutils.py:
1872         (make_stdout_binary):
1873         * Scripts/webkitpy/test/cat.py:
1874         (command_arguments):
1875         (main):
1876         * Scripts/webkitpy/test/cat_unittest.py:
1877         (CatTest):
1878         (CatTest.assert_cat):
1879         (CatTest.test_basic):
1880         (CatTest.test_no_newline):
1881         (CatTest.test_unicode):
1882         (CatTest.test_as_command):
1883         * Scripts/webkitpy/test/echo.py:
1884         (command_arguments):
1885         (main):
1886         * Scripts/webkitpy/test/echo_unittest.py:
1887         (EchoTest):
1888         (EchoTest.test_basic):
1889         (EchoTest.test_no_newline):
1890         (EchoTest.test_unicode):
1891         (EchoTest.test_argument_order):
1892         (EchoTest.test_empty_arguments):
1893         (EchoTest.test_no_arguments):
1894         (EchoTest.test_as_command):
1895
1896 2012-01-26  Gabor Rapcsanyi  <rgabor@webkit.org>
1897
1898         [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
1899         https://bugs.webkit.org/show_bug.cgi?id=76138
1900
1901         Reviewed by Martin Robinson.
1902
1903         * Scripts/webkitdirs.pm:
1904         (isCrossCompilation):
1905         (buildAutotoolsProject):
1906
1907 2012-01-25  Adam Barth  <abarth@webkit.org>
1908
1909         Kentaro is a reviewer now.  Yay!
1910
1911         * Scripts/webkitpy/common/config/committers.py:
1912
1913 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1914
1915         nrwt: running w/ no arguments fails
1916         https://bugs.webkit.org/show_bug.cgi?id=77064
1917
1918         Unreviewed, build fix.
1919
1920         This change fixes a regression introduced in r105944
1921         where running without --platform <foo> or one of the other
1922         platform switches would cause a null deref :(.
1923
1924         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1925         (main):
1926
1927 2012-01-25  Eric Seidel  <eric@webkit.org>
1928
1929         Automatically CC someone from Apple on any changes to Obj-C public API
1930         https://bugs.webkit.org/show_bug.cgi?id=77053
1931
1932         Reviewed by Timothy Hatcher.
1933
1934         This has long been de-facto practice, seems now that we have
1935         fancy watchlist support, we should just make the tools
1936         do this automatically.
1937
1938         * Scripts/webkitpy/common/config/watchlist:
1939
1940 2012-01-25  Antoine Labour  <piman@chromium.org>
1941
1942         Updating status in committers.py.
1943
1944         Unreviewed.
1945
1946         * Scripts/webkitpy/common/config/committers.py:
1947
1948 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1949
1950         test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
1951         https://bugs.webkit.org/show_bug.cgi?id=77058
1952
1953         Reviewed by Eric Seidel.
1954
1955         r105935 broke executive_unittest by changing which script we
1956         were running and not ensuring that the PYTHONPATH was set up
1957         properly.
1958
1959         This change also fixes a regression introduced recently where
1960         test-webkitpy wasn't figuring out the path to Tools/Scripts
1961         right, either (so running ./test-webkitpy would fail).
1962
1963         * Scripts/test-webkitpy:
1964         * Scripts/webkitpy/common/system/executive_unittest.py:
1965         (script_dir):
1966         (ExecutiveTest.setUp):
1967         (ExecutiveTest):
1968         (ExecutiveTest.tearDown):
1969
1970 2012-01-25  Adam Barth  <abarth@webkit.org>
1971
1972         Disable tests on the mac-ews while we sort out hte stability issues.
1973
1974         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1975         (MacEWS):
1976
1977 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
1978
1979         investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
1980         https://bugs.webkit.org/show_bug.cgi?id=76475
1981
1982         Reviewed by Eric Seidel.
1983
1984         This patch cleans up the internal usage of port names for the
1985         Apple mac and Apple win ports so that 'mac' and 'win are never
1986         considered "fully specified" port names: they are still legal
1987         input to the PortFactory.get() routine, but only if run on the given
1988         platform (i.e. trying to PortFactory.get('mac') on windows or
1989         linux will return an error, since we don't know which version of
1990         the port is desired.
1991
1992         This also cleans up handling of the webkit2 variants, so that
1993         the full port names consistently follow the
1994         <operating_system>-<version>[-<wk2>] convention.
1995
1996         Lastly this patch adds some assertions and removes some
1997         try/catch logic to catch more programming and usage errors;
1998         previously mac-tiger might've been allowed -- and it would've
1999         translated into using just the baselines in platform/mac -- but
2000         now it should fail.
2001
2002         * Scripts/webkitpy/layout_tests/port/apple.py:
2003         (ApplePort.determine_full_port_name):
2004         (ApplePort.__init__):
2005         (ApplePort):
2006         (ApplePort._port_name_with_version):
2007         * Scripts/webkitpy/layout_tests/port/builders.py:
2008         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2009         (FactoryTest.test_mac):
2010         (FactoryTest.test_win):
2011         * Scripts/webkitpy/layout_tests/port/mac.py:
2012         (MacPort.baseline_search_path):
2013         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2014         (MacTest.test_versions):
2015         * Scripts/webkitpy/layout_tests/port/win.py:
2016         (WinPort.baseline_search_path):
2017         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2018         (WinTest.test_versions):
2019
2020 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
2021
2022         webkitpy: print nicer errors while linting expectations files, remove redundant tests
2023         https://bugs.webkit.org/show_bug.cgi?id=76955
2024
2025         Reviewed by Adam Barth.
2026
2027         This change cleans up the errors that are printed so that the
2028         are more "quickfix" compatible (path:lineno).
2029
2030         Also, there were a bunch of redundant tests between
2031         layout_tests.models.test_expectations_unittest and
2032         style.checkers.test_expectations_unittest. The latter should
2033         just expect the former to do most of the testing.
2034
2035         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2036         (TestExpectationParser._parse_modifiers):
2037         (TestExpectations._report_errors):
2038         (TestExpectations._add_skipped_tests):
2039         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2040         (test_parse_error_nonfatal):
2041         (SemanticTests.test_bad_bugid):
2042         * Scripts/webkitpy/style/checkers/test_expectations.py:
2043         (TestExpectationsChecker.__init__):
2044         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2045         (TestExpectationsTestCase.assert_lines_lint):
2046         (TestExpectationsTestCase.test_valid_expectations):
2047         (TestExpectationsTestCase.test_invalid_expectations):
2048         (TestExpectationsTestCase.test_tab):
2049
2050 2012-01-25  Eric Seidel  <eric@webkit.org>
2051
2052         webkit-patch apply-* should always continue after failures
2053         https://bugs.webkit.org/show_bug.cgi?id=77057
2054
2055         Reviewed by Adam Barth.
2056
2057         As far as I can tell there is only one potential drawback to always
2058         forcing: that if you're somehow in the wrong directory it will create new
2059         directories for new files.  Since webkit-patch always cd's to the root
2060         it seems that's not a drawback.  The drawback of not using --force for
2061         svn-apply, is that it will stop after the first failure, which is rarely
2062         (if ever) the desired behavior.  This just removes the force option
2063         (which was strangely hidden behind --non-interactive).  This should
2064         make for a better user experiance.
2065
2066         * Scripts/webkitpy/common/checkout/checkout.py:
2067         (Checkout.apply_patch):
2068         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2069         (MockCheckout.apply_patch):
2070         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2071         (CheckoutTest.test_chromium_deps):
2072         (CheckoutTest):
2073         (CheckoutTest.test_apply_patch):
2074         * Scripts/webkitpy/tool/commands/download_unittest.py:
2075         (DownloadCommandsTest._default_options):
2076         * Scripts/webkitpy/tool/steps/applypatch.py:
2077         (ApplyPatch.options):
2078         (ApplyPatch.run):
2079         * Scripts/webkitpy/tool/steps/options.py:
2080         (Options):
2081
2082 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
2083
2084         nrwt: should be able to run --platform test interactively
2085         https://bugs.webkit.org/show_bug.cgi?id=76959
2086
2087         Reviewed by Adam Barth.
2088
2089         As part of refactoring the Port interfaces, in r103254 I made
2090         passing a Host object to the Port mandatory; previously TestPort
2091         objects would create their own (mock) hosts. However,
2092         new-run-webkit-tests always passed a real Host, not a MockHost,
2093         and so you couldn't run new-run-webkit-tests --platform test
2094         interactively to debug test failures.
2095
2096         This change fixes that by creating a MockHost instead of a real
2097         host if you say --platform test*.
2098
2099         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2100         (main):
2101
2102 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
2103
2104         run-webkit-tests --lint-test-files should lint all the ports by default
2105         https://bugs.webkit.org/show_bug.cgi?id=76749
2106
2107         Reviewed by Ojan Vafai.
2108
2109         Currently run-webkit-tests --lint-test-files will only lint the
2110         test_expectations for the single port determined by the command
2111         line options. This is not obvious and can produce unintended results
2112         if you want to lint the chromium port (probably the normal case
2113         for using --lint-test-files) but don't specify a port name or
2114         --chromium.
2115
2116         I think we should probably lint *all* of the ports if no port
2117         name is supplied. This change implements that, and also moves
2118         the linting logic out of the Manager class, since this really
2119         has nothing to do with Managers. It has little to do with
2120         run-webkit-tests, but splitting it into a different script would
2121         introduce compatibility issues. It might make sense to do that
2122         anyway, in a separate patch and combining that with cleaning up
2123         the style checker to share more code.
2124
2125         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2126         (Manager._strip_test_dir_prefix):
2127         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2128         (lint):
2129         (run):
2130         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2131         (LintTest.test_all_configurations): added.
2132         (LintTest.test_lint_test_files): added.
2133         (LintTest.test_lint_test_files__errors): added.
2134         (MainTest.test_lint_test_files): removed.
2135         (MainTest.test_lint_test_files__errors): removed.
2136
2137 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
2138
2139         webkitpy: clean up a bunch of test scaffolding
2140         https://bugs.webkit.org/show_bug.cgi?id=76973
2141
2142         Reviewed by Eric Seidel.
2143
2144         There were several helper modules in the webkitpy.test package
2145         that appear to only be used by executive_unittest.py. I am
2146         rolling them all into that file to make that clearer.
2147
2148         * Scripts/webkitpy/common/system/executive_unittest.py:
2149         (ExecutiveTest.test_run_command_args_type):
2150         (ExecutiveTest.test_run_command_with_unicode):
2151         (ExecutiveTest.test_running_pids):
2152         (command_line):
2153         (main):
2154         * Scripts/webkitpy/common/system/fileutils.py: Removed.
2155         * Scripts/webkitpy/test/cat.py: Removed.
2156         * Scripts/webkitpy/test/cat_unittest.py: Removed.
2157         * Scripts/webkitpy/test/echo.py: Removed.
2158         * Scripts/webkitpy/test/echo_unittest.py: Removed.
2159
2160 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
2161
2162         webkitpy: clean up a bunch of test scaffolding
2163         https://bugs.webkit.org/show_bug.cgi?id=76973
2164
2165         Reviewed by Eric Seidel.
2166
2167         There were several helper modules in the webkitpy.test package
2168         that appear to only be used by executive_unittest.py. I am
2169         rolling them all into that file to make that clearer.
2170
2171         * Scripts/webkitpy/common/system/executive_unittest.py:
2172         (ExecutiveTest.test_run_command_args_type):
2173         (ExecutiveTest.test_run_command_with_unicode):
2174         (ExecutiveTest.test_running_pids):
2175         (command_line):
2176         (main):
2177         * Scripts/webkitpy/common/system/fileutils.py: Removed.
2178         * Scripts/webkitpy/test/cat.py: Removed.
2179         * Scripts/webkitpy/test/cat_unittest.py: Removed.
2180         * Scripts/webkitpy/test/echo.py: Removed.
2181         * Scripts/webkitpy/test/echo_unittest.py: Removed.
2182
2183 2012-01-25  Eric Seidel  <eric@webkit.org>
2184
2185         Remove Python 2.5 support from WebKit
2186         https://bugs.webkit.org/show_bug.cgi?id=71593
2187
2188         Reviewed by Adam Barth.
2189
2190         Just removing support from this one core file.
2191         I'll commit the rest of the (large) change once we've
2192         gone 24 hours and seen that no bots have exploded.
2193         We can roll out this one change if we break bots
2194         and then roll in the rest once those bots are fixed.
2195
2196         * Scripts/webkitpy/common/system/executive.py:
2197         (Executive.cpu_count):
2198
2199 2012-01-25  Hajime Morita  <morrita@google.com>
2200
2201         ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
2202         https://bugs.webkit.org/show_bug.cgi?id=76863
2203
2204         Reviewed by Dimitri Glazkov.
2205
2206         Added a feature flag.
2207
2208         * Scripts/build-webkit:
2209         * qmake/mkspecs/features/features.prf:
2210
2211 2012-01-25  Martin Robinson  <mrobinson@igalia.com>
2212
2213         [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
2214         https://bugs.webkit.org/show_bug.cgi?id=76344
2215
2216         Reviewed by Sam Weinig.
2217
2218         Add a test verifying that the mouse button during policy decisions for
2219         events not triggered by mouse events is NoButton.
2220
2221         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2222         (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
2223         (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
2224
2225 2012-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2226
2227         run-perf-tests should timeout sooner
2228         https://bugs.webkit.org/show_bug.cgi?id=77026
2229
2230         Reviewed by Adam Barth.
2231
2232         Bump off the timeout from 10 minutes to 4 minutes.
2233
2234         Also use float instead of str in test result values to compress the size of json files bots upload.
2235
2236         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2237         (PerfTestsRunner._parse_args):
2238         (PerfTestsRunner._process_chromium_style_test_result):
2239         (PerfTestsRunner._process_parser_test_result):
2240         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2241         (test_run_test_set_for_parser_tests):
2242         (test_run_test_set_with_json_output):
2243         (test_run_test_set_with_json_source):
2244
2245 2012-01-25  Enrica Casucci  <enrica@apple.com>
2246
2247         WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2248         https://bugs.webkit.org/show_bug.cgi?id=76951
2249         <rdar://problem/9325158>
2250
2251         Reviewed by Alexey Proskuryakov.
2252
2253         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
2254         and WebHTMLView.
2255         (TestWebKitAPI::TEST):
2256
2257 2012-01-23  MORITA Hajime  <morrita@google.com>
2258
2259         [Refactoring][Internals] Should have InternalSettings
2260         https://bugs.webkit.org/show_bug.cgi?id=76424
2261
2262         Reviewed by Kent Tamura.
2263
2264         * GNUmakefile.am: Added so new files.
2265
2266 2012-01-25  Takashi Toyoshima  <toyoshim@chromium.org>
2267
2268         webkitpy: new-run-webkit-websocket is broken
2269         https://bugs.webkit.org/show_bug.cgi?id=76999
2270
2271         Reviewed by Dirk Pranke.
2272
2273         r105674 broke new-run-webkit-websocket, since options.chromium
2274         doesn't exist any more. new-run-webkit-httpd was also broken
2275         and already fixed at r105835.
2276         * Scripts/new-run-webkit-websocketserver:
2277         (main):
2278
2279 2012-01-25  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
2280
2281         [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
2282         https://bugs.webkit.org/show_bug.cgi?id=63458
2283
2284         Reviewed by Adam Roben.
2285
2286         Implement the setPopupBlockingEnabled method.
2287
2288         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2289         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2290         (WTR::LayoutTestController::setPopupBlockingEnabled):
2291         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2292
2293 2012-01-24  Balazs Kelemen  <kbalazs@webkit.org>
2294
2295         [Qt] Cleanup testfonts handling
2296         https://bugs.webkit.org/show_bug.cgi?id=76068
2297
2298         Reviewed by Simon Hausmann.
2299
2300         Factor test font initialization into it's own file  so test
2301         font users can share the implementation by adding the file
2302         to their build.
2303         Use fonts.conf from the test font directory to not require the
2304         current directory to be the WebKit root.
2305         Fix the -use-test-fonts option of QtTestBrowser by initializing
2306         the fonts earlier, before it is too late (namely before calling
2307         show on the main window).
2308
2309         * DumpRenderTree/qt/DumpRenderTree.pro:
2310         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2311         (WebCore::DumpRenderTree::open):
2312         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2313         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
2314         (WebKit::initializeTestFonts):
2315         * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
2316         * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
2317         we will use the one from the test fonts directory.
2318         * DumpRenderTree/qt/main.cpp:
2319         (main): Fix the ifdefs to make it clear that the code to
2320         set up the Dpi has not been ported to Qt5 yet.
2321         * QtTestBrowser/QtTestBrowser.pro:
2322         * QtTestBrowser/launcherwindow.h:
2323         (WindowOptions::WindowOptions):
2324         * QtTestBrowser/main.cpp:
2325         (launcherMain):
2326         (LauncherApplication::handleUserOptions):
2327         * WebKitTestRunner/InjectedBundle/Target.pri:
2328         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2329         (WTR::activateFonts): Remove the code to set up the Dpi
2330         because it does not work with Qt5.
2331
2332 2012-01-25  Simon Hausmann  <simon.hausmann@nokia.com>
2333
2334         [Qt] build-webkit --qt requires a git-svn or SVN checkout.
2335
2336         Reviewed by Tor Arne Vestø.
2337
2338         Don't require it by making svnRevisionForDirectory return "unknown"
2339         instead of bailing out with an error.
2340
2341         * Scripts/VCSUtils.pm:
2342         (svnRevisionForDirectory):
2343
2344 2012-01-25  Adam Barth  <abarth@webkit.org>
2345
2346         Temporarily disable running the unit tests on the Chromium EWS.  These
2347         tests don't work properly (see
2348         https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
2349         blocking the EWS.
2350
2351         * Scripts/webkitpy/common/config/ports.py:
2352         (ChromiumPort):
2353
2354 2012-01-25  Adam Barth  <abarth@webkit.org>
2355
2356         Update results.html version of PixelZoomer
2357         https://bugs.webkit.org/show_bug.cgi?id=76965
2358
2359         Reviewed by Ojan Vafai.
2360
2361         Improve readability as suggested by Ojan.
2362
2363         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
2364
2365 2012-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2366
2367         [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
2368         https://bugs.webkit.org/show_bug.cgi?id=76899
2369
2370         Reviewed by Martin Robinson.
2371
2372         * gtk/generate-gtkdoc:
2373         (get_webkit2_options): WebKitWebLoaderClient has been renamed to
2374         WebKitLoaderClient.
2375
2376 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2377
2378         Build fix. Trigger Chromium Mac Release (Perf) on new commits.
2379
2380         * BuildSlaveSupport/build.webkit.org-config/config.json:
2381
2382 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2383
2384         WebKit needs public performance tests running on public bots
2385         https://bugs.webkit.org/show_bug.cgi?id=10266
2386
2387         Reviewed by Adam Barth.
2388
2389         Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
2390         and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
2391
2392         * BuildSlaveSupport/build.webkit.org-config/config.json:
2393         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2394         (RunAndUploadPerfTests):
2395         (RunAndUploadPerfTests.start):
2396         (UploadPerfTestResults):
2397         (BuildAndPerfTestFactory):
2398         (BuildAndPerfTestFactory.__init__):
2399
2400 2012-01-24  Ojan Vafai  <ojan@chromium.org>
2401
2402         Initializing the browser property of the Bugzilla class takes too long
2403         https://bugs.webkit.org/show_bug.cgi?id=76960
2404
2405         Reviewed by Adam Barth.
2406
2407         Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
2408         on my Mac Pro.
2409
2410         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2411         (Bugzilla.__init__):
2412         (Bugzilla._get_browser):
2413         (Bugzilla):
2414         (Bugzilla._set_browser):
2415
2416 2012-01-24  Mark Rowe  <mrowe@apple.com>
2417
2418         Death to JavaScriptGlue.
2419
2420         Rubber-stamped by Geoffrey Garen.
2421
2422         * BuildSlaveSupport/build-launcher-app:
2423         (copyNightlyLauncher):
2424         * Scripts/build-webkit:
2425         * Scripts/do-file-rename:
2426         * Scripts/do-webcore-rename:
2427         * Scripts/webkitpy/common/config/build.py:
2428         (_should_file_trigger_build):
2429         * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
2430         path in conjunction with a cross-platform path.
2431         (ShouldBuildTest):
2432
2433 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2434
2435         webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
2436         https://bugs.webkit.org/show_bug.cgi?id=75836
2437
2438         Reviewed by David Kilzer.
2439
2440         Previously parser_unittests.pl can just test the returned value of
2441         get_function_line_ranges() in prepare-ChangeLog. This patch fixes
2442         parser_unittests.pl so that it also tests the stdout and stderr of
2443         get_function_line_ranges().
2444
2445         This patch adds css_unittests_warning.css, which contains test cases
2446         for warning messages of the CSS parser of prepare-ChangeLog.
2447
2448         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2449         (captureOutput): Captures the stdout and stderr of a given method.
2450         (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
2451         string to relative paths.
2452
2453         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
2454         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
2455         (element1):
2456         (element2):
2457         (element3):
2458         (element4):
2459         ():
2460         (element5):
2461         (element6):
2462
2463         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2464         Just updated the test results, i.e. added stdout and stderr results.
2465         No essential changes in the test results.
2466         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
2467         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
2468         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
2469         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
2470         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
2471
2472 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
2473
2474         webkitpy: new-run-webkit-httpd is broken
2475         https://bugs.webkit.org/show_bug.cgi?id=76963
2476
2477         Reviewed by Adam Barth.
2478
2479         r105674 broke new-run-webkit-httpd, since options.chromium
2480         doesn't exist any more. We didn't catch this because we don't
2481         run the integration tests by default anywhere :(.
2482
2483         * Scripts/new-run-webkit-httpd:
2484         (run):
2485         (main):
2486
2487 2012-01-24  Adam Barth  <abarth@webkit.org>
2488
2489         garden-o-matic pixel zoomer should let you look at every pixel of the image
2490         https://bugs.webkit.org/show_bug.cgi?id=76962
2491
2492         Reviewed by Ojan Vafai.
2493
2494         Previously, you couldn't get up to the right and bottom pixels.
2495
2496         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
2497
2498 2012-01-24  Enrica Casucci  <enrica@apple.com>
2499
2500         WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2501         https://bugs.webkit.org/show_bug.cgi?id=76951
2502         <rdar://problem/9325158>
2503
2504         Added test to verify that WebHTMLView supports the typingAttributes method and that it
2505         works as expected.
2506         
2507         Reviewed by Alexey Proskuryakov.
2508
2509         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2510         (TestWebKitAPI::TEST):
2511
2512 2012-01-24  James Robinson  <jamesr@chromium.org>
2513
2514         Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
2515         https://bugs.webkit.org/show_bug.cgi?id=76884
2516
2517         Reviewed by Adam Barth.
2518
2519         * Scripts/webkitpy/tool/bot/irc_command.py:
2520         (Rollout.execute):
2521         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2522         (SheriffIRCBotTest.test_rollout):
2523         (SheriffIRCBotTest.test_revert):
2524         (SheriffIRCBotTest.test_multi_rollout):
2525         (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
2526         (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
2527         (SheriffIRCBotTest.test_rollout_invalidate_reason):
2528         (test_multi_rollout_invalidate_reason):
2529
2530 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2531
2532         The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
2533         https://bugs.webkit.org/show_bug.cgi?id=75531
2534
2535         Reviewed by David Kilzer.
2536
2537         Previously, the cpp parser of prepare-ChangeLog could not detect a change
2538         outside methods. Consider the following cpp file.
2539
2540             namespace N {
2541             int a;     // this change does not appear on ChangeLog.
2542             class C {
2543                 int b;     // this change does not appear on ChangeLog.
2544                 void f()
2545                 {
2546                     int c;     // this change appears on ChangeLog.
2547                 }
2548                 int d;     // this change does not appear on ChangeLog.
2549             };
2550             int e;     // this change does not appear on ChangeLog.
2551             };
2552
2553         The previous prepare-ChangeLog outputs just methods in which a change is found:
2554             (N::C::f):
2555
2556         This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
2557         and methods in which a change is found:
2558             (N):
2559             (N::C):
2560             (N::C::f):
2561
2562         * Scripts/prepare-ChangeLog:
2563         (get_function_line_ranges_for_cpp): Modified as described above.
2564
2565         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
2566         (Class104):
2567         (Class105):
2568         (Class106):
2569         (Class106::func32):
2570         (Class106::func33):
2571         (NameSpace3):
2572         (NameSpace4):
2573         (NameSpace5):
2574         (NameSpace6):
2575         (Class107):
2576         (NameSpace5::NameSpace6::Class107::func34):
2577         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2578
2579 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2580
2581         prepare-ChangeLog outputs warnings for top-level { ... } blocks
2582         https://bugs.webkit.org/show_bug.cgi?id=75943
2583
2584         Reviewed by David Kilzer.
2585
2586         Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
2587         because it does not distinguish '}' at the end of a subroutine
2588         with '}' at the end of a if or for statement.
2589
2590         foo.pl:
2591             if (1) {
2592             }
2593             for (@v) {
2594             }
2595
2596         output:
2597             nested functions found at top-level at foo.pl:2
2598             nested functions found at top-level at foo.pl:4
2599
2600         This patch fixes the bug.
2601
2602         * Scripts/prepare-ChangeLog:
2603         (get_function_line_ranges_for_perl):
2604         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2605         Added test cases. No change in the test results.
2606
2607 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
2608
2609         r105674 broke check-webkit-style for chromium's test_expectations.
2610
2611         Unreviewed, build fix.
2612         
2613         We now need to pass in a platform name of 'chromium' if we want
2614         the chromium port; options.chromium is no longer recognized. I
2615         will follow this patch up with a separate patch that has a test,
2616         but this at least fixes the build.
2617
2618         * Scripts/webkitpy/style/checkers/test_expectations.py:
2619         (TestExpectationsChecker._determine_port_from_exepectations_path):
2620
2621 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2622
2623         check-webkit-style of the chromium test_expectations.txt file takes too long
2624         https://bugs.webkit.org/show_bug.cgi?id=76745
2625
2626         Reviewed by Dimitri Glazkov.
2627
2628         When in lint mode, have TestExpectations test all configurations instead
2629         of looping over each configuration. This also has the benefit of making
2630         the error output considerably more concise.
2631
2632         Also, got rid of the double-printing of errors when linting through check-webkit-style.
2633
2634         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2635         (Manager.lint):
2636         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2637         (TestExpectations._report_errors):
2638         (TestExpectations._add_expectations):
2639         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2640         (test_parse_error_nonfatal):
2641         (test_error_on_different_platform):
2642         * Scripts/webkitpy/style/checkers/test_expectations.py:
2643         (TestExpectationsChecker.check_test_expectations):
2644         (TestExpectationsChecker.check):
2645         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2646         (TestExpectationsTestCase.test_determine_port_from_exepectations_path):
2647         (TestExpectationsTestCase.assert_lines_lint):
2648
2649 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2650
2651         Another build fix attempt after r105543.
2652
2653         * Scripts/webkitpy/common/net/file_uploader.py:
2654         (FileUploader.upload_as_multipart_form_data):
2655
2656 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2657
2658         Build fix attempt after r105543.
2659
2660         * Scripts/webkitpy/common/net/file_uploader.py:
2661         (FileUploader.upload_as_multipart_form_data):
2662
2663 2012-01-24  Vincent Scheib  <scheib@chromium.org>
2664
2665         [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree
2666         https://bugs.webkit.org/show_bug.cgi?id=76411
2667
2668         Reviewed by Adam Barth.
2669
2670         Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
2671         into a series of patches, this change adds a trivial
2672         pointer lock implementation to the Chromium port's DumpRenderTree
2673         and exposes LayoutTestController hooks to force failure conditions.
2674
2675         * DumpRenderTree/chromium/LayoutTestController.cpp:
2676         (LayoutTestController::LayoutTestController):
2677         (LayoutTestController::didLosePointerLock):
2678         (LayoutTestController::setPointerLockWillFailAsynchronously):
2679         (LayoutTestController::setPointerLockWillFailSynchronously):
2680         * DumpRenderTree/chromium/LayoutTestController.h:
2681         * DumpRenderTree/chromium/WebViewHost.cpp:
2682         (WebViewHost::requestPointerLock):
2683         (WebViewHost::requestPointerUnlock):
2684         (WebViewHost::isPointerLocked):
2685         (WebViewHost::didCompletePointerLock):
2686         (WebViewHost::didNotCompletePointerLock):
2687         (WebViewHost::didLosePointerLock):
2688         (WebViewHost::reset):
2689         * DumpRenderTree/chromium/WebViewHost.h:
2690         (WebViewHost::setPointerLockWillFailAsynchronously):
2691         (WebViewHost::setPointerLockWillFailSynchronously):
2692
2693 2012-01-24  Mario Sanchez Prada  <msanchez@igalia.com>
2694
2695         Unreviewed, skip WK2 API test timing out on some GTK bots.
2696
2697         WebKit2APITests/TestDownloads is consistently timing out on the
2698         32bit release and 64bit debug bots.
2699
2700         * Scripts/run-gtk-tests:
2701         (TestRunner): Skip WebKit2APITests/TestDownloads.
2702
2703 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2704
2705         [Qt] Fix the build with the newes Qt5 hashes
2706         https://bugs.webkit.org/show_bug.cgi?id=76657
2707
2708         Reviewed by Simon Hausmann.
2709
2710         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2711         (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
2712         for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
2713
2714 2012-01-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2715
2716         [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
2717
2718         We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
2719         building with MinGW inside cmd.exe will require the same construct. Instead
2720         we assume that when the first character in PWD is a '/' we're running under
2721         Cygwin, and use the normal unix way of setting environment variables.
2722
2723         Reviewed by Simon Hausmann.
2724
2725         * qmake/mkspecs/features/default_pre.prf:
2726
2727 2012-01-24  Simon Hausmann  <simon.hausmann@nokia.com>
2728
2729         Some qmake build files must include Qt5's "quick" module.
2730         https://bugs.webkit.org/show_bug.cgi?id=76671
2731
2732         Unreviewed build fix.
2733
2734         * MiniBrowser/qt/MiniBrowser.pro:
2735         * WebKitTestRunner/Target.pri:
2736
2737 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2738
2739         [Qt] Fix the event timestamps for touch mocking
2740
2741         Reviewed by Simon Hausmann.
2742
2743         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2744         (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
2745         timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
2746
2747 2012-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2748
2749         [GTK] Implement DownloadClient in WebKit2 GTK+ API
2750         https://bugs.webkit.org/show_bug.cgi?id=72952
2751
2752         Reviewed by Martin Robinson.
2753
2754         * gtk/generate-gtkdoc:
2755         (get_webkit2_options): Ignore WebKitDownloadClient.
2756
2757 2012-01-23  Zan Dobersek  <zandobersek@gmail.com>
2758
2759         [GTK] editing/deleting/5408255.html results are incorrect
2760         https://bugs.webkit.org/show_bug.cgi?id=53644
2761
2762         Reviewed by Martin Robinson.
2763
2764         WEBKIT_TOP_LEVEL environment variable is now set directly in either
2765         WebKitTestRunner or DumpRenderTree through usage of a compilation-time
2766         macro. This way both tools can be run outside the test harness without
2767         the need to manually set the environment variable.
2768
2769         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2770         (getTopLevelPath):
2771         * GNUmakefile.am:
2772         * Scripts/webkitpy/layout_tests/port/gtk.py:
2773         (GtkPort.setup_environ_for_server):
2774         * WebKitTestRunner/GNUmakefile.am:
2775         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2776         (WTR::InjectedBundle::platformInitialize):
2777
2778 2012-01-23  Dmitry Lomov  <dslomov@google.com>
2779
2780         [Chromium] Implement layoutTestController.workerThreadCount in DRT
2781         https://bugs.webkit.org/show_bug.cgi?id=74653.
2782
2783         Reviewed by Darin Fisher.
2784
2785         * DumpRenderTree/chromium/LayoutTestController.cpp:
2786         (LayoutTestController::LayoutTestController):
2787         (LayoutTestController::workerThreadCount):
2788         * DumpRenderTree/chromium/LayoutTestController.h:
2789
2790 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2791
2792         nrwt: make --chromium work like --qt
2793         https://bugs.webkit.org/show_bug.cgi?id=76875
2794
2795         Reviewed by Adam Barth.
2796
2797         --chromium used to have to be handled differently from --qt
2798         due to the way the PortFactory was implemented; there's not
2799         really a good reason for that any more so this patch makes
2800         things slightly more consistent and eliminates the
2801         options.chromium flag (--chromium is now truly a synonym for
2802         --platform chromium).
2803
2804         * Scripts/webkitpy/layout_tests/port/factory.py:
2805         (PortFactory._default_port):
2806         (PortFactory.get):
2807         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2808         (FactoryTest.setUp):
2809         (FactoryTest.test_chromium_mac):
2810         (FactoryTest.test_chromium_linux):
2811         (FactoryTest.test_chromium_win):
2812         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2813         (parse_args):
2814
2815 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2816
2817         run-webkit-tests needs to propagate --chromium
2818         https://bugs.webkit.org/show_bug.cgi?id=76870
2819
2820         Reviewed by Eric Seidel.
2821
2822         run-webkit-tests removes '--chromium' argument from @ARGV when
2823         determining which port to run, which means that that doesn't
2824         propagate to new-run-webkit-tests. That's bad (and is handled
2825         for the other ports by re-adding the flag, but apparently we're
2826         just now noticing for Chromium).
2827
2828         * Scripts/run-webkit-tests:
2829
2830 2012-01-23  Brian Weinstein  <bweinstein@apple.com>
2831
2832         More build fixing after r105646.
2833
2834         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2835         (TestWebKitAPI::TestNode::key):
2836
2837 2012-01-23  Gavin Barraclough  <barraclough@apple.com>
2838
2839         Unreviewed build fix - r105646 broke this.
2840
2841         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2842         (TestWebKitAPI::TestNode::TestNode):
2843         (TestWebKitAPI::TestNode::key):
2844         (TestWebKitAPI::RedBlackTreeTest::assertEqual):
2845         (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
2846         (TestWebKitAPI::RedBlackTreeTest::testDriver):
2847
2848 2012-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2849
2850         Unreviewed, rolling out r105658.
2851         http://trac.webkit.org/changeset/105658
2852         https://bugs.webkit.org/show_bug.cgi?id=76883
2853
2854         We want this eventually, but not right at this moment
2855         (Requested by abarth on #webkit).
2856
2857         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2858
2859 2012-01-23  Adam Barth  <abarth@webkit.org>
2860
2861         garden-o-matic should support Chromium Mac Lion
2862         https://bugs.webkit.org/show_bug.cgi?id=76880
2863
2864         Reviewed by Eric Seidel.
2865
2866         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2867
2868 2012-01-23  Emil A Eklund  <eae@chromium.org>
2869
2870         check-webkit-style whitespace/operators triggers on overloaded division operator
2871         https://bugs.webkit.org/show_bug.cgi?id=76650
2872
2873         Reviewed by Darin Adler.
2874
2875         * Scripts/webkitpy/style/checkers/cpp.py:
2876         (check_spacing):
2877         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2878         (CppStyleTest.test_operator_methods):
2879
2880 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2881
2882         run-perf-tests should report server-side errors
2883         https://bugs.webkit.org/show_bug.cgi?id=76802
2884
2885         Reviewed by Tony Chang.
2886
2887         Report errors whenever server's response doesn't match "OK".
2888
2889         * Scripts/webkitpy/common/net/file_uploader.py:
2890         (FileUploader.upload_single_text_file):
2891         (FileUploader.upload_as_multipart_form_data):
2892         (FileUploader._upload_data.callback):
2893         (FileUploader):
2894         (FileUploader._upload_data):
2895         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2896         (PerfTestsRunner._upload_json):
2897         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2898         (test_upload_json):
2899         (test_upload_json.MockFileUploader.upload_single_text_file):
2900
2901 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2902
2903         run-perf-tests ignore Skipped list on chromium
2904         https://bugs.webkit.org/show_bug.cgi?id=76764
2905
2906         Reviewed by Dirk Pranke.
2907
2908         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
2909         can also find skipped list. Chromium port only uses test_expectations.txt for
2910         layout tests but performacne tests don't use test_expectations.txt so Chromium port
2911         also needs to use Skipped list.
2912
2913         * Scripts/webkitpy/layout_tests/port/base.py:
2914         (Port._tests_from_skipped_file_contents):
2915         (Port):
2916         (Port._expectations_from_skipped_files):
2917         (Port.skipped_perf_tests):
2918         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2919         (PortTest.test_skipped_perf_tests):
2920         (PortTest.test_skipped_perf_tests.add_text_file):
2921         * Scripts/webkitpy/layout_tests/port/webkit.py:
2922         (WebKitPort._skipped_tests_for_unsupported_features):
2923         (WebKitPort._skipped_file_search_paths):
2924         (WebKitPort.skipped_layout_tests):
2925
2926 2012-01-23  Andy Estes  <aestes@apple.com>
2927
2928         Fix the build after r105635.
2929
2930         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2931         (TestWebKitAPI::TEST):
2932
2933 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2934
2935         Basic enhancements to StringBuilder
2936         https://bugs.webkit.org/show_bug.cgi?id=67081
2937
2938         Reviewed by Darin Adler.
2939
2940         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2941         (TestWebKitAPI::TEST):
2942
2943 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2944
2945         [GTK] run-gtk-tests randomly fails while running the xprop comand
2946         https://bugs.webkit.org/show_bug.cgi?id=76817
2947
2948         Reviewed by Gustavo Noronha Silva.
2949
2950         No need to use xprop to remove the AT_SPI_BUS property since
2951         run-gtk-tests will always run new instances of Xvfb.
2952
2953         * Scripts/run-gtk-tests:
2954         (TestRunner): Unskip TestWebKitAccessibility.
2955         (TestRunner.run): Uncomment lines for launching the accessibility
2956         bus and registry daemon, and remove lines for running xprop.
2957
2958 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2959
2960         [Qt] Don't warn about override and final being C++11 extensions
2961
2962         Clang will emit a warning when these extensions are used without passing
2963         --std=c++11, but we use feature checking to decide if we have the right
2964         extensions, so we can safely ignore these warnings. The XCode and Windows
2965         project files have the same workaround.
2966
2967         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
2968         we only have one extra compiler for Objective-C, which is also used for
2969         Objective-C++ sources, so we have to pass the flag, even if it doesn't
2970         make sense for Objective-C.
2971
2972         Reviewed by Simon Hausmann.
2973
2974         * qmake/mkspecs/features/unix/default_post.prf:
2975
2976 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2977
2978         [Qt] Change how build-webkit decides when to do full incremental builds
2979
2980         Instead of relying on update-webkit (which isn't run on the bots) to
2981         decide when to do a full incremental build (make qmake), we let the
2982         build-webkit script itself check the current SVN revision against the
2983         previous build (by storing it in .webkit.config).
2984
2985         If the two differ we assume a full incremental build is needed, since
2986         the new revisions might have introduced problematic things like new
2987         Q_OBJECT macros. If not, we assume the developer is doing changes
2988         locally, and revert to doing a plain 'make'.
2989
2990         In addition, when the build fails in the latter case, we inform the
2991         developer of possible pitfalls and how to manually run 'make qmake'.
2992
2993         Reviewed by Ossy.
2994
2995         * Scripts/update-webkit:
2996         * Scripts/webkitdirs.pm:
2997         (buildQMakeProjects):
2998
2999 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
3000
3001         [GTK] run-gtk-tests randomly fails while running the xprop comand
3002         https://bugs.webkit.org/show_bug.cgi?id=76817
3003
3004         Reviewed by Philippe Normand.
3005
3006         Temporarily comment the lines related to launching the ATSPI bus
3007         and registry daemon, which are making the bots to fail randomly.
3008
3009         * Scripts/run-gtk-tests:
3010         (TestRunner): Skip TestWebKitAccessibility, as it won't run
3011         properly if the ATSPI infrastructure is not properly initialized.
3012         (TestRunner.run): Comment lines related to initialization of ATSPI.
3013
3014 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
3015
3016         Windows python test build fix.
3017
3018         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3019         (PerfTestsRunner.__init__):
3020
3021 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
3022
3023         [GTK] DumpRenderTree converts "file:///" to a path differently
3024         https://bugs.webkit.org/show_bug.cgi?id=76631
3025
3026         Reviewed by Martin Robinson.
3027
3028         DumpRenderTree should print "/" as the last path component if the
3029         path is a lone slash instead of empty output.
3030
3031         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3032         (webViewConsoleMessage):
3033
3034 2012-01-20  David Levin  <levin@chromium.org>
3035
3036         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
3037         https://bugs.webkit.org/show_bug.cgi?id=76752
3038
3039         Reviewed by Eric Seidel.
3040
3041         * Scripts/webkitpy/style/checkers/cpp.py:
3042         (check_for_leaky_patterns):
3043         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3044         (LeakyPatternTest.test_create_dc):
3045         (LeakyPatternTest.test_create_compatible_dc):
3046
3047 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
3048
3049         Changed my status in commiters.py
3050
3051         Unreviewed.
3052
3053         * Scripts/webkitpy/common/config/committers.py:
3054
3055 2012-01-20  Ojan Vafai  <ojan@chromium.org>
3056
3057         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
3058         https://bugs.webkit.org/show_bug.cgi?id=76748
3059
3060         Reviewed by Ryosuke Niwa.
3061
3062         It crawls the whole subtree and then doesn't use the data. Cutting this out
3063         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
3064
3065         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3066         (run):
3067
3068 2012-01-20  Adam Barth  <abarth@webkit.org>
3069
3070         Another tiny tweak to the garden-o-matic CSS.  This makes things line
3071         up slightly nicer when there aren't any failures.
3072
3073         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
3074         (#summary):
3075
3076 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
3077
3078         run-perf-tests should support --test-results-server option
3079         https://bugs.webkit.org/show_bug.cgi?id=76680
3080
3081         Reviewed by Adam Barth.
3082
3083         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
3084         to be used by perf bots. Also refactor file_uploader as needed.
3085
3086         * Scripts/webkitpy/common/net/file_uploader.py:
3087         (FileUploader.__init__):
3088         (FileUploader.upload_single_file):
3089         (FileUploader.upload_as_multipart_form_data):
3090         (FileUploader):
3091         (FileUploader._upload_data):
3092         (FileUploader._upload_data.callback):
3093         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3094         (JSONResultsGeneratorBase.upload_json_files):
3095         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3096         (PerfTestsRunner):
3097         (PerfTestsRunner._parse_args):
3098         (PerfTestsRunner.run):
3099         (PerfTestsRunner._generate_json):
3100         (PerfTestsRunner._upload_json):
3101         (PerfTestsRunner._run_tests_set):
3102         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3103         (create_runner):
3104         (test_run_with_upload_json):
3105         (test_run_with_upload_json.mock_upload_json):
3106         (test_upload_json):
3107         (test_upload_json.MockFileUploader):
3108         (test_upload_json.MockFileUploader.__init__):
3109         (test_upload_json.MockFileUploader.upload_single_file):
3110         (test_parse_args):
3111
3112 2012-01-20  Adam Barth  <abarth@webkit.org>
3113
3114         The party time image overlaps real content!  This patch makes the
3115         image centered vertically.
3116
3117         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
3118         (#onebar.partytime #summary):
3119
3120 2012-01-19  Ojan Vafai  <ojan@chromium.org>
3121
3122         Refactor TestExpectationsParser in preparation for caching the results
3123         https://bugs.webkit.org/show_bug.cgi?id=76669
3124
3125         Reviewed by Dimitri Glazkov.
3126
3127         Make everything private expect for the parse method. 
3128         Eventually, we'll need the expectations lines to not be modified
3129         outside of TestExpectationsParser so we can cache the results.
3130         This makes check-webkit-style of the chromium test_expectations.txt file
3131         go from ~17 seconds to ~12 seconds on my Mac Pro.
3132
3133         This patch is just a refactor in preparation, so no new tests.
3134
3135         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3136         (TestExpectationEditorTests.make_parsed_expectation_lines):
3137         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3138         (TestExpectationParser.parse):
3139         (TestExpectationParser):
3140         (TestExpectationParser._parse_line):
3141         (TestExpectationParser._tokenize):
3142         (TestExpectationParser._tokenize_list):
3143         (TestExpectationsModel._clear_expectations_for_test):
3144         (TestExpectations.__init__):
3145         (TestExpectations._add_expectations):
3146         (TestExpectations._add_skipped_tests):
3147         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3148         (TestExpectationParserTests.test_tokenize_blank):
3149         (TestExpectationParserTests.test_tokenize_missing_colon):
3150         (TestExpectationParserTests.test_tokenize_extra_colon):
3151         (TestExpectationParserTests.test_tokenize_empty_comment):
3152         (TestExpectationParserTests.test_tokenize_comment):
3153         (TestExpectationParserTests.test_tokenize_missing_equal):
3154         (TestExpectationParserTests.test_tokenize_extra_equal):
3155         (TestExpectationParserTests.test_tokenize_valid):
3156         (TestExpectationParserTests.test_tokenize_valid_with_comment):
3157         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
3158         (TestExpectationParserTests.test_parse_empty_string):
3159         (TestExpectationSerializerTests.assert_round_trip):
3160         (TestExpectationSerializerTests.assert_list_round_trip):
3161         * Scripts/webkitpy/tool/commands/expectations.py:
3162         (OptimizeExpectations.execute):
3163         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3164         (GardeningExpectationsUpdater.update_expectations):
3165
3166 2012-01-20  Adam Barth  <abarth@webkit.org>
3167
3168         Follow-up to previous patch: don't produce NaN when the revision number
3169         is missing.
3170
3171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
3173
3174 2012-01-20  Adam Barth  <abarth@webkit.org>
3175
3176         Garden-o-matic should tell me which revisions have been checked by all the bots
3177         https://bugs.webkit.org/show_bug.cgi?id=76722
3178
3179         Reviewed by Dimitri Glazkov.
3180
3181         This information helps me know when it's safe for me to roll a
3182         candidate revision.
3183
3184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
3187
3188 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3189
3190         build-webkit: Don't spit out congratulations message on Ctrl+C
3191
3192         Reviewed by Andreas Kling.
3193
3194         * Scripts/build-webkit:
3195
3196 2012-01-20  Philippe Normand  <pnormand@igalia.com>
3197
3198         [GTK] Allow extra jhbuild modulesets
3199         https://bugs.webkit.org/show_bug.cgi?id=76691
3200
3201         Reviewed by Gustavo Noronha Silva.
3202
3203         * gtk/jhbuildrc: Extra modulesets and modules can be added in
3204         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
3205         env variables respectively. Use comma-separated values. Example:
3206         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
3207
3208 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
3209
3210         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
3211         https://bugs.webkit.org/show_bug.cgi?id=72589
3212
3213         Reviewed by Martin Robinson.
3214
3215         Ensure the accessibility infrastructure is available when running
3216         the unit tests, otherwise WK2's accessibility tests won't work.
3217
3218         * Scripts/run-gtk-tests:
3219         (TestRunner):
3220         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
3221         where at-spi2's stuff is located (like at-spi-bus-launcher and
3222         at-spi2-registryd).
3223         (TestRunner.run): Initialize the accessibility infrastructure.
3224
3225         * gtk/generate-gtkdoc:
3226         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
3227
3228         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
3229
3230 2012-01-20  Hayato Ito  <hayato@chromium.org>
3231
3232         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
3233         https://bugs.webkit.org/show_bug.cgi?id=76353
3234
3235         Reviewed by Hajime Morita.
3236
3237         Add ShadowRoot.idl, which is enabled only on chromium port since this is
3238         under development feature.
3239         ShadowRoot.idl contains minimum API so that we can test it.
3240         Other APIs should be added on other changes so that we can isolate issues.
3241
3242         * DumpRenderTree/chromium/TestShell.cpp:
3243         (TestShell::TestShell):
3244
3245 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
3246
3247         [GTK] GTK's DRT not to log events for already defunct objects
3248         https://bugs.webkit.org/show_bug.cgi?id=76620
3249
3250         Reviewed by Martin Robinson.
3251
3252         Do not log 'state-change:defunct' events.
3253
3254         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
3255         (printAccessibilityEvent): Early return if a
3256         'state-change:defunct' signal is passed.
3257         (axObjectEventListener): Pass the signal name and value in
3258         separate parameters to printAccessibilityEvent.
3259
3260 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
3261
3262         Unreviewed build fix. Wrong variable being used as the cwd for git
3263         remote update command.
3264
3265         * gtk/run-with-jhbuild:
3266         (update_jhbuild):
3267
3268 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
3269
3270         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
3271         https://bugs.webkit.org/show_bug.cgi?id=76585
3272
3273         Reviewed by Martin Robinson.
3274
3275         This allows us to specify a minimum version of jhbuild required,
3276         while also providing stability against changes done to the master
3277         branch, by letting us choose what is the exact version that will
3278         be used.
3279
3280         * gtk/run-with-jhbuild: refactored for more hackability and easier
3281         reading
3282         (jhbuild_installed): checks whether jhbuild is installed
3283         (jhbuild_cloned): checks whether jhbuild has been cloned
3284         (jhbuild_at_expected_revision): checks whether jhbuild is at the
3285         expected revision
3286         (update_jhbuild): brings jhbuild to the expected revision
3287         (clone_jhbuild): clones jhbuild
3288         (install_jhbuild): build and installs jhbuild
3289         (update_webkitgtk_libs): runs update-webkitgtk-libs
3290         (ensure_jhbuild): high-level logic to decide whether and which of
3291         the steps above are executed
3292
3293 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
3294
3295         [WK2] DumpRenderTree converts "file:///" to a path differently
3296         https://bugs.webkit.org/show_bug.cgi?id=76653
3297
3298         Reviewed by John Sullivan.
3299
3300         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
3301         Do print a slash if there are no path components.
3302
3303 2012-01-19  Eric Seidel  <eric@webkit.org>
3304
3305         webkit-patch cannot rollout patches without changelog/bug number
3306         https://bugs.webkit.org/show_bug.cgi?id=75962
3307
3308         Reviewed by Adam Barth.
3309
3310         * Scripts/webkitpy/tool/commands/download.py:
3311         (AbstractRolloutPrepCommand._prepare_state):
3312         * Scripts/webkitpy/tool/commands/download_unittest.py:
3313         (AbstractRolloutPrepCommandTest.test_prepare_state):
3314
3315 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
3316
3317         [WK2] fast/url/degenerate-file-base.html fails
3318         https://bugs.webkit.org/show_bug.cgi?id=76619
3319
3320         Reviewed by Adam Roben.
3321
3322         A URL generated form local path for loading had an extra slash, making document.URL
3323         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
3324
3325         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
3326
3327 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3328
3329         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
3330         https://bugs.webkit.org/show_bug.cgi?id=76510
3331
3332         Reviewed by Adam Barth.
3333
3334         Unlike other style rules, if you get the syntax of the test_expectations.txt
3335         file wrong, the layout tests won't run. Also, this check is simple and only
3336         slows down committing if you actually modify one of the test_expectations.txt files.
3337
3338         * Scripts/webkitpy/style/checkers/test_expectations.py:
3339         (TestExpectationsChecker.check_test_expectations):
3340         (TestExpectationsChecker.check):
3341         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3342         (TestExpectationsTestCase.test_check_covers_all_configurations):
3343         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
3344         (TestExpectationsTestCase):
3345         (assert_lines_lint):
3346
3347 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
3348
3349         Build fix. Revert an unintentional change to WebKitDriver in r105443.
3350
3351         * Scripts/webkitpy/layout_tests/port/driver.py:
3352         (DriverProxy.__init__):
3353
3354 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
3355
3356         remove the duplicated build rules from WebKit.gyp, Tools.gyp
3357         https://bugs.webkit.org/show_bug.cgi?id=73384
3358
3359         Reviewed by Tony Chang.
3360
3361         This patch removes the no-longer-necessary conditional logic for
3362         build_webkit_exes_from_webkit_gyp; we now always build the exes
3363         from their own dedicated gyp files.
3364
3365         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3366
3367 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
3368
3369         make-new-script-test should work with HTTP tests
3370         https://bugs.webkit.org/show_bug.cgi?id=76603
3371
3372         Reviewed by Adam Roben.
3373
3374         * Scripts/make-new-script-test:
3375         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
3376         now also creates absolute paths for HTTP.
3377
3378 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
3379
3380         Some perf tests time out when ran by run-perf-tests
3381         https://bugs.webkit.org/show_bug.cgi?id=76612
3382
3383         Reviewed by Dirk Pranke and Eric Seidel.
3384
3385         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
3386         Otherwise some tests such as Parser/xml-parser.html will timeout.
3387
3388         --no-timeout option is currently supported by Chromium and Mac ports.
3389
3390         * Scripts/webkitpy/layout_tests/port/base.py:
3391         (Port.to.create_driver):
3392         * Scripts/webkitpy/layout_tests/port/chromium.py:
3393         (ChromiumDriver.__init__):
3394         (ChromiumDriver._wrapper_options):
3395         * Scripts/webkitpy/layout_tests/port/driver.py:
3396         (Driver.__init__):
3397         (DriverProxy.__init__):
3398         * Scripts/webkitpy/layout_tests/port/webkit.py:
3399         (WebKitDriver.__init__):
3400         (WebKitDriver.cmd_line):
3401         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3402         (WebKitDriverTest.test_read_binary_block):
3403         (WebKitDriverTest):
3404         (WebKitDriverTest.test_no_timeout):
3405         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3406         (get_tests_run.RecordingTestDriver.__init__):
3407         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3408         (PerfTestsRunner._parse_args):
3409         (PerfTestsRunner._run_tests_set):
3410         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3411         (create_runner):
3412
3413 2012-01-19  Ben Wells  <benwells@chromium.org>
3414
3415         Add support for window.print to chromium DRT
3416         https://bugs.webkit.org/show_bug.cgi?id=76479
3417
3418         When used in a test window.print goes into print mode and then
3419         straight out again. This will allow the afterprint event to be
3420         tested by having the afterprint event happen before the dump
3421         happens.
3422
3423         Reviewed by Mihai Parparita.
3424
3425         * DumpRenderTree/chromium/WebViewHost.cpp:
3426         (WebViewHost::printPage):
3427         * DumpRenderTree/chromium/WebViewHost.h:
3428
3429 2012-01-18  Enrica Casucci  <enrica@apple.com>
3430
3431         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
3432         https://bugs.webkit.org/show_bug.cgi?id=76588
3433         <rdar://problem/9325183>
3434
3435         Added test.
3436         
3437         Reviewed by Dan Bernstein.
3438
3439         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3440         (TestWebKitAPI::TEST):
3441
3442 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3443
3444         [Qt] Do full incremental builds until bots use update-webkit
3445
3446         Rubber-stamped by Simon Hausmann.
3447
3448         * Scripts/webkitdirs.pm:
3449         (buildQMakeProjects):
3450
3451 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3452
3453         Fix the Qt build
3454
3455         Unreviewed build fix.
3456
3457         * Scripts/webkitdirs.pm:
3458         (buildQMakeProjects):
3459
3460 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3461
3462         [Qt] Make build-webkit always do safe incremental builds after update-webkit
3463
3464         When building against Qt5 with GCC we would just run 'make' in the build dir,
3465         and rely on the dependency files output by GCC (-MD) to handle dependency
3466         tracking, but that fails for special-cases like adding a Q_OBJECT macro
3467         to a header.
3468
3469         To guarantee that an incrmental build will work, we have to run 'make qmake',
3470         which we now do on every build-webkit that's followed by a successful run
3471         of update-webkit. The reasoning is that update-webkit can result in such
3472         potential corner-cases being applied, and since we can't know for sure
3473         unless we inspect the diff and account for all the corner cases we assume
3474         the worst and always run 'make qmake'.
3475
3476         After a succesful run of build-webkit we proceed to do just 'make' for any
3477         subsequent runs, since we assume that the developer knows what kind of
3478         changes he/she is doing, and when a 'make qmake' is needed.
3479
3480         Reviewed by Simon Hausmann.
3481
3482         * Scripts/update-webkit:
3483         * Scripts/webkitdirs.pm:
3484         (determineCurrentSVNRevision):
3485         (currentSVNRevision):
3486         (buildQMakeProjects):
3487         * qmake/mkspecs/features/default_post.prf:
3488
3489 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
3490
3491         run-perf-tests should support Skipped list
3492         https://bugs.webkit.org/show_bug.cgi?id=76594
3493
3494         Reviewed by Adam Barth.
3495
3496         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
3497
3498         * Scripts/webkitpy/layout_tests/port/base.py:
3499         (Port.perf_tests_dir):
3500         (Port.skipped_perf_tests):
3501         (Port.skips_perf_test):
3502         (Port.relative_perf_test_filename):
3503         * Scripts/webkitpy/layout_tests/port/test.py:
3504         (TestPort.perf_tests_dir):
3505         * Scripts/webkitpy/layout_tests/port/webkit.py:
3506         (WebKitPort._expectations_from_skipped_files):
3507         (WebKitPort):
3508         (WebKitPort.skipped_layout_tests):
3509         (WebKitPort.skipped_perf_tests):
3510         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3511         (PerfTestsRunner._collect_tests):
3512         (PerfTestsRunner.run):
3513         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3514         (test_run_test_set_with_json_output):
3515         (test_run_test_set_with_json_source):
3516         (test_collect_tests_with_skipped_list):
3517         (test_collect_tests_with_skipped_list.add_file):
3518
3519 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3520
3521         Fix path to chromium_src_dir introduced in previous change.
3522
3523         Unreviewed, build fix.
3524
3525         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3526
3527 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
3528
3529         Need infrastructure to test Content-Disposition filename encoding support
3530         https://bugs.webkit.org/show_bug.cgi?id=76572
3531         <rdar://problem/6421825>
3532
3533         Reviewed by Sam Weinig.
3534
3535         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
3536
3537         WebKitTestRunner does not have a policy delegate yet, bug 42546.
3538
3539         * DumpRenderTree/mac/PolicyDelegate.mm:
3540         (dispositionTypeFromContentDispositionHeader):
3541         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
3542
3543 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3544
3545         Fix tests from http://trac.webkit.org/changeset/105332.
3546
3547         The code assumed that if you passed an options object with a configuration
3548         attribute that it would have a valid value. A bunch of the testing mocks
3549         do things like having a configuration value of None.
3550
3551         * Scripts/webkitpy/layout_tests/port/base.py:
3552         (Port.__init__):
3553
3554 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3555
3556         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
3557         https://bugs.webkit.org/show_bug.cgi?id=76576
3558
3559         Reviewed by Adam Barth.
3560
3561         Avoid calling default_configuration in base.py. We don't need it for
3562         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
3563         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
3564         from common.executive.
3565
3566         At some point someone should probably look into why that call is so slow
3567         since it's on the critical path for run-webkit-tests and build-webkit startup.
3568
3569         * Scripts/webkitpy/layout_tests/port/base.py:
3570         (Port.__init__):
3571         * Scripts/webkitpy/style/checkers/test_expectations.py:
3572         (TestExpectationsChecker._determine_port_from_exepectations_path):
3573
3574 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3575
3576         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
3577         https://bugs.webkit.org/show_bug.cgi?id=76505
3578
3579         Reviewed by Tony Chang.
3580
3581         Update chromium build script to use All.gyp instead of WebKit.gyp
3582
3583         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
3584         * Scripts/webkitdirs.pm:
3585
3586 2012-01-18  Sam Weinig  <sam@webkit.org>
3587
3588         Don’t hardcode the path to ‘make‘.
3589
3590         Reviewed by Dan Bernstein.
3591
3592         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3593
3594 2012-01-18  Joshua Bell  <jsbell@chromium.org>
3595
3596         Adding myself to committers.py
3597         https://bugs.webkit.org/show_bug.cgi?id=76569
3598
3599         Unreviewed.
3600
3601         * Scripts/webkitpy/common/config/committers.py:
3602
3603 2012-01-18  Adam Barth  <abarth@webkit.org>
3604
3605         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
3606         https://bugs.webkit.org/show_bug.cgi?id=76567
3607
3608         Reviewed by Eric Seidel.
3609
3610         Current the AppleMac port has slightly more failures than we allow on
3611         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
3612         which should hopefully let the mac-ews run to completion.  Once
3613         AppleMac has fewer failures, we can lower the cap again.
3614
3615         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3616         (LayoutTestResultsReaderTest.test_layout_test_results):
3617         * Scripts/webkitpy/tool/steps/runtests.py:
3618         (RunTests):
3619         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3620
3621 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
3622
3623         Provide access to user's list of preferred languages
3624         https://bugs.webkit.org/show_bug.cgi?id=76138
3625
3626         Reviewed by Alexey Proskuryakov.
3627
3628         * GNUmakefile.am: Add JSInternalsCustom.cpp.
3629
3630 2012-01-18  Adam Barth  <abarth@webkit.org>
3631
3632         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
3633         configurations.
3634
3635         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3636         (ChromiumLinuxPort.__init__):
3637
3638 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
3639
3640         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
3641         https://bugs.webkit.org/show_bug.cgi?id=73460
3642
3643         Reviewed by Chris Fleizach.
3644
3645         * DumpRenderTree/AccessibilityUIElement.h:
3646         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3647         (AccessibilityUIElement::AccessibilityUIElement):
3648         (AccessibilityUIElement::scrollToMakeVisibleCallback):
3649         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
3650         (AccessibilityUIElement::scrollToGlobalPointCallback):
3651         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3652         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3653         (AccessibilityUIElement::scrollToMakeVisible):
3654         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3655         (AccessibilityUIElement::scrollToGlobalPoint):
3656         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3657         (AccessibilityUIElement::scrollToMakeVisible):
3658         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3659         (AccessibilityUIElement::scrollToGlobalPoint):
3660         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3661         (AccessibilityUIElement::scrollToMakeVisible):
3662         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3663         (AccessibilityUIElement::scrollToGlobalPoint):
3664
3665 2012-01-17  Enrica Casucci  <enrica@apple.com>
3666
3667         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
3668         https://bugs.webkit.org/show_bug.cgi?id=76490
3669         <rdar://problem/9460733>
3670
3671         Added TestWebKitAPI test.
3672         
3673         Reviewed by Dan Bernstein.
3674
3675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
3676         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls