28e22ed4cb88997eaeaf67a3eff60e4a1bf28073
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
2
3         <select> menu on iPad causes shifting of hit-testing areas
4         https://bugs.webkit.org/show_bug.cgi?id=150079
5
6         Reviewed by Tim Horton.
7
8         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
9         so when it changes we have to update visible rects. We were doing this on focus, but failing
10         to do it on blur.
11
12         Added the ability to test by:
13         1. Making it possible to initiate an animated scroll in the UI process
14         2. Adding callbacks for starting and ending interaction with a form control. Sadly
15         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
16         have no way currently to know when the dimming view behind the popover animates out,
17         so for now the test keeps trying to tap a button.
18
19         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
20         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
21         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
22         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
23         (WTR::UIScriptController::didStartFormControlInteractionCallback):
24         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
25         (WTR::UIScriptController::didEndFormControlInteractionCallback):
26         (WTR::UIScriptController::scrollToOffset):
27         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
28         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
29         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
30         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
31         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
32         (-[TestRunnerWKWebView dealloc]):
33         (-[TestRunnerWKWebView didStartFormControlInteraction]):
34         (-[TestRunnerWKWebView didEndFormControlInteraction]):
35         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
36         (WTR::contentOffsetBoundedInValidRange):
37         (WTR::UIScriptController::scrollToOffset):
38         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
39         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
40
41 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
42
43         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
44         https://bugs.webkit.org/show_bug.cgi?id=160927
45
46         Reviewed by Daniel Bates.
47
48         * Scripts/process-linux-coredump: Removed.
49         * Scripts/webkitpy/port/efl.py:
50         (EflPort._get_crash_log):
51         * Scripts/webkitpy/port/gtk.py:
52         (GtkPort._get_crash_log):
53         * Scripts/webkitpy/port/linux_get_crash_log.py:
54         (GDBCrashLogGenerator.__init__):
55         (GDBCrashLogGenerator.generate_crash_log):
56         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
57         (GDBCrashLogGeneratorTest.test_generate_crash_log):
58
59 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
60
61         check-webkit-style does not work with Lambda functions in C++
62         https://bugs.webkit.org/show_bug.cgi?id=160910
63
64         Reviewed by Darin Adler.
65
66         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
67
68         * Scripts/webkitpy/style/checkers/cpp.py:
69         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
70         (check_for_non_standard_constructs): Added lambda function check.
71         (check_spacing_for_function_call): Added lambda function check.
72         (check_braces): Added lambda function check.
73         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
74         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
75
76 2016-08-21  Alex Christensen  <achristensen@webkit.org>
77
78         URLParser should parse IPv4 addresses
79         https://bugs.webkit.org/show_bug.cgi?id=161023
80
81         Reviewed by Darin Adler.
82
83         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
84         (TestWebKitAPI::TEST_F):
85         (TestWebKitAPI::checkURLDifferences):
86         We are already getting differences between the old URL::parse and the new URLParser.
87         (TestWebKitAPI::shouldFail):
88
89 2016-08-21  Daniel Bates  <dabates@apple.com>
90
91         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
92         https://bugs.webkit.org/show_bug.cgi?id=148437
93
94         Reviewed by Dan Bernstein.
95
96         * Scripts/prepare-ChangeLog:
97         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
98         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
99         assumes that its line ranges were from a unified diff without any context lines.
100         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
101         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
102         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
103         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
104         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
105         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
106         to /dev/null for the duration of the function call.
107
108 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
109
110         [EFL] Remove unnecessary a patch to mute ecore warnings
111         https://bugs.webkit.org/show_bug.cgi?id=160997
112
113         Reviewed by Darin Adler.
114
115         There is no warning messages during the layout test and perf test
116         after bumping efl version from 1.17 to 1.18. Remove it.
117
118         * efl/patches/ecore_remove_warnings.patch: Removed.
119
120 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
121
122         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
123         https://bugs.webkit.org/show_bug.cgi?id=160985
124
125         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
126         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
127         with that.
128
129         * Scripts/webkitpy/layout_tests/views/printing.py:
130         (Printer.print_config):
131         * Scripts/webkitpy/port/base.py:
132         (Port.driver_cmd_line_for_logging):
133         (Port.driver_cmd_line): Deleted.
134         * Scripts/webkitpy/port/driver.py:
135         (IOSSimulatorDriver.cmd_line):
136         * Scripts/webkitpy/port/ios.py:
137         (IOSSimulatorPort.__init__):
138         (IOSSimulatorPort.driver_cmd_line_for_logging):
139         (IOSSimulatorPort._create_simulators):
140         (IOSSimulatorPort.setup_test_run):
141         (IOSSimulatorPort._quit_ios_simulator):
142         (IOSSimulatorPort.clean_up_test_run):
143         (IOSSimulatorPort._create_device):
144         (IOSSimulatorPort):
145         (IOSSimulatorPort._remove_device):
146         (IOSSimulatorPort._testing_device):
147         (IOSSimulatorPort.device_id_for_worker_number):
148         (IOSSimulatorPort._set_device_class): Deleted.
149         (IOSSimulatorPort.testing_device): Deleted.
150         * Scripts/webkitpy/port/port_testcase.py:
151         (PortTestCase.test_driver_cmd_line):
152         * Scripts/webkitpy/xcode/simulator.py:
153         (Device.shutdown):
154         (Device):
155         (Device.delete):
156         (Device.reset):
157         (Simulator):
158         (Simulator.create_device):
159         (Simulator.remove_device):
160         (Simulator.device_number):
161         (Simulator.device_state_description):
162         (Simulator.wait_until_device_is_in_state):
163
164 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
165
166         Unreviewed, rolling out r204659.
167
168         This change appears to have caused ios-simulator LayoutTests
169         to fail when shutting down the simulator
170
171         Reverted changeset:
172
173         "REGRESSION (r204477): Running LayoutTests on ios-simulator
174         became ~15 minutes slower"
175         https://bugs.webkit.org/show_bug.cgi?id=160985
176         http://trac.webkit.org/changeset/204659
177
178 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
179
180         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
181         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
182
183 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
184
185         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
186         https://bugs.webkit.org/show_bug.cgi?id=160985
187
188         Reviewed by Alexey Proskuryakov.
189         
190         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
191         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
192         must not be @memoized, because their return value depends on the value of simulator_device_type().
193         
194         Fix by adding some global state in simulator.py that tracks the created devices 
195         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
196         and delete them in clean_up_test_run().
197         
198         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
199         that killing the Simulator apps isn't enough.
200         
201         Simulator tracks the devices in a global dictionary, since state needs to persist
202         across different instances of IOSSimulatorPort.
203         
204         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
205         any setup. Rather than implicitly creating a device here (which the old code did),
206         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
207         and set flag to say that device_id_for_worker_number() doesn't need to return a real
208         device id.
209
210         * Scripts/webkitpy/layout_tests/views/printing.py:
211         (print_options):
212         (Printer.print_config):
213         * Scripts/webkitpy/port/base.py:
214         (Port.driver_cmd_line_for_logging):
215         (Port.driver_cmd_line): Deleted.
216         * Scripts/webkitpy/port/driver.py:
217         (IOSSimulatorDriver.cmd_line):
218         * Scripts/webkitpy/port/ios.py:
219         (IOSSimulatorPort.__init__):
220         (IOSSimulatorPort.driver_cmd_line_for_logging):
221         (IOSSimulatorPort._create_simulators):
222         (IOSSimulatorPort.setup_test_run):
223         (IOSSimulatorPort.clean_up_test_run):
224         (IOSSimulatorPort._create_device):
225         (IOSSimulatorPort):
226         (IOSSimulatorPort._remove_device):
227         (IOSSimulatorPort._testing_device):
228         (IOSSimulatorPort.device_id_for_worker_number):
229         (IOSSimulatorPort._set_device_class): Deleted.
230         (IOSSimulatorPort.testing_device): Deleted.
231         * Scripts/webkitpy/port/port_testcase.py:
232         (PortTestCase.test_driver_cmd_line):
233         * Scripts/webkitpy/xcode/simulator.py:
234         (Device.shutdown):
235         (Device.delete):
236         (Device.reset):
237         (Simulator.create_device):
238         (Simulator.remove_device):
239         (Simulator.device_number):
240         (Simulator.device_state_description):
241         (Simulator.wait_until_device_is_in_state):
242
243 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
244
245         Adopt SimServiceContext in LayoutTestRelay
246         https://bugs.webkit.org/show_bug.cgi?id=161000
247         <rdar://problem/25765594>
248
249         Reviewed by Daniel Bates.
250
251         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
252         * LayoutTestRelay/LayoutTestRelay/main.m:
253
254 2016-08-19  Lucas Forschler  <lforschler@apple.com>
255
256         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
257
258         Reviewed by Kocsen Chung.
259
260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
261         (WebKitBuildbot):
262
263 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
264
265         Partial revert of r203811 - this key is not needed.
266
267         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
268
269 2016-08-19  Daniel Bates  <dabates@apple.com>
270
271         Another attempt to fix the iOS 9.3 build
272
273         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
274
275         * DumpRenderTree/mac/Configurations/Base.xcconfig:
276         * WebKitTestRunner/Configurations/Base.xcconfig:
277
278 2016-08-19  Lucas Forschler  <lforschler@apple.com>
279
280         Remove Yosemite Leaks bot from config.json
281         
282         Reviewed by Alexey Proskuryakov.
283
284         * BuildSlaveSupport/build.webkit.org-config/config.json:
285
286 2016-08-18  Dan Bernstein  <mitz@apple.com>
287
288         [Cocoa] API::Number needs to be wrapped by an NSNumber
289         https://bugs.webkit.org/show_bug.cgi?id=160977
290         <rdar://problem/27877735>
291
292         Reviewed by Anders Carlsson.
293
294         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
295         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
296         (TestWebKitAPI::TEST):
297
298 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
299
300         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
301         https://bugs.webkit.org/show_bug.cgi?id=160895
302
303         Reviewed by Dean Jackson.
304
305         Link to the existing CoreText framework.
306
307         * DumpRenderTree/PlatformWin.cmake:
308         * TestWebKitAPI/PlatformWin.cmake:
309
310 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
311
312         [Win] Remove old libraries from build inputs
313         https://bugs.webkit.org/show_bug.cgi?id=160949
314
315         Reviewed by Dean Jackson.
316
317         Modify the download script to remove the old 'icuuc.lib' and
318         'icuin.lib' files for Windows builds.
319
320         * Scripts/update-webkit-auxiliary-libs:
321
322 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
323
324         Extra logging for crash reason
325         https://bugs.webkit.org/show_bug.cgi?id=160943
326
327         Reviewed by Alexey Proskuryakov.
328
329         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
330
331         * Scripts/webkitpy/port/server_process.py:
332         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
333         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
334         (ServerProcess.has_crashed): Ditto.
335
336 2016-08-17  Dan Bernstein  <mitz@apple.com>
337
338         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
339         https://bugs.webkit.org/show_bug.cgi?id=160938
340         <rdar://problem/27876652>
341
342         Reviewed by Anders Carlsson.
343
344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
345         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
346         (TestWebKitAPI::TEST):
347
348 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
349
350         AX: Support abbreviations in iOS
351         https://bugs.webkit.org/show_bug.cgi?id=160907
352
353         Reviewed by Joanmarie Diggs.
354
355         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
356         (AccessibilityUIElement::stringAttributeValue):
357         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
358         (WTR::AccessibilityUIElement::stringAttributeValue):
359
360 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
361
362         [EFL] Bump efl version from 1.17 to 1.18
363         https://bugs.webkit.org/show_bug.cgi?id=160899
364
365         Reviewed by Antonio Gomes.
366
367         To use efl-1.18, EFL port needs to update install dependencies as well.
368
369         * efl/install-dependencies:
370         * efl/jhbuild.modules:
371
372 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
373
374         [Win] Add tests for linked fonts.
375         https://bugs.webkit.org/show_bug.cgi?id=160898
376
377         Reviewed by Brent Fulgham.
378
379         Add tests for https://trac.webkit.org/changeset/204502.
380
381         * TestWebKitAPI/PlatformWin.cmake:
382         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
383         (TestWebKitAPI::TEST):
384
385 2016-08-16  Daniel Bates  <dabates@apple.com>
386
387         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
388         https://bugs.webkit.org/show_bug.cgi?id=160924
389
390         Reviewed by Stephanie Lewis.
391
392         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
393         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
394         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
395         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
396         object that mocks out the file system and SCM operations.
397
398         * Scripts/VCSUtils.pm:
399         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
400         * Scripts/prepare-ChangeLog:
401         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
402         abstracting the logic to query the file system and SCM into functions on a delegate object that
403         we pass to it.
404         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
405         (diffHeaderFormat): Deleted.
406
407 2016-08-16  Alex Christensen  <achristensen@webkit.org>
408
409         URLParser should parse URLs without credentials
410         https://bugs.webkit.org/show_bug.cgi?id=160913
411
412         Reviewed by Brady Eidson.
413
414         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
415         (TestWebKitAPI::s):
416         (TestWebKitAPI::checkURL):
417         (TestWebKitAPI::TEST_F):
418
419 2016-08-16  Anders Carlsson  <andersca@apple.com>
420
421         Add WTF::ScopeExit
422         https://bugs.webkit.org/show_bug.cgi?id=160908
423
424         Reviewed by Geoffrey Garen.
425
426         * TestWebKitAPI/CMakeLists.txt:
427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
428         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
429         (TestWebKitAPI::TEST):
430
431 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
432
433         EWS logs file are rotated too quickly
434         https://bugs.webkit.org/show_bug.cgi?id=160724
435
436         Reviewed by Daniel Bates.
437
438         Currently we are rotating the log file after 10 iterations of queue. If the queue
439         doesn't have any pending patches, these iterations result in very small amount of 
440         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
441         This results in a lot of log files in a day. This patch ensures that we rotate the
442         log file when its file size is greater than or equal to 100 KB.
443
444         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
445
446 2016-08-16  Daniel Bates  <dabates@apple.com>
447
448         WKSI static library should be named by major iOS revision, not individual updates
449         https://bugs.webkit.org/show_bug.cgi?id=160727
450         <rdar://problem/22274848>
451
452         Reviewed by Alexey Proskuryakov.
453
454         * DumpRenderTree/mac/Configurations/Base.xcconfig:
455         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
456         * Scripts/copy-webkitlibraries-to-product-directory:
457         * WebKitTestRunner/Configurations/Base.xcconfig:
458         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
459
460 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
461
462         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
463         https://bugs.webkit.org/show_bug.cgi?id=160909
464
465         Reviewed by Enrica Casucci.
466         
467         Add functions to UIScriptController to dismiss the form accessory view for iOS,
468         and to programmatically pick a row from a <select> picker.
469
470         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
471         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
472         (WTR::UIScriptController::dismissFormAccessoryView):
473         (WTR::UIScriptController::selectFormAccessoryPickerRow):
474         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
475         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
476         (WTR::UIScriptController::dismissFormAccessoryView):
477         (WTR::UIScriptController::selectFormAccessoryPickerRow):
478
479 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
480
481         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
482         https://bugs.webkit.org/show_bug.cgi?id=160878
483
484         Reviewed by Tim Horton.
485         
486         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
487         now that we have the ability to run tests in the iPad simulator.
488
489         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
490         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
491         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
492         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
493         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
494         * WebKitTestRunner/ios/TestControllerIOS.mm:
495         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
496         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
497         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
498         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
499
500 2016-08-15  Anders Carlsson  <andersca@apple.com>
501
502         Add an address-of operator to RetainPtr
503         https://bugs.webkit.org/show_bug.cgi?id=160879
504
505         Reviewed by Tim Horton.
506
507         Test HashMap and HashSet with an object whose operator& is deleted.
508
509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
510         Sort the Xcode project.
511
512         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
513         (DeletedAddressOfOperator::DeletedAddressOfOperator):
514         (DeletedAddressOfOperator::value):
515         (DeletedAddressOfOperator::operator==):
516         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
517         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
518         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
519         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
520         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
521         (TestWebKitAPI::TEST):
522         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
523         (TestWebKitAPI::TEST):
524
525 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
526
527         False crashes in fast/text/emoji-gender-* tests
528         https://bugs.webkit.org/show_bug.cgi?id=160779
529
530         Reviewed by Alexey Proskuryakov.
531
532         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
533
534         * Scripts/webkitpy/port/driver.py:
535         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
536         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
537         * Scripts/webkitpy/port/server_process.py:
538         (ServerProcess.write): Allow caller to disable crash flag on exception.
539
540 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
541
542         webkitpy error in TestRunResults.merge()
543         https://bugs.webkit.org/show_bug.cgi?id=160882
544
545         Reviewed by Daniel Bates.
546         
547         The argument to TestRunResults.merge() can be None if there are no device-specifc
548         initial results or retry results in Manager.run(), so just return early in that case.
549
550         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
551         (TestRunResults.merge):
552
553 2016-08-15  Sam Weinig  <sam@webkit.org>
554
555         Speed up compile times by not including wtf/Variant.h so much
556         https://bugs.webkit.org/show_bug.cgi?id=160847
557
558         Reviewed by Alex Christensen and Saam Barati.
559
560         * TestWebKitAPI/Tests/WTF/Variant.cpp:
561         (TestWebKitAPI::TEST):
562         Explicitly use std::experimental::variant.
563
564 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
565
566         Allow a port to run tests with a custom device setup
567         https://bugs.webkit.org/show_bug.cgi?id=160833
568
569         Reviewed by Daniel Bates.
570
571         These changes allow the IOSSimulator port to run tests in iPad mode.
572
573         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
574         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
575         a custom device will be collected into a set, and run in that device's environment after
576         the other tests have run.
577
578         * Scripts/webkitpy/layout_tests/controllers/manager.py:
579         (Manager._custom_device_for_test): If the test contains a directory matching a
580         custom device suffix, return that custom device.
581         (Manager._set_up_run): Push the custom device class, if any, into options so
582         that the Worker can get to it.
583         (Manager.run): Go through the list of tests, and break it down into device-generic
584         tests, and tests for each device class. _run_test_subset is then called for
585         each collection of tests, and the results merged.
586         (Manager._run_test_subset): Some lines unwrapped.
587         (Manager._end_test_run):
588         (Manager._run_tests):
589         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
590         (SingleTestRunner.__init__): Unwrapped a line.
591         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
592         (TestRunResults.merge): Add this function to merge TestRunResults
593         * Scripts/webkitpy/layout_tests/views/printing.py:
594         (Printer.print_workers_and_shards): Print the custom device, if any.
595         * Scripts/webkitpy/port/base.py:
596         (Port): Base port has empty array of custom devices.
597         (Port.setup_test_run): Add device_class argument.
598         * Scripts/webkitpy/port/driver.py:
599         (DriverInput.__repr__):
600         (Driver.check_driver.implementation):
601         * Scripts/webkitpy/port/efl.py:
602         (EflPort.setup_test_run):
603         * Scripts/webkitpy/port/gtk.py:
604         (GtkPort.setup_test_run):
605         * Scripts/webkitpy/port/ios.py:
606         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
607         (IOSSimulatorPort.__init__):
608         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
609         based on the custom device class.
610         (IOSSimulatorPort._set_device_class):
611         (IOSSimulatorPort._create_simulators): Factor some code into this function.
612         (IOSSimulatorPort.setup_test_run):
613         (IOSSimulatorPort.testing_device):
614         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
615         seemed wrong for this function. That was moved to setup_test_run().
616         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
617         but this happened too early, before we knew which kind of devices to create. Devices
618         are now created in setup_test_run().
619         * Scripts/webkitpy/port/win.py:
620         (WinPort.setup_test_run):
621
622 2016-08-15  Daniel Bates  <dabates@apple.com>
623
624         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
625         private frameworks and libraries
626         https://bugs.webkit.org/show_bug.cgi?id=155931
627         <rdar://problem/25807989>
628
629         Reviewed by Dan Bernstein.
630
631         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
632         where X is the major version of the active iOS SDK.
633
634         * DumpRenderTree/mac/Configurations/Base.xcconfig:
635         * WebKitTestRunner/Configurations/Base.xcconfig:
636
637 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
638
639         Add a setting and preferences to enable visual viewport mode
640         https://bugs.webkit.org/show_bug.cgi?id=160843
641
642         Reviewed by Sam Weinig.
643         
644         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
645
646         * MiniBrowser/mac/SettingsController.h:
647         * MiniBrowser/mac/SettingsController.m:
648         (-[SettingsController _populateMenu]):
649         (-[SettingsController validateMenuItem:]):
650         (-[SettingsController visualViewportEnabled]):
651         (-[SettingsController toggleVisualViewportEnabled:]):
652         * MiniBrowser/mac/WK1BrowserWindowController.m:
653         (-[WK1BrowserWindowController didChangeSettings]):
654         * MiniBrowser/mac/WK2BrowserWindowController.m:
655         (-[WK2BrowserWindowController didChangeSettings]):
656
657 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
658
659         Allow using make-dist with non-GTK ports
660         https://bugs.webkit.org/show_bug.cgi?id=160842
661
662         Reviewed by Michael Catanzaro.
663
664         This patch adds support for setting base name of tarball and argument
665         passed to cmake's -DPORT= via command line arguments.
666
667         * gtk/make-dist.py:
668         (Distcheck.configure):
669         (Distcheck.check):
670         (get_tarball_root_and_output_filename_from_arguments):
671
672 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
673
674         [GTK] Install script lacks gstreamer related dependencies
675         https://bugs.webkit.org/show_bug.cgi?id=160814
676
677         Reviewed by Carlos Garcia Campos.
678
679         * gtk/install-dependencies: Fedora case had already listed this dependencies,
680         but both Arch and Debian/Ubuntu were missing them.
681
682 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
683
684         make-dist.py should not allow unknown rules in manifest
685         https://bugs.webkit.org/show_bug.cgi?id=160841
686
687         Reviewed by Carlos Garcia Campos.
688
689         * gtk/make-dist.py:
690         (Manifest.process_line):
691
692 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
693
694         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
695         https://bugs.webkit.org/show_bug.cgi?id=160809
696
697         Reviewed by Carlos Garcia Campos.
698
699         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
700         case, and use it also for the new package names of libpng and libgeoclue.
701         * gtk/install-dependencies: Ditto.
702
703 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
704
705         Skip to check directories existence in build-webkit
706         https://bugs.webkit.org/show_bug.cgi?id=160691
707
708         Reviewed by Alex Christensen.
709
710         CMake checks if directories are there itself. So CMake ports
711         don't need to check it in the build-webkit script.
712
713         * Scripts/build-webkit:
714         * Scripts/webkitdirs.pm:
715         (determineSourceDir):
716         (isCMakeBuild):
717
718 2016-08-12  Alex Christensen  <achristensen@webkit.org>
719
720         Make URLParser work with URLs missing URL parts
721         https://bugs.webkit.org/show_bug.cgi?id=160824
722
723         Reviewed by Brady Eidson.
724
725         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
726         (TestWebKitAPI::s):
727         (TestWebKitAPI::checkURL):
728         (TestWebKitAPI::TEST_F):
729         (TestWebKitAPI::eq): Deleted.
730
731 2016-08-12  John Wilander  <wilander@apple.com>
732
733         Add HashCountedSet API tests to TestWTFLibrary target
734         https://bugs.webkit.org/show_bug.cgi?id=160815
735
736         Reviewed by Alex Christensen.
737
738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
739             Added HashCountedSet.cpp and sorted the file reference section
740             according to UNIX sort.
741
742 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
743
744         run-benchmark should run JetStream 1.1 instead of 1.0.1
745         https://bugs.webkit.org/show_bug.cgi?id=160816
746
747         Reviewed by Filip Pizlo.
748
749         Use the latest JetStream 1.1 in run-benchmark.
750
751         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
752         (BenchmarkBuilder.__exit__):
753         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
754         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
755         change to JetStream directory.
756
757 2016-08-12  Alex Christensen  <achristensen@webkit.org>
758
759         Initial URLParser implementation
760         https://bugs.webkit.org/show_bug.cgi?id=160811
761
762         Reviewed by Brady Eidson.
763
764         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
765         (TestWebKitAPI::eq):
766         (TestWebKitAPI::checkURL):
767         (TestWebKitAPI::TEST_F):
768
769 2016-08-12  Brady Eidson  <beidson@apple.com>
770
771         Fix the 32-bit Mac build after:
772         Add WK2 ExperimentalFeature support to MiniBrowser
773         https://bugs.webkit.org/show_bug.cgi?id=160788
774
775         Unreviewed.
776
777         Sprinkle "#if WK_API_ENABLED"s liberally.
778         
779         * MiniBrowser/mac/AppDelegate.m:
780         (defaultConfiguration):
781         * MiniBrowser/mac/SettingsController.m:
782         (-[SettingsController _populateMenu]):
783         (-[SettingsController validateMenuItem:]):
784
785 2016-08-12  Philippe Normand  <pnormand@igalia.com>
786
787         [GStreamer][OWR] Video rendering fixes
788         https://bugs.webkit.org/show_bug.cgi?id=160764
789
790         Reviewed by Xabier Rodriguez-Calvar.
791
792         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
793
794 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
795
796         Add missing return statement in convertFast function added in r204376.
797
798         Unreviewed.
799
800         * Scripts/webkitpy/common/system/path.py:
801         (_CygPath.convertFast):
802
803 2016-08-11  Brady Eidson  <beidson@apple.com>
804
805         Add WK2 ExperimentalFeature support to MiniBrowser.
806         https://bugs.webkit.org/show_bug.cgi?id=160788
807
808         Reviewed by Alex Christensen.
809
810         * MiniBrowser/mac/AppDelegate.h:
811         * MiniBrowser/mac/AppDelegate.m:
812         (defaultConfiguration):
813         (defaultPreferences):
814         
815         * MiniBrowser/mac/SettingsController.m:
816         (-[SettingsController _populateMenu]):
817         (-[SettingsController validateMenuItem:]):
818         (-[SettingsController toggleExperimentalFeature:]):
819
820 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
821
822         Keep EWS logs for longer
823         https://bugs.webkit.org/show_bug.cgi?id=160776
824
825         Reviewed by Daniel Bates.
826
827         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
828
829 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
830
831         iOS DRT/WTR project cleanup
832         https://bugs.webkit.org/show_bug.cgi?id=160778
833
834         Reviewed by Tim Horton.
835
836         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
837
838         Remove AppDelegate.* which were unused.
839
840         Exclude ios/Launch.storyboard on more platforms.
841
842         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
843         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
844         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
845         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
846         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
847         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
848         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
849
850 2016-08-11  Alex Christensen  <achristensen@webkit.org>
851
852         Fix Yosemite bots' cookie accept policies after r204365.
853         https://bugs.webkit.org/show_bug.cgi?id=160758
854
855         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
856         (TEST):
857         This makes the test fully clean up after itself.
858
859 2016-08-11  Alex Christensen  <achristensen@webkit.org>
860
861         Fix Yosemite bots' cookie accept policies after r204365.
862         https://bugs.webkit.org/show_bug.cgi?id=160758
863
864         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
865         (TEST):
866         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
867         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
868         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
869         causing any problems because there are no other API tests that do anything with cookies.
870         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
871         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
872         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
873
874 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
875
876         EWS should check if the patch is still valid before executing every major step
877         https://bugs.webkit.org/show_bug.cgi?id=160739
878         rdar://problem/27768813
879
880         Reviewed by Alexey Proskuryakov.
881
882         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
883         (CommitQueueTask.run): validate method is now executed in base class.
884         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
885         (EarlyWarningSystemTask.run): validate method is now executed in base class.
886         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
887         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
888         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
889         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
890         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
891         * Scripts/webkitpy/tool/commands/perfalizer.py:
892         (PerfalizerTask.validate): Added.
893         * Scripts/webkitpy/tool/commands/queues_unittest.py:
894         (test_manual_reject_during_processing): Updated test case.
895
896 2016-08-11  Alex Christensen  <achristensen@webkit.org>
897
898         Add URLParser stub
899         https://bugs.webkit.org/show_bug.cgi?id=160770
900
901         Reviewed by Sam Weinig.
902
903         * TestWebKitAPI/PlatformGTK.cmake:
904         * TestWebKitAPI/PlatformWin.cmake:
905         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
906         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
907         (TestWebKitAPI::TEST_F):
908
909 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
910
911         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
912         https://bugs.webkit.org/show_bug.cgi?id=160761
913
914         Reviewed by Tim Horton.
915
916         Give iOS DRT a Launch storyboard.
917
918         Have it use a UIViewController so future forms testing works correctly.
919
920         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
921         can run in iPad mode.
922
923         Remove empty InfoPlist.strings files.
924
925         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
926         * DumpRenderTree/ios/Info.plist:
927         * DumpRenderTree/ios/Launch.storyboard: Added.
928         * DumpRenderTree/mac/DumpRenderTree.mm:
929         (createWebViewAndOffscreenWindow):
930         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
931         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
932         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
933         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
934
935 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
936
937         [Win] Unable to reliably run tests in parallel
938         https://bugs.webkit.org/show_bug.cgi?id=140914
939
940         Reviewed by Brent Fulgham.
941
942         The cygpath utility function can fail badly when running with multiple DumpRenderTree
943         processes. We can use string replacement to convert the Cygwin path to a Windows path
944         instead.
945
946         * Scripts/webkitpy/common/system/path.py:
947         (cygpathFast):
948         * Scripts/webkitpy/port/driver.py:
949         (Driver._command_from_driver_input):
950
951 2016-08-10  Alex Christensen  <achristensen@webkit.org>
952
953         Fix crash when changing cookie accept policy after r204327
954         https://bugs.webkit.org/show_bug.cgi?id=160758
955
956         Reviewed by Simon Fraser.
957
958         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
959         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
960         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
961         (TEST):
962         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
963
964 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
965
966         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
967         https://bugs.webkit.org/show_bug.cgi?id=160757
968
969         Reviewed by Tim Horton.
970
971         When programmatically creating the test UIWindow, make a root UIViewController and parent
972         the WKWebView in its view. This makes the app more like a normal UIKit application.
973         
974         Move the WKWebView down 20px to avoid the status bar.
975         
976         Give the UIWindow a gray background so it's obvious where the window and view positioned.
977
978         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
979         
980         Remove duplicate references to Launch.storyboard.
981
982         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
983         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
984         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
985         (-[AppDelegate applicationWillResignActive:]): Deleted.
986         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
987         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
988         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
989         (-[AppDelegate applicationWillTerminate:]): Deleted.
990         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
991         (WTR::viewRectForWindowRect):
992         (WTR::PlatformWebView::PlatformWebView):
993         (WTR::PlatformWebView::setWindowFrame):
994
995 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
996
997         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
998         https://bugs.webkit.org/show_bug.cgi?id=160748
999
1000         Reviewed by Tim Horton.
1001         
1002         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
1003         opens the door for tests using other device sizes.
1004
1005         * WebKitTestRunner/ios/TestControllerIOS.mm:
1006         (WTR::TestController::platformConfigureViewForTest):
1007
1008 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1009
1010         Sort the feature flags in the FEATURE_DEFINES lines
1011         https://bugs.webkit.org/show_bug.cgi?id=160742
1012
1013         Reviewed by Anders Carlsson.
1014         
1015         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1016
1017 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
1018
1019         Logging and other minor improvements to iOS webkitpy
1020         https://bugs.webkit.org/show_bug.cgi?id=160722
1021
1022         Reviewed by Dan Bates.
1023
1024         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
1025         to make it easier to debug launching issues.
1026
1027         Have reset_preferences() reset the device, rather than just nuking the data
1028         directory (which broke some versions of the simulator).
1029
1030         Make the Simulator.app launch in the background with open -g.
1031
1032         Wait for the simulator device to be in a known state in some more places.
1033
1034         * Scripts/webkitpy/port/ios.py:
1035         (IOSSimulatorPort.setup_test_run):
1036         (IOSSimulatorPort._quit_ios_simulator):
1037         (IOSSimulatorPort.clean_up_test_run):
1038         (IOSSimulatorPort.setup_environ_for_server):
1039         (IOSSimulatorPort.reset_preferences):
1040         * Scripts/webkitpy/xcode/simulator.py:
1041         (Device.create):
1042         (Device.delete):
1043         (Device):
1044         (Device.reset):
1045         (Simulator.wait_until_device_is_booted):
1046         (Simulator.wait_until_device_is_in_state):
1047         (Simulator):
1048         (Simulator.delete_device):
1049         (Simulator.reset_device):
1050         (Simulator.lookup_or_create_device):
1051
1052 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1053
1054         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
1055         https://bugs.webkit.org/show_bug.cgi?id=160697
1056
1057         Reviewed by Antonio Gomes.
1058
1059         * Scripts/webkitpy/port/base.py:
1060         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
1061         list of environment variables to copy.
1062
1063 2016-08-09  George Ruan  <gruan@apple.com>
1064
1065         Implement functionality of media capture on iOS
1066         https://bugs.webkit.org/show_bug.cgi?id=158945
1067         <rdar://problem/26893343>
1068
1069         Reviewed by Tim Horton.
1070
1071         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
1072         Capture feature on iOS.
1073
1074 2016-08-09  Saam Barati  <sbarati@apple.com>
1075
1076         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
1077         https://bugs.webkit.org/show_bug.cgi?id=160671
1078         <rdar://problem/27756112>
1079
1080         Reviewed by Mark Lam.
1081
1082         * Scripts/run-jsc-stress-tests:
1083
1084 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
1085
1086         Make directory reading code in iOSSimulatorDevices() more strict
1087         https://bugs.webkit.org/show_bug.cgi?id=160702
1088
1089         Reviewed by Tim Horton.
1090
1091         * Scripts/webkitdirs.pm:
1092         (iOSSimulatorDevices):
1093
1094 2016-08-06  Sam Weinig  <sam@webkit.org>
1095
1096         Replace NodeOrString with std::variant<RefPtr<Node>, String>
1097         https://bugs.webkit.org/show_bug.cgi?id=160638
1098
1099         Reviewed by Anders Carlsson.
1100
1101         * TestWebKitAPI/CMakeLists.txt:
1102         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1103         Add additional tests for the initial state of std::variant and using
1104         makeVisitor for visiting.
1105
1106 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
1107
1108         EWS logging should ensure the logging to file is stopped on queue termination
1109         https://bugs.webkit.org/show_bug.cgi?id=160698
1110         rdar://problem/24464570
1111
1112         Reviewed by Daniel Bates.
1113
1114         * Scripts/webkitpy/tool/bot/queueengine.py:
1115         (QueueEngine._stopping): Stop logging to file on queue termination.
1116         (QueueEngine._begin_logging): Configure the Python logger to log to file.
1117         * Scripts/webkitpy/common/system/logutils.py:
1118         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
1119         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1120         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
1121         * Scripts/webkitpy/tool/commands/queues.py:
1122         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
1123         (AbstractQueue.queue_log_path): Same.
1124         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
1125         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
1126         which moved to QueueEngine now.
1127         (PatchProcessingQueue.__init__): Same.
1128         (CommitQueue.__init__): Same.
1129         (AbstractReviewQueue.__init__): Same.
1130         (StyleQueue.__init__): Same.
1131         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1132         (TestCommitQueue): Removed host parameter.
1133         (TestCommitQueue.__init__): Same.
1134         (AbstractPatchQueueTest.test_next_patch): Same.
1135         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1136         (test_commit_queue_failure): Same.
1137         (mock_run_webkit_patch):
1138         (MockCommitQueueTask.results_from_patch_test_run): Same.
1139         (test_rollout_lands): Same.
1140         (test_non_valid_patch): Same.
1141         (test_auto_retry): Same.
1142         (test_style_queue_with_watch_list_exception): Same.
1143         (TestQueue.__init__): Deleted.
1144         (TestReviewQueue.__init__): Deleted.
1145         (TestFeederQueue.__init__): Deleted.
1146
1147 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
1148
1149         webkit-gtk tarball fails to build due to missing files
1150         https://bugs.webkit.org/show_bug.cgi?id=160684
1151
1152         Reviewed by Alex Christensen.
1153
1154         * gtk/manifest.txt.in: Added back spi directories.
1155
1156 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1157
1158         [GTK] Build the jhbuild with -O2 optimization level by default
1159         https://bugs.webkit.org/show_bug.cgi?id=160544
1160
1161         Reviewed by Michael Catanzaro.
1162
1163         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
1164         which don't increases the required disk space significatively and
1165         provides better debug information than no passing it.
1166
1167 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
1168
1169         Allow more --cmakeargs option in build-jsc and build-webkit
1170         https://bugs.webkit.org/show_bug.cgi?id=160340
1171
1172         Reviewed by Michael Catanzaro.
1173
1174         * Scripts/build-jsc:
1175         * Scripts/build-webkit:
1176
1177 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1178
1179         Do not check if WebKitLibraries folder exists on EFL and GTK
1180         https://bugs.webkit.org/show_bug.cgi?id=160659
1181
1182         Reviewed by Csaba Osztrogonác.
1183
1184         Though WebKitLibraries is only needed by mac and win ports,
1185         EFL and GTK ports have checked whether it exists.
1186
1187         * Scripts/build-webkit:
1188
1189 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
1190
1191         Some EWS console logs doesn't go to log file
1192         https://bugs.webkit.org/show_bug.cgi?id=160585
1193         rdar://problem/24464570
1194
1195         Reviewed by Daniel Bates.
1196
1197         * Scripts/webkitpy/common/system/logutils.py:
1198         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
1199         any possible overwriting.
1200         * Scripts/webkitpy/common/system/filesystem.py:
1201         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
1202         * Scripts/webkitpy/common/system/filesystem_mock.py:
1203         (MockFileSystem.open_text_file_for_writing): Same.
1204         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1205         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
1206         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
1207         * Scripts/webkitpy/tool/commands/queues.py:
1208         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
1209         This will ensure that all the sub-modules inside webkitpy will log to file.
1210
1211 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
1212
1213         Have the iOS platform interit from the Apple platform in webkitpy
1214         https://bugs.webkit.org/show_bug.cgi?id=160672
1215
1216         Reviewed by Dan Bates.
1217         
1218         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
1219         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
1220         ApplePort.
1221         
1222         Since WinPort also inherits from ApplePort, it needs to stub out some things
1223         that are unavailable on Windows (leaks, sampling).
1224         
1225         Some SnowLeopard-related code and the associated test were removed.
1226
1227         * Scripts/webkitpy/port/apple.py:
1228         (ApplePort.__init__):
1229         (ApplePort):
1230         (ApplePort._make_leak_detector):
1231         (ApplePort.default_timeout_ms):
1232         (ApplePort.supports_per_test_timeout):
1233         (ApplePort.should_retry_crashes):
1234         (ApplePort._generate_all_test_configurations):
1235         (ApplePort.check_for_leaks):
1236         (ApplePort.print_leaks_summary):
1237         (ApplePort._path_to_webcore_library):
1238         (ApplePort.show_results_html_file):
1239         (ApplePort._merge_crash_logs):
1240         (ApplePort._look_for_all_crash_logs_in_log_dir):
1241         (ApplePort._get_crash_log):
1242         (ApplePort.look_for_new_crash_logs):
1243         (ApplePort.sample_process):
1244         (ApplePort.sample_file_path):
1245         (ApplePort.look_for_new_samples):
1246         (ApplePort._path_to_helper):
1247         (ApplePort.determine_full_port_name): Deleted.
1248         * Scripts/webkitpy/port/ios.py:
1249         (IOSSimulatorPort):
1250         (IOSSimulatorPort.__init__):
1251         (IOSSimulatorPort.default_timeout_ms): Deleted.
1252         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
1253         (IOSSimulatorPort.should_retry_crashes): Deleted.
1254         (IOSSimulatorPort.check_for_leaks): Deleted.
1255         (IOSSimulatorPort.print_leaks_summary): Deleted.
1256         (IOSSimulatorPort._path_to_webcore_library): Deleted.
1257         (IOSSimulatorPort.show_results_html_file): Deleted.
1258         (IOSSimulatorPort.sample_file_path): Deleted.
1259         (IOSSimulatorPort._merge_crash_logs): Deleted.
1260         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
1261         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1262         (IOSSimulatorPort.look_for_new_samples): Deleted.
1263         (IOSSimulatorPort.sample_process): Deleted.
1264         (IOSSimulatorPort._path_to_helper): Deleted.
1265         (IOSSimulatorPort.make_command): Deleted.
1266         * Scripts/webkitpy/port/mac.py:
1267         (MacPort.__init__):
1268         (MacPort.make_command):
1269         (MacPort._build_java_test_support):
1270         (MacPort): Deleted.
1271         (MacPort.default_timeout_ms): Deleted.
1272         (MacPort.supports_per_test_timeout): Deleted.
1273         (MacPort.should_retry_crashes): Deleted.
1274         (MacPort.default_child_processes): Deleted.
1275         (MacPort.check_for_leaks): Deleted.
1276         (MacPort.print_leaks_summary): Deleted.
1277         (MacPort._path_to_webcore_library): Deleted.
1278         (MacPort.show_results_html_file): Deleted.
1279         (MacPort.sample_file_path): Deleted.
1280         (MacPort._merge_crash_logs): Deleted.
1281         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
1282         (MacPort.look_for_new_crash_logs): Deleted.
1283         (MacPort.look_for_new_samples): Deleted.
1284         (MacPort.sample_process): Deleted.
1285         (MacPort._path_to_helper): Deleted.
1286         * Scripts/webkitpy/port/mac_unittest.py:
1287         (MacTest.test_default_child_processes): Deleted.
1288         * Scripts/webkitpy/port/win.py:
1289         (WinPort.look_for_new_samples):
1290         (WinPort):
1291         (WinPort.sample_process):
1292         (WinPort._make_leak_detector):
1293         (WinPort.check_for_leaks):
1294         (WinPort.print_leaks_summary):
1295         (WinPort._path_to_webcore_library):
1296
1297 2016-08-08  Matt Baker  <mattbaker@apple.com>
1298
1299         Unreviewed: moved myself to the reviewers list.
1300
1301         * Scripts/webkitpy/common/config/contributors.json:
1302
1303 2016-08-08  Chris Dumez  <cdumez@apple.com>
1304
1305         Update API tests in mac/SetDocumentURI.mm after r204247
1306         https://bugs.webkit.org/show_bug.cgi?id=160660
1307
1308         Reviewed by Alex Christensen.
1309
1310         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1311         (TestWebKitAPI::TEST):
1312
1313 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
1314
1315         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
1316         https://bugs.webkit.org/show_bug.cgi?id=159827
1317
1318         Reviewed by Daniel Bates.
1319
1320         This change was spurred by a process hang which occurred between tests and did
1321         not produce a meaningful crashlog.
1322
1323         * Scripts/webkitpy/port/driver.py:
1324         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1325
1326          * Scripts/webkitpy/port/ios.py:
1327         (IOSSimulatorPort):
1328         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1329         * Scripts/webkitpy/port/mac.py:
1330         (MacPort):
1331         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1332
1333         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1334         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1335
1336         * WebKitTestRunner/TestController.h:
1337         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1338         * WebKitTestRunner/TestInvocation.cpp:
1339         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1340
1341 2016-08-07  Dan Bernstein  <mitz@apple.com>
1342
1343         [Cocoa] Reply block leaks if the remote object doesn’t call it
1344         https://bugs.webkit.org/show_bug.cgi?id=160642
1345
1346         Reviewed by Sam Weinig.
1347
1348         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1349         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1350         (TEST): Added a test case that checks that the reply block is released even when it’s not
1351           called.
1352         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1353         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1354           calling the completion handler.
1355
1356 2016-08-07  Chris Dumez  <cdumez@apple.com>
1357
1358         Write API test to cover crash fix in r204135
1359         https://bugs.webkit.org/show_bug.cgi?id=160587
1360
1361         Reviewed by Darin Adler.
1362
1363         Add API test to cover crash fix in r204135. This reproduces the crash
1364         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1365         callback.
1366
1367         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1368         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1369         (TEST):
1370
1371 2016-08-06  Chris Dumez  <cdumez@apple.com>
1372
1373         Unreviewed, rolling out r204226.
1374
1375         Broke some API tests
1376
1377         Reverted changeset:
1378
1379         "Write API test to cover crash fix in r204135"
1380         https://bugs.webkit.org/show_bug.cgi?id=160587
1381         http://trac.webkit.org/changeset/204226
1382
1383 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1384
1385         EWS Style Queue fails to process patches which fails validation
1386         https://bugs.webkit.org/show_bug.cgi?id=160632
1387
1388         Reviewed by Alexey Proskuryakov.
1389
1390         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1391         (StyleQueueTask.validate): Add more information about validation failure.
1392         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1393         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1394         (test_non_valid_patch): Add a unit test to test the above code path.
1395
1396 2016-08-06  Sam Weinig  <sam@webkit.org>
1397
1398         WTF needs a variant implementation
1399         https://bugs.webkit.org/show_bug.cgi?id=160618
1400
1401         Reviewed by Darin Adler.
1402
1403         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1404         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1405         Add tests for the variant implementation.
1406
1407 2016-08-06  Chris Dumez  <cdumez@apple.com>
1408
1409         Write API test to cover crash fix in r204135
1410         https://bugs.webkit.org/show_bug.cgi?id=160587
1411
1412         Reviewed by Darin Adler.
1413
1414         Add API test to cover crash fix in r204135. This reproduces the crash
1415         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1416         callback.
1417
1418         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1419         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1420         (TEST):
1421
1422 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1423
1424         run-api-tests should use a headed simulator
1425         https://bugs.webkit.org/show_bug.cgi?id=160611
1426
1427         Reviewed by Sam Weinig.
1428
1429         CADisplayLink doesn't work in a headless simulator, but is
1430         vital for the proper functioning of WebKit2 painting on iOS.
1431         So, we should not use a headless simulator.
1432
1433         * Scripts/run-api-tests:
1434         Launch a simulator app, don't just boot the simulator.
1435
1436         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1437         Re-enable a test that works now.
1438
1439 2016-08-05  Dan Bernstein  <mitz@apple.com>
1440
1441         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1442         https://bugs.webkit.org/show_bug.cgi?id=160589
1443
1444         Reviewed by Tim Horton.
1445
1446         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1447         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1448           blocks, which wasn’t caught because the test wasn’t run correctly.
1449         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1450         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1451           added a test that sends over an NSRange.
1452         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1453         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1454           handler with the range‘s location and length.
1455
1456 2016-08-05  Enrica Casucci  <enrica@apple.com>
1457
1458         Fixing tests failing after r204175.
1459
1460         Unreviewed.
1461
1462         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1463
1464 2016-08-05  Enrica Casucci  <enrica@apple.com>
1465
1466         Build fix after 204053.
1467
1468         Unreviewed.
1469
1470         * TestWebKitAPI/Configurations/Base.xcconfig:
1471         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1472         (-[MockContentFilterEnabler initWithCoder:]):
1473         (-[MockContentFilterEnabler dealloc]):
1474
1475 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1476
1477         Print test name in "Last character read from DRT..." error message.
1478         https://bugs.webkit.org/show_bug.cgi?id=160559
1479
1480         Reviewed by Michael Catanzaro.
1481
1482         * Scripts/webkitpy/port/driver.py:
1483         (Driver.run_test):
1484         (Driver._read_first_block):
1485         (Driver._read_optional_image_block):
1486         (Driver._read_block):
1487         * Scripts/webkitpy/port/driver_unittest.py:
1488         (DriverTest.test_read_block):
1489         (DriverTest.test_read_binary_block):
1490         (DriverTest.test_read_base64_block):
1491
1492 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1493
1494         Unreviewed, rolling out r204123.
1495         https://bugs.webkit.org/show_bug.cgi?id=160597
1496
1497         Caused layout test timeouts on Windows. (Requested by perarne
1498         on #webkit).
1499
1500         Reverted changeset:
1501
1502         "[Win] Unable to reliably run tests in parallel"
1503         https://bugs.webkit.org/show_bug.cgi?id=140914
1504         http://trac.webkit.org/changeset/204123
1505
1506 2016-08-04  Saam Barati  <sbarati@apple.com>
1507
1508         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1509         https://bugs.webkit.org/show_bug.cgi?id=151241
1510
1511         Reviewed by Benjamin Poulain.
1512
1513         * Scripts/run-jsc-stress-tests:
1514
1515 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1516
1517         UI improvements to Flakiness Dashboard.
1518         https://bugs.webkit.org/show_bug.cgi?id=153295
1519
1520         Reviewed by Alexey Proskuryakov.
1521
1522         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1523         (td.options-container): Center text in most fields.
1524         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1525         (createBugHTML): Text/Grammar updates.
1526         (tableHeaders): Ditto.
1527         (htmlForSingleTestRow): Ditto.
1528         (headerForTestTableHtml): Ditto.
1529         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1530         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1531
1532 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1533
1534         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1535         https://bugs.webkit.org/show_bug.cgi?id=160518
1536
1537         Reviewed by Michael Catanzaro.
1538
1539         * Scripts/webkitpy/thirdparty/__init__.py:
1540         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1541         * gtk/install-dependencies:
1542
1543 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1544
1545         Optimize bot watcher's dashboard a little
1546         https://bugs.webkit.org/show_bug.cgi?id=160515
1547         rdar://problem/26096900
1548
1549         Reviewed by Lucas Forschler.
1550
1551         Made re-sorting after loading an iteration more efficient.
1552
1553         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1554         (BuildbotIteration.prototype._updateWithData):
1555         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1556         (BuildbotQueue.prototype.updateIterationPosition):
1557
1558 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1559
1560         [Win] Unable to reliably run tests in parallel
1561         https://bugs.webkit.org/show_bug.cgi?id=140914
1562
1563         Reviewed by Brent Fulgham.
1564
1565         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1566         processes. We can use string replacement to convert the Cygwin path to a Windows path
1567         instead.
1568  
1569         * Scripts/webkitpy/common/system/path.py:
1570         (cygpathFast):
1571         * Scripts/webkitpy/port/driver.py:
1572         (Driver._command_from_driver_input):
1573
1574 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1575
1576         Document instructions for increasing process and file limits
1577         https://bugs.webkit.org/show_bug.cgi?id=160528
1578         rdar://problem/24777576
1579
1580         Reviewed by Alexey Proskuryakov.
1581
1582         * Scripts/webkitpy/port/ios.py:
1583         (IOSSimulatorPort.default_child_processes):
1584
1585 2016-08-03  Anders Carlsson  <andersca@apple.com>
1586
1587         Remove the Objective-C bindings generator
1588         https://bugs.webkit.org/show_bug.cgi?id=160526
1589
1590         Reviewed by Sam Weinig.
1591
1592         * Scripts/run-bindings-tests:
1593         Update test.
1594
1595 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1596
1597         Revise a TestWebKitAPI comment to mention the actual underlying problem
1598
1599         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1600         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1601
1602 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1603
1604         Benchmark test content-animation timeouts always
1605         https://bugs.webkit.org/show_bug.cgi?id=160057
1606
1607         Reviewed by Simon Fraser.
1608
1609         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1610         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1611         (start):
1612
1613 2016-08-02  Nan Wang  <n_wang@apple.com>
1614
1615         AX: Simulated touch events are not working on iOS
1616         https://bugs.webkit.org/show_bug.cgi?id=160395
1617         <rdar://problem/27633597>
1618
1619         Reviewed by Chris Fleizach.
1620
1621         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1622         (WTR::AccessibilityUIElement::press):
1623         (WTR::AccessibilityUIElement::setSelectedChild):
1624
1625 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1626
1627         run-javascriptcore-tests should accept multiple --extra-tests
1628         https://bugs.webkit.org/show_bug.cgi?id=160486
1629
1630         Reviewed by Saam Barati.
1631         
1632         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1633         test suites. This does it by using GetOpt::Long's array support.
1634
1635         * Scripts/run-javascriptcore-tests:
1636         (runJSCStressTests):
1637
1638 2016-08-02  Enrica Casucci  <enrica@apple.com>
1639
1640         Allow building with content filtering disabled.
1641         https://bugs.webkit.org/show_bug.cgi?id=160454
1642
1643         Reviewed by Simon Fraser.
1644
1645         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1646
1647 2016-08-02  Brady Eidson  <beidson@apple.com>
1648
1649         Removing IndexedDB WebsiteData can fail for some users.
1650         https://bugs.webkit.org/show_bug.cgi?id=160463
1651
1652         Reviewed by Alex Christensen.
1653
1654         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1655
1656 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1657
1658         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1659         https://bugs.webkit.org/show_bug.cgi?id=160437
1660         <rdar://problem/27578272>
1661
1662         Reviewed by Brady Eidson.
1663
1664         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1665         (-[DownloadDelegate _download:didReceiveResponse:]):
1666         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1667         (runTest):
1668         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1669
1670 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1671
1672         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1673         https://bugs.webkit.org/show_bug.cgi?id=160414
1674
1675         Reviewed by Michael Catanzaro.
1676
1677         * Scripts/webkitpy/port/linux_get_crash_log.py:
1678         (GDBCrashLogGenerator._wait_for_corefile):
1679
1680 2016-08-01  Youenn Fablet  <youenn@apple.com>
1681
1682         Make wpt server generate its certificates in layout test results folder
1683         https://bugs.webkit.org/show_bug.cgi?id=160422
1684
1685         Reviewed by Chris Dumez.
1686
1687         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1688         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1689
1690 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1691
1692         Function Call on NULL Object
1693         https://bugs.webkit.org/show_bug.cgi?id=160325
1694
1695         Reviewed by Darin Adler.
1696
1697         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1698         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1699         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1700
1701 2016-08-01  Keith Miller  <keith_miller@apple.com>
1702
1703         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1704         https://bugs.webkit.org/show_bug.cgi?id=160372
1705
1706         Rubber stamped by Geoffrey Garen.
1707
1708         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1709         a new top level directory, JSTests. Having the tests in the Source directory
1710         was both confusing an inconvenient for people that just want to checkout the
1711         source code of WebKit. Since there is no other obvious place to put all the
1712         JavaScript tests a new top level directory seemed the most sensible.
1713
1714         * Scripts/import-test262-tests:
1715         * Scripts/run-javascriptcore-tests:
1716         * Scripts/update-javascriptcore-test-res:
1717
1718 2016-07-31  Nan Wang  <n_wang@apple.com>
1719
1720         AX: Add a check for touch event listener on iOS accessibility object
1721         https://bugs.webkit.org/show_bug.cgi?id=160388
1722
1723         Reviewed by Chris Fleizach.
1724
1725         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1726         (AccessibilityUIElement::boolAttributeValue):
1727         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1728         (WTR::AccessibilityUIElement::boolAttributeValue):
1729
1730 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1731
1732         Unreviewed: add myself to the reviewers list.
1733
1734         * Scripts/webkitpy/common/config/contributors.json:
1735
1736 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1737
1738         Undo r203939, and copy over a rule that clips the logos.
1739
1740         Sierra wasn't the only logo without transparency.
1741
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1743         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1745
1746 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1747
1748         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1749         https://bugs.webkit.org/show_bug.cgi?id=160377
1750
1751         Reviewed by Brian Weinstein.
1752
1753         Update assets to remove the white background and use a transparent background instead.
1754
1755         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1756         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1757
1758 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1759
1760         Ignore most check-webkit-style checks for ANGLE project
1761         <https://webkit.org/b/160333>
1762
1763         Reviewed by Daniel Bates.
1764
1765         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1766         - No tabs.
1767         - No spaces at the end of lines.
1768         - No carriage returns (DOS line endings).
1769
1770 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1771
1772         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1773         https://bugs.webkit.org/show_bug.cgi?id=160360
1774         <rdar://problem/27179484>
1775
1776         Reviewed by Myles C. Maxfield.
1777
1778         Adds two tests verifying that videos may be considered main content as long as they
1779         are large enough and cover a majority of the mainframe's viewport.
1780
1781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1782         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1783         (TestWebKitAPI::TEST):
1784         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1785         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1786
1787 2016-07-29  Mark Lam  <mark.lam@apple.com>
1788
1789         Gardening: removed unused variable.
1790
1791         Not reviewed.
1792
1793         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1794         (TestWebKitAPI::TEST):
1795
1796 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1797
1798         Add TestWebKitAPI support for interacting with media controls
1799         https://bugs.webkit.org/show_bug.cgi?id=160342
1800         <rdar://problem/27610246>
1801
1802         Reviewed by Beth Dakin.
1803
1804         Adds support for testing interaction with some media controls, as well as a basic test
1805         verifying that media control teardown after interaction does not result in a crash.
1806
1807         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1808         (-[WKWebView mouseDownAtPoint:]):
1809         (-[WKWebView performAfterLoading:]):
1810         (TestWebKitAPI::TEST):
1811
1812 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1813
1814         Crash Log Clobbering on Unbound Crashes
1815         https://bugs.webkit.org/show_bug.cgi?id=160198
1816         <rdar://problem/27472618>
1817
1818         Reviewed by Alexey Proskuryakov.
1819
1820         * Scripts/webkitpy/common/system/crashlogs.py:
1821         (CrashLogs): Fix header order.
1822         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1823         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1824
1825 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1826
1827         Update for contributors.json
1828         https://bugs.webkit.org/show_bug.cgi?id=160294
1829
1830         * Scripts/webkitpy/common/config/contributors.json:
1831
1832 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1833
1834         Remove deprecated SPI for video inline / fullscreen controls
1835         https://bugs.webkit.org/show_bug.cgi?id=160318
1836
1837         Reviewed by Tim Horton.
1838
1839         * DumpRenderTree/mac/DumpRenderTree.mm:
1840         (setDefaultsToConsistentValuesForTesting): Deleted.
1841         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1842         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1843         * WebKitTestRunner/TestController.cpp:
1844         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1845         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1846         (WTR::initializeWebViewConfiguration): Deleted.
1847
1848 2016-07-28  Daniel Bates  <dabates@apple.com>
1849
1850         [iOS] TestWebKitAPI bundle targets are not code signed
1851         https://bugs.webkit.org/show_bug.cgi?id=160328
1852         <rdar://problem/27409246>
1853
1854         Reviewed by Andy Estes.
1855
1856         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1857         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1858         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1859
1860         * TestWebKitAPI/Configurations/Base.xcconfig:
1861
1862 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1863
1864         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1865
1866         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1867         (animatedResizeWebView):
1868         (TEST):
1869         This test times out only when run in the WebKit Testing simulator environment,
1870         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1871
1872 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1873
1874         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1875         https://bugs.webkit.org/show_bug.cgi?id=160289
1876         <rdar://problem/27553464>
1877
1878         Reviewed by Simon Fraser.
1879
1880         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1882         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1883         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1884         (-[AnimatedResizeWebView _endAnimatedResize]):
1885         (animatedResizeWebView):
1886         (TEST):
1887         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1888         Add two tests that ensure that hidden-content and animated resizes
1889         don't cause unnecessary synchronous waits. Only the hidden-content
1890         one fails before my patch, but it seemed reasonable to add both anyway.
1891
1892 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1893
1894         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1895         <https://webkit.org/b/83342>
1896
1897         Reviewed by Ryosuke Niwa.
1898
1899         * Scripts/webkitpy/common/checkout/scm/git.py:
1900         (Git.revisions_changing_file): Remove code to raise an exception
1901         when the file doesn't exist.  If a file was moved or renamed,
1902         then this caused the script to terminate, which was very
1903         frustrating when you wanted a list of reviewers.
1904         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1905         (SCMTest._shared_test_revisions_changing_file): Update test
1906         expectation to return an empty list of revisions.
1907         (test_create_patch_is_full_patch): Drive-by fix when running all
1908         webkitpy tests (including scm tests).
1909         * Scripts/webkitpy/common/checkout/scm/svn.py:
1910         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1911         return an empty array of revisions if this occurs.
1912
1913 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1914
1915         EWS error message "Error: * did not process patch" should include explanation
1916         https://bugs.webkit.org/show_bug.cgi?id=159903
1917         <rdar://problem/27410788>
1918
1919         Reviewed by Alexey Proskuryakov.
1920
1921         * QueueStatusServer/handlers/statusbubble.py:
1922         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1923         is not processed.
1924         * QueueStatusServer/handlers/processingtimesjson.py:
1925         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1926         of the code.
1927         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1928         (CommitQueueTask.validate): Add more information about validation failure.
1929         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1930         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1931         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1932         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1933         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1934         (PatchIsNotValid.__init__): Add the failure_message argument.
1935         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1936         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1937         failure details.
1938         * Scripts/webkitpy/tool/commands/queues.py:
1939         (CommitQueue.process_work_item): Same.
1940         (StyleQueue.review_patch): Same.
1941         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1942         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1943
1944 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1945
1946         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1947         https://bugs.webkit.org/show_bug.cgi?id=160262
1948
1949         Reviewed by Daniel Bates.
1950
1951         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1952         (-[LTRelayController installApp]):
1953
1954 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1955
1956         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1957         https://bugs.webkit.org/show_bug.cgi?id=160225
1958
1959         Reviewed by Alexey Proskuryakov.
1960
1961         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1962
1963 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1964
1965         [GTK] Fix some video/canvas tests that should be passing
1966         https://bugs.webkit.org/show_bug.cgi?id=160023
1967
1968         Reviewed by Carlos Garcia Campos.
1969
1970         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1971         EFL or GTK platforms.
1972
1973         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1974         (WTR::TestController::platformConfigureViewForTest):
1975         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1976         (WTR::TestController::platformConfigureViewForTest):
1977
1978 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1979
1980         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1981         https://bugs.webkit.org/show_bug.cgi?id=160247
1982
1983         Reviewed by Michael Catanzaro.
1984
1985         * BuildSlaveSupport/built-product-archive:
1986         (createZip):
1987         (dirContainsdwo):
1988         (archiveBuiltProduct):
1989
1990 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1991
1992         Fix tests after r203743.
1993         https://bugs.webkit.org/show_bug.cgi?id=156947
1994
1995         * WebKitTestRunner/TestController.cpp:
1996         (WTR::TestController::resetStateToConsistentValues):
1997         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1998
1999 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
2000
2001         [iPhone] Playing a video on tudou.com plays only sound, no video
2002         https://bugs.webkit.org/show_bug.cgi?id=160178
2003         <rdar://problem/27535468>
2004
2005         Reviewed by Dan Bernstein.
2006
2007         * DumpRenderTree/mac/DumpRenderTree.mm:
2008         (setDefaultsToConsistentValuesForTesting):
2009         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2010         (RequiresUserActionForPlaybackTest::SetUp):
2011         * WebKitTestRunner/TestController.cpp:
2012         (WTR::TestController::resetPreferencesToConsistentValues):
2013         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2014         (WTR::initializeWebViewConfiguration):
2015
2016 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2017
2018         Allow LOG macros to be used outside the namespace, and other logging cleanup
2019         https://bugs.webkit.org/show_bug.cgi?id=160216
2020
2021         Reviewed by Anders Carlsson.
2022         
2023         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
2024
2025         * DumpRenderTree/TestRunner.cpp:
2026         * DumpRenderTree/mac/DumpRenderTree.mm:
2027         (resetWebViewToConsistentStateBeforeTesting):
2028
2029 2016-07-26  David Kilzer <ddkilzer@apple.com>
2030
2031         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
2032         https://bugs.webkit.org/show_bug.cgi?id=156947
2033         <rdar://problem/23325160>
2034
2035         Reviewed by Alex Christensen.
2036
2037         * DumpRenderTree/TestRunner.cpp:
2038         (TestRunner::TestRunner):
2039         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
2040         * DumpRenderTree/TestRunner.h:
2041         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2042         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2043         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2044         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2045         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2046         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2047         (WTR::TestRunner::queueNonLoadingScript):
2048         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2049         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2050         * WebKitTestRunner/TestController.cpp:
2051         (WTR::TestController::didReceiveAuthenticationChallenge):
2052         * WebKitTestRunner/TestController.h:
2053         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2054         * WebKitTestRunner/TestInvocation.cpp:
2055         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2056         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
2057
2058 2016-07-26  David Kilzer  <ddkilzer@apple.com>
2059
2060         check-for-exit-time-destructors should be usable outside Xcode
2061         <https://webkit.org/b/160195>
2062
2063         Reviewed by Darin Adler.
2064
2065         * Scripts/check-for-exit-time-destructors: Update to parse
2066         -h|--help switch, or to take one argument to a binary to check
2067         for exit time destructors on the command-line.  The clang
2068         compiler will find these at compile-time with the
2069         -Wexit-time-destructors switch, but this script will check for
2070         them after-the-fact.
2071
2072 2016-07-26  Lucas Forschler  <lforschler@apple.com>
2073
2074         Test svn.webkit.org functionality after maintenance.
2075
2076 2016-07-25  Brady Eidson  <beidson@apple.com>
2077
2078         Modern IDB: Make sure IndexedDB works from file:// url documents by default
2079         https://bugs.webkit.org/show_bug.cgi?id=153783
2080
2081         Reviewed by Alex Christensen.
2082
2083         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
2084         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
2085         
2086         As of https://trac.webkit.org/changeset/203695 this is no longer required.
2087         
2088         Change the relevant API tests to make sure this continues to be no longer required.
2089
2090         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2091         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2092         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2093         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2094         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2095         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2096
2097 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2098
2099         Media controls should not be displayed for a video until it starts playing
2100         https://bugs.webkit.org/show_bug.cgi?id=160092
2101         <rdar://problem/26986673>
2102
2103         Reviewed by Beth Dakin.
2104
2105         Verify that multiple videos do or don't show the media controller depending on whether videos
2106         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
2107         passing because we were always showing media controls for large videos with audio, even if they
2108         had not played back yet. This change ensures that large videos with audio show media controls
2109         only after they begin to play back, and not by virtue of being large enough for main content.
2110
2111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2112         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2113         (TestWebKitAPI::TEST):
2114         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
2115         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
2116         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
2117
2118 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2119
2120         Media controls on apple.com don't disappear when movie finishes playing
2121         https://bugs.webkit.org/show_bug.cgi?id=160068
2122         <rdar://problem/26668526>
2123
2124         Reviewed by Darin Adler.
2125
2126         Adds new API tests. Please see WebCore ChangeLog for more details.
2127
2128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2129         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2130         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
2131         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2132         (TestWebKitAPI::TEST):
2133         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
2134         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2135         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
2136         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
2137         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
2138
2139 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2140
2141         Unreviewed, fix test-webkitpy after r203674.
2142
2143         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2144         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2145
2146 2016-07-24  Philippe Normand  <pnormand@igalia.com>
2147
2148         Unreviewed, forgot to commit this file in r203674.
2149
2150         * Scripts/process-linux-coredump: Added.
2151         (main):
2152
2153 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2154
2155         Improve GDB backtrace generation for GTK/EFL
2156         https://bugs.webkit.org/show_bug.cgi?id=128928
2157
2158         Reviewed by Carlos Garcia Campos.
2159
2160         The PID of the crashed process is now correctly supplied to the
2161         crash log reporter. The kernel core_pattern needs to be updated
2162         after this change to something like:
2163
2164         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
2165
2166         * Scripts/process-linux-coredump: Added.
2167         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
2168         * Scripts/webkitpy/port/efl.py:
2169         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
2170         * Scripts/webkitpy/port/gtk.py:
2171         (GtkPort._get_crash_log): Ditto.
2172         * Scripts/webkitpy/port/linux_get_crash_log.py:
2173         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
2174         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
2175         (GDBCrashLogGenerator): Deleted.
2176         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2177         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
2178         * WebKitTestRunner/TestController.cpp:
2179         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
2180         (WTR::TestController::databaseProcessDidCrash): Ditto.
2181         (WTR::TestController::processDidCrash): Ditto.
2182
2183 2016-07-23  Youenn Fablet  <youenn@apple.com>
2184
2185         WPT stash server should be kept running when launching wpt server
2186         https://bugs.webkit.org/show_bug.cgi?id=160052
2187
2188         Reviewed by Sam Weinig.
2189
2190         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2191         (main): waiting to read stdin while stash server is started.
2192
2193 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2194
2195         Media controls should be displayed for media in media documents
2196         https://bugs.webkit.org/show_bug.cgi?id=160104
2197         <rdar://problem/27438936>
2198
2199         Reviewed by Myles C. Maxfield.
2200
2201         Verifies that even a small video with audio in a media document gets media controls.
2202
2203         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2204         (TestWebKitAPI::TEST):
2205
2206 2016-07-22  Michael Saboff  <msaboff@apple.com>
2207
2208         REGRESSION(203616): no FTL testing was inadvertently removed
2209         https://bugs.webkit.org/show_bug.cgi?id=160100
2210
2211         Rubber-stamped by Filip Pizlo.
2212
2213         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
2214         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
2215         logic for the runLayout and runNoisy variants to match the run test logic,
2216         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
2217         enabled platforms.
2218
2219         * Scripts/run-jsc-stress-tests:
2220
2221 2016-07-22  Brady Eidson  <beidson@apple.com>
2222
2223         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
2224         https://bugs.webkit.org/show_bug.cgi?id=160089
2225
2226         Reviewed by Darin Adler.
2227
2228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2229         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
2230         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
2231
2232 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
2233
2234         [GTK] Improved exclusion patterns in make-dist.py manifest.
2235         https://bugs.webkit.org/show_bug.cgi?id=160094
2236
2237         Reviewed by Michael Catanzaro.
2238
2239         * gtk/manifest.txt.in:
2240         Exclude Platform*.cmake files for more ports.
2241         Removed obsolete .gyp and .pro.user patterns.
2242         Exclude 'Configurations' and 'spi' directories.
2243         Exclude CMakeLists.txt.user (Qt Creator IDE).
2244
2245 2016-07-22  Michael Saboff  <msaboff@apple.com>
2246
2247         Don't run FTL related JSC stress tests on non-FTL platforms
2248         https://bugs.webkit.org/show_bug.cgi?id=160033
2249
2250         Reviewed by Mark Lam.
2251
2252         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
2253         Refactored several of the runXXX test methods to always runXXXDefault and made those
2254         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
2255         doesn't cause a problem.
2256
2257         * Scripts/run-jsc-stress-tests:
2258
2259 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
2260
2261         IWebView::mainFrame crashes if called after IWebView::close
2262         https://bugs.webkit.org/show_bug.cgi?id=32868
2263
2264         Reviewed by Brent Fulgham.
2265
2266         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2267         (TestWebKitAPI::TEST_F): Added test.
2268
2269 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2270
2271         [GTK] Enable threaded compositor by default
2272         https://bugs.webkit.org/show_bug.cgi?id=160079
2273
2274         Reviewed by Žan Doberšek.
2275
2276         * Scripts/webkitperl/FeatureList.pm:
2277
2278 2016-07-22  Youenn Fablet  <youenn@apple.com>
2279
2280         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
2281         https://bugs.webkit.org/show_bug.cgi?id=159921
2282
2283         Reviewed by Brian Burg.
2284
2285         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
2286
2287         * Scripts/webkitpy/codegen/main.py:
2288         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
2289         (BuiltinsGeneratorTests):
2290         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
2291         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
2292         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
2293         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
2294
2295 2016-07-21  Dan Bernstein  <mitz@apple.com>
2296
2297         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
2298         https://bugs.webkit.org/show_bug.cgi?id=160072
2299
2300         Reviewed by Andy Estes.
2301
2302         * Scripts/webkitdirs.pm:
2303         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
2304           for old Xcode versions.
2305         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
2306           to readXcodeUserDefault.
2307         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
2308           debugger.
2309         (determineDebugger): Ditto.
2310         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
2311           7.0.
2312         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
2313           switches.
2314         (execMacWebKitAppForDebugging): Removed support for GDB.
2315
2316 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2317
2318         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2319         https://bugs.webkit.org/show_bug.cgi?id=160066
2320
2321         Reviewed by Dean Jackson.
2322
2323         * DumpRenderTree/mac/DumpRenderTree.mm:
2324         (setDefaultsToConsistentValuesForTesting): Deleted.
2325         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2326         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2327         * WebKitTestRunner/TestController.cpp:
2328         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2329         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2330         (WTR::initializeWebViewConfiguration): Deleted.
2331
2332 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
2333
2334         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2335         https://bugs.webkit.org/show_bug.cgi?id=159980
2336         rdar://problem/27450825
2337
2338         Reviewed by Dan Bernstein.
2339
2340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2341         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2342         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2343         when our delegate has hit -dealloc.
2344         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2345         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2346         will not be messaged.
2347
2348 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2349
2350         Follow-up patch to r203520
2351         https://bugs.webkit.org/show_bug.cgi?id=159967
2352         <rdar://problem/26964090>
2353
2354         Unreviewed.
2355
2356         * DumpRenderTree/mac/DumpRenderTree.mm:
2357         (setDefaultsToConsistentValuesForTesting):
2358         * WebKitTestRunner/TestController.cpp:
2359         (WTR::TestController::resetPreferencesToConsistentValues):
2360
2361 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2362
2363         [iPhone] Playing a video on tudou.com plays only sound, no video
2364         https://bugs.webkit.org/show_bug.cgi?id=159967
2365         <rdar://problem/26964090>
2366
2367         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2368
2369         Migrate tests to use new SPI.
2370
2371         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2372         (RequiresUserActionForPlaybackTest::SetUp):
2373         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2374         (WTR::initializeWebViewConfiguration):
2375
2376 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2377
2378         Clarify testing mode names in run-jsc-stress-tests
2379         https://bugs.webkit.org/show_bug.cgi?id=160021
2380
2381         Reviewed by Mark Lam.
2382
2383         Default should mean really default, not default with disabled FTL, renamed
2384         - runMozillaTestDefault to runMozillaTestNoFTL
2385         - runMozillaTestDefaultFTL to runMozillaTestDefault
2386         - runDefault to runNoFTL
2387         - runDefaultFTL to runDefault
2388         - runLayoutTestDefault to runLayoutTestNoFTL
2389         - runLayoutTestDefaultFTL to runLayoutTestDefault
2390         - runNoisyTestDefault to runNoisyTestNoFTL
2391         - runNoisyTestDefaultFTL to runNoisyTestDefault
2392
2393         * Scripts/run-jsc-stress-tests:
2394
2395 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2396
2397         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2398         https://bugs.webkit.org/show_bug.cgi?id=159986
2399
2400         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2401         to 0.
2402
2403         Reviewed by Dan Bernstein.
2404
2405         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2406         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
2407         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
2408         (TEST):
2409
2410 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2411
2412         [GTK] Web view background colors don't work in accelerated compositing mode
2413         https://bugs.webkit.org/show_bug.cgi?id=159455
2414
2415         Reviewed by Michael Catanzaro.
2416
2417         Set always RGBA visual to the view widget when setting a background color.
2418
2419         * MiniBrowser/gtk/BrowserWindow.c:
2420         (browser_window_set_background_color):
2421
2422 2016-07-20  Youenn Fablet  <youenn@apple.com>
2423
2424         Bots should run built-ins generator tests
2425         https://bugs.webkit.org/show_bug.cgi?id=159971
2426
2427         Reviewed by Alexey Proskuryakov.
2428
2429         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2430         (RunBuiltinsTests): New step to run built-in generator tests.
2431         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2432         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2434
2435 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2436
2437         Revert temporary fix r203417
2438         https://bugs.webkit.org/show_bug.cgi?id=160001
2439
2440         Reviewed by Alexey Proskuryakov.
2441
2442         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2443
2444 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2445
2446         REGRESSION(r148588): ews classes might get garbage collected
2447         https://bugs.webkit.org/show_bug.cgi?id=159990
2448
2449         Reviewed by Ryosuke Niwa.
2450
2451         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2452         in a variable so that they do not get garbage collected.
2453
2454 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2455
2456         Add API test for layout constraints after exit fullscreen
2457         https://bugs.webkit.org/show_bug.cgi?id=159900
2458
2459         Reviewed by Jon Lee.
2460
2461         Added Fullscreen.LaytoutConstraints API test. 
2462         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2463
2464         This test compares layout constraints on the web view before and after fullscreen to make sure 
2465         they are preserved.
2466
2467         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2468         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2469         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2470         (TestWebKitAPI::TEST):
2471
2472 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2473
2474         Disable two failing API tests.
2475
2476         Unreviewed test gardening.
2477
2478         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2479         (TestWebKitAPI::TEST):
2480
2481 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2482
2483         Unreviewed iOS build fix.
2484
2485         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2486
2487 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2488
2489         Media controls don't appear when pausing a small autoplaying video
2490         https://bugs.webkit.org/show_bug.cgi?id=159972
2491         <rdar://problem/27180657>
2492
2493         Reviewed by Beth Dakin.
2494
2495         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2496         for simulating basic user interaction in VideoControlsManager.
2497
2498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2499         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2500         (-[WKWebView mouseDownAtPoint:]):
2501         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2502         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2503         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2504         (TestWebKitAPI::TEST):
2505         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2506
2507 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2508
2509         [Win] MathML fonts are not found.
2510         https://bugs.webkit.org/show_bug.cgi?id=159920
2511
2512         Reviewed by Alex Christensen.
2513
2514         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2515         for a specific registry key value.
2516
2517         * Scripts/webkitdirs.pm:
2518         (fontExists):
2519
2520 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2521
2522         Improve prepare-ChangeLog for @media blocks
2523         https://bugs.webkit.org/show_bug.cgi?id=159907
2524
2525         Reviewed by Timothy Hatcher.
2526
2527         * Scripts/prepare-ChangeLog:
2528         (get_selector_line_ranges_for_css):
2529         Get a range for @media blocks just like a selector.
2530             Start Line = line with '{'
2531             End line = line with '}'
2532             Name = "@media ..."
2533
2534         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2535         Improved error messages for unbalanced portions.
2536
2537         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2538         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2539         (.media-query::before):
2540         (@media only screen and (max-width: 980px)):
2541         (.media-query a):
2542         (@media (-webkit-min-device-pixel-ratio: 2)):
2543         (.both a):
2544         (.both b):
2545         (.media-query b):
2546         (.media-query::after):
2547
2548 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2549
2550         Fix expectedFailErrorHandler in run-jsc-stress-tests
2551         https://bugs.webkit.org/show_bug.cgi?id=159811
2552
2553         Reviewed by Yusuke Suzuki.
2554
2555         * Scripts/run-jsc-stress-tests:
2556
2557 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2558
2559         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2560
2561         * TestWebKitAPI/PlatformMac.cmake:
2562
2563 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2564
2565         The default testing mode should not involve disabling the FTL JIT
2566         https://bugs.webkit.org/show_bug.cgi?id=159929
2567
2568         Rubber stamped by Mark Lam and Saam Barati.
2569         
2570         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2571         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2572         FTL was not the default. You had to enable it with an option.
2573         
2574         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2575         all of the major ports. This has become a serious pain. For example, it's useful to be able
2576         to say that a test should only run in the default config that is representative of what a
2577         normal user would see if they ran JSC. Clearly, this would be a config that does not
2578         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2579         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2580         
2581         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2582         try to fix it, because:
2583         
2584         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2585           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2586           doesn't do anything. The code is not really structured to allow this.
2587         
2588         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2589           disabled in testing. On the other hand there are already build bots that do FTL tests
2590           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2591           preserving this broken feature, we should create something that (a) acknowledges the fact
2592           that the FTL is the default on those platforms that support it and (b) avoids running
2593           no-ftl tests on precisely those platforms that don't have FTL.
2594         
2595         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2596           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2597           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2598           pretending that the FTL JIT is not the default just because some bots used that as an
2599           optimization.
2600         
2601         This change allows me to speed up some debug tests and paint some bots green.
2602
2603         * Scripts/run-javascriptcore-tests:
2604         (runJSCStressTests):
2605         * Scripts/run-jsc-stress-tests:
2606
2607 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2608
2609         Fix API test after r203426.
2610         https://bugs.webkit.org/show_bug.cgi?id=159949
2611
2612         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2613         (TEST):
2614         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2615         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2616
2617 2016-07-19  Andy Estes  <aestes@apple.com>
2618
2619         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2620         https://bugs.webkit.org/show_bug.cgi?id=159956
2621
2622         Reviewed by Dan Bernstein.
2623
2624         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2625         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2626         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2627         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2628
2629 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2630
2631         Add regression test for r203392
2632         https://bugs.webkit.org/show_bug.cgi?id=159949
2633
2634         Reviewed by Brady Eidson.
2635
2636         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2637         (fileSize):
2638         (swizzledBundleIdentifierWebBookmarksD):
2639         (defaultApplicationCacheDirectory):
2640         (TEST):
2641         (swizzledBundleIdentifierMobileSafari): Deleted.
2642         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2643         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2644         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2645
2646 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2647
2648         Add regression test for r203392
2649         https://bugs.webkit.org/show_bug.cgi?id=159949
2650
2651         Reviewed by Brady Eidson.
2652
2653         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2654         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2655         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2656         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2657         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2658         (TEST):
2659         (fileSize):
2660         (swizzledBundleIdentifierMobileSafari):
2661         (swizzledBundleIdentifierWebBookmarksD):
2662         (defaultApplicationCacheDirectory):
2663         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2664         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2665         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2666         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2667
2668 2016-07-19  Keith Miller  <keith_miller@apple.com>
2669
2670         Test262 should have a file with the revision and url
2671         https://bugs.webkit.org/show_bug.cgi?id=159937
2672
2673         Reviewed by Mark Lam.
2674
2675         The import script should update the information from
2676         the path to the test262 repository it gets.
2677
2678         * Scripts/import-test262-tests:
2679
2680 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2681
2682         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2683         To be deleted once the root cause is found and addressed.
2684
2685         * EWSTools/start-queue-mac.sh:
2686
2687 2016-07-19  Frederic Wang  <fwang@igalia.com>
2688
2689         [win] Fixup the register name for STIX Math and Latin Modern Math
2690
2691         Unreviewed follow-up of r203406
2692
2693         * Scripts/webkitdirs.pm:
2694         (checkInstalledTools):
2695
2696 2016-07-19  Frederic Wang  <fwang@igalia.com>
2697
2698         [win] Update the list of MathML fonts
2699         https://bugs.webkit.org/show_bug.cgi?id=156838
2700
2701         The set of recommended math fonts is now described at
2702         https://trac.webkit.org/wiki/MathML/Fonts
2703         We update the Perl script to use the latest list of fonts.
2704
2705         Reviewed by Brent Fulgham.
2706
2707         * Scripts/webkitdirs.pm:
2708         (checkInstalledTools):
2709
2710 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2711
2712         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2713         https://bugs.webkit.org/show_bug.cgi?id=159342
2714
2715         Reviewed by Darin Adler.
2716
2717         Implement required functions in event sender.
2718
2719         * DumpRenderTree/PlatformWin.cmake:
2720         * DumpRenderTree/win/EventSender.cpp:
2721         (monitorWheelEvents): Added.
2722         (callAfterScrollingCompletes): Added.
2723
2724 2016-07-19  Youenn Fablet  <youenn@apple.com>
2725
2726         Add new aliases to http test server
2727         https://bugs.webkit.org/show_bug.cgi?id=159878
2728
2729         Reviewed by Darin Adler.
2730
2731         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2732         Adding explicitly these links to perl script.
2733         Extracting default alias in an aliases.json file.
2734         Reading that file from python scripts to initialize aliases from that file.
2735
2736         Python script changes covered by unit tests and changed layout test.
2737
2738         * Scripts/webkitperl/httpd.pm:
2739         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2740         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2741         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2742         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2743         Adding -c directives for each alias.
2744         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2745         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2746         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2747         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2748         Adding alias directive for each alias.
2749         (Lighttpd._prepare_config):
2750         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2751         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2752         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2753         layout tests directory.
2754         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2755         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2756         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2757
2758 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2759
2760         EWS console logs doesn't go to log file
2761         https://bugs.webkit.org/show_bug.cgi?id=159539
2762         <rdar://problem/24464570>
2763
2764         Reviewed by David Kilzer.
2765
2766         * Scripts/webkitpy/common/system/logutils.py:
2767         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2768         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2769         to filesystem. It also supports passing MockFilesystem.
2770         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2771         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2772         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2773         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2774         (_test_ews): Same.
2775         * Scripts/webkitpy/tool/commands/queues.py:
2776         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2777         (AbstractQueue._log_directory): Using filesystem object instead of os.
2778         (AbstractQueue.queue_log_path): Same.
2779         (AbstractQueue.__init__): Passed host parameter.
2780         (PatchProcessingQueue.__init__): Same.
2781         (CommitQueue.__init__): Same.
2782         (AbstractReviewQueue.__init__): Same.
2783         (StyleQueue.__init__): Same.
2784         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2785         (TestCommitQueue): Passed MockHost() as host.
2786         (TestCommitQueue.__init__): Same.
2787         (TestQueue.__init__): Same.
2788         (TestReviewQueue.__init__): Same.
2789         (TestFeederQueue.__init__): Same.
2790         (AbstractPatchQueueTest.test_next_patch): Same.
2791         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2792         (test_commit_queue_failure): Same.
2793         (MockCommitQueueTask.results_from_patch_test_run): Same.
2794         (test_rollout_lands): Same.
2795         (test_non_valid_patch): Same.
2796         (test_auto_retry): Same.
2797         (test_style_queue_with_watch_list_exception): Same.
2798
2799 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2800
2801         WTF::Lock should be fair eventually
2802         https://bugs.webkit.org/show_bug.cgi?id=159384
2803
2804         Reviewed by Geoffrey Garen.
2805
2806         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2807
2808 2016-07-17  Sam Weinig  <sam@webkit.org>
2809
2810         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2811         <rdar://problem/26554137>
2812         https://bugs.webkit.org/show_bug.cgi?id=159856
2813
2814         Reviewed by Dan Bernstein.
2815
2816         * MiniBrowser/mac/WK2BrowserWindowController.m:
2817         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2818         Add basic window.open implementation.
2819
2820         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2821         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2822         to open a single non-web URL, all others are dropped.
2823
2824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2825         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2826         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2827         Add API for the new SPI.
2828
2829 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2830
2831         [JSC] Enable test262 module tests
2832         https://bugs.webkit.org/show_bug.cgi?id=159854
2833
2834         Reviewed by Saam Barati.
2835
2836         Use --module-file instead.
2837
2838         * Scripts/run-jsc-stress-tests:
2839
2840 2016-07-16  Chris Dumez  <cdumez@apple.com>
2841
2842         Unreviewed, rolling out r203318.
2843
2844         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2845         SunSpider)
2846
2847         Reverted changeset:
2848
2849         "[JSC] Change some parameters based on a random search"
2850         https://bugs.webkit.org/show_bug.cgi?id=158514
2851         http://trac.webkit.org/changeset/203318
2852
2853 2016-07-16  Chris Dumez  <cdumez@apple.com>
2854
2855         Add move constructor / assignment operator to ListHashSet
2856         https://bugs.webkit.org/show_bug.cgi?id=159837
2857
2858         Reviewed by Darin Adler.
2859
2860         Add API tests.
2861
2862         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2863         (TestWebKitAPI::TEST):
2864
2865 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2866
2867         [JSC] Change some parameters based on a random search
2868         https://bugs.webkit.org/show_bug.cgi?id=158514
2869
2870         Reviewed by Saam Barati.
2871
2872         * Scripts/run-jsc-stress-tests:
2873
2874 2016-07-15  Jon Davis  <jond@apple.com>
2875
2876         Changed the start page URL for WebKit Nightly builds.
2877         https://bugs.webkit.org/show_bug.cgi?id=159816
2878
2879         Reviewed by Timothy Hatcher.
2880
2881         * WebKitLauncher/start.html:
2882
2883 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2884
2885         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2886         https://bugs.webkit.org/show_bug.cgi?id=159414
2887
2888         Reviewed by Brent Fulgham.
2889
2890         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2891         when the HDC parameter is invalid.
2892
2893         * TestWebKitAPI/PlatformWin.cmake:
2894         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2895         (TestWebKitAPI::TEST):
2896
2897 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2898
2899         [GTK] Add basic tabs support to MiniBrowser
2900         https://bugs.webkit.org/show_bug.cgi?id=159803
2901
2902         Reviewed by Sergio Villar Senin.
2903
2904         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2905         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2906
2907         * MiniBrowser/gtk/BrowserTab.c: Added.
2908         (titleChanged):
2909         (isLoadingChanged):
2910         (decidePolicy):
2911         (removeChildIfInfoBar):
2912         (loadChanged):
2913         (createInfoBarQuestionMessage):
2914         (tlsErrorsDialogResponse):
2915         (loadFailedWithTLSerrors):
2916         (permissionRequestDialogResponse):
2917         (decidePermissionRequest):
2918         (colorChooserRGBAChanged):
2919         (popoverColorClosed):
2920         (colorChooserRequestFinished):
2921         (runColorChooserCallback):
2922         (inspectorOpenedInWindow):
2923         (inspectorClosed):
2924         (browserTabSetProperty):
2925         (browserTabFinalize):
2926         (browser_tab_init):
2927         (browserTabConstructed):
2928         (browser_tab_class_init):
2929         (getInternalURI):
2930         (browser_tab_new):
2931         (browser_tab_get_web_view):
2932         (browser_tab_load_uri):
2933         (browser_tab_get_title_widget):
2934         (browser_tab_set_status_text):
2935         (browser_tab_toggle_inspector):
2936         (browser_tab_start_search):
2937         (browser_tab_stop_search):
2938         (browser_tab_add_accelerators):
2939         (fullScreenMessageTimeoutCallback):
2940         (browser_tab_enter_fullscreen):
2941         (browser_tab_leave_fullscreen):
2942         * MiniBrowser/gtk/BrowserTab.h: Added.
2943         * MiniBrowser/gtk/BrowserWindow.c:
2944         (getExternalURI):
2945         (browserWindowSetStatusText):
2946         (reloadOrStopCallback):
2947         (goBackCallback):
2948         (goForwardCallback):
2949         (settingsCallback):
2950         (webViewURIChanged):
2951         (browserWindowHistoryItemActivated):
2952         (browserWindowUpdateNavigationActions):
2953         (webViewCreate):
2954         (webViewEnterFullScreen):
2955         (webViewLeaveFullScreen):
2956         (webViewDecidePolicy):
2957         (browserWindowCanZoomIn):
2958         (browserWindowCanZoomOut):
2959         (browserWindowZoomIn):
2960         (browserWindowZoomOut):
2961         (scrollEventCallback):
2962         (faviconChanged):
2963         (webViewIsLoadingChanged):
2964         (defaultZoomCallback):
2965         (searchCallback):
2966         (newTabCallback):
2967         (toggleWebInspector):
2968         (reloadPage):
2969         (reloadPageIgnoringCache):
2970         (stopPageLoad):
2971         (loadHomePage):
2972         (editingCommandCallback):
2973         (insertImageCommandCallback):
2974         (insertLinkCommandCallback):
2975         (browserWindowSetupEditorToolbar):
2976         (browserWindowSwitchTab):
2977         (browserWindowTabAddedOrRemoved):
2978         (browser_window_init):
2979         (browserWindowConstructed):
2980         (browserWindowSaveSession):
2981         (browserWindowDeleteEvent):
2982         (browser_window_new):
2983         (browser_window_append_view):
2984         (browser_window_load_uri):
2985         (browser_window_load_session):
2986         (browser_window_set_background_color):
2987         (resetStatusText): Deleted.
2988         (activateUriEntryCallback): Deleted.
2989         (webViewTitleChanged): Deleted.
2990         (resetEntryProgress): Deleted.
2991         (browserWindowCreateBackForwardMenu): Deleted.
2992         (webViewReadyToShow): Deleted.
2993         (webViewLoadFailed): Deleted.
2994         (webViewMouseTargetChanged): Deleted.
2995         (browserWindowUpdateZoomActions): Deleted.
2996         (webViewZoomLevelChanged): Deleted.
2997         (updateUriEntryIcon): Deleted.
2998         (zoomInCallback): Deleted.
2999         (zoomOutCallback): Deleted.
3000         (toggleFullScreen): Deleted.
3001         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
3002         (browserWindowFinalize): Deleted.
3003         (browser_window_class_init): Deleted.
3004         * MiniBrowser/gtk/BrowserWindow.h:
3005         * MiniBrowser/gtk/CMakeLists.txt:
3006         * MiniBrowser/gtk/main.c:
3007         (createBrowserTab):
3008         (aboutURISchemeRequestCallback):
3009         (main):
3010         (parseBackgroundColor): Deleted.
3011
3012 2016-07-14  Alex Christensen  <achristensen@webkit.org>
3013
3014         Allow RefPtrs of const RefCounted types
3015         https://bugs.webkit.org/show_bug.cgi?id=158269
3016
3017         Reviewed by Anders Carlsson.
3018
3019         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3020         (TestWebKitAPI::TEST):
3021         (TestWebKitAPI::ConstRefCounted::create):
3022         (TestWebKitAPI::returnConstRefCountedRef):
3023         (TestWebKitAPI::returnRefCountedRef):
3024
3025 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3026
3027         Test WTF.StringViewIterators is crashing since r203119
3028         https://bugs.webkit.org/show_bug.cgi?id=159710
3029
3030         Reviewed by Darin Adler.
3031
3032         There are two problems in the test case added in r203119. First is that it's testing
3033         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
3034         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
3035         const reference to the string view member of the deleted CodePoints object.
3036
3037         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3038         (TestWebKitAPI::TEST):
3039
3040 2016-07-13  Daniel Bates  <dabates@apple.com>
3041
3042         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
3043         https://bugs.webkit.org/show_bug.cgi?id=159738
3044         <rdar://problem/27304649>
3045
3046         Reviewed by Dan Bernstein.
3047
3048         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
3049         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
3050         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
3051         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
3052
3053         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3054         * WebKitTestRunner/ios/TestControllerIOS.mm:
3055         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
3056         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
3057
3058 2016-07-13  Beth Dakin  <bdakin@apple.com>
3059
3060         Attempted build fix.
3061
3062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3063
3064 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
3065
3066         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
3067         https://bugs.webkit.org/show_bug.cgi?id=159686
3068
3069         Reviewed by Chris Dumez.
3070
3071         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
3072
3073         * WebKitTestRunner/TestController.cpp:
3074         (WTR::runOpenPanel):
3075         (WTR::TestController::createOtherPage):
3076         (WTR::TestController::createWebViewWithOptions):
3077
3078 2016-07-13  Beth Dakin  <bdakin@apple.com>
3079
3080         Add more candidate tests
3081         https://bugs.webkit.org/show_bug.cgi?id=159730
3082
3083         Reviewed by Tim Horton.
3084
3085         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
3086         two new tests to that file.
3087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3088         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
3089         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
3090         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
3091         (TestWebKitAPI::TEST):
3092         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
3093
3094 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
3095
3096         AX: [ATK] spinbutton-crash.html fails
3097         https://bugs.webkit.org/show_bug.cgi?id=159723
3098
3099         Reviewed by Chris Fleizach.
3100
3101         Implement support for AXDecrementButton and AXIncrementButton in
3102         ATK's AccessibilityUIElement::uiElementAttributeValue().
3103
3104         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3105         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3106
3107 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3108
3109         [EFL] [GTK] Enable back crypto subtle on development builds.
3110         https://bugs.webkit.org/show_bug.cgi?id=159260
3111
3112         Reviewed by Carlos Garcia Campos.
3113
3114         * Scripts/webkitperl/FeatureList.pm:
3115
3116 2016-07-12  Mark Lam  <mark.lam@apple.com>
3117
3118         We should use different stack limits for stack checks from JS and host code.
3119         https://bugs.webkit.org/show_bug.cgi?id=159442
3120         <rdar://problem/26889188>
3121
3122         Reviewed by Geoffrey Garen.
3123
3124         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
3125         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
3126         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
3127         order to keep the js/regress-139548.html test happy with this patch.
3128
3129         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
3130         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
3131
3132         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3133         (-[LTRelayController _environmentVariables]):
3134         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3135         (main):
3136
3137 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
3138
3139         platformUserPreferredLanguages on Mac should not try to put the region into the language
3140         https://bugs.webkit.org/show_bug.cgi?id=159693
3141
3142         Rubber stamped by Alexey Proskuryakov.
3143         
3144         Revert the test change in r200105.
3145
3146         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
3147         (TestWebKitAPI::languageForSystemLanguage):
3148
3149 2016-07-12  Chris Dumez  <cdumez@apple.com>
3150
3151         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
3152         https://bugs.webkit.org/show_bug.cgi?id=159663
3153         <rdar://problem/18995873>
3154
3155         Reviewed by Benjamin Poulain.
3156
3157         Add API test coverage.
3158
3159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3160         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
3161         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
3162         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
3163         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
3164         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
3165         (TEST):
3166
3167 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
3168
3169         Relax ordering requirements on StringView::CodePoints iterator
3170         https://bugs.webkit.org/show_bug.cgi?id=159609
3171
3172         Reviewed by Darin Adler.
3173
3174         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3175         (TestWebKitAPI::TEST):
3176
3177 2016-07-12  Youenn Fablet  <youenn@apple.com>
3178
3179         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
3180         https://bugs.webkit.org/show_bug.cgi?id=159564
3181
3182         Reviewed by Brian Burg.
3183
3184         * Scripts/webkitpy/codegen/main.py:
3185         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
3186
3187 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3188
3189         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
3190         https://bugs.webkit.org/show_bug.cgi?id=159671
3191
3192         Reviewed by Csaba Osztrogonác.
3193
3194         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
3195         https://bugs.webkit.org/show_bug.cgi?id=89235
3196
3197         So this guard can be removed in build scripts.
3198
3199         * Scripts/webkitperl/FeatureList.pm:
3200         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3201
3202 2016-07-11  Jason Marcell  <jmarcell@apple.com>
3203
3204         SVN.create_patch should find svn-create-patch relative to the WebKit root.
3205         https://bugs.webkit.org/show_bug.cgi?id=159652
3206
3207         Reviewed by Daniel Bates.
3208
3209         * Scripts/webkitpy/common/checkout/scm/svn.py:
3210         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
3211
3212 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
3213
3214         Implement grapheme cluster iterator on StringView
3215         https://bugs.webkit.org/show_bug.cgi?id=159598
3216
3217         Reviewed by Anders Carlsson.
3218
3219         This is in preparation for honoring the second argument to FontFaceSet.load().
3220
3221         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3222         (TestWebKitAPI::compareLoopIterations):
3223         (TestWebKitAPI::TEST):
3224
3225 2016-07-11  Nan Wang  <n_wang@apple.com>
3226
3227         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
3228         https://bugs.webkit.org/show_bug.cgi?id=158364
3229
3230         Reviewed by Anders Carlsson.
3231
3232         Added a function in TestRunner so that we can toggle the ignoring viewport
3233         scale limits setting. Also added a test option for that in order to change the 
3234         configuration of the webview in test.
3235
3236         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3237         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3238         (WTR::TestRunner::setNavigationGesturesEnabled):
3239         (WTR::TestRunner::setIgnoresViewportScaleLimits):
3240         (WTR::nextUIScriptCallbackID):
3241         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3242         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3243         * WebKitTestRunner/TestController.cpp:
3244         (WTR::TestController::resetStateToConsistentValues):
3245         (WTR::updateTestOptionsFromTestHeader):
3246         (WTR::TestController::setNavigationGesturesEnabled):
3247         (WTR::TestController::setIgnoresViewportScaleLimits):
3248         (WTR::TestController::platformWillRunTest):
3249         * WebKitTestRunner/TestController.h:
3250         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3251         * WebKitTestRunner/TestInvocation.cpp:
3252         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3253         * WebKitTestRunner/TestOptions.h:
3254         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3255         (WTR::TestController::platformCreateWebView):
3256
3257 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
3258
3259         [GTK] install-dependencies should not install packages built by jhbuild.
3260         https://bugs.webkit.org/show_bug.cgi?id=159628
3261
3262         Reviewed by Michael Catanzaro.
3263
3264         * gtk/install-dependencies:
3265         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
3266
3267 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
3268
3269         System proxy settings not used when building deps with jhbuild
3270         https://bugs.webkit.org/show_bug.cgi?id=159567
3271
3272         Reviewed by Michael Catanzaro.
3273
3274         This adds the gsettings-desktop-schemas-devel build dep to enable
3275         the libgiognomeproxy.so gio module in glib-networking, which uses
3276         GSettings on org.gnome.system.proxy.
3277         This is needed to query system proxy settings for Gnome desktops.
3278
3279         dconf can be manually added to jhbuild to build the
3280         libdconfsettings.so gio module for GSettings, so that
3281         libgiognomeproxy.so can access system settings.
3282           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
3283
3284         As an alternative to dconf settings, this commit also adds the
3285         libproxy-devel build dep to enable the libgiolibproxy.so module in
3286         glib-networking (suggested by Fujii Hironori).
3287
3288         It is useful to read proxy settings from environment variables.
3289         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
3290         environment variable to force using the envvar module in libproxy.
3291
3292         * gtk/install-dependencies:
3293
3294 2016-07-11  Mark Lam  <mark.lam@apple.com>
3295
3296         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
3297         https://bugs.webkit.org/show_bug.cgi?id=159524
3298
3299         Reviewed by Michael Saboff.
3300
3301         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
3302         Also fixed up some tests to behave better to work with this new limit.  This
3303         should make stack overflow tests complete sooner.
3304
3305         * Scripts/run-jsc-stress-tests:
3306         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3307         (main):
3308
3309 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3310
3311         [GTK] Whitespace fixes in install-dependencies script
3312
3313         Unreviewed.
3314
3315         * gtk/install-dependencies:
3316
3317 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3318
3319         [GTK] Install missing Fedora dependencies
3320
3321         Unreviewed.
3322
3323         * gtk/install-dependencies:
3324
3325 2016-07-09  Dan Bernstein  <mitz@apple.com>
3326
3327         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
3328         https://bugs.webkit.org/show_bug.cgi?id=159600
3329
3330         Reviewed by Daniel Bates.
3331
3332         * Scripts/git-add-reviewer:
3333         Added the -s|--rubber-stamp option.
3334         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
3335           new option.
3336
3337 2016-07-08  Andy Estes  <aestes@apple.com>
3338
3339         [Content Filtering] Load blocked pages more like other error pages are loaded
3340         https://bugs.webkit.org/show_bug.cgi?id=159485
3341         <rdar://problem/26014076>
3342
3343         Reviewed by Brady Eidson.
3344
3345         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3346         to a content filtering provisional navigation failure is ignored in preference of
3347         ContentFilter's own error page.
3348
3349         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3351         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3352         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3353         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3354         (loadAlternateTest):
3355         (TEST):
3356         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3357         (-[MockContentFilterEnabler initWithCoder:]):
3358         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3359         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3360         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3361         (TestWebKitAPI::loadAlternateTest):
3362         (TestWebKitAPI::TEST):
3363
3364 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3365
3366         Unreviewed, rolling out r202944.
3367         https://bugs.webkit.org/show_bug.cgi?id=159570
3368
3369         caused some tests to crash under GuardMalloc (Requested by
3370         estes on #webkit).
3371
3372         Reverted changeset:
3373
3374         "[Content Filtering] Load blocked pages more like other error
3375         pages are loaded"
3376         https://bugs.webkit.org/show_bug.cgi?id=159485
3377         http://trac.webkit.org/changeset/202944
3378
3379 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
3380
3381         Remove mrobinson from the MathML watchlist
3382         https://bugs.webkit.org/show_bug.cgi?id=159559
3383
3384         Reviewed by Philippe Normand.
3385
3386         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
3387
3388 2016-07-08  Brady Eidson  <beidson@apple.com>
3389
3390         Clearing LocalStorage doesn't also delete -wal and -shm files.
3391         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
3392
3393         Reviewed by Brent Fulgham.
3394         Also helpfully picked over by Andy "Never Forgets" Estes.
3395
3396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3397         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
3398         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
3399
3400 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
3401
3402         Removed Qt leftovers from Tools.
3403         https://bugs.webkit.org/show_bug.cgi?id=159557
3404
3405         Reviewed by Csaba Osztrogonác.
3406
3407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3408         Removed 'qt' platform config.
3409         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3410         Deleted non-functional e-mail address.
3411
3412 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3413
3414         Unreviewed, rolling out r202967.
3415         https://bugs.webkit.org/show_bug.cgi?id=159556
3416
3417         This patch caused crashes in https tests on Windows (Requested
3418         by perarne on #webkit).
3419
3420         Reverted changeset:
3421
3422         "[Win] The test http/tests/security/contentSecurityPolicy
3423         /upgrade-insecure-requests/basic-upgrade.https.html is
3424         failing."
3425         https://bugs.webkit.org/show_bug.cgi?id=159510
3426         http://trac.webkit.org/changeset/202967
3427
3428 2016-07-08  Youenn Fablet  <youenn@apple.com>
3429
3430         Generate WebCore builtin wrapper files
3431         https://bugs.webkit.org/show_bug.cgi?id=159461
3432
3433         Reviewed by Brian Burg.
3434
3435         * Scripts/webkitpy/codegen/main.py:
3436         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
3437         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
3438
3439 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
3440
3441         [EFL] Fix build when media-stream is enabled.
3442         https://bugs.webkit.org/show_bug.cgi?id=159206
3443
3444         Bump up the openwebrtc to find the correct package.
3445
3446         Reviewed by Gyuyoung Kim.
3447
3448         * efl/jhbuild.modules:
3449         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
3450
3451 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3452
3453         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
3454         https://bugs.webkit.org/show_bug.cgi?id=159510
3455
3456         Reviewed by Brent Fulgham.
3457
3458         Allow any https certificate when running tests.
3459
3460         * DumpRenderTree/win/DumpRenderTree.cpp:
3461         (runTest):
3462
3463 2016-07-07  Beth Dakin  <bdakin@apple.com>
3464
3465         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3466         https://bugs.webkit.org/show_bug.cgi?id=159532
3467         -and corresponding-
3468         rdar://problem/27177179
3469
3470         Reviewed by Tim Horton.
3471
3472         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
3473         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
3474
3475 2016-07-07  Andy Estes  <aestes@apple.com>
3476
3477         [Content Filtering] Load blocked pages more like other error pages are loaded
3478         https://bugs.webkit.org/show_bug.cgi?id=159485
3479         <rdar://problem/26014076>
3480
3481         Reviewed by Brady Eidson.
3482
3483         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3484         to a content filtering provisional navigation failure is ignored in preference of
3485         ContentFilter's own error page.
3486
3487         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3489         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3490         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3491         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3492         (loadAlternateTest):
3493         (TEST):
3494         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3495         (-[MockContentFilterEnabler initWithCoder:]):
3496         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3497         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3498         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3499         (TestWebKitAPI::loadAlternateTest):
3500         (TestWebKitAPI::TEST):
3501
3502 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3503
3504         Unreviewed: add myself to the reviewers list.
3505
3506         * Scripts/webkitpy/common/config/contributors.json:
3507
3508 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3509
3510         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3511         https://bugs.webkit.org/show_bug.cgi?id=159509
3512
3513         Reviewed by Alex Christensen.
3514
3515         We should always insert the url in the url map when identifierForInitialRequest
3516         is called. Otherwise we can end up with identifiers not having an entry in the
3517         url map when urls are written to the test output file. 
3518
3519         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3520         (ResourceLoadDelegate::identifierForInitialRequest):
3521
3522 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3523
3524         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3525         https://bugs.webkit.org/show_bug.cgi?id=159498
3526         <rdar://problem/26719903>
3527
3528         Reviewed by Sam Weinig.
3529
3530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3531         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3532         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3533         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3534         (expectLinkCount):
3535         (TEST):
3536         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3537         when deciding what to linkify.
3538
3539 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3540
3541         Build fix - work around rdar://problem/27196668.
3542
3543         * LayoutTestRelay/Configurations/Base.xcconfig:
3544
3545 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3546
3547         Enhance Windows DRT implementation to support platform scroll wheel events.
3548         https://bugs.webkit.org/show_bug.cgi?id=36002
3549
3550         Reviewed by Brent Fulgham.
3551
3552         Implement function continuousMouseScrollBy in Windows event sender.
3553
3554         * DumpRenderTree/win/EventSender.cpp:
3555         (mouseScrollBy):
3556         (continuousMouseScrollBy):
3557
3558 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3559
3560         [Sierra] Rebaseline tests to use un-mocked system font metrics
3561         https://bugs.webkit.org/show_bug.cgi?id=159311
3562         <rdar://problem/24138411>
3563
3564         Reviewed in person by Alexey Proskuryakov.
3565
3566         Stop mocking the system font on Sierra.
3567
3568         * DumpRenderTree/mac/DumpRenderTree.mm:
3569         (setDefaultsToConsistentValuesForTesting):
3570         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3571         (WTR::InjectedBundle::platformInitialize):
3572
3573 2016-07-05  Brady Eidson  <beidson@apple.com>
3574
3575         Database process crashes deleting a corrupt SQLite database file (null deref).
3576         https://bugs.webkit.org/show_bug.cgi?id=155506.
3577
3578         Reviewed by Alex Christensen.
3579
3580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3581         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3582         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3583         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3584         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3585         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3586
3587 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3588
3589         run-webkit-tests should print more complete baseline search paths
3590         https://bugs.webkit.org/show_bug.cgi?id=159354
3591
3592         Reviewed by Daniel Bates.
3593
3594         run-webkit-tests used to only print directory names in baseline search paths.
3595         This was ok in basic usage, but quickly got confusing when using
3596         --additional-platform-directory flags.
3597
3598         * Scripts/webkitpy/layout_tests/views/printing.py:
3599         (Printer.print_config):
3600         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3601         (Testprinter.test_print_config):
3602         (Testprinter.test_print_one_line_summary):
3603
3604 2016-07-04  Brady Eidson  <beidson@apple.com>
3605
3606         WebProcesses don't handle DatabaseProcess going away uncleanly..
3607         https://bugs.webkit.org/show_bug.cgi?id=159371
3608
3609         Reviewed by Alex Christensen.
3610
3611         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3612         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3613         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3614         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3615         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3616
3617 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3618
3619         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3620         https://bugs.webkit.org/show_bug.cgi?id=158141
3621
3622         Rubber-stamped by Michael Catanzaro.
3623
3624         Instead of checking for an specific Ubuntu version, query the apt
3625         database to see which version of PHP is available.
3626
3627         * efl/install-dependencies:
3628         * gtk/install-dependencies:
3629
3630 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3631
3632         webkit-patch failure-reason always raises TypeError
3633         https://bugs.webkit.org/show_bug.cgi?id=159394
3634
3635         Reviewed by Benjamin Poulain.
3636
3637         In r170637 (Bug 133067), the first and second arguments of
3638         pluralize were swapped.
3639
3640         * Scripts/webkitpy/tool/commands/queries.py:
3641         (FailureReason._builder_to_explain): Swap the first and second
3642         arguments of pluralize.
3643
3644 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3645
3646         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3647         https://bugs.webkit.org/show_bug.cgi?id=152486
3648
3649         Reviewed by Daniel Bates.
3650
3651         Add launch of web-platform-tests server by run-webkit-httpd.
3652         Add two options to disable starting httpd and web-platform-tests servers.
3653
3654         * Scripts/run-webkit-httpd:
3655         (parse_args):
3656         (main):
3657
3658 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3659
3660         REGRESSION(r189668): Notification tests are flakey
3661         https://bugs.webkit.org/show_bug.cgi?id=159375
3662         <rdar://problem/22760990>
3663
3664         Reviewed by Alexey Proskuryakov.
3665
3666         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3667         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3668         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3669         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3670
3671         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3672         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3673         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3674         global notification ID mapping, causing the wrong notification to be investigated.
3675
3676         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3677         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3678         notification is created or destroyed. However, because this object is implemented outside WebKit,
3679         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3680         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3681         WebNotificationProvider can properly map between the different IDs.
3682
3683         * WebKitTestRunner/TestController.cpp:
3684         (WTR::TestController::runTestingServerLoop):
3685         (WTR::TestController::simulateWebNotificationClick):
3686         * WebKitTestRunner/WebNotificationProvider.cpp:
3687         (WTR::WebNotificationProvider::showWebNotification):
3688         (WTR::removeGlobalIDFromIDMap):
3689         (WTR::WebNotificationProvider::closeWebNotification):
3690         (WTR::WebNotificationProvider::removeNotificationManager):
3691         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3692         (WTR::WebNotificationProvider::reset):
3693         * WebKitTestRunner/WebNotificationProvider.h:
3694
3695 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3696
3697         Simplify LayoutTestRelay
3698         https://bugs.webkit.org/show_bug.cgi?id=159353
3699
3700         Reviewed by Daniel Bates.
3701
3702         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3703         by name and runtime makes no sense.
3704         2. Removed code to create devices, webkitpy always does this in advance.
3705         3. Don't create copies of testing apps - we can install the same one into
3706         each simulator, now that we don't run multiple tester processes in a single simulator.
3707         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3708         5. Removed code that kept testing apps alive in the background.
3709         6. Slightly updated coding style in functions that I touched.
3710
3711         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3712         Updated for what we acually use at this point.
3713
3714         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3715         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3716         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3717         (-[LTRelayController ipcIdentifier]):
3718         (-[LTRelayController processName]):
3719         (-[LTRelayController didReceiveStdoutData:]):
3720         (-[LTRelayController didCrashWithMessage:]):
3721         (-[LTRelayController installApp]):
3722         (-[LTRelayController _environmentVariables]):
3723         (-[LTRelayController launchApp]):
3724         (-[LTRelayController start]):
3725         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3726         (-[LTRelayController uniqueAppPath]): Deleted.
3727         (-[LTRelayController uniqueAppURL]): Deleted.
3728         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3729         (-[LTRelayController createUniqueApp]): Deleted.
3730         * LayoutTestRelay/LayoutTestRelay/main.m:
3731         (usage):
3732         (getRequiredStringArgument):
3733         (main):
3734         (getTestingSimDevice): Deleted.
3735         * Scripts/webkitpy/port/driver.py:
3736         (IOSSimulatorDriver.cmd_line):
3737         * WebKitTestRunner/ios/TestControllerIOS.mm:
3738         (WTR::TestController::platformInitialize):
3739         * WebKitTestRunner/ios/mainIOS.mm:
3740         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3741         * DumpRenderTree/mac/DumpRenderTree.mm:
3742         (dumpRenderTree):
3743         (-[DumpRenderTree applicationDidEnterBackground:]):
3744
3745 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3746
3747         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3748         https://bugs.webkit.org/show_bug.cgi?id=159344
3749
3750         Reviewed by Alex Christensen.
3751
3752         * DumpRenderTree/CMakeLists.txt:
3753
3754 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3755
3756         Add a runtime flag for DOM iterators
3757         https://bugs.webkit.org/show_bug.cgi?id=159300
3758
3759         Reviewed by Alex Christensen.
3760
3761         * DumpRenderTree/mac/DumpRenderTree.mm:
3762         (resetWebPreferencesToConsistentValues):
3763         * DumpRenderTree/win/DumpRenderTree.cpp:
3764         (resetWebPreferencesToConsistentValues):
3765         * Scripts/webkitperl/FeatureList.pm:
3766         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3767         (WTR::InjectedBundle::beginTesting):
3768         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3769         (WTR::TestRunner::setDOMIteratorEnabled):
3770         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3771
3772 2016-06-30  Tina Liu  <iting_liu@apple.com>
3773
3774         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3775         https://bugs.webkit.org/show_bug.cgi?id=159326
3776
3777         Reviewed by Brady Eidson.
3778
3779         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3780         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3781         (TestWebKitAPI::didFinishLoadForFrame):
3782         (TestWebKitAPI::didChangeBackForwardListForPage):
3783         (TestWebKitAPI::setPageLoaderClient):
3784         Set the page loader client and register for didFinishLoadForFrame and
3785         didChangeBackForwardList callbacks.
3786         (TestWebKitAPI::createSessionStateData):
3787         Load a webpage ("simple.html") and return the session state for this page.
3788         (TestWebKitAPI::TEST):
3789         Restore the page session state with that of "simple.html" without navigation.
3790         Verify that the committed URL is NULL since there's no navigation involved.
3791         Verify that the current item in the back forward list, which should be what
3792         we restored from the session state, has the expected URL.
3793
3794 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3795
3796         Generators violate bytecode liveness validation
3797         https://bugs.webkit.org/show_bug.cgi?id=159279
3798
3799         Reviewed by Yusuke Suzuki.
3800         
3801         Add Basic to our test harness.
3802
3803         * Scripts/run-javascriptcore-tests:
3804         (runJSCStressTests):
3805
3806 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3807
3808         [Win][Debug] Assertion fails in TestWTF.
3809         https://bugs.webkit.org/show_bug.cgi?id=159299
3810
3811         Reviewed by Alex Christensen.
3812
3813         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3814         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3815         the assertion failure. Since the variable is actually used, there is no need to use the
3816         UNUSED_PARAM macro.
3817
3818         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3819         (TestWebKitAPI::TEST):
3820
3821 2016-06-30  Youenn Fablet  <youennf@gmail.com>
3822
3823         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3824         https://bugs.webkit.org/show_bug.cgi?id=159166
3825         <rdar://problem/27051759>
3826
3827         Reviewed by Alexey Proskuryakov.
3828
3829         Setting the certificate directory to the copied config.json.
3830
3831         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3832         (WebPlatformTestServer._copy_webkit_test_files):
3833
3834 2016-06-29  Mark Lam  <mark.lam@apple.com>
3835
3836         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3837         https://bugs.webkit.org/show_bug.cgi?id=159274
3838
3839         Reviewed by Keith Miller.
3840
3841         * DumpRenderTree/mac/DumpRenderTree.mm:
3842         (DumpRenderTreeMain):
3843
3844 2016-06-29  Alex Christensen  <achristensen@webkit.org>
3845
3846         WKWebView should ask WKNavigationDelegate about bad ssl certificates
3847         https://bugs.webkit.org/show_bug.cgi?id=159176
3848
3849         Reviewed by Sam Weinig.
3850
3851         * MiniBrowser/mac/WK2BrowserWindowController.m:
3852         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3853         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3854         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3855
3856 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3857
3858         [GTK] Add missing install dependency after r202619
3859         https://bugs.webkit.org/show_bug.cgi?id=156716
3860
3861         Unreviewed.
3862
3863         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3864
3865 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3866
3867         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3868         https://bugs.webkit.org/show_bug.cgi?id=156716
3869
3870         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3871
3872         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3873         (parse_args):
3874         * Scripts/webkitpy/port/gtk.py:
3875         (GtkPort.__init__):
3876         (GtkPort._driver_class):
3877         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3878         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3879         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3880         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3881         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3882         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3883         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3884         (WestonDriver.check_driver):
3885         (WestonDriver.__init__):
3886         (WestonDriver._start):
3887         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3888         (WestonXvfbDriverDisplayTest):
3889         (WestonXvfbDriverDisplayTest.__init__):
3890         (WestonXvfbDriverDisplayTest._xvfb_run):
3891         (WestonDriverTest.make_driver):
3892         (WestonDriverTest.test_start):
3893         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3894         or to satisfy the pkg-config check of the new added modules in JHBuild.
3895         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3896         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3897         provided by the system are already new enough.
3898         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3899         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3900         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3901         feature to avoid building libdrm when the one provided by the system is new enough.
3902         * gtk/jhbuildrc:
3903         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3904         Xorg had no support for searching the DRI drivers on a custom path at runtime.
3905         This patch implements support for that reusing the same variable that we use with Mesa to set the
3906         custom path for the DRI drivers path.
3907
3908 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
3909
3910         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3911         https://bugs.webkit.org/show_bug.cgi?id=159256
3912
3913         Reviewed by Philippe Normand.
3914
3915         We need the last fixes in the repository to make the scream queue
3916         work with apprtc.
3917
3918         * gtk/jhbuild.modules:
3919
3920 2016-06-28  Commit Queue  <commit-queue@webkit.org>
3921
3922         Unreviewed, rolling out r202580.
3923         https://bugs.webkit.org/show_bug.cgi?id=159245
3924
3925         Caused all WKTR tests to fail on GuardMalloc and Production
3926         only for unknown reasons, investigating offline. (Requested by
3927         brrian on #webkit).
3928
3929         Reverted changeset:
3930
3931         "RunLoop::Timer should use constructor templates instead of
3932         class templates"
3933         https://bugs.webkit.org/show_bug.cgi?id=159153
3934         http://trac.webkit.org/changeset/202580
3935
3936 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3937
3938         Use a regex to check if a test step is for JavaScriptCore
3939         https://bugs.webkit.org/show_bug.cgi?id=159224
3940
3941         Reviewed by Geoffrey Garen.
3942
3943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3944         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3946         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3948         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3949
3950 2016-06-28  Michael Saboff  <msaboff@apple.com>
3951
3952         btjs no longer accepts optional frame count argument
3953         https://bugs.webkit.org/show_bug.cgi?id=159235
3954
3955         Reviewed by Saam Barati.
3956
3957         Fix the detection of optional backtrace-depth parameter to use the length
3958         of the command.
3959
3960         * lldb/lldb_webkit.py:
3961         (btjs):
3962
3963 2016-06-28  Jon Lee  <jonlee@apple.com>
3964
3965         Update animometer.plan
3966
3967         Rubber-stamped by Said Abou-Hallawa.
3968
3969         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3970
3971 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
3972
3973         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3974
3975         * Scripts/run-javascriptcore-tests:
3976         (runJSCStressTests):
3977
3978 2016-06-28  Brian Burg  <bburg@apple.com>
3979
3980         RunLoop::Timer should use constructor templates instead of class templates
3981         https://bugs.webkit.org/show_bug.cgi?id=159153
3982
3983         Reviewed by Alex Christensen.
3984
3985         Remove the RunLoop::Timer class template argument, and pass its constructor
3986         a reference to `this` instead of a pointer to `this`.
3987
3988         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3989         (WTR::TestRunner::TestRunner):
3990         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3991         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3992         (TestWebKitAPI::TEST):
3993
3994 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3995
3996         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3997         https://bugs.webkit.org/show_bug.cgi?id=159199
3998
3999         Reviewed by Alexey Proskuryakov.
4000
4001         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
4002
4003         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
4004         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
4005         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
4006         an input element getting automatically focused on Mac.
4007
4008 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
4009
4010         [Win] Custom elements tests are failing.
4011         https://bugs.webkit.org/show_bug.cgi?id=159139
4012
4013         Reviewed by Alex Christensen.
4014
4015         Enable custom element API when running tests.
4016
4017         * DumpRenderTree/win/DumpRenderTree.cpp:
4018         (resetWebPreferencesToConsistentValues):
4019
4020 2016-06-27  Lucas Forschler  <lforschler@apple.com>
4021
4022         Test commit. Please ignore.
4023         
4024 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
4025
4026         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
4027         https://bugs.webkit.org/show_bug.cgi?id=155073
4028
4029         Reviewed by Daniel Bates.
4030
4031         * Scripts/webkitperl/FeatureList.pm:
4032
4033 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
4034
4035         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
4036         https://bugs.webkit.org/show_bug.cgi?id=159077
4037
4038         Reviewed by Tim Horton.
4039
4040         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
4041
4042         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
4043         which is necessary for UI-side compositing.
4044
4045         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
4046         seems to happen for some tests that call window.resizeTo().
4047
4048         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4049         (WTR::InjectedBundlePage::dump): Deleted.
4050         * WebKitTestRunner/TestInvocation.cpp:
4051         (WTR::TestInvocation::dumpResults):
4052         * WebKitTestRunner/cg/TestInvocationCG.cpp:
4053         (WTR::createCGContextFromImage):
4054         (WTR::computeMD5HashStringForContext):
4055         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
4056         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4057         (WTR::PlatformWebView::windowSnapshotImage):
4058
4059 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4060
4061         [EFL] Support to build on Debian linux
4062         https://bugs.webkit.org/show_bug.cgi?id=159123
4063
4064         Reviewed by Antonio Gomes.
4065
4066         * efl/install-dependencies: Install libgnutls28-dev.
4067
4068 2016-06-27  Alex Christensen  <achristensen@webkit.org>
4069
4070         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
4071         https://bugs.webkit.org/show_bug.cgi?id=159071
4072
4073         Reviewed by Brady Eidson.
4074
4075         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4076         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4077         (WTR::TestRunner::setHandlesAuthenticationChallenges):
4078         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
4079         (WTR::TestRunner::setAuthenticationUsername):
4080         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4081         * WebKitTestRunner/TestController.cpp:
4082         (WTR::TestController::TestController):
4083         (WTR::TestController::resetStateToConsistentValues):
4084         (WTR::TestController::didFinishNavigation):
4085         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
4086         (WTR::TestController::didReceiveAuthenticationChallenge):
4087         (WTR::TestController::didCommitNavigation):
4088         * WebKitTestRunner/TestController.h:
4089         (WTR::TestController::setBlockAllPlugins):
4090         (WTR::TestController::setShouldLogHistoryClientCallbacks):
4091         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
4092         (WTR::TestController::isCurrentInvocation):
4093         * WebKitTestRunner/TestInvocation.cpp:
4094         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4095         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
4096
4097 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
4098
4099         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
4100         https://bugs.webkit.org/show_bug.cgi?id=159129
4101
4102         Reviewed by Alex Christensen.
4103
4104         Implement the function mouseScrollBy in the Windows event sender.
4105
4106         * DumpRenderTree/win/EventSender.cpp:
4107         (mouseScrollBy):
4108         (mouseScrollByWithWheelAndMomentumPhasesCallback):
4109
4110 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
4111
4112         REGRESSION: Weak symbol warning when linking TestWebKitAPI
4113         https://bugs.webkit.org/show_bug.cgi?id=159104
4114
4115         Reviewed by Dan Bernstein.
4116         
4117         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
4118         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
4119
4120         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
4121         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
4122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
4123
4124 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
4125
4126         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
4127         https://bugs.webkit.org/show_bug.cgi?id=159086
4128
4129         Reviewed by Alex Christensen.
4130
4131         Implement required wheel event function in event sender.
4132  
4133         * DumpRenderTree/win/EventSender.cpp:
4134         (mouseScrollByWithWheelAndMomentumPhasesCallback):
4135
4136 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
4137
4138         REGRESSION: Weak symbol warning when linking TestWebKitAPI
4139         https://bugs.webkit.org/show_bug.cgi?id=159104
4140
4141         Reviewed by Mark Lam.
4142         
4143         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
4144         WK.
4145
4146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4147
4148 2016-06-24  David Kilzer  <ddkilzer@apple.com>
4149
4150         parser_unittests.pl should not hardcode list of tests
4151         <https://webkit.org/b/159074>
4152
4153         Reviewed by Daniel Bates.
4154
4155         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
4156         Update to read the list of tests from the 'resources' directory,
4157         and instead map file extensions to subroutine names.  Switch to
4158         use File::Basename::fileparse() to get basename and file
4159         extension for each test.
4160         (readTestFiles): Added.  Reads files from the directory passed
4161         in and ignores: hidden files, anything that isn't a plain file,
4162         and expected test results files.
4163
4164 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
4165
4166         Fix Windows build.
4167
4168         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
4169         * DumpRenderTree/cg/PixelDumpSupportCG.h:
4170
4171 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4172
4173         [EFL] Change download path of libxslt
4174
4175         Unreviewed EFL build fix.
4176
4177         In Korea current download path can't be accessed. Change it.
4178
4179         * efl/jhbuild.modules:
4180
4181 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
4182
4183         https://bugs.webkit.org/show_bug.cgi?id=159077
4184
4185         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
4186         snapshot the final state of the test in release builds. 
4187
4188         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4189         (WTR::InjectedBundlePage::dump):
4190
4191 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
4192
4193         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
4194
4195         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
4196         (createBitmapContextFromWebView):
4197         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4198         (WTR::PlatformWebView::windowSnapshotImage):
4199
4200 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
4201
4202         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
4203         https://bugs.webkit.org/show_bug.cgi?id=159077
4204
4205         Reviewed by Tim Horton.
4206
4207         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
4208         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
4209         thus enabling testing of more things.
4210
4211         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
4212         (createBitmapContext): Moved to this file to share it.
4213         * DumpRenderTree/cg/PixelDumpSupportCG.h:
4214         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
4215         (createBitmapContextFromWebView):
4216         (BitmapContext::createFromUIImage): Deleted.
4217         (BitmapContext::pixelData): Deleted.
4218         (BitmapContext::BitmapContext): Deleted.
4219         (computeMD5HashStringForBitmapContext): Deleted.
4220         (dumpBitmap): Deleted.
4221         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
4222         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4223         (createPagedBitmapContext):
4224         (createBitmapContext): Deleted.
4225         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
4226         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4227         (WTR::InjectedBundlePage::dump): Deleted.
4228         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4229         (WTR::PlatformWebView::windowSnapshotImage):
4230
4231 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
4232
4233         [jhbuild] Added libxslt module.
4234         https://bugs.webkit.org/show_bug.cgi?id=159034
4235
4236         Unreviewed, followup for r202373.
4237
4238         * efl/install-dependencies: Removed libxslt 
4239         * gtk/install-dependencies: Ditto.
4240
4241 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4242
4243         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
4244         https://bugs.webkit.org/show_bug.cgi?id=159050
4245
4246         Reviewed by Antonio Gomes.
4247
4248         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
4249
4250         * efl/jhbuild.modules:
4251         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
4252         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
4253
4254 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
4255
4256         [jhbuild] Added libxslt module.
4257         https://bugs.webkit.org/show_bug.cgi?id=159034
4258
4259         Reviewed by Michael Catanzaro.
4260
4261         * efl/jhbuild.modules:
4262         * gtk/jhbuild.modules:
4263
4264 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4265
4266         [Win] Use Windows api function to find top level parent.
4267         https://bugs.webkit.org/show_bug.cgi?id=159021
4268
4269         Reviewed by Brent Fulgham.
4270
4271         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
4272  
4273         * DumpRenderTree/win/UIDelegate.cpp:
4274         (UIDelegate::runModal):
4275         (findTopLevelParent): Deleted.
4276         * MiniBrowser/win/PrintWebUIDelegate.cpp:
4277         (PrintWebUIDelegate::runModal):
4278         (findTopLevelParent): Deleted.
4279
4280 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4281
4282         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
4283         https://bugs.webkit.org/show_bug.cgi?id=158934
4284
4285         Reviewed by Brent Fulgham.
4286
4287         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
4288
4289         * DumpRenderTree/win/TestRunnerWin.cpp:
4290         (TestRunner::clearAllDatabases):
4291
4292 2016-06-22  Saam Barati  <sbarati@apple.com>
4293
4294         run-javascriptcore-tests should have some environment variables for commonly used settings
4295         https://bugs.webkit.org/show_bug.cgi?id=159047
4296
4297         Reviewed by Keith Miller.
4298
4299         This patch adds three environment v