WKR does not include my nick when commit-queue lands my patch
[WebKit-https.git] / Tools / ChangeLog
1 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2
3         WKR does not include my nick when commit-queue lands my patch
4         https://bugs.webkit.org/show_bug.cgi?id=167388
5
6         Reviewed by Ryosuke Niwa.
7
8         * Scripts/webkitpy/tool/commands/newcommitbot.py:
9         (NewCommitBot._summarize_commit_log):
10         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
11         Perform nickname insertion before grabbing "Patch by" details.
12         This way we can include the nickname with the full name.
13
14 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
15
16         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
17         https://bugs.webkit.org/show_bug.cgi?id=167394
18
19         Reviewed by Ryosuke Niwa.
20
21         * Scripts/webkitperl/FeatureList.pm:
22         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
23
24 2017-01-24  Youenn Fablet  <youenn@apple.com>
25
26         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
27         https://bugs.webkit.org/show_bug.cgi?id=167353
28
29         Reviewed by Alex Christensen.
30
31         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
32         (CMakeGenerator.initialize_targets):
33
34 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
35
36         WKR should not confuse Miguel Gomez with Andres Gomez
37         https://bugs.webkit.org/show_bug.cgi?id=167389
38
39         Reviewed by Lucas Forschler.
40
41         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
42         "mAndres Gomez". Fix this.
43
44         * Scripts/webkitpy/tool/commands/newcommitbot.py:
45         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
46         space on each side of the email address, so expect both spaces to be there before
47         considering the email for replacement.
48         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
49
50 2017-01-24  Matt Rajca  <mrajca@apple.com>
51
52         Pass down website autoplay policies to media elements
53         https://bugs.webkit.org/show_bug.cgi?id=167355
54
55         Reviewed by Alex Christensen.
56
57         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
58         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
59         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
60         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
61         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
62         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
63         (TEST):
64
65 2017-01-24  Nan Wang  <n_wang@apple.com>
66
67         AX: Speak Selection does not work in an iframe
68         https://bugs.webkit.org/show_bug.cgi?id=166794
69         <rdar://problem/29913013>
70
71         Reviewed by Chris Fleizach.
72
73         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
74         (WTR::UIScriptController::retrieveSpeakSelectionContent):
75         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
76         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
77         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
78         (WTR::UIScriptController::retrieveSpeakSelectionContent):
79         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
80         * TestRunnerShared/UIScriptContext/UIScriptController.h:
81         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
82         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
83         (-[TestRunnerWKWebView dealloc]):
84         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
85         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
86         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
87         (WTR::UIScriptController::retrieveSpeakSelectionContent):
88         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
89
90 2017-01-24  Daniel Bates  <dabates@apple.com>
91
92         StringView.split() should use an iterator design pattern instead of allocating a Vector
93         https://bugs.webkit.org/show_bug.cgi?id=163225
94
95         Reviewed by Darin Adler.
96
97         Add unit tests for StringView.split().
98
99         * TestWebKitAPI/Tests/WTF/StringView.cpp:
100         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
101         used in the StringView.split() unit tests.
102         (TestWebKitAPI::stringViewFromUTF8): Ditto.
103         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
104         object to a Vector of String objects.
105         (TestWebKitAPI::TEST): Added the following tests:
106             - WTF.StringViewSplitEmptyAndNullStrings
107             - WTF.StringViewSplitBasic
108             - WTF.StringViewSplitWithConsecutiveSeparators
109
110 2017-01-23  Anders Carlsson  <andersca@apple.com>
111
112         The Score Esports crashes on launch
113         https://bugs.webkit.org/show_bug.cgi?id=167338
114         rdar://problem/29948645
115
116         Reviewed by Dan Bernstein.
117
118         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
119         (TestWebKitAPI::TEST):
120         Add a test.
121
122 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
123
124         [GTK] Add API to WebKitWebsiteDataManager to handle website data
125         https://bugs.webkit.org/show_bug.cgi?id=146589
126
127         Reviewed by Michael Catanzaro.
128
129         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
130         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
131
132         * MiniBrowser/gtk/BrowserWindow.c:
133         (webViewDecidePolicy):
134         (newTabCallback):
135         * MiniBrowser/gtk/main.c:
136         (createBrowserTab):
137         (aboutDataRequestFree):
138         (aboutDataRequestNew):
139         (aboutDataRequestForView):
140         (websiteDataRemovedCallback):
141         (websiteDataClearedCallback):
142         (aboutDataScriptMessageReceivedCallback):
143         (domainListFree):
144         (aboutDataFillTable):
145         (gotWebsiteDataCallback):
146         (aboutDataHandleRequest):
147         (aboutURISchemeRequestCallback):
148         (main):
149         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
150         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
151         (serverCallback):
152         (beforeAll):
153         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
154         (serverCallback):
155         (WebsiteDataTest::WebsiteDataTest):
156         (WebsiteDataTest::~WebsiteDataTest):
157         (WebsiteDataTest::fetch):
158         (WebsiteDataTest::remove):
159         (WebsiteDataTest::clear):
160         (testWebsiteDataConfiguration):
161         (testWebsiteDataCache):
162         (testWebsiteDataStorage):
163         (testWebsiteDataDatabases):
164         (testWebsiteDataAppcache):
165         (beforeAll):
166         (afterAll):
167
168 2017-01-23  Commit Queue  <commit-queue@webkit.org>
169
170         Unreviewed, rolling out r211062.
171         https://bugs.webkit.org/show_bug.cgi?id=167354
172
173         broke API tests (Requested by alexchristensen on #webkit).
174
175         Reverted changeset:
176
177         "Pass down website autoplay policies to media elements"
178         https://bugs.webkit.org/show_bug.cgi?id=167132
179         http://trac.webkit.org/changeset/211062
180
181 2017-01-23  Alex Christensen  <achristensen@webkit.org>
182
183         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
184         https://bugs.webkit.org/show_bug.cgi?id=167330
185
186         Reviewed by Tim Horton.
187
188         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
189         (TestWebKitAPI::TEST_F):
190
191 2017-01-23  Alex Christensen  <achristensen@webkit.org>
192
193         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
194         https://bugs.webkit.org/show_bug.cgi?id=167317
195
196         Reviewed by Sam Weinig.
197
198         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
199         (TestWebKitAPI::TEST_F):
200
201 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
202
203         svn-create-patch should emit properties when files are moved or copied
204         https://bugs.webkit.org/show_bug.cgi?id=167264
205
206         Reviewed by Daniel Bates.
207
208         * Scripts/svn-create-patch:
209         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
210
211 2017-01-23  Youenn Fablet  <youenn@apple.com>
212
213         [WebRTC] Filter libwebrtc link flags
214         https://bugs.webkit.org/show_bug.cgi?id=167287
215
216         Reviewed by Alex Christensen.
217
218         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
219         (CMakeGenerator._compute_link_flags):
220         (CMakeGenerator._compute_link_flags.keep_flag):
221         (CMakeGenerator._generate_compile_target_options):
222
223 2017-01-23  Youenn Fablet  <youennf@gmail.com>
224
225         [WebRTC] Make VP8 optional in libwebrtc
226         https://bugs.webkit.org/show_bug.cgi?id=167257
227
228         Reviewed by Darin Adler.
229
230         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
231         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
232
233 2017-01-23  Jer Noble  <jer.noble@apple.com>
234
235         Video details does not apear and missing scrubber in Control Center
236         https://bugs.webkit.org/show_bug.cgi?id=167233
237
238         Reviewed by Alex Christensen.
239
240         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
241         NowPlayingControlTests for iOS.
242
243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
244         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
245         (-[NowPlayingTestWebView setWindowVisible:]):
246         (TestWebKitAPI::TEST):
247         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
248         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
249         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
250         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
251         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
252         (SOFT_LINK_CLASS):
253         (-[TestMessageHandler addMessage:withHandler:]):
254         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
255         (__simulated_forceClickAssociatedEventsMask):
256         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
257         (-[TestWKWebViewHostWindow isKeyWindow]):
258         (-[TestWKWebViewHostWindow makeKeyWindow]):
259         (-[TestWKWebViewHostWindow resignKeyWindow]):
260         (-[TestWKWebView initWithFrame:]):
261         (-[TestWKWebView initWithFrame:configuration:]):
262         (-[TestWKWebView _setUpTestWindow:]):
263         (-[TestWKWebView performAfterReceivingMessage:action:]):
264         (-[TestWKWebView loadTestPageNamed:]):
265         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
266         (-[TestWKWebView stringByEvaluatingJavaScript:]):
267         (-[TestWKWebView waitForMessage:]):
268         (-[TestWKWebView performAfterLoading:]):
269         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
270         (-[TestWKWebView typeCharacter:]):
271
272 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
273
274         Unreviewed. Bring back gtk-doc error messages after r209981.
275
276         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
277         impossible to know what's wrong.
278
279         * gtk/gtkdoc.py:
280         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
281
282 2017-01-20  Youenn Fablet  <youennf@gmail.com>
283
284         [WebRTC] Update build system to make G711 optional in libwebrtc
285         https://bugs.webkit.org/show_bug.cgi?id=167256
286
287         Reviewed by Alex Christensen.
288
289         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
290         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
291
292 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
293
294         Cleanup RuntimeEnabledFeatures
295         https://bugs.webkit.org/show_bug.cgi?id=167228
296
297         Reviewed by Simon Fraser.
298
299         * DumpRenderTree/mac/DumpRenderTree.mm:
300         (enableExperimentalFeatures):
301         (resetWebPreferencesToConsistentValues):
302         (setWebPreferencesForTestOptions):
303         (resetWebViewToConsistentStateBeforeTesting):
304         * DumpRenderTree/win/DumpRenderTree.cpp:
305         (enableExperimentalFeatures):
306         (resetWebPreferencesToConsistentValues):
307         More closely match WebKitTestRunner initialization of preferences
308         for experimental features.
309
310 2017-01-20  Alex Christensen  <achristensen@webkit.org>
311
312         Build Fix for Windows DumpRenderTree after r210976
313         https://bugs.webkit.org/show_bug.cgi?id=167115
314
315         * DumpRenderTree/win/DumpRenderTree.cpp:
316         (resetWebPreferencesToConsistentValues):
317
318 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
319
320         Remove outdated ENABLE(CSP_NEXT) build flag
321         https://bugs.webkit.org/show_bug.cgi?id=167252
322
323         Reviewed by Brent Fulgham.
324
325         * Scripts/webkitperl/FeatureList.pm:
326         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
327
328 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
329
330         Build Fix for Windows DumpRenderTree after r210976
331
332         * DumpRenderTree/win/DumpRenderTree.cpp:
333         (resetWebPreferencesToConsistentValues):
334
335 2017-01-20  Antoine Quint  <graouts@apple.com>
336
337         Web Animations should be off by default and enabled as an experimental feature
338         https://bugs.webkit.org/show_bug.cgi?id=167115
339         <rdar://problem/30048963>
340
341         Reviewed by Joseph Pecoraro.
342
343         Turn Web Animations on in DRT.
344
345         * DumpRenderTree/mac/DumpRenderTree.mm:
346         (resetWebPreferencesToConsistentValues):
347         * DumpRenderTree/win/DumpRenderTree.cpp:
348         (resetWebPreferencesToConsistentValues):
349
350 2017-01-20  Youenn Fablet  <youenn@apple.com>
351
352         [WebRTC] Add libwebrtc build infrastructure
353         https://bugs.webkit.org/show_bug.cgi?id=167207
354
355         Reviewed by Alex Christensen.
356
357         Adding a script doing the libwebrtc project json to CMake file conversion.
358
359         * Scripts/generate-libwebrtc-cmake: Added.
360         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
361         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
362
363 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
364
365         Mini Browser: Show tooltip for Experimental Features
366         https://bugs.webkit.org/show_bug.cgi?id=167225
367
368         Reviewed by Alex Christensen.
369
370         * MiniBrowser/mac/SettingsController.m:
371         (-[SettingsController _populateMenu]):
372         Include the full details string as a tooltip.
373
374 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
375
376         [Win] Test output results should not be written twice.
377         https://bugs.webkit.org/show_bug.cgi?id=167197
378
379         Reviewed by Brent Fulgham.
380
381         Prevent test output from being written twice by returning early from
382         the dump() function, if it already has been called.
383         This patch also adds a missing newline to a test output line. 
384         
385         * DumpRenderTree/win/DumpRenderTree.cpp:
386         (dump):
387
388 2017-01-20  Antoine Quint  <graouts@apple.com>
389
390         [Modern Media Controls] Turn modern media controls on by default
391         https://bugs.webkit.org/show_bug.cgi?id=165668
392
393         Reviewed by Dean Jackson.
394
395         Enabled modern media controls by default in test runners.
396
397         * DumpRenderTree/TestOptions.h:
398         * WebKitTestRunner/TestOptions.h:
399
400 2017-01-19  Chris Dumez  <cdumez@apple.com>
401
402         iterable<> should be enabled on WK1
403         https://bugs.webkit.org/show_bug.cgi?id=167221
404         <rdar://problem/30108531>
405
406         Reviewed by Youenn Fablet.
407
408         * DumpRenderTree/mac/DumpRenderTree.mm:
409         (resetWebPreferencesToConsistentValues):
410         * DumpRenderTree/win/DumpRenderTree.cpp:
411         (resetWebPreferencesToConsistentValues):
412         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
413         (WTR::InjectedBundle::beginTesting):
414         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
415         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
416         * WebKitTestRunner/InjectedBundle/TestRunner.h:
417
418 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
419
420         Ensure status server logs go to log file
421         https://bugs.webkit.org/show_bug.cgi?id=167210
422
423         Reviewed by Alexey Proskuryakov.
424
425         * Scripts/webkitpy/common/net/statusserver.py:
426         (StatusServer.next_work_item): Change log level from debug to info in
427         order to facilitate deubgging issues.
428         (StatusServer.update_work_items): Same.
429
430 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
431
432         Additional selection tests and interpolation fix
433         https://bugs.webkit.org/show_bug.cgi?id=167171
434
435         Reviewed by Simon Fraser.
436
437         We weren't adding the final event when interpolating event streams.
438
439         * WebKitTestRunner/ios/HIDEventGenerator.mm:
440         (-[HIDEventGenerator interpolatedEvents:]):
441
442 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
443
444         [Cocoa] Variation fonts are erroneously disabled on iOS
445         https://bugs.webkit.org/show_bug.cgi?id=167172
446
447         Reviewed by Simon Fraser.
448
449         OpenSource builders don't seem to understand sdk=embedded*.
450
451         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
452
453 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
454
455         Unreviewed. Fix GTK+ unit tests failing since r210531.
456
457         Avoid using paths to files that don't actually exist.
458
459         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
460         (testWebKitConsoleMessageNetworkError):
461         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
462         (testContextMenuDefaultMenu):
463         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
464         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
465         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
466
467 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
468
469         [GTK] Provide API to set proxy settings
470         https://bugs.webkit.org/show_bug.cgi?id=128674
471
472         Reviewed by Michael Catanzaro.
473
474         Add tests for new proxy settings API.
475
476         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
477         (serverCallback):
478         (ProxyTest::ProxyTest):
479         (ProxyTest::~ProxyTest):
480         (ProxyTest::loadURIAndGetMainResourceData):
481         (ProxyTest::proxyServerPortAsString):
482         (testWebContextProxySettings):
483         (beforeAll):
484
485 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
486
487         Add back my old email address so old commits will still match it.
488
489         * Scripts/webkitpy/common/config/contributors.json:
490
491 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
492
493         Remove my old email address from contributors.json and watchlist.
494
495         * Scripts/validate-committer-lists:
496         (CommitterListFromGit): Change the mapping to the correct email.
497         * Scripts/webkitpy/common/config/contributors.json:
498         * Scripts/webkitpy/common/config/watchlist:
499
500 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
501
502         Unreviewed, rolling out r210848.
503
504         This change introduced media-related LayoutTest failures and
505         crashes on macOS.
506
507         Reverted changeset:
508
509         "[Modern Media Controls] Turn modern media controls on by
510         default"
511         https://bugs.webkit.org/show_bug.cgi?id=165668
512         http://trac.webkit.org/changeset/210848
513
514 2017-01-18  Andreas Kling  <akling@apple.com>
515
516         Document::securityOrigin() should return a reference.
517         <https://webkit.org/b/167124>
518
519         Reviewed by Sam Weinig.
520
521         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
522         (TestWebKitAPI::TEST_F):
523
524 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
525
526         [Win] Clipboard tests are flaky.
527         https://bugs.webkit.org/show_bug.cgi?id=167088
528
529         Reviewed by Brent Fulgham.
530
531         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
532         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
533
534         * DumpRenderTree/win/DumpRenderTree.cpp:
535         (main):
536
537 2017-01-18  Antoine Quint  <graouts@apple.com>
538
539         [Modern Media Controls] Turn modern media controls on by default
540         https://bugs.webkit.org/show_bug.cgi?id=165668
541
542         Reviewed by Dean Jackson.
543
544         Enabled modern media controls by default in test runners. 
545
546         * DumpRenderTree/TestOptions.h:
547         * WebKitTestRunner/TestOptions.h:
548
549 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
550
551         Unreviewed, rolling out r210834
552         https://bugs.webkit.org/show_bug.cgi?id=165668
553
554         It introduced dozens of test timeouts.
555
556         Reverted changeset:
557         "[Modern Media Controls] Turn modern media controls on by default"
558         https://bugs.webkit.org/show_bug.cgi?id=165668
559         http://trac.webkit.org/changeset/210834
560
561 2017-01-17  Antoine Quint  <graouts@apple.com>
562
563         [Modern Media Controls] Turn modern media controls on by default
564         https://bugs.webkit.org/show_bug.cgi?id=165668
565
566         Reviewed by Dean Jackson.
567
568         Enabled modern media controls by default in test runners. 
569
570         * DumpRenderTree/TestOptions.h:
571         * WebKitTestRunner/TestOptions.h:
572
573 2017-01-17  Chris Dumez  <cdumez@apple.com>
574
575         Document title changed twice when setting document.title
576         https://bugs.webkit.org/show_bug.cgi?id=167065
577
578         Reviewed by Darin Adler.
579
580         Add WebKit2GTK API test that was written by Michael Catanzaro.
581
582         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
583         (testWebViewTitleChange):
584         (beforeAll):
585
586 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
587
588         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
589         https://bugs.webkit.org/show_bug.cgi?id=116551
590         <rdar://problem/13949830>
591
592         Reviewed by Alex Christensen.
593
594         * Scripts/webkitperl/FeatureList.pm:
595         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
596         that is part of the existing WEB_TIMING feature.
597
598         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
599
600 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
601
602         'webkit-patch post' no longer works with moved/copied files
603         https://bugs.webkit.org/show_bug.cgi?id=166914
604         <rdar://problem/29979707>
605
606         Reviewed by Daniel Bates.
607
608         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
609         file outputs only the "Index:" line with an empty body.  This workaround
610         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
611         public email list tracking this bug is below.
612         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
613         
614
615         * Scripts/svn-create-patch:
616         (generateDiff): Ignore an "Index:" line with an empty body.
617
618 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
619
620         Remove the REQUEST_ANIMATION_FRAME flag
621         https://bugs.webkit.org/show_bug.cgi?id=156980
622         <rdar://problem/25906849>
623
624         Reviewed by Simon Fraser.
625
626         * Scripts/webkitperl/FeatureList.pm:
627         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
628
629 2017-01-15  Sam Weinig  <sam@webkit.org>
630
631         Add the ability to use numbers in makeString()
632         https://bugs.webkit.org/show_bug.cgi?id=167087
633
634         Reviewed by Darin Adler.
635
636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
637         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
638         Add tests for StringConcatenate, focusing on new numeric additions.
639
640 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
641
642         Unreviewed, remove stale comment.
643
644         This test was fixed by r163173.
645
646         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
647
648 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
649
650         Annotate large string tests with largeHeap
651         https://bugs.webkit.org/show_bug.cgi?id=167054
652
653         Reviewed by Filip Pizlo.
654
655         * Scripts/run-javascriptcore-tests:
656         * Scripts/run-jsc-stress-tests:
657
658 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
659
660         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
661         https://bugs.webkit.org/show_bug.cgi?id=167043
662
663         Reviewed by Darin Adler.
664
665         * Scripts/webkitperl/FeatureList.pm:
666
667 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
668
669         Remove ENABLE(DETAILS_ELEMENT) guards
670         https://bugs.webkit.org/show_bug.cgi?id=167042
671
672         Reviewed by Alex Christensen.
673
674         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
675
676 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
677
678         26 MotionMark performance tests failing
679         https://bugs.webkit.org/show_bug.cgi?id=166854
680
681         Reviewed by Ryosuke Niwa.
682
683         Unrelated change. This is the last place that we need to rename Animometer
684         to MotionMark.
685
686         * Scripts/webkitpy/common/config/watchlist:
687
688 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
689
690         run-jsc-benchmarks' echo should have -e option
691         https://bugs.webkit.org/show_bug.cgi?id=167009
692
693         Reviewed by Sam Weinig.
694
695         echo requires `-e` option to use escape sequence.
696         Without it, in some environment (in my Fedora 25), the escape sequence is not
697         recognized and just dumped as `\c` etc.
698
699         * Scripts/run-jsc-benchmarks:
700
701 2017-01-12  Chris Dumez  <cdumez@apple.com>
702
703         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
704         https://bugs.webkit.org/show_bug.cgi?id=166995
705
706         Reviewed by Jer Noble.
707
708         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
709         as some people are having trouble building without it.
710
711         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
712
713 2017-01-12  Sam Weinig  <sam@webkit.org>
714
715         Add the ability to filter the set of bindings tests you want to run
716         https://bugs.webkit.org/show_bug.cgi?id=166977
717
718         Reviewed by Tim Horton.
719
720         Allows doing things like:
721             run-bindings-tests TestObj* TestCEReactions*
722         
723         to run only those tests that match the patterns.
724
725         * Scripts/run-bindings-tests:
726         (main):
727         Switch to using optparse and pass the remaining args as the filters.
728
729         * Scripts/webkitpy/bindings/main.py:
730         (BindingsTests.__init__):
731         Store the pattens.
732
733         (BindingsTests.test_matches_patterns):
734         Add helper predicate to determine if a test should be run. When no
735         patterns are present, all tests should run.
736
737         (BindingsTests.run_tests):
738         Filter tests using the passed in patterns.
739
740 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
741
742         Followup fix after r210503.
743         https://bugs.webkit.org/show_bug.cgi?id=166887
744
745         Reviewed by Alex Christensen.
746
747         After <http://trac.webkit.org/changeset/210503>, test results are written to a
748         duplicated file handle on Windows. This patch fixes the remaining call sites.
749
750         * DumpRenderTree/PixelDumpSupport.cpp:
751         * DumpRenderTree/TestRunner.cpp:
752         (TestRunner::waitToDumpWatchdogTimerFired):
753         * DumpRenderTree/TestRunner.h:
754         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
755         * DumpRenderTree/win/DumpRenderTree.cpp:
756         * DumpRenderTree/win/DumpRenderTreeWin.h:
757         * DumpRenderTree/win/TestRunnerWin.cpp:
758         (TestRunner::setSpellCheckerLoggingEnabled):
759
760 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
761
762         Add committer status for Megan
763         https://bugs.webkit.org/show_bug.cgi?id=166954
764
765         Reviewed by Tim Horton.
766
767         Add committer status for Megan Gardner
768
769         * Scripts/webkitpy/common/config/contributors.json:
770
771 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
772
773         Unreviewed test fix after r210599.
774
775         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
776         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
777
778 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
779
780         Unreviewed build fix after r210599.
781
782         Add missing files.
783
784         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
785         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
786
787 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
788
789         File scheme should not allow access of a resource on a different volume.
790         https://bugs.webkit.org/show_bug.cgi?id=158552
791         <rdar://problem/15307582>
792
793         Reviewed by Alex Christensen.
794
795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
796         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
797         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
798
799 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
800
801         Unreviewed, rolling out r210571.
802
803         This change broke the 32-bit macOS build and caused LayoutTest
804         failures.
805
806         Reverted changeset:
807
808         "File scheme should not allow access of a resource on a
809         different volume."
810         https://bugs.webkit.org/show_bug.cgi?id=158552
811         http://trac.webkit.org/changeset/210571
812
813 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
814
815         [GTK] install-dependencies script misses gdb
816         https://bugs.webkit.org/show_bug.cgi?id=166917
817
818         Reviewed by Michael Catanzaro.
819
820         gdb is needed for generating the crash logs.
821
822         * gtk/install-dependencies:
823
824 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
825
826         [GTK] No way for applications to set notification permissions without waiting for permission request
827         https://bugs.webkit.org/show_bug.cgi?id=163366
828
829         Reviewed by Carlos Garcia Campos.
830
831         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
832         (testWebViewNotification):
833         (setInitialNotificationPermissionsAllowedCallback):
834         (setInitialNotificationPermissionsDisallowedCallback):
835         (testWebViewNotificationInitialPermissionAllowed):
836         (testWebViewNotificationInitialPermissionDisallowed):
837         (beforeAll):
838         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
839         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
840         (WebViewTest::WebViewTest):
841         (WebViewTest::initializeWebView):
842         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
843
844 2017-01-10  Tim Horton  <timothy_horton@apple.com>
845
846         MobileMiniBrowser tests don't work by default
847         https://bugs.webkit.org/show_bug.cgi?id=166910
848
849         Reviewed by Alex Christensen.
850
851         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
852         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
853
854 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
855
856         File scheme should not allow access of a resource on a different volume.
857         https://bugs.webkit.org/show_bug.cgi?id=158552
858         <rdar://problem/15307582>
859
860         Reviewed by Alex Christensen.
861
862         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
863         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
864         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
865
866 2017-01-10  Mark Lam  <mark.lam@apple.com>
867
868         Reverting run-jsc-stress-tests' $buildType to use string values.
869         https://bugs.webkit.org/show_bug.cgi?id=166912
870
871         Rubber stamped by Filip Pizlo.
872
873         This is so that we can test for it in the tests e.g.
874         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
875
876         * Scripts/run-jsc-stress-tests:
877
878 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
879
880         Temporarily add back the file removed in r210463 to unbreak internal bots.
881
882         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
883
884 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
885
886         svn-apply failed to apply a patch (deleting file with svn property)
887         https://bugs.webkit.org/show_bug.cgi?id=165953
888
889         Reviewed by Daniel Bates.
890
891         * Scripts/VCSUtils.pm:
892         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
893         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
894
895 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
896
897         Update flakiness dashboard configuration.
898         https://bugs.webkit.org/show_bug.cgi?id=166869
899
900         Reviewed by Alexey Proskuryakov.
901
902         * TestResultServer/static-dashboards/builders.jsonp:
903         * TestResultServer/static-dashboards/flakiness_dashboard.js:
904
905 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
906
907         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
908         https://bugs.webkit.org/show_bug.cgi?id=165232
909
910         Unreviewed follow-up patch after r210539 and r210523.
911
912         Instead of using that environment variable, the argument
913         --display-server=xorg should be passed now.
914
915         The GTK+ performance bot was the only bot using this, and is
916         already passing --display-server=xorg after r210539.
917
918         * Scripts/webkitpy/port/gtk.py:
919         (GtkPort._driver_class):
920
921 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
922
923         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
924         https://bugs.webkit.org/show_bug.cgi?id=166872
925
926         Reviewed by Michael Catanzaro.
927
928         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
929         Define the required "--display-server=driver" in the bot additionalArguments config entry.
930         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
931         The step RunWebKitTests already has support for it.
932
933         * BuildSlaveSupport/build.webkit.org-config/config.json:
934         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
935         (RunGtkAPITests.start):
936         (RunAndUploadPerfTests.start):
937         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
938
939 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
940
941         Unreviewed, rolling out r210531.
942
943         This change broke the 32-bit macOS build and caused LayoutTest
944         failures.
945
946         Reverted changeset:
947
948         "File scheme should not allow access of a resource on a
949         different volume."
950         https://bugs.webkit.org/show_bug.cgi?id=158552
951         http://trac.webkit.org/changeset/210531
952
953 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
954
955         File scheme should not allow access of a resource on a different volume.
956         https://bugs.webkit.org/show_bug.cgi?id=158552
957         <rdar://problem/15307582>
958
959         Reviewed by Alex Christensen.
960
961         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
962         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
963         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
964
965 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
966
967         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
968         https://bugs.webkit.org/show_bug.cgi?id=165232
969
970         Reviewed by Michael Catanzaro.
971
972         Add a new WaylandDriver to run the tests in the user current wayland session.
973
974         Also merge all the configuration options for selecting the display server inside one
975         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
976
977         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
978
979         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
980         (TestRunner._create_driver):
981         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
982         (parse_args):
983         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
984         (PerfTestsRunner._parse_args):
985         * Scripts/webkitpy/port/gtk.py:
986         (GtkPort.__init__):
987         (GtkPort._driver_class):
988         (GtkPort._search_paths):
989         * Scripts/webkitpy/port/waylanddriver.py: Added.
990         (WaylandDriver):
991         (WaylandDriver.check_driver):
992         (WaylandDriver._setup_environ_for_test):
993         (WaylandDriver._start):
994
995 2017-01-09  Andy Estes  <aestes@apple.com>
996
997         [QuickLook] Add a layout test for webkit.org/b/135651
998         https://bugs.webkit.org/show_bug.cgi?id=166855
999
1000         Reviewed by Andreas Kling.
1001
1002         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1003         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
1004         errors with code WebKitErrorCannotShowURL.
1005         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1006         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
1007         not specific to WebKit2 error codes.
1008
1009 2017-01-09  Antoine Quint  <graouts@apple.com>
1010
1011         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
1012         https://bugs.webkit.org/show_bug.cgi?id=166837
1013
1014         Reviewed by Alex Christensen.
1015
1016         We now correctly handle the --absolutePath argument in DumpRenderTree and use
1017         the provided value when trying to determine the path to the test file. Failing
1018         that, we use the computed URL or the raw path provided to cover all cases.
1019         
1020         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
1021         by applying this patch and seeing the number test failures dramatically reduced
1022         with WK1 due to the option to turn modern media controls off for older media controls
1023         tests.
1024
1025         * DumpRenderTree/DumpRenderTree.h:
1026         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1027         (parseInputLine):
1028         * DumpRenderTree/TestOptions.h:
1029         * DumpRenderTree/TestOptions.mm:
1030         (TestOptions::TestOptions):
1031         * DumpRenderTree/mac/DumpRenderTree.mm:
1032         (runTest):
1033
1034 2017-01-09  Milan Crha  <mcrha@redhat.com>
1035
1036         prepare-ChangeLog: Correct help string for --style option
1037         https://bugs.webkit.org/show_bug.cgi?id=166725
1038
1039         Reviewed by Alexey Proskuryakov.
1040
1041         * Scripts/prepare-ChangeLog:
1042         (main):
1043
1044 2017-01-09  Lucas Forschler  <lforschler@apple.com>
1045
1046         https://bugs.webkit.org/show_bug.cgi?id=166839
1047         Add php7 support for macOS.
1048         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
1049
1050         Reviewed by Alexey Proskuryakov.
1051
1052         * Scripts/webkitpy/port/base.py:
1053         (Port._is_darwin_php_version_7):
1054         (Port._debian_php_version):
1055         (Port):
1056         (Port._darwin_php_version):
1057         (Port._apache_config_file_name_for_platform):
1058
1059 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1060
1061         [GTK] Should support key and code properties on keyboard events
1062         https://bugs.webkit.org/show_bug.cgi?id=166759
1063
1064         Reviewed by Carlos Garcia Campos.
1065
1066         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1067         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
1068         on tests.
1069
1070 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
1071
1072         [Win] Some tests are flaky because certain DLLs are writing to stdout.
1073         https://bugs.webkit.org/show_bug.cgi?id=166760
1074
1075         Reviewed by Darin Adler.
1076
1077         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
1078         We can work around that by duplicating and redirecting stdout.
1079
1080         * DumpRenderTree/PixelDumpSupport.cpp:
1081         (dumpWebViewAsPixelsAndCompareWithExpected):
1082         (printPNG):
1083         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1084         (logEventProc):
1085         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1086         (DRTDesktopNotificationPresenter::showDesktopNotification):
1087         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
1088         (DRTDesktopNotificationPresenter::requestNotificationPermission):
1089         * DumpRenderTree/win/DumpRenderTree.cpp:
1090         (dumpFrameScrollPosition):
1091         (dumpHistoryItem):
1092         (dumpBackForwardList):
1093         (dump):
1094         (runTest):
1095         (main):
1096         * DumpRenderTree/win/DumpRenderTreeWin.h:
1097         * DumpRenderTree/win/EditingDelegate.cpp:
1098         (EditingDelegate::shouldBeginEditingInDOMRange):
1099         (EditingDelegate::shouldEndEditingInDOMRange):
1100         (EditingDelegate::shouldInsertNode):
1101         (EditingDelegate::shouldInsertText):
1102         (EditingDelegate::shouldDeleteDOMRange):
1103         (EditingDelegate::shouldChangeSelectedDOMRange):
1104         (EditingDelegate::shouldApplyStyle):
1105         (EditingDelegate::shouldChangeTypingStyle):
1106         (EditingDelegate::doPlatformCommand):
1107         (EditingDelegate::webViewDidBeginEditing):
1108         (EditingDelegate::webViewDidChange):
1109         (EditingDelegate::webViewDidEndEditing):
1110         (EditingDelegate::webViewDidChangeTypingStyle):
1111         (EditingDelegate::webViewDidChangeSelection):
1112         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1113         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1114         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
1115         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
1116         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1117         (FrameLoadDelegate::didCommitLoadForFrame):
1118         (FrameLoadDelegate::didReceiveTitle):
1119         (FrameLoadDelegate::didFinishLoadForFrame):
1120         (FrameLoadDelegate::didFailLoadWithError):
1121         (FrameLoadDelegate::willPerformClientRedirectToURL):
1122         (FrameLoadDelegate::didCancelClientRedirectForFrame):
1123         (FrameLoadDelegate::windowScriptObjectAvailable):
1124         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1125         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1126         (FrameLoadDelegate::didDisplayInsecureContent):
1127         (FrameLoadDelegate::didRunInsecureContent):
1128         (FrameLoadDelegate::webViewProgressFinishedNotification):
1129         * DumpRenderTree/win/HistoryDelegate.cpp:
1130         (HistoryDelegate::didNavigateWithNavigationData):
1131         (HistoryDelegate::didPerformClientRedirectFromURL):
1132         (HistoryDelegate::didPerformServerRedirectFromURL):
1133         (HistoryDelegate::updateHistoryTitle):
1134         (HistoryDelegate::populateVisitedLinksForWebView):
1135         * DumpRenderTree/win/PolicyDelegate.cpp:
1136         (PolicyDelegate::decidePolicyForNavigationAction):
1137         (PolicyDelegate::unableToImplementPolicyWithError):
1138         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1139         (ResourceLoadDelegate::willSendRequest):
1140         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1141         (ResourceLoadDelegate::didReceiveResponse):
1142         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1143         (ResourceLoadDelegate::didFailLoadingWithError):
1144         * DumpRenderTree/win/TestRunnerWin.cpp:
1145         (TestRunner::addDisallowedURL):
1146         (TestRunner::originsWithApplicationCache):
1147         (TestRunner::setStorageDatabaseIdleInterval):
1148         (TestRunner::closeIdleLocalStorageDatabases):
1149         (TestRunner::copyDecodedHostName):
1150         (TestRunner::copyEncodedHostName):
1151         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1152         (TestRunner::isGeolocationProviderActive):
1153         (TestRunner::pathToLocalResource):
1154         (TestRunner::setMockDeviceOrientation):
1155         (TestRunner::setMockGeolocationPosition):
1156         (TestRunner::setMockGeolocationPositionUnavailableError):
1157         (TestRunner::setSpatialNavigationEnabled):
1158         (TestRunner::setAutomaticLinkDetectionEnabled):
1159         (TestRunner::isCommandEnabled):
1160         (TestRunner::authenticateSession):
1161         (TestRunner::addChromeInputField):
1162         (TestRunner::removeChromeInputField):
1163         (TestRunner::focusWebView):
1164         (TestRunner::grantWebNotificationPermission):
1165         (TestRunner::denyWebNotificationPermission):
1166         (TestRunner::removeAllWebNotificationPermissions):
1167         (TestRunner::simulateWebNotificationClick):
1168         (TestRunner::imageCountInGeneralPasteboard):
1169         * DumpRenderTree/win/UIDelegate.cpp:
1170         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1171         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1172         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1173         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
1174         (UIDelegate::webViewAddMessageToConsole):
1175         (UIDelegate::exceededDatabaseQuota):
1176         (UIDelegate::setStatusText):
1177         (UIDelegate::didPressMissingPluginButton):
1178
1179 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1180
1181         Add a setting to create editable MiniBrowser windows by default
1182         https://bugs.webkit.org/show_bug.cgi?id=166806
1183
1184         Reviewed by Beth Dakin.
1185
1186         * MiniBrowser/mac/AppDelegate.m:
1187         (-[BrowserAppDelegate createBrowserWindowController:]):
1188         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1189         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1190         * MiniBrowser/mac/SettingsController.h:
1191         * MiniBrowser/mac/SettingsController.m:
1192         (-[SettingsController _populateMenu]):
1193         (-[SettingsController validateMenuItem:]):
1194         (-[SettingsController toggleCreateEditorByDefault:]):
1195         (-[SettingsController createEditorByDefault]):
1196         Add a setting and update the key equivalents accordingly.
1197         Also make sure to make the right kind of window on launch.
1198
1199 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1200
1201         Fix the 32-bit build.
1202
1203         * MiniBrowser/mac/BrowserWindowController.h:
1204         * MiniBrowser/mac/BrowserWindowController.m:
1205
1206 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1207
1208         Fix the 32-bit build.
1209
1210         * MiniBrowser/mac/BrowserWindowController.m:
1211
1212 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1213
1214         Make it possible to drop HTML files on the MiniBrowser icon
1215         https://bugs.webkit.org/show_bug.cgi?id=166802
1216
1217         Reviewed by Simon Fraser.
1218
1219         * MiniBrowser/mac/AppDelegate.m:
1220         (-[BrowserAppDelegate application:openFile:]):
1221         * MiniBrowser/mac/Info.plist:
1222         If you're using an editable window, the usual trick of dropping on the
1223         window doesn't work anymore (it makes an <attachment> instead).
1224
1225 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1226
1227         MiniBrowser window gets smaller each time it is instantiated
1228         https://bugs.webkit.org/show_bug.cgi?id=166807
1229
1230         Reviewed by Andy Estes.
1231
1232         * MiniBrowser/mac/BrowserWindowController.m:
1233         (-[BrowserWindowController windowDidLoad]):
1234         * MiniBrowser/mac/BrowserWindow.xib:
1235         Turn on full-window content view support with IB, instead of waiting
1236         until after the views have been loaded. This seems to resolve the
1237         longstanding ever-shrinking-window problem.
1238
1239 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1240
1241         Add indent/outdent items to MiniBrowser's new format menu
1242         https://bugs.webkit.org/show_bug.cgi?id=166805
1243
1244         Reviewed by Dan Bernstein.
1245
1246         * MiniBrowser/mac/MainMenu.xib:
1247
1248 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1249
1250         Add a stock Format menu to MiniBrowser
1251         https://bugs.webkit.org/show_bug.cgi?id=166804
1252
1253         Reviewed by Andy Estes.
1254
1255         * MiniBrowser/mac/MainMenu.xib:
1256         Many of the features automatically work with editable web views.
1257         However, this seems to expose a bug where none of the font-related features
1258         (Cmd-B, for example) work until the first time the font panel is shown,
1259         per process, which will need to be investigated separately.
1260
1261 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1262
1263         Remove unused applicationWillTerminate methods from MiniBrowser
1264         https://bugs.webkit.org/show_bug.cgi?id=166803
1265
1266         Reviewed by Andy Estes.
1267
1268         * MiniBrowser/mac/AppDelegate.m:
1269         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
1270         * MiniBrowser/mac/BrowserWindowController.h:
1271         * MiniBrowser/mac/BrowserWindowController.m:
1272         (-[BrowserWindowController applicationTerminating]): Deleted.
1273         * MiniBrowser/mac/WK1BrowserWindowController.m:
1274         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
1275         * MiniBrowser/mac/WK2BrowserWindowController.m:
1276         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
1277
1278 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1279
1280         Add the ability to create empty contentEditable windows in MiniBrowser
1281         https://bugs.webkit.org/show_bug.cgi?id=166801
1282
1283         Reviewed by Wenson Hsieh.
1284
1285         * MiniBrowser/mac/AppDelegate.h:
1286         * MiniBrowser/mac/AppDelegate.m:
1287         (-[BrowserAppDelegate createBrowserWindowController:]):
1288         (-[BrowserAppDelegate newWindow:]):
1289         (-[BrowserAppDelegate newEditorWindow:]):
1290         (-[BrowserAppDelegate openDocument:]):
1291         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1292         * MiniBrowser/mac/BrowserWindowController.h:
1293         * MiniBrowser/mac/BrowserWindowController.m:
1294         (-[BrowserWindowController loadHTMLString:]):
1295         (-[BrowserWindowController toggleEditable:]):
1296         * MiniBrowser/mac/MainMenu.xib:
1297         * MiniBrowser/mac/WK1BrowserWindowController.m:
1298         (-[WK1BrowserWindowController awakeFromNib]):
1299         (-[WK1BrowserWindowController loadHTMLString:]):
1300         (-[WK1BrowserWindowController validateMenuItem:]):
1301         (-[WK1BrowserWindowController setEditable:]):
1302         (-[WK1BrowserWindowController updateTitle:]):
1303         * MiniBrowser/mac/WK2BrowserWindowController.m:
1304         (-[WK2BrowserWindowController awakeFromNib]):
1305         (-[WK2BrowserWindowController validateMenuItem:]):
1306         (-[WK2BrowserWindowController setEditable:]):
1307         (-[WK2BrowserWindowController updateTitle:]):
1308         (-[WK2BrowserWindowController loadHTMLString:]):
1309         Merge more functionality from WebEditingTester.
1310         Add two menu items for creating empty editable WebKit1/2 windows.
1311         Add a menu item to the Edit menu to toggle editability on any window.
1312
1313 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1314
1315         Implement find-in-page in MiniBrowser
1316         https://bugs.webkit.org/show_bug.cgi?id=166799
1317
1318         Reviewed by Andy Estes.
1319
1320         * MiniBrowser/mac/BrowserWindow.xib:
1321         * MiniBrowser/mac/BrowserWindowController.h:
1322         * MiniBrowser/mac/BrowserWindowController.m:
1323         (-[BrowserWindowController find:]): Deleted.
1324         * MiniBrowser/mac/MainMenu.xib:
1325         * MiniBrowser/mac/WK1BrowserWindowController.m:
1326         (-[WK1BrowserWindowController toggleShrinkToFit:]):
1327         (-[WK1BrowserWindowController find:]): Deleted.
1328         * MiniBrowser/mac/WK2BrowserWindowController.m:
1329         (-[WK2BrowserWindowController awakeFromNib]):
1330         (-[WK2BrowserWindowController dealloc]):
1331         (-[WK2BrowserWindowController validateMenuItem:]):
1332         (-[WK2BrowserWindowController performTextFinderAction:]):
1333         (-[WK2BrowserWindowController findBarView]):
1334         (-[WK2BrowserWindowController setFindBarView:]):
1335         (-[WK2BrowserWindowController isFindBarVisible]):
1336         (-[WK2BrowserWindowController setFindBarVisible:]):
1337         (-[WK2BrowserWindowController contentView]):
1338         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
1339         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
1340         (-[WK2BrowserWindowController find:]): Deleted.
1341         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
1342         protocol. At first glance, it's pretty broken, but vaguely works.
1343
1344 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1345
1346         Share the implementation of MiniBrowser view hiding functionality
1347         https://bugs.webkit.org/show_bug.cgi?id=166800
1348
1349         Reviewed by Andy Estes.
1350
1351         * MiniBrowser/mac/BrowserWindowController.m:
1352         (-[BrowserWindowController showHideWebView:]):
1353         (-[BrowserWindowController removeReinsertWebView:]):
1354         * MiniBrowser/mac/WK1BrowserWindowController.m:
1355         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
1356         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
1357         * MiniBrowser/mac/WK2BrowserWindowController.m:
1358         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
1359         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
1360         Move the implementation of these two things to the shared superclass,
1361         since they don't depend on WebKit-specific things.
1362         Also, there was no reason to retain the (WK)WebView while it was unparented,
1363         as the BrowserWindowController maintains a reference the entire time.
1364
1365 2017-01-06  Andy Estes  <aestes@apple.com>
1366
1367         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
1368         https://bugs.webkit.org/show_bug.cgi?id=166789
1369
1370         Reviewed by Alex Christensen.
1371
1372         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1373         * DumpRenderTree/PlatformMac.cmake:
1374         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
1375         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
1376         * DumpRenderTree/mac/DumpRenderTree.mm:
1377         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
1378         createXMLStringFromWebArchiveData().
1379         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
1380         * WebKitTestRunner/Configurations/Base.xcconfig:
1381         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
1382         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1383         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1384         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
1385         createXMLStringFromWebArchiveData().
1386         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
1387         * WebKitTestRunner/PlatformMac.cmake:
1388         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1389         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
1390
1391 2017-01-06  Tim Horton  <timothy_horton@apple.com>
1392
1393         Minor cleanups to IndentOutdentCommand and related code
1394         https://bugs.webkit.org/show_bug.cgi?id=166791
1395
1396         Reviewed by Simon Fraser.
1397
1398         * WebEditingTester/EditingOperations.m:
1399         (editingOperations):
1400         Add the outdent operation to WebEditingTester.
1401
1402 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
1403
1404         Create a plan and a patch files for MotionMark and delete the Animometer's ones
1405         https://bugs.webkit.org/show_bug.cgi?id=166785
1406
1407         Reviewed by Ryosuke Niwa.
1408
1409         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
1410         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
1411
1412 2017-01-06  Antoine Quint  <graouts@apple.com>
1413
1414         Support webkit-test-runner key-value pairs in http tests
1415         https://bugs.webkit.org/show_bug.cgi?id=149812
1416
1417         Reviewed by Alex Christensen.
1418
1419         We pass the absolute path for a test through to WKTR so that we can parse
1420         tests that are running as URLs for webkit-test-runner options.
1421
1422         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1423         (parseInputLine):
1424
1425         Explicitly skip the --absolute-path option in DRT or else we'd crash.
1426
1427         * Scripts/webkitpy/port/driver.py:
1428         (Driver._command_from_driver_input):
1429
1430         Pass the absolute path to the file through the CLI.
1431
1432         * WebKitTestRunner/TestController.cpp:
1433         (WTR::updateTestOptionsFromTestHeader):
1434         (WTR::TestController::testOptionsForTest):
1435         (WTR::parseInputLine):
1436         (WTR::TestController::runTest):
1437         * WebKitTestRunner/TestController.h:
1438
1439 2017-01-06  Tim Horton  <timothy_horton@apple.com>
1440
1441         Warning about unconnectable outlets when opening a MiniBrowser window
1442         https://bugs.webkit.org/show_bug.cgi?id=166756
1443
1444         Reviewed by Dan Bernstein.
1445
1446         * MiniBrowser/mac/BrowserWindow.xib:
1447         When launching MiniBrowser, it says:
1448         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
1449             (MBToolbarItem): missing setter or instance variable
1450         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
1451             (NSButtonCell): missing setter or instance variable.
1452
1453         It looks like someone added the connection from the share button
1454         to the BrowserWindowController three times; only one of the connections
1455         is valid. Remove the other two.
1456
1457 2017-01-05  Keith Rollin  <krollin@apple.com>
1458
1459         Add WebCore::URL::protocolHostAndPort
1460         https://bugs.webkit.org/show_bug.cgi?id=166426
1461
1462         Reviewed by Alex Christensen.
1463
1464         Add test for protocolHostAndPort.
1465
1466         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1467         (TestWebKitAPI::TEST_F):
1468
1469 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
1470
1471         [Win] Archive test result is failing.
1472         https://bugs.webkit.org/show_bug.cgi?id=166720
1473
1474         Reviewed by Alex Christensen.
1475
1476         Deleting the layout test result folder is sometimes failing
1477         on Windows. This is not a critical error.
1478
1479         * BuildSlaveSupport/test-result-archive:
1480         (archiveTestResults):
1481
1482 2017-01-04  Tomas Popela  <tpopela@redhat.com>
1483
1484         [GTK] Minibrowser: Add printing support
1485         https://bugs.webkit.org/show_bug.cgi?id=165298
1486
1487         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
1488         an error during the print, it's printed on the console.
1489
1490         Reviewed by Michael Catanzaro.
1491
1492         * MiniBrowser/gtk/BrowserWindow.c:
1493         (webKitPrintOperationFailedCallback):
1494         (printPage):
1495         (browser_window_init):
1496
1497 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
1498
1499         [css-grid] Fix crash clamping grid lines
1500         https://bugs.webkit.org/show_bug.cgi?id=166637
1501
1502         Reviewed by Darin Adler.
1503
1504         Creates new unit test to verify that the maximum tracks limit
1505         is used in GridPosition too.
1506
1507         * TestWebKitAPI/PlatformEfl.cmake:
1508         * TestWebKitAPI/PlatformGTK.cmake:
1509         * TestWebKitAPI/PlatformWin.cmake:
1510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1511         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
1512         (TestWebKitAPI::TEST):
1513
1514 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1515
1516         Move editing history scripts to WebCore PrivateHeaders
1517         https://bugs.webkit.org/show_bug.cgi?id=166709
1518         <rdar://problem/29876612>
1519
1520         Reviewed by Dan Bernstein.
1521
1522         Update references to editing script files in WebCore that were moved.
1523
1524         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
1525
1526 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1527
1528         Unreviewed, build fix after r210313 part 2
1529         https://bugs.webkit.org/show_bug.cgi?id=166676
1530
1531         Add 'U' suffix.
1532
1533         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1534         (TestWebKitAPI::TEST):
1535         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1536         (TestWebKitAPI::TEST):
1537
1538 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1539
1540         Limit thread name appropriately
1541         https://bugs.webkit.org/show_bug.cgi?id=166676
1542
1543         Reviewed by Sam Weinig.
1544
1545         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1546         (TestWebKitAPI::TEST):
1547         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1548         (TestWebKitAPI::TEST):
1549
1550 2017-01-04  Andy Estes  <aestes@apple.com>
1551
1552         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
1553         https://bugs.webkit.org/show_bug.cgi?id=166696
1554
1555         Reviewed by Tim Horton.
1556
1557         * TestWebKitAPI/PlatformGTK.cmake:
1558         * TestWebKitAPI/PlatformWin.cmake:
1559         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1560         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
1561         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
1562         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
1563         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
1564         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
1565         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
1566
1567 2017-01-03  Brian Burg  <bburg@apple.com>
1568
1569         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
1570         https://bugs.webkit.org/show_bug.cgi?id=166003
1571         <rdar://problem/28718990>
1572
1573         Reviewed by Joseph Pecoraro.
1574
1575         Teach run-inspector-generator-tests to generate test output using the platform name
1576         derived from the directory that the test is in. For example, tests in the /generic/
1577         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
1578
1579         * Scripts/webkitpy/inspector/main.py:
1580         (InspectorGeneratorTests.generate_from_json):
1581         (InspectorGeneratorTests.run_tests):
1582         (InspectorGeneratorTests.main):
1583
1584 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
1585
1586         Unreviewed cmake buildfix after r210266.
1587
1588         * DumpRenderTree/PlatformMac.cmake:
1589
1590 2017-01-04  Tim Horton  <timothy_horton@apple.com>
1591
1592         Provide a setting for clients to always prefer low-power WebGL
1593         https://bugs.webkit.org/show_bug.cgi?id=166675
1594         <rdar://problem/29834093>
1595
1596         Reviewed by Dan Bernstein.
1597
1598         * MiniBrowser/mac/Info.plist:
1599         Have MiniBrowser claim to be a modern app that supports
1600         automatic graphics switching. WebKit needs to support automatic
1601         graphics switching, so our test app might as well. Without this
1602         Info.plist parameter, this change has no effect, and bringing up
1603         a WebGL context still brings up the discrete GPU (also true of the
1604         existing web-exposed preferLowPowerToHighPerformance API).
1605
1606 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
1607
1608         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
1609         https://bugs.webkit.org/show_bug.cgi?id=166645
1610
1611         Reviewed by Carlos Garcia Campos.
1612
1613         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1614         (TestWebKitAPI::TEST):
1615
1616 2017-01-03  Andy Estes  <aestes@apple.com>
1617
1618         Place all the Cocoa WebCore API tests in the same directory
1619         https://bugs.webkit.org/show_bug.cgi?id=166673
1620
1621         Reviewed by Michael Catanzaro.
1622
1623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1624         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
1625         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
1626         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
1627
1628 2017-01-03  Tim Horton  <timothy_horton@apple.com>
1629
1630         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
1631         https://bugs.webkit.org/show_bug.cgi?id=166450
1632         <rdar://problem/29447824>
1633
1634         Reviewed by Darin Adler.
1635
1636         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1637         * DumpRenderTree/TestRunner.cpp:
1638         (TestRunner::staticFunctions):
1639         * DumpRenderTree/mac/TestRunnerMac.mm:
1640         (setSpellCheckerLoggingEnabledCallback):
1641         * DumpRenderTree/win/TestRunnerWin.cpp:
1642         (setSpellCheckerLoggingEnabledCallback):
1643         * DumpRenderTree/mac/DumpRenderTree.mm:
1644         (resetWebViewToConsistentStateBeforeTesting):
1645         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
1646         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
1647         (stringForCorrectionResponse):
1648         (drt_NSSpellChecker_recordResponseToCorrection):
1649         (swizzleNSSpellCheckerMethodsIfNeeded):
1650         (setSpellCheckerLoggingEnabled):
1651         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
1652         set to true, logs to stdout (which ends up in the test result) whenever
1653         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
1654         is called, and then calls the original method. It is reset to false between tests.
1655
1656 2017-01-03  Sam Weinig  <sam@webkit.org>
1657
1658         Make WTF::Expected support Ref template parameters
1659         https://bugs.webkit.org/show_bug.cgi?id=166662
1660
1661         Reviewed by Alex Christensen.
1662
1663         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1664         (TestWebKitAPI::TEST):
1665         Add tests for using Ref with Expected.
1666
1667 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1668
1669         [GTK] Expose WebKitSecurityOrigin API
1670         https://bugs.webkit.org/show_bug.cgi?id=166632
1671
1672         Reviewed by Carlos Garcia Campos.
1673
1674         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1675         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
1676         (testSecurityOriginBasicConstructor):
1677         (testSecurityOriginURIConstructor):
1678         (testSecurityOriginDefaultPort):
1679         (testSecurityOriginFileURI):
1680         (testSecurityOriginDataURI):
1681         (beforeAll):
1682         (afterAll):
1683
1684 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1685
1686         [GTK] HTTP auth layout tests are flaky
1687         https://bugs.webkit.org/show_bug.cgi?id=158919
1688
1689         Reviewed by Michael Catanzaro.
1690
1691         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
1692         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
1693         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
1694         missing valac in the bots.
1695
1696 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1697
1698         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
1699         https://bugs.webkit.org/show_bug.cgi?id=165797
1700
1701         Reviewed by Michael Catanzaro.
1702
1703         Move directory ruleset after all exclude rules of Source rulset.
1704
1705         * gtk/manifest.txt.in:
1706
1707 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1708
1709         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
1710         https://bugs.webkit.org/show_bug.cgi?id=166636
1711
1712         Reviewed by Darin Adler.
1713
1714         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1715         (TestWebKitAPI::TEST):
1716
1717 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
1718
1719         [GTK] WebCore/CSSParser unit test is not being built
1720         https://bugs.webkit.org/show_bug.cgi?id=166492
1721
1722         Reviewed by Michael Catanzaro.
1723
1724         This test was introduced in r175930, but we were not building
1725         it on GTK+ port since r176015.
1726         This patch marks the test to be built again on GTK+.
1727         JFTR, the test is passing right now.
1728
1729         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
1730         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
1731
1732 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
1733
1734         AX: Expose block quote level to iOS API
1735         https://bugs.webkit.org/show_bug.cgi?id=166629
1736         <rdar://problem/29834793>
1737
1738         Reviewed by Darin Adler.
1739
1740         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1741         (AccessibilityUIElement::numberAttributeValue):
1742         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1743         (WTR::AccessibilityUIElement::numberAttributeValue):
1744
1745 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
1746
1747         SecurityOrigin::create triplet constructor does not canonicalize port
1748         https://bugs.webkit.org/show_bug.cgi?id=166624
1749
1750         Reviewed by Daniel Bates.
1751
1752         * TestWebKitAPI/PlatformGTK.cmake:
1753         * TestWebKitAPI/PlatformWin.cmake:
1754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1755         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
1756         (TestWebKitAPI::SecurityOriginTest::SetUp):
1757         (TestWebKitAPI::TEST_F):
1758
1759 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1760
1761         [GTK] Improve user agent construction
1762         https://bugs.webkit.org/show_bug.cgi?id=142074
1763
1764         Reviewed by Carlos Garcia Campos.
1765
1766         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1767         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
1768         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
1769         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
1770         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
1771         (TestWebKitAPI::TEST):
1772
1773 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
1774
1775         [GTK] Improve user agent construction
1776         https://bugs.webkit.org/show_bug.cgi?id=142074
1777
1778         Reviewed by Carlos Garcia Campos.
1779
1780         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1781         (TestWebKitAPI::TEST):
1782
1783 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
1784
1785         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
1786         https://bugs.webkit.org/show_bug.cgi?id=166472
1787         rdar://problem/29675551
1788
1789         Reviewed by Tim Horton.
1790
1791         These changes are necessary to allow the mouse to leave the WTR window while
1792         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
1793         (which DRT does); we'd always go through mouseMoved, which hits an early return
1794         in WebViewImpl::mouseMoved() when the point is outside the view.
1795
1796         * WebKitTestRunner/mac/EventSenderProxy.mm:
1797         (WTR::EventSenderProxy::mouseMoveTo):
1798
1799 2016-12-23  Andy Estes  <aestes@apple.com>
1800
1801         [iOS] Fix some crashing webarchive tests
1802         https://bugs.webkit.org/show_bug.cgi?id=166470
1803
1804         Reviewed by Andreas Kling.
1805
1806         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
1807         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
1808         so this change uses that on both platforms.
1809
1810         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
1811         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
1812         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
1813         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
1814         * WebKitTestRunner/PlatformMac.cmake:
1815         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1816         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
1817
1818 2016-12-22  Saam Barati  <sbarati@apple.com>
1819
1820         WebAssembly: Silence the output of the spec-tests
1821         https://bugs.webkit.org/show_bug.cgi?id=166417
1822
1823         Reviewed by Mark Lam.
1824
1825         * Scripts/run-jsc-stress-tests:
1826
1827 2016-12-22  Zhuo Li  <zachli@apple.com>
1828
1829         [Cocoa] SPI for setloadsImagesAutomatically.
1830         https://bugs.webkit.org/show_bug.cgi?id=166401.
1831
1832         Reviewed by Darin Adler.
1833
1834         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
1835         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
1836         _loadsImagesAutomatically returns YES.
1837
1838 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1839
1840         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
1841         https://bugs.webkit.org/show_bug.cgi?id=161328
1842         <rdar://problem/28475977>
1843
1844         Reviewed by Darin Adler.
1845
1846         Running a test that scales the viewport and listens to a didEndZooming callback (such as
1847         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
1848         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
1849         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
1850         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
1851         load, should prevent this from happening, but from reading documentation and code inspection, this is not
1852         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
1853         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
1854         we finish running a test and before we load the next test.
1855
1856         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
1857         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
1858         previous test started zooming and then finished before zooming completed. Since this happens before the next
1859         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
1860
1861         * WebKitTestRunner/ios/TestControllerIOS.mm:
1862         (WTR::TestController::platformResetStateToConsistentValues):
1863
1864 2016-12-22  Jer Noble  <jer.noble@apple.com>
1865
1866         Muted media element playback should not interrupt other audio playback
1867         https://bugs.webkit.org/show_bug.cgi?id=166347
1868
1869         Reviewed by Eric Carlson.
1870
1871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1872         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1873         (TestWebKitAPI::TEST):
1874         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
1875
1876 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
1877
1878         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
1879         https://bugs.webkit.org/show_bug.cgi?id=166346
1880
1881         Reviewed by Carlos Garcia Campos.
1882
1883         Enable WebRTC by default to simplify testing.
1884
1885         * MiniBrowser/gtk/main.c:
1886         (main):
1887
1888 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
1889
1890         REGRESSION: API test failure: WKWebView.LocalStorageClear
1891         https://bugs.webkit.org/show_bug.cgi?id=166032
1892         <rdar://problem/29758423>
1893
1894         Reviewed by Simon Fraser.
1895
1896         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
1897         to ensure that the view is destroyed before the callback fires.
1898
1899         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1900         (TEST):
1901
1902 2016-12-21  Saam Barati  <sbarati@apple.com>
1903
1904         WebAssembly: Import spec tests
1905         https://bugs.webkit.org/show_bug.cgi?id=166395
1906
1907         Rubber stamped by Keith Miller.
1908
1909         * Scripts/run-jsc-stress-tests:
1910
1911 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
1912
1913         REGRESSION: API test failure: _WKDownload.OriginatingWebView
1914         https://bugs.webkit.org/show_bug.cgi?id=166033
1915         <rdar://problem/29758428>
1916
1917         Reviewed by Simon Fraser.
1918
1919         Add an @autoreleasepool around the code that allocates the WKWebView, 
1920         so that it can be destroyed by removing the last reference in _downloadDidStart.
1921
1922         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1923         (TEST):
1924
1925 2016-12-21  Daniel Bates  <dabates@apple.com>
1926
1927         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
1928         https://bugs.webkit.org/show_bug.cgi?id=166356
1929
1930         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
1931         as a means to allow a test to explicit allow an embedding client to open a new windows
1932         such that the default behavior is for the embedding client to forbid such an action.
1933         The test plugins/get-url-with-blank-target.html assumes this default behavior though
1934         it is currently skipped on WebKit2 because questions were raised in the patch for
1935         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
1936         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
1937         this test.
1938
1939         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1940         (WTR::TestRunner::setCanOpenWindows):
1941
1942 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
1943
1944         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
1945         https://bugs.webkit.org/show_bug.cgi?id=166031
1946
1947         Reviewed by Tim Horton.
1948         
1949         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
1950         to ensure that the view is destroyed before the callback fires.
1951
1952         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
1953
1954 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
1955
1956         Throw Exception when test doesn't clean up HID Events properly
1957         https://bugs.webkit.org/show_bug.cgi?id=166271
1958
1959         Reviewed by Simon Fraser.
1960
1961         Add in a check when UIScriptController is deleted to make sure that the HID event
1962         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
1963         the program to crash without any good information. Crashes are race-y, and will still
1964         happen with malformed test, but the information will be much more helpful. 
1965
1966         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1967         (WTR::UIScriptController::checkForClean):
1968         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1969         (UIScriptContext::~UIScriptContext):
1970         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1971         (WTR::UIScriptController::checkForClean):
1972         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1973         * WebKitTestRunner/ios/HIDEventGenerator.h:
1974         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1975         (-[HIDEventGenerator checkHIDCallbacksClear]):
1976         * WebKitTestRunner/ios/TestControllerIOS.mm:
1977         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1978         (WTR::UIScriptController::checkForClean):
1979
1980 2016-12-20  Andy Estes  <aestes@apple.com>
1981
1982         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
1983         https://bugs.webkit.org/show_bug.cgi?id=165992
1984
1985         Reviewed by Brady Eidson.
1986
1987         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1988         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
1989         (expectException):
1990         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1991         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1992         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1993         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
1994         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
1995         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
1996         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
1997         (TEST):
1998         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
1999
2000 2016-12-20  Dean Jackson  <dino@apple.com>
2001
2002         Remove INDIE_UI
2003         https://bugs.webkit.org/show_bug.cgi?id=165881
2004         <rdar://problem/29672532>
2005
2006         Reviewed by Simon Fraser.
2007
2008         The Indie UI work has been discontinued.
2009
2010         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2011
2012 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2013
2014         [ES6] Enable ES6 Modules
2015         https://bugs.webkit.org/show_bug.cgi?id=165849
2016
2017         Reviewed by Geoffrey Garen.
2018
2019         * DumpRenderTree/mac/DumpRenderTree.mm:
2020         (resetWebPreferencesToConsistentValues):
2021         * DumpRenderTree/win/DumpRenderTree.cpp:
2022         (resetWebPreferencesToConsistentValues):
2023         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2024         (WTR::InjectedBundle::beginTesting):
2025         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2026         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
2027         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2028
2029 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
2030
2031         Repurpose bots and clean up dashboard.
2032         https://bugs.webkit.org/show_bug.cgi?id=166045
2033
2034         Reviewed by Lucas Forschler.
2035
2036         * BuildSlaveSupport/build.webkit.org-config/config.json:
2037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2038         (BubbleQueueServer):
2039         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2041         (WebKitBuildbot):
2042         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2043         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
2044
2045 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2046
2047         [CMake] TestWebKitAPIBase links to itself
2048         https://bugs.webkit.org/show_bug.cgi?id=165985
2049
2050         Reviewed by Alex Christensen.
2051
2052         Fix CMake warning about a target linking to itself, which makes no sense.
2053
2054         * TestWebKitAPI/CMakeLists.txt:
2055
2056 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2057
2058         [GTK] GtkDoc build should be quieter
2059         https://bugs.webkit.org/show_bug.cgi?id=165994
2060
2061         Reviewed by Carlos Garcia Campos.
2062
2063         Make it not print by default.
2064
2065         * gtk/generate-gtkdoc:
2066         (get_generator_for_config):
2067         (generate_doc):
2068         * gtk/gtkdoc.py:
2069         (GTKDoc._run_command):
2070         (GTKDoc._copy_doc_files_to_output_dir):
2071
2072 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
2073
2074         Expose a way for MiniBrowser to simulate header and footer banners
2075         https://bugs.webkit.org/show_bug.cgi?id=166005
2076
2077         Reviewed by Wenson Hsieh.
2078         
2079         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
2080         banners. This only works in WebKit2.
2081         
2082         We need to reset these on each navigation, since newly created FrameViews
2083         don't re-fetch the header and footer height stored on Page.
2084         
2085         Also fix the signature of webView:didFinishNavigation: to follow API changes,
2086         as well as fixing webViewWebContentProcessDidTerminate:
2087
2088         * MiniBrowser/mac/SettingsController.h:
2089         * MiniBrowser/mac/SettingsController.m:
2090         (-[SettingsController _populateMenu]):
2091         (-[SettingsController validateMenuItem:]):
2092         (-[SettingsController toggleReserveSpaceForBanners:]):
2093         (-[SettingsController isSpaceReservedForBanners]):
2094         * MiniBrowser/mac/WK2BrowserWindowController.m:
2095         (-[WK2BrowserWindowController didChangeSettings]):
2096         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2097         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
2098         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
2099         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
2100
2101 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
2102
2103         Fix iOS test results after r209967.
2104         
2105         Subtracting out the status bar height was erroneously happening for all tests,
2106         not just for flexible viewport tests.
2107         
2108         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
2109
2110         * WebKitTestRunner/PlatformWebView.h:
2111         * WebKitTestRunner/TestController.cpp:
2112         (WTR::TestController::resetStateToConsistentValues):
2113         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2114         (WTR::PlatformWebView::resizeTo):
2115         (WTR::PlatformWebView::setWindowFrame):
2116         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2117         (WTR::PlatformWebView::resizeTo):
2118         (WTR::PlatformWebView::setWindowFrame):
2119         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2120         (WTR::PlatformWebView::resizeTo):
2121         (WTR::PlatformWebView::setWindowFrame):
2122         * WebKitTestRunner/ios/TestControllerIOS.mm:
2123         (WTR::TestController::platformConfigureViewForTest):
2124         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2125         (WTR::PlatformWebView::resizeTo):
2126         (WTR::PlatformWebView::setWindowFrame):
2127
2128 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
2129
2130         [EFL] bump EFL version to 1.18.4
2131         https://bugs.webkit.org/show_bug.cgi?id=166004
2132
2133         Reviewed by Gyuyoung Kim.
2134
2135         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
2136
2137 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2138
2139         Visual viewports: bottom fixed elements disappear behind the keyboard
2140         https://bugs.webkit.org/show_bug.cgi?id=165983
2141         <rdar://problem/29409852>
2142
2143         Reviewed by Simon Fraser.
2144
2145         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
2146         the keyboard when it is up.
2147
2148         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2149         (WTR::UIScriptController::inputViewBounds):
2150         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2151         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2152         (WTR::UIScriptController::inputViewBounds):
2153         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2154         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2155         (WTR::viewRectForWindowRect):
2156
2157         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
2158         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
2159         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
2160
2161         (WTR::PlatformWebView::PlatformWebView):
2162         (WTR::PlatformWebView::setWindowFrame):
2163         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2164         (WTR::UIScriptController::inputViewBounds):
2165
2166 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
2167
2168         Deleting a character converted from pinyin after an image causes a Safari crash
2169         https://bugs.webkit.org/show_bug.cgi?id=165839
2170         <rdar://problem/27951933>
2171
2172         Reviewed by Wenson Hsieh.
2173
2174         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
2175         while the proposed range contains an image. This should not cause a WebProcess to crash
2176         or send an invalid message to the UIProcess.
2177
2178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2179         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
2180         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
2181         (TestWebKitAPI::didFinishLoadForFrame):
2182         (TestWebKitAPI::processDidCrash):
2183         (TestWebKitAPI::invalidMessageFunction):
2184         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
2185
2186 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2187
2188         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
2189         https://bugs.webkit.org/show_bug.cgi?id=165767
2190         <rdar://problem/29602382>
2191
2192         Reviewed by Simon Fraser.
2193
2194         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
2195         WebKit2 ChangeLog for more details.
2196
2197         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2198         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2199         (WTR::UIScriptController::textSelectionCaretRect):
2200         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2201         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2202         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2203         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2204         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2205         (WTR::UIScriptController::textSelectionCaretRect):
2206         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2207         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2208         (-[TestRunnerWKWebView _setStableStateOverride:]):
2209
2210         Force the WKWebView to update its visible content rects when changing the stable state override.
2211
2212         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2213         (WTR::toNSDictionary):
2214         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2215         (WTR::UIScriptController::selectionRangeViewRects):
2216         (WTR::UIScriptController::textSelectionCaretRect):
2217         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2218         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2219
2220 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
2221
2222         Arguments called in wrong order
2223         https://bugs.webkit.org/show_bug.cgi?id=165923
2224
2225         Reviewed by Simon Fraser.
2226
2227         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
2228         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
2229
2230         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2231         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
2232         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
2233
2234 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
2235
2236         [EFL] Disable non-srcdir builds for failing libraries
2237         https://bugs.webkit.org/show_bug.cgi?id=165896
2238
2239         Reviewed by Gyuyoung Kim.
2240
2241         * efl/jhbuild.modules: Set non srcdir builds to no
2242
2243 2016-12-15  Daniel Bates  <dabates@apple.com>
2244
2245         check-style should not complain about code in icu directories
2246         https://bugs.webkit.org/show_bug.cgi?id=53929
2247
2248         Reviewed by Darin Adler.
2249
2250         Skip style checking of imported ICU headers to avoid a deluge of style issues
2251         as they do not conform to the WebKit Code Style guideline. We want to preserve
2252         the formatting of these headers so as to make it straightforward to merge
2253         changes to them, if necessary.
2254
2255         * Scripts/webkitpy/style/checker.py:
2256
2257 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
2258
2259         Move JSC testers from Yosemite to Sierra
2260         https://bugs.webkit.org/show_bug.cgi?id=165925
2261
2262         Reviewed by Lucas Forschler.
2263
2264         * BuildSlaveSupport/build.webkit.org-config/config.json:
2265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2266         (WebKitBuildbot):
2267
2268 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
2269
2270         Add coordinate space to event streams and streamline tests
2271         https://bugs.webkit.org/show_bug.cgi?id=165119
2272
2273         Reviewed by Simon Fraser.
2274
2275         Update event streams to allow for both content and global coordinate space.
2276         Update example script to more accurately show all the available options.
2277
2278         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2279         * WebKitTestRunner/ios/HIDEventGenerator.h:
2280         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2281         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2282         (WTR::convertCoordinates):
2283         (WTR::UIScriptController::sendEventStream):
2284
2285 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
2286
2287         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
2288         https://bugs.webkit.org/show_bug.cgi?id=165855
2289
2290         Reviewed by Philippe Normand.
2291
2292         GStreamer's autogen.sh enables gtk-doc always so we end up building
2293         docs even if we disable them. Use the configure script instead, since
2294         we build from packages and these include it already.
2295
2296         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
2297         upstream gstreamer packages.
2298
2299 2016-12-15  Alex Christensen  <achristensen@webkit.org>
2300
2301         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
2302         https://bugs.webkit.org/show_bug.cgi?id=165885
2303         <rdar://problem/29476917>
2304
2305         Reviewed by Darin Adler.
2306
2307         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2308         (TestWebKitAPI::utf16String): Deleted.
2309         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
2310         (TestWebKitAPI::TEST_F):
2311         * TestWebKitAPI/WTFStringUtilities.h:
2312         (utf16String):
2313         Moved from URLParser to share with other tests.
2314
2315 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
2316
2317         iOS: An element with tabindex is not focusable unless there is no mouse event handler
2318         https://bugs.webkit.org/show_bug.cgi?id=165843
2319
2320         Reviewed by Antti Koivisto.
2321
2322         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
2323         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
2324         and DumpRenderTree's runUIScript would hit an assertion :(
2325
2326         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2327         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2328         (WTR::TestRunner::isWebKit2):
2329
2330 2016-12-14  Brady Eidson  <beidson@apple.com>
2331
2332         IndexedDB 2.0: Massively speedup IDBIndex.get().
2333         https://bugs.webkit.org/show_bug.cgi?id=165802
2334
2335         Reviewed by Alex Christensen.
2336
2337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2338         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
2339         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
2340         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
2341         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
2342
2343 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2344
2345         [GTK][EFL] Update the JHBuild version.
2346         https://bugs.webkit.org/show_bug.cgi?id=165838
2347
2348         Reviewed by Michael Catanzaro.
2349
2350         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
2351         usage of the JHBUILD_MIRROR feature with git repositories.
2352
2353 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2354
2355         [GTK] Yasm is needed for building the JHBuild after r208940
2356         https://bugs.webkit.org/show_bug.cgi?id=165837
2357
2358         Reviewed by Alejandro G. Castro.
2359
2360         * gtk/install-dependencies: Yasm is needed for building libvpx.
2361
2362 2016-12-14  Youenn Fablet  <youenn@apple.com>
2363
2364         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
2365         https://bugs.webkit.org/show_bug.cgi?id=161310
2366
2367         Reviewed by Ryosuke Niwa.
2368
2369         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
2370         When set, WTR and DRT output JS console log in the stderr and not the test output.
2371         This allows removing potentially flaky information while still being able to read it for investigation.
2372
2373         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
2374
2375         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
2376         This test should have this option when fetch API will start logging resource loader errors.
2377
2378         * DumpRenderTree/DumpRenderTree.h:
2379         (TestCommand::TestCommand): Deleted.
2380         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2381         (parseInputLine):
2382         * DumpRenderTree/TestRunner.h:
2383         (TestRunner::setDumpJSConsoleLogInStdErr):
2384         (TestRunner::dumpJSConsoleLogInStdErr):
2385         * DumpRenderTree/mac/DumpRenderTree.mm:
2386         (runTest):
2387         * DumpRenderTree/mac/UIDelegate.mm:
2388         (-[UIDelegate webView:addMessageToConsole:withSource:]):
2389         * DumpRenderTree/win/DumpRenderTree.cpp:
2390         (runTest):
2391         * DumpRenderTree/win/UIDelegate.cpp:
2392         (UIDelegate::webViewAddMessageToConsole):
2393         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2394         (TestExpectationParser._tokenize_line):
2395         * Scripts/webkitpy/port/driver.py:
2396         (Driver._command_from_driver_input):
2397         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2398         (WTR::InjectedBundle::didReceiveMessageToPage):
2399         (WTR::InjectedBundle::dumpToStdErr):
2400         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2401         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
2402         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2403         (WTR::InjectedBundlePage::willAddMessageToConsole):
2404         * WebKitTestRunner/TestController.cpp:
2405         (WTR::parseInputLine):
2406         (WTR::TestController::runTest):
2407         (WTR::TestCommand::TestCommand): Deleted.
2408         * WebKitTestRunner/TestInvocation.cpp:
2409         (WTR::TestInvocation::invoke):
2410         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2411         * WebKitTestRunner/TestInvocation.h:
2412         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
2413
2414
2415 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
2416
2417         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
2418         https://bugs.webkit.org/show_bug.cgi?id=164022
2419
2420         Reviewed by Xabier Rodriguez-Calvar.
2421
2422         * Scripts/webkitperl/FeatureList.pm:
2423           Re-enable MEDIA_SOURCE for the GTK+ port.
2424
2425 2016-12-13  Alex Christensen  <achristensen@webkit.org>
2426
2427         Fix CMake build.
2428
2429         * DumpRenderTree/PlatformMac.cmake:
2430         Define NS_RETURNS_RETAINED as nothing for now.
2431
2432 2016-12-13  Jer Noble  <jer.noble@apple.com>
2433
2434         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
2435         https://bugs.webkit.org/show_bug.cgi?id=165697
2436
2437         Reviewed by Tim Horton.
2438
2439         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
2440         (TestWebKitAPI::TEST):
2441
2442 2016-12-13  Andy Estes  <aestes@apple.com>
2443
2444         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
2445         https://bugs.webkit.org/show_bug.cgi?id=165785
2446         <rdar://problem/26929398>
2447
2448         Reviewed by Darin Adler.
2449
2450         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
2451         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
2452         expectations for the text, range, and action.
2453         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
2454         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
2455         plain-text string to the pasteboard, executed a paste action, and verified that the selected
2456         text in the web view did not change.
2457         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
2458         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
2459         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
2460         parameter.
2461         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
2462         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
2463         and returned the value of _editingDelegateShouldInsertText.
2464         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
2465         -shouldInsertText:replacingRange:givenAction:.
2466
2467 2016-12-13  Chris Dumez  <cdumez@apple.com>
2468
2469         Unreviewed, rolling out r209544.
2470
2471         Looks like r209489 did not cause the performance regression
2472         after all
2473
2474         Reverted changeset:
2475
2476         "Unreviewed, rolling out r209489."
2477         https://bugs.webkit.org/show_bug.cgi?id=165550
2478         http://trac.webkit.org/changeset/209544
2479
2480 2016-12-12  Sam Weinig  <sam@webkit.org>
2481
2482         [WebIDL] Remove use of Dictionary in ApplePaySession
2483         https://bugs.webkit.org/show_bug.cgi?id=165787
2484
2485         Reviewed by Anders Carlsson.
2486
2487         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2488         (WTR::initializeWebViewConfiguration):
2489         (WTR::TestController::platformCreateWebView):
2490         Enable ApplePay for the tests (where supported).
2491
2492 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
2493
2494         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
2495         https://bugs.webkit.org/show_bug.cgi?id=165251
2496
2497         Reviewed by Youenn Fablet.
2498
2499         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
2500         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
2501         the preferences have been set.
2502
2503 2016-12-08  Antti Koivisto  <antti@apple.com>
2504
2505         Enable network cache speculative revalidation in MiniBrowser
2506         https://bugs.webkit.org/show_bug.cgi?id=165616
2507
2508         Reviewed by Darin Adler.
2509
2510         Match Safari. Also add a menu item to disable it.
2511
2512         * MiniBrowser/mac/AppDelegate.m:
2513         (defaultConfiguration):
2514         * MiniBrowser/mac/SettingsController.h:
2515         * MiniBrowser/mac/SettingsController.m:
2516         (-[SettingsController _populateMenu]):
2517         (-[SettingsController validateMenuItem:]):
2518         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
2519         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
2520
2521 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
2522
2523         ChangeLogs become readonly after resolving a conflict
2524         https://bugs.webkit.org/show_bug.cgi?id=165440
2525         rdar://problem/29491002
2526
2527         Reviewed by Darin Adler.
2528
2529         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
2530         moving the file.
2531
2532 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
2533
2534         Re-enable collectContinuously since it doesn't crash anymore
2535
2536         Rubber stamped by Michael Saboff.
2537
2538         * Scripts/run-jsc-stress-tests:
2539
2540 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
2541
2542         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
2543         https://bugs.webkit.org/show_bug.cgi?id=165686
2544
2545         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
2546         so that right config.h comes first in include path.
2547
2548 2016-12-11  Dave Hyatt  <hyatt@apple.com>
2549
2550         [CSS Parser] Make sure content extensions initialize AtomicString
2551         https://bugs.webkit.org/show_bug.cgi?id=165737
2552
2553         Reviewed by Darin Adler.
2554
2555         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2556         (TestWebKitAPI::makeBackend):
2557
2558 2016-12-08  Dave Hyatt  <hyatt@apple.com>
2559
2560         [CSS Parser] Remove the old CSS Parser
2561         https://bugs.webkit.org/show_bug.cgi?id=165645
2562
2563         Reviewed by Daniel Bates.
2564
2565         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
2566         (TestWebKitAPI::TEST):
2567
2568 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
2569
2570         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
2571         https://bugs.webkit.org/show_bug.cgi?id=165686
2572
2573         Reviewed by Michael Catanzaro.
2574
2575         This change reduces duplication of include path lists between modules,
2576         and reduces future need for fixes like r209605 (broken build because of
2577         WebCore header suddenly becoming used in WebKit2).
2578
2579         * DumpRenderTree/CMakeLists.txt:
2580         * DumpRenderTree/PlatformMac.cmake:
2581         * ImageDiff/CMakeLists.txt:
2582         * MiniBrowser/gtk/CMakeLists.txt:
2583         * MiniBrowser/mac/CMakeLists.txt:
2584         * MiniBrowser/win/CMakeLists.txt:
2585         * TestWebKitAPI/CMakeLists.txt:
2586         * TestWebKitAPI/PlatformEfl.cmake:
2587         * TestWebKitAPI/PlatformJSCOnly.cmake:
2588         * TestWebKitAPI/PlatformMac.cmake:
2589         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2590         * WebKitTestRunner/CMakeLists.txt:
2591         * WebKitTestRunner/PlatformGTK.cmake:
2592         * WebKitTestRunner/PlatformMac.cmake:
2593
2594 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
2595
2596         Unreviewed buildfix after r209630.
2597
2598         * Scripts/build-jsc: Remove building the non-existing testWASM.
2599
2600 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
2601
2602         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
2603         https://bugs.webkit.org/show_bug.cgi?id=165251
2604
2605         Reviewed by Dean Jackson.
2606
2607         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
2608
2609         * DumpRenderTree/mac/DumpRenderTree.mm:
2610         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
2611
2612         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2613         (WTR::InjectedBundle::beginTesting): Ditto.
2614
2615         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2616         (WTR::TestRunner::setMediaStreamEnabled): New.
2617         (WTR::TestRunner::setPeerConnectionEnabled): New.
2618         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2619
2620 2016-12-09  Brady Eidson  <beidson@apple.com> 
2621  
2622         Re-landing:
2623         Add _WKIconLoadingDelegate SPI. 
2624         https://bugs.webkit.org/show_bug.cgi?id=164894 
2625  
2626         Reviewed by Alex Christensen. 
2627         
2628         Add MiniBrowser support for this new SPI, configurable with a setting. 
2629  
2630         * MiniBrowser/mac/SettingsController.h: 
2631         * MiniBrowser/mac/SettingsController.m: 
2632         (-[SettingsController _populateMenu]): 
2633         (-[SettingsController validateMenuItem:]): 
2634         (-[SettingsController loadsAllSiteIcons]): 
2635         (-[SettingsController toggleLoadsAllSiteIcons:]): 
2636         * MiniBrowser/mac/WK2BrowserWindowController.m: 
2637         (-[WK2BrowserWindowController awakeFromNib]): 
2638         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
2639
2640 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
2641
2642         Fix the 32-bit build.
2643
2644         Unreviewed build fix.
2645
2646         * MiniBrowser/mac/SettingsController.h:
2647
2648 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2649
2650         Fedora also needs a PHP7 config file alternative
2651         https://bugs.webkit.org/show_bug.cgi?id=165606
2652
2653         Reviewed by Michael Catanzaro.
2654
2655         * Scripts/webkitpy/port/base.py:
2656         (Port._is_fedora_php_version_7): check for the php7 library.
2657         (Port._fedora_php_version): get the appropriate filename for Fedora.
2658         (Port._apache_config_file_name_for_platform):
2659
2660 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
2661
2662         Complete the revert of r208865.
2663         https://bugs.webkit.org/show_bug.cgi?id=164894
2664
2665         Unreviewed build fix.
2666
2667         * MiniBrowser/mac/SettingsController.h:
2668         * MiniBrowser/mac/SettingsController.m:
2669         (-[SettingsController _populateMenu]):
2670         (-[SettingsController validateMenuItem:]):
2671         (-[SettingsController loadsAllSiteIcons]): Deleted.
2672         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
2673         * MiniBrowser/mac/WK2BrowserWindowController.m:
2674         (-[WK2BrowserWindowController awakeFromNib]):
2675         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
2676
2677 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2678
2679         [GTK] Force GDK backend to x11 when running with XvfbDriver
2680         https://bugs.webkit.org/show_bug.cgi?id=165612
2681
2682         Reviewed by Michael Catanzaro.
2683
2684         When the developer is running a Wayland session, GDK may get confused
2685         and try to use its Wayland backend (which is higher priority) instead.
2686         This ensures it will use the appropriate backend when running under
2687         Xvfb.
2688
2689         * Scripts/webkitpy/port/gtk.py:
2690         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
2691         force GDK_BACKEND to x11.
2692
2693 2016-12-08  Keith Miller  <keith_miller@apple.com>
2694
2695         Add 64-bit signed LEB decode method
2696         https://bugs.webkit.org/show_bug.cgi?id=165630
2697
2698         Reviewed by Ryosuke Niwa.
2699
2700         Add tests for LEB int64 and uint64 decode since I guess
2701         I forgot to add tests before.
2702
2703         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
2704         (TestWebKitAPI::testUInt32LEBDecode):
2705         (TestWebKitAPI::TEST):
2706         (TestWebKitAPI::testUInt64LEBDecode):
2707         (TestWebKitAPI::testInt32LEBDecode):
2708         (TestWebKitAPI::testInt64LEBDecode):
2709         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
2710
2711 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
2712
2713         Make it easy to enable --force-collectContinuously
2714         https://bugs.webkit.org/show_bug.cgi?id=165638
2715
2716         Reviewed by Keith Miller.
2717
2718         * Scripts/run-javascriptcore-tests:
2719         (runJSCStressTests):
2720
2721 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
2722
2723         Disable the collectContinuously mode until I investigate failures.
2724
2725         Rubber stamped by Keith Miller.
2726         
2727         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
2728         while I investigate.
2729
2730         * Scripts/run-jsc-stress-tests:
2731
2732 2016-12-08  Alex Christensen  <achristensen@webkit.org>
2733
2734         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
2735         https://bugs.webkit.org/show_bug.cgi?id=165621
2736
2737         Reviewed by Dan Bernstein.
2738
2739         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2740         (TestWebKitAPI::TEST_F):
2741
2742 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
2743
2744         Concurrent GC should be stable enough to land enabled
2745         https://bugs.webkit.org/show_bug.cgi?id=164990
2746
2747         Reviewed by Geoffrey Garen.
2748         
2749         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
2750         
2751         It's clear that this works just fine in release, but I'm still trying to figure out if it's
2752         safe for debug. It might be too slow for debug.
2753
2754         * Scripts/run-jsc-stress-tests:
2755
2756 2016-12-08  Alex Christensen  <achristensen@webkit.org>
2757
2758         Add SPI for sending WebsiteSettings to WebProcess during navigation
2759         https://bugs.webkit.org/show_bug.cgi?id=165517
2760         <rdar://29341068>
2761
2762         Reviewed by Anders Carlsson.
2763
2764         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2765         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
2766         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
2767         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2768         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2769         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2770         (TEST):
2771
2772 2016-12-08  Chris Dumez  <cdumez@apple.com>
2773
2774         Unreviewed, rolling out r209489.
2775
2776         Likely caused large regressions on JetStream, Sunspider and
2777         Speedometer
2778
2779         Reverted changeset:
2780
2781         "Add system trace points for JavaScript VM entry/exit"
2782         https://bugs.webkit.org/show_bug.cgi?id=165550
2783         http://trac.webkit.org/changeset/209489
2784
2785 2016-12-08  Keith Miller  <keith_miller@apple.com>
2786
2787         Move LEB tests to API tests
2788         https://bugs.webkit.org/show_bug.cgi?id=165586
2789
2790         Reviewed by Saam Barati.
2791
2792         Move the tests from testWasm.cpp and make them functions
2793         rather than macros.
2794
2795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2796         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
2797         (TestWebKitAPI::testUnsignedLEBDecode):
2798         (TestWebKitAPI::TEST):
2799         (TestWebKitAPI::testInt32LEBDecode):
2800
2801 2016-12-08  Chris Dumez  <cdumez@apple.com>
2802
2803         Support running the layout tests offline
2804         https://bugs.webkit.org/show_bug.cgi?id=165534
2805
2806         Reviewed by Ryosuke Niwa.
2807
2808         * Scripts/webkitpy/common/system/autoinstall.py:
2809         (AutoInstaller._download_to_stream):
2810         getcode() returns None for file URLs so handle this.
2811
2812         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2813         (WebPlatformTestServer._install_modules):
2814         Deal with local path in the json file and resolve them into file URLs
2815         before using AutoInstall.
2816
2817 2016-12-08  Alex Christensen  <achristensen@webkit.org>
2818
2819         Fix CMake build.
2820
2821         * DumpRenderTree/PlatformMac.cmake:
2822         Remove CheckedMalloc.cpp after r209516.
2823
2824 2016-12-07  Mark Lam  <mark.lam@apple.com>
2825
2826         DumpRenderTree should stop using CheckedMalloc.
2827         https://bugs.webkit.org/show_bug.cgi?id=165563
2828         <rdar://problem/28945820>
2829
2830         Reviewed by Geoffrey Garen.
2831
2832         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
2833            in CheckedMalloc.
2834         2. bmalloc does not honor the settings of CheckedMalloc.
2835
2836         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
2837         malloc.  As a result, DRT exhibits different behavior from the normal way we run
2838         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
2839         with WKTR.
2840
2841         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2842         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
2843         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
2844         * DumpRenderTree/mac/DumpRenderTree.mm:
2845         (prepareConsistentTestingEnvironment):
2846
2847 2016-12-07  Dean Jackson  <dino@apple.com>
2848
2849         Remove runtime toggle for pointer-lock
2850         https://bugs.webkit.org/show_bug.cgi?id=165577
2851         <rdar://problems/29566996>
2852
2853         Reviewed by Jon Lee.
2854
2855         Remove any runtime calls to check if pointer-lock is enabled. It's
2856         either compiled in or out.
2857
2858         * DumpRenderTree/mac/DumpRenderTree.mm:
2859         (resetWebPreferencesToConsistentValues):
2860         * WebKitTestRunner/TestController.cpp:
2861         (WTR::TestController::resetPreferencesToConsistentValues):
2862
2863 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
2864
2865         [MediaStream][Mac] Revoke sandbox extensions when capture ends
2866         https://bugs.webkit.org/show_bug.cgi?id=165476
2867
2868         Reviewed by Brady Eidson.
2869         
2870         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
2871         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
2872         is reset and recreated when a web page exits and is reloaded.
2873
2874         * TestWebKitAPI/PlatformGTK.cmake:
2875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2876         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
2877         (TestWebKitAPI::checkUserMediaPermissionCallback):
2878         (TestWebKitAPI::TEST):
2879         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
2880
2881 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
2882
2883         One esc to exit fullscreen and pointer lock
2884         https://bugs.webkit.org/show_bug.cgi?id=165416
2885         rdar://problem/29430711
2886
2887         Reviewed by Jer Noble.
2888
2889         Implement WKPageUIClientV8 for pointer lock support.
2890         Add "escape" key support in EventSenderProxy.
2891
2892         * WebKitTestRunner/TestController.cpp:
2893         (WTR::requestPointerLock):
2894         (WTR::TestController::createOtherPage):
2895         (WTR::TestController::createWebViewWithOptions):
2896         * WebKitTestRunner/mac/EventSenderProxy.mm:
2897         (WTR::EventSenderProxy::keyDown):
2898
2899 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
2900
2901         Add system trace points for JavaScript VM entry/exit
2902         https://bugs.webkit.org/show_bug.cgi?id=165550
2903
2904         Reviewed by Tim Horton.
2905
2906         Add trace points for entry/exit into/out of the JS VM.
2907
2908         * Tracing/SystemTracePoints.plist:
2909
2910 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
2911
2912         [GTK] Cannot build GTK+ with CUPS 2.* versions
2913         https://bugs.webkit.org/show_bug.cgi?id=163591
2914
2915         Reviewed by Michael Catanzaro.
2916
2917         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
2918         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
2919         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
2920         old gtk+ since it requires not only bumping up glib accordingly and its consequence
2921         causes many printing test failures. So, I propose to fix the configuration issue by
2922         applying the change to the configure file directly. By doing this, we don't need to
2923         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
2924
2925         * gtk/jhbuild.modules:
2926         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
2927
2928 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
2929
2930         Fix use of enum in a WK2 C SPI header.
2931         rdar://problem/28725583
2932
2933         Followup to correctly prefix the enum values.
2934
2935         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2936         (WTR::InjectedBundlePage::prepare):
2937
2938 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
2939
2940         Fix use of enum in a WK2 C SPI header.
2941         rdar://problem/28725583
2942
2943         Reviewed by Dan Bernstein.
2944
2945         Use correct enum style for a C SPI header and fix the callers.
2946
2947         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2948         (WTR::InjectedBundlePage::prepare):
2949
2950 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2951
2952         Add a new project for recording and playing back editing commands in editable web content
2953         https://bugs.webkit.org/show_bug.cgi?id=165114
2954         <rdar://problem/29408135>
2955
2956         Reviewed by Beth Dakin.
2957
2958         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
2959         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
2960         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
2961         then be dragged into the playback test harness.
2962
2963         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
2964         steps:
2965
2966         1. Load the capture harness and perform test-specific editing on the web view.
2967         2. Let originalState be a dump of the DOM at this point in time.
2968         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
2969         4. Rewind all editing to the beginning.
2970         5. Playback all editing to the end.
2971         6. Dump the state of the DOM. This should be identical to originalState.
2972
2973         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
2974         * EditingHistory/EditingHistory/Info.plist: Added.
2975         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
2976         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
2977         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
2978         * EditingHistory/EditingHistory/TestRunner.h: Added.
2979         * EditingHistory/EditingHistory/TestRunner.m: Added.
2980         (injectedMessageEventHandlerScript):
2981         (-[TestRunner init]):
2982         (-[TestRunner deleteBackwards:]):
2983         (-[TestRunner typeString:]):
2984         (-[TestRunner bodyElementSubtree]):
2985         (-[TestRunner bodyTextContent]):
2986         (-[TestRunner editingHistoryJSON]):
2987         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
2988         (-[TestRunner numberOfUpdates]):
2989         (-[TestRunner jumpToUpdateIndex:]):
2990         (-[TestRunner expectEvents:afterPerforming:]):
2991         (-[TestRunner loadCaptureTestHarness]):
2992         (-[TestRunner setTextObfuscationEnabled:]):
2993         (-[TestRunner isDoneWaitingForPendingEvents]):
2994         (-[TestRunner userContentController:didReceiveScriptMessage:]):
2995
2996         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
2997         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
2998
2999         * EditingHistory/EditingHistory/TestUtil.h: Added.
3000         * EditingHistory/EditingHistory/TestUtil.m: Added.
3001         (waitUntilWithTimeout):
3002         (waitUntil):
3003
3004         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
3005
3006         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
3007         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
3008         (-[WKWebView loadPageFromBundleNamed:]):
3009         (-[WKWebView typeCharacter:]):
3010         (-[WKWebView keyPressWithCharacters:keyCode:]):
3011         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
3012
3013         Provides utilities for simulating interaction in a web view.
3014
3015         * EditingHistory/EditingHistory/main.m: Added.
3016         (main):
3017         * EditingHistory/EditingHistoryTests/Info.plist: Added.
3018         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
3019         (-[RewindAndPlaybackTests setUp]):
3020         (-[RewindAndPlaybackTests tearDown]):
3021         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
3022         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
3023         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
3024         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
3025         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
3026
3027 2016-12-07  Philippe Normand  <pnormand@igalia.com>
3028
3029         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
3030         https://bugs.webkit.org/show_bug.cgi?id=165525
3031
3032         Reviewed by Carlos Garcia Campos.
3033
3034         * gtk/jhbuild.modules: gst-plugins-good should depend on the
3035         libvpx package built within jhbuild.
3036
3037 2016-12-07  Philippe Normand  <pnormand@igalia.com>
3038
3039         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
3040         https://bugs.webkit.org/show_bug.cgi?id=165520
3041
3042         Reviewed by Carlos Garcia Campos.
3043
3044         * gtk/jhbuild.modules: Added missing dependency on openh264 in
3045         gst-plugins-bad, along with 2 upstream patches fixing the build
3046         against OpenSSL 1.1.0.
3047         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
3048         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
3049
3050 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
3051
3052         Correct SDKROOT values in xcconfig files
3053         https://bugs.webkit.org/show_bug.cgi?id=165487
3054         rdar://problem/29539209
3055
3056         Reviewed by Dan Bernstein.
3057
3058         Fix suggested by Dan Bernstein.
3059
3060         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3061         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3062         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3063         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3064         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3065         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3066
3067 2016-12-06  Daniel Bates  <dabates@apple.com>
3068
3069         WebKitTestRunner: Plugins are disabled in new windows
3070         https://bugs.webkit.org/show_bug.cgi?id=165410
3071
3072         Reviewed by Alex Christensen.
3073
3074         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
3075         a new window and loads a plugin will fail. We should enable plugins in all windows by
3076         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
3077
3078         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
3079         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
3080         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
3081
3082         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3083         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
3084         WKBundleSetPluginsEnabled().
3085         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3086         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
3087         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
3088
3089 2016-12-05  Dean Jackson  <dino@apple.com>
3090
3091         pointer lock needs to be feature detectable
3092         https://bugs.webkit.org/show_bug.cgi?id=165426
3093         <rdar://problem/29486715>
3094
3095         Reviewed by Antoine Quint.
3096
3097         Expose the comment line to turn on/off pointer lock.
3098
3099         * DumpRenderTree/TestOptions.h:
3100         * DumpRenderTree/TestOptions.mm:
3101         (TestOptions::TestOptions):
3102         * DumpRenderTree/mac/DumpRenderTree.mm:
3103         (resetWebPreferencesToConsistentValues):
3104         * WebKitTestRunner/TestController.cpp:
3105         (WTR::TestController::resetPreferencesToConsistentValues):
3106         (WTR::updateTestOptionsFromTestHeader):
3107         * WebKitTestRunner/TestOptions.h:
3108         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3109         (WTR::PlatformWebView::viewSupportsOptions):
3110         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3111         (WTR::PlatformWebView::viewSupportsOptions):
3112
3113 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
3114
3115         Make it possible to use an existing simulator instance for one-off testing
3116         https://bugs.webkit.org/show_bug.cgi?id=164568
3117         <rdar://problem/29189133>
3118
3119         Reviewed by Daniel Bates.
3120
3121         With this patch, if a simulator is currently running on the machine and
3122         '--dedicated-simulators' is not passed into the application, only one simulator
3123         instance will be used, and this instance will be the existing instance.
3124         If no simulator is running or '--dedicated-simulators' is passed to the script,
3125         previous behavior will be used.
3126
3127         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3128         (parse_args):
3129         * Scripts/webkitpy/port/ios.py:
3130         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
3131         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
3132         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
3133         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
3134         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
3135         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
3136         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
3137         * Scripts/webkitpy/xcode/simulator.py:
3138         (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
3139         (Simulator.current_device): Get currently running device.
3140
3141 2016-12-05  Dan Bernstein  <mitz@apple.com>
3142
3143         Disable a crashing test on iOS.
3144
3145         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3146
3147 2016-12-04  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3148
3149         Fix a build break on EFL since r209303.
3150
3151         Unreviewed build fix.
3152
3153         * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
3154
3155 2016-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3156
3157         Refactor SymbolImpl layout
3158         https://bugs.webkit.org/show_bug.cgi?id=165247
3159
3160         Reviewed by Darin Adler.
3161
3162         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3163         (TestWebKitAPI::TEST):
3164
3165 2016-12-03  Dan Bernstein  <mitz@apple.com>
3166
3167         Fixed the build after r209307.
3168
3169         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3170         (TEST):
3171
3172 2016-12-03  Dan Bernstein  <mitz@apple.com>
3173
3174         [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI
3175         https://bugs.webkit.org/show_bug.cgi?id=165276
3176         <rdar://problem/29467040>
3177
3178         Reviewed by Darin Adler.
3179
3180         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3181         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added.
3182         (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]):
3183         (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]):
3184         (TEST):
3185         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added.
3186         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3187         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]):
3188         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
3189         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]):
3190         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added.
3191
3192 2016-12-02  Andy Estes  <aestes@apple.com>
3193
3194         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
3195         https://bugs.webkit.org/show_bug.cgi?id=164492
3196
3197         Reviewed by Dan Bernstein.
3198
3199         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
3200         com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
3201         * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
3202         org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
3203         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
3204         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
3205         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
3206         PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
3207         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
3208         org.webkit.$(PRODUCT_NAME:rfc1034identifier).
3209         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
3210         com.apple.$(PRODUCT_NAME:rfc1034identifier).
3211         * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
3212         com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
3213         * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
3214         org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
3215         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
3216         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
3217         com.apple.$(PRODUCT_NAME:rfc1034identifier).
3218         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
3219         com.apple.$(PRODUCT_NAME:rfc1034identifier).
3220         * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
3221         com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
3222         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
3223         value ${PRODUCT_BUNDLE_IDENTIFIER}.
3224         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
3225         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
3226         com.apple.WebKitTestRunner.InjectedBundle.
3227         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
3228         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
3229         * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
3230         com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
3231         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
3232         CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
3233         ${PRODUCT_BUNDLE_IDENTIFIER}.
3234
3235 2016-12-02  Brady Eidson  <beidson@apple.com>
3236
3237         Make IndexedDB.WebProcessKillIDBCleanup even more reliable.
3238         https://bugs.webkit.org/show_bug.cgi?id=165330
3239
3240         Reviewed by Alex Christensen.
3241
3242         The test currently nulls out a RetainPtr<WKWebView> to try to destroy the view and kill the process.
3243
3244         Problem is that doesn't reliably destroy the view.
3245         We should explicitly kill the process instead.
3246
3247         Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism.
3248         e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first.
3249
3250         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
3251         (TEST):
3252
3253 2016-12-02  Commit Queue  <commit-queue@webkit.org>
3254
3255         Unreviewed, rolling out r209136.
3256         https://bugs.webkit.org/show_bug.cgi?id=165337
3257
3258         broke 36 webkitpy tests (Requested by mcatanzaro on #webkit).
3259
3260         Reverted changeset:
3261
3262         "Make it possible to use an existing simulator instance for
3263         one-off testing"
3264         https://bugs.webkit.org/show_bug.cgi?id=164568
3265         http://trac.webkit.org/changeset/209136
3266
3267 2016-12-02  Chris Dumez  <cdumez@apple.com>
3268
3269         [Mac][WK1] Implement new HTML interactive form validation user interface
3270         https://bugs.webkit.org/show_bug.cgi?id=164483
3271
3272         Reviewed by Simon Fraser.
3273
3274         Add support for UIScriptController's contentsOfUserInterfaceItem("validationBubble")
3275         on Mac DRT as this is needed by the HTML form validation layout tests.
3276
3277         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3278         (WTR::UIScriptController::contentsOfUserInterfaceItem):
3279
3280 2016-12-02  Brady Eidson  <beidson@apple.com>
3281
3282         IndexedDB.IndexedDBMultiProcess and IndexedDB.WebProcessKillIDBCleanup sometimes timeout.
3283         https://bugs.webkit.org/show_bug.cgi?id=160780 and https://bugs.webkit.org/show_bug.cgi?id=161001
3284
3285         Reviewed by Alexey Proskuryakov.
3286
3287         These tests had "run-loop races."
3288         
3289         The test spins the runloop waiting for one message.
3290         Two messages might come in from the WebProcess in short succession, and both be delivered to the
3291         UIProcess in the same spin of the runloop.
3292
3293         Therefore by the time the test stops spinning the runloop, notified that a message was received,
3294         the first message has been overwritten by the second.
3295
3296         These tests are fixed by queueing the incoming messages instead of just storing one.
3297
3298         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3299         (-[IndexedDBMPMessageHandler userContentController:didReceiveScriptMessage:]):
3300         (getNextMessage):
3301         (TEST):
3302
3303         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
3304         (-[IndexedDBWebProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3305         (getNextMessage):
3306         (TEST):
3307
3308 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
3309
3310         Add a runtime flag for SubtleCrypto
3311         https://bugs.webkit.org/show_bug.cgi?id=164982
3312
3313         Reviewed by Brent Fulgham.
3314
3315         * DumpRenderTree/mac/DumpRenderTree.mm:
3316         (resetWebPreferencesToConsistentValues):
3317         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3318         (WTR::InjectedBundle::beginTesting):
3319         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3320         (WTR::TestRunner::setSubtleCryptoEnabled):
3321         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3322
3323 2016-12-01  Alexey Proskuryakov  <ap@apple.com>
3324
3325         Remove webkitpy dependency on Eliza
3326         https://bugs.webkit.org/show_bug.cgi?id=164979
3327
3328         Reviewed by Daniel Bates.
3329
3330         This module is not on pypi, so installing it is a challenge. The jokes feel pretty old too!
3331
3332         * Scripts/webkitpy/thirdparty/__init__.py:
3333         * Scripts/webkitpy/thirdparty/__init___unittest.py: Changed mock import hook to
3334         test buildbot instead of eliza.
3335         * Scripts/webkitpy/tool/bot/ircbot.py:
3336         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3337
3338 2016-12-01  Beth Dakin  <bdakin@apple.com>
3339
3340         Force clicking tests fail on some machines
3341         https://bugs.webkit.org/show_bug.cgi?id=165263
3342
3343         Reviewed by Tim Horton.
3344
3345         Initialize com.apple.trackpad.forceClick to 1 so that we don’t have to depend on 
3346         the user account having this feature enabled. 
3347         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3348         (WTR::InjectedBundle::platformInitialize):
3349         * WebKitTestRunner/mac/main.mm:
3350         (setDefaultsToConsistentValuesForTesting):
3351
3352 2016-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
3353
3354         Introduce StringImpl::StaticStringImpl with constexpr constructor
3355         https://bugs.webkit.org/show_bug.cgi?id=165093
3356
3357         Reviewed by Darin Adler.
3358
3359         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3360         (TestWebKitAPI::TEST):
3361
3362 2016-11-30  Antoine Quint  <graouts@apple.com>
3363
3364         [Modern Media Controls] Add an HTML comment flag to turn the feature on
3365         https://bugs.webkit.org/show_bug.cgi?id=165226
3366
3367         Reviewed by Dean Jackson.
3368
3369         Add a new flag to turn Modern Media Controls on in the test runners.
3370
3371         * DumpRenderTree/TestOptions.h:
3372         * DumpRenderTree/TestOptions.mm:
3373         (TestOptions::TestOptions):
3374         * DumpRenderTree/mac/DumpRenderTree.mm:
3375         (resetWebPreferencesToConsistentValues):
3376         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3377         (WTR::InjectedBundle::beginTesting):
3378         * WebKitTestRunner/TestController.cpp:
3379         (WTR::TestController::resetPreferencesToConsistentValues):
3380         (WTR::updateTestOptionsFromTestHeader):
3381         * WebKitTestRunner/TestOptions.h:
3382         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3383         (WTR::PlatformWebView::viewSupportsOptions):
3384         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3385         (WTR::PlatformWebView::viewSupportsOptions):
3386
3387 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
3388
3389         Add separate settings and preferences to enable/disable async decoding for large images and animated images
3390         https://bugs.webkit.org/show_bug.cgi?id=165177
3391
3392         Reviewed by Simon Fraser.
3393         
3394         Pref and a menu item to toggle async image decoding settings for WebKits 1 and 2.
3395
3396         * MiniBrowser/mac/SettingsController.h:
3397         * MiniBrowser/mac/SettingsController.m:
3398         (-[SettingsController _populateMenu]):
3399         (-[SettingsController validateMenuItem:]):
3400         (-[SettingsController toggleLargeImageAsyncDecodingEnabled:]):
3401         (-[SettingsController largeImageAsyncDecodingEnabled]):
3402         (-[SettingsController toggleAnimatedImageAsyncDecodingEnabled:]):
3403         (-[SettingsController animatedImageAsyncDecodingEnabled]):
3404         (-[SettingsController toggleAsyncImageDecodingEnabled:]): Deleted.
3405         (-[SettingsController asyncImageDecodingEnabled]): Deleted.
3406         * MiniBrowser/mac/WK1BrowserWindowController.m:
3407         (-[WK1BrowserWindowController didChangeSettings]):
3408         * MiniBrowser/mac/WK2BrowserWindowController.m:
3409         (-[WK2BrowserWindowController didChangeSettings]):
3410
3411 2016-11-30  Jonathan Bedard  <jbedard@apple.com>
3412
3413         Make it possible to use an existing simulator instance for one-off testing
3414         https://bugs.webkit.org/show_bug.cgi?id=164568
3415         <rdar://problem/29189133>
3416
3417         Reviewed by Daniel Bates.
3418
3419         With this patch, if a simulator is currently running on the machine and
3420         '--dedicated-simulators' is not passed into the application, only one simulator
3421         instance will be used, and this instance will be the existing instance.
3422         If no simulator is running or '--dedicated-simulators' is passed to the script,
3423         previous behavior will be used.
3424
3425         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3426         (parse_args):
3427         * Scripts/webkitpy/port/ios.py:
3428         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
3429         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
3430         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
3431         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
3432         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
3433         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
3434         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
3435         * Scripts/webkitpy/xcode/simulator.py:
3436         (Simulator.current_device): Get currently running device.
3437
3438 2016-11-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3439
3440         [Linux] run-benchmark should be able to execute the benchmarks with more browsers.
3441         https://bugs.webkit.org/show_bug.cgi?id=164792
3442
3443         Reviewed by Michael Catanzaro.
3444
3445         This removes the GTKBrowserDriver (and the platform 'gtk') from the run-benchmark script,
3446         and adds a new LinuxBrowserDriver with a platform 'linux'.
3447
3448         It add also drivers for Chrome (Chromium), Firefox, Epiphany and MiniBrowser-GTK (previously MiniBrowser).
3449
3450         The detection of the platform is now done automatically, so it is not longer needed to pass a "--platform" parameter.
3451
3452         The tracking of the browser process is now more robust, we track the pid of the browser process and we only try to
3453         kill the ones that were executed by this script, instead of doing a 'killall $browser' (like before).
3454         We also check for browser process childs and we kill them if they are still alive after the main browser process has been killed.
3455         This depends on psutil, so this will only be done if psutil is installed.
3456
3457         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3458         (RunBenchmarkTests.start): The platform is now autodetected and the MiniBrowser driver is renamed to MiniBrowser-GTK.
3459         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3460         (BenchmarkRunner._run_benchmark): Fix a bug that caused close_browsers to be called twice. Its already called inside BenchmarkRunner._run_one_test.
3461         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py: Added.
3462         (LinuxBrowserDriver): Implement base class that has all the needed functionality for driving the browsers.
3463         (LinuxBrowserDriver.__init__):
3464         (LinuxBrowserDriver.prepare_env):
3465         (LinuxBrowserDriver.restore_env):
3466         (LinuxBrowserDriver.close_browsers): Made the dependency on psutil optional (because it was listed as such on the README file <Tools/Scripts/webkitpy/benchmark_runner/README.md>)
3467         (LinuxBrowserDriver.launch_url):
3468         (LinuxBrowserDriver._get_first_executable_path_from_list):
3469         (LinuxBrowserDriver._screen_size):
3470         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
3471         (LinuxChromeDriver):
3472         (LinuxChromeDriver.launch_url):
3473         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py.
3474         (EpiphanyBrowserDriver):
3475         (EpiphanyBrowserDriver.launch_url):
3476         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
3477         (LinuxFirefoxDriver):
3478         (LinuxFirefoxDriver.launch_url):
3479         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
3480         (GTKMiniBrowserDriver):
3481         (GTKMiniBrowserDriver.launch_url):
3482         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3483         (SimpleHTTPServerDriver):
3484         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3485         (getplatform):
3486         (getdefaultbrowser):
3487         (parse_args):
3488         * Scripts/webkitpy/benchmark_runner/utils.py:
3489         (load_subclasses): The loading of subclasses was still (even after r196979) sensitive to the order in which the modules are loaded.
3490         We have to ensure that the files containing subclasses of the base_class_file are loaded after the base_class_file,
3491         we can do that by matching against the base_class_file pattern when the list is created.
3492
3493 2016-11-29  Andy Estes  <aestes@apple.com>
3494
3495         [Cocoa] Enable two clang warnings recommended by Xcode
3496         https://bugs.webkit.org/show_bug.cgi?id=164498
3497
3498         Reviewed by Mark Lam.
3499
3500         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
3501         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
3502         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3503         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3504
3505 2016-11-29  Eric Carlson  <eric.carlson@apple.com>
3506
3507         [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
3508         https://bugs.webkit.org/show_bug.cgi?id=164760
3509         <rdar://problem/29261266>
3510
3511         Reviewed by Youenn Fablet.
3512         
3513         Allow scripts to determine the number of times the user has been prompted for capture device access.
3514
3515         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3516         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3517         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
3518         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
3519         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
3520         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
3521         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3523         (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
3524         (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
3525         (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
3526         (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
3527         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3528         * WebKitTestRunner/TestController.cpp:
3529         (WTR::TestController::resetStateToConsistentValues):
3530         (WTR::OriginSettings::incrementRequestCount):
3531         (WTR::OriginSettings::resetRequestCount):
3532         (WTR::OriginSettings::requestCount):
3533         (WTR::TestController::saltForOrigin):
3534         (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
3535         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
3536         (WTR::TestController::settingsForOrigin):
3537         (WTR::TestController::userMediaPermissionRequestCountForOrigin):
3538         (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin):
3539         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
3540         (WTR::TestController::setUserMediaPermissionForOrigin): Deleted.
3541         * WebKitTestRunner/TestController.h:
3542         * WebKitTestRunner/TestInvocation.cpp:
3543         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3544         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3545
3546 2016-11-29  Simon Fraser  <simon.fraser@apple.com>
3547
3548         intersection-observer-entry-interface.html test fails on the bots
3549         https://bugs.webkit.org/show_bug.cgi?id=165133
3550
3551         Reviewed by Darin Adler.
3552         
3553         Tests that enabled Intersection Observer via <!-- webkit-test-runner [ enableIntersectionObserver=true ] -->
3554         would fail sometimes, because TestController::ensureViewSupportsOptionsForTest() failed to check
3555         to see if this option required creating a new web view, so would just use the old view without
3556         even resetting preferences.
3557         
3558         In general, TestController doesn't distinguish properly between options that require the creation
3559         of a new view (like mock scrollbars), and those that can be simply reset as resetPreferencesToConsistentValues()
3560         does.
3561         
3562         Do the easy fix of having viewSupportsOptions() check options.enableIntersectionObserver. We should probably
3563         just call resetPreferencesToConsistentValues() even when re-use the same view.
3564         
3565         * WebKitTestRunner/TestController.cpp:
3566         (WTR::TestController::resetPreferencesToConsistentValues):
3567         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3568         (WTR::PlatformWebView::viewSupportsOptions):
3569         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3570         (WTR::PlatformWebView::viewSupportsOptions):
3571
3572 2016-11-28  Ryan Haddad  <ryanhaddad@apple.com>
3573
3574         Unreviewed, rolling out r209008.
3575
3576         This change appears to have caused two fast/mediastrem
3577         LayoutTests to fail.
3578
3579         Reverted changeset:
3580
3581         "[MediaStream] Don't request user permission for a device if
3582         it has already been granted in the current browsing context"
3583         https://bugs.webkit.org/show_bug.cgi?id=164760
3584         http://trac.webkit.org/changeset/209008
3585
3586 2016-11-28  Daniel Bates  <dabates@apple.com>
3587
3588         Teach webkitpy how to read CSSProperties.json r209001
3589         https://bugs.webkit.org/show_bug.cgi?id=165108
3590
3591         Reviewed by Simon Fraser.
3592
3593         Fix webkitpy logic so that it can read CSS property names from CSSProperties.json following r209001.
3594
3595         Following r209001 CSSPropertyNames.in no longer exists as it was replaced with CSSProperties.json.
3596         We need to modify the webkitpy machinery that processed CSSPropertyNames.in to process CSSProperties.json.
3597
3598         * Scripts/webkitpy/w3c/test_converter.py:
3599         (_W3CTestConverter.__init__): Make self._css_property_file and self._css_property_value_file local
3600         variables as it is unnecessary for them to be instance variables. Call read_webkit_prefixed_css_property_list()
3601         to read the property names from file CSSProperties.json. Call legacy_read_webkit_prefixed_css_property_list() to
3602         read CSS keyword values from CSSValueKeywords.in.
3603         (_W3CTestConverter.read_webkit_prefixed_css_property_list): Added.
3604         (_W3CTestConverter):
3605         (_W3CTestConverter.legacy_read_webkit_prefixed_css_property_list): Renamed from read_webkit_prefixed_css_property_list.
3606         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3607         (TestImporterTest.test_harnesslinks_conversion): Substitute CSSProperties.json for CSSPropertyNames.in.
3608
3609 2016-11-28  Eric Carlson  <eric.carlson@apple.com>
3610
3611         [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
3612         https://bugs.webkit.org/show_bug.cgi?id=164760
3613         <rdar://problem/29261266>
3614
3615         Reviewed by Youenn Fablet.
3616         
3617         Allow scripts to determine the number of times the user has been prompted for capture device access.
3618
3619         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3620         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3621         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
3622         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
3623         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
3624         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
3625         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3626         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3627         (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
3628         (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
3629         (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
3630         (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
3631         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3632         * WebKitTestRunner/TestController.cpp:
3633         (WTR::TestController::resetStateToConsistentValues):
3634         (WTR::OriginSettings::incrementRequestCount):
3635         (WTR::OriginSettings::resetRequestCount):
3636         (WTR::OriginSettings::requestCount):
3637         (WTR::TestController::saltForOrigin):
3638         (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
3639         (WTR::TestController::handleCheckOfUserMediaPermiss