Another build fix attempt after r105543.
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Another build fix attempt after r105543.
4
5         * Scripts/webkitpy/common/net/file_uploader.py:
6         (FileUploader.upload_as_multipart_form_data):
7
8 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
9
10         Build fix attempt after r105543.
11
12         * Scripts/webkitpy/common/net/file_uploader.py:
13         (FileUploader.upload_as_multipart_form_data):
14
15 2012-01-24  Mario Sanchez Prada  <msanchez@igalia.com>
16
17         Unreviewed, skip WK2 API test timing out on some GTK bots.
18
19         WebKit2APITests/TestDownloads is consistently timing out on the
20         32bit release and 64bit debug bots.
21
22         * Scripts/run-gtk-tests:
23         (TestRunner): Skip WebKit2APITests/TestDownloads.
24
25 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
26
27         [Qt] Fix the build with the newes Qt5 hashes
28         https://bugs.webkit.org/show_bug.cgi?id=76657
29
30         Reviewed by Simon Hausmann.
31
32         * MiniBrowser/qt/MiniBrowserApplication.cpp:
33         (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
34         for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
35
36 2012-01-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
37
38         [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
39
40         We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
41         building with MinGW inside cmd.exe will require the same construct. Instead
42         we assume that when the first character in PWD is a '/' we're running under
43         Cygwin, and use the normal unix way of setting environment variables.
44
45         Reviewed by Simon Hausmann.
46
47         * qmake/mkspecs/features/default_pre.prf:
48
49 2012-01-24  Simon Hausmann  <simon.hausmann@nokia.com>
50
51         Some qmake build files must include Qt5's "quick" module.
52         https://bugs.webkit.org/show_bug.cgi?id=76671
53
54         Unreviewed build fix.
55
56         * MiniBrowser/qt/MiniBrowser.pro:
57         * WebKitTestRunner/Target.pri:
58
59 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
60
61         [Qt] Fix the event timestamps for touch mocking
62
63         Reviewed by Simon Hausmann.
64
65         * MiniBrowser/qt/MiniBrowserApplication.cpp:
66         (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
67         timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
68
69 2012-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
70
71         [GTK] Implement DownloadClient in WebKit2 GTK+ API
72         https://bugs.webkit.org/show_bug.cgi?id=72952
73
74         Reviewed by Martin Robinson.
75
76         * gtk/generate-gtkdoc:
77         (get_webkit2_options): Ignore WebKitDownloadClient.
78
79 2012-01-23  Zan Dobersek  <zandobersek@gmail.com>
80
81         [GTK] editing/deleting/5408255.html results are incorrect
82         https://bugs.webkit.org/show_bug.cgi?id=53644
83
84         Reviewed by Martin Robinson.
85
86         WEBKIT_TOP_LEVEL environment variable is now set directly in either
87         WebKitTestRunner or DumpRenderTree through usage of a compilation-time
88         macro. This way both tools can be run outside the test harness without
89         the need to manually set the environment variable.
90
91         * DumpRenderTree/gtk/DumpRenderTree.cpp:
92         (getTopLevelPath):
93         * GNUmakefile.am:
94         * Scripts/webkitpy/layout_tests/port/gtk.py:
95         (GtkPort.setup_environ_for_server):
96         * WebKitTestRunner/GNUmakefile.am:
97         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
98         (WTR::InjectedBundle::platformInitialize):
99
100 2012-01-23  Dmitry Lomov  <dslomov@google.com>
101
102         [Chromium] Implement layoutTestController.workerThreadCount in DRT
103         https://bugs.webkit.org/show_bug.cgi?id=74653.
104
105         Reviewed by Darin Fisher.
106
107         * DumpRenderTree/chromium/LayoutTestController.cpp:
108         (LayoutTestController::LayoutTestController):
109         (LayoutTestController::workerThreadCount):
110         * DumpRenderTree/chromium/LayoutTestController.h:
111
112 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
113
114         nrwt: make --chromium work like --qt
115         https://bugs.webkit.org/show_bug.cgi?id=76875
116
117         Reviewed by Adam Barth.
118
119         --chromium used to have to be handled differently from --qt
120         due to the way the PortFactory was implemented; there's not
121         really a good reason for that any more so this patch makes
122         things slightly more consistent and eliminates the
123         options.chromium flag (--chromium is now truly a synonym for
124         --platform chromium).
125
126         * Scripts/webkitpy/layout_tests/port/factory.py:
127         (PortFactory._default_port):
128         (PortFactory.get):
129         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
130         (FactoryTest.setUp):
131         (FactoryTest.test_chromium_mac):
132         (FactoryTest.test_chromium_linux):
133         (FactoryTest.test_chromium_win):
134         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
135         (parse_args):
136
137 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
138
139         run-webkit-tests needs to propagate --chromium
140         https://bugs.webkit.org/show_bug.cgi?id=76870
141
142         Reviewed by Eric Seidel.
143
144         run-webkit-tests removes '--chromium' argument from @ARGV when
145         determining which port to run, which means that that doesn't
146         propagate to new-run-webkit-tests. That's bad (and is handled
147         for the other ports by re-adding the flag, but apparently we're
148         just now noticing for Chromium).
149
150         * Scripts/run-webkit-tests:
151
152 2012-01-23  Brian Weinstein  <bweinstein@apple.com>
153
154         More build fixing after r105646.
155
156         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
157         (TestWebKitAPI::TestNode::key):
158
159 2012-01-23  Gavin Barraclough  <barraclough@apple.com>
160
161         Unreviewed build fix - r105646 broke this.
162
163         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
164         (TestWebKitAPI::TestNode::TestNode):
165         (TestWebKitAPI::TestNode::key):
166         (TestWebKitAPI::RedBlackTreeTest::assertEqual):
167         (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
168         (TestWebKitAPI::RedBlackTreeTest::testDriver):
169
170 2012-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
171
172         Unreviewed, rolling out r105658.
173         http://trac.webkit.org/changeset/105658
174         https://bugs.webkit.org/show_bug.cgi?id=76883
175
176         We want this eventually, but not right at this moment
177         (Requested by abarth on #webkit).
178
179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
180
181 2012-01-23  Adam Barth  <abarth@webkit.org>
182
183         garden-o-matic should support Chromium Mac Lion
184         https://bugs.webkit.org/show_bug.cgi?id=76880
185
186         Reviewed by Eric Seidel.
187
188         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
189
190 2012-01-23  Emil A Eklund  <eae@chromium.org>
191
192         check-webkit-style whitespace/operators triggers on overloaded division operator
193         https://bugs.webkit.org/show_bug.cgi?id=76650
194
195         Reviewed by Darin Adler.
196
197         * Scripts/webkitpy/style/checkers/cpp.py:
198         (check_spacing):
199         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
200         (CppStyleTest.test_operator_methods):
201
202 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
203
204         run-perf-tests should report server-side errors
205         https://bugs.webkit.org/show_bug.cgi?id=76802
206
207         Reviewed by Tony Chang.
208
209         Report errors whenever server's response doesn't match "OK".
210
211         * Scripts/webkitpy/common/net/file_uploader.py:
212         (FileUploader.upload_single_text_file):
213         (FileUploader.upload_as_multipart_form_data):
214         (FileUploader._upload_data.callback):
215         (FileUploader):
216         (FileUploader._upload_data):
217         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
218         (PerfTestsRunner._upload_json):
219         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
220         (test_upload_json):
221         (test_upload_json.MockFileUploader.upload_single_text_file):
222
223 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
224
225         run-perf-tests ignore Skipped list on chromium
226         https://bugs.webkit.org/show_bug.cgi?id=76764
227
228         Reviewed by Dirk Pranke.
229
230         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
231         can also find skipped list. Chromium port only uses test_expectations.txt for
232         layout tests but performacne tests don't use test_expectations.txt so Chromium port
233         also needs to use Skipped list.
234
235         * Scripts/webkitpy/layout_tests/port/base.py:
236         (Port._tests_from_skipped_file_contents):
237         (Port):
238         (Port._expectations_from_skipped_files):
239         (Port.skipped_perf_tests):
240         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
241         (PortTest.test_skipped_perf_tests):
242         (PortTest.test_skipped_perf_tests.add_text_file):
243         * Scripts/webkitpy/layout_tests/port/webkit.py:
244         (WebKitPort._skipped_tests_for_unsupported_features):
245         (WebKitPort._skipped_file_search_paths):
246         (WebKitPort.skipped_layout_tests):
247
248 2012-01-23  Andy Estes  <aestes@apple.com>
249
250         Fix the build after r105635.
251
252         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
253         (TestWebKitAPI::TEST):
254
255 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
256
257         Basic enhancements to StringBuilder
258         https://bugs.webkit.org/show_bug.cgi?id=67081
259
260         Reviewed by Darin Adler.
261
262         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
263         (TestWebKitAPI::TEST):
264
265 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
266
267         [GTK] run-gtk-tests randomly fails while running the xprop comand
268         https://bugs.webkit.org/show_bug.cgi?id=76817
269
270         Reviewed by Gustavo Noronha Silva.
271
272         No need to use xprop to remove the AT_SPI_BUS property since
273         run-gtk-tests will always run new instances of Xvfb.
274
275         * Scripts/run-gtk-tests:
276         (TestRunner): Unskip TestWebKitAccessibility.
277         (TestRunner.run): Uncomment lines for launching the accessibility
278         bus and registry daemon, and remove lines for running xprop.
279
280 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
281
282         [Qt] Don't warn about override and final being C++11 extensions
283
284         Clang will emit a warning when these extensions are used without passing
285         --std=c++11, but we use feature checking to decide if we have the right
286         extensions, so we can safely ignore these warnings. The XCode and Windows
287         project files have the same workaround.
288
289         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
290         we only have one extra compiler for Objective-C, which is also used for
291         Objective-C++ sources, so we have to pass the flag, even if it doesn't
292         make sense for Objective-C.
293
294         Reviewed by Simon Hausmann.
295
296         * qmake/mkspecs/features/unix/default_post.prf:
297
298 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
299
300         [Qt] Change how build-webkit decides when to do full incremental builds
301
302         Instead of relying on update-webkit (which isn't run on the bots) to
303         decide when to do a full incremental build (make qmake), we let the
304         build-webkit script itself check the current SVN revision against the
305         previous build (by storing it in .webkit.config).
306
307         If the two differ we assume a full incremental build is needed, since
308         the new revisions might have introduced problematic things like new
309         Q_OBJECT macros. If not, we assume the developer is doing changes
310         locally, and revert to doing a plain 'make'.
311
312         In addition, when the build fails in the latter case, we inform the
313         developer of possible pitfalls and how to manually run 'make qmake'.
314
315         Reviewed by Ossy.
316
317         * Scripts/update-webkit:
318         * Scripts/webkitdirs.pm:
319         (buildQMakeProjects):
320
321 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
322
323         [GTK] run-gtk-tests randomly fails while running the xprop comand
324         https://bugs.webkit.org/show_bug.cgi?id=76817
325
326         Reviewed by Philippe Normand.
327
328         Temporarily comment the lines related to launching the ATSPI bus
329         and registry daemon, which are making the bots to fail randomly.
330
331         * Scripts/run-gtk-tests:
332         (TestRunner): Skip TestWebKitAccessibility, as it won't run
333         properly if the ATSPI infrastructure is not properly initialized.
334         (TestRunner.run): Comment lines related to initialization of ATSPI.
335
336 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
337
338         Windows python test build fix.
339
340         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
341         (PerfTestsRunner.__init__):
342
343 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
344
345         [GTK] DumpRenderTree converts "file:///" to a path differently
346         https://bugs.webkit.org/show_bug.cgi?id=76631
347
348         Reviewed by Martin Robinson.
349
350         DumpRenderTree should print "/" as the last path component if the
351         path is a lone slash instead of empty output.
352
353         * DumpRenderTree/gtk/DumpRenderTree.cpp:
354         (webViewConsoleMessage):
355
356 2012-01-20  David Levin  <levin@chromium.org>
357
358         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
359         https://bugs.webkit.org/show_bug.cgi?id=76752
360
361         Reviewed by Eric Seidel.
362
363         * Scripts/webkitpy/style/checkers/cpp.py:
364         (check_for_leaky_patterns):
365         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
366         (LeakyPatternTest.test_create_dc):
367         (LeakyPatternTest.test_create_compatible_dc):
368
369 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
370
371         Changed my status in commiters.py
372
373         Unreviewed.
374
375         * Scripts/webkitpy/common/config/committers.py:
376
377 2012-01-20  Ojan Vafai  <ojan@chromium.org>
378
379         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
380         https://bugs.webkit.org/show_bug.cgi?id=76748
381
382         Reviewed by Ryosuke Niwa.
383
384         It crawls the whole subtree and then doesn't use the data. Cutting this out
385         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
386
387         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
388         (run):
389
390 2012-01-20  Adam Barth  <abarth@webkit.org>
391
392         Another tiny tweak to the garden-o-matic CSS.  This makes things line
393         up slightly nicer when there aren't any failures.
394
395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
396         (#summary):
397
398 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
399
400         run-perf-tests should support --test-results-server option
401         https://bugs.webkit.org/show_bug.cgi?id=76680
402
403         Reviewed by Adam Barth.
404
405         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
406         to be used by perf bots. Also refactor file_uploader as needed.
407
408         * Scripts/webkitpy/common/net/file_uploader.py:
409         (FileUploader.__init__):
410         (FileUploader.upload_single_file):
411         (FileUploader.upload_as_multipart_form_data):
412         (FileUploader):
413         (FileUploader._upload_data):
414         (FileUploader._upload_data.callback):
415         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
416         (JSONResultsGeneratorBase.upload_json_files):
417         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
418         (PerfTestsRunner):
419         (PerfTestsRunner._parse_args):
420         (PerfTestsRunner.run):
421         (PerfTestsRunner._generate_json):
422         (PerfTestsRunner._upload_json):
423         (PerfTestsRunner._run_tests_set):
424         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
425         (create_runner):
426         (test_run_with_upload_json):
427         (test_run_with_upload_json.mock_upload_json):
428         (test_upload_json):
429         (test_upload_json.MockFileUploader):
430         (test_upload_json.MockFileUploader.__init__):
431         (test_upload_json.MockFileUploader.upload_single_file):
432         (test_parse_args):
433
434 2012-01-20  Adam Barth  <abarth@webkit.org>
435
436         The party time image overlaps real content!  This patch makes the
437         image centered vertically.
438
439         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
440         (#onebar.partytime #summary):
441
442 2012-01-19  Ojan Vafai  <ojan@chromium.org>
443
444         Refactor TestExpectationsParser in preparation for caching the results
445         https://bugs.webkit.org/show_bug.cgi?id=76669
446
447         Reviewed by Dimitri Glazkov.
448
449         Make everything private expect for the parse method. 
450         Eventually, we'll need the expectations lines to not be modified
451         outside of TestExpectationsParser so we can cache the results.
452         This makes check-webkit-style of the chromium test_expectations.txt file
453         go from ~17 seconds to ~12 seconds on my Mac Pro.
454
455         This patch is just a refactor in preparation, so no new tests.
456
457         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
458         (TestExpectationEditorTests.make_parsed_expectation_lines):
459         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
460         (TestExpectationParser.parse):
461         (TestExpectationParser):
462         (TestExpectationParser._parse_line):
463         (TestExpectationParser._tokenize):
464         (TestExpectationParser._tokenize_list):
465         (TestExpectationsModel._clear_expectations_for_test):
466         (TestExpectations.__init__):
467         (TestExpectations._add_expectations):
468         (TestExpectations._add_skipped_tests):
469         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
470         (TestExpectationParserTests.test_tokenize_blank):
471         (TestExpectationParserTests.test_tokenize_missing_colon):
472         (TestExpectationParserTests.test_tokenize_extra_colon):
473         (TestExpectationParserTests.test_tokenize_empty_comment):
474         (TestExpectationParserTests.test_tokenize_comment):
475         (TestExpectationParserTests.test_tokenize_missing_equal):
476         (TestExpectationParserTests.test_tokenize_extra_equal):
477         (TestExpectationParserTests.test_tokenize_valid):
478         (TestExpectationParserTests.test_tokenize_valid_with_comment):
479         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
480         (TestExpectationParserTests.test_parse_empty_string):
481         (TestExpectationSerializerTests.assert_round_trip):
482         (TestExpectationSerializerTests.assert_list_round_trip):
483         * Scripts/webkitpy/tool/commands/expectations.py:
484         (OptimizeExpectations.execute):
485         * Scripts/webkitpy/tool/servers/gardeningserver.py:
486         (GardeningExpectationsUpdater.update_expectations):
487
488 2012-01-20  Adam Barth  <abarth@webkit.org>
489
490         Follow-up to previous patch: don't produce NaN when the revision number
491         is missing.
492
493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
495
496 2012-01-20  Adam Barth  <abarth@webkit.org>
497
498         Garden-o-matic should tell me which revisions have been checked by all the bots
499         https://bugs.webkit.org/show_bug.cgi?id=76722
500
501         Reviewed by Dimitri Glazkov.
502
503         This information helps me know when it's safe for me to roll a
504         candidate revision.
505
506         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
507         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
509
510 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
511
512         build-webkit: Don't spit out congratulations message on Ctrl+C
513
514         Reviewed by Andreas Kling.
515
516         * Scripts/build-webkit:
517
518 2012-01-20  Philippe Normand  <pnormand@igalia.com>
519
520         [GTK] Allow extra jhbuild modulesets
521         https://bugs.webkit.org/show_bug.cgi?id=76691
522
523         Reviewed by Gustavo Noronha Silva.
524
525         * gtk/jhbuildrc: Extra modulesets and modules can be added in
526         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
527         env variables respectively. Use comma-separated values. Example:
528         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
529
530 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
531
532         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
533         https://bugs.webkit.org/show_bug.cgi?id=72589
534
535         Reviewed by Martin Robinson.
536
537         Ensure the accessibility infrastructure is available when running
538         the unit tests, otherwise WK2's accessibility tests won't work.
539
540         * Scripts/run-gtk-tests:
541         (TestRunner):
542         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
543         where at-spi2's stuff is located (like at-spi-bus-launcher and
544         at-spi2-registryd).
545         (TestRunner.run): Initialize the accessibility infrastructure.
546
547         * gtk/generate-gtkdoc:
548         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
549
550         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
551
552 2012-01-20  Hayato Ito  <hayato@chromium.org>
553
554         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
555         https://bugs.webkit.org/show_bug.cgi?id=76353
556
557         Reviewed by Hajime Morita.
558
559         Add ShadowRoot.idl, which is enabled only on chromium port since this is
560         under development feature.
561         ShadowRoot.idl contains minimum API so that we can test it.
562         Other APIs should be added on other changes so that we can isolate issues.
563
564         * DumpRenderTree/chromium/TestShell.cpp:
565         (TestShell::TestShell):
566
567 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
568
569         [GTK] GTK's DRT not to log events for already defunct objects
570         https://bugs.webkit.org/show_bug.cgi?id=76620
571
572         Reviewed by Martin Robinson.
573
574         Do not log 'state-change:defunct' events.
575
576         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
577         (printAccessibilityEvent): Early return if a
578         'state-change:defunct' signal is passed.
579         (axObjectEventListener): Pass the signal name and value in
580         separate parameters to printAccessibilityEvent.
581
582 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
583
584         Unreviewed build fix. Wrong variable being used as the cwd for git
585         remote update command.
586
587         * gtk/run-with-jhbuild:
588         (update_jhbuild):
589
590 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
591
592         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
593         https://bugs.webkit.org/show_bug.cgi?id=76585
594
595         Reviewed by Martin Robinson.
596
597         This allows us to specify a minimum version of jhbuild required,
598         while also providing stability against changes done to the master
599         branch, by letting us choose what is the exact version that will
600         be used.
601
602         * gtk/run-with-jhbuild: refactored for more hackability and easier
603         reading
604         (jhbuild_installed): checks whether jhbuild is installed
605         (jhbuild_cloned): checks whether jhbuild has been cloned
606         (jhbuild_at_expected_revision): checks whether jhbuild is at the
607         expected revision
608         (update_jhbuild): brings jhbuild to the expected revision
609         (clone_jhbuild): clones jhbuild
610         (install_jhbuild): build and installs jhbuild
611         (update_webkitgtk_libs): runs update-webkitgtk-libs
612         (ensure_jhbuild): high-level logic to decide whether and which of
613         the steps above are executed
614
615 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
616
617         [WK2] DumpRenderTree converts "file:///" to a path differently
618         https://bugs.webkit.org/show_bug.cgi?id=76653
619
620         Reviewed by John Sullivan.
621
622         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
623         Do print a slash if there are no path components.
624
625 2012-01-19  Eric Seidel  <eric@webkit.org>
626
627         webkit-patch cannot rollout patches without changelog/bug number
628         https://bugs.webkit.org/show_bug.cgi?id=75962
629
630         Reviewed by Adam Barth.
631
632         * Scripts/webkitpy/tool/commands/download.py:
633         (AbstractRolloutPrepCommand._prepare_state):
634         * Scripts/webkitpy/tool/commands/download_unittest.py:
635         (AbstractRolloutPrepCommandTest.test_prepare_state):
636
637 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
638
639         [WK2] fast/url/degenerate-file-base.html fails
640         https://bugs.webkit.org/show_bug.cgi?id=76619
641
642         Reviewed by Adam Roben.
643
644         A URL generated form local path for loading had an extra slash, making document.URL
645         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
646
647         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
648
649 2012-01-18  Ojan Vafai  <ojan@chromium.org>
650
651         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
652         https://bugs.webkit.org/show_bug.cgi?id=76510
653
654         Reviewed by Adam Barth.
655
656         Unlike other style rules, if you get the syntax of the test_expectations.txt
657         file wrong, the layout tests won't run. Also, this check is simple and only
658         slows down committing if you actually modify one of the test_expectations.txt files.
659
660         * Scripts/webkitpy/style/checkers/test_expectations.py:
661         (TestExpectationsChecker.check_test_expectations):
662         (TestExpectationsChecker.check):
663         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
664         (TestExpectationsTestCase.test_check_covers_all_configurations):
665         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
666         (TestExpectationsTestCase):
667         (assert_lines_lint):
668
669 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
670
671         Build fix. Revert an unintentional change to WebKitDriver in r105443.
672
673         * Scripts/webkitpy/layout_tests/port/driver.py:
674         (DriverProxy.__init__):
675
676 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
677
678         remove the duplicated build rules from WebKit.gyp, Tools.gyp
679         https://bugs.webkit.org/show_bug.cgi?id=73384
680
681         Reviewed by Tony Chang.
682
683         This patch removes the no-longer-necessary conditional logic for
684         build_webkit_exes_from_webkit_gyp; we now always build the exes
685         from their own dedicated gyp files.
686
687         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
688
689 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
690
691         make-new-script-test should work with HTTP tests
692         https://bugs.webkit.org/show_bug.cgi?id=76603
693
694         Reviewed by Adam Roben.
695
696         * Scripts/make-new-script-test:
697         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
698         now also creates absolute paths for HTTP.
699
700 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
701
702         Some perf tests time out when ran by run-perf-tests
703         https://bugs.webkit.org/show_bug.cgi?id=76612
704
705         Reviewed by Dirk Pranke and Eric Seidel.
706
707         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
708         Otherwise some tests such as Parser/xml-parser.html will timeout.
709
710         --no-timeout option is currently supported by Chromium and Mac ports.
711
712         * Scripts/webkitpy/layout_tests/port/base.py:
713         (Port.to.create_driver):
714         * Scripts/webkitpy/layout_tests/port/chromium.py:
715         (ChromiumDriver.__init__):
716         (ChromiumDriver._wrapper_options):
717         * Scripts/webkitpy/layout_tests/port/driver.py:
718         (Driver.__init__):
719         (DriverProxy.__init__):
720         * Scripts/webkitpy/layout_tests/port/webkit.py:
721         (WebKitDriver.__init__):
722         (WebKitDriver.cmd_line):
723         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
724         (WebKitDriverTest.test_read_binary_block):
725         (WebKitDriverTest):
726         (WebKitDriverTest.test_no_timeout):
727         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
728         (get_tests_run.RecordingTestDriver.__init__):
729         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
730         (PerfTestsRunner._parse_args):
731         (PerfTestsRunner._run_tests_set):
732         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
733         (create_runner):
734
735 2012-01-19  Ben Wells  <benwells@chromium.org>
736
737         Add support for window.print to chromium DRT
738         https://bugs.webkit.org/show_bug.cgi?id=76479
739
740         When used in a test window.print goes into print mode and then
741         straight out again. This will allow the afterprint event to be
742         tested by having the afterprint event happen before the dump
743         happens.
744
745         Reviewed by Mihai Parparita.
746
747         * DumpRenderTree/chromium/WebViewHost.cpp:
748         (WebViewHost::printPage):
749         * DumpRenderTree/chromium/WebViewHost.h:
750
751 2012-01-18  Enrica Casucci  <enrica@apple.com>
752
753         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
754         https://bugs.webkit.org/show_bug.cgi?id=76588
755         <rdar://problem/9325183>
756
757         Added test.
758         
759         Reviewed by Dan Bernstein.
760
761         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
762         (TestWebKitAPI::TEST):
763
764 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
765
766         [Qt] Do full incremental builds until bots use update-webkit
767
768         Rubber-stamped by Simon Hausmann.
769
770         * Scripts/webkitdirs.pm:
771         (buildQMakeProjects):
772
773 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
774
775         Fix the Qt build
776
777         Unreviewed build fix.
778
779         * Scripts/webkitdirs.pm:
780         (buildQMakeProjects):
781
782 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
783
784         [Qt] Make build-webkit always do safe incremental builds after update-webkit
785
786         When building against Qt5 with GCC we would just run 'make' in the build dir,
787         and rely on the dependency files output by GCC (-MD) to handle dependency
788         tracking, but that fails for special-cases like adding a Q_OBJECT macro
789         to a header.
790
791         To guarantee that an incrmental build will work, we have to run 'make qmake',
792         which we now do on every build-webkit that's followed by a successful run
793         of update-webkit. The reasoning is that update-webkit can result in such
794         potential corner-cases being applied, and since we can't know for sure
795         unless we inspect the diff and account for all the corner cases we assume
796         the worst and always run 'make qmake'.
797
798         After a succesful run of build-webkit we proceed to do just 'make' for any
799         subsequent runs, since we assume that the developer knows what kind of
800         changes he/she is doing, and when a 'make qmake' is needed.
801
802         Reviewed by Simon Hausmann.
803
804         * Scripts/update-webkit:
805         * Scripts/webkitdirs.pm:
806         (determineCurrentSVNRevision):
807         (currentSVNRevision):
808         (buildQMakeProjects):
809         * qmake/mkspecs/features/default_post.prf:
810
811 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
812
813         run-perf-tests should support Skipped list
814         https://bugs.webkit.org/show_bug.cgi?id=76594
815
816         Reviewed by Adam Barth.
817
818         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
819
820         * Scripts/webkitpy/layout_tests/port/base.py:
821         (Port.perf_tests_dir):
822         (Port.skipped_perf_tests):
823         (Port.skips_perf_test):
824         (Port.relative_perf_test_filename):
825         * Scripts/webkitpy/layout_tests/port/test.py:
826         (TestPort.perf_tests_dir):
827         * Scripts/webkitpy/layout_tests/port/webkit.py:
828         (WebKitPort._expectations_from_skipped_files):
829         (WebKitPort):
830         (WebKitPort.skipped_layout_tests):
831         (WebKitPort.skipped_perf_tests):
832         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
833         (PerfTestsRunner._collect_tests):
834         (PerfTestsRunner.run):
835         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
836         (test_run_test_set_with_json_output):
837         (test_run_test_set_with_json_source):
838         (test_collect_tests_with_skipped_list):
839         (test_collect_tests_with_skipped_list.add_file):
840
841 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
842
843         Fix path to chromium_src_dir introduced in previous change.
844
845         Unreviewed, build fix.
846
847         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
848
849 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
850
851         Need infrastructure to test Content-Disposition filename encoding support
852         https://bugs.webkit.org/show_bug.cgi?id=76572
853         <rdar://problem/6421825>
854
855         Reviewed by Sam Weinig.
856
857         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
858
859         WebKitTestRunner does not have a policy delegate yet, bug 42546.
860
861         * DumpRenderTree/mac/PolicyDelegate.mm:
862         (dispositionTypeFromContentDispositionHeader):
863         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
864
865 2012-01-18  Ojan Vafai  <ojan@chromium.org>
866
867         Fix tests from http://trac.webkit.org/changeset/105332.
868
869         The code assumed that if you passed an options object with a configuration
870         attribute that it would have a valid value. A bunch of the testing mocks
871         do things like having a configuration value of None.
872
873         * Scripts/webkitpy/layout_tests/port/base.py:
874         (Port.__init__):
875
876 2012-01-18  Ojan Vafai  <ojan@chromium.org>
877
878         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
879         https://bugs.webkit.org/show_bug.cgi?id=76576
880
881         Reviewed by Adam Barth.
882
883         Avoid calling default_configuration in base.py. We don't need it for
884         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
885         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
886         from common.executive.
887
888         At some point someone should probably look into why that call is so slow
889         since it's on the critical path for run-webkit-tests and build-webkit startup.
890
891         * Scripts/webkitpy/layout_tests/port/base.py:
892         (Port.__init__):
893         * Scripts/webkitpy/style/checkers/test_expectations.py:
894         (TestExpectationsChecker._determine_port_from_exepectations_path):
895
896 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
897
898         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
899         https://bugs.webkit.org/show_bug.cgi?id=76505
900
901         Reviewed by Tony Chang.
902
903         Update chromium build script to use All.gyp instead of WebKit.gyp
904
905         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
906         * Scripts/webkitdirs.pm:
907
908 2012-01-18  Sam Weinig  <sam@webkit.org>
909
910         Don’t hardcode the path to ‘make‘.
911
912         Reviewed by Dan Bernstein.
913
914         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
915
916 2012-01-18  Joshua Bell  <jsbell@chromium.org>
917
918         Adding myself to committers.py
919         https://bugs.webkit.org/show_bug.cgi?id=76569
920
921         Unreviewed.
922
923         * Scripts/webkitpy/common/config/committers.py:
924
925 2012-01-18  Adam Barth  <abarth@webkit.org>
926
927         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
928         https://bugs.webkit.org/show_bug.cgi?id=76567
929
930         Reviewed by Eric Seidel.
931
932         Current the AppleMac port has slightly more failures than we allow on
933         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
934         which should hopefully let the mac-ews run to completion.  Once
935         AppleMac has fewer failures, we can lower the cap again.
936
937         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
938         (LayoutTestResultsReaderTest.test_layout_test_results):
939         * Scripts/webkitpy/tool/steps/runtests.py:
940         (RunTests):
941         * Scripts/webkitpy/tool/steps/steps_unittest.py:
942
943 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
944
945         Provide access to user's list of preferred languages
946         https://bugs.webkit.org/show_bug.cgi?id=76138
947
948         Reviewed by Alexey Proskuryakov.
949
950         * GNUmakefile.am: Add JSInternalsCustom.cpp.
951
952 2012-01-18  Adam Barth  <abarth@webkit.org>
953
954         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
955         configurations.
956
957         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
958         (ChromiumLinuxPort.__init__):
959
960 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
961
962         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
963         https://bugs.webkit.org/show_bug.cgi?id=73460
964
965         Reviewed by Chris Fleizach.
966
967         * DumpRenderTree/AccessibilityUIElement.h:
968         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
969         (AccessibilityUIElement::AccessibilityUIElement):
970         (AccessibilityUIElement::scrollToMakeVisibleCallback):
971         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
972         (AccessibilityUIElement::scrollToGlobalPointCallback):
973         * DumpRenderTree/chromium/AccessibilityUIElement.h:
974         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
975         (AccessibilityUIElement::scrollToMakeVisible):
976         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
977         (AccessibilityUIElement::scrollToGlobalPoint):
978         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
979         (AccessibilityUIElement::scrollToMakeVisible):
980         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
981         (AccessibilityUIElement::scrollToGlobalPoint):
982         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
983         (AccessibilityUIElement::scrollToMakeVisible):
984         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
985         (AccessibilityUIElement::scrollToGlobalPoint):
986
987 2012-01-17  Enrica Casucci  <enrica@apple.com>
988
989         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
990         https://bugs.webkit.org/show_bug.cgi?id=76490
991         <rdar://problem/9460733>
992
993         Added TestWebKitAPI test.
994         
995         Reviewed by Dan Bernstein.
996
997         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
998         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
999         changeAttributes to the WebView.
1000         
1001 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
1002
1003         [Qt] Consolidate layout test crash logging
1004         https://bugs.webkit.org/show_bug.cgi?id=75088
1005
1006         Reviewed by Simon Hausmann.
1007
1008         Move backtrace generating logic into WTFReportBacktrace
1009         and add a way to deinstall signal handlers if we know
1010         that we have already printed the backtrace.
1011
1012         * DumpRenderTree/qt/main.cpp:
1013         (crashHandler):
1014         (setupSignalHandlers):
1015         (WTFCrashHook):
1016         (main):
1017         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1018         (WTR::crashHandler):
1019         (WTR::setupSignalHandlers):
1020         (WTR::crashHook):
1021         (WTR::InjectedBundle::platformInitialize):
1022
1023 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
1024
1025         Unreviewed build fix after r105256.
1026
1027         There was a cyclic dependency between self._port and self._host assigments.
1028
1029         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1030         (PerfTestsRunner.__init__):
1031
1032 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1033
1034         Add new watchlist rule for the Qt build system
1035
1036         Reviewed by Simon Hausmann.
1037
1038         * Scripts/webkitpy/common/config/watchlist:
1039
1040 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1041
1042         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
1043
1044         Reviewed by Simon Hausmann.
1045
1046         * Tools.pro:
1047
1048 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1049
1050         [Qt] Allow building only a subset of the WebKit sub-projects
1051
1052         Fixes build-jsc, broken in r104825.
1053
1054         We no longer need the intermediate buildQMakeQtProject(), as we're the
1055         only port using qmake, and buildQMakeProject is now highly Qt specific.
1056
1057         <http://webkit.org/b/76179>
1058
1059         Reviewed by Simon Hausmann.
1060
1061         * Scripts/build-jsc:
1062         * Scripts/build-webkit:
1063         * Scripts/webkitdirs.pm:
1064         (buildQMakeProjects):
1065
1066 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
1067
1068         run-perf-tests should generate a json file that summaries the result
1069         https://bugs.webkit.org/show_bug.cgi?id=76504
1070
1071         Reviewed by Adam Barth.
1072
1073         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
1074         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
1075         another json file to be merged into the generated json file.
1076
1077         Also fixed a bug that --build wasn't set by default.
1078
1079         * Scripts/webkitpy/layout_tests/port/test.py:
1080         (TestPort.webkit_base):
1081         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1082         (PerfTestsRunner.__init__):
1083         (PerfTestsRunner):
1084         (PerfTestsRunner._parse_args):
1085         (PerfTestsRunner.run):
1086         (PerfTestsRunner._generate_json_if_specified):
1087         (PerfTestsRunner._process_chromium_style_test_result):
1088         (PerfTestsRunner._process_parser_test_result):
1089         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1090         (MainTest):
1091         (create_runner):
1092         (test_run_test_set):
1093         (test_run_test_set_for_parser_tests):
1094         (test_run_test_set_with_summary_json):
1095         (test_collect_tests):
1096         (test_parse_args):
1097
1098 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
1099
1100         Unreviewed, rolling out r105244.
1101         http://trac.webkit.org/changeset/105244
1102         https://bugs.webkit.org/show_bug.cgi?id=76518
1103
1104         broke Chromium Mac (Requested by rolandsteiner on #webkit).
1105
1106         * DumpRenderTree/AccessibilityUIElement.h:
1107         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1108         (AccessibilityUIElement::AccessibilityUIElement):
1109         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1110         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1111         (AccessibilityUIElement::removeSelection):
1112         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1113         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1114         (AccessibilityUIElement::removeSelection):
1115
1116 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
1117
1118         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
1119         https://bugs.webkit.org/show_bug.cgi?id=73460
1120
1121         Reviewed by Chris Fleizach.
1122
1123         * DumpRenderTree/AccessibilityUIElement.h:
1124         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1125         (AccessibilityUIElement::AccessibilityUIElement):
1126         (AccessibilityUIElement::scrollToMakeVisibleCallback):
1127         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
1128         (AccessibilityUIElement::scrollToGlobalPointCallback):
1129         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1130         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1131         (AccessibilityUIElement::scrollToMakeVisible):
1132         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1133         (AccessibilityUIElement::scrollToGlobalPoint):
1134         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1135         (AccessibilityUIElement::scrollToMakeVisible):
1136         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1137         (AccessibilityUIElement::scrollToGlobalPoint):
1138         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1139         (AccessibilityUIElement::scrollToMakeVisible):
1140         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1141         (AccessibilityUIElement::scrollToGlobalPoint):
1142
1143 2012-01-17  Adam Barth  <abarth@webkit.org>
1144
1145         Enable tests on the mac-ews
1146         https://bugs.webkit.org/show_bug.cgi?id=76502
1147
1148         Reviewed by Simon Fraser.
1149
1150         Apple now has five machines running the mac-ews.  Lucas Forschler has
1151         asked that we try enabling tests to see if we have enough bandwidth.
1152
1153         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1154         (MacEWS):
1155
1156 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
1157
1158         Add a check-webkit-style exception for GDBInterface.cpp
1159         https://bugs.webkit.org/show_bug.cgi?id=76187
1160
1161         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
1162         that it does not fail the style check.
1163
1164         Reviewed by Martin Robinson.
1165
1166         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
1167         readability/naming tests on
1168         Source/JavaScriptCore/jit/GDBInterface.cpp.
1169         * Scripts/webkitpy/style/checker_unittest.py:
1170         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
1171         the above exception.
1172
1173 2012-01-17  Hajime Morrita  <morrita@chromium.org>
1174
1175         https://bugs.webkit.org/show_bug.cgi?id=76245
1176         [Mac][DRT] should allow query string for the file URL.
1177
1178         Reviewed by Tony Chang.
1179
1180         Taught DRT about file:// as a url instead of a file path.
1181         We are now able to use a path file:///foo/bar.html?baz as a url
1182         with which DRT opens "/foo/bar.html" with "baz" as a query string.
1183
1184         * DumpRenderTree/mac/DumpRenderTree.mm:
1185         (runTest):
1186
1187 2012-01-17  Ojan Vafai  <ojan@chromium.org>
1188
1189         Check style on test_expectations.txt files before commit
1190         https://bugs.webkit.org/show_bug.cgi?id=76484
1191
1192         Reviewed by Adam Barth.
1193
1194         Unlike other style rules, if you get the syntax of the test_expectations.txt
1195         file wrong, the layout tests won't run. Also, this check is simple and only
1196         slows down committing if you actually modify one of the test_expectations.txt files.
1197
1198         * Scripts/webkitpy/tool/steps/commit.py:
1199         (Commit._check_test_expectations):
1200         (Commit.run):
1201         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
1202         (CommitTest):
1203         (CommitTest.test_check_test_expectations):
1204
1205 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1206
1207         [Qt] Debug build fails with debug qt5
1208         https://bugs.webkit.org/show_bug.cgi?id=76463
1209
1210         Reviewed by Simon Hausmann.
1211
1212         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
1213
1214         * QtTestBrowser/cookiejar.h:
1215
1216 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1217
1218         webkitpy: fix json import on linux
1219         https://bugs.webkit.org/show_bug.cgi?id=76481
1220
1221         Reviewed by Adam Barth.
1222
1223         For some reason, the version of simplejson autoinstalled on my linux
1224         box seems to be broken. We should really only be using
1225         simplejson if json isn't available anyway, so this change looks
1226         for json first.
1227
1228         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1229         (JSONGeneratorTest.test_test_timings_trie):
1230
1231 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1232
1233         Fix failures in test-webkitpy caused by r105177.
1234
1235         Unreviewed, build fix.
1236
1237         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1238         (ChromiumLinuxPort._determine_driver_path_statically):
1239         (ChromiumLinuxPort._static_build_path):
1240
1241 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1242
1243         webkitpy: make PortFactory.get() be fully data-driven
1244         https://bugs.webkit.org/show_bug.cgi?id=76360
1245
1246         Reviewed by Eric Seidel.
1247
1248         Refactor PortFactory.get() to be fully data-driven.
1249
1250         * Scripts/webkitpy/layout_tests/port/factory.py:
1251         (PortFactory):
1252         (PortFactory._default_port):
1253         (PortFactory.get):
1254         (PortFactory.get.in):
1255         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1256         (FactoryTest.assert_port):
1257
1258 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1259
1260         webkitpy: add determine_full_port_name(), clean up port.__init__()
1261         https://bugs.webkit.org/show_bug.cgi?id=76357
1262
1263         Reviewed by Adam Barth.
1264
1265         Each Port class is now required to implement a 'port_name' field
1266         that will match the start of all ports constructed by this class and
1267         a 'determine_full_port_name' field that will make the port
1268         fully-qualified.
1269
1270         * Scripts/webkitpy/layout_tests/port/apple.py:
1271         (ApplePort.__init__):
1272         * Scripts/webkitpy/layout_tests/port/base.py:
1273         (Port):
1274         (Port.determine_port_name):
1275         (Port.__init__):
1276         * Scripts/webkitpy/layout_tests/port/chromium.py:
1277         (ChromiumPort.for):
1278         (ChromiumPort.__init__):
1279         (ChromiumPort):
1280         (ChromiumPort._chromium_base_dir):
1281         (ChromiumPort.path_from_chromium_base):
1282         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1283         (ChromiumGpuLinuxPort):
1284         (ChromiumGpuLinuxPort.__init__):
1285         (ChromiumGpuMacPort):
1286         (ChromiumGpuMacPort.__init__):
1287         (ChromiumGpuWinPort):
1288         (ChromiumGpuWinPort.__init__):
1289         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1290         (ChromiumLinuxPort):
1291         (ChromiumLinuxPort.determine_port_name):
1292         (ChromiumLinuxPort.__init__):
1293         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1294         (ChromiumMacPort):
1295         (ChromiumMacPort.determine_port_name):
1296         (ChromiumMacPort.__init__):
1297         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1298         (ChromiumWinPort):
1299         (ChromiumWinPort.determine_port_name):
1300         (ChromiumWinPort.__init__):
1301         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1302         (DryRunPort):
1303         (DryRunPort.determine_port_name):
1304         (DryRunPort.__init__):
1305         * Scripts/webkitpy/layout_tests/port/efl.py:
1306         (EflPort):
1307         * Scripts/webkitpy/layout_tests/port/factory.py:
1308         (PortFactory):
1309         (PortFactory._default_port):
1310         (PortFactory.get):
1311         (PortFactory.get.in):
1312         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1313         (FactoryTest.assert_port):
1314         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1315         (GoogleChromeLinux32Port):
1316         (GoogleChromeLinux32Port.determine_port_name):
1317         (GoogleChromeLinux64Port):
1318         (GoogleChromeLinux64Port.determine_port_name):
1319         (GoogleChromeMacPort):
1320         (GoogleChromeMacPort.determine_port_name):
1321         (GoogleChromeWinPort):
1322         (GoogleChromeWinPort.determine_port_name):
1323         * Scripts/webkitpy/layout_tests/port/gtk.py:
1324         (GtkPort):
1325         * Scripts/webkitpy/layout_tests/port/mac.py:
1326         (MacPort):
1327         (MacPort.determine_port_name):
1328         (MacPort.__init__):
1329         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1330         (test_versions):
1331         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1332         (MockDRTPort):
1333         (MockDRTPort.determine_port_name):
1334         (MockDRTPort.__init__):
1335         (MockDRT):
1336         (MockDRT.determine_port_name):
1337         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1338         (PortTestCase.make_port):
1339         * Scripts/webkitpy/layout_tests/port/qt.py:
1340         (QtPort):
1341         (QtPort.determine_port_name):
1342         (QtPort.__init__):
1343         * Scripts/webkitpy/layout_tests/port/test.py:
1344         (TestPort):
1345         (TestPort.determine_port_name):
1346         (TestPort.__init__):
1347         * Scripts/webkitpy/layout_tests/port/webkit.py:
1348         (WebKitPort.__init__):
1349         * Scripts/webkitpy/layout_tests/port/win.py:
1350         (WinPort):
1351         (WinPort.determine_port_name):
1352         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1353         (get_test_baselines.AllPlatformsPort.__init__):
1354         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1355         (get_test_config.TestMacPort):
1356         (get_test_config):
1357
1358 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1359
1360         webkitpy: clean up port code in preparation for static port names
1361         https://bugs.webkit.org/show_bug.cgi?id=76356
1362
1363         Reviewed by Adam Barth.
1364
1365         To fix bug 76215 and be able to determine appropriate port names
1366         in webkitpy without actually constructing Port objects, we need
1367         to shuffle some logic in the chromium ports to be able to figure
1368         out whether we built DRT in 32 or 64-bit mode.
1369
1370         * Scripts/webkitpy/layout_tests/port/chromium.py:
1371         (ChromiumPort):
1372         (ChromiumPort._chromium_base_dir):
1373         (ChromiumPort.__init__):
1374         (ChromiumPort.path_from_chromium_base):
1375         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1376         (ChromiumLinuxPort):
1377         (ChromiumLinuxPort._determine_driver_path_statically):
1378         (ChromiumLinuxPort._static_build_path):
1379         (ChromiumLinuxPort._determine_architecture):
1380         (ChromiumLinuxPort.__init__):
1381         (ChromiumLinuxPort._build_path):
1382
1383 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
1384
1385         Do not remove pixel failures for ref tests.
1386         https://bugs.webkit.org/show_bug.cgi?id=76243
1387
1388         Reviewed by Tony Chang.
1389
1390         'NRWT --no-pixel-tests' complains when reftests are expected to
1391         be image mismatch.
1392
1393         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1394         (Manager._update_summary_with_result):
1395         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1396         (is_reftest_failure):
1397         (determine_result_type):
1398
1399 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
1400
1401         REGRESSION(r81225): ORWT should ignore reftests
1402         https://bugs.webkit.org/show_bug.cgi?id=67936
1403
1404         Reviewed by Csaba Osztrogonác.
1405
1406         * Scripts/old-run-webkit-tests:
1407         (isUsedInReftest): $filename should be the first parameter
1408         (findTestsToRun): run test if it isn't reftest
1409
1410 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
1411
1412         Unreviewed. Fix python unit test I broke with r105142
1413
1414         * Scripts/webkitpy/common/config/ports_unittest.py:
1415         (WebKitPortTest.test_gtk_port):
1416
1417 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1418
1419         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
1420
1421         Qt 5 no longer has that flag.
1422
1423         Reviewed by Simon Hausmann.
1424
1425         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1426         (MiniBrowserApplication::notify):
1427
1428 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1429
1430         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
1431         https://bugs.webkit.org/show_bug.cgi?id=75857
1432
1433         Reviewed by Adam Barth.
1434
1435         * Scripts/webkitdirs.pm:
1436         (buildAutotoolsProject): move cleaning the build to happen early,
1437         and handle --update-gtk right after that
1438         * Scripts/webkitpy/common/config/ports.py:
1439         (GtkPort.build_webkit_command): pass --update-gtk as an option to
1440         build-webkit, so that it is used in the EWS
1441
1442 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1443
1444         [Qt] Don't add _debug postfix to targets when building debug only
1445
1446         Reviewed by Simon Hausmann.
1447
1448         * qmake/mkspecs/features/default_post.prf:
1449         * qmake/mkspecs/features/functions.prf:
1450
1451 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1452
1453         [Qt] Add more files to project-files for easier navigation in Qt Creator
1454
1455         Reviewed by Simon Hausmann.
1456
1457         * Tools.pro:
1458         * qmake/config.tests/README: Added.
1459
1460 2012-01-17  Philippe Normand  <pnormand@igalia.com>
1461
1462         [GTK] fast/dom/constructed-objects-prototypes.html fails
1463         https://bugs.webkit.org/show_bug.cgi?id=75432
1464
1465         Reviewed by Martin Robinson.
1466
1467         * Scripts/build-webkit: Enable video-track in GTK.
1468
1469 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
1470
1471         Add toyoshim as a committer.
1472         https://bugs.webkit.org/show_bug.cgi?id=76390
1473
1474         Reviewed by Hajime Morita.
1475
1476         * Scripts/webkitpy/common/config/committers.py:
1477
1478 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
1479
1480         [WinCairo] Build fix after r104155. Several debug targets were not
1481         properly including the '*Common' property sheets.
1482
1483         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
1484         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
1485         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
1486         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
1487         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
1488
1489 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
1490
1491         REGRESSION(r105072): It broke committers_unittest.py
1492         https://bugs.webkit.org/show_bug.cgi?id=76396
1493
1494         Reviewed by Adam Barth.
1495
1496         * Scripts/webkitpy/common/config/committers_unittest.py:
1497         (CommittersTest._assert_fuzz_match): It should handle more names.
1498         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
1499
1500 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
1501
1502         [GTK] Include gtk+3 in the jhbuild modules
1503         https://bugs.webkit.org/show_bug.cgi?id=76284
1504
1505         Reviewed by Philippe Normand.
1506
1507         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
1508
1509 2012-01-16  Dan Winship  <danw@gnome.org>
1510
1511         Add myself as a committer
1512
1513         Unreviewed
1514
1515         * Scripts/webkitpy/common/config/committers.py:
1516
1517 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
1518
1519         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
1520
1521         Some recent versions of a few Linux distributions have started passing
1522         --as-needed and --no-copy-dt-needed-entries by default to the linker,
1523         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
1524         needed a few symbols from libjavascriptcore_efl.so.
1525
1526         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
1527         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
1528         libraries are searched in the right order by the linker.
1529
1530 2012-01-16  Philippe Normand  <pnormand@igalia.com>
1531
1532         [GTK] set audio resources path in NRTW
1533         https://bugs.webkit.org/show_bug.cgi?id=76380
1534
1535         Reviewed by Martin Robinson.
1536
1537         * Scripts/webkitpy/layout_tests/port/gtk.py:
1538         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
1539         the uninstalled audio resources are used during webaudio tests.
1540
1541 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1542
1543         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
1544         https://bugs.webkit.org/show_bug.cgi?id=76369
1545
1546         Reviewed by Xan Lopez.
1547
1548         If there's an installed version of webkit and there are new
1549         symbols in the build tree, gtkdoc-scanobj fails due to undefined
1550         references, because the env ldflags are given before the local
1551         ones.
1552
1553         * gtk/gtkdoc.py:
1554         (GTKDoc._run_gtkdoc_scangobj):
1555
1556 2012-01-15  Pablo Flouret  <pablof@motorola.com>
1557
1558         Fix compilation errors on build-webkit --debug --no-video on mac.
1559         https://bugs.webkit.org/show_bug.cgi?id=75867
1560
1561         Reviewed by Philippe Normand.
1562
1563         Add --[no-]video-track to build-webkit, since video track feature
1564         depends on video.
1565
1566         * Scripts/build-webkit:
1567
1568 2012-01-14  James Robinson  <jamesr@chromium.org>
1569
1570         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
1571         https://bugs.webkit.org/show_bug.cgi?id=76313
1572
1573         Reviewed by Adam Barth.
1574
1575         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
1576
1577         * Scripts/run-chromium-webkit-unit-tests:
1578
1579 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1580
1581         Unreviewed, rolling out r105017.
1582         http://trac.webkit.org/changeset/105017
1583         https://bugs.webkit.org/show_bug.cgi?id=76333
1584
1585         broke the build (Requested by philn-tp on #webkit).
1586
1587         * gtk/jhbuild.modules:
1588
1589 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
1590
1591         [GTK] Include gtk+3 in the jhbuild modules
1592         https://bugs.webkit.org/show_bug.cgi?id=76284
1593
1594         Reviewed by Philippe Normand.
1595
1596         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
1597
1598 2012-01-13  Adam Barth  <abarth@webkit.org>
1599
1600         Remove --dry-run support from webkit-patch
1601         https://bugs.webkit.org/show_bug.cgi?id=76300
1602
1603         Reviewed by Dirk Pranke.
1604
1605         This is the rest of the patch from Bug 76300.  I landed it separtely
1606         because main.py had some stray conflict markers that I needed to clean
1607         up first.
1608
1609         * Scripts/webkitpy/test/main.py:
1610         (Tester.parse_args):
1611         (Tester._run_tests):
1612
1613 2012-01-13  Adam Barth  <abarth@webkit.org>
1614
1615         test-webkitpy does not run
1616         https://bugs.webkit.org/show_bug.cgi?id=76318
1617
1618         Unreviewed.
1619
1620         Looks like some conflict markers got left in the file.
1621
1622         * Scripts/webkitpy/test/main.py:
1623         (Tester.run):
1624
1625 2012-01-13  Adam Barth  <abarth@webkit.org>
1626
1627         Remove --dry-run support from webkit-patch
1628         https://bugs.webkit.org/show_bug.cgi?id=76300
1629
1630         Reviewed by Dirk Pranke.
1631
1632         We don't use this functionality for anything, and it doesn't really
1633         work.  Someone in #webkit tried using it and and got sad/confused.  We
1634         should just remove it.
1635
1636         * Scripts/webkitpy/common/checkout/scm/git.py:
1637         (Git.push_local_commits_to_server):
1638         * Scripts/webkitpy/common/checkout/scm/scm.py:
1639         (SCM.__init__):
1640         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1641         (_shared_test_commit_with_message):
1642         (GitSVNTest.test_commit_text_parsing):
1643         * Scripts/webkitpy/common/checkout/scm/svn.py:
1644         (SVN.commit_with_message):
1645         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1646         (Bugzilla.__init__):
1647         (Bugzilla.quips):
1648         (Bugzilla.authenticate):
1649         (Bugzilla.add_attachment_to_bug):
1650         (Bugzilla.add_patch_to_bug):
1651         (Bugzilla.create_bug):
1652         (Bugzilla.clear_attachment_flags):
1653         (Bugzilla.set_flag_on_attachment):
1654         (Bugzilla.obsolete_attachment):
1655         (Bugzilla.add_cc_to_bug):
1656         (Bugzilla.post_comment_to_bug):
1657         (Bugzilla.close_bug_as_fixed):
1658         (Bugzilla.reassign_bug):
1659         (reopen_bug):
1660         * Scripts/webkitpy/test/main.py:
1661         (Tester.parse_args):
1662         (Tester.run_tests):
1663
1664 2012-01-13  David Levin  <levin@chromium.org>
1665
1666         check-webkit-style: should encourage the use of Own* classes for Windows DC.
1667         https://bugs.webkit.org/show_bug.cgi?id=76227
1668
1669         Reviewed by Dirk Pranke.
1670
1671         * Scripts/webkitpy/style/checkers/cpp.py:
1672         (check_for_leaky_patterns): The new check.
1673         (process_line): Added a call to the new check.
1674         (CppChecker): Added the new error type.
1675         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1676         (CppStyleTestBase):
1677         (CppStyleTestBase.perform_leaky_pattern_check):
1678         The check for only leaky pattern errors.
1679         (LeakyPatternTest): Test cases.
1680
1681 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1682
1683         test-webkitpy: clean up handling of test directories, QueueStatusServer
1684         https://bugs.webkit.org/show_bug.cgi?id=76238
1685
1686         Reviewed by Adam Barth.
1687
1688         This patch cleans up a bunch of hacks related to how we find all
1689         of the python unit tests and set up the sys.path variable in
1690         test-webkitpy.
1691
1692         This patch changes how test-webkitpy works slightly in that we
1693         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
1694         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
1695         This greatly simplifies the mapping of paths to module names and
1696         appears to have no significant performance impact or other drawbacks.
1697
1698         There are other ways that we could remove all of the hacks and
1699         still have a more flexible mapping of paths to module names, but
1700         the ones I've thought of so far add a decent amount of complexity to
1701         the implementation and don't seem to buy us much.
1702         
1703         * QueueStatusServer/__init__.py:
1704         * Scripts/test-webkitpy:
1705         * Scripts/webkitpy/test/main.py:
1706         (Tester._modules_from_paths):
1707         (Tester._is_module):
1708
1709 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1710
1711         test-webkitpy: should support classes and individual test names as well as modules
1712         https://bugs.webkit.org/show_bug.cgi?id=76233
1713
1714         Reviewed by Adam Barth.
1715
1716         The default unittest.main() supports a list of individual
1717         TestCase classes or individual tests as well as modules. This
1718         change adds support for the same to test-webkitpy, so now you
1719         can say
1720
1721           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
1722
1723         and
1724
1725           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
1726
1727         in addition to
1728
1729           % test-wekbitpy webkitpy.test.cat_unittest
1730
1731         * Scripts/test-webkitpy:
1732         * Scripts/webkitpy/test/cat_unittest.py:
1733         * Scripts/webkitpy/test/main.py:
1734         (Tester.parse_args):
1735         (Tester.run):
1736         (Tester):
1737         (Tester._find_modules):
1738         (Tester._exclude):
1739         (Tester._run_tests):
1740         (Tester._is_module):
1741         (Tester._log_exception):
1742
1743 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1744
1745         test-webkitpy: add basic code coverage support
1746         https://bugs.webkit.org/show_bug.cgi?id=76201
1747
1748         Reviewed by Adam Barth.
1749
1750         This test adds basic code coverage support to test-webkitpy; if
1751         you pass the -c flag, we will generate a new coverage file. We
1752         can start simply with this and add more features as necessary.
1753
1754         This patch requires coverage to be already installed on the
1755         machine. I am not auto-installing this for now.
1756
1757         * Scripts/webkitpy/test/main.py:
1758         (Tester.parse_args):
1759         (Tester.run_tests):
1760
1761 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1762
1763         StatusBubbleTest.test_build_bubble is failing
1764         https://bugs.webkit.org/show_bug.cgi?id=76222
1765
1766         Reviewed by Adam Barth.
1767
1768         * QueueStatusServer/handlers/statusbubble_unittest.py:
1769         (StatusBubbleTest.test_build_bubble):
1770
1771 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1772
1773         nrwt should use multiple http shards
1774         https://bugs.webkit.org/show_bug.cgi?id=75958
1775
1776         Add --max-locked-shards option to the nrwt for manual set
1777         the maximum number of the locked shards
1778
1779         Reviewed by Dirk Pranke.
1780
1781         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1782         (Manager._max_locked_shards):
1783         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1784         (ShardingTests.get_shards):
1785         (ShardingTests.test_multiple_locked_shards):
1786         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1787         (parse_args):
1788
1789 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1790
1791         prepare-ChangeLog: Look for a text editor in a few more variables.
1792         https://bugs.webkit.org/show_bug.cgi?id=76289
1793
1794         Reviewed by Ryosuke Niwa.
1795
1796         A text editor was looked for only in the CHANGE_LOG_EDITOR and
1797         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
1798         to the OS X-specific open(1) command.
1799
1800         As there does not seem to be a common way of looking for a text editor
1801         among the scripts in Tools/Scripts right now, just look at $VISUAL and
1802         $EDITOR (set much more often than the other variables in Unix systems)
1803         before falling back to open(1).
1804
1805         * Scripts/prepare-ChangeLog:
1806         (openChangeLogs):
1807
1808 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
1809
1810         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
1811         https://bugs.webkit.org/show_bug.cgi?id=76269
1812
1813         Reviewed by Martin Robinson.
1814
1815         * gtk/gtkdoc.py:
1816         (GTKDoc._run_gtkdoc_scangobj):
1817
1818 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1819
1820         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
1821         https://bugs.webkit.org/show_bug.cgi?id=76247
1822
1823         Reviewed by Kenneth Rohde Christiansen.
1824
1825         * WebKitTestRunner/TestController.cpp:
1826         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
1827
1828 2012-01-13  Hajime Morrita  <morrita@chromium.org>
1829
1830         [Mac][DRT] Should support --no-timeout
1831         https://bugs.webkit.org/show_bug.cgi?id=76242
1832
1833         Reviewed by Darin Adler.
1834
1835         * DumpRenderTree/mac/DumpRenderTree.mm:
1836         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
1837         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
1838         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
1839         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1840         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1841         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
1842
1843 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
1844
1845         Mitigate scrollbar differences when running pixel tests
1846         https://bugs.webkit.org/show_bug.cgi?id=67217
1847
1848         Reviewed by Dan Bernstein.
1849         
1850         Enable mock scrollbars by default for tests.
1851
1852         * DumpRenderTree/mac/DumpRenderTree.mm:
1853         (resetDefaultsToConsistentValues):
1854         * WebKitTestRunner/TestController.cpp:
1855         (WTR::TestController::resetStateToConsistentValues):
1856
1857 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
1858
1859         Need a script to run tests in PerformanceTests
1860         https://bugs.webkit.org/show_bug.cgi?id=76132
1861
1862         Reviewed by Adam Barth.
1863
1864         Add run-perf-tests to run performance tests using parser/resources/runner.js.
1865         Unfortunately, there isn't an easy way of telling which test uses which format
1866         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
1867
1868         All test outputs are re-formatted to match Chromium perf-bot style.
1869
1870         * Scripts/run-inspector-perf-tests.py:
1871         * Scripts/run-perf-tests: Added.
1872         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1873         (PerfTestsRunner):
1874         (PerfTestsRunner.__init__):
1875         (PerfTestsRunner._collect_tests):
1876         (PerfTestsRunner.run):
1877         (PerfTestsRunner._print_status):
1878         (PerfTestsRunner._run_tests_set):
1879         (PerfTestsRunner._process_chromium_style_test_result):
1880         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
1881         (PerfTestsRunner._process_parser_test_result):
1882         (PerfTestsRunner._run_single_test):
1883         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1884         (MainTest.TestDriver.run_test):
1885         (create_runner):
1886         (run_test):
1887         (test_run_test_set):
1888         (test_run_test_set_for_parser_tests):
1889         (test_collect_tests):
1890
1891 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1892
1893         webkitpy: clean up port unit tests in preparation for making port_name mandatory
1894         https://bugs.webkit.org/show_bug.cgi?id=76123
1895
1896         Reviewed by Adam Barth.
1897
1898         This change updates the unit tests to be more consistent in how
1899         ports are created, in preparation for making port_name a
1900         mandatory parameter to the constructor and removing any version
1901         interpretation from it.
1902
1903         There should be no functional changes in this patch, but some
1904         tests that are no longer relevant have been removed or reworked.
1905
1906         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1907         (PortTest.test_get_option__default):
1908         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1909         (ChromiumLinuxPortTest):
1910         (ChromiumLinuxPortTest.assert_architecture):
1911         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1912         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1913         (ChromiumMacPortTest):
1914         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1915         (ChromiumPortTest):
1916         (ChromiumPortTest.test_all_test_configurations):
1917         (ChromiumPortTest.TestMacPort.__init__):
1918         (ChromiumPortTest.TestLinuxPort.__init__):
1919         (ChromiumPortTest.TestWinPort.__init__):
1920         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1921         (ChromiumWinTest):
1922         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1923         (EflPortTest):
1924         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1925         (GtkPortTest):
1926         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1927         (MacTest):
1928         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1929         (MockDRTPortTest):
1930         (MockDRTPortTest.make_port):
1931         * Scripts/webkitpy/layout_tests/port/qt.py:
1932         (QtPort._port_flag_for_scripts):
1933         (QtPort.__init__):
1934         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1935         (QtPortTest):
1936         (QtPortTest._assert_search_path):
1937         (QtPortTest.test_baseline_search_path):
1938         (QtPortTest.test_operating_system):
1939         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1940         (WebKitPortTest):
1941         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1942         (WinPortTest):
1943         (WinPortTest._assert_search_path):
1944         (WinPortTest.test_baseline_search_path):
1945         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1946         (get_test_config.TestMacPort.__init__):
1947
1948 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1949
1950         test-webkitpy: clean up logging and provide a real --help message
1951         https://bugs.webkit.org/show_bug.cgi?id=76142
1952
1953         Reviewed by Adam Barth.
1954
1955         This test is mostly more refactoring - it calls objects in
1956         unittest directly instead of routing through unittest.main() --
1957         in order to gain more control over the logging and to provide a
1958         correct --help message. This will also give us a better
1959         foundation for adding more feautures down the road.
1960
1961         This patch adds different levels of logging controlled by the
1962         '-s', '-q', and '-v' options (see --help for details), and
1963         removes the --verbose-logging option.
1964
1965         * Scripts/test-webkitpy:
1966         * Scripts/webkitpy/test/main.py:
1967         (Tester):
1968         (Tester.clean_packages):
1969         (Tester.__init__):
1970         (Tester.parse_args):
1971         (Tester.configure):
1972         (Tester._configure_logging):
1973         (Tester.find_modules):
1974         (Tester._exclude):
1975         (Tester._modules_from_paths):
1976         (Tester.run_tests):
1977
1978 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
1979
1980         Make the new WTF module build on Qt
1981         https://bugs.webkit.org/show_bug.cgi?id=76163
1982
1983         Reviewed by Tor Arne Vestbø.
1984
1985         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
1986
1987 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1988
1989         Unreviewed, mac DumpRenderTree fix.
1990
1991         * DumpRenderTree/mac/UIDelegate.mm:
1992         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1993
1994 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1995
1996         WebKitTestRunner should not print console message line number when it is equal to zero.
1997         https://bugs.webkit.org/show_bug.cgi?id=76167
1998
1999         Reviewed by Csaba Osztrogonác.
2000
2001         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2002         (WTR::InjectedBundlePage::willAddMessageToConsole):
2003
2004 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
2005
2006         Make default console messages line numbers consistent.
2007         https://bugs.webkit.org/show_bug.cgi?id=74075
2008
2009         Reviewed by Pavel Feldman.
2010
2011         Unset line numbers are not printed to console now.
2012         Added Source/WebCore/inspector to efl DumpRenderTree include path.
2013
2014         * DumpRenderTree/chromium/WebViewHost.cpp:
2015         (WebViewHost::didAddMessageToConsole):
2016         * DumpRenderTree/efl/CMakeLists.txt:
2017         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2018         (onConsoleMessage):
2019         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2020         (webViewConsoleMessage):
2021         * DumpRenderTree/mac/UIDelegate.mm:
2022         (-[UIDelegate webView:addMessageToConsole:withSource:]):
2023         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2024         (WebCore::WebPage::javaScriptConsoleMessage):
2025         * DumpRenderTree/win/UIDelegate.cpp:
2026         (UIDelegate::webViewAddMessageToConsole):
2027         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2028         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
2029
2030 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
2031
2032         test-webkitpy: push more logic into webkitpy.test.main, clean up code
2033         https://bugs.webkit.org/show_bug.cgi?id=76021
2034
2035         Reviewed by Eric Seidel.
2036
2037         I plan to add more functionality to test-webkitpy, but it is
2038         difficult to hack on now; this patch is the first of two that
2039         brings test-webkitpy more inline with current coding style by
2040         pushing more logic into the webkitpy.test.main.Tester class (so
2041         that it will be testable itself).
2042         
2043         There should be no functional changes in this patch.
2044
2045         * Scripts/test-webkitpy:
2046         (_path_from_webkit_root):
2047         * Scripts/webkitpy/test/main.py:
2048         (Tester):
2049         (Tester.init):
2050         (Tester.configure_logging):
2051         (Tester.configure_logging.filter):
2052         (Tester.clean_packages):
2053         (Tester.run_tests):
2054
2055 2012-01-11  Wei Jia  <wjia@chromium.org>
2056
2057         implement layout tests for <video> with media stream
2058         https://bugs.webkit.org/show_bug.cgi?id=74882
2059
2060         Reviewed by Kent Tamura.
2061
2062         * DumpRenderTree/DumpRenderTree.gypi:
2063         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
2064         (WebKit::WebUserMediaClientMock::create):
2065         (WebKit::WebUserMediaClientMock::IsMockStream):
2066         (WebKit::WebUserMediaClientMock::requestUserMedia):
2067         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
2068         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
2069         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
2070         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
2071         * DumpRenderTree/chromium/WebViewHost.cpp:
2072         (WebViewHost::userMediaClient):
2073         (WebViewHost::userMediaClientMock):
2074         (WebViewHost::createMediaPlayer):
2075         (WebViewHost::mediaStreamUtil):
2076         (WebViewHost::testMediaStreamClient):
2077         * DumpRenderTree/chromium/WebViewHost.h:
2078
2079 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2080
2081         Unreviewed, build fix.
2082
2083         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
2084
2085         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2086         (ChromiumWinPort.__init__):
2087
2088 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2089
2090         Sheriffbot build fix. Don't emit empty lines on IRC.
2091
2092         * Scripts/webkitpy/tool/bot/irc_command.py:
2093         (LastGreenRevision.execute):
2094
2095 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2096
2097         last-green-revision should report the revision that succeeded on all bots
2098         https://bugs.webkit.org/show_bug.cgi?id=76109
2099
2100         Reviewed by Adam Barth.
2101
2102         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
2103         considered green by this algorithm, all matching builders must have a successful run at the revision
2104         or two consecutive successful runs before and after the revision.
2105
2106         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
2107         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
2108
2109         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2110         (BuildBot._revisions_for_builder):
2111         (BuildBot):
2112         (BuildBot._find_green_revision):
2113         (BuildBot.last_green_revision):
2114         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2115         (MockBuildBot.last_green_revision):
2116         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2117         (test_revisions_for_builder):
2118         (test_find_green_revision):
2119         (test_last_green_revision):
2120         * Scripts/webkitpy/tool/bot/irc_command.py:
2121         (LastGreenRevision.execute):
2122         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2123         (SheriffIRCBotTest.test_lgr):
2124         * Scripts/webkitpy/tool/commands/queries.py:
2125         (LastGreenRevision):
2126
2127 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2128
2129         Unreviewed, fix build bustage on win32 introduced by r104725.
2130
2131         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2132         (MockDRTPortTest.make_port):
2133         (MockChromiumDRTTest.test_pixeltest__fails):
2134
2135 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
2136
2137         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
2138         https://bugs.webkit.org/show_bug.cgi?id=75618
2139
2140         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
2141
2142         Reviewed by Tony Chang.
2143
2144         * DumpRenderTree/chromium/LayoutTestHelper.mm:
2145         (installLayoutTestColorProfile):
2146         (restoreUserColorProfile):
2147         (main):
2148
2149 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2150
2151         test-webkitpy: fix -v and eliminate some spurious warnings
2152         https://bugs.webkit.org/show_bug.cgi?id=76099
2153
2154         Reviewed by Adam Barth.
2155
2156         when we added support for --xml output, we broke the -v flag.
2157
2158         Also, fix the code to swallow a harmless warning from
2159         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
2160
2161         test-webkitpy is now silent again except for the one known
2162         logging issue.
2163
2164         * Scripts/webkitpy/common/checkout/checkout.py:
2165         (Checkout.commit_message_for_this_commit):
2166         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2167         (test_commit_message_for_this_commit):
2168         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2169         (JSONChecker.check):
2170         (JSONChecker.line_number_from_json_exception):
2171         * Scripts/webkitpy/test/main.py:
2172         (Tester.run_tests):
2173
2174 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2175
2176         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
2177         https://bugs.webkit.org/show_bug.cgi?id=76084
2178
2179         Reviewed by Adam Barth.
2180
2181         This will help make it easier to catch layering violations. This
2182         change just refactors test code; there are no changes to
2183         production code.
2184
2185         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2186         (PortTest.make_port):
2187         (PortTest.test_find_no_paths_specified):
2188         (PortTest.test_find_one_test):
2189         (PortTest.test_find_glob):
2190         (PortTest.test_find_with_skipped_directories):
2191         (PortTest.test_find_with_skipped_directories_2):
2192         (PortTest.test_parse_reftest_list):
2193         (PortTest.test_httpd_returns_error_code):
2194         (PortTest.test_virtual_methods):
2195         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2196         (ChromiumGpuTest.assert_port_works):
2197         (ChromiumGpuTest._assert_baseline_path):
2198         (ChromiumGpuTest.test_graphics_type):
2199         (ChromiumGpuTest.test_default_tests_paths.test_paths):
2200         (ChromiumGpuTest.test_test_files):
2201         (ChromiumGpuTest.test_test_files.test_paths):
2202         (ChromiumGpuTest):
2203         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2204         (ChromiumLinuxPortTest.assert_architecture):
2205         (ChromiumLinuxPortTest.test_check_illegal_port_names):
2206         (ChromiumLinuxPortTest.test_determine_architecture_fails):
2207         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2208         (DriverTest.make_port):
2209         (DriverTest):
2210         (DriverTest.assertVirtual):
2211         (DriverTest._assert_wrapper):
2212         (DriverTest.test_virtual_driver_methods):
2213         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2214         (MockDRTPortTest.make_port):
2215         (MockDRTPortTest.test_port_name_in_constructor):
2216         (MockDRTTest.assertTest):
2217         (MockDRTTest.test_main):
2218         (MockChromiumDRTTest.test_pixeltest__fails):
2219         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2220         (QtPortTest._assert_search_path):
2221         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2222         (TestWebKitPort.__init__):
2223         (WebKitPortUnitTests.test_default_options):
2224         (test_runtime_feature_list):
2225         (test_test_expectations):
2226
2227 2012-01-11  Ojan Vafai  <ojan@chromium.org>
2228
2229         Style skipped tests in the flakiness dashboard
2230         https://bugs.webkit.org/show_bug.cgi?id=76091
2231
2232         Reviewed by Tony Chang.
2233
2234         * TestResultServer/static-dashboards/dashboard_base.js:
2235         Removed "FLAKY" from this list since we don't ever mark individual runs
2236         as flaky. Also deleted an outdated line.
2237         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2238
2239 2012-01-11  Ojan Vafai  <ojan@chromium.org>
2240
2241         Remove gtest normalization code from the test results server
2242         https://bugs.webkit.org/show_bug.cgi?id=76089
2243
2244         Reviewed by Tony Chang.
2245
2246         The normalization now happens on the gtest side.
2247
2248         * TestResultServer/model/jsonresults.py:
2249         (JsonResults.merge):
2250         * TestResultServer/model/jsonresults_unittest.py:
2251         (JsonResultsTest.test_gtest):
2252
2253 2012-01-11  Ojan Vafai  <ojan@chromium.org>
2254
2255         Be more aggressive about deleting unnecessary results from the test-results-server json files
2256         https://bugs.webkit.org/show_bug.cgi?id=76086
2257
2258         Reviewed by Tony Chang.
2259
2260         Remove any tests that only contain skip/pass/nodata values whose runtime
2261         is less than 5 seconds.
2262
2263         * TestResultServer/model/jsonresults.py:
2264         (JsonResults._normalize_results_json):
2265         * TestResultServer/model/jsonresults_unittest.py:
2266         (JsonResultsTest.test_merge_remove_test):
2267         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
2268
2269 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2270
2271         last-green-revision should give us per-bot information
2272         https://bugs.webkit.org/show_bug.cgi?id=76011
2273
2274         Reviewed by Adam Barth.
2275
2276         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
2277         we report the latest green run on each bot from the last 100 runs.
2278
2279         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2280         (BuildBot._fetch_builder_page):
2281         (BuildBot):
2282         (BuildBot._green_revision_for_builder):
2283         (BuildBot.last_green_revision):
2284         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2285         (test_green_revision_for_builder):
2286         (test_last_green_revision):
2287         * Scripts/webkitpy/tool/bot/irc_command.py:
2288         (LastGreenRevision.execute):
2289         * Scripts/webkitpy/tool/commands/queries.py:
2290         (LastGreenRevision.execute):
2291
2292 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2293
2294         webkitpy: clean up version detection in webkitpy.layout_tests.port
2295         https://bugs.webkit.org/show_bug.cgi?id=76016
2296
2297         Reviewed by Adam Barth.
2298
2299         This change updates the code in webkitpy.layout_tests.port to
2300         use the new os_name and os_version fields on host.platform. This
2301         gets layout_tests.port out of the version parsing business. Most
2302         of the diffs are just cleaning up test code to accomodate the
2303         changes.
2304
2305         * Scripts/webkitpy/common/system/executive_mock.py:
2306         (MockExecutive):
2307         (MockExecutive.ignore_error):
2308         (MockExecutive2):
2309         (MockExecutive2.ignore_error):
2310         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2311         (MockPlatformInfo.is_mac):
2312         (MockPlatformInfo.is_linux):
2313         (MockPlatformInfo.is_win):
2314         * Scripts/webkitpy/common/system/systemhost_mock.py:
2315         (MockSystemHost.__init__):
2316         * Scripts/webkitpy/layout_tests/port/apple.py:
2317         (ApplePort.__init__):
2318         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2319         (ChromiumMacPort.__init__):
2320         (ChromiumMacPort.check_wdiff):
2321         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2322         (ChromiumMacPortTest):
2323         (ChromiumMacPortTest.assert_name):
2324         (ChromiumMacPortTest.test_versions):
2325         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2326         (ChromiumPortTest.test_all_test_configurations):
2327         (ChromiumPortTest.TestMacPort.__init__):
2328         (ChromiumPortTest.TestLinuxPort.__init__):
2329         (ChromiumPortTest.TestWinPort.__init__):
2330         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2331         (ChromiumWinPort.__init__):
2332         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2333         (ChromiumWinTest):
2334         (ChromiumWinTest.assert_name):
2335         (ChromiumWinTest.test_versions):
2336         (ChromiumWinTest.test_baseline_path):
2337         (ChromiumWinTest.test_build_path):
2338         * Scripts/webkitpy/layout_tests/port/factory.py:
2339         (PortFactory._port_name_from_arguments_and_options):
2340         (PortFactory.get):
2341         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2342         (FactoryTest):
2343         (FactoryTest.setUp):
2344         (FactoryTest.assert_port):
2345         (FactoryTest.test_mac):
2346         (FactoryTest.test_win):
2347         (FactoryTest.test_google_chrome):
2348         (FactoryTest.test_gtk):
2349         (FactoryTest.test_qt):
2350         (FactoryTest.test_chromium_gpu):
2351         (FactoryTest.test_chromium_gpu_linux):
2352         (FactoryTest.test_chromium_gpu_mac):
2353         (FactoryTest.test_chromium_gpu_win):
2354         (FactoryTest.test_chromium_mac):
2355         (FactoryTest.test_chromium_linux):
2356         (FactoryTest.test_chromium_win):
2357         (FactoryTest.test_unknown_specified):
2358         (FactoryTest.test_unknown_default):
2359         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2360         (TestGoogleChromePort):
2361         (TestGoogleChromePort._verify_baseline_path):
2362         (TestGoogleChromePort._verify_expectations_overrides):
2363         (TestGoogleChromePort.test_get_google_chrome_port):
2364         * Scripts/webkitpy/layout_tests/port/mac.py:
2365         (MacPort):
2366         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2367         (MacTest):
2368         (assert_name):
2369         (test_tests_for_other_platforms):
2370         (test_version):
2371         (test_versions):
2372         (test_is_version_methods):
2373         (test_setup_environ_for_server):
2374         (_assert_search_path):
2375         (test_show_results_html_file):
2376         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2377         (PortTestCase):
2378         (PortTestCase.make_port):
2379         * Scripts/webkitpy/layout_tests/port/win.py:
2380         (WinPort):
2381         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2382         (WinPortTest):
2383         (WinPortTest.test_show_results_html_file):
2384         (WinPortTest._assert_search_path):
2385         (WinPortTest._assert_version):
2386
2387 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
2388
2389         [Qt][WK2] Remove workaround introduced into bug 75470
2390         https://bugs.webkit.org/show_bug.cgi?id=75889
2391
2392         Reviewed by Tor Arne Vestbø.
2393
2394         * MiniBrowser/qt/qml/BrowserWindow.qml:
2395
2396 2012-01-10  Dmitry Lomov  <dslomov@google.com>
2397
2398         [Chromium] Remove obsolete references to WebWorker class.
2399         https://bugs.webkit.org/show_bug.cgi?id=76020
2400
2401         Reviewed by David Levin.
2402
2403         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
2404         * DumpRenderTree/chromium/WebViewHost.cpp:
2405         * DumpRenderTree/chromium/WebViewHost.h:
2406
2407 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
2408
2409         [Qt] Some css3 filter tests are failing after r104698
2410         https://bugs.webkit.org/show_bug.cgi?id=76055
2411
2412         Reviewed by Simon Hausmann.
2413
2414         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2415         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
2416
2417 2012-01-11  Tony Chang  <tony@chromium.org>
2418
2419         Don't remove 0 byte files when running build-webkit --chromium
2420         https://bugs.webkit.org/show_bug.cgi?id=75997
2421
2422         Reviewed by Csaba Osztrogonác.
2423
2424         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
2425
2426         * Scripts/webkitdirs.pm:
2427         (determineIsQt):
2428
2429 2012-01-10  David Kilzer  <ddkilzer@apple.com>
2430
2431         Add TestWebKitAPI tests for KURL
2432         <http://webkit.org/b/75774>
2433
2434         Reviewed by Adam Barth.
2435
2436         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
2437         WebCore folder and KURL.cpp source file to the project.
2438         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
2439         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
2440         during setup since this test doesn't go through WebKit or
2441         WebKit2.
2442         (TestWebKitAPI::TEST_F): Add two basic tests.
2443
2444 2012-01-10  David Kilzer  <ddkilzer@apple.com>
2445
2446         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
2447
2448         Reviewed by Adam Barth.
2449
2450         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
2451
2452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
2453         WTFStringUtilities.h to the project.
2454         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
2455         WTFStringUtilities.h.
2456         * TestWebKitAPI/WTFStringUtilities.h: Added.
2457         (WTF::operator<<):
2458
2459 2012-01-10  Vincent Scheib  <scheib@chromium.org>
2460
2461         Clarify run-webkit-tests options reset-results and new-baseline
2462         https://bugs.webkit.org/show_bug.cgi?id=75993
2463
2464         Reviewed by Dirk Pranke.
2465
2466         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2467         (parse_args):
2468
2469 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
2470
2471         Disabled mock scrollbars should draw differently
2472         https://bugs.webkit.org/show_bug.cgi?id=75995
2473
2474         Reviewed by James Robinson.
2475
2476         When the scrollbar is disabled, paint the entire track of
2477         mock scrollbars with a lighter gray, and hide the thumb.
2478
2479         * DumpRenderTree/mac/DumpRenderTree.mm:
2480         (-[DRTMockScroller drawKnob]):
2481         (-[DRTMockScroller drawRect:]):
2482
2483 2012-01-10  James Robinson  <jamesr@chromium.org>
2484
2485         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
2486         https://bugs.webkit.org/show_bug.cgi?id=75988
2487
2488         Reviewed by Adam Barth.
2489
2490         * Scripts/webkitpy/common/config/ports.py:
2491         (WebKitPort.run_webkit_unit_tests_command):
2492         (WebKitPort):
2493         (ChromiumPort.run_webkit_unit_tests_command):
2494         (ChromiumPort):
2495         * Scripts/webkitpy/common/config/ports_mock.py:
2496         (MockPort.run_webkit_unit_tests_command):
2497         * Scripts/webkitpy/tool/commands/download_unittest.py:
2498         (DownloadCommandsTest.test_build_and_test):
2499         (test_land):
2500         (test_land_red_builders):
2501         * Scripts/webkitpy/tool/steps/runtests.py:
2502         (RunTests.run):
2503         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2504
2505 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2506
2507         webkitpy: add os_name, os_version to platforminfo
2508         https://bugs.webkit.org/show_bug.cgi?id=75931
2509
2510         Reviewed by Eric Siedel.
2511
2512         As a first step in cleaning up the version parsing logic in
2513         webkitpy.layout_tests.port, this adds common routines for
2514         getting the os_name and os_version fields to the PlatformInfo
2515         class. Nothing uses them yet but I've added FIXME's to some of
2516         the code that needs to be deleted in the port files.
2517
2518         * Scripts/webkitpy/common/system/platforminfo.py:
2519         (PlatformInfo.__init__):
2520         (PlatformInfo):
2521         (PlatformInfo._determine_os_name):
2522         (PlatformInfo._determine_mac_version):
2523         (PlatformInfo._determine_linux_version):
2524         (PlatformInfo._determine_win_version):
2525         (PlatformInfo.display_name):
2526         (PlatformInfo.total_bytes_memory):
2527         (PlatformInfo._compute_bytes_from_vm_stat_output):
2528         (PlatformInfo.free_bytes_memory):
2529         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
2530         (TestPlatformInfo):
2531         (TestPlatformInfo.make_info):
2532         (TestPlatformInfo.make_info.mock_run_command):
2533         (TestPlatformInfo.setUp):
2534         (TestPlatformInfo.tearDown):
2535         (TestPlatformInfo.test_basic):
2536         (TestPlatformInfo.integration_test_basic):
2537         (TestPlatformInfo.test_display_name_mac):
2538         (TestPlatformInfo.test_display_name_win32):
2539         (TestPlatformInfo.test_memory_mac):
2540         (TestPlatformInfo.test_memory_win32):
2541         (TestPlatformInfo.test_determine_os_name):
2542         (TestPlatformInfo.test_determine_mac_version):
2543         (TestPlatformInfo.test_determine_linux_version):
2544         (TestPlatformInfo.test_determine_win_version_from_tuple):
2545         (TestPlatformInfo.test_determine_win_version_from_cmd):
2546         * Scripts/webkitpy/layout_tests/port/apple.py:
2547         (ApplePort.__init__):
2548         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2549         (ChromiumMacPort.__init__):
2550         * Scripts/webkitpy/layout_tests/port/mac.py:
2551         (MacPort):
2552         * Scripts/webkitpy/layout_tests/port/win.py:
2553         (WinPort):
2554
2555 2012-01-10  Adam Roben  <aroben@apple.com>
2556
2557         Make it possible to type data: URLs into MiniBrowser on Windows
2558
2559         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
2560         MiniBrowser on Windows
2561
2562         Reviewed by Darin Adler.
2563
2564         * MiniBrowser/win/BrowserWindow.cpp:
2565         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
2566         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
2567         does, we assume it already has a scheme and don't modify it.
2568
2569 2012-01-10  Adam Roben  <aroben@apple.com>
2570
2571         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
2572
2573         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
2574         MiniBrowser on Windows
2575
2576         Reviewed by Darin Adler.
2577
2578         * MiniBrowser/win/BrowserView.cpp:
2579         (BrowserView::goToURL): Pass the typed string through
2580         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
2581
2582 2012-01-10  Ben Wells  <benwells@chromium.org>
2583
2584         Adding myself (benwells) to committers.py
2585         https://bugs.webkit.org/show_bug.cgi?id=75971
2586
2587         Reviewed by Ojan Vafai.
2588
2589         * Scripts/webkitpy/common/config/committers.py:
2590
2591 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
2592
2593         AX: support helpText() in DumpRenderTree
2594         https://bugs.webkit.org/show_bug.cgi?id=40193
2595
2596         Reviewed by Chris Fleizach.
2597
2598         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2599         (AccessibilityUIElement::helpText): Implemented.
2600
2601 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2602
2603         Unreviewed, rolling out r104572.
2604         http://trac.webkit.org/changeset/104572
2605         https://bugs.webkit.org/show_bug.cgi?id=75967
2606
2607         It broke zillion tests (Requested by Ossy on #webkit).
2608
2609         * DumpRenderTree/qt/EventSenderQt.cpp:
2610         (EventSender::EventSender):
2611         (EventSender::sendOrQueueEvent):
2612         (EventSender::replaySavedEvents):
2613         (EventSender::eventFilter):
2614         * DumpRenderTree/qt/EventSenderQt.h:
2615
2616 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
2617
2618         [Qt] fast/events/dont-loose-last-event test fails on WK1
2619         https://bugs.webkit.org/show_bug.cgi?id=73894
2620
2621         Reviewed by Simon Hausmann.
2622
2623         Empty the entire event queue when requested besides using
2624         sendEvent instead of postEvent to make sure all events were
2625         delivered.
2626         This commit also removes not working DRT code to handle drag and drop,
2627         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
2628
2629         * DumpRenderTree/qt/EventSenderQt.cpp:
2630         (EventSender::EventSender):
2631         (EventSender::sendOrQueueEvent):
2632         (EventSender::replaySavedEvents):
2633         * DumpRenderTree/qt/EventSenderQt.h:
2634
2635 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
2636
2637         [Qt] Enable CSS_FILTERS in Qt build
2638         https://bugs.webkit.org/show_bug.cgi?id=75777
2639
2640         Add the CSS_FILTERS feature flag to Qt.
2641
2642         Reviewed by Kenneth Rohde Christiansen.
2643
2644         * qmake/mkspecs/features/features.prf:
2645
2646 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2647
2648         [Qt] Unreviewed -Werror build fix.
2649
2650         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2651         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
2652         declaration.
2653
2654 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2655
2656         [Qt] Remove dependency to uitools
2657         https://bugs.webkit.org/show_bug.cgi?id=75952
2658
2659         Reviewed by Tor Arne Vestbø.
2660
2661         QUiLoader is used for creating QLabel/QProgressBar widgets for
2662         a layout test, to verify some widget embedding feature. Unfortunately
2663         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
2664         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
2665         let's break the circular dependency.
2666
2667         * DumpRenderTree/qt/DumpRenderTree.pro:
2668         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2669         (WebCore::WebPage::createPlugin):
2670         * QtTestBrowser/QtTestBrowser.pro:
2671         * QtTestBrowser/launcherwindow.h:
2672         * QtTestBrowser/webpage.cpp:
2673         (WebPage::createPlugin):
2674         * qmake/mkspecs/features/minimal_qt.prf:
2675         * qmake/mkspecs/features/uitools.prf: Removed.
2676
2677 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
2678
2679         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
2680         https://bugs.webkit.org/show_bug.cgi?id=75894
2681
2682         Reviewed by Tor Arne Vestbø.
2683
2684         * MiniBrowser/qt/MiniBrowserApplication.h:
2685         (MiniBrowserApplication::windowOptions):
2686         * MiniBrowser/qt/main.cpp:
2687         (main):
2688
2689 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2690
2691         [Qt] DRT crashes with Qt 5
2692         https://bugs.webkit.org/show_bug.cgi?id=75951
2693
2694         Reviewed by Ossy.
2695
2696         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
2697         Qt relies on font-config to define the default font family.
2698
2699 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
2700
2701         [Qt] REGRESSION(r100130): Clean build feature is broken.
2702         https://bugs.webkit.org/show_bug.cgi?id=75863
2703
2704         Reviewed by Tor Arne Vestbø.
2705
2706         * Scripts/webkitdirs.pm:
2707         (buildQMakeProject):
2708
2709 2012-01-10  Zeno Albisser  <zeno@webkit.org>
2710
2711         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
2712         https://bugs.webkit.org/show_bug.cgi?id=75885
2713
2714         In QML events are propagated through parents. But since the
2715         WebView may consume key events, a shortcut might never reach
2716         the top QtQuickItem.
2717         Therefore an application wide event handling function in C++
2718         needs to take care of shortcuts for MiniBrowser.
2719
2720         Reviewed by Kenneth Rohde Christiansen.
2721
2722         * MiniBrowser/qt/BrowserWindow.cpp:
2723         (BrowserWindow::reload):
2724         (BrowserWindow::focusAddressBar):
2725         * MiniBrowser/qt/BrowserWindow.h:
2726         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2727         (MiniBrowserApplication::notify):
2728         * MiniBrowser/qt/qml/BrowserWindow.qml:
2729
2730 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2731
2732         Add --efl alias for --platform=efl to run-webkit-test
2733         https://bugs.webkit.org/show_bug.cgi?id=75937
2734
2735         Reviewed by Andreas Kling.
2736         
2737         * Scripts/run-webkit-tests: Add --efl alias.
2738         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
2739         (parse_args):
2740
2741 2012-01-09  Dan Bernstein  <mitz@apple.com>
2742
2743         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
2744         https://bugs.webkit.org/show_bug.cgi?id=75920
2745
2746         Reviewed by Darin Adler.
2747
2748         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2749         (TestWebKitAPI::TEST): Added a test for a range in a
2750         -webkit-user-select: none; block.
2751
2752 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2753
2754         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
2755         https://bugs.webkit.org/show_bug.cgi?id=75884
2756
2757         Reviewed by Ryosuke Niwa.
2758
2759         Fix regression introduced (revealed?) in r104340. Chromium file         
2760         url syntax is different on win32 and the test results weren't           
2761         expecting that.                                                         
2762
2763         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2764         (TestExpectations._report_errors):
2765         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2766         (test_parse_error_nonfatal):
2767         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2768         (MockDRTTest.input_line):
2769         (MockChromiumDRTTest.test_pixeltest__fails):
2770         * Scripts/webkitpy/layout_tests/port/test.py:
2771         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2772         (TestRebaseliner.make_rebaseliner):
2773         (TestRebaseliner.test_one_platform):
2774         (TestRebaseliner.test_all_platforms):
2775         (TestRebaseliner.test_png_file_with_comment):
2776         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
2777         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
2778         (TestRealMain.test_all_platforms):
2779
2780 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2781
2782         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
2783
2784         Unreviewed, build fix.
2785
2786         test-webkitpy had a built-in self-test routine to verify that
2787         deleting the .pyc files worked correctly. When I removed the
2788         python24 directory in r104482, I broke the self-test.
2789
2790         I have deleted the self-test for now. Since I am reworking
2791         test-webkitpy I will make sure the new version is adequately
2792         tested.
2793
2794         * Scripts/test-webkitpy:
2795         (configure_logging):
2796         (_clean_pyc_files):
2797         (_clean_packages):
2798         (init):
2799
2800 2012-01-09  Justin Novosad  <junov@chromium.org>
2801
2802         [Chromium] remove all references to the legacy accelerated 2d Canvas
2803         implementation
2804         https://bugs.webkit.org/show_bug.cgi?id=75108
2805
2806         Purging an old settings flag that is no longer referenced
2807
2808         Reviewed by Darin Fisher.
2809
2810         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2811         (main):
2812         * DumpRenderTree/chromium/TestShell.cpp:
2813         (TestShell::TestShell):
2814         (TestShell::resetWebSettings):
2815         * DumpRenderTree/chromium/TestShell.h:
2816         (TestShell::setAccelerated2dCanvasEnabled):
2817         * DumpRenderTree/chromium/WebPreferences.cpp:
2818         (WebPreferences::reset):
2819         (WebPreferences::applyTo):
2820         * DumpRenderTree/chromium/WebPreferences.h:
2821
2822 2012-01-09  Adam Roben  <aroben@apple.com>
2823
2824         Convert Cygwin paths to Windows paths before passing them to DRT
2825
2826         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
2827         NRWT
2828
2829         I couldn't find a way to test this because I couldn't figure out how to override the
2830         cygpath function as it is used by WebKitDriver.
2831
2832         Reviewed by Dirk Pranke.
2833
2834         * Scripts/webkitpy/layout_tests/port/webkit.py:
2835         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
2836         Windows-style path before passing it to DRT.
2837
2838 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
2839
2840         webkitpy: revamp version checking
2841         https://bugs.webkit.org/show_bug.cgi?id=75765
2842
2843         Reviewed by Adam Barth.
2844
2845         The version-checking code in webkitpy/python24/versioning seems really
2846         awkward and overdesigned, especially since we don't support python 2.4
2847         any more.
2848
2849         In addition, I am tired of getting warnings about Python 2.6 being "a
2850         newer release than what is supported" :).
2851
2852         I'm taking a page from the depot_tools python code and just creating a
2853         new webkitpy.common.version_check module that will print a message on
2854         stderr and call sys.exit() if we're running an unsupported version.
2855
2856         * Scripts/check-webkit-style:
2857         * Scripts/new-run-webkit-httpd:
2858         * Scripts/new-run-webkit-tests:
2859         * Scripts/rebaseline-chromium-webkit-tests:
2860         * Scripts/test-webkitpy:
2861         (configure_logging):
2862         (init):
2863         * Scripts/webkit-patch:
2864         (main):
2865         * Scripts/webkitpy/common/system/executive.py:
2866         (Executive._child_process_encoding):
2867         (Executive._should_encode_child_process_arguments):
2868         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
2869         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2870         * Scripts/webkitpy/python24/__init__.py: Removed.
2871         * Scripts/webkitpy/python24/versioning.py: Removed.
2872         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
2873
2874 2012-01-09  Adam Barth  <abarth@webkit.org>
2875
2876         Remove Chromium Mac CG from the flakiness dashboard
2877         https://bugs.webkit.org/show_bug.cgi?id=75873
2878
2879         Reviewed by Ojan Vafai.
2880
2881         This configuration no longer exists.
2882
2883         * TestResultServer/static-dashboards/builders.js:
2884         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2885         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2886         (testOverrideJustBuildType):
2887         (testPlatformAndBuildType):
2888
2889 2012-01-06  Adam Roben  <aroben@apple.com>
2890
2891         Print an error message when NRWT can't run Apache
2892
2893         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
2894
2895         Reviewed by Dirk Pranke.
2896
2897         * Scripts/webkitpy/layout_tests/port/base.py:
2898         (Port.check_httpd): Print an error message when Apache returns an error code instead of
2899         failing silently.
2900
2901         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2902         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
2903         run Apache.
2904         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
2905         fails.
2906
2907 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
2908
2909         [Gtk][ARM] Cross compiler buildbot is failing after r103040
2910         https://bugs.webkit.org/show_bug.cgi?id=75846
2911
2912         Reviewed by Philippe Normand.
2913
2914         * Scripts/webkitdirs.pm:
2915         (runAutogenForAutotoolsProjectIfNecessary):
2916
2917 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
2918
2919         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
2920         https://bugs.webkit.org/show_bug.cgi?id=75807
2921
2922         This patch adds a new icon to navigationbar of the Qt MiniBrowser
2923         which allows you to dynamically toggle whether touch mocking is
2924         enabled or disabled.
2925
2926         Reviewed by Tor Arne Vestbø.
2927
2928         * MiniBrowser/qt/MiniBrowser.qrc:
2929         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2930         (MiniBrowserApplication::notify):
2931         * MiniBrowser/qt/MiniBrowserApplication.h:
2932         (WindowOptions::WindowOptions):
2933         (WindowOptions::touchMockingEnabled):
2934         (WindowOptions::setTouchMockingEnabled):
2935         * MiniBrowser/qt/icons/touch.png: Added.
2936         * MiniBrowser/qt/qml/BrowserWindow.qml:
2937
2938 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2939
2940         Unreviewed. Fix make distcheck issues.
2941
2942         * MiniBrowser/gtk/GNUmakefile.am:
2943
2944 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2945
2946         Unreviewed, rolling out r104421.
2947         http://trac.webkit.org/changeset/104421
2948         https://bugs.webkit.org/show_bug.cgi?id=75816
2949
2950         Need to rebaseline some tests on Linux (Requested by noamr on
2951         #webkit).
2952
2953         * qmake/mkspecs/features/features.prf:
2954
2955 2012-01-08  Adam Barth  <abarth@webkit.org>
2956
2957         Remove support for Chromium Mac CG from garden-o-matic
2958         https://bugs.webkit.org/show_bug.cgi?id=75814
2959
2960         Reviewed by Eric Seidel.
2961
2962         This configuration no longer exists.  This patch is mostly a matter of
2963         updating config.js and removing the examples from the unit tests.
2964
2965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2968         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2970
2971 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2972
2973         [Qt] Enable CSS_FILTERS in Qt build
2974         https://bugs.webkit.org/show_bug.cgi?id=75777
2975
2976         Add the CSS_FILTERS feature flag to Qt.
2977
2978         Reviewed by Kenneth Rohde Christiansen.
2979
2980         * qmake/mkspecs/features/features.prf:
2981
2982 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2983
2984         Categorize bots by ports instead of core/non-core separation
2985         https://bugs.webkit.org/show_bug.cgi?id=75766
2986
2987         Reviewed by Eric Seidel.
2988
2989         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
2990         (Chromium still comes before GTK and Qt).
2991
2992         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2993         (loadBuilderConfig):
2994         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2995
2996 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2997
2998         Remove the concept of core builders from webkitpy
2999         https://bugs.webkit.org/show_bug.cgi?id=75809
3000
3001         Reviewed by Ryosuke Niwa.
3002
3003         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
3004         and remove the relevant code.
3005
3006         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3007         (BuildBot.__init__):
3008         (BuildBot._matches_regexps):
3009         (BuildBot._builder_statuses_with_names_matching_regexps):
3010         (BuildBot.builder_statuses):
3011         (BuildBot.failure_map):
3012         (BuildBot._latest_builds_from_builders):
3013         (BuildBot.last_green_revision):
3014         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3015         (MockBuildBot.builder_statuses):
3016         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3017         (test_status_parsing):
3018         (test_last_green_revision):
3019         (test_last_green_revision.mock_builds_from_builders):
3020
3021 2012-01-08  Adam Barth  <abarth@webkit.org>
3022
3023         Remove Chromium Mac CG concept from webkitpy
3024         https://bugs.webkit.org/show_bug.cgi?id=75810
3025
3026         Reviewed by Ryosuke Niwa.
3027
3028         This configuration no longer exists.  We can remove all the supporting
3029         code from webkitpy.
3030
3031         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3032         (BaselineOptimizerTest.test_move_baselines):
3033         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
3034         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
3035         (BaselineOptimizerTest.test_common_directory_includes_root):
3036         (BaselineOptimizerTest.test_complex_shadowing):
3037         * Scripts/webkitpy/common/config/build.py:
3038         (_should_file_trigger_build):
3039         * Scripts/webkitpy/common/config/build_unittest.py:
3040         (ShouldBuildTest):
3041         * Scripts/webkitpy/layout_tests/port/builders.py:
3042         * Scripts/webkitpy/layout_tests/port/chromium.py:
3043         (ChromiumPort):
3044         (ChromiumPort._generate_all_test_configurations):
3045         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3046         (_default_tests_paths):
3047         (ChromiumGpuLinuxPort.tests):
3048         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3049         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
3050         (ChromiumGpuTest.assert_port_works):
3051         (ChromiumGpuTest.test_baseline_paths):
3052         (ChromiumGpuTest.test_graphics_type):
3053         (ChromiumGpuTest.test_default_tests_paths):
3054         (ChromiumGpuTest.test_test_files):
3055         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3056         (ChromiumMacPort):
3057         (ChromiumMacPort.__init__):
3058         (ChromiumMacPort.baseline_search_path):
3059         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3060         (ChromiumMacPortTest.test_graphics_type):
3061         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3062         (ChromiumPortTest.test_all_test_configurations):
3063         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3064         * Scripts/webkitpy/layout_tests/port/factory.py:
3065         (PortFactory._port_name_from_arguments_and_options):
3066         (PortFactory.get):
3067         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3068         (FactoryTest.test_chromium_gpu_mac):
3069         (FactoryTest.test_chromium_mac):
3070         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3071         (GetGoogleChromePortTest._verify_expectations_overrides):
3072         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3073         (MockChromiumDRTTest.test_chromium_parse_options):
3074         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3075         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3076         (test_url_fetcher):
3077         (test_zip_factory):
3078         (test_archive):
3079         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3080         (TestRebaseline.test_rebaseline_expectations):
3081
3082 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
3083
3084         Categorize bots by ports instead of core/non-core separation
3085         https://bugs.webkit.org/show_bug.cgi?id=75766
3086
3087         Reviewed by Adam Barth.
3088
3089         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
3090
3091         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3092         (loadBuilderConfig):
3093         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3094
3095 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3096
3097         Unreviewed, rolling out r104403.
3098         http://trac.webkit.org/changeset/104403
3099         https://bugs.webkit.org/show_bug.cgi?id=75803
3100
3101         It broke all tests on Qt5 (Requested by Ossy_weekend on
3102         #webkit).
3103
3104         * qmake/mkspecs/features/features.prf:
3105
3106 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
3107
3108         [Qt] Enable CSS_FILTERS in Qt build
3109         https://bugs.webkit.org/show_bug.cgi?id=75777
3110
3111         Add the CSS_FILTERS feature flag to Qt.
3112
3113         Reviewed by Kenneth Rohde Christiansen.
3114
3115         * qmake/mkspecs/features/features.prf:
3116
3117 2012-01-04  Kentaro Hara  <haraken@chromium.org>
3118
3119         Rewrite the CSS parser of prepare-ChangeLog with unittests.
3120         https://bugs.webkit.org/show_bug.cgi?id=75202
3121
3122         Reviewed by David Kilzer.
3123
3124         The current CSS parser can just parse simple CSSes like
3125
3126             foo bar baz {
3127                 property1: value;
3128                 property2: value;
3129             }
3130
3131         , and cannot parse comments nor a CSS in which a selector and {
3132         appears in different lines. This patch rewrites the CSS parser
3133         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
3134         shown in css_unittests.css.
3135
3136         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
3137
3138         * Scripts/prepare-ChangeLog:
3139         (get_selector_line_ranges_for_css):
3140         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3141         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
3142         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
3143         (element1):
3144         (element2):
3145         (element3):
3146         (element4.p):
3147         (element5.p.q.r.s):
3148         (element6#p):
3149         (element7 element8):
3150         (element9.p element10.q):
3151         (element11#p element12#q):
3152         (element13, element14):
3153         (.p):
3154         (#p):
3155         (.p element15 #q element16.r element17#s):
3156         (element18:target):
3157         (element19):
3158         (element20):
3159         (element21):
3160         (element22):
3161
3162 2012-01-04  Kentaro Hara  <haraken@chromium.org>
3163
3164         The Perl parser of prepare-ChangeLog can parse here-documents
3165         https://bugs.webkit.org/show_bug.cgi?id=73208
3166
3167         Reviewed by David Kilzer.
3168
3169         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
3170         which results in wrong subroutine names in ChangeLogs.
3171         With this patch, prepare-ChangeLog can judge whether the line of "}"
3172         is the end of a subroutine or a line inside a here-document.
3173
3174         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
3175
3176         * Scripts/prepare-ChangeLog:
3177         (get_function_line_ranges_for_perl):
3178         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
3179         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
3180         Added test cases for here-documents.
3181         (func7):
3182         (func8):
3183         (func9):
3184         (func10):
3185         (func11):
3186         (func12):
3187         (func13):
3188         (func14):
3189         (func15):
3190         (func16):
3191
3192 2012-01-08  Kentaro Hara  <haraken@chromium.org>
3193
3194         Add unittests for the JavaScript parser of prepare-ChangeLog
3195         https://bugs.webkit.org/show_bug.cgi?id=75201
3196
3197         Reviewed by David Kilzer.
3198
3199         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
3200         of prepare-ChangeLog.
3201
3202         * Scripts/prepare-ChangeLog:
3203         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
3204         omitted from parsing. Thus,
3205
3206             str = "foo"
3207             function func() {
3208             }
3209
3210         was recognized as equivalent to
3211
3212             str = function func() {
3213             }
3214
3215         This patch replaces a string with a dummy identifier 'string_appeared_here'
3216         to tell the parser that a string appeared there.
3217
3218         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3219         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
3220         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
3221         (func1):
3222         (func2):
3223         (func3):
3224         (func4):
3225         (func5):
3226         (func6):
3227         (func7):
3228         (func8):
3229         (func9):
3230         (func10):
3231         (func11):
3232         (func12):
3233         (funcOverloaded):
3234         (Func1.prototype.get x1):
3235         (Func1.prototype.get x2):
3236         (Func1.prototype.set x1):
3237         (Func1.prototype.set x3):
3238         (Func2.prototype.func13):
3239         (Func2.prototype.func14):
3240         (Func2.prototype.func15):
3241         (func16.func17):
3242         (func16.func18):
3243         (func16.func19):
3244         (func16):
3245
3246 2012-01-08  David Levin  <levin@chromium.org>
3247
3248         [chromium] Add layout test support for autosize code in FrameView.
3249         https://bugs.webkit.org/show_bug.cgi?id=73631
3250
3251         Reviewed by Dmitry Titov.
3252
3253         * DumpRenderTree/chromium/LayoutTestController.cpp:
3254         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
3255         (LayoutTestController::reset): Set the autoresize mode back to false.
3256         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
3257         * DumpRenderTree/chromium/LayoutTestController.h:
3258         * DumpRenderTree/chromium/WebViewHost.cpp:
3259         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
3260         * DumpRenderTree/chromium/WebViewHost.h:
3261
3262 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
3263
3264         [WK2][GTK] Each test takes roughly half a second to load
3265         https://bugs.webkit.org/show_bug.cgi?id=70699
3266
3267         Reviewed by Martin Robinson.
3268
3269         Set the XDG_CACHE_HOME environment variable when testing with
3270         WebKitTestRunner. This way the testing is started with a non-existing
3271         application cache. If the cache exists and is not empty, the emptying
3272         and vacuuming that is performed before every test can consume a lot of
3273         time.
3274
3275         This is just a temporary workaround until it becomes possible to set
3276         a desired directory to be used as the application cache location through
3277         WebKitWebContext.
3278
3279         * Scripts/webkitpy/layout_tests/port/gtk.py:
3280         (GtkPort.setup_environ_for_server):
3281
3282 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
3283
3284         [GTK] Enable requestAnimationFrame in build-webkit
3285         https://bugs.webkit.org/show_bug.cgi?id=75773
3286
3287         Reviewed by Martin Robinson.
3288
3289         Enable requestAnimationFrame for the Gtk port.
3290
3291         * Scripts/build-webkit:
3292
3293 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
3294
3295         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
3296
3297         * Scripts/webkitdirs.pm:
3298         (buildChromium):
3299         Missing parentheses.
3300
3301 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3302
3303         Fix DRT build on case-sensitive file systems.
3304
3305         Fix case of include of WebDynamicScrollBarsView.h
3306         
3307         * DumpRenderTree/mac/DumpRenderTree.mm:
3308
3309 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3310
3311         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
3312         https://bugs.webkit.org/show_bug.cgi?id=75662
3313
3314         Reviewed by Dan Bernstein.
3315         
3316         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
3317         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
3318         test window uses the main display's color space, so that the pixel values in the bitmap
3319         that gets checksummed are identical to the CSS colors.
3320         
3321         Removed the code that switches the display profile in DRT, since that is no longer required.
3322
3323         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
3324         * DumpRenderTree/mac/DumpRenderTree.mm:
3325         (crashHandler): Remove code that switches display profiles.
3326         (prepareConsistentTestingEnvironment): Ditto.
3327         (dumpRenderTree): Ditto.
3328         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
3329         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
3330         (createBitmapContextFromWebView): Add comment about the colorspace handling.
3331         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3332         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
3333         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
3334         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3335         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
3336         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
3337
3338 2012-01-06  David Kilzer  <ddkilzer@apple.com>
3339
3340         run-api-tests: specify individual suites and tests on the command-line
3341
3342         Reviewed by Adam Roben.
3343
3344         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3345
3346         The run-api-tests script will now accept a list of arguments on
3347         the command-line that are used as prefix filters.  To run all
3348         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
3349         use:
3350
3351             $ run-api-tests WTF
3352
3353         To run only the tests in the "WTF" suite, not the "WTF_Vector"
3354         suite, use:
3355
3356             $ run-api-tests WTF.
3357
3358         * Scripts/run-api-tests: Filter tests if any prefix arguments
3359         are passed on the command-line.
3360
3361 2012-01-06  David Kilzer  <ddkilzer@apple.com>
3362
3363         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
3364
3365         Reviewed by Adam Roben.
3366
3367         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3368
3369         * Scripts/run-api-tests:
3370         (dumpTestsBySuite): Update to accept array of tests instead of
3371         hash data structure.
3372         (runTestsBySuite): Ditto.
3373         (listAllTests): Rename from populateTests().  Update to return
3374         an array of tests instad of the hash data structure.
3375
3376 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3377
3378         webkitpy: clean up test/uri conversion routines
3379         https://bugs.webkit.org/show_bug.cgi?id=75648
3380
3381         Reviewed by Eric Seidel.
3382
3383         This change moves test_to_uri and uri_to_test from the Port
3384         class to the Driver class (the routines were only being
3385         called by the drivers), and removes a bunch of stale and/or
3386         busted logic.
3387
3388         * Scripts/webkitpy/layout_tests/port/base.py:
3389         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3390         * Scripts/webkitpy/layout_tests/port/chromium.py:
3391         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3392         * Scripts/webkitpy/layout_tests/port/driver.py:
3393         (is_http_test):
3394         (test_to_uri):
3395         (uri_to_test):
3396         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3397         (run_one_test):
3398         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3399         (MockDRTTest.input_line):
3400         (input_line):
3401         (expected_output):
3402         * Scripts/webkitpy/layout_tests/port/test.py:
3403         * Scripts/webkitpy/layout_tests/port/webkit.py:
3404         (_command_from_driver_input):
3405
3406 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3407
3408         Mitigate scrollbar differences when running pixel tests
3409         https://bugs.webkit.org/show_bug.cgi?id=67217
3410
3411         Reviewed by Dan Bernstein.
3412         
3413         Add an NSScroller subclass that draws mock scrollbars identically
3414         to the WebCore mock scrollbar theme, and register it with the
3415         WebDynamicScrollbarsView.
3416
3417         * DumpRenderTree/mac/DumpRenderTree.mm:
3418         (-[DRTMockScroller rectForPart:]):
3419         (-[DRTMockScroller drawKnob]):
3420         (-[DRTMockScroller drawRect:]):
3421         (registerMockScrollbars):
3422         (prepareConsistentTestingEnvironment):
3423
3424 2012-01-05  Jon Lee  <jonlee@apple.com>
3425
3426         Update DRT on Mac to draw resize handles on text areas.
3427
3428         Reviewed by John Sullivan.
3429
3430         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
3431         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
3432
3433         * DumpRenderTree/mac/DumpRenderTree.mm:
3434         (resetDefaultsToConsistentValues):
3435
3436 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3437
3438         [Qt] Move listing of include paths and libs to pri files in sources
3439
3440         Includepaths are sometimes modified by non-Qt contributors so keeping
3441         them in files inside Sources makes it more likely that they are updated
3442         along with project files for the other ports.
3443
3444         Using pri files instead of prf files for this also has the benefit that
3445         the include() from the main target file can be parsed and followed by
3446         Qt Creator -- something that does not work with load().
3447
3448         Dependency from a target to a library through the WEBKIT variable are
3449         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
3450         set the source root of the module and include the right pri file.
3451
3452         Ideally we'd use the variant of include() that takes an optional
3453         namespace to read the variables into, or the fromfile() function,
3454         but both of these add an overhead of about 40% on the total qmake
3455         runtime, due to making a deep copy of all the variables in the
3456         project or re-reading all the prf files from scratch.
3457
3458         Reviewed by Simon Hausmann.
3459         Reviewed by Ossy.
3460
3461         * qmake/mkspecs/features/default_post.prf:
3462         * qmake/mkspecs/modules/javascriptcore.prf: Added.
3463         * qmake/mkspecs/modules/webcore.prf: Added.
3464         * qmake/mkspecs/modules/webkit2.prf: Added.
3465         * qmake/mkspecs/modules/wtf.prf: Added.
3466
3467 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
3468
3469         [EFL] Add pre-render handling code in EWebLauncher.
3470         https://bugs.webkit.org/show_bug.cgi?id=73430
3471
3472         Reviewed by Zoltan Herczeg.
3473
3474         Add pre-render handling code by pressing Insert key.
3475
3476         * EWebLauncher/main.c:
3477         (on_key_down):
3478
3479 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
3480
3481         NRWT should use test_expectation.txt on wk2 platforms
3482         https://bugs.webkit.org/show_bug.cgi?id=75417
3483
3484         Reviewed by Dirk Pranke.
3485
3486         * Scripts/webkitpy/layout_tests/port/webkit.py:
3487         (path_to_test_expectations_file):
3488         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3489         (test_path_to_test_expectations_file):
3490
3491 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
3492
3493         Don't hardcode expected file URIs in as they depend on the platform
3494         https://bugs.webkit.org/show_bug.cgi?id=75666
3495
3496         Reviewed by Dirk Pranke.
3497
3498         * Scripts/webkitpy/layout_tests/port/win.py:
3499         (WinPort.show_results_html_file):
3500         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3501         (MainTest.test_unexpected_failures):
3502         (MainTest.test_results_directory_default):
3503         (MainTest.test_results_directory_relative):
3504
3505 2012-01-05  Anders Carlsson  <andersca@apple.com>
3506
3507         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
3508         https://bugs.webkit.org/show_bug.cgi?id=75667
3509         <rdar://problem/10389454>
3510
3511         Reviewed by Kevin Decker.
3512
3513         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
3514
3515         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3516         (PluginTest::executeScript):
3517         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3518         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
3519         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
3520         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
3521         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
3522
3523 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3524
3525         webkitpy: clean up port factory methods
3526         https://bugs.webkit.org/show_bug.cgi?id=75590
3527
3528         Reviewed by Eric Seidel.
3529
3530         This change consolidates much of the "factory method" logic
3531         of determining which port objects to create for a given set
3532         of configurations by merging the separate factory methods in
3533         chromium_gpu and google_chrome into PortFactory so that at least
3534         all of the logic is in one place.
3535
3536         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3537         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3538         * Scripts/webkitpy/layout_tests/port/factory.py:
3539         (_port_name_from_arguments_and_options):
3540         (get):
3541         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3542         (test_google_chrome):
3543         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3544         (GoogleChromeLinux32Port):
3545         (GoogleChromeLinux32Port.baseline_search_path):
3546         (test_expectations_overrides):
3547         (architecture):
3548         (GoogleChromeLinux64Port):
3549         (GoogleChromeLinux64Port.baseline_search_path):
3550         (GoogleChromeMacPort):
3551         (GoogleChromeMacPort.baseline_search_path):
3552         (GoogleChromeWinPort):
3553         (GoogleChromeWinPort.baseline_search_path):
3554         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3555         (_verify_baseline_path):
3556
3557 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
3558
3559         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
3560         https://bugs.webkit.org/show_bug.cgi?id=75617
3561
3562         Reviewed by Dirk Pranke.
3563
3564         * Scripts/webkitpy/common/system/filesystem.py:
3565         (FileSystem.exists):
3566         * Scripts/webkitpy/common/system/filesystem_mock.py:
3567         (MockFileSystem.exists):
3568         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3569         (GenericFileSystemTests.teardown_generic_test_dir):
3570         * Scripts/webkitpy/layout_tests/port/base.py:
3571         (Port.to.show_results_html_file):
3572         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3573         (MainTest.test_results_directory_absolute):
3574
3575 2012-01-05  Adam Roben  <aroben@apple.com>
3576
3577         Remove some unnecessary code from old-run-webkit-tests
3578
3579         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
3580         WebKitTestRunner.
3581
3582         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
3583         Windows
3584
3585         Reviewed by Eric Seidel.
3586
3587         * Scripts/old-run-webkit-tests:
3588         (top level):
3589         (openDumpTool):
3590         Removed calls to setPathForRunningWebKitApp.
3591
3592 2012-01-05  Adam Roben  <aroben@apple.com>
3593
3594         Teach NRWT to use run-safari to open results.html on Apple's Windows port
3595
3596         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
3597         better, since we always want to open results.html using the user's build of WebKit, not
3598         whatever their default browser is.
3599
3600         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
3601         for Apple's Windows port
3602
3603         Reviewed by Eric Seidel.
3604
3605         * Scripts/webkitpy/layout_tests/port/win.py:
3606         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
3607         an obsolete comment.
3608
3609         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3610         (WinPortTest.test_show_results_html_file): Updated expected results.
3611
3612 2012-01-05  Adam Roben  <aroben@apple.com>
3613
3614         Prepend Safari.exe's path to the command-line passed to CreateProcess
3615
3616         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
3617         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
3618         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
3619         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
3620         first argument that WebKitLauncherWin was trying to pass to it.
3621
3622         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
3623
3624         Reviewed by Steve Falkenburg.
3625
3626         * WebKitLauncherWin/WebKitLauncherWin.cpp:
3627         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
3628         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
3629
3630 2012-01-05  Adam Roben  <aroben@apple.com>
3631
3632         Stop using explicit memory management in WebKitLauncherWin
3633
3634         We now use stack-allocated STL objects instead.
3635
3636         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
3637         Safari
3638
3639         Reviewed by Steve Falkenburg.
3640
3641         * WebKitLauncherWin/WebKitLauncherWin.cpp:
3642         (getStringValue):
3643         (applePathFromRegistry):
3644         (safariInstallDir):
3645         (safariBrowserExe):
3646         (_tWinMain):
3647         Changed to use stack-allocated STL objects instead of malloc/free.
3648
3649 2012-01-05  Adam Roben  <aroben@apple.com>
3650
3651         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
3652
3653         This allows us to add the Safari and Apple Application Support directories to PATH before
3654         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3655
3656         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3657         Windows port of DumpRenderTree/WebKitTestRunner
3658
3659         Reviewed by Steve Falkenburg.
3660
3661         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
3662         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
3663
3664         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3665         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3666         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
3667
3668         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
3669         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
3670         the stub launcher.
3671
3672         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
3673         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
3674         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
3675         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
3676         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
3677         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
3678         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
3679
3680         * WebKitTestRunner/win/main.cpp:
3681         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3682
3683 2012-01-05  Adam Roben  <aroben@apple.com>
3684
3685         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
3686