iOS Simulator LayoutTestRelay
[WebKit-https.git] / Tools / ChangeLog
1 2014-07-29  David Farler  <dfarler@apple.com>
2
3         iOS Simulator LayoutTestRelay
4         https://bugs.webkit.org/show_bug.cgi?id=135269
5
6         Reviewed by David Kilzer.
7
8         * LayoutTestRelay/Configurations/Base.xcconfig: Added.
9         * LayoutTestRelay/Configurations/DebugRelease.xcconfig: Added.
10         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: Added.
11         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.h: Added.
12         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.m: Added.
13         (-[LTPipeRelay inPipePath]):
14         (-[LTPipeRelay outPipePath]):
15         (-[LTPipeRelay errorPipePath]):
16         (-[LTPipeRelay outputStream]):
17         (-[LTPipeRelay initWithPrefix:]):
18         (-[LTPipeRelay setup]):
19         (-[LTPipeRelay tearDown]):
20         (-[LTPipeRelay connect]):
21         (-[LTPipeRelay disconnect]):
22         (-[LTPipeRelay createFIFOs]):
23         (-[LTPipeRelay destroyFIFOs]):
24         (-[LTPipeRelay relayStream:]):
25         (-[LTPipeRelay stream:handleEvent:]):
26         * LayoutTestRelay/LayoutTestRelay/LTRelay.h: Added.
27         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h: Added.
28         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: Added.
29         (-[LTRelayController uniqueAppPath]):
30         (-[LTRelayController uniqueAppURL]):
31         (-[LTRelayController uniqueAppIdentifier]):
32         (-[LTRelayController processName]):
33         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
34         (-[LTRelayController readFileHandle:]):
35         (-[LTRelayController receivedStandardOutputData:]):
36         (-[LTRelayController receivedStandardErrorData:]):
37         (-[LTRelayController disconnected]):
38         (-[LTRelayController connected]):
39         (-[LTRelayController crashWithMessage:]):
40         (-[LTRelayController launchSimulator]):
41         (-[LTRelayController bootDevice]):
42         (-[LTRelayController createUniqueApp]):
43         (-[LTRelayController killApp]):
44         (-[LTRelayController launchApp]):
45         (-[LTRelayController start]):
46         * LayoutTestRelay/LayoutTestRelay/main.m: Added.
47         (usage):
48         (getTestingSimDevice):
49         (getRequiredStringArgument):
50         (getRemainderArguments):
51         (main):
52         * LayoutTestRelay/Makefile: Added.
53         * Tools/Scripts/build-layouttestrelay: Added.
54
55 2014-07-29  Brent Fulgham  <bfulgham@apple.com>
56
57         [Win] Modify version numbering scheme to support 5-tuple versions
58         https://bugs.webkit.org/show_bug.cgi?id=135400
59         <rdar://problem/17849033>
60
61         Reviewed by David Kilzer.
62
63         Update test cases to recognize that we can only support Major
64         values from 0-65535, Minor values from 0-64, Tiny values from 0-999,
65         Micro values from 0-64, and Nano values from 0-999.
66
67         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Update
68         test expectations for physical limits.
69
70 2014-07-30  Carlos Garcia Campos  <cgarcia@igalia.com>
71
72         [GTK] GLib tests fail with recent GTK+ due to runtime warning about deprecated properties
73         https://bugs.webkit.org/show_bug.cgi?id=135411
74
75         Reviewed by Sergio Villar Senin.
76
77         Recent versions of GTK+ now warn at runtime when a deprecated
78         property or signal is used. A diagnostic mode was added that is
79         enabled by default, but that can be disabled by setting
80         G_ENABLE_DIAGNOSTIC=0. Runtime warnings are considered test
81         failures by gtester, so we need to run the tests with the
82         diganostic mode disabled.
83
84         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
85         (main):
86
87 2014-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
88
89         [GTK] Remove WebKitCertificateInfo from WebKit2GTK+ API
90         https://bugs.webkit.org/show_bug.cgi?id=134830
91
92         Reviewed by Gustavo Noronha Silva.
93
94         Update the SSL test for the API changes.
95
96         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
97         (testLoadFailedWithTLSErrors):
98
99 2014-07-24  David Farler  <dfarler@apple.com>
100
101         Add knowledge of the iOS Simulator to webkitpy
102         http://bugs.webkit.org/show_bug.cgi?id=133963
103
104         Reviewed by Simon Fraser.
105
106         * Scripts/webkitdirs.pm:
107         (argumentsForConfiguration): Add --ios-sim*
108         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
109         --runtime and --device-type args added.
110         * Scripts/webkitpy/port/base.py:
111         * Scripts/webkitpy/port/driver.py: Add simulator driver.
112         (IOSSimulatorDriver): Added.
113         * Scripts/webkitpy/port/factory.py: Add simulator platform.
114         * Scripts/webkitpy/port/ios.py: Added.
115
116 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
117
118         fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
119         https://bugs.webkit.org/show_bug.cgi?id=135398
120
121         Reviewed by Zalan Bujtas.
122
123         * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
124         "hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.
125
126         * DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
127         For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
128         sure why.
129
130 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
131
132         PPT: run-webkit-tests doesn't upload crash logs to bots
133         https://bugs.webkit.org/show_bug.cgi?id=135391
134
135         Reviewed by Joseph Pecoraro.
136
137         * WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):
138         Not a fix to be proud of, but better than not having it work at all.
139
140 2014-07-29  Adrian Perez de Castro  <aperez@igalia.com>
141
142         [GTK] Remove WebKitWebViewGroup from WebKit2 GTK+ API
143         https://bugs.webkit.org/show_bug.cgi?id=133729
144
145         Reviewed by Carlos Garcia Campos.
146
147         Removes WebKitWebViewGroup, effectively reverting the changes
148         introduced by r149117. The motivation for WebKitWebViewGroup
149         was using the user style sheet injection API, which has been
150         moved into WebKitUserContentManager, rendering it unneeded.
151
152         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Remove tests
153         for WebKitWebViewGroup.
154         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
155         (testWebViewSettings):
156         Restore the assertions that check that settings objects are
157         released. Add test for webkit_web_view_new_with_settings().
158         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Removed.
159
160 2014-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
161
162         Implement webkit_web_view_load_string() in WebKit2
163         https://bugs.webkit.org/show_bug.cgi?id=134735
164
165         Reviewed by Sergio Villar Senin.
166
167         Add /webkit2/WebKitWebView/load-bytes test case and simplify
168         TestDOMXPathNSResolver by using webkit_web_view_load_bytes()
169         instead of a soup server just to sent the Content-type header.
170
171         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
172         (testWebKitDOMXPathNSResolverNative):
173         (testWebKitDOMXPathNSResolverCustom):
174         (beforeAll):
175         (afterAll):
176         (serverCallback): Deleted.
177         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
178         (testLoadBytes):
179         (beforeAll):
180         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
181         (LoadTrackingTest::loadBytes):
182         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
183         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
184         (WebViewTest::loadBytes):
185         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
186
187 2014-07-28  Daniel Bates  <dabates@apple.com>
188
189         Add support for running the Clang static analyzer when building WebKit and JSC
190         https://bugs.webkit.org/show_bug.cgi?id=134955
191
192         Reviewed by Brent Fulgham.
193
194         * Scripts/build-jsc: Added command line options -[no]-analyze (disabled by default).
195         * Scripts/build-webkit: Add --analyze command line option to build-webkit to enable
196         running the Clang static analyzer.
197         * Scripts/webkitdirs.pm:
198         (XcodeStaticAnalyzerOption): Added.
199
200 2014-07-24  David Farler  <dfarler@apple.com>
201
202         Allow for multiple DumpRenderTree and WebKitTestRunner instances in the iOS Simulator
203         https://bugs.webkit.org/show_bug.cgi?id=135272
204
205         Reviewed by Simon Fraser.
206
207         * DumpRenderTree/mac/DumpRenderTree.mm:
208         (dumpRenderTree): Remove hard-coding of FIFO paths.
209         (-[DumpRenderTree applicationDidEnterBackground:]): Create background task.
210         (DumpRenderTreeMain): Set DumpRenderTree as UIApplication delegate.
211         * DumpRenderTree/mac/DumpRenderTreeMac.h: bgTask ivar.
212         * Scripts/old-run-webkit-tests: Update FIFO paths for ORWT.
213         * WebKitTestRunner/TestController.cpp: Remove hard-coding of FIFO paths.
214         * WebKitTestRunner/ios/TestControllerIOS.mm: Move dup2 calls to platformInitialize
215         * WebKitTestRunner/ios/mainIOS.mm: bgTask ivar.
216         (-[WebKitTestRunnerApp applicationDidEnterBackground:]): Create background task.
217         (main): Set WebKitTestRunnerApp as UIApplication delegate.
218
219 2014-07-24  David Farler  <dfarler@apple.com>
220
221         ImageDiff builds for the simulator when running iOS layout tests
222         https://bugs.webkit.org/show_bug.cgi?id=135270
223
224         Reviewed by Simon Fraser.
225
226         * Scripts/build-imagediff: Added.
227
228 2014-07-28  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
229
230         Followup fix after r171594
231         https://bugs.webkit.org/show_bug.cgi?id=135048
232
233         Reviewed by Csaba Osztrogonác.
234
235         * Scripts/sort-export-file: Removed extra newlines from help.
236
237 2014-07-25  Anders Carlsson  <andersca@apple.com>
238
239         WKNavigation's properties are either always nil or don't behave as documented
240         https://bugs.webkit.org/show_bug.cgi?id=135267
241         <rdar://problem/17730536>
242
243         Reviewed by Andreas Kling.
244
245         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
246         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
247         (TEST):
248         (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
249         (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
250
251 2014-07-25  Michael Catanzaro  <mcatanzaro@igalia.com>
252
253         [GTK] install-dependencies needs to install perl-CGI on Fedora
254         https://bugs.webkit.org/show_bug.cgi?id=135302
255
256         Reviewed by Martin Robinson.
257
258         * gtk/install-dependencies:
259         Add perl-CGI to yum dependencies needed for tests
260
261 2014-07-25  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
262
263         Add --dry-run option to sort-export-file
264         https://bugs.webkit.org/show_bug.cgi?id=135048
265
266         Reviewed by Csaba Osztrogonác.
267
268         Added --dry-run option to sort-export-file. Running the script with --dry-run
269         option does not sort the export files but creates a list of the files that
270         need to be sorted.
271
272         * Scripts/sort-export-file:
273         (sawError):
274
275 2014-07-24  Michael Catanzaro  <mcatanzaro@igalia.com>
276
277         GTK jhbuild modules needs to build xserver with --disable-local-transport
278         https://bugs.webkit.org/show_bug.cgi?id=135262
279
280         Reviewed by Martin Robinson.
281
282         * gtk/jhbuild.modules:
283         Build X server with --disable-local-transport, since local transport
284         is only supported on Solaris, SCO, and System V. Fixes build on
285         Fedora.
286
287 2014-07-24  Michael Catanzaro  <mcatanzaro@igalia.com>
288
289         [GTK] build-webkit script fails under jhbuild if ACLOCAL_FLAGS is unset
290         https://bugs.webkit.org/show_bug.cgi?id=135065
291
292         Reviewed by Martin Robinson.
293
294         * jhbuild/jhbuild-wrapper:
295         (ensure_jhbuild): do not assume jhbuild sets ACLOCAL_FLAGS
296
297 2014-07-23  Joseph Pecoraro  <pecoraro@apple.com>
298
299         Unreviewed iOS build fix after r171355.
300
301         * TestWebKitAPI/Configurations/Base.xcconfig:
302         Since all the Tests/WebKit2Cocoa tests are already explicitly skipped on iOS,
303         simplify to skipping all the tests in the directory. PlatformUtilities are not
304         building on iOS, which means we are missing necessary Util functions.
305
306 2014-07-23  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
307
308         [EFL] Fix build after r171454
309         https://bugs.webkit.org/show_bug.cgi?id=135191
310
311         Reviewed by Csaba Osztrogonác.
312
313         * MiniBrowser/efl/CMakeLists.txt: Add path to new EWebKit2.h location .
314
315 2014-07-23  Ryuan Choi  <ryuan.choi@samsung.com>
316
317         [EFL] Do not generate forwarding header for ewk headers
318         https://bugs.webkit.org/show_bug.cgi?id=135147
319
320         Reviewed by Gyuyoung Kim.
321
322         * WebKitTestRunner/EventSenderProxy.h:
323
324 2014-07-21  Sam Weinig  <sam@webkit.org>
325
326         [Cocoa] WKScriptMessageHandlers don't seem to function properly after navigating
327         https://bugs.webkit.org/show_bug.cgi?id=135148
328
329         Reviewed by Geoffrey Garen.
330
331         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
332         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Added.
333         (-[SimpleNavigationDelegate webView:didFinishNavigation:]):
334         (-[ScriptMessageHandler userContentController:didReceiveScriptMessage:]):
335
336 2014-07-22  Brent Fulgham  <bfulgham@apple.com>
337
338         Correct handling of __VERSION_TEXT__ for 4+-tuple versions
339         https://bugs.webkit.org/show_bug.cgi?id=135161
340         <rdar://problem/17763546>
341
342         Reviewed by David Kilzer.
343
344         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
345         Add additional test cases to catch errors in multiple-tuple
346         version string handling.
347
348 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
349
350         Extend exception fuzzing to the LLInt
351         https://bugs.webkit.org/show_bug.cgi?id=135076
352
353         Reviewed by Oliver Hunt.
354
355         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
356
357 2014-07-22  Jochen Eisinger  <jochen@chromium.org>
358
359         Fix my email address in contributors.json
360         https://bugs.webkit.org/show_bug.cgi?id=135156
361
362         Reviewed by Gyuyoung Kim.
363
364         * Scripts/webkitpy/common/config/contributors.json:
365
366 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
367
368         Unreviewed test fix.
369
370         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Revert
371         to older Perl 5.8 syntax for iterating over hashes to allow tests to
372         run on Mountain Lion bots.
373
374 2014-07-21  Alexey Proskuryakov  <ap@apple.com>
375
376         https://bugs.webkit.org/show_bug.cgi?id=135137
377         build.webkit.org/dashboard: webkitperl failures show up as yellow, not red
378
379         Reviewed by Darin Adler.
380
381         webkitperl results are binary, handle them the same way we handle bindings test results.
382
383         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
384         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
385         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
386
387 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
388
389         [Win] Follow-up for r171324.
390
391         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Cygwin
392         perl reports itself as 'cygwin'; native Windows Perl reports as
393         'MSWin32'. We need to handle both cases.
394
395 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
396
397         Unreviewed build fix after r171319.
398
399         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: This test should
400         only execute on Windows. It will fail on other platforms, so give it a way to
401         successfully exit.
402
403 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
404
405         [Win] Extend auto-version.pl to support 5-tuple versions
406         https://bugs.webkit.org/show_bug.cgi?id=135124
407         <rdar://problem/17750334>
408
409         Reviewed by David Kilzer.
410
411         Add test cases for auto-version.pl.
412
413         * Scripts/webkitperl/auto-version_unittest: Added.
414         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Added.
415
416 2014-07-21  Dean Jackson  <dino@apple.com>
417
418         Allow MiniBrowser WK1 to do element fullscreen
419         https://bugs.webkit.org/show_bug.cgi?id=135125
420
421         Reviewed by Simon Fraser.
422
423         Allow WK1 windows to go fullscreen using the DOM API.
424
425         * MiniBrowser/mac/WK1BrowserWindowController.m:
426         (-[WK1BrowserWindowController awakeFromNib]): Enable the preference for
427         fullscreen.
428
429 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
430
431         [GTK] Documentation files are added twice to the tarball
432         https://bugs.webkit.org/show_bug.cgi?id=135115
433
434         Reviewed by Sergio Villar Senin.
435
436         * gtk/manifest.txt: Remove duplicated rules.
437
438 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
439
440         [GTK] Simplify make-dist command line arguments
441         https://bugs.webkit.org/show_bug.cgi?id=134832
442
443         Reviewed by Martin Robinson.
444
445         Remove --tarball-root and -o command line options and add
446         --version, since the version can be used to build both, the
447         tarball root and the output filename. When the version it's not
448         provided, the pkg-config file is used to get the version. Also
449         change the default value of build-dir to the current directory,
450         since it's very common to call make-dist.py from the build dir.
451
452         * gtk/make-dist.py:
453         (get_tarball_root_and_output_filename_from_arguments):
454
455 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
456
457         [GTK] Reduce the size of the tarball generated by distcheck
458         https://bugs.webkit.org/show_bug.cgi?id=134802
459
460         Reviewed by Martin Robinson.
461
462         Add more rules to the manifest to decide what files to add:
463
464           - Do not include platform specific directories of other ports.
465           - Do not include port specific cmake files.
466           - Do not include Objective-C sources.
467           - Do not include .orig and .rej files.
468           - Do not include mac specific sandbox files.
469           - Only include the resources we actually build.
470
471         * gtk/manifest.txt:
472
473 2014-07-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
474
475         [EFL] Enable mpg123 feature for gst-plugin-bad.
476         https://bugs.webkit.org/show_bug.cgi?id=135016
477
478         Reviewed by Laszlo Gombos.
479
480         enable-mpg123 feature is added to jhbuild in order to support playback of mp3 format.
481
482         * efl/install-dependencies:
483         * efl/jhbuild.modules:
484
485 2014-07-20  Dan Bernstein  <mitz@apple.com>
486
487         Test for <rdar://problems/17742611> -[_WKActivatedElementInfo image] is often empty
488         https://bugs.webkit.org/show_bug.cgi?id=135107
489
490         Reviewed by Sam Weinig.
491
492         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
493         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMNode.mm: Added.
494         (-[RenderedImageFromDOMNodeFrameLoadDelegate webView:didFinishLoadForFrame:]):
495         (TestWebKitAPI::TEST):
496
497 2014-07-20  David Kilzer  <ddkilzer@apple.com>
498
499         Checker: Value stored to 'kernResult' is never read (LayoutTestHelper.m:164)
500         <http://webkit.org/b/135096>
501
502         Reviewed by Alexey Proskuryakov.
503
504         * DumpRenderTree/mac/LayoutTestHelper.m:
505         (lockDownDiscreteGraphics): Check the return values of
506         IOServiceOpen() and IOObjectRelease(), and log if not
507         KERN_SUCCESS.
508
509 2014-07-19  Anders Carlsson  <andersca@apple.com>
510
511         Update.
512
513         * Scripts/webkitpy/common/config/watchlist:
514
515 2014-07-18  Sam Weinig  <sam@webkit.org>
516
517         Revert accidental commit to MiniBrowser to make everything layer backed.
518
519         * MiniBrowser/mac/BrowserWindowController.m:
520         (-[BrowserWindowController windowDidLoad]):
521
522 2014-07-18  Dana Burkart  <dburkart@apple.com>
523
524         Add a new 'analyze' target to the makefile. This will make use of a new
525         'PATH_TO_SCAN_BUILD' which, if set will wrap xcodebuild in the clang
526         static analyzer.
527         https://bugs.webkit.org/show_bug.cgi?id=135057
528         <rdar://problem/10193187>
529
530         Reviewed by David Kilzer.
531
532         * Makefile:
533
534 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
535
536         Fix EFL+GTK.
537
538         * Scripts/run-jsc-stress-tests:
539
540 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
541
542         Exception fuzzing should work on iOS
543         https://bugs.webkit.org/show_bug.cgi?id=135070
544
545         Reviewed by Mark Hahnenberg.
546
547         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
548         (fail):
549         * Scripts/run-jsc-stress-tests:
550
551 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
552
553         run-jsc-stress-tests should be able to run helper-based tests in remote mode
554         https://bugs.webkit.org/show_bug.cgi?id=135064
555
556         Reviewed by Mark Hahnenberg.
557
558         * Scripts/run-jsc-stress-tests:
559
560 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
561
562         run-jsc-stress-tests: rename $copy to $doNotMessWithVMPath
563         https://bugs.webkit.org/show_bug.cgi?id=135061
564
565         Rubber stamped by Mark Hahnenberg.
566
567         * Scripts/run-jsc-stress-tests:
568
569 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
570
571         Refactor run-jsc-stress-tests VM copying code to remove some abstractions
572         https://bugs.webkit.org/show_bug.cgi?id=135059
573
574         Reviewed by Mark Lam.
575         
576         This is meant to make it easier for me to extend the copying functionality to copy things other than
577         the framework.
578
579         * Scripts/run-jsc-stress-tests:
580
581 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
582
583         Fix cloop build.
584
585         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
586
587 2014-07-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
588
589         Fix -v|--verbose option in sort-export-file script.
590         https://bugs.webkit.org/show_bug.cgi?id=135043
591
592         Reviewed by Tim Horton.
593
594         -v|--verbose option does not work. Option added to getOptionsResult.
595
596         * Scripts/sort-export-file:
597
598 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
599
600         Really remove dependency on ShellQuote.
601
602         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
603
604 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
605
606         Unreviewed, fix build for platforms that don't have ShellQuote.
607         
608         * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Take a single argument that has the whole command string.
609         * Scripts/run-jsc-stress-tests: Do the escaping in Ruby.
610
611 2014-07-15  Filip Pizlo  <fpizlo@apple.com>
612
613         Need ability to fuzz exception throwing
614         https://bugs.webkit.org/show_bug.cgi?id=134945
615         <rdar://problem/17722027>
616
617         Reviewed by Sam Weinig.
618         
619         Adds a new script, js-exception-fuzz, which will run some jsc command-line using
620         exception fuzzing. This means that we will force exceptions to be thrown in random
621         places to see how the engine reacts. This is now integrated with the various test
622         drivers, so run-javascriptcore-tests will run some exception fuzzing tests by
623         default.
624
625         * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Added.
626         (fail):
627         * Scripts/run-javascriptcore-tests:
628         * Scripts/run-jsc-stress-tests:
629
630 2014-07-17  Sam Weinig  <sam@webkit.org>
631
632         Fix failing API tests.
633
634         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
635         (-[ActiveOffscreenWindow isVisible]):
636         Override isVisible to make the NSWindows pretend they are visible.
637
638 2014-07-17  Alexey Proskuryakov  <ap@apple.com>
639
640         Disable button animations in regression tests
641         https://bugs.webkit.org/show_bug.cgi?id=133647
642         <rdar://problem/16677530>
643
644         Reviewed by Dean Jackson.
645
646         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
647         We already did this for WebKit2, let's do it for WebKit1 too.
648
649 2014-07-16  Alexey Proskuryakov  <ap@apple.com>
650
651         A test that hangs at cleanup stage confuses webkitpy hugely
652         https://bugs.webkit.org/show_bug.cgi?id=122475
653         <rdar://problem/17184354>
654
655         Reviewed by Anders Carlsson.
656
657         Terminate WebContent process if it freezes between tests. Ideally, we should report
658         this somehow, but this is better than blaming the wrong test.
659
660         * WebKitTestRunner/TestController.cpp:
661         (WTR::TestController::terminateWebContentProcess):
662         * WebKitTestRunner/TestController.h:
663         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
664
665 2014-07-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
666
667         Change style check path with EFL WK2's path in checker_unittest.py
668         https://bugs.webkit.org/show_bug.cgi?id=134967
669
670         Reviewed by Csaba Osztrogonác.
671
672         * Scripts/webkitpy/style/checker_unittest.py: Change ewk_view.h path.
673         (GlobalVariablesTest.test_path_rules_specifier):
674
675 2014-07-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
676
677         Unreviewed. Added myself to the list of committers.
678
679         * Scripts/webkitpy/common/config/contributors.json:
680
681 2014-07-15  Ryuan Choi  <ryuan.choi@samsung.com>
682
683         [EFL] Remove EFL WK1 directory from the checker.py
684         https://bugs.webkit.org/show_bug.cgi?id=134954
685
686         Reviewed by Gyuyoung Kim.
687
688         * Scripts/webkitpy/style/checker.py:
689
690 2014-07-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
691
692         Adding myself to contributors.json breaks a webkitpy test
693         https://bugs.webkit.org/show_bug.cgi?id=134958
694
695         Reviewed by Ryosuke Niwa.
696
697         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
698         (IRCCommandTest.test_whois): Be more specific and include also the
699         first name when asking for the whois of Xan in the unit test.
700
701 2014-07-14  Daniel Bates  <dabates@apple.com>
702
703         check-webkit-style should apply C++ rules to Objective-C++ files
704         https://bugs.webkit.org/show_bug.cgi?id=134884
705
706         Reviewed by Joseph Pecoraro.
707
708         Fixes an issue where check-webkit-style doesn't apply applicable C++ rules to
709         Objective-C++ files.
710
711         Currently check-webkit-style doesn't apply the following rules to Objective-C++
712         files: build/using_std, runtime/max_min_macros, runtime/wtf_move, readability/null.
713         Instead, we should teach check-webkit-style to apply these rules because, as
714         its name implies, an Objective-C++ file may contain C++ code.
715
716         * Scripts/webkitpy/style/checkers/cpp.py:
717         (_FileState.__init__): Add instance variable _is_objective_cpp to track whether a file has
718         extension mm (i.e. an Objective-C++ file).
719         (_FileState.is_objective_c_or_objective_cpp): Added; returns true if the file
720         has extension m or mm or if the file has extension h and contains Objective-C directives.
721         (check_for_null): No change in behavior; don't apply rule to Objective-C++ file.
722         (check_identifier_name_in_declaration): Substitute _FileState.is_objective_c_or_objective_cpp() for
723         _FileState.is_c_or_objective_c()
724         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
725         (WebKitStyleTest.test_null_false_zero): Added test case for Objective-C++ file.
726         (WebKitStyleTest.test_max_macro): Add test case for Objective-C and Objective-C++ file.
727         (WebKitStyleTest.test_min_macro): Ditto.
728         (WebKitStyleTest.test_wtf_move): Add test case for Objective-C++ file.
729
730 2014-07-14  Anders Carlsson  <andersca@apple.com>
731
732         Make shouldKeepCurrentBackForwardListItemInList part of WKPageLoaderClientV5 to avoid breaking ABI
733         https://bugs.webkit.org/show_bug.cgi?id=134889
734
735         Reviewed by Beth Dakin.
736
737         Bump loader version number to 5.
738
739         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
740         (TestWebKitAPI::setPageLoaderClient):
741         * WebKitTestRunner/TestController.cpp:
742         (WTR::TestController::createWebViewWithOptions):
743
744 2014-07-14  Daniel Bates  <dabates@apple.com>
745
746         Teach check-webkit-style to suggest WTF::move() when it sees std::move()
747         https://bugs.webkit.org/show_bug.cgi?id=134620
748
749         Reviewed by Joseph Pecoraro.
750
751         * Scripts/webkitpy/style/checkers/cpp.py:
752         (check_max_min_macros): Fix up comment so that it reads well.
753         (check_wtf_move): Added.
754         (check_style): Modified to call check_wtf_move().
755         (CppChecker): Add category "runtime/wtf_move".
756         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
757         (WebKitStyleTest.test_wtf_move): Added.
758
759 2014-07-12  Peter Szanka  <h868064@stud.u-szeged.hu>
760
761         Style checker complains about namespace indentation when there is no namespace
762         https://bugs.webkit.org/show_bug.cgi?id=105427
763
764         Reviewed by Darin Adler.
765
766         * Scripts/webkitpy/style/checkers/cpp.py:
767         (check_namespace_indentation):
768         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
769         (WebKitStyleTest.test_indentation):
770
771         The indentation level depends on the parantheses too, to avoid false warning in case of several statements inside macros.
772
773 2014-07-12  Daker Fernandes Pinheiro  <daker.pinheiro@openbossa.org>
774
775         Remove excessive nesting from _EnumState.process_clean_line at cpp style checker
776         https://bugs.webkit.org/show_bug.cgi?id=125317
777
778         Reviewed by Darin Adler.
779
780         * Scripts/webkitpy/style/checkers/cpp.py:
781         (_EnumState.process_clean_line):
782
783 2014-07-12  Brian Holt  <brian.holt@samsung.com>
784
785         Style Checker should prevent enums in bitfields
786         https://bugs.webkit.org/show_bug.cgi?id=57352
787
788         Reviewed by Darin Adler.
789
790         Added check that enums are not used as types for bitfields
791         and a unit test.
792
793         * Scripts/webkitpy/style/checkers/cpp.py:
794         (check_language):
795         (CppChecker):
796         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
797         (CppStyleTest):
798         (CppStyleTest.test_enum_bitfields):
799         (CppStyleTest.test_plain_integral_bitfields):
800
801 2014-07-10  Myles C. Maxfield  <mmaxfield@apple.com>
802
803         [iOS] Pasting rich content does not perform a two-step paste
804         https://bugs.webkit.org/show_bug.cgi?id=134795
805
806         Reviewed by Benjamin Poulain.
807
808         Two-step paste requires setting InputViewObeysDOMFocus on the UIWebBrowserView.
809
810         * DumpRenderTree/mac/DumpRenderTree.mm:
811         (createWebViewAndOffscreenWindow):
812
813 2014-07-10  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>
814
815         [GTK][CMake] Add a 'distcheck' target
816         https://bugs.webkit.org/show_bug.cgi?id=130675
817
818         Reviewed by Gustavo Noronha Silva.
819
820         Add --check option to make-dist script that builds and installs the tarball.
821
822         * gtk/make-dist.py:
823         (Distcheck.__init__):
824         (Distcheck.extract_tarball): Extratc the tarball.
825         (Distcheck.configure): Run cmake.
826         (Distcheck.configure.create_dir): Helper function to create a directory.
827         (Distcheck.build): Run make.
828         (Distcheck.install): Run make install.
829         (Distcheck.clean): Clean up the extracted tarball.
830         (Distcheck.check): Run all previous methods in order.
831         * gtk/manifest.txt: Add missing file.
832
833 2014-07-10  Carlos Garcia Campos  <cgarcia@igalia.com>
834
835         [GTK] Use the same default options for production builds that previous stable releases
836         https://bugs.webkit.org/show_bug.cgi?id=134589
837
838         Reviewed by Martin Robinson.
839
840         Make sure all features enabled in production builds are also
841         enabled in developer mode.
842
843         * Scripts/webkitperl/FeatureList.pm: Enable ACCELERATED_2D_CANVAS
844         and CSS_FILTERS for the GTK port.
845
846 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
847
848         [Win] Remove uses of 'bash' in build system
849         https://bugs.webkit.org/show_bug.cgi?id=134782
850         <rdar://problem/17615533>
851
852         Reviewed by Dean Jackson.
853
854         Remove uses of 'bash' by replacing Windows-specific bash scripts
855         with Perl equivalents.
856
857         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
858         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
859         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
860         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
861         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
862         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
863
864 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
865
866         [Win] Remove use of 'grep' in build steps
867         https://bugs.webkit.org/show_bug.cgi?id=134770
868         <rdar://problem/17608783>
869
870         Reviewed by Tim Horton.
871
872         Replace uses of the grep command in Windows builds with the equivalent
873         Perl program.
874
875         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
876         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
877         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
878         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
879         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
880         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
881
882 2014-07-09  Commit Queue  <commit-queue@webkit.org>
883
884         Unreviewed, rolling out r170889.
885         https://bugs.webkit.org/show_bug.cgi?id=134754
886
887         This patch is wrong (Requested by philn on #webkit).
888
889         Reverted changeset:
890
891         "[GTK] Gstreamer missing from the install-dependencies script"
892         https://bugs.webkit.org/show_bug.cgi?id=134727
893         http://trac.webkit.org/changeset/170889
894
895 2014-07-08  Brian J. Burg  <burg@cs.washington.edu>
896
897         resolve-ChangeLogs fails when WebKit repository is a git submodule
898         https://bugs.webkit.org/show_bug.cgi?id=134734
899
900         Reviewed by David Kilzer.
901
902         When using resolve-ChangeLogs in a WebKit git repository with a
903         non-default arrangement of GIT_DIR and GIT_WORK_TREE, incorrect
904         paths are computed and the script fails mysteriously.
905
906         We were naively computing GIT_WORK_TREE as being one level above
907         GIT_DIR, but this is not the case for submodules or a manually
908         configured GIT_WORK_TREE or GIT_DIR location.
909
910         * Scripts/VCSUtils.pm:
911         (gitTreeDirectory): Added. Find the equivalent of GIT_WORK_TREE.
912         (determineVCSRoot): Calculate the working tree root directly.
913
914 2014-07-08  Tim Horton  <timothy_horton@apple.com>
915
916         [WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
917         https://bugs.webkit.org/show_bug.cgi?id=134645
918
919         Reviewed by Dan Bernstein.
920
921         * MiniBrowser/mac/BrowserWindowController.h:
922         * MiniBrowser/mac/MainMenu.xib:
923         Add menu items for layer borders and the tiled scrolling indicator.
924
925         * MiniBrowser/mac/WK1BrowserWindowController.m:
926         (-[WK1BrowserWindowController validateMenuItem:]):
927         (-[WK1BrowserWindowController layerBordersAreVisible]):
928         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]):
929         Add getters/setters/validators for layer borders.
930
931         * MiniBrowser/mac/WK2BrowserWindowController.m:
932         (-[WK2BrowserWindowController awakeFromNib]):
933         (-[WK2BrowserWindowController validateMenuItem:]):
934         (-[WK2BrowserWindowController layerBordersAreVisible]):
935         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]):
936         (-[WK2BrowserWindowController tiledScrollingIndicatorIsVisible]):
937         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]):
938         Add getters/setters/validators for layer borders and the tiled scrolling indicator.
939
940         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
941         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
942         Remove the WebKit2 version of the subpixel metrics pref, because it doesn't work, because
943         nothing in WebKit2 reads this default, and there is no WebKit2 API for adjusting this preference.
944
945 2014-07-08  Adrian Perez de Castro  <aperez@igalia.com>
946
947         [GTK] Move user style sheet API out of WebKitWebViewGroup
948         https://bugs.webkit.org/show_bug.cgi?id=134551
949
950         Reviewed by Carlos Garcia Campos.
951
952         Removes testing user style sheet injection from
953         TestWebKitWebViewGroup and moves that into a new
954         TestWebKitUserContentManager, adapting the existing tests to the new
955         API. Also, it contains a new test case for
956         webkit_web_view_new_with_user_content_manager().
957
958         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
959         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: Added.
960         (UserContentManagerTest::UserContentManagerTest):
961         (testWebViewNewWithUserContentManager):
962         (isStyleSheetInjectedForURLAtPath):
963         (fillURLListFromPaths):
964         (removeOldInjectedStyleSheetsAndResetLists):
965         (testUserContentManagerInjectedStyleSheet):
966         (serverCallback):
967         (beforeAll):
968         (afterAll):
969         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
970         (beforeAll):
971         (afterAll):
972         (isStyleSheetInjectedForURLAtPath): Deleted.
973         (fillURLListFromPaths): Deleted.
974         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
975         (testWebViewGroupInjectedStyleSheet): Deleted.
976         (serverCallback): Deleted.
977         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
978         (WebViewTest::WebViewTest):
979         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
980
981 2014-07-08  Ziran Sun  <ziran.sun@samsung.com>
982
983         [GTK] Gstreamer missing from the install-dependencies script
984         https://bugs.webkit.org/show_bug.cgi?id=134727
985
986         Reviewed by Mario Sanchez Prada.
987
988         Added missing gstreamer dependencies for debian based systems.
989
990         * gtk/install-dependencies: Added 2 dependencies for apt-get.
991
992 2014-07-08  Myles C. Maxfield  <mmaxfield@apple.com>
993
994         Add myself to the watchlist for text-related files
995         https://bugs.webkit.org/show_bug.cgi?id=134707
996
997         Reviewed by Timothy Horton.
998
999         * Scripts/webkitpy/common/config/watchlist:
1000
1001 2014-07-08  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1002
1003         Add option to specify output file location in sunspider.
1004         https://bugs.webkit.org/show_bug.cgi?id=134339
1005
1006         Reviewed by Darin Adler.
1007
1008         * Scripts/run-sunspider:
1009
1010 2014-07-07  Alex Christensen  <achristensen@webkit.org>
1011
1012         Unreviewed build fix.
1013
1014         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1015         Make Common.cpp excluded from both 32-bit and 64-bit builds.
1016
1017 2014-07-07  Simon Fraser  <simon.fraser@apple.com>
1018
1019         Have MiniBrowser log and reload if the Web Content Process crashes
1020         https://bugs.webkit.org/show_bug.cgi?id=134691
1021
1022         Reviewed by Tim Horton.
1023         
1024         Implement _webViewWebProcessDidCrash, log and reload when the web process
1025         crashes.
1026
1027         * MiniBrowser/mac/WK2BrowserWindowController.m:
1028         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]):
1029
1030 2014-07-07  Alberto Garcia  <berto@igalia.com>
1031
1032         update-webkitgtk-libs script fails by unsatisfied dependencies
1033         https://bugs.webkit.org/show_bug.cgi?id=134547
1034
1035         Reviewed by Martin Robinson.
1036
1037         Install libxcb-xfixes0-dev, needed to build Mesa.
1038
1039         * gtk/install-dependencies:
1040
1041 2014-07-06  Yoav Weiss  <yoav@yoav.ws>
1042
1043         Turn on img@sizes compile flag
1044         https://bugs.webkit.org/show_bug.cgi?id=134634
1045
1046         Reviewed by Benjamin Poulain.
1047
1048         * Scripts/webkitperl/FeatureList.pm: Turn on the img@sizes feature.
1049
1050 2014-07-06  Hyowon Kim  <hw1008.kim@samsung.com>
1051
1052         Unreviewed. Adding myself to committers.
1053
1054         * Scripts/webkitpy/common/config/contributors.json:
1055
1056 2014-07-05  KwangHyuk Kim  <hyuki.kim@samsung.com>
1057
1058         [EFL] Add libgeoclue-dev to Tools/efl/install-dependencies.
1059         https://bugs.webkit.org/show_bug.cgi?id=134648
1060
1061         Reviewed by Gyuyoung Kim.
1062
1063         As Geoclue is enabled for EFL, libgeoclue-dev is also added to Tools/efl/install-dependencies.
1064
1065         * efl/install-dependencies:
1066
1067 2014-07-04  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1068
1069         [EFL] Support Geolocation
1070         https://bugs.webkit.org/show_bug.cgi?id=134439
1071
1072         Reviewed by Antonio Gomes.
1073
1074         * Scripts/webkitperl/FeatureList.pm: Enable geolocation for EFL port.
1075
1076 2014-07-04  Shivakumar JM  <shiva.jm@samsung.com>
1077
1078         [EFL][WK2] Enhance the Minibrowser to show selected/highlighted text in search bar, if any.
1079         https://bugs.webkit.org/show_bug.cgi?id=134485
1080
1081         Reviewed by Gyuyoung Kim.
1082
1083         Use script_execute_callback to get selected/highlighted text and show in search bar.
1084
1085         * MiniBrowser/efl/main.c:
1086         (script_execute_callback):
1087         (on_key_down):
1088
1089 2014-07-04  Dan Bernstein  <mitz@apple.com>
1090
1091         Build fix after r170811.
1092
1093         * MiniBrowser/mac/WK2BrowserWindowController.m:
1094         (-[WK2BrowserWindowController reload:]):
1095
1096 2014-07-04  Timothy Horton  <timothy_horton@apple.com>
1097
1098         Typo in watchlist config means four specific people get Cc'd on everything
1099         https://bugs.webkit.org/show_bug.cgi?id=134626
1100
1101         Reviewed by Gyuyoung Kim.
1102
1103         * Scripts/webkitpy/common/config/watchlist:
1104         Remove leading pipe, which meant that this rule matched everything!
1105
1106 2014-07-03  Shivakumar JM  <shiva.jm@samsung.com>
1107
1108         [EFL][WK2] Enhance the Minibrowser to show text search count and close search bar.
1109         https://bugs.webkit.org/show_bug.cgi?id=134486
1110
1111         Reviewed by Gyuyoung Kim.
1112
1113         Use on_search_close_button_clicked() callback to close search bar and on_search_text_found() callback to show search count.
1114
1115         * MiniBrowser/efl/main.c:
1116         (search_box_show):
1117         (search_box_hide):
1118         (on_search_close_button_clicked):
1119         (on_search_text_found):
1120         (window_create):
1121
1122 2014-07-03  Daniel Bates  <dabates@apple.com>
1123
1124         Add WTF::move()
1125         https://bugs.webkit.org/show_bug.cgi?id=134500
1126
1127         Rubber-stamped by Anders Carlsson.
1128
1129         Substitute WTF::move() for std::move().
1130
1131         * DumpRenderTree/win/DRTDataObject.cpp:
1132         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1133         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1134         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1135         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1136         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1137         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added FIXME comments that explain that some of the sub-tests
1138         aren't actually testing move semantics in tests: MoveAssignmentFromSameType, MoveAssignmentFromSimilarType,
1139         ConstructionFromSameType, and ConstructionFromSimilarType.
1140         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1141
1142 2014-07-03  László Langó  <llango.u-szeged@partner.samsung.com>
1143
1144         [JavaScriptCore] Add --cmakeargs option to build-jsc.
1145         https://bugs.webkit.org/show_bug.cgi?id=134590
1146
1147         Reviewed by Ryosuke Niwa.
1148
1149         * Scripts/build-jsc:
1150
1151 2014-07-03  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1152
1153         Add option to specify jsc args in run-sunspider.
1154         https://bugs.webkit.org/show_bug.cgi?id=134341
1155
1156         Reviewed by Csaba Osztrogonác.
1157
1158         * Scripts/run-sunspider:
1159
1160 2014-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1161
1162         [GTK] Unreviewed gardening.
1163
1164         * Scripts/run-gtk-tests:
1165         (TestRunner): Report and mark flaky test WebKit2Gtk/TestCookieManager:persistent-storage
1166
1167 2014-07-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1168
1169         Clean up unused EFL buildbot information in BuildSlaveSupport and TestResultServer
1170         https://bugs.webkit.org/show_bug.cgi?id=134581
1171
1172         Reviewed by Tim Horton.
1173
1174         Should be removed unused EFL bot info.
1175
1176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1177         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1178         (EWS):
1179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1180         (WebKitBuildbot):
1181         * TestResultServer/static-dashboards/builders.jsonp:
1182         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1183         (test):
1184
1185 2014-07-02  Alex Christensen  <achristensen@webkit.org>
1186
1187         Unreviewed.  Moved self to reviewers list.
1188
1189         * Scripts/webkitpy/common/config/contributors.json:
1190         Moved self to reviewers list, added WebGL to expertise.
1191
1192 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1193
1194         [GTK] Make dist only works when run from the source directory
1195         https://bugs.webkit.org/show_bug.cgi?id=134543
1196
1197         Reviewed by Martin Robinson.
1198
1199         Since the paths in the manifest are relative to the source dir,
1200         and the script expects the current working directory to be the
1201         source directory, resolve all passed in relative paths while
1202         parsing the arguments and then change the current working
1203         directory.
1204
1205         * gtk/make-dist.py:
1206
1207 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1208
1209         [GTK] make dist is broken
1210         https://bugs.webkit.org/show_bug.cgi?id=134542
1211
1212         Reviewed by Martin Robinson.
1213
1214         * gtk/make-dist.py: Rename command line options to match what cmake uses.
1215         * gtk/manifest.txt: Remove WebKit1 references and add WebKitDOM documentation.
1216
1217 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1218
1219         [GTK] WebKitWebView::create should receive information about the navigation action
1220         https://bugs.webkit.org/show_bug.cgi?id=133680
1221
1222         Reviewed by Martin Robinson.
1223
1224         Add unit test to check the WebKitNavigationAction passed to
1225         WebKitWebView::create callback.
1226
1227         * MiniBrowser/gtk/BrowserWindow.c:
1228         (webViewCreate): Add WebKitNavigationAction parameter.
1229         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1230         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1231         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1232         (testWebViewCreateNavigationData):
1233         (beforeAll):
1234         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
1235         (createCallback):
1236
1237 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1238
1239         [GTK] Do not add forward declaration of class struct for interfaces
1240         https://bugs.webkit.org/show_bug.cgi?id=134297
1241
1242         Reviewed by Martin Robinson.
1243
1244         Add Iface symbol to documentation instead of Class for interfaces.
1245
1246         * gtk/webkitdom.py:
1247         (WebKitDOMDocGeneratorSections.write_section):
1248
1249 2014-07-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1250
1251         [GTK] XPathNSResolver should be exposed as an interface instead of as a class
1252         https://bugs.webkit.org/show_bug.cgi?id=134028
1253
1254         Reviewed by Gustavo Noronha Silva.
1255
1256         Add unit tests to check WebKitDOMXPathNSResolver API when using the
1257         native one and a user provided one.
1258
1259         * Scripts/webkitpy/style/checker.py: Add WebKitDOMXPathNSResolver
1260         to the list of GTK+ public API exceptions.
1261         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
1262         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Added.
1263         (webkitXPathNSResolverLookupNamespaceURI):
1264         (webkitXPathNSResolverDOMXPathNSResolverIfaceInit):
1265         (webkit_xpath_ns_resolver_init):
1266         (webkit_xpath_ns_resolver_class_init):
1267         (WebKitDOMXPathNSResolverTest::create):
1268         (WebKitDOMXPathNSResolverTest::webPageFromArgs):
1269         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1270         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1271         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1272         (WebKitDOMXPathNSResolverTest::runTest):
1273         (registerTests):
1274         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Added.
1275         (runTest):
1276         (testWebKitDOMXPathNSResolverNative):
1277         (testWebKitDOMXPathNSResolverCustom):
1278         (serverCallback):
1279         (beforeAll):
1280         (afterAll):
1281         * gtk/webkitdom.py:
1282         (WebKitDOMDocGeneratorSections.write_section): Add
1283         WebKitDOMXPathNSResolver to the list of interfaces.
1284
1285 2014-07-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1286
1287         Fix build break on EFL and GTK ports since r170683
1288         https://bugs.webkit.org/show_bug.cgi?id=134536
1289
1290         Unreviewed, build fix.
1291
1292         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1293
1294 2014-07-01  Sam Weinig  <sam@webkit.org>
1295
1296         [Cocoa][Mac] WKWebView should automatically set topContentInset when beneath a toolbar
1297         <rdar://problem/17523159>
1298         https://bugs.webkit.org/show_bug.cgi?id=134496
1299
1300         Reviewed by Beth Dakin.
1301
1302         * MiniBrowser/mac/BrowserWindowController.m:
1303         (-[BrowserWindowController windowDidLoad]):
1304         Use the NSFullSizeContentViewWindowMask bit on Yosemite and later to enable toolbar blurring.
1305
1306 2014-07-01  Zan Dobersek  <zdobersek@igalia.com>
1307
1308         [CMake] Add necessary support for building for the Wayland target
1309         https://bugs.webkit.org/show_bug.cgi?id=134160
1310
1311         Reviewed by Darin Adler.
1312
1313         * CMakeLists.txt: Only build the TestNetscapePlugIn target in case
1314         the X11 windowing target is enabled.
1315
1316 2014-07-01  Chris Fleizach  <cfleizach@apple.com>
1317
1318         AX: HTML indeterminate IDL attribute not mapped to checkbox value=2
1319         https://bugs.webkit.org/show_bug.cgi?id=134492
1320
1321         Reviewed by Andreas Kling.
1322
1323         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1324         (AccessibilityUIElement::isIndeterminate):
1325         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1326         (WTR::AccessibilityUIElement::isIndeterminate):
1327
1328 2014-07-01  Daniel Bates  <dabates@apple.com>
1329
1330         Remove unnecessary calls to std::move()
1331         https://bugs.webkit.org/show_bug.cgi?id=134493
1332
1333         Reviewed by Anders Carlsson.
1334
1335         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1336         (TestWebKitAPI::TEST):
1337         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1338         (TestWebKitAPI::TEST):
1339
1340 2014-07-01  Pratik Solanki  <psolanki@apple.com>
1341
1342         Unreviewed. Adding myself to the reviewers list to make commit bot happy.
1343
1344         * Scripts/webkitpy/common/config/contributors.json:
1345
1346 2014-07-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1347
1348         webkit-patch apply-from-bug / apply-attachment should not ask for credentials if none are required
1349         https://bugs.webkit.org/show_bug.cgi?id=40095
1350
1351         Reviewed by Csaba Osztrogonác.
1352
1353         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1354         (Bugzilla.fetch_attachment_contents): make a first fetch on bugzilla without authentication. If failing, use authentication (similar to fetch_bug_dictionary).
1355         (Bugzilla):
1356         (Bugzilla.bug_id_for_attachment_id): ditto.
1357
1358 2014-07-01  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1359
1360         [webkitpy] Refactor pluralizer in grammar.py
1361         https://bugs.webkit.org/show_bug.cgi?id=133067
1362
1363         Reviewed by Csaba Osztrogonác.
1364
1365         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1366         (LayoutTestRunner.run_tests):
1367         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1368         (Manager.run):
1369         * Scripts/webkitpy/layout_tests/views/printing.py:
1370         (Printer.print_found):
1371         (Printer.print_workers_and_shards):
1372         (Printer._print_one_line_summary):
1373         * Scripts/webkitpy/test/printer.py:
1374         (Printer.print_result):
1375         * Scripts/webkitpy/tool/bot/feeders.py:
1376         (EWSFeeder.feed):
1377         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1378         (FlakyTestReporter._lookup_bug_for_flaky_test):
1379         * Scripts/webkitpy/tool/bot/irc_command.py:
1380         (Rollout._check_diff_failure):
1381         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1382         (IRCCommandTest.test_rollout):
1383         * Scripts/webkitpy/tool/commands/download.py:
1384         (AbstractPatchProcessingCommand._process_patch.execute):
1385         (ProcessBugsMixin._fetch_list_of_patches_to_process):
1386         (ProcessURLsMixin._fetch_list_of_patches_to_process):
1387         * Scripts/webkitpy/tool/commands/queries.py:
1388         (WhatBroke.execute):
1389         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1390         (SuggestNominations._print_nominations):
1391         (SuggestNominations._print_counts):
1392         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1393         (_make_options):
1394         (test_basic):
1395         (test_with_verbose):
1396         * Scripts/webkitpy/tool/commands/upload.py:
1397         (PostCommits.execute):
1398         * Scripts/webkitpy/tool/grammar.py:
1399         (pluralize):
1400         * Scripts/webkitpy/tool/grammar_unittest.py:
1401         (GrammarTest.test_join_with_separators):
1402         (GrammarTest):
1403         (GrammarTest.test_plural):
1404         (GrammarTest.test_pluralize):
1405         * Scripts/webkitpy/tool/multicommandtool.py:
1406         (Command.check_arguments_and_execute):
1407         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1408         (ObsoletePatches.run):
1409         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1410         (PrepareChangeLogForRevert._message_for_revert):
1411
1412 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
1413
1414         [iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree
1415         https://bugs.webkit.org/show_bug.cgi?id=134133
1416
1417         Reviewed by Simon Fraser.
1418
1419         Replace it with CTFontManagerRegisterGraphicsFont
1420
1421         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1422         * DumpRenderTree/mac/DumpRenderTree.mm:
1423         (activateFontIOS):
1424
1425 2014-06-30  Michael Saboff  <msaboff@apple.com>
1426
1427         Add option to run-jsc-stress-testes to filter out tests that use large heaps
1428         https://bugs.webkit.org/show_bug.cgi?id=134458
1429
1430         Reviewed by Filip Pizlo.
1431
1432         Added new --memory-limited to filter out tests that have large heap usage.
1433         Such tests are either tagged with //@largeHeap or logic is added to their .yaml file.
1434
1435         * Scripts/run-jsc-stress-tests:
1436
1437 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
1438
1439         DRT in iOS sim crashes while loading fonts
1440         https://bugs.webkit.org/show_bug.cgi?id=134451
1441
1442         Reviewed by Geoffrey Garen.
1443
1444         The magic linker symbols had the same name, and were therefore being unified
1445         to a single font file. Then, adding the same file twice was failing.
1446
1447         * DumpRenderTree/mac/DumpRenderTree.mm:
1448         (activateFontsIOS):
1449
1450 2014-06-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1451
1452         Remove Qt cruft from webkitpy
1453         https://bugs.webkit.org/show_bug.cgi?id=134445
1454
1455         Reviewed by Csaba Osztrogonác.
1456
1457         * Scripts/webkitpy/common/config/ports.py:
1458         (DeprecatedPort.port):
1459         (QtPort): Deleted.
1460         (QtPort.build_webkit_command): Deleted.
1461         (QtPort.run_webkit_tests_command): Deleted.
1462         (QtWK2Port): Deleted.
1463         (QtWK2Port.build_webkit_command): Deleted.
1464         (QtWK2Port.run_webkit_tests_command): Deleted.
1465         * Scripts/webkitpy/common/config/ports_unittest.py:
1466         (DeprecatedPortTest): Deleted.
1467         (DeprecatedPortTest.test_qt_port): Deleted.
1468         (DeprecatedPortTest.test_qt_wk2_port): Deleted.
1469
1470 2014-06-29  Yoav Weiss  <yoav@yoav.ws>
1471
1472         Add support for HTMLImageElement's sizes attribute
1473         https://bugs.webkit.org/show_bug.cgi?id=133620
1474
1475         Reviewed by Dean Jackson.
1476
1477         Added an ENABLE_PICTURE_SIZES compile flag.
1478
1479         * Scripts/webkitperl/FeatureList.pm:
1480
1481 2014-06-27  Tim Horton  <timothy_horton@apple.com>
1482
1483         check-webkit-style should check the order of #imports as well as #includes
1484         https://bugs.webkit.org/show_bug.cgi?id=134428
1485
1486         Reviewed by Dan Bernstein.
1487
1488         * Scripts/webkitpy/style/checkers/cpp.py:
1489         Allow "import" in addition to "include", so that the sort order of headers in ObjC files is checked.
1490
1491 2014-06-27  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1492
1493         [EFL] Remove efl-wk2 from baseline search path
1494         https://bugs.webkit.org/show_bug.cgi?id=134391
1495
1496         Reviewed by Gyuyoung Kim.
1497
1498         As WebKit1 EFL is removed and platform/efl and platform/efl-wk2 baselines and test expectations files
1499         are merged efl-wk2 search path should be removed.
1500
1501         * Scripts/webkitpy/port/base.py:
1502         (Port.test_expectations_file_postion): Added method to determine port test expectations file position in expectations_dict.
1503         * Scripts/webkitpy/port/efl.py:
1504         (EflPort._search_paths): Changed baseline search paths from efl-wk2 -> wk2 -> efl -> generic is changed to: efl -> wk2 -> generic.
1505         (EflPort.test_expectations_file_postion): Added method to determine EFL port specific test expectation file position.
1506         * Scripts/webkitpy/port/port_testcase.py:
1507         (PortTestCase.test_expectations_ordering): Changed constant value to one returned from test_expectations_file_postion().
1508         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1509         (TestExpectationsTestCase.test_determine_port_from_expectations_path): Removed efl-wk2 test case.
1510         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1511         (TestRebaselineTest.test_baseline_directory): Changed directory name in assertion from platform/efl-wk2 to platform/efl.
1512
1513 2014-06-26  Dan Bernstein  <mitz@apple.com>
1514
1515         prepare-ChangeLog outputs (NS_ENUM): entries for Cocoa enums
1516         https://bugs.webkit.org/show_bug.cgi?id=134387
1517
1518         Reviewed by Tim Horton.
1519
1520         * Scripts/prepare-ChangeLog:
1521         (get_function_line_ranges_for_cpp): Don’t consider {CF,NS}_{ENUM,OPTIONS} as function names.
1522
1523 2014-06-26  Dan Bernstein  <mitz@apple.com>
1524
1525         prepare-ChangeLog mangles Objective-C selectors for methods with parameter types that contain colons
1526         https://bugs.webkit.org/show_bug.cgi?id=134383
1527
1528         Reviewed by Tim Horton.
1529
1530         * Scripts/prepare-ChangeLog:
1531         (method_decl_to_selector): Strip out the return type and parameter types before splitting at
1532         colons.
1533
1534 2014-06-26  Brady Eidson  <beidson@apple.com>
1535
1536         MiniBrowser should support a preference to override the default URL
1537         https://bugs.webkit.org/show_bug.cgi?id=134373
1538
1539         Reviewed by Darin Adler.
1540
1541         * MiniBrowser/mac/AppDelegate.m:
1542         (-[BrowserAppDelegate applicationDidFinishLaunching:]): See if there’s a pref
1543           overriding the default URL, and use it if there is.
1544
1545 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
1546
1547         [Win] Fix potential buffer overrun in DLLLauncher
1548         https://bugs.webkit.org/show_bug.cgi?id=134351
1549         <rdar://problem/17469185>
1550
1551         Reviewed by Darin Adler.
1552
1553         * win/DLLLauncher/DLLLauncherMain.cpp: Correct error
1554         in end-of-buffer calculation.
1555
1556 2014-06-26  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1557
1558         [EFL] Missing dependency between freetype6 and fontconfig libs.
1559         https://bugs.webkit.org/show_bug.cgi?id=134190
1560
1561         Reviewed by Gyuyoung Kim.
1562
1563         The external dependencies contain the freetype6 and the fontconfig libs.
1564         The fontconfig lib requires freetype, but the dependency is not set in
1565         the efl/jhbuild.modules file. So, during building the external libs,
1566         fontconfig uses the freetype package of the system, while WebKit
1567         binaries will use freetype from the WebKitBuild/Dependency directory.
1568         There are more similar dependencies that were not indicated in the
1569         jhbuild.modules file.
1570
1571         * efl/jhbuild.modules:
1572           Added dependencies between libs.
1573
1574 2014-06-25  Brent Fulgham  <bfulgham@apple.com>
1575
1576         [Win] Expose Cache Information to WinLauncher
1577         https://bugs.webkit.org/show_bug.cgi?id=134318
1578
1579         Reviewed by Dean Jackson.
1580
1581         * WinLauncher/Common.cpp: Update for new dialog.
1582         * WinLauncher/WinLauncher.cpp: Add support for WebCache
1583         and WebCoreStatistics.
1584         * WinLauncher/WinLauncher.h:
1585         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
1586         Update for new Cache Dialog.
1587         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to
1588         WTF.lib
1589         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
1590         for new Dialog.
1591
1592 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
1593
1594         [Win] Unreviewed gardening. Use consistent line-endings in file.
1595
1596         * WinLauncher/WinLauncher.h: Use '\n' EOL marker, not DOS-style
1597         '\r\n' EOL.
1598
1599 2014-06-25  László Langó  <llango.u-szeged@partner.samsung.com>
1600
1601         [JavaScriptCore] Make build-jsc output format better.
1602         https://bugs.webkit.org/show_bug.cgi?id=133547
1603
1604         Reviewed by Ryosuke Niwa.
1605
1606         * Scripts/build-jsc: Emit built time information on successful builds.
1607         (writeCongrats):
1608         * Scripts/build-webkit: Move formatBuildTime function into webkitdirs.pm.
1609         (cMakeArgsFromFeatures):
1610         (formatBuildTime): Deleted.
1611         * Scripts/webkitdirs.pm:
1612         (formatBuildTime):
1613
1614 2014-06-25  Chris Fleizach  <cfleizach@apple.com>
1615
1616         Add an undo group for each dictated utterance in WebKit
1617         https://bugs.webkit.org/show_bug.cgi?id=134086
1618
1619         Reviewed by Enrica Casucci.
1620
1621         Create a method for creating attributed strings with the undo insertion marker.
1622
1623         * DumpRenderTree/mac/TextInputController.m:
1624         (+[TextInputController isSelectorExcludedFromWebScript:]):
1625         (+[TextInputController webScriptNameForSelector:]):
1626         (-[TextInputController stringWithUndoGroupingInsertion:]):
1627
1628 2014-06-25  Michael Saboff  <msaboff@apple.com>
1629
1630         Provide javascript aware backtrace script for lldb
1631         https://bugs.webkit.org/show_bug.cgi?id=134276
1632
1633         Reviewed by Jer Noble.
1634
1635         * lldb/lldb_webkit.py:
1636         (__lldb_init_module):
1637         (btjs): New scripted command to display a backtrace that shows JavaScript frames with details.
1638
1639 2014-06-25  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1640
1641         REGRESSION (r170426) Broke two python tests
1642         https://bugs.webkit.org/show_bug.cgi?id=134299
1643
1644         Reviewed by Csaba Osztrogonác.
1645
1646         * Scripts/webkitpy/port/efl.py:
1647         (EflPort._search_paths): Added search path for efl-wk2.
1648
1649 2014-06-25  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1650
1651         [EFL] Remove WebKit1 related code from scripts
1652         https://bugs.webkit.org/show_bug.cgi?id=134195
1653
1654         Reviewed by Laszlo Gombos.
1655
1656         After removing WebKit1 from EFL port, still there is some code left related to DumpRenderTree, 
1657         EWebLauncher. Also running layout tests does not require adding -2/--webkit-test-runner switch.
1658
1659         * Scripts/run-launcher: MiniBrowser now runs as default without -2 switch.
1660         * Scripts/webkitdirs.pm:
1661         (builtDylibPathForName): Remove reference to libewebkit.so
1662         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1663         (_set_up_derived_options): Script runs WKTR by default.
1664         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1665         (PerfTestsRunner.__init__): Ditto.
1666         * Scripts/webkitpy/port/efl.py:
1667         (EflPort._search_paths): Remove efl-wk2 from baseline search path.
1668         (EflPort.show_results_html_file): Run MiniBrowser as result viewer.
1669
1670 2014-06-25  Laszlo Gombos  <l.gombos@samsung.com>
1671
1672         Remove build guard for progress element
1673         https://bugs.webkit.org/show_bug.cgi?id=134292
1674
1675         Reviewed by Benjamin Poulain.
1676
1677         * Scripts/webkitperl/FeatureList.pm:
1678
1679 2014-06-24  Tomas Popela  <tpopela@redhat.com>
1680
1681         [GTK] Some of DOM bindings macros are misnamed
1682         https://bugs.webkit.org/show_bug.cgi?id=121543
1683
1684         Reviewed by Carlos Garcia Campos.
1685
1686         As we are using WebKitDOM as a namespace we should unify all type macros
1687         to have WEBKIT_DOM_TYPE prefix instead of WEBKIT_TYPE_DOM. Also add
1688         more exceptions to decamelize function in GObject bindings generator
1689         to fix the names of bindings for BR, HR, UL, OL, DL and LI elements.
1690
1691         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1692         * gtk/webkitdom.py:
1693         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
1694         (WebKitDOMDocGeneratorSections.write_section):
1695
1696 2014-06-24  Frédéric Wang  <fred.wang@free.fr>
1697
1698         [EFL] Install Latin Modern Math on the bots
1699         https://bugs.webkit.org/show_bug.cgi?id=134153
1700
1701         Reviewed by Gyuyoung Kim.
1702
1703         * efl/jhbuild.modules: Switch back to https://github.com/ for the webkitgtk-test-fonts.
1704
1705 2014-06-24  Frédéric Wang  <fred.wang@free.fr>
1706
1707         [EFL] [GTK] Use Latin Modern Math in the jhbuild environments.
1708         https://bugs.webkit.org/show_bug.cgi?id=134153
1709
1710         Reviewed by Martin Robinson.
1711
1712         * efl/jhbuild.modules: Use webkitgtk-test-fonts.git instead of the zip archive and upgrade to 0.0.5.
1713         * gtk/jhbuild.modules: Upgrade webkitgtk-test-fonts to 0.0.5.
1714
1715 2014-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1716
1717         Unreviewed, update my speciality.
1718
1719         * Scripts/webkitpy/common/config/contributors.json:
1720
1721 2014-06-24  Brent Fulgham  <bfulgham@apple.com>
1722
1723         [Win] Clean up and refactor WinLauncher
1724         https://bugs.webkit.org/show_bug.cgi?id=134209
1725
1726         Reviewed by Tim Thorton.
1727
1728         Relanding r170339 and r170340 with correct WinLauncher.h file.
1729
1730         * WinLauncher/Common.cpp: Copied from WinLauncher/WinLauncher.cpp.
1731         (PrintView):
1732         (ToggleMenuItem):
1733         (WndProc):
1734         (BackButtonProc):
1735         (ForwardButtonProc):
1736         (loadURL):
1737         (shouldUseFullDesktop): Deleted.
1738         (SimpleEventListener::SimpleEventListener): Deleted.
1739         (SimpleEventListener::handleEvent): Deleted.
1740         (WinLauncherWebHost::updateAddressBar): Deleted.
1741         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
1742         (WinLauncherWebHost::QueryInterface): Deleted.
1743         (WinLauncherWebHost::AddRef): Deleted.
1744         (WinLauncherWebHost::Release): Deleted.
1745         (updateMenuItemForHistoryItem): Deleted.
1746         (showLastVisitedSites): Deleted.
1747         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
1748         (resizeSubViews): Deleted.
1749         (setToDefaultPreferences): Deleted.
1750         (wWinMain): Deleted.
1751         (MyRegisterClass): Deleted.
1752         (LaunchInspector): Deleted.
1753         (NavigateForwardOrBackward): Deleted.
1754         (NavigateToHistory): Deleted.
1755         * WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
1756         (DOMEventListener::Release):
1757         (WebScriptObject::WebScriptObject): Deleted.
1758         (WebScriptObject::~WebScriptObject): Deleted.
1759         (WebScriptObject::throwException): Deleted.
1760         (WebScriptObject::callWebScriptMethod): Deleted.
1761         (WebScriptObject::evaluateWebScript): Deleted.
1762         (WebScriptObject::removeWebScriptKey): Deleted.
1763         (WebScriptObject::stringRepresentation): Deleted.
1764         (WebScriptObject::webScriptValueAtIndex): Deleted.
1765         (WebScriptObject::setWebScriptValueAtIndex): Deleted.
1766         (WebScriptObject::setException): Deleted.
1767         (DOMEventListener::throwException): Deleted.
1768         (DOMEventListener::callWebScriptMethod): Deleted.
1769         (DOMEventListener::evaluateWebScript): Deleted.
1770         (DOMEventListener::removeWebScriptKey): Deleted.
1771         (DOMEventListener::stringRepresentation): Deleted.
1772         (DOMEventListener::webScriptValueAtIndex): Deleted.
1773         (DOMEventListener::setWebScriptValueAtIndex): Deleted.
1774         (DOMEventListener::setException): Deleted.
1775         (DOMEventListener::handleEvent): Deleted.
1776         * WinLauncher/DOMDefaultImpl.h:
1777         (WebScriptObject::QueryInterface): Deleted.
1778         (WebScriptObject::AddRef): Deleted.
1779         (WebScriptObject::Release): Deleted.
1780         (DOMObject::QueryInterface): Deleted.
1781         (DOMEventListener::QueryInterface): Deleted.
1782         (DOMEventListener::AddRef): Deleted.
1783         (DOMEventListener::Release): Deleted.
1784         * WinLauncher/WinLauncher.cpp:
1785         (WinLauncher::WinLauncher):
1786         (WinLauncher::init):
1787         (WinLauncher::prepareViews):
1788         (WinLauncher::setFrameLoadDelegate):
1789         (WinLauncher::setUIDelegate):
1790         (WinLauncher::setAccessibilityDelegate):
1791         (WinLauncher::mainFrame):
1792         (WinLauncher::seedInitialDefaultPreferences):
1793         (WinLauncher::setToDefaultPreferences):
1794         (updateMenuItemForHistoryItem):
1795         (WinLauncher::showLastVisitedSites):
1796         (WinLauncher::launchInspector):
1797         (WinLauncher::navigateForwardOrBackward):
1798         (WinLauncher::navigateToHistory):
1799         (WinLauncher::goBack):
1800         (WinLauncher::goForward):
1801         (WinLauncher::loadURL):
1802         (shouldUseFullDesktop): Deleted.
1803         (SimpleEventListener::SimpleEventListener): Deleted.
1804         (SimpleEventListener::handleEvent): Deleted.
1805         (WinLauncherWebHost::updateAddressBar): Deleted.
1806         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
1807         (WinLauncherWebHost::QueryInterface): Deleted.
1808         (WinLauncherWebHost::AddRef): Deleted.
1809         (WinLauncherWebHost::Release): Deleted.
1810         (showLastVisitedSites): Deleted.
1811         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
1812         (resizeSubViews): Deleted.
1813         (subclassForLayeredWindow): Deleted.
1814         (computeFullDesktopFrame): Deleted.
1815         (DllMain): Deleted.
1816         (getAppDataFolder): Deleted.
1817         (setToDefaultPreferences): Deleted.
1818         (setCacheFolder): Deleted.
1819         (createCrashReport): Deleted.
1820         (wWinMain): Deleted.
1821         (MyRegisterClass): Deleted.
1822         (AbortProc): Deleted.
1823         (getPrinterDC): Deleted.
1824         (initDocStruct): Deleted.
1825         (PrintView): Deleted.
1826         (ToggleMenuItem): Deleted.
1827         (LaunchInspector): Deleted.
1828         (NavigateForwardOrBackward): Deleted.
1829         (NavigateToHistory): Deleted.
1830         (WndProc): Deleted.
1831         (EditProc): Deleted.
1832         (BackButtonProc): Deleted.
1833         (ForwardButtonProc): Deleted.
1834         (About): Deleted.
1835         (loadURL): Deleted.
1836         (dllLauncherEntryPoint): Deleted.
1837         * WinLauncher/WinLauncher.h:
1838         (WinLauncher::standardPreferences):
1839         (WinLauncher::privatePreferences):
1840         (WinLauncher::hasWebView):
1841         (WinLauncher::usesLayeredWebView):
1842         (WinLauncherWebHost::WinLauncherWebHost): Deleted.
1843         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
1844         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): Deleted.
1845         (WinLauncherWebHost::didCommitLoadForFrame): Deleted.
1846         (WinLauncherWebHost::didReceiveTitle): Deleted.
1847         (WinLauncherWebHost::didChangeIcons): Deleted.
1848         (WinLauncherWebHost::didReceiveIcon): Deleted.
1849         (WinLauncherWebHost::didFailLoadWithError): Deleted.
1850         (WinLauncherWebHost::didChangeLocationWithinPageForFrame): Deleted.
1851         (WinLauncherWebHost::willPerformClientRedirectToURL): Deleted.
1852         (WinLauncherWebHost::didCancelClientRedirectForFrame): Deleted.
1853         (WinLauncherWebHost::willCloseFrame): Deleted.
1854         (WinLauncherWebHost::windowScriptObjectAvailable): Deleted.
1855         (WinLauncherWebHost::didClearWindowObject): Deleted.
1856         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1857         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1858         * WinLauncher/WinLauncherReplace.h:
1859         (processCrashReport):
1860         * WinLauncher/WinLauncherWebHost.cpp: Copied from WinLauncher/WinLauncher.cpp.
1861         (WinLauncherWebHost::updateAddressBar):
1862         (WinLauncherWebHost::QueryInterface):
1863         (WinLauncherWebHost::AddRef):
1864         (WinLauncherWebHost::Release):
1865         (WinLauncherWebHost::didFinishLoadForFrame):
1866         (shouldUseFullDesktop): Deleted.
1867         (updateMenuItemForHistoryItem): Deleted.
1868         (showLastVisitedSites): Deleted.
1869         (resizeSubViews): Deleted.
1870         (subclassForLayeredWindow): Deleted.
1871         (computeFullDesktopFrame): Deleted.
1872         (DllMain): Deleted.
1873         (getAppDataFolder): Deleted.
1874         (setToDefaultPreferences): Deleted.
1875         (setCacheFolder): Deleted.
1876         (createCrashReport): Deleted.
1877         (wWinMain): Deleted.
1878         (MyRegisterClass): Deleted.
1879         (AbortProc): Deleted.
1880         (getPrinterDC): Deleted.
1881         (initDocStruct): Deleted.
1882         (PrintView): Deleted.
1883         (ToggleMenuItem): Deleted.
1884         (LaunchInspector): Deleted.
1885         (NavigateForwardOrBackward): Deleted.
1886         (NavigateToHistory): Deleted.
1887         (WndProc): Deleted.
1888         (EditProc): Deleted.
1889         (BackButtonProc): Deleted.
1890         (ForwardButtonProc): Deleted.
1891         (About): Deleted.
1892         (loadURL): Deleted.
1893         (dllLauncherEntryPoint): Deleted.
1894         * WinLauncher/WinLauncherWebHost.h: Copied from WinLauncher/WinLauncher.h.
1895         (WinLauncherWebHost::WinLauncherWebHost):
1896         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
1897         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
1898         (WinLauncherWebHost::didCommitLoadForFrame):
1899         (WinLauncherWebHost::didReceiveTitle):
1900         (WinLauncherWebHost::didChangeIcons):
1901         (WinLauncherWebHost::didReceiveIcon):
1902         (WinLauncherWebHost::didFailLoadWithError):
1903         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
1904         (WinLauncherWebHost::willPerformClientRedirectToURL):
1905         (WinLauncherWebHost::didCancelClientRedirectForFrame):
1906         (WinLauncherWebHost::willCloseFrame):
1907         (WinLauncherWebHost::windowScriptObjectAvailable):
1908         (WinLauncherWebHost::didClearWindowObject):
1909         * WinLauncher/WinMain.cpp: Copied from WinLauncher/WinLauncher.cpp.
1910         (wWinMain):
1911         (MyRegisterClass):
1912         (shouldUseFullDesktop): Deleted.
1913         (SimpleEventListener::SimpleEventListener): Deleted.
1914         (SimpleEventListener::handleEvent): Deleted.
1915         (WinLauncherWebHost::updateAddressBar): Deleted.
1916         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
1917         (WinLauncherWebHost::QueryInterface): Deleted.
1918         (WinLauncherWebHost::AddRef): Deleted.
1919         (WinLauncherWebHost::Release): Deleted.
1920         (updateMenuItemForHistoryItem): Deleted.
1921         (showLastVisitedSites): Deleted.
1922         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
1923         (resizeSubViews): Deleted.
1924         (subclassForLayeredWindow): Deleted.
1925         (computeFullDesktopFrame): Deleted.
1926         (DllMain): Deleted.
1927         (getAppDataFolder): Deleted.
1928         (setToDefaultPreferences): Deleted.
1929         (setCacheFolder): Deleted.
1930         (createCrashReport): Deleted.
1931         (AbortProc): Deleted.
1932         (getPrinterDC): Deleted.
1933         (initDocStruct): Deleted.
1934         (PrintView): Deleted.
1935         (ToggleMenuItem): Deleted.
1936         (LaunchInspector): Deleted.
1937         (NavigateForwardOrBackward): Deleted.
1938         (NavigateToHistory): Deleted.
1939         (WndProc): Deleted.
1940         (EditProc): Deleted.
1941         (BackButtonProc): Deleted.
1942         (ForwardButtonProc): Deleted.
1943         (About): Deleted.
1944         (loadURL): Deleted.
1945         (dllLauncherEntryPoint): Deleted.
1946
1947 2014-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
1948
1949         [iOS] getsectdata() is deprecated and we use it in DRT
1950         https://bugs.webkit.org/show_bug.cgi?id=134122
1951
1952         Reviewed by Alexey Proskuryakov.
1953
1954         Migrate to using magic linker symbols.
1955
1956         No tests because there should be no behavior change
1957
1958         * DumpRenderTree/mac/DumpRenderTree.mm:
1959         (activateFontsIOS):
1960
1961 2014-06-24  Javier Fernandez  <jfernandez@igalia.com>
1962
1963         Name moving. Unreviewed.
1964
1965         * Scripts/webkitpy/common/config/contributors.json:
1966
1967 2014-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1968
1969         Remove EFL WK1 watch category
1970         https://bugs.webkit.org/show_bug.cgi?id=134231
1971
1972         Reviewed by Csaba Osztrogonác.
1973
1974         * Scripts/webkitpy/common/config/watchlist: Removed EFL WK1 category.
1975
1976 2014-06-24  Krzysztof Czech  <k.czech@samsung.com>
1977
1978         [ATK] Remove some unused code from DumpRenderTree
1979         https://bugs.webkit.org/show_bug.cgi?id=134191
1980
1981         Reviewed by Chris Fleizach.
1982
1983         DumpRenderTree's accessibility code could be removed since GTK and EFL has stopped supporting WK1.
1984
1985         * DumpRenderTree/atk/AccessibilityCallbacks.h: Removed.
1986         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Removed.
1987         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp: Removed.
1988         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Removed.
1989         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Removed.
1990         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Removed.
1991
1992 2014-06-23  Shivakumar JM  <shiva.jm@samsung.com>
1993
1994         [EFL][WK2] Search field is not shown properly on doing ctrl+f on Minibrowser.
1995         https://bugs.webkit.org/show_bug.cgi?id=134025
1996
1997         Reviewed by Gyuyoung Kim.
1998
1999         Use EVAS_HINT_FILL in evas_object_size_hint_align_set() api.
2000
2001         * MiniBrowser/efl/main.c:
2002         (window_create):
2003
2004 2014-06-23  Ryuan Choi  <ryuan.choi@samsung.com>
2005
2006         [EFL] Replace RefPtr<Evas_Object> with UniquePtrEfl
2007         https://bugs.webkit.org/show_bug.cgi?id=134236
2008
2009         Reviewed by Gyuyoung Kim.
2010
2011         * ImageDiff/efl/ImageDiff.cpp:
2012         (calculateDifference):
2013         (printImageDifferences):
2014         (readImageFromStdin):
2015         (main):
2016
2017 2014-06-23  Daniel Bates  <dabates@apple.com>
2018
2019         Rolling out r170340 and r170339.
2020
2021         Changeset r170339 broke the Apple Windows Debug and Release builds.
2022
2023         Reverted changesets:
2024
2025         "[Win] Build fix after r134209"
2026         http://trac.webkit.org/changeset/170340
2027
2028         "[Win] Clean up and refactor WinLauncher"
2029         https://bugs.webkit.org/show_bug.cgi?id=134209
2030         http://trac.webkit.org/changeset/170339
2031
2032 2014-06-23  Brent Fulgham  <bfulgham@apple.com>
2033
2034         [Win] Build fix after r134209
2035
2036         * WinLauncher/WinMain.cpp: Must include the resources file
2037         before Common.cpp.
2038
2039 2014-06-23  Brent Fulgham  <bfulgham@apple.com>
2040
2041         [Win] Clean up and refactor WinLauncher
2042         https://bugs.webkit.org/show_bug.cgi?id=134209
2043
2044         Reviewed by Tim Horton.
2045
2046         Make WinLauncher a class, and move all non-class driver functions
2047         into "Common.cpp" and "WinMain.cpp". These files are distinct
2048         to allow some internal tools to reuse the code in 'Common'.
2049
2050         * WinLauncher/Common.cpp: Added. Consists of code moved from
2051         'WinLauncher.cpp' that can be reused for other tools.
2052         (subclassForLayeredWindow):
2053         (computeFullDesktopFrame):
2054         (DllMain):
2055         (getAppDataFolder):
2056         (setCacheFolder):
2057         (createCrashReport):
2058         (AbortProc):
2059         (getPrinterDC):
2060         (initDocStruct):
2061         (PrintView):
2062         (ToggleMenuItem):
2063         (WndProc):
2064         (EditProc):
2065         (BackButtonProc):
2066         (ForwardButtonProc):
2067         (About):
2068         (loadURL):
2069         (dllLauncherEntryPoint):
2070         * WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
2071         (DOMEventListener::Release):
2072         (WebScriptObject::WebScriptObject): Deleted.
2073         (WebScriptObject::~WebScriptObject): Deleted.
2074         (WebScriptObject::throwException): Deleted.
2075         (WebScriptObject::callWebScriptMethod): Deleted.
2076         (WebScriptObject::evaluateWebScript): Deleted.
2077         (WebScriptObject::removeWebScriptKey): Deleted.
2078         (WebScriptObject::stringRepresentation): Deleted.
2079         (WebScriptObject::webScriptValueAtIndex): Deleted.
2080         (WebScriptObject::setWebScriptValueAtIndex): Deleted.
2081         (WebScriptObject::setException): Deleted.
2082         (DOMEventListener::throwException): Deleted.
2083         (DOMEventListener::callWebScriptMethod): Deleted.
2084         (DOMEventListener::evaluateWebScript): Deleted.
2085         (DOMEventListener::removeWebScriptKey): Deleted.
2086         (DOMEventListener::stringRepresentation): Deleted.
2087         (DOMEventListener::webScriptValueAtIndex): Deleted.
2088         (DOMEventListener::setWebScriptValueAtIndex): Deleted.
2089         (DOMEventListener::setException): Deleted.
2090         (DOMEventListener::handleEvent): Deleted.
2091         * WinLauncher/DOMDefaultImpl.h:
2092         (WebScriptObject::QueryInterface): Deleted.
2093         (WebScriptObject::AddRef): Deleted.
2094         (WebScriptObject::Release): Deleted.
2095         (DOMObject::QueryInterface): Deleted.
2096         (DOMEventListener::QueryInterface): Deleted.
2097         (DOMEventListener::AddRef): Deleted.
2098         (DOMEventListener::Release): Deleted.
2099         * WinLauncher/WinLauncher.cpp: Converted stand-alone implementation
2100         into a C++ class and removed WinAPI code.
2101         (WinLauncher::WinLauncher):
2102         (WinLauncher::init):
2103         (WinLauncher::prepareViews):
2104         (WinLauncher::setFrameLoadDelegate):
2105         (WinLauncher::setUIDelegate):
2106         (WinLauncher::setAccessibilityDelegate):
2107         (WinLauncher::mainFrame):
2108         (WinLauncher::seedInitialDefaultPreferences):
2109         (WinLauncher::setToDefaultPreferences):
2110         (updateMenuItemForHistoryItem):
2111         (WinLauncher::showLastVisitedSites):
2112         (WinLauncher::launchInspector):
2113         (WinLauncher::navigateForwardOrBackward):
2114         (WinLauncher::navigateToHistory):
2115         (WinLauncher::goBack):
2116         (WinLauncher::goForward):
2117         (WinLauncher::loadURL):
2118         (shouldUseFullDesktop): Deleted.
2119         (SimpleEventListener::SimpleEventListener): Deleted.
2120         (SimpleEventListener::handleEvent): Deleted.
2121         (WinLauncherWebHost::updateAddressBar): Deleted.
2122         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
2123         (WinLauncherWebHost::QueryInterface): Deleted.
2124         (WinLauncherWebHost::AddRef): Deleted.
2125         (WinLauncherWebHost::Release): Deleted.
2126         (showLastVisitedSites): Deleted.
2127         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
2128         (resizeSubViews): Deleted.
2129         (subclassForLayeredWindow): Deleted.
2130         (computeFullDesktopFrame): Deleted.
2131         (DllMain): Deleted.
2132         (getAppDataFolder): Deleted.
2133         (setToDefaultPreferences): Deleted.
2134         (setCacheFolder): Deleted.
2135         (createCrashReport): Deleted.
2136         (wWinMain): Deleted.
2137         (MyRegisterClass): Deleted.
2138         (AbortProc): Deleted.
2139         (getPrinterDC): Deleted.
2140         (initDocStruct): Deleted.
2141         (PrintView): Deleted.
2142         (ToggleMenuItem): Deleted.
2143         (LaunchInspector): Deleted.
2144         (NavigateForwardOrBackward): Deleted.
2145         (NavigateToHistory): Deleted.
2146         (WndProc): Deleted.
2147         (EditProc): Deleted.
2148         (BackButtonProc): Deleted.
2149         (ForwardButtonProc): Deleted.
2150         (About): Deleted.
2151         (loadURL): Deleted.
2152         (dllLauncherEntryPoint): Deleted.
2153         * WinLauncher/WinLauncher.h: Removed.
2154         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2155         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2156         * WinLauncher/WinLauncherReplace.h:
2157         (processCrashReport):
2158         * WinLauncher/WinLauncherWebHost.cpp: Added.
2159         (SimpleEventListener::SimpleEventListener):
2160         (SimpleEventListener::handleEvent):
2161         (WinLauncherWebHost::updateAddressBar):
2162         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2163         (WinLauncherWebHost::QueryInterface):
2164         (WinLauncherWebHost::AddRef):
2165         (WinLauncherWebHost::Release):
2166         (WinLauncherWebHost::didFinishLoadForFrame):
2167         * WinLauncher/WinLauncherWebHost.h: Copied from WinLauncher/WinLauncher.h.
2168         Moved WinLauncherWebHost implementation from WinLauncher.cpp into
2169         its own set of files.
2170         (WinLauncherWebHost::WinLauncherWebHost):
2171         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
2172         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
2173         (WinLauncherWebHost::didCommitLoadForFrame):
2174         (WinLauncherWebHost::didReceiveTitle):
2175         (WinLauncherWebHost::didChangeIcons):
2176         (WinLauncherWebHost::didReceiveIcon):
2177         (WinLauncherWebHost::didFailLoadWithError):
2178         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
2179         (WinLauncherWebHost::willPerformClientRedirectToURL):
2180         (WinLauncherWebHost::didCancelClientRedirectForFrame):
2181         (WinLauncherWebHost::willCloseFrame):
2182         (WinLauncherWebHost::windowScriptObjectAvailable):
2183         (WinLauncherWebHost::didClearWindowObject):
2184         * WinLauncher/WinMain.cpp: Added. This consists of code from
2185         WinLauncher that is unique to the WinLauncher utility, and is
2186         not part of the WinLauncher class.
2187         (wWinMain):
2188         (MyRegisterClass):
2189
2190 2014-06-23  Simon Fraser  <simon.fraser@apple.com>
2191
2192         Enable the Web Inspector in MiniBrowser
2193         https://bugs.webkit.org/show_bug.cgi?id=134148
2194
2195         Reviewed by Joseph Pecoraro.
2196         
2197         Set the pref to enable Web Inspector in both WK1 and WK2 windows.
2198
2199         * MiniBrowser/mac/AppDelegate.m:
2200         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2201
2202 2014-06-21  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2203
2204         Disable gamepad feature on EFL and GTK ports by default
2205         https://bugs.webkit.org/show_bug.cgi?id=134169
2206
2207         Reviewed by Brady Eidson.
2208
2209         EFL and GTK ports disabled Gamepad feature now. Besides current implementation
2210         was treated to 'deprecated' status.
2211
2212         ENABLE_GAMEPAD_DEPRECATED is disabled for now. There is build break on EFL port.
2213
2214         * Scripts/webkitperl/FeatureList.pm:
2215
2216 2014-06-21  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2217
2218         [Inspector][EFL] Can't resume a special break point on EFL inspector
2219         https://bugs.webkit.org/show_bug.cgi?id=129294
2220
2221         Reviewed by Gyuyoung Kim.
2222
2223         Patch our EFL 1.9 with the fix landed in upstream EFL 1.10
2224         by Ryuan Choi - <https://phab.enlightenment.org/D790>
2225
2226         * efl/jhbuild.modules:
2227         * efl/patches/ecore.patch: Added.
2228
2229 2014-06-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2230
2231         Removing PAGE_VISIBILITY_API compile guard.
2232         https://bugs.webkit.org/show_bug.cgi?id=133844
2233
2234         Reviewed by Gavin Barraclough.
2235
2236         * Scripts/webkitperl/FeatureList.pm:
2237
2238 2014-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
2239
2240         [EFL] Remove DumpRenderTree/efl and EWebLauncher
2241         https://bugs.webkit.org/show_bug.cgi?id=134138
2242
2243         Reviewed by Gyuyoung Kim.
2244
2245         DumpRenderTree/efl and EWebLauncher are not necessary anymore because WebKit1 EFL will be removed.
2246
2247         * CMakeLists.txt:
2248         * DumpRenderTree/PlatformEfl.cmake: Removed.
2249         * DumpRenderTree/efl: Removed entire directory.
2250         * EWebLauncher: Ditto.
2251         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Renamed from Tools/DumpRenderTree/efl/FontManagement.cpp.
2252         (buildPath):
2253         (getCoreFontFiles):
2254         (addFontDirectory):
2255         (addFontFiles):
2256         (getCustomBuildDir):
2257         (getPlatformFontsPath):
2258         (addFontsToEnvironment):
2259         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Renamed from Tools/DumpRenderTree/efl/FontManagement.h.
2260         * WebKitTestRunner/PlatformEfl.cmake:
2261
2262 2014-06-20  Zalan Bujtas  <zalan@apple.com>
2263
2264         Name moving. Unreviewed.
2265
2266         * Scripts/webkitpy/common/config/contributors.json:
2267
2268 2014-06-20  Javier Fernandez  <jfernandez@igalia.com>
2269
2270         Unreviewed. Adding myself to committers.
2271
2272         * Scripts/webkitpy/common/config/contributors.json:
2273
2274 2014-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>
2275
2276         Unreviewed. Adding myself to committers.
2277
2278         * Scripts/webkitpy/common/config/contributors.json:
2279
2280 2014-06-20  Tim Horton  <timothy_horton@apple.com>
2281
2282         Make WebKit2 more accessible in MiniBrowser
2283         https://bugs.webkit.org/show_bug.cgi?id=134099
2284
2285         Reviewed by Anders Carlsson.
2286
2287         * MiniBrowser/mac/AppDelegate.h:
2288         * MiniBrowser/mac/AppDelegate.m:
2289         (-[BrowserAppDelegate newWindow:]):
2290         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2291         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]):
2292         (-[BrowserAppDelegate _useWebKit2ByDefault]):
2293         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2294         (-[BrowserAppDelegate validateMenuItem:]):
2295         * MiniBrowser/mac/MainMenu.xib:
2296         Add a "Use WebKit2 By Default" menu item to the top of the Debug menu.
2297         When switched on, Cmd-N will make WebKit2 windows (and the default window will be WebKit2).
2298         Make the non-default new-window menu item always show up, because people often don't find it
2299         when you have to press option to have it show up.
2300
2301         * MiniBrowser/mac/BrowserWindowController.h:
2302         * MiniBrowser/mac/BrowserWindowController.m:
2303         (-[BrowserWindowController initWithWindow:]):
2304         
2305         * MiniBrowser/mac/WK1BrowserWindowController.m:
2306         (-[WK1BrowserWindowController validateMenuItem:]):
2307         * MiniBrowser/mac/WK2BrowserWindowController.m:
2308         (-[WK2BrowserWindowController validateMenuItem:]):
2309         Use the cached [menuItem action] like the earlier cases do.
2310
2311 2014-06-20  Daniel Bates  <dabates@apple.com>
2312
2313         Teach run-{safari, webkit-app} about iOS Simulator
2314         https://bugs.webkit.org/show_bug.cgi?id=133986
2315
2316         Reviewed by David Kilzer.
2317
2318         Extract the logic from old-run-webkit-tests to install and launch {DumpRenderTree, WebKitTestRunnerApp}.app
2319         into general-purpose routines in webkitdirs.pm so that they can be used both by script old-run-webkit-tests
2320         and run-safari.
2321
2322         * Scripts/old-run-webkit-tests:
2323         (installAndLaunchDumpToolAppUsingNotification): Extracted logic to install and launch {DumpRenderTree,
2324         WebKitTestRunnerApp}.app into webkitdirs::installAndLaunchIOSWebKitAppInSimulator() and modified code
2325         to call it.
2326         (openIPhoneSimulator): Deleted; moved logic to webkitdirs::openIOSSimulator().
2327         (quitIPhoneSimulator): Deleted; moved logic to webkitdirs::quitIOSSimulator().
2328         * Scripts/run-webkit-app: Modified to call runIOSWebKitApp() when the iOS simulator SDK is used
2329         (say, by specifying the optional command-line argument --simulator). For now, die() with an error
2330         when the iOS device SDK is used as we don't support launching an app on the device at this time.
2331         * Scripts/webkitdirs.pm:
2332         (xcodeSDKVersion): Added.
2333         (setupIOSWebKitEnvironment): Added.
2334         (installedMobileSafariBundle): Added.
2335         (mobileSafariBundle): Added.
2336         (plistPathFromBundle): Added.
2337         (appIdentiferFromBundle): Added.
2338         (appDisplayNameFromBundle): Added.
2339         (loadIPhoneSimulatorNotificationIfNeeded): Added.
2340         (openIOSSimulator): Added.
2341         (quitIOSSimulator): Added.
2342         (iosSimulatorDeviceByName): Added.
2343         (iosSimulatorRuntime): Added.
2344         (findOrCreateSimulatorForIOSDevice): Added.
2345         (runIOSWebKitAppInSimulator): Added.
2346         (installAndLaunchIOSWebKitAppInSimulator): Added.
2347         (runIOSWebKitApp): Added.
2348         (runSafari): Modified to call runIOSWebKitAppInSimulator() the iOS simulator SDK is used. For now,
2349         die() with an error when the iOS device SDK is used as we don't support launching Safari on the
2350         device at this time.
2351
2352 2014-06-19  Anders Carlsson  <andersca@apple.com>
2353
2354         Add WTF::Optional class
2355         https://bugs.webkit.org/show_bug.cgi?id=134083
2356
2357         Reviewed by Andreas Kling.
2358
2359         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2360         * TestWebKitAPI/Tests/WTF/Optional.cpp: Added.
2361         (TestWebKitAPI::TEST):
2362
2363 2014-06-20  Ion Rosca  <rosca@adobe.com>
2364
2365         Unreviewed. Adding myself to Committers list.
2366
2367         * Scripts/webkitpy/common/config/contributors.json:
2368
2369 2014-06-20  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2370
2371         [EFL] Add gstreamer as dependecy of EFL after r169785
2372         https://bugs.webkit.org/show_bug.cgi?id=134066
2373
2374         Reviewed by Gyuyoung Kim.
2375
2376         * efl/jhbuild.modules:
2377
2378 2014-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
2379
2380         [EFL] Merge url_utils.c to MiniBrowser
2381         https://bugs.webkit.org/show_bug.cgi?id=134095
2382
2383         Reviewed by Csaba Osztrogonác.
2384
2385         url_utils.c is simple code to share between EWebLauncher and MiniBrowser.
2386         This patch removes the dependency of url_utils.c from MiniBrowser to drop WebKit1 EFL port.
2387
2388         * MiniBrowser/efl/CMakeLists.txt:
2389         Remove the EWebLauncher/ from the includes and url_utils.h from the source lists.
2390         * MiniBrowser/efl/main.c:
2391         (has_scheme): Copied from url_utils.c
2392         (url_from_user_input): Ditto.
2393
2394 2014-06-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2395
2396         Fix webkitpy tests after EFL WK1 buildbot and EWS removal - r170172.
2397
2398         Reviewed by Csaba Osztrogonác.
2399
2400         * Scripts/webkitpy/common/config/ports_unittest.py:
2401         (DeprecatedPortTest.test_gtk_wk2_port):
2402         (DeprecatedPortTest.test_efl_port): Deleted.
2403         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2404         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2405         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2406         (TestRebaselineExpectations.test_rebaseline_expectations):
2407
2408 2014-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
2409
2410         [EFL][CMAKE] Disable WebKit1 build as a default
2411         https://bugs.webkit.org/show_bug.cgi?id=134093
2412
2413         Reviewed by Gyuyoung Kim.
2414
2415         * CMakeLists.txt:
2416
2417 2014-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2418
2419         [GTK] webkit_dom_document_create_tree_walker impossible to use due to WebKitDOMNodeFilter
2420         https://bugs.webkit.org/show_bug.cgi?id=93002
2421
2422         Reviewed by Gustavo Noronha Silva.
2423
2424         Add unit tests to check WebKitDOMNodefilter API used from both
2425         TreeWalker and NodeIterator.
2426
2427         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+
2428         public headers and add WebKitDOMNodeFilter to the list of exceptions.
2429         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
2430         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Added.
2431         (webkitNodeFilterAcceptNode):
2432         (webkitNodeFilterDOMNodeFilterIfaceInit):
2433         (webkit_node_filter_init):
2434         (webkit_node_filter_class_init):
2435         (WebKitDOMNodeFilterTest::create):
2436         (WebKitDOMNodeFilterTest::webPageFromArgs):
2437         (WebKitDOMNodeFilterTest::testTreeWalker):
2438         (WebKitDOMNodeFilterTest::testNodeIterator):
2439         (WebKitDOMNodeFilterTest::runTest):
2440         (registerTests):
2441         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Added.
2442         (runTest):
2443         (testWebKitDOMNodeFilterTreeWalker):
2444         (testWebKitDOMNodeFilterNodeIterator):
2445         (beforeAll):
2446         (afterAll):
2447         * gtk/webkitdom.py:
2448         (WebKitDOMDocGeneratorSections.__init__):
2449         (WebKitDOMDocGeneratorSections._symbol_list):
2450         (WebKitDOMDocGeneratorSections.write_section):
2451
2452 2014-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2453
2454         [GTK] Limit the amount of API exposed to GObject DOM bindings API
2455         https://bugs.webkit.org/show_bug.cgi?id=133726
2456
2457         Reviewed by Gustavo Noronha Silva.
2458
2459         Don't make fatal finding files without a .symbols file, since now
2460         only the stable DOM API has .symbols files.
2461
2462         * gtk/webkitdom.py:
2463         (get_all_webkitdom_symbol_files):
2464
2465 2014-06-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2466
2467         Remove efl wk1 buildbot and ews
2468         https://bugs.webkit.org/show_bug.cgi?id=134089
2469
2470         Reviewed by Benjamin Poulain.
2471
2472         EFL WK1 is not supported anymore. Removed all bots for EFL WK1 bots.
2473
2474         * BuildSlaveSupport/build.webkit.org-config/config.json:
2475         * QueueStatusServer/config/queues.py:
2476         * Scripts/webkitpy/common/config/ews.json:
2477         * Scripts/webkitpy/common/config/ports.py:
2478         (DeprecatedPort.port):
2479         (QtWK2Port.run_webkit_tests_command):
2480         (EflPort): Deleted.
2481         (EflPort.build_webkit_command): Deleted.
2482         * Scripts/webkitpy/port/builders.py:
2483         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2484         * TestResultServer/static-dashboards/loader_unittests.js:
2485
2486 2014-06-19  David Kilzer  <ddkilzer@apple.com>
2487
2488         check-webkit-style does not understand Obj-C literal syntax for NSDictionary
2489         <http://webkit.org/b/134061>
2490
2491         Reviewed by Dan Bernstein.
2492
2493         * Scripts/webkitpy/style/checkers/cpp.py:
2494         (check_spacing): Ignore '@' immediately before '{'.
2495         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2496         (CppStyleTest.test_spacing_before_braces): Add unit test for
2497         '^{' block syntax and '@{' Objective-C liternal NSDitionary
2498         syntax.
2499
2500 2014-06-18  Tim Horton  <timothy_horton@apple.com>
2501
2502         All of MiniBrowser's WKWebViews should share a configuration
2503         https://bugs.webkit.org/show_bug.cgi?id=134017
2504
2505         Reviewed by Anders Carlsson.
2506
2507         * MiniBrowser/mac/WK2BrowserWindowController.m:
2508         (-[WK2BrowserWindowController awakeFromNib]):
2509         Share a single WKWebViewConfiguration between all of MiniBrowser's views.
2510         This means that they'll share things like preferences, visited links, etc.
2511         It also means that we'll properly share processes once we hit the process limit.
2512
2513 2014-06-18  Zan Dobersek  <zdobersek@igalia.com>
2514
2515         [GTK] Bump the GLib and GTK+ dependencies in jhbuild-wayland.modules
2516         https://bugs.webkit.org/show_bug.cgi?id=133971
2517
2518         Reviewed by Martin Robinson.
2519
2520         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's required for
2521         building for the Wayland target. The latest 3.12 version is required to match
2522         the xdg_shell protocol version used in Weston 1.5. GLib dependency is bumped
2523         as well due to GTK+ depending on a newer version.
2524
2525 2014-06-17  Ryuan Choi  <ryuan.choi@samsung.com>
2526
2527         [EFL] Turn on NOSNIFF in FeatureList.pm
2528         https://bugs.webkit.org/show_bug.cgi?id=134010
2529
2530         Reviewed by Csaba Osztrogonác.
2531
2532         r164848 enabled NOSNIFF feature for EFL port but missed to change FeatureList.pm.
2533
2534         * Scripts/webkitperl/FeatureList.pm: Turn on NOSNIFF for the EFL port.
2535
2536 2014-06-17  Tim Horton  <timothy_horton@apple.com>
2537
2538         MiniBrowser should show Web Content process pids in the window title
2539         https://bugs.webkit.org/show_bug.cgi?id=134016
2540
2541         Reviewed by Sam Weinig.
2542
2543         * MiniBrowser/mac/WK2BrowserWindowController.m:
2544         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2545
2546 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2547
2548         [GTK] Fix the handling of resize events after r169505.
2549         https://bugs.webkit.org/show_bug.cgi?id=133517
2550
2551         Reviewed by Martin Robinson.
2552
2553         * Scripts/webkitpy/port/xvfbdriver.py:
2554         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
2555         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
2556         need at least 900x640 pixels to pass.
2557         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2558         (XvfbDriverTest.test_start_no_pixel_tests): Update resolution.
2559         (XvfbDriverTest.test_start_pixel_tests): Update resolution.
2560         (XvfbDriverTest.test_start_arbitrary_worker_number): Update resolution.
2561         (XvfbDriverTest.test_start_next_worker): Update resolution.
2562         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2563         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
2564         be requested over the main widget instead of the window.
2565         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
2566         the Mac port.
2567         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
2568         (WTR::PlatformWebView::setWindowFrame): Set the size and position
2569         of the Window and the web view.
2570
2571 2014-06-17  Matthew Mirman <mmirman@apple.com>
2572
2573         Unreviewed. Added myself to list of contributors.
2574
2575         * Scripts/webkitpy/common/config/contributors.json: Added myself.
2576
2577 2014-06-17  Commit Queue  <commit-queue@webkit.org>
2578
2579         Unreviewed, rolling out r170058.
2580         https://bugs.webkit.org/show_bug.cgi?id=133993
2581
2582         Caused 4 webkitpy failures on the bots (Requested by bradee-oh
2583         on #webkit).
2584
2585         Reverted changeset:
2586
2587         "[GTK] Fix the handling of resize events after r169505."
2588         https://bugs.webkit.org/show_bug.cgi?id=133517
2589         http://trac.webkit.org/changeset/170058
2590
2591 2014-06-17  Rebecca Hauck  <rhauck@adobe.com>
2592
2593         Update import-w3c-tests to reflect current W3C test repo directory structure
2594         https://bugs.webkit.org/show_bug.cgi?id=133460
2595
2596         Reviewed by Bem Jones-Bey.
2597
2598         Removed all references to test status, which are no longer reflected in the
2599         directory names in the W3C CSS test repo.  No tests are required for this 
2600         change, the existing tests pass.
2601
2602         * Scripts/webkitpy/w3c/test_importer.py:
2603         (main):
2604         (TestImporter.__init__):
2605         (TestImporter.find_importable_tests):
2606         (TestImporter.setup_destination_directory):
2607         (TestImporter.write_import_log):
2608         (TestImporter.update_test_status): Deleted.
2609
2610 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2611
2612         [GTK] Fix the handling of resize events after r169505.
2613         https://bugs.webkit.org/show_bug.cgi?id=133517
2614
2615         Reviewed by Martin Robinson.
2616
2617         * Scripts/webkitpy/port/xvfbdriver.py:
2618         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
2619         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
2620         need at least 900x640 pixels to pass.
2621         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2622         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
2623         be requested over the main widget instead of the window.
2624         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
2625         the Mac port.
2626         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
2627         (WTR::PlatformWebView::setWindowFrame): Set the size and position
2628         of the Window and the web view.
2629
2630 2014-06-17  Dan Bernstein  <mitz@apple.com>
2631
2632         String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference
2633         https://bugs.webkit.org/show_bug.cgi?id=133968
2634
2635         Reviewed by Anders Carlsson.
2636
2637         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2638         (TestWebKitAPI::TEST): Added a test that an isolated copy of an rvalue reference doesn’t
2639         share an impl() with the original.
2640
2641 2014-06-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2642
2643         [EFL][WK2] Skip failing EFL API tests
2644         https://bugs.webkit.org/show_bug.cgi?id=133981
2645
2646         Reviewed by Csaba Osztrogonác.
2647
2648         UserMessage, WillLoad and test_ewk2_view have been failed since r169784.
2649
2650         * TestWebKitAPI/PlatformEfl.cmake:
2651
2652 2014-06-16  Ryuan Choi  <ryuan.choi@samsung.com>
2653
2654         [EFL][WK2] Remove workaround for icon display bug in MiniBrowser
2655         https://bugs.webkit.org/show_bug.cgi?id=133962
2656
2657         Reviewed by Gyuyoung Kim.
2658
2659         Since we bumped EFL to 1.9, this workaround is unnecessary.
2660
2661         * MiniBrowser/efl/main.c:
2662         (update_view_favicon):
2663
2664 2014-06-16  Gwang Yoon Hwang  <yoon@igalia.com>
2665
2666         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2667         https://bugs.webkit.org/show_bug.cgi?id=131472
2668
2669         Reviewed by Martin Robinson.
2670
2671         This patch reapplies r167510 with fixes to add llvm as a dependency for llvmpipe.
2672
2673         * Scripts/webkitpy/port/xvfbdriver.py:
2674         (XvfbDriver._start): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2675         when running WebKitTestRunner with the Xvfb driver.
2676         * gtk/install-dependencies: Add LLVM as a dependency to build llvmpipe.
2677         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
2678         installed.
2679         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
2680         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
2681         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
2682         deal.
2683
2684 2014-06-16  Tanay C  <tanay.c@samsung.com>
2685
2686         Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
2687         https://bugs.webkit.org/show_bug.cgi?id=133792
2688
2689         Reviewed by Gyuyoung Kim.
2690
2691         * MiniBrowser/efl/main.c: replaced the deprecated API's with the latest ones
2692         (show_file_entry_dialog):
2693         (window_create):
2694
2695 2014-06-16  Mario Sanchez Prada  <mario.prada@samsung.com>
2696
2697         [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard
2698         https://bugs.webkit.org/show_bug.cgi?id=133512
2699
2700         Reviewed by Chris Fleizach.
2701
2702         Added support for connecting to AtkSelection's 'selection-changed'
2703         signal, and print it out as AXSelectedChildrenChanged in the tests.
2704
2705         Also removed some dead code, that became useless after r169487.
2706
2707         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2708         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated.
2709
2710 2014-06-15  Ryuan Choi  <ryuan.choi@samsung.com>
2711
2712         [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
2713         https://bugs.webkit.org/show_bug.cgi?id=133841
2714
2715         Reviewed by Gyuyoung Kim.
2716
2717         * MiniBrowser/efl/main.c:
2718         (window_create):
2719
2720 2014-06-15  Dan Bernstein  <mitz@apple.com>
2721
2722         Set the svn:ignore property on an Xcode project to ignore user and workspace data.
2723
2724         * jsc-cli/jsc-cli.xcodeproj: Added property svn:ignore.
2725
2726 2014-06-15  Anders Carlsson  <andersca@apple.com>
2727
2728         Fix build.
2729
2730         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2731         (callRunJavaScriptBlockAndRelease):
2732         (runJavaScriptInMainFrame):
2733         (TEST_F):
2734
2735 2014-06-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2736
2737         Create MSE and EME watchlist
2738         https://bugs.webkit.org/show_bug.cgi?id=133810
2739
2740         Reviewed by Eric Carlson.
2741
2742         * Scripts/webkitpy/common/config/watchlist: Create MSEEME
2743         definition and add Eric Carlson and myself to it.
2744
2745 2014-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2746
2747         [GTK] Remove all deprecated API from GObject DOM bindings
2748         https://bugs.webkit.org/show_bug.cgi?id=133728
2749
2750         Reviewed by Martin Robinson.
2751
2752         * gtk/webkitdom.py:
2753         (WebKitDOMDocGenerator): Remove all deleted classes from the list.
2754         (WebKitDOMDocGeneratorSections.__init__): Fix a typo in member initialization.
2755
2756 2014-06-12  Simon Fraser  <simon.fraser@apple.com>
2757
2758         [iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
2759         https://bugs.webkit.org/show_bug.cgi?id=133835
2760
2761         Reviewed by Tim Horton.
2762         
2763         Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
2764
2765         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2766         (-[WebKitTestRunnerWindow initWithFrame:]):
2767         (-[WebKitTestRunnerWindow setFrame:]):
2768
2769 2014-06-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2770
2771         [GTK] Performance tests should be always ran with WKTR.
2772         https://bugs.webkit.org/show_bug.cgi?id=133780
2773
2774         Reviewed by Ryosuke Niwa.
2775
2776         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2777         (PerfTestsRunner.__init__): Enable webkit_test_runner when port
2778         is GTK.
2779
2780 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
2781
2782         [GTK] REGRESSION: application name is not correctly appended to the UA
2783         https://bugs.webkit.org/show_bug.cgi?id=133793
2784
2785         Reviewed by Carlos Garcia Campos.
2786
2787         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2788         (testWebKitSettingsUserAgent):
2789
2790 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
2791
2792         [GTK] Unsupported browser in www.icloud.com
2793         https://bugs.webkit.org/show_bug.cgi?id=133403
2794
2795         Reviewed by Martin Robinson.
2796
2797         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
2798         (TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
2799         quirk that was removed.
2800
2801 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
2802
2803         [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
2804         https://bugs.webkit.org/show_bug.cgi?id=133779
2805
2806         Reviewed by Benjamin Poulain.
2807         
2808         Tell the WebPage to use the testing viewport configuration from the injected bundle.
2809
2810         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2811         (WTR::InjectedBundle::didReceiveMessage): Code cleanup.
2812         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2813         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
2814         on iOS.
2815
2816 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
2817
2818         WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
2819         https://bugs.webkit.org/show_bug.cgi?id=133770
2820
2821         Reviewed by Anders Carlsson.
2822         
2823         Push the per-test view configuration up to TestController, so that platforms
2824         can modify the behavior. This also allows platform-specific changes (e.g.
2825         for threaded scrolling) to made without #ifefs.
2826
2827         * WebKitTestRunner/TestController.cpp:
2828         (WTR::TestController::updateWebViewSizeForTest):
2829         (WTR::TestController::updateWindowScaleForTest):
2830         (WTR::shouldUseFixedLayout):
2831         (WTR::TestController::updateLayoutTypeForTest):
2832         (WTR::TestController::platformConfigureViewForTest):
2833         (WTR::TestController::configureViewForTest):
2834         * WebKitTestRunner/TestController.h:
2835         * WebKitTestRunner/TestInvocation.cpp:
2836         (WTR::TestInvocation::invoke):
2837         (WTR::sizeWebViewForCurrentTest): Deleted.
2838         (WTR::changeWindowScaleIfNeeded): Deleted.
2839         (WTR::shouldUseThreadedScrolling): Deleted.
2840         (WTR::updateThreadedScrollingForCurrentTest): Deleted.
2841         (WTR::shouldUseFixedLayout): Deleted.
2842         (WTR::updateLayoutType): Deleted.
2843         * WebKitTestRunner/TestInvocation.h:
2844         (WTR::TestInvocation::pathOrURL):
2845         * WebKitTestRunner/ios/TestControllerIOS.mm:
2846         (WTR::shouldMakeViewportFlexible):
2847         (WTR::TestController::platformConfigureViewForTest):
2848         * WebKitTestRunner/mac/TestControllerMac.mm:
2849         (WTR::shouldUseThreadedScrolling):
2850         (WTR::TestController::platformConfigureViewForTest):
2851
2852 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2853
2854         [EFL] Add dependencies packages to efl install-dependencies file
2855         https://bugs.webkit.org/show_bug.cgi?id=133720
2856
2857         Reviewed by Csaba Osztrogonác.
2858
2859         After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
2860         install doxygen and libssl-dev because efl 1.9 depends on those libraries.
2861
2862         * efl/install-dependencies:
2863
2864 2014-06-11  Zoltan Horvath  <zoltan@webkit.org>
2865
2866         Unreviewed. Moving myself to the list of reviewers.
2867
2868         * Scripts/webkitpy/common/config/contributors.json:
2869
2870 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2871
2872         [EFL] Drop to maintain EFL 32bit release bot
2873         https://bugs.webkit.org/show_bug.cgi?id=133710
2874
2875         Reviewed by Csaba Osztrogonác.
2876
2877         * BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
2878
2879 2014-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2880
2881         [GTK] Use a different user agent string depending on the site
2882         https://bugs.webkit.org/show_bug.cgi?id=132681
2883
2884         Reviewed by Anders Carlsson.
2885
2886         Add a unit test to check user agent quirks.
2887
2888         * TestWebKitAPI/PlatformGTK.cmake:
2889         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
2890         (TestWebKitAPI::TEST):
2891         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2892         (testWebKitSettings): Site specific quirks setting is now enabled
2893         by default.
2894
2895 2014-06-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2896
2897         Unreviewed, update my list of email addresses in contributors.json.
2898
2899         * Scripts/webkitpy/common/config/contributors.json:
2900
2901 2014-06-10  Simon Fraser  <simon.fraser@apple.com>
2902
2903         Always switch to an sRGB screen color profile when running tests
2904         https://bugs.webkit.org/show_bug.cgi?id=133712
2905
2906         Reviewed by Tim Horton.
2907         
2908         Switch the screen color profile to sRGB when running tests, because even ref
2909         tests need the screen to use the correct color profile.
2910
2911         * DumpRenderTree/mac/LayoutTestHelper.m:
2912         (installLayoutTestColorProfile):
2913         * Scripts/webkitpy/port/mac.py:
2914         (MacPort.start_helper):
2915
2916 2014-06-10  Martin Hodovan  <mhodovan@partner.samsung.com>
2917
2918         [EFL] Bump EFL libraries to 1.9
2919         https://bugs.webkit.org/show_bug.cgi?id=125479
2920
2921         Reviewed by Gyuyoung Kim.
2922
2923         Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
2924         and László Langó <llango.u-szeged@partner.samsung.com>.
2925
2926         * ImageDiff/CMakeLists.txt:
2927         * MiniBrowser/efl/CMakeLists.txt:
2928         * efl/install-dependencies:
2929         * efl/jhbuild.modules:
2930         * efl/jhbuildrc:
2931
2932 2014-06-10  David Farler  <dfarler@apple.com>
2933
2934         old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
2935         https://bugs.webkit.org/show_bug.cgi?id=133663
2936
2937         Reviewed by David Kilzer.
2938
2939         * Scripts/old-run-webkit-tests:
2940         (installAndLaunchDumpToolAppUsingNotification):
2941         - Remove obsolete notification keys
2942         - Key off of mandatory device UDID (a UUID)
2943         - Create a device on demand via CoreSimulator if necessary
2944         -- Grab the UDID from the created device plist.
2945         * Scripts/webkitdirs.pm:
2946         (iOSSimulatorDevicesPath): Added
2947         (iOSSimulatorDevices): Added
2948         (createiOSSimulatorDevice): Added
2949         (deleteiOSSimulatorDevice): Added
2950
2951 2014-06-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
2952
2953         [GTK][gtkdoc] remove -Wcast-align
2954         https://bugs.webkit.org/show_bug.cgi?id=133640
2955
2956         Apparently gcc warns that GParamSpec is not castable to
2957         GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
2958         though ARM hackers claim that those only need 4byte alignment. As long as gcc
2959         behaves that way, this warning is not very useful, also they break the Debian
2960         packaging.
2961
2962         This patch appends the compiler flag -Wno-align-cast for the gtkdoc
2963         scanner compilation, thus the compiler ignores the previous
2964         -Waling-cast flag.
2965
2966         Reviewed by Martin Robinson.
2967
2968         * gtk/generate-gtkdoc:
2969         (get_generator_for_config):
2970
2971 2014-06-09  Alexey Proskuryakov  <ap@apple.com>
2972
2973         Disable button animations in regression tests
2974         https://bugs.webkit.org/show_bug.cgi?id=133647
2975         <rdar://problem/16677530>
2976
2977         Reviewed by Tim Horton.
2978
2979         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2980         (WTR::InjectedBundle::platformInitialize):
2981
2982 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
2983
2984         Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
2985         https://bugs.webkit.org/show_bug.cgi?id=133650
2986
2987         Reviewed by Tim Horton.
2988         
2989         No point checking for a Windows-style path in Cocoa code.
2990
2991         * WebKitTestRunner/TestInvocation.cpp:
2992         (WTR::shouldUseThreadedScrolling):
2993
2994 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
2995
2996         Fix more latched scrolling test flakiness and slowness
2997         https://bugs.webkit.org/show_bug.cgi?id=133601
2998
2999         Reviewed by Brent Fulgham.
3000         
3001         Latched scrolling tests were flakey for two reasons. First, the EventSender
3002         wheel events were async from the web to the UI process, and the resulting
3003         synthetic events also async from the UI to the web process. Make them sync
3004         for testing.
3005         
3006         Secondly, the timer-based scrolling tree commit could result in the scrolling
3007         tree (specifically the frame node's notion of the scrollable area and content
3008         size) not being updated before the scrolling thread starts getting wheel events.
3009         Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
3010         
3011         Finally remove all the now-unnecessary timeouts from the tests.
3012
3013         * WebKitTestRunner/mac/EventSenderProxy.mm:
3014         (WTR::EventSenderProxy::mouseMoveTo):
3015         (WTR::EventSenderProxy::mouseScrollBy):
3016         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3017
3018 2014-06-09  Andrzej Badowski  <a.badowski@samsung.com>
3019
3020         [EFL] Add parameter to MiniBrowser to disable web security
3021         https://bugs.webkit.org/show_bug.cgi?id=121095
3022
3023         Reviewed by Gyuyoung Kim.
3024
3025         -w (--web-security) commandline allows to disable/enable web security (enabled by default).
3026         The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
3027         resources from other domains (cross-domain requests) such as access map location on another server.
3028         Another possibility is to launch in a webkit browser local file tests that will refer to the links
3029         in the http website loaded in an iframe. It will not be possible without deactivation of web security.
3030
3031         * MiniBrowser/efl/main.c:
3032         (window_create):
3033         (elm_main):
3034
3035 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
3036
3037         32-bit build fix.
3038
3039         * WebKitTestRunner/mac/EventSenderProxy.mm:
3040         (WTR::EventSenderProxy::mouseMoveTo):
3041         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3042
3043 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
3044
3045         Fix builds on 10.8; -firstObject isn't declared on NSArray there.
3046
3047         * DumpRenderTree/mac/DumpRenderTree.mm:
3048         (createWebViewAndOffscreenWindow):
3049         * DumpRenderTree/mac/EventSendingController.mm:
3050         (-[EventSendingController mouseScrollByX:andY:continuously:]):
3051         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
3052         * WebKitTestRunner/mac/EventSenderProxy.mm:
3053         (WTR::EventSenderProxy::mouseScrollBy):
3054         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3055
3056 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
3057
3058         Latched scrolling tests are flakey on Mavericks
3059         https://bugs.webkit.org/show_bug.cgi?id=133578
3060         <rdar://problem/17180591>
3061
3062         Reviewed by Brent Fulgham.
3063         
3064         The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
3065         be wrong on machines with more than one screen. This is because we use
3066         [NSScreen mainScreen] when computing the global coordinates of the events, but
3067         [NSScreen mainScreen] returns the screen with the key window, not the first screen.
3068         
3069         So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
3070         add comments clarifying why the coordinate math works (which is not obvious given
3071         the events have no target window).
3072         
3073         Some scrolling tests also dispatched events outside the 800x600 test window, so
3074         fix those tests, and add logging that will appear in test output when this happens.
3075
3076         * DumpRenderTree/mac/DumpRenderTree.mm:
3077         (createWebViewAndOffscreenWindow):
3078         * DumpRenderTree/mac/EventSendingController.mm:
3079         (-[EventSendingController mouseScrollByX:andY:continuously:]):
3080         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
3081         * WebKitTestRunner/mac/EventSenderProxy.mm:
3082         (WTR::EventSenderProxy::mouseMoveTo):
3083         (WTR::EventSenderProxy::mouseScrollBy):
3084         (WTR::EventSenderProxy::continuousMouseScrollBy):
3085         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3086
3087 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3088
3089         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
3090         https://bugs.webkit.org/show_bug.cgi?id=133533
3091
3092         Reviewed by Carlos Garcia Campos.
3093
3094         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
3095         (run): Remove the jhbuild-wrapper wrapper from here. It should be
3096         on Scripts/webkitpy/port/gtk.py.
3097         * Scripts/webkitpy/port/base.py:
3098         (Port.set_option): Add a set_option(name, value) function to set
3099         the optparse parameter "name" to the value "value", even if the
3100         parameter "name" is already initialized.
3101         * Scripts/webkitpy/port/gtk.py:
3102         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
3103         If another wrapper is specified via the option "-l --wrapper=x",
3104         then prepend the jhbuild-wrapper to the one specified.
3105
3106 2014-06-04  David Farler  <dfarler@apple.com>
3107
3108         Build ASan WebKit for iOS Simulator
3109         https://bugs.webkit.org/show_bug.cgi?id=133489
3110
3111         Reviewed by Darin Adler.
3112
3113         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3114         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3115         - Add missing ASan LDFLAGS.
3116         * asan/asan.xcconfig:
3117         - Split compiler-rt linker flags for OS X and iOS Simulator
3118
3119 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
3120
3121         Add myself (yoav@yoav.ws) to contributors.json
3122         https://bugs.webkit.org/show_bug.cgi?id=133492
3123
3124         * Scripts/webkitpy/common/config/contributors.json:
3125
3126 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3127
3128         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
3129         https://bugs.webkit.org/show_bug.cgi?id=133149
3130
3131         Reviewed by Csaba Osztrogonác.
3132
3133         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
3134
3135 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3136
3137         Add a verbose flag to binding tests
3138         https://bugs.webkit.org/show_bug.cgi?id=122303
3139
3140         Reviewed by Csaba Osztrogonác.
3141
3142         This patch will:
3143         - Add a verbose keyword argument to the BindingsTests constructor,
3144         - Add --no-verbose option to the run-bindigs-test.
3145         Verbose mode, which is on by default, prints positive results to stdout as before.
3146         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
3147
3148         Original patch from Matthew Hanson <matthew_hanson@apple.com>
3149
3150         * Scripts/run-bindings-tests:
3151         (main):
3152         * Scripts/webkitpy/bindings/main.py:
3153         (BindingsTests.__init__):
3154         (BindingsTests.detect_changes):
3155
3156 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
3157
3158         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
3159         https://bugs.webkit.org/show_bug.cgi?id=133455
3160
3161         Reviewed by Timothy Hatcher.
3162
3163         Since the perf. dashboard doesn't support following renamed benchmarks,
3164         keep reporting Speedometer results as DoYouEvenBench results.
3165
3166         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3167         (_generate_results_dict):
3168
3169 2014-05-31  Darin Adler  <darin@apple.com>
3170
3171         Viewport percentage tests that resize the viewport are flaky
3172         https://bugs.webkit.org/show_bug.cgi?id=133351
3173
3174         Reviewed by Anders Carlsson.
3175
3176         * DumpRenderTree/mac/DumpRenderTree.mm:
3177         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
3178         happens to be stored in the UI delegate object. This is part of resetting the
3179         window position.
3180
3181         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
3182         a frame rectangle. The size is stored in the size of the web view itself.
3183         * DumpRenderTree/mac/UIDelegate.mm:
3184         (-[UIDelegate resetWindowOrigin]): Added.
3185         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
3186         old version would store the frame, but not resize the web view!
3187         (-[UIDelegate webViewFrame:]): Get the size from the web view.
3188
3189         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3190         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
3191
3192         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3193         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
3194         the window.
3195
3196         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3197         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
3198         window gets resized too, not just the web view.
3199         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
3200
3201         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3202         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
3203         window gets resized too, not just the web view.
3204         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
3205
3206 2014-05-30  Michael Saboff  <msaboff@apple.com>
3207
3208         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
3209         https://bugs.webkit.org/show_bug.cgi?id=133409
3210
3211         Reviewed by Filip Pizlo.
3212
3213         Handle creating a tarball the same way as running remote when processing
3214         paths in prepareBundle.
3215
3216         * Scripts/run-jsc-stress-tests:
3217
3218 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
3219
3220         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
3221         https://bugs.webkit.org/show_bug.cgi?id=132280
3222
3223         Reviewed by Chris Fleizach.
3224
3225         Remove implementation of logAccessibilityEvents() for ATK based
3226         ports, as this has proved to be a flaky method of checking that
3227         ATK events are being properly emitted. Instead, it's better to use
3228         the addNotificationListener() functions and provide a JS callback
3229         to check that the right events are being emmitted from the tests.
3230
3231         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3232         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
3233         with dummy implementation.
3234         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3235         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
3236
3237 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
3238
3239         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
3240         https://bugs.webkit.org/show_bug.cgi?id=132280
3241
3242         Rubber stamped by Carlos Garcia Campos.
3243
3244         Fix two small issues with previous patch (r169483), that caused some tests to break.
3245
3246         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3247         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
3248         duplicated entry.
3249         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3250         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
3251
3252 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
3253
3254         [ATK] Added new accessibility signal: text-caret-moved.
3255         Make AccessibilityUIElement.setSelectedTextRange work
3256         as atk_text_set_caret_offset when given offset == 0.
3257         https://bugs.webkit.org/show_bug.cgi?id=132527
3258
3259         Reviewed by Mario Sanchez Prada.
3260
3261         text-caret-moved signal in accessibilityController is needed to
3262         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
3263         as LayoutTests. Add the signal to the controller.
3264
3265         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3266         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3267         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3268         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3269         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3270         (setSelectedTextRange): Change return type to bool.
3271         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3272         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
3273         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3274         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
3275         for extra arguments passed to handler and use it for text-caret-moved offset.
3276         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3277         Connect callback to new listener for ATK:AtkText:text-caret-moved.
3278         Refactor so that failures be reported.
3279         Initialize atk interfaces before trying to connect to them, see
3280         https://bugzilla.gnome.org/show_bug.cgi?id=729922
3281         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
3282         Simplify code by using a vector in place of dozen variables.
3283         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3284         Comment about not synchronizing with accessibilityController.
3285
3286 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3287
3288         [GTK] Add a WebKit2 Performance bot.
3289         https://bugs.webkit.org/show_bug.cgi?id=132862
3290
3291         Reviewed by Csaba Osztrogonác.
3292
3293         This adds a GTK WebKit2 perf bot.
3294
3295         * BuildSlaveSupport/build.webkit.org-config/config.json:
3296
3297 2014-05-29  Dan Bernstein  <mitz@apple.com>
3298
3299         Fixed the WebKitTestRunner build after r169452.
3300
3301         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3302         (WTR::InjectedBundle::initialize):
3303
3304 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
3305
3306         Unreviewed. Update my email addresses in contributors.json.
3307
3308         * Scripts/webkitpy/common/config/contributors.json:
3309
3310 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
3311
3312         Need an API test for bug #133193 (r169315)
3313         <https://bugs.webkit.org/show_bug.cgi?id=133324>
3314
3315         This adds an API test that ensures that calling "stop loading" during a
3316         "did fail provisional load" callback doesn't crash.
3317
3318         Reviewed by Andy Estes.
3319
3320         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3321         Add new files to project.
3322
3323         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
3324         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3325         If the message is the "test done" message, record that.
3326         (TestWebKitAPI::setInjectedBundleClient):
3327         Register a function for the "did receive message from injected bundle"
3328         callback.
3329         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
3330         Assert that we received the message from the injected bundle, and set
3331         'done' to finish the test.
3332         (TestWebKitAPI::TEST):
3333         Create a WebView, register a page loader client for the "did fail
3334         provisional load" callback, and load a non-existent resource.
3335
3336         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
3337         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
3338         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
3339         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
3340         provisional load failed.
3341         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
3342         Register a page loader client for the "did fail provisional load"
3343         callback.
3344         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
3345         Call WKBundlePageStopLoading() during the callback. This not crashing
3346         is what we're ensuring with this test.
3347
3348 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3349
3350         [GTK] Make it possible to build with FTL enabled
3351         https://bugs.webkit.org/show_bug.cgi?id=133219
3352
3353         Reviewed by Philippe Normand.
3354
3355         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
3356         same revision than mac.
3357
3358 2014-05-27  Michael Saboff  <msaboff@apple.com>
3359
3360         REGRESSION(r169265): sh: line 0: cd: ../.vm
3361         https://bugs.webkit.org/show_bug.cgi?id=133242
3362
3363         Rubber stamped by Oliver Hunt.
3364
3365         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
3366         array since the command may contain character escapes that don't work with the
3367         array form of system().
3368
3369         * Scripts/run-jsc-stress-tests:
3370
3371 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3372
3373         [EFL] Change download url of freetype6
3374         https://bugs.webkit.org/show_bug.cgi?id=133303
3375
3376         Reviewed by Csaba Osztrogonác.
3377
3378         freetype6 tarball isn't downloaded in Korea. So, we need to
3379         change the url for now.
3380
3381         * efl/jhbuild.modules:
3382
3383 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3384
3385         Remove BLOB guards
3386         https://bugs.webkit.org/show_bug.cgi?id=132863
3387
3388         Reviewed by Csaba Osztrogonác.
3389
3390         * Scripts/webkitperl/FeatureList.pm:
3391
3392 2014-05-27  Alberto Garcia  <berto@igalia.com>
3393
3394         Remove leftover comment from r165182.
3395
3396         Rubber stamped by Carlos Garcia Campos.
3397
3398         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3399
3400 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3401
3402         [EFL] Add LLVM as optional jhbuild module for FTL developers
3403         https://bugs.webkit.org/show_bug.cgi?id=133216
3404
3405         Reviewed by Gyuyoung Kim.
3406
3407         * efl/jhbuild.modules:
3408
3409 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3410
3411         Fix test failures on python test
3412         https://bugs.webkit.org/show_bug.cgi?id=133297
3413
3414         Reviewed by Dirk Schulze.
3415
3416         2 tests are failing because of unbounded local variable reference in test_importer.py.
3417
3418         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
3419         (TestImporter.import_tests):
3420
3421 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3422
3423         [GTK] GObject DOM bindings API break test fails in the tests bots
3424         https://bugs.webkit.org/show_bug.cgi?id=133211
3425
3426         Reviewed by Martin Robinson.
3427
3428         When generating the built product archive on platform GTK, we need
3429         to copy also the file gtkdoc-webkitdom.cfg and the directory
3430         DerivedSources/webkitdom.
3431
3432         * BuildSlaveSupport/built-product-archive:
3433         (archiveBuiltProduct):
3434
3435 2014-05-26  Commit Queue  <commit-queue@webkit.org>
3436
3437         Unreviewed, rolling out r169122.
3438         https://bugs.webkit.org/show_bug.cgi?id=133288
3439
3440         Broke CJK font fallback (Requested by ap on #webkit).
3441
3442         Reverted changeset:
3443
3444         "[Mac] WebProcess doesn't follow localization of UI process
3445         when run as a service"
3446         https://bugs.webkit.org/show_bug.cgi?id=133126
3447         http://trac.webkit.org/changeset/169122
3448
3449 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3450
3451         [GTK] WebProcess leaked when closing pages with network process enabled
3452         https://bugs.webkit.org/show_bug.cgi?id=129684
3453
3454         Reviewed by Anders Carlsson.
3455
3456         Enable the test to check that web processes finish when the web
3457         view is destroyed.
3458
3459         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3460
3461 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3462
3463         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
3464         https://bugs.webkit.org/show_bug.cgi?id=133279
3465
3466         Reviewed by Philippe Normand.
3467
3468         generator.saw_warnings is only set by GTKDoc::generate(), so it
3469         should only be used after generate.
3470
3471         * gtk/generate-gtkdoc:
3472         (generate_documentation_for_config): Do not check
3473         generator.saw_warnings again, simply return the value returned by
3474         generate_doc() which is generator.saw_warnings. When rebasing,
3475         returns always False since there aren't warnings.
3476
3477 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3478
3479         W3C test importer should catch exceptions coming from HTML/CSS conversion
3480         https://bugs.webkit.org/show_bug.cgi?id=133176
3481
3482         Reviewed by Darin Adler.
3483
3484         Exceptions raised when converting HTML/CSS are caught.
3485         Files for which conversion failed are still copied to the target directory.
3486         Each individual conversion failure is logged.
3487         Total conversion failure number is logged at the end of the import process.
3488
3489         * Scripts/webkitpy/w3c/test_importer.py:
3490         (TestImporter.import_tests):
3491
3492 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3493
3494         [GTK] Allow to run the tests on the native X display.
3495         https://bugs.webkit.org/show_bug.cgi?id=133157
3496
3497         Reviewed by Benjamin Poulain.
3498
3499         This adds a new driver (xorgdriver) that runs the tests on the
3500         X display referenced by the environment variable DISPLAY.
3501
3502         This new driver will be activated only if the environment variable
3503         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
3504         tests and performance tests.
3505
3506         This patch also makes the script run-perf-tests to check the
3507         system dependencies before starting the tests. Previously this
3508         was not checked, and if the system dependencies were not met,
3509         the script tried to execute the tests anyway, causing massive
3510         failures. For example, if you had Xvfb not installed and you
3511         wanted to use the Xvfb driver (the default on GTK and EFL),
3512         run-perf-tests would not abort.
3513
3514         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3515         (PerfTestsRunner._parse_args): Check the system dependencies of
3516         the driver before starting the tests.
3517         * Scripts/webkitpy/port/driver.py:
3518         (Driver): Implement generic check_driver method.
3519         (Driver.check_driver):
3520         (Driver.check_driver.implementation):
3521         * Scripts/webkitpy/port/gtk.py:
3522         (GtkPort._driver_class): Check for environment variable
3523         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
3524         * Scripts/webkitpy/port/xorgdriver.py: Added.
3525         (XorgDriver): Implement Xorg driver.
3526         (XorgDriver.check_driver):
3527         (XorgDriver._start):
3528
3529 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3530
3531         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
3532         https://bugs.webkit.org/show_bug.cgi?id=133215
3533
3534         Reviewed by Csaba Osztrogonác.
3535
3536         This reverts r166798.
3537
3538         * BuildSlaveSupport/kill-old-processes:
3539         (main):
3540
3541 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3542
3543         [EFL] Turn on ENABLE_CSS_FILTERS in build script
3544         https://bugs.webkit.org/show_bug.cgi?id=133278
3545
3546         Reviewed by Gyuyoung Kim.
3547
3548         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
3549
3550 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3551
3552         run-javascriptcore-tests warning fix on non Mac platforms
3553         https://bugs.webkit.org/show_bug.cgi?id=133260
3554
3555         Reviewed by Darin Adler.
3556
3557         * Scripts/webkitdirs.pm:
3558         (argumentsForConfiguration):
3559
3560 2014-05-23  Michael Saboff  <msaboff@apple.com>
3561
3562         REGRESSION(r169265): sh: line 0: cd: ../.vm
3563         https://bugs.webkit.org/show_bug.cgi?id=133242
3564
3565         Rubber stamped by Geoffrey Garen.
3566
3567         Added missing shell escapes '\' required as part of previous fix.
3568
3569         * Scripts/run-jsc-stress-tests:
3570
3571 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
3572
3573         Revert the erroneous change committed in r169286.
3574
3575         * Scripts/webkitpy/performance_tests/perftest.py:
3576         (PerfTest._run_with_driver):
3577
3578 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
3579
3580         run-perf-tests should ignore whitespace lines when snarfing test output
3581         https://bugs.webkit.org/show_bug.cgi?id=133238
3582
3583         Reviewed by Ryosuke Niwa.
3584
3585         Required for PerformanceTests/Canvas/terrain.html.
3586
3587         * Scripts/webkitpy/performance_tests/perftest.py:
3588         (PerfTest._run_with_driver):
3589         (PerfTest):
3590
3591 2014-05-23  Michael Saboff  <msaboff@apple.com>
3592
3593         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
3594         https://bugs.webkit.org/show_bug.cgi?id=133223
3595
3596         Reviewed by Geoffrey Garen.
3597
3598         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
3599         string before calling IO.popen() to work with older versions of ruby.
3600         Changed the remote path in runShellTestRunner to quote the command
3601         string we want to run via ssh so that it will work correctly with array
3602         to string conversion needed for popen.
3603
3604         * Scripts/run-jsc-stress-tests:
3605
3606 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3607
3608         Remove 'css-shaders' option from the build-webkit
3609         https://bugs.webkit.org/show_bug.cgi?id=133212
3610
3611         Reviewed by Daniel Bates.
3612
3613         Original CSS shaders removed in r162644.
3614
3615         * Scripts/webkitperl/FeatureList.pm:
3616
3617 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3618
3619         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
3620         https://bugs.webkit.org/show_bug.cgi?id=133209
3621
3622         Reviewed by Sergio Villar Senin.
3623
3624         Return FAILURE when the command failed to run.
3625
3626         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3627         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
3628
3629 2014-05-23  Alberto Garcia  <berto@igalia.com>
3630
3631         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
3632         https://bugs.webkit.org/show_bug.cgi?id=133210
3633
3634         Reviewed by Carlos Garcia Campos.
3635
3636         * gtk/install-dependencies:
3637
3638 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
3639
3640         Add Yusuke Suzuki to the list of contributors (for real)
3641
3642         Wrong section...
3643
3644         * Scripts/webkitpy/common/config/contributors.json:
3645
3646 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
3647
3648         Add Yusuke Suzuki to the list of contributors
3649
3650         * Scripts/webkitpy/common/config/contributors.json:
3651
3652 2014-05-22  Michael Saboff  <msaboff@apple.com>
3653
3654         Eliminate n/total progress update from run-jsc-stress-tests output to file
3655         https://bugs.webkit.org/show_bug.cgi?id=133191
3656
3657         Reviewed by Geoffrey Garen.
3658
3659         Changed progressMeter setting to be based on stdout being a tty instead of
3660         stdin.  Unified the processing of output from the shell runner to match the
3661         same processing as is used by the makefile runner.  As part of this, the 
3662         shell runner script was simplified.  It now forwards the output of each
3663         test_script just like the Makefile and doesn't provide its own progress.
3664
3665         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
3666         * Scripts/run-jsc-stress-tests:
3667
3668 2014-05-22  Michael Saboff  <msaboff@apple.com>
3669
3670         Add option to run-jsc-stress-tests to use installed jsc
3671         https://bugs.webkit.org/show_bug.cgi?id=133102
3672
3673         Reviewed by Geoffrey Garen.
3674
3675         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
3676         provied with the --jsc option.
3677
3678         * Scripts/run-jsc-stress-tests:
3679
3680 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3681