2813b7d226059736931b7c8ee980b60d9429bc5f
[WebKit-https.git] / Tools / ChangeLog
1 2017-04-10  Adrian Perez de Castro  <aperez@igalia.com>
2
3         [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
4         https://bugs.webkit.org/show_bug.cgi?id=170553
5
6         Reviewed by Michael Catanzaro.
7
8         Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when
9         building with GTK+ 3.22 or newer. This allows the Wayland GTK+ backend
10         to properly position popup menus, and also avoids using functions
11         which were deprecated starting at that GTK+ release.
12
13         * MiniBrowser/gtk/BrowserSearchBar.c:
14         (searchEntryMenuIconPressedCallback):
15         Update MiniBrowser to use gtk_menu_popup_at_pointer().
16
17 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
18
19         REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing
20         https://bugs.webkit.org/show_bug.cgi?id=170677
21         <rdar://problem/31512633>
22
23         Reviewed by Tim Horton.
24
25         Fixes two drag and drop LayoutTests by introducing and enabling a TestOptions switch (enableDragDestinationActionLoad)
26         to allow dropping URLs to trigger page navigation.
27
28         * DumpRenderTree/TestOptions.h:
29         * DumpRenderTree/TestOptions.mm:
30         (TestOptions::TestOptions):
31         * DumpRenderTree/mac/DumpRenderTree.mm:
32         (resetWebViewToConsistentStateBeforeTesting):
33         * DumpRenderTree/mac/UIDelegate.h:
34         * DumpRenderTree/mac/UIDelegate.mm:
35         (-[UIDelegate resetToConsistentStateBeforeTesting:]):
36         (-[UIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
37
38 2017-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
39
40         update-webkit-dependency should report $response->message for diagnose
41         https://bugs.webkit.org/show_bug.cgi?id=170666
42
43         Reviewed by Alex Christensen.
44
45         * Scripts/update-webkit-dependency: Print $response->message to STDERR if an error happens.
46
47 2017-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
48
49         Data interaction on an image enclosed by an anchor should vend the anchor's URL
50         https://bugs.webkit.org/show_bug.cgi?id=170660
51         <rdar://problem/31043220>
52
53         Reviewed by Tim Horton.
54
55         Adds two new unit tests covering cases where data interaction is triggered from an image nested underneath an
56         anchor. In one of the tests, the link has an href, and in the other, its href is missing, in which case we
57         should fall back to the image URL instead. Also fixes a related unit test that was trying to check selection
58         rects, but should not be.
59
60         See WebCore ChangeLog for more details.
61
62         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
63         * TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Added.
64         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
65         (TestWebKitAPI::TEST):
66
67 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
68
69         [GTK] Remove the GDK dependency from ImageDiff
70         https://bugs.webkit.org/show_bug.cgi?id=85299
71
72         Reviewed by Žan Doberšek.
73
74         Add a cairo only implementation of ImageDiff. We currently have 3 different implementations of ImageDiff: the
75         Gdk based one used by GTK+ port, the cairo based one used by WinCairo and the CG based one. Most of the code is
76         actually common in all of them, but it's duplicated. So, I've taken advantage of this patch to refactor the
77         ImageDiff code to share the common implementation. This patch adds the cross-platform code, and the cairo
78         implementation and enables it in the GTK+ port. In follow up patches we can move WinCairo to this implementation
79         and also add CG implementation.
80
81         * ImageDiff/CMakeLists.txt:
82         * ImageDiff/Cairo.cmake: Added.
83         * ImageDiff/ImageDiff.cpp: Added.
84         (main):
85         * ImageDiff/PlatformGTK.cmake:
86         * ImageDiff/PlatformImage.cpp: Added.
87         (ImageDiff::PlatformImage::isCompatible):
88         (ImageDiff::PlatformImage::difference):
89         * ImageDiff/PlatformImage.h: Added.
90         * ImageDiff/cairo/PlatformImageCairo.cpp: Added.
91         (ImageDiff::PlatformImage::createFromStdin):
92         (ImageDiff::PlatformImage::createFromDiffData):
93         (ImageDiff::PlatformImage::PlatformImage):
94         (ImageDiff::PlatformImage::~PlatformImage):
95         (ImageDiff::PlatformImage::width):
96         (ImageDiff::PlatformImage::height):
97         (ImageDiff::PlatformImage::rowBytes):
98         (ImageDiff::PlatformImage::hasAlpha):
99         (ImageDiff::PlatformImage::pixels):
100         (ImageDiff::PlatformImage::writeAsPNGToStdout):
101         * ImageDiff/gtk/ImageDiff.cpp: Removed.
102
103 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
104
105         REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
106         https://bugs.webkit.org/show_bug.cgi?id=170667
107
108         Reviewed by Žan Doberšek.
109
110         In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
111         that value.
112
113         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
114         (WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.
115
116 2017-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
117
118         WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results
119         https://bugs.webkit.org/show_bug.cgi?id=170653
120
121         Reviewed by Tim Horton.
122
123         When dumping pixels from a web view snapshot, we create a platform image that is then converted to a WKImage,
124         which is a ShareableBitmap, so the image is rendered into a graphics context. Then we immediately extract the
125         platform image back from the WKImage to dump the pixels. We could avoid that conversion by taking the web
126         snapshot from TestInvocation::dumpPixelsAndCompareWithExpected().
127
128         * WebKitTestRunner/PlatformWebView.h: Add PlatformImage typedef and use it as return value of windowSnapshotImage().
129         * WebKitTestRunner/TestInvocation.cpp:
130         (WTR::TestInvocation::dumpResults): Pass the WKImage to dumpPixelsAndCompareWithExpected() only when pixel
131         results were created in the web process.
132         * WebKitTestRunner/TestInvocation.h: Make WKImage a default paramater of dumpPixelsAndCompareWithExpected().
133         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
134         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the cairo surface from the given WKimage in case
135         of web contents snapshot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
136         * WebKitTestRunner/cg/TestInvocationCG.cpp:
137         (WTR::createCGContextFromCGImage): Changed to receive a CGImageRef and renamed.
138         (WTR::createCGContextFromImage): Get the CGImageRef from the WKImage and call createCGContextFromCGImage().
139         (WTR::paintRepaintRectOverlay): It receives now the image size instead of the WKImage.
140         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the CGContextRef from the WKImage in case of web
141         contents snpashot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.
142         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
143         (WTR::PlatformWebView::windowSnapshotImage): Return the cairo surface instead of creating a WKImage. Also use
144         RGB24 format to match what mac does (kCGWindowImageShouldBeOpaque).
145         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
146         (WTR::PlatformWebView::windowSnapshotImage): Return the CGImageRef instead of creating a WKImage.
147         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
148         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
149
150 2017-04-10  Chris Dumez  <cdumez@apple.com>
151
152         Drop Timer::startOneShot() overload taking a double
153         https://bugs.webkit.org/show_bug.cgi?id=170659
154
155         Reviewed by Yusuke Suzuki.
156
157         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
158
159         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
160         (TestWebKitAPI::TEST):
161         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
162         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
163
164 2017-04-09  Wenson Hsieh  <wenson_hsieh@apple.com>
165
166         [WK2] Add infrastructure to perform actions after an asynchronous position information request finishes
167         https://bugs.webkit.org/show_bug.cgi?id=170658
168         <rdar://problem/31431450>
169
170         Reviewed by Tim Horton.
171
172         Adds a new test verifying that when a web page is unresponsive, the process of preparing for data interaction
173         does not also cause the UI process to spin. We assume here that the call to prepare must be asynchronous, so it
174         should complete before the unresponsiveness timeout is triggered.
175
176         See WebKit2 ChangeLog for more details.
177
178         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
179         (TestWebKitAPI::TEST):
180
181 2017-04-09  Chris Dumez  <cdumez@apple.com>
182
183         Drop Timer::startRepeating() overload taking a double
184         https://bugs.webkit.org/show_bug.cgi?id=170656
185
186         Reviewed by Yusuke Suzuki.
187
188         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
189
190         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
191         (TestWebKitAPI::TEST):
192
193 2017-04-09  Youenn Fablet  <youenn@apple.com>
194
195         Resync WPT tests up to 23cd07d4685d81024b7440e042f8bbdb33e7ddec
196         https://bugs.webkit.org/show_bug.cgi?id=170647
197
198         Reviewed by Sam Weinig.
199
200         * Scripts/webkitpy/common/checkout/scm/git.py:
201         (Git.fetch): Fetching origin remote in case there is more than one.
202
203 2017-04-08  Simon Fraser  <simon.fraser@apple.com>
204
205         Update CSSProperties.json with correct fill-and-stroke status, and other cleanup
206         https://bugs.webkit.org/show_bug.cgi?id=170643
207
208         Reviewed by Chris Dumez.
209         
210         Update the CSSProperties.json style checker to allow:
211             - comments in codegen_properties
212             - obsolete-category and obsolete-url in specification blocks
213             - renamed "done" to "supported"
214             
215         Fix some references to codegen_properties to be codegen-properties.
216
217         * Scripts/webkitpy/style/checkers/jsonchecker.py:
218         (JSONCSSPropertiesChecker.validate_status_type):
219         (JSONCSSPropertiesChecker.validate_property_specification):
220         (JSONCSSPropertiesChecker.check_codegen_properties):
221
222 2017-04-08  Youenn Fablet  <youenn@apple.com>
223
224         WebRTC tests gardening
225         https://bugs.webkit.org/show_bug.cgi?id=170508
226
227         Reviewed by Eric Carlson.
228
229         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
230
231 2017-04-07  Keith Miller  <keith_miller@apple.com>
232
233         Add a PriorityQueue class
234         https://bugs.webkit.org/show_bug.cgi?id=170579
235
236         Reviewed by Saam Barati.
237
238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
239         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp: Added.
240         (operator  _z ):
241         (enqueue):
242         (dequeue):
243         (TEST):
244         (compareMove):
245
246 2017-04-07  Ryosuke Niwa  <rniwa@webkit.org>
247
248         Replace ES6SampleBench by ARES-6 in run-benchmark
249         https://bugs.webkit.org/show_bug.cgi?id=170585
250
251         Reviewed by Saam Barati.
252
253         Updated the plan file for ES6SampleBench to run ARES-6 instead. Also increased the number of iterations
254         from 4 to 8 to match teh default, and reduced the number of browser instances to use from 5 to 3.
255
256         * Scripts/webkitpy/benchmark_runner/data/patches/ARES-6.patch: Renamed from ES6SampleBench.patch.
257         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan: Renamed from es6bench.plan.
258
259 2017-04-07  Myles C. Maxfield  <mmaxfield@apple.com>
260
261         REGRESSION(r211382): Complex text with justification erroneously overflows containers
262         https://bugs.webkit.org/show_bug.cgi?id=170399
263         <rdar://problem/31442008>
264
265         Reviewed by Simon Fraser.
266
267         Check for the invariant that the sum of the advances is equal to m_totalWidth.
268
269         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
270         (TestWebKitAPI::TEST_F):
271
272 2017-04-07  Ryan Haddad  <ryanhaddad@apple.com>
273
274         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
275         https://bugs.webkit.org/show_bug.cgi?id=167594
276
277         Unreviewed test gardening.
278
279         Disable this test because it is still timing out on the bots.
280
281         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
282         (TEST):
283
284 2017-04-07  Jonathan Bedard  <jbedard@apple.com>
285
286         REGRESSION (r214553): Allow layout-tests to be run from Xcode without re-directing stdout, stdin and stderr
287         https://bugs.webkit.org/show_bug.cgi?id=170601
288         <rdar://problem/31492696>
289
290         Reviewed by Simon Fraser.
291
292         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
293         (setUpIOSLayoutTestCommunication): Skip TCP setup if no port is in the environment.
294         (tearDownIOSLayoutTestCommunication): Only teardown if TCP was used.
295
296 2017-04-07  Aakash Jain  <aakash_jain@apple.com>
297
298         Add support for test262 JavaScriptCore tests
299         https://bugs.webkit.org/show_bug.cgi?id=170523
300
301         Reviewed by Daniel Bates.
302
303         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bot433 and bot434.
304         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
305         (RunTest262Tests): Added class to run Test262 tests.
306         (RunTest262Tests.start): Added.
307         (RunTest262Tests.countFailures): Method to count the failures.
308         (Test262Factory): Added Test262 factory class.
309         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
310         (RunTest262TestsTest): Added unit tests.
311         (RunTest262TestsTest.assertResults): Helper method.
312         (RunTest262TestsTest.test_no_regressions_output): Added test case.
313         (test_failure_output): Same. 
314         (test_failures_output): Same.
315
316 2017-04-07  Caio Lima  <ticaiolima@gmail.com>
317
318         [JSC] Change --debug option to --debugger
319         https://bugs.webkit.org/show_bug.cgi?id=170587
320
321         Reviewed by Keith Miller.
322
323         * Scripts/run-jsc:
324
325         This patch is changing the new debugger flag for Tools/Scripts/run-jsc
326         to --debugger to avoid shadowing --debug flag used to run JSC with
327         Debug build.
328
329 2017-04-07  Brent Fulgham  <bfulgham@apple.com>
330
331         WebKit should percent encode single quotes in query strings
332         https://bugs.webkit.org/show_bug.cgi?id=170561
333         <rdar://problem/7415154>
334
335         Reviewed by Alex Christensen.
336
337         Add a test case for single-quote in the URL query string.
338
339         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
340
341 2017-04-06  Myles C. Maxfield  <mmaxfield@apple.com>
342
343         Make FontWithFeatures test font pass OTS
344         https://bugs.webkit.org/show_bug.cgi?id=169788
345
346         Reviewed by Tim Horton.
347
348         OTS, or the OpenType Sanitizer, is a check which tells if fonts are properly formed.
349         Previously, our FontWithFeatures test font did not pass this check. This patch updates
350         the font to pass the checks. Now, we can use this font on other platforms, and
351         contribute the font to the W3C for testing the CSS Fonts level 3 spec.
352
353         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
354         (Generator::appendCFFTable):
355         (Generator::Feature::operator<):
356         (Generator::appendGSUBTable):
357         (Generator::appendOS2Table):
358         (Generator::appendFormat4CMAPTable):
359         (Generator::appendHEADTable):
360         (Generator::appendHHEATable):
361         (Generator::NameRecord::operator<):
362         (Generator::appendNameSubtable):
363         (Generator::appendNAMETable):
364
365 2017-04-06  Alexey Proskuryakov  <ap@apple.com>
366
367         Disable flaky WebKit2.ResizeWithHiddenContentDoesNotHang
368         for https://bugs.webkit.org/show_bug.cgi?id=170195
369
370         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
371
372 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
373
374         Unreviewed, rolling out r215046.
375
376         This change broke internal builds.
377
378         Reverted changeset:
379
380         "WebRTC tests gardening"
381         https://bugs.webkit.org/show_bug.cgi?id=170508
382         http://trac.webkit.org/changeset/215046
383
384 2017-04-06  Youenn Fablet  <youenn@apple.com>
385
386         WebRTC tests gardening
387         https://bugs.webkit.org/show_bug.cgi?id=170508
388
389         Reviewed by Eric Carlson.
390
391         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
392
393 2017-04-06  Jonathan Bedard  <jbedard@apple.com>
394
395         REGRESSION: Simulators failing to install after launch_app times out
396         <rdar://problem/31478107>
397
398         Unreviewed infrastructure fix.
399
400         * Scripts/webkitpy/xcode/simulated_device.py:
401         (SimulatedDevice.launch_app._install_timeout): Raise RuntimeError, not Exception.
402
403 2017-04-05  Joseph Pecoraro  <pecoraro@apple.com>
404
405         test262: module test progressions need updated expectations (@@iterator changes)
406         https://bugs.webkit.org/show_bug.cgi?id=170535
407
408         Reviewed by Saam Barati.
409
410         * Scripts/run-jsc-stress-tests:
411         Add :failDueToOutdatedOrBadTest to distinguish between a test failure
412         in JavaScriptCore or an outdated or incorrect test262 test.
413
414 2017-04-05  Joseph Pecoraro  <pecoraro@apple.com>
415
416         Remove run-jsc-stress-tests benign warning about otool '-S' switch
417         https://bugs.webkit.org/show_bug.cgi?id=170527
418
419         Reviewed by Aakash Jain.
420
421         * Scripts/run-jsc-stress-tests:
422         The switch is not necessary and produces an error.
423
424 2017-04-05  Jonathan Bedard  <jbedard@apple.com>
425
426         webkitpy: Add pid logging for simulator processes
427         https://bugs.webkit.org/show_bug.cgi?id=170505
428
429         Reviewed by Alexey Proskuryakov.
430
431         * Scripts/webkitpy/port/simulator_process.py:
432         (SimulatorProcess._start.handler): Add pid to exception.
433         (SimulatorProcess._start): Ditto.
434         * Scripts/webkitpy/xcode/simulated_device.py:
435         (SimulatedDevice.launch_app): Log pid when the process fails to launch and when
436         a pid is successfully returned.
437
438 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
439
440         Unreviewed, rolling out r214932.
441
442         This change broke an internal build.
443
444         Reverted changeset:
445
446         "[ios-simulator] API test WebKit2.DataDetectionReferenceDate
447         timing out"
448         https://bugs.webkit.org/show_bug.cgi?id=161967
449         http://trac.webkit.org/changeset/214932
450
451 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
452
453         Unreviewed, rolling out r214962.
454
455         Roll r214937 back in because it wasn't at fault for the build
456         breakage.
457
458         Reverted changeset:
459
460         "Unreviewed, rolling out r214937."
461         https://bugs.webkit.org/show_bug.cgi?id=170365
462         http://trac.webkit.org/changeset/214962
463
464 2017-04-05  Ryan Haddad  <ryanhaddad@apple.com>
465
466         Unreviewed, rolling out r214937.
467
468         This change broke an internal build.
469
470         Reverted changeset:
471
472         "REGRESSION (r202472): Data Detection overwrites existing
473         links in detected ranges"
474         https://bugs.webkit.org/show_bug.cgi?id=170365
475         http://trac.webkit.org/changeset/214937
476
477 2017-04-05  Jonathan Bedard  <jbedard@apple.com>
478
479         Increase timeouts for simulator testing
480         Unreviewed infrastructure fix.
481
482         r214895 was not sufficient, increasing timeouts again.
483
484         * Scripts/webkitpy/xcode/simulated_device.py:
485         (SimulatedDevice.install_app): Increase timeout from 3 to 10 seconds.
486
487 2017-04-05  Aakash Jain  <aakash_jain@apple.com>
488
489         Formatting fix to remove extra space.
490
491         Unreviewed formatting fix.
492
493         * Scripts/webkitdirs.pm:
494         (isEmbeddedWebKit): Remove extra space.
495
496 2017-04-05  Aakash Jain  <aakash_jain@apple.com>
497
498         Rename isIOSLikeWebKit to isEmbeddedWebKit.
499
500         Rubber-stamped by Alexey Proskuryakov. 
501
502         * Scripts/webkitdirs.pm:
503         (isEmbeddedWebKit): Added
504         (isIOSLikeWebKit): Deleted.
505
506 2017-04-05  Alex Christensen  <achristensen@webkit.org>
507
508         Fix CMake build.
509
510         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
511         * TestRunnerShared/spi/CoreGraphicsSPI.h: Removed.
512         * TestRunnerShared/spi/CoreGraphicsTestSPI.h: Copied from Tools/TestRunnerShared/spi/CoreGraphicsSPI.h.
513         There is a CoreGraphicsSPI.h in WebCore and the CMake build was finding the wrong one.
514         Since we just inherit the include paths from WebCore in the CMake build and since this SPI is only used for testing,
515         I just renamed CoreGraphicsSPI.h to CoreGraphicsTestSPI.h to avoid any name collisions.
516         * WebKitTestRunner/PlatformMac.cmake:
517         Add some missing files.
518         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
519
520 2017-04-05  Keith Miller  <keith_miller@apple.com>
521
522         Add debug option to run-jsc script
523         https://bugs.webkit.org/show_bug.cgi?id=170503
524
525         Reviewed by Yusuke Suzuki.
526
527         Adds a new option to the run-jsc script so that when passed
528         "--debug" it will wrap the jsc call with an lldb invocation. If
529         someone wishes to use a different debugger they can set the
530         DEBUGGER environment variable. Additionally, run-jsc now exits
531         with the exit status of the jsc call.
532
533         * Scripts/run-jsc:
534
535 2017-04-05  Andy Estes  <aestes@apple.com>
536
537         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
538         https://bugs.webkit.org/show_bug.cgi?id=170365
539         <rdar://problem/29205721>
540
541         Reviewed by Tim Horton.
542
543         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
544         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
545         (TEST): Re-enabled the test, which now passes.
546
547 2017-04-05  Andy Estes  <aestes@apple.com>
548
549         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
550         https://bugs.webkit.org/show_bug.cgi?id=167594
551
552         Re-enabled this API test now that webkit.org/b/161967 is fixed.
553
554         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
555         (TEST):
556
557 2017-04-05  Andy Estes  <aestes@apple.com>
558
559         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
560         https://bugs.webkit.org/show_bug.cgi?id=161967
561
562         Reviewed by Alexey Proskuryakov.
563
564         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
565         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
566
567 2017-04-04  Simon Fraser  <simon.fraser@apple.com>
568
569         Various settings in Minibrowser are off by default, and should be on
570         https://bugs.webkit.org/show_bug.cgi?id=170465
571         rdar://problem/31421543
572
573         Reviewed by Tim Horton.
574
575         Explicitly set preferences that should be on by default to enabled, if they have not been
576         set previously.
577
578         * MiniBrowser/mac/SettingsController.m:
579         (-[SettingsController init]):
580
581 2017-04-04  JF Bastien  <jfbastien@apple.com>
582
583         Add JF Bastien as reviewer
584         https://bugs.webkit.org/show_bug.cgi?id=170481
585
586         Reviewed by Mark Lam.
587
588         * Scripts/webkitpy/common/config/contributors.json:
589
590 2017-04-04  Jonathan Bedard  <jbedard@apple.com>
591
592         Increase timeouts for simulator testing
593
594         Unreviewed infrastructure fix.
595
596         * Scripts/webkitpy/port/simulator_process.py:
597         (SimulatorProcess._start): Increase timeout from 3 to 6 seconds.
598         * Scripts/webkitpy/xcode/simulated_device.py:
599         (SimulatedDevice.install_app): Increase timeout from 1 to 3 seconds.
600
601 2017-04-04  Tim Horton  <timothy_horton@apple.com>
602
603         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
604         https://bugs.webkit.org/show_bug.cgi?id=165801
605         <rdar://problem/29649535>
606
607         Reviewed by Wenson Hsieh.
608
609         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
610         (TEST):
611         Add some tests for wrapping finds.
612
613 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
614
615         Add some new patterns to filter-build-webkit
616         https://bugs.webkit.org/show_bug.cgi?id=170429
617
618         Reviewed by Alexey Proskuryakov.
619
620         * Scripts/filter-build-webkit:
621         (setOutputFormatOption):
622
623 2017-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
624
625         Data interaction should register type identifiers in order of priority
626         https://bugs.webkit.org/show_bug.cgi?id=170428
627         <rdar://problem/30633296>
628
629         Reviewed by Tim Horton.
630
631         Augments existing unit tests to check for the existence and priority of type identifiers in the UIItemProviders
632         created upon starting data interaction. Also fixes a race condition in one of the unit tests and adds a new unit
633         test for data interaction from a textarea to an input.
634
635         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
636         (checkTypeIdentifierPrecedesOtherTypeIdentifier):
637         (TestWebKitAPI::TEST):
638         * TestWebKitAPI/ios/DataInteractionSimulator.h:
639         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
640         (-[DataInteractionSimulator _advanceProgress]):
641         (-[DataInteractionSimulator sourceItemProviders]):
642         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
643
644 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
645
646         [GTK][JHBuild] Update mesa repository url for tarballs
647         https://bugs.webkit.org/show_bug.cgi?id=170431
648
649         Reviewed by Michael Catanzaro.
650
651         * gtk/jhbuild.modules:
652
653 2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
654
655         TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf
656         https://bugs.webkit.org/show_bug.cgi?id=170430
657
658         Reviewed by Alexey Proskuryakov.
659
660         * TestWebKitAPI/Tests/mac/Ahem.ttf: Removed.
661         Eliminate one of the copies of Ahem.ttf.
662
663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
664         Once eliminated, there is now only one Ahem.ttf that is copied
665         to the Resources bundle. Drive-by sort the project file.
666
667 2017-04-03  Simon Fraser  <simon.fraser@apple.com>
668
669         Allow MiniBrowser windows to receive local file drags again
670         https://bugs.webkit.org/show_bug.cgi?id=170422
671
672         Reviewed by Wenson Hsieh.
673
674         Adopt the new UIDelegate SPI to allow drops.
675
676         * MiniBrowser/mac/WK2BrowserWindowController.m:
677         (-[WK2BrowserWindowController _webView:dragDestinationActionMaskForDraggingInfo:]):
678
679 2017-04-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
680
681         [GTK][JHBuild] Fetch libvpx from a release tarball instead of git
682         https://bugs.webkit.org/show_bug.cgi?id=170426
683
684         Reviewed by Michael Catanzaro.
685
686         * gtk/jhbuild.modules:
687
688 2017-04-03  Nan Wang  <n_wang@apple.com>
689
690         AX: Expose link children when doing search predication on iOS
691         https://bugs.webkit.org/show_bug.cgi?id=170424
692         <rdar://problem/31413335>
693
694         Reviewed by Chris Fleizach.
695
696         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
697         (AccessibilityUIElement::uiElementForSearchPredicate):
698         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
699         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
700
701 2017-04-03  Brian Burg  <bburg@apple.com>
702
703         run-safari should support launching with custom language and locale
704         https://bugs.webkit.org/show_bug.cgi?id=170397
705
706         Reviewed by Alexey Proskuryakov.
707
708         Hook up -AppleLanguages and -AppleLocale to command line options.
709
710         * Scripts/webkitdirs.pm:
711         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
712         (argumentsForRunAndDebugMacWebKitApp):
713
714 2017-04-03  Jonathan Bedard  <jbedard@apple.com>
715
716         webkitpy: Provide option to skip install
717         https://bugs.webkit.org/show_bug.cgi?id=170344
718
719         Reviewed by Alexey Proskuryakov.
720
721         Installing can take time for on device testing.  Provide an option to skip install
722         and use whatever driver is currently installed on the device or simulator.
723
724         * Scripts/webkitpy/port/base.py:
725         (Port.check_build): Do not check driver if skipping install.
726         * Scripts/webkitpy/port/factory.py:
727         (platform_options): Add '--no-install' option.
728         * Scripts/webkitpy/port/ios.py:
729         (IOSPort.setup_test_run): Check install option before installing.
730
731 2017-04-03  Keith Miller  <keith_miller@apple.com>
732
733         WebAssembly: Update spec tests
734         https://bugs.webkit.org/show_bug.cgi?id=170361
735
736         Rubber-stamped by Saam Barati.
737
738         Update the runner to know the new wasm spec test harness code.
739
740         * Scripts/run-jsc-stress-tests:
741
742 2017-04-01  Alexey Proskuryakov  <ap@apple.com>
743
744         Rolling back <https://trac.webkit.org/r214697>, as it made WebKit2.DataDetectionReferenceDate time out.
745
746         Was REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
747         https://bugs.webkit.org/show_bug.cgi?id=170365
748
749         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
750
751 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
752
753         Mac cmake buildfix after 214586.
754         https://bugs.webkit.org/show_bug.cgi?id=170381
755
756         Unreviewed speculative buildfix.
757
758         * WebKitTestRunner/PlatformMac.cmake:
759
760 2017-04-01  Csaba Osztrogonác  <ossy@webkit.org>
761
762         Unreviewed speculative Mac cmake buildfix after r214586, just for fun.
763         https://bugs.webkit.org/show_bug.cgi?id=161675
764
765         * WebKitTestRunner/PlatformMac.cmake:
766
767 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
768
769         webkitpy: Add target host concept
770         https://bugs.webkit.org/show_bug.cgi?id=170186
771         <rdar://problem/31301797>
772
773         Reviewed by Alexey Proskuryakov.
774
775         Adding the idea of a target host. Target hosts are objects conforming to the
776         structure of the SystemHost object in Scripts/webkitpy/common/system/systemhost.py
777         Target hosts are the hosts associated with a worker process.
778
779         * Scripts/webkitpy/common/system/filesystem.py:
780         (FileSystem.map_base_host_path): Convert a path from an absolute path on the base
781         host to an absolute path on this host.
782         (FileSystem.move_to_base_host): Move file from this host to the base host.
783         (FileSystem.move_from_base_host): Move file from the base host to this host.
784         (FileSystem.copy_to_base_host): Copy file from this host to the base host.
785         (FileSystem.copy_from_base_host): Copy file from the base host to this host.
786         * Scripts/webkitpy/common/system/filesystem_mock.py:
787         (MockFileSystem.map_base_host_path): Convert a path from an absolute path on the base
788         host to an absolute path on this host.
789         (MockFileSystem.move_to_base_host): Move file from this host to the base host.
790         (MockFileSystem.move_from_base_host): Move file from the base host to this host.
791         (MockFileSystem.copy_to_base_host): Copy file from this host to the base host.
792         (MockFileSystem.copy_from_base_host): Copy file from the base host to this host.
793         * Scripts/webkitpy/port/base.py:
794         (Port.target_host): Return host determined by worker number.
795         (Port.abspath_for_test): Accept optional target_host argument to return location
796         of test on a target host.
797         (Port._driver_tempdir): Accept optional target_host argument to return a temporary
798         directory on a target host.
799         (Port.sample_process): Accept optional target_host argument to sample process on
800         a target host.
801         * Scripts/webkitpy/port/darwin.py:
802         (DarwinPort.sample_process): Run sample process on target host.
803         (DarwinPort.sample_file_path): Accept directory for file.
804         (DarwinPort.spindump_file_path): Ditto.
805         * Scripts/webkitpy/port/darwin_testcase.py:
806         (DarwinTest.test_spindump): Check file movement.
807         (DarwinTest.test_sample_process): Ditto.
808         (DarwinTest.test_sample_process_exception):
809         * Scripts/webkitpy/port/driver.py:
810         (Driver.__init__): Add and set self._target_host variable.
811         (Driver._start): Pass target host to _driver_tempdir().
812         (Driver.stop): Call the target host's rmtree.
813         (Driver._check_for_driver_timeout): Pass target host to sample_process.
814         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
815         (Driver._command_from_driver_input): Pass target host to abspath_for_test and map
816         layout test directory to target host.
817         * Scripts/webkitpy/port/ios.py:
818         (IOSPort):
819         (IOSPort.target_host): Replaced device_for_worker_number.
820         (IOSPort.setup_test_run): Replace device_for_worker_number with target_host.
821         (IOSPort.device_for_worker_number): Replaced with target_host.
822         * Scripts/webkitpy/port/server_process.py:
823         (ServerProcess.__init__): Accept target_host instead of worker_number.
824         (ServerProcess._start): Replace _host with _target_host.
825         (ServerProcess._handle_timeout): Ditto.
826         (ServerProcess._kill): Ditto.
827         * Scripts/webkitpy/port/simulator_process.py:
828         (SimulatorProcess.__init__): Accept target_host instead of worker_number.
829         (SimulatorProcess._start): Replace _device with _target_host.
830         (SimulatorProcess.stop): Ditto.
831         (SimulatorProcess._kill): Deleted.
832
833 2017-03-31  Jonathan Bedard  <jbedard@apple.com>
834
835         Unreviewed fix after r214569
836         https://bugs.webkit.org/show_bug.cgi?id=170255
837
838         Unreviewed infrastructure fix.
839
840         * Scripts/webkitpy/port/ios.py:
841         (IOSPort.clean_up_test_run): Check if the device is defined before teardown.
842
843 2017-03-31  Andy Estes  <aestes@apple.com>
844
845         REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
846         https://bugs.webkit.org/show_bug.cgi?id=170365
847         <rdar://problem/29205721>
848
849         Reviewed by Tim Horton.
850
851         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
852         (expectLinkCount): Changed to only query links with the x-apple-data-detectors attribute.
853         (TEST): Re-enabled the test, which now passes.
854
855 2017-03-31  Tim Horton  <timothy_horton@apple.com>
856
857         Mail can get stuck underneath FindController::findStringMatches after searching in a long message
858         https://bugs.webkit.org/show_bug.cgi?id=170326
859         <rdar://problem/30330395>
860
861         Reviewed by Simon Fraser.
862
863         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
864         (TEST):
865
866 2017-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
867
868         Unreviewed. Fix WTR crashes in GTK+ port after r214413.
869
870         Fixes: http/tests/ssl/upgrade-origin-usage.html
871                http/tests/websocket/tests/hybi/network-process-crash-error.html
872                http/tests/websocket/tests/hybi/simple-wss.html
873
874         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
875         (WTR::TestController::platformContext): Return the context.
876
877 2017-03-30  Sam Weinig  <sam@webkit.org>
878
879         Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWebView SPI
880         https://bugs.webkit.org/show_bug.cgi?id=170315
881
882         Reviewed by Simon Fraser.
883
884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
885         * TestWebKitAPI/Tests/WebKit2Cocoa/PrepareForMoveToWindow.mm: Added.
886         Add test showing the completion handler is called.
887
888 2017-03-30  Filip Pizlo  <fpizlo@apple.com>
889
890         Air should support linear scan for optLevel<2
891         https://bugs.webkit.org/show_bug.cgi?id=170161
892
893         Reviewed by Saam Barati.
894         
895         This makes us run a bunch of JS tests at optLevel=1 to force testing of this new compiler
896         pipeline.
897
898         * Scripts/run-jsc-stress-tests:
899
900 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
901
902         Support tvOS and watchOS in webkitdirs.pm
903         https://bugs.webkit.org/show_bug.cgi?id=170267
904
905         Reviewed by Alexey Proskuryakov.
906
907         * Scripts/webkitdirs.pm:
908         (determineXcodeSDK): Evaluate sdk for tvos and watchos.
909         (xcodeSDKPlatformName): Added support for tvos and watchos.
910         (determinePortName): Same.
911         (isAppleCocoaWebKit): Same.
912         (willUseAppleTVDeviceSDK): Added.
913         (willUseAppleTVSimulatorSDK): Added.
914         (willUseWatchDeviceSDK): Added.
915         (willUseWatchSimulatorSDK): Added.
916         (isTVOSWebKit): Added.
917         (isWATCHOSWebKit): Added.
918         (isIOSLikeWebKit): Added.
919
920 2017-03-30  Wenson Hsieh  <wenson_hsieh@apple.com>
921
922         [WK2] Touches should not cancel when showing a custom action sheet while data interaction is active
923         https://bugs.webkit.org/show_bug.cgi?id=170291
924         <rdar://problem/31301388>
925
926         Reviewed by Tim Horton.
927
928         Adds support for testing how the custom action sheet presentation codepath interacts with data interaction, as
929         well as a new unit test. In this case, we force data interaction to fail if touches are canceled on the
930         shared UIApplication, and verify that data interaction completes successfully.
931
932         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
933         (TestWebKitAPI::TEST):
934         * TestWebKitAPI/ios/DataInteractionSimulator.h:
935         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
936         (-[DataInteractionSimulatorApplication _cancelAllTouches]):
937         (-[DataInteractionSimulator initWithWebView:]):
938         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
939         (-[DataInteractionSimulator runFrom:to:]):
940         (-[DataInteractionSimulator _advanceProgress]):
941         (-[DataInteractionSimulator _webView:showCustomSheetForElement:]):
942
943 2017-03-30  Per Arne Vollan  <pvollan@apple.com>
944
945         [Win] Pass close_fds = True in Python popen call.
946         https://bugs.webkit.org/show_bug.cgi?id=170172
947
948         Reviewed by Brent Fulgham.
949
950         This was previously not supported on Windows, but in Python 2.7.10 it is.
951
952         * Scripts/webkitpy/common/system/executive.py:
953         (Executive._should_close_fds):
954         * Scripts/webkitpy/port/server_process.py:
955         (ServerProcess._start):
956
957 2017-03-30  Aakash Jain  <aakash_jain@apple.com>
958
959         Change my status to be a WebKit reviewer.
960
961         Unreviewed status update edit.
962
963         * Scripts/webkitpy/common/config/contributors.json:
964
965 2017-03-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
966
967         Change my status to be a WebKit reviewer.
968
969         Unreviewed status update edit.
970
971         * Scripts/webkitpy/common/config/contributors.json:
972
973 2017-03-29  Tim Horton  <timothy_horton@apple.com>
974
975         Swipe gesture tests don't work on macOS Sierra
976         https://bugs.webkit.org/show_bug.cgi?id=161675
977         <rdar://problem/23379930>
978
979         Reviewed by Darin Adler.
980
981         * DumpRenderTree/mac/UIScriptControllerMac.mm:
982         (WTR::UIScriptController::platformPlayBackEventStream):
983         (WTR::UIScriptController::beginBackSwipe):
984         (WTR::UIScriptController::completeBackSwipe):
985         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h: Copied from Tools/DumpRenderTree/mac/UIScriptControllerMac.mm.
986         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm: Added.
987         (eventIsOfType):
988         (eventIsOfTypes):
989         (eventIsOfGestureType):
990         (eventIsOfGestureTypes):
991         (+[EventSerializer dictionaryForEvent:relativeToTime:]):
992         (+[EventSerializer createEventForDictionary:inWindow:relativeToTime:]):
993         (+[EventSerializer playEventStream:inWindow:completionHandler:]):
994         * TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.h: Copied from Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm.
995         * TestRunnerShared/EventSerialization/mac/SharedEventStreamsMac.mm: Added.
996         (beginSwipeBackEventStream):
997         (completeSwipeBackEventStream):
998         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
999         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1000         (WTR::UIScriptController::playBackEventStream):
1001         (WTR::UIScriptController::beginBackSwipe):
1002         (WTR::UIScriptController::completeBackSwipe):
1003         (WTR::UIScriptController::platformPlayBackEventStream):
1004         (WTR::UIScriptController::platformClearAllCallbacks): Deleted.
1005         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1006         * TestRunnerShared/spi/CoreGraphicsSPI.h: Added.
1007         * TestRunnerShared/spi/IOKitSPI.h: Renamed from Tools/WebKitTestRunner/ios/IOKitSPI.h.
1008         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1009         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1010         (WTR::playBackEvents):
1011         (WTR::UIScriptController::beginBackSwipe):
1012         (WTR::UIScriptController::completeBackSwipe):
1013         (WTR::UIScriptController::platformPlayBackEventStream):
1014
1015 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
1016
1017         webkitpy: Robust test clean-up
1018         https://bugs.webkit.org/show_bug.cgi?id=170255
1019
1020         Reviewed by Alexey Proskuryakov.
1021
1022         On-device testing is the motivation for this change.  Failure to run clean-up functions can
1023         result in zombie processes, residual NFS mounts and other undesirable remnants from a failed
1024         test run.  Make an effort to clean-up even if exceptions are thrown during set-up or clean-up.
1025
1026         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1027         (Manager._set_up_run): Clean up test run if set-up fails.
1028         * Scripts/webkitpy/port/ios.py:
1029         (IOSPort.clean_up_test_run): Continue cleaning up devices even after an exception is thrown.
1030
1031 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
1032
1033         Simulator testing stops after the first crash
1034         <rdar://problem/31325362>
1035
1036         Unreviewed infrastructure fix.
1037
1038         * Scripts/webkitpy/xcode/simulated_device.py:
1039         (SimulatedDevice):
1040         (SimulatedDevice.launch_app): Increase timeout when attempting to launch app.
1041
1042 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
1043
1044         webkitpy: Standardize web-server port definitions
1045         https://bugs.webkit.org/show_bug.cgi?id=170144
1046         <rdar://problem/31284026>
1047
1048         Reviewed by Daniel Bates.
1049
1050         Default web-server ports should be declared in global variables.
1051         Add functions to web-servers which return the ports these servers
1052         are using so that other tools can forward them.
1053
1054         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1055         (LayoutTestApacheHttpd.__init__): Use shared constants in http_server_base.py.
1056         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1057         (TestLayoutTestApacheHttpd.test_start_cmd): Check port_to_forward for expected values.
1058         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1059         (Lighttpd.__init__): Use shared constants in http_server_base.py.
1060         (Lighttpd._prepare_config): Ditto.
1061         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1062         (HttpServerBase): Add default port constants.
1063         (HttpServerBase.ports_to_forward): Add function to return ports used for http server.
1064         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1065         (TestHttpServer.test_start_cmd): Check port_to_forward for expected values.
1066         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1067          (WebPlatformTestServer.ports_to_forward): Add function to return ports used for web-platform tests.
1068         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1069         (PyWebSocket): Make default port values public.
1070         (PyWebSocket.__init__): Use public default port.
1071         (PyWebSocket.ports_to_forward): Return port used in an array.
1072         * Scripts/webkitpy/port/base.py:
1073         (Port.to.ports_to_forward): Return all ports used the various web-servers managed by the port object.
1074         (Port.to.start_websocket_server): Use PyWebSocket port constants.
1075
1076 2017-03-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1077
1078         Links with empty hrefs should not be drag sources
1079         https://bugs.webkit.org/show_bug.cgi?id=170241
1080         <rdar://problem/31305505>
1081
1082         Reviewed by Tim Horton.
1083
1084         Adds a new API test: DataInteractionTests.LinkWithEmptyHREF.
1085
1086         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1087         (TestWebKitAPI::TEST):
1088         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1089
1090         Expose the current phase of the data interaction simulator for verifying behaviors in unit tests.
1091
1092         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1093         (-[DataInteractionSimulator phase]):
1094
1095 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
1096
1097         Use TCP instead of FIFOs for Simulator/Device communication
1098         https://bugs.webkit.org/show_bug.cgi?id=169419
1099         <rdar://problem/30949615>
1100
1101         Reviewed by Alexey Proskuryakov.
1102
1103         Using TCP instead of FIFOs when communicating with devices allows the device being tested
1104         to be on a different machine then the one handling the management of the test run.
1105
1106         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1107         * DumpRenderTree/mac/DumpRenderTree.mm:
1108         (dumpRenderTree): Call setUp/tearDownIOSLayoutTestCommunication() instead of using FIFOs.
1109         * Scripts/webkitpy/port/device.py:
1110         (Device.__init__): Initialize the listening_socket.
1111         (Device.listening_port): Return port of listening socket.
1112         (Device.prepare_for_testing): Open listening socket on an open port, prepare platform device
1113         fro testing.
1114         (Device.finished_testing): Close listening socket associated with this device, call the
1115         platform device's finished_testing function if it exists.
1116         * Scripts/webkitpy/port/ios.py:
1117         (IOSPort.setup_test_run): Prepare each device for testing.
1118         (IOSPort.clean_up_test_run): Notify each device that testing has completed.
1119         * Scripts/webkitpy/port/ios_simulator.py:
1120         (IOSSimulatorPort): Work around device persistence bug.
1121         (IOSSimulatorPort.__init__): Ditto.
1122         * Scripts/webkitpy/port/simulator_process.py:
1123         (SimulatorProcess):
1124         (SimulatorProcess.NonBlockingFileFromSocket): Add to work around shortcomings in
1125         Python 2’s makefile.
1126         (SimulatorProcess.NonBlockingFileFromSocket.__init__): Initialize file with socket.
1127         (SimulatorProcess.ReadFileSocket.close): Close file and then socket;
1128         (SimulatorProcess.__init__): Pass TCP port over environment, remove FIFO names.
1129         (SimulatorProcess.__getattr__): Expose all file attributes.
1130         (SimulatorProcess._accept_connection_create_file): Wait for connection from server and
1131         create and return a file-like object from the incoming connection.
1132         (SimulatorProcess._start): Use TCP connections instead of FIFOs.
1133         (SimulatorProcess._start.handler): Output server port in timeout exception.
1134         (SimulatorProcess._reset): Deleted.
1135         * TestRunnerShared/IOSLayoutTestCommunication.cpp: Added.
1136         (connectToServer): Return socket connected to the provided server address.
1137         (setupiOSLayoutTestCommunication): Connect stdin, stdout and stderr as socket to a
1138         TCP server running on localhost.
1139         (tearDownIOSLayoutTestCommunication): Close stdin, stdout and stderr TCP sockets.
1140         * TestRunnerShared/IOSLayoutTestCommunication.h: Added.
1141         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1142         * WebKitTestRunner/ios/TestControllerIOS.mm:
1143         (WTR::TestController::platformInitialize): Call setUpIOSLayoutTestCommunication()
1144         instead of using FIFOs.
1145         (WTR::TestController::platformDestroy): Call tearDownIOSLayoutTestCommunication().
1146
1147 2017-03-29  Jonathan Bedard  <jbedard@apple.com>
1148
1149         webkitpy: Add IOSDevicePort and IOSPort tests
1150         https://bugs.webkit.org/show_bug.cgi?id=170206
1151         <rdar://problem/31308364>
1152
1153         Reviewed by Alexey Proskuryakov.
1154
1155         * Scripts/webkitpy/port/darwin_testcase.py: Removed unused import.
1156         * Scripts/webkitpy/port/ios_device_unittest.py: Added.
1157         (iosDeviceTest): Contains tests for the IOSDevicePort.
1158         (iosDeviceTest.make_port): Creates an IOSDevicePort with arguments.
1159         (iosDeviceTest.test_operating_system): Check for the correct operating system.
1160         * Scripts/webkitpy/port/ios_simulator_unittest.py: Moved from Tools/Scripts/webkitpy/port/ios_unittest.py.
1161         (iosSimulatorTest): Inherit from ios_testcase.
1162         (iosSimulatorTest.make_port): Ditto.
1163         (iosSimulatorTest.test_get_crash_log): Ditto.
1164         * Scripts/webkitpy/port/ios_testcase.py: Added.
1165         (iOSTest): Contains shared tests for the IOSDevicePort and IOSSimulatorPort.
1166         (iOSTest.test_driver_name): Tests for iOS app driver.
1167         (iOSTest.test_baseline_searchpath): Check that ios and ios-wk1 are in the baseline search path.
1168         * Scripts/webkitpy/port/ios_unittest.py: Moved to ios_simulator_unittest.py.
1169         * Scripts/webkitpy/port/port_testcase.py:
1170         (PortTestCase): Rename is_simulator to disable_setup to more accurately describe it's meaning.
1171         (PortTestCase.test_diff_image): Use disable_setup instead of is_simulator.
1172         (PortTestCase.test_diff_image_crashed): Ditto.
1173
1174 2017-03-28  Jason Marcell  <jmarcell@apple.com>
1175
1176         Fix `index-expected.txt` for dashboard test results.
1177         https://bugs.webkit.org/show_bug.cgi?id=170214
1178
1179         Reviewed by Alexey Proskuryakov.
1180
1181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt:
1182
1183 2017-03-28  Alexey Proskuryakov  <ap@apple.com>
1184
1185         Bot watcher's dashboard has separate settings for "mac" and "macos"
1186         https://bugs.webkit.org/show_bug.cgi?id=170164
1187
1188         Reviewed by Tim Horton.
1189
1190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1191         (Settings.prototype.parsePlatformFamily): Aded a special case for "macos".
1192
1193 2017-03-28  Alexey Proskuryakov  <ap@apple.com>
1194
1195         Fix dashboard test results on the dashboard
1196         https://bugs.webkit.org/show_bug.cgi?id=170158
1197
1198         Reviewed by Tim Horton.
1199
1200         Link to result diff instead of stdio. Looking at the diff, I wonder if it can be
1201         further improved, as it's not super readable, but stdio is entirely useless in this context.
1202
1203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1204         (Buildbot.prototype.dashboardTestResultsURLForIteration): Generate formatted diff link.
1205
1206         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1207         Fixed a typo in step name, so that it's actually treated as productive.
1208
1209         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1210         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
1211         (BuildbotTesterQueueView.prototype.update):
1212         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
1213         Added special handling for dashboard test results.
1214
1215 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
1216
1217         Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
1218         https://bugs.webkit.org/show_bug.cgi?id=170193
1219
1220         Reviewed by Alexey Proskuryakov.
1221
1222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1223         Fixed the order of arguments.
1224
1225 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
1226
1227         Dashboard tests fails to fetch the revision from commits
1228         https://bugs.webkit.org/show_bug.cgi?id=170191
1229
1230         Reviewed by Alexey Proskuryakov.
1231
1232         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1233         Added recordedCommitIndicesByRevisionNumber.
1234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1235         (setup): Populated trac.recordedCommitIndicesByRevisionNumber since the dashboard code uses this variable.
1236
1237 2017-03-28  Timothy Horton  <timothy_horton@apple.com>
1238
1239         Safari crashes when attempting to close tab that is displaying PDF
1240         https://bugs.webkit.org/show_bug.cgi?id=170201
1241         <rdar://problem/31242019>
1242
1243         Reviewed by Wenson Hsieh.
1244
1245         * TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
1246         (TEST):
1247         Add a test for doAfterNextStablePresentationUpdate just like the existing
1248         non-stable one.
1249
1250 2017-03-28  Jonathan Bedard  <jbedard@apple.com>
1251
1252         webkitpy: Use host pattern for devices
1253         https://bugs.webkit.org/show_bug.cgi?id=170121
1254
1255         Reviewed by Daniel Bates.
1256
1257         Devices should be treated like hosts throughout webkitpy
1258         so that more code can be re-used.  Add the needed properties
1259         and use executive over custom implemented polling/killing
1260         functions.
1261
1262         * Scripts/webkitpy/port/device.py:
1263         (Device):
1264         (Device.executive): Add optional executive property.
1265         (Device.filesystem): Add optional filesystem property.
1266         (Device.user): Add optional user property.
1267         (Device.platform): Add optional platform property.
1268         (Device.workspace): Add optional workspace property.
1269         (Device.poll): Deleted.
1270         * Scripts/webkitpy/port/simulator_process.py:
1271         (SimulatorProcess.Popen.poll): Use the devices executive.
1272         (SimulatorProcess.stop): Ditto.
1273         (SimulatorProcess._kill): Ditto.
1274         * Scripts/webkitpy/xcode/simulated_device.py:
1275         (SimulatedDevice.__init__): Add executive, filesystem, user, platform
1276         and workspace to the platform device.
1277         (SimulatedDevice.poll): Deleted.
1278
1279 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
1280
1281         Dashboard test fails with error: latestIterationGetter is not a function
1282         https://bugs.webkit.org/show_bug.cgi?id=170167
1283
1284         Reviewed by Alexey Proskuryakov.
1285
1286         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1287         (this.view._latestProductiveIteration): Configure _latestProductiveIteration in setup.
1288
1289 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1290
1291         Another test v8.
1292
1293 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1294
1295         Another test v7.
1296
1297 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1298
1299         Another test v6.
1300
1301 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1302
1303         Another test v5.
1304
1305 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1306
1307         Another test v4.
1308
1309 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1310
1311         Another test v3.
1312
1313 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1314
1315         Another test v2.
1316
1317 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1318
1319         Another test.
1320
1321 2017-03-27  Lucas Forschler  <lforschler@apple.com>
1322
1323         <rdar://problem/30949128>
1324         Update build.webkit.org to use port 16000 for PBChangeSource.
1325         
1326         Reviewed by Alexey Proskuryakov.
1327
1328         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1329
1330 2017-03-27  Jason Marcell  <jmarcell@apple.com>
1331
1332         Bots should run the dashboard tests
1333         https://bugs.webkit.org/show_bug.cgi?id=168994
1334
1335         Reviewed by Daniel Bates and David Kilzer.
1336
1337         We pull the `--results-directory` argument value out so that `RunDashboardTests` can override it so that we can separately run the dashboard layout tests.
1338
1339         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1340         (RunWebKitTests): Define a class variable called resultDirectory for the `--results-directory` argument so that subclasses can override this if needed.
1341         (RunWebKitTests.start): Set the `--results-directory` argument value to the value of self.resultDirectory.
1342         (RunDashboardTests): Subclass of RunWebKitTests in which we run the layout tests for the Bot Watcher's Dashboard.
1343         (RunDashboardTests.start): Override the `--layout-tests-directory` to point to the dashboard layout tests.
1344         (ExtractTestResults.addCustomURLs): Update the current results URL label to indicate that it links to layout tests results and add a new link to link to dashboard layout test results.
1345         (TestFactory.__init__): Update unit tests to account for new RunDashboardTests step.
1346         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1347         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1348
1349 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
1350
1351         webkitpy: Look for 'ios' test expectations for IOSPorts
1352         https://bugs.webkit.org/show_bug.cgi?id=169413
1353
1354         Reviewed by Alexey Proskuryakov.
1355
1356         Test expectations for iOS tests should include the 'ios' folder.  Modify
1357         default_baseline_search_path to include 'ios' folder and derivatives for
1358         IOSPort.
1359
1360         * Scripts/webkitpy/port/ios.py:
1361         (IOSPort._generate_all_test_configurations): Moved from IOSSimulatorPort.
1362         (IOSPort.default_baseline_search_path): Add ios expectations along with port specific expectations.
1363         (IOSPort.test_expectations_file_position): Added for testing.
1364         * Scripts/webkitpy/port/ios_simulator.py:
1365         (IOSSimulatorPort._generate_all_test_configurations): Moved to IOSPort.
1366         (IOSSimulatorPort.default_baseline_search_path): Moved to IOSPort.
1367
1368 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
1369
1370         REGRESSION: Reseting _device_map on each child process
1371         <rdar://problem/31274476>
1372
1373         Unreviewed infrastructure fix.
1374
1375         * Scripts/webkitpy/port/ios_simulator.py:
1376         (IOSSimulatorPort): Add _DEVICE_MAP class variable.
1377         (IOSSimulatorPort.__init__): Use shared class variable
1378         (IOSSimulatorPort._device_for_worker_number_map): Use _DEVICE_MAP class variable
1379         (IOSSimulatorPort._create_devices): Ditto.
1380         (IOSSimulatorPort._quit_ios_simulator): Ditto.
1381         (IOSSimulatorPort.clean_up_test_run): Ditto.
1382
1383 2017-03-27  Jonathan Bedard  <jbedard@apple.com>
1384
1385         REGRESSION: Failing to iterate over Simulator.managed_devices map
1386         <rdar://problem/31274476>
1387
1388         Unreviewed infrastructure fix.
1389
1390         * Scripts/webkitpy/port/ios_simulator.py:
1391         (IOSSimulatorPort._create_devices): Iterate through managed_devices by worker number.
1392
1393 2017-03-27  Alex Christensen  <achristensen@webkit.org>
1394
1395         Make WebSockets work in network process
1396         https://bugs.webkit.org/show_bug.cgi?id=169930
1397
1398         Reviewed by Youenn Fablet.
1399
1400         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1401         Add terminateNetworkProcess for the new test
1402         http/tests/websocket/tests/hybi/network-process-crash-error.html
1403         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1404         (WTR::TestRunner::setAllowsAnySSLCertificate):
1405         (WTR::TestRunner::terminateNetworkProcess):
1406         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1407         * WebKitTestRunner/TestController.cpp:
1408         (WTR::TestController::setAllowsAnySSLCertificate):
1409         (WTR::TestController::terminateNetworkProcess):
1410         * WebKitTestRunner/TestController.h:
1411         * WebKitTestRunner/TestInvocation.cpp:
1412         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1413         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1414         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1415         (WTR::TestController::platformContext):
1416         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1417         (WTR::TestController::platformContext):
1418         (WTR::TestController::platformLibraryPathForTesting):
1419         Add some infrastructure for http/tests/websocket/tests/hybi/simple-wss.html
1420         which calls testRunner.setAllowsAnySSLCertificate.  It used to only be effective
1421         for the WebProcess, but SocketStreamHandleImpl::createStreams is now in the NetworkProcess,
1422         and we need its call to Settings::allowsAnySSLCertificate to be loosened for this test,
1423         which tests that wss works, but our test certificate has an invalid certificate chain.
1424         We want production software to not have the ability to have its security weakened, so this
1425         is a test code path that is only implemented in WebKitTestRunner.
1426
1427 2017-03-25  Jonathan Bedard  <jbedard@apple.com>
1428
1429         webkitpy: Use generalized device instead of platform specific one
1430         https://bugs.webkit.org/show_bug.cgi?id=170078
1431
1432         Reviewed by Daniel Bates.
1433
1434         SimulatedDevice is re-created each time 'xcrun simctl list' is called.  Device
1435         should remain persistent.  Changing Device to a more explicit interface.
1436         SimulatedDevice no longer inherits from Device and IOSSimulator returns Devices
1437         wrapping SimulatedDevices.
1438
1439         * Scripts/webkitpy/port/device.py: Added.
1440         (Device):
1441         (Device.__init__): Construct with platform device.
1442         (Device.install_app): Install app at app path on platform device.
1443         (Device.launch_app): Launch app with bundle ID on platform device.
1444         (Device.poll): Poll platform device.
1445         (Device.udid): Access platform device UDID.
1446         (Device.__nonzero__): Check if instantiated with a valid platform device.
1447         (Device.__eq__): Compare by udid.
1448         (Device.__ne__): Ditto.
1449         (Device.__repr__): Print out platform_device representation.
1450         * Scripts/webkitpy/port/ios_simulator.py:
1451         (IOSSimulatorPort.__init__): Initialize the _device_map to an empty dictionary.
1452         (IOSSimulatorPort._device_for_worker_number_map):  Return self._device_map.
1453         (IOSSimulatorPort._create_simulators): Call Simulator.managed_devices directly.
1454         (IOSSimulatorPort._create_devices): Place Simulator.managed_devices into the
1455         device map.
1456         (IOSSimulatorPort._quit_ios_simulator): Reset self._device_map.
1457         * Scripts/webkitpy/xcode/device.py: Removed.
1458         * Scripts/webkitpy/xcode/simulated_device.py:
1459         (SimulatedDevice):
1460         (SimulatedDevice.__init__): Move host, name and did to SimulatedDevice.
1461         (SimulatedDevice.__eq__): Compare two simulated devices.
1462         (SimulatedDevice.__ne__): Ditto.
1463         (SimulatedDevice.__repr__): Print name and udid.
1464
1465 2017-03-25  Adrian Perez de Castro  <aperez@igalia.com>
1466
1467         [GTK] No value returned from PrintCustomWidgetTest::createWebKitPrintOperation() in TestPrinting.cpp
1468         https://bugs.webkit.org/show_bug.cgi?id=170059
1469
1470         Reviewed by Carlos Garcia Campos.
1471
1472         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Use "void" as return type in the declaration,
1473         the only use of the method in this same file ignores the returned value anyway.
1474
1475 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1476
1477         webkitpy should be able to run API tests
1478         https://bugs.webkit.org/show_bug.cgi?id=170028
1479
1480         Reviewed by Alexey Proskuryakov.
1481
1482         * Scripts/webkitpy/common/config/ports.py:
1483         (DeprecatedPort.run_api_tests_command): Added.
1484         * Scripts/webkitpy/port/base.py:
1485         (Port.api_results_directory): Added.
1486         * Scripts/webkitpy/tool/steps/runtests.py:
1487         (RunTests.run): Check if we should be running API tests.
1488         (RunTests._run_api_tests): Generate script to run API tests with json output.
1489         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
1490
1491 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1492
1493         Add JSON results for API tests
1494         https://bugs.webkit.org/show_bug.cgi?id=170021
1495
1496         Reviewed by Alexey Proskuryakov.
1497
1498         * Scripts/run-api-tests:
1499         (runTestsBySuite): Appends failures and timeouts to JSON data.
1500         (writeJsonDataIfApplicable): Writes JSON data to a file.
1501
1502 2017-03-24  Lucas Forschler  <lforschler@apple.com>
1503
1504         update committer_auth.py to be python 2.7 compliant
1505         https://bugs.webkit.org/show_bug.cgi?id=170063
1506         
1507         Reviewed by Alexey Proskuryakov.
1508
1509         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
1510         (CommitterAuth.authenticate):
1511             convert e.message to e.args[0]
1512
1513 2017-03-24  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1514
1515         webkitpy: Parse JSON results from run-api-tests
1516         https://bugs.webkit.org/show_bug.cgi?id=170062
1517
1518         Reviewed by Alexey Proskuryakov.
1519
1520         * Scripts/webkitpy/common/net/apitestresults.py: Added.
1521         (APITestResults): Structure to represent API test results.
1522         (APITestResults.__init__):
1523         (APITestResults.intersection): Return the failures common to both sets of results.
1524         (APITestResults.results_from_string): Create an APITestResults object from a JSON results string.
1525         (APITestResults.equals): Return True if both results were the same.
1526         (APITestResults.is_subset): Return True if failing tests are a subset of the other failing tests.
1527         (APITestResults.all_passed): Return True if everything passed.
1528         (APITestResults.failing_tests): List of tests that didn't pass.
1529         (APITestResults.did_exceed_test_failure_limit): Always False.
1530         * Scripts/webkitpy/common/net/apitestresults_unittest.py: Added.
1531         (APITestResultsTest): Unit tests.
1532         * Scripts/webkitpy/tool/bot/apitestresultsreader.py: Added.
1533         (APITestResultsReader): Read contents of JSON results file.
1534
1535 2017-03-24  Alex Christensen  <achristensen@webkit.org>
1536
1537         REGRESSION: Content Blocker: Blocking "a[href*=randomString]" doesn't work
1538         https://bugs.webkit.org/show_bug.cgi?id=169167
1539
1540         Reviewed by Simon Fraser.
1541
1542         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1543         (TestWebKitAPI::TEST_F):
1544         Test an example of a selector that was incorrectly determined to be invalid.
1545
1546 2017-03-24  Jonathan Bedard  <jbedard@apple.com>
1547
1548         Increase timeout for booting simulators.
1549         <rdar://problem/31080009>
1550
1551         Unreviewed infrastructure fix.
1552
1553         * Scripts/webkitpy/xcode/simulator.py:
1554         (Simulator.wait_until_device_is_booted): Increase timeout.
1555         (Simulator.wait_until_device_is_in_state): Increase timeout.
1556
1557 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1558
1559         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r214277.
1560
1561         Since r214277 beforeunload events are not fired unless there's some user interaction, so we need to simulate it
1562         in our unit tests to work.
1563
1564         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1565         (testWebViewJavaScriptDialogs):
1566
1567 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1568
1569         [GTK] Add MIMETypeRegistry implementation using xdgmime and remove the GTK+ one
1570         https://bugs.webkit.org/show_bug.cgi?id=170001
1571
1572         Reviewed by Michael Catanzaro.
1573
1574         Ignore style of xdgmime sources.
1575
1576         * Scripts/webkitpy/tool/steps/checkstyle.py:
1577
1578 2017-03-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1579
1580         Dragging on a large image should not revert to a file icon if data interaction is enabled
1581         https://bugs.webkit.org/show_bug.cgi?id=170018
1582         <rdar://problem/31184508>
1583
1584         Reviewed by Tim Horton.
1585
1586         Add new tests for data interaction. LargeImageToTargetDiv verifies the change made in this patch, while
1587         AttachmentElementItemProviders was a test that was previously removed due to <rdar://problem/31038797>.
1588
1589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1590         * TestWebKitAPI/Tests/WebKit2Cocoa/large-red-square.png: Added.
1591         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1592         (TestWebKitAPI::TEST):
1593
1594 2017-03-23  Fujii Hironori  <Hironori.Fujii@sony.com>
1595
1596         Update WinCairoRequirements.zip
1597         https://bugs.webkit.org/show_bug.cgi?id=169950
1598
1599         Reviewed by Alex Christensen.
1600
1601         * Scripts/update-webkit-wincairo-libs: Replace $winCairoLibsURL.
1602
1603 == Rolled over to ChangeLog-2017-03-23 ==