Tools/ChangeLog

   1 2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>
   2
   3         Reviewed by Martin Robinson.
   4
   5         [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
   6         https://bugs.webkit.org/show_bug.cgi?id=58297
   7
   8         Do not disable flash specifically when built with GTK+ 3 -
   9         PluginPackage should do the right thing while loading plugins.
  10
  11         * GtkLauncher/main.c:
  12         (main):
  13
  14 2011-04-12  Kent Tamura  <tkent@chromium.org>
  15
  16         Reviewed by Dimitri Glazkov.
  17
  18         [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
  19         https://bugs.webkit.org/show_bug.cgi?id=57426
  20
  21         * DumpRenderTree/chromium/WebPreferences.cpp:
  22         (WebPreferences::applyTo): Disable the validation message timer.
  23
  24 2011-04-12  James Kozianski  <koz@chromium.org>
  25
  26         Unreviewed.
  27
  28         Adding myself to committers.py.
  29
  30         * Scripts/webkitpy/common/config/committers.py:
  31
  32 2011-04-12  Brent Fulgham  <bfulgham@webkit.org>
  33
  34         Unreviewed build correction for WinCairo bot after r83639.
  35         https://bugs.webkit.org/show_bug.cgi?id=51790
  36
  37         Correct typo for the new "update-webkit-wincairo-libs" script.
  38
  39         * Scripts/build-webkit: Incorrectly calling the
  40           update-webkit-cairo-libs which does not exist.
  41
  42 2011-04-12  Alice Liu  <alice.liu@apple.com>
  43
  44         Reviewed by Jon Honeycutt.
  45
  46         A change that should have been part of http://trac.webkit.org/changeset/83628
  47
  48         * DumpRenderTree/win/DumpRenderTree.cpp:
  49         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
  50
  51 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
  52
  53         Reviewed by Tony Chang.
  54
  55         new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
  56         https://bugs.webkit.org/show_bug.cgi?id=58272
  57
  58         NRWT was interpreting the --results-directory cmd line arg as
  59         relative to the build directory, not the current working
  60         directory (ORWT uses the latter, which is much more intuitive).
  61
  62         This patch fixes the base case, but includes an override for
  63         Chromium that is needed until the bots can be updated.
  64
  65         * Scripts/webkitpy/layout_tests/port/base.py:
  66         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  67         * Scripts/webkitpy/layout_tests/port/chromium.py:
  68         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  69         * Scripts/webkitpy/layout_tests/port/test.py:
  70         * Scripts/webkitpy/layout_tests/port/webkit.py:
  71         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  72         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  73
  74 2011-04-12  Philippe Normand  <pnormand@igalia.com>
  75
  76         Unreviewed, roll out r83621 as it broke the GTK build.
  77
  78         [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
  79         https://bugs.webkit.org/show_bug.cgi?id=58333
  80
  81         * Scripts/build-jsc:
  82         * Scripts/build-webkit:
  83
  84 2011-04-12  Carl Lobo  <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
  85
  86         Reviewed by Adam Roben.
  87
  88         Patch to download the WinCairo dependancies as part of build-webkit.
  89         https://bugs.webkit.org/show_bug.cgi?id=51790
  90
  91         This patch downloads the dependancies from
  92             http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip
  93         checking the modification timestamp etc.
  94
  95         * Tools/Scripts/build-webkit
  96         * Tools/Scripts/update-webkit: Modified to understand the --wincairo
  97           flag, and to update WinCairo dependencies when used.
  98         * Tools/Scripts/update-webkit-cairo-libs: added
  99         * Tools/Scripts/update-webkit-dependency: added
 100         * Tools/Scripts/update-webkit-auxiliary-libs
 101
 102 2011-04-12  Jeff Miller  <jeffm@apple.com>
 103
 104         Reviewed by Adam Roben.
 105
 106         WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
 107         https://bugs.webkit.org/show_bug.cgi?id=56020
 108
 109         Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
 110         since WebKit will do this for us.  If we didn't do this, TranslateMessage() would be called twice,
 111         which would generate two characters for every keypress (for example).  I didn't bother doing this for
 112         WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
 113
 114         Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
 115
 116         * MiniBrowser/win/main.cpp:
 117         (shouldTranslateMessage): Added.
 118         (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
 119         * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
 120         * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
 121         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
 122         (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
 123         (TestWebKitAPI::runAndWatchForWMChar): Added.
 124         (TestWebKitAPI::TEST): Added.
 125         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
 126         (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
 127         (TestWebKitAPI::Util::shouldTranslateMessage): Added.
 128         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
 129         (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
 130         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
 131
 132 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
 133
 134         Reviewed by Tony Chang.
 135
 136         new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
 137         https://bugs.webkit.org/show_bug.cgi?id=58290
 138
 139         This is some preliminary refactoring for bug 58272.
 140
 141         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
 142         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
 143         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 144         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
 145         * Scripts/webkitpy/layout_tests/port/test.py:
 146         * Scripts/webkitpy/layout_tests/port/chromium.py:
 147         * Scripts/webkitpy/layout_tests/port/base.py:
 148         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 149
 150 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
 151
 152         Reviewed by Eric Seidel.
 153
 154         webkitpy: fix mock_filesystem abspath to handle relative paths
 155         and add filesystem.chdir() and filesystem.getcwd() to be able
 156         to test this and mock it out.
 157
 158         https://bugs.webkit.org/show_bug.cgi?id=58288
 159
 160         * Scripts/webkitpy/common/system/filesystem.py:
 161         * Scripts/webkitpy/common/system/filesystem_mock.py:
 162         * Scripts/webkitpy/common/system/filesystem_unittest.py:
 163
 164 2011-04-12  Alice Liu  <alice.liu@apple.com>
 165
 166         Reviewed by Sam Weinig.
 167
 168         https://bugs.webkit.org/show_bug.cgi?id=58292
 169         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
 170
 171         * DumpRenderTree/mac/DumpRenderTree.mm:
 172         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
 173
 174 2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
 175
 176         Reviewed by Eric Seidel.
 177
 178         [Qt] Enable JIT build for SH4 platforms.
 179         https://bugs.webkit.org/show_bug.cgi?id=58317
 180
 181
 182         * DumpRenderTree/qt/DumpRenderTree.pro:
 183         * QtTestBrowser/QtTestBrowser.pro:
 184         * Scripts/webkitdirs.pm:
 185
 186 2011-04-12  Tony Chang  <tony@chromium.org>
 187
 188         Reviewed by Andreas Kling.
 189
 190         [Qt] embed checksums in PNGs written by Qt-DRT
 191         https://bugs.webkit.org/show_bug.cgi?id=58173
 192
 193         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 194         (WebCore::DumpRenderTree::dump):
 195
 196 2011-04-12  Eric Seidel  <eric@webkit.org>
 197
 198         Reviewed by Adam Barth.
 199
 200         commit-queue should upload failure diffs when tests fail
 201         https://bugs.webkit.org/show_bug.cgi?id=58348
 202
 203         This change was mostly just plumbing.  We were already saving
 204         this information for flaky test reporting.  I just made it possible
 205         for normal failures to report archives as well.
 206
 207         I did a little abstraction work to try and share some code between
 208         flakytestreporter.py and this new code.  There is still more we could do.
 209
 210         In making this change I also went through and updated the various
 211         places we have urls hard-coded in our python and pointed them at
 212         common.config.urls.
 213
 214         * Scripts/webkitpy/common/checkout/scm.py:
 215         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 216         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
 217         * Scripts/webkitpy/common/net/statusserver.py:
 218         * Scripts/webkitpy/layout_tests/port/base.py:
 219         * Scripts/webkitpy/tool/bot/botinfo.py: Added.
 220         * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
 221         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 222         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
 223         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
 224         * Scripts/webkitpy/tool/commands/queues.py:
 225
 226 2011-04-12  Daniel Bates  <dbates@rim.com>
 227
 228         Rubber-stamped by Eric Seidel.
 229
 230         svn-apply and/or patch(1) has trouble applying patches that makes changes to files
 231         with Windows line endings
 232         https://bugs.webkit.org/show_bug.cgi?id=53625
 233
 234         Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
 235         applied to an SCM checkout on a Windows file system and vice-versa.
 236
 237         This issue manifests itself due to custom SCM settings as well as differences in
 238         gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
 239         into svn-apply/unapply to compensate for differences in line endings by converting
 240         the line endings in a patch to match the line endings in the target file (if it exists).
 241
 242         * Scripts/VCSUtils.pm:
 243           - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
 244             content read from the specified file handle. Obviously, this heuristic will not work
 245             for files with mixed line endings, but I don't envision such files to be the norm. If
 246             this turns out to be an issue then we can improve the heuristic.
 247           - Added firstEOLInFile().
 248           - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
 249             In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
 250             endings in the diff instead of the line endings in the target file.
 251           - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
 252             re-used in parseDiff().
 253         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
 254           to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
 255           mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
 256         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
 257         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
 258
 259 2011-04-12  Sam Weinig  <sam@webkit.org>
 260
 261         Reviewed by Adam Roben.
 262
 263         REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
 264         https://bugs.webkit.org/show_bug.cgi?id=58336
 265
 266         * WebKitTestRunner/TestController.cpp:
 267         (WTR::TestController::resetStateToConsistentValues):
 268         Remove cache clearing as that is causing tests to crash on Windows 7.
 269
 270 2011-04-11  Sam Weinig  <sam@webkit.org>
 271
 272         Reviewed by Anders Carlsson.
 273
 274         REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
 275         <rdar://problem/8981346>
 276         https://bugs.webkit.org/show_bug.cgi?id=54159
 277
 278         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 279         (WTR::InjectedBundlePage::InjectedBundlePage):
 280         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
 281         (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
 282         (WTR::InjectedBundlePage::decidePolicyForResponse):
 283         (WTR::InjectedBundlePage::unableToImplementPolicy):
 284         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 285         Add short-circuited policy client which matches WebKit1.
 286
 287         * WebKitTestRunner/TestController.cpp:
 288         (WTR::TestController::resetStateToConsistentValues):
 289         Clear the cache between tests to ensure consistent results.
 290
 291 2011-04-11  George Guo  <George.Guo@nokia.com>
 292
 293         Reviewed by Eric Seidel.
 294
 295         prepare-ChangeLog support email input but -h did not show the option
 296         https://bugs.webkit.org/show_bug.cgi?id=58164
 297
 298         Add email option to -h to improve the usability
 299
 300         * Scripts/prepare-ChangeLog:
 301
 302 2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
 303
 304         Reviewed by Eric Carlson.
 305
 306         Rename MediaControls to MediaControlRootElement.
 307         https://bugs.webkit.org/show_bug.cgi?id=58250
 308
 309         * Scripts/do-webcore-rename: Documented the renaming.
 310
 311 2011-04-11  Sam Weinig  <sam@webkit.org>
 312
 313         Fix Windows build.
 314
 315         * MiniBrowser/win/BrowserView.cpp:
 316         (BrowserView::create):
 317
 318 2011-04-11  Sam Weinig  <sam@webkit.org>
 319
 320         Reviewed by Anders Carlsson.
 321
 322         Move focus management out of WebKit via  the UIClient
 323         <rdar://problem/8784068>
 324         https://bugs.webkit.org/show_bug.cgi?id=58278
 325
 326         * MiniBrowser/mac/BrowserWindowController.m:
 327         (-[BrowserWindowController awakeFromNib]):
 328         * WebKitTestRunner/TestController.cpp:
 329         (WTR::TestController::createOtherPage):
 330         (WTR::TestController::initialize):
 331         Add stubs for new UIClient functions.
 332
 333 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
 334
 335         Reviewed by Eric Seidel.
 336
 337         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
 338         https://bugs.webkit.org/show_bug.cgi?id=53605
 339
 340         Add an implementation of the PlainTextController for the GTK+ DRT.
 341
 342         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 343         (addControllerToWindow): Added this helper method.
 344         (webViewWindowObjectCleared): Use the new helper to add EventSender
 345         and the PlainTextController to the window object.
 346         * GNUmakefile.am: Added PlainTextController source files.
 347         * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
 348         on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
 349         until that functionality exists somewhere in the WebKitGTK+ stack.
 350         * DumpRenderTree/gtk/PlainTextController.h: Added.
 351
 352 2011-04-11  Yael Aharon  <yael.aharon@nokia.com>
 353
 354         Unreviewed.
 355
 356         Adding my IRC nick.
 357
 358         * Scripts/webkitpy/common/config/committers.py:
 359
 360 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
 361
 362         Reviewed by Adam Roben.
 363
 364         new-run-webkit-tests: fix crash when running under windows cmd.exe
 365         https://bugs.webkit.org/show_bug.cgi?id=58197
 366
 367         We would intermittently crash when running NRWT directly under
 368         cmd.exe on windows because we were sharing the stdin file
 369         descriptor between the python process and the http server.
 370         cmd.exe really didn't like that, and there was no reason to
 371         share the descriptor, so we now use a PIPE instead.
 372
 373         * Scripts/webkitpy/layout_tests/port/http_server.py:
 374
 375 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
 376
 377         Reviewed by Ojan Vafai.
 378
 379         new-run-webkit-tests: add unit tests for Port.diff_image()
 380         https://bugs.webkit.org/show_bug.cgi?id=58196
 381
 382         Add the unit tests for the fix in bug 58195.
 383
 384         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 385         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 386         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
 387
 388 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
 389
 390         Reviewed by Tony Chang.
 391
 392         new-run-webkit-tests: implement support for audio, take two
 393         https://bugs.webkit.org/show_bug.cgi?id=58195
 394
 395         Attempt to re-land the fix for bug 58101 (which was initially
 396         landed in r83330, but rolled out). This is the same patch but
 397         fixes crashes in Port.diff_image() caused by the change for
 398         empty image files being None instead of ''.
 399
 400         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
 401         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
 402         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 403         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
 404         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
 405         * Scripts/webkitpy/layout_tests/port/base.py:
 406         * Scripts/webkitpy/layout_tests/port/chromium.py:
 407         * Scripts/webkitpy/layout_tests/port/dryrun.py:
 408         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
 409         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
 410         * Scripts/webkitpy/layout_tests/port/test.py:
 411         * Scripts/webkitpy/layout_tests/port/webkit.py:
 412
 413 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
 414
 415         Reviewed by Xan Lopez.
 416
 417         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
 418         https://bugs.webkit.org/show_bug.cgi?id=57854
 419
 420         Implement missing features in GTK's DRT.
 421
 422         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 423         (indexRangeInTable): New helper function to get the range string
 424         for the current cell inside the parent table, either from the
 425         point of view of rows or columns.
 426         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
 427         the new helper function indexRangeInTable().
 428         (AccessibilityUIElement::columnIndexRange): Ditto.
 429
 430 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
 431
 432         Reviewed by Chris Fleizach.
 433
 434         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
 435         https://bugs.webkit.org/show_bug.cgi?id=57826
 436
 437         Implement missing feature in GTK's DRT.
 438
 439         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 440         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
 441         relying on the analogous function from the AtkTable interface.
 442
 443 2011-04-05  Timothy Hatcher  <timothy@apple.com>
 444
 445         Fix the extract-localizable-strings script errors that started after
 446         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
 447
 448         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
 449
 450 2011-04-11  Tony Chang  <tony@chromium.org>
 451
 452         Reviewed by Eric Seidel.
 453
 454         fix crc computation on 64 bit machines
 455         https://bugs.webkit.org/show_bug.cgi?id=58243
 456
 457         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
 458
 459         * DumpRenderTree/CyclicRedundancyCheck.cpp:
 460         (makeCrcTable):
 461         (computeCrc):
 462         * DumpRenderTree/CyclicRedundancyCheck.h:
 463         * DumpRenderTree/PixelDumpSupport.cpp:
 464         (appendIntToVector):
 465         (convertChecksumToPNGComment):
 466
 467 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
 468
 469         Reviewed by Eric Seidel.
 470
 471         Require no undefined symbols during compilation.
 472
 473         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
 474         https://bugs.webkit.org/show_bug.cgi?id=54896
 475
 476         Add -Wl,--no-undefined to catch missing symbols early.
 477
 478         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 479         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 480
 481 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
 482
 483         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
 484
 485         * wx/build/settings.py:
 486
 487 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
 488
 489         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
 490
 491         * wx/build/settings.py:
 492
 493 2011-04-10  David Levin  <levin@chromium.org>
 494
 495         Reviewed by Dimitri Glazkov.
 496
 497         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
 498         https://bugs.webkit.org/show_bug.cgi?id=58201
 499
 500         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
 501         and filed bug 58202.
 502
 503 2011-04-09  David Levin  <levin@chromium.org>
 504
 505         Unreviewed, rolling out r83394.
 506         http://trac.webkit.org/changeset/83394
 507         https://bugs.webkit.org/show_bug.cgi?id=53625
 508
 509         Patch was incorrect as noted in the bug.
 510
 511         * Scripts/svn-apply:
 512
 513 2011-04-09  David Levin  <levin@chromium.org>
 514
 515         Reviewed by Adam Barth.
 516
 517         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
 518         https://bugs.webkit.org/show_bug.cgi?id=53625
 519
 520         * Scripts/svn-apply: Ensure that the portions of patches
 521         which are for vcproj/vsprops files has DOS line endings.
 522
 523 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
 524
 525         Reviewed by Tony Chang.
 526
 527         It looks like NRWT has not been stopping DRT/TestShell
 528         instances properly on windows, probably for a long time.
 529         This would go a long way to explaining why we often have
 530         processes lying around :)
 531
 532         https://bugs.webkit.org/show_bug.cgi?id=57807
 533
 534         * Scripts/webkitpy/layout_tests/port/chromium.py:
 535         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 536
 537 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
 538
 539         Reviewed by Laszlo Gombos.
 540
 541         [Qt] Don't link against fontconfig or X11 if embedded
 542         https://bugs.webkit.org/show_bug.cgi?id=58104
 543
 544         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
 545         * QtTestBrowser/QtTestBrowser.pro: ditto
 546         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
 547         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
 548
 549 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
 550
 551         http/tests/loading/preload-append-scan.php is failing on Windows
 552         https://bugs.webkit.org/show_bug.cgi?id=58178
 553
 554         Reviewed by Brian Weinstein.
 555
 556         * DumpRenderTree/win/DumpRenderTree.cpp:
 557         (lastPathComponent):
 558         Use CFURL API to find the last path component, rather than
 559         PathFindFileName(), because the latter will include the query string.
 560
 561 2011-04-08  Jian Li  <jianli@chromium.org>
 562
 563         Unreviewed, rolling out r83327, r83330 since these patches are very
 564         likely to break chromium webkit mac10.6 builders.
 565
 566         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
 567         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
 568         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 569         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
 570         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
 571         * Scripts/webkitpy/layout_tests/port/base.py:
 572         * Scripts/webkitpy/layout_tests/port/chromium.py:
 573         * Scripts/webkitpy/layout_tests/port/dryrun.py:
 574         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
 575         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
 576         * Scripts/webkitpy/layout_tests/port/test.py:
 577         * Scripts/webkitpy/layout_tests/port/webkit.py:
 578
 579 2011-04-08  Vincent Scheib  <scheib@chromium.org>
 580
 581         Reviewed by Eric Seidel.
 582
 583         add chromium-gpu-linux-x86_64 to the recognized list of ports
 584         https://bugs.webkit.org/show_bug.cgi?id=58099
 585
 586         Add chromium-gpu-linux-x86_64 to fix assert.
 587
 588         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 589
 590 2011-04-08  Alpha Lam  <hclam@chromium.org>
 591
 592         Unreviewed, rolling out r83335.
 593         http://trac.webkit.org/changeset/83335
 594         https://bugs.webkit.org/show_bug.cgi?id=53556
 595
 596         GTK and QT bots are broken
 597
 598         * Scripts/build-webkit:
 599
 600 2011-04-07  Anna Cavender  <annacc@chromium.org>
 601
 602         Reviewed by Eric Carlson.
 603
 604         Setup ENABLE(TRACK) feature define
 605         https://bugs.webkit.org/show_bug.cgi?id=53556
 606
 607         * Scripts/build-webkit:
 608
 609 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
 610
 611         Reviewed by Adam Roben.
 612
 613         new-run-webkit-tests: configure a NRWT test bot for Mac SL
 614         https://bugs.webkit.org/show_bug.cgi?id=58114
 615
 616         This change removes the old new-run-webkit-tests entry and
 617         updates it for a new test-only bot.
 618
 619         * BuildSlaveSupport/build.webkit.org-config/config.json:
 620
 621 2011-04-08  Dominic Cooney  <dominicc@google.com>
 622
 623         Reviewed by Adam Roben.
 624
 625         Make layoutTestController.shadowRoot return null, not undefined,
 626         when its argument is invalid.
 627         https://bugs.webkit.org/show_bug.cgi?id=58121
 628
 629         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 630         (LayoutTestController::shadowRoot):
 631         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 632         (WTR::LayoutTestController::shadowRoot):
 633
 634 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
 635
 636         Reviewed by Adam Roben.
 637
 638         Locate NSTD.EXE in 64-bit Windows
 639         https://bugs.webkit.org/show_bug.cgi?id=57847
 640
 641         * Scripts/old-run-webkit-tests:
 642
 643 2011-04-08  Adam Roben  <aroben@apple.com>
 644
 645         Qt build fix
 646
 647         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
 648
 649 2011-04-07  Adam Roben  <aroben@apple.com>
 650
 651         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
 652
 653         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
 654         plugin
 655
 656         Reviewed by Anders Carlsson.
 657
 658         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
 659         (pluginLogWithArguments): Moved code to format and log the message here...
 660         (pluginLog): ...from here.
 661
 662         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
 663
 664         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
 665         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
 666
 667         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
 668
 669         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
 670         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
 671         to begin.
 672         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
 673         constructor.
 674         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
 675         can be used to invoke our setWillBeDestroyed function.
 676         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
 677         anything unexpected happens).
 678         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
 679         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
 680         NPP_SetWindow was *not* called during destruction.
 681         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
 682         method, setWillBeDestroyed.
 683         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
 684         object.
 685
 686         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 687         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
 688         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 689         * GNUmakefile.am:
 690         Added new test.
 691
 692         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
 693         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
 694
 695 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
 696
 697         Reviewed by Martin Robinson.
 698
 699         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
 700         https://bugs.webkit.org/show_bug.cgi?id=58039
 701
 702         Implement missing functions in GTK's DRT.
 703
 704         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 705         (AccessibilityUIElement::increment): Implemented.
 706         (AccessibilityUIElement::decrement): Implemented.
 707
 708 2011-04-08  Dominic Cooney  <dominicc@google.com>
 709
 710         Reviewed by Kent Tamura.
 711
 712         Make WK2 layoutTestController.shadowRoot return undefined, not
 713         null, when its argument is not an element.
 714         https://bugs.webkit.org/show_bug.cgi?id=58121
 715
 716         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 717         (WTR::LayoutTestController::shadowRoot):
 718
 719 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
 720
 721         Reviewed by Mihai Parparita.
 722
 723         Change reference port for Mac GPU baselines from
 724         Leopard to SnowLeopard, XP to Win7, and Linux-x86
 725         to Linux x86-64.
 726
 727         https://bugs.webkit.org/show_bug.cgi?id=58099
 728
 729         * Scripts/webkitpy/layout_tests/port/chromium.py:
 730
 731 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
 732
 733         Revert ENABLE_TRACK patch due to compile failures.
 734
 735         * Scripts/build-webkit:
 736
 737 2011-04-07  Tony Chang  <tony@chromium.org>
 738
 739         Reviewed by Eric Seidel.
 740
 741         update DRT to embed checksums in png files
 742         https://bugs.webkit.org/show_bug.cgi?id=57871
 743
 744         We insert the bytes for the comment in printPNG rather than at encode
 745         time because each platform does its own PNG encoding (either using CG
 746         or cairo).  Putting this in pringPNG avoids having to duplicate this
 747         code, although it's not as clean as doing it at encoding time.
 748
 749         We insert the comment right after the IHDR chunk of the PNG.
 750
 751         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 752         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
 753         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
 754         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
 755         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
 756         * DumpRenderTree/PixelDumpSupport.cpp:
 757         (dumpWebViewAsPixelsAndCompareWithExpected):
 758         (convertChecksumToPNGComment): Generate the bytes to insert.
 759         (printPNG): Insert the png comment before the first IDAT section.
 760         * DumpRenderTree/PixelDumpSupport.h:
 761         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
 762         (printPNG):
 763         (dumpBitmap):
 764         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 765         (printPNG):
 766         (dumpBitmap):
 767         * DumpRenderTree/win/DumpRenderTree.vcproj:
 768         * GNUmakefile.am:
 769
 770 2011-04-07  Jeff Miller  <jeffm@apple.com>
 771
 772         Reviewed by Adam Roben.
 773
 774         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
 775         https://bugs.webkit.org/show_bug.cgi?id=58058
 776
 777         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
 778         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
 779
 780 2011-04-07  Chang Shu  <cshu@webkit.org>
 781
 782         Reviewed by Darin Adler.
 783
 784         WebKitTestRunner needs layoutTestController.isPageBoxVisible
 785         https://bugs.webkit.org/show_bug.cgi?id=42695
 786
 787         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
 788         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 789         (WTR::LayoutTestController::isPageBoxVisible):
 790         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 791
 792 2011-04-07  Adam Roben  <aroben@apple.com>
 793
 794         Build fix
 795
 796         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
 797
 798 2011-04-07  Adam Roben  <aroben@apple.com>
 799
 800         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
 801
 802         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
 803         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
 804         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
 805         be overridden by subclasses to provide extra URLs before we call up to the base class (after
 806         which adding more URLs is no longer possible).
 807
 808         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
 809         bot results page
 810
 811         Reviewed by John Sullivan.
 812
 813         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 814         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
 815         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
 816         method is never called for MasterShellCommands.
 817         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
 818         with this method (which is).
 819
 820 2011-04-07  Adam Roben  <aroben@apple.com>
 821
 822         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
 823
 824         This matches how most of our other build steps work, so is good just for improving
 825         consistency between build steps. It should also make it possible for
 826         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
 827         trying to do this in finished() after we had called up to the base class, but that was
 828         apparently too late to add more URLs.)
 829
 830         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
 831         results page
 832
 833         Reviewed by John Sullivan.
 834
 835         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 836         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
 837         call setText to get the right text to show up for this step. This matches how most of our
 838         other build steps work.
 839         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
 840         This is how most of our other build steps work.
 841         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
 842         function, to match the base class.
 843
 844 2011-04-07  Adam Barth  <abarth@webkit.org>
 845
 846         Reviewed by Maciej Stachowiak.
 847
 848         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
 849         https://bugs.webkit.org/show_bug.cgi?id=58022
 850
 851         Previously, we were ignoring the args variable!  This patch fixes the
 852         regression introduced in http://trac.webkit.org/changeset/82771.
 853
 854         * Scripts/webkitpy/tool/commands/download_unittest.py:
 855         * Scripts/webkitpy/tool/mocktool.py:
 856         * Scripts/webkitpy/tool/steps/checkstyle.py:
 857
 858 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
 859
 860         Reviewed by Adam Barth.
 861
 862         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
 863         https://bugs.webkit.org/show_bug.cgi?id=58017
 864
 865         * Scripts/webkitpy/common/checkout/scm.py:
 866         * Scripts/webkitpy/common/checkout/scm_unittest.py:
 867
 868 2011-04-06  Chang Shu  <cshu@webkit.org>
 869
 870         Reviewed by Darin Adler.
 871
 872         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
 873         https://bugs.webkit.org/show_bug.cgi?id=57984
 874
 875         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
 876         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 877         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
 878         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 879
 880 2011-04-06  Chris Rogers  <crogers@google.com>
 881
 882         Reviewed by Tony Chang.
 883
 884         Add web audio support to DumpRenderTree (mac port)
 885         https://bugs.webkit.org/show_bug.cgi?id=57969
 886
 887         * DumpRenderTree/LayoutTestController.cpp:
 888         (LayoutTestController::LayoutTestController):
 889         (setEncodedAudioDataCallback):
 890         (LayoutTestController::staticFunctions):
 891         * DumpRenderTree/LayoutTestController.h:
 892         (LayoutTestController::dumpAsAudio):
 893         (LayoutTestController::setDumpAsAudio):
 894         (LayoutTestController::encodedAudioData):
 895         (LayoutTestController::setEncodedAudioData):
 896         * DumpRenderTree/mac/DumpRenderTree.mm:
 897         (dumpAudio):
 898         (dump):
 899
 900 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
 901
 902         Reviewed by Kenneth Rohde Christiansen.
 903
 904         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
 905         https://bugs.webkit.org/show_bug.cgi?id=56086
 906
 907         Add the missing method.
 908
 909         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 910         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
 911         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 912         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 913         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
 914
 915 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
 916
 917         Reviewed by David Levin.
 918
 919         Add QUOTA build flag for unified quota API
 920         https://bugs.webkit.org/show_bug.cgi?id=57918
 921
 922         * Scripts/build-webkit: Added QUOTA build flag
 923
 924 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
 925
 926         Reviewed by Tony Chang.
 927
 928         Adjust the apple webkit port's default timeout to match
 929         old-run-webkit-tests at 35 seconds.
 930
 931         https://bugs.webkit.org/show_bug.cgi?id=37738
 932
 933         * Scripts/webkitpy/layout_tests/port/mac.py:
 934
 935 2011-04-06  Scott Cameron  <sccameron@rim.com>
 936
 937         Reviewed by Eric Seidel.
 938
 939         Remove global variable $httpdPath and replace with the return value of
 940         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
 941         https://bugs.webkit.org/show_bug.cgi?id=53499
 942
 943         * Scripts/run-iexploder-tests:
 944         * Scripts/webkitperl/httpd.pm:
 945
 946 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
 947
 948         Reviewed by Darin Adler.
 949
 950         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
 951
 952         https://bugs.webkit.org/show_bug.cgi?id=27551
 953
 954         * DumpRenderTree/config.h:
 955         * WebKitAPITest/config.h:
 956         * WebKitTestRunner/config.h:
 957
 958 2011-04-06  Tony Chang  <tony@chromium.org>
 959
 960         Reviewed by Darin Adler.
 961
 962         teach run-webkit-tests to read checksums from png files
 963         https://bugs.webkit.org/show_bug.cgi?id=57993
 964
 965         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
 966           no .checksum and look for the checksum in there.
 967
 968 2011-04-06  David Dorwin  <ddorwin@chromium.org>
 969
 970         Reviewed by David Levin.
 971
 972         Enable fullscreen layout tests for Chromium
 973         https://bugs.webkit.org/show_bug.cgi?id=55726
 974
 975         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
 976
 977         * DumpRenderTree/chromium/WebPreferences.cpp:
 978         (WebPreferences::applyTo):
 979
 980 2011-04-06  Adam Roben  <aroben@apple.com>
 981
 982         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
 983
 984         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
 985
 986         Reviewed by David Kilzer.
 987
 988         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 989         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
 990         build's results directory here...
 991         (ExtractTestResults.finished): ...from here.
 992         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
 993         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
 994         leaks" link to point to Leaks Viewer for this build.
 995         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
 996         but it seemed good to add for consistency with BuildAndTestFactory.
 997         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
 998         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
 999         that we'll get a "view leaks" link.
1000
1001 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
1002
1003         Reviewed by Eric Seidel.
1004
1005         [Gtk] plugins/set-status.html fails
1006         https://bugs.webkit.org/show_bug.cgi?id=57844
1007
1008         Allow an empty status text to be dumped.
1009
1010         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1011         (webViewStatusBarTextChanged):
1012
1013 2011-04-06  Chang Shu  <cshu@webkit.org>
1014
1015         Reviewed by Darin Adler.
1016
1017         WebKitTestRunner needs layoutTestController.pageNumberForElementById
1018         https://bugs.webkit.org/show_bug.cgi?id=42329
1019
1020         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1021         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1022         (WTR::LayoutTestController::pageNumberForElementById):
1023         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1024
1025 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
1026
1027         Reviewed by Martin Robinson.
1028
1029         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
1030         https://bugs.webkit.org/show_bug.cgi?id=57932
1031
1032         Some Layout tests have invalid URIs that do not generate valid
1033         SoupURI instances. Do not try to free those NULL SoupURIs.
1034
1035         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1036         (willSendRequestCallback):
1037
1038 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
1039
1040         Reviewed by Andreas Kling.
1041
1042         ORWT shouldn't generate diff files for tests without expected files
1043         https://bugs.webkit.org/show_bug.cgi?id=57846
1044
1045         * Scripts/old-run-webkit-tests:
1046
1047 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
1048
1049         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
1050         to deps.
1051
1052         * wx/install-unix-extras:
1053
1054 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1055
1056         Unreviewed, rolling out r82978, r82999, and r83001.
1057         http://trac.webkit.org/changeset/82978
1058         http://trac.webkit.org/changeset/82999
1059         http://trac.webkit.org/changeset/83001
1060         https://bugs.webkit.org/show_bug.cgi?id=57913
1061
1062         Does not work in Python 2.5 (Requested by abarth on #webkit).
1063
1064         * Scripts/webkitpy/common/system/executive.py:
1065         * Scripts/webkitpy/common/system/executive_unittest.py:
1066
1067 2011-04-05  Chang Shu  <cshu@webkit.org>
1068
1069         Reviewed by Darin Adler.
1070
1071         WebKitTestRunner needs layoutTestController.numberOfPages
1072         https://bugs.webkit.org/show_bug.cgi?id=42694
1073
1074         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1075         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1076         (WTR::LayoutTestController::numberOfPages):
1077         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1078
1079 2011-04-05  Tony Chang  <tony@chromium.org>
1080
1081         Reviewed by Mihai Parparita.
1082
1083         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
1084         https://bugs.webkit.org/show_bug.cgi?id=57889
1085
1086         * Scripts/webkitpy/layout_tests/port/chromium.py:
1087         * Scripts/webkitpy/layout_tests/port/test.py:
1088         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1089
1090 2011-04-05  Adam Barth  <abarth@webkit.org>
1091
1092         Silly with statement, from the future!
1093
1094         * Scripts/webkitpy/common/system/executive.py:
1095
1096 2011-04-05  Adam Barth  <abarth@webkit.org>
1097
1098         Reviewed by Tony Chang.
1099
1100         Don't use Exception.message because it's deprecated
1101         https://bugs.webkit.org/show_bug.cgi?id=57892
1102
1103         Suppress the warning for now.  When we move to Python 3, we might need
1104         to something more dramatic.
1105
1106         * Scripts/webkitpy/common/system/executive.py:
1107
1108 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
1109
1110         Reviewed by Ojan Vafai.
1111
1112         Add builders.js to dashboard file list
1113         https://bugs.webkit.org/show_bug.cgi?id=57899
1114
1115         Add file added by http://crrev.com/80538 to dashboard file list.
1116
1117         * TestResultServer/handlers/dashboardhandler.py:
1118
1119 2011-04-05  MORITA Hajime  <morrita@google.com>
1120
1121         Reviewed by Adam Barth.
1122
1123         webkit-patch should print git's stderr when git svn dcommit fail
1124         http://webkit.org/b/57861
1125
1126         * Scripts/webkitpy/common/checkout/scm.py:
1127
1128 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
1129
1130         Reviewed by Tony Chang.
1131
1132         Add --baseline-search-path to NRWT
1133         https://bugs.webkit.org/show_bug.cgi?id=56233
1134
1135         Add NRWT option to specify additional directories to look for baselines
1136         (will be used by hardware GPU bots which will have local per-bot
1137         expectations for some tests)
1138
1139         * Scripts/webkitpy/common/system/filesystem_mock.py:
1140         * Scripts/webkitpy/layout_tests/port/base.py:
1141         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1142         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1143
1144 2011-04-05  Adam Roben  <aroben@apple.com>
1145
1146         Strip off /results.html from results URLs before trying to load leaks files from them
1147
1148         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
1149         files, rather than pointing to the directory that contains them. This is more convenient for
1150         people browsing build.webkit.org, but confused Leaks Viewer.
1151
1152         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
1153         list don't work
1154
1155         Reviewed by Joseph Pecoraro.
1156
1157         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1158         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
1159
1160 2011-04-05  Carol Szabo  <carol@webkit.org>
1161
1162         Unreviewed.
1163
1164         Updated my info in committers.py
1165
1166         Scripts\webkitpy\common\config\committers.py
1167
1168 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
1169
1170         Reviewed by Laszlo Gombos.
1171
1172         [Qt] Make WebKitLibraries optional for building QtWebKit
1173         https://bugs.webkit.org/show_bug.cgi?id=57542
1174
1175         * Scripts/build-webkit:
1176
1177 2011-04-05  Chang Shu  <cshu@webkit.org>
1178
1179         Reviewed by Laszlo Gombos.
1180
1181         [Qt] MiniBrowser defaultUrl does not work
1182         https://bugs.webkit.org/show_bug.cgi?id=57021
1183
1184         Match the behavior and coding of MiniBrowser to QtTestBrowser.
1185         * MiniBrowser/qt/main.cpp:
1186         (main):
1187
1188 2011-04-05  Jade Han  <jade.han@nokia.com>
1189
1190         Reviewed by Laszlo Gombos.
1191
1192         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
1193         https://bugs.webkit.org/show_bug.cgi?id=54977
1194
1195         This change is a preparation to enable building webkit2 for Symbian.
1196         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
1197
1198         * Tools.pro:
1199
1200 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1201
1202         Reviewed by Andreas Kling.
1203
1204         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
1205         https://bugs.webkit.org/show_bug.cgi?id=57832
1206
1207         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
1208
1209         * MiniBrowser/qt/UrlLoader.cpp:
1210         (UrlLoader::UrlLoader):
1211
1212 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1213
1214         [Qt] Linux Release minimal build fix after r82919.
1215
1216         * MiniBrowser/qt/BrowserWindow.cpp:
1217         (BrowserWindow::loadURLListFromFile):
1218         * QtTestBrowser/launcherwindow.cpp:
1219         (LauncherWindow::loadURLListFromFile):
1220
1221 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1222
1223         Reviewed by Andreas Kling.
1224
1225         [Qt] Make URL loader accessible from testbrowser's menus
1226         https://bugs.webkit.org/show_bug.cgi?id=57823
1227
1228         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
1229
1230         * MiniBrowser/qt/BrowserWindow.cpp:
1231         (BrowserWindow::BrowserWindow):
1232         (BrowserWindow::loadURLListFromFile):
1233         (BrowserWindow::~BrowserWindow):
1234         * MiniBrowser/qt/BrowserWindow.h:
1235         * QtTestBrowser/launcherwindow.cpp:
1236         (LauncherWindow::LauncherWindow):
1237         (LauncherWindow::~LauncherWindow):
1238         (LauncherWindow::createChrome):
1239         (LauncherWindow::loadURLListFromFile):
1240         * QtTestBrowser/launcherwindow.h:
1241
1242 2011-04-04  Sam Weinig  <sam@webkit.org>
1243
1244         Reviewed by Brian Weinstein.
1245
1246         Remove duplicate API from WKContext
1247         <rdar://problem/8727879>
1248         https://bugs.webkit.org/show_bug.cgi?id=57815
1249
1250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1251         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
1252         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1253         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
1254
1255 2011-04-04  Tony Chang  <tony@chromium.org>
1256
1257         Reviewed by Ojan Vafai.
1258
1259         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
1260         https://bugs.webkit.org/show_bug.cgi?id=57783
1261
1262         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1263         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1264
1265 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
1266
1267         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
1268         from WebKitBuild.
1269
1270         * Scripts/webkitdirs.pm:
1271
1272 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
1273
1274         Reviewed by Gustavo Noronha Silva.
1275
1276         [GTK] WebGL support
1277         https://bugs.webkit.org/show_bug.cgi?id=31517
1278
1279         Add support to the DRT for turning on WebGL when a layout tests requests it.
1280
1281         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1282         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
1283
1284 2011-04-04  Chang Shu  <cshu@webkit.org>
1285
1286         Reviewed by Darin Adler.
1287
1288         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
1289         https://bugs.webkit.org/show_bug.cgi?id=57572
1290
1291         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1292         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1293         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
1294         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1295
1296 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
1297
1298         Reviewed by Csaba Osztrogonác.
1299
1300         [Qt] DumpRenderTree breaks compilation in some uClibc environments
1301         https://bugs.webkit.org/show_bug.cgi?id=57602
1302
1303         * DumpRenderTree/qt/main.cpp:
1304         (get_backtrace):
1305
1306 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
1307
1308         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
1309
1310         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1311         (LayoutTestController::shadowRoot):
1312
1313 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
1314
1315         Unreviewed, fix exception in rebaseline tool.
1316
1317         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1318
1319 2011-04-02  Beth Dakin  <bdakin@apple.com>
1320
1321         Rubber-stamped by Geoff Garen.
1322
1323         For Dan!
1324         * DumpRenderTree/mac/DumpRenderTree.mm:
1325         (resetWebViewToConsistentStateBeforeTesting):
1326
1327 2011-04-02  Beth Dakin  <bdakin@apple.com>
1328
1329         Rubber-stamped by Geoff Garen.
1330
1331         Need to reset the scale, much like zoom.
1332         * DumpRenderTree/mac/DumpRenderTree.mm:
1333         (resetWebViewToConsistentStateBeforeTesting):
1334
1335 2011-04-02  Sam Weinig  <sam@webkit.org>
1336
1337         Reviewed by Beth Dakin.
1338
1339         https://bugs.webkit.org/show_bug.cgi?id=57605
1340         Frame::pageScaleFactor() should not affect getBoundingClientRect() or
1341         getClientRects()
1342         -and corresponding-
1343         <rdar://problem/9194541>
1344
1345         Add DRT support for the scaleWebView SPI.
1346         * DumpRenderTree/mac/EventSendingController.mm:
1347         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1348         (+[EventSendingController webScriptNameForSelector:]):
1349         (-[EventSendingController scalePageBy:atX:andY:]):
1350         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1351         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1352         (WTR::EventSendingController::scalePageBy):
1353         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1354         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1355         (WTR::InjectedBundlePage::reset):
1356
1357 2011-04-02  Dominic Cooney  <dominicc@google.com>
1358
1359         Reviewed by Martin Robinson.
1360
1361         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1362         https://bugs.webkit.org/show_bug.cgi?id=57551
1363
1364         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1365         (LayoutTestController::shadowRoot):
1366
1367 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1368
1369         Reviewed by Eric Seidel.
1370
1371         Remove AbstractStep._run_script and move script names to ports.py
1372         https://bugs.webkit.org/show_bug.cgi?id=57704
1373
1374         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
1375
1376         * Scripts/webkitpy/common/config/ports.py:
1377         * Scripts/webkitpy/tool/commands/download_unittest.py:
1378         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1379         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1380         * Scripts/webkitpy/tool/steps/abstractstep.py:
1381         * Scripts/webkitpy/tool/steps/checkstyle.py:
1382         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1383         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1384         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1385
1386 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1387
1388         Reviewed by Eric Seidel.
1389
1390         Emulate shebang on Win32
1391         https://bugs.webkit.org/show_bug.cgi?id=55927
1392
1393         Scripts on Windows work only if they are called with the explicit interpreter.
1394         Read the first line of scripts to detect the correct executable.
1395
1396         * Scripts/webkitpy/common/config/ports.py:
1397         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
1398         * Scripts/webkitpy/common/system/executive_unittest.py:
1399
1400 2011-04-01  Adam Barth  <abarth@webkit.org>
1401
1402         Reviewed by Eric Seidel.
1403
1404         apos entities shouldn't show up in ChangeLogs when using webkit-patch
1405         https://bugs.webkit.org/show_bug.cgi?id=57692
1406
1407         Previously, we were using BeautifulSoup to process XML from
1408         bugs.webkit.org, but that's incorrect.  We should be using
1409         BeautifulStoneSoup to process the XML.  We were getting the &apos;
1410         entity wrong because &apos; is an XML entity but not an HTML entity.
1411
1412         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1413         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1414
1415 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1416
1417         Unreviewed, rolling out r82721.
1418         http://trac.webkit.org/changeset/82721
1419         https://bugs.webkit.org/show_bug.cgi?id=57687
1420
1421         This patch introduced assertion failures on the GTK+ bots.
1422         (Requested by mrobinson on #webkit).
1423
1424         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1425         (LayoutTestController::shadowRoot):
1426
1427 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
1428
1429         Unreviewed buildfix.
1430
1431         [Qt][WK2] Build Webkit2 using "-2" option on Qt
1432         https://bugs.webkit.org/show_bug.cgi?id=55074
1433
1434         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
1435         (The isWK2() function removes it from @ARGV, but not from @options.)
1436
1437 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
1438
1439         Reviewed by Csaba Osztrogonác.
1440
1441         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
1442         https://bugs.webkit.org/show_bug.cgi?id=57666
1443
1444         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
1445
1446 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1447
1448         Reviewed by Adam Barth.
1449
1450         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
1451
1452         We apparently never implemented the code to skip tests based on
1453         what was compiled into DRT. Also, change the logic used to skip
1454         platform directories to match what old-run-webkit-tests does:
1455         skip every test not in a directory in the baseline search path.
1456
1457         https://bugs.webkit.org/show_bug.cgi?id=57662
1458
1459         * Scripts/webkitpy/layout_tests/port/mac.py:
1460         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1461         * Scripts/webkitpy/layout_tests/port/webkit.py:
1462
1463 2011-03-29  Mark Rowe  <mrowe@apple.com>
1464
1465         Reviewed by Jon Honeycutt.
1466
1467         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
1468
1469         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
1470
1471         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1472         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1473         * Scripts/webkitpy/layout_tests/port/mac.py:
1474         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1475
1476 2011-04-01  Chang Shu  <cshu@webkit.org>
1477
1478         Reviewed by Csaba Osztrogonác.
1479
1480         [Qt][WK2] Build Webkit2 using "-2" option on Qt
1481         https://bugs.webkit.org/show_bug.cgi?id=55074
1482
1483         * Scripts/build-webkit:
1484
1485 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1486
1487         Reviewed by Tony Chang.
1488
1489         new-run-webkit-tests: remove spurious port version override in webkit.py
1490         base.py provides a default implementation so this is just
1491         breaking things.
1492
1493         https://bugs.webkit.org/show_bug.cgi?id=57667
1494
1495         * Scripts/webkitpy/layout_tests/port/webkit.py:
1496         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1497
1498 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
1499
1500         Reviewed by Adam Roben.
1501
1502         Make view results on waterfall direct link to results.html
1503         https://bugs.webkit.org/show_bug.cgi?id=57671
1504
1505         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
1506         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
1507
1508 2011-04-01  Sam Weinig  <sam@webkit.org>
1509
1510         Fix windows build.
1511
1512         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
1513         (TestWebKitAPI::TEST):
1514         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1515         (TestWebKitAPI::flushMessages):
1516
1517 2011-04-01  Sam Weinig  <sam@webkit.org>
1518
1519         Reviewed by Adam Roben.
1520
1521         Add adoptWK to WKRetainPtr.h
1522         https://bugs.webkit.org/show_bug.cgi?id=57670
1523
1524         * TestWebKitAPI/PlatformUtilities.h:
1525         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1526         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1527         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1528         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1529         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1530         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1531         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1532         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1533         (TestWebKitAPI::createSessionStateContainingFormData):
1534         * WebKitTestRunner/StringFunctions.h:
1535         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
1536
1537 2011-04-01  Sam Weinig  <sam@webkit.org>
1538
1539         Reviewed by Adam Roben.
1540
1541         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
1542
1543         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1544         (WTR::LayoutTestController::shadowRoot):
1545         Make judicious use of adoptWK().
1546
1547 2011-04-01  Sam Weinig  <sam@webkit.org>
1548
1549         Reviewed by Timothy Hatcher.
1550
1551         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
1552
1553         * Scripts/extract-localizable-strings:
1554
1555 2011-04-01  Anders Carlsson  <andersca@apple.com>
1556
1557         Reviewed by Sam Weinig.
1558
1559         Shockwave plug-in doesn't accept mouse events
1560         https://bugs.webkit.org/show_bug.cgi?id=57653
1561         <rdar://problem/8483273>
1562
1563         Add a plug-in test.
1564
1565         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1566         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1567         (PluginTest::indicateTestFailure):
1568         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
1569
1570         (PluginTest::NPN_ConvertPoint):
1571         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1572         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1573         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1574         Call indicateTestFailure.
1575
1576         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
1577         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
1578         (ConvertPoint::ConvertPoint):
1579         (ConvertPoint::testConvert):
1580         (ConvertPoint::NPP_New):
1581
1582 2011-04-01  Dominic Cooney  <dominicc@google.com>
1583
1584         Reviewed by Martin Robinson.
1585
1586         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1587         https://bugs.webkit.org/show_bug.cgi?id=57551
1588
1589         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1590         (LayoutTestController::shadowRoot):
1591
1592 2011-04-01  Sam Weinig  <sam@webkit.org>
1593
1594         Reviewed by Anders Carlsson.
1595
1596         WebKitTestRunner needs layoutTestController.shadowRoot
1597         https://bugs.webkit.org/show_bug.cgi?id=57661
1598
1599         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1600         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1601         (WTR::LayoutTestController::shadowRoot):
1602         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1603         Implement layoutTestController.shadowRoot for WebKit2.
1604
1605 2011-04-01  Chang Shu  <cshu@webkit.org>
1606
1607         Reviewed by Darin Adler.
1608
1609         WebKitTestRunner needs layoutTestController.setDatabaseQuota
1610         https://bugs.webkit.org/show_bug.cgi?id=57568
1611
1612         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1613         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1614         (WTR::LayoutTestController::setDatabaseQuota):
1615         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1616
1617 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1618
1619         Reviewed by Tony Chang.
1620
1621         This patch completes the cleanup of
1622         rebaseline-chromium-webkit-tests to work with all of the
1623         variants of a platform (we can now rebaseline gpu- and non-gpu
1624         files at the same time).
1625
1626         When the rebaselining is complete, any lines declared as
1627         REBASELINE in the expectations file that matches a test that was
1628         actually rebaselined will be deleted, even if only one of the
1629         variants was actually rebaselined. This may cause odd problems,
1630         but is better than where we're at today.
1631
1632         This change removes the -g flag and deprecates -w. The -g flag is gone
1633         because GPU baselines are handled just like any other variant.
1634         The -w flag is deprecated because this tool now only works
1635         against the canaries, since that's the only place we have a full
1636         set of bots. It will be trivial to change this to
1637         build.webkit.org if we decide that's where we want them to be.
1638
1639         Also, this patch deletes a lot of cruft that is no longer needed
1640         in the test_expectations code and the port-specific code.
1641
1642         https://bugs.webkit.org/show_bug.cgi?id=55191
1643
1644         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1645         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1646         * Scripts/webkitpy/layout_tests/port/base.py:
1647         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1648         * Scripts/webkitpy/layout_tests/port/chromium.py:
1649         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1650         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1651         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1652         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1653         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1654         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1655         * Scripts/webkitpy/layout_tests/port/mac.py:
1656         * Scripts/webkitpy/layout_tests/port/test.py:
1657         * Scripts/webkitpy/layout_tests/port/webkit.py:
1658         * Scripts/webkitpy/layout_tests/port/win.py:
1659         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1660         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1661
1662 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1663
1664         Reviewed by Adam Barth.
1665
1666         rebaseline-chromium-webkit-tests does not work correctly with
1667         version-specific baselines. This patch updates the tool to use
1668         all of the version-specific bots on the canaries, and will now
1669         attempt to rebaseline all of the versions by default, although
1670         it will not update both GPU and CPU versions.
1671
1672         Also, it will no longer modify the test_expectations.txt file
1673         *at all*. You will have to manually delete the REBASELINE lines
1674         after running the tool and determining that it did what you
1675         wanted it to do. This should be fixed in a separate bug - see
1676         webkit bug #55191.
1677
1678         https://bugs.webkit.org/show_bug.cgi?id=55608
1679
1680         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1681         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1682         * Scripts/webkitpy/layout_tests/port/chromium.py:
1683         * Scripts/webkitpy/layout_tests/port/test.py:
1684         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1685         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1686
1687 2011-03-31  Tony Chang  <tony@chromium.org>
1688
1689         Reviewed by Ojan Vafai.
1690
1691         [chromium] update the rebaseline tool to know about pngs with checksums
1692         https://bugs.webkit.org/show_bug.cgi?id=57481
1693
1694         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
1695         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1696
1697 2011-04-01  Adam Roben  <aroben@apple.com>
1698
1699         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
1700
1701         Previously, we were getting the revision of the first revision that triggered a build.
1702         Choosing the last revision would have been more accurate. But got_revision is what is used
1703         everywhere else on build.webkit.org, and should work even when there were no changes that
1704         triggered a build (e.g., if someone clicked the Force Build button).
1705
1706         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
1707         recent builds list
1708
1709         Reviewed by Anders Carlsson.
1710
1711         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1712         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
1713         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
1714
1715         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
1716         (Array.prototype.first): Added this helper function to return the first element in an array
1717         that matches the given predicate, or null if no such element exists.
1718
1719 2011-03-31  Adam Roben  <aroben@apple.com>
1720
1721         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
1722
1723         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
1724
1725         Reviewed by Darin Adler.
1726
1727         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1728         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
1729         URL on its own line.
1730
1731         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1732         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
1733         progression, and added a new test that uses a short bug URL while I was at it.
1734
1735 2011-04-01  Adam Roben  <aroben@apple.com>
1736
1737         Mark .vcproj/.vsprops/.sln files as being Windows-only
1738
1739         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
1740
1741         Reviewed by Anders Carlsson.
1742
1743         * Scripts/webkitpy/common/config/build.py:
1744         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
1745         directories as Windows-only.
1746
1747         * Scripts/webkitpy/common/config/build_unittest.py:
1748         (ShoulBuildTest): Added test cases for the above.
1749
1750 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
1751
1752         Reviewed by Laszlo Gombos.
1753
1754         [Qt] Build MiniBrowser for Symbian
1755         https://bugs.webkit.org/show_bug.cgi?id=56319
1756
1757         Have MiniBrowser reference it's own copy of useragentlist.txt instead
1758         of copying QtTestBrowser's.
1759         Remove Tools/MiniBrowser/DerivedSources.pro
1760         This reduces complexity in the Tools scripts due to Symbian limitations.
1761
1762         * DerivedSources.pro:
1763         * MiniBrowser/DerivedSources.pro: Removed.
1764         * MiniBrowser/MiniBrowser.qrc:
1765         * MiniBrowser/qt/MiniBrowser.pro:
1766         * Scripts/webkitdirs.pm:
1767
1768 2011-03-31  Chang Shu  <cshu@webkit.org>
1769
1770         Reviewed by Darin Adler.
1771
1772         WebKitTestRunner needs layoutTestController.clearAllDatabases
1773         https://bugs.webkit.org/show_bug.cgi?id=42540
1774
1775         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1776         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1777         (WTR::InjectedBundle::beginTesting):
1778         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1779         (WTR::LayoutTestController::clearAllDatabases):
1780         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1781
1782 2011-03-31  Chang Shu  <cshu@webkit.org>
1783
1784         Reviewed by Darin Adler.
1785
1786         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
1787         https://bugs.webkit.org/show_bug.cgi?id=42692
1788
1789         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1790
1791 2011-03-31  Darin Adler  <darin@apple.com>
1792
1793         Reviewed by Sam Weinig.
1794
1795         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
1796         https://bugs.webkit.org/show_bug.cgi?id=57573
1797
1798         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1799         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
1800         Removed fake definitions of keyDown and contextClick.
1801
1802         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1803         (WTR::operator==): Added. So we can compare two WKPoint structs.
1804         (WTR::parseModifier): Added.
1805         (WTR::parseModifierArray): Added.
1806         (WTR::EventSendingController::EventSendingController): Initialize the
1807         new data members.
1808         (WTR::EventSendingController::mouseDown): Added. Calls
1809         WKBundlePageSimulateMouseDown.
1810         (WTR::EventSendingController::mouseUp): Added. Calls
1811         WKBundlePageSimulateMouseUp.
1812         (WTR::EventSendingController::mouseMoveTo): Added. Calls
1813         WKBundlePageSimulateMouseMotion.
1814         (WTR::EventSendingController::leapForward): Added.
1815         (WTR::EventSendingController::updateClickCount): Added. Used by the
1816         mouseDown/Up functions to create a click count.
1817
1818         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
1819         for the changes above.
1820
1821 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
1822
1823         Reviewed by Martin Robinson.
1824
1825         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
1826         https://bugs.webkit.org/show_bug.cgi?id=57362
1827
1828         Do not generate DRT output if willSendRequestReturnsNull is set.
1829
1830         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1831         (willSendRequestCallback):
1832
1833 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
1834
1835         Reviewed by Martin Robinson.
1836
1837         Implement MiniBrowser for Gtk port.
1838         https://bugs.webkit.org/show_bug.cgi?id=48512
1839
1840         Initial implementation of the Gtk MiniBrowser.
1841
1842         * MiniBrowser/gtk/GNUmakefile.am: Added.
1843         * MiniBrowser/gtk/main.c: Added.
1844         (activateUriEntryCallback):
1845         (destroyCallback):
1846         (goBackCallback):
1847         (goForwardCallback):
1848         (createToolbar):
1849         (createWebView):
1850         (createWindow):
1851         (argumentToURL):
1852         (main):
1853
1854 2011-03-30  Dominic Cooney  <dominicc@google.com>
1855
1856         Reviewed by Dimitri Glazkov.
1857
1858         Adds layoutTestController.shadowRoot accessor to Mac DRT.
1859         https://bugs.webkit.org/show_bug.cgi?id=57415
1860
1861         * DumpRenderTree/LayoutTestController.cpp:
1862         (shadowRootCallback):
1863         (LayoutTestController::staticFunctions):
1864         * DumpRenderTree/LayoutTestController.h:
1865         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1866         (LayoutTestController::shadowRoot):
1867         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1868         (LayoutTestController::shadowRoot):
1869
1870 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
1871
1872         Reviewed by Chris Marrin.
1873
1874         Update fast/canvas tests to avoid dumping the render tree when possible
1875         https://bugs.webkit.org/show_bug.cgi?id=57493
1876
1877         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
1878           accelerated drawing and accelerated drawing for canvas
1879
1880 2011-03-30  Adam Roben  <aroben@apple.com>
1881
1882         Stop ignoring leaks in CGGradientCreateWithColorStops
1883
1884         Fixes <rdar://problem/7888547>.
1885
1886         Rubber-stamped by John Sullivan.
1887
1888         * Scripts/old-run-webkit-tests:
1889         (countAndPrintLeaks): Removed some code to ignore those leaks.
1890
1891 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
1892
1893         Reviewed by Alexey Proskuryakov.
1894
1895         Add some dynamic annotations to JavaScriptCore/wtf
1896         https://bugs.webkit.org/show_bug.cgi?id=53747
1897
1898         By using these annotations we can improve the precision of finding
1899         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
1900         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
1901
1902         These files don't add new functionality, so don't need extra tests.
1903
1904         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
1905
1906 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1907
1908         Reviewed by Adam Roben.
1909
1910         Share most vsprops between Release and Production builds in releaseproduction.vsprops
1911         https://bugs.webkit.org/show_bug.cgi?id=57508
1912
1913         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1914         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1915         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1916         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1917         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1918         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1919         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1920         * DumpRenderTree/win/ImageDiffRelease.vsprops:
1921         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1922         * FindSafari/FindSafariProduction.vsprops:
1923         * FindSafari/FindSafariRelease.vsprops:
1924         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
1925         * FindSafari/FindSafariReleasePGO.vsprops:
1926         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1927         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1928         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1929         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1930         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1931         * WebKitAPITest/WebKitAPITestProduction.vsprops:
1932         * WebKitAPITest/WebKitAPITestRelease.vsprops:
1933         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
1934         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1935         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1936         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1937         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1938         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1939         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1940         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1941         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1942         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1943         * WinLauncher/WinLauncherProduction.vsprops:
1944         * WinLauncher/WinLauncherRelease.vsprops:
1945         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1946         * record-memory-win/record-memory-winProduction.vsprops:
1947         * record-memory-win/record-memory-winRelease.vsprops:
1948         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1949
1950 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1951
1952         Reviewed by Adam Roben.
1953
1954         Update Windows production build logic for new production configurations
1955         https://bugs.webkit.org/show_bug.cgi?id=57494
1956
1957         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1958         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1959         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1960         * FindSafari/FindSafariProduction.vsprops:
1961         * FindSafari/FindSafariReleasePGO.vsprops:
1962         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1963         * WebKitAPITest/WebKitAPITestProduction.vsprops:
1964         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1965         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1966         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1967         * WinLauncher/WinLauncherProduction.vsprops:
1968         * record-memory-win/record-memory-winProduction.vsprops:
1969
1970 2011-03-30  Robert Hogan  <robert@webkit.org>
1971
1972         Reviewed by Antonio Gomes.
1973
1974         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
1975         Unskip http/tests/navigation/go-back-to-error-page.html
1976
1977         Also add the location of DumpRenderTreeSupportQt.h
1978         to DRT's include paths.
1979
1980         https://bugs.webkit.org/show_bug.cgi?id=52614
1981
1982         * DumpRenderTree/qt/DumpRenderTree.pro:
1983         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1984         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1985         * DumpRenderTree/qt/GCControllerQt.cpp:
1986         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1987         (LayoutTestController::queueLoadHTMLString):
1988         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1989         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1990         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1991         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1992         (LoadAlternateHTMLStringItem::invoke):
1993         * DumpRenderTree/qt/WorkQueueItemQt.h:
1994         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1995         * QtTestBrowser/QtTestBrowser.pro:
1996         * QtTestBrowser/launcherwindow.h:
1997
1998 2011-03-30  Adam Barth  <abarth@webkit.org>
1999
2000         Reviewed by Adam Roben.
2001
2002         SheriffBot rollouts take too long
2003         https://bugs.webkit.org/show_bug.cgi?id=57498
2004
2005         We used to build before landing rollouts via the commit-queue to
2006         prevent further breakage, but now that our individual commit-queue
2007         machines are slower, building takes too long.  I can't remember the
2008         last time a rollout broke compile.  It seems like just landing the
2009         patch is the better trade-off.
2010
2011         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2012         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2013
2014 2011-03-30  Adam Barth  <abarth@webkit.org>
2015
2016         Remove platform/chromium-mac-snowleopard
2017         https://bugs.webkit.org/show_bug.cgi?id=57486
2018
2019         This directory no longer exists, so we can remove it from the fallback
2020         chain.
2021
2022         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2023
2024 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2025
2026         Reviewed by Adam Roben.
2027
2028         Rename Windows configuration Release_LTCG to Production for clarity
2029         https://bugs.webkit.org/show_bug.cgi?id=57465
2030
2031         * DumpRenderTree/DumpRenderTree.sln:
2032         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2033         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
2034         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
2035         * DumpRenderTree/win/DumpRenderTree.vcproj:
2036         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
2037         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
2038         * DumpRenderTree/win/ImageDiff.vcproj:
2039         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
2040         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
2041         * FindSafari/FindSafari.vcproj:
2042         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
2043         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
2044         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
2045         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
2046         * MiniBrowser/MiniBrowser.vcproj:
2047         * Scripts/webkitdirs.pm:
2048         * TestWebKitAPI/win/TestWebKitAPI.sln:
2049         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2050         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
2051         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2052         * WebKitAPITest/WebKitAPITest.vcproj:
2053         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
2054         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
2055         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2056         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
2057         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
2058         * WebKitTestRunner/WebKitTestRunner.sln:
2059         * WebKitTestRunner/win/InjectedBundle.vcproj:
2060         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
2061         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
2062         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
2063         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2064         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
2065         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
2066         * WinLauncher/WinLauncher.vcproj:
2067         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
2068         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
2069         * record-memory-win/record-memory-win.vcproj:
2070         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
2071         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
2072
2073 2011-03-30  MORITA Hajime  <morrita@google.com>
2074
2075         Reviewed by Dimitri Glazkov.
2076
2077         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
2078         https://bugs.webkit.org/show_bug.cgi?id=56573
2079
2080         Added LayoutTestController.shadowRoot() to Chromium DRT.
2081
2082         * DumpRenderTree/chromium/LayoutTestController.cpp:
2083         (LayoutTestController::LayoutTestController):
2084         (LayoutTestController::shadowRoot):
2085         * DumpRenderTree/chromium/LayoutTestController.h:
2086
2087 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
2088
2089         Reviewed by Kent Tamura.
2090
2091         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
2092         https://bugs.webkit.org/show_bug.cgi?id=57430
2093
2094         * DumpRenderTree/chromium/LayoutTestController.cpp:
2095         (LayoutTestController::LayoutTestController):
2096         (LayoutTestController::setPluginsEnabled):
2097         * DumpRenderTree/chromium/LayoutTestController.h:
2098
2099 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2100
2101         Reviewed by Adam Barth.
2102
2103         make webkit-patch upload respect -d
2104         https://bugs.webkit.org/show_bug.cgi?id=57425
2105
2106         * Scripts/webkitpy/common/checkout/scm.py:
2107         * Scripts/webkitpy/tool/steps/commit.py:
2108
2109 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2110
2111         Reviewed by Adam Barth.
2112
2113         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
2114         https://bugs.webkit.org/show_bug.cgi?id=57429
2115
2116         * Scripts/webkitpy/common/checkout/scm.py:
2117
2118 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2119
2120         Unreviewed, rolling out r82383.
2121         http://trac.webkit.org/changeset/82383
2122         https://bugs.webkit.org/show_bug.cgi?id=57417
2123
2124         "nrwt isn't shutting down cleanly" (Requested by dpranke on
2125         #webkit).
2126
2127         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2128         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2129         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2130
2131 2011-03-29  Kent Tamura  <tkent@chromium.org>
2132
2133         Reviewed by Dimitri Glazkov.
2134
2135         Make validation message bubble testable
2136         https://bugs.webkit.org/show_bug.cgi?id=57290
2137
2138         * DumpRenderTree/mac/DumpRenderTree.mm:
2139         (createWebViewAndOffscreenWindow): Change a setting so that validation
2140           bubbles isn't hidden automatically.
2141
2142 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
2143
2144         Reviewed by Ojan Vafai.
2145
2146         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
2147
2148         It's a bit unclear whether multiple threads or multiple
2149         processes will be a better model on windows. This change will
2150         test threads for now while we're still working out the bugs in
2151         multiple-processes.
2152
2153         https://bugs.webkit.org/show_bug.cgi?id=57410
2154
2155         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2156         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2157         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2158
2159 2011-03-29  David Levin  <levin@chromium.org>
2160
2161         Reviewed by Shinichiro Hamaji.
2162
2163         check-webkit-style confused by two ChangeLog entries in a row from same user
2164         https://bugs.webkit.org/show_bug.cgi?id=57250
2165
2166         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
2167         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
2168         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
2169           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
2170           checking more than that would be very messey.
2171         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
2172         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
2173
2174 2011-03-29  Kent Tamura  <tkent@chromium.org>
2175
2176         Reviewed by Dimitri Glazkov.
2177
2178         [Mac] Enable interactive-validation tests on Mac DRT
2179         https://bugs.webkit.org/show_bug.cgi?id=57308
2180
2181         * DumpRenderTree/mac/DumpRenderTree.mm:
2182         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
2183
2184 2011-03-29  Chang Shu  <cshu@webkit.org>
2185
2186         Reviewed by Kenneth Rohde Christiansen.
2187
2188         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
2189         https://bugs.webkit.org/show_bug.cgi?id=42692
2190
2191         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2192         (WTR::InjectedBundle::beginTesting):
2193         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2194         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
2195         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2196
2197 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
2198
2199         Reviewed by Xan Lopez.
2200
2201         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
2202         https://bugs.webkit.org/show_bug.cgi?id=57067
2203
2204         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
2205         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
2206         update DRT and pixel results as hundreds of results will need to be updated.
2207
2208         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2209         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
2210         by overriding the theme RC/CSS files.
2211
2212 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
2213
2214         Reviewed by Adam Roben.
2215
2216         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
2217         https://bugs.webkit.org/show_bug.cgi?id=57394
2218
2219         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
2220         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
2221         the IDE. To avoid this, add a separate vsprops file for each project configuration that
2222         contains the required inherited property sheets.
2223
2224         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2225         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
2226         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
2227         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
2228         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
2229         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
2230         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
2231         * DumpRenderTree/win/DumpRenderTree.vcproj:
2232         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
2233         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
2234         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
2235         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
2236         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
2237         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
2238         * DumpRenderTree/win/ImageDiff.vcproj:
2239         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
2240         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
2241         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
2242         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
2243         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
2244         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
2245         * FindSafari/FindSafari.vcproj:
2246         * FindSafari/FindSafariDebug.vsprops: Added.
2247         * FindSafari/FindSafariDebugAll.vsprops: Added.
2248         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
2249         * FindSafari/FindSafariRelease.vsprops: Added.
2250         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
2251         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
2252         * FindSafari/FindSafariReleasePGO.vsprops: Added.
2253         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
2254         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
2255         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
2256         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
2257         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
2258         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
2259         * MiniBrowser/MiniBrowser.vcproj:
2260         * WebKitAPITest/WebKitAPITest.vcproj:
2261         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
2262         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
2263         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
2264         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
2265         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
2266         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
2267         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2268         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
2269         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
2270         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
2271         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
2272         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
2273         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
2274         * WebKitTestRunner/win/InjectedBundle.vcproj:
2275         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
2276         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
2277         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
2278         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
2279         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
2280         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
2281         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2282         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
2283         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
2284         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
2285         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
2286         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
2287         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
2288         * WinLauncher/WinLauncher.vcproj:
2289         * WinLauncher/WinLauncherDebug.vsprops: Added.
2290         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
2291         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
2292         * WinLauncher/WinLauncherRelease.vsprops: Added.
2293         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
2294         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
2295         * record-memory-win/record-memory-win.vcproj:
2296         * record-memory-win/record-memory-winDebug.vsprops: Added.
2297         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
2298         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
2299         * record-memory-win/record-memory-winRelease.vsprops: Added.
2300         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
2301         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
2302
2303 2011-03-29  Adam Barth  <abarth@webkit.org>
2304
2305         Reviewed by Darin Adler.
2306
2307         test_runner2.py can crash due to undefined variable
2308         https://bugs.webkit.org/show_bug.cgi?id=57356
2309
2310         Replace reference to undefined variable with a variable that's actually
2311         defined.  AFAICT, there's no way to test this code.
2312
2313         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2314
2315 2011-03-29  Tony Chang  <tony@chromium.org>
2316
2317         Reviewed by Eric Seidel.
2318
2319         cleanup rebaseline-chromium-webkit-tests
2320         https://bugs.webkit.org/show_bug.cgi?id=57375
2321
2322         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2323             - Split _extract_and_add_new_baselines into 3 functions
2324             - Reduce the amount of line wrapping (the file already has lines
2325               over 80 col, so may as well try to make the file consistent)
2326             - Remove unnecessary ()s
2327
2328 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
2329
2330         Reviewed by Adam Roben.
2331
2332         Make WinCairo a core builder.
2333         https://bugs.webkit.org/show_bug.cgi?id=57373
2334
2335         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
2336         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
2337
2338 2011-03-29  Timothy Hatcher  <timothy@apple.com>
2339
2340         Update update-webkit-localizable-strings to understand that WebKit and
2341         WebKit2 strings go in WebCore.
2342
2343         Also make extract-localizable-strings optionally use an exclude file. No individual
2344         warnings are produced about unlocalized strings when there is no exclude file. This
2345         is needed for WebCore, since there are too many bare strings.
2346
2347         https://webkit.org/b/57354
2348
2349         Reviewed by Sam Weinig.
2350
2351         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
2352         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
2353
2354 2011-03-29  Darin Adler  <darin@apple.com>
2355
2356         Reviewed by Adam Roben.
2357
2358         WebKit2 bundle page needs to offer generated file hooks
2359         https://bugs.webkit.org/show_bug.cgi?id=57279
2360
2361         (Land missing part of the original patch after r82289.)
2362
2363         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2364         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
2365
2366 2011-03-29  Tony Chang  <tony@chromium.org>
2367
2368         Reviewed by Ojan Vafai.
2369
2370         [chromium] NRWT should be able to read checksums from png comments
2371         https://bugs.webkit.org/show_bug.cgi?id=57280
2372
2373         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
2374             from a file.
2375         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
2376         * Scripts/webkitpy/common/system/filesystem_mock.py:
2377         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
2378             if the -checksum.txt file doesn't exist, try looking in the png.
2379         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2380         * Scripts/webkitpy/layout_tests/port/test.py:
2381         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
2382             2k for a png comment with the checksum
2383         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
2384
2385 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2386
2387         Rubber-stamped by Gustavo Noronha Silva.
2388
2389         [GTK] http/tests/uri/username-with-no-hostname.html fails
2390         https://bugs.webkit.org/show_bug.cgi?id=57325
2391
2392         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2393         (willSendRequestCallback): URI host value check done case-insensitively.
2394
2395 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2396
2397         Reviewed by Martin Robinson.
2398
2399         [GTK] http/tests/uri/username-with-no-hostname.html fails
2400         https://bugs.webkit.org/show_bug.cgi?id=57325
2401
2402         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2403         (willSendRequestCallback): Check URI before submitting the request
2404         to WebCore.
2405
2406 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
2407
2408         Reviewed by Ojan Vafai.
2409
2410         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
2411         https://bugs.webkit.org/show_bug.cgi?id=57303
2412
2413         * DumpRenderTree/chromium/EventSender.cpp:
2414         (EventSender::doDragDrop):
2415         (EventSender::beginDragWithFiles):
2416
2417 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
2418
2419         Reviewed by Andreas Kling.
2420
2421         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
2422         https://bugs.webkit.org/show_bug.cgi?id=57314
2423
2424         Provide possibility to print loaded urls to the standard output.
2425
2426         * MiniBrowser/qt/BrowserWindow.cpp:
2427         (BrowserWindow::BrowserWindow):
2428         (BrowserWindow::printURL):
2429         * MiniBrowser/qt/BrowserWindow.h:
2430         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2431         (MiniBrowserApplication::handleUserOptions):
2432         * MiniBrowser/qt/MiniBrowserApplication.h:
2433         (WindowOptions::WindowOptions):
2434         * QtTestBrowser/launcherwindow.cpp:
2435         (LauncherWindow::initializeView):
2436         (LauncherWindow::printURL):
2437         (LauncherWindow::cloneWindow):
2438         * QtTestBrowser/launcherwindow.h:
2439         (WindowOptions::WindowOptions):
2440         * QtTestBrowser/main.cpp:
2441         (LauncherApplication::handleUserOptions):
2442
2443 2011-03-29  Gabor Loki  <loki@webkit.org>
2444
2445         Rubber-stamped by Csaba Osztrogonác.
2446
2447         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2448         https://bugs.webkit.org/show_bug.cgi?id=56918
2449
2450         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
2451
2452 2011-03-28  Gabor Loki  <loki@webkit.org>
2453
2454         Reviewed by Csaba Osztrogonác.
2455
2456         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2457         https://bugs.webkit.org/show_bug.cgi?id=56918
2458
2459         * Scripts/build-jsc:
2460         * Scripts/webkitdirs.pm:
2461
2462 2011-03-28  Andrew Foster  <andrewf@chromium.org>
2463
2464         Reviewed by Ojan Vafai.
2465
2466         webkit-patch should be more intelligent about whether a bug applies to a patch
2467         Create a new function, parse_bug_id_from_changelog() which determines
2468         that a bug is related to a patch by parsing the output generated from
2469         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
2470         the description of a patch.
2471         https://bugs.webkit.org/show_bug.cgi?id=56989
2472
2473         * Scripts/webkitpy/common/checkout/api.py:
2474         * Scripts/webkitpy/common/checkout/changelog.py:
2475         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2476         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2477         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2478         * Scripts/webkitpy/style/checkers/changelog.py:
2479         * Scripts/webkitpy/tool/commands/upload.py:
2480
2481 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
2482
2483         Revert accidentally commited change.
2484
2485         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2486         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2487
2488 2011-03-28  Tony Chang  <tony@chromium.org>
2489
2490         Reviewed by Adam Barth.
2491
2492         [chromium] have DRT write the png checksum into a png comment
2493         https://bugs.webkit.org/show_bug.cgi?id=57255
2494
2495         * DumpRenderTree/chromium/TestShell.cpp:
2496         (TestShell::dumpImage):
2497
2498 2011-03-28  Adele Peterson  <adele@apple.com>
2499
2500         Removing Qt stub, since it doesn't use the same header as the others.
2501
2502         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2503
2504 2011-03-28  Adele Peterson  <adele@apple.com>
2505
2506         Added a few more stubs.
2507
2508         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2509         (LayoutTestController::hasGrammarMarker):
2510         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2511         (LayoutTestController::hasGrammarMarker):
2512         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2513         (LayoutTestController::hasGrammarMarker):
2514
2515 2011-03-28  Adele Peterson  <adele@apple.com>
2516
2517         Build fix.
2518
2519         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2520         (LayoutTestController::hasGrammarMarker):
2521
2522 2011-03-28  Adele Peterson  <adele@apple.com>
2523
2524         Reviewed by Eric Seidel.
2525
2526         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
2527         https://bugs.webkit.org/show_bug.cgi?id=57173
2528
2529         * DumpRenderTree/LayoutTestController.cpp:
2530         (hasGrammarMarkerCallback): Added.
2531         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
2532         * DumpRenderTree/LayoutTestController.h:
2533         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
2534         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
2535
2536 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
2537
2538         Reviewed by Benjamin Poulain.
2539
2540         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2541         https://bugs.webkit.org/show_bug.cgi?id=57087
2542
2543         Trivial typo fix after r82082.
2544
2545         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2546         (WTR::activateFonts):
2547
2548 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
2549
2550         Reviewed by Andreas Kling.
2551
2552         Add myself to the committers list.
2553
2554         * Scripts/webkitpy/common/config/committers.py:
2555
2556 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
2557
2558         Reviewed by Sam Weinig.
2559
2560         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
2561         to link against WebKit.framework for now.
2562
2563         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2564
2565 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2566
2567         Reviewed by Andreas Kling.
2568
2569         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2570         https://bugs.webkit.org/show_bug.cgi?id=57087
2571
2572         Disable QT_ASCII_CAST_WARNINGS for applications.
2573
2574         * DumpRenderTree/qt/DumpRenderTree.pro:
2575         * DumpRenderTree/qt/ImageDiff.pro:
2576         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2577         * MiniBrowser/qt/MiniBrowser.pro:
2578         * QtTestBrowser/QtTestBrowser.pro:
2579         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2580
2581 2011-03-28  Andreas Kling  <kling@webkit.org>
2582
2583         Reviewed by Kenneth Rohde Christiansen.
2584
2585         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
2586         https://bugs.webkit.org/show_bug.cgi?id=57224
2587
2588         * QtTestBrowser/mainwindow.cpp:
2589         (MainWindow::buildUI):
2590         (MainWindow::onTitleChanged):
2591         * QtTestBrowser/mainwindow.h:
2592
2593 2011-03-27  Jer Noble  <jer.noble@apple.com>
2594
2595         Reviewed by Maciej Stachowiak.
2596
2597         Full Screen: disable keyboard access by default
2598         https://bugs.webkit.org/show_bug.cgi?id=56684
2599
2600         Accept the withKeyboard parameter to supportsFullScreenForElement.
2601
2602         * DumpRenderTree/mac/UIDelegate.mm:
2603         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2604
2605 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
2606
2607         Reviewed by David Levin.
2608
2609         check-webkit-style should check ChangeLog for a valid bug number
2610         https://bugs.webkit.org/show_bug.cgi?id=57184
2611
2612         * Scripts/webkitpy/style/checker.py:
2613         * Scripts/webkitpy/style/checker_unittest.py:
2614         * Scripts/webkitpy/style/checkers/changelog.py: Added.
2615         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
2616
2617 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
2618
2619         Reviewed by Andreas Kling.
2620
2621         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2622         https://bugs.webkit.org/show_bug.cgi?id=57087
2623
2624         Use explicit conversion for string to avoid depending on the default codec
2625         installed by the user code.
2626
2627         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2628         (WTR::activateFonts):
2629
2630 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
2631
2632         Revert inadvertantly committed changes.
2633
2634         * Scripts/old-run-webkit-tests:
2635         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2636
2637 2011-03-26  Andreas Kling  <kling@webkit.org>
2638
2639         Reviewed by Kenneth Rohde Christiansen.
2640
2641         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
2642         https://bugs.webkit.org/show_bug.cgi?id=57162
2643
2644         * QtTestBrowser/QtTestBrowser.qrc:
2645         * QtTestBrowser/favicon.png: Added.
2646         * QtTestBrowser/locationedit.cpp:
2647         (defaultPageIcon):
2648         (LocationEdit::LocationEdit):
2649         (LocationEdit::setPageIcon):
2650         (LocationEdit::resizeEvent):
2651         (LocationEdit::updateInternalGeometry):
2652         * QtTestBrowser/locationedit.h:
2653         * QtTestBrowser/mainwindow.cpp:
2654         (MainWindow::buildUI):
2655         (MainWindow::onIconChanged):
2656         (MainWindow::onLoadStarted):
2657         * QtTestBrowser/mainwindow.h:
2658
2659 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
2660
2661         Reviewed by Xan Lopez.
2662
2663         [GTK] Force DumpRenderTree to use 96 DPI
2664         https://bugs.webkit.org/show_bug.cgi?id=56866
2665
2666         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
2667         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
2668
2669         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2670         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
2671         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
2672         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
2673
2674 2011-03-25  Andy Estes  <aestes@apple.com>
2675
2676         Reviewed by Adele Peterson.
2677
2678         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2679         https://bugs.webkit.org/show_bug.cgi?id=49016
2680
2681         TestNetscapePlugIn needs to register support for an image MIME type so
2682         we can test that the embed tag prefers plug-ins to render image MIME
2683         types.
2684
2685         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
2686         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2687         (NP_GetMIMEDescription): Ditto.
2688         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
2689
2690 2011-03-25  Jessie Berlin  <jberlin@apple.com>
2691
2692         Reviewed by Sam Weinig.
2693
2694         WebKit2: Need to be able to set and get the Cookie Storage Policy.
2695         https://bugs.webkit.org/show_bug.cgi?id=50780
2696
2697         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
2698
2699         The test is named "CookieManager" so that we can eventually exercise more of the
2700         CookieManager functionality in the test.
2701
2702         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
2703         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
2704         Assert that the policy returned is equal to the policy set in
2705         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
2706         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
2707         Set the policy to something different than the user's policy and get the policy again.
2708         (TestWebKitAPI::didFinishLoadForFrame):
2709         Get the user's policy so that it can be restored at the end of the test.
2710         (TestWebKitAPI::TEST):
2711         Load about:blank so that the Web Process gets instatiated (needed to get the
2712         CookieManager).
2713
2714         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2715         Add CookieManager.cpp.
2716
2717 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
2718
2719         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
2720
2721         * wx/build/settings.py:
2722
2723 2011-03-24  Ilya Sherman  <isherman@chromium.org>
2724
2725         Reviewed by Adam Roben.
2726
2727         Implement layoutTestController.setAutoFilled in DRT on Windows
2728         https://bugs.webkit.org/show_bug.cgi?id=56828
2729
2730         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2731         (LayoutTestController::setAutofilled): Implemented.
2732
2733 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
2734
2735         Unreviewed build correction.
2736
2737         Correct vsprops file for Debug variant of the CFLite build.
2738         Disable a CFNETWORK-specific test when building for CFLite.
2739
2740         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
2741         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2742
2743 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
2744
2745         Reviewed by Adam Barth.
2746
2747         fix regressions introduced in 81908 - there were a couple of
2748         code paths that only fired under python 2.5 that I missed.
2749
2750         Also change a couple of 'python' references to sys.executable
2751         in order to handle runing test-webkitpy with a binary other than
2752         something called 'python'.
2753
2754         https://bugs.webkit.org/show_bug.cgi?id=57063
2755
2756         * Scripts/webkitpy/layout_tests/port/mac.py:
2757         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2758         * Scripts/webkitpy/test/cat.py:
2759         * Scripts/webkitpy/test/echo.py:
2760
2761 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
2762
2763         Unreviewed build correction.
2764
2765         Add a stub implementation of the TestInvocation dumping logic.
2766         Update project files to reflect new file.
2767
2768         * WebKitTestRunner/cairo: Added.
2769         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
2770         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2771         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2772
2773 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
2774
2775         Reviewed by Tony Chang.
2776
2777         new-run-webkit-tests: clean up worker model defaults. This
2778         changes the default behavior to 'threads' instead of
2779         'old-threads', and clarifies that chromium-win-* and
2780         chromium-mac-leopard are exceptions.
2781
2782         https://bugs.webkit.org/show_bug.cgi?id=56971
2783
2784         * Scripts/webkitpy/layout_tests/port/base.py:
2785         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2786         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2787         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2788         * Scripts/webkitpy/layout_tests/port/test.py:
2789         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2790
2791 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
2792
2793         Reviewed by Darin Adler.
2794
2795         Media Stream API: fix the order of the options in build-webkit.
2796         https://bugs.webkit.org/show_bug.cgi?id=56949
2797
2798         Fix the order of the options in build-webkit.
2799
2800         * Scripts/build-webkit:
2801
2802 2011-03-23  Adam Klein  <adamk@chromium.org>
2803
2804         Reviewed by Mihai Parparita.
2805
2806         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
2807         https://bugs.webkit.org/show_bug.cgi?id=56884
2808
2809         This option will be utilized by Chromium's ui_tests to allow
2810         referencing js-test-resources from a layout test over HTTP.
2811
2812         * Scripts/new-run-webkit-httpd:
2813         Added --layout_tests_dir option.
2814         * Scripts/webkitpy/layout_tests/port/http_server.py:
2815         Plumbed through as layout_tests_dir param.
2816
2817 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
2818
2819         Reviewed by Mihai Parparita.
2820
2821         new-run-webkit-tests: run tests in ascending alphabetical order per
2822         dir. This is a second attempt at the fix; the first attempt, in
2823         r81597, broke the behavior on the old-inline and old-threads
2824         worker models.
2825
2826         https://bugs.webkit.org/show_bug.cgi?id=56760
2827
2828         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2829         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2830         * Scripts/webkitpy/layout_tests/port/test.py:
2831         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2832
2833 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
2834
2835         Reviewed by Martin Robinson.
2836
2837         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
2838         https://bugs.webkit.org/show_bug.cgi?id=56953
2839
2840         Print the string for the detail of 'property-change' signal.
2841
2842         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2843         (axObjectEventListener): Print the detail string.
2844
2845 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
2846
2847         Reviewed by Pavel Feldman.
2848
2849         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
2850         https://bugs.webkit.org/show_bug.cgi?id=56843
2851
2852         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2853         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2854
2855 2011-03-22  Eric Seidel  <eric@webkit.org>
2856
2857         Reviewed by Adam Barth.
2858
2859         Teach update-webkit about gyp
2860         https://bugs.webkit.org/show_bug.cgi?id=56881
2861
2862         This makes it possible for someone who builds from Xcode
2863         to just run update-webkit --gyp and have the project files
2864         generated after update automatically.
2865
2866         I also added a stand-alone "generate-project-files" script
2867         wrapping Source/gyp/configure.  This makes running gyp simpler
2868         since most people will not have gyp or Source/gyp in their path.
2869
2870         * Scripts/build-webkit:
2871         * Scripts/generate-project-files: Added.
2872         * Scripts/update-webkit:
2873
2874 2011-03-22  Anton D'Auria  <adauria@apple.com>
2875
2876         Reviewed by Alexey Proskuryakov.
2877
2878         Add +[WebApplicationCache getOriginsWithCache]
2879         https://bugs.webkit.org/show_bug.cgi?id=56722
2880
2881         * DumpRenderTree/LayoutTestController.cpp:
2882         (originsWithApplicationCacheCallback):
2883         (LayoutTestController::staticFunctions):
2884         * DumpRenderTree/LayoutTestController.h:
2885         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2886         (LayoutTestController::originsWithApplicationCache):
2887         * DumpRenderTree/chromium/LayoutTestController.h:
2888         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
2889         (LayoutTestController::originsWithApplicationCache):
2890         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
2891         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
2892         (LayoutTestController::originsWithApplicationCache):
2893         (LayoutTestController::originsWithLocalStorage):
2894         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
2895         (LayoutTestController::originsWithApplicationCache):
2896         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2897         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
2898         (LayoutTestController::originsWithApplicationCache):
2899         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
2900         (LayoutTestController::originsWithApplicationCache):
2901
2902 2011-03-22  Eric Seidel  <eric@webkit.org>
2903
2904         Reviewed by Adam Barth.
2905
2906         Add support to build-webkit for building with gyp-generated project files
2907         https://bugs.webkit.org/show_bug.cgi?id=56877
2908
2909         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
2910         Eventually we'll want to support gyp-generated projects in a more general manner.
2911
2912         * Scripts/build-webkit:
2913
2914 2011-03-22  David Kilzer  <ddkilzer@apple.com>
2915
2916         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
2917
2918         Reviewed by Joseph Pecoraro.
2919
2920         * Scripts/build-webkit: Updated usage statement to include
2921         --dsym.
2922         * Scripts/webkitdirs.pm: Added $generateDsym variable.
2923         (generateDsym): Added. Call determineGenerateDsym() and
2924         return $generateDsym.
2925         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
2926         $generateDsym.
2927         (argumentsForXcode): Added.  Returns additional arguments for
2928         xcodebuild based on command-line switches.
2929         (XcodeOptions): Updated to include argumentsForXcode() in the
2930         array returned.
2931
2932 2011-03-22  Adam Roben  <aroben@apple.com>
2933
2934         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
2935
2936         These bots are consistently green again.
2937
2938         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
2939         core builders
2940
2941         Rubber-stamped by Antti Koivisto.
2942
2943         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2944         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
2945
2946         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2947         (BuildBotTest.test_builder_name_regexps): Updated expectations.
2948
2949 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2950
2951         Unreviewed, rolling out r81597.
2952         http://trac.webkit.org/changeset/81597
2953         https://bugs.webkit.org/show_bug.cgi?id=56801
2954
2955         Change results in lots of unexpected flaky on the dashboard.
2956         (Requested by pfeldman on #webkit).
2957
2958         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2959         * Scripts/webkitpy/layout_tests/port/test.py:
2960         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2961
2962 2011-03-21  Sam Weinig  <sam@webkit.org>
2963
2964         Fix failing tests on the WebKit2 bots.
2965
2966         * WebKitTestRunner/TestController.cpp:
2967         (WTR::TestController::resetStateToConsistentValues):
2968
2969 2011-03-21  Daniel Sievers  <sievers@google.com>
2970
2971         Reviewed by Simon Fraser.
2972
2973         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2974         https://bugs.webkit.org/show_bug.cgi?id=56139
2975
2976         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2977         (main):
2978         * DumpRenderTree/chromium/LayoutTestController.cpp:
2979         (LayoutTestController::LayoutTestController):
2980         (LayoutTestController::layerTreeAsText):
2981         * DumpRenderTree/chromium/LayoutTestController.h:
2982         (LayoutTestController::setShowDebugLayerTree):
2983         * DumpRenderTree/chromium/TestShell.cpp:
2984         (TestShell::runFileTest):
2985         (TestShell::dump):
2986         * DumpRenderTree/chromium/TestShell.h:
2987         (TestParams::TestParams):
2988
2989 2011-03-21  Adam Roben  <aroben@apple.com>
2990
2991         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
2992
2993         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
2994         output as plain text
2995
2996         Reviewed by David Kilzer.
2997
2998         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2999         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
3000         to the master.
3001         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
3002         since we're running on the build master, not the slave. Instead, turn the raw source of
3003         actual.html which the build slave uploaded into an HTML log.
3004
3005 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
3006
3007         Reviewed by Mihai Parparita.
3008
3009         new-run-webkit-tests: run tests in ascending alphabetical order per dir
3010         https://bugs.webkit.org/show_bug.cgi?id=56760
3011
3012         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3013         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3014         * Scripts/webkitpy/layout_tests/port/test.py:
3015
3016 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
3017
3018         Reviewed by Steve Block.
3019
3020         Media Stream API patch 0: adding compilation guards.
3021         https://bugs.webkit.org/show_bug.cgi?id=56458
3022
3023         Adding options to enable the media stream API feature in Chromium.
3024
3025         * Scripts/build-webkit:
3026
3027 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
3028
3029         Reviewed by Laszlo Gombos.
3030
3031         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
3032         https://bugs.webkit.org/show_bug.cgi?id=56323
3033
3034         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide
3035         "--stdout" or "--stderr" option.
3036
3037         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3038         (WebCore::DumpRenderTree::~DumpRenderTree):
3039         (WebCore::DumpRenderTree::processArgsLine):
3040         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
3041         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3042         (WebCore::DumpRenderTree::setRedirectOutputFileName):
3043         (WebCore::DumpRenderTree::setRedirectErrorFileName):
3044         * DumpRenderTree/qt/main.cpp:
3045         (isOption):
3046         (takeOptionValue):
3047         (printUsage):
3048         (main):
3049
3050 2011-03-21  Adam Roben  <aroben@apple.com>
3051
3052         Fix exceptions on the buildbot due to my last change
3053
3054         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3055         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
3056
3057 2011-03-21  Adam Roben  <aroben@apple.com>
3058
3059         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
3060
3061         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
3062         output as plain text
3063
3064         Reviewed by Darin Adler.
3065
3066         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3067         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
3068         logs.
3069         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
3070         the build master. This will correctly treat it as HTML.
3071
3072 2011-03-20  Bill Budge  <bbudge@chromium.org>
3073
3074         Reviewed by Adam Barth.
3075
3076         Rename ThreadSafeShared to ThreadSafeRefCounted
3077         https://bugs.webkit.org/show_bug.cgi?id=56714
3078
3079         No new tests. Exposes no new functionality.
3080
3081         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
3082         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
3083         * Scripts/do-webcore-rename:
3084
3085 2011-03-19  Anton D'Auria  <adauria@apple.com>
3086
3087         Reviewed by Dan Bernstein.
3088
3089         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
3090         https://bugs.webkit.org/show_bug.cgi?id=56719
3091
3092         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
3093         (LayoutTestController::clearApplicationCacheForOrigin):
3094
3095 2011-03-19  Anton D'Auria  <adauria@apple.com>
3096
3097         Reviewed by Alexey Proskuryakov.
3098
3099         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
3100         https://bugs.webkit.org/show_bug.cgi?id=56415
3101
3102         * DumpRenderTree/LayoutTestController.cpp:
3103         (clearApplicationCacheForOriginCallback):
3104         (LayoutTestController::staticFunctions):
3105         * DumpRenderTree/LayoutTestController.h:
3106         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
3107         (LayoutTestController::LayoutTestController):
3108         (LayoutTestController::clearAllApplicationCaches):
3109         (LayoutTestController::clearApplicationCacheForOrigin):
3110         * DumpRenderTree/chromium/LayoutTestController.h:
3111         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
3112         (LayoutTestController::clearApplicationCacheForOrigin):
3113         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
3114         (LayoutTestController::clearApplicationCacheForOrigin):
3115         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3116         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
3117         (LayoutTestController::clearApplicationCacheForOrigin):
3118         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
3119         (LayoutTestController::clearApplicationCacheForOrigin):
3120
3121 2011-03-18  Dan Bernstein  <mitz@apple.com>
3122
3123         Revised build fix for r81135.
3124
3125         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3126         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3127
3128 2011-03-18  Adam Roben  <aroben@apple.com>
3129
3130         Windows build fix
3131
3132         * WebKitTestRunner/config.h: Add a missing #endif.
3133
3134 2011-03-18  Andreas Kling  <kling@webkit.org>
3135
3136         Unbreak Qt build after r81494.
3137
3138         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3139         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3140
3141 2011-03-18  Sam Weinig  <sam@webkit.org>
3142
3143         Fix windows build. This was really Adam Roben's fault. I swear!
3144
3145         * WebKitTestRunner/config.h:
3146
3147 2011-03-18  Sam Weinig  <sam@webkit.org>
3148
3149         Reviewed by Adam Roben.
3150
3151         Pixel tests don't work in WebKitTestRunner on Windows
3152         https://bugs.webkit.org/show_bug.cgi?id=56630
3153
3154         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
3155         built-in snapshotting instead of using the window server on the Mac.
3156
3157         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3158         (WTR::InjectedBundle::InjectedBundle):
3159         (WTR::InjectedBundle::didReceiveMessage):
3160         (WTR::InjectedBundle::beginTesting):
3161         (WTR::InjectedBundle::done):
3162         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3163         (WTR::InjectedBundle::setPixelResult):
3164         (WTR::InjectedBundle::shouldDumpPixels):
3165         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3166         (WTR::InjectedBundlePage::dump):
3167         Take the snapshot in the bundle and send it to the UIProcess for dumping.
3168
3169         * WebKitTestRunner/TestInvocation.cpp:
3170         (WTR::TestInvocation::invoke):
3171         (WTR::TestInvocation::dump):
3172         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3173         * WebKitTestRunner/TestInvocation.h:
3174         * WebKitTestRunner/cg: Added.
3175         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
3176         (WTR::createCGContextFromImage):
3177         (WTR::computeMD5HashStringForContext):
3178         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3179         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
3180         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
3181
3182         * WebKitTestRunner/win/TestInvocationWin.cpp:
3183         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3184         Keep stub for Cairo build.
3185
3186         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
3187         Add CG configuration.
3188
3189         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3190         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3191         Add new files.
3192
3193 2011-03-18  Adam Roben  <aroben@apple.com>
3194
3195         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
3196
3197         Rubber-stamped by Simon Fraser.
3198
3199         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3200         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
3201         overflow-y:overlay so that the scrollbar doesn't overlay the content.
3202
3203 2011-03-18  Adam Roben  <aroben@apple.com>
3204
3205         Don't ellipsize long or indented function names in Leaks Viewer
3206
3207         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
3208         scrollbar
3209
3210         Reviewed by Simon Fraser.
3211
3212         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3213         (.data-grid .data-container):
3214         (.data-grid td > div, .data-grid th > div):
3215         Allow the contents to extend to the right.
3216
3217 2011-03-18  Adam Roben  <aroben@apple.com>
3218
3219         Fix some leaks in DRT seen on the leaks bot
3220
3221         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
3222         setWillSendRequestClearHeaderCallback in DRT are leaky
3223
3224         Reviewed by Alexey Proskuryakov.
3225
3226         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
3227
3228         * DumpRenderTree/LayoutTestController.cpp:
3229         (addURLToRedirectCallback):
3230         (setWillSendRequestClearHeaderCallback):
3231         Use OwnArrayPtr to cause the strings to be deleted.
3232
3233 2011-03-18  Adam Roben  <aroben@apple.com>
3234
3235         Fix a NSURLCredential leak seen on the leaks bot
3236
3237         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
3238         connection:didReceiveAuthenticationChallenge:] is leaky
3239
3240         Reviewed by John Sullivan.
3241
3242         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3243         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
3244         cause the NSURLCredential to be released.
3245
3246 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
3247
3248         Unreviewed.
3249
3250         Remove unnecessary brackets around my email address.
3251
3252         * Scripts/webkitpy/common/config/committers.py:
3253
3254 2011-03-18  Adam Roben  <aroben@apple.com>
3255
3256         Remove some files I accidentally added in r81454
3257
3258         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
3259         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
3260
3261 2011-03-18  Adam Roben  <aroben@apple.com>
3262
3263         Ignore an NSNumberFormatter leak on SnowLeopard
3264
3265         * Scripts/old-run-webkit-tests:
3266         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
3267         getObjectValue:forString:errorDescription:].
3268
3269 2011-03-18  Adam Roben  <aroben@apple.com>
3270
3271         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
3272
3273         Rubber-stamped by Mark Rowe.
3274
3275         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3276         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
3277         released.
3278
3279 2011-03-17  Adam Roben  <aroben@apple.com>
3280
3281         Address a review comment I missed in r81445
3282
3283         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3284         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
3285         leaked bytes to speed up searching on long lines.
3286
3287 2011-03-17  Adam Roben  <aroben@apple.com>
3288
3289         Mark leaky builds orange, even if all regression tests passed
3290
3291         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
3292         build.webkit.org when all tests pass even though there are still leaks
3293
3294         Reviewed by Dan Bernstein.
3295
3296         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3297         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
3298         be marked orange if this build step generates warnings.
3299
3300 2011-03-17  Adam Roben  <aroben@apple.com>
3301
3302         Allow values in Leaks Viewer to be shown as percentages
3303
3304         Double-clicking on a column will toggle between showing percentages and showing real values.
3305
3306         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
3307         number of leaked bytes in Leaks Viewer
3308
3309         Reviewed by Joe Pecoraro.
3310
3311         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3312         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
3313         node's totalTime, which is used in calculating percentages.
3314
3315         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3316         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
3317         showing them as percentages.
3318
3319 2011-03-17  Adam Roben  <aroben@apple.com>
3320
3321         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
3322
3323         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
3324         the number of leaked allocations. And the new Average column shows the average number of
3325         leaked bytes per call.
3326
3327         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
3328         just how many allocations
3329
3330         Reviewed by Joe Pecoraro.
3331
3332         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3333         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
3334         line and store it with the leak stack.
3335         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
3336         properties.
3337         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
3338         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
3339         .numberOfCalls now holds the number of leaked allocations.
3340
3341         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3342         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
3343         appear.
3344         (monkeyPatchInspectorObjects): Format the values as bytes.
3345
3346 2011-03-17  Adam Roben  <aroben@apple.com>
3347
3348         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
3349
3350         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
3351         regression tests
3352
3353         Reviewed by James Robinson.
3354
3355         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3356         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
3357         is always populated, even when all regression tests pass.
3358
3359 2011-03-10  Hayato Ito  <hayato@chromium.org>
3360
3361         Reviewed by Tony Chang.
3362
3363         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
3364
3365         https://bugs.webkit.org/show_bug.cgi?id=56076
3366
3367         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3368
3369 2011-03-17  Adam Roben  <aroben@apple.com>
3370
3371         Skip a compositing-sensitive test when accelerated compositing is disabled
3372
3373         Reviewed by Sam Weinig.
3374
3375         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
3376         accelerated compositing is disabled.
3377
3378 2011-03-17  Adam Roben  <aroben@apple.com>
3379
3380         Start using PlatformSpecificScheduler for the Mac builders
3381
3382         The current set of file/directory patterns should work for Mac builders. We may discover
3383         that there are more files and directories we can exclude from the Mac builds, but they can
3384         be added later.
3385
3386         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
3387
3388         Reviewed by Mark Rowe.
3389
3390         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
3391         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
3392
3393         * Scripts/webkitpy/common/config/build.py:
3394         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
3395         cleaned up patterns a little bit.
3396
3397         * Scripts/webkitpy/common/config/build_unittest.py:
3398         (ShouldBuildTest): Fixed some expected results.
3399         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
3400         platforms.
3401
3402 2011-03-17  Jeff Miller  <jeffm@apple.com>
3403
3404         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
3405
3406         *.mode*
3407         *.pbxuser
3408         *.perspective*
3409         project.xcworkspace
3410         xcuserdata
3411
3412         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
3413         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
3414         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
3415         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3416         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
3417
3418 2011-03-17  Adam Roben  <aroben@apple.com>
3419
3420         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
3421
3422         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
3423         mac-wk2
3424
3425         Reviewed by Anders Carlsson.
3426
3427         * Scripts/old-run-webkit-tests:
3428         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
3429         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
3430         we're running in WebKit2 mode.
3431
3432 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
3433
3434         Reviewed by Yury Semikhatsky.
3435
3436         Web Inspector: Clean up Inspector strings.
3437         https://bugs.webkit.org/show_bug.cgi?id=56557
3438
3439         Modify the script to deal correctly with "\xNN" escapes, and to
3440         check strings in Chromium's DevTools.js.
3441
3442         * Scripts/check-inspector-strings:
3443
3444 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
3445
3446         Reviewed by Benjamin Poulain.
3447
3448         Update autoinstall to install mechanize 0.2.4
3449         https://bugs.webkit.org/show_bug.cgi?id=56499
3450
3451         Newer versions of mechanize support HTTPS proxies, which is necessary
3452         for people using webkit-patch behind firewalls.
3453
3454         * Scripts/webkitpy/common/system/autoinstall.py:
3455         * Scripts/webkitpy/thirdparty/__init__.py:
3456
3457 2011-03-16  Sam Weinig  <sam@webkit.org>
3458
3459         Reviewed by Adam Roben.
3460
3461         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
3462         https://bugs.webkit.org/show_bug.cgi?id=56541
3463
3464         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3465         (WTR::InjectedBundlePage::willSendRequestForFrame):
3466         Check for an empty host in addition to a null host.  This bug was introduced
3467         when porting off of the KURL code and onto the WKURLRef version.
3468
3469 2011-03-16  Sam Weinig  <sam@webkit.org>
3470
3471         Reviewed by Adam Roben.
3472
3473         Add Lucas Forschler to the list of WebKit committers.
3474
3475         * Scripts/webkitpy/common/config/committers.py:
3476
3477 2011-03-16  Sam Weinig  <sam@webkit.org>
3478
3479         Reviewed upon and dictated through Adam Roben.
3480
3481         Escape crashing function names in results.html. This fixes an issue
3482         when a crash involves a type with templates.
3483
3484         * Scripts/old-run-webkit-tests:
3485
3486 2011-03-16  Daniel Sievers  <sievers@google.com>
3487
3488         Reviewed by James Robinson.
3489
3490         Add setting to always force compositing mode
3491         https://bugs.webkit.org/show_bug.cgi?id=56156
3492
3493         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3494         (main):
3495         * DumpRenderTree/chromium/TestShell.cpp:
3496         (TestShell::TestShell):
3497         (TestShell::resetWebSettings):
3498         * DumpRenderTree/chromium/TestShell.h:
3499         (TestShell::setForceCompositingMode):
3500         * DumpRenderTree/chromium/WebPreferences.cpp:
3501         (WebPreferences::reset):
3502         (WebPreferences::applyTo):
3503         * DumpRenderTree/chromium/WebPreferences.h:
3504
3505 2011-03-15  Hayato Ito  <hayato@chromium.org>
3506
3507         Reviewed by Ojan Vafai.
3508
3509         Ignore files that will be used by reftests in old-run-webkit-tests.
3510
3511         https://bugs.webkit.org/show_bug.cgi?id=55936
3512
3513         * Scripts/old-run-webkit-tests:
3514
3515 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
3516
3517         Reviewed by Adam Roben.
3518
3519         Function relativeScriptsDir doesn't return the correct relative
3520         Scripts directory.
3521
3522         * Scripts/webkitdirs.pm:
3523         (relativeScriptsDir): Ensure we use the directory that contains
3524         webkitdirs.pm, not the one that contains the original script that
3525         was invoked.
3526
3527 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
3528
3529         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
3530         fix to link against the Security framework after recent WebKitSystemInterface changes.
3531
3532         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3533         (LayoutTestController::originsWithLocalStorage):
3534         * wx/build/settings.py:
3535         * wx/build/waf_extensions.py:
3536
3537 2011-03-15  Sam Weinig  <sam@webkit.org>
3538
3539         Reviewed by Darin Adler.
3540
3541         Add script to convert a patch to a prettypatch and show in the default browser
3542         https://bugs.webkit.org/show_bug.cgi?id=56416
3543
3544         This can be used either like
3545             $ svn-create-patch | show-pretty-diff
3546         or
3547             $ show-pretty-diff patch.diff
3548
3549         * Scripts/show-pretty-diff: Added.
3550
3551 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
3552
3553         Rubber-stamped by Adam Roben.
3554
3555         Adding myself as a reviewer.
3556
3557         * Scripts/webkitpy/common/config/committers.py:
3558
3559 2011-03-15  Anders Carlsson  <andersca@apple.com>
3560
3561         Try to fix the Windows build.
3562
3563         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
3564         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3565
3566 2011-03-15  Anders Carlsson  <andersca@apple.com>
3567
3568         Reviewed by Sam Weinig.
3569
3570         Make sure that NP_Shutdown is always the last NPP function called
3571         https://bugs.webkit.org/show_bug.cgi?id=56391
3572
3573         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
3574
3575         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3576         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3577         (PluginTest::PluginTest):
3578         (PluginTest::NP_Shutdown):
3579         (PluginTest::registerNPShutdownFunction):
3580         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3581         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
3582         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
3583         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3584         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
3585         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
3586         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
3587         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
3588         (NPDeallocateCalledBeforeNPShutdown::shutdown):
3589         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3590         (NP_Shutdown):
3591         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3592         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3593         * GNUmakefile.am:
3594
3595 2011-03-15  Ilya Sherman  <isherman@chromium.org>
3596
3597         Reviewed by Tony Chang.
3598
3599         Autofilled form elements are assigned fixed background color but not text color
3600         https://bugs.webkit.org/show_bug.cgi?id=48382
3601
3602         * DumpRenderTree/LayoutTestController.cpp:
3603         (setAutofilledCallback): Added.
3604         (LayoutTestController::staticFunctions):
3605         * DumpRenderTree/LayoutTestController.h:
3606         * DumpRenderTree/chromium/LayoutTestController.cpp:
3607         (LayoutTestController::LayoutTestController):
3608         (LayoutTestController::setAutofilled): Added.
3609         * DumpRenderTree/chromium/LayoutTestController.h:
3610         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3611         (LayoutTestController::setAutofilled): Added.
3612         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3613         (LayoutTestController::setAutofilled): Added.
3614         (LayoutTestController::setValueForUser): Style tweak.
3615         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3616         (LayoutTestController::setAutofilled): Added (stub).
3617         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3618         (LayoutTestController::setAutofilled): Added (stub).
3619
3620 2011-03-15  Dan Bernstein  <mitz@apple.com>
3621
3622         Build fix after r81135.
3623
3624         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3625
3626 2011-03-15  Dan Bernstein  <mitz@apple.com>
3627
3628         Build fix after r81135.
3629
3630         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3631         * WebKitTestRunner/mac/TestControllerMac.mm:
3632         * WebKitTestRunner/mac/TestInvocationMac.mm:
3633         * WebKitTestRunner/mac/main.mm:
3634
3635 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
3636
3637         Reviewed by Adam Barth.
3638
3639         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
3640         https://bugs.webkit.org/show_bug.cgi?id=56349
3641
3642         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
3643         on platforms where we use it. Copied from DumpRenderTree.pro.
3644
3645 2011-03-15  Dan Bernstein  <mitz@apple.com>
3646
3647         Build fix after r81135.
3648
3649         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3650         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
3651
3652 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
3653
3654         Reviewed by Darin Adler.
3655
3656         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
3657         info into the headers rather than in export symbol definition files, but disable it on
3658         all platforms initially so we can deal with port build issues one port at a time.
3659
3660         https://bugs.webkit.org/show_bug.cgi?id=27551
3661
3662         * DumpRenderTree/cg/ImageDiffCG.cpp:
3663         * DumpRenderTree/chromium/config.h:
3664         * DumpRenderTree/config.h:
3665         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3666         * TestWebKitAPI/TestWebKitAPIPrefix.h:
3667         * WebKitAPITest/HostWindow.cpp:
3668         * WebKitAPITest/TestsController.cpp:
3669         * WebKitAPITest/config.h: Added.
3670         * WebKitAPITest/main.cpp:
3671         * WebKitAPITest/tests/WebViewDestruction.cpp:
3672         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
3673         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3674         * WebKitTestRunner/InjectedBundle/GCController.cpp:
3675         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3676         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3677         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3678         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3679         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3680         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3681         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3682         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
3683         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
3684         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3685         * WebKitTestRunner/TestController.cpp:
3686         * WebKitTestRunner/TestInvocation.cpp:
3687         * WebKitTestRunner/config.h: Added.
3688         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3689         * WebKitTestRunner/qt/TestControllerQt.cpp:
3690         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3691         * WebKitTestRunner/qt/main.cpp:
3692         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3693         * WebKitTestRunner/win/TestControllerWin.cpp:
3694         * WebKitTestRunner/win/TestInvocationWin.cpp:
3695         * WebKitTestRunner/win/main.cpp:
3696         * wx/build/settings.py:
3697
3698 2011-03-15  Hayato Ito  <hayato@chromium.org>
3699
3700         Reviewed by Shinichiro Hamaji.
3701
3702         [NRWT] Add support for reftests to new-run-webkit-tests.
3703
3704         https://bugs.webkit.org/show_bug.cgi?id=55457
3705
3706         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3707         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3708         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3709         * Scripts/webkitpy/layout_tests/port/base.py:
3710         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3711         * Scripts/webkitpy/layout_tests/port/test.py:
3712         * Scripts/webkitpy/layout_tests/port/test_files.py:
3713         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3714
3715 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
3716
3717         Reviewed by Martin Robinson.
3718
3719         [GTK] Fix compilation warning after r80892
3720         https://bugs.webkit.org/show_bug.cgi?id=56302
3721
3722         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3723         (LayoutTestController::originsWithLocalStorage):
3724
3725 2011-03-15  Robert Hogan  <robert@webkit.org>
3726
3727         Reviewed by Adam Barth.
3728
3729         Document the qmakearg argument, and hint how to build webkit2 on Qt
3730         https://bugs.webkit.org/show_bug.cgi?id=56326
3731
3732         * Scripts/build-webkit: add --qmakearg to build-webkit --help
3733
3734 2011-03-15  Adam Roben  <aroben@apple.com>
3735
3736         Make Windows 7 Release (Tests) a core builder
3737
3738         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
3739         give it a few more days of greenness first.
3740
3741         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
3742
3743         Reviewed by Sam Weinig.
3744
3745         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3746         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
3747
3748         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3749         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
3750         Updated the core regexps to match the buildbot module. Updated the expected results to match
3751         the current set of core builders.
3752
3753 2011-03-14  Adam Roben  <aroben@apple.com>
3754
3755         Add forgotten file from r81116
3756
3757         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
3758
3759 2011-03-14  Sam Weinig  <sam@webkit.org>
3760
3761         Reviewed by Adam Roben.
3762
3763         about:blank fake responses don't get serialized when sent the UIProcess
3764         <rdar://problem/9108119>
3765         https://bugs.webkit.org/show_bug.cgi?id=56357
3766
3767         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
3768         (TestWebKitAPI::decidePolicyForResponse):
3769         (TestWebKitAPI::TEST):
3770         Add test that loads of about:blank have a response with a MIMEType of text/html.
3771
3772         * TestWebKitAPI/PlatformUtilities.h:
3773         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3774         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3775         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3776         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3777         Add helper to get the MIMEType from a WKURLResponse.
3778
3779         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3780         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3781         Add new files.
3782
3783 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3784
3785         Reviewed by Kenneth Rohde Christiansen.
3786
3787         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
3788         https://bugs.webkit.org/show_bug.cgi?id=56006
3789
3790         * QtTestBrowser/launcherwindow.cpp:
3791         (LauncherWindow::initializeView):
3792         * QtTestBrowser/main.cpp:
3793         (LauncherApplication::handleUserOptions):
3794
3795 2011-03-14  James Kozianski  <koz@chromium.org>
3796
3797         Reviewed by Ojan Vafai.
3798
3799         Add method to make BuildBot return test outputs
3800         https://bugs.webkit.org/show_bug.cgi?id=54374
3801
3802         The Builder.latest_cached_build will be used by the new rebaseline
3803         script to determine the build to use baselines from.
3804
3805         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3806         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3807
3808 2011-03-14  Adam Roben  <aroben@apple.com>
3809
3810         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
3811
3812         Reviewed by Sam Weinig.
3813
3814         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
3815         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
3816         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
3817         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
3818         ensure the web process is initialized, then ask the bundle to run the test and assert that
3819         it succeeded.
3820
3821         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
3822         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
3823         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
3824         handle a given URL.
3825         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
3826         URL type cannot be handled).
3827         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
3828         result.
3829
3830         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3831         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3832         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3833         Added new files to the project.
3834
3835 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3836
3837         Unreviewed, rolling out r81094.
3838         http://trac.webkit.org/changeset/81094
3839         https://bugs.webkit.org/show_bug.cgi?id=56355
3840
3841         Broke the chromium DRT related build. (Requested by dave_levin
3842         on #webkit).
3843
3844         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3845         (main):
3846         * DumpRenderTree/chromium/LayoutTestController.cpp:
3847         (LayoutTestController::LayoutTestController):
3848         (LayoutTestController::layerTreeAsText):
3849         * DumpRenderTree/chromium/LayoutTestController.h:
3850         * DumpRenderTree/chromium/TestShell.cpp:
3851         (TestShell::runFileTest):
3852         (TestShell::dump):
3853         * DumpRenderTree/chromium/TestShell.h:
3854         (TestParams::TestParams):
3855
3856 2011-03-14  Daniel Sievers  <sievers@google.com>
3857
3858         Reviewed by Simon Fraser.
3859
3860         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
3861         https://bugs.webkit.org/show_bug.cgi?id=56139
3862
3863         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3864         (main):
3865         * DumpRenderTree/chromium/LayoutTestController.cpp:
3866         (LayoutTestController::LayoutTestController):
3867         (LayoutTestController::layerTreeAsText):
3868         * DumpRenderTree/chromium/LayoutTestController.h:
3869         (LayoutTestController::setShowDebugLayerTree):
3870         * DumpRenderTree/chromium/TestShell.cpp:
3871         (TestShell::runFileTest):
3872         (TestShell::dump):
3873         * DumpRenderTree/chromium/TestShell.h:
3874         (TestParams::TestParams):
3875
3876 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
3877
3878         Reviewed by Adam Roben.
3879
3880         [Qt][WK2]Unbreak InjectedBundle on Qt
3881         https://bugs.webkit.org/show_bug.cgi?id=54109
3882
3883         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3884         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
3885         API's instead of KURL to analyze the URL.
3886         * WebKitTestRunner/StringFunctions.h:
3887         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
3888         in the WebKitTestRunner project.
3889         (WTR::toWK): Use adoptWK.
3890         (WTR::operator<<): Added helper for printing a WKURL.
3891         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
3892         against WebCore.
3893
3894 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
3895
3896         Reviewed by Kenneth Rohde Christiansen.
3897
3898         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
3899         https://bugs.webkit.org/show_bug.cgi?id=56321
3900
3901         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
3902         to the list of exceptions for WebKit2 C API headers.
3903
3904 2011-03-14  Adam Roben  <aroben@apple.com>
3905
3906         Show the list of recent leaky builds in reverse chronological order
3907
3908         Previously they were being shown in a deterministic but surprising order based on
3909         lexicographically sorting the build offsets (-1, -10, -2, -3...).
3910
3911         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
3912
3913         Reviewed by Darin Adler.
3914
3915         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3916         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
3917         callback.
3918
3919 2011-03-14  Adam Roben  <aroben@apple.com>
3920
3921         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
3922
3923         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
3924         analyze
3925
3926         Reviewed by David Kilzer and Joe Pecoraro.
3927
3928         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3929         (#url-prompt): Made this a bit taller to make room for the list of builds.
3930
3931         (#recent-builds-loading-indicator):
3932         (#recent-builds-list):
3933         Added styles for the build list and loading indicator.
3934
3935         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3936         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
3937         it. This will unescape it.
3938         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
3939         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
3940         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
3941         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
3942         prompt UI.
3943         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
3944         now also used when a recent build is clicked.
3945
3946         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
3947         (RecentBuildsLoader): Store the callback.
3948         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
3949         builder. Find the revision number, leak count, and results URL for each one. Pass the
3950         resulting info to our callback.
3951
3952         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
3953         (range): Added this helper function to return an array containing the integers [0, n).
3954
3955         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
3956         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
3957
3958 2011-03-14  Mark Rowe  <mrowe@apple.com>
3959
3960         Reviewed by Adam Roben.
3961
3962         Fix two memory leaks within LayoutTestController's storage support.
3963
3964         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3965         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
3966         by JSStringCreateWithCFString.
3967         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
3968         allocate.
3969
3970 2011-03-14  Mark Rowe  <mrowe@apple.com>
3971
3972         Reviewed by Oliver Hunt.
3973
3974         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
3975
3976         * DumpRenderTree/LayoutTestController.cpp:
3977         (LayoutTestController::staticFunctions): Remove duplicate entries.
3978
3979 2011-03-14  Alice Liu  <alice.liu@apple.com>
3980
3981         Reviewed by Dan Bernstein.
3982
3983         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
3984
3985         * DumpRenderTree/mac/PerlSupport/Makefile:
3986         Add whitespace when joining "-arch" with the architectures passed in as arguments.
3987
3988 2011-03-14  Daniel Bates  <dbates@rim.com>
3989
3990         https://bugs.webkit.org/show_bug.cgi?id=55438
3991         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
3992         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
3993
3994         * Scripts/build-webkit:
3995
3996 2011-03-14  Daniel Bates  <dbates@rim.com>
3997
3998         Reviewed by David Kilzer.
3999
4000         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
4001         https://bugs.webkit.org/show_bug.cgi?id=55438
4002
4003         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
4004         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
4005         CMake arguments for feature defines.
4006
4007         * Scripts/build-webkit:
4008           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
4009           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
4010           - Sorted forward declarations.
4011           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
4012             Modified call sites as needed.
4013         * Scripts/webkitdirs.pm:
4014           - Added cleanCMakeGeneratedProject() to clean a CMake build.
4015           - Added buildCMakeGeneratedProject() to build using generated build system.
4016           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
4017           - Added generateBuildSystemFromCMakeProject() to generate the build system from
4018             a CMake project.
4019           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
4020
4021 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
4022
4023         Reviewed by Steve Block.
4024
4025         Detach Geolocation from Frame when Page destroyed.
4026         https://bugs.webkit.org/show_bug.cgi?id=52877
4027
4028         Extend the layout test controller to expose the number of pending
4029         geolocation requests, so that we can test that the requests have
4030         been cancelled on page close.
4031
4032         * DumpRenderTree/LayoutTestController.cpp:
4033         (numberOfPendingGeolocationPermissionRequestsCallback):
4034         (LayoutTestController::staticFunctions):
4035         * DumpRenderTree/LayoutTestController.h:
4036         * DumpRenderTree/chromium/LayoutTestController.cpp:
4037         (LayoutTestController::LayoutTestController):
4038         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
4039         * DumpRenderTree/chromium/LayoutTestController.h:
4040         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4041         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
4042         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4043         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
4044         * DumpRenderTree/mac/UIDelegate.h:
4045         * DumpRenderTree/mac/UIDelegate.mm:
4046         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
4047         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4048         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
4049         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4050         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4051         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
4052         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4053         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
4054
4055
4056 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4057
4058         Unreviewed. Modify my email address in committers.py.
4059
4060         * Scripts/webkitpy/common/config/committers.py:
4061
4062 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
4063
4064         Reviewed by Kenneth Rohde Christiansen.
4065
4066         [Qt] QtLauncher does not load the same set of fonts as the DRT
4067         https://bugs.webkit.org/show_bug.cgi?id=34959
4068
4069         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
4070         When this option is used the webkit fonts are loaded the same
4071         as they are in DumpRenderTree.  This option can be used on
4072         QtTestBrowser and run-launcher.  It can only be used
4073         on Linux systems with FcInit and is configured as such.
4074
4075         * QtTestBrowser/launcherwindow.h:
4076         (WindowOptions::WindowOptions):
4077         * QtTestBrowser/main.cpp:
4078         (initWebKitTestFonts):
4079         (launcherMain):
4080         (LauncherApplication::handleUserOptions):
4081
4082 2011-03-12  Dan Bernstein  <mitz@apple.com>
4083
4084         Reviewed by Mark Rowe.
4085
4086         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
4087         DumpRenderTree is being built for.
4088
4089         * DumpRenderTree/mac/PerlSupport/Makefile:
4090
4091 2011-03-12  Dan Bernstein  <mitz@apple.com>
4092
4093         Suggested by Mark Rowe.
4094
4095         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
4096         as they were before r80915.
4097
4098 2011-03-12  Anders Carlsson  <andersca@apple.com>
4099
4100         Reviewed by Sam Weinig.
4101
4102         Should be able to download a PDF to the Downloads folder
4103         https://bugs.webkit.org/show_bug.cgi?id=56256
4104
4105         * MiniBrowser/mac/BrowserWindowController.m:
4106         (-[BrowserWindowController awakeFromNib]):
4107         * WebKitTestRunner/TestController.cpp:
4108         (WTR::TestController::createOtherPage):
4109         (WTR::TestController::initialize):
4110         Update for API changes.
4111
4112 2011-03-11  Anton D'Auria  <adauria@apple.com>
4113
4114         Reviewed and landed by Brady Eidson.
4115
4116         https://bugs.webkit.org/show_bug.cgi?id=51878
4117         Add WebKit1 API to view and delete local storage
4118
4119         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
4120
4121         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4122         * DumpRenderTree/LayoutTestController.cpp:
4123         (syncLocalStorageCallback):
4124         (observeStorageTrackerNotificationsCallback):
4125         (deleteAllLocalStorageCallback):
4126         (deleteLocalStorageForOriginCallback):
4127         (originsWithLocalStorageCallback):
4128         (LayoutTestController::staticFunctions):
4129         * DumpRenderTree/LayoutTestController.h:
4130         * DumpRenderTree/StorageTrackerDelegate.h: Added.
4131         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
4132         (-[StorageTrackerDelegate init]):
4133         (-[StorageTrackerDelegate logNotifications:controller:]):
4134         (-[StorageTrackerDelegate originModified:]):
4135         (-[StorageTrackerDelegate dealloc]):
4136         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
4137         * DumpRenderTree/chromium/LayoutTestController.cpp:
4138         (LayoutTestController::LayoutTestController):
4139         (LayoutTestController::deleteAllLocalStorage):
4140         (LayoutTestController::originsWithLocalStorage):
4141         (LayoutTestController::deleteLocalStorageForOrigin):
4142         (observeStorageTrackerNotifications):
4143         (syncLocalStorage):
4144         * DumpRenderTree/chromium/LayoutTestController.h:
4145         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4146         (LayoutTestController::originsWithLocalStorage):
4147         (LayoutTestController::deleteAllLocalStorage):
4148         (LayoutTestController::deleteLocalStorageForOrigin):
4149         (LayoutTestController::observeStorageTrackerNotifications):
4150         (LayoutTestController::syncLocalStorage):
4151         * DumpRenderTree/mac/DumpRenderTree.mm:
4152         (resetDefaultsToConsistentValues):
4153         (allocateGlobalControllers):
4154         (releaseGlobalControllers):
4155         * DumpRenderTree/mac/DumpRenderTreeMac.h:
4156         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4157         (LayoutTestController::syncLocalStorage):
4158         (LayoutTestController::observeStorageTrackerNotifications):
4159         (LayoutTestController::deleteAllLocalStorage):
4160         (LayoutTestController::originsWithLocalStorage):
4161         (LayoutTestController::deleteLocalStorageForOrigin):
4162         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4163         (LayoutTestController::originsWithLocalStorage):
4164         (LayoutTestController::deleteAllLocalStorage):
4165         (LayoutTestController::deleteLocalStorageForOrigin):
4166         (LayoutTestController::observeStorageTrackerNotifications):
4167         (LayoutTestController::syncLocalStorage):
4168         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4169         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4170         (LayoutTestController::clearAllApplicationCaches):
4171         (LayoutTestController::syncLocalStorage):
4172         (LayoutTestController::observeStorageTrackerNotifications):
4173         (LayoutTestController::clearAllDatabases):
4174         (LayoutTestController::deleteAllLocalStorage):
4175         (LayoutTestController::originsWithLocalStorage):
4176         (LayoutTestController::deleteLocalStorageForOrigin):
4177         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4178         (LayoutTestController::syncLocalStorage):
4179         (LayoutTestController::observeStorageTrackerNotifications):
4180         (LayoutTestController::clearAllDatabases):
4181         (LayoutTestController::deleteAllLocalStorage):
4182         (LayoutTestController::originsWithLocalStorage):
4183         (LayoutTestController::deleteLocalStorageForOrigin):
4184
4185 2011-03-11  Jessie Berlin  <jberlin@apple.com>
4186
4187         Reviewed by Adam Roben.
4188
4189         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
4190         Process has finished launching.
4191         https://bugs.webkit.org/show_bug.cgi?id=56208
4192
4193         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
4194         (TestWebKitAPI::TEST):
4195         Test that calling WKContextClearResourceCaches works with both options when called before
4196         the Web Process is valid.
4197
4198         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4199         Add the new test.
4200         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4201         Ditto.
4202
4203 2011-03-11  Adam Roben  <aroben@apple.com>
4204
4205         Make it possible to view all leaks from a build at once in Leaks Viewer
4206
4207         You can now give Leaks Viewer the URL of a build results page (e.g.,
4208         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
4209         will load all the leaks files from that build.
4210
4211         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
4212         files from a particular build at once, rather than one at a time
4213
4214         Reviewed by David Kilzer.
4215
4216         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
4217         (LeaksLoader): Initialize our properties.
4218         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
4219         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
4220         from that page.
4221         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
4222         so it can provide feedback. Then load each one and pass it to the client.
4223         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
4224         it into a DOM, pull out all the links to leaks files, and load each one.
4225
4226         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
4227         (LeaksParser): Initialize our worker.
4228         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
4229
4230         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
4231         This code mostly came from Worker.js.
4232         (LeaksParserWorker): Initialize our profile.
4233         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
4234         profile.
4235         (LeaksParserWorker.prototype._parseLeaks):
4236         (LeaksParserWorker.prototype._createNode):
4237         (LeaksParserWorker.prototype._incorporateLeaks):
4238         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
4239         version of createProfile which adds to this.profile instead of making a new profile each
4240         time.
4241         (onmessage): Parse the file and send back the new profile.
4242
4243         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
4244         (#loading-indicator):
4245         (#spinner):
4246         (#loading-indicator-label):
4247         Tweaked styles to accomodate a longer label.
4248
4249         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
4250         (LeaksViewer.loaded): Set up a loader and parser.
4251
4252         (LeaksViewer.get filesLeftToParse):
4253         (LeaksViewer.set filesLeftToParse):
4254         Added these simple accessors.
4255
4256         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
4257         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
4258         the parser.
4259         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
4260         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
4261         _loadLeaksFromURL function).
4262         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
4263         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
4264         loading indicator, including the number of files being loaded.
4265         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
4266         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
4267         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
4268         _loadingIndicatorText.
4269
4270         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
4271         (getResource): Moved here from LeaksViewer.js.
4272
4273         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
4274         LeaksParserWorker.js.
4275
4276         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
4277         files, added a #loading-indicator-label element, and tweaked the prompt wording.
4278
4279 2011-03-11  Adam Roben  <aroben@apple.com>
4280
4281         Don't trigger a build when build.webkit.org's HTML files are modified
4282
4283         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
4284
4285         Reviewed by Dan Bernstein.
4286
4287         * Scripts/webkitpy/common/config/build.py:
4288         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
4289         directories that shouldn't trigger builds. Re-sorted the list.
4290
4291         * Scripts/webkitpy/common/config/build_unittest.py:
4292         (ShouldBuildTest): Added a test to cover the above change.
4293
4294 2011-03-11  Adam Roben  <aroben@apple.com>
4295
4296         Roll out r80848
4297
4298         It was accidentally committed.
4299
4300         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
4301         (LeaksViewer._loadLeaksFromURL):
4302
4303 2011-03-11  Tony Chang  <tony@chromium.org>
4304
4305         Reviewed by Ojan Vafai.
4306
4307         kill hung lighttpd processes on the chromium win bot
4308         https://bugs.webkit.org/show_bug.cgi?id=56152
4309
4310         Sometimes this process doesn't exit and it holds on to
4311         a log file that we can't delete or copy, causing the tests
4312         to go red.
4313
4314         * BuildSlaveSupport/win/kill-old-processes:
4315
4316 2011-03-11  Ilya Sherman  <isherman@chromium.org>
4317
4318         Reviewed by Kent Tamura.
4319
4320         [Chromium] missing HTMLInputElement::setValueForUser() to tests
4321         https://bugs.webkit.org/show_bug.cgi?id=55854
4322
4323         * DumpRenderTree/chromium/LayoutTestController.cpp:
4324         (LayoutTestController::LayoutTestController):
4325         (LayoutTestController::setValueForUser): Added.
4326         * DumpRenderTree/chromium/LayoutTestController.h: