[iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavig...
[WebKit-https.git] / Tools / ChangeLog
1 2015-09-18  Andy Estes  <aestes@apple.com>
2
3         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
4         https://bugs.webkit.org/show_bug.cgi?id=149360
5
6         Reviewed by Tim Horton.
7
8         Added an API test.
9
10         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
12         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
13         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
14         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
15         (TEST):
16         * TestWebKitAPI/ios/pages.pages: Added.
17
18 2015-09-18  Nan Wang  <n_wang@apple.com>
19
20         AX: Implement ARIA 1.1 @aria-current on iOS
21         https://bugs.webkit.org/show_bug.cgi?id=149297
22
23         Reviewed by Chris Fleizach.
24
25         Added support to test aria-current on iOS.
26
27         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
28         (AccessibilityUIElement::stringAttributeValue):
29         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
30         (WTR::AccessibilityUIElement::stringAttributeValue):
31
32 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
33
34         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
35         https://bugs.webkit.org/show_bug.cgi?id=149352
36
37         Reviewed by Simon Fraser.
38
39         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
40         m_context can be null. This may indicate a bug in webkitpy too, but
41         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
42         wrong with opening and immediately closing it.
43
44 2015-09-18  Daniel Bates  <dabates@apple.com>
45
46         isGitSVNDirectory() returns true when Git is not installed
47         https://bugs.webkit.org/show_bug.cgi?id=149351
48
49         Reviewed by Alexey Proskuryakov.
50
51         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
52         Git is not installed on the machine.
53
54         * Scripts/VCSUtils.pm:
55         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
56         status code 0 (success).
57
58 2015-09-18  Alex Christensen  <achristensen@webkit.org>
59
60         Prevent build-webkit from building four times on Windows 
61         https://bugs.webkit.org/show_bug.cgi?id=149336
62
63         Reviewed by Brent Fulgham.
64
65         * Scripts/build-webkit:
66         Move the Windows code out of the for loop iterating over each subdirectory to be build.
67         They're built all at once.
68         * Scripts/webkitdirs.pm:
69         (buildVisualStudioProject):
70         (cmakeGeneratedBuildfile):
71         Don't generate the Visual Studio solution if it already exists.
72         It will run CMake again if necessary.
73
74 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
75
76         [iOS WK2] WTR fails to set the key window in the UIKit sense
77         https://bugs.webkit.org/show_bug.cgi?id=149325
78
79         Reviewed by Tim Horton.
80
81         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
82         This causes UIKit to bypass code that actually sets the key window, resulting in
83         [UIAppliation sharedApplication].keyWindow always being nil.
84
85         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
86         -[WebKitTestRunnerWindow isKeyWindow] call super.
87
88         * WebKitTestRunner/PlatformWebView.h:
89         (WTR::PlatformWebView::setWindowIsKey): Deleted.
90         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
91         (WTR::PlatformWebView::setWindowIsKey):
92         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
93         (WTR::PlatformWebView::setWindowIsKey):
94         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
95         (-[WebKitTestRunnerWindow isKeyWindow]):
96         (WTR::PlatformWebView::PlatformWebView):
97         (WTR::PlatformWebView::~PlatformWebView):
98         (WTR::PlatformWebView::setWindowIsKey):
99         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
100         (WTR::PlatformWebView::setWindowIsKey):
101
102 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
103
104         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
105         https://bugs.webkit.org/show_bug.cgi?id=149321
106
107         Reviewed by Tim Horton.
108         
109         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
110         enabled the "testing" viewport configuration, which disables page scaling.
111         
112         If we're running viewport tests, we want the normal web page configuration.
113         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
114         based on whether the test is in a "viewport" directory.
115
116         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
117         (WTR::InjectedBundle::beginTesting):
118         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
119         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
120         * WebKitTestRunner/TestInvocation.cpp:
121         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
122         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
123         (WTR::TestInvocation::shouldMakeViewportFlexible):
124         (WTR::TestInvocation::invoke):
125         * WebKitTestRunner/TestInvocation.h:
126         * WebKitTestRunner/ios/TestControllerIOS.mm:
127         (WTR::TestController::platformConfigureViewForTest):
128         (WTR::shouldMakeViewportFlexible): Deleted.
129
130 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
131
132         Give iOS WebKitTestRunner a launch storyboard
133         https://bugs.webkit.org/show_bug.cgi?id=149314
134
135         Reviewed by Dan Bates.
136         
137         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
138         that it's been built for specific device configurations, and puts the window
139         at the top of the screen. This simplifies coordinate conversions in a future patch.
140
141         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
142         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
143         * WebKitTestRunner/ios/Launch.storyboard: Added.
144
145 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
146
147         Update licence in r189890
148         https://bugs.webkit.org/show_bug.cgi?id=149306
149
150         Reviewed by Dean Jackson.
151
152         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
153         * FontWithFeatures/FontWithFeatures/FontCreator.h:
154         * FontWithFeatures/FontWithFeatures/main.cpp:
155
156 2015-09-17  Mark Lam  <mark.lam@apple.com>
157
158         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
159         https://bugs.webkit.org/show_bug.cgi?id=149285
160
161         Reviewed by Saam Barati.
162
163         Just need to add an option to pass --no-jit to run-jsc-stress-test.
164
165         * Scripts/run-javascriptcore-tests:
166         (runJSCStressTests):
167
168 2015-09-17  Alex Christensen  <achristensen@webkit.org>
169
170         Switch AppleWin build to use CMake
171         https://bugs.webkit.org/show_bug.cgi?id=149163
172
173         Reviewed by Brent Fulgham.
174
175         * Scripts/build-webkit:
176         * Scripts/run-api-tests:
177         (runTest):
178         (listAllTests):
179         (prepareEnvironmentForRunningTestTool):
180         (testToolPaths):
181         (testToolPath): Deleted.
182         Run the API tests as separate executables on Windows.
183         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
184         * Scripts/webkitdirs.pm:
185         (checkRequiredSystemConfig):
186         (jhbuildWrapperPrefixIfNeeded):
187         (generateBuildSystemFromCMakeProject):
188         Fix configuration quirks.
189
190 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
191
192         Added toggle options for hiding and showing certain platform families on the dashboard.
193         https://bugs.webkit.org/show_bug.cgi?id=148403
194
195         Reviewed by David Kilzer.
196
197         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
198         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
199         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
200         in lieu of an "all" button in the toggle menu.
201
202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
203         (parsePlatformFamily): Helper function to parse out a platform family.
204         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
205         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
206         (updateToggleButtons): Updates the status of the toggle buttons.
207         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
208         (documentReady): Added creation of toggle buttons.
209         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
210         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
211         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
212         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
213         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
215         (QueueView): Updated to use hiddenPlatformFamilies.
216         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
218         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
219         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
220         (Settings.prototype.toggleHiddenPlatform): Deleted.
221         (Settings.prototype.clearHiddenPlatforms): Deleted.
222         (Settings.prototype.toggleShowPlatformFamily): Deleted.
223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
224         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
225         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
226         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
227         (table.queue-grid tr.headers th):
228         (div.settingsWrapper.hide):
229         (div.settingsWrapper):
230         (div.familyToggleWrapper):
231         (div.platformFamilyToggleButton):
232         (div.platformFamilyShowToggleButton:not(:last-child)):
233         (div.familyShown):
234         (div.accessibilityButton):
235         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
236         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
237         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
238         platformFamilyToggleButton and settingsWrapper class.
239         (.accessibilityButton): Deleted.
240
241 2015-09-17  Tim Horton  <timothy_horton@apple.com>
242
243         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
244         https://bugs.webkit.org/show_bug.cgi?id=148904
245
246         Reviewed by Myles Maxfield.
247
248         * WebKitTestRunner/TestController.cpp:
249         (WTR::parseBooleanTestHeaderValue):
250         (WTR::updateViewOptionsFromTestHeader):
251         Check for the key "useThreadedScrolling".
252         Add some code to check for "true" and "false" for boolean options.
253
254         (WTR::TestController::viewOptionsForTest):
255         Apply the test's overrides last, even after the platform's.
256
257 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
258
259         printing does not use minimum page zoom factor
260         https://bugs.webkit.org/show_bug.cgi?id=108507
261
262         Reviewed by Darin Adler.
263
264         WebKitTestRunner always takes the snapshots from the UI process
265         (expect for IOS), so in the case of printing, the layout in the
266         web view is not the expected one. When printing, we need to take
267         the snapshot in the web process and ensure it's rendered with a
268         PrintContext.
269
270         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
271         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
272         kWKSnapshotOptionsPrinting option to
273         WKBundlePageCreateSnapshotWithOptions() when printing. When not
274         printing, don't even create the snapshot, since it will be ignored
275         by the UI process that always creates its own from the WebView (expect for IOS platform)
276         * WebKitTestRunner/TestInvocation.cpp:
277         (WTR::TestInvocation::dumpResults): Use always the snapshot image
278         received from the web process if any when comparing pixel
279         results. Now we only receive a snapshot from the web process in
280         case of printing, or when platform is IOS. Otherwhise, generate
281         the snapshot from the WebView as usual.
282         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
283         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
284         is created by the caller now, but the CG implementation needs to
285         know if it's a Web or UI process snapshot.
286         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
287         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
288         cairo surface for the given image.
289         * WebKitTestRunner/cg/TestInvocationCG.cpp:
290         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
291         CGContext for the given image.
292
293 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
294
295         Create a font which can be used for testing font features
296         https://bugs.webkit.org/show_bug.cgi?id=149237
297
298         Reviewed by Simon Fraser.
299
300         This patch adds a new project in the Tools/ directory which generates a font which can
301         be used for testing font features. This is a standalone project consisting of two files:
302         1. A file which actually generates the byte vector representing the font. This file has
303         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
304         specific, and only relies on the C++ STL.
305         2. A file with a main() which calls generateFont() and writes out the font, as well as
306         uses the font to render some demonstration text into a .png file. This file is platform
307         specific.
308
309         The font itself only supports the following characters:
310         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
311         However, the shape of these letters are either an X or a check mark.
312
313         The letter "A" always is a check mark.
314         The letter "B" always is an X.
315         Without any font features turned on, the rest of the letters are shown as X.
316
317         Each font feature has an letter associated with it. When the font feature is enabled,
318         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
319         as a check mark.
320
321         Here are the mappings of font features to letters:
322         liga: C
323         clig: D
324         dlig: E
325         hlig: F
326         calt: G
327         subs: H
328         sups: I
329         smcp: J
330         c2sc: K
331         pcap: L
332         c2pc: M
333         unic: N
334         titl: O
335         onum: P
336         pnum: Q
337         tnum: R
338         frac: S
339         afrc: T
340         ordn: U
341         zero: V
342         hist: W
343         jp78: X
344         jp83: Y
345         jp90: Z
346         jp04: a
347         smpl: b
348         trad: c
349         fwid: d
350         pwid: e
351         ruby: f
352
353         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
354         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
355         (integralLog2):
356         (roundDownToPowerOfTwo):
357         (isFourByteAligned):
358         (clampTo):
359         (append32):
360         (writeCFFEncodedNumber):
361         (CFFBuilder::CFFBuilder):
362         (CFFBuilder::takeResult):
363         (CFFBuilder::moveTo):
364         (CFFBuilder::lineTo):
365         (CFFBuilder::curveToCubic):
366         (CFFBuilder::closePath):
367         (CFFBuilder::writePoint):
368         (generateBoxCharString):
369         (generateCheckCharString):
370         (generateXCharString):
371         (charStringForGlyph):
372         (Generator::generate):
373         (Generator::Placeholder::Placeholder):
374         (Generator::Placeholder::populate):
375         (Generator::Placeholder::~Placeholder):
376         (Generator::placeholder):
377         (Generator::append16):
378         (Generator::append32):
379         (Generator::append32BitCode):
380         (Generator::overwrite16):
381         (Generator::overwrite32):
382         (Generator::appendCFFTable):
383         (Generator::appendSubstitutionSubtable):
384         (Generator::appendScriptSubtable):
385         (Generator::appendGSUBTable):
386         (Generator::appendOS2Table):
387         (Generator::appendFormat12CMAPTable):
388         (Generator::appendFormat4CMAPTable):
389         (Generator::appendCMAPTable):
390         (Generator::appendHEADTable):
391         (Generator::appendHHEATable):
392         (Generator::appendHMTXTable):
393         (Generator::appendMAXPTable):
394         (Generator::appendNAMETable):
395         (Generator::appendPOSTTable):
396         (Generator::calculateChecksum):
397         (Generator::appendTable):
398         (generateFont):
399         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
400         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
401         (drawTextWithFeature):
402         (main):
403
404 2015-09-16  Commit Queue  <commit-queue@webkit.org>
405
406         Unreviewed, rolling out r189875 and r189878.
407         https://bugs.webkit.org/show_bug.cgi?id=149235
408
409         cygwin cmake build not ready yet (Requested by alexchristensen
410         on #webkit).
411
412         Reverted changesets:
413
414         "Switch AppleWin build to use CMake"
415         https://bugs.webkit.org/show_bug.cgi?id=149163
416         http://trac.webkit.org/changeset/189875
417
418         "Cygwin build fix after r189875"
419         http://trac.webkit.org/changeset/189878
420
421 2015-09-16  Alex Christensen  <achristensen@webkit.org>
422
423         Cygwin build fix after r189875
424
425         * Scripts/build-webkit:
426         * Scripts/webkitdirs.pm:
427         (jhbuildWrapperPrefixIfNeeded):
428         (generateBuildSystemFromCMakeProject):
429         Make things work with cygwin and cmake.
430
431 2015-09-16  Alex Christensen  <achristensen@webkit.org>
432
433         Switch AppleWin build to use CMake
434         https://bugs.webkit.org/show_bug.cgi?id=149163
435
436         Reviewed by Brent Fulgham.
437
438         * Scripts/build-webkit:
439         Build with CMake.
440         * Scripts/run-api-tests:
441         (runTest):
442         (listAllTests):
443         (prepareEnvironmentForRunningTestTool):
444         (testToolPaths):
445         (testToolPath): Deleted.
446         Run the API tests as separate executables on Windows.
447         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
448
449 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
450
451         Add newer build.webkit.org pages to robots.txt
452         https://bugs.webkit.org/show_bug.cgi?id=149219
453
454         Reviewed by Darin Adler.
455
456         Indexing bot watcher's dashboard can't be good.
457
458         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
459
460 2015-09-16  Alex Christensen  <achristensen@webkit.org>
461
462         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
463
464         * BuildSlaveSupport/built-product-archive:
465         (unzipArchive):
466
467 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
468
469         [EFL] Fix the help message of separated web process option of MiniBrowser
470         https://bugs.webkit.org/show_bug.cgi?id=149212
471
472         Reviewed by Gyuyoung Kim.
473
474         * MiniBrowser/efl/main.c:
475
476 2015-09-16  Alex Christensen  <achristensen@webkit.org>
477
478         Fix python syntax after r189851.
479
480         * BuildSlaveSupport/built-product-archive:
481         (unzipArchive):
482         For loops need a colon.
483
484 2015-09-15  Alex Christensen  <achristensen@webkit.org>
485
486         Fix Windows test bots after changing to non-cygwin build
487         https://bugs.webkit.org/show_bug.cgi?id=149196
488
489         Reviewed by Daniel Bates.
490
491         * BuildSlaveSupport/built-product-archive:
492         (unzipArchive):
493         Using different versions of python makes what I think is https://bugs.python.org/issue15795
494         prevent us from executing files from the archive on the test bots.
495
496 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
497
498         Add ShadowRoot interface and Element.prototype.attachShadow
499         https://bugs.webkit.org/show_bug.cgi?id=149187
500
501         Reviewed by Antti Koivisto.
502
503         * Scripts/webkitperl/FeatureList.pm:
504
505 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
506
507         Appscale queue status json output lacks bots
508         https://bugs.webkit.org/show_bug.cgi?id=149194
509         <rdar://problem/22171089>
510
511         Reviewed by Alexey Proskuryakov.
512
513         * QueueStatusServer/handlers/queuestatusjson.py:
514         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
515         * QueueStatusServer/index.yaml: Index according to appscale requirements.
516
517 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
518
519         [Win] Provide a means for viewing the layer tree
520         https://bugs.webkit.org/show_bug.cgi?id=149165
521
522         Reviewed by Simon Fraser.
523
524         Update MiniBrowser with a new Debug menu option that will
525         dump the current layer tree to the debug console.
526         
527         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
528         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
529         * MiniBrowser/win/Common.cpp:
530         (WndProc): Add handler for 'Print Layer Tree' menu option.
531         * MiniBrowser/win/MiniBrowser.cpp:
532         (MiniBrowser::printLayerTree): Added Handler.
533         * MiniBrowser/win/MiniBrowser.h:
534
535 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
536
537         WebKitTestRunner declarative language setting is broken for iOS
538         https://bugs.webkit.org/show_bug.cgi?id=149119
539
540         Unreviewed.
541
542         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
543         lost in the final version which got committed. This simply implements the existing
544         OS X behavior on iOS.
545
546         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
547         (WTR::InjectedBundle::platformInitialize):
548
549 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
550
551         Unreviewed, add myself to committers list.
552
553         * Scripts/webkitpy/common/config/contributors.json:
554
555 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
556
557         [Cocoa] Allow testing with the system language
558         https://bugs.webkit.org/show_bug.cgi?id=148671
559
560         Reviewed by Anders Carlsson and Alexey Proskuryakov.
561
562         React to tests marked with language=lang1,lang2,etc in their header.
563         Once this information is parsed, pass it to
564         WKContextConfigurationSetOverrideLanguages().
565
566         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
567         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
568         list.
569         * WebKitTestRunner/TestController.cpp:
570         (WTR::TestController::createWebViewWithOptions): Call
571         WKContextConfigurationSetOverrideLanguages().
572         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
573         * WebKitTestRunner/TestOptions.h:
574         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
575         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
576         option to restart the web process.
577         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
578         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
579
580 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
581
582         [WKTR] Allow changing the WKContextConfiguration between successive tests
583         https://bugs.webkit.org/show_bug.cgi?id=148833
584
585         Reviewed by Tim Horton.
586
587         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
588         However, there are certain tests which require specifying options in this object. This patch makes
589         our existing code for recreating the test runner web view also recreate the WKContext.
590
591         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
592         class.
593
594         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
595         * WebKitTestRunner/PlatformWebView.h:
596         (WTR::PlatformWebView::options):
597         * WebKitTestRunner/TestController.cpp:
598         (WTR::TestController::initialize):
599         (WTR::TestController::generateContextConfiguration):
600         (WTR::TestController::generatePageConfiguration):
601         (WTR::TestController::createWebViewWithOptions):
602         (WTR::TestController::ensureViewSupportsOptionsForTest):
603         (WTR::updateContextConfigurationOptionsFromTestHeader):
604         (WTR::TestController::contextConfigurationOptionsForTest):
605         (WTR::TestController::platformCreateWebView):
606         (WTR::TestController::platformCreateOtherPage):
607         (WTR::updateViewOptionsFromTestHeader): Deleted.
608         (WTR::TestController::viewOptionsForTest): Deleted.
609         * WebKitTestRunner/TestController.h:
610         (WTR::TestController::injectedBundlePath):
611         (WTR::TestController::testPluginDirectory):
612         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
613         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
614         (WTR::TestController::platformCreateWebView):
615         (WTR::TestController::platformCreateOtherPage):
616         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
617         (WTR::PlatformWebView::PlatformWebView):
618         (WTR::PlatformWebView::viewSupportsOptions):
619         * WebKitTestRunner/efl/TestControllerEfl.cpp:
620         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
621         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
622         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
623         (WTR::PlatformWebView::PlatformWebView):
624         (WTR::PlatformWebView::viewSupportsOptions):
625         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
626         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
627         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
628         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
629         (WTR::PlatformWebView::PlatformWebView):
630         (WTR::PlatformWebView::viewSupportsOptions):
631         * WebKitTestRunner/ios/TestControllerIOS.mm:
632         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
633         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
634         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
635         (WTR::PlatformWebView::PlatformWebView):
636         (WTR::PlatformWebView::viewSupportsOptions):
637         * WebKitTestRunner/mac/TestControllerMac.mm:
638         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
639         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
640
641 2015-09-11  Michael Saboff  <msaboff@apple.com>
642
643         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
644         https://bugs.webkit.org/show_bug.cgi?id=149083
645
646         Reviewed by Alexey Proskuryakov.
647
648         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
649
650         * DumpRenderTree/mac/LayoutTestHelper.m:
651         (colorProfileURLForDisplay):
652
653 2015-09-11  Saam barati  <sbarati@apple.com>
654
655         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
656         https://bugs.webkit.org/show_bug.cgi?id=149058
657
658         Reviewed by Geoffrey Garen.
659
660         * Scripts/run-jsc-stress-tests:
661
662 2015-09-10  Commit Queue  <commit-queue@webkit.org>
663
664         Unreviewed, rolling out r189595.
665         https://bugs.webkit.org/show_bug.cgi?id=149052
666
667         The tests still fail (Requested by ap on #webkit).
668
669         Reverted changeset:
670
671         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
672         error -1"
673         https://bugs.webkit.org/show_bug.cgi?id=142929
674         http://trac.webkit.org/changeset/189595
675
676 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
677
678         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
679         https://bugs.webkit.org/show_bug.cgi?id=142929
680
681         Reviewed by Brent Fulgham.
682
683         Silence the logging. We'll track fixing the root cause in Radar.
684
685         * Scripts/webkitpy/port/mac.py:
686         (MacPort.stderr_patterns_to_strip): Added a FIXME.
687
688         * Scripts/webkitpy/port/win.py:
689         (WinPort.logging_patterns_to_strip): Added.
690
691 2015-09-09  Andy Estes  <aestes@apple.com>
692
693         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
694         https://bugs.webkit.org/show_bug.cgi?id=149022
695
696         Reviewed by Daniel Bates.
697
698         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
699         did not account for this.
700
701         * Scripts/webkitpy/xcode/simulator.py:
702         (Simulator): Optionally matched a revision at the end of a runtime version number.
703         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
704
705 2015-09-09  Andy Estes  <aestes@apple.com>
706
707         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
708         https://bugs.webkit.org/show_bug.cgi?id=149029
709         <rdar://problem/22432624>
710
711         Reviewed by Daniel Bates.
712
713         * Scripts/webkitpy/xcode/simulator.py:
714         (Simulator): Taught to parse tvOS runtimes.
715         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
716
717 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
718
719         Fix bit rot on bot watcher's dashboard page
720         https://bugs.webkit.org/show_bug.cgi?id=149012
721
722         Reviewed by Tim Horton.
723
724         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
725         The code path used by the metrics page was trying to add properties to an undefined.
726
727         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
728         Silence an expection that would occur when the step has no logs. This should never
729         happen, but it did (perhaps buildbot was misconfigured for a while).
730
731 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
732
733         Update LayoutTestRelay xcconfig file.
734
735         Rubber-stamped by Dan Bernstein.
736
737         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
738
739 2015-09-09  Saam barati  <sbarati@apple.com>
740
741         DFG should have a debugging option that runs a phase that flushes all locals
742         https://bugs.webkit.org/show_bug.cgi?id=148916
743
744         Reviewed by Filip Pizlo.
745
746         * Scripts/run-jsc-stress-tests:
747
748 2015-09-09  Commit Queue  <commit-queue@webkit.org>
749
750         Unreviewed, rolling out r189530 and r189534.
751         https://bugs.webkit.org/show_bug.cgi?id=148996
752
753         Caused assertion failures on Yosemite (Requested by litherum
754         on #webkit).
755
756         Reverted changesets:
757
758         "[WKTR] Allow changing the WKContextConfiguration between
759         successive tests"
760         https://bugs.webkit.org/show_bug.cgi?id=148833
761         http://trac.webkit.org/changeset/189530
762
763         "[Cocoa] Fix the tests after r189530"
764         http://trac.webkit.org/changeset/189534
765
766 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
767
768         [Cocoa] Fix the tests after r189530
769
770         Unreviewed.
771
772         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
773         (WTR::initializeWebViewConfiguration):
774
775 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
776
777         [WKTR] Allow changing the WKContextConfiguration between successive tests
778         https://bugs.webkit.org/show_bug.cgi?id=148833
779
780         Reviewed by Tim Horton.
781
782         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
783         However, there are certain tests which require specifying options in this object. This patch makes
784         our existing code for recreating the test runner web view also recreate the WKContext.
785
786         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
787         class.
788
789         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
790         * WebKitTestRunner/PlatformWebView.h:
791         (WTR::PlatformWebView::options):
792         * WebKitTestRunner/TestController.cpp:
793         (WTR::TestController::initialize):
794         (WTR::TestController::generateContextConfiguration):
795         (WTR::TestController::generatePageConfiguration):
796         (WTR::TestController::createWebViewWithOptions):
797         (WTR::TestController::ensureViewSupportsOptionsForTest):
798         (WTR::updateContextConfigurationOptionsFromTestHeader):
799         (WTR::TestController::contextConfigurationOptionsForTest):
800         (WTR::TestController::platformCreateWebView):
801         (WTR::TestController::platformCreateOtherPage):
802         (WTR::updateViewOptionsFromTestHeader): Deleted.
803         (WTR::TestController::viewOptionsForTest): Deleted.
804         * WebKitTestRunner/TestController.h:
805         (WTR::TestController::injectedBundlePath):
806         (WTR::TestController::testPluginDirectory):
807         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
808         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
809         (WTR::TestController::platformCreateWebView):
810         (WTR::TestController::platformCreateOtherPage):
811         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
812         (WTR::PlatformWebView::PlatformWebView):
813         (WTR::PlatformWebView::viewSupportsOptions):
814         * WebKitTestRunner/efl/TestControllerEfl.cpp:
815         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
816         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
817         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
818         (WTR::PlatformWebView::PlatformWebView):
819         (WTR::PlatformWebView::viewSupportsOptions):
820         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
821         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
822         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
823         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
824         (WTR::PlatformWebView::PlatformWebView):
825         (WTR::PlatformWebView::viewSupportsOptions):
826         * WebKitTestRunner/ios/TestControllerIOS.mm:
827         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
828         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
829         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
830         (WTR::PlatformWebView::PlatformWebView):
831         (WTR::PlatformWebView::viewSupportsOptions):
832         * WebKitTestRunner/mac/TestControllerMac.mm:
833         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
834         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
835
836 2015-09-08  Daniel Bates  <dabates@apple.com>
837
838         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
839         https://bugs.webkit.org/show_bug.cgi?id=148980
840
841         Reviewed by Alexey Proskuryakov.
842
843         Add setting to enable/disable accelerated drawing so as to support testing
844         this feature in MiniBrowser on Mac.
845
846         * MiniBrowser/mac/SettingsController.h:
847         * MiniBrowser/mac/SettingsController.m:
848         (-[SettingsController _populateMenu]): Add menu item.
849         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
850         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
851         (-[SettingsController acceleratedDrawingEnabled]): Added.
852         * MiniBrowser/mac/WK1BrowserWindowController.m:
853         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
854         * MiniBrowser/mac/WK2BrowserWindowController.m:
855         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
856
857 2015-09-08  Jason Marcell  <jmarcell@apple.com>
858
859         Unreviewed. Added myself as a commiter in contributors.json.
860
861         * Scripts/webkitpy/common/config/contributors.json:
862
863 2015-09-08  Keith Miller  <keith_miller@apple.com>
864
865         Unreviewed, added myself to the list of contributors.
866
867         * Scripts/webkitpy/common/config/contributors.json:
868
869 2015-09-08  Daniel Bates  <dabates@apple.com>
870
871         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
872         https://bugs.webkit.org/show_bug.cgi?id=148921
873
874         Reviewed by Alexey Proskuryakov.
875
876         The ring image is positioned above the platform icon in markup and we specify the CSS
877         property z-index for the ring image so that it is painted on top of the platform icon
878         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
879         of the ring image, switch the order of these DOM elements and remove the use of the CSS
880         property z-index to achieve a similar effect.
881
882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
883         (documentReady): Create the platform icon image element before the ring image such that
884         the ring image is painted on top of the platform icon.
885         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
886         (table.queue-grid td.logo img.ring): Removed property z-index.
887
888 2015-09-08  Daniel Bates  <dabates@apple.com>
889
890         Dashboard: Remove duplicate gear icon data URLs
891         https://bugs.webkit.org/show_bug.cgi?id=148920
892
893         Reviewed by Alexey Proskuryakov.
894
895         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
896         background-image associated with each of the three gear icon states: collapsed (.settings), hover
897         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
898         as a mask and make use of the CSS background-color to define the fill color for each of these three
899         states.
900
901         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
902         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
903         (.settings:hover): Override CSS background-color for hover state.
904         (.settings-visible .settings): Override CSS background-color for expanded state.
905
906 2015-09-07  Andy Estes  <aestes@apple.com>
907
908         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
909         https://bugs.webkit.org/show_bug.cgi?id=148946
910         <rdar://problem/22603981>
911
912         Reviewed by Dan Bernstein.
913
914         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
915         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
916
917 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
918
919         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
920         https://bugs.webkit.org/show_bug.cgi?id=148927
921
922         Reviewed by Csaba Osztrogonác.
923
924         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
925         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
926
927         * WebKitTestRunner/TestController.cpp:
928         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
929         * WebKitTestRunner/efl/TestControllerEfl.cpp:
930         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
931
932 2015-09-07  Andy Estes  <aestes@apple.com>
933
934         Fix the Production build after r189455.
935
936         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
937         In-App Purchase template instead of the Aggregate template. Whoops.
938
939 2015-09-06  Andy Estes  <aestes@apple.com>
940
941         WebKit.xcworkspace should be be able to build iOS platforms
942         https://bugs.webkit.org/show_bug.cgi?id=148881
943
944         Reviewed by Daniel Bates.
945
946         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
947         for all supported platforms.
948
949         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
950         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
951         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
952         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
953
954 2015-09-06  Andy Estes  <aestes@apple.com>
955
956         WebKitTestRunner should build for iOS using the default target
957         https://bugs.webkit.org/show_bug.cgi?id=148918
958
959         Reviewed by Daniel Bates.
960
961         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
962         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
963         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
964
965         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
966         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
967         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
968         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
969         WebKitTestRunner is skipped when installing on iOS.
970
971         The target dependency graph now looks like this:
972
973             All
974                 WebKitTestRunnerApp
975                     WebKitTestRunner (Library)
976                         WebKitTestRunnerInjectedBundle
977                             Derived Sources
978                 WebKitTestRunner
979                     WebKitTestRunner (Library)
980                         WebKitTestRunnerInjectedBundle
981                             Derived Sources
982
983         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
984         * Scripts/build-webkittestrunner: Ditto.
985         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
986         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
987         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
988         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
989         excluded iOS-only files, and skipped installing on iOS.
990         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
991         excluded Mac-only files, and skipped installing on Mac.
992         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
993         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
994         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
995         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
996         new configuration files.
997
998 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
999
1000         Web Inspector: Improve prepare-ChangeLog for multiple cases
1001         https://bugs.webkit.org/show_bug.cgi?id=148875
1002
1003         Reviewed by Timothy Hatcher.
1004
1005         * Scripts/prepare-ChangeLog:
1006         (get_function_line_ranges_for_javascript):
1007         - We were ignoring everything inside of an anonymous function expression,
1008           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
1009           Better handle this by inserting a few tweaks.
1010         - Allow method syntax outside of classes as long as they are at the global level.
1011         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
1012
1013         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
1014         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
1015         (Foo.prototype.method1):
1016         (Foo.prototype.method2):
1017         (Foo.prototype.method3.innerFunction):
1018         (Foo.prototype.method3):
1019         (insideGlobalAnonymousFunctionExpression):
1020         (foo.insideGlobalFunctionExpression):
1021         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
1022         (IssueWithMapGetAndSet.prototype.method1):
1023         (IssueWithMapGetAndSet.prototype.method2):
1024         (IssueWithMapGetAndSet.prototype.method3):
1025         (IssueWithMapGetAndSet):
1026
1027 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1028
1029         [ES6] Enable ES6 Module in JSC shell by default
1030         https://bugs.webkit.org/show_bug.cgi?id=148689
1031
1032         Reviewed by Geoffrey Garen.
1033
1034         * Scripts/run-javascriptcore-tests:
1035         (runJSCStressTests):
1036         * Scripts/run-jsc-stress-tests:
1037
1038 2015-09-04  Basile Clement  <basile_clement@apple.com>
1039
1040         Unreviewed, change my email address.
1041
1042         * Scripts/webkitpy/common/config/contributors.json:
1043
1044 2015-09-04  Beth Dakin  <bdakin@apple.com>
1045
1046         Should have a test to make sure links don't navigate after a cancelled force 
1047         click
1048         https://bugs.webkit.org/show_bug.cgi?id=148846
1049
1050         Reviewed by Tim Horton.
1051
1052         New EventSender function for a started then cancelled force click.
1053         * WebKitTestRunner/EventSenderProxy.h:
1054         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1055         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1056         (WTR::EventSendingController::mouseForceClick):
1057         (WTR::EventSendingController::startAndCancelMouseForceClick):
1058         (WTR::EventSendingController::mouseForceDown):
1059         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1060         * WebKitTestRunner/TestController.cpp:
1061         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1062         * WebKitTestRunner/mac/EventSenderProxy.mm:
1063         (WTR::EventSenderProxy::mouseForceClick):
1064         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
1065         (WTR::EventSenderProxy::mouseForceDown):
1066         (WTR::EventSenderProxy::mouseMoveTo):
1067
1068 2015-09-04  Tim Horton  <timothy_horton@apple.com>
1069
1070         Add a test for r179736 (programmatic navigation during swipe causing a crash)
1071         https://bugs.webkit.org/show_bug.cgi?id=148830
1072
1073         Reviewed by Beth Dakin.
1074
1075         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1076         (WTR::InjectedBundle::beginTesting):
1077         Make sure that TestRunner callbacks don't leak between tests!
1078
1079 2015-09-04  Anders Carlsson  <andersca@apple.com>
1080
1081         It should be possible to pass relative HTTP test paths to DumpRenderTree
1082         https://bugs.webkit.org/show_bug.cgi?id=148825
1083         <rdar://problem/22583866>
1084
1085         Reviewed by Tim Horton.
1086
1087         Convert the path to an absolute path if needed.
1088
1089         * DumpRenderTree/mac/DumpRenderTree.mm:
1090         (computeTestURL):
1091
1092 2015-09-04  Jason Marcell  <jmarcell@apple.com>
1093
1094         Fix Swift unit tests for prepare-ChangeLog.
1095         https://bugs.webkit.org/show_bug.cgi?id=148817
1096
1097         Reviewed by Alexey Proskuryakov.
1098
1099         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
1100         Swift unit tests for prepare-ChangeLog.
1101
1102 2015-09-04  Lucas Forschler  <lforschler@apple.com>
1103
1104         Modifications to the webkit-nightly logic.
1105         
1106         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
1107         (updateAlertPanel):
1108         * WebKitLauncher/main.m:
1109         (displayErrorAndQuit):
1110
1111 2015-09-04  Beth Dakin  <bdakin@apple.com>
1112
1113         Speculative build fix.
1114
1115         * WebKitTestRunner/mac/EventSenderProxy.mm:
1116
1117 2015-09-04  Brian Burg  <bburg@apple.com>
1118
1119         Web Inspector: InspectorController should support multiple frontend channels
1120         https://bugs.webkit.org/show_bug.cgi?id=148538
1121
1122         Reviewed by Joseph Pecoraro.
1123
1124         InspectorClients must explicitly disconnect their frontend channel(s) from the
1125         inspected page's InspectorController.
1126
1127         To make this possible, DumpRenderTree should not destroy non-primary views until
1128         it has tried to close any abandoned Web Inspector instances. Performing teardown
1129         in the reverse order prevents disconnection of the frontend channel because that
1130         prematurely destroys the inspector frontend client.
1131
1132         * DumpRenderTree/mac/DumpRenderTree.mm:
1133         (runTest):
1134         * DumpRenderTree/win/DumpRenderTree.cpp:
1135         (runTest):
1136
1137 2015-09-04  Beth Dakin  <bdakin@apple.com>
1138
1139         Need to be able to test default behaviors on force click
1140         https://bugs.webkit.org/show_bug.cgi?id=148758
1141
1142         Reviewed by Tim Horton.
1143
1144         This patch adds a new eventSender method to do a full, completed force click, 
1145         and it re-works all of the existing force methods to dispatch their events in 
1146         such a way that they will trigger the NSImmediateAction gesture recognizer. 
1147         To do this, first we need to send the events to the app rather than straight 
1148         to the view, and also needed to tweak some state and send the events in a 
1149         delayed fashion.
1150
1151         New public function mouseForceClick() and private helper functions to make 
1152         NSEvents.
1153         * WebKitTestRunner/EventSenderProxy.h:
1154
1155         New public function mouseForceClick().
1156         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1157         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1158         (WTR::EventSendingController::mouseMoveTo):
1159         (WTR::EventSendingController::mouseForceClick):
1160         (WTR::EventSendingController::mouseForceDown):
1161         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1162         * WebKitTestRunner/TestController.cpp:
1163         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1164
1165         initPressureEventAtLocation needs to take a stageTransition and a window.
1166         * WebKitTestRunner/mac/EventSenderProxy.mm:
1167         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1168         (-[EventSenderSyntheticEvent stageTransition]):
1169         (-[EventSenderSyntheticEvent timestamp]):
1170         (-[EventSenderSyntheticEvent _cgsEventRecord]):
1171         (-[EventSenderSyntheticEvent window]):
1172
1173         In order to enter the gesture recognizer, we need to start with a mouse down 
1174         that has a NSEventMaskPressure modifier.
1175         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
1176
1177         This ensures that the events queue properly for the force monitor in AppKit.
1178         (WTR::spinRunLoopForForce):
1179
1180          We need to start the pressure change events with a began.
1181         (WTR::EventSenderProxy::beginPressureEvent):
1182
1183         These functions can be used to create the NSEvent for a pressure change every 
1184         time we need one.
1185         (WTR::EventSenderProxy::pressureChangeEvent):
1186
1187         Send the right series of events to emulate a full, completed force click.
1188         (WTR::EventSenderProxy::mouseForceClick):
1189
1190         Use all of the new things for these existing functions.
1191         (WTR::EventSenderProxy::mouseForceDown):
1192         (WTR::EventSenderProxy::mouseForceUp):
1193         (WTR::EventSenderProxy::mouseForceChanged):
1194
1195         Set NSFakeForceTouchDevice to YES.
1196         * WebKitTestRunner/mac/main.mm:
1197         (setDefaultsToConsistentValuesForTesting):
1198
1199 2015-09-04  Jason Marcell  <jmarcell@apple.com>
1200
1201         prepare-ChangeLog needs to know how to parse Swift files.
1202         https://bugs.webkit.org/show_bug.cgi?id=148784
1203         <rdar://problem/22510062>
1204
1205         Reviewed by Darin Adler.
1206
1207         * Scripts/prepare-ChangeLog:
1208         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
1209         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
1210         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
1211         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
1212         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
1213         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
1214         (freeFunction): Ditto.
1215         (MyClass.function): Ditto.
1216         (MyClass.functionWithArgument(_:)): Ditto.
1217         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
1218         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
1219         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
1220         (MyClass.classFunction): Ditto.
1221         (MyClass.readWriteComputedVariable): Ditto.
1222         (MyClass.readOnlyComputedVariable): Ditto.
1223
1224 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
1225
1226         Import css/css-color-3
1227         https://bugs.webkit.org/show_bug.cgi?id=148803
1228
1229         Reviewed by Chris Dumez.
1230
1231         Fixed a bug that the imported reference files used the same extention as tests.
1232         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
1233
1234         * Scripts/webkitpy/w3c/test_importer.py:
1235         (TestImporter.find_importable_tests):
1236
1237 2015-09-03  Commit Queue  <commit-queue@webkit.org>
1238
1239         Unreviewed, rolling out r189338.
1240         https://bugs.webkit.org/show_bug.cgi?id=148785
1241
1242         Caused tons of crashes (Requested by cdumez on #webkit).
1243
1244         Reverted changeset:
1245
1246         "Web Inspector: InspectorController should support multiple
1247         frontend channels"
1248         https://bugs.webkit.org/show_bug.cgi?id=148538
1249         http://trac.webkit.org/changeset/189338
1250
1251 2015-09-03  Brian Burg  <bburg@apple.com>
1252
1253         Web Inspector: InspectorController should support multiple frontend channels
1254         https://bugs.webkit.org/show_bug.cgi?id=148538
1255
1256         Reviewed by Joseph Pecoraro.
1257
1258         InspectorClients must explicitly disconnect their frontend channel(s) from the
1259         inspected page's InspectorController.
1260
1261         To make this possible, DumpRenderTree should not destroy non-primary views until
1262         it has tried to close any abandoned Web Inspector instances. Performing teardown
1263         in the reverse order prevents disconnection of the frontend channel because that
1264         prematurely destroys the inspector frontend client.
1265
1266         * DumpRenderTree/mac/DumpRenderTree.mm:
1267         (runTest):
1268         * DumpRenderTree/win/DumpRenderTree.cpp:
1269         (runTest):
1270
1271 2015-09-03  Timothy Hatcher  <timothy@apple.com>
1272
1273         Update WebKit nightly icon to be more like Safari
1274         https://bugs.webkit.org/show_bug.cgi?id=148768
1275
1276         Reviewed by Joseph Pecoraro.
1277
1278         * WebKitLauncher/webkit.icns:
1279
1280 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
1281
1282         JavaScriptCore should have some ES6 conformance tests
1283         https://bugs.webkit.org/show_bug.cgi?id=148771
1284
1285         Reviewed by Chris Dumez.
1286
1287         * Scripts/run-javascriptcore-tests:
1288         (runJSCStressTests): Added es6 as a test suite.
1289
1290         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
1291
1292         Some of these tests currently fail, so I also added a way to expect
1293         failure for now. We'll migrate failing tests to expected passes as we
1294         fix them.
1295
1296 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1297
1298         Add a test for swipe-start hysteresis
1299         https://bugs.webkit.org/show_bug.cgi?id=148756
1300
1301         Reviewed by Anders Carlsson.
1302
1303         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1304         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1305         (WTR::cacheTestRunnerCallback):
1306         (WTR::TestRunner::clearTestRunnerCallbacks):
1307         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1308         Make sure that we log if a client tries to install a callback twice
1309         (since we use .add, the second call would not work).
1310
1311         Also, add clearTestRunnerCallbacks so tests can swap out installed
1312         callbacks.
1313
1314 2015-09-03  Anders Carlsson  <andersca@apple.com>
1315
1316         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
1317         https://bugs.webkit.org/show_bug.cgi?id=148746
1318         rdar://problem/22568073
1319
1320         Reviewed by Tim Horton.
1321
1322         * DumpRenderTree/mac/DumpRenderTree.mm:
1323         (computeTestURL):
1324         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
1325
1326         (runTest):
1327         Call computeTestURL.
1328
1329         (testPathFromURL):
1330         Get rid of this; computeTestURL does this for us now.
1331
1332         * Scripts/webkitpy/port/driver.py:
1333         (Driver._command_from_driver_input):
1334         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
1335
1336 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1337
1338         Swipe tests fail on Mavericks
1339         https://bugs.webkit.org/show_bug.cgi?id=148752
1340
1341         Reviewed by Beth Dakin.
1342
1343         * WebKitTestRunner/mac/EventSenderProxy.mm:
1344
1345 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1346
1347         Fix the 32-bit build
1348
1349         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1350         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1351
1352 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1353
1354         Remove some logging that wasn't meant to be in the tree
1355
1356         * WebKitTestRunner/mac/EventSenderProxy.mm:
1357         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1358
1359 2015-09-03  Tim Horton  <timothy_horton@apple.com>
1360
1361         [Mac] Add support for testing swipes
1362         https://bugs.webkit.org/show_bug.cgi?id=148700
1363
1364         Reviewed by Beth Dakin.
1365
1366         * WebKitTestRunner/EventSenderProxy.h:
1367         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1368         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1369         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1370         (WTR::cgEventPhaseFromString):
1371         (WTR::cgEventMomentumPhaseFromString):
1372         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1373         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
1374         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1375         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1376         (WTR::InjectedBundle::didReceiveMessageToPage):
1377         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1378         (WTR::TestRunner::installDidBeginSwipeCallback):
1379         (WTR::TestRunner::installWillEndSwipeCallback):
1380         (WTR::TestRunner::installDidEndSwipeCallback):
1381         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
1382         (WTR::TestRunner::callDidBeginSwipeCallback):
1383         (WTR::TestRunner::callWillEndSwipeCallback):
1384         (WTR::TestRunner::callDidEndSwipeCallback):
1385         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
1386         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1387         * WebKitTestRunner/TestController.cpp:
1388         (WTR::TestController::createOtherPage):
1389         (WTR::TestController::createWebViewWithOptions):
1390         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1391         (WTR::TestController::didBeginNavigationGesture):
1392         (WTR::TestController::willEndNavigationGesture):
1393         (WTR::TestController::didEndNavigationGesture):
1394         (WTR::TestController::didRemoveNavigationGestureSnapshot):
1395         * WebKitTestRunner/TestController.h:
1396         * WebKitTestRunner/TestInvocation.cpp:
1397         (WTR::TestInvocation::didBeginSwipe):
1398         (WTR::TestInvocation::willEndSwipe):
1399         (WTR::TestInvocation::didEndSwipe):
1400         (WTR::TestInvocation::didRemoveSwipeSnapshot):
1401         * WebKitTestRunner/TestInvocation.h:
1402         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
1403         when the snapshot is removed.
1404
1405         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
1406         mouseScrollBy function.
1407
1408         * WebKitTestRunner/mac/EventSenderProxy.mm:
1409         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1410         (-[EventSenderSyntheticEvent type]):
1411         (-[EventSenderSyntheticEvent subtype]):
1412         (-[EventSenderSyntheticEvent locationInWindow]):
1413         (-[EventSenderSyntheticEvent location]):
1414         (-[EventSenderSyntheticEvent momentumPhase]):
1415         (-[EventSenderSyntheticEvent _isTouchesEnded]):
1416         (-[EventSenderSyntheticEvent _cgsEventRecord]):
1417         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
1418         more adjustable values.
1419
1420         (WTR::EventSenderProxy::mouseForceDown):
1421         (WTR::EventSenderProxy::mouseForceUp):
1422         (WTR::EventSenderProxy::mouseForceChanged):
1423         Adopt EventSenderSyntheticEvent.
1424
1425         (WTR::nsEventPhaseFromCGEventPhase):
1426         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1427         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
1428
1429         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1430         (WTR::PlatformWebView::PlatformWebView):
1431         Enable swipe.
1432
1433 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
1434
1435         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
1436         https://bugs.webkit.org/show_bug.cgi?id=148723
1437
1438         Reviewed by Anders Carlsson.
1439
1440         * WebKitTestRunner/TestController.cpp:
1441         (WTR::testPath):
1442         (WTR::updateViewOptionsFromTestHeader):
1443         (WTR::TestController::viewOptionsForTest):
1444
1445 2015-09-03  Lucas Forschler  <lforschler@apple.com>
1446
1447         Test commit.
1448
1449 2015-09-02  Tim Horton  <timothy_horton@apple.com>
1450
1451         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
1452         https://bugs.webkit.org/show_bug.cgi?id=148693
1453
1454         Reviewed by Anders Carlsson.
1455
1456         * WebKitTestRunner/TestController.cpp:
1457         (WTR::TestController::createOtherPage):
1458         (WTR::TestController::createWebViewWithOptions):
1459
1460 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1461
1462         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
1463         https://bugs.webkit.org/show_bug.cgi?id=148529
1464
1465         Reviewed by Darin Adler.
1466
1467         When there are pending EventSender messages after a test finishes,
1468         they could be processed in the main loop started by the
1469         resetStateToConsistentValues(), but the old EventSender has been
1470         replaced by a new one at that point. The new Eventsender can crash
1471         when processing messages that were sent to the old one. To avoid
1472         this, we return early when receiving an EventSender message and
1473         the TestController state is not RunningTest.
1474
1475         * WebKitTestRunner/TestController.cpp:
1476         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
1477         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1478
1479 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1480
1481         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
1482         https://bugs.webkit.org/show_bug.cgi?id=148528
1483
1484         Reviewed by Darin Adler.
1485
1486         Before r188548 resetStateToConsistentValues() was called in
1487         TestController::run(), before tests are run, but now it's called
1488         for every test in TestInvocation::invoke(), after m_status has
1489         changed to RunningTest.
1490
1491         * WebKitTestRunner/TestController.cpp:
1492         (WTR::TestController::resetStateToConsistentValues): Use
1493         TemporaryChange to reset m_state ot its previous value after reset
1494         is done.
1495
1496 2015-08-31  Jason Marcell  <jmarcell@apple.com>
1497
1498         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
1499         that are marked as requiring corresponding tests.
1500         https://bugs.webkit.org/show_bug.cgi?id=148498
1501         <rdar://problem/21555314>
1502
1503         Reviewed by Dan Bernstein and David Kilzer.
1504
1505         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
1506         simulate Git's attribute behevaior.
1507         (main): Added "requiresTests" array to contain files that require tests.
1508         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
1509         section in ChangeLog.
1510         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
1511         however, we check if the file or any containing folder has the given property set to "1" and
1512         return 1 if so; return 0 otherwise.
1513         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
1514         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
1515
1516 2015-08-26  Andy Estes  <aestes@apple.com>
1517
1518         [Content Filtering] Determine navigation and content policy before continuing to filter a load
1519         https://bugs.webkit.org/show_bug.cgi?id=148506
1520
1521         Reviewed by Brady Eidson.
1522
1523         Added download API tests covering every decision and decision point.
1524         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
1525
1526         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
1527         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
1528         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1529         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
1530         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
1531         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
1532         decision and decision point as a bundle parameter.
1533         (+[MockContentFilterEnabler supportsSecureCoding]):
1534         (-[MockContentFilterEnabler copyWithZone:]):
1535         (-[MockContentFilterEnabler initWithCoder:]):
1536         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
1537         (-[MockContentFilterEnabler encodeWithCoder:]):
1538         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
1539         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
1540         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
1541         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
1542         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
1543         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
1544         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
1545         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
1546         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
1547         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
1548         (+[MockContentFilterEnabler supportsSecureCoding]):
1549         (-[MockContentFilterEnabler copyWithZone:]):
1550         (-[MockContentFilterEnabler initWithCoder:]):
1551         (-[MockContentFilterEnabler dealloc]):
1552         (-[MockContentFilterEnabler encodeWithCoder:]):
1553         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
1554         (-[ContentFilteringPlugIn dealloc]): Stop observing.
1555         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
1556         (+[ServerRedirectPlugIn initialize]): Deleted.
1557         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1558         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1559         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
1560         (TEST): Deleted.
1561
1562 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
1563
1564         Skip slow lock tests on Windows/debug
1565         https://bugs.webkit.org/show_bug.cgi?id=148643
1566
1567         Reviewed by Alexey Proskuryakov.
1568
1569         The lock tests simulate a critical section by doing some floating point math, and then either
1570         make those critical sections very long or invoke them many times. This appears to be
1571         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
1572         that kind of computation slow.
1573
1574         These tests are almost as useful in release as they are in debug, so it's probably better to
1575         just skip the in debug on platforms where this causes timeouts.
1576
1577         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1578         (TestWebKitAPI::runLockTest):
1579         (TestWebKitAPI::skipSlow):
1580         (TestWebKitAPI::TEST):
1581
1582 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
1583
1584         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
1585         https://bugs.webkit.org/show_bug.cgi?id=125720
1586
1587         Reviewed by Daniel Bates.
1588
1589         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
1590
1591         * DumpRenderTree/AccessibilityUIElement.cpp:
1592         (pressCallback):
1593         (scrollToMakeVisibleWithSubFocusCallback):
1594         (scrollToGlobalPointCallback):
1595         (scrollToMakeVisibleCallback):
1596         (AccessibilityUIElement::getJSClass):
1597         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1598         (AccessibilityUIElement::scrollToMakeVisible):
1599         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1600         (AccessibilityUIElement::scrollToGlobalPoint):
1601         (AccessibilityUIElement::selectedTextRange):
1602         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1603         (AccessibilityUIElement::AccessibilityUIElement):
1604         (AccessibilityUIElement::mathPrescriptsDescription):
1605         (AccessibilityUIElement::scrollToMakeVisible):
1606         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1607         (AccessibilityUIElement::scrollToGlobalPoint):
1608         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1609         (WTR::AccessibilityUIElement::isTextMarkerValid):
1610         (WTR::AccessibilityUIElement::textMarkerForIndex):
1611         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1612         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1613         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1614         (WTR::AccessibilityUIElement::supportedActions):
1615         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1616         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1617         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1618         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1619         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1620         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1621         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1622         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1623         (WTR::AccessibilityUIElement::selectedTextRange):
1624         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1625         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1626         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1627         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1628         (WTR::AccessibilityUIElement::selectedTextRange):
1629
1630 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
1631
1632         Add a mysteriously nonproblematic missing comma.
1633
1634         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1635         (TestExpectationParser._collect_matching_tests):
1636         (TestExpectationParser):
1637
1638 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
1639
1640         Remove an old temporary script that has served its purpose
1641
1642         * Scripts/convert-test-expectations: Removed.
1643
1644 2015-08-28  Jer Noble  <jer.noble@apple.com>
1645
1646         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
1647         https://bugs.webkit.org/show_bug.cgi?id=148579
1648
1649         Reviewed by Anders Carlsson.
1650
1651         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
1652
1653         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
1654         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
1655
1656         * DumpRenderTree/mac/DumpRenderTree.mm:
1657         (resetWebPreferencesToConsistentValues):
1658         (resetWebViewToConsistentStateBeforeTesting): 
1659         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1660         (WTR::initializeWebViewConfiguration):
1661
1662 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
1663
1664         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
1665         https://bugs.webkit.org/show_bug.cgi?id=148592
1666
1667         Reviewed by Tim Horton.
1668
1669         * Scripts/webkitpy/port/base.py:
1670         (Port.to.setup_environ_for_server):
1671         (Port.to):
1672         (Port.to._append_value_colon_separated):
1673         (Port.to.show_results_html_file):
1674         * Scripts/webkitpy/port/ios.py:
1675         (IOSSimulatorPort.setup_environ_for_server):
1676         * Scripts/webkitpy/port/mac.py:
1677         (MacPort.setup_environ_for_server):
1678
1679 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
1680
1681         LICM should be sound even if the CFG has changed
1682         https://bugs.webkit.org/show_bug.cgi?id=148259
1683
1684         Reviewed by Benjamin Poulain.
1685
1686         Add a utility for creating tests that set some uncommon option.
1687
1688         * Scripts/run-jsc-stress-tests:
1689
1690 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
1691
1692         [Win] Unreviewed EWS correction.
1693
1694         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
1695
1696 2015-08-28  Jer Noble  <jer.noble@apple.com>
1697
1698         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
1699         https://bugs.webkit.org/show_bug.cgi?id=147512
1700
1701         Reviewed by Anders Carlsson.
1702
1703         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
1704         to a consistent (true) value.
1705
1706         * DumpRenderTree/mac/DumpRenderTree.mm:
1707         (setDefaultsToConsistentValuesForTesting):
1708         * WebKitTestRunner/TestController.cpp:
1709         (WTR::TestController::resetPreferencesToConsistentValues):
1710
1711 2015-08-28  Tim Horton  <timothy_horton@apple.com>
1712
1713         Add navigation gesture callbacks to WKPageNavigationClient
1714         https://bugs.webkit.org/show_bug.cgi?id=148568
1715         <rdar://problem/22371346>
1716
1717         Reviewed by Anders Carlsson.
1718
1719         * WebKitTestRunner/TestController.cpp:
1720         (WTR::TestController::createOtherPage):
1721         (WTR::TestController::createWebViewWithOptions):
1722         Add some zeroes.
1723
1724 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
1725
1726         [Mac] kill-old-processes should kill more processes
1727         https://bugs.webkit.org/show_bug.cgi?id=148577
1728
1729         Reviewed by Tim Horton.
1730
1731         * BuildSlaveSupport/kill-old-processes:
1732
1733 2015-08-28  Jason Marcell  <jmarcell@apple.com>
1734
1735         The status message for combined builder queues should say "all builds succeeded" if everything
1736         built correctly.
1737         https://bugs.webkit.org/show_bug.cgi?id=148535
1738
1739         Reviewed by David Kilzer and Alexey Proskuryakov.
1740
1741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1742         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
1743         say "all builds succeeded" if everything built correctly.
1744
1745 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1746
1747         [GTK] Simplify the internal API to create a WebView
1748         https://bugs.webkit.org/show_bug.cgi?id=148570
1749
1750         Reviewed by Žan Doberšek.
1751
1752         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
1753         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1754         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
1755         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
1756         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
1757         passing the received PageConfiguration.
1758         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1759         (WTR::PlatformWebView::PlatformWebView): Create the WebView
1760         passing the received PageConfiguration.
1761
1762 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
1763
1764         iOS Simulator API tests fails as Simulator is not running
1765         https://bugs.webkit.org/show_bug.cgi?id=148501
1766         rdar://problem/22447525
1767
1768         Reviewed by Daniel Bates.
1769
1770         This change is a workaround for <rdar://problem/22388812>.
1771
1772          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
1773          and quit it on program termination when running tests on the iOS port.
1774          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
1775          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
1776
1777 2015-08-27  Alex Christensen  <achristensen@webkit.org>
1778
1779         Make DLLLauncherMain executables dependent on dll
1780         https://bugs.webkit.org/show_bug.cgi?id=148548
1781
1782         Reviewed by Brent Fulgham.
1783
1784         * DumpRenderTree/CMakeLists.txt:
1785         * DumpRenderTree/PlatformWin.cmake:
1786         * MiniBrowser/win/CMakeLists.txt:
1787         * TestWebKitAPI/CMakeLists.txt:
1788         * TestWebKitAPI/PlatformWin.cmake:
1789
1790 2015-08-27  Lucas Forschler  <lforschler@apple.com>
1791
1792         Remove Mac slaves 188/189 after being replaced with 400/401.
1793         
1794         Unreviewed.
1795         
1796         * BuildSlaveSupport/build.webkit.org-config/config.json:
1797
1798 2015-08-27  Lucas Forschler  <lforschler@apple.com>
1799
1800         Add two bots to the Mac Yosemite queue.
1801         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
1802         
1803         Unreviewed.
1804         
1805         * BuildSlaveSupport/build.webkit.org-config/config.json:
1806
1807 2015-08-27  Alex Christensen  <achristensen@webkit.org>
1808
1809         [Win CMake] Fix incremental build after r188673
1810         https://bugs.webkit.org/show_bug.cgi?id=148539
1811
1812         Reviewed by Brent Fulgham.
1813
1814         * TestWebKitAPI/PlatformWin.cmake:
1815         Copy forwarding headers from WebCore before building in case that was not yet done.
1816         It used to be done when running CMake, but now it's a build step.
1817
1818 2015-08-27  Nan Wang  <n_wang@apple.com>
1819
1820         AX: Fix accessibility/select-element-at-index.html test
1821         https://bugs.webkit.org/show_bug.cgi?id=148516
1822
1823         Reviewed by Chris Fleizach.
1824
1825         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
1826
1827         * DumpRenderTree/AccessibilityUIElement.cpp:
1828         (setSelectedChildCallback):
1829         (setSelectedChildAtIndexCallback):
1830         (removeSelectionAtIndexCallback):
1831         (elementAtPointCallback):
1832         (sentenceAtOffsetCallback):
1833         (stringForSelectionCallback):
1834         (AccessibilityUIElement::getJSClass):
1835         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1836         (AccessibilityUIElement::setSelectedChild):
1837         (AccessibilityUIElement::setSelectedChildAtIndex):
1838         (AccessibilityUIElement::removeSelectionAtIndex):
1839         (AccessibilityUIElement::accessibilityValue):
1840         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1841         (WTR::AccessibilityUIElement::wordAtOffset):
1842         (WTR::AccessibilityUIElement::lineAtOffset):
1843         (WTR::AccessibilityUIElement::sentenceAtOffset):
1844         (WTR::AccessibilityUIElement::isSelectable):
1845         (WTR::AccessibilityUIElement::isMultiSelectable):
1846         (WTR::AccessibilityUIElement::setSelectedChild):
1847         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1848         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1849         (WTR::AccessibilityUIElement::selectedChildrenCount):
1850         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1851         (WTR::AccessibilityUIElement::isExpanded):
1852         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1853         (WTR::AccessibilityUIElement::setSelectedChild):
1854         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1855         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1856         (WTR::AccessibilityUIElement::accessibilityValue):
1857
1858 2015-08-27  Alex Christensen  <achristensen@webkit.org>
1859
1860         Build fix after r188982
1861
1862         * MiniBrowser/win/CMakeLists.txt:
1863         The directory structure changed in the move.
1864
1865 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
1866
1867         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
1868
1869         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
1870
1871         * gtk/install-dependencies:
1872
1873 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1874
1875         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
1876
1877         * Scripts/run-gtk-tests:
1878         (TestRunner):
1879
1880 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1881
1882         Fix GTK+ WTR crashes in initializeMainRunLoop()
1883
1884         Rubber-stamped by Žan Doberšek.
1885
1886         Initialize threading and main thread before
1887         RunLoop::initializeMainRunLoop(), since the GLib implementation of
1888         the RunLoop uses isMainThread() to decide whether to create a new
1889         GMainContext or use the default one. Also use RunLoop::run() and
1890         ::stop() instead of gtk_main/quit.
1891
1892         * WebKitTestRunner/TestController.cpp:
1893         (WTR::TestController::initialize):
1894         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1895         (WTR::TestController::notifyDone):
1896         (WTR::TestController::platformRunUntil):
1897
1898 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
1899
1900         Unreviewed, further shorten a test that times out because it's very long
1901         running.
1902
1903         I've locally run these tests on repeat for 24 hours and found no genuine
1904         failures, like deadlocks. So, the timeouts are probably because the test
1905         machine is slow and debug is slow. We should just run this test for fewer
1906         iterations.
1907
1908         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1909         (TestWebKitAPI::TEST):
1910
1911 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
1912
1913         Unreviewed build fix attempt on EFL
1914
1915         * WebKitTestRunner/PlatformEfl.cmake:
1916
1917 2015-08-26  Alex Christensen  <achristensen@webkit.org>
1918
1919         Build fix after r188982
1920
1921         * MiniBrowser/win/CMakeLists.txt:
1922         Find .rc files in correct directory.
1923
1924 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
1925
1926         [EFL] Bump cairo version to 1.14.2
1927         https://bugs.webkit.org/show_bug.cgi?id=148474
1928
1929         Reviewed by Csaba Osztrogonác.
1930
1931         * efl/jhbuild.modules:
1932
1933 2015-08-26  Andy Estes  <aestes@apple.com>
1934
1935         Crash when following a Google search link to Twitter with Limit Adult Content enabled
1936         https://bugs.webkit.org/show_bug.cgi?id=147651
1937
1938         Rubber-stamped by Brady Eidson.
1939
1940         Taught TestRunner how to decide the navigation policy after a delay.
1941
1942         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1943         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1944         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1945         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1946         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1947         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1948         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
1949         * WebKitTestRunner/TestController.cpp:
1950         (WTR::TestController::initialize):
1951         (WTR::TestController::resetStateToConsistentValues):
1952         (WTR::TestController::decidePolicyForNavigationAction):
1953         * WebKitTestRunner/TestController.h:
1954         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
1955         * WebKitTestRunner/TestInvocation.cpp:
1956         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1957
1958 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
1959
1960         [Win] Rename 'WinLauncher' to 'MiniBrowser'
1961         https://bugs.webkit.org/show_bug.cgi?id=148485
1962
1963         Reviewed by Alex Christensen
1964
1965         Move the WinLauncher project and source files to a subdirectory
1966         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
1967         source code and project files.
1968         
1969         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
1970         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
1971         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
1972         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
1973         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
1974         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
1975         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
1976         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
1977         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
1978         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
1979         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
1980         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
1981         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
1982         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
1983         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
1984         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
1985         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
1986         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
1987         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
1988         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
1989         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
1990         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
1991         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
1992         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
1993         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
1994         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
1995         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
1996         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
1997         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
1998         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
1999         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
2000         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
2001         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
2002         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
2003         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2004         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
2005         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
2006         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2007         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2008         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
2009         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
2010         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
2011         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
2012         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
2013         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
2014         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
2015         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
2016         * MiniBrowser/win: Copied from WinLauncher.
2017         * MiniBrowser/win/Common.cpp:
2018         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
2019         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
2020         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
2021         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
2022         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
2023         * MiniBrowser/win/PageLoadTestClient.cpp:
2024         * MiniBrowser/win/PageLoadTestClient.h:
2025         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2026         * MiniBrowser/win/ResourceLoadDelegate.h:
2027         * MiniBrowser/win/WinLauncher.cpp: Removed.
2028         * MiniBrowser/win/WinLauncher.h: Removed.
2029         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
2030         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
2031         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
2032         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
2033         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
2034         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
2035         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
2036         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
2037         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
2038         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
2039         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
2040         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2041         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
2042         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
2043         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2044         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2045         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
2046         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
2047         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
2048         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
2049         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
2050         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
2051         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
2052         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
2053         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
2054         * MiniBrowser/win/WinLauncherReplace.h: Removed.
2055         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
2056         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
2057         * MiniBrowser/win/WinMain.cpp:
2058         * WinLauncher: Removed.
2059         * WinLauncher/AccessibilityDelegate.cpp: Removed.
2060         * WinLauncher/AccessibilityDelegate.h: Removed.
2061         * WinLauncher/CMakeLists.txt: Removed.
2062         * WinLauncher/Common.cpp: Removed.
2063         * WinLauncher/DOMDefaultImpl.cpp: Removed.
2064         * WinLauncher/DOMDefaultImpl.h: Removed.
2065         * WinLauncher/PageLoadTestClient.cpp: Removed.
2066         * WinLauncher/PageLoadTestClient.h: Removed.
2067         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
2068         * WinLauncher/PrintWebUIDelegate.h: Removed.
2069         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
2070         * WinLauncher/ResourceLoadDelegate.h: Removed.
2071         * WinLauncher/WebDownloadDelegate.cpp: Removed.
2072         * WinLauncher/WebDownloadDelegate.h: Removed.
2073         * WinLauncher/WinLauncher.cpp: Removed.
2074         * WinLauncher/WinLauncher.h: Removed.
2075         * WinLauncher/WinLauncher.vcxproj: Removed.
2076         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
2077         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
2078         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
2079         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
2080         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
2081         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
2082         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
2083         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
2084         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
2085         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
2086         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
2087         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
2088         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
2089         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
2090         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
2091         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
2092         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
2093         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
2094         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
2095         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
2096         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
2097         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
2098         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
2099         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
2100         * WinLauncher/WinLauncherReplace.h: Removed.
2101         * WinLauncher/WinLauncherWebHost.cpp: Removed.
2102         * WinLauncher/WinLauncherWebHost.h: Removed.
2103         * WinLauncher/WinMain.cpp: Removed.
2104         * WinLauncher/resource.h: Removed.
2105         * WinLauncher/stdafx.cpp: Removed.
2106         * WinLauncher/stdafx.h: Removed.
2107         * win/AssembleBuildLogs/AssembleLogs.cmd:
2108
2109 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
2110
2111         [Win] Simplify menu handling code in WinLauncher
2112         https://bugs.webkit.org/show_bug.cgi?id=148461
2113
2114         Reviewed by Zalan Bujtas.
2115
2116         Revise 'ToggleMenuItem' to return a boolean value indicating if
2117         it handled the message. Revise WndProc to use this to decide if it
2118         should pass the message on to the default handler, rather than
2119         duplicating the logic in both places.
2120         
2121         * WinLauncher/Common.cpp:
2122         (ToggleMenuItem): Return true if the menu item message was handled.
2123         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
2124         the message tothe default handler.
2125
2126 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
2127
2128         Remove unused code after r188948
2129         https://bugs.webkit.org/show_bug.cgi?id=148467
2130
2131         Reviewed by Gyuyoung Kim.
2132
2133         * WebKitTestRunner/TestController.cpp:
2134         (WTR::TestController::platformPreferences): Deleted.
2135
2136 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2137
2138         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
2139         https://bugs.webkit.org/show_bug.cgi?id=148377
2140
2141         Reviewed by Carlos Garcia Campos.
2142
2143         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
2144         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
2145         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
2146         EFL and GTK at the moment.
2147
2148         * WebKitTestRunner/TestController.cpp:
2149         (WTR::TestController::platformWillRunTest):
2150         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2151         (WTR::TestController::platformPreferences):
2152         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2153         (WTR::TestController::platformPreferences):
2154
2155 2015-08-25  Nan Wang  <n_wang@apple.com>
2156
2157         AX: Enable accessibility/aria-controls.html test for mac
2158         https://bugs.webkit.org/show_bug.cgi?id=148458
2159
2160         Reviewed by Chris Fleizach.
2161
2162         Implemented ariaControlsElementAtIndex(unsigned index).
2163
2164         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2165         (AccessibilityUIElement::ariaControlsElementAtIndex):
2166         (AccessibilityUIElement::disclosedRowAtIndex):
2167         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2168         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
2169
2170 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2171
2172         Remove python tests for PassRefPtr 
2173         https://bugs.webkit.org/show_bug.cgi?id=148463
2174
2175         Reviewed by Andy Estes.
2176
2177         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
2178
2179         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2180         (PassPtrTest): Deleted.
2181         (PassPtrTest.assert_pass_ptr_check): Deleted.
2182         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
2183         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
2184         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
2185         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
2186         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
2187         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
2188
2189 2015-08-25  Andy Estes  <aestes@apple.com>
2190
2191         [iOS] run-webkit-tests fails if watchOS SDK is installed
2192         https://bugs.webkit.org/show_bug.cgi?id=148453
2193
2194         Reviewed by David Kilzer.
2195
2196         * Scripts/webkitpy/xcode/simulator.py:
2197         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
2198         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
2199
2200 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
2201
2202         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
2203         https://bugs.webkit.org/show_bug.cgi?id=148197
2204         rdar://problem/22334382
2205
2206         Reviewed by Daniel Bates.
2207
2208         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
2209         * Scripts/webkitpy/port/ios.py:
2210         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
2211         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
2212         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
2213         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
2214         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
2215
2216 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2217
2218         Remove PassRefPtr style check rule
2219         https://bugs.webkit.org/show_bug.cgi?id=148432
2220
2221         Reviewed by Andreas Kling.
2222
2223         PassRefPtr is being removed. Thus style rule needs to be removed as well.
2224
2225         * Scripts/webkitpy/style/checkers/cpp.py:
2226         (_check_parameter_name_against_text): Deleted.
2227         (check_function_definition_and_pass_ptr): Deleted.
2228         (check_function_definition): Deleted.
2229         (check_pass_ptr_usage): Deleted.
2230         (process_line): Deleted.
2231         (CppChecker): Deleted.
2232
2233 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
2234
2235         [Win] Expose "Inverted Colors" option in WinLauncher
2236         https://bugs.webkit.org/show_bug.cgi?id=148451
2237
2238         Reviewed by Tim Horton.
2239
2240         Add the ability to toggle the "Inverted Colors" preference
2241         in WinLauncher.
2242         
2243         * WinLauncher/Common.cpp:
2244         (ToggleMenuItem): Toggle the feature when the menu item
2245         is selected.
2246         (WndProc): Recognize the new menu option.
2247         * WinLauncher/WinLauncher.cpp:
2248         (WinLauncher::setToDefaultPreferences): Launch with "Invert
2249         Colors" turned off.
2250         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
2251         entry for "Invert Colors".
2252         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2253
2254 2015-08-25  Nan Wang  <n_wang@apple.com>
2255
2256         [Mac] accessibility/document-attributes.html fails
2257         https://bugs.webkit.org/show_bug.cgi?id=116636
2258
2259         Reviewed by Chris Fleizach.
2260
2261         Implemented documentURI() and documentEncoding().
2262
2263         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2264         (AccessibilityUIElement::documentEncoding):
2265         (AccessibilityUIElement::documentURI):
2266         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2267         (WTR::AccessibilityUIElement::documentEncoding):
2268         (WTR::AccessibilityUIElement::documentURI):
2269
2270 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
2271
2272         [Win] Unreviewed test gardening.
2273
2274         Fix another case where the logging string is constructed using the variable 'frame',
2275         but the method argument is not given a name. This causes the global 'frame' value to
2276         be used, producing incorrect output.
2277
2278         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2279         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
2280         argument.
2281
2282 2015-08-24  Tim Horton  <timothy_horton@apple.com>
2283
2284         (Finally...) get rid of WKViewIOS
2285         https://bugs.webkit.org/show_bug.cgi?id=148404
2286
2287         Reviewed by Anders Carlsson.
2288
2289         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2290         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2291         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2292         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2293         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2294         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2295         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
2296         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2297         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2298         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
2299         Mark tests that use WKBrowsingContextController as Mac-only.
2300
2301         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2302         (WTR::AccessibilityController::addNotificationListener):
2303         * WebKitTestRunner/ios/mainIOS.mm:
2304         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
2305         Import UIKit instead of depending on WKView.h to do so.
2306
2307 2015-08-24  Jason Marcell  <jmarcell@apple.com>
2308
2309         Add support to dashboard for displaying Git SHA's as revisions.
2310         https://bugs.webkit.org/show_bug.cgi?id=148387
2311
2312         Reviewed by Daniel Bates.
2313
2314         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2315         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
2316         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2317         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
2318         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
2319         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
2320
2321 2015-08-24  Andy Estes  <aestes@apple.com>
2322
2323         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
2324
2325         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
2326
2327 2015-08-23  Andy Estes  <aestes@apple.com>
2328
2329         Addressed a missed piece of review feedback from r188851.
2330
2331         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2332
2333 2015-08-23  Andy Estes  <aestes@apple.com>
2334
2335         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
2336         https://bugs.webkit.org/show_bug.cgi?id=147872
2337         rdar://problem/22044000
2338
2339         Reviewed by Dan Bernstein.
2340         
2341         Added an API test.
2342
2343         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
2344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2345         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
2346         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
2347         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
2348         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
2349         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
2350         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
2351         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
2352         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
2353         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
2354
2355 2015-08-23  Andy Estes  <aestes@apple.com>
2356
2357         Fixed the 32-bit Mac build after r188844.
2358
2359         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
2360         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
2361
2362 2015-08-22  Andy Estes  <aestes@apple.com>
2363
2364         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
2365         https://bugs.webkit.org/show_bug.cgi?id=148317
2366
2367         Reviewed by Dan Bernstein.
2368
2369         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
2370         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
2371         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
2372         when creating WKWebViews.
2373
2374         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
2375         added a new API test for bundle parameters.
2376
2377         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
2378         named its executable TestWebKitAPI.bundle.
2379         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
2380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
2381         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
2382         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
2383         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
2384         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
2385         bundle parameter and asked for an initial notification.
2386         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
2387         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
2388         mirror its value in the main frame's JSContext.
2389         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
2390         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
2391         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
2392         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
2393         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
2394         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
2395         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
2396         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
2397         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
2398         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
2399
2400 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
2401
2402         URTBF after r188828.
2403
2404         * WebKitTestRunner/PlatformWebView.h:
2405
2406 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
2407
2408         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
2409         https://bugs.webkit.org/show_bug.cgi?id=148356
2410
2411         Reviewed by Darin Adler.
2412
2413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2414         (BuildbotCombinedQueueView.prototype.update):
2415
2416 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
2417
2418         build.webkit.org/dashboard: Respect step's hidden flag
2419         https://bugs.webkit.org/show_bug.cgi?id=148357
2420
2421         Reviewed by Darin Adler.
2422
2423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2424         (BuildbotIteration.prototype._parseData):
2425
2426 2015-08-23  Nan Wang  <n_wang@apple.com>
2427
2428         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
2429         https://bugs.webkit.org/show_bug.cgi?id=148328
2430
2431         Reviewed by Darin Adler.
2432
2433         We should only expose stringValue() when value attribute is set.
2434
2435         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2436         (AccessibilityUIElement::stringValue):
2437         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2438         (WTR::AccessibilityUIElement::stringValue):
2439
2440 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2441
2442         Remove style checking rule regarding OwnPtr and PassOwnPtr
2443         https://bugs.webkit.org/show_bug.cgi?id=148360
2444
2445         Reviewed by Darin Adler.
2446
2447         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
2448         Removed it.
2449
2450         * Scripts/do-webcore-rename:
2451         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2452         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
2453         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
2454         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
2455         (WebKitStyleTest.test_names): Deleted.
2456
2457 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
2458
2459         WebKitTestRunner should use WKWebView on OS X and iOS
2460         https://bugs.webkit.org/show_bug.cgi?id=143743
2461         <rdar://problem/16947123>
2462
2463         Reviewed by Anders Carlsson.
2464         Patch by Enrica Casucci and myself.
2465
2466         * WebKitTestRunner/PlatformWebView.h:
2467         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
2468         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
2469         instead of WKContext and WKPageGroup.
2470
2471         Remove the unused, always-true windowSnapshotEnabled().
2472         While technically some platforms don't have window snapshotting,
2473         they just return null instead of implementing windowSnapshotEnabled().
2474
2475         * WebKitTestRunner/TestController.h:
2476         * WebKitTestRunner/TestController.cpp:
2477         (WTR::TestController::createOtherPage):
2478         (WTR::TestController::initialize):
2479         (WTR::TestController::createWebViewWithOptions):
2480         Delegate to the various platforms for creating PlatformWebView instances,
2481         for creating WKContexts, and for accessing WKPreferences,
2482         so that they can do special things (like, use WKWebView instead!).
2483
2484         (WTR::TestController::resetPreferencesToConsistentValues):
2485         Make explicit WebKitTestRunner's desired default for two preferences
2486         which have differing defaults between the antique and modern API,
2487         for consistency's sake.
2488
2489         (WTR::TestController::resetStateToConsistentValues):
2490         Add platformResetStateToConsistentValues.
2491
2492         * WebKitTestRunner/TestInvocation.cpp:
2493         (WTR::TestInvocation::dumpResults):
2494         Adjust to the aforementioned removal of windowSnapshotEnabled().
2495
2496         * WebKitTestRunner/ios/TestControllerCocoa.mm:
2497         (WTR::TestController::platformResetStateToConsistentValues):
2498         (WTR::TestController::platformPreferences):
2499         (WTR::TestController::platformCreateWebView):
2500         (WTR::TestController::platformCreateOtherPage):
2501         (WTR::TestController::platformInitializeConfiguration):
2502         Implement the new platform functions for the Modern WebKit2 API,
2503         in a new TestControllerCocoa file that is shared between iOS and Mac.
2504         
2505         For platformMaybeCreateContext, use the trick that we know we can cast
2506         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
2507         WKWebView's configuration.
2508
2509         Ditto for WKPreferencesRef and WKPreferences.
2510
2511         Remove user content filters on the WKWebView's userContentController.
2512
2513         * WebKitTestRunner/mac/TestControllerMac.mm:
2514         * WebKitTestRunner/ios/TestControllerIOS.mm:
2515         Move code into TestControllerCocoa.
2516
2517         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2518         (WTR::InjectedBundle::beginTesting):
2519         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2520         (WTR::TestRunner::addUserScript):
2521         (WTR::TestRunner::addUserStyleSheet):
2522         Adopt WKBundlePage API for user scripts/sheets.
2523
2524         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2525         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2526         Make and keep a WKWebView instead of a WKView.
2527         
2528         * WebKitTestRunner/mac/EventSenderProxy.mm:
2529         (WTR::EventSenderProxy::mouseUp):
2530         (WTR::EventSenderProxy::mouseMoveTo):
2531         Reach inside the WKWebView to the WKView when dispatching events.
2532         This is fairly ugly and we should come up with a better solution.
2533         Also, fix some flipping and style errors.
2534
2535 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
2536
2537         Unreviewed, attempt to fix GTK build after r188718
2538
2539         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2540         (WTR::PlatformWebView::PlatformWebView):
2541
2542 2015-08-21  Commit Queue  <commit-queue@webkit.org>
2543
2544         Unreviewed, rolling out r188807, r188813, and r188815.
2545         https://bugs.webkit.org/show_bug.cgi?id=148349
2546
2547         lots of 32-bit build problems, better to resolve separately
2548         and try again (Requested by thorton on #webkit).
2549
2550         Reverted changesets:
2551
2552         "WebKitTestRunner should use WKWebView on OS X and iOS"
2553         https://bugs.webkit.org/show_bug.cgi?id=143743
2554         http://trac.webkit.org/changeset/188807
2555
2556         "Stop building WebKitTestRunner for 32-bit platforms"
2557         https://bugs.webkit.org/show_bug.cgi?id=143743
2558         http://trac.webkit.org/changeset/188813
2559
2560         "Stop building WebKitTestRunner for 32-bit platforms"
2561         https://bugs.webkit.org/show_bug.cgi?id=143743
2562         http://trac.webkit.org/changeset/188815
2563
2564 2015-08-21  Tim Horton  <timothy_horton@apple.com>
2565
2566         Stop building WebKitTestRunner for 32-bit platforms
2567         https://bugs.webkit.org/show_bug.cgi?id=143743
2568         <rdar://problem/16947123>
2569
2570         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2571         This is a restriction on the valid set, not the desired set.
2572
2573 2015-08-21  Jason Marcell  <jmarcell@apple.com>
2574
2575         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
2576         to work with these new objects.
2577         https://bugs.webkit.org/show_bug.cgi?id=148188
2578
2579         Reviewed by Daniel Bates.
2580
2581         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2582         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
2583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2584         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
2585         (repository, "branch name")-pair.
2586         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
2587         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2588         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
2589         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2590         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
2591         objects which represent a (repository, "branch name")-pair.
2592         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2593         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
2594         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
2595         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
2596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
2597         BuildbotQueue.branch to BuildbotQueue.branches.
2598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2599         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
2600
2601 2015-08-21  Tim Horton  <timothy_horton@apple.com>
2602
2603         Stop building WebKitTestRunner for 32-bit platforms
2604         https://bugs.webkit.org/show_bug.cgi?id=143743
2605         <rdar://problem/16947123>
2606
2607         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2608         WKWebView is not available on 32-bit OS X.
2609
2610 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
2611
2612         [Win] Unreviewed test correction after r188709.
2613
2614         I removed a function argument that happened to be mirrored by a global
2615         value with the same name. This prevented a compile error, but testing
2616         showed that the wrong value was being used in the function.
2617
2618         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2619         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
2620         back
2621
2622 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
2623
2624         WebKitTestRunner should use WKWebView on OS X and iOS
2625         https://bugs.webkit.org/show_bug.cgi?id=143743
2626         <rdar://problem/16947123>
2627
2628         Reviewed by Anders Carlsson.
2629         Patch by Enrica Casucci and myself.
2630
2631         * WebKitTestRunner/PlatformWebView.h:
2632         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
2633         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
2634         instead of WKContext and WKPageGroup.
2635
2636         Remove the unused, always-true windowSnapshotEnabled().
2637         While technically some platforms don't have window snapshotting,
2638         they just return null instead of implementing windowSnapshotEnabled().
2639
2640         * WebKitTestRunner/TestController.h:
2641         * WebKitTestRunner/TestController.cpp:
2642         (WTR::TestController::createOtherPage):
2643         (WTR::TestController::initialize):
2644         (WTR::TestController::createWebViewWithOptions):
2645         Delegate to the various platforms for creating PlatformWebView instances,
2646         for creating WKContexts, and for accessing WKPreferences,
2647         so that they can do special things (like, use WKWebView instead!).
2648
2649         (WTR::TestController::resetPreferencesToConsistentValues):
2650         Make explicit WebKitTestRunner's desired default for two preferences
2651         which have differing defaults between the antique and modern API,
2652         for consistency's sake.
2653
2654         (WTR::TestController::resetStateToConsistentValues):
2655         Add platformResetStateToConsistentValues.
2656
2657         * WebKitTestRunner/TestInvocation.cpp:
2658         (WTR::TestInvocation::dumpResults):
2659         Adjust to the aforementioned removal of windowSnapshotEnabled().
2660
2661         * WebKitTestRunner/ios/TestControllerCocoa.mm:
2662         (WTR::TestController::platformResetStateToConsistentValues):
2663         (WTR::TestController::platformPreferences):
2664         (WTR::TestController::platformCreateWebView):
2665         (WTR::TestController::platformCreateOtherPage):
2666         (WTR::TestController::platformInitializeConfiguration):
2667         Implement the new platform functions for the Modern WebKit2 API,
2668         in a new TestControllerCocoa file that is shared between iOS and Mac.
2669         
2670         For platformMaybeCreateContext, use the trick that we know we can cast
2671         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
2672         WKWebView's configuration.
2673
2674         Ditto for WKPreferencesRef and WKPreferences.
2675
2676         Remove user content filters on the WKWebView's userContentController.
2677
2678         * WebKitTestRunner/mac/TestControllerMac.mm:
2679         * WebKitTestRunner/ios/TestControllerIOS.mm:
2680         Move code into TestControllerCocoa.
2681
2682         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2683         (WTR::InjectedBundle::beginTesting):
2684         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2685         (WTR::TestRunner::addUserScript):
2686         (WTR::TestRunner::addUserStyleSheet):
2687         Adopt WKBundlePage API for user scripts/sheets.
2688
2689         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2690         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2691         Make and keep a WKWebView instead of a WKView.
2692         
2693         * WebKitTestRunner/mac/EventSenderProxy.mm:
2694         (WTR::EventSenderProxy::mouseUp):
2695         (WTR::EventSenderProxy::mouseMoveTo):
2696         Reach inside the WKWebView to the WKView when dispatching events.
2697         This is fairly ugly and we should come up with a better solution.
2698         Also, fix some flipping and style errors.
2699
2700 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
2701
2702         Improve how UI events are dispatched by WebKitTestRunner
2703         https://bugs.webkit.org/show_bug.cgi?id=148326
2704
2705         Reviewed by Anders Carlsson.
2706
2707         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2708         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2709         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
2710         asynchronous (and really, it has always been for the most part).
2711
2712         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2713         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
2714         (WTR::EventSendingController::mouseUp): Ditto.
2715         (WTR::EventSendingController::mouseMoveTo): Ditto.
2716         (WTR::EventSendingController::mouseForceDown): Ditto.
2717         (WTR::EventSendingController::mouseForceUp): Ditto.
2718         (WTR::EventSendingController::mouseForceChanged): Ditto.
2719         (WTR::EventSendingController::leapForward): Ditto.
2720         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
2721         (WTR::EventSendingController::keyDown): Ditto.
2722         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
2723         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
2724         to be done in custom WebKit2 code for test wheel event handling.
2725         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
2726         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
2727         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
2728         (WTR::EventSendingController::addTouchPoint): Ditto.
2729         (WTR::EventSendingController::updateTouchPoint): Ditto.
2730         (WTR::EventSendingController::setTouchModifier): Ditto.
2731         (WTR::EventSendingController::setTouchPointRadius): Ditto.
2732         (WTR::EventSendingController::touchStart): Ditto.
2733         (WTR::EventSendingController::touchMove): Ditto.
2734         (WTR::EventSendingController::touchEnd): Ditto.
2735         (WTR::EventSendingController::touchCancel): Ditto.
2736         (WTR::EventSendingController::clearTouchPoints): Ditto.
2737         (WTR::EventSendingController::releaseTouchPoint): Ditto.
2738         (WTR::EventSendingController::cancelTouchPoint): Ditto.
2739
2740         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2741         (WTR::InjectedBundle::postSetWindowIsKey):
2742         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2743         (WTR::InjectedBundle::isGeolocationProviderActive):
2744         (WTR::InjectedBundle::shouldProcessWorkQueue):
2745         Updated for WKBundlePagePostSynchronousMessage renaming.
2746
2747         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2748         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
2749
2750         * WebKitTestRunner/TestController.cpp:
2751         (WTR::TestController::initialize): Allow handling the new test style messages.
2752         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
2753         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
2754         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2755         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
2756         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
2757
2758         * WebKitTestRunner/mac/EventSenderProxy.mm:
2759         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
2760         (WTR::EventSenderProxy::keyDown): Ditto.
2761         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
2762         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2763
2764 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2765
2766         Skip no-llint tests that fail due to running out of executable memory after r188969
2767         https://bugs.webkit.org/show_bug.cgi?id=148273
2768
2769         Reviewed by Michael Saboff.
2770
2771         * Scripts/run-jsc-stress-tests:
2772
2773 2015-08-21  Nan Wang  <n_wang@apple.com>
2774
2775         [Mac] accessibility/selection-states.html fails
2776         https://bugs.webkit.org/show_bug.cgi?id=116637
2777
2778         Reviewed by Chris Fleizach.
2779
2780         Implemented isSelectable() and isMultiSelectable().
2781
2782         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2783         (AccessibilityUIElement::isSelectable):
2784         (AccessibilityUIElement::isMultiSelectable):
2785         (AccessibilityUIElement::isSelectedOptionActive):
2786         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2787         (WTR::AccessibilityUIElement::isSelectable):
2788         (WTR::AccessibilityUIElement::isMultiSelectable):
2789         (WTR::AccessibilityUIElement::isVisible):
2790
2791 2015-08-21  Jason Marcell  <jmarcell@apple.com>
2792
2793         Fix iteration over repositories on bot watcher's dashboard.
2794
2795         Reviewed by Alexey Proskuryakov.
2796
2797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2798         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
2799
2800 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
2801
2802         [EFL] Revise PlatformWebView ctor according to r188718
2803         https://bugs.webkit.org/show_bug.cgi?id=148282
2804
2805         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
2806         instead of WKContextRef and WKPageGroupRef respectively.
2807
2808         Reviewed by Gyuyoung Kim.
2809
2810         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2811         (WTR::PlatformWebView::PlatformWebView):
2812
2813 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
2814
2815         Unreviewed, changed Devin Rousso's email.
2816
2817         * Scripts/webkitpy/common/config/contributors.json:
2818
2819 2015-08-20  Anders Carlsson  <andersca@apple.com>
2820
2821         Use WKPageConfigurationRef in WebKitTestRunner
2822         https://bugs.webkit.org/show_bug.cgi?id=147996
2823
2824         Reviewed by Tim Horton.
2825
2826         * WebKitTestRunner/TestController.cpp:
2827         (WTR::TestController::createOtherPage):
2828         (WTR::TestController::initialize):
2829         (WTR::TestController::createWebViewWithOptions):
2830         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2831         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
2832         (WTR::PlatformWebView::PlatformWebView):
2833         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
2834
2835 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
2836
2837         [Win] Update Windows tools for revised MIDL interfaces
2838         https://bugs.webkit.org/show_bug.cgi?id=148249
2839
2840         Reviewed by Dean Jackson.
2841
2842         This is a follow-up to Bug 148001.
2843
2844         Revise the testing software to use compatible signatures and
2845         implementations to match the requirements of the IDL generated
2846         with the SAL annotations.
2847
2848         * DumpRenderTree/win/DRTDataObject.cpp:
2849         * DumpRenderTree/win/DRTDataObject.h:
2850         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2851         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2852         * DumpRenderTree/win/DRTDropSource.cpp:
2853         * DumpRenderTree/win/DRTDropSource.h:
2854         * DumpRenderTree/win/DumpRenderTree.cpp:
2855         * DumpRenderTree/win/EditingDelegate.cpp:
2856         * DumpRenderTree/win/EditingDelegate.h:
2857         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2858         * DumpRenderTree/win/FrameLoadDelegate.h:
2859         * DumpRenderTree/win/HistoryDelegate.cpp:
2860         * DumpRenderTree/win/HistoryDelegate.h:
2861         * DumpRenderTree/win/PolicyDelegate.cpp:
2862         * DumpRenderTree/win/PolicyDelegate.h:
2863         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2864         * DumpRenderTree/win/ResourceLoadDelegate.h:
2865         * DumpRenderTree/win/TestRunnerWin.cpp:
2866         * DumpRenderTree/win/UIDelegate.cpp:
2867         * DumpRenderTree/win/UIDelegate.h:
2868         * WinLauncher/AccessibilityDelegate.cpp:
2869         * WinLauncher/AccessibilityDelegate.h:
2870         * WinLauncher/Common.cpp:
2871         * WinLauncher/DOMDefaultImpl.cpp:
2872         * WinLauncher/DOMDefaultImpl.h:
2873         * WinLauncher/PageLoadTestClient.cpp:
2874         * WinLauncher/PageLoadTestClient.h:
2875         * WinLauncher/PrintWebUIDelegate.cpp:
2876         * WinLauncher/PrintWebUIDelegate.h:
2877         * WinLauncher/ResourceLoadDelegate.cpp:
2878         * WinLauncher/ResourceLoadDelegate.h:
2879         * WinLauncher/WebDownloadDelegate.cpp:
2880         * WinLauncher/WebDownloadDelegate.h:
2881         * WinLauncher/WinLauncherWebHost.cpp:
2882         * WinLauncher/WinLauncherWebHost.h:
2883         * WinLauncher/WinMain.cpp:
2884         * win/DLLLauncher/DLLLauncherMain.cpp:
2885
2886 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
2887
2888         Unreviewed, shorten a test that runs too long and times out.
2889
2890         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2891         (TestWebKitAPI::TEST):
2892
2893 2015-08-20  Alex Christensen  <achristensen@webkit.org>
2894
2895         Clean up CMake build after r188673
2896         https://bugs.webkit.org/show_bug.cgi?id=148234
2897
2898         Reviewed by Tim Horton.
2899
2900         * DumpRenderTree/PlatformWin.cmake:
2901         * TestWebKitAPI/CMakeLists.txt:
2902         * TestWebKitAPI/PlatformWin.cmake:
2903         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
2904         gtest needs to be a static library on Windows to not crash.
2905
2906 2015-08-19  Alex Christensen  <achristensen@webkit.org>
2907
2908         CMake Windows build should not include files directly from other Source directories
2909         https://bugs.webkit.org/show_bug.cgi?id=148198
2910
2911         Reviewed by Brent Fulgham.
2912
2913         * DumpRenderTree/DumpRenderTreePrefix.h:
2914         Include cmakeconfig.h to properly define all enabled features.
2915         * DumpRenderTree/PlatformWin.cmake:
2916         * TestWebKitAPI/PlatformWin.cmake:
2917
2918 2015-08-19  Alex Christensen  <achristensen@webkit.org>
2919
2920         Build TestWTF on Mac with CMake.
2921         https://bugs.webkit.org/show_bug.cgi?id=147972
2922
2923         Reviewed by Tim Horton.
2924
2925         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
2926         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
2927
2928         * TestWebKitAPI/CMakeLists.txt:
2929         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
2930         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
2931         * TestWebKitAPI/PlatformMac.cmake: Added.
2932         * TestWebKitAPI/config.h:
2933         Postpone some build fixes until WebKit builds completely on Mac with CMake.
2934
2935 2015-08-19  Brian Burg  <bburg@apple.com>
2936
2937         Unreviewed, add Aleksandr Skachkov to the list of contributors.
2938
2939         * Scripts/webkitpy/common/config/contributors.json:
2940
2941 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2942
2943         REGRESSION(r188548): [GTK] Build broken.
2944         https://bugs.webkit.org/show_bug.cgi?id=148154
2945
2946         Reviewed by Martin Robinson.
2947
2948         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2949         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2950         Even if we don't need to add/override any settings in ViewOptions,
2951         we need to define this as an empty function to make it build.
2952
2953 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2954
2955         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
2956         https://bugs.webkit.org/show_bug.cgi?id=148073
2957
2958         Reviewed by Alexey Proskuryakov.
2959
2960         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
2961         (TestWebKitAPI::TEST):
2962
2963 2015-08-18  Anders Carlsson  <andersca@apple.com>
2964
2965         Fix test failure fallout from r188602 by using a V5 page ui client struct.
2966
2967         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2968         (TestWebKitAPI::setUpClients):
2969
2970 2015-08-18  Brian Burg  <bburg@apple.com>
2971
2972         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
2973         https://bugs.webkit.org/show_bug.cgi?id=147955
2974
2975         Reviewed by Timothy Hatcher.
2976
2977         To enable sharing of common test code between protocol and model tests,
2978         start loading the protocol TestStub.js through the WebInspectorUI bundle.
2979
2980         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
2981         protocol-test.js uses to load the inspector frontend stub into its iframe
2982         from an arbitrary local file URL.
2983
2984         * DumpRenderTree/TestRunner.cpp:
2985         (getInspectorTestStubURLCallback):
2986         (TestRunner::staticValues):
2987         * DumpRenderTree/TestRunner.h:
2988         * DumpRenderTree/mac/TestRunnerMac.mm:
2989         (SOFT_LINK_STAGED_FRAMEWORK):
2990         (TestRunner::inspectorTestStubURL):
2991         * DumpRenderTree/win/TestRunnerWin.cpp:
2992         (TestRunner::inspectorTestStubURL):
2993         * WebKitTestRunner/Configurations/Base.xcconfig:
2994         Since WebKitTestRunner now includes WebCore private headers, also search
2995         for the WebCore framework inside the WebKit umbrella framework.
2996
2997         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2998         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2999         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3000         (WTR::TestRunner::inspectorTestStubURL):
3001         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3002         (WTR::TestRunner::inspectorTestStubURL):
3003         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3004         (WTR::TestRunner::inspectorTestStubURL):
3005
3006 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
3007
3008         Unreviewed, fix GTK build.
3009
3010         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3011         (TestWebKitAPI::TEST):
3012
3013 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
3014
3015         Replace all remaining uses of WTF::Mutex with WTF::Lock
3016         https://bugs.webkit.org/show_bug.cgi?id=148089
3017
3018         Reviewed by Geoffrey Garen.
3019
3020         * DumpRenderTree/JavaScriptThreading.cpp:
3021         (javaScriptThreadsMutex):
3022         (runJavaScriptThread):
3023         (startJavaScriptThreads):
3024         (stopJavaScriptThreads):
3025         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
3026         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3027         (TestWebKitAPI::TEST):
3028         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3029         (TestWebKitAPI::TEST):
3030
3031 2015-08-17  Commit Queue  <commit-queue@webkit.org>
3032
3033         Unreviewed, rolling out r188539, r188544, r188552, and
3034         r188564.
3035         https://bugs.webkit.org/show_bug.cgi?id=148122
3036
3037         Broke tests and some build styles (Requested by ap on
3038         #webkit).
3039
3040         Reverted changesets:
3041
3042         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
3043         bundle"
3044         https://bugs.webkit.org/show_bug.cgi?id=147955
3045         http://trac.webkit.org/changeset/188539
3046
3047         "Web Inspector: split TestStub.js into multiple files and
3048         modernize it"
3049         https://bugs.webkit.org/show_bug.cgi?id=148077
3050         http://trac.webkit.org/changeset/188544
3051
3052         "Web Inspector: InspectorTest should be a subclass of
3053         TestHarness"
3054         https://bugs.webkit.org/show_bug.cgi?id=148079
3055         http://trac.webkit.org/changeset/188552
3056
3057         "Unreviewed internal build fix attempt after r188539."
3058         http://trac.webkit.org/changeset/188564
3059
3060 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
3061
3062         [OS X] Remove support for composite fonts
3063         https://bugs.webkit.org/show_bug.cgi?id=147920
3064
3065         Reviewed by Dan Bernstein.
3066
3067         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3068         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
3069         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3070         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3071         * DumpRenderTree/mac/DumpRenderTree.mm:
3072         (allowedFontFamilySet): Deleted.
3073         (activateTestingFonts): Deleted.
3074         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3075         (WTR::allowedFontFamilySet): Deleted.
3076         (WTR::activateFonts): Deleted.
3077         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3078         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
3079         * WebKitTestRunner/mac/TestControllerMac.mm:
3080         (WTR::allowedFontFamilySet): Deleted.
3081
3082 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
3083
3084         Unreviewed internal build fix attempt after r188539.
3085
3086         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3087
3088 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
3089
3090         Fix the build
3091
3092         Unreviewed.
3093
3094         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3095
3096 2015-08-17  Alex Christensen  <achristensen@webkit.org>
3097
3098         Build Debug Suffix on Windows with CMake
3099         https://bugs.webkit.org/show_bug.cgi?id=148083
3100
3101         Reviewed by Brent Fulgham.
3102
3103         * TestWebKitAPI/CMakeLists.txt:
3104         * TestWebKitAPI/PlatformWin.cmake:
3105         Add DEBUG_SUFFIX
3106
3107 2015-08-17  Anders Carlsson  <andersca@apple.com>
3108
3109         Simplify how PlatformWebViews are created when view options change
3110         https://bugs.webkit.org/show_bug.cgi?id=148093
3111
3112         Reviewed by Sam Weinig.
3113
3114         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
3115
3116         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
3117         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
3118         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
3119
3120         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
3121
3122         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
3123         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
3124
3125         * WebKitTestRunner/TestController.cpp:
3126         (WTR::TestController::ensureViewSupportsOptionsForTest):
3127         (WTR::shouldUseFixedLayout):
3128         (WTR::TestController::viewOptionsForTest):
3129         (WTR::TestController::updateWebViewSizeForTest):
3130         (WTR::TestController::updateWindowScaleForTest):
3131         (WTR::TestController::configureViewForTest):
3132         (WTR::TestController::initialize): Deleted.
3133         (WTR::TestController::ensureViewSupportsOptions): Deleted.
3134         (WTR::TestController::updateLayoutTypeForTest): Deleted.
3135         (WTR::TestController::platformConfigureViewForTest): Deleted.
3136         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
3137         (WTR::TestController::run): Deleted.
3138         * WebKitTestRunner/TestController.h:
3139         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3140         (WTR::shouldUseFixedLayout):
3141         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3142         (WTR::TestController::platformConfigureViewForTest):
3143         (WTR::TestController::platformResetPreferencesToConsistentValues):
3144         * WebKitTestRunner/ios/TestControllerIOS.mm:
3145         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3146         * WebKitTestRunner/mac/TestControllerMac.mm:
3147         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
3148         (WTR::TestController::platformConfigureViewForTest):
3149
3150 2015-08-17  Sam Weinig  <sam@webkit.org>
3151
3152         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
3153         https://bugs.webkit.org/show_bug.cgi?id=148097
3154
3155         Reviewed by Anders Carlsson.
3156
3157         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
3158         Add tests for WebsiteDataStores in the WKPageConfiguration.
3159
3160 2015-08-17  Brian Burg  <bburg@apple.com>
3161
3162         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
3163         https://bugs.webkit.org/show_bug.cgi?id=147955
3164
3165         Reviewed by Timothy Hatcher.
3166
3167         To enable sharing of common test code between protocol and model tests,
3168         start loading the protocol TestStub.js through the WebInspectorUI bundle.
3169
3170         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
3171         protocol-test.js uses to load the inspector frontend stub into its iframe
3172         from an arbitrary local file URL.
3173
3174         * DumpRenderTree/TestRunner.cpp:
3175         (getInspectorTestStubURLCallback):
3176         (TestRunner::staticValues):
3177         * DumpRenderTree/TestRunner.h:
3178         * DumpRenderTree/mac/TestRunnerMac.mm:
3179         (SOFT_LINK_STAGED_FRAMEWORK):
3180         (TestRunner::inspectorTestStubURL):
3181         * DumpRenderTree/win/TestRunnerWin.cpp:
3182         (TestRunner::inspectorTestStubURL):
3183         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3184         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3185         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3186         (WTR::TestRunner::inspectorTestStubURL):
3187         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3188         (WTR::TestRunner::inspectorTestStubURL):
3189         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3190         (WTR::TestRunner::inspectorTestStubURL):
3191
3192 2015-08-17  Saam barati  <sbarati@apple.com>
3193
3194         Change email address from saambarati1@gmail.com to sbarati@apple.com
3195
3196         * Scripts/webkitpy/common/config/contributors.json:
3197
3198 2015-08-17  Jason Marcell  <jmarcell@apple.com>
3199
3200         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
3201         repositories other than "openSource" and "internal".
3202         https://bugs.webkit.org/show_bug.cgi?id=147961
3203
3204         Reviewed by Daniel Bates.
3205
3206         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3207         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
3208         generically with repositories other than "openSource" and "internal".
3209
3210 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
3211
3212         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
3213         https://bugs.webkit.org/show_bug.cgi?id=148081
3214
3215         Reviewed by Tim Horton.
3216
3217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3218         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3219
3220 2015-08-11  Andy Estes  <aestes@apple.com>
3221
3222         [Cocoa] Add redirect support to CustomProtocolManager
3223         https://bugs.webkit.org/show_bug.cgi?id=147871
3224
3225         Reviewed by Dan Bernstein.
3226
3227         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
3228
3229         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3230         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
3231         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
3232         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3233         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
3234         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
3235         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
3236         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
3237         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
3238         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3239         (TestWebKitAPI::TEST): Unregistered TestProtocol.
3240         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
3241         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
3242         (-[TestProtocol startLoading]): Taught to handle redirect responses.
3243
3244 2015-08-13  Andy Estes  <aestes@apple.com>
3245
3246         [Cocoa] Downloads do not start if policy decision is made asynchronously
3247         https://bugs.webkit.org/show_bug.cgi?id=147985
3248
3249         Reviewed by Brady Eidson.
3250
3251         Added a new API test.
3252
3253         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3254         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3255         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
3256         (TEST):
3257
3258 2015-08-14  Commit Queue  <commit-queue@webkit.org>
3259
3260         Unreviewed, rolling out r187357.
3261         https://bugs.webkit.org/show_bug.cgi?id=148032
3262
3263         webkit-patch generates incorrect patches that cannot be
3264         applied (Requested by dydz on #webkit).
3265
3266         Reverted changeset:
3267
3268         "Call fixChangeLogPatch when generating patches from webkit-
3269         patch"
3270         https://bugs.webkit.org/show_bug.cgi?id=147248
3271         http://trac.webkit.org/changeset/187357
3272
3273 2015-08-14  Jason Marcell  <jmarcell@apple.com>
3274
3275         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
3276         other than "openSource" and "internal".
3277         https://bugs.webkit.org/show_bug.cgi?id=147938
3278
3279         Reviewed by Daniel Bates.
3280
3281         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3282         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
3283         repositories other than "openSource" and "internal".
3284
3285 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
3286
3287         Unreviewed, shorten another test that is timing out.
3288
3289         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3290         (TestWebKitAPI::TEST):
3291
3292 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
3293
3294         AppScale: Assertion hit when hovering a webkit-queue bubble
3295         https://bugs.webkit.org/show_bug.cgi?id=147997
3296
3297         Reviewed by Alexey Proskuryakov.
3298
3299         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
3300         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
3301
3302 2015-08-13  Lucas Forschler  <lforschler@apple.com>
3303
3304         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
3305         
3306         Unreviewed.
3307         
3308         * Scripts/copy-webkitlibraries-to-product-directory:
3309
3310 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
3311
3312         Run benchmark customized Dromaeo should not assume there is an internet connection.
3313         https://bugs.webkit.org/show_bug.cgi?id=147995
3314
3315         Reviewed by Ryosuke Niwa.
3316
3317         Add several dependency js libs to local.
3318
3319         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
3320
3321 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
3322
3323         WTF should have a compact Condition object to use with Lock
3324         https://bugs.webkit.org/show_bug.cgi?id=147986
3325
3326         Reviewed by Geoffrey Garen.
3327
3328         Add a test for WTF::Condition.
3329
3330         * TestWebKitAPI/CMakeLists.txt:
3331         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3333         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
3334         (TestWebKitAPI::TEST):
3335         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3336         (TestWebKitAPI::runLockTest): Change the name of the thread.
3337
3338 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
3339
3340         Unreviewed, shorten another test. It's timing out in debug on some bot.
3341
3342         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3343         (TestWebKitAPI::TEST):
3344
3345 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
3346
3347         WTF::Lock should not suffer from the thundering herd
3348         https://bugs.webkit.org/show_bug.cgi?id=147947
3349
3350         Reviewed by Geoffrey Garen.
3351
3352         Add testing that checks that locks return to a pristine state after contention is over.
3353
3354         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3355         (TestWebKitAPI::LockInspector::isFullyReset):
3356         (TestWebKitAPI::runLockTest):
3357         (TestWebKitAPI::TEST):
3358
3359 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
3360
3361         Benchmarks supported by run_benchmark script should not assume we have internet access.
3362         https://bugs.webkit.org/show_bug.cgi?id=147959
3363
3364         Reviewed by Ryosuke Niwa.
3365
3366         For JSBench we should not request jquery.min.js from google through the internet.
3367
3368         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
3369
3370 2015-08-12  Jason Marcell  <jmarcell@apple.com>
3371
3372         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
3373         other than "openSource" and "internal".
3374         https://bugs.webkit.org/show_bug.cgi?id=147796
3375
3376         Reviewed by Daniel Bates.
3377
3378         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3379         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
3380         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
3381         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
3382         and another assertion that, if the previousIteration is non-null, the given repository is in
3383         previousIteration.revision.
3384         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
3385         with repositories other than "openSource" and "internal". Also added an assertion that the returned
3386         fragment has at least one child node.
3387
3388 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
3389
3390         Add a tool that dumps class and struct member layout, showing padding
3391         https://bugs.webkit.org/show_bug.cgi?id=147898
3392
3393         Reviewed by Zalan Bujtas.
3394         
3395         This 'dump-class-layout' script uses the lldb Python bindings to collect data
3396         about data member layout, and displays it.
3397         
3398         Sample output:
3399
3400               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
3401               +0 < 56>     WebCore::URL m_value;
3402               +0 <  8>         WTF::String m_string;
3403               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
3404               +0 <  8>                 WTF::StringImpl * m_ptr;
3405               +8 <  1>         bool:1 m_isValid;
3406               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
3407               +9 <  3>         <PADDING>
3408              +12 <  4>         int m_schemeEnd;
3409              +16 <  4>         int m_userStart;
3410              +20 <  4>         int m_userEnd;
3411              +24 <  4>         int m_passwordEnd;
3412              +28 <  4>         int m_hostEnd;
3413              +32 <  4>         int m_portEnd;
3414              +36 <  4>         int m_pathAfterLastSlash;
3415              +40 <  4>         int m_pathEnd;
3416              +44 <  4>         int m_queryEnd;
3417              +48 <  4>         int m_fragmentEnd;
3418              +52 <  4>         <PADDING>
3419              +52 <  4>     <PADDING>
3420              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
3421              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
3422             Total byte size: 72
3423             Total pad bytes: 11
3424             Padding percentage: 15.28 %
3425
3426         * Scripts/dump-class-layout: Added.
3427         (webkit_build_dir):
3428         (developer_dir):
3429         (import_lldb):
3430         (find_build_directory):
3431         (verify_type):
3432         (verify_type_recursive):
3433         (dump_class):
3434         (main):
3435         (main.or):
3436
3437 2015-08-12  Alex Christensen  <achristensen@webkit.org>
3438
3439         Fix Debug CMake builds on Windows
3440         https://bugs.webkit.org/show_bug.cgi?id=147940
3441
3442         Reviewed by Chris Dumez.
3443
3444         * DumpRenderTree/PlatformWin.cmake:
3445         * TestWebKitAPI/PlatformWin.cmake:
3446         The BitmapImage test is not enabled on the AppleWin port.
3447         * WinLauncher/CMakeLists.txt:
3448         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
3449
3450 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3451
3452         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
3453
3454         In r188125 I added a way to mark tests as slow to use a longer
3455         timeout. But it seems it was not enough for
3456         WTF_Lock.ContendedShortSection, so let's try again with a longer
3457         timeout now.
3458
3459         * Scripts/run-gtk-tests:
3460         (TestRunner._run_google_test):
3461
3462 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
3463
3464         Allow --debug option in run-jsc
3465         https://bugs.webkit.org/show_bug.cgi?id=147923
3466
3467         Reviewed by Csaba Osztrogonác.
3468
3469         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
3470
3471         * Scripts/run-jsc:
3472
3473 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3474
3475         Fix test after build fix in r188286.
3476         https://bugs.webkit.org/show_bug.cgi?id=147907
3477
3478         Reviewed by Anders Carlsson.
3479
3480         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3481         sleep_for can now be used, but we need to include <thread>
3482
3483 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
3484
3485         Always use a byte-sized lock implementation
3486         https://bugs.webkit.org/show_bug.cgi?id=147908
3487
3488         Reviewed by Geoffrey Garen.
3489
3490         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
3491         now tests of Lock.
3492
3493         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3494         (TestWebKitAPI::runLockTest):
3495         (TestWebKitAPI::TEST):
3496
3497 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
3498
3499         Make ASan build not depend on asan.xcconfig
3500         https://bugs.webkit.org/show_bug.cgi?id=147840
3501         rdar://problem/21093702
3502
3503         Reviewed by Daniel Bates.
3504
3505         * asan/asan.xcconfig:
3506         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
3507         are now marked in source code.
3508
3509 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
3510
3511         Unreviewed, shorten another test since it timed out.
3512
3513         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3514         (TestWebKitAPI::TEST):
3515
3516 2015-08-11  Mark Lam  <mark.lam@apple.com>
3517
3518         Fix names of Lock tests: should be "Contended", not "Contented".
3519         https://bugs.webkit.org/show_bug.cgi?id=147905
3520
3521         Reviewed by Saam Barati.
3522
3523         We're testing the behavior of lock contention (i.e. when threads contend), not
3524         whether the locks are happy (contented).
3525
3526         * Scripts/run-gtk-tests:
3527         (TestRunner):
3528         (TestRunner.__init__): Deleted.
3529         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3530         (TestWebKitAPI::runLockTest):
3531         (TestWebKitAPI::TEST):
3532
3533 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3534
3535         Update WinCairoRequirements to VS2015.
3536
3537         * Scripts/update-webkit-wincairo-libs:
3538         Update WinCairoRequirements location.
3539
3540 2015-08-11  Jason Marcell  <jmarcell@apple.com>
3541
3542         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
3543         for internalTrac.
3544         https://bugs.webkit.org/show_bug.cgi?id=147805
3545
3546         Reviewed by Daniel Bates.
3547
3548         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3549         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
3550         Dashboard.Repository.Internal.trac for internalTrac.
3551         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
3552         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
3553         respectively.
3554         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
3555         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
3556         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
3557         internalTrac.
3558         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
3559         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
3560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3561         (Analyzer): Ditto.
3562         (Analyzer.prototype.analyze): Ditto.
3563
3564 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
3565
3566         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
3567