Standardize the usage of "branch" vs. "branchName". https://bugs.webkit.org/show_bug...
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-14  Jason Marcell  <jmarcell@apple.com>
2
3         Standardize the usage of "branch" vs. "branchName".
4         https://bugs.webkit.org/show_bug.cgi?id=152982
5
6         Reviewed by Daniel Bates.
7
8         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
9         "branchName" implies that the variable or property in question is simply a string.
10
11         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
12         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
13         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
14         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
15         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
16         (Trac.prototype.commitsOnBranch): Change branch to branchName.
17         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
18         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
19         (MockTrac): Ditto.
20
21 2016-01-14  Jason Marcell  <jmarcell@apple.com>
22
23         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
24         https://bugs.webkit.org/show_bug.cgi?id=152910
25
26         Reviewed by Daniel Bates.
27
28         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
29         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
30         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
31         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
32         the need to talk to a real Buildbot server.
33         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
34         without the need to talk to a real Buildbot server.
35         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
36         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
37         server.
38         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
39         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
40         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
41         trying to talk to Trac.
42         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
43         QUnit unit tests.
44         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
45
46 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
47
48         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
49         https://bugs.webkit.org/show_bug.cgi?id=132599
50
51         Reviewed by Michael Catanzaro.
52
53         Check if cmake Ninja generators are installed.
54
55         * Scripts/webkitdirs.pm:
56         (canUseNinjaGenerator):
57         (canUseEclipseNinjaGenerator):
58         (generateBuildSystemFromCMakeProject):
59         (canUseEclipse): Deleted.
60
61 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
62
63         [Cocoa] Testing with font family name "System Font" is unused
64         https://bugs.webkit.org/show_bug.cgi?id=153073
65         <rdar://problem/24091683>
66
67         Reviewed by Brent Fulgham.
68
69         * DumpRenderTree/mac/DumpRenderTree.mm:
70         (allowedFontFamilySet): Deleted.
71         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
72         (WTR::allowedFontFamilySet): Deleted.
73         * WebKitTestRunner/mac/TestControllerMac.mm:
74         (WTR::allowedFontFamilySet): Deleted.
75
76 2016-01-13  Daniel Bates  <dabates@apple.com>
77
78         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
79         https://bugs.webkit.org/show_bug.cgi?id=152871
80
81         Reviewed by Brent Fulgham.
82
83         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
84         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
85
86         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
87
88 2016-01-08  Andy Estes  <aestes@apple.com>
89
90         [Content Filtering] Lazily load platform frameworks
91         https://bugs.webkit.org/show_bug.cgi?id=152881
92         rdar://problem/23270886
93
94         Reviewed by Brady Eidson.
95
96         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
97         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
98         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
99         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
100         is loaded after an HTTPS request.
101
102         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
103         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
104         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
105         also re-enabled on iOS after mistakenly being disabled by r188892.
106
107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
108         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
109         (TestWebKitAPI::TEST):
110         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
111         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
112         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
113         (TEST):
114         (downloadTest):
115         (-[LazilyLoadPlatformFrameworksController init]):
116         (-[LazilyLoadPlatformFrameworksController webView]):
117         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
118         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
119         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
120         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
121         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
122         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
123         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
124         (TestWebKitAPI::TEST):
125         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
126         (TestWebKitAPI::TEST): Deleted.
127         * TestWebKitAPI/cocoa/TestProtocol.h:
128         * TestWebKitAPI/cocoa/TestProtocol.mm:
129         (+[TestProtocol registerWithScheme:]):
130         (+[TestProtocol unregister]):
131
132 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
133
134         Fix the Sunpider converage in slow device.
135         https://bugs.webkit.org/show_bug.cgi?id=152938
136         <rdar://problem/22511411>
137
138         Reviewed by Ryosuke Niwa.
139
140         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
141
142         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
143
144 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
145
146         Add a build flag for custom element
147         https://bugs.webkit.org/show_bug.cgi?id=153005
148
149         Reviewed by Alex Christensen.
150
151         Added --custom-elements option to enable custom elements support.
152
153         * Scripts/webkitperl/FeatureList.pm:
154
155 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
156
157         [JSC] Add a help message when run-jsc-stress-tests fails
158         https://bugs.webkit.org/show_bug.cgi?id=153014
159
160         Reviewed by Csaba Osztrogonác.
161
162         * Scripts/run-jsc-stress-tests:
163
164 2016-01-11  Saam barati  <sbarati@apple.com>
165
166         run-jsc-stress-tests should try to figure out a JSC path
167         https://bugs.webkit.org/show_bug.cgi?id=152971
168
169         Reviewed by Yusuke Suzuki.
170
171         This patch now allows run-jsc-stress-tests to be run
172         without a "--jsc <jsc-path>" argument. It tries
173         to take its best guess at a <jsc-path> automagically.
174         
175         This makes it much easier to just run run-jsc-stress-tests
176         with a directory or a yaml file as an argument.
177         You now just do this:
178         `run-jsc-stress-tests <path-to-yaml>`
179         or
180         `run-jsc-stress-tests <path-to-directory-of-js-files>`
181         
182         I wrote this patch because I'd often find myself hacking the 
183         run-javascriptcore-tests file just to run a particular subset of tests.
184         Because I always forget the arguments to run-jsc-stress-tests (which means
185         I always forgot to provide a --jsc argument), I always found it easier to 
186         just hack on that file instead of calling run-jsc-stress-tests directly.
187         No longer is this true!
188
189         * Scripts/run-jsc-stress-tests:
190
191 2016-01-09  Andy Estes  <aestes@apple.com>
192
193         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
194         https://bugs.webkit.org/show_bug.cgi?id=152950
195         rdar://problem/24066652
196
197         Reviewed by Tim Horton.
198
199         Added an API test.
200
201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
202         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
203         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
204         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
205         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
206         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
207         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
208         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
209         (TEST):
210
211 2016-01-11  Commit Queue  <commit-queue@webkit.org>
212
213         Unreviewed, rolling out r194866.
214         https://bugs.webkit.org/show_bug.cgi?id=152986
215
216         This change broke the mac build (Requested by ryanhaddad on
217         #webkit).
218
219         Reverted changeset:
220
221         "[Cocoa] Add SPI to opt out a URL scheme from the memory
222         cache"
223         https://bugs.webkit.org/show_bug.cgi?id=152950
224         http://trac.webkit.org/changeset/194866
225
226 2016-01-11  Andy Estes  <aestes@apple.com>
227
228         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
229         https://bugs.webkit.org/show_bug.cgi?id=152950
230         rdar://problem/24066652
231
232         Reviewed by Tim Horton.
233
234         Added an API test.
235
236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
237         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
238         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
239         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
240         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
241         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
242         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
243         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
244         (TEST):
245
246 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
247
248         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
249         https://bugs.webkit.org/show_bug.cgi?id=152959
250
251         Reviewed by Brent Fulgham.
252
253         * Scripts/webkitdirs.pm:
254         (determineArchitecture):
255
256 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
257
258         [GTK] W3C CSS2.1 anonymous table tests are failing
259         https://bugs.webkit.org/show_bug.cgi?id=152455
260
261         Reviewed by Mario Sanchez Prada.
262
263         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
264         tests. Add upstream patches to fix detection of XHTML files.
265
266         * gtk/jhbuild.modules:
267         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
268         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
269
270 2016-01-10  Saam barati  <sbarati@apple.com>
271
272         Implement a sampling profiler
273         https://bugs.webkit.org/show_bug.cgi?id=151713
274
275         Reviewed by Filip Pizlo.
276
277         * Scripts/run-jsc-stress-tests:
278
279 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
280
281         [webkitdirs] Try arch and uname commands on non-windows OS
282         https://bugs.webkit.org/show_bug.cgi?id=152958
283
284         Reviewed by Michael Catanzaro.
285
286         Right now, determineArchitecture()  uses `arch` and `uname -m`
287         commands to determine architecture in case of condition (isGtk() ||
288         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
289         instead, because this code is applicable to any non-windows OS WebKit
290         supports (even Haiku which once was supported is moderately
291         POSIX-compliant and has uname command).
292
293         * Scripts/webkitdirs.pm:
294         (determineArchitecture):
295
296 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
297
298         run-webkit-tests mis-counts totals when there are other crashes
299         https://bugs.webkit.org/show_bug.cgi?id=152894
300         <rdar://problem/24098697>
301
302         Reviewed by Alexey Proskuryakov.
303
304         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
305         (TestRunResults.add): Do not update result counters for other crashes.
306
307 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
308
309         webkit-patch build-and-test should have an option to iterate over new tests
310         https://bugs.webkit.org/show_bug.cgi?id=143093
311
312         Reviewed by Michael Catanzaro.
313
314         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
315         It allows running run-webkit-tests on modified or new paths in LayoutTests.
316         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
317         It implements the translation of -expected.* paths to their related tests.
318         It also implements the removal of skipped tests.
319
320         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
321         (LayoutTestFinder.find_touched_tests):
322         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
323         (MockPort):
324         (MockPort.__init__):
325         (MockPort.tests):
326         (LayoutTestFinderTests):
327         (LayoutTestFinderTests.touched_files):
328         (LayoutTestFinderTests.test_touched_test):
329         (LayoutTestFinderTests.test_expected_touched_test):
330         (LayoutTestFinderTests.test_platform_expected_touched_test):
331         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
332         (LayoutTestFinderTests.test_touched_but_skipped_test):
333         * Scripts/webkitpy/port/base.py:
334         (Port.potential_test_names_from_expected_file):
335         * Scripts/webkitpy/tool/commands/download_unittest.py:
336         (DownloadCommandsTest._default_options):
337         * Scripts/webkitpy/tool/steps/options.py:
338         (Options):
339         * Scripts/webkitpy/tool/steps/runtests.py:
340         (RunTests.options):
341         (RunTests.run):
342         (RunTests):
343         (RunTests._new_or_modified_tests):
344         (RunTests._run_webkit_tests):
345         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
346         (RunTestsTest.test_webkit_run_unit_tests):
347         * Scripts/webkitpy/tool/steps/steps_unittest.py:
348         (StepsTest._step_options):
349
350 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
351
352         prepare-ChangeLog should include radar number
353         https://bugs.webkit.org/show_bug.cgi?id=152839
354         <rdar://problem/24093563>
355
356         Reviewed by Daniel Bates.
357
358         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
359         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
360         in the ChangeLog description after the bug URL.
361
362         * Scripts/prepare-ChangeLog:
363         (main): Update signatures.
364         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
365         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
366         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
367         (generateNewChangeLogs): Include radar URL if we found one.
368
369         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
370         Tests for the radar URL extraction.
371
372 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
373
374         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
375         https://bugs.webkit.org/show_bug.cgi?id=152390
376         <rdar://problem/23948321>
377
378         Reviewed by Simon Fraser.
379
380         Fix two use-after-frees.
381
382         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
383         but we may have already progressed to another test by the time the callback fires,
384         having destroyed the TestInvocation.
385         2. UIScriptController is a RefCounted object, but it has a raw pointer to
386         UIScriptContext which has the same lifetime as a TestInvocation.
387         As a result, completion blocks of UIScriptController actions would use a destroyed
388         TestInvocation.
389
390         * WebKitTestRunner/TestInvocation.cpp:
391         (WTR::TestInvocation::~TestInvocation):
392         (WTR::TestInvocation::url):
393         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
394         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
395         (WTR::TestInvocation::runUISideScript):
396         * WebKitTestRunner/TestInvocation.h:
397         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
398         (UIScriptContext::UIScriptContext):
399         (UIScriptContext::~UIScriptContext):
400         (UIScriptContext::runUIScript):
401         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
402         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
403         (WTR::UIScriptController::UIScriptController):
404         (WTR::UIScriptController::contextDestroyed):
405         (WTR::UIScriptController::makeWindowObject):
406         (WTR::UIScriptController::setWillBeginZoomingCallback):
407         (WTR::UIScriptController::willBeginZoomingCallback):
408         (WTR::UIScriptController::setDidEndZoomingCallback):
409         (WTR::UIScriptController::didEndZoomingCallback):
410         (WTR::UIScriptController::setDidEndScrollingCallback):
411         (WTR::UIScriptController::didEndScrollingCallback):
412         (WTR::UIScriptController::setDidShowKeyboardCallback):
413         (WTR::UIScriptController::didShowKeyboardCallback):
414         (WTR::UIScriptController::setDidHideKeyboardCallback):
415         (WTR::UIScriptController::didHideKeyboardCallback):
416         (WTR::UIScriptController::uiScriptComplete):
417         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
418         (WTR::UIScriptController::create):
419         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
420         (WTR::UIScriptController::doAsyncTask):
421         (WTR::UIScriptController::zoomToScale):
422         (WTR::UIScriptController::singleTapAtPoint):
423         (WTR::UIScriptController::doubleTapAtPoint):
424         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
425         (WTR::UIScriptController::contentVisibleRect):
426         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
427         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
428         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
429         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
430         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
431         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
432         (WTR::UIScriptController::doAsyncTask):
433
434 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
435
436         [buildbot] clean-build script should remove untracked files and revert local changes too
437         https://bugs.webkit.org/show_bug.cgi?id=142400
438
439         Reviewed by Ryosuke Niwa.
440
441         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
442         A helper routine SCM.discard_untracked_files is added for that purpose.
443
444         * BuildSlaveSupport/clean-build:
445         (main): Making call to Scripts/clean-webkit
446         * Scripts/clean-webkit: Added.
447         (main): Revert changes and delete untracked files.
448         * Scripts/webkitpy/common/checkout/scm/scm.py:
449         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
450         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
451         (SCMTest._shared_test_discard_untracked_files):
452         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
453
454 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
455
456         Add a setting and preferences to enable display-list drawing. Does nothing yet.
457         https://bugs.webkit.org/show_bug.cgi?id=152807
458
459         Reviewed by Zalan Bujtas.
460         
461         Add an item to the Settings menu to toggle display-list drawing.
462
463         * MiniBrowser/mac/SettingsController.h:
464         * MiniBrowser/mac/SettingsController.m:
465         (-[SettingsController _populateMenu]):
466         (-[SettingsController validateMenuItem:]):
467         (-[SettingsController toggleDisplayListDrawingEnabled:]):
468         (-[SettingsController displayListDrawingEnabled]):
469         * MiniBrowser/mac/WK2BrowserWindowController.m:
470         (-[WK2BrowserWindowController didChangeSettings]):
471
472 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
473
474         Python SCM should be able to retrieve untracked files - Add GIT support
475         https://bugs.webkit.org/show_bug.cgi?id=143135
476
477         Reviewed by Michael Catanzaro.
478
479         * Scripts/webkitpy/common/checkout/scm/git.py:
480         (Git.untracked_files): Adding support for git.
481         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
482         (GitTest.setUp):
483         (GitTest.test_untracked_files): Adding test.
484
485 2016-01-05  Mark Lam  <mark.lam@apple.com>
486
487         Rename badly named JSC_timeout env var to JSCTEST_timeout.
488         https://bugs.webkit.org/show_bug.cgi?id=152748
489
490         Reviewed by Geoffrey Garen.
491
492         Now that we validate JSC options, the badly named JSC_timeout env var causes the
493         bots to have a bad time.
494
495         * Scripts/run-javascriptcore-tests:
496         * Scripts/run-jsc-stress-tests:
497
498 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
499
500         [GTK] Allow to save and restore session
501         https://bugs.webkit.org/show_bug.cgi?id=115600
502
503         Reviewed by Michael Catanzaro.
504
505         Add test case to check the new session API.
506
507         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
508         (testWebKitWebViewSessionState):
509         (testWebKitWebViewSessionStateWithFormData):
510         (beforeAll):
511
512 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
513
514         [EFL] Bump EFL version to 1.16.1
515         https://bugs.webkit.org/show_bug.cgi?id=152688
516
517         Reviewed by Gyuyoung Kim.
518
519         * efl/jhbuild.modules:
520
521 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
522
523         error running layout tests on iOS simulator on latest build
524         https://bugs.webkit.org/show_bug.cgi?id=152719
525         <rdar://problem/24009549>
526
527         Reviewed by Alexey Proskuryakov.
528
529         * Scripts/webkitpy/xcode/simulator.py:
530         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
531           before running simctl spawn command.
532
533 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
534
535         Unreviewed, move Frédéric Wang to committers list
536
537         He seems to be on the contributors list by accident. He has been landing his own commits for
538         about two years now.
539
540         * Scripts/webkitpy/common/config/contributors.json:
541
542 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
543
544         Unreviewed, move Sebastian Dröge to committers list harder
545
546         He accidentally added himself to the reviewers list because the file is confusing. Then I
547         accidentially moved him to the contributors list because the file is confusing, even though
548         I knew the contributors list existed in this file and was attempting to add him to the
549         committers list. Really move him to the committers list now.
550
551         * Scripts/webkitpy/common/config/contributors.json:
552
553 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
554
555         Python SCM should be able to retrieve untracked files - Add SVN support
556         https://bugs.webkit.org/show_bug.cgi?id=152546
557
558         Reviewed by Michael Catanzaro.
559
560         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
561         (test_untracked_files): Activating test for SVN.
562         * Scripts/webkitpy/common/checkout/scm/svn.py:
563         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
564
565 2015-12-31  Andy Estes  <aestes@apple.com>
566
567         Replace WTF::move with WTFMove
568         https://bugs.webkit.org/show_bug.cgi?id=152601
569
570         Reviewed by Brady Eidson.
571
572         * DumpRenderTree/TestRunner.h:
573         (TestRunner::setAllowedHosts):
574         * DumpRenderTree/win/DRTDataObject.cpp:
575         (DRTDataObject::SetData):
576         * TestWebKitAPI/Tests/WTF/Deque.cpp:
577         (TestWebKitAPI::TEST):
578         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
579         (TestWebKitAPI::TEST):
580         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
581         (TestWebKitAPI::TEST):
582         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
583         (TestWebKitAPI::TEST):
584         * TestWebKitAPI/Tests/WTF/Ref.cpp:
585         (TestWebKitAPI::passWithRef):
586         (TestWebKitAPI::TEST):
587         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
588         (TestWebKitAPI::TEST):
589         * TestWebKitAPI/Tests/WTF/Vector.cpp:
590         (TestWebKitAPI::TEST):
591         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
592         (TestWebKitAPI::TEST):
593         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
594         (TestWebKitAPI::TEST):
595         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
596         (TestWebKitAPI::createTestValue):
597         (TestWebKitAPI::TEST):
598         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
599         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
600         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
601         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
602         (TestWebKitAPI::createNFAs):
603         (TestWebKitAPI::TEST_F):
604         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
605         (TestWebKitAPI::combine):
606         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
607         (TestWebKitAPI::createNFAs):
608         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
609         (TEST):
610         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
611         (WebProcessTest::add):
612
613 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
614
615         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
616         https://bugs.webkit.org/show_bug.cgi?id=152634
617
618         Reviewed by Carlos Garcia Campos.
619
620         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
621         (testLoadFromGResource): Added test.
622         (beforeAll):
623         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
624         (registerGResource): Added.
625         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
626         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
627         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
628
629 2015-12-31  David Kilzer  <ddkilzer@apple.com>
630
631         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
632         <https://bugs.webkit.org/show_bug.cgi?id=152601>
633
634         Ignore unknown pragmas on older clangs.  Fixes the following
635         build failure:
636
637             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
638             #pragma clang diagnostic ignored "-Wself-move"
639                                              ^
640             1 error generated.
641
642         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
643         (TestWebKitAPI::TEST):
644         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
645         (TestWebKitAPI::TEST):
646
647 2015-12-31  Andy Estes  <aestes@apple.com>
648
649         Update the style checker to advise using WTFMove() instead of WTF::move()
650         https://bugs.webkit.org/show_bug.cgi?id=152601
651
652         Reviewed by Daniel Bates.
653
654         * Scripts/webkitpy/style/checkers/cpp.py:
655         (check_wtf_move):
656         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
657         (WebKitStyleTest.test_wtf_move):
658
659 2015-12-31  Andy Estes  <aestes@apple.com>
660
661         Fix warnings uncovered by migrating to WTF_MOVE
662         https://bugs.webkit.org/show_bug.cgi?id=152601
663
664         Reviewed by Daniel Bates.
665
666         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
667         self-move, even if doing so would trigger a warning.
668
669         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
670         (TestWebKitAPI::TEST):
671         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
672         (TestWebKitAPI::TEST):
673
674 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
675
676         [GTK] The install-dependencies script has a syntax error
677         https://bugs.webkit.org/show_bug.cgi?id=152613
678
679         Reviewed by Michael Catanzaro.
680
681         * gtk/install-dependencies: Add the missing 'then.'
682
683 2015-12-30  Philippe Normand  <pnormand@igalia.com>
684
685         [Mac][GTK] Jhbuild support for OSX
686         https://bugs.webkit.org/show_bug.cgi?id=150799
687
688         Reviewed by Michael Catanzaro.
689
690         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
691         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
692         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
693         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
694
695 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
696
697         Unreviewed, move Sebastian Dröge to committers list
698
699         He accidentally added himself to the reviewers list because the file is confusing.
700
701         * Scripts/webkitpy/common/config/contributors.json:
702
703 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
704
705         Remove the unused #define _USE_MATH_DEFINES
706         https://bugs.webkit.org/show_bug.cgi?id=152034
707
708         Reviewed by Tim Horton.
709         
710         Update this test to use piDouble from MathExtras.h, and
711         std::numeric_limits<>.
712
713         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
714
715 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
716
717         Python SCM should be able to retrieve untracked files - Generic changes
718         https://bugs.webkit.org/show_bug.cgi?id=152536
719
720         Reviewed by Brent Fulgham.
721
722         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
723         No support is yet added to GIT and SVN specific implementations.
724
725         * Scripts/webkitpy/common/checkout/scm/scm.py:
726         (SCM.untracked_files):
727         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
728         (SCMTest._shared_test_untracked_files):
729
730 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
731
732         SVN checkout used by RunBenchmark should be non-interactive
733         https://bugs.webkit.org/show_bug.cgi?id=152542
734
735         Reviewed by Ryosuke Niwa.
736
737         RunBenchmark should not require user interaction while running.
738
739         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
740         (BenchmarkBuilder._checkout_with_subversion):
741
742 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
743
744         Web Inspector: add support for running protocol-test.js tests on Windows
745         https://bugs.webkit.org/show_bug.cgi?id=148037
746         <rdar://problem/22292237>
747
748         Reviewed by Simon Fraser.
749
750         * DumpRenderTree/win/TestRunnerWin.cpp:
751         (TestRunner::inspectorTestStubURL): Provide implementation.
752
753 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
754
755         [MediaStream] MediaDeviceInfo.label must be empty in some situations
756         https://bugs.webkit.org/show_bug.cgi?id=152000
757
758         Reviewed by Brent Fulgham.
759
760         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
761         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
762         (WTR::InjectedBundle::setUserMediaPermission):
763         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
764         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
765
766         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
767         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
768         * WebKitTestRunner/InjectedBundle/TestRunner.h:
769
770         * WebKitTestRunner/TestController.cpp:
771         (WTR::TestController::setUserMediaPermissionForOrigin):
772         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
773         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
774           persistent permission for origin, that can be done from script now.
775         * WebKitTestRunner/TestController.h:
776
777         * WebKitTestRunner/TestInvocation.cpp:
778         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
779           SetUserMediaPermissionForOrigin.
780
781 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
782
783         [Win] Unreviewed build fix: Recognize Windows 10 variants.
784
785         * Scripts/webkitpy/common/system/platforminfo.py:
786         (PlatformInfo._determine_win_version):
787
788 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
789
790         Content blockers should be able to promote http to https
791         https://bugs.webkit.org/show_bug.cgi?id=148966
792
793         Reviewed by Benjamin Poulain.
794
795         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
796         (WebCore::ContentExtensions::operator<<):
797         (TestWebKitAPI::TEST_F):
798
799 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
800
801         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
802         https://bugs.webkit.org/show_bug.cgi?id=152516
803
804         Reviewed by Gyuyoung Kim.
805
806         * MiniBrowser/efl/main.c:
807
808 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
809
810         Unreviewed: Add John Wilander as a contributor.
811
812         * Scripts/webkitpy/common/config/contributors.json:
813
814 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
815
816         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
817         https://bugs.webkit.org/show_bug.cgi?id=152482
818
819         Reviewed by Brent Fulgham.
820
821         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
822         for the same property. On WK2, the element returned will not be valid, but is still present and
823         that can lead to looping.
824
825         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
826         (AccessibilityUIElement::horizontalScrollbar):
827         (AccessibilityUIElement::verticalScrollbar):
828         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
829         (WTR::AccessibilityUIElement::horizontalScrollbar):
830         (WTR::AccessibilityUIElement::verticalScrollbar):
831
832 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
833
834         Unreviewed.
835
836         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
837
838 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
839
840         [EFL] test_ewk2_context failed after r192808
841         https://bugs.webkit.org/show_bug.cgi?id=151846
842
843         Reviewed by Gyuyoung Kim.
844
845         Used the added ewk_context_web_process_count_limit_set api
846         instead of the deprecated ewk_context_process_model_set.
847
848         * MiniBrowser/efl/main.c:
849         (elm_main):
850
851 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
852
853         Unreviewed, move myself to reviewer list.
854
855         * Scripts/webkitpy/common/config/contributors.json:
856
857 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
858
859         Unreviewed, add myself to the committers list.
860
861         * Scripts/webkitpy/common/config/contributors.json:
862
863 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
864
865         [GTK] jquery.min.js violates DFSG
866         https://bugs.webkit.org/show_bug.cgi?id=152428
867
868         Reviewed by Joseph Pecoraro.
869
870         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
871         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
872
873         * gtk/manifest.txt.in:
874
875 2015-12-19  Dan Bernstein  <mitz@apple.com>
876
877         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
878         https://bugs.webkit.org/show_bug.cgi?id=152462
879
880         Reviewed by Alexey Proskuryakov.
881
882         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
883           OS X 10.9:
884
885         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
886         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
887         * MiniBrowser/Configurations/DebugRelease.xcconfig:
888         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
889         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
890
891         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
892           never getting compiled:
893
894         * DumpRenderTree/mac/TextInputController.m:
895         * MiniBrowser/mac/BrowserWindowController.m:
896         * TestWebKitAPI/Tests/mac/AttributedString.mm:
897         * WebKitTestRunner/mac/EventSenderProxy.mm:
898
899 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
900
901         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
902
903         This is to make it easy to CC it on Bugzilla.
904
905         * Scripts/webkitpy/common/config/contributors.json:
906
907 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
908
909         Pasteboard get messed up after running kill-old-processes
910         https://bugs.webkit.org/show_bug.cgi?id=152426
911
912         Reviewed by Alexey Proskuryakov.
913
914         * BuildSlaveSupport/kill-old-processes:
915         (main): Do not kill pasteboard anymore.
916
917 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
918
919         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
920         https://bugs.webkit.org/show_bug.cgi?id=152157
921         <rdar://problem/23851817>
922
923         Reviewed by Alexey Proskuryakov.
924
925         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
926         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
927         * Scripts/webkitpy/layout_tests/controllers/manager.py:
928         (Manager._get_test_inputs): Common method to calculate test_inputs.
929         (Manager._update_worker_count): Calculate and update required number of workers.
930
931 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
932
933         run-webkit-tests fails to delete Simulator device during cleanup
934         https://bugs.webkit.org/show_bug.cgi?id=152363
935
936         Reviewed by Alexey Proskuryakov.
937
938         * Scripts/webkitpy/xcode/simulator.py:
939         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
940
941 2015-12-16  Tim Horton  <timothy_horton@apple.com>
942
943         [mac-wk2] fast/events force click tests crashing
944         https://bugs.webkit.org/show_bug.cgi?id=152339
945
946         Reviewed by Beth Dakin.
947
948         * WebKitTestRunner/mac/EventSenderProxy.mm:
949         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
950         Set the NSEvent's _type member in addition to overriding -type,
951         because there are assertions in touch event handling code that depend on it.
952
953 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
954
955         Enforce temporarily bots to sync WebKit and WPT testharness.js
956         https://bugs.webkit.org/show_bug.cgi?id=152334
957
958         Reviewed by Darin Adler.
959
960         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
961         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
962
963 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
964
965         [Fetch API] Add fetch API compile time flag
966         https://bugs.webkit.org/show_bug.cgi?id=152254
967
968         Reviewed by Darin Adler.
969
970         * Scripts/webkitperl/FeatureList.pm:
971
972 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
973
974         Unreviewed.
975
976         Added files that have impact in building Streams API to the watchlist.
977
978         * Scripts/webkitpy/common/config/watchlist:
979
980 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
981
982         Unreviewed.
983
984         Added imported tests to Streams API watchlist.
985
986         * Scripts/webkitpy/common/config/watchlist:
987
988 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
989
990         Remove default copy of wpt testharness.js when launching wpt server
991         https://bugs.webkit.org/show_bug.cgi?id=152298
992
993         Reviewed by Darin Adler.
994
995         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
996         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
997
998 2015-12-15  David Kilzer  <ddkilzer@apple.com>
999
1000         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1001         <http://webkit.org/b/152314>
1002
1003         Reviewed by Daniel Bates.
1004
1005         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1006         code path to exit immediately when calling main().
1007         Unfortunately, DumpRenderTreeMain.mm was used for both
1008         DumpRenderTree command-line binary and DumpRenderTree.app, which
1009         meant that the app would exit immediately with no error code
1010         when run!
1011
1012         The workaround is to introduce a separate source file called
1013         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1014         already does.
1015
1016         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1017         DumpRenderTreeAppMain.mm to the project.  Make it the only
1018         compiled source for the DumpRenderTree.app target.
1019         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1020         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1021         case someone tries mistakenly to use the app.
1022         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1023         Link to JavaScriptCore.framework on iOS for the assert.
1024         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1025         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1026         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1027         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1028         (main): Add assert for iOS so that a crash occurs if someone
1029         tries to run the wrong command.
1030
1031 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1032
1033         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1034         https://bugs.webkit.org/show_bug.cgi?id=152266
1035         <rdar://problem/22092676>
1036
1037         Reviewed by Simon Fraser.
1038
1039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1040         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1041         Add a test that crashed before this change, and doesn't crash after.
1042
1043 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1044
1045         AX: iOS: Text field variations do not have the correct traits
1046         https://bugs.webkit.org/show_bug.cgi?id=152237
1047
1048         Reviewed by Mario Sanchez Prada.
1049
1050         Add iOS calls for determing if an object is a search field or a text area.
1051
1052         * DumpRenderTree/AccessibilityUIElement.cpp:
1053         (getIsSearchFieldCallback):
1054         (getIsTextAreaCallback):
1055         (stringForSelectionCallback):
1056         (AccessibilityUIElement::getJSClass):
1057         * DumpRenderTree/AccessibilityUIElement.h:
1058         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1059         (AccessibilityUIElement::identifier):
1060         (AccessibilityUIElement::isTextArea):
1061         (AccessibilityUIElement::isSearchField):
1062         (AccessibilityUIElement::traits):
1063         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1064         (WTR::AccessibilityUIElement::scrollPageRight):
1065         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1066         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1067         (WTR::AccessibilityUIElement::isSearchField):
1068         (WTR::AccessibilityUIElement::isTextArea):
1069         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1070         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1071         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1072         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1073         (WTR::AccessibilityUIElement::isTextArea):
1074         (WTR::AccessibilityUIElement::isSearchField):
1075         (WTR::AccessibilityUIElement::rowCount):
1076
1077 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1078
1079         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1080         https://bugs.webkit.org/show_bug.cgi?id=152252
1081
1082         Reviewed by Sergio Villar Senin.
1083
1084         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1085         for building the JHBuild on Debian systems.
1086
1087 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1088
1089         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1090         https://bugs.webkit.org/show_bug.cgi?id=152156
1091
1092         Reviewed by Dan Bernstein.
1093
1094         Our frameworks should appropriately prefix all ObjC classes,
1095         not just external symbols.
1096
1097         * Scripts/check-for-inappropriate-objc-class-names:
1098         Remove the -g switch to check all ObjC class names.
1099
1100 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1101
1102         [MediaStream] Expose media capture devices persistent permissions to WebCore
1103         https://bugs.webkit.org/show_bug.cgi?id=152087
1104
1105         Add support for the new user media permission checker page UI client method.
1106
1107         Reviewed by Chris Dumez.
1108
1109         * WebKitTestRunner/TestController.cpp:
1110         (WTR::decidePolicyForUserMediaPermissionRequest):
1111         (WTR::checkUserMediaPermissionForOrigin):
1112         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1113         (WTR::TestController::createWebViewWithOptions): Ditto.
1114         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1115         (WTR::originUserVisibleName): New, create a string for the origin.
1116         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1117           according to the state of the origin permission map.
1118         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1119           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1120         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1121           origin permission map.
1122         * WebKitTestRunner/TestController.h:
1123
1124 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1125
1126         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1127         https://bugs.webkit.org/show_bug.cgi?id=152022
1128         rdar://problem/23763584
1129
1130         Reviewed by Darin Adler.
1131
1132         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1133         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1134         (WTR::InjectedBundlePage::willSendRequestForFrame):
1135         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1136         (WTR::TestRunner::setWillSendRequestReturnsNull):
1137         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1138         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1139         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1140         (WTR::TestRunner::willSendRequestHTTPBody):
1141         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1142
1143 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1144
1145         Remove additional simulator checks before running layout-tests
1146         https://bugs.webkit.org/show_bug.cgi?id=152146
1147
1148         Reviewed by Darin Adler.
1149
1150         * Scripts/webkitpy/port/ios.py:
1151         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1152         * Scripts/webkitpy/xcode/simulator.py:
1153         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1154         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1155
1156 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1157
1158         Run atleast one simulator even if max process limit is low
1159         https://bugs.webkit.org/show_bug.cgi?id=152081
1160         <rdar://problem/23819694>
1161
1162         Reviewed by Alexey Proskuryakov.
1163
1164 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1165
1166         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1167         https://bugs.webkit.org/show_bug.cgi?id=144262
1168
1169         Reviewed by Carlos Garcia Campos.
1170
1171         Added new unit test to check the additional scenarios we now
1172         handle for custom URI schemes.
1173
1174         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1175         (generateHTMLContent): New helper function to generate big enough content.
1176         (testWebContextURIScheme): New unit test.
1177
1178 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1179
1180         [EFL] Fix unhandled web process message when launching MiniBrowser
1181         https://bugs.webkit.org/show_bug.cgi?id=152048
1182
1183         Reviewed by Gyuyoung Kim.
1184
1185         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1186         (TestWebKitAPI::TEST):
1187
1188 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1189
1190         [GTK] Add API to handle beforeunload events
1191         https://bugs.webkit.org/show_bug.cgi?id=139090
1192
1193         Reviewed by Gustavo Noronha Silva.
1194
1195         * MiniBrowser/gtk/BrowserWindow.c:
1196         (browserWindowConstructed):
1197         (browserWindowDeleteEvent):
1198         (browser_window_class_init):
1199         Handle delete-event to prevent the window from being closed when
1200         the page has beforeunload handlers. Use
1201         webkit_web_view_try_close() when the window is requested to be
1202         closed.
1203         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1204         (testWebViewJavaScriptDialogs):
1205         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1206         script dialog type.
1207
1208 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1209
1210         Refactored initialization code in LoadTrackingTest.
1211
1212         Rubber-stamped by Carlos Garcia Campos.
1213
1214         Small refactoring to make sure that the state of a LoadTrackingTest
1215         gets properly reset before loading new web content.
1216
1217         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1218         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1219         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1220         functions and reset the remaining local variables.
1221         (LoadTrackingTest::loadURI): Call reset();
1222         (LoadTrackingTest::loadHtml): Ditto.
1223         (LoadTrackingTest::loadPlainText): Ditto.
1224         (LoadTrackingTest::loadBytes): Ditto.
1225         (LoadTrackingTest::loadRequest): Ditto.
1226         (LoadTrackingTest::reload): Ditto.
1227         (LoadTrackingTest::goBack): Ditto.
1228         (LoadTrackingTest::goForward): Ditto.
1229
1230 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1231
1232         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1233         https://bugs.webkit.org/show_bug.cgi?id=151942
1234
1235         Reviewed by Darin Adler.
1236
1237         * MiniBrowser/efl/main.c:
1238         (window_create): Enable offline web application cache feature on MiniBrowser.
1239         (elm_main):
1240
1241 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1242
1243         https://bugs.webkit.org/show_bug.cgi?id=151243
1244         <rdar://problem/22955197>
1245
1246         Reviewed by Alexey Proskuryakov.
1247
1248         * LayoutTestRelay/LayoutTestRelay/main.m:
1249         (getTestingSimDevice): Use separate testing device for each worker.
1250         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1251         (Manager.run): Perform cleanup even if setup fails.
1252         * Scripts/webkitpy/port/ios.py:
1253         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1254         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1255         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1256         (IOSSimulatorPort._quit_ios_simulator): Same
1257         (IOSSimulatorPort.clean_up_test_run): Same
1258         (IOSSimulatorPort.check_sys_deps): Same
1259         (IOSSimulatorPort.testing_device): Same
1260         (IOSSimulatorPort.reset_preferences): Same
1261         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1262         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1263         * Scripts/webkitpy/xcode/simulator.py:
1264         (Device.delete): Delete the simulator device.
1265         (Simulator.delete_device): Same
1266         (Simulator.wait_until_device_is_booted): Wait for device booting.
1267
1268 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1269
1270         [EFL] Add API to provide preferences before creating ewk_view
1271         https://bugs.webkit.org/show_bug.cgi?id=151587
1272
1273         Reviewed by Gyuyoung Kim.
1274
1275         * MiniBrowser/efl/main.c:
1276         (on_key_down):
1277         (quit):
1278         (window_create):
1279         Moved settings related code to configuration() not to update settings
1280         whenever ewk_view is created.
1281         (configuration):
1282         (elm_main):
1283
1284 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1285
1286         Unreviewed. Fix GTK+ API tests after r193639.
1287
1288         The new jhbuild version needs some more variables ot be present in
1289         the builtin dict, even if they are set to None.
1290
1291         * jhbuild/jhbuildutils.py:
1292         (enter_jhbuild_environment_if_available):
1293
1294 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1295
1296         [GTK] Notify WebCore when notification is clicked
1297         https://bugs.webkit.org/show_bug.cgi?id=151951
1298
1299         Reviewed by Carlos Garcia Campos.
1300
1301         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1302         (testWebViewNotification): test the new API.
1303
1304 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1305
1306         'jhbuild build' should fail immediately when building any module fails
1307         https://bugs.webkit.org/show_bug.cgi?id=145697
1308
1309         Reviewed by Carlos Garcia Campos.
1310
1311         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1312         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1313         Everything is placed under lib instead of lib64 now.
1314         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1315         --exit-on-error when running 'jhbuild build'.
1316         * jhbuild/jhbuildrc_common.py:
1317         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1318         jhbuild should be able to handle these for us without breaking things....
1319
1320 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1321
1322         Add support to import w3c tests from a repository with a different root that the main repo dir
1323         https://bugs.webkit.org/show_bug.cgi?id=151751
1324
1325         Reviewed by Ryosuke Niwa and Youenn Fablet.
1326
1327         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1328         in a different directory than the repository root.
1329
1330         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1331         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1332         requires having the copy_path lists including tuples of origin and destination directories.
1333
1334         * Scripts/webkitpy/w3c/test_downloader.py:
1335         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1336         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1337         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1338         (TestImporterTest.test_tests_directory): Test.
1339
1340 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1341
1342         Mock TestRepositories in W3C importer tests
1343         https://bugs.webkit.org/show_bug.cgi?id=151938
1344
1345         Reviewed by Youenn Fablet.
1346
1347         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1348         is because the test repository method reading the file was using the filesystem directly instead of taking the
1349         host one. This patch changes that.
1350
1351         * Scripts/webkitpy/w3c/test_downloader.py:
1352         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1353         default one.
1354         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1355         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1356         (TestImporterTest.test_harnesslinks_conversion):
1357         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1358
1359 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1360
1361         TestNetscapePlugIn: Address review comment on 193607
1362         <http://webkit.org/b/151881>
1363
1364         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1365         (testSetStatus): Initializing std::unique_ptr<char[]> with
1366         nullptr is redundant.
1367
1368 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1369
1370         [GTK] Add webkit_uri_request_get_http_method
1371         https://bugs.webkit.org/show_bug.cgi?id=151601
1372
1373         Reviewed by Martin Robinson.
1374
1375         Add test case to check HTTP method of WebKitURIRequest.
1376
1377         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1378         (testURIRequestHTTPMethod):
1379         (serverCallback):
1380         (beforeAll):
1381         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1382         (sendRequestCallback):
1383
1384 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1385
1386         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1387         https://bugs.webkit.org/show_bug.cgi?id=79918
1388
1389         Reviewed by Gustavo Noronha Silva.
1390
1391         Add unit tests to check the different console messages.
1392
1393         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1394         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1395         (ConsoleMessageTest::ConsoleMessage::operator==):
1396         (ConsoleMessageTest::consoleMessageReceivedCallback):
1397         (ConsoleMessageTest::ConsoleMessageTest):
1398         (ConsoleMessageTest::~ConsoleMessageTest):
1399         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1400         (testWebKitConsoleMessageConsoleAPI):
1401         (testWebKitConsoleMessageJavaScriptException):
1402         (testWebKitConsoleMessageNetworkError):
1403         (testWebKitConsoleMessageSecurityError):
1404         (beforeAll):
1405         (afterAll):
1406         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1407         (consoleMessageSentCallback):
1408         (pageCreatedCallback):
1409
1410 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1411
1412         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1413         https://bugs.webkit.org/show_bug.cgi?id=151934
1414
1415         Reviewed by Csaba Osztrogonác.
1416
1417         * MiniBrowser/efl/main.c:
1418         (on_window_deletion): Revert the changes of r192767.
1419
1420 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1421
1422         [GTK] update-webkitgtk-libs cannot build mesa
1423         https://bugs.webkit.org/show_bug.cgi?id=151535
1424
1425         Reviewed by Martin Robinson.
1426
1427         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1428         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1429         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1430         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1431         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1432         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1433
1434         * gtk/jhbuild.modules:
1435
1436 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1437
1438         [GTK][Mac] libWebExtensionTest link error
1439         https://bugs.webkit.org/show_bug.cgi?id=150802
1440
1441         Reviewed by Carlos Garcia Campos.
1442
1443         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1444
1445 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1446
1447         TestNetscapePlugIn: Fix leaks found by static analyzer
1448         <http://webkit.org/b/151881>
1449
1450         Reviewed by Darin Adler.
1451
1452         Fixes the following leaks found by the static analyzer:
1453             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1454                     return false;
1455                            ^~~~~
1456             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1457                     return false;
1458                            ^~~~~
1459             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1460                     return false;
1461                            ^~~~~
1462
1463         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1464         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1465         early return if allocation fails.
1466         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1467         Make sure to call fclose() on filehandle, even for an early
1468         return.
1469         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1470
1471 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1472
1473         prepare-ChangeLog: Fix some warning messages when using svn
1474         <http://webkit.org/b/151914>
1475
1476         Reviewed by Daniel Bates.
1477
1478         * Scripts/prepare-ChangeLog:
1479         (generateFunctionLists): Simplify logic so that we never call
1480         normalizePath() with an undefined value.
1481         (attributeCommand): Quote $subPath for the shell so that we
1482         don't try to run "svn propget" on invalid paths.
1483
1484 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1485
1486         TestNetscapePlugIn: Fix remaining static analyzer warnings
1487         <http://webkit.org/b/151888>
1488
1489         Reviewed by Alexey Proskuryakov.
1490
1491         Fixes the following static analyzer warnings:
1492             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1493                     CRASH();
1494                     ^~~~~~~
1495             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1496                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1497                 ^~~~~~~~~~~~~~~~
1498             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1499                 return obj->pluginTest->NPP_SetWindow(window);
1500                        ^~~~~~~~~~~~~~~
1501             2 warnings generated.
1502
1503         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1504         (CRASH): Use __builtin_trap() for gcc/clang.
1505         (NPP_SetWindow): Add early return if obj is nullptr.
1506
1507 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1508
1509         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1510         https://bugs.webkit.org/show_bug.cgi?id=151797
1511
1512         Reviewed by Martin Robinson.
1513
1514         Since we switched to use the network process to run the unit tests
1515         the test /webkit2/WebKitWebResource/get-data sometimes fails and
1516         sometimes passes. We are now also getting the notification for the
1517         css image. Since we wait for 3 resources, sometimes the css image
1518         is loaded before and then checkResourceData is called for it, but
1519         not handled. When the css image is the last one loaded the test
1520         passes. So, we just need to wait for the 4 resources.
1521
1522         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1523         (testWebResourceGetData):
1524
1525 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1526
1527         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1528         <http://webkit.org/b/151845>
1529
1530         Reviewed by Simon Fraser.
1531
1532         Fixes the following static analyzer warning:
1533             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1534                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1535                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1536
1537         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1538         (createBitmapContext): Free 'buffer' after using it in logging
1539         to fix the use-after-free.  Assign a value of nullptr to buffer
1540         so we don't return with it set to a freed address.
1541
1542 2015-12-03  Jer Noble  <jer.noble@apple.com>
1543
1544         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1545         https://bugs.webkit.org/show_bug.cgi?id=151830
1546
1547         Reviewed by Anders Carlsson.
1548
1549         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1550
1551         * DumpRenderTree/mac/DumpRenderTree.mm:
1552         (resetWebPreferencesToConsistentValues):
1553         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1554         (WTR::initializeWebViewConfiguration):
1555
1556 2015-12-03  Anders Carlsson  <andersca@apple.com>
1557
1558         Remove Objective-C GC support
1559         https://bugs.webkit.org/show_bug.cgi?id=151819
1560         rdar://problem/23746991
1561
1562         Reviewed by Dan Bernstein.
1563
1564         * asan/asan.xcconfig:
1565
1566 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1567
1568         Allow nil for unspecified benchmark pathes
1569         https://bugs.webkit.org/show_bug.cgi?id=151784
1570
1571         Reviewed by Filip Pizlo.
1572
1573         `Pathname.new(nil)` will raise an error.
1574         Only generate Pathname if the benchmark path is specified.
1575
1576         * Scripts/run-jsc-benchmarks:
1577
1578 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1579
1580         [Win] Run non-http tests without Cygwin
1581         https://bugs.webkit.org/show_bug.cgi?id=151721
1582
1583         Reviewed by Andy Estes.
1584
1585         Support native 32-bit and 64-bit Python (and Perl) builds
1586         for running tests:
1587
1588         1. Use "startswith('win')", rather than "== 'win32'" to support
1589         various Windows build types.
1590         2. Supply full path for some native Windows utilities, since the
1591         path environment does not always have the specified, and they are
1592         guaranteed to exist in those specific locations.
1593         3. Make sure native Windows Python test runs pass proper environment
1594         variables to run programs.
1595         4. Append 'exe' suffix when running Windows executables.
1596         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1597         command doesn't exist.
1598         
1599         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1600         the current Perl executable, rather than requiring a new path search.
1601         * Scripts/webkitpy/common/find_files_unittest.py:
1602         (TestWinNormalize.test_win): Use startswith('win').
1603         * Scripts/webkitpy/common/prettypatch_unittest.py:
1604         (test_pretty_diff_encodings): Ditto.
1605         * Scripts/webkitpy/common/system/executive.py:
1606         (Executive._should_close_fds): Ditto.
1607         (Executive.shell_command_for_script): Use startswith('win').
1608         (Executive.kill_process): Use full path to killall executable.
1609         (Executive.check_running_pid): Use startswith('win').
1610         (Executive.running_pids): Ditto.
1611         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1612         running under native Windows Python.
1613         (Executive._child_process_encoding): Use startswith('win').
1614         (Executive._should_encode_child_process_arguments): Ditto.
1615         (Executive.popen): Recognize proper script engine on Windows, since it
1616         does not support the shebang syntax.
1617         (Executive.run_in_parallel): Use startswith('win').
1618         * Scripts/webkitpy/common/system/executive_unittest.py:
1619         (never_ending_command): Ditto.
1620         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1621         (ExecutiveTest.serial_test_kill_process): Ditto.
1622         (ExecutiveTest.serial_test_kill_all): Ditto.
1623         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1624         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1625         (main): Ditto.
1626         * Scripts/webkitpy/common/system/file_lock.py:
1627         (FileLock._create_lock): Ditto.
1628         (FileLock._remove_lock): Ditto.
1629         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1630         (RealFileSystemTest.test_chdir): Ditto.
1631         (RealFileSystemTest.test_chdir__notexists): Ditto.
1632         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1633         * Scripts/webkitpy/common/system/path_unittest.py:
1634         (AbspathTest.test_abspath_to_uri_win): Ditto.
1635         * Scripts/webkitpy/common/system/platforminfo.py:
1636         (PlatformInfo._determine_os_name): Ditto.
1637         * Scripts/webkitpy/common/system/user.py: Ditto.
1638         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1639         (ManagerTest.integration_test_needs_servers): Ditto.
1640         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1641         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1642         driver letters.
1643         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1644         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1645         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1646         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1647         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1648         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1649         (TestHttpServer.test_start_cmd): Ditto.
1650         * Scripts/webkitpy/port/base.py:
1651         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1652         and 'SYSTEMROOT' in environment passed to test runners.
1653         (Port._apache_config_file_name_for_platform): Use startswith('win').
1654         (Port._build_path): Ditto.
1655         (Port._path_to_driver): Include 'exe' suffix when running under native
1656         Windows.
1657         * Scripts/webkitpy/port/driver.py:
1658         (Driver._setup_environ_for_driver): Explicitly make some environment
1659         variables strings.
1660         * Scripts/webkitpy/port/server_process.py:
1661         (ServerProcess.__init__): Use startswith('win').
1662         * Scripts/webkitpy/port/win.py:
1663         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1664         registry key formats.
1665         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1666         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1667         and regtool on Cygwin.
1668         (WinPort.write_registry_value): Ditto.
1669         (WinPort.setup_crash_log_saving): Ditto.
1670         (WinPort.restore_crash_log_saving): Ditto.
1671         (WinPort.prevent_error_dialogs): Ditto.
1672         (WinPort.allow_error_dialogs): Ditto.
1673         (WinPort.find_system_pid): Revise to use Windows management
1674         infrastructure on native Windows, continue using 'ps' on Cygwin.
1675         (WinPort.read_registry_string): Deleted.
1676         (WinPort.write_registry_string): Deleted.
1677         * Scripts/webkitpy/test/main.py:
1678         (main): Use startswith('win').
1679         (Tester._parse_args): Ditto.
1680
1681 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1682
1683         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1684         https://bugs.webkit.org/show_bug.cgi?id=150792
1685
1686         Reviewed by Saam Barati.
1687
1688         * Scripts/webkitperl/FeatureList.pm:
1689
1690 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1691
1692         Unreviewed, rolling out r192914.
1693         https://bugs.webkit.org/show_bug.cgi?id=151734
1694
1695         JSC tests for this change are failing on 32 and 64-bit bots
1696         (Requested by ryanhaddad on #webkit).
1697
1698         Reverted changeset:
1699
1700         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1701         enable this feature"
1702         https://bugs.webkit.org/show_bug.cgi?id=150792
1703         http://trac.webkit.org/changeset/192914
1704
1705 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1706
1707         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1708         <http://webkit.org/b/151726>
1709
1710         Reviewed by Simon Fraser.
1711
1712         * WebKitTestRunner/mac/EventSenderProxy.mm:
1713         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1714         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1715
1716 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1717
1718         Give String and AtomicString an existingHash() function
1719         https://bugs.webkit.org/show_bug.cgi?id=151717
1720
1721         Reviewed by Andreas Kling.
1722
1723         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1724         (TestWebKitAPI::TEST):
1725         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1726         (TestWebKitAPI::TEST):
1727
1728 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1729
1730         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1731         https://bugs.webkit.org/show_bug.cgi?id=150792
1732
1733         Reviewed by Saam Barati.
1734
1735         * Scripts/webkitperl/FeatureList.pm:
1736
1737 2015-12-01  Sam Weinig  <sam@webkit.org>
1738
1739         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1740         <rdar://problem/23320863>
1741         https://bugs.webkit.org/show_bug.cgi?id=151708
1742
1743         Reviewed by Anders Carlsson.
1744
1745         * WebKitTestRunner/TestController.cpp:
1746         (WTR::TestController::createOtherPage):
1747         (WTR::TestController::createWebViewWithOptions):
1748         Update for new WKPageUIClient.
1749
1750 2015-12-01  Anders Carlsson  <andersca@apple.com>
1751
1752         Remove WebKit2.framework
1753         https://bugs.webkit.org/show_bug.cgi?id=151715
1754
1755         Reviewed by Dan Bernstein.
1756
1757         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1758         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1759         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1760         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1761         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1762         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1763         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1764
1765 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
1766
1767         Unreviewed common typo fix "occurance" => "occurrence".
1768
1769         * Scripts/webkitpy/tool/commands/queries.py:
1770         (FindFlakyTests._print_statistics):
1771
1772 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1773
1774         Make ProcessModel always MultipleSecondaryProcesses
1775         https://bugs.webkit.org/show_bug.cgi?id=151662
1776
1777         Reviewed by Antti Koivisto.
1778
1779         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1780         (TestWebKitAPI::TEST):
1781         * WebKitTestRunner/TestController.cpp:
1782         (WTR::TestController::generatePageConfiguration):
1783
1784 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1785
1786         Make usesNetworkProcess always true
1787         https://bugs.webkit.org/show_bug.cgi?id=151580
1788
1789         Reviewed by Darin Adler.
1790
1791         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1792         (TestWebKitAPI::TEST):
1793         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1794         (TestWebKitAPI::TEST):
1795         * WebKitTestRunner/TestController.cpp:
1796         (WTR::TestController::generatePageConfiguration):
1797
1798 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1799
1800         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1801
1802         Add a way to skip unit tests only for Debug or Release builds and
1803         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1804
1805         * Scripts/run-gtk-tests:
1806         (SkippedTest):
1807         (SkippedTest.__init__):
1808         (SkippedTest.__str__):
1809         (SkippedTest.skip_entire_suite):
1810         (SkippedTest.skip_for_build_type):
1811         (TestRunner):
1812         (TestRunner.__init__):
1813
1814 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1815
1816         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
1817
1818         It's an assert hit because we are reloading a view loaded with
1819         HTML data which is not supported. Use loadURI instead.
1820
1821         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1822         (testWebViewCustomCharset):
1823
1824 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1825
1826         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
1827         https://bugs.webkit.org/show_bug.cgi?id=151633
1828
1829         Reviewed by Csaba Osztrogonác.
1830
1831         * TestWebKitAPI/PlatformGTK.cmake:
1832         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
1833
1834 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1835
1836         [GTK] Remove the remaining uses of GMainLoopSource
1837         https://bugs.webkit.org/show_bug.cgi?id=151632
1838
1839         Reviewed by Žan Doberšek.
1840
1841         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1842         (testWebViewSyncRequestOnMaxConns):
1843         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1844         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1845         (WTR::TestRunner::TestRunner):
1846         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1847         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1848         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1849         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1850         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1851         (WTR::timeoutSource):
1852         (WTR::TestController::notifyDone):
1853         (WTR::TestController::platformRunUntil):
1854
1855 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1856
1857         [cmake] Add testb3 to the build system
1858         https://bugs.webkit.org/show_bug.cgi?id=151619
1859
1860         Reviewed by Gyuyoung Kim.
1861
1862         * Scripts/build-jsc:
1863
1864 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1865
1866         [jhbuild] Fix pixman build with clang
1867         https://bugs.webkit.org/show_bug.cgi?id=151441
1868
1869         Reviewed by Carlos Garcia Campos.
1870
1871         * efl/jhbuild.modules:
1872         * gtk/jhbuild.modules:
1873
1874 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1875
1876         Extract prependToEnvironmentVariableList
1877         <http://webkit.org/b/151536>
1878
1879         Reviewed by Daniel Bates.
1880
1881         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1882                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1883
1884         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1885         and prependToEnvironmentVariableList.
1886         (appendToEnvironmentVariableList): Simplify variable name.
1887         Switch to use $Config{path_sep}.
1888         (prependToEnvironmentVariableList): Add new method.
1889         (setupMacWebKitEnvironment): Switch to use
1890         prependToEnvironmentVariableList().
1891         (setupIOSWebKitEnvironment): Ditto.
1892
1893         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1894         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1895
1896 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1897
1898         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1899         https://bugs.webkit.org/show_bug.cgi?id=151567
1900
1901         Reviewed by Darin Adler.
1902
1903         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1904         (on_window_deletion):
1905
1906 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1907
1908         [GTK] Use the network process unconditionally
1909         https://bugs.webkit.org/show_bug.cgi?id=151541
1910
1911         Reviewed by Alex Christensen.
1912
1913         Fix TestInspectorServer test. Do not assume we already have the
1914         title we want when the page has been loaded, since the title is
1915         changed afterwards. So, check if the title has already been set,
1916         and if not wait for it.
1917
1918         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1919         (openRemoteDebuggingSession):
1920
1921 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1922
1923         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1924         https://bugs.webkit.org/show_bug.cgi?id=151532
1925
1926         Reviewed by Benjamin Poulain.
1927
1928         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1929         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1930         (TestWebKitAPI::TEST):
1931         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1932         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
1933         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
1934         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
1935         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
1936         so it was calling a function on a test object that had gone out of scope.
1937         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
1938         but that will become the default soon and that call will be removed.
1939
1940 2015-11-22  David Kilzer  <ddkilzer@apple.com>
1941
1942         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
1943         <http://webkit.org/b/151542>
1944
1945         Reviewed by Daniel Bates.
1946
1947         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1948         (base_url): Use the Port object (already passed in) to give us
1949         the path to the LayoutTests directory, which already checks for a
1950         --layout-tests-directory command-line switch.
1951         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
1952         argument since we can get this from the Port object already
1953         passed in via Port.results_directory().  Also switch to use
1954         Port.layout_tests_dir() to get the LayoutTests directory.
1955
1956         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1957         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
1958         Add test case for custom LayoutTests directory.
1959         (TestWebPlatformTestServer.test_previously_spawned_instance):
1960         Update Port object to set mock results directory as if it was
1961         set on the command-line.  Remove unneeded argument from
1962         WebPlatformTestServer constructor.
1963         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
1964
1965         * Scripts/webkitpy/port/base.py:
1966         (Port.to.start_web_platform_test_server): Remove unneeded
1967         argument from WebPlatformTestServer constuctor.
1968
1969 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1970
1971         [GTK] Some unit tests fail when using the network process
1972         https://bugs.webkit.org/show_bug.cgi?id=151490
1973
1974         Reviewed by Martin Robinson.
1975
1976         Run the soup server in a separate thread in TestResources test to
1977         avoid deadlocks.
1978
1979         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1980         /webkit2/WebKitWebResource/get-data when using the network process.
1981
1982         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1983         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1984         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1985         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1986         present, create a WorkQueue to run the server.
1987         (WebKitTestServer::run): Run the server in the work queue if it
1988         has been created.
1989         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1990         type into server options as flags.
1991
1992 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1993
1994         [GTK] ImageDiff should normalize the diff image
1995         https://bugs.webkit.org/show_bug.cgi?id=151261
1996
1997         Reviewed by Sergio Villar Senin.
1998
1999         * ImageDiff/gtk/ImageDiff.cpp:
2000         (readPixbufFromStdin): Fix memory leak.
2001         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2002         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2003
2004 == Rolled over to ChangeLog-2015-11-21 ==