Partially revert 207805 after resolution in URL spec issue 87
[WebKit-https.git] / Tools / ChangeLog
1 2016-10-28  Alex Christensen  <achristensen@webkit.org>
2
3         Partially revert 207805 after resolution in URL spec issue 87
4         https://bugs.webkit.org/show_bug.cgi?id=164142
5
6         Reviewed by Andy Estes.
7
8         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
9         (TestWebKitAPI::TEST_F):
10
11 2016-10-28  Alex Christensen  <achristensen@webkit.org>
12
13         URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
14         https://bugs.webkit.org/show_bug.cgi?id=164154
15
16         Reviewed by Andy Estes.
17
18         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
19         (TestWebKitAPI::TEST_F):
20
21 2016-10-28  Sam Weinig  <sam@webkit.org>
22
23         [WebIDL] Update parser and code generators to only access type information through the type property
24         https://bugs.webkit.org/show_bug.cgi?id=164141
25
26         Reviewed by Anders Carlsson.
27
28         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
29         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
30         Update to always access type information through type accessors. Remove use of removed
31         properties.
32
33 2016-10-28  Frederic Wang  <fwang@igalia.com>
34
35         [GTK] Upgrade HarfBuzz to version 1.3.3
36         https://bugs.webkit.org/show_bug.cgi?id=162719
37
38         Reviewed by Michael Catanzaro.
39
40         * gtk/jhbuild.modules:
41
42 2016-10-27  Chris Dumez  <cdumez@apple.com>
43
44         Regression(r203601): Caused crashes in iBooks
45         https://bugs.webkit.org/show_bug.cgi?id=164093
46         <rdar://problem/28745634>
47
48         Reviewed by Darin Adler.
49
50         Add API test coverage.
51
52         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
53         * TestWebKitAPI/Tests/mac/DOMNode.mm: Added.
54         (-[DOMNodeTest webView:didFinishLoadForFrame:]):
55         (TestWebKitAPI::TEST):
56
57 2016-10-27  Sam Weinig  <sam@webkit.org>
58
59         [WebIDL] Move code generators off of domSignature::type and onto domSignature::idlType
60         https://bugs.webkit.org/show_bug.cgi?id=164089
61
62         Reviewed by Alex Christensen.
63
64         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
65         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
66         Update for the removal of domSignature::type, and new signatures of helper predicates.
67
68 2016-10-27  Commit Queue  <commit-queue@webkit.org>
69
70         Unreviewed, rolling out r207992.
71         https://bugs.webkit.org/show_bug.cgi?id=164070
72
73         triggered aclocal version conflict (Requested by mcatanzaro on
74         #webkit).
75
76         Reverted changeset:
77
78         "[GTK] Bump glib to 2.50.1 (or find alternative solution to
79         Gtk+ CUPS build issue)"
80         https://bugs.webkit.org/show_bug.cgi?id=163689
81         http://trac.webkit.org/changeset/207992
82
83 2016-10-27  Joanmarie Diggs  <jdiggs@igalia.com>
84
85         [GTK] Bump glib to 2.50.1 (or find alternative solution to Gtk+ CUPS build issue)
86         https://bugs.webkit.org/show_bug.cgi?id=163689
87
88         Reviewed by Michael Catanzaro.
89
90         In order to fix bug #163591, we need to apply an upstream patch to GTK+.
91         But GTK+ won't build with that patch due to the following error:
92
93             m4_copy: won't overwrite defined macro: glib_DEFUN
94
95         There is an upstream GLib patch which solves that issue. We should apply
96         that patch as well, until we bump GLib to 2.50.1 or later.
97
98         * gtk/jhbuild.modules: Apply upstream GLib patch.
99         * gtk/patches/glib-deprecate-am-glib-gnu-gettext.patch: Added.
100
101 2016-10-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
102
103         Unreviewed fix of GTK and EFL test bots.
104
105         * Scripts/webkitperl/FeatureList.pm: Deactivated media-source and
106         legacy-encrypted-media by default for GTK and EFL.
107
108 2016-10-26  Yusuke Suzuki  <utatane.tea@gmail.com>
109
110         [GTK] JSC test wasm.yaml/wasm/js-api/test_basic_api.js.default-wasm and wasm.yaml/wasm/js-api/test_Module.js.default-wasm fail with Exception: ReferenceError: Can't find variable: WebAssembly
111         https://bugs.webkit.org/show_bug.cgi?id=163846
112
113         Reviewed by Michael Catanzaro.
114
115         WebAssembly is now developed for Darwin right now.
116         Disable WASM tests in the other platforms.
117
118         * Scripts/run-jsc-stress-tests:
119
120 2016-10-26  Enrique Ocaña González  <eocanha@igalia.com>
121
122         [cmake][GStreamer][MSE][EME] Build MSE and EME code after refactoring
123         https://bugs.webkit.org/show_bug.cgi?id=162928
124
125         Reviewed by Xabier Rodriguez-Calvar.
126
127         Explicitly enable MSE and EME on WebKitGTK+ buildbots.
128
129         This patch is co-authored with Philippe Normand <philn@igalia.com> (EME support).
130
131         * Scripts/webkitperl/FeatureList.pm:
132
133 2016-10-25  Antoine Quint  <graouts@apple.com>
134
135         [Modern Media Controls] Media Controller: skip back support
136         https://bugs.webkit.org/show_bug.cgi?id=163725
137         <rdar://problem/27989480>
138
139         Reviewed by Dean Jackson.
140
141         * Scripts/webkitpy/layout_tests/servers/aliases.json: Adding a new alias such that we may
142         access the modern-media-controls source files through the web server.
143
144 2016-10-19  Jer Noble  <jer.noble@apple.com>
145
146         Add WKWebView fullscreen delegate SPI
147         https://bugs.webkit.org/show_bug.cgi?id=163674
148
149         Reviewed by Anders Carlsson.
150
151         Add a new API test which verifies that the fullscreen delegate receives notifications.
152
153         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
154         (-[FullscreenDelegateMessageHandler userContentController:didReceiveScriptMessage:]):
155         (-[FullscreenDelegateMessageHandler _webViewWillEnterFullscreen:]):
156         (-[FullscreenDelegateMessageHandler _webViewDidEnterFullscreen:]):
157         (-[FullscreenDelegateMessageHandler _webViewWillExitFullscreen:]):
158         (-[FullscreenDelegateMessageHandler _webViewDidExitFullscreen:]):
159         (TestWebKitAPI::TEST):
160
161 2016-10-24  Alex Christensen  <achristensen@webkit.org>
162
163         URLParser should match old URL::parse with %2E in path
164         https://bugs.webkit.org/show_bug.cgi?id=163929
165
166         Reviewed by Alexey Proskuryakov.
167
168         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
169         (TestWebKitAPI::TEST_F):
170
171 2016-10-24  Ryan Haddad  <ryanhaddad@apple.com>
172
173         Unreviewed, rolling out r207795.
174
175         Introduced API test failures on iOS and macOS.
176
177         Reverted changeset:
178
179         "URLParser should match old URL::parse with %2E in path"
180         https://bugs.webkit.org/show_bug.cgi?id=163929
181         http://trac.webkit.org/changeset/207795
182
183 2016-10-24  Alex Christensen  <achristensen@webkit.org>
184
185         URLParser should match old URL::parse with %2E in path
186         https://bugs.webkit.org/show_bug.cgi?id=163929
187
188         Reviewed by Alexey Proskuryakov.
189
190         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
191         (TestWebKitAPI::TEST_F):
192
193 2016-10-21  Alex Christensen  <achristensen@webkit.org>
194
195         URL::port should return Optional<uint16_t>
196         https://bugs.webkit.org/show_bug.cgi?id=163806
197
198         Reviewed by Darin Adler.
199
200         * TestWebKitAPI/Tests/WebCore/URL.cpp:
201         (TestWebKitAPI::TEST_F):
202         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
203         (TestWebKitAPI::checkURL):
204         (TestWebKitAPI::checkRelativeURL):
205         (TestWebKitAPI::checkURLDifferences):
206         (TestWebKitAPI::checkRelativeURLDifferences):
207         (TestWebKitAPI::TEST_F):
208
209 2016-10-24  Youenn Fablet  <youenn@apple.com>
210
211         Activate WEB_RTC compilation flags for Mac bots
212         https://bugs.webkit.org/show_bug.cgi?id=163886
213
214         Reviewed by Eric Carlson.
215
216         * Scripts/webkitperl/FeatureList.pm:
217         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
218
219 2016-10-24  Wenson Hsieh  <wenson_hsieh@apple.com>
220
221         Unreviewed, add myself as a WebKit reviewer
222
223         * Scripts/webkitpy/common/config/contributors.json:
224
225 2016-10-22  Dan Bernstein  <mitz@apple.com>
226
227         Improve MiniBrowser window titles for URLs without paths and with no title
228         <https://webkit.org/b/163843>
229
230         Reviewed by Darin Adler.
231
232         * MiniBrowser/mac/WK1BrowserWindowController.m:
233         (-[WK1BrowserWindowController fetch:]): While we’re here, deploy
234           +[NSURL _webkit_URLWithUserTypedString:] here to match the WK2BrowserWindowController
235           version of this method.
236         (-[WK1BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
237           use the entire URL.
238         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]): Also while we’re here,
239           deploy +[NSURL _web_userVisibleString] here to match the WK2BrowserWindowController
240           behavior.
241
242         * MiniBrowser/mac/WK2BrowserWindowController.m:
243         (-[WK2BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
244           use the entire URL.
245
246 2016-10-21  David Kilzer  <ddkilzer@apple.com>
247
248         Bug 163762: IntSize::area() should used checked arithmetic
249         <https://webkit.org/b/163762>
250
251         Reviewed by Darin Adler.
252
253         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
254         (TestWebKitAPI::TEST): Call unsafeGet().
255         * TestWebKitAPI/Tests/WebCore/IntSize.cpp:
256         (TestWebKitAPI::TEST): Ditto.
257
258 2016-10-21  James Craig  <jcraig@apple.com>
259
260         Unreviewed: Added Aaron Chu <aaron_chu@apple.com> to contributors list.
261
262         * Scripts/webkitpy/common/config/contributors.json:
263
264 2016-10-21  Commit Queue  <commit-queue@webkit.org>
265
266         Unreviewed, rolling out r207582.
267         https://bugs.webkit.org/show_bug.cgi?id=163819
268
269         Not quite ready rdar://problem/28897179 (Requested by
270         alexchristensen on #webkit).
271
272         Reverted changeset:
273
274         "Re-enable URLParser for non-Safari Cocoa apps after r207321"
275         https://bugs.webkit.org/show_bug.cgi?id=163690
276         http://trac.webkit.org/changeset/207582
277
278 2016-10-21  Jonathan Bedard  <jbedard@apple.com>
279
280         WebKitTestRunnerApp packages .idl file
281         https://bugs.webkit.org/show_bug.cgi?id=163788
282
283         Reviewed by Darin Adler.
284
285         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Removed .idl file from app package, removed bad reference to app icon.
286
287 2016-10-21  Csaba Osztrogonác  <ossy@webkit.org>
288
289         [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package
290         https://bugs.webkit.org/show_bug.cgi?id=163733
291
292         Reviewed by Gyuyoung Kim.
293
294         * efl/install-dependencies: Added geoclue-2.0 package.
295
296 2016-10-21  Commit Queue  <commit-queue@webkit.org>
297
298         Unreviewed, rolling out r207609.
299         https://bugs.webkit.org/show_bug.cgi?id=163776
300
301         As glib bump was rollout, we need to rollout this too
302         (Requested by rego on #webkit).
303
304         Reverted changeset:
305
306         "[GTK] Cannot build GTK+ with CUPS 2.* versions"
307         https://bugs.webkit.org/show_bug.cgi?id=163591
308         http://trac.webkit.org/changeset/207609
309
310 2016-10-20  Chris Dumez  <cdumez@apple.com>
311
312         "Download Linked File" context menu action should use 'download' attribute as suggested filename
313         https://bugs.webkit.org/show_bug.cgi?id=163742
314         <rdar://problem/28840734>
315
316         Reviewed by Darin Adler.
317
318         Add API test coverage.
319
320         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
321         * TestWebKitAPI/Tests/WebKit2/link-with-download-attribute.html: Added.
322         * TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm: Added.
323         (TestWebKitAPI::didFinishLoadForFrame):
324         (TestWebKitAPI::getContextMenuFromProposedMenu):
325         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
326         (TestWebKitAPI::TEST):
327
328 2016-10-20  Commit Queue  <commit-queue@webkit.org>
329
330         Unreviewed, rolling out r207589.
331         https://bugs.webkit.org/show_bug.cgi?id=163765
332
333         Introduced 17 new layout test failures (Requested by
334         mcatanzaro on #webkit).
335
336         Reverted changeset:
337
338         "[GTK] Bump glib to 2.50.1"
339         https://bugs.webkit.org/show_bug.cgi?id=163689
340         http://trac.webkit.org/changeset/207589
341
342 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
343
344         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
345         https://bugs.webkit.org/show_bug.cgi?id=163374
346
347         Reviewed by Darin Adler.
348
349         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
350
351 2016-10-20  Sam Weinig  <sam@webkit.org>
352
353         Add convenience function that combines WTF::visit(...) with WTF::makeVisitor(...)
354         https://bugs.webkit.org/show_bug.cgi?id=163713
355
356         Reviewed by Dan Bernstein.
357
358         * TestWebKitAPI/Tests/WTF/Variant.cpp:
359         Add test for WTF::switchOn()
360
361 2016-10-20  Fujii Hironori  <Hironori.Fujii@sony.com>
362
363         [CMake] CMake does not support the dep files for implicit dependency
364         https://bugs.webkit.org/show_bug.cgi?id=161433
365
366         Reviewed by Brent Fulgham.
367
368         Created a Perl script to generate all IDL bindings for CMake.
369         This script can regenerate outdated bindings by based on the
370         supplemental dependency and dep files created by
371         '--write-dependencies' switch of generate-bindings.pl.
372
373         add_custom_target is used to invoke the script instead of
374         add_custom_command because Ninja deletes all output files before
375         executing the command in case of add_custom_command.
376
377         USES_TERMINAL option of add_custom_target has two effects:
378         1) Not buffering output of the command
379         2) Invoking the command in the special Ninja pool which inhibits parallel build
380         One needs to use CMake 3.2 or later to enable this feature.
381
382         * DumpRenderTree/CMakeLists.txt: Specified a target name for
383         GENERATE_BINDINGS. Added dependency for the target.
384         * WebKitTestRunner/CMakeLists.txt: Ditto.
385
386 2016-10-20  Manuel Rego Casasnovas  <rego@igalia.com>
387
388         [GTK] Cannot build GTK+ with CUPS 2.* versions
389         https://bugs.webkit.org/show_bug.cgi?id=163591
390
391         Reviewed by Michael Catanzaro.
392
393         GTK+ is wrongly checking about the available CUPS version,
394         so if you have CUPS 2.* the configure step fails.
395
396         This has been already fixed upstream and included in 2.30 series:
397         https://git.gnome.org/browse/gtk+/commit/?id=631f6b536485829a0bd00532f5826ad302b4951b
398
399         Added patch on JHBuild so we can now build GTK+ with CUPS 2.*.
400
401         * gtk/jhbuild.modules: Applied patch and avoid using "configure" script directly
402         as the patch modifies "configure.ac".
403         * gtk/patches/configure-fix-detecting-CUPS-2.x.patch: Added.
404
405 2016-10-20  Manuel Rego Casasnovas  <rego@igalia.com>
406
407         [GTK] Bump glib to 2.50.1
408         https://bugs.webkit.org/show_bug.cgi?id=163689
409
410         Reviewed by Michael Catanzaro.
411
412         This is need in order to fix GTK+ build with CUPS 2.* (bug #163591).
413
414         * gtk/jhbuild.modules: Bump glib version. Pass --disable-libmount to build properly.
415         Also we don't need the patches anymore.
416         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed.
417         * gtk/patches/glib-warning-fix.patch: Removed.
418
419 2016-10-19  Alex Christensen  <achristensen@webkit.org>
420
421         Re-enable URLParser for non-Safari Cocoa apps after r207321
422         https://bugs.webkit.org/show_bug.cgi?id=163690
423
424         Reviewed by Darin Adler.
425
426         * DumpRenderTree/mac/DumpRenderTree.mm:
427         (DumpRenderTreeMain):
428         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
429         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
430         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
431         (TestWebKitAPI::TEST):
432         * WebKitTestRunner/TestController.cpp:
433         (WTR::TestController::TestController):
434
435 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
436
437         Unreviewed, rolling out r207557.
438
439         This change caused animations/font-variations tests to time
440         out on pre-Sierra Macs.
441
442         Reverted changeset:
443
444         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
445         iOS 9"
446         https://bugs.webkit.org/show_bug.cgi?id=163374
447         http://trac.webkit.org/changeset/207557
448
449 2016-10-19  Andy Estes  <aestes@apple.com>
450
451         Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
452         https://bugs.webkit.org/show_bug.cgi?id=163476
453         <rdar://problem/26941395>
454
455         Reviewed by Andreas Kling.
456
457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
458         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
459         (TEST): Added an API test that passes a nil MIMEType to
460         -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
461
462 2016-10-19  Jer Noble  <jer.noble@apple.com>
463
464         Modify testrunner to mute audio during tests
465         https://bugs.webkit.org/show_bug.cgi?id=162582
466
467         Reviewed by Alexey Proskuryakov.
468
469         * DumpRenderTree/mac/DumpRenderTree.mm:
470         (createWebViewAndOffscreenWindow):
471         * WebKitTestRunner/TestController.cpp:
472         (WTR::TestController::resetStateToConsistentValues):
473
474 2016-10-19  Joseph Pecoraro  <pecoraro@apple.com>
475
476         check-webkit-style: fix false-positive warnings about using #pragma once header guard
477         https://bugs.webkit.org/show_bug.cgi?id=163575
478
479         Reviewed by Brady Eidson.
480
481         There were some false positive warnings about header guards
482         for ObjC headers that don't need guards. This changes the
483         style checker to no longer warn if there is no #pragma once.
484         It only warns if there are #ifndef that should be #pragma once.
485
486         * Scripts/webkitpy/style/checkers/cpp.py:
487         (check_for_header_guard):
488         Change when we output an error.
489
490         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
491         (CppStyleTest.test_build_header_guard):
492         Update tests.
493
494 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
495
496         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
497         https://bugs.webkit.org/show_bug.cgi?id=163374
498
499         Reviewed by Darin Adler.
500
501         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
502
503 2016-10-18  Philippe Normand  <pnormand@igalia.com>
504
505         WebRTC: [GTK] Update jhbuild environment for OpenWebRTC
506         https://bugs.webkit.org/show_bug.cgi?id=163330
507
508         Reviewed by Michael Catanzaro.
509
510         Bring back the openwebrtc JHBuild moduleset in the time being. It
511         should be removed after the bump to GStreamer 1.10 is complete and
512         the libnice patches have been upstreamed. The GStreamer git
513         snapshots used in this patch are the ones configured in Ericsson's
514         GStreamer Cerbero fork.
515
516         * gtk/openwebrtc.modules: Added.
517         * gtk/patches/libnice-0001-TURN-allow-REALM-to-be-empty.patch: Added.
518         * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Added.
519         * gtk/patches/libnice-0001-nicesrc-spin-the-agent-mainloop-in-a-separate-thread.patch: Added.
520         * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Added.
521         * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Added.
522         * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Added.
523         * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Added.
524
525 2016-10-18  Sam Weinig  <sam@webkit.org>
526
527         Replace std::experimental::variant with WTF::Variant (or similar)
528         https://bugs.webkit.org/show_bug.cgi?id=163626
529
530         Reviewed by Chris Dumez.
531
532         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
533         into the WTF namespace.
534
535         * TestWebKitAPI/Tests/WTF/Variant.cpp:
536         (TestWebKitAPI::TEST):
537
538 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
539
540         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
541         https://bugs.webkit.org/show_bug.cgi?id=163627
542
543         Reviewed by Dean Jackson.
544
545         Rename setScale: to setViewScale: and add setPageScale:, hooking it up for WK1 (via exisiting SPI)
546         and WK2 (via new SPI).
547
548         * MiniBrowser/mac/BrowserWindowController.h:
549         * MiniBrowser/mac/BrowserWindowController.m:
550         (-[BrowserWindowController pageScaleForMenuItemTag:]):
551         (-[BrowserWindowController setPageScale:]):
552         (-[BrowserWindowController setViewScale:]):
553         (-[BrowserWindowController setScale:]): Deleted.
554         * MiniBrowser/mac/MainMenu.xib:
555         * MiniBrowser/mac/WK1BrowserWindowController.m:
556         (-[WK1BrowserWindowController setPageScale:]):
557         (-[WK1BrowserWindowController setViewScale:]):
558         (areEssentiallyEqual):
559         (-[WK1BrowserWindowController validateMenuItem:]):
560         (-[WK1BrowserWindowController setScale:]): Deleted.
561         * MiniBrowser/mac/WK2BrowserWindowController.m:
562         (-[WK2BrowserWindowController setPageScale:]):
563         (-[WK2BrowserWindowController viewScaleForMenuItemTag:]):
564         (-[WK2BrowserWindowController setViewScale:]):
565         (areEssentiallyEqual):
566         (-[WK2BrowserWindowController validateMenuItem:]):
567         (viewScaleForMenuItemTag): Deleted.
568         (-[WK2BrowserWindowController setScale:]): Deleted.
569
570 2016-10-18  Anders Carlsson  <andersca@apple.com>
571
572         Add an beforeunload alert to the WebKitLegacy MiniBrowser
573         https://bugs.webkit.org/show_bug.cgi?id=163634
574
575         Reviewed by Sam Weinig.
576
577         * MiniBrowser/mac/WK1BrowserWindowController.m:
578         (-[WK1BrowserWindowController webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
579
580 2016-10-18  Commit Queue  <commit-queue@webkit.org>
581
582         Unreviewed, rolling out r207443.
583         https://bugs.webkit.org/show_bug.cgi?id=163616
584
585         "Caused 5% PLT regression" (Requested by krollin on #webkit).
586
587         Reverted changeset:
588
589         "Crash in ASCIICaseInsensitiveHash::hash() when a response has
590         a null MIME type"
591         https://bugs.webkit.org/show_bug.cgi?id=163476
592         http://trac.webkit.org/changeset/207443
593
594 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
595
596         [MediaStream] Resolve constraints and enumerate devices in the UI process
597         https://bugs.webkit.org/show_bug.cgi?id=162147
598         <rdar://problem/28803569>
599
600         Reviewed by Darin Adler.
601
602         * WebKitTestRunner/TestController.cpp:
603         (WTR::TestController::resetPreferencesToConsistentValues): Enable mock capture devices.
604         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update for API changes.
605
606 2016-10-17  Megan Gardner  <megan_gardner@apple.com>
607
608         Add test and infrastructure for link popover
609         https://bugs.webkit.org/show_bug.cgi?id=163406
610
611         Reviewed by Simon Fraser.
612
613         Added functionality test for link popovers.
614         Can query for what URL is loaded, and that the popover has appeared or has
615         been dismissed.
616         Added a link popover test.
617
618         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
619         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
620         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
621         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
622         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
623         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
624         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
625         (WTR::UIScriptController::setDidShowForcePressPreviewCallback):
626         (WTR::UIScriptController::didShowForcePressPreviewCallback):
627         (WTR::UIScriptController::setDidDismissForcePressPreviewCallback):
628         (WTR::UIScriptController::didDismissForcePressPreviewCallback):
629         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
630         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
631         (WTR::UIScriptController::didEndFormControlInteractionCallback): Deleted.
632         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
633         * TestRunnerShared/UIScriptContext/UIScriptController.h:
634         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
635         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
636         (-[TestRunnerWKWebView dealloc]):
637         (-[TestRunnerWKWebView didShowForcePressPreview]):
638         (-[TestRunnerWKWebView didDismissForcePressPreview]):
639         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
640         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
641         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
642         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
643
644 2016-10-17  Tim Horton  <timothy_horton@apple.com>
645
646         REGRESSION (r169805): WKWebView canGoBack returning YES when nothing is in the back-forward list after restoring session state
647         https://bugs.webkit.org/show_bug.cgi?id=163573
648         <rdar://problem/28744549>
649
650         Reviewed by Dan Bernstein.
651
652         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
653         (TEST):
654         Add a test ensuring that canGoBack returns NO after restoring session state without navigating.
655
656 2016-10-17  Andy Estes  <aestes@apple.com>
657
658         Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
659         https://bugs.webkit.org/show_bug.cgi?id=163476
660         <rdar://problem/26941395>
661
662         Reviewed by Tim Horton.
663
664         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
665         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
666         (TEST): Added an API test that passes a nil MIMEType to
667         -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
668
669 2016-10-17  Dean Jackson  <dino@apple.com>
670
671         Allow creation of ExtendedColors and make Color immutable
672         https://bugs.webkit.org/show_bug.cgi?id=163557
673         <rdar://problem/28805360>
674
675         Reviewed by Darin Adler and Dave Hyatt.
676
677         API tests for ExtendedColor.
678
679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
680         * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp: Added.
681         (TestWebKitAPI::TEST):
682         (TestWebKitAPI::makeColor):
683
684 2016-10-17  JF Bastien  <jfbastien@apple.com>
685
686         WebAssembly JS API: implement basic stub
687
688         Implement the global WebAssembly JavaScript object, and its constructor +
689         function properties as described in:
690           https://github.com/WebAssembly/design/blob/master/JS.md
691
692         These don't do anything at the moment, the parent bug will take care of adding
693         more functionality and associated tests.
694
695         WebAssembly JS API: implement basic stub
696         https://bugs.webkit.org/show_bug.cgi?id=163404
697
698         Reviewed by Keith Miller.
699
700         * Scripts/run-jsc-stress-tests: use the new JSC option which exposes the WebAssembly object.
701
702 2016-10-17  Fujii Hironori  <Hironori.Fujii@sony.com>
703
704         resolve-ChangeLogs: Specify --no-page to git diff
705         https://bugs.webkit.org/show_bug.cgi?id=163441
706
707         Reviewed by Darin Adler.
708
709         resolve-ChangeLogs shows the result after resolving by invoking
710         'git diff'. It runs a pager for every ChangeLog if it is under
711         TTY.
712
713         * Scripts/resolve-ChangeLogs:
714         (showStatus): Specify '--no-page' to git diff.
715
716 2016-10-17  Michael Catanzaro  <mcatanzaro@igalia.com>
717
718         Move user agent quirks to cross-platform location
719         https://bugs.webkit.org/show_bug.cgi?id=163508
720
721         Reviewed by Carlos Garcia Campos.
722
723         Move the test to a cross-platform location and improve it to better check the full list of
724         sites we have defined quirks for.
725
726         * TestWebKitAPI/PlatformGTK.cmake:
727         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp.
728         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
729         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
730         (TestWebKitAPI::TEST):
731
732 2016-10-17  Carlos Garcia Campos  <cgarcia@igalia.com>
733
734         [SOUP] Downloads should always sniff contents
735         https://bugs.webkit.org/show_bug.cgi?id=163538
736
737         Reviewed by Michael Catanzaro.
738
739         Add a test case to check that the MIME type is correctly guessed for downloads.
740
741         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
742         (writeNextChunk):
743         (serverCallback):
744         (testDownloadMIMEType):
745         (beforeAll):
746         (writeNextChunkIdle): Deleted.
747
748 2016-10-16  Daniel Bates  <dabates@apple.com>
749
750         Fix Perl warning about masked variable following <http://trac.webkit.org/changeset/207382>
751         (https://bugs.webkit.org/show_bug.cgi?id=163456)
752
753         * Scripts/prepare-ChangeLog:
754         (actuallyGenerateFunctionLists):
755
756 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
757
758         Unreviewed. Fix GTK+ unit test /webkit2/WebKitWebContext/languages after r206949.
759
760         After r206949 navigator.language returns en-US instead of en-us. Language tags in Accept-Language header are
761         actually case-insensitive, so we should actually do case-insensitive comparisons, but we only have
762         g_assert_cmpstr for tests.
763
764         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
765         (testWebContextLanguages):
766
767 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
768
769         [GTK] WebKitWebPage URI not updated after URI is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
770         https://bugs.webkit.org/show_bug.cgi?id=163389
771
772         Reviewed by Michael Catanzaro.
773
774         Update /webkit2/WebKitWebPage/get-uri test to check that web view and page uri always match even when request is
775         modified by WebKitWebPage::send-request signal.
776
777         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
778         (testWebPageURI):
779
780 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
781
782         Document request not updated after willSendRequest is called for a redirect
783         https://bugs.webkit.org/show_bug.cgi?id=163436
784
785         Reviewed by Michael Catanzaro.
786
787         Update /webkit2/WebKitWebView/active-uri test to check the active URI also when modified by
788         WebKitPage::send-request signal in a web extension.
789
790         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
791         (testWebViewActiveURI):
792         (serverCallback):
793         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
794         (sendRequestCallback):
795         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
796         (loadChangedCallback):
797
798 2016-10-15  Dan Bernstein  <mitz@apple.com>
799
800         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
801         https://bugs.webkit.org/show_bug.cgi?id=163492
802         <rdar://problem/28654799>
803
804         Reviewed by Darin Adler.
805
806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
807         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm: Added.
808         (-[ContextMenuDefaultItemsHaveTagsDelegate webView:didFinishLoadForFrame:]):
809         (TestWebKitAPI::TEST):
810
811 2016-10-15  Daniel Bates  <dabates@apple.com>
812
813         prepare-ChangeLog erroneously said that a python __init__ method was deleted
814         https://bugs.webkit.org/show_bug.cgi?id=163456
815
816         Reviewed by Simon Fraser.
817
818         Fixes an issue where prepare-ChangeLog may list as deleted functions that are
819         immediately above added code.
820
821         Currently prepare-ChangeLog makes use of the same overlap detection algorithm
822         to compute the list of deleted functions as it does to compute added and modified
823         functions. We consider a function deleted if its entire function body and signature
824         are removed. It is sufficient to compare the list of functions before the patch
825         is applied and the list of functions are the patch is applied to identify
826         these functions.
827
828         * Scripts/prepare-ChangeLog: Fix some style nits, including using Camel Case for
829         variable names.
830         (actuallyGenerateFunctionLists): Modified to call computeModifiedFunctions(). Always
831         compute the list of functions in the file after the patch regardless of whether the
832         patch only contains deletions. We will compare this list against the list of functions
833         before the patch was applied to determine the deleted functions.
834         (computeModifiedFunctions): Renamed; formerly named generateFunctionListsByRanges.
835         Removed out argument for the seen functions as we no longer make use of when computing
836         the list of deleted functions.
837         (diffCommand): Update comment.
838         (generateFunctionListsByRanges): Deleted.
839         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added more unit tests.
840
841 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
842
843         REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name'
844         https://bugs.webkit.org/show_bug.cgi?id=163478
845
846         Reviewed by Daniel Bates.
847         
848         Handle a None other in Contributor.__eq__.
849
850         * Scripts/webkitpy/common/config/committers.py:
851         (Contributor.__eq__):
852
853 2016-10-14  JF Bastien  <jfbastien@apple.com>
854
855         Basic WebAssembly testing
856
857         Create a small DSL in JavaScript which can build WebAssembly binary modules based on the JSON description of the format as described in:
858         https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md
859
860         This DSL can then be used to write small text description of valid and invalid WebAssembly binaries, making testing the JSC implementation much easier.
861
862         Details and example in README.md.
863
864         Basic WebAssembly testing
865         https://bugs.webkit.org/show_bug.cgi?id=163267
866
867         Reviewed by Keith Miller.
868
869         * Scripts/run-javascriptcore-tests:
870         (runJSCStressTests): run wasm.yaml tests
871         * Scripts/run-jsc-stress-tests: add a WebAssembly-specific runner
872
873 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
874
875         Annotate bots in contributors.json and don't show them on webkit.org/team
876         https://bugs.webkit.org/show_bug.cgi?id=163317
877
878         Reviewed by Daniel Bates.
879         
880         Add "class" : "bot" for non-humans in contributors.json and round-trip it.
881
882         * Scripts/webkitpy/common/config/committers.py:
883         (Contributor.__init__):
884         (Contributor.as_dict):
885         (Bot):
886         (Bot.__init__):
887         (CommitterList.load_json):
888         * Scripts/webkitpy/common/config/contributors.json:
889
890 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
891
892         Fix printing in WK2 MiniBrowser
893         https://bugs.webkit.org/show_bug.cgi?id=163455
894
895         Reviewed by Tim Horton.
896         
897         Call the basic -_printOperationWithPrintInfo: which doens't require a frame argument.
898
899         * MiniBrowser/mac/WK2BrowserWindowController.m:
900         (-[WK2BrowserWindowController printWebView:]):
901
902 2016-10-14  Commit Queue  <commit-queue@webkit.org>
903
904         Unreviewed, rolling out r207335.
905         https://bugs.webkit.org/show_bug.cgi?id=163445
906
907         WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing
908         out on Mac bots (Requested by youenn on #webkit).
909
910         Reverted changeset:
911
912         "Add ProvisionalURLAfterWillSendRequestCallback.cpp and
913         ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac
914         builds"
915         https://bugs.webkit.org/show_bug.cgi?id=163440
916         http://trac.webkit.org/changeset/207335
917
918 2016-10-14  Youenn Fablet  <youenn@apple.com>
919
920         Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac builds
921         https://bugs.webkit.org/show_bug.cgi?id=163440
922
923         Unreviewed.
924
925         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Adding new test files introduced in
926         https://bugs.webkit.org/show_bug.cgi?id=146306 patch.
927
928 2016-10-13  Carlos Garcia Campos  <cgarcia@igalia.com>
929
930         Unreviewed. Removed myself from BindingsScripts watch list.
931
932         * Scripts/webkitpy/common/config/watchlist:
933
934 2016-10-13  Carlos Garcia Campos  <cgarcia@igalia.com>
935
936         WebView and WebPage URLs not updated after URL is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
937         https://bugs.webkit.org/show_bug.cgi?id=146306
938
939         Reviewed by Darin Adler.
940
941         Add unit test to check that the committed URL is updated when changed in willSendRequest callback.
942
943         * TestWebKitAPI/CMakeLists.txt:
944         * TestWebKitAPI/PlatformEfl.cmake:
945         * TestWebKitAPI/PlatformGTK.cmake:
946         * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Added.
947         (TestWebKitAPI::didCommitLoadForFrame):
948         (TestWebKitAPI::TEST):
949         * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Added.
950         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::ProvisionalURLAfterWillSendRequestCallbackTest):
951         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::willSendRequestForFrame):
952         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::didCommitLoadForFrame):
953
954 2016-10-13  Alex Christensen  <achristensen@webkit.org>
955
956         Hosts of URLs with non-special schemes should be case-sensitive, and non-ASCII characters in such hosts should be punycode-encoded
957         https://bugs.webkit.org/show_bug.cgi?id=163413
958
959         Reviewed by Tim Horton.
960
961         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
962         (TestWebKitAPI::TEST_F):
963         Update parsing results.  There are now fewer differences between the new URLParser and the old URL::parse.
964
965 2016-10-13  Alex Christensen  <achristensen@webkit.org>
966
967         Rebase API tests after r207305.
968
969         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
970         Actually build Tests/mac/LoadInvalidURLRequest.mm so we are running the WebKit1.LoadInvalidURLRequest API test.
971         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
972         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
973         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
974         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
975         Change results back to what they were before r207162, r207167, and r207184.
976
977 2016-10-13  Alex Christensen  <achristensen@webkit.org>
978
979         Disable URLParser for non-Safari iOS and Mac apps for now
980         https://bugs.webkit.org/show_bug.cgi?id=163397
981
982         Reviewed by Tim Horton.
983
984         * DumpRenderTree/mac/DumpRenderTree.mm:
985         (DumpRenderTreeMain):
986         * WebKitTestRunner/TestController.cpp:
987         Enable the URLParser for testing.
988         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
989         Link with WebCoreTestSupport so we can find setURLParserEnabled.
990
991 2016-10-13  Ryan Haddad  <ryanhaddad@apple.com>
992
993         Unreviewed, rolling out r207297.
994
995         This change broke the iOS build.
996
997         Reverted changeset:
998
999         "Disable URLParser for non-Safari iOS and Mac apps for now"
1000         https://bugs.webkit.org/show_bug.cgi?id=163397
1001         http://trac.webkit.org/changeset/207297
1002
1003 2016-10-13  Alex Christensen  <achristensen@webkit.org>
1004
1005         Disable URLParser for non-Safari iOS and Mac apps for now
1006         https://bugs.webkit.org/show_bug.cgi?id=163397
1007
1008         Reviewed by Tim Horton.
1009
1010         * DumpRenderTree/mac/DumpRenderTree.mm:
1011         (DumpRenderTreeMain):
1012         * WebKitTestRunner/ios/mainIOS.mm:
1013         (main):
1014         * WebKitTestRunner/mac/main.mm:
1015         (main):
1016
1017 2016-10-12  Alex Christensen  <achristensen@webkit.org>
1018
1019         Fix out-of-bounds reading in URLParser when parsing improperly percent-encoded values
1020         https://bugs.webkit.org/show_bug.cgi?id=163376
1021
1022         Reviewed by Saam Barati.
1023
1024         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1025         (TestWebKitAPI::TEST_F):
1026
1027 2016-10-11  Dean Jackson  <dino@apple.com>
1028
1029         Add preliminary support for extended colors to WebCore::Color
1030         https://bugs.webkit.org/show_bug.cgi?id=162878
1031         <rdar://problem/28596413>
1032
1033         Reviewed by Darin Adler.
1034
1035         A new API test for Colors.
1036
1037         * TestWebKitAPI/Tests/WebCore/Color.cpp:
1038         (TestWebKitAPI::TEST):
1039
1040 2016-10-12  Ryan Haddad  <ryanhaddad@apple.com>
1041
1042         Unreviewed, rolling out r207225.
1043
1044         This change causes debug tests to exit early with crashes.
1045
1046         Reverted changeset:
1047
1048         "Optional's move-constructor and move-assignment operator
1049         don't disengage the value being moved from"
1050         https://bugs.webkit.org/show_bug.cgi?id=163309
1051         http://trac.webkit.org/changeset/207225
1052
1053 2016-10-12  Alex Christensen  <achristensen@webkit.org>
1054
1055         Fix assertion after switching to URLParser
1056         https://bugs.webkit.org/show_bug.cgi?id=163350
1057         rdar://problem/28739938
1058
1059         Reviewed by Brady Eidson.
1060
1061         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1062         (TEST):
1063
1064 2016-10-11  Sam Weinig  <sam@webkit.org>
1065
1066         Optional's move-constructor and move-assignment operator don't disengage the value being moved from
1067         https://bugs.webkit.org/show_bug.cgi?id=163309
1068
1069         Reviewed by Anders Carlsson.
1070
1071         * TestWebKitAPI/Tests/WTF/Optional.cpp:
1072         (TestWebKitAPI::TEST):
1073         Add tests for Optional's move-constructor and move-assignment operator.
1074
1075 2016-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1076
1077         Now playing media sessions are always cleared for the active foreground tab
1078         https://bugs.webkit.org/show_bug.cgi?id=163310
1079         <rdar://problem/28573301>
1080
1081         Reviewed by Jer Noble.
1082
1083         Tweaks existing unit tests to verify that media session info persists when backgrounding and foregrounding, but
1084         that media session info is correctly cleared out if the media session itself is no longer eligible for Now
1085         Playing (not accounting for foreground/active state). Previously, these tests were verifying that we would
1086         always clear out the information, but this is incorrect, and is the source of the problem.
1087
1088         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1089         (-[NowPlayingTestWebView waitForNowPlayingInfoToChange]):
1090         (TestWebKitAPI::TEST):
1091
1092 2016-10-12  Per Arne Vollan  <pvollan@apple.com>
1093
1094         [Win] Parallel DRTs are sharing preferences and cache.
1095         https://bugs.webkit.org/show_bug.cgi?id=163013
1096
1097         Reviewed by Brent Fulgham.
1098
1099         Use separate cache and preferences for each DRT instance.
1100
1101         * DumpRenderTree/win/DumpRenderTree.cpp:
1102         (applicationId):
1103         (setApplicationId):
1104         (setCacheFolder):
1105         (setDefaultsToConsistentValuesForTesting):
1106         * Scripts/webkitpy/port/win.py:
1107         (WinPort.setup_test_run):
1108
1109 2016-10-11  Alex Christensen  <achristensen@webkit.org>
1110
1111         Update API test expectation after r207162.
1112        ​https://bugs.webkit.org/show_bug.cgi?id=162660
1113
1114         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
1115         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1116         Like r207167 but with a WebKit2 test.
1117         "https://www.example.com<>/" was an invalid URL with the old URL parser, is now valid with URLParser but not with NSURL's parser.
1118
1119 2016-10-11  Alex Christensen  <achristensen@webkit.org>
1120
1121         Update API test expectation after r207162.
1122         https://bugs.webkit.org/show_bug.cgi?id=162660
1123
1124         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
1125         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1126         "https://www.example.com<>/" was an invalid URL with the old URL parser.
1127         It is now a valid URL, but NSURL still considers it invalid.
1128         This will be looked into more with https://bugs.webkit.org/show_bug.cgi?id=163127
1129
1130 2016-10-11  Edward O'Connor  <eoconnor@apple.com>
1131
1132         Update my name in contributors.json
1133         https://bugs.webkit.org/show_bug.cgi?id=163251
1134
1135         Reviewed by Simon Fraser.
1136
1137         * Scripts/webkitpy/common/config/contributors.json:
1138
1139 2016-10-11  Said Abou-Hallawa  <sabouhallawa@apple.com>
1140
1141         Add SynchronizedFixedQueue class
1142         https://bugs.webkit.org/show_bug.cgi?id=162478
1143
1144         Reviewed by Geoffrey Garen.
1145
1146         Add a new test for SynchronizedFixedQueue. The test defines a new class
1147         called ToUpperConverter which converts strings from lower case to upper
1148         case. It creates two threads : (1) produce thread and (2) consume thread.
1149         Here is what each thread does:
1150
1151         1. Main threads: Enqueues lower case strings into m_lowerQueue.
1152         2. Produce thread: Dequeues lower case strings from m_lowerQueue and 
1153            enqueue their upper case strings in the m_upperQueue.
1154         3. Consume thread: Dequeues upper case strings from m_upperQueue.
1155
1156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1157         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp: Added.
1158         (TestWebKitAPI::textItem): A helper function which returns a lower case string given an index.
1159         (TestWebKitAPI::toUpper): A helper function which Returns the upper case of a string.
1160         (TestWebKitAPI::ToUpperConverter::ToUpperConverter):
1161         (TestWebKitAPI::ToUpperConverter::produceQueue): Returns a workQueue for the produce thread.
1162         (TestWebKitAPI::ToUpperConverter::consumeQueue): Returns a workQueue for the consume thread.
1163         (TestWebKitAPI::ToUpperConverter::startProducing): Creates a thread for the producer.
1164         (TestWebKitAPI::ToUpperConverter::startConsuming): Creates a thread for the consumer.
1165         (TestWebKitAPI::ToUpperConverter::start): Starts both the producer and the consumer threads.
1166         (TestWebKitAPI::ToUpperConverter::stopProducing): Terminates the producer thread.
1167         (TestWebKitAPI::ToUpperConverter::stopConsuming): Terminates the consumer thread.
1168         (TestWebKitAPI::ToUpperConverter::stop): Terminates both the producer and the consumer threads.
1169         (TestWebKitAPI::ToUpperConverter::enqueueLower): Adds a lower case string to the m_lowerQueue on the main thread.
1170         (TestWebKitAPI::ToUpperConverter::isProducing): Returns whether the producing thread is active.
1171         (TestWebKitAPI::ToUpperConverter::isConsuming): Returns whether the consuming thread is active.
1172         (TestWebKitAPI::ToUpperConverter::produceCount): Returns the number of produced elements.
1173         (TestWebKitAPI::ToUpperConverter::consumeCount): Returns the number of consumed elements.
1174         (TestWebKitAPI::TEST):
1175
1176 2016-10-11  Megan Gardner  <megan_gardner@apple.com>
1177
1178         Extend event stream to include interpolated events and add a force press test that uses that interpolation
1179         https://bugs.webkit.org/show_bug.cgi?id=163161
1180
1181         Reviewed by Simon Fraser.
1182
1183         Added functionality to the event stream to allow for interpolated events.
1184         Can now do long press, as well as a better way to do drag and other time-based
1185         events that require a large stream of descrete HID events.
1186         Added a basic force touch test to demostrate this interpolation.
1187         Also updated the script to allow for iPhone 7 specific tests, as force touch
1188         needs to be on a device that had force touch.
1189
1190         * Scripts/webkitpy/port/ios.py:
1191         (IOSSimulatorPort):
1192         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1193         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1194         (linearInterpolation):
1195         (simpleCurveInterpolation):
1196         (calculateNextCurveLocation):
1197         (phaseFromString):
1198         (interpolationFromString):
1199         (-[HIDEventGenerator eventMaskFromEventInfo:]):
1200         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
1201         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
1202         (-[HIDEventGenerator interpolatedEvents:]):
1203         (-[HIDEventGenerator processEventsArray:withStartTime:]):
1204         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1205         (simpleDragCurve): Deleted.
1206         (calculateNextLocation): Deleted.
1207
1208 2016-10-11  Alex Christensen  <achristensen@webkit.org>
1209
1210         URLParser should percent-encode non-ASCII and non-printable characters in fragment
1211         https://bugs.webkit.org/show_bug.cgi?id=163287
1212
1213         Reviewed by Brady Eidson.
1214
1215         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1216         (TestWebKitAPI::TEST_F):
1217
1218 2016-10-11  Alex Christensen  <achristensen@webkit.org>
1219
1220         Remove dead networking code
1221         https://bugs.webkit.org/show_bug.cgi?id=163263
1222
1223         Reviewed by Daniel Bates.
1224
1225         * DumpRenderTree/DumpRenderTree.h:
1226         * DumpRenderTree/config.h:
1227         * DumpRenderTree/win/DumpRenderTree.cpp:
1228         (main):
1229
1230 2016-10-11  John Wilander  <wilander@apple.com>
1231
1232         Modify check-webkit-style to prohibit sensitive phrases
1233         https://bugs.webkit.org/show_bug.cgi?id=163048
1234         <rdar://problem/28289755>
1235
1236         Terms considered or found to be too general to flag:
1237         ASSERT_WITH_SECURITY_IMPLICATION, bad cast, bug, bypass, crash,
1238         denial of service, dereference, disclosure, error, exploit,
1239         failure, heap, integer overflow, leak, null dereference,
1240         null pointer dereference, out of bounds, overflow,
1241         race condition, sensitive information, stack, type confusion.
1242
1243         Reviewed by Brent Fulgham.
1244
1245         * Scripts/webkitpy/style/checkers/changelog.py:
1246         (ChangeLogChecker.check_entry):
1247             Now calls ChangeLogChecker.check_for_unwanted_security_terms().
1248         (ChangeLogChecker):
1249         (ChangeLogChecker.check_for_unwanted_security_terms):
1250             New function to check for sensitive terms.
1251         (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm):
1252         (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm.__init__):
1253             Convenience class.
1254         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1255         (ChangeLogCheckerTest.test_unwanted_security_terms):
1256
1257 2016-10-11  Ryan Haddad  <ryanhaddad@apple.com>
1258
1259         Unreviewed, rolling out r207067.
1260
1261         This change caused webkitpy test failures.
1262
1263         Reverted changeset:
1264
1265         "[Win] Parallel DRTs are sharing preferences and cache."
1266         https://bugs.webkit.org/show_bug.cgi?id=163013
1267         http://trac.webkit.org/changeset/207067
1268
1269 2016-10-11  Per Arne Vollan  <pvollan@apple.com>
1270
1271         [Win] Parallel DRTs are sharing preferences and cache.
1272         https://bugs.webkit.org/show_bug.cgi?id=163013
1273
1274         Reviewed by Brent Fulgham.
1275
1276         Use separate cache and preferences for each DRT instance.
1277
1278         * DumpRenderTree/win/DumpRenderTree.cpp:
1279         (applicationId):
1280         (setApplicationId):
1281         (setCacheFolder):
1282         (setDefaultsToConsistentValuesForTesting):
1283         * Scripts/webkitpy/port/win.py:
1284         (WinPort.setup_test_run):
1285
1286 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
1287
1288         Add ENABLE_ENCRYPTED_MEDIA configuration option
1289         https://bugs.webkit.org/show_bug.cgi?id=163219
1290
1291         Reviewed by Darin Adler.
1292
1293         * Scripts/webkitperl/FeatureList.pm:
1294         Make the ENABLE_ENCRYPTED_MEDIA option overridable via build-webkit.
1295         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1296         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
1297         to enable or disable the new EME implementation at build-time.
1298
1299 2016-10-10  Commit Queue  <commit-queue@webkit.org>
1300
1301         Unreviewed, rolling out r206972.
1302         https://bugs.webkit.org/show_bug.cgi?id=163227
1303
1304         Making EWS flaky (Requested by bfulgham_ on #webkit).
1305
1306         Reverted changeset:
1307
1308         "[CMake] CMake does not support the dep files for implicit
1309         dependency"
1310         https://bugs.webkit.org/show_bug.cgi?id=161433
1311         http://trac.webkit.org/changeset/206972
1312
1313 2016-10-10  Youenn Fablet  <youenn@apple.com>
1314
1315         W3C test downloader should be able to import specific files/sub-directories in a skipped directory
1316         https://bugs.webkit.org/show_bug.cgi?id=161789
1317
1318         Reviewed by Ryosuke Niwa.
1319
1320         Removed tests_directory option and corresponding test.
1321         This option was allowing to import a sub-directory from a test repository.
1322         We can readd it if necessary.
1323
1324         Adding support for finer-grained import rules.
1325         Previously skipped directories were fully removed.
1326         Now, directories may be skipped but sub directories of them may be imported.
1327         This currently happens in web-platform-tests repo.
1328
1329         * Scripts/webkitpy/w3c/test_downloader.py:
1330         (TestDownloader._add_test_suite_paths): Removing tests_directory option.
1331         (TestDownloader.copy_tests): Refactoring file copy by generating the list of all directories for which direct files should be imported.
1332         (TestDownloader.copy_tests.should_copy_dir):
1333         (TestDownloader.copy_tests.should_copy_file):
1334         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1335         (TestImporterTest.test_tests_directory): Deleted.
1336         (TestImporterTest.test_skip_test_import): Added.
1337
1338 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
1339
1340         Make validate-committer-lists show inactive reviewers
1341         https://bugs.webkit.org/show_bug.cgi?id=163193
1342
1343         Reviewed by Sam Weinig.
1344         
1345         In preparation for updating contributors.json with the WebKit policy of retiring
1346         inactive reviewers, make validate-committer-lists show the list of reviewers who
1347         have not reviewed in the past year.
1348         
1349         This list is computed by grepping the output of 'git log --since=1.year" for
1350         the reviewer line, and looking up reviewers via Contributor.mentioned_in_text(),
1351         which looks for full names, aliases, irc nicks and email addresses.
1352         
1353         Support for aliases is added to Contributor. Aliases are alternates
1354         or misspellings of the reviewer's name. Some common aliases were added to
1355         contributors.json by manual examination of "Reviewed by" lines.
1356
1357         * Scripts/validate-committer-lists:
1358         (CommitterListFromGit.possibly_expired_committers):
1359         (CommitterListFromGit):
1360         (CommitterListFromGit.possibly_inactive_reviewers):
1361         (CommitterListFromGit.print_possibly_expired_committers):
1362         (CommitterListFromGit.print_possibly_inactive_reviewers):
1363         * Scripts/webkitpy/common/config/committers.py:
1364         (Contributor.__init__):
1365         (Contributor.contains_string):
1366         (Contributor.mentioned_in_text):
1367         (Contributor.as_dict):
1368         (Committer.__init__):
1369         (Reviewer.__init__):
1370         (CommitterList.load_json):
1371         * Scripts/webkitpy/common/config/contributors.json:
1372
1373 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
1374
1375         Convert contributors.json to a flat list
1376         https://bugs.webkit.org/show_bug.cgi?id=163183
1377
1378         Reviewed by Darin Adler.
1379         
1380         Make contributors.json easier to maintain by eliminating the big groupings ("Committers", "Reviewers" etc)
1381         and moving that data to a "status" property on each contributor.
1382
1383         * Scripts/webkitpy/common/config/committers.py:
1384         (Contributor.__eq__): Implement this to fix unit tests, now that load_json() is not @memoized.
1385         (Contributor.as_dict): Include status in the dict.
1386         (CommitterList.__init__): Clean up to make the testing code path more explicit.
1387         (CommitterList.load_json):
1388         (CommitterList.load_test_data):
1389         (CommitterList.as_json):
1390         (Contributor.__unicode__): Deleted.
1391         * Scripts/webkitpy/common/config/contributors.json:
1392         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1393         (IRCCommandTest.test_whois): The ordering here is now alphabetical.
1394
1395 2016-10-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1396
1397         [CMake] CMake does not support the dep files for implicit dependency
1398         https://bugs.webkit.org/show_bug.cgi?id=161433
1399
1400         Reviewed by Brent Fulgham.
1401
1402         Created a Perl script to generate all IDL bindings for CMake.
1403         This script can regenerate outdated bindings by based on the
1404         supplemental dependency and dep files created by
1405         '--write-dependencies' switch of generate-bindings.pl.
1406
1407         add_custom_target is used to invoke the script instead of
1408         add_custom_command because Ninja deletes all output files before
1409         executing the command in case of add_custom_command.
1410
1411         USES_TERMINAL option of add_custom_target has two effects:
1412         1) Not buffering output of the command
1413         2) Invoking the command in the special Ninja pool which inhibits parallel build
1414         One needs to use CMake 3.2 or later to enable this feature.
1415
1416         * DumpRenderTree/CMakeLists.txt: Specified a target name for
1417         GENERATE_BINDINGS. Added dependency for the target.
1418         * WebKitTestRunner/CMakeLists.txt: Ditto.
1419
1420 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
1421
1422         Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
1423         https://bugs.webkit.org/show_bug.cgi?id=163177
1424
1425         Follow-up fix.
1426         
1427         For unknown reasons, overriding Commiter.__dict__() caused mysterious test failures.
1428         Rename it to as_dict().
1429
1430         * Scripts/webkitpy/common/config/committers.py:
1431         (Contributor.as_dict):
1432         (CommitterList._contributor_list_to_dict):
1433         (Contributor.__dict__): Deleted.
1434
1435 2016-10-08  Simon Fraser  <simon.fraser@apple.com>
1436
1437         Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
1438         https://bugs.webkit.org/show_bug.cgi?id=163177
1439
1440         Reviewed by Ryosuke Niwa.
1441         
1442         Make it possible to round-trip contributors.json through CommitterList, so we can
1443         support writing out contributors.json in canonical format. This requires saving
1444         the case-preserved email and expertise in Contributor. CommitterList also needs
1445         to be able to generate the "exclusive" lists, since it currently uses lists
1446         that are the union of, say, committers and reviewers.
1447         
1448         If contributors.json is malformed (invalid JSON), catch the Exception, report it
1449         and exit rather than allowing the exception to propagate. With an invalid file,
1450         an exception would be thrown before the JSON style checker reached this file, so
1451         the error was not correctly reported.
1452         
1453         Add style/checker/committer.py for checking that committers.json has the canonical format.
1454         
1455         Add support to validate-committer-lists to dump out the canonical json (-d) or update
1456         the file in-place (-c).
1457
1458         * Scripts/validate-committer-lists:
1459         (CommitterListFromGit._print_three_column_row):
1460         (CommitterListFromGit.possibly_expired_committers):
1461         (CommitterListFromGit):
1462         (CommitterListFromGit.print_possibly_expired_committers):
1463         (main):
1464         * Scripts/webkitpy/common/config/committers.py:
1465         (Contributor.__init__):
1466         (Contributor.__dict__):
1467         (Committer.__init__):
1468         (Reviewer.__init__):
1469         (CommitterList.load_json):
1470         (CommitterList):
1471         (CommitterList._contributor_list_to_dict):
1472         (CommitterList.as_json):
1473         (CommitterList.reformat_in_place):
1474         (CommitterList._exclusive_contributors):
1475         (CommitterList._exclusive_committers):
1476         (Contributor.matches_glob): Deleted.
1477         (CommitterList.contributors): Deleted.
1478         * Scripts/webkitpy/common/config/contributors.json:
1479         * Scripts/webkitpy/style/checker.py:
1480         (CheckerDispatcher._create_checker):
1481         * Scripts/webkitpy/style/checkers/contributors.py: Added.
1482         (ContributorsChecker):
1483         (ContributorsChecker.__init__):
1484         (ContributorsChecker.check):
1485         (ContributorsChecker._unidiff_output):
1486
1487 2016-10-06  Darin Adler  <darin@apple.com>
1488
1489         Next step on moving to modern way to return DOM exceptions
1490         https://bugs.webkit.org/show_bug.cgi?id=163016
1491
1492         Reviewed by Ryosuke Niwa.
1493
1494         * Scripts/do-webcore-rename: Add proposed name change of setDOMException
1495         to propagateException, since this function is primarily used to take an
1496         exception already effectively "thrown" by setting an ExceptionCode out
1497         argument and propagate it into the JavaScript engine's exception machinery.
1498
1499 2016-10-07  Alex Christensen  <achristensen@webkit.org>
1500
1501         Non-special URL fragments should percent-encode non-ASCII characters
1502         https://bugs.webkit.org/show_bug.cgi?id=163153
1503
1504         Reviewed by Tim Horton.
1505
1506         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1507         (TestWebKitAPI::TEST_F):
1508
1509 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
1510
1511         Build fix for “Move functionality common to Darwin ports into a base class”
1512         https://bugs.webkit.org/show_bug.cgi?id=160709
1513
1514         Unreviewed build fix.
1515
1516         * Scripts/webkitpy/port/ios.py:
1517         (IOSSimulatorPort._get_crash_log): Added iOS implementation.
1518         * Scripts/webkitpy/port/mac.py:
1519         (MacPort._get_crash_log): Added Mac implementation.
1520
1521 2016-10-07  Chelsea Pugh  <cpugh@apple.com>
1522
1523         Unreviewed. Added myself to the list of committers.
1524
1525         * Scripts/webkitpy/common/config/contributors.json:
1526
1527 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
1528
1529         Move functionality common to Darwin ports into a base class
1530         https://bugs.webkit.org/show_bug.cgi?id=160709
1531
1532         Reviewed by Darin Adler.
1533
1534         * Scripts/webkitpy/port/apple.py:
1535         (ApplePort.determine_full_port_name): Specific iOS port check.
1536         (ApplePort.__init__): Move leak detector to DarwinPort.
1537         (ApplePort._make_leak_detector): Moved to DarwinPort.
1538         (ApplePort.supports_per_test_timeout): Moved to Port.
1539         (ApplePort.check_for_leaks): Moved to DarwinPort.
1540         (ApplePort.print_leaks_summary): Moved to DarwinPort.
1541         (ApplePort._path_to_webcore_library): Moved to DarwinPort.
1542         (ApplePort.show_results_html_file): Moved to DarwinPort.
1543         (ApplePort._merge_crash_logs): Moved to DarwinPort.
1544         (ApplePort._look_for_all_crash_logs_in_log_dir): Moved to DarwinPort.
1545         (ApplePort._get_crash_log): Moved to DarwinPort.
1546         (ApplePort.look_for_new_crash_logs): Moved to DarwinPort.
1547         (ApplePort.sample_process): Moved to DarwinPort.
1548         (ApplePort.sample_file_path): Moved to DarwinPort.
1549         (ApplePort.look_for_new_samples): Moved to DarwinPort.
1550         * Scripts/webkitpy/port/base.py:
1551         (Port.supports_per_test_timeout): Return true for all ports.
1552         * Scripts/webkitpy/port/darwin.py: Added.
1553         (DarwinPort): Shared iOS and Mac functions.
1554         * Scripts/webkitpy/port/darwin_testcase.py: Added.
1555         (DarwinTest): Shared iOS and Mac testing.
1556         * Scripts/webkitpy/port/efl.py:
1557         (EflPort):
1558         (EflPort.supports_per_test_timeout): Moved to Port.
1559         * Scripts/webkitpy/port/gtk.py:
1560         (GtkPort._driver_class):
1561         (GtkPort):
1562         (GtkPort.supports_per_test_timeout): Moved to Port.
1563         * Scripts/webkitpy/port/ios.py:
1564         (IOSPort):
1565         (IOSPort.operating_system):
1566         (IOSSimulatorPort):
1567         (IOSSimulatorPort.__init__): Inherits from DarwinPort.
1568         (IOSSimulatorPort._port_specific_expectations_files): Moved to DarwinPort.
1569         (IOSSimulatorPort._get_crash_log): Deleted.
1570         (IOSSimulatorPort.xcrun_find): Deleted.
1571         * Scripts/webkitpy/port/ios_unittest.py: Added.
1572         (iosTest): Unit tests for the iOS port.
1573         * Scripts/webkitpy/port/mac.py:
1574         (MacPort):
1575         (MacPort.__init__): Inherits from DarwinPort.
1576         (MacPort._port_specific_expectations_files): Moved to DarwinPort.
1577         (MacPort.make_command): Moved to DarwinPort.
1578         (MacPort._get_crash_log): Moved to DarwinPort.
1579         (MacPort.nm_command): Moved to DarwinPort.
1580         * Scripts/webkitpy/port/mac_unittest.py:
1581         (MacTest):
1582         (MacTest.test_sdk_name): Added test.
1583         (MacTest.test_xcrun): Added test.
1584         (MacTest.assert_skipped_file_search_paths): Moved to DarwinTest.
1585         (MacTest.test_default_timeout_ms): Moved to DarwinTest.
1586         (MacTest.assert_name): Moved to DarwinTest.
1587         (MacTest.test_helper_starts): Moved to DarwinTest.
1588         (MacTest.test_helper_fails_to_start): Moved to DarwinTest.
1589         (MacTest.test_helper_fails_to_stop): Moved to DarwinTest.
1590         (MacTest.test_spindump): Moved to DarwinTest.
1591         (MacTest.test_sample_process): Moved to DarwinTest.
1592         (MacTest.test_sample_process_exception): Moved to DarwinTest.
1593         * Scripts/webkitpy/port/port_testcase.py:
1594         (PortTestCase):
1595         (PortTestCase.test_diff_image): Added is_simulator flag.
1596         (PortTestCase.test_diff_image): Skip test if on a simulator.
1597         (PortTestCase.test_diff_image_crashed): Skip test if on a simulator.
1598         * Scripts/webkitpy/port/win.py:
1599         (WinPort):
1600         (WinPort.look_for_new_samples): Used default, ApplePort no longer implements.
1601         (WinPort.sample_process): Ditto.
1602         (WinPort._make_leak_detector): Ditto.
1603         (WinPort.check_for_leaks): Ditto.
1604         (WinPort.print_leaks_summary): Ditto.
1605         (WinPort._path_to_webcore_library): Ditto.
1606
1607 2016-10-07  Anders Carlsson  <andersca@apple.com>
1608
1609         Get rid of WKPageSetSession
1610         https://bugs.webkit.org/show_bug.cgi?id=163129
1611
1612         Reviewed by Tim Horton.
1613
1614         Rewrite this test to use WKPageConfigurationRef and WKWebsiteDataStoreRef.
1615
1616         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1617         (TestWebKitAPI::TEST):
1618
1619 2016-10-07  Andreas Kling  <akling@apple.com>
1620
1621         [WK2] didRemoveFrameFromHierarchy callback doesn't fire for subframes when evicting from PageCache.
1622         <https://webkit.org/b/163098>
1623         <rdar://problem/28663488>
1624
1625         Reviewed by Antti Koivisto.
1626
1627         Add an API test that puts a 10-subframe page into the page cache, then loads other pages
1628         until the first page gets kicked out. The test succeeds if we receive didRemoveFrameFromHierarchy
1629         callbacks for all the subframes.
1630
1631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1632         * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp: Added.
1633         (TestWebKitAPI::didFinishLoadForFrame):
1634         (TestWebKitAPI::setPageLoaderClient):
1635         (TestWebKitAPI::didReceivePageMessageFromInjectedBundle):
1636         (TestWebKitAPI::setInjectedBundleClient):
1637         (TestWebKitAPI::TEST):
1638         * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp: Added.
1639         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1640         (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::DidRemoveFrameFromHiearchyInPageCacheTest):
1641         (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::didCreatePage):
1642         * TestWebKitAPI/Tests/WebKit2/many-iframes.html: Added.
1643
1644 2016-10-07  Emanuele Aina  <emanuele.aina@collabora.com>
1645
1646         Replace bug URL placeholders independently of the short desc one
1647         https://bugs.webkit.org/show_bug.cgi?id=161684
1648
1649         Reviewed by Darin Adler.
1650
1651         Instead of adding the bug URL when replacing the short description
1652         placeholder and then ignoring the bug URL placeholder, use the former
1653         to set the short description and the latter for the bug URL.
1654         This means that developers can fully prepare the changelog with short
1655         and long description before submission leaving the bug placeholder in
1656         place, and the changelog machinery will make sure to replace the
1657         latter with the URL of the newly created bug while submitting.
1658
1659         Note that this also means that the short description placeholder alone
1660         no longer causes the bug URL to be added.
1661
1662         * Scripts/webkitpy/common/checkout/changelog.py:
1663         (ChangeLog.set_short_description_and_bug_url):
1664         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1665         (test_set_short_description_and_bug_url):
1666
1667 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
1668
1669         Style Checking Error when Objective C Blocks passed as Argument
1670         https://bugs.webkit.org/show_bug.cgi?id=162463
1671
1672         Reviewed by Darin Adler.
1673
1674         * Scripts/webkitpy/style/checkers/cpp.py:
1675         (regex_for_lambdas_and_blocks): Consider case where block is passed as a function argument.
1676         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1677         (CppStyleTest.test_objective_c_block_as_argument): Test case where block is passed as a function argument. 
1678
1679 2016-10-07  Philippe Normand  <pnormand@igalia.com>
1680
1681         [GTK] Docs build failure
1682         https://bugs.webkit.org/show_bug.cgi?id=163102
1683
1684         Reviewed by Carlos Garcia Campos.
1685
1686         * gtk/jhbuild.modules: Bump to gtk-doc 1.25 to fix build errors on Debian Testing.
1687
1688 2016-10-06  Joseph Pecoraro  <pecoraro@apple.com>
1689
1690         check-webkit-style: Enable the legal/copyright rule for cpp/h files
1691         https://bugs.webkit.org/show_bug.cgi?id=162707
1692
1693         Reviewed by Darin Adler.
1694
1695         * Scripts/webkitpy/style/checker.py:
1696         Enable this rule by default.
1697
1698 2016-10-06  Joseph Pecoraro  <pecoraro@apple.com>
1699
1700         Header guard style should be updated to be "#pragma once"
1701         https://bugs.webkit.org/show_bug.cgi?id=159785
1702
1703         Reviewed by Darin Adler.
1704
1705         * Scripts/webkitpy/style/checkers/cpp.py:
1706         (check_for_header_guard):
1707         (_process_lines):
1708         Simplify header_guard check to warn for a missing #pragma once
1709         in header files. For legacy files that contain an #ifndef only
1710         warn if the #ifndef line itself is changing.
1711
1712         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1713         (CppStyleTestBase.perform_header_guard_check):
1714         (CppStyleTestBase.assert_header_guard):
1715         Helpers for enabling just this warning.
1716
1717         (CppStyleTest.test_build_header_guard):
1718         Test different header guard cases.
1719
1720         * Scripts/webkitpy/style/error_handlers.py:
1721         (DefaultStyleErrorHandler.should_line_be_checked):
1722         Always allow warnings that output for "line 0" which won't be in
1723         the list of modified lines that are 1-based.
1724
1725 2016-10-06  Commit Queue  <commit-queue@webkit.org>
1726
1727         Unreviewed, rolling out r206713.
1728         https://bugs.webkit.org/show_bug.cgi?id=163097
1729
1730         triggers apparent codegen bug on ARM 32-bit (Requested by smfr
1731         on #webkit).
1732
1733         Reverted changeset:
1734
1735         "Support transitions/animations of background-position with
1736         right/bottom-relative values"
1737         https://bugs.webkit.org/show_bug.cgi?id=162048
1738         http://trac.webkit.org/changeset/206713
1739
1740 2016-10-06  Alex Christensen  <achristensen@webkit.org>
1741
1742         URLParser: Non-ASCII characters in Non-UTF-8 encoded queries of relative URLs with ws, wss, or nonspecial schemes should be UTF-8 encoded
1743         https://bugs.webkit.org/show_bug.cgi?id=163089
1744
1745         Reviewed by Tim Horton.
1746
1747         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1748         (TestWebKitAPI::checkURL):
1749         (TestWebKitAPI::TEST_F):
1750
1751 2016-10-06  Alex Christensen  <achristensen@webkit.org>
1752
1753         Skip tabs and newlines between end of query and beginning of fragment in non-UTF-8-encoded URLs
1754         https://bugs.webkit.org/show_bug.cgi?id=163071
1755
1756         Reviewed by Tim Horton.
1757
1758         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1759         (TestWebKitAPI::TEST_F):
1760
1761 2016-10-06  Alex Christensen  <achristensen@webkit.org>
1762
1763         URLParser should parse file URLs with ports consistently
1764         https://bugs.webkit.org/show_bug.cgi?id=163075
1765
1766         Reviewed by Brady Eidson.
1767
1768         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1769         (TestWebKitAPI::TEST_F):
1770
1771 2016-10-06  John Wilander  <wilander@apple.com>
1772
1773         Update Resource Load Statistics
1774         https://bugs.webkit.org/show_bug.cgi?id=162811
1775
1776         Reviewed by Alex Christensen.
1777
1778         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
1779             Change from USE(PUBLIC_SUFFIX_LIST) to ENABLE(PUBLIC_SUFFIX_LIST)
1780
1781 2016-10-05  Philippe Normand  <pnormand@igalia.com>
1782
1783         [GStreamer][OWR] GL rendering support
1784         https://bugs.webkit.org/show_bug.cgi?id=162972
1785
1786         Reviewed by Žan Doberšek.
1787
1788         When GStreamer-GL is enabled the GL context needs to be properly passed
1789         to the GStreamer pipeline running within the OpenWebRTC video renderer.
1790         This is now supported using a new OpenWebRTC API that allows the
1791         renderer to request the context from the application using a callback
1792         registered within the renderer.
1793
1794         * gtk/jhbuild.modules: Bump to latest OpenWebRTC for the new
1795         owr_video_renderer_set_request_context_callback API added
1796         recently.
1797
1798 2016-10-05  Youenn Fablet  <youenn@apple.com>
1799
1800         Reuse CodeGenerator::UpdateFile in Tools CodeGenerator
1801         https://bugs.webkit.org/show_bug.cgi?id=162960
1802
1803         Reviewed by Alex Christensen.
1804
1805         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1806         (WriteData): Using CodeGenerator::UpdateFile to do lazy generated file update when it is made feasible.
1807         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1808         (WriteData): Ditto.
1809
1810 2016-10-05  Alex Christensen  <achristensen@webkit.org>
1811
1812         URLParser should parse IPv4 addresses as the last two pieces of an IPv6 address
1813         https://bugs.webkit.org/show_bug.cgi?id=162991
1814
1815         Reviewed by Saam Barati.
1816
1817         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1818         (TestWebKitAPI::TEST_F):
1819
1820 2016-10-05  Tim Horton  <timothy_horton@apple.com>
1821
1822         Avoid automatically re-taking snapshots for back-forward items that were never loaded into the view
1823         https://bugs.webkit.org/show_bug.cgi?id=162955
1824         <rdar://problem/27659173>
1825
1826         Reviewed by Simon Fraser.
1827
1828         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1829         (-[SnapshotTestWKWebView init]):
1830         (forceRepaintCallback):
1831         (-[SnapshotTestWKWebView synchronouslyForceRepaint]):
1832         (-[SnapshotTestWKWebView synchronouslyLoadTestPageAndForceRepaint:]):
1833         (TEST):
1834         (makeRedSquareView):
1835         Add a test that restoring session state into a web view without navigating,
1836         then explicitly snapshotting and navigating away, leaves the original snapshot alone.
1837
1838         Adjust the existing test, as well, to ensure that it will reliably fail
1839         if the feature is broken. Use an explicitly added and removed red square
1840         instead of scrolling, because we can't scroll in the restore-without-navigating case.
1841
1842         Stop trying to override the window scale, because it's not working (we're getting partial snapshots)
1843         and isn't necessary; instead just multiply the expected value by the page scale.
1844
1845         (-[SnapshotTestWKWebView loadPageNamed:]): Deleted.
1846         * TestWebKitAPI/mac/TestWKWebViewMac.h:
1847         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
1848         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1849         Reorganize to reduce duplication.
1850
1851 2016-10-05  Tim Horton  <timothy_horton@apple.com>
1852
1853         Make it possible to test ViewSnapshotStore behaviors
1854         https://bugs.webkit.org/show_bug.cgi?id=162983
1855
1856         Reviewed by Simon Fraser.
1857
1858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1859         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: Added.
1860         (-[SnapshotTestWKWebView init]):
1861         (-[SnapshotTestWKWebView loadPageNamed:]):
1862         (imagesAreEqual):
1863         Add tests for existing basic snapshotting behavior:
1864
1865         - a back-forward item shouldn't have a snapshot
1866           until it is navigated away from
1867
1868         - causing a back-forward item to fall out of the
1869           back-forward list should remove the snapshot
1870
1871         - calling the explicit snapshotting SPI, then navigating away from the page,
1872           should result in the snapshot being retaken
1873
1874 2016-10-05  Chris Dumez  <cdumez@apple.com>
1875
1876         KeyboardEvent.getModifierState() should support "CapsLock" modifier
1877         https://bugs.webkit.org/show_bug.cgi?id=162861
1878
1879         Reviewed by Darin Adler.
1880
1881         Add support for 'capsLockKey' modifier for EventSender.keyDown() so
1882         that we can test this new modifier support for layout tests.
1883
1884         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1885         (TestWebKitAPI::modifierFlagsForWKModifiers):
1886         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1887         (WTR::parseModifier):
1888         * WebKitTestRunner/mac/EventSenderProxy.mm:
1889         (WTR::buildModifierFlags):
1890
1891 2016-10-05  Jeremy Jones  <jeremyj@apple.com>
1892
1893         Add MobileMiniBrowser tests for control center and looping fullscreen.
1894         https://bugs.webkit.org/show_bug.cgi?id=162748
1895
1896         Reviewed by Jer Noble.
1897
1898         Refactor existing MobileMiniBrowserTests and add new tests for 
1899         - fullscreen rotation
1900         - fullscreen looping (failing)
1901         - control center interruption (failing)
1902
1903         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1904         * MobileMiniBrowser/MobileMiniBrowserFramework/Resources/looping2s.html: Added.
1905         * MobileMiniBrowser/MobileMiniBrowserFramework/test2s.mp4: Added.
1906         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
1907         (-[MobileMiniBrowserUITests setUp]):
1908         (-[MobileMiniBrowserUITests waitToTapButtonNamed:forApp:]):
1909         (-[MobileMiniBrowserUITests loadURL:]):
1910         (-[MobileMiniBrowserUITests requireMinFPS:sampleDurationSeconds:message:]):
1911         (-[MobileMiniBrowserUITests ensureFullscreenControls]):
1912         (-[MobileMiniBrowserUITests timeForTimeString:]):
1913         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
1914         (-[MobileMiniBrowserUITests testBasicVideoFullscreen]):
1915         (-[MobileMiniBrowserUITests testVideoFullscreenAndRotationAnimation]):
1916         (-[MobileMiniBrowserUITests testVideoFullscreenControlCenter]):
1917         (-[MobileMiniBrowserUITests testLoopingFullscreenLockup]):
1918
1919 2016-10-05  Alex Christensen  <achristensen@webkit.org>
1920
1921         URLParser should correctly strip unnecessary 0's in IPv6 addresses
1922         https://bugs.webkit.org/show_bug.cgi?id=162979
1923
1924         Reviewed by Brady Eidson.
1925
1926         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1927         (TestWebKitAPI::TEST_F):
1928
1929 2016-10-05  Alex Christensen  <achristensen@webkit.org>
1930
1931         UTF-8 encode queries of nonspecial and websocket schemes
1932         https://bugs.webkit.org/show_bug.cgi?id=162956
1933
1934         Reviewed by Geoffrey Garen and Brady Eidson.
1935
1936         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1937         (TestWebKitAPI::TEST_F):
1938
1939 2016-10-05  Alex Christensen  <achristensen@webkit.org>
1940
1941         Prepare to enable URLParser
1942         https://bugs.webkit.org/show_bug.cgi?id=162974
1943
1944         Reviewed by Brady Eidson.
1945
1946         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1947         (TestWebKitAPI::TEST_F):
1948         Added some tests that are unrelated to the code change, but these are
1949         reflected in changed LayoutTest results when enabling the URLParser,
1950         and they weren't in the URLParser tests yet.  They should be.
1951
1952 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
1953
1954         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
1955         https://bugs.webkit.org/show_bug.cgi?id=162903
1956
1957         Reviewed by Alex Christensen.
1958
1959         Rename build guards for the remaining implementation of the legacy EME API
1960         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
1961         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
1962
1963         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Also remove the
1964         ENABLE_IOS_TEXT_AUTOSIZING feature define that was renamed in r206395 and was
1965         throwing up style checker errors.
1966
1967 2016-10-04  Andy Estes  <aestes@apple.com>
1968
1969         [iOS] Crash in WebResourceLoaderQuickLookDelegate when the client cancels the navigation to a QuickLook resource
1970         https://bugs.webkit.org/show_bug.cgi?id=162950
1971         <rdar://problem/23759114>
1972
1973         Reviewed by Brady Eidson.
1974
1975         Added a new API test.
1976
1977         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Sorted imports and removed redundant
1978         initialization of static bools.
1979         (runTest): Factored out the common test logic between QuickLook.NavigationDelegate and
1980         QuickLook.CancelNavigationAfterResponse.
1981         (TEST): Added QuickLook.CancelNavigationAfterResponse.
1982         (-[QuickLookDecidePolicyDelegate
1983         webView:decidePolicyForNavigationResponse:decisionHandler:]): Canceled the navigation.
1984         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Set
1985         isDone to true.
1986
1987 2016-10-04  Ryosuke Niwa  <rniwa@webkit.org>
1988
1989         Add the support for running ES6SampleBench to run-benchmark
1990         https://bugs.webkit.org/show_bug.cgi?id=162890
1991
1992         Reviewed by Saam Barati.
1993
1994         Added the support for running ES6SampleBench as "es6bench".
1995         e.g. ./Tools/Scripts/run-benchmark --platform osx --plan es6bench --browser safari
1996
1997         Instead of the default 10 iterations, run the test 4 iterations using 5 instances of browser
1998         for the total of 20 iterations.
1999
2000         * Scripts/webkitpy/benchmark_runner/data/patches/ES6SampleBench.patch: Added.
2001         * Scripts/webkitpy/benchmark_runner/data/plans/es6bench.plan: Added.
2002         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2003         (start): Fixed the bug that the linter will complain about the presence of "debugOutput" by
2004         removing it if it's present.
2005
2006 2016-10-04  Simon Fraser  <simon.fraser@apple.com>
2007
2008         [iOS WK2] Make it possible for a test to describe a user gesture as a stream of events in JSON format
2009         https://bugs.webkit.org/show_bug.cgi?id=162934
2010
2011         Reviewed by Dean Jackson.
2012
2013         With this change, a test can describe a user gesture in an "event stream", which is
2014         some JSON describing an array of events with their underlying touches. The added
2015         test describes a single tap.
2016         
2017         The implementation fires up an NSThread, and sleeps the thread between events to dispatch
2018         them at close to real time.
2019         
2020         In future, HIDEventGenerator could use this internally for all of the "compound" interactions.
2021
2022         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2023         (WTR::UIScriptController::sendEventStream):
2024         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2025         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2026         (WTR::UIScriptController::sendEventStream):
2027         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2028         * WebKitTestRunner/ios/HIDEventGenerator.h:
2029         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2030         (transducerTypeFromString):
2031         (phaseFromString):
2032         (-[HIDEventGenerator eventMaskFromEventInfo:]):
2033         (-[HIDEventGenerator touchFromEventInfo:]):
2034         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
2035         (-[HIDEventGenerator dispatchEventWithInfo:]):
2036         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2037         (-[HIDEventGenerator sendEventStream:completionBlock:]):
2038         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2039         (WTR::UIScriptController::sendEventStream):
2040
2041 2016-10-04  Megan Gardner  <megan_gardner@apple.com>
2042
2043         Add Megan to contributor's list
2044         https://bugs.webkit.org/show_bug.cgi?id=162944
2045
2046         Reviewed by Tim Horton.
2047
2048         Add Megan to the contributor's lists so that her e-mail autocompletes for CC
2049
2050         * Scripts/webkitpy/common/config/contributors.json:
2051
2052 2016-10-04  Alex Christensen  <achristensen@webkit.org>
2053
2054         Add tests verifying non-special URL hosts are parsed according to spec
2055         https://bugs.webkit.org/show_bug.cgi?id=162885
2056
2057         Reviewed by Sam Weinig.
2058
2059         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2060         (TestWebKitAPI::TEST_F):
2061
2062 2016-10-04  Anders Carlsson  <andersca@apple.com>
2063
2064         Properly kill web processes in the launching state
2065         https://bugs.webkit.org/show_bug.cgi?id=162938
2066
2067         Reviewed by Tim Horton.
2068
2069         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
2070         Enable this test again.
2071
2072 2016-10-04  Alex Christensen  <achristensen@webkit.org>
2073
2074         URLParser: query-only URLs relative to file URLs should just add a query
2075         https://bugs.webkit.org/show_bug.cgi?id=162888
2076
2077         Reviewed by Tim Horton.
2078
2079         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2080         (TestWebKitAPI::TEST_F):
2081
2082 2016-10-04  Alex Christensen  <achristensen@webkit.org>
2083
2084         URLParser should match URL::parse and other browsers when parsing a URL containing only scheme://
2085         https://bugs.webkit.org/show_bug.cgi?id=162909
2086
2087         Reviewed by Tim Horton.
2088
2089         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2090         (TestWebKitAPI::TEST_F):
2091
2092 2016-10-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2093
2094         [DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information
2095         https://bugs.webkit.org/show_bug.cgi?id=162916
2096
2097         Reviewed by Filip Pizlo.
2098
2099         * DumpRenderTree/CMakeLists.txt:
2100
2101 2016-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2102
2103         Media controls are displayed in the incorrect state momentarily after switching between tabs playing media
2104         https://bugs.webkit.org/show_bug.cgi?id=162766
2105         <rdar://problem/28533523>
2106
2107         Reviewed by Jer Noble.
2108
2109         Adds new tests and tweaks existing tests to verify last updated Now Playing information.
2110
2111         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2112         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]):
2113         (TestWebKitAPI::TEST):
2114         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]): Deleted.
2115         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html:
2116
2117 2016-10-03  Alex Christensen  <achristensen@webkit.org>
2118
2119         URLParser should ignore tabs at all locations
2120         https://bugs.webkit.org/show_bug.cgi?id=162836
2121
2122         Reviewed by Geoffrey Garen.
2123
2124         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2125         (TestWebKitAPI::checkURL):
2126         (TestWebKitAPI::checkRelativeURL):
2127         (TestWebKitAPI::checkURLDifferences):
2128         (TestWebKitAPI::checkRelativeURLDifferences):
2129         (TestWebKitAPI::TEST_F):
2130
2131 2016-10-03  Alex Christensen  <achristensen@webkit.org>
2132
2133         URLParser: fragment-only URLs relative to file URLs should just add a fragment
2134         https://bugs.webkit.org/show_bug.cgi?id=162871
2135
2136         Reviewed by Geoffrey Garen.
2137
2138         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2139         (TestWebKitAPI::TEST_F):
2140
2141 2016-10-03  Per Arne Vollan  <pvollan@apple.com>
2142
2143         [Win] DRT temp folder is not used.
2144         https://bugs.webkit.org/show_bug.cgi?id=162863
2145
2146         Reviewed by Alex Christensen.
2147
2148         Convert DRT temp folder to DOS path, which DRT can use.
2149
2150         * Scripts/webkitpy/port/driver.py:
2151         (Driver._setup_environ_for_driver):
2152
2153 2016-10-03  Alex Christensen  <achristensen@webkit.org>
2154
2155         URLParser: empty relative URLs should not copy fragment from the base URL
2156         https://bugs.webkit.org/show_bug.cgi?id=162864
2157
2158         Reviewed by Chris Dumez.
2159
2160         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2161         (TestWebKitAPI::TEST_F):
2162
2163 2016-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2164
2165         [SOUP] Cleanup persistent credential storage code
2166         https://bugs.webkit.org/show_bug.cgi?id=162777
2167
2168         Reviewed by Alex Christensen.
2169
2170         Use USE(LIBSECRET) instead of ENABLE(CREDENTIAL_STORAGE).
2171
2172         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2173         (testWebViewAuthenticationStorage):
2174
2175 2016-10-02  Darin Adler  <darin@apple.com>
2176
2177         Rename ExceptionCode-based exception handling to "legacy"
2178         https://bugs.webkit.org/show_bug.cgi?id=162859
2179
2180         Reviewed by Chris Dumez.
2181
2182         * Scripts/do-webcore-rename: Updated script to do this round of renames.
2183
2184 2016-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2185
2186         Media controls for Soundcloud easily falls out of sync with what's actually playing
2187         https://bugs.webkit.org/show_bug.cgi?id=162843
2188         <rdar://problem/28176874>
2189
2190         Reviewed by Beth Dakin.
2191
2192         Adds two new tests simulating audio playback behavior on soundcloud. Also tweaks some of the WKWebView test
2193         message handling logic to support having multiple message-handler mappings.
2194
2195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2196         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2197         (TestWebKitAPI::TEST):
2198         * TestWebKitAPI/Tests/WebKit2Cocoa/play-audio-on-click.html: Added.
2199         * TestWebKitAPI/mac/TestWKWebViewMac.h:
2200         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
2201         (-[TestMessageHandler addMessage:withHandler:]):
2202         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2203         (-[TestWKWebView performAfterReceivingMessage:action:]):
2204         (-[TestWKWebView performAfterLoading:]):
2205         (-[TestMessageHandler initWithMessage:handler:]): Deleted.
2206
2207 2016-09-30  Alex Christensen  <achristensen@webkit.org>
2208
2209         Fix off-by-one error in URLParser::parseIPv4Host
2210         https://bugs.webkit.org/show_bug.cgi?id=162789
2211
2212         Reviewed by Tim Horton.
2213
2214         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2215         (TestWebKitAPI::TEST_F):
2216
2217 2016-09-30  Alex Christensen  <achristensen@webkit.org>
2218
2219         URLParser: parsing a URL with an empty host and a colon should fail
2220         https://bugs.webkit.org/show_bug.cgi?id=162795
2221
2222         Reviewed by Tim Horton.
2223
2224         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2225         (TestWebKitAPI::TEST_F):
2226
2227 2016-09-30  Alex Christensen  <achristensen@webkit.org>
2228
2229         URLParser: handle syntax violations in non-UTF-8 encoded queries
2230         https://bugs.webkit.org/show_bug.cgi?id=162770
2231
2232         Reviewed by Tim Horton.
2233
2234         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2235         (TestWebKitAPI::checkURL):
2236         (TestWebKitAPI::TEST_F):
2237         Tests with emoji change behavior when we insert a tab between the surrogates, so don't do the
2238         insert-tab-at-each-location verification that syntax violations are handled correctly.
2239
2240 2016-09-30  Megan Gardner  <megan_gardner@apple.com>
2241
2242         Make it possible to test web-related user-interface features
2243         https://bugs.webkit.org/show_bug.cgi?id=162657
2244
2245         Reviewed by Simon Fraser.
2246
2247         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2248         (WTR::UIScriptController::contentsOfUserInterfaceItem):
2249         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
2250         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2251         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2252         (WTR::UIScriptController::contentsOfUserInterfaceItem):
2253         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
2254         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2255         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2256         (WTR::UIScriptController::contentsOfUserInterfaceItem):
2257         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
2258
2259 2016-09-29  Jiewen Tan  <jiewen_tan@apple.com>
2260
2261         Expose CryptoKey to web workers
2262         https://bugs.webkit.org/show_bug.cgi?id=162640
2263         <rdar://problem/28182204>
2264
2265         Reviewed by Brent Fulgham.
2266
2267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2268         * TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm: Added.
2269         (TestWebKitAPI::TEST_F):
2270         Add API tests for SerializedCryptoKeyWrap APIs.
2271
2272 2016-09-29  Alex Christensen  <achristensen@webkit.org>
2273
2274         Fix syntax violation handling in IPv4 address parsing
2275         https://bugs.webkit.org/show_bug.cgi?id=162756
2276
2277         Reviewed by Tim Horton.
2278
2279         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2280         (TestWebKitAPI::TEST_F):
2281
2282 2016-09-29  Alex Christensen  <achristensen@webkit.org>
2283
2284         URLParser should correctly parse ports with leading 0's
2285         https://bugs.webkit.org/show_bug.cgi?id=162752
2286
2287         Reviewed by Tim Horton.
2288
2289         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2290         (TestWebKitAPI::TEST_F):
2291
2292 2016-09-29  Alex Christensen  <achristensen@webkit.org>
2293
2294         URLParser: make parsing invalid IPv4 addresses more robust and correct
2295         https://bugs.webkit.org/show_bug.cgi?id=162746
2296
2297         Reviewed by Tim Horton.
2298
2299         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2300         (TestWebKitAPI::TEST_F):
2301
2302 2016-09-29  Alex Christensen  <achristensen@webkit.org>
2303
2304         URLParser: IPv6 addresses followed by a colon are invalid
2305         https://bugs.webkit.org/show_bug.cgi?id=162747
2306
2307         Reviewed by Tim Horton.
2308
2309         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2310         (TestWebKitAPI::TEST_F):
2311
2312 2016-09-29  Alexey Proskuryakov  <ap@apple.com>
2313
2314         Make WKTR short timeout dynamic
2315         https://bugs.webkit.org/show_bug.cgi?id=162733
2316
2317         Reviewed by Alex Christensen.
2318
2319         WebKitTestRunner has a hardcoded value for how long to wait for IPC responses,
2320         which is 5 seconds, or 10 seconds under ASan. But some of the operations can be
2321         fairly time consuming - e.g. launching Networking process on demand.
2322         These may take longer under load, especially with GuardMalloc.
2323
2324         * WebKitTestRunner/TestController.cpp:
2325         (WTR::TestController::resetStateToConsistentValues):
2326         (WTR::TestController::reattachPageToWebProcess):
2327         * WebKitTestRunner/TestController.h:
2328         * WebKitTestRunner/TestInvocation.cpp:
2329         (WTR::TestInvocation::shortTimeout):
2330         (WTR::TestInvocation::invoke):
2331         (WTR::TestInvocation::dumpResults):
2332
2333         * WebKitTestRunner/TestInvocation.h:
2334         (WTR::TestInvocation::customTimeout): Deleted, this function was unused.
2335
2336 2016-09-29  Alex Christensen  <achristensen@webkit.org>
2337
2338         URLParser should fail to parse unclosed IPv6 addresses
2339         https://bugs.webkit.org/show_bug.cgi?id=162715
2340
2341         Reviewed by Tim Horton.
2342
2343         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2344         (TestWebKitAPI::TEST_F):
2345
2346 2016-09-29  Alex Christensen  <achristensen@webkit.org>
2347
2348         URLParser should ignore tabs at all possible locations
2349         https://bugs.webkit.org/show_bug.cgi?id=162711
2350
2351         Reviewed by Tim Horton.
2352
2353         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2354         (TestWebKitAPI::ExpectedParts::isInvalid):
2355         (TestWebKitAPI::checkURL):
2356         (TestWebKitAPI::TEST_F):
2357
2358 2016-09-29  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
2359
2360         [EFL] Add search button to url bar in MiniBrowser
2361         https://bugs.webkit.org/show_bug.cgi?id=162716
2362
2363         Reviewed by Michael Catanzaro.
2364
2365         As a bug title, it would be good to add a search button to URL bar.
2366         Additionally this patch changes color of button to recognize the buttons.
2367
2368         * MiniBrowser/efl/main.c:
2369         (_search_button_clicked_cb):
2370         (_create_toolbar_button):
2371         (window_create):
2372         (create_toolbar_button): Deleted.
2373
2374 2016-09-28  Tim Horton  <timothy_horton@apple.com>
2375
2376         API test WebKit2.AutoLayoutIntegration is a flaky timeout
2377         https://bugs.webkit.org/show_bug.cgi?id=160284
2378
2379         Reviewed by Dan Bernstein.
2380
2381         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2382         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
2383         (-[AutoLayoutWKWebView beginLayoutAtMinimumWidth:andExpectContentSizeChange:]):
2384         (-[AutoLayoutWKWebView waitForContentSizeChangeResettingWidth:]):
2385         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
2386         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
2387         (TEST):
2388         Make the autolayout tests a bit more flexible regarding the ordering of
2389         invalidateIntrinsicContentSize, to avoid a race between the load
2390         completing and the invalidation.
2391
2392         Also, move the newly added test to use its own WKWebView, since once in a
2393         while we get a first layout notification from the previous page, causing the test to fail.
2394
2395         Un-disable the tests, which now run without any flakes for me with quite a few iterations.
2396
2397 2016-09-28  Alex Christensen  <achristensen@webkit.org>
2398
2399         URLParser should properly handle unexpected periods and overflows in IPv4 addresses
2400         https://bugs.webkit.org/show_bug.cgi?id=162655
2401
2402         Reviewed by Geoffrey Garen.
2403
2404         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2405         (TestWebKitAPI::TEST_F):
2406
2407 2016-09-28  Ryan Haddad  <ryanhaddad@apple.com>
2408
2409         Disable flaky API test WebKit2.AutoLayoutIntegration.
2410         https://bugs.webkit.org/show_bug.cgi?id=160284
2411
2412         Unreviewed test gardening.
2413
2414         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2415         (TEST):
2416
2417 2016-09-28  Alex Christensen  <achristensen@webkit.org>
2418
2419         URLParser should ignore tabs in authority
2420         https://bugs.webkit.org/show_bug.cgi?id=162694
2421
2422         Reviewed by Geoffrey Garen.
2423
2424         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2425         (TestWebKitAPI::TEST_F):
2426
2427 2016-09-28  Alex Christensen  <achristensen@webkit.org>
2428
2429         URLParser should ignore extra slashes after scheme:// and handle a missing slash after the port
2430         https://bugs.webkit.org/show_bug.cgi?id=162690
2431
2432         Reviewed by Geoffrey Garen.
2433
2434         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2435         (TestWebKitAPI::TEST_F):
2436
2437 2016-09-28  Alex Christensen  <achristensen@webkit.org>
2438
2439         URLParser should correctly canonicalize uppercase IPv6 addresses
2440         https://bugs.webkit.org/show_bug.cgi?id=162680
2441
2442         Reviewed by Tim Horton.
2443
2444         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2445         (TestWebKitAPI::TEST_F):
2446
2447 2016-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2448
2449         Adopt MediaRemote SPI to achieve desired Now Playing behavior
2450         https://bugs.webkit.org/show_bug.cgi?id=162658
2451         <rdar://problem/28499358>
2452
2453         Reviewed by Jer Noble.
2454
2455         Introduces 2 unit tests in the new NowPlayingControlsTests test suite. Also provides some basic support for
2456         mocking key window status for TestWKWebViews.
2457
2458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2459         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: Added.
2460         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
2461         (-[NowPlayingTestWebView expectHasActiveNowPlayingSession:]):
2462         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]):
2463         (TestWebKitAPI::TEST):
2464         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html: Added.
2465         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
2466         (-[TestWKWebViewHostWindow isKeyWindow]):
2467         (-[TestWKWebViewHostWindow makeKeyWindow]):
2468         (-[TestWKWebViewHostWindow resignKeyWindow]):
2469
2470 2016-09-28  Per Arne Vollan  <pvollan@apple.com>
2471
2472         [Win] Compile fix.
2473         https://bugs.webkit.org/show_bug.cgi?id=162670
2474
2475         Reviewed by Brent Fulgham.
2476
2477         Make sure we include JavaScriptCore files from the forwarding headers folder.
2478         Otherwise we might get multiple definitions if a JSC file is included both
2479         from the forwarding headers folder and the JSC source folder, since
2480         #pragma once is used in the header files.
2481
2482         * DumpRenderTree/TestRunner.cpp:
2483
2484 2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2485
2486         [GTK] Add Chrome UA quirk
2487         https://bugs.webkit.org/show_bug.cgi?id=162617
2488
2489         Reviewed by Carlos Garcia Campos.
2490
2491         Update test. This portion of the commit was actually unreviewed.
2492
2493         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
2494         (TestWebKitAPI::TEST):
2495
2496 2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2497
2498         [GTK] Adjust OS X UA quirks list
2499         https://bugs.webkit.org/show_bug.cgi?id=162616
2500
2501         "Reviewed" by Carlos Garcia Campos.
2502
2503         Update test. This portion of the commit was actually unreviewed.
2504
2505         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
2506         (TestWebKitAPI::TEST):
2507
2508 2016-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2509
2510         [GTK] Switch to use GMenu internally in the context menu implementation
2511         https://bugs.webkit.org/show_bug.cgi?id=162603
2512
2513         Reviewed by Michael Catanzaro.
2514
2515         Remove smart separators test, since that's now done automatically by GTK+.
2516
2517         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2518         (beforeAll):
2519         (testContextMenuWebExtensionMenu): Deleted.
2520
2521 2016-09-27  Alex Christensen  <achristensen@webkit.org>
2522
2523         Correctly parse URLs with the first tab in the fragment
2524         https://bugs.webkit.org/show_bug.cgi?id=162650
2525
2526         Reviewed by Saam Barati.
2527
2528         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2529         (TestWebKitAPI::TEST_F):
2530
2531 2016-09-27  Alex Christensen  <achristensen@webkit.org>
2532
2533         URLParser: Handle windows drive letters after two slashes in relative URLs according to spec
2534         https://bugs.webkit.org/show_bug.cgi?id=162646
2535
2536         Reviewed by Saam Barati.
2537
2538         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2539         (TestWebKitAPI::TEST_F):
2540
2541 2016-09-27  Alex Christensen  <achristensen@webkit.org>
2542
2543         URLs with @ in the user should only search for the last @ until the end of the authority and host
2544         https://bugs.webkit.org/show_bug.cgi?id=162635
2545
2546         Reviewed by Geoffrey Garen.
2547
2548         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2549         (TestWebKitAPI::TEST_F):
2550
2551 2016-09-27  JF Bastien  <jfbastien@apple.com>
2552
2553         Speed up Heap::isMarkedConcurrently
2554         https://bugs.webkit.org/show_bug.cgi?id=162095
2555
2556         Reviewed by Filip Pizlo.
2557
2558         * TestWebKitAPI/CMakeLists.txt:
2559         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2560         * TestWebKitAPI/Tests/WTF/Consume.cpp: Added.
2561         (testConsume):
2562         (TestWebKitAPI::TEST):
2563
2564 2016-09-26  Alex Christensen  <achristensen@webkit.org>
2565
2566         Implement URLParser::syntaxViolation
2567         https://bugs.webkit.org/show_bug.cgi?id=162593
2568
2569         Reviewed by Geoffrey Garen.
2570
2571         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2572         (TestWebKitAPI::TEST_F):
2573
2574 2016-09-27  Anders Carlsson  <andersca@apple.com>
2575
2576         Turns out OptionSet.cpp wasn't added to the right target. Add it and fix the build for real.
2577
2578         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2579         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2580         (TestWebKitAPI::TEST):
2581
2582 2016-09-27  Anders Carlsson  <andersca@apple.com>
2583
2584         Try to fix the GTK+ build.
2585
2586         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
2587         (TestWebKitAPI::TEST):
2588
2589 2016-09-27  Dan Bernstein  <mitz@apple.com>
2590
2591         [iOS] REGRESSION (r182126): Selection highlight and handles aren’t visible with WKSelectionGranularityCharacter
2592         https://bugs.webkit.org/show_bug.cgi?id=162577
2593         <rdar://problem/28481984>
2594
2595         Reviewed by Simon Fraser.
2596
2597         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2598         (WTR::UIScriptController::selectionRangeViewRects): Returns null.
2599
2600         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Declared new
2601           selectionRangeViewRects attribute.
2602
2603         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2604         (WTR::UIScriptContext::jsContext): Added this public accessor.
2605
2606         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2607         (WTR::selectionRangeViewRects): Generic implementation that returns null.
2608         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2609
2610         * WebKitTestRunner/TestController.cpp:
2611         (WTR::updateTestOptionsFromTestHeader): Parse the new useCharacterSelectionGranularity
2612           option.
2613
2614         * WebKitTestRunner/TestOptions.h: Added new useCharacterSelectionGranularity option.
2615
2616         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2617         (WTR::TestController::platformCreateWebView): Set the configuration’s selectionGranularity
2618           property based on the new option.
2619
2620         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2621         (WTR::PlatformWebView::viewSupportsOptions): Compare selection granularity option values.
2622
2623         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2624         (WTR::UIScriptController::selectionRangeViewRects): iOS-specific implementation that calls
2625           the new -[WKWebView _uiTextSelectionRectViews] and returns an array of view frame
2626           dictionaries.
2627
2628 2016-09-27  Daniel Bates  <dabates@apple.com>
2629
2630         Cannot run dump-class-layout; dies with "global name 'lldb' is not defined"
2631         https://bugs.webkit.org/show_bug.cgi?id=162585
2632
2633         Reviewed by Simon Fraser.
2634
2635         Import the lldb module into the global namespace.
2636
2637         Currently dump-class-layout imports the lldb Python module using the import statement
2638         from the helper function import_lldb. The import statement imports the names of the
2639         specified module into the scope of import_lldb(); => the names imported from this
2640         module cannot be accessed outside the scope of import_lldb(). Other functions in
2641         this script assume that the lldb module was imported into the global scope. We should
2642         import the module lldb into the global scope, if it exists, so that these functions
2643         can find it. Otherwise, we should emit a human readable error message that explains
2644         that we failed to import the lldb module.
2645
2646         Also remove some unnecessary semicolon characters.
2647
2648         * Scripts/dump-class-layout:
2649         (import_lldb):
2650
2651 2016-09-27  Jer Noble  <jer.noble@apple.com>
2652
2653         Remove deprecated ENCRYPTED_MEDIA implementation.
2654         https://bugs.webkit.org/show_bug.cgi?id=161010
2655
2656         Reviewed by Eric Carlson.
2657
2658         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2659
2660 2016-09-27  Chris Dumez  <cdumez@apple.com>
2661
2662         [WK2] Navigating to a Blob URL does not trigger a download
2663         https://bugs.webkit.org/show_bug.cgi?id=162574
2664
2665         Reviewed by Darin Adler.
2666
2667         Add API that tests navigating to a Blob URL and checks that that the load
2668         properly gets converted into a download.
2669
2670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2671         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2672         (-[BlobDownloadDelegate _downloadDidStart:]):
2673         (-[BlobDownloadDelegate _download:didReceiveResponse:]):
2674         (-[BlobDownloadDelegate _download:didReceiveData:]):
2675         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2676         (-[BlobDownloadDelegate _downloadDidFinish:]):
2677         (-[DownloadBlobURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2678         (TEST):
2679         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestBlobURL.html: Added.
2680
2681 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2682
2683         [GTK] Install binaries to pkglibexecdir rather than bindir
2684         https://bugs.webkit.org/show_bug.cgi?id=162602
2685
2686         Reviewed by Carlos Garcia Campos.
2687
2688         Install MiniBrowser to LIBEXEC_INSTALL_DIR rather than EXEC_INSTALL_DIR.
2689
2690         * MiniBrowser/gtk/CMakeLists.txt:
2691
2692 2016-09-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2693
2694         [EFL] Locate color picker popup to center of window
2695         https://bugs.webkit.org/show_bug.cgi?id=162540
2696
2697         Reviewed by Michael Catanzaro.
2698
2699         Color picker popup hasn't located in a center of main window, because
2700         elm_win_center() function doesn't work correctly. It looks a bug.
2701
2702         To fix the problem, this patch uses evas_object_geometry_set() instead.
2703
2704         * MiniBrowser/efl/main.c:
2705         (_color_picker_request_cb):
2706
2707 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2708
2709         [GTK] Disable ACCELERATED_2D_CANVAS when using build-webkit
2710         https://bugs.webkit.org/show_bug.cgi?id=162600
2711
2712         Reviewed by Carlos Garcia Campos.
2713
2714         * Scripts/webkitperl/FeatureList.pm:
2715
2716 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2717
2718         PyGIWarnings printed by webkit-patch
2719         https://bugs.webkit.org/show_bug.cgi?id=152470
2720
2721         Reviewed by Carlos Garcia Campos.
2722
2723         Update to a newer version of the keyring module, since this bug has been fixed upstream for
2724         a while. But be careful not to update to the latest version, since it has some compatibility
2725         breaks and requires the SecretService python module on Linux, but I couldn't figure out how
2726         to autoinstall it successfully.
2727
2728         * Scripts/webkitpy/thirdparty/__init__.py:
2729         (AutoinstallImportHook._install_keyring):
2730
2731 2016-09-26  Ryan Haddad  <ryanhaddad@apple.com>
2732
2733         Add Sierra to the flakiness dashboard.
2734         https://bugs.webkit.org/show_bug.cgi?id=162509
2735
2736         Reviewed by Alexey Proskuryakov.
2737
2738         * TestResultServer/static-dashboards/builders.jsonp:
2739
2740 2016-09-26  Daniel Bates  <dabates@apple.com>
2741
2742         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
2743         https://bugs.webkit.org/show_bug.cgi?id=162365
2744
2745         Reviewed by Simon Fraser.
2746
2747         * DumpRenderTree/TestRunner.h:
2748         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2749
2750 2016-09-26  Tomas Popela  <tpopela@redhat.com>
2751
2752         [GTK] TestContextMenu is failing
2753         https://bugs.webkit.org/show_bug.cgi?id=162569
2754
2755         We cannot use the MP3 file in the TestContextMenu, as it will not work
2756         by default on most distributions (that don't have an MP3 codecs
2757         installed). Change the test to use OGG file instead.
2758
2759         Reviewed by Michael Catanzaro.
2760
2761         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2762         (testContextMenuDefaultMenu):
2763
2764 2016-09-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2765
2766         Using char16_t instead of wchar_t in TestWebKitAPI URLParser tests
2767         https://bugs.webkit.org/show_bug.cgi?id=162537
2768
2769         Reviewed by Alex Christensen.
2770
2771         Some build bot (Linux ARM GTK port) fails since we cannot select
2772         the specific StringBuilder::append method for wchar_t.
2773
2774         wchar_t implementation highly depends on platforms. sizeof(wchar_t) == 2
2775         in Windows, while sizeof(wchar_t) == 4 in Linux and OS X. So, ICU
2776         uses wchar_t for UChar (UTF-16) in Windows while it doesn't in other
2777         platforms.
2778
2779         StringBuilder::append is overloaded for UChar. In Windows, we can pass
2780         wchar_t since UChar is wchar_t. However, we cannot do that in other platforms.
2781
2782         Instead of using wchar_t, we use more platform portable UTF-16 literal for
2783         testing. Use char16_t and C++11 UTF-16 literal.
2784
2785         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2786         (TestWebKitAPI::utf16String):
2787         (TestWebKitAPI::TEST_F):
2788         (TestWebKitAPI::wideString): Deleted.
2789
2790 2016-09-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2791
2792         [EFL] Adjust EFL indentation to EFL MiniBrowser
2793         https://bugs.webkit.org/show_bug.cgi?id=162542
2794
2795         Unreviewed, EFL simple coding style fix.
2796
2797         Some functions wasn't applied EFL coding style in prefix fix.
2798
2799         * MiniBrowser/efl/main.c:
2800         (_key_down_cb):
2801         (view_focus_set):
2802         (_mouse_down_cb):
2803         (title_set):
2804         (_title_changed_cb):
2805         (_url_changed_cb):
2806         (_back_forward_list_changed_cb):
2807         (_progress_cb):
2808         (_error_cb):
2809         (_download_request_cb):
2810         (close_file_picker):
2811         (_filepicker_parent_deletion_cb):
2812         (_filepicker_deletion_cb):
2813         (_fileselector_done_cb):
2814         (_file_chooser_request_cb):
2815         (_download_finished_cb):
2816         (_download_failed_cb):
2817         (_color_changed_cb):
2818         (_color_item_selected_cb):
2819         (_color_picker_ok_clicked_cb):
2820         (_color_picker_cancel_clicked_cb):
2821         (_color_picker_dismiss_cb):
2822         (_color_picker_request_cb):
2823         (quit):
2824         (has_scheme):
2825         (url_from_user_input):
2826         (url_load_from_user_input):
2827         (_url_bar_activated_cb):
2828         (_url_bar_clicked_cb):
2829         (_search_field_aborted_cb):
2830         (_search_field_activated_cb):
2831         (_search_field_clicked_cb):
2832         (_back_button_clicked_cb):
2833         (_forward_button_clicked_cb):
2834         (_search_backward_button_clicked_cb):
2835         (_search_forward_button_clicked_cb):
2836         (_search_case_option_changed):
2837         (_search_word_start_option_changed_cb):
2838         (_search_close_button_clicked_cb):
2839         (_refresh_button_clicked_cb):
2840         (_stop_button_clicked_cb):
2841         (list_item_label_get):
2842         (_list_item_select_cb):
2843         (navigation_button_longpress_process):
2844         (_forward_button_longpress_cb):
2845         (_back_button_longpress_cb):
2846         (quit_event_loop):
2847         (_ok_clicked_cb):
2848         (_file_entry_dialog_show):
2849
2850 2016-09-24  Chris Dumez  <cdumez@apple.com>
2851
2852         [WK2] anchor.download attribute value is ignored by NETWORK_SESSION code path
2853         https://bugs.webkit.org/show_bug.cgi?id=162531
2854
2855         Reviewed by Darin Adler.
2856
2857         Update decideDestinationWithSuggestedFilename() to return a actual file path
2858         instead of nullptr. The NETWORK_SESSION code path cancels the download when
2859         decideDestinationWithSuggestedFilename() returns an empty file path, unlike
2860         the !NETWORK_SESSION code path that just continue downloading without
2861         explicitely setting a destination path. This lead to different test results
2862         for NETWORK_SESSION and !NETWORK_SESSION code paths. Returns a valid
2863         destination path makes more sense and leads to consistent results.
2864
2865         * WebKitTestRunner/TestController.cpp:
2866         (WTR::TestController::decideDestinationWithSuggestedFilename):
2867
2868 2016-09-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2869
2870         [mac-sierra] 2 WKWebViewCandidateTests API test failures
2871         https://bugs.webkit.org/show_bug.cgi?id=162470
2872
2873         Reviewed by Tim Horton.
2874
2875         VideoControlsManager, WKWebViewCandidateTests and CandidateTests should not be running on 10.12.0. Guard these
2876         tests with an SDK check to prevent 10.12.0 bots from building them.
2877
2878         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2879         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2880         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2881
2882 2016-09-23  Alex Christensen  <achristensen@webkit.org>
2883
2884         Refactor URLParser
2885         https://bugs.webkit.org/show_bug.cgi?id=162516
2886
2887         Reviewed by Brady Eidson.
2888
2889         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2890         (TestWebKitAPI::TEST_F):
2891
2892 2016-09-23  Caitlin Potter  <caitp@igalia.com>
2893
2894         [JSC] Implement parsing of Async Functions
2895         https://bugs.webkit.org/show_bug.cgi?id=161409
2896
2897         Reviewed by Yusuke Suzuki.
2898
2899         * Scripts/build-jsc:
2900         (cMakeArgsFromFeatures):
2901         * Scripts/webkitperl/FeatureList.pm:
2902         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2903
2904 2016-09-23  Alex Christensen  <achristensen@webkit.org>
2905
2906         Refactor URLParser
2907         https://bugs.webkit.org/show_bug.cgi?id=162511
2908
2909         Reviewed by Brady Eidson.
2910
2911         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2912         (TestWebKitAPI::TEST_F):
2913         (TestWebKitAPI::checkURL):
2914
2915 2016-09-23  Alexey Proskuryakov  <ap@apple.com>
2916
2917         iOS playback user action tests fail on some machines
2918         https://bugs.webkit.org/show_bug.cgi?id=162504
2919         rdar://problem/28013994
2920
2921         Reviewed by Jer Noble.
2922
2923         Avoid the need to have a timeout.
2924
2925         * TestWebKitAPI/Tests/WebKit/ios/audio-only.html:
2926         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
2927         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
2928         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html:
2929
2930 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2931
2932         REGRESSION(r204163): [GTK] API test /webkit2/WebKitSecurityManager/file-xhr is failing
2933         https://bugs.webkit.org/show_bug.cgi?id=161607
2934
2935         Reviewed by Michael Catanzaro.
2936
2937         Since r204163, in case of cross origin error when loading the XHR, the load fails and an error message is shown
2938         in the console, but there isn't any js expcetion, which is what we were checking. Now, we check that there
2939         aren't exceptions, and that the error message is sent to the console.
2940
2941         * Scripts/run-gtk-tests:
2942         (TestRunner):
2943         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2944         (consoleMessageReceivedCallback):
2945         (testWebContextSecurityFileXHR):
2946
2947 2016-09-23  Ryan Haddad  <ryanhaddad@apple.com>
2948
2949         Use correct hardware for Sierra Debug WK2 testers.
2950         https://bugs.webkit.org/show_bug.cgi?id=162474
2951
2952         Reviewed by Alexey Proskuryakov.
2953
2954         * BuildSlaveSupport/build.webkit.org-config/config.json:
2955
2956 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2957
2958         [GTK] Make all WebView tests have a WebKitUserContentManager
2959         https://bugs.webkit.org/show_bug.cgi?id=162487
2960
2961         Reviewed by Michael Catanzaro.
2962
2963         It simplifies tests using the user content manager, and allows to use it without having to subclass WebViewTest.
2964
2965         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2966         (ConsoleMessageTest::ConsoleMessageTest):
2967         (ConsoleMessageTest::~ConsoleMessageTest):
2968         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2969         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2970         (testUserContentManagerInjectedStyleSheet):
2971         (testUserContentManagerInjectedScript):
2972         (UserScriptMessageTest::UserScriptMessageTest):
2973         (beforeAll):
2974         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2975         (testWebViewIsPlayingAudio):
2976         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2977         (WebViewTest::WebViewTest):
2978         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2979
2980 2016-09-23  Antoine Quint  <graouts@apple.com>
2981
2982         Add a new runtime flag for work on modern media controls (off by default)
2983         https://bugs.webkit.org/show_bug.cgi?id=162420
2984         <rdar://problem/27989489>
2985
2986         Reviewed by Eric Carlson.
2987
2988         * DumpRenderTree/mac/DumpRenderTree.mm:
2989         (resetWebPreferencesToConsistentValues):
2990         * DumpRenderTree/win/DumpRenderTree.cpp:
2991         (resetWebPreferencesToConsistentValues):
2992         * Scripts/webkitperl/FeatureList.pm:
2993         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2994         (WTR::InjectedBundle::beginTesting):
2995         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2996         (WTR::TestRunner::setModernMediaControlsEnabled):
2997         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2998
2999 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3000
3001         REGRESSION(r194387): Crash on github.com in IntlDateTimeFormat::resolvedOptions in C locale
3002         https://bugs.webkit.org/show_bug.cgi?id=162139
3003
3004         Reviewed by Michael Catanzaro.
3005
3006         Add test cases to check the behavior when using the C locale and an invalid locale.
3007
3008         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3009         (testWebContextLanguages):
3010
3011 2016-09-22  Hunseop Jeong  <hs85.jeong@samsung.com>
3012
3013         [EFL] alert box is not displayed 
3014         https://bugs.webkit.org/show_bug.cgi?id=156395
3015
3016         Reviewed by Gyuyoung Kim.
3017
3018         Some popup objects(alert, confirm, prompt, file entry dialog) used the ecore_main_loop_begin() to make
3019         the modal popup but ecore_main_loop_begin() was not executed inside an exisiting main loop. So we have
3020         to use the ecore_main_loop_iterate() instead of the ecore_main_loop_begin().
3021
3022         * MiniBrowser/efl/main.c:
3023         (_ok_clicked_cb):
3024         (_file_entry_dialog_show):
3025         (_javascript_alert_cb):
3026         (_javascript_confirm_cb):
3027         (_javascript_prompt_cb):
3028         (quit_event_loop): Deleted.
3029
3030 2016-09-22  Matthew Hanson  <matthew_hanson@apple.com>
3031
3032         Add an API for getting the branch identifier from a Git or SVN checkout.
3033         https://bugs.webkit.org/show_bug.cgi?id=151570
3034         rdar://problem/17959831
3035
3036         Reviewed by David Kilzer.
3037
3038         This patch adds a function called svnIdentifierForPath. This function returns either "trunk",
3039         the name of the tag, or the name of the branch, as appropriate. This function is necessary for
3040         a VCSUtils client that is not checked in to the WebKit project.
3041
3042         This patch also breaks up pathRelativeToSVNRepositoryRootForPath into four functions:
3043         - pathRelativeToSVNRepositoryRootForPath
3044         - svnInfoForPath
3045         - svnURLForPath
3046         - svnRepositoryRootForPath
3047
3048         This allows us to reuse logic from pathRelativeToSVNRepositoryRootForPath in svnIdentifierForPath and
3049         allows clients of VCSUtils to extract what arbitrary information from the `svn info` command regardless
3050         of SCM.
3051
3052         * Scripts/VCSUtils.pm:
3053         (svnInfoForPath):
3054         Copied logic that previously lived in pathRelativeToSVNRepositoryRootForPath.
3055         Make code safe to use for a path, and not just for the CWD.
3056
3057         (svnURLForPath):
3058         Calls svnInfoForPath and extracts the URL.
3059
3060         (svnRepositoryRootForPath):
3061         Calls svnInfoForPath and extracts the Repository Root.
3062
3063         (svnIdentifierForPath):
3064         Calls pathRelativeToSVNRepositoryRootForPath and extracts the repository identifier.
3065
3066         (pathRelativeToSVNRepositoryRootForPath):
3067         Now uses svnURLForPath and svnRepositoryRootForPath instead of being responsible for
3068         determining both values.
3069
3070 2016-09-22  Megan Gardner  <megan_gardner@apple.com>
3071
3072         Add long press selection test
3073         https://bugs.webkit.org/show_bug.cgi?id=162367
3074
3075         Reviewed by Simon Fraser.
3076
3077         Add support to UIScriptController to synthesize long press events on iOS.
3078         This required adding long-press functionality to HIDEventGenerator.
3079
3080         HIDEventGenerator sends the touchDown, but must then send the touchUp with
3081         a dispatch_after (rather than sleeping, as we do for other events) in order
3082         for the gesture recognizers to correctly detect a long press.
3083
3084         Use the long press synthesis in a test that detects whether a long press
3085         gesture triggers text selection.
3086
3087         Fixed incorrect constants. NSTimeInterval is in seconds, original numbers
3088         were nanoseconds and typedefed to long without regard to the type
3089         differences. Redid constants to be the right value, and converted upon use.
3090
3091         Cleaned up unused enum types.
3092
3093         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3094         (WTR::UIScriptController::longPressAtPoint):
3095         (WTR::UIScriptController::forcePressAtPoint):
3096         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
3097         * Scripts/webkitpy/common/config/contributors.json:
3098         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3099         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3100         (WTR::UIScriptController::longPressAtPoint):
3101         (WTR::UIScriptController::forcePressAtPoint):
3102         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
3103         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3104         * WebKitTestRunner/ios/HIDEventGenerator.h:
3105         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3106         (-[HIDEventGenerator _createIOHIDEventType:]):
3107         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3108         (-[HIDEventGenerator clearTap:]):
3109         (-[HIDEventGenerator longPressTimerCall:]):
3110         (-[HIDEventGenerator longPressFinish:completionBlock:]):
3111         (-[HIDEventGenerator longPress:completionBlock:]):
3112         (-[HIDEventGenerator forcePress:completionBlock:]):
3113         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3114         (WTR::UIScriptController::longPressAtPoint):
3115         (WTR::UIScriptController::forcePressAtPoint):
3116         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
3117
3118 2016-09-22  Jonathan Bedard  <jbedard@apple.com>
3119
3120         Automatic Text Replacement Testing in WebKit2
3121         https://bugs.webkit.org/show_bug.cgi?id=161919
3122
3123         Reviewed by Ryosuke Niwa.
3124
3125         Implemented test hooks for text replacement for WebKit2.
3126         Note that spell checking has not been implemented, so most tests which use text replacement still fail.
3127
3128         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Removed setAutomaticLinkDetectionEnabled from TestRunner, moved to Internals.
3129         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
3130         (WTR::InjectedBundle::beginTesting): Ditto.
3131         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
3132         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
3133         * WebKitTestRunner/TestController.cpp:
3134         (WTR::TestController::runTest): Place TextChecker into testing mode.
3135
3136 2016-09-21  Dan Bernstein  <mitz@apple.com>
3137
3138         [macOS] Upon layout, _webView:renderingProgressDidChange: fires before the intrinsic content size is updated
3139         https://bugs.webkit.org/show_bug.cgi?id=162359
3140         <rdar://problem/27776454>
3141
3142         Reviewed by Tim Horton.
3143
3144         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3145         (TEST):
3146
3147 2016-09-21  Keith Miller  <keith_miller@apple.com>
3148
3149         Fix build for future versions of Clang.
3150         https://bugs.webkit.org/show_bug.cgi?id=162346
3151
3152         Reviewed by Filip Pizlo.
3153
3154         * TestWebKitAPI/Counters.cpp:
3155         * TestWebKitAPI/Counters.h:
3156         (DeleterCounter::deleterCount):
3157         (DeleterCounter::TestingScope::TestingScope):
3158         (DeleterCounter::operator()):
3159         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
3160         (TestWebKitAPI::TEST):
3161         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3162         (TestWebKitAPI::TEST):
3163
3164 2016-09-21  Commit Queue  <commit-queue@webkit.org>
3165
3166         Unreviewed, rolling out r206222 and r206227.
3167         https://bugs.webkit.org/show_bug.cgi?id=162361
3168
3169         "broke the windows build" (Requested by keith_mi_ on #webkit).
3170
3171         Reverted changesets:
3172
3173         "Fix build for future versions of Clang."
3174         https://bugs.webkit.org/show_bug.cgi?id=162346
3175         http://trac.webkit.org/changeset/206222
3176
3177         "Attempt to fix windows build after r206222."
3178         http://trac.webkit.org/changeset/206227
3179
3180 2016-09-21  Alex Christensen  <achristensen@webkit.org>
3181
3182         URLParser should match URL::parse when parsing data urls with slashes in them
3183         https://bugs.webkit.org/show_bug.cgi?id=162352
3184
3185         Reviewed by Darin Adler.
3186
3187         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3188         (TestWebKitAPI::TEST_F):
3189
3190 2016-09-21  Alex Christensen  <achristensen@webkit.org>
3191
3192         URLParser should fail when parsing invalid relative URLs with no schemes
3193         https://bugs.webkit.org/show_bug.cgi?id=162355
3194
3195         Reviewed by Tim Horton.
3196
3197         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3198         (TestWebKitAPI::TEST_F):
3199
3200 2016-09-21  Keith Miller  <keith_miller@apple.com>
3201
3202         Fix build for future versions of Clang.
3203         https://bugs.webkit.org/show_bug.cgi?id=162346
3204
3205         Reviewed by Filip Pizlo.
3206
3207         * TestWebKitAPI/Counters.cpp:
3208         * TestWebKitAPI/Counters.h:
3209         (DeleterCounter::deleterCount):
3210         (DeleterCounter::TestingScope::TestingScope):
3211         (DeleterCounter::operator()):
3212         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
3213         (TestWebKitAPI::TEST):
3214         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3215         (TestWebKitAPI::TEST):
3216
3217 2016-09-21  Alex Christensen  <achristensen@webkit.org>
3218
3219         Prepare API tests for enabling URLParser by default
3220         https://bugs.webkit.org/show_bug.cgi?id=162341
3221
3222         Reviewed by Tim Horton.
3223
3224         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3225         (TestWebKitAPI::checkURL):
3226         (TestWebKitAPI::checkRelativeURL):
3227         (TestWebKitAPI::checkURLDifferences):
3228         (TestWebKitAPI::checkRelativeURLDifferences):
3229         (TestWebKitAPI::shouldFail):
3230
3231 2016-09-21  Alex Christensen  <achristensen@webkit.org>
3232
3233         URLParser: Correctly parse URLs that are just nonspecialscheme:/
3234         https://bugs.webkit.org/show_bug.cgi?id=162340
3235
3236         Reviewed by Tim Horton.
3237
3238         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3239         (TestWebKitAPI::TEST_F):
3240
3241 2016-09-21  Alex Christensen  <achristensen@webkit.org>
3242
3243         URLParser: correctly parse relative URLs that are just one character
3244         https://bugs.webkit.org/show_bug.cgi?id=162344
3245
3246         Reviewed by Tim Horton.
3247
3248         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3249         (TestWebKitAPI::TEST_F):
3250
3251 2016-09-20  Alex Christensen  <achristensen@webkit.org>
3252
3253         Optimize URLParser
3254         https://bugs.webkit.org/show_bug.cgi?id=162105
3255
3256         Reviewed by Geoffrey Garen.
3257
3258         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3259         (TestWebKitAPI::TEST_F):
3260
3261 2016-09-20  Aakash Jain  <aakash_jain@apple.com>
3262
3263         enable remote_api (for debugging) in flakiness dashboard app
3264         https://bugs.webkit.org/show_bug.cgi?id=162325
3265
3266         Reviewed by Alexey Proskuryakov.
3267
3268         * TestResultServer/app.yaml: enabled remote_api and datastore_admin.
3269
3270 2016-09-20  Ryan Haddad  <ryanhaddad@apple.com>
3271
3272         Unreviewed, rolling out r206180.
3273
3274         Roll r206178 back in as the necessary changes have been made
3275         on the build master.
3276
3277         Reverted changeset:
3278
3279         "Unreviewed, rolling out r206178."
3280         https://bugs.webkit.org/show_bug.cgi?id=162249
3281         http://trac.webkit.org/changeset/206180
3282
3283 2016-09-20  Alexey Proskuryakov  <ap@apple.com>
3284
3285         Use a hardcoded patch for sRGB color profile
3286         https://bugs.webkit.org/show_bug.cgi?id=162320
3287         rdar://problem/28387318
3288
3289         Reviewed by Simon Fraser.
3290
3291         This is a workaround for rdar://problem/28392768
3292
3293         * DumpRenderTree/mac/LayoutTestHelper.m:
3294         (installLayoutTestColorProfile):
3295
3296 2016-09-20  Ryan Haddad  <ryanhaddad@apple.com>
3297
3298         Unreviewed, rolling out r206178.
3299
3300         This change caused buildbot config issues.
3301
3302         Reverted changeset:
3303
3304         "Add Sierra bots to buildbot and dashboard."
3305         https://bugs.webkit.org/show_bug.cgi?id=162249
3306         http://trac.webkit.org/changeset/206178
3307
3308 2016-09-20  Dean Johnson  <dean_johnson@apple.com>
3309
3310         Add Sierra bots to buildbot and dashboard.
3311         https://bugs.webkit.org/show_bug.cgi?id=162249
3312
3313         Reviewed by Alexey Proskuryakov.
3314
3315         * BuildSlaveSupport/build.webkit.org-config/config.json:
3316         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3317         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3318         (WebKitBuildbot):
3319
3320 2016-09-20  Alex Christensen  <achristensen@webkit.org>
3321
3322         Reduce allocations in URLParser
3323         https://bugs.webkit.org/show_bug.cgi?id=162241
3324
3325         Reviewed by Chris Dumez.
3326
3327         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3328         (TestWebKitAPI::TEST_F):
3329         (TestWebKitAPI::checkURL):
3330
3331 2016-09-20  Alex Christensen  <achristensen@webkit.org>
3332
3333         Align URLParser with web platform tests when parsing non-special relative URLs ending in AuthorityOrHost state
3334         https://bugs.webkit.org/show_bug.cgi?id=162251
3335
3336         Reviewed by Tim Horton.
3337
3338         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3339         (TestWebKitAPI::checkURL):
3340         (TestWebKitAPI::TEST_F):
3341         (TestWebKitAPI::checkRelativeURL):
3342         (TestWebKitAPI::checkURLDifferences):
3343         (TestWebKitAPI::checkRelativeURLDifferences):
3344
3345 2016-09-20  Alex Christensen  <achristensen@webkit.org>
3346
3347         URLParser should allow '@' in user
3348         https://bugs.webkit.org/show_bug.cgi?id=162272
3349
3350         Reviewed by Tim Horton.
3351
3352         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3353         (TestWebKitAPI::TEST_F):
3354
3355 2016-09-20  Alex Christensen  <achristensen@webkit.org>
3356
3357         URLParser: Fix parsing relative URLs with one slash after the scheme:
3358         https://bugs.webkit.org/show_bug.cgi?id=162294
3359
3360         Reviewed by Tim Horton.
3361
3362         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3363         (TestWebKitAPI::TEST_F):
3364
3365 2016-09-20  Alex Christensen  <achristensen@webkit.org>
3366
3367         Fix Windows file URL quirks in URLParser
3368         https://bugs.webkit.org/show_bug.cgi?id=162303
3369
3370         Reviewed by Tim Horton.
3371
3372         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3373         (TestWebKitAPI::TEST_F):
3374
3375 2016-09-20  Filip Pizlo  <fpizlo@apple.com>
3376
3377         Make MarkedBlock state tracking support overlapped allocation and marking state
3378         https://bugs.webkit.org/show_bug.cgi?id=161581
3379
3380         Reviewed by Geoffrey Garen.
3381         
3382         Remove the always-trigger-copy-phase configuration.
3383
3384         * Scripts/run-jsc-stress-tests:
3385
3386 2016-09-20  Don Olmstead  <don.olmstead@am.sony.com>
3387
3388         [WinCairo] Use find_package cairo in build
3389         https://bugs.webkit.org/show_bug.cgi?id=162239
3390
3391         Reviewed by Alex Christensen.
3392
3393         * DumpRenderTree/PlatformWin.cmake:
3394         * TestWebKitAPI/PlatformWin.cmake:
3395
3396 2016-09-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3397
3398         Unreviewed build fix on 10.10 bots.
3399
3400         * TestWebKitAPI/mac/TestWKWebViewMac.h:
3401
3402 2016-09-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3403
3404         VideoControlsManager.VideoControlsManagerSingleLargeVideo fails intermittently on the Mac WK2 bot
3405         https://bugs.webkit.org/show_bug.cgi?id=162255
3406
3407         Reviewed by Jer Noble.
3408
3409         This is reproducible by running the test repeatedly in a for loop (locally, I observed that running the test
3410         back-to-back would result in the second one failing). This suggests that even on the runloop after the video
3411         starts playing, the state of the playback controls manager may not be up to date in the UI process. Instead, we
3412         can just spin the runloop until the playback controls are shown, which makes back-to-back tests to succeed and
3413         will probably address flakiness on the bots for this test.
3414
3415         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3416         (TestWebKitAPI::TEST):
3417         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
3418
3419 2016-09-20  Per Arne Vollan  <pvollan@apple.com>
3420
3421         [Win] Run layout tests in parallel.
3422         https://bugs.webkit.org/show_bug.cgi?id=162145
3423
3424         Reviewed by Brent Fulgham.
3425
3426         To speed up layout tests, try running them in parallel.
3427
3428         * Scripts/webkitpy/port/win.py:
3429         (WinPort.default_child_processes): Deleted.
3430
3431 2016-09-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3432
3433         Unreviewed build fix after r206135
3434
3435         NSEventMaskLeftMouseDown and friends are only available on 10.12.
3436
3437         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
3438         (__simulated_forceClickAssociatedEventsMask):
3439
3440 2016-09-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3441
3442         Add a unit test covering <https://trac.webkit.org/changeset/205983>
3443         https://bugs.webkit.org/show_bug.cgi?id=162112
3444
3445         Reviewed by Beth Dakin.
3446
3447         Adds a new unit test covering the changes in r205983 along with the infrastructure needed to support it. Also
3448         further refactors the TestWKWebView used by VideoControlsManager and WKWebViewCandidateTests so that in both
3449         cases, we add the WKWebView to a visible key window, and when sending a mouse down event, we propagate the event
3450         at the window level rather than the view level, allowing greater flexibility to simulate behaviors such as
3451         pressure-sensitive events that are needed for the new test.
3452
3453         Also rewrites currently disabled unit tests in CandidateTests as WebKit2 unit tests in WKWebViewCandidateTests,
3454         checking whether or not to should be requesting candidates in password and non-password fields.
3455
3456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3457         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3458         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
3459         (TestWebKitAPI::TEST):
3460         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
3461         (-[CandidateTestWebView typeString:inputMessage:]):
3462         (+[CandidateTestWebView setUpWithFrame:testPage:]):
3463         * TestWebKitAPI/Tests/WebKit2Cocoa/large-input-field-focus-onload.html: Added.
3464         * TestWebKitAPI/Tests/WebKit2Cocoa/text-and-password-inputs.html: Added.
3465         * TestWebKitAPI/mac/TestWKWebViewMac.h:
3466         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
3467         (__simulated_forceClickAssociatedEventsMask):
3468         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
3469         (-[TestWKWebView initWithFrame:]):
3470         (-[TestWKWebView initWithFrame:configuration:]):
3471         (-[TestWKWebView _setUpTestWindow:]):
3472         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
3473         (-[TestWKWebView typeCharacter:]):
3474         (-[TestWKWebView mouseDownAtPoint:]): Deleted.
3475
3476 2016-09-19  Alex Christensen  <achristensen@webkit.org>
3477
3478         URLParser can read memory out of bounds
3479         https://bugs.webkit.org/show_bug.cgi?id=162206
3480
3481         Reviewed by Geoff Garen.
3482
3483         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3484         (TestWebKitAPI::TEST_F):
3485
3486 2016-09-19  Daniel Bates  <dabates@apple.com>
3487
3488         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
3489         https://bugs.webkit.org/show_bug.cgi?id=162167
3490
3491         Reviewed by Simon Fraser.
3492
3493         * Scripts/webkitperl/FeatureList.pm:
3494         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3495
3496 2016-09-19  Nan Wang  <n_wang@apple.com>
3497
3498         AX: Add accessibility support for details element on iOS
3499         https://bugs.webkit.org/show_bug.cgi?id=162041
3500
3501         Reviewed by Chris Fleizach.
3502
3503         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3504         (AccessibilityUIElement::isExpanded):
3505         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3506         (WTR::AccessibilityUIElement::isExpanded):
3507
3508 2016-09-18  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
3509
3510         [EFL] Bump efl library to 1.18.1
3511         https://bugs.webkit.org/show_bug.cgi?id=162120
3512
3513         Reviewed by Michael Catanzaro.
3514
3515         * efl/jhbuild.modules: Use efl-1.18.1 instead of 1.18.
3516
3517 2016-09-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3518
3519         [EFL] Adjust EFL coding style to EFL MiniBrowser
3520         https://bugs.webkit.org/show_bug.cgi?id=162119
3521
3522         Reviewed by Michael Catanzaro.
3523
3524         Apply EFL coding style to main.c for MiniBrowser.
3525           - Use _foo_cb instead of on_foo for callback function
3526           - Use 3 spaces and use 2 spaces in keywords.
3527
3528         - EFL coding style.
3529           https://phab.enlightenment.org/w/coding_convention/
3530
3531         Additionally this patch adds an exception rule that style checker doesn't
3532         check indentation rule in EFL MiniBrowser.
3533
3534         * MiniBrowser/efl/main.c:
3535         (miniBrowserViewSmartClass):
3536         (window_find_with_ewk_view):
3537         (_tooltip_show):
3538         (window_tooltip_hide):
3539         (window_tooltip_update):
3540         (_mouse_in_cb):
3541         (_mouse_move_cb):
3542         (_mouse_out_cb):
3543         (_mouse_wheel_cb):
3544         (_window_resize_cb):
3545         (update_view_favicon):
3546         (_icon_changed_cb):
3547         (window_free):
3548         (window_close):
3549         (search_icon_show):
3550         (search_box_show):
3551         (search_box_hide):
3552         (history_list_hide):
3553         (save_page_contents_callback):
3554         (script_execute_callback):
3555         (toggle_window_fullscreen):
3556         (_key_down_cb):
3557         (_mouse_down_cb):
3558         (_title_changed_cb):
3559         (_url_changed_cb):
3560         (_back_forward_list_changed_cb):
3561         (_progress_cb):
3562         (_error_cb):
3563         (_download_request_cb):
3564         (close_file_picker):
3565         (_filepicker_parent_deletion_cb):
3566         (_filepicker_deletion_cb):
3567         (_fileselector_done_cb):
3568         (_file_chooser_request_cb):
3569         (_download_finished_cb):
3570         (_download_failed_cb):
3571         (_color_changed_cb):
3572         (_color_item_selected_cb):
3573         (_color_picker_ok_clicked_cb):
3574         (_color_picker_cancel_clicked_cb):
3575         (_color_picker_dismiss_cb):
3576         (_color_picker_request_cb):
3577         (_url_bar_activated_cb):
3578         (_url_bar_clicked_cb):
3579         (_search_field_aborted_cb):
3580         (_search_field_activated_cb):
3581         (_search_field_clicked_cb):
3582         (_back_button_clicked_cb):
3583         (_forward_button_clicked_cb):
3584         (_search_backward_button_clicked_cb):
3585         (_search_forward_button_clicked_cb):
3586         (_search_case_option_changed):
3587         (_search_word_start_option_changed_cb):
3588         (_search_close_button_clicked_cb):
3589         (_refresh_button_clicked_cb):
3590         (_stop_button_clicked_cb):
3591         (_list_item_select_cb):
3592         (navigation_button_longpress_process):
3593         (_forward_button_longpress_cb):
3594         (_back_button_longpress_cb):
3595         (_ok_clicked_cb):
3596         (_file_entry_dialog_show):
3597         (_javascript_alert_cb):
3598         (_javascript_confirm_cb):
3599         (_javascript_prompt_cb):
3600         (_javascript_before_unload_confirm_cb):
3601         (_popup_menu_item_clicked_cb):
3602         (popup_menu_populate):
3603         (_popup_menu_show):
3604         (_popup_menu_hide):
3605         (_window_geometry_get):
3606         (_window_geometry_set):
3607         (_fullscreen_accept_cb):
3608         (_fullscreen_deny_cb):
3609         (_fullscreen_enter_cb):
3610         (_fullscreen_exit_cb):
3611         (_window_create_cb):
3612         (_window_close_cb):
3613         (_context_menu_item_selected_cb):
3614         (context_menu_populate):
3615         (_context_menu_show):
3616         (_context_menu_hide):
3617         (auth_popup_close):
3618         (_auth_cancel_cb):
3619         (_auth_ok_cb):
3620         (_authentication_request_cb):
3621         (_search_text_found_cb):
3622         (_tooltip_text_set):
3623         (_tooltip_text_unset):
3624         (_navigation_policy_decision_cb):
3625         (_home_button_clicked_cb):
3626         (_window_deletion_cb):
3627         (create_toolbar_button):
3628         (window_create):
3629         (configuration):
3630         (parse_cookies_policy):
3631         (parse_window_size):
3632         (elm_main):
3633         (on_tooltip_show): Deleted.
3634         (on_mouse_in): Deleted.
3635         (on_mouse_move): Deleted.
3636         (on_mouse_out): Deleted.
3637         (on_mouse_wheel): Deleted.
3638         (on_window_resize): Deleted.
3639         (on_icon_changed_cb): Deleted.
3640         (on_key_down): Deleted.
3641         (on_mouse_down): Deleted.
3642         (on_title_changed): Deleted.
3643         (on_url_changed): Deleted.
3644         (on_back_forward_list_changed): Deleted.
3645         (on_progress): Deleted.
3646         (on_error): Deleted.
3647         (on_download_request): Deleted.
3648         (on_filepicker_parent_deletion): Deleted.
3649         (on_filepicker_deletion): Deleted.
3650         (on_fileselector_done): Deleted.
3651         (on_file_chooser_request): Deleted.
3652         (on_download_finished): Deleted.
3653         (on_download_failed): Deleted.
3654         (on_color_changed): Deleted.
3655         (on_color_item_selected): Deleted.
3656         (on_color_picker_ok_clicked): Deleted.
3657         (on_color_picker_cancel_clicked): Deleted.
3658         (on_color_picker_dismiss): Deleted.
3659         (on_color_picker_request): Deleted.
3660         (on_url_bar_activated): Deleted.
3661         (on_url_bar_clicked): Deleted.
3662         (on_search_field_aborted): Deleted.
3663         (on_search_field_activated): Deleted.
3664         (on_search_field_clicked): Deleted.
3665         (on_back_button_clicked): Deleted.
3666         (on_forward_button_clicked): Deleted.
3667         (on_search_backward_button_clicked): Deleted.
3668         (on_search_forward_button_clicked): Deleted.
3669         (on_search_case_option_changed): Deleted.
3670         (on_search_word_start_option_changed): Deleted.
3671         (on_search_close_button_clicked): Deleted.
3672         (on_refresh_button_clicked): Deleted.
3673         (on_stop_button_clicked): Deleted.
3674         (on_list_item_select): Deleted.
3675         (on_forward_button_longpress): Deleted.
3676         (on_back_button_longpress): Deleted.
3677         (on_ok_clicked): Deleted.
3678         (show_file_entry_dialog): Deleted.
3679         (on_javascript_alert): Deleted.
3680         (on_javascript_confirm): Deleted.