Make the new WTF module build on Qt
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
2
3         Make the new WTF module build on Qt
4         https://bugs.webkit.org/show_bug.cgi?id=76163
5
6         Reviewed by Tor Arne Vestbø.
7
8         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
9
10 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
11
12         Unreviewed, mac DumpRenderTree fix.
13
14         * DumpRenderTree/mac/UIDelegate.mm:
15         (-[UIDelegate webView:addMessageToConsole:withSource:]):
16
17 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
18
19         WebKitTestRunner should not print console message line number when it is equal to zero.
20         https://bugs.webkit.org/show_bug.cgi?id=76167
21
22         Reviewed by Csaba Osztrogonác.
23
24         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
25         (WTR::InjectedBundlePage::willAddMessageToConsole):
26
27 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
28
29         Make default console messages line numbers consistent.
30         https://bugs.webkit.org/show_bug.cgi?id=74075
31
32         Reviewed by Pavel Feldman.
33
34         Unset line numbers are not printed to console now.
35         Added Source/WebCore/inspector to efl DumpRenderTree include path.
36
37         * DumpRenderTree/chromium/WebViewHost.cpp:
38         (WebViewHost::didAddMessageToConsole):
39         * DumpRenderTree/efl/CMakeLists.txt:
40         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
41         (onConsoleMessage):
42         * DumpRenderTree/gtk/DumpRenderTree.cpp:
43         (webViewConsoleMessage):
44         * DumpRenderTree/mac/UIDelegate.mm:
45         (-[UIDelegate webView:addMessageToConsole:withSource:]):
46         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
47         (WebCore::WebPage::javaScriptConsoleMessage):
48         * DumpRenderTree/win/UIDelegate.cpp:
49         (UIDelegate::webViewAddMessageToConsole):
50         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
51         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
52
53 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
54
55         test-webkitpy: push more logic into webkitpy.test.main, clean up code
56         https://bugs.webkit.org/show_bug.cgi?id=76021
57
58         Reviewed by Eric Seidel.
59
60         I plan to add more functionality to test-webkitpy, but it is
61         difficult to hack on now; this patch is the first of two that
62         brings test-webkitpy more inline with current coding style by
63         pushing more logic into the webkitpy.test.main.Tester class (so
64         that it will be testable itself).
65         
66         There should be no functional changes in this patch.
67
68         * Scripts/test-webkitpy:
69         (_path_from_webkit_root):
70         * Scripts/webkitpy/test/main.py:
71         (Tester):
72         (Tester.init):
73         (Tester.configure_logging):
74         (Tester.configure_logging.filter):
75         (Tester.clean_packages):
76         (Tester.run_tests):
77
78 2012-01-11  Wei Jia  <wjia@chromium.org>
79
80         implement layout tests for <video> with media stream
81         https://bugs.webkit.org/show_bug.cgi?id=74882
82
83         Reviewed by Kent Tamura.
84
85         * DumpRenderTree/DumpRenderTree.gypi:
86         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
87         (WebKit::WebUserMediaClientMock::create):
88         (WebKit::WebUserMediaClientMock::IsMockStream):
89         (WebKit::WebUserMediaClientMock::requestUserMedia):
90         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
91         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
92         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
93         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
94         * DumpRenderTree/chromium/WebViewHost.cpp:
95         (WebViewHost::userMediaClient):
96         (WebViewHost::userMediaClientMock):
97         (WebViewHost::createMediaPlayer):
98         (WebViewHost::mediaStreamUtil):
99         (WebViewHost::testMediaStreamClient):
100         * DumpRenderTree/chromium/WebViewHost.h:
101
102 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
103
104         Unreviewed, build fix.
105
106         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
107
108         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
109         (ChromiumWinPort.__init__):
110
111 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
112
113         Sheriffbot build fix. Don't emit empty lines on IRC.
114
115         * Scripts/webkitpy/tool/bot/irc_command.py:
116         (LastGreenRevision.execute):
117
118 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
119
120         last-green-revision should report the revision that succeeded on all bots
121         https://bugs.webkit.org/show_bug.cgi?id=76109
122
123         Reviewed by Adam Barth.
124
125         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
126         considered green by this algorithm, all matching builders must have a successful run at the revision
127         or two consecutive successful runs before and after the revision.
128
129         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
130         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
131
132         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
133         (BuildBot._revisions_for_builder):
134         (BuildBot):
135         (BuildBot._find_green_revision):
136         (BuildBot.last_green_revision):
137         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
138         (MockBuildBot.last_green_revision):
139         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
140         (test_revisions_for_builder):
141         (test_find_green_revision):
142         (test_last_green_revision):
143         * Scripts/webkitpy/tool/bot/irc_command.py:
144         (LastGreenRevision.execute):
145         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
146         (SheriffIRCBotTest.test_lgr):
147         * Scripts/webkitpy/tool/commands/queries.py:
148         (LastGreenRevision):
149
150 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
151
152         Unreviewed, fix build bustage on win32 introduced by r104725.
153
154         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
155         (MockDRTPortTest.make_port):
156         (MockChromiumDRTTest.test_pixeltest__fails):
157
158 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
159
160         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
161         https://bugs.webkit.org/show_bug.cgi?id=75618
162
163         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
164
165         Reviewed by Tony Chang.
166
167         * DumpRenderTree/chromium/LayoutTestHelper.mm:
168         (installLayoutTestColorProfile):
169         (restoreUserColorProfile):
170         (main):
171
172 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
173
174         test-webkitpy: fix -v and eliminate some spurious warnings
175         https://bugs.webkit.org/show_bug.cgi?id=76099
176
177         Reviewed by Adam Barth.
178
179         when we added support for --xml output, we broke the -v flag.
180
181         Also, fix the code to swallow a harmless warning from
182         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
183
184         test-webkitpy is now silent again except for the one known
185         logging issue.
186
187         * Scripts/webkitpy/common/checkout/checkout.py:
188         (Checkout.commit_message_for_this_commit):
189         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
190         (test_commit_message_for_this_commit):
191         * Scripts/webkitpy/style/checkers/jsonchecker.py:
192         (JSONChecker.check):
193         (JSONChecker.line_number_from_json_exception):
194         * Scripts/webkitpy/test/main.py:
195         (Tester.run_tests):
196
197 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
198
199         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
200         https://bugs.webkit.org/show_bug.cgi?id=76084
201
202         Reviewed by Adam Barth.
203
204         This will help make it easier to catch layering violations. This
205         change just refactors test code; there are no changes to
206         production code.
207
208         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
209         (PortTest.make_port):
210         (PortTest.test_find_no_paths_specified):
211         (PortTest.test_find_one_test):
212         (PortTest.test_find_glob):
213         (PortTest.test_find_with_skipped_directories):
214         (PortTest.test_find_with_skipped_directories_2):
215         (PortTest.test_parse_reftest_list):
216         (PortTest.test_httpd_returns_error_code):
217         (PortTest.test_virtual_methods):
218         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
219         (ChromiumGpuTest.assert_port_works):
220         (ChromiumGpuTest._assert_baseline_path):
221         (ChromiumGpuTest.test_graphics_type):
222         (ChromiumGpuTest.test_default_tests_paths.test_paths):
223         (ChromiumGpuTest.test_test_files):
224         (ChromiumGpuTest.test_test_files.test_paths):
225         (ChromiumGpuTest):
226         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
227         (ChromiumLinuxPortTest.assert_architecture):
228         (ChromiumLinuxPortTest.test_check_illegal_port_names):
229         (ChromiumLinuxPortTest.test_determine_architecture_fails):
230         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
231         (DriverTest.make_port):
232         (DriverTest):
233         (DriverTest.assertVirtual):
234         (DriverTest._assert_wrapper):
235         (DriverTest.test_virtual_driver_methods):
236         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
237         (MockDRTPortTest.make_port):
238         (MockDRTPortTest.test_port_name_in_constructor):
239         (MockDRTTest.assertTest):
240         (MockDRTTest.test_main):
241         (MockChromiumDRTTest.test_pixeltest__fails):
242         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
243         (QtPortTest._assert_search_path):
244         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
245         (TestWebKitPort.__init__):
246         (WebKitPortUnitTests.test_default_options):
247         (test_runtime_feature_list):
248         (test_test_expectations):
249
250 2012-01-11  Ojan Vafai  <ojan@chromium.org>
251
252         Style skipped tests in the flakiness dashboard
253         https://bugs.webkit.org/show_bug.cgi?id=76091
254
255         Reviewed by Tony Chang.
256
257         * TestResultServer/static-dashboards/dashboard_base.js:
258         Removed "FLAKY" from this list since we don't ever mark individual runs
259         as flaky. Also deleted an outdated line.
260         * TestResultServer/static-dashboards/flakiness_dashboard.html:
261
262 2012-01-11  Ojan Vafai  <ojan@chromium.org>
263
264         Remove gtest normalization code from the test results server
265         https://bugs.webkit.org/show_bug.cgi?id=76089
266
267         Reviewed by Tony Chang.
268
269         The normalization now happens on the gtest side.
270
271         * TestResultServer/model/jsonresults.py:
272         (JsonResults.merge):
273         * TestResultServer/model/jsonresults_unittest.py:
274         (JsonResultsTest.test_gtest):
275
276 2012-01-11  Ojan Vafai  <ojan@chromium.org>
277
278         Be more aggressive about deleting unnecessary results from the test-results-server json files
279         https://bugs.webkit.org/show_bug.cgi?id=76086
280
281         Reviewed by Tony Chang.
282
283         Remove any tests that only contain skip/pass/nodata values whose runtime
284         is less than 5 seconds.
285
286         * TestResultServer/model/jsonresults.py:
287         (JsonResults._normalize_results_json):
288         * TestResultServer/model/jsonresults_unittest.py:
289         (JsonResultsTest.test_merge_remove_test):
290         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
291
292 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
293
294         last-green-revision should give us per-bot information
295         https://bugs.webkit.org/show_bug.cgi?id=76011
296
297         Reviewed by Adam Barth.
298
299         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
300         we report the latest green run on each bot from the last 100 runs.
301
302         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
303         (BuildBot._fetch_builder_page):
304         (BuildBot):
305         (BuildBot._green_revision_for_builder):
306         (BuildBot.last_green_revision):
307         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
308         (test_green_revision_for_builder):
309         (test_last_green_revision):
310         * Scripts/webkitpy/tool/bot/irc_command.py:
311         (LastGreenRevision.execute):
312         * Scripts/webkitpy/tool/commands/queries.py:
313         (LastGreenRevision.execute):
314
315 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
316
317         webkitpy: clean up version detection in webkitpy.layout_tests.port
318         https://bugs.webkit.org/show_bug.cgi?id=76016
319
320         Reviewed by Adam Barth.
321
322         This change updates the code in webkitpy.layout_tests.port to
323         use the new os_name and os_version fields on host.platform. This
324         gets layout_tests.port out of the version parsing business. Most
325         of the diffs are just cleaning up test code to accomodate the
326         changes.
327
328         * Scripts/webkitpy/common/system/executive_mock.py:
329         (MockExecutive):
330         (MockExecutive.ignore_error):
331         (MockExecutive2):
332         (MockExecutive2.ignore_error):
333         * Scripts/webkitpy/common/system/platforminfo_mock.py:
334         (MockPlatformInfo.is_mac):
335         (MockPlatformInfo.is_linux):
336         (MockPlatformInfo.is_win):
337         * Scripts/webkitpy/common/system/systemhost_mock.py:
338         (MockSystemHost.__init__):
339         * Scripts/webkitpy/layout_tests/port/apple.py:
340         (ApplePort.__init__):
341         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
342         (ChromiumMacPort.__init__):
343         (ChromiumMacPort.check_wdiff):
344         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
345         (ChromiumMacPortTest):
346         (ChromiumMacPortTest.assert_name):
347         (ChromiumMacPortTest.test_versions):
348         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
349         (ChromiumPortTest.test_all_test_configurations):
350         (ChromiumPortTest.TestMacPort.__init__):
351         (ChromiumPortTest.TestLinuxPort.__init__):
352         (ChromiumPortTest.TestWinPort.__init__):
353         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
354         (ChromiumWinPort.__init__):
355         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
356         (ChromiumWinTest):
357         (ChromiumWinTest.assert_name):
358         (ChromiumWinTest.test_versions):
359         (ChromiumWinTest.test_baseline_path):
360         (ChromiumWinTest.test_build_path):
361         * Scripts/webkitpy/layout_tests/port/factory.py:
362         (PortFactory._port_name_from_arguments_and_options):
363         (PortFactory.get):
364         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
365         (FactoryTest):
366         (FactoryTest.setUp):
367         (FactoryTest.assert_port):
368         (FactoryTest.test_mac):
369         (FactoryTest.test_win):
370         (FactoryTest.test_google_chrome):
371         (FactoryTest.test_gtk):
372         (FactoryTest.test_qt):
373         (FactoryTest.test_chromium_gpu):
374         (FactoryTest.test_chromium_gpu_linux):
375         (FactoryTest.test_chromium_gpu_mac):
376         (FactoryTest.test_chromium_gpu_win):
377         (FactoryTest.test_chromium_mac):
378         (FactoryTest.test_chromium_linux):
379         (FactoryTest.test_chromium_win):
380         (FactoryTest.test_unknown_specified):
381         (FactoryTest.test_unknown_default):
382         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
383         (TestGoogleChromePort):
384         (TestGoogleChromePort._verify_baseline_path):
385         (TestGoogleChromePort._verify_expectations_overrides):
386         (TestGoogleChromePort.test_get_google_chrome_port):
387         * Scripts/webkitpy/layout_tests/port/mac.py:
388         (MacPort):
389         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
390         (MacTest):
391         (assert_name):
392         (test_tests_for_other_platforms):
393         (test_version):
394         (test_versions):
395         (test_is_version_methods):
396         (test_setup_environ_for_server):
397         (_assert_search_path):
398         (test_show_results_html_file):
399         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
400         (PortTestCase):
401         (PortTestCase.make_port):
402         * Scripts/webkitpy/layout_tests/port/win.py:
403         (WinPort):
404         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
405         (WinPortTest):
406         (WinPortTest.test_show_results_html_file):
407         (WinPortTest._assert_search_path):
408         (WinPortTest._assert_version):
409
410 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
411
412         [Qt][WK2] Remove workaround introduced into bug 75470
413         https://bugs.webkit.org/show_bug.cgi?id=75889
414
415         Reviewed by Tor Arne Vestbø.
416
417         * MiniBrowser/qt/qml/BrowserWindow.qml:
418
419 2012-01-10  Dmitry Lomov  <dslomov@google.com>
420
421         [Chromium] Remove obsolete references to WebWorker class.
422         https://bugs.webkit.org/show_bug.cgi?id=76020
423
424         Reviewed by David Levin.
425
426         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
427         * DumpRenderTree/chromium/WebViewHost.cpp:
428         * DumpRenderTree/chromium/WebViewHost.h:
429
430 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
431
432         [Qt] Some css3 filter tests are failing after r104698
433         https://bugs.webkit.org/show_bug.cgi?id=76055
434
435         Reviewed by Simon Hausmann.
436
437         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
438         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
439
440 2012-01-11  Tony Chang  <tony@chromium.org>
441
442         Don't remove 0 byte files when running build-webkit --chromium
443         https://bugs.webkit.org/show_bug.cgi?id=75997
444
445         Reviewed by Csaba Osztrogonác.
446
447         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
448
449         * Scripts/webkitdirs.pm:
450         (determineIsQt):
451
452 2012-01-10  David Kilzer  <ddkilzer@apple.com>
453
454         Add TestWebKitAPI tests for KURL
455         <http://webkit.org/b/75774>
456
457         Reviewed by Adam Barth.
458
459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
460         WebCore folder and KURL.cpp source file to the project.
461         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
462         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
463         during setup since this test doesn't go through WebKit or
464         WebKit2.
465         (TestWebKitAPI::TEST_F): Add two basic tests.
466
467 2012-01-10  David Kilzer  <ddkilzer@apple.com>
468
469         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
470
471         Reviewed by Adam Barth.
472
473         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
474
475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
476         WTFStringUtilities.h to the project.
477         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
478         WTFStringUtilities.h.
479         * TestWebKitAPI/WTFStringUtilities.h: Added.
480         (WTF::operator<<):
481
482 2012-01-10  Vincent Scheib  <scheib@chromium.org>
483
484         Clarify run-webkit-tests options reset-results and new-baseline
485         https://bugs.webkit.org/show_bug.cgi?id=75993
486
487         Reviewed by Dirk Pranke.
488
489         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
490         (parse_args):
491
492 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
493
494         Disabled mock scrollbars should draw differently
495         https://bugs.webkit.org/show_bug.cgi?id=75995
496
497         Reviewed by James Robinson.
498
499         When the scrollbar is disabled, paint the entire track of
500         mock scrollbars with a lighter gray, and hide the thumb.
501
502         * DumpRenderTree/mac/DumpRenderTree.mm:
503         (-[DRTMockScroller drawKnob]):
504         (-[DRTMockScroller drawRect:]):
505
506 2012-01-10  James Robinson  <jamesr@chromium.org>
507
508         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
509         https://bugs.webkit.org/show_bug.cgi?id=75988
510
511         Reviewed by Adam Barth.
512
513         * Scripts/webkitpy/common/config/ports.py:
514         (WebKitPort.run_webkit_unit_tests_command):
515         (WebKitPort):
516         (ChromiumPort.run_webkit_unit_tests_command):
517         (ChromiumPort):
518         * Scripts/webkitpy/common/config/ports_mock.py:
519         (MockPort.run_webkit_unit_tests_command):
520         * Scripts/webkitpy/tool/commands/download_unittest.py:
521         (DownloadCommandsTest.test_build_and_test):
522         (test_land):
523         (test_land_red_builders):
524         * Scripts/webkitpy/tool/steps/runtests.py:
525         (RunTests.run):
526         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
527
528 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
529
530         webkitpy: add os_name, os_version to platforminfo
531         https://bugs.webkit.org/show_bug.cgi?id=75931
532
533         Reviewed by Eric Siedel.
534
535         As a first step in cleaning up the version parsing logic in
536         webkitpy.layout_tests.port, this adds common routines for
537         getting the os_name and os_version fields to the PlatformInfo
538         class. Nothing uses them yet but I've added FIXME's to some of
539         the code that needs to be deleted in the port files.
540
541         * Scripts/webkitpy/common/system/platforminfo.py:
542         (PlatformInfo.__init__):
543         (PlatformInfo):
544         (PlatformInfo._determine_os_name):
545         (PlatformInfo._determine_mac_version):
546         (PlatformInfo._determine_linux_version):
547         (PlatformInfo._determine_win_version):
548         (PlatformInfo.display_name):
549         (PlatformInfo.total_bytes_memory):
550         (PlatformInfo._compute_bytes_from_vm_stat_output):
551         (PlatformInfo.free_bytes_memory):
552         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
553         (TestPlatformInfo):
554         (TestPlatformInfo.make_info):
555         (TestPlatformInfo.make_info.mock_run_command):
556         (TestPlatformInfo.setUp):
557         (TestPlatformInfo.tearDown):
558         (TestPlatformInfo.test_basic):
559         (TestPlatformInfo.integration_test_basic):
560         (TestPlatformInfo.test_display_name_mac):
561         (TestPlatformInfo.test_display_name_win32):
562         (TestPlatformInfo.test_memory_mac):
563         (TestPlatformInfo.test_memory_win32):
564         (TestPlatformInfo.test_determine_os_name):
565         (TestPlatformInfo.test_determine_mac_version):
566         (TestPlatformInfo.test_determine_linux_version):
567         (TestPlatformInfo.test_determine_win_version_from_tuple):
568         (TestPlatformInfo.test_determine_win_version_from_cmd):
569         * Scripts/webkitpy/layout_tests/port/apple.py:
570         (ApplePort.__init__):
571         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
572         (ChromiumMacPort.__init__):
573         * Scripts/webkitpy/layout_tests/port/mac.py:
574         (MacPort):
575         * Scripts/webkitpy/layout_tests/port/win.py:
576         (WinPort):
577
578 2012-01-10  Adam Roben  <aroben@apple.com>
579
580         Make it possible to type data: URLs into MiniBrowser on Windows
581
582         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
583         MiniBrowser on Windows
584
585         Reviewed by Darin Adler.
586
587         * MiniBrowser/win/BrowserWindow.cpp:
588         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
589         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
590         does, we assume it already has a scheme and don't modify it.
591
592 2012-01-10  Adam Roben  <aroben@apple.com>
593
594         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
595
596         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
597         MiniBrowser on Windows
598
599         Reviewed by Darin Adler.
600
601         * MiniBrowser/win/BrowserView.cpp:
602         (BrowserView::goToURL): Pass the typed string through
603         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
604
605 2012-01-10  Ben Wells  <benwells@chromium.org>
606
607         Adding myself (benwells) to committers.py
608         https://bugs.webkit.org/show_bug.cgi?id=75971
609
610         Reviewed by Ojan Vafai.
611
612         * Scripts/webkitpy/common/config/committers.py:
613
614 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
615
616         AX: support helpText() in DumpRenderTree
617         https://bugs.webkit.org/show_bug.cgi?id=40193
618
619         Reviewed by Chris Fleizach.
620
621         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
622         (AccessibilityUIElement::helpText): Implemented.
623
624 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
625
626         Unreviewed, rolling out r104572.
627         http://trac.webkit.org/changeset/104572
628         https://bugs.webkit.org/show_bug.cgi?id=75967
629
630         It broke zillion tests (Requested by Ossy on #webkit).
631
632         * DumpRenderTree/qt/EventSenderQt.cpp:
633         (EventSender::EventSender):
634         (EventSender::sendOrQueueEvent):
635         (EventSender::replaySavedEvents):
636         (EventSender::eventFilter):
637         * DumpRenderTree/qt/EventSenderQt.h:
638
639 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
640
641         [Qt] fast/events/dont-loose-last-event test fails on WK1
642         https://bugs.webkit.org/show_bug.cgi?id=73894
643
644         Reviewed by Simon Hausmann.
645
646         Empty the entire event queue when requested besides using
647         sendEvent instead of postEvent to make sure all events were
648         delivered.
649         This commit also removes not working DRT code to handle drag and drop,
650         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
651
652         * DumpRenderTree/qt/EventSenderQt.cpp:
653         (EventSender::EventSender):
654         (EventSender::sendOrQueueEvent):
655         (EventSender::replaySavedEvents):
656         * DumpRenderTree/qt/EventSenderQt.h:
657
658 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
659
660         [Qt] Enable CSS_FILTERS in Qt build
661         https://bugs.webkit.org/show_bug.cgi?id=75777
662
663         Add the CSS_FILTERS feature flag to Qt.
664
665         Reviewed by Kenneth Rohde Christiansen.
666
667         * qmake/mkspecs/features/features.prf:
668
669 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
670
671         [Qt] Unreviewed -Werror build fix.
672
673         * MiniBrowser/qt/MiniBrowserApplication.cpp:
674         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
675         declaration.
676
677 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
678
679         [Qt] Remove dependency to uitools
680         https://bugs.webkit.org/show_bug.cgi?id=75952
681
682         Reviewed by Tor Arne Vestbø.
683
684         QUiLoader is used for creating QLabel/QProgressBar widgets for
685         a layout test, to verify some widget embedding feature. Unfortunately
686         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
687         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
688         let's break the circular dependency.
689
690         * DumpRenderTree/qt/DumpRenderTree.pro:
691         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
692         (WebCore::WebPage::createPlugin):
693         * QtTestBrowser/QtTestBrowser.pro:
694         * QtTestBrowser/launcherwindow.h:
695         * QtTestBrowser/webpage.cpp:
696         (WebPage::createPlugin):
697         * qmake/mkspecs/features/minimal_qt.prf:
698         * qmake/mkspecs/features/uitools.prf: Removed.
699
700 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
701
702         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
703         https://bugs.webkit.org/show_bug.cgi?id=75894
704
705         Reviewed by Tor Arne Vestbø.
706
707         * MiniBrowser/qt/MiniBrowserApplication.h:
708         (MiniBrowserApplication::windowOptions):
709         * MiniBrowser/qt/main.cpp:
710         (main):
711
712 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
713
714         [Qt] DRT crashes with Qt 5
715         https://bugs.webkit.org/show_bug.cgi?id=75951
716
717         Reviewed by Ossy.
718
719         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
720         Qt relies on font-config to define the default font family.
721
722 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
723
724         [Qt] REGRESSION(r100130): Clean build feature is broken.
725         https://bugs.webkit.org/show_bug.cgi?id=75863
726
727         Reviewed by Tor Arne Vestbø.
728
729         * Scripts/webkitdirs.pm:
730         (buildQMakeProject):
731
732 2012-01-10  Zeno Albisser  <zeno@webkit.org>
733
734         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
735         https://bugs.webkit.org/show_bug.cgi?id=75885
736
737         In QML events are propagated through parents. But since the
738         WebView may consume key events, a shortcut might never reach
739         the top QtQuickItem.
740         Therefore an application wide event handling function in C++
741         needs to take care of shortcuts for MiniBrowser.
742
743         Reviewed by Kenneth Rohde Christiansen.
744
745         * MiniBrowser/qt/BrowserWindow.cpp:
746         (BrowserWindow::reload):
747         (BrowserWindow::focusAddressBar):
748         * MiniBrowser/qt/BrowserWindow.h:
749         * MiniBrowser/qt/MiniBrowserApplication.cpp:
750         (MiniBrowserApplication::notify):
751         * MiniBrowser/qt/qml/BrowserWindow.qml:
752
753 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
754
755         Add --efl alias for --platform=efl to run-webkit-test
756         https://bugs.webkit.org/show_bug.cgi?id=75937
757
758         Reviewed by Andreas Kling.
759         
760         * Scripts/run-webkit-tests: Add --efl alias.
761         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
762         (parse_args):
763
764 2012-01-09  Dan Bernstein  <mitz@apple.com>
765
766         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
767         https://bugs.webkit.org/show_bug.cgi?id=75920
768
769         Reviewed by Darin Adler.
770
771         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
772         (TestWebKitAPI::TEST): Added a test for a range in a
773         -webkit-user-select: none; block.
774
775 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
776
777         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
778         https://bugs.webkit.org/show_bug.cgi?id=75884
779
780         Reviewed by Ryosuke Niwa.
781
782         Fix regression introduced (revealed?) in r104340. Chromium file         
783         url syntax is different on win32 and the test results weren't           
784         expecting that.                                                         
785
786         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
787         (TestExpectations._report_errors):
788         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
789         (test_parse_error_nonfatal):
790         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
791         (MockDRTTest.input_line):
792         (MockChromiumDRTTest.test_pixeltest__fails):
793         * Scripts/webkitpy/layout_tests/port/test.py:
794         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
795         (TestRebaseliner.make_rebaseliner):
796         (TestRebaseliner.test_one_platform):
797         (TestRebaseliner.test_all_platforms):
798         (TestRebaseliner.test_png_file_with_comment):
799         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
800         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
801         (TestRealMain.test_all_platforms):
802
803 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
804
805         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
806
807         Unreviewed, build fix.
808
809         test-webkitpy had a built-in self-test routine to verify that
810         deleting the .pyc files worked correctly. When I removed the
811         python24 directory in r104482, I broke the self-test.
812
813         I have deleted the self-test for now. Since I am reworking
814         test-webkitpy I will make sure the new version is adequately
815         tested.
816
817         * Scripts/test-webkitpy:
818         (configure_logging):
819         (_clean_pyc_files):
820         (_clean_packages):
821         (init):
822
823 2012-01-09  Justin Novosad  <junov@chromium.org>
824
825         [Chromium] remove all references to the legacy accelerated 2d Canvas
826         implementation
827         https://bugs.webkit.org/show_bug.cgi?id=75108
828
829         Purging an old settings flag that is no longer referenced
830
831         Reviewed by Darin Fisher.
832
833         * DumpRenderTree/chromium/DumpRenderTree.cpp:
834         (main):
835         * DumpRenderTree/chromium/TestShell.cpp:
836         (TestShell::TestShell):
837         (TestShell::resetWebSettings):
838         * DumpRenderTree/chromium/TestShell.h:
839         (TestShell::setAccelerated2dCanvasEnabled):
840         * DumpRenderTree/chromium/WebPreferences.cpp:
841         (WebPreferences::reset):
842         (WebPreferences::applyTo):
843         * DumpRenderTree/chromium/WebPreferences.h:
844
845 2012-01-09  Adam Roben  <aroben@apple.com>
846
847         Convert Cygwin paths to Windows paths before passing them to DRT
848
849         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
850         NRWT
851
852         I couldn't find a way to test this because I couldn't figure out how to override the
853         cygpath function as it is used by WebKitDriver.
854
855         Reviewed by Dirk Pranke.
856
857         * Scripts/webkitpy/layout_tests/port/webkit.py:
858         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
859         Windows-style path before passing it to DRT.
860
861 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
862
863         webkitpy: revamp version checking
864         https://bugs.webkit.org/show_bug.cgi?id=75765
865
866         Reviewed by Adam Barth.
867
868         The version-checking code in webkitpy/python24/versioning seems really
869         awkward and overdesigned, especially since we don't support python 2.4
870         any more.
871
872         In addition, I am tired of getting warnings about Python 2.6 being "a
873         newer release than what is supported" :).
874
875         I'm taking a page from the depot_tools python code and just creating a
876         new webkitpy.common.version_check module that will print a message on
877         stderr and call sys.exit() if we're running an unsupported version.
878
879         * Scripts/check-webkit-style:
880         * Scripts/new-run-webkit-httpd:
881         * Scripts/new-run-webkit-tests:
882         * Scripts/rebaseline-chromium-webkit-tests:
883         * Scripts/test-webkitpy:
884         (configure_logging):
885         (init):
886         * Scripts/webkit-patch:
887         (main):
888         * Scripts/webkitpy/common/system/executive.py:
889         (Executive._child_process_encoding):
890         (Executive._should_encode_child_process_arguments):
891         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
892         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
893         * Scripts/webkitpy/python24/__init__.py: Removed.
894         * Scripts/webkitpy/python24/versioning.py: Removed.
895         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
896
897 2012-01-09  Adam Barth  <abarth@webkit.org>
898
899         Remove Chromium Mac CG from the flakiness dashboard
900         https://bugs.webkit.org/show_bug.cgi?id=75873
901
902         Reviewed by Ojan Vafai.
903
904         This configuration no longer exists.
905
906         * TestResultServer/static-dashboards/builders.js:
907         * TestResultServer/static-dashboards/flakiness_dashboard.html:
908         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
909         (testOverrideJustBuildType):
910         (testPlatformAndBuildType):
911
912 2012-01-06  Adam Roben  <aroben@apple.com>
913
914         Print an error message when NRWT can't run Apache
915
916         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
917
918         Reviewed by Dirk Pranke.
919
920         * Scripts/webkitpy/layout_tests/port/base.py:
921         (Port.check_httpd): Print an error message when Apache returns an error code instead of
922         failing silently.
923
924         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
925         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
926         run Apache.
927         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
928         fails.
929
930 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
931
932         [Gtk][ARM] Cross compiler buildbot is failing after r103040
933         https://bugs.webkit.org/show_bug.cgi?id=75846
934
935         Reviewed by Philippe Normand.
936
937         * Scripts/webkitdirs.pm:
938         (runAutogenForAutotoolsProjectIfNecessary):
939
940 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
941
942         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
943         https://bugs.webkit.org/show_bug.cgi?id=75807
944
945         This patch adds a new icon to navigationbar of the Qt MiniBrowser
946         which allows you to dynamically toggle whether touch mocking is
947         enabled or disabled.
948
949         Reviewed by Tor Arne Vestbø.
950
951         * MiniBrowser/qt/MiniBrowser.qrc:
952         * MiniBrowser/qt/MiniBrowserApplication.cpp:
953         (MiniBrowserApplication::notify):
954         * MiniBrowser/qt/MiniBrowserApplication.h:
955         (WindowOptions::WindowOptions):
956         (WindowOptions::touchMockingEnabled):
957         (WindowOptions::setTouchMockingEnabled):
958         * MiniBrowser/qt/icons/touch.png: Added.
959         * MiniBrowser/qt/qml/BrowserWindow.qml:
960
961 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
962
963         Unreviewed. Fix make distcheck issues.
964
965         * MiniBrowser/gtk/GNUmakefile.am:
966
967 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
968
969         Unreviewed, rolling out r104421.
970         http://trac.webkit.org/changeset/104421
971         https://bugs.webkit.org/show_bug.cgi?id=75816
972
973         Need to rebaseline some tests on Linux (Requested by noamr on
974         #webkit).
975
976         * qmake/mkspecs/features/features.prf:
977
978 2012-01-08  Adam Barth  <abarth@webkit.org>
979
980         Remove support for Chromium Mac CG from garden-o-matic
981         https://bugs.webkit.org/show_bug.cgi?id=75814
982
983         Reviewed by Eric Seidel.
984
985         This configuration no longer exists.  This patch is mostly a matter of
986         updating config.js and removing the examples from the unit tests.
987
988         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
989         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
990         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
991         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
992         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
993
994 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
995
996         [Qt] Enable CSS_FILTERS in Qt build
997         https://bugs.webkit.org/show_bug.cgi?id=75777
998
999         Add the CSS_FILTERS feature flag to Qt.
1000
1001         Reviewed by Kenneth Rohde Christiansen.
1002
1003         * qmake/mkspecs/features/features.prf:
1004
1005 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1006
1007         Categorize bots by ports instead of core/non-core separation
1008         https://bugs.webkit.org/show_bug.cgi?id=75766
1009
1010         Reviewed by Eric Seidel.
1011
1012         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
1013         (Chromium still comes before GTK and Qt).
1014
1015         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1016         (loadBuilderConfig):
1017         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1018
1019 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1020
1021         Remove the concept of core builders from webkitpy
1022         https://bugs.webkit.org/show_bug.cgi?id=75809
1023
1024         Reviewed by Ryosuke Niwa.
1025
1026         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
1027         and remove the relevant code.
1028
1029         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1030         (BuildBot.__init__):
1031         (BuildBot._matches_regexps):
1032         (BuildBot._builder_statuses_with_names_matching_regexps):
1033         (BuildBot.builder_statuses):
1034         (BuildBot.failure_map):
1035         (BuildBot._latest_builds_from_builders):
1036         (BuildBot.last_green_revision):
1037         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1038         (MockBuildBot.builder_statuses):
1039         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1040         (test_status_parsing):
1041         (test_last_green_revision):
1042         (test_last_green_revision.mock_builds_from_builders):
1043
1044 2012-01-08  Adam Barth  <abarth@webkit.org>
1045
1046         Remove Chromium Mac CG concept from webkitpy
1047         https://bugs.webkit.org/show_bug.cgi?id=75810
1048
1049         Reviewed by Ryosuke Niwa.
1050
1051         This configuration no longer exists.  We can remove all the supporting
1052         code from webkitpy.
1053
1054         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1055         (BaselineOptimizerTest.test_move_baselines):
1056         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
1057         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
1058         (BaselineOptimizerTest.test_common_directory_includes_root):
1059         (BaselineOptimizerTest.test_complex_shadowing):
1060         * Scripts/webkitpy/common/config/build.py:
1061         (_should_file_trigger_build):
1062         * Scripts/webkitpy/common/config/build_unittest.py:
1063         (ShouldBuildTest):
1064         * Scripts/webkitpy/layout_tests/port/builders.py:
1065         * Scripts/webkitpy/layout_tests/port/chromium.py:
1066         (ChromiumPort):
1067         (ChromiumPort._generate_all_test_configurations):
1068         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1069         (_default_tests_paths):
1070         (ChromiumGpuLinuxPort.tests):
1071         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1072         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
1073         (ChromiumGpuTest.assert_port_works):
1074         (ChromiumGpuTest.test_baseline_paths):
1075         (ChromiumGpuTest.test_graphics_type):
1076         (ChromiumGpuTest.test_default_tests_paths):
1077         (ChromiumGpuTest.test_test_files):
1078         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1079         (ChromiumMacPort):
1080         (ChromiumMacPort.__init__):
1081         (ChromiumMacPort.baseline_search_path):
1082         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1083         (ChromiumMacPortTest.test_graphics_type):
1084         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1085         (ChromiumPortTest.test_all_test_configurations):
1086         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1087         * Scripts/webkitpy/layout_tests/port/factory.py:
1088         (PortFactory._port_name_from_arguments_and_options):
1089         (PortFactory.get):
1090         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1091         (FactoryTest.test_chromium_gpu_mac):
1092         (FactoryTest.test_chromium_mac):
1093         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1094         (GetGoogleChromePortTest._verify_expectations_overrides):
1095         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1096         (MockChromiumDRTTest.test_chromium_parse_options):
1097         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1098         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1099         (test_url_fetcher):
1100         (test_zip_factory):
1101         (test_archive):
1102         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1103         (TestRebaseline.test_rebaseline_expectations):
1104
1105 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1106
1107         Categorize bots by ports instead of core/non-core separation
1108         https://bugs.webkit.org/show_bug.cgi?id=75766
1109
1110         Reviewed by Adam Barth.
1111
1112         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
1113
1114         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1115         (loadBuilderConfig):
1116         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1117
1118 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1119
1120         Unreviewed, rolling out r104403.
1121         http://trac.webkit.org/changeset/104403
1122         https://bugs.webkit.org/show_bug.cgi?id=75803
1123
1124         It broke all tests on Qt5 (Requested by Ossy_weekend on
1125         #webkit).
1126
1127         * qmake/mkspecs/features/features.prf:
1128
1129 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
1130
1131         [Qt] Enable CSS_FILTERS in Qt build
1132         https://bugs.webkit.org/show_bug.cgi?id=75777
1133
1134         Add the CSS_FILTERS feature flag to Qt.
1135
1136         Reviewed by Kenneth Rohde Christiansen.
1137
1138         * qmake/mkspecs/features/features.prf:
1139
1140 2012-01-04  Kentaro Hara  <haraken@chromium.org>
1141
1142         Rewrite the CSS parser of prepare-ChangeLog with unittests.
1143         https://bugs.webkit.org/show_bug.cgi?id=75202
1144
1145         Reviewed by David Kilzer.
1146
1147         The current CSS parser can just parse simple CSSes like
1148
1149             foo bar baz {
1150                 property1: value;
1151                 property2: value;
1152             }
1153
1154         , and cannot parse comments nor a CSS in which a selector and {
1155         appears in different lines. This patch rewrites the CSS parser
1156         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
1157         shown in css_unittests.css.
1158
1159         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
1160
1161         * Scripts/prepare-ChangeLog:
1162         (get_selector_line_ranges_for_css):
1163         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1164         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
1165         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
1166         (element1):
1167         (element2):
1168         (element3):
1169         (element4.p):
1170         (element5.p.q.r.s):
1171         (element6#p):
1172         (element7 element8):
1173         (element9.p element10.q):
1174         (element11#p element12#q):
1175         (element13, element14):
1176         (.p):
1177         (#p):
1178         (.p element15 #q element16.r element17#s):
1179         (element18:target):
1180         (element19):
1181         (element20):
1182         (element21):
1183         (element22):
1184
1185 2012-01-04  Kentaro Hara  <haraken@chromium.org>
1186
1187         The Perl parser of prepare-ChangeLog can parse here-documents
1188         https://bugs.webkit.org/show_bug.cgi?id=73208
1189
1190         Reviewed by David Kilzer.
1191
1192         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
1193         which results in wrong subroutine names in ChangeLogs.
1194         With this patch, prepare-ChangeLog can judge whether the line of "}"
1195         is the end of a subroutine or a line inside a here-document.
1196
1197         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
1198
1199         * Scripts/prepare-ChangeLog:
1200         (get_function_line_ranges_for_perl):
1201         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1202         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1203         Added test cases for here-documents.
1204         (func7):
1205         (func8):
1206         (func9):
1207         (func10):
1208         (func11):
1209         (func12):
1210         (func13):
1211         (func14):
1212         (func15):
1213         (func16):
1214
1215 2012-01-08  Kentaro Hara  <haraken@chromium.org>
1216
1217         Add unittests for the JavaScript parser of prepare-ChangeLog
1218         https://bugs.webkit.org/show_bug.cgi?id=75201
1219
1220         Reviewed by David Kilzer.
1221
1222         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
1223         of prepare-ChangeLog.
1224
1225         * Scripts/prepare-ChangeLog:
1226         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
1227         omitted from parsing. Thus,
1228
1229             str = "foo"
1230             function func() {
1231             }
1232
1233         was recognized as equivalent to
1234
1235             str = function func() {
1236             }
1237
1238         This patch replaces a string with a dummy identifier 'string_appeared_here'
1239         to tell the parser that a string appeared there.
1240
1241         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1242         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
1243         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
1244         (func1):
1245         (func2):
1246         (func3):
1247         (func4):
1248         (func5):
1249         (func6):
1250         (func7):
1251         (func8):
1252         (func9):
1253         (func10):
1254         (func11):
1255         (func12):
1256         (funcOverloaded):
1257         (Func1.prototype.get x1):
1258         (Func1.prototype.get x2):
1259         (Func1.prototype.set x1):
1260         (Func1.prototype.set x3):
1261         (Func2.prototype.func13):
1262         (Func2.prototype.func14):
1263         (Func2.prototype.func15):
1264         (func16.func17):
1265         (func16.func18):
1266         (func16.func19):
1267         (func16):
1268
1269 2012-01-08  David Levin  <levin@chromium.org>
1270
1271         [chromium] Add layout test support for autosize code in FrameView.
1272         https://bugs.webkit.org/show_bug.cgi?id=73631
1273
1274         Reviewed by Dmitry Titov.
1275
1276         * DumpRenderTree/chromium/LayoutTestController.cpp:
1277         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
1278         (LayoutTestController::reset): Set the autoresize mode back to false.
1279         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
1280         * DumpRenderTree/chromium/LayoutTestController.h:
1281         * DumpRenderTree/chromium/WebViewHost.cpp:
1282         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
1283         * DumpRenderTree/chromium/WebViewHost.h:
1284
1285 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
1286
1287         [WK2][GTK] Each test takes roughly half a second to load
1288         https://bugs.webkit.org/show_bug.cgi?id=70699
1289
1290         Reviewed by Martin Robinson.
1291
1292         Set the XDG_CACHE_HOME environment variable when testing with
1293         WebKitTestRunner. This way the testing is started with a non-existing
1294         application cache. If the cache exists and is not empty, the emptying
1295         and vacuuming that is performed before every test can consume a lot of
1296         time.
1297
1298         This is just a temporary workaround until it becomes possible to set
1299         a desired directory to be used as the application cache location through
1300         WebKitWebContext.
1301
1302         * Scripts/webkitpy/layout_tests/port/gtk.py:
1303         (GtkPort.setup_environ_for_server):
1304
1305 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
1306
1307         [GTK] Enable requestAnimationFrame in build-webkit
1308         https://bugs.webkit.org/show_bug.cgi?id=75773
1309
1310         Reviewed by Martin Robinson.
1311
1312         Enable requestAnimationFrame for the Gtk port.
1313
1314         * Scripts/build-webkit:
1315
1316 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
1317
1318         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
1319
1320         * Scripts/webkitdirs.pm:
1321         (buildChromium):
1322         Missing parentheses.
1323
1324 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1325
1326         Fix DRT build on case-sensitive file systems.
1327
1328         Fix case of include of WebDynamicScrollBarsView.h
1329         
1330         * DumpRenderTree/mac/DumpRenderTree.mm:
1331
1332 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1333
1334         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
1335         https://bugs.webkit.org/show_bug.cgi?id=75662
1336
1337         Reviewed by Dan Bernstein.
1338         
1339         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
1340         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
1341         test window uses the main display's color space, so that the pixel values in the bitmap
1342         that gets checksummed are identical to the CSS colors.
1343         
1344         Removed the code that switches the display profile in DRT, since that is no longer required.
1345
1346         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
1347         * DumpRenderTree/mac/DumpRenderTree.mm:
1348         (crashHandler): Remove code that switches display profiles.
1349         (prepareConsistentTestingEnvironment): Ditto.
1350         (dumpRenderTree): Ditto.
1351         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
1352         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
1353         (createBitmapContextFromWebView): Add comment about the colorspace handling.
1354         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1355         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
1356         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
1357         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1358         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
1359         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
1360
1361 2012-01-06  David Kilzer  <ddkilzer@apple.com>
1362
1363         run-api-tests: specify individual suites and tests on the command-line
1364
1365         Reviewed by Adam Roben.
1366
1367         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
1368
1369         The run-api-tests script will now accept a list of arguments on
1370         the command-line that are used as prefix filters.  To run all
1371         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
1372         use:
1373
1374             $ run-api-tests WTF
1375
1376         To run only the tests in the "WTF" suite, not the "WTF_Vector"
1377         suite, use:
1378
1379             $ run-api-tests WTF.
1380
1381         * Scripts/run-api-tests: Filter tests if any prefix arguments
1382         are passed on the command-line.
1383
1384 2012-01-06  David Kilzer  <ddkilzer@apple.com>
1385
1386         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
1387
1388         Reviewed by Adam Roben.
1389
1390         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
1391
1392         * Scripts/run-api-tests:
1393         (dumpTestsBySuite): Update to accept array of tests instead of
1394         hash data structure.
1395         (runTestsBySuite): Ditto.
1396         (listAllTests): Rename from populateTests().  Update to return
1397         an array of tests instad of the hash data structure.
1398
1399 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1400
1401         webkitpy: clean up test/uri conversion routines
1402         https://bugs.webkit.org/show_bug.cgi?id=75648
1403
1404         Reviewed by Eric Seidel.
1405
1406         This change moves test_to_uri and uri_to_test from the Port
1407         class to the Driver class (the routines were only being
1408         called by the drivers), and removes a bunch of stale and/or
1409         busted logic.
1410
1411         * Scripts/webkitpy/layout_tests/port/base.py:
1412         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1413         * Scripts/webkitpy/layout_tests/port/chromium.py:
1414         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1415         * Scripts/webkitpy/layout_tests/port/driver.py:
1416         (is_http_test):
1417         (test_to_uri):
1418         (uri_to_test):
1419         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1420         (run_one_test):
1421         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1422         (MockDRTTest.input_line):
1423         (input_line):
1424         (expected_output):
1425         * Scripts/webkitpy/layout_tests/port/test.py:
1426         * Scripts/webkitpy/layout_tests/port/webkit.py:
1427         (_command_from_driver_input):
1428
1429 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1430
1431         Mitigate scrollbar differences when running pixel tests
1432         https://bugs.webkit.org/show_bug.cgi?id=67217
1433
1434         Reviewed by Dan Bernstein.
1435         
1436         Add an NSScroller subclass that draws mock scrollbars identically
1437         to the WebCore mock scrollbar theme, and register it with the
1438         WebDynamicScrollbarsView.
1439
1440         * DumpRenderTree/mac/DumpRenderTree.mm:
1441         (-[DRTMockScroller rectForPart:]):
1442         (-[DRTMockScroller drawKnob]):
1443         (-[DRTMockScroller drawRect:]):
1444         (registerMockScrollbars):
1445         (prepareConsistentTestingEnvironment):
1446
1447 2012-01-05  Jon Lee  <jonlee@apple.com>
1448
1449         Update DRT on Mac to draw resize handles on text areas.
1450
1451         Reviewed by John Sullivan.
1452
1453         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
1454         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
1455
1456         * DumpRenderTree/mac/DumpRenderTree.mm:
1457         (resetDefaultsToConsistentValues):
1458
1459 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1460
1461         [Qt] Move listing of include paths and libs to pri files in sources
1462
1463         Includepaths are sometimes modified by non-Qt contributors so keeping
1464         them in files inside Sources makes it more likely that they are updated
1465         along with project files for the other ports.
1466
1467         Using pri files instead of prf files for this also has the benefit that
1468         the include() from the main target file can be parsed and followed by
1469         Qt Creator -- something that does not work with load().
1470
1471         Dependency from a target to a library through the WEBKIT variable are
1472         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
1473         set the source root of the module and include the right pri file.
1474
1475         Ideally we'd use the variant of include() that takes an optional
1476         namespace to read the variables into, or the fromfile() function,
1477         but both of these add an overhead of about 40% on the total qmake
1478         runtime, due to making a deep copy of all the variables in the
1479         project or re-reading all the prf files from scratch.
1480
1481         Reviewed by Simon Hausmann.
1482         Reviewed by Ossy.
1483
1484         * qmake/mkspecs/features/default_post.prf:
1485         * qmake/mkspecs/modules/javascriptcore.prf: Added.
1486         * qmake/mkspecs/modules/webcore.prf: Added.
1487         * qmake/mkspecs/modules/webkit2.prf: Added.
1488         * qmake/mkspecs/modules/wtf.prf: Added.
1489
1490 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
1491
1492         [EFL] Add pre-render handling code in EWebLauncher.
1493         https://bugs.webkit.org/show_bug.cgi?id=73430
1494
1495         Reviewed by Zoltan Herczeg.
1496
1497         Add pre-render handling code by pressing Insert key.
1498
1499         * EWebLauncher/main.c:
1500         (on_key_down):
1501
1502 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
1503
1504         NRWT should use test_expectation.txt on wk2 platforms
1505         https://bugs.webkit.org/show_bug.cgi?id=75417
1506
1507         Reviewed by Dirk Pranke.
1508
1509         * Scripts/webkitpy/layout_tests/port/webkit.py:
1510         (path_to_test_expectations_file):
1511         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1512         (test_path_to_test_expectations_file):
1513
1514 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
1515
1516         Don't hardcode expected file URIs in as they depend on the platform
1517         https://bugs.webkit.org/show_bug.cgi?id=75666
1518
1519         Reviewed by Dirk Pranke.
1520
1521         * Scripts/webkitpy/layout_tests/port/win.py:
1522         (WinPort.show_results_html_file):
1523         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1524         (MainTest.test_unexpected_failures):
1525         (MainTest.test_results_directory_default):
1526         (MainTest.test_results_directory_relative):
1527
1528 2012-01-05  Anders Carlsson  <andersca@apple.com>
1529
1530         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
1531         https://bugs.webkit.org/show_bug.cgi?id=75667
1532         <rdar://problem/10389454>
1533
1534         Reviewed by Kevin Decker.
1535
1536         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
1537
1538         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1539         (PluginTest::executeScript):
1540         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1541         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
1542         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
1543         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
1544         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
1545
1546 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1547
1548         webkitpy: clean up port factory methods
1549         https://bugs.webkit.org/show_bug.cgi?id=75590
1550
1551         Reviewed by Eric Seidel.
1552
1553         This change consolidates much of the "factory method" logic
1554         of determining which port objects to create for a given set
1555         of configurations by merging the separate factory methods in
1556         chromium_gpu and google_chrome into PortFactory so that at least
1557         all of the logic is in one place.
1558
1559         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1560         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1561         * Scripts/webkitpy/layout_tests/port/factory.py:
1562         (_port_name_from_arguments_and_options):
1563         (get):
1564         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1565         (test_google_chrome):
1566         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1567         (GoogleChromeLinux32Port):
1568         (GoogleChromeLinux32Port.baseline_search_path):
1569         (test_expectations_overrides):
1570         (architecture):
1571         (GoogleChromeLinux64Port):
1572         (GoogleChromeLinux64Port.baseline_search_path):
1573         (GoogleChromeMacPort):
1574         (GoogleChromeMacPort.baseline_search_path):
1575         (GoogleChromeWinPort):
1576         (GoogleChromeWinPort.baseline_search_path):
1577         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1578         (_verify_baseline_path):
1579
1580 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
1581
1582         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
1583         https://bugs.webkit.org/show_bug.cgi?id=75617
1584
1585         Reviewed by Dirk Pranke.
1586
1587         * Scripts/webkitpy/common/system/filesystem.py:
1588         (FileSystem.exists):
1589         * Scripts/webkitpy/common/system/filesystem_mock.py:
1590         (MockFileSystem.exists):
1591         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1592         (GenericFileSystemTests.teardown_generic_test_dir):
1593         * Scripts/webkitpy/layout_tests/port/base.py:
1594         (Port.to.show_results_html_file):
1595         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1596         (MainTest.test_results_directory_absolute):
1597
1598 2012-01-05  Adam Roben  <aroben@apple.com>
1599
1600         Remove some unnecessary code from old-run-webkit-tests
1601
1602         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
1603         WebKitTestRunner.
1604
1605         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
1606         Windows
1607
1608         Reviewed by Eric Seidel.
1609
1610         * Scripts/old-run-webkit-tests:
1611         (top level):
1612         (openDumpTool):
1613         Removed calls to setPathForRunningWebKitApp.
1614
1615 2012-01-05  Adam Roben  <aroben@apple.com>
1616
1617         Teach NRWT to use run-safari to open results.html on Apple's Windows port
1618
1619         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
1620         better, since we always want to open results.html using the user's build of WebKit, not
1621         whatever their default browser is.
1622
1623         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
1624         for Apple's Windows port
1625
1626         Reviewed by Eric Seidel.
1627
1628         * Scripts/webkitpy/layout_tests/port/win.py:
1629         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
1630         an obsolete comment.
1631
1632         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1633         (WinPortTest.test_show_results_html_file): Updated expected results.
1634
1635 2012-01-05  Adam Roben  <aroben@apple.com>
1636
1637         Prepend Safari.exe's path to the command-line passed to CreateProcess
1638
1639         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
1640         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
1641         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
1642         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
1643         first argument that WebKitLauncherWin was trying to pass to it.
1644
1645         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
1646
1647         Reviewed by Steve Falkenburg.
1648
1649         * WebKitLauncherWin/WebKitLauncherWin.cpp:
1650         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
1651         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
1652
1653 2012-01-05  Adam Roben  <aroben@apple.com>
1654
1655         Stop using explicit memory management in WebKitLauncherWin
1656
1657         We now use stack-allocated STL objects instead.
1658
1659         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
1660         Safari
1661
1662         Reviewed by Steve Falkenburg.
1663
1664         * WebKitLauncherWin/WebKitLauncherWin.cpp:
1665         (getStringValue):
1666         (applePathFromRegistry):
1667         (safariInstallDir):
1668         (safariBrowserExe):
1669         (_tWinMain):
1670         Changed to use stack-allocated STL objects instead of malloc/free.
1671
1672 2012-01-05  Adam Roben  <aroben@apple.com>
1673
1674         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
1675
1676         This allows us to add the Safari and Apple Application Support directories to PATH before
1677         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
1678
1679         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
1680         Windows port of DumpRenderTree/WebKitTestRunner
1681
1682         Reviewed by Steve Falkenburg.
1683
1684         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
1685         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
1686
1687         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1688         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1689         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
1690
1691         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
1692         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
1693         the stub launcher.
1694
1695         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
1696         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
1697         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
1698         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
1699         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
1700         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
1701         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
1702
1703         * WebKitTestRunner/win/main.cpp:
1704         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
1705
1706 2012-01-05  Adam Roben  <aroben@apple.com>
1707
1708         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
1709
1710         This allows us to add the Safari and Apple Application Support directories to PATH before
1711         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
1712
1713         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
1714         Windows port of DumpRenderTree/WebKitTestRunner
1715
1716         Reviewed by Steve Falkenburg.
1717
1718         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
1719         which I forgot to add to this .sln when that project was created.
1720
1721         * DumpRenderTree/win/DumpRenderTree.cpp:
1722         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
1723
1724         * DumpRenderTree/win/DumpRenderTree.vcproj:
1725         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1726         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
1727
1728         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
1729         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
1730         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
1731         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
1732         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
1733         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
1734         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
1735         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
1736
1737         * win/DLLLauncher/DLLLauncherMain.cpp:
1738         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
1739         Safari's directory to PATH so that SafariTheme.dll can be found.
1740
1741         (main):
1742         (wWinMain):
1743         Changed to use the new modifyPath function.
1744
1745 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
1746
1747         [Qt] Never enable FontConfig on Mac OS X
1748         https://bugs.webkit.org/show_bug.cgi?id=75616
1749
1750         Reviewed by Tor Arne Vestbø.
1751
1752         * qmake/mkspecs/features/features.prf:
1753
1754 2012-01-05  Alpha Lam  <hclam@chromium.org>
1755
1756         Unreviewed, rolling out r104159.
1757         http://trac.webkit.org/changeset/104159
1758         https://bugs.webkit.org/show_bug.cgi?id=75590
1759
1760         Chromium port GPU tests cannot be executed.
1761
1762         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1763         (get):
1764         (_default_tests_paths):
1765         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1766         (ChromiumGpuTest.assert_port_works):
1767         * Scripts/webkitpy/layout_tests/port/factory.py:
1768         (PortFactory._port_name_from_arguments_and_options):
1769         (PortFactory):
1770         (PortFactory._get_kwargs):
1771         (PortFactory.get):
1772         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1773         (FactoryTest.test_google_chrome.names):
1774         (FactoryTest.test_google_chrome):
1775         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1776         (GetGoogleChromePort):
1777         (GetGoogleChromePort.GoogleChromeLinux32Port):
1778         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
1779         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
1780         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
1781         (GetGoogleChromePort.GoogleChromeLinux64Port):
1782         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
1783         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
1784         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
1785         (GetGoogleChromePort.GoogleChromeMacPort):
1786         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
1787         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
1788         (GetGoogleChromePort.GoogleChromeWinPort):
1789         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
1790         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
1791         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1792         (GetGoogleChromePortTest._verify_baseline_path):
1793         (GetGoogleChromePortTest._verify_expectations_overrides):
1794
1795 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1796
1797         webkitpy: clean up port factory methods
1798         https://bugs.webkit.org/show_bug.cgi?id=75590
1799
1800         Reviewed by Eric Seidel.
1801
1802         This change consolidates much of the "factory method" logic
1803         of determining which port objects to create for a given set
1804         of configurations by merging the separate factory methods in
1805         chromium_gpu and google_chrome into PortFactory so that at least
1806         all of the logic is in one place.
1807
1808         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1809         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1810         * Scripts/webkitpy/layout_tests/port/factory.py:
1811         (_port_name_from_arguments_and_options):
1812         (get):
1813         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1814         (test_google_chrome):
1815         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1816         (GoogleChromeLinux32Port):
1817         (GoogleChromeLinux32Port.baseline_search_path):
1818         (test_expectations_overrides):
1819         (architecture):
1820         (GoogleChromeLinux64Port):
1821         (GoogleChromeLinux64Port.baseline_search_path):
1822         (GoogleChromeMacPort):
1823         (GoogleChromeMacPort.baseline_search_path):
1824         (GoogleChromeWinPort):
1825         (GoogleChromeWinPort.baseline_search_path):
1826         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1827         (_verify_baseline_path):
1828
1829 2012-01-04  Adam Roben  <aroben@apple.com>
1830
1831         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
1832
1833         This allows us to add the Apple Application Support directory to PATH before trying to load
1834         WebKit so that CoreGraphics.dll and friends can be found.
1835
1836         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
1837
1838         Reviewed by Anders Carlsson.
1839
1840         * DumpRenderTree/win/ImageDiff.vcproj:
1841         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1842         Changed to build ImageDiff.dll instead of ImageDiff.exe.
1843
1844         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
1845         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
1846
1847         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
1848         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
1849         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
1850         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
1851         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
1852         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
1853         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
1854
1855         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
1856         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
1857         to main.
1858
1859         * win/DLLLauncher/DLLLauncherMain.cpp:
1860         (main):
1861         (wWinMain):
1862         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
1863         stub launcher acts as a console program and calls a console version of
1864         dllLauncherEntryPoint.
1865
1866 2012-01-04  Adam Roben  <aroben@apple.com>
1867
1868         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
1869
1870         This allows us to add the Apple Application Support directory to PATH before trying to load
1871         WebKit so that CoreGraphics.dll and friends can be found.
1872
1873         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
1874         double-clicked
1875
1876         Reviewed by Anders Carlsson.
1877
1878         * MiniBrowser/MiniBrowser.vcproj:
1879         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1880         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
1881
1882         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
1883         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
1884         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
1885         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
1886         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
1887         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
1888         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
1889
1890         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
1891         but changed to build the stub launcher.
1892
1893         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
1894         it needs to be compiled into the .exe instead of the .dll.
1895         (DllMain): Added. We use this to store the DLL's HINSTANCE.
1896         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
1897         DLLLauncherMain code.
1898
1899         * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
1900         to here.
1901
1902 2012-01-04  Adam Roben  <aroben@apple.com>
1903
1904         Make WinLauncher's window frame respond to clicks/drags again
1905
1906         Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
1907         bar when Aero is disabled
1908
1909         Reviewed by Brent Fulgham.
1910
1911         * WinLauncher/WinLauncher.cpp:
1912         (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
1913         Also removed an unnecessary "break" keyword.
1914
1915 2012-01-04  Adam Roben  <aroben@apple.com>
1916
1917         Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
1918
1919         This allows us to add the Apple Application Support directory to PATH before trying to load
1920         WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
1921         should use this mechanism.
1922
1923         Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
1924         double-clicked
1925
1926         Reviewed by Anders Carlsson.
1927
1928         * WinLauncher/WinLauncher.cpp: Removed InitInstance.
1929         (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
1930         done by the now-removed InitInstance function.
1931         (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
1932         calls. Merged code from InitInstance into this function, and change to use the global hInst
1933         variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
1934         function, which corresponds to WinLauncher.exe.
1935
1936         * WinLauncher/WinLauncher.vcproj:
1937         * WinLauncher/WinLauncherCommon.vsprops:
1938         Changed to build WinLauncher.dll instead of WinLauncher.exe.
1939
1940         * WinLauncher/WinLauncherLauncher.rc: Added.
1941         * WinLauncher/WinLauncherLauncherResource.h: Added.
1942         This just references the WinLauncher.ico file to set the application icon (though it looks
1943         like that's a default icon).
1944
1945         * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
1946         but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
1947
1948         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
1949         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
1950         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
1951         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
1952         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
1953         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
1954         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
1955
1956         * win/DLLLauncher/DLLLauncherMain.cpp: Added.
1957         (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
1958         program if it detects heap corruption.
1959         (getStringValue): Helper function to read a string value from the registry.
1960         (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
1961         application from the registry.
1962         (appleApplicationSupportDirectory): Helper function to return the path to the Apple
1963         Application Support directory.
1964         (copyEnvironmentVariable): Helper function to copy an environment variable's value.
1965         (prependPath): Helper function to prepend a directory to the PATH.
1966         (fatalError): Helper function to display an error to the user.
1967         (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
1968         dllLauncherEntryPoint function.
1969
1970 2012-01-05  Kentaro Hara  <haraken@chromium.org>
1971
1972         prepare-ChangeLog cannot parse python code that nests classes and defs
1973         https://bugs.webkit.org/show_bug.cgi?id=75524
1974
1975         Reviewed by Ryosuke Niwa.
1976
1977         This patch fixes the python parser of prepare-ChangeLog so that it can parse
1978         python code that nests classes and defs, like this:
1979
1980         class C:
1981             pass
1982             def f():
1983                 pass
1984             pass
1985
1986         Also, this patch fixes the python parser so that it inserts a dummy line
1987         at the end of the file to pop out all popped scopes.
1988
1989         * Scripts/prepare-ChangeLog:
1990         (get_function_line_ranges_for_python):
1991
1992         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
1993         Added test cases that nest classes and defs.
1994         (func7):
1995         (func7.func8):
1996         (func7.func8.func9):
1997         (Class2):
1998         (Class2.Class3):
1999         (Class2.Class3.Class4):
2000         (Class5):
2001         (Class5.func10):
2002         (Class5.func11):
2003         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
2004
2005 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2006
2007         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
2008         https://bugs.webkit.org/show_bug.cgi?id=75433
2009
2010         Reviewed by Martin Robinson.
2011
2012         * MiniBrowser/gtk/BrowserWindow.c:
2013         (webViewLoadFailed): Reset the progress bar when load fails.
2014         (browserWindowConstructed): Connect to load-failed signal.
2015
2016 2012-01-04  Dan Bernstein  <mitz@apple.com>
2017
2018         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
2019         start WebProcess under gdb and WebProcess will then run the client executable.
2020
2021         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
2022
2023         Reviewed by Anders Carlsson.
2024
2025         * Scripts/webkitdirs.pm:
2026         (shouldTargetWebProcess): Added.
2027         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
2028         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
2029         app using the -client-executable option if targeting the web process.
2030
2031 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2032
2033         Adding myself to committers list.
2034
2035         Unreviewed.
2036
2037         * Scripts/webkitpy/common/config/committers.py:
2038
2039 2012-01-04  David Kilzer  <ddkilzer@apple.com>
2040
2041         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
2042
2043         This reverts commit r103546.
2044
2045         * TestWebKitAPI/TestsController.cpp:
2046         (TestWebKitAPI::TestsController::TestsController):
2047
2048 2012-01-04  James Robinson  <jamesr@chromium.org>
2049
2050         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
2051         https://bugs.webkit.org/show_bug.cgi?id=74583
2052
2053         Reviewed by Darin Fisher.
2054
2055         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
2056
2057         * Scripts/webkitpy/style/checkers/cpp.py:
2058         (check_function_definition):
2059
2060 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2061
2062         [Qt] Fix link order of static libraries and unbreak QtWin32
2063
2064         We were keeping the correct static link order between the intermediate
2065         WebKit libraries, but not the internal dependencies for each of those
2066         libraries. The load() will in some instances mess with LIBS, so we need
2067         to ensure that the dependent libraries are added after the library we
2068         are linking against.
2069
2070         Reviewed by Simon Hausmann.
2071
2072         * qmake/mkspecs/features/default_post.prf:
2073
2074 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2075
2076         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
2077
2078         The custom qmake variable 'WEBKIT' is used for signaling that a
2079         target depends in some way on other subproject of the WebKit
2080         project. For now this is limited to the set of intermediate
2081         libraries: wtf, javascriptcore, webcore, and webkit2.
2082
2083         This replaces the previous convension of using load(foo) for
2084         just include paths, and CONFIG += foo to also link against foo.
2085
2086         Adding a dependency results in additional include paths being
2087         available, and potentially linking to the library. This is
2088         decided by the build system based on conditions such as what
2089         kind of target is being built and the general build config.
2090
2091         An advantage to his approach is that it simplifies the individual
2092         foo.prf files, for example by allowing us to use INCLUDEPATH +=
2093         and LIBS += as normal instead of prepending.
2094
2095         Reviewed by Simon Hausmann.
2096
2097         * DumpRenderTree/qt/DumpRenderTree.pro:
2098         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2099         * QtTestBrowser/QtTestBrowser.pro:
2100         * WebKitTestRunner/InjectedBundle/Target.pri:
2101         * WebKitTestRunner/Target.pri:
2102         * qmake/README:
2103         * qmake/mkspecs/features/default_post.prf:
2104         * qmake/mkspecs/features/functions.prf:
2105         * qmake/mkspecs/features/javascriptcore.prf:
2106         * qmake/mkspecs/features/qtwebkit.prf:
2107         * qmake/mkspecs/features/webcore.prf:
2108         * qmake/mkspecs/features/webkit2.prf:
2109         * qmake/mkspecs/features/wtf.prf:
2110
2111 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
2112
2113         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
2114         https://bugs.webkit.org/show_bug.cgi?id=75488
2115
2116         Reviewed by Tor Arne Vestbø.
2117
2118         * MiniBrowser/qt/MiniBrowser.qrc:
2119         * MiniBrowser/qt/qml/BrowserWindow.qml:
2120         * MiniBrowser/qt/qml/Dialog.qml:
2121         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
2122         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
2123
2124 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2125
2126         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
2127
2128         It wasn't really a problem at runtime since the right QtWebKit was
2129         already loaded as a dependency of the web process, but the ldd output
2130         would still be busted.
2131
2132         Reviewed by Simon Hausmann.
2133
2134         * WebKitTestRunner/InjectedBundle/Target.pri:
2135
2136 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2137
2138         [Qt] Move use of $$qtLibraryTarget() to a single place
2139
2140         Reviewed by Kenneth Rohde Christiansen.
2141
2142         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2143         * WebKitTestRunner/InjectedBundle/Target.pri:
2144         * qmake/mkspecs/features/default_post.prf:
2145         * qmake/mkspecs/features/webcore.prf:
2146
2147 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
2148
2149         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
2150         https://bugs.webkit.org/show_bug.cgi?id=75238
2151
2152         Reviewed by Antonio Gomes.
2153
2154         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
2155         it could initiate download directly if it has the download attribute in the link 
2156         and doesn't need to open new blank page for the target="_blank". Enabling this 
2157         feature in the BlackBerry porting also prepares for later blob feature implementation.
2158
2159         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
2160         for the BlackBerry porting.
2161
2162 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2163
2164         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
2165         https://bugs.webkit.org/show_bug.cgi?id=75475
2166
2167         Reviewed by Martin Robinson.
2168
2169         The problem is that the property blurb contains <a ping> and tree
2170         view uses gtk_tooltip_set_markup() internally, so we need to
2171         escape the text.
2172
2173         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2174         (browserSettingsDialogConstructed): Escape property blurb before
2175         storing it in the GtkTreeModel.
2176
2177 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
2178
2179         When showing results.html pass a correct URL to webbrowser.open
2180         https://bugs.webkit.org/show_bug.cgi?id=75438
2181
2182         Reviewed by Adam Barth.
2183
2184         * Scripts/webkitpy/common/system/filesystem.py:
2185         (file_path_as_url):
2186         * Scripts/webkitpy/common/system/filesystem_mock.py:
2187         (file_path_as_url):
2188         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2189         (test_file_path_as_url):
2190         * Scripts/webkitpy/layout_tests/port/base.py:
2191         (show_results_html_file):
2192         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2193         (test_show_results_html_file):
2194         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2195         (test_results_directory_relative):
2196
2197 2012-01-03  Ojan Vafai  <ojan@chromium.org>
2198
2199         shrink the header on the flakiness dashboard
2200         https://bugs.webkit.org/show_bug.cgi?id=65153
2201
2202         Reviewed by Adam Roben.
2203
2204         Move some of the "show" links to be to the right of the header
2205         instead of below the header when they content they're showing
2206         is hidden. That way we don't waste vertical space on them.
2207
2208         No new tests. This code is covered by existing tests.
2209
2210         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2211
2212 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2213
2214         Add a tool to analyze change logs
2215         https://bugs.webkit.org/show_bug.cgi?id=72243
2216
2217         Reviewed by Eric Seidel.
2218
2219         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
2220         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
2221         for visualizing json files.
2222
2223         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
2224         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
2225         generates json files, and N is the number of changelogs to parse.
2226
2227         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
2228         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
2229         * Scripts/webkitpy/tool/commands/__init__.py:
2230         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
2231         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
2232         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
2233         * Scripts/webkitpy/tool/steps/options.py:
2234
2235 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2236
2237         Add a tool to analyze change logs
2238         https://bugs.webkit.org/show_bug.cgi?id=72243
2239
2240         Reviewed by Eric Seidel.
2241
2242         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
2243         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
2244         for visualizing json files.
2245
2246         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
2247         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
2248         generates json files, and N is the number of changelogs to parse.
2249
2250         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
2251         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
2252         * Scripts/webkitpy/tool/commands/__init__.py:
2253         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
2254         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
2255         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
2256         * Scripts/webkitpy/tool/steps/options.py:
2257
2258 2012-01-03  Adam Roben  <aroben@apple.com>
2259
2260         Make Port subclasses override the operating_system method rather than setting an attribute
2261
2262         Without this patch, any use of Port.operating_system() within a port's __init__ method would
2263         return the default value ("mac"). This was confusing the version-checking logic inside
2264         ApplePort.__init__ on Windows.
2265
2266         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
2267         crashes on launch on Windows 7 SP1
2268
2269         Reviewed by Eric Seidel.
2270
2271         * Scripts/webkitpy/layout_tests/port/apple.py:
2272         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
2273
2274         * Scripts/webkitpy/layout_tests/port/base.py:
2275         (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
2276         should now override the operating_system method instead.
2277         (Port.operating_system): Changed to always return "mac". Subclasses should override to
2278         return something else.
2279
2280         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2281         (ChromiumLinuxPort.__init__):
2282         (ChromiumLinuxPort.operating_system):
2283         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2284         (ChromiumMacPort.__init__):
2285         (ChromiumMacPort.operating_system):
2286         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2287         (ChromiumWinPort.__init__):
2288         (ChromiumWinPort.operating_system):
2289         * Scripts/webkitpy/layout_tests/port/mac.py:
2290         (MacPort.__init__):
2291         (MacPort.operating_system):
2292         * Scripts/webkitpy/layout_tests/port/win.py:
2293         (WinPort.__init__):
2294         (WinPort.operating_system):
2295         Changed to override the operating_system method rather than setting the _operating_system
2296         attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
2297
2298         * Scripts/webkitpy/layout_tests/port/qt.py:
2299         (QtPort.__init__):
2300         (QtPort._path_to_webcore_library):
2301         Changed to use self.operating_system() instead of self._operating_system, for consistency
2302         with other Port-related code.
2303
2304         (QtPort.operating_system): Added this override of Port.operating_system that returns the
2305         value we determined in our __init__ method.
2306
2307         * Scripts/webkitpy/layout_tests/port/test.py:
2308         (TestPort.operating_system): Added this override of Port.operating_system that returns the
2309         value we determined in our __init__ method.
2310
2311         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2312         (PortTest.test_operating_system):
2313         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2314         (ChromiumLinuxPortTest.test_operating_system):
2315         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2316         (ChromiumMacPortTest.test_operating_system):
2317         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2318         (ChromiumWinPortTest.test_operating_system):
2319         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2320         (MacPortTest.test_operating_system):
2321         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2322         (QtPortTest.test_operating_system):
2323         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2324         (WinPortTest.test_operating_system):
2325         Test that all ports return the expected operating system string.
2326
2327 2012-01-03  Mario Sanchez Prada  <msanchez@igalia.com>
2328
2329         [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
2330         https://bugs.webkit.org/show_bug.cgi?id=75474
2331
2332         Reviewed by Philippe Normand.
2333
2334         * Scripts/run-gtk-tests: Ignore files whose name does not start
2335         with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
2336
2337 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
2338
2339         [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
2340         https://bugs.webkit.org/show_bug.cgi?id=75472
2341
2342         Reviewed by Tor Arne Vestbø.
2343
2344         * MiniBrowser/qt/MiniBrowser.pro:
2345         * MiniBrowser/qt/MiniBrowser.qrc:
2346         * MiniBrowser/qt/qml/BrowserWindow.qml:
2347         * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
2348
2349 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
2350
2351         [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
2352         https://bugs.webkit.org/show_bug.cgi?id=75471
2353
2354         Reviewed by Tor Arne Vestbø.
2355
2356         Add simple UI for JavaScript Alert dialogs. This patch also adds a
2357         simple DialogButton QML type and a Dialog QML type which will be
2358         reusable for other JavaScript dialogs.
2359
2360         * MiniBrowser/qt/MiniBrowser.qrc:
2361         * MiniBrowser/qt/qml/AlertDialog.qml: Added.
2362         * MiniBrowser/qt/qml/BrowserWindow.qml:
2363         * MiniBrowser/qt/qml/Dialog.qml: Added.
2364         * MiniBrowser/qt/qml/DialogButton.qml: Added.
2365
2366 2012-01-03  Rafael Brandao  <rafael.lobo@openbossa.org>
2367
2368         [Qt][WK2] MiniBrowser doesn't show url bar
2369         https://bugs.webkit.org/show_bug.cgi?id=75470
2370
2371         Reviewed by Tor Arne Vestbø.
2372
2373         * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
2374         on QtDeclarative (QTBUG-23422).
2375
2376 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2377
2378         [GTK] Simplify loader client WebKit2 GTK+ API
2379         https://bugs.webkit.org/show_bug.cgi?id=74605
2380
2381         Reviewed by Gustavo Noronha Silva.
2382
2383         * gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now
2384         private API.
2385
2386 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2387
2388         [Qt] Clean up detection of fontconfig
2389
2390         We decide in features.prf whether or not fontconfig is available, and
2391         set the HAVE_FONTCONFIG define accordingly. All leaf project files
2392         should use this define to decide whether or not to link against
2393         fontconfig, not do their own detection.
2394
2395         We don't need to add link_pkgconfig to CONFIG in each project file,
2396         as we selectivly enable that configuration in defaults_post when
2397         needed.
2398
2399         Reviewed by Ossy.
2400
2401         * DumpRenderTree/qt/DumpRenderTree.pro:
2402         * QtTestBrowser/QtTestBrowser.pro:
2403         * WebKitTestRunner/InjectedBundle/Target.pri:
2404         * qmake/mkspecs/features/unix/default_post.prf:
2405         * qmake/mkspecs/features/unix/default_pre.prf:
2406
2407 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2408
2409         [Qt] Introduce qmake replace function for the active build config
2410
2411         Reviewed by Ossy.
2412
2413         * qmake/mkspecs/features/default_post.prf:
2414         * qmake/mkspecs/features/functions.prf:
2415
2416 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2417
2418         [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()
2419         https://bugs.webkit.org/show_bug.cgi?id=75435
2420
2421         Reviewed by Martin Robinson.
2422
2423         * GNUmakefile.am: Make sure DRT links to X11.
2424         * WebKitTestRunner/GNUmakefile.am: Make sure WTR links to X11.
2425
2426 2011-12-04  Philippe Normand  <pnormand@igalia.com>
2427
2428         [WK2][GTK] WebSettings support in MiniBrowser
2429         https://bugs.webkit.org/show_bug.cgi?id=73773
2430
2431         Reviewed by Martin Robinson.
2432
2433         Patch heavily inspired from the WebKit GtkLauncher to support
2434         command-line WebSettings. Example: --enable-fullscreen=TRUE.
2435         The full list of options can be consulted with --help-websettings.
2436
2437         * MiniBrowser/gtk/main.c:
2438         (loadURI):
2439         (parseOptionEntryCallback):
2440         (isValidParameterType):
2441         (getOptionEntriesFromWebKitSettings):
2442         (addSettingsGroupToContext):
2443         (main):
2444
2445 2012-01-02  Philippe Normand  <pnormand@igalia.com>
2446
2447         [GTK] GtkLauncher settings improvements
2448         https://bugs.webkit.org/show_bug.cgi?id=75439
2449
2450         Reviewed by Martin Robinson.
2451
2452         * GtkLauncher/main.c:
2453         (filenameToURL): We can use NULL in C.
2454         (isValidParameterType): Utility function to filter GParamTypes
2455         that can be edited.
2456         (getOptionEntriesFromWebKitWebSettings): Avoid handling
2457         construct-only properties and use the isValidParameterType
2458         function. Makes the code a bit cleaner.
2459
2460 2012-01-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2461
2462         [EFL] Remove whitespace/declaration style exception
2463         https://bugs.webkit.org/show_bug.cgi?id=75424
2464
2465         Reviewed by David Levin.
2466
2467         Remove *whitespace/eclaration* style rule. However, EWebLauncher and MiniBrowser are EFL simple
2468         application. So, they still need to use EFL coding style.
2469
2470         * Scripts/webkitpy/style/checker.py:
2471
2472 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2473
2474         [GTK] Add a way to change web view settings in MiniBrowser
2475         https://bugs.webkit.org/show_bug.cgi?id=71568
2476
2477         Reviewed by Philippe Normand.
2478
2479         Add a preferences button to the toolbar that shows a dialog to
2480         change settings of the current web view. It uses a GtkTreeView
2481         with a custom cell renderer to support multiple types of values.
2482
2483         * MiniBrowser/gtk/BrowserCellRendererVariant.c: Added.
2484         (browserCellRendererVariantFinalize):
2485         (browserCellRendererVariantGetProperty):
2486         (browserCellRendererVariantSetModeForValue):
2487         (browserCellRendererVariantSetProperty):
2488         (browserCellRendererVariantGetRendererForValue):
2489         (browserCellRendererVariantCellRendererTextEdited):
2490         (browserCellRendererVariantCellRendererSpinEdited):
2491         (browserCellRendererVariantCellRendererActivate):
2492         (browserCellRendererVariantCellRendererRender):
2493         (browserCellRendererVariantCellRendererStartEditing):
2494         (browserCellRendererVariantCellRendererGetPreferredWidth):
2495         (browserCellRendererVariantCellRendererGetPreferredHeight):
2496         (browserCellRendererVariantCellRendererGetPreferredWidthForHeight):
2497         (browserCellRendererVariantCellRendererGetPreferredHeightForWidth):
2498         (browserCellRendererVariantCellRendererGetAlignedArea):
2499         (browser_cell_renderer_variant_init):
2500         (browser_cell_renderer_variant_class_init):
2501         (browser_cell_renderer_variant_new):
2502         * MiniBrowser/gtk/BrowserCellRendererVariant.h: Added.
2503         * MiniBrowser/gtk/BrowserSettingsDialog.c: Added.
2504         (cellRendererChanged):
2505         (browserSettingsDialogSetProperty):
2506         (browser_settings_dialog_init):
2507         (browserSettingsDialogConstructed):
2508         (browser_settings_dialog_class_init):
2509         (browser_settings_dialog_new):
2510         * MiniBrowser/gtk/BrowserSettingsDialog.h: Added.
2511         * MiniBrowser/gtk/BrowserWindow.c:
2512         (settingsCallback):
2513         (browser_window_init):
2514         * MiniBrowser/gtk/GNUmakefile.am:
2515         * MiniBrowser/gtk/browser-marshal.list: Added.
2516
2517 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2518
2519         [GTK] Implement create/ready-to-show/close signals in MiniBrowser
2520         https://bugs.webkit.org/show_bug.cgi?id=74711
2521
2522         Reviewed by Philippe Normand.
2523
2524         * MiniBrowser/gtk/BrowserWindow.c:
2525         (webViewClose): Destroy the window.
2526         (webViewReadyToShow): Use WindowProperties of the new view to
2527         setup and show the window.
2528         (webViewCreate): Create a new view and add it to a browser window.
2529         (browser_window_init):
2530         (browserWindowConstructed): Connect to WebKitWebView::create signal.
2531
2532 2011-12-31  Dan Bernstein  <mitz@apple.com>
2533
2534         MiniBrowser sets the WKView’s frame incorrectly
2535         https://bugs.webkit.org/show_bug.cgi?id=75393
2536
2537         Reviewed by Anders Carlsson.
2538
2539         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed Make Launchable build phase,
2540         which is not needed since the binray is linked with the frameworks search path set to the
2541         built products directory.
2542         * MiniBrowser/mac/BrowserWindowController.m:
2543         (-[BrowserWindowController awakeFromNib]): Changed to set the WKView’s frame to its
2544         container’s bounds rather than its frame.
2545         * MiniBrowser/mac/make-launchable.sh: Removed.
2546
2547 2011-12-29  Dan Bernstein  <mitz@apple.com>
2548
2549         debug-safari --no-saved-state fails to start the debugger
2550         https://bugs.webkit.org/show_bug.cgi?id=75374
2551
2552         Reviewed by Sam Weinig.
2553
2554         * Scripts/webkitdirs.pm:
2555         (execMacWebKitAppForDebugging): Pass the --args option to gdb so that it passes arguments to
2556         the executable being debugged.
2557
2558 2011-12-29  Sam Weinig  <sam@webkit.org>
2559
2560         It should be easier to iterate a Vector backwards
2561         https://bugs.webkit.org/show_bug.cgi?id=75359
2562
2563         Reviewed by Anders Carlsson.
2564
2565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2566         * TestWebKitAPI/TestWebKitAPI.gypi:
2567         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2568         Add new Vector test.
2569
2570         * TestWebKitAPI/Tests/Vector.cpp: Added.
2571         (TestWebKitAPI::TEST):
2572         Test Vector iterators, reverse_iterators and new reversed proxy.
2573
2574 2011-12-28  Dmitry Lomov  <dslomov@google.com>
2575
2576         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2577         https://bugs.webkit.org/show_bug.cgi?id=66509
2578         Just renames, merges and removal of dead code. Here are the list of renames:
2579           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2580           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2581           - WebWorkerBase merged into WebSharedWorkerImpl
2582           - NewWebWorkerBase renamed into WebWorkerBase
2583  
2584         Reviewed by David Levin.
2585
2586         * DumpRenderTree/chromium/TestWebWorker.h:
2587         (TestWebWorker::createWorker):
2588         * DumpRenderTree/chromium/WebViewHost.cpp:
2589         (WebViewHost::createWorker):
2590         * DumpRenderTree/chromium/WebViewHost.h:
2591
2592 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2593
2594         Unreviewed, rolling out r103785.
2595         http://trac.webkit.org/changeset/103785
2596         https://bugs.webkit.org/show_bug.cgi?id=75332
2597
2598         Broke builders; looks like clobbering didnt help (Requested by
2599         dslomov on #webkit).
2600
2601         * DumpRenderTree/chromium/TestWebWorker.h:
2602         (TestWebWorker::createWorker):
2603         * DumpRenderTree/chromium/WebViewHost.cpp:
2604         (WebViewHost::createWorker):
2605         * DumpRenderTree/chromium/WebViewHost.h:
2606
2607 2011-12-28  Dmitry Lomov  <dslomov@google.com>
2608
2609
2610         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2611         https://bugs.webkit.org/show_bug.cgi?id=66509
2612         Just renames, merges and removal of dead code. Here are the list of renames:
2613           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2614           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2615           - WebWorkerBase merged into WebSharedWorkerImpl
2616           - NewWebWorkerBase renamed into WebWorkerBase
2617  
2618         Reviewed by David Levin.
2619
2620         * DumpRenderTree/chromium/TestWebWorker.h:
2621         (TestWebWorker::createWorker):
2622         * DumpRenderTree/chromium/WebViewHost.cpp:
2623         (WebViewHost::createWorker):
2624         * DumpRenderTree/chromium/WebViewHost.h:
2625
2626 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2627
2628         Unreviewed, rolling out r103620.
2629         http://trac.webkit.org/changeset/103620
2630         https://bugs.webkit.org/show_bug.cgi?id=75316
2631
2632         Causes many crashes (Requested by abarth on #webkit).
2633
2634         * DumpRenderTree/chromium/LayoutTestController.cpp:
2635         (LayoutTestController::LayoutTestController):
2636         (LayoutTestController::reset):
2637         * DumpRenderTree/chromium/LayoutTestController.h:
2638         * DumpRenderTree/chromium/WebViewHost.cpp:
2639         * DumpRenderTree/chromium/WebViewHost.h:
2640
2641 2011-12-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2642
2643         Unreviewed, rolling out r103734.
2644         http://trac.webkit.org/changeset/103734
2645         https://bugs.webkit.org/show_bug.cgi?id=75278
2646
2647         Broke cr-mac (Requested by dslomov on #webkit).
2648
2649         * DumpRenderTree/chromium/TestWebWorker.h:
2650         (TestWebWorker::createWorker):
2651         * DumpRenderTree/chromium/WebViewHost.cpp:
2652         (WebViewHost::createWorker):
2653         * DumpRenderTree/chromium/WebViewHost.h:
2654
2655 2011-12-27  Dmitry Lomov  <dslomov@google.com>
2656
2657
2658         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2659         https://bugs.webkit.org/show_bug.cgi?id=66509
2660         Just renames, merges and removal of dead code. Here are the list of renames:
2661           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2662           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2663           - WebWorkerBase merged into WebSharedWorkerImpl
2664           - NewWebWorkerBase renamed into WebWorkerBase
2665  
2666         Reviewed by David Levin.
2667
2668         * DumpRenderTree/chromium/TestWebWorker.h:
2669         (TestWebWorker::createWorker):
2670         * DumpRenderTree/chromium/WebViewHost.cpp:
2671         (WebViewHost::createWorker):
2672         * DumpRenderTree/chromium/WebViewHost.h:
2673
2674 2011-12-27  Anders Carlsson  <andersca@apple.com>
2675
2676         Function should handle wrapping/unwrapping RefPtr and PassRefPtr
2677         https://bugs.webkit.org/show_bug.cgi?id=75266
2678
2679         Reviewed by Sam Weinig.
2680
2681         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2682         (TestWebKitAPI::Number::create):
2683         (TestWebKitAPI::Number::~Number):
2684         (TestWebKitAPI::Number::value):
2685         (TestWebKitAPI::Number::Number):
2686         (TestWebKitAPI::multiplyNumberByTwo):
2687         (TestWebKitAPI::TEST):
2688
2689 2011-12-24  Kentaro Hara  <haraken@chromium.org>
2690
2691         Add unittests for the C++ parser of prepare-ChangeLog
2692         https://bugs.webkit.org/show_bug.cgi?id=75191
2693
2694         Reviewed by Ryosuke Niwa.
2695
2696         cpp_unittests.cpp is the unittests for get_function_line_ranges_for_cpp()
2697         of prepare-ChangeLog.
2698
2699         * Scripts/prepare-ChangeLog:
2700         (get_function_line_ranges): Renames get_function_line_ranges_for_c()
2701         to get_function_line_ranges_for_cpp().
2702         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2703         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Added.
2704         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added.
2705         (func1):
2706         (func2):
2707         (func3):
2708         (func4):
2709         (func5):
2710         (func6):
2711         (func7):
2712         (func8):
2713         (func9):
2714         (func10):
2715         (func11):
2716         (func12):
2717         (func13):
2718         (func14):
2719         (func15):
2720         (funcOverloaded):
2721         (Class::func16):
2722         (Class1::Class2::func17):
2723         (Class2::func18):
2724         (Class2::func19):
2725         (Class2::func20):
2726         (Class2::func21):
2727         (Class2::func22):
2728         (func23):
2729         (func24):
2730         (Class2::func25):
2731         (Class1::func26):
2732         (Class2::func27):
2733         (Class3::func28):
2734         (Class7::operator+):
2735         (Class100::Class100):
2736         (Class101::~Class101):
2737         (Class102::Class102):
2738         (Class103::Class103):
2739         (Struct1::func29):
2740         (Struct2::func30):
2741         (NameSpace1::func30):
2742         (NameSpace1::NameSpace2::func31):
2743
2744 2011-12-24  Kentaro Hara  <haraken@chromium.org>
2745
2746         Add unittests for the Java parser of prepare-ChangeLog
2747         https://bugs.webkit.org/show_bug.cgi?id=75195
2748
2749         Reviewed by Ryosuke Niwa.
2750
2751         java_unittests.java is unittest cases for get_function_line_ranges_for_java()
2752         of prepare-ChangeLog.
2753
2754         * Scripts/prepare-ChangeLog:
2755         (get_function_line_ranges_for_java): Fixed a parser bug.
2756
2757             interface I
2758             {
2759                 void f()
2760                 {
2761                 }
2762             }
2763
2764         should be recognized as "I.f", and
2765
2766             class C interface I
2767             {
2768                 void f()
2769                 {
2770                 }
2771             }
2772
2773         should be recognized as "C.f".
2774         Without this patch, both are recognized as "I.f".
2775
2776         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2777         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Added.
2778         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests.java: Added.
2779         (Simple):
2780         (Simple.func1):
2781         (Simple.func2):
2782         (Simple.func3):
2783         (Simple.func4):
2784         (Simple.func5):
2785         (Simple.func6):
2786         (Simple.func7):
2787         (Simple.func8):
2788         (Simple.func9):
2789         (Simple.func10):
2790         (Simple.funcOverloaded):
2791         (Simple.func11):
2792         (Simple.func12):
2793         (Simple.func13):
2794         (Simple.func14):
2795         (Simple.func15):
2796         (Simple.func16):
2797         (Simple.func17):
2798         (Simple.func18):
2799         (Simple.func19):
2800         (Simple.func20):
2801         (Simple.func21):
2802         (Derived1):
2803         (Derived1.Derived1):
2804         (Derived1.func22):
2805         (Interface1):
2806         (Interface2):
2807         (Interface2.func23):
2808         (Derived2):
2809         (Derived2.Derived2):
2810         (Derived2.func23):
2811
2812 2011-12-24  Kentaro Hara  <haraken@chromium.org>
2813
2814         Add unittests for the Python parser of prepare-ChangeLog
2815         https://bugs.webkit.org/show_bug.cgi?id=75197
2816
2817         Reviewed by Ryosuke Niwa.
2818
2819         python_unittests.py is the unittest for get_function_line_ranges_for_python()
2820         of prepare-ChangeLog. The unittest just contains classes and defs that are not nested.
2821         This is because the current python parser is wrong, and it cannot correctly parse nested
2822         classes and defs (even one def in a class), nor class inheritance.
2823         We will fix it in another patch.
2824
2825         * Scripts/prepare-ChangeLog:
2826         (get_function_line_ranges_for_python): Ignores comment lines that starts from #.
2827         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2828         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Added.
2829         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py: Added.
2830         (func1):
2831         (func2):
2832         (func3):
2833         (funcInsideComment):
2834         (func4):
2835         (func5):
2836         (func6):
2837         (funcOverloaded):
2838         (Class1):
2839
2840 2011-12-24  Dan Bernstein  <mitz@apple.com>
2841
2842         Set SHARED_PRECOMPS_DIR when Xcode is set to use a custom build product path.
2843
2844         Reviewed by Anders Carlsson.
2845
2846         * Scripts/webkitdirs.pm:
2847         (determineBaseProductDir):
2848
2849 2011-12-24  Dan Bernstein  <mitz@apple.com>
2850
2851         Make build-webkit aware of additional Xcode build location defaults.
2852
2853         Reviewed by Anders Carlsson.
2854
2855         * Scripts/webkitdirs.pm:
2856         (determineXcodeVersion): Added. This was previously in determineBaseProductDir().
2857         (readXcodeUserDefault): Added. Factored out from determineBaseProductDir().
2858         (determineBaseProductDir): Changed to check for a custom build location
2859         style specified as an absolute location.
2860
2861 2011-12-24  Ryosuke Niwa  <rniwa@webkit.org>
2862
2863         Unreviewed, rolling out r103619.
2864         http://trac.webkit.org/changeset/103619
2865         https://bugs.webkit.org/show_bug.cgi?id=66509
2866
2867         Broke chromium clang build
2868
2869         * DumpRenderTree/chromium/TestWebWorker.h:
2870         (TestWebWorker::createWorker):
2871         * DumpRenderTree/chromium/WebViewHost.cpp:
2872         (WebViewHost::createWorker):
2873         * DumpRenderTree/chromium/WebViewHost.h:
2874
2875 2011-12-23  Daniel Bates  <dbates@webkit.org>
2876
2877         Provide option to disable Mac OS 10.7 application resume when using
2878         {debug, run}-{safari, minibrowser, test-runner, test-webkit-api}, and run-webkit-app
2879         https://bugs.webkit.org/show_bug.cgi?id=66902
2880
2881         Reviewed by David Kilzer.
2882
2883         Add an optional command line argument --no-saved-state to disable
2884         application resume (state restoration) for the session on Mac OS 10.7.
2885
2886         For instance, when debugging an issue in Safari it is useful to be able
2887         to temporarily disable application resume. Currently you can disable
2888         application resume when launching Safari from within Xcode. We should
2889         expose a similar option in our command line tools.
2890
2891         * Scripts/debug-minibrowser: Call printHelpAndExitForRunAndDebugWebKitAppIfNeeded()
2892         to print a help message and exit() if the command line argument --help was given.
2893         * Scripts/debug-safari: Ditto.
2894         * Scripts/debug-test-runner: Ditto.
2895         * Scripts/run-minibrowser: Ditto.
2896         * Scripts/run-safari: Ditto.
2897         * Scripts/run-test-runner: Ditto.
2898         * Scripts/run-test-webkit-api: Ditto.
2899         * Scripts/run-webkit-app: Ditto.
2900         * Scripts/webkitdirs.pm:
2901         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Added.
2902         (argumentsForRunAndDebugMacWebKitApp): Added.
2903         (runMacWebKitApp): If the --no-saved-state command line argument was given then
2904         disable application resume for the session.
2905         (execMacWebKitAppForDebugging): Ditto.
2906
2907 2011-12-23  Dmitry Lomov  <dslomov@google.com>
2908
2909         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2910         https://bugs.webkit.org/show_bug.cgi?id=66509
2911         Just renames, merges and removal of dead code. Here are the list of renames:
2912           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2913           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2914           - WebWorkerBase merged into WebSharedWorkerImpl
2915           - NewWebWorkerBase renamed into WebWorkerBase
2916  
2917         Reviewed by David Levin.
2918
2919         * DumpRenderTree/chromium/TestWebWorker.h:
2920         (TestWebWorker::createWorker):
2921         * DumpRenderTree/chromium/WebViewHost.cpp:
2922         (WebViewHost::createWorker):
2923         * DumpRenderTree/chromium/WebViewHost.h:
2924
2925 2011-12-23  Kentaro Hara  <haraken@chromium.org>
2926
2927         Let parser_unittests.pl call different language parsers
2928         https://bugs.webkit.org/show_bug.cgi?id=75081
2929
2930         Reviewed by David Kilzer.
2931
2932         We introduced parser_unittests.pl in bug 74994 , but it is implemented
2933         to always call get_function_line_ranges_for_perl(). In order to enable unittests
2934         for other languages, this patch lets parser_unittests.pl call different language
2935         parsers depending on the languages.
2936
2937         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
2938
2939         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2940
2941 2011-12-22  Adam Roben  <aroben@apple.com>
2942
2943         Snow Leopard test fix
2944
2945         * Scripts/webkitpy/test/main.py:
2946         (Tester.run_tests): Python 2.6.1 doesn't seem to like specifying testRunner=None to
2947         unittest.main, even though that's the default. So now we explicitly specify a
2948         TextTestRunner.
2949
2950 2011-12-22  Chris Fleizach  <cfleizach@apple.com>
2951
2952         AX: attributed strings do not include AXHeading information when a link is contained within the heading
2953         https://bugs.webkit.org/show_bug.cgi?id=75059
2954
2955         Reviewed by Darin Adler.
2956
2957         Support the ability to check if an arbitrary attribute is present within an
2958         attributed string that can be retrieved through an AccessibilityTextMarkerRange.
2959
2960         * DumpRenderTree/AccessibilityUIElement.cpp:
2961         (attributedStringForTextMarkerRangeContainsAttributeCallback):
2962         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2963         (AccessibilityUIElement::getJSClass):
2964         * DumpRenderTree/AccessibilityUIElement.h:
2965         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2966         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2967         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2968         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2969         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2970         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2971         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2972         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2973
2974 2011-12-22  David Kilzer  <ddkilzer@apple.com>
2975
2976         run-api-tests: runAllTests() and runTest() should not use global variables
2977
2978         Reviewed by Adam Roben.
2979
2980         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2981
2982         * Scripts/run-api-tests:
2983         (runTestsBySuite): Rename from runAllTests().  Add arguments for
2984         list of tests and $verbose.
2985         (runTest): Add $verbose argument.
2986
2987 2011-12-22  David Kilzer  <ddkilzer@apple.com>
2988
2989         run-api-tests: inline runAllTestsInSuite() into runAllTests()
2990
2991         Reviewed by Adam Roben.
2992
2993         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2994
2995         In order to make it easy to run one or more individual suites,
2996         or one more individual tests, it's easier to call a single
2997         method with different data structures than individual methods.
2998
2999         * Scripts/run-api-tests:
3000         (runAllTests): Inline runAllTestsInSuite().
3001
3002 2011-12-22  Adam Roben  <aroben@apple.com>
3003
3004         Add a --xml flag to test-webkitpy
3005
3006         test-webkitpy --xml will, in addition to providing the standard text output on stdout, write
3007         JUnit-style XML files to a test-webkitpy-xml-reports subdirectory in the working directory.
3008         This is useful for working with tools that consume JUnit-style XML files.
3009
3010         Fixes <http://webkit.org/b/75090> Would like a way to generate JUnit-style XML files when
3011         running test-webkitpy
3012
3013         Reviewed by Darin Adler.
3014
3015         * Scripts/webkitpy/test/main.py:
3016         (Tester.run_tests): If the --xml flag is passed, create an XMLTestRunner and pass it to
3017         unittest.main(). Otherwise pass no test runner so that unittest will choose its own default.
3018
3019         * Scripts/webkitpy/thirdparty/__init__.py:
3020         (AutoinstallImportHook.find_module):
3021         (AutoinstallImportHook._install_xmlrunner):
3022         Added code to install unittest-xml-reporting as webkitpy.thirdparty.autoinstalled.xmlrunner.
3023         This change is untested because it's basically impossible to get a test to pass when --xml
3024         is passed to test-webkitpy (because xmlrunner will already have been imported by the time
3025         the test runs).
3026
3027 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3028
3029         TestWebKitAPI: initialize the main thread before running tests
3030         <http://webkit.org/b/75064>
3031
3032         Reviewed by Adam Roben.
3033
3034         * TestWebKitAPI/TestsController.cpp:
3035         (TestWebKitAPI::TestsController::TestsController): Call
3036         WTF::initializeMainThread() to prevent assertions in Debug
3037         builds.
3038
3039 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3040
3041         run-api-tests: dumpAllTests() should not use global variables
3042
3043         Reviewed by Adam Roben.
3044
3045         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3046
3047         * Scripts/run-api-tests: Renamed $dump to $dumpTests.
3048         (dumpTestsBySuite): Rename from dumpAllTests() and pass in
3049         global data as an argument.  Sort suite names and test names
3050         alphabetically to match output when running tests.
3051
3052 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
3053
3054         [BlackBerry] Enable blob for the BlackBerry porting
3055         https://bugs.webkit.org/show_bug.cgi?id=75074
3056
3057         Reviewed by George Staikos.
3058
3059         * Scripts/build-webkit:
3060
3061 2011-12-22  Kentaro Hara  <haraken@chromium.org>
3062
3063         Add unittests for the Perl parser of prepare-ChangeLog
3064         https://bugs.webkit.org/show_bug.cgi?id=74994
3065
3066         Reviewed by David Kilzer.
3067
3068         This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
3069
3070         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
3071
3072         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
3073         Runs unittests specified in @testFiles.
3074         You can reset expected results by specifying a --reset-results option.
3075         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
3076         Contains simple methods.
3077         (func1):
3078         (func2):
3079         (func3):
3080         (func4):
3081         (func5):
3082         (func6):
3083         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
3084         This test result is generated by the --reset-results option.
3085
3086 2011-12-21  Eric Seidel  <eric@webkit.org>
3087
3088         Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
3089         so that they appear in the bugzilla autocomplete CC list.
3090         I also removed the "radar" irc nick (which I believe does not exist)
3091         and removed the uneeded [] around the radar bugzilla email.
3092
3093         Unreviewed.
3094
3095         * Scripts/webkitpy/common/config/committers.py:
3096
3097 2011-12-21  Daniel Bates  <dbates@rim.com>
3098
3099         Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
3100         https://bugs.webkit.org/show_bug.cgi?id=74985
3101
3102         Reviewed by Eric Seidel.
3103
3104         * Scripts/build-jsc:
3105         * Scripts/webkitdirs.pm:
3106         (cmakeBasedPortName): Added.
3107
3108 2011-12-21  Daniel Bates  <dbates@rim.com>
3109
3110         Extract BlackBerry CMake arguments from build-webkit into separate function
3111         https://bugs.webkit.org/show_bug.cgi?id=74981
3112
3113         Reviewed by Rob Buis.
3114
3115         Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
3116         the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
3117         and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
3118         This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
3119         that we can pass them to the CMake build system when building JavaScriptCore.
3120
3121         * Scripts/build-webkit: Move construction of CMake argument list from here to
3122         webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
3123         since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
3124         call it from build-webkit.
3125         * Scripts/webkitdirs.pm:
3126         (blackberryCMakeArguments): Added.
3127         (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
3128         BlackBerry port.
3129
3130 2011-12-21  Daniel Bates  <dbates@webkit.org>
3131
3132         Extract WinCE CMake arguments from build-webkit into separate function
3133         https://bugs.webkit.org/show_bug.cgi?id=74983
3134
3135         Reviewed by Rob Buis.
3136
3137         Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
3138         WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
3139         This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
3140         that we can pass it to the CMake build system when building JavaScriptCore.
3141
3142         * Scripts/build-webkit:
3143         * Scripts/webkitdirs.pm:
3144         (cmakeBasedPortArguments): Added.
3145
3146 2011-12-21  Kentaro Hara  <haraken@chromium.org>
3147
3148         In prepare-ChangeLog, replace constant global variables with "use constant"
3149         https://bugs.webkit.org/show_bug.cgi?id=74992
3150
3151         Reviewed by Ryosuke Niwa.
3152
3153         This patch replaces the following constant global variables with "use constant"s.
3154             - $changeLogTimeZone
3155             - $SVN
3156             - $GIT
3157             - %supportedTestExtensions
3158
3159         * Scripts/prepare-ChangeLog:
3160         (changeLogNameFromArgs):
3161         (changeLogEmailAddressFromArgs):
3162         (resolveConflictedChangeLogs):
3163         (generateNewChangeLogs):
3164         (diffCommand):
3165         (statusCommand):
3166         (createPatchCommand):
3167         (findOriginalFileFromSvn):
3168         (determinePropertyChanges):
3169         (generateFileList):
3170         (reviewerAndDescriptionForGitCommit):
3171
3172 2011-12-20  Dirk Pranke  <dpranke@chromium.org>
3173
3174         nrwt: rename field references from _fs to _filesystem
3175         https://bugs.webkit.org/show_bug.cgi?id=74898
3176
3177         Reviewed by Adam Barth.
3178
3179         This is a simple cleanup; most of the code uses
3180         self._filesystem, but some used self._fs; this change renames
3181         the latter to the former to be more consistent.
3182
3183         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3184         (Manager.__init__):
3185         (Manager.collect_tests):
3186         (Manager._strip_test_dir_prefix):
3187         (Manager._split_into_chunks_if_necessary):
3188         (Manager.results_directory):
3189         (Manager._clobber_old_results):
3190         (Manager._upload_json_files):
3191         (Manager.print_config):
3192         (Manager._copy_results_html_file):
3193         (Manager._show_results_html_file):
3194         (Manager._log_worker_stack):
3195         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3196         (JSONLayoutResultsGenerator._normalize_results_json):
3197         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3198         (JSONResultsGeneratorBase.__init__):
3199         (JSONResultsGeneratorBase.generate_json_output):
3200         (JSONResultsGeneratorBase.generate_times_ms_file):
3201         (JSONResultsGeneratorBase.upload_json_files):
3202         (JSONResultsGeneratorBase._get_svn_revision):
3203         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3204         (Base.__init__):
3205
3206 2011-12-20  Kentaro Hara  <haraken@chromium.org>
3207
3208         Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
3209         https://bugs.webkit.org/show_bug.cgi?id=74836
3210
3211         Reviewed by David Kilzer.
3212
3213         webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
3214         This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
3215         for unit-testing of other Perl scripts. We are planning to use it for unit-testing
3216         of prepare-ChangeLog.
3217
3218         Using LoadAsModule.pm, you can load a Perl script as follows.
3219         The first argument is the arbitrary package name you want to use, and the second argument
3220         is the name of the Perl script you want to load.
3221
3222             use LoadAsModule qw(RunLeaks run-leaks);
3223             RunLeaks::someFunctionDefinedInRunLeaks(...);
3224
3225         Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
3226                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
3227                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
3228
3229         * Scripts/webkitperl/LoadAsModule.pm: Added.
3230         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
3231         (import):
3232         (readFile):
3233         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
3234         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
3235         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
3236
3237 2011-12-20  Balazs Kelemen  <kbalazs@webkit.org>
3238
3239         [Qt] WK2 Debugging quirks need some improvement
3240         https://bugs.webkit.org/show_bug.cgi?id=74859
3241
3242         Reviewed by Simon Hausmann.
3243
3244         Improvements added to make debugging WebKit2 more
3245         confortable and efficient:
3246         1. Unify debugging quirks. From now all of them are controlled
3247         by the QT_WEBKIT2_DEBUG environment variable.
3248         2. Disable crash handlers for WebKitTestRunner if debugging quirks
3249         are used to make it possible to use postmortem debugging via core dumps
3250         which is extremely useful for debugging bugs triggered by layout tests.
3251         3. Disable test timeout for WebKitTestRunner if debugging quirks
3252         are used because that makes debugging impossible.
3253
3254         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3255         (WTR::InjectedBundle::platformInitialize):
3256         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3257         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3258         * WebKitTestRunner/qt/TestControllerQt.cpp:
3259         (WTR::TestController::platformRunUntil):
3260
3261 2011-12-20  Rafael Brandao  <rafael.lobo@openbossa.org>
3262
3263         [Qt][WK2] Implement favicon support
3264         https://bugs.webkit.org/show_bug.cgi?id=71082
3265
3266         Reviewed by Simon Hausmann.
3267
3268         A favorite icon was added on MiniBrowser's url bar as example.
3269         We display a default icon when the page doesn't have an icon ready.
3270
3271         * MiniBrowser/qt/MiniBrowser.qrc:
3272         * MiniBrowser/qt/icons/favicon.png: Added.
3273         * MiniBrowser/qt/qml/BrowserWindow.qml:
3274
3275 2011-12-19  Sam Weinig  <sam@webkit.org>
3276
3277         Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
3278         https://bugs.webkit.org/show_bug.cgi?id=74907
3279
3280         Reviewed by Dan Bernstein.
3281
3282         Add ScrollByLineCommands API test.
3283
3284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3285         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
3286         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
3287
3288 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3289
3290         webkitpy: remove port.executive, port.filesystem, port.user properties
3291         https://bugs.webkit.org/show_bug.cgi?id=74896
3292
3293         Reviewed by Eric Seidel.
3294
3295         Following on the refactoring of the port and host objects, this
3296         removes the public executive, filesystem, and user properties
3297         from the Port interface (protected versions of executive and
3298         filesystem still exist). There is still some more clean up to
3299         make the code more consistent and rearrange some other files to
3300         talk to Hosts directly instead of getting them off of the Port
3301         class.
3302
3303         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3304         (Manager.__init__):
3305         (Manager.results_directory):
3306         (Manager._log_worker_stack):
3307         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3308         (ManagerTest.test_fallback_path_in_config):
3309         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3310         (_InlineManager.start_worker):
3311         (_InlineWorkerConnection.__init__):
3312         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3313         (Worker.safe_init):
3314         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3315         (TestConfiguration.from_port):
3316         * Scripts/webkitpy/layout_tests/port/base.py:
3317         (Port.__init__):
3318         (Port.tests):
3319         (Port.show_results_html_file):
3320         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3321         (PortTest.test_layout_tests_skipping):
3322         (PortTest.test_test_dirs):
3323         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3324         (_set_up_derived_options):
3325         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3326         (PerfTestsRunner.__init__):
3327         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3328         (HtmlGenerator.__init__):
3329         (HtmlGenerator.show_html):
3330         (real_main):
3331         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3332         (TestHtmlGenerator.make_generator):
3333
3334 2011-12-19  Daniel Bates  <dbates@webkit.org>
3335
3336         Pass command line arguments to GDB when debugging a Mac WebKit application
3337         https://bugs.webkit.org/show_bug.cgi?id=72829
3338
3339         Reviewed by David Kilzer.
3340
3341         Pass through any command line arguments given to debug-{safari, minibrowser}
3342         to GDB so that they may influence the application instance launched by GDB.
3343
3344         * Scripts/webkitdirs.pm:
3345         (execMacWebKitAppForDebugging):
3346
3347 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3348
3349         webkitpy: remove executive,filesystem,user parameters from Port constructor
3350         https://bugs.webkit.org/show_bug.cgi?id=74878
3351
3352         Reviewed by Eric Seidel.
3353
3354         This change concludes the refactoring that makes Host a required
3355         parameter for Port and ensures that all access to filesystem,
3356         executives, etc. is going through the Host.
3357
3358         * Scripts/webkitpy/layout_tests/port/base.py:
3359         (Port.__init__):
3360
3361 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3362
3363         webkitpy: finish refactoring port classes to make a host mandatory
3364         https://bugs.webkit.org/show_bug.cgi?id=74566
3365
3366         Reviewed by Eric Seidel.
3367
3368         This change makes all Port objects take a required (System)Host
3369         parameter, and updates the TestPort object to no longer create a
3370         mock filesystem or add files to the existing filesystem by
3371         default.
3372
3373         * Scripts/webkitpy/layout_tests/port/base.py:
3374         (Port.__init__):
3375         * Scripts/webkitpy/layout_tests/port/factory.py:
3376         (PortFactory.__init__):
3377         (PortFactory._get_kwargs):
3378         * Scripts/webkitpy/layout_tests/port/test.py:
3379         (TestInstance.__init__):
3380         (TestPort.__init__):
3381         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3382         (passing_run):
3383         (logging_run):
3384         (get_tests_run):
3385         (MainTest.test_single_file):
3386         (MainTest.test_stderr_is_saved):
3387         (MainTest.test_test_list):
3388         (MainTest.test_test_list_with_prefix):
3389         (MainTest.test_missing_and_unexpected_results):
3390         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
3391         (MainTest.test_crash_with_stderr):
3392         (MainTest.test_no_image_failure_with_image_diff):
3393         (MainTest.test_crash_log):
3394         (MainTest.test_web_process_crash_log):
3395         (MainTest.test_exit_after_n_failures_upload):
3396         (MainTest.test_results_directory_absolute):
3397         (MainTest.test_results_directory_relative):
3398         (MainTest.test_retries_directory):
3399         (MainTest.test_tolerance.get_port_for_run):
3400         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
3401         (EndToEndTest.test_end_to_end):
3402         (EndToEndTest.test_reftest_with_two_notrefs):
3403         (RebaselineTest.test_reset_results):
3404         (RebaselineTest.test_missing_results):
3405         (RebaselineTest.test_new_baseline):
3406         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3407         (Rebaseliner.__init__):
3408         (main):
3409         (real_main):
3410         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3411         (test_host_port_and_filesystem):
3412         (TestRebaseliner.make_rebaseliner):
3413         (TestRealMain.test_all_platforms):
3414         (TestHtmlGenerator.make_generator):
3415
3416 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3417
3418         webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
3419         https://bugs.webkit.org/show_bug.cgi?id=74562
3420
3421         Reviewed by Eric Seidel.
3422
3423         Apart from a minor change to style/checkers/test_expectations.py
3424         to take a host as a parameter to a TestExpectationsChecker(),
3425         there are only refactoring changes to unit tests here.
3426
3427         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3428         (TestResultWriterTest.test_reftest_diff_image):
3429         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3430         (JSONGeneratorTest._test_json_generation):
3431         (JSONGeneratorTest.test_test_timings_trie):
3432         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3433         (Base.__init__):
3434         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3435         (PortTest.make_port):
3436         (PortTest.test_layout_tests_skipping):
3437         (PortTest.test_test_dirs):
3438         (PortTest.test_additional_platform_directory):
3439         (PortTest.test_uses_test_expectations_file):
3440         (PortTest.test_find_no_paths_specified):
3441         (PortTest.test_find_one_test):
3442         (PortTest.test_find_glob):
3443         (PortTest.test_find_with_skipped_directories):
3444         (PortTest.test_find_with_skipped_directories_2):
3445         (PortTest.test_parse_reftest_list):
3446         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3447         (DryRunPort.__init__):
3448         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3449         (FactoryTest.setUp):
3450         (FactoryTest.tearDown):
3451         (FactoryTest.assert_port):
3452         (FactoryTest.assert_platform_port):
3453         (FactoryTest.test_unknown_specified):
3454         (FactoryTest.test_unknown_default):
3455         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3456         (GetGoogleChromePortTest._verify_expectations_overrides):
3457         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3458         (MockDRTPortTest.make_port):
3459         (MockDRTTest.assertTest):
3460         (MockDRTTest.test_main):
3461         (MockChromiumDRTTest.test_pixeltest__fails):
3462         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3463         (QtPortTest._assert_search_path):
3464         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3465         (TestWebKitPort.__init__):
3466         (WebKitPortTest.test_skipped_directories_for_symbols):
3467         (test_skipped_directories_for_features):
3468         (test_skipped_layout_tests):
3469         (test_skipped_file_search_paths):
3470         (test_root_option):
3471         (test_test_expectations):
3472         (test_build_driver):
3473         (test_linux_distro_detection):
3474         (test_apache_config_file_name_for_platform):
3475         (test_path_to_apache_config_file):
3476         (WebKitDriverTest.test_read_block):
3477         * Scripts/webkitpy/style/checkers/test_expectations.py:
3478         (TestExpectationsChecker.__init__):
3479         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3480         (TestExpectationsTestCase._expect_port_for_expectations_path):
3481         (TestExpectationsTestCase.assert_lines_lint):
3482         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3483         (get_test_config.TestMacPort):
3484
3485 2011-12-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
3486
3487         [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
3488         https://bugs.webkit.org/show_bug.cgi?id=74854
3489
3490         Reviewed by Csaba Osztrogonác.
3491
3492         Since r101052, libewebkit.so is built in a different location, so we
3493         need to adjust the path returned by builtDylibPathForName.
3494
3495         usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
3496         port also respects Release/Debug configurations.
3497
3498         These changes should make run-launcher finally work correctly with
3499         webkit-efl.
3500
3501         * Scripts/webkitdirs.pm:
3502         (usesPerConfigurationBuildDirectory):
3503         (builtDylibPathForName):
3504
3505 2011-12-19  Simon Hausmann  <simon.hausmann@nokia.com>
3506
3507         [Qt][WK2] Add support for modal event loop processing for WTR
3508         https://bugs.webkit.org/show_bug.cgi?id=74852
3509
3510         Reviewed by Kenneth Rohde Christiansen.
3511
3512         Rewrote event loop processing: Instead of terminating the event loop
3513         in notifyDone() - something no other platform does - we now respect the
3514         "bool& condition" parameter passed to platformRunUntil. This ensures
3515         proper termination even when the condition is changed from within a
3516         nested event loop, because only when we _exit_ from the nested event
3517         loop we will check the condition and terminate the test properly.
3518
3519         In addition this patch implements TestController::runModal by means of
3520         a nested event loop, which is passed to the platform webview that is
3521         supposed to be modal. It is that view's responsibility to exit the
3522         loop, upon destruction. I believe that's similar to how it works on the Mac,
3523         where it doesn't seem that NSApp's runModalForWindow is terminate via
3524         abort/stopModal but simply because the window is closed.
3525
3526         * WebKitTestRunner/PlatformWebView.h:
3527         (WTR::PlatformWebView::setModalEventLoop):
3528         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3529         (WTR::PlatformWebView::PlatformWebView):
3530         (WTR::PlatformWebView::~PlatformWebView):
3531         * WebKitTestRunner/qt/TestControllerQt.cpp:
3532         (WTR::TestController::notifyDone):
3533         (WTR::TestController::platformRunUntil):
3534         (WTR::TestController::runModal):
3535
3536 2011-12-18  Kentaro Hara  <haraken@chromium.org>
3537
3538         REGRESSION(r103149): prepare-ChangeLog outputs a warning
3539         https://bugs.webkit.org/show_bug.cgi?id=74808
3540
3541         Reviewed by David Kilzer.
3542
3543         Added the prototype declaration of main() to avoid warning messages.
3544         Sorted subroutine declarations in the alphabetical order.
3545
3546         * Scripts/prepare-ChangeLog:
3547
3548 2011-12-17  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3549
3550         [Qt] Fix QtTestBrowser compilation with QtWidgets module
3551         https://bugs.webkit.org/show_bug.cgi?id=74791
3552
3553         Reviewed by Andreas Kling.
3554
3555         * QtTestBrowser/QtTestBrowser.pro:
3556
3557 2011-12-17  Kentaro Hara  <haraken@chromium.org>
3558
3559         Remove top-level code completely from prepare-ChangeLog
3560         https://bugs.webkit.org/show_bug.cgi?id=74698
3561
3562         Reviewed by Darin Adler.
3563
3564         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
3565         This patch just moves all top-level code into main().
3566
3567         * Scripts/prepare-ChangeLog:
3568         (main):
3569
3570 2011-12-16  Dean Jackson  <dino@apple.com>
3571
3572         Move webkit-bug-importer to Contributor. It won't
3573         autocomplete as an Account.
3574         See https://bugs.webkit.org/show_bug.cgi?id=74739
3575         for some discussion.
3576
3577         Unreviewed.
3578
3579         * Scripts/webkitpy/common/config/committers.py:
3580
3581 2011-12-16  Dean Jackson  <dino@apple.com>
3582
3583         Add webkit-bug-importer@group.apple.com to accounts
3584         so that it autocompletes in bugzilla.
3585
3586         Unreviewed.
3587
3588         * Scripts/webkitpy/common/config/committers.py:
3589
3590 2011-12-16  Philippe Normand  <pnormand@igalia.com>
3591
3592         Unreviewed, skipping 3 failing GTK API tests.
3593
3594         * Scripts/run-gtk-tests:
3595
3596 2011-12-16  Philippe Normand  <pnormand@igalia.com>
3597
3598         Unreviewed, GTK API tests build fix attempt.
3599
3600         * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
3601
3602 2011-12-16  Philippe Normand  <pnormand@igalia.com>
3603
3604         Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
3605
3606         * Scripts/run-gtk-tests:
3607
3608 2011-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
3609
3610         [Qt] Fix the build for newer Qt5
3611         https://bugs.webkit.org/show_bug.cgi?id=74703
3612
3613         Reviewed by Csaba Osztrogonác.
3614
3615         * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
3616         * DumpRenderTree/qt/EventSenderQt.cpp:
3617         (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
3618         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
3619         (WTR::EventSenderProxy::sendTouchEvent):
3620         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3621         (MiniBrowserApplication::sendTouchEvent): Ditto.
3622         (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
3623
3624 2011-12-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3625
3626         [Qt] Detect and force clean build when feature defines are added
3627
3628         Reviewed by Ossy.
3629
3630         https://bugs.webkit.org/show_bug.cgi?id=74689
3631
3632         * Scripts/webkitdirs.pm:
3633
3634 2011-12-16  Kentaro Hara  <haraken@chromium.org>
3635