23b16edb79e6bab303936f3a5a3980ffe2a61353
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-10  JF Bastien  <jfbastien@apple.com>
2
3         Poison small JSObject derivatives which only contain pointers
4         https://bugs.webkit.org/show_bug.cgi?id=181483
5         <rdar://problem/36407127>
6
7         Reviewed by Mark Lam.
8
9         Test the new move-assign and move-copy from unique_ptr, as well as
10         nullptr_t ctors.
11
12         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
13         (TestWebKitAPI::TEST):
14         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
15         (TestWebKitAPI::TEST):
16         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
17         (TestWebKitAPI::TEST):
18
19 2018-01-10  Chris Dumez  <cdumez@apple.com>
20
21         Multiple http/wpt/beacon/contentextensions/ test are flaky.
22         https://bugs.webkit.org/show_bug.cgi?id=179256
23         <rdar://problem/35401978>
24
25         Reviewed by Alex Christensen.
26
27         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
28         instance gets its own folder to avoid conflicts and flakiness.
29
30         * WebKitTestRunner/mac/TestControllerMac.mm:
31         (WTR::TestController::platformConfigureViewForTest):
32
33 2018-01-10  Tim Horton  <timothy_horton@apple.com>
34
35         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
36         https://bugs.webkit.org/show_bug.cgi?id=181269
37         <rdar://problem/35110344>
38
39         Reviewed by Simon Fraser.
40
41         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
42         (WTR::UIScriptController::beginBackSwipe):
43         (WTR::UIScriptController::completeBackSwipe):
44         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
45         (WTR::UIScriptController::beginBackSwipe):
46         (WTR::UIScriptController::completeBackSwipe):
47         (WTR::UIScriptController::overridePreference):
48         (WTR::UIScriptController::replaceTextAtRange):
49         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
50         (WTR::PlatformWebView::setNavigationGesturesEnabled):
51         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
52         (WTR::UIScriptController::beginBackSwipe):
53         (WTR::UIScriptController::completeBackSwipe):
54         Implement beginBackSwipe and completeBackSwipe on iOS (they already
55         exist on Mac) in terms of the new WKWebView testing SPI.
56
57 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
58
59         REGRESSION (r226715): ignore WARNING output in linter tests
60         https://bugs.webkit.org/show_bug.cgi?id=181486
61         <rdar://problem/36408847>
62
63         Reviewed by Aakash Jain.
64
65         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
66
67         * Scripts/webkitpy/common/system/outputcapture.py:
68         (OutputCapture.__init__): Pass logging level to be captured.
69         * Scripts/webkitpy/style/main_unittest.py:
70         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
71         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
72         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
73         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
74         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
75         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
76         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
77         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
78
79 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
80
81         Add a JSCOnly MIPS buildbot
82         https://bugs.webkit.org/show_bug.cgi?id=181487
83
84         Reviewed by Michael Catanzaro.
85
86         Add the new bot configs definitions for the master and update the unit tests.
87
88         * BuildSlaveSupport/build.webkit.org-config/config.json:
89         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
90
91 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
92
93         REGRESSION (r226715): don't re-check number of simulators in child processes
94         https://bugs.webkit.org/show_bug.cgi?id=181484
95         <rdar://problem/36407151>
96
97         Reviewed by Aakash Jain.
98
99         * Scripts/webkitpy/port/ios_simulator.py:
100         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
101         are already initialized.
102
103 2018-01-10  Commit Queue  <commit-queue@webkit.org>
104
105         Unreviewed, rolling out r226667 and r226673.
106         https://bugs.webkit.org/show_bug.cgi?id=181488
107
108         This caused a flaky crash. (Requested by mlewis13 on #webkit).
109
110         Reverted changesets:
111
112         "CodeBlocks should be in IsoSubspaces"
113         https://bugs.webkit.org/show_bug.cgi?id=180884
114         https://trac.webkit.org/changeset/226667
115
116         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
117         https://bugs.webkit.org/show_bug.cgi?id=180884
118         https://trac.webkit.org/changeset/226673
119
120 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
121
122         Follow-up fix to r226715
123         https://bugs.webkit.org/show_bug.cgi?id=180555
124         <rdar://problem/36131381>
125
126         Unreviewed infrastructure fix.
127
128         * Scripts/webkitpy/xcode/new_simulated_device.py:
129         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
130         of delete.
131
132 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
133
134         webkitpy: Refactor simulator code (Part 2)
135         https://bugs.webkit.org/show_bug.cgi?id=180555
136         <rdar://problem/36131381>
137
138         Reviewed by Aakash Jain.
139
140         The patch leverages the SimulatedDeviceManager when running layout tests.
141         This patch is primarily code removal, since much of the IOSSimulatorPort
142         was dedicated to managing simulators. The removed code is either now owned by the
143         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
144         boot multiple simulators which was made obsolete in Xcode 9.
145
146         * Scripts/webkitpy/layout_tests/controllers/manager.py:
147         (Manager._custom_device_for_test.in): Device names now have spaces in them,
148         strip those spaces.
149         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
150         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
151         * Scripts/webkitpy/port/ios.py:
152         (IOSPort.__init__): The _current_device idiom is no longer required since the
153         SimulatedDeviceManager keeps track of any previously booted devices.
154         (IOSPort.target_host): Even when only a single device is used, it will be accessed
155         through the array of managed devices.
156         (IOSPort.using_multiple_devices): Deleted.
157         * Scripts/webkitpy/port/ios_device.py:
158         (IOSDevicePort.using_multiple_devices): Deleted.
159         * Scripts/webkitpy/port/ios_simulator.py:
160         (IOSSimulatorPort): Remove constants required to manage simulators, change device
161         class strings so they can be parsed by the DeviceType class.
162         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
163         the number of simulators currently booted, the number of child processes specified
164         and the maximum number of simulators supported by this system.
165         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
166         devices owned by the SimulatedDeviceManager.
167         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
168         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
169         the maximum number of supported simulators on this system.
170         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
171         request for each child process and send this list to the SimulatedDeviceManager to
172         initialize the devices.
173         (IOSSimulatorPort.clean_up_test_run):
174         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
175         specified version of iOS.
176         (IOSSimulatorPort.reset_preferences):
177         (IOSSimulatorPort.simulator_runtime): Deleted.
178         (IOSSimulatorPort.simulator_device_type): Deleted.
179         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
180         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
181         (IOSSimulatorPort._create_simulators): Deleted.
182         (IOSSimulatorPort._quit_ios_simulator): Deleted.
183         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
184         (IOSSimulatorPort.using_multiple_devices): Deleted.
185         (IOSSimulatorPort._create_device): Deleted.
186         (IOSSimulatorPort.get_simulator_path): Deleted.
187         (IOSSimulatorPort._createSimulatorApps): Deleted.
188         (IOSSimulatorPort._createSimulatorApp): Deleted.
189         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
190         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
191         maximum number of simulators run on this system.
192         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
193         * Scripts/webkitpy/xcode/new_simulated_device.py:
194         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
195
196 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
197
198         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
199         https://bugs.webkit.org/show_bug.cgi?id=181474
200
201         Reviewed by Carlos Alberto Lopez Perez.
202
203         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
204         name as the name.
205
206         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
207         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
208         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
209
210 2018-01-09  Andy Estes  <aestes@apple.com>
211
212         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
213         https://bugs.webkit.org/show_bug.cgi?id=181459
214
215         Reviewed by Dan Bernstein.
216
217         * ImageDiff/cg/Configurations/Base.xcconfig:
218
219 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
220
221         font-display:fallback can cause a visual flash (which is supposed to be impossible)
222         https://bugs.webkit.org/show_bug.cgi?id=181374
223
224         Reviewed by Simon Fraser.
225
226         The test requires Palatino.
227
228         * DumpRenderTree/mac/DumpRenderTree.mm:
229         (allowedFontFamilySet):
230         * WebKitTestRunner/mac/TestControllerMac.mm:
231         (WTR::allowedFontFamilySet):
232
233 2018-01-09  Saam Barati  <sbarati@apple.com>
234
235         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
236         https://bugs.webkit.org/show_bug.cgi?id=181449
237
238         Reviewed by JF Bastien.
239
240         This allows me to Cmd+f in my terminal to search for things without
241         having the results become misaligned.
242
243         * Scripts/display-profiler-output:
244
245 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
246
247         [webkitpy] PlatformInfo should have default argument for casual use
248         https://bugs.webkit.org/show_bug.cgi?id=180827
249
250         Reviewed by David Kilzer.
251
252         PlatformInfo should be the only way to check platform specific thing instead
253         of sys.platform or other various checks. If there is something you want to check,
254         it should be placed in PlatformInfo.
255
256         Currently to instantiate PlatformInfo, it requires arguments, which is usually
257         sys, platform and Executive(). They are straight forward and should be handled
258         by default arguments. Then we can instantiate PlatformInfo more casual.
259
260         * Scripts/webkitpy/common/system/platforminfo.py:
261         (PlatformInfo): Use relative module path import
262         (PlatformInfo.__init__):
263         (PlatformInfo.executive): Lazy instantiation of Executive()
264         (PlatformInfo.total_bytes_memory): Accessing via above property
265         (PlatformInfo.xcode_sdk_version): Ditto
266         (PlatformInfo.xcode_simctl_list): Ditto
267         (PlatformInfo.xcode_version): Ditto
268         (PlatformInfo._win_version_str): Ditto
269         * Scripts/webkitpy/common/system/systemhost.py:
270         (SystemHost.__init__):
271         * Scripts/webkitpy/common/system/user.py:
272         (User.__init__):
273
274 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
275
276         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
277         https://bugs.webkit.org/show_bug.cgi?id=176443
278
279         Reviewed by Darin Adler.
280
281         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
282         (TEST):
283
284 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
285
286         check-webkit-style: Verify syntax for WK_API_AVAILABLE
287         https://bugs.webkit.org/show_bug.cgi?id=181394
288
289         Reviewed by Darin Adler.
290
291         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
292         as the second parameter instead of ios(WK_IOS_TBA). This generally
293         builds for iOS on EWS but not when using the public SDK. See r224057,
294         r223207 and r226211 for example. This patch adds a basic style check
295         for that macro to prevent this kind of mistake.
296
297         * Scripts/webkitpy/style/checkers/cpp.py:
298         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
299         (check_style): Run new style check.
300         (CppChecker): Add build type for the new style check.
301         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
302         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
303
304 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
305
306         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
307         https://bugs.webkit.org/show_bug.cgi?id=181420
308         <rdar://problem/36365827>
309
310         Reviewed by Alex Christensen.
311
312         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
313         of corresponding _WKAttachments.
314
315         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
316         (TestWebKitAPI::TEST):
317
318 2018-01-08  Alex Christensen  <achristensen@webkit.org>
319
320         Add WKNavigationDelegate SPI exposing WebProcess crash reason
321         https://bugs.webkit.org/show_bug.cgi?id=181410
322         <rdar://problem/36167199>
323
324         Reviewed by Wenson Hsieh.
325
326         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
327         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
328         (TEST):
329
330 2018-01-08  Alex Christensen  <achristensen@webkit.org>
331
332         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
333         https://bugs.webkit.org/show_bug.cgi?id=181408
334         <rdar://problem/35884960>
335
336         Reviewed by Tim Horton.
337
338         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
339         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
340
341 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
342
343         [Attachment Support] Expose file name and content type of WKAttachment
344         https://bugs.webkit.org/show_bug.cgi?id=181390
345         <rdar://problem/36336837>
346
347         Reviewed by Tim Horton.
348
349         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
350
351         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
352         (-[_WKAttachment synchronouslyRequestInfo:]):
353         (-[_WKAttachment synchronouslyRequestData:]):
354
355         Reimplement this in terms of -synchronouslyRequestInfo:.
356
357         (-[_WKAttachment expectRequestedDataToBe:]):
358         (TestWebKitAPI::TEST):
359
360 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
361
362         Copying, pasting, and then deleting an attachment element breaks attachment data requests
363         https://bugs.webkit.org/show_bug.cgi?id=181365
364         <rdar://problem/36340647>
365
366         Reviewed by Tim Horton.
367
368         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
369         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
370         detail.
371
372         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
373         (TestWebKitAPI::TEST):
374
375 2018-01-08  Youenn Fablet  <youenn@apple.com>
376
377         navigator.onLine does not work inside service workers
378         https://bugs.webkit.org/show_bug.cgi?id=181079
379         <rdar://problem/36178606>
380
381         Reviewed by Darin Adler.
382
383         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
384         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
385
386 2018-01-07  Saam Barati  <sbarati@apple.com>
387
388         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
389         https://bugs.webkit.org/show_bug.cgi?id=181372
390
391         Reviewed by Filip Pizlo.
392
393         Adding these sorting modes makes it easier to analyze functions
394         that recompile a lot and exit a lot.
395
396         * Scripts/display-profiler-output:
397
398 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
399
400         Unreviewed, remove my Cisco email from contributors.json
401
402         * Scripts/webkitpy/common/config/contributors.json:
403
404 2018-01-05  JF Bastien  <jfbastien@apple.com>
405
406         WebAssembly: poison JS object's secrets
407         https://bugs.webkit.org/show_bug.cgi?id=181339
408         <rdar://problem/36325001>
409
410         Reviewed by Mark Lam.
411
412         Update tests for swap(Poisoned<k, T>, T*)
413
414         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
415         (TestWebKitAPI::TEST):
416         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
417         (TestWebKitAPI::TEST):
418         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
419         (TestWebKitAPI::TEST):
420
421 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
422
423         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
424         https://bugs.webkit.org/show_bug.cgi?id=181359
425
426         Reviewed by Tim Horton.
427
428         Ensure that these tests still pass using older SDKs.
429
430         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
431         (TestWebKitAPI::TEST):
432
433 2018-01-05  Alex Christensen  <achristensen@webkit.org>
434
435         Rebase API test after r226469
436         https://bugs.webkit.org/show_bug.cgi?id=181308
437
438         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
439         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
440         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
441
442 2018-01-05  Alex Christensen  <achristensen@webkit.org>
443
444         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
445         https://bugs.webkit.org/show_bug.cgi?id=181217
446
447         Reviewed by Tim Horton.
448
449         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
450         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
451         (TEST):
452
453 2018-01-05  Alex Christensen  <achristensen@webkit.org>
454
455         Add WKBundleFrameCreateFrameHandle
456         https://bugs.webkit.org/show_bug.cgi?id=181232
457         <rdar://problem/35926696>
458
459         Reviewed by Tim Horton.
460
461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
462         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
463         (mouseDidMoveOverElement):
464         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
465         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
466         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
467         (TEST):
468
469 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
470
471         iOS: Build fix after r226432.
472         
473         Unreviewed. Stop duplicating speakAs symbols for iOS.
474
475         * DumpRenderTree/AccessibilityUIElement.cpp:
476         (AccessibilityUIElement::speakAs):
477
478 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
479
480         Unreviewed, added myself as WebKit reviewer
481
482         * Scripts/webkitpy/common/config/contributors.json:
483
484 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
485
486         WPE: Build fix after r226432.
487
488         Unreviewed. Rename ::speak() to ::speakAs().
489         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
490         (WTR::AccessibilityUIElement::speakAs):
491         (WTR::AccessibilityUIElement::speak): Deleted.
492
493 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
494
495         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
496         https://bugs.webkit.org/show_bug.cgi?id=180361
497
498         Reviewed by Zalan Bujtas.
499
500         * DumpRenderTree/AccessibilityUIElement.cpp:
501         (speakAsCallback):
502         (AccessibilityUIElement::speakAs):
503         (AccessibilityUIElement::getJSClass):
504         (speakCallback): Deleted.
505         (AccessibilityUIElement::speak): Deleted.
506         * DumpRenderTree/AccessibilityUIElement.h:
507         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
508         (AccessibilityUIElement::speakAs):
509         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
510         (AccessibilityUIElement::speakAs):
511         (AccessibilityUIElement::speak): Deleted.
512         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
513         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
514         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
515         (WTR::AccessibilityUIElement::speakAs):
516         (WTR::AccessibilityUIElement::speak): Deleted.
517         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
518         (WTR::AccessibilityUIElement::speakAs):
519         (WTR::AccessibilityUIElement::speak): Deleted.
520
521 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
522
523         REGRESSION (r226395): test-webkitperl test expectations incorrect
524         https://bugs.webkit.org/show_bug.cgi?id=181307
525         <rdar://problem/36306558>
526
527         Rubber-stamped by Aakash Jain.
528
529         r226395 added two lines towards the beginning of
530         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
531         numbers in the test expectations need to update.
532
533         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
534
535 2018-01-04  Tim Horton  <timothy_horton@apple.com>
536
537         WKWebView loses minimum layout size overrides that happen while the process is terminated
538         https://bugs.webkit.org/show_bug.cgi?id=181306
539         <rdar://problem/34398288>
540
541         Reviewed by Dan Bernstein.
542
543         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
544         (TEST):
545         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
546         while the process is terminated results in the page getting the correct
547         minimum layout size.
548
549 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
550
551         [MediaStream] Add Mock screen capture source
552         https://bugs.webkit.org/show_bug.cgi?id=181291
553         <rdar://problem/36298164>
554
555         Reviewed by Dean Jackson.
556
557         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
558         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
559         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
560
561 2018-01-04  Lucas Forschler  <lforschler@apple.com>
562
563         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
564
565         Reviewed by Ling Ho.
566
567         * BuildSlaveSupport/build.webkit.org-config/steps.py:
568
569 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
570
571         [Attachment Support] Create attachment elements when dropping files on iOS
572         https://bugs.webkit.org/show_bug.cgi?id=181192
573         <rdar://problem/36280945>
574
575         Reviewed by Tim Horton.
576
577         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
578         switch is enabled. See below for more details.
579
580         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
581         (-[NSItemProvider registerData:type:]):
582         (platformCopyPNG):
583         (TestWebKitAPI::TEST):
584         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
585
586         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
587         source item provider when dragging rich text *without* attachments, so this should have been a check for just
588         kUTTypeRTF instead.
589
590         (TestWebKitAPI::TEST):
591
592         Tests a few cases of inserting attachment elements via drop:
593         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
594             Instead of inserting the contents as inline web content, this should generate attachment elements.
595         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
596             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
597             back to inserting the content as an attachment.
598         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
599             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
600             or at the end).
601
602         * TestWebKitAPI/cocoa/TestWKWebView.h:
603         * TestWebKitAPI/cocoa/TestWKWebView.mm:
604         (-[TestWKWebView objectByEvaluatingJavaScript:]):
605
606         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
607         -stringByEvaluatingJavaScript to just turn around and call this.
608
609         (-[TestWKWebView stringByEvaluatingJavaScript:]):
610
611 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
612
613         Replace hard-coded paths in shebangs with #!/usr/bin/env
614         https://bugs.webkit.org/show_bug.cgi?id=181040
615
616         Reviewed by Alex Christensen.
617
618         * BuildSlaveSupport/build-launcher-app:
619         * BuildSlaveSupport/build-launcher-dmg:
620         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
621         * BuildSlaveSupport/built-product-archive:
622         * BuildSlaveSupport/clean-build:
623         * BuildSlaveSupport/delete-stale-build-files:
624         * BuildSlaveSupport/download-built-product:
625         * BuildSlaveSupport/gtk/buildbot/log/run:
626         * BuildSlaveSupport/gtk/buildbot/run:
627         * BuildSlaveSupport/gtk/pulseaudio/run:
628         * BuildSlaveSupport/kill-old-processes:
629         * BuildSlaveSupport/test-result-archive:
630         * BuildSlaveSupport/win/kill-old-processes:
631         * Scripts/SpacingHeuristics.pm:
632         * Scripts/add-include:
633         * Scripts/build-api-tests:
634         * Scripts/build-dumprendertree:
635         * Scripts/build-imagediff:
636         * Scripts/build-jsc:
637         * Scripts/build-webkit:
638         * Scripts/build-webkittestrunner:
639         * Scripts/check-Xcode-source-file-types:
640         * Scripts/check-dom-results:
641         * Scripts/check-for-exit-time-destructors:
642         * Scripts/check-for-global-initializers:
643         * Scripts/check-for-inappropriate-objc-class-names:
644         * Scripts/check-for-weak-vtables-and-externals:
645         * Scripts/clean-header-guards:
646         * Scripts/compare-timing-files:
647         * Scripts/configure-xcode-for-ios-development:
648         * Scripts/copy-webkitlibraries-to-product-directory:
649         * Scripts/create-exports:
650         * Scripts/debug-minibrowser:
651         * Scripts/debug-safari:
652         * Scripts/debug-test-runner:
653         * Scripts/do-file-rename:
654         * Scripts/do-webcore-rename:
655         * Scripts/dump-webkit-tests-run:
656         * Scripts/ensure-valid-python:
657         * Scripts/execAppWithEnv:
658         * Scripts/extract-localizable-js-strings:
659         * Scripts/filter-build-webkit:
660         * Scripts/find-extra-includes:
661         * Scripts/fix-blink-patch:
662         * Scripts/generate-coverage-data:
663         * Scripts/git-add-reviewer:
664         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
665         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
666         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
667         * Scripts/make-new-script-test:
668         * Scripts/make-script-test-wrappers:
669         * Scripts/package-root:
670         * Scripts/parse-malloc-history:
671         * Scripts/report-include-statistics:
672         * Scripts/resolve-ChangeLogs:
673         * Scripts/run-api-tests:
674         * Scripts/run-bindings-tests:
675         * Scripts/run-content-extension-tester:
676         * Scripts/run-iexploder-tests:
677         * Scripts/run-javascriptcore-tests:
678         * Scripts/run-jsc:
679         * Scripts/run-leaks:
680         * Scripts/run-mangleme-tests:
681         * Scripts/run-minibrowser:
682         * Scripts/run-pageloadtest:
683         * Scripts/run-regexp-tests:
684         * Scripts/run-safari:
685         * Scripts/run-sunspider:
686         * Scripts/run-test-runner:
687         * Scripts/run-webkit-app:
688         * Scripts/run-webkit-httpd:
689         * Scripts/run-webkit-websocketserver:
690         * Scripts/set-webkit-configuration:
691         * Scripts/show-pretty-diff:
692         * Scripts/sort-Xcode-project-file:
693         * Scripts/split-file-by-class:
694         * Scripts/sunspider-compare-results:
695         * Scripts/svn-apply:
696         * Scripts/svn-unapply:
697         * Scripts/test-webkit-scripts:
698         * Scripts/test-webkitperl:
699         * Scripts/update-iexploder-cssproperties:
700         * Scripts/update-javascriptcore-test-results:
701         * Scripts/update-webkit:
702         * Scripts/update-webkit-auxiliary-libs:
703         * Scripts/update-webkit-dependency:
704         * Scripts/update-webkit-libs-jhbuild:
705         * Scripts/update-webkit-localizable-strings:
706         * Scripts/update-webkit-support-libs:
707         * Scripts/update-webkitgtk-libs:
708         * Scripts/update-webkitwpe-libs:
709         * Scripts/webkit-build-directory:
710         * Scripts/webkitperl/LoadAsModule.pm:
711         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
712         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
713         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
714         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
715         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
716         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
717         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
718         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
719         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
720         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
721         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
722         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
723         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
724         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
725         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
726         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
727         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
728         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
729         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
730         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
731         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
732         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
733         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
734         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
735         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
736         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
737         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
738         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
739         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
740         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
741         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
742         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
743         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
744         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
745         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
746         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
747         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
748         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
749         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
750         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
751         * ccache/ccache-clang:
752         * ccache/ccache-clang++:
753         * ccache/ccache-wrapper:
754         * gtk/install-dependencies:
755         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
756         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
757         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
758         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
759         * iExploder/iexploder-1.3.2/tools/showtest.rb:
760         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
761         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
762         * iExploder/iexploder-1.7.2/src/webserver.rb:
763         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
764         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
765         * wpe/install-dependencies:
766
767 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
768
769         filter-build-webkit filters out useful compiler error lines
770         https://bugs.webkit.org/show_bug.cgi?id=179864
771
772         Reviewed by Tim Horton.
773
774         Don't filter out lines that contain information about build errors by always showing lines
775         after a line that contains "note:" or "error:".
776
777         * Scripts/filter-build-webkit:
778         (shouldShowSubsequentLine):
779         (shouldIgnoreLine):
780
781 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
782
783         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
784         https://bugs.webkit.org/show_bug.cgi?id=173915
785
786         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
787         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
788         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
789         empty string in this case.
790
791         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
792         (emitFormSubmissionEvent):
793
794 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
795
796         [GTK] Add web process API to detect when form is submitted via JavaScript
797         https://bugs.webkit.org/show_bug.cgi?id=173915
798
799         Reviewed by Carlos Garcia Campos.
800
801         Test it.
802
803         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
804         (FormSubmissionTest::FormSubmissionTest):
805         (FormSubmissionTest::~FormSubmissionTest):
806         (FormSubmissionTest::testFormSubmissionResult):
807         (FormSubmissionTest::willSendDOMEventCallback):
808         (FormSubmissionTest::willCompleteCallback):
809         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
810         (testWebExtensionFormSubmissionSteps):
811         (beforeAll):
812         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
813         (DelayedSignal::DelayedSignal):
814         (emitFormSubmissionEvent):
815         (handleFormSubmissionCallback):
816         (willSubmitFormCallback):
817         (pageCreatedCallback):
818
819 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
820
821         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
822         https://bugs.webkit.org/show_bug.cgi?id=181251
823
824         * Scripts/run-gtk-tests:
825         (GtkTestRunner):
826
827 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
828
829         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
830         https://bugs.webkit.org/show_bug.cgi?id=181136
831
832         * Scripts/run-gtk-tests:
833         (GtkTestRunner):
834
835 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
836
837         [macOS, iOS] Adopt new secure coding APIs in WebKit
838         https://bugs.webkit.org/show_bug.cgi?id=181085
839         <rdar://problem/34837397>
840
841         Reviewed by Tim Horton.
842
843         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
844         capable of supporting NSSecureCoding, so pass through the current coding routines.
845
846         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
847         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
848         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
849         routines if necessary.
850         (TEST): Updated for NSSecureCoding.
851         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
852         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
853
854 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
855
856         Remove std::chrono completely
857         https://bugs.webkit.org/show_bug.cgi?id=181186
858
859         Reviewed by Alex Christensen.
860
861         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
862         (WTR::TestController::platformRunUntil):
863
864 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
865
866         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
867         https://bugs.webkit.org/show_bug.cgi?id=181231
868
869         Reviewed by Alex Christensen.
870
871         Implement TestController APIs needed by ResourceLoadStatistics tests.
872
873         * WebKitTestRunner/TestController.cpp:
874         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
875         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
876
877 2018-01-02  Tim Horton  <timothy_horton@apple.com>
878
879         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
880         https://bugs.webkit.org/show_bug.cgi?id=181219
881
882         Reviewed by Wenson Hsieh.
883
884         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
885
886 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
887
888         Add a WebAuthentication runtime feature flag
889         https://bugs.webkit.org/show_bug.cgi?id=181220
890         <rdar://problem/36055305>
891
892         Reviewed by Brent Fulgham.
893
894         Renames the CredentialManagement runtime feature flag into WebAuthentication.
895
896         * DumpRenderTree/TestOptions.h:
897         * DumpRenderTree/TestOptions.mm:
898         (TestOptions::TestOptions):
899         * DumpRenderTree/mac/DumpRenderTree.mm:
900         (enableExperimentalFeatures):
901         (setWebPreferencesForTestOptions):
902         * WebKitTestRunner/TestController.cpp:
903         (WTR::TestController::resetPreferencesToConsistentValues):
904         (WTR::updateTestOptionsFromTestHeader):
905         * WebKitTestRunner/TestOptions.h:
906         (WTR::TestOptions::hasSameInitializationOptions const):
907
908 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
909
910         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
911         https://bugs.webkit.org/show_bug.cgi?id=181143
912         <rdar://problem/36200381>
913
914         Reviewed by Tim Horton.
915
916         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
917         attachment elements are enabled.
918
919         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
920         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
921         (TestWebKitAPI::TEST):
922
923 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
924
925         Update Credential Management API for WebAuthentication
926         https://bugs.webkit.org/show_bug.cgi?id=181082
927         <rdar://problem/36055239>
928
929         Reviewed by Brent Fulgham.
930
931         Enable Credential Management API for testing.
932
933         * DumpRenderTree/TestOptions.h:
934         * WebKitTestRunner/TestOptions.h:
935
936 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
937
938         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
939         https://bugs.webkit.org/show_bug.cgi?id=168194
940
941         Reviewed by Carlos Garcia Campos.
942
943         Fix an assertion and unskip the test. The order that form controls are associated is not
944         guaranteed.
945
946         * Scripts/run-gtk-tests:
947         (GtkTestRunner):
948         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
949         (didAssociateFormControlsCallback):
950
951 2018-01-02  Alex Christensen  <achristensen@webkit.org>
952
953         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
954         https://bugs.webkit.org/show_bug.cgi?id=180897
955         <rdar://problem/35535328>
956
957         Reviewed by Brent Fulgham.
958
959         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
960
961         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
962         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
963         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
964         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
965         (websiteDataStoreTestWebView):
966         (TEST):
967
968 == Rolled over to ChangeLog-2018-01-01 ==