239b3f928887e884fe0ce980d1ccfda77c18ff85
[WebKit-https.git] / Tools / ChangeLog
1 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         Disable font variations on macOS Sierra and iOS 10
4         https://bugs.webkit.org/show_bug.cgi?id=173618
5         <rdar://problem/32879164>
6
7         Reviewed by Jon Lee.
8
9         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
10
11 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
12
13         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
14         https://bugs.webkit.org/show_bug.cgi?id=173578
15         <rdar://problem/32825028>
16
17         Reviewed by Tim Horton.
18
19         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
20         a custom popover does not cause dragging to fail when the popover is presented.
21
22         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
23         (-[DataInteractionSimulator _advanceProgress]):
24
25 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
26
27         [WPE] Add initial implementation of glib API
28         https://bugs.webkit.org/show_bug.cgi?id=173546
29
30         Reviewed by Žan Doberšek.
31
32         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
33         include WPE glib API files.
34
35         * Scripts/webkitperl/FeatureList.pm:
36         * Scripts/webkitpy/style/checker.py:
37         * Scripts/webkitpy/style/checkers/cpp.py:
38         (check_identifier_name_in_declaration):
39
40 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
41
42         [GTK] Upgrade to ICU to version 57.1
43         https://bugs.webkit.org/show_bug.cgi?id=173538
44
45         Reviewed by Žan Doberšek.
46
47         * gtk/jhbuild.modules:
48
49 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
50
51         [GTK] Remove unneeded modules from the jhbuild
52         https://bugs.webkit.org/show_bug.cgi?id=170540
53
54         Reviewed by Michael Catanzaro.
55
56         We are building libxslt and libffi that we don't really need to build from sources.
57
58         * gtk/jhbuild.modules:
59
60 2017-06-19  Frederic Wang  <fwang@igalia.com>
61
62         [Mac] Add an experimental feature setting for async frame scrolling
63         https://bugs.webkit.org/show_bug.cgi?id=173359
64
65         Reviewed by Simon Fraser.
66
67         * DumpRenderTree/mac/DumpRenderTree.mm:
68         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
69         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
70         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
71         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
72
73 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
74
75         Unreviewed, adding myself to contributors.json
76
77         * Scripts/webkitpy/common/config/contributors.json:
78
79 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
80
81         test262: Completion values for control flow do not match the spec
82         https://bugs.webkit.org/show_bug.cgi?id=171265
83
84         Reviewed by Saam Barati.
85
86         * Scripts/run-jsc-stress-tests:
87         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
88
89 2017-06-19  Zalan Bujtas  <zalan@apple.com>
90
91         Opening certain mails brings up a mail that grows indefinitely.
92         https://bugs.webkit.org/show_bug.cgi?id=173562
93         <rdar://problem/32766579>
94
95         Reviewed by Tim Horton.
96
97         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
98         (TEST):
99
100 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
101
102         [iOS DnD] Support .zip archives for file uploads via drag and drop
103         https://bugs.webkit.org/show_bug.cgi?id=173511
104         <rdar://problem/32521025>
105
106         Reviewed by Tim Horton.
107
108         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
109         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
110
111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
112         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
113         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
114         (testZIPArchive):
115         (TestWebKitAPI::TEST):
116
117 2017-06-18  Darin Adler  <darin@apple.com>
118
119         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
120         https://bugs.webkit.org/show_bug.cgi?id=173526
121
122         Reviewed by Sam Weinig.
123
124         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
126
127         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
128         tests for assignment before destruction ones.
129
130         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
131         as a function, so it can be used in WTF::Function tests.
132
133         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
134         Added tests for swap and for assignment before deref.
135
136         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
137         to inline everything. Also removed the unnecessary clearing of the log every time
138         the DerivedRefLogger constructor is called.
139         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
140
141         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
142         Added tests for assignment before deref and similar for releaseNonNull.
143
144 2017-06-19  Sam Weinig  <sam@webkit.org>
145
146         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
147         https://bugs.webkit.org/show_bug.cgi?id=173513
148
149         Reviewed by Alex Christensen.
150
151         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
152         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
153         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
154
155 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
156
157         [Win] fast/dom/assign-to-window-status.html is flaky.
158         https://bugs.webkit.org/show_bug.cgi?id=173512
159
160         Reviewed by Alex Christensen.
161
162         We should not dump status callbacks when test is done.
163
164         * DumpRenderTree/win/UIDelegate.cpp:
165         (UIDelegate::setStatusText):
166
167 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
168
169         [WPE][JHBuild] Update WPEBackend-mesa
170         https://bugs.webkit.org/show_bug.cgi?id=173433
171
172         Unreviewed.
173
174         Update WPEBackend-mesa back (like it was done originally in r218344)
175         after fixing the issue with the DISPLAY environment variables that
176         caused the crashes.
177
178         * wpe/jhbuild.modules:
179
180 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
181
182         Rename unit test file after r218482
183         https://bugs.webkit.org/show_bug.cgi?id=173483
184
185         Unreviewed.
186
187         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
188
189 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
190
191         Unreviewed. Fix wrong style checker condition added in r218487.
192
193         * Scripts/webkitpy/style/checkers/cpp.py:
194         (check_identifier_name_in_declaration):
195
196 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
197
198         Missing <functional> includes make builds fail with GCC 7.x
199         https://bugs.webkit.org/show_bug.cgi?id=173544
200
201         Unreviewed gardening.
202
203         Fix compilation with GCC 7.
204
205         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
206         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
207
208 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
209
210         [GTK] Move GTK+ API files that could be shared to glib dirs
211         https://bugs.webkit.org/show_bug.cgi?id=173545
212
213         Reviewed by Žan Doberšek.
214
215         Update paths of GTK+ API in watchlist and style checker.
216
217         * Scripts/webkitpy/common/config/watchlist:
218         * Scripts/webkitpy/style/checker.py:
219         * Scripts/webkitpy/style/checkers/cpp.py:
220         (check_identifier_name_in_declaration):
221
222 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
223
224         Port setup_environ_for_server should not set environment variables related with the driver.
225         https://bugs.webkit.org/show_bug.cgi?id=173483
226
227         Reviewed by Carlos Garcia Campos.
228
229         The port setup_environ_for_server() should not set environment variables
230         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
231         This varibles should be only set on the driver setup_environ_for_test().
232
233         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
234         into the test environment even when running the tests with a driver
235         that is not the Xorg or Xvfb one.
236
237         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
238         (Port.to.setup_environ_for_server):
239         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
240         (Driver._setup_environ_for_driver):
241         * Scripts/webkitpy/port/driver_unittest.py:
242         (DriverTest.test_setup_environ_for_test):
243         (DriverTest):
244         (DriverTest.test_setup_environ_base_vars):
245         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
246         (GtkPort.setup_environ_for_server):
247         * Scripts/webkitpy/port/wayland_unittest.py: Added.
248         (WaylandDriverTest):
249         (WaylandDriverTest.make_driver):
250         (WaylandDriverTest.make_environment):
251         (WaylandDriverTest.test_checkdriver):
252         (WaylandDriverTest.test_environment_needed_variables):
253         (WaylandDriverTest.test_environment_forbidden_variables):
254         (WaylandDriverTest.test_environment_optional_variables):
255         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
256         (WaylandDriver.check_driver):
257         (WaylandDriver._setup_environ_for_test):
258         * Scripts/webkitpy/port/xorgdriver.py:
259         (XorgDriver.check_driver):
260         (XorgDriver._setup_environ_for_test):
261         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
262         (XorgDriverTest):
263         (XorgDriverTest.make_driver):
264         (XorgDriverTest.make_environment):
265         (XorgDriverTest.test_checkdriver):
266         (XorgDriverTest.test_environment_needed_variables):
267         (XorgDriverTest.test_environment_forbidden_variables):
268         (XorgDriverTest.test_environment_optional_variables):
269         * Scripts/webkitpy/port/xvfbdriver.py:
270         (XvfbDriver._setup_environ_for_test):
271         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
272         (XvfbDriverTest.assertDriverStartSuccessful):
273
274
275 2017-05-14 Frederic Wang  <fwang@igalia.com>
276
277         Add heuristic to avoid flattening "fullscreen" iframes
278         https://bugs.webkit.org/show_bug.cgi?id=171914
279
280         Reviewed by Simon Fraser.
281
282         * DumpRenderTree/mac/DumpRenderTree.mm:
283         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
284
285 2017-06-18  Chris Dumez  <cdumez@apple.com>
286
287         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
288         https://bugs.webkit.org/show_bug.cgi?id=173522
289         <rdar://problem/31185739>
290
291         Reviewed by Darin Adler.
292
293         Add API test for re-entering Function's assignment operators.
294
295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
296         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
297         (TestWebKitAPI::TestObject::TestObject):
298         (TestWebKitAPI::TestObject::~TestObject):
299         (TestWebKitAPI::TestObject::operator()):
300         (TestWebKitAPI::TEST):
301
302 2017-06-16  Dan Bernstein  <mitz@apple.com>
303
304         [Cocoa] Some declarations have missing or incorrect availability attributes
305         https://bugs.webkit.org/show_bug.cgi?id=173508
306
307         Reviewed by Tim Horton.
308
309         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
310         (TestWebKitAPI::TEST): Updated for renames.
311
312 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
313
314         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
315         https://bugs.webkit.org/show_bug.cgi?id=173366
316         <rdar://problem/32767014>
317
318         Reviewed by Tim Horton.
319
320         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
321         change in behavior.
322
323         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
324         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
325         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
326         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
327         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
328         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
329         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
330         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
331         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
332         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
333         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
334         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
335         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
336         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
337         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
338         (-[MockDragDropSession initWithItems:location:window:]):
339         (-[MockDragDropSession allowsMoveOperation]):
340         (-[MockDragDropSession isRestrictedToDraggingApplication]):
341         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
342         (-[MockDragDropSession canLoadObjectsOfClass:]):
343         (-[MockDragDropSession canLoadObjectsOfClasses:]):
344         (-[MockDragDropSession items]):
345         (-[MockDragDropSession setItems:]):
346         (-[MockDragDropSession locationInView:]):
347         (-[MockDataOperationSession initWithProviders:location:window:]):
348         (-[MockDataOperationSession session]):
349         (-[MockDataOperationSession isLocal]):
350         (-[MockDataOperationSession progress]):
351         (-[MockDataOperationSession setProgressIndicatorStyle:]):
352         (-[MockDataOperationSession progressIndicatorStyle]):
353         (-[MockDataOperationSession operationMask]):
354         (-[MockDataOperationSession localDragSession]):
355         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
356         (-[MockDataOperationSession canCreateItemsOfClass:]):
357         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
358         (-[MockDataInteractionSession initWithWindow:]):
359         (-[MockDataInteractionSession localOperationMask]):
360         (-[MockDataInteractionSession externalOperationMask]):
361         (-[MockDataInteractionSession session]):
362         (-[DataInteractionSimulator _advanceProgress]):
363
364 2017-06-16  Alex Christensen  <achristensen@webkit.org>
365
366         Show punycode to user if a URL has dotless i or j followed by diacritic dot
367         https://bugs.webkit.org/show_bug.cgi?id=173431
368
369         Reviewed by Darin Adler.
370
371         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
372         (TestWebKitAPI::TEST):
373
374 2017-06-16  Chris Dumez  <cdumez@apple.com>
375
376         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
377         https://bugs.webkit.org/show_bug.cgi?id=173472
378         <rdar://problem/28858817>
379
380         Reviewed by Brady Eidson.
381
382         Add API test coverage.
383
384         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
385         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
386         (TEST):
387
388 2017-06-16  Brady Eidson  <beidson@apple.com>
389
390         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
391         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
392
393         Reviewed by Daniel Bates.
394
395         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
396
397 2017-06-16  Chris Dumez  <cdumez@apple.com>
398
399         DRT fails to reset page visibility between tests
400         https://bugs.webkit.org/show_bug.cgi?id=173485
401
402         Reviewed by Alexey Proskuryakov.
403
404         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
405         Fix this to address flakiness.
406
407         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
408         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
409         The test became flaky without the DRT change and was no longer flaky with the DRT
410         change.
411
412         WebKitTestRunner already does this.
413
414         * DumpRenderTree/mac/DumpRenderTree.mm:
415         (resetWebViewToConsistentStateBeforeTesting):
416
417 2017-06-16  Alex Christensen  <achristensen@webkit.org>
418
419         Implement basic authentication in MiniBrowser
420         https://bugs.webkit.org/show_bug.cgi?id=173443
421
422         Reviewed by Tim Horton.
423
424         * MiniBrowser/mac/WK2BrowserWindowController.m:
425         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
426
427 2017-06-16  Jer Noble  <jer.noble@apple.com>
428
429         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
430         https://bugs.webkit.org/show_bug.cgi?id=173398
431         <rdar://problem/32592961>
432
433         Reviewed by Eric Carlson.
434
435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
436         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
437         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
438         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
439         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
440         (TestWebKitAPI::TEST):
441         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
442
443 2017-06-16  Matt Lewis  <jlewis3@apple.com>
444
445         Unreviewed, rolling out r218375.
446
447         The API test MediaStreamTrackDetached is still timing out
448         after the patch
449
450         Reverted changeset:
451
452         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
453         reports no recording to WebKit clients"
454         https://bugs.webkit.org/show_bug.cgi?id=173398
455         http://trac.webkit.org/changeset/218375
456
457 2017-06-15  Jer Noble  <jer.noble@apple.com>
458
459         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
460         https://bugs.webkit.org/show_bug.cgi?id=173398
461         <rdar://problem/32592961>
462
463         Reviewed by Eric Carlson.
464
465         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
466         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
467         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
468         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
469         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
470         (TestWebKitAPI::TEST):
471         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
472
473 2017-06-15  Matt Lewis  <jlewis3@apple.com>
474
475         Unreviewed, rolling out r218365.
476
477         The revision caused API timeouts on all builds.
478
479         Reverted changeset:
480
481         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
482         reports no recording to WebKit clients"
483         https://bugs.webkit.org/show_bug.cgi?id=173398
484         http://trac.webkit.org/changeset/218365
485
486 2017-06-15  Jer Noble  <jer.noble@apple.com>
487
488         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
489         https://bugs.webkit.org/show_bug.cgi?id=173398
490         <rdar://problem/32592961>
491
492         Reviewed by Eric Carlson.
493
494         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
495         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
496         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
497         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
498         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
499         (TestWebKitAPI::TEST):
500         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
501
502 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
503
504         REGRESSION(r218344): [WPE] Thousands of layout test crashes
505         https://bugs.webkit.org/show_bug.cgi?id=173433
506
507         Unreviewed.
508
509         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
510
511 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
512
513         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
514         https://bugs.webkit.org/show_bug.cgi?id=173061
515
516         Reviewed by Žan Doberšek.
517
518         Launch dyz <https://github.com/Igalia/dyz> with the script
519         run-minibrowser for the wpe port. It is now built as part of the
520         WPE dependencies with JHBuild.
521
522         * Scripts/run-minibrowser:
523         * Scripts/webkitdirs.pm:
524         (launcherPath):
525         (launcherName):
526         * wpe/install-dependencies: Luajit is needed for building dyz.
527         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
528
529 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
530
531         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
532         https://bugs.webkit.org/show_bug.cgi?id=173338
533         <rdar://problem/32777720>
534
535         Reviewed by Tim Horton.
536
537         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
538         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
539         these remaining items on drop.
540
541         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
542         (TestWebKitAPI::TEST):
543         * TestWebKitAPI/ios/DataInteractionSimulator.h:
544         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
545
546         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
547
548         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
549
550 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
551
552         [Win] Crash in accessibility layout test.
553         https://bugs.webkit.org/show_bug.cgi?id=173401
554
555         Reviewed by Brent Fulgham.
556
557         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
558         member will be automatically released when the _variant_t object goes out of scope if the vt member
559         does not equal VT_UNKNOWN | VT_BYREF.
560         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
561
562         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
563         (AccessibilityUIElement::titleUIElement):
564
565 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
566
567         [GTK] Add API to allow overriding popup menus
568         https://bugs.webkit.org/show_bug.cgi?id=172905
569
570         Reviewed by Michael Catanzaro.
571
572         Add a unit test to check the new API.
573
574         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
575         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
576         (OptionMenuTest::OptionMenuTest):
577         (OptionMenuTest::~OptionMenuTest):
578         (OptionMenuTest::destroyMenu):
579         (OptionMenuTest::showOptionMenuCallback):
580         (OptionMenuTest::menuCloseCallback):
581         (OptionMenuTest::showOptionMenu):
582         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
583         (OptionMenuTest::close):
584         (OptionMenuTest::activateItem):
585         (OptionMenuTest::selectItem):
586         (testOptionMenuSimple):
587         (testOptionMenuGroups):
588         (testOptionMenuActivate):
589         (testOptionMenuSelect):
590         (beforeAll):
591         (afterAll):
592
593 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
594
595         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
596         https://bugs.webkit.org/show_bug.cgi?id=173399
597
598         Reviewed by Per Arne Vollan.
599
600         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
601         Curl port needs to do nothing because libcurl doesn't have disk cache.
602
603         * DumpRenderTree/win/DumpRenderTree.cpp:
604         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
605         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
606
607 2017-06-14  Tomas Popela  <tpopela@redhat.com>
608
609         [GTK] integer expression expected if running Tools/gtk/install-dependencies
610         https://bugs.webkit.org/show_bug.cgi?id=173356
611
612         Reviewed by Michael Catanzaro.
613
614         Use the correct operator to compare the strings.
615
616         * gtk/install-dependencies:
617
618 2017-06-14  Commit Queue  <commit-queue@webkit.org>
619
620         Unreviewed, rolling out r218285.
621         https://bugs.webkit.org/show_bug.cgi?id=173391
622
623         API test fails on iOS (Requested by alexchristensen on
624         #webkit).
625
626         Reverted changeset:
627
628         "Add SPI for immediate injection of user scripts"
629         https://bugs.webkit.org/show_bug.cgi?id=173342
630         http://trac.webkit.org/changeset/218285
631
632 2017-06-14  Chris Dumez  <cdumez@apple.com>
633
634         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
635         https://bugs.webkit.org/show_bug.cgi?id=173384
636         <rdar://problem/32723779>
637
638         Reviewed by Dan Bernstein.
639
640         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
641         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
642         Add API test coverage.
643
644         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
645         (TestWebKitAPI::Util::sleep):
646         Update implementation of Util::sleep() so that we actually run the run loop.
647         Otherwise, we don't process events while sleeping.
648
649 2017-06-14  Alex Christensen  <achristensen@webkit.org>
650
651         Add SPI for immediate injection of user scripts
652         https://bugs.webkit.org/show_bug.cgi?id=173342
653         <rdar://problem/29202285>
654
655         Reviewed by Brady Eidson.
656
657         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
658         (waitForMessage):
659         (TEST):
660
661 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
662
663         Add WPE to the flakiness dashboard
664         https://bugs.webkit.org/show_bug.cgi?id=173365
665
666         Reviewed by Carlos Alberto Lopez Perez.
667
668         * TestResultServer/static-dashboards/builders.jsonp:
669         * TestResultServer/static-dashboards/flakiness_dashboard.js:
670         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
671         (resetGlobals):
672         * TestResultServer/static-dashboards/loader_unittests.js:
673
674 2017-06-14  Brady Eidson  <beidson@apple.com>
675
676         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
677         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
678
679         Reviewed by Alex Christensen.
680
681         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
682         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
683         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
684         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
685         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
686         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
687         (TEST):
688
689 2017-06-14  Tim Horton  <timothy_horton@apple.com>
690
691         WKContentViewEditingActions API test always fails
692         https://bugs.webkit.org/show_bug.cgi?id=173374
693
694         Reviewed by Wenson Hsieh.
695
696         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
697         (TEST):
698         selectAll isn't working, because canPerformAction for selectAll returns NO
699         if selectionIsNone (which is true in the non-contenteditable case).
700         Instead, make use of r218180's test page, which knows how to select itself.
701         Also, reset the pasteboard at the beginning of the test to reduce confusion
702         (I landed the test broken because my simulator had the correct text
703         stuck in its pasteboard).
704
705 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
706
707         Configure screen scale for running layout tests on plus devices
708         https://bugs.webkit.org/show_bug.cgi?id=173319
709
710         Reviewed by Tim Horton.
711
712         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
713         * DumpRenderTree/mac/DumpRenderTree.mm:
714         (dumpRenderTree): Set screen scale to 2.0.
715         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
716         add _setScale for UIScreen.
717         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
718         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
719         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
720         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
721         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
722         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
723         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
724         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
725         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
726         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
727
728 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
729
730         Add iOS 11 support to the bot watcher's dashboard
731         https://bugs.webkit.org/show_bug.cgi?id=173369
732
733         Reviewed by Lucas Forschler.
734
735         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
736         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
738         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
740         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
741
742 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
743
744         [GTK][WPE] Raise the timeout values for layout tests
745         https://bugs.webkit.org/show_bug.cgi?id=173368
746
747         Reviewed by Carlos Garcia Campos.
748
749         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
750         When running under valgrind a 10x multiplier is applied.
751
752         * Scripts/webkitpy/port/gtk.py:
753         (GtkPort.default_timeout_ms):
754         * Scripts/webkitpy/port/gtk_unittest.py:
755         (GtkPortTest.test_default_timeout_ms):
756         * Scripts/webkitpy/port/wpe.py:
757         (WPEPort.default_timeout_ms):
758         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
759         (WPEPortTest):
760         (WPEPortTest.make_port):
761         (WPEPortTest.test_default_timeout_ms):
762         (WPEPortTest.test_get_crash_log):
763
764 2017-06-14  Alex Christensen  <achristensen@webkit.org>
765
766         Test persistent WKHTTPCookieStorages on iOS.
767         https://bugs.webkit.org/show_bug.cgi?id=173284
768
769         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
770         (TEST):
771         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
772
773 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
774
775         [Win] DRT should not use disk cache.
776         https://bugs.webkit.org/show_bug.cgi?id=173361
777
778         Reviewed by Darin Adler.
779
780         Like on macOS/iOS, DRT on Windows should only use memory cache.
781
782         * DumpRenderTree/win/DumpRenderTree.cpp:
783         (setDefaultsToConsistentValuesForTesting):
784         (prepareConsistentTestingEnvironment):
785
786 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
787
788         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
789         https://bugs.webkit.org/show_bug.cgi?id=171668
790
791         Reviewed by Jer Noble.
792
793         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
794         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
795         Infinity when the double value passed as argument is greater than 2^64.
796
797         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
798         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
799         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
800         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
801         method. No behavior change for rational MediaTime.
802
803         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
804         (TestWebKitAPI::TEST):
805
806 2017-06-13  Alex Christensen  <achristensen@webkit.org>
807
808         Test persistent WKHTTPCookieStorages on iOS
809         https://bugs.webkit.org/show_bug.cgi?id=173284
810         <rdar://problem/32260156>
811
812         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
813         (TEST):
814
815 2017-06-13  Matt Rajca  <mrajca@apple.com>
816
817         WebsitePolicies: let clients select specific autoplay quirks
818         https://bugs.webkit.org/show_bug.cgi?id=173343
819
820         Reviewed by Alex Christensen.
821
822         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
823         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
824         (TEST): Updated tests.
825
826 2017-06-13  Daniel Bates  <dabates@apple.com>
827
828         Implement W3C Secure Contexts Draft Specification
829         https://bugs.webkit.org/show_bug.cgi?id=158121
830         <rdar://problem/26012994>
831
832         Reviewed by Brent Fulgham.
833
834         Part 4
835
836         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
837         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
838         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
839
840         * DumpRenderTree/TestOptions.h:
841         * DumpRenderTree/TestOptions.mm:
842         (TestOptions::TestOptions):
843         * DumpRenderTree/mac/DumpRenderTree.mm:
844         (setWebPreferencesForTestOptions):
845         * DumpRenderTree/win/DumpRenderTree.cpp:
846         (enableExperimentalFeatures):
847         * WebKitTestRunner/TestController.cpp:
848         (WTR::TestController::resetPreferencesToConsistentValues):
849         (WTR::updateTestOptionsFromTestHeader):
850         * WebKitTestRunner/TestOptions.h:
851         (WTR::TestOptions::hasSameInitializationOptions):
852
853 2017-06-13  Alex Christensen  <achristensen@webkit.org>
854
855         Test persistent WKHTTPCookieStorages on iOS
856         https://bugs.webkit.org/show_bug.cgi?id=173284
857         <rdar://problem/32260156>
858
859         Reviewed by Alexey Proskuryakov.
860
861         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
862         (TEST):
863
864 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
865
866         [GTK] Blob download doesn't work
867         https://bugs.webkit.org/show_bug.cgi?id=172442
868
869         Reviewed by Carlos Alberto Lopez Perez.
870
871         Add a unit test to check blob downloads.
872
873         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
874         (testBlobDownload):
875         (beforeAll):
876
877 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
878
879         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
880         https://bugs.webkit.org/show_bug.cgi?id=173316
881
882         Reviewed by Alex Christensen.
883
884         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
885
886         * gtk/manifest.txt.in:
887
888 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
889
890         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
891         https://bugs.webkit.org/show_bug.cgi?id=173315
892
893         Reviewed by Darin Adler.
894
895         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
896         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
897         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
898         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
899         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
900         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
901         WKGeolocationManagerRef is not destroyed.
902
903         * WebKitTestRunner/GeolocationProviderMock.cpp:
904         (WTR::GeolocationProviderMock::GeolocationProviderMock):
905         * WebKitTestRunner/GeolocationProviderMock.h:
906
907 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
908
909         Unable to paste text that was copied from a page into the universal search field
910         https://bugs.webkit.org/show_bug.cgi?id=173293
911         <rdar://problem/32440918>
912
913         Reviewed by Ryosuke Niwa.
914
915         Adds 2 new unit tests for copying plain and rich selected web content.
916         See WebCore and WebKit ChangeLogs for more detail.
917
918         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
919         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
920         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
921         (TestWebKitAPI::dataForPasteboardType):
922         (TestWebKitAPI::setUpWebViewForPasteboardTests):
923         (TestWebKitAPI::TEST):
924
925 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
926
927         AX: [ATK] Implement missing AtkRelation types
928         https://bugs.webkit.org/show_bug.cgi?id=155494
929
930         Reviewed by Darin Adler.
931
932         Add additional methods to test ARIA properties which are exposed via
933         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
934
935         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
936         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
937         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
938         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
939         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
940         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
941         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
942         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
943         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
944         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
945         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
946         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
947         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
948         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
949         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
950         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
951         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
952         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
953
954 2017-06-12  Daniel Bates  <dabates@apple.com>
955
956         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
957         https://bugs.webkit.org/show_bug.cgi?id=173286
958         <rdar://problem/32726102>
959
960         Reviewed by Brent Fulgham.
961
962         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
963         (TestWebKitAPI::TEST_F):
964
965 2017-06-12  Lucas Forschler  <lforschler@apple.com>
966
967         <rdar://problem/32683422>
968         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
969
970         Reviewed by Conrad Schultz.
971
972         * Scripts/copy-webkitlibraries-to-product-directory:
973
974 2017-06-12  Tim Horton  <timothy_horton@apple.com>
975
976         [iOS] Cmd-C doesn't copy text from WKWebView
977         https://bugs.webkit.org/show_bug.cgi?id=173277
978         <rdar://problem/32396742>
979
980         Reviewed by Dan Bernstein.
981
982         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
983         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
984         Add a test ensuring that -copy on WKContentView will cause text to be copied.
985
986 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
987
988         [WebCrypto] Remove experimental feature flag of SubtleCrypto
989         https://bugs.webkit.org/show_bug.cgi?id=173197
990         <rdar://problem/32688148>
991
992         Reviewed by Brent Fulgham.
993
994         * DumpRenderTree/mac/DumpRenderTree.mm:
995         (enableExperimentalFeatures):
996         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
997         (WTR::InjectedBundle::beginTesting):
998         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
999         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
1000         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1001
1002 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1003
1004         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
1005         https://bugs.webkit.org/show_bug.cgi?id=173238
1006         <rdar://problem/31943370>
1007
1008         Reviewed by Ryosuke Niwa and Tim Horton.
1009
1010         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
1011         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
1012         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
1013
1014         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1015         (TestWebKitAPI::TEST):
1016         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1017         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1018         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
1019         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
1020
1021 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1022
1023         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
1024         https://bugs.webkit.org/show_bug.cgi?id=173225
1025         <rdar://problem/32713144>
1026
1027         Reviewed by Tim Horton.
1028
1029         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
1030         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
1031
1032         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1033         (TestWebKitAPI::TEST):
1034
1035 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
1036
1037         Return correct process names for iOS on-device testing
1038         https://bugs.webkit.org/show_bug.cgi?id=173263
1039
1040         Reviewed by Alex Christensen.
1041
1042         When running tests on iOS devices, process names do not end with '.Development'
1043         as they do on Mac and iOS simulator.
1044
1045         * WebKitTestRunner/TestController.cpp:
1046         (WTR::TestController::webProcessName): Return correct process name without '.Development'
1047         for iOS on-device testing.
1048         (WTR::TestController::networkProcessName): Ditto.
1049         (WTR::TestController::databaseProcessName): Ditto.
1050
1051 2017-06-12  Chris Dumez  <cdumez@apple.com>
1052
1053         Regression(r217867): Legacy SessionHistoryEntryData format should not change
1054         https://bugs.webkit.org/show_bug.cgi?id=173267
1055         <rdar://problem/32701257>
1056
1057         Reviewed by Simon Fraser.
1058
1059         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
1060         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
1061         though as this covers the crash that r217867 was fixing.
1062
1063         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
1064         (TestWebKitAPI::createSessionStateData):
1065         (TestWebKitAPI::TEST):
1066         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
1067
1068 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1069
1070         [GTK] Stop dismissing menus attached to the web view for every injected event
1071         https://bugs.webkit.org/show_bug.cgi?id=172708
1072
1073         Reviewed by Alex Christensen.
1074
1075         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
1076         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
1077         events while the menu is open.
1078
1079         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1080         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
1081         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1082         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
1083
1084 2017-06-12  Miguel Gomez  <magomez@igalia.com>
1085
1086         [GTK][WPE] Enable GStreamer GL on development builds
1087         https://bugs.webkit.org/show_bug.cgi?id=173248
1088
1089         Enable GStreamer GL for GTK and WPE.
1090
1091         Reviewed by Carlos Garcia Campos.
1092
1093         * Scripts/webkitperl/FeatureList.pm:
1094
1095 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1096
1097         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
1098
1099         Notifications are no longer cleared on page navigation.
1100
1101         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1102         (testWebViewNotification):
1103
1104 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1105
1106         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
1107
1108         DBus interface and object path names were updated in r217831.
1109
1110         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
1111
1112 2017-06-10  Dan Bernstein  <mitz@apple.com>
1113
1114         Reverted r218056 because it made the IDE reindex constantly.
1115
1116         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1117         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1118         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1119         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1120         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
1121         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1122         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1123         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1124
1125 2017-06-10  Dan Bernstein  <mitz@apple.com>
1126
1127         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
1128         https://bugs.webkit.org/show_bug.cgi?id=173223
1129
1130         Reviewed by Sam Weinig.
1131
1132         The rebuilds were happening due to a difference in the compiler options that the IDE and
1133         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
1134         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
1135         specify an appropriate path in CLANG_INDEX_STORE_PATH.
1136
1137         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1138         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1139         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1140         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1141         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
1142         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1143         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1144         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1145
1146 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
1147
1148         webkitpy: Reduce polling in ServerProcess
1149         https://bugs.webkit.org/show_bug.cgi?id=173116
1150
1151         Reviewed by Ryosuke Niwa.
1152
1153         We should be smarter about polling. We do not need to poll every time a line is read from
1154         stdout and stderr since lines are usually read from cached data. We should only poll
1155         when extracting that cached data from stdout and stderr.
1156
1157         * Scripts/webkitpy/port/driver.py:
1158         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
1159         and on ServerProcess to poll the process if not data is available in stdout and stderr.
1160         * Scripts/webkitpy/port/driver_unittest.py:
1161         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
1162         ServerProcess.
1163         * Scripts/webkitpy/port/server_process.py:
1164         (ServerProcess._read): Allow for data to be read from _output even if the process has
1165         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
1166         * Scripts/webkitpy/port/server_process_mock.py:
1167         (MockServerProcess): Add number_of_times_polled.
1168         (MockServerProcess.poll): Increment number_of_times_polled.
1169         (MockServerProcess.has_crashed): Poll before returning crash state.
1170         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
1171         just like a ServerProcess would.
1172         (MockServerProcess.read_stdout): Ditto.
1173         * Scripts/webkitpy/port/server_process_unittest.py:
1174         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
1175         process from ending before stdout and stderr are read. This is the reason this test was flakey.
1176         (TestServerProcess):
1177         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
1178         the processes is polled.
1179         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
1180         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
1181
1182 2017-06-10  Andy Estes  <aestes@apple.com>
1183
1184         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
1185         https://bugs.webkit.org/show_bug.cgi?id=173190
1186         <rdar://problem/31360659>
1187
1188         Reviewed by Brady Eidson.
1189         
1190         Added a release assert that tries to create a proper test failure if the web process crashes.
1191
1192         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1193         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
1194
1195 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1196
1197         [iOS DnD] Add a hook to perform two-step drops in editable content
1198         https://bugs.webkit.org/show_bug.cgi?id=172992
1199         <rdar://problem/32590174>
1200
1201         Reviewed by Tim Horton.
1202
1203         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
1204         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
1205                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
1206
1207         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
1208         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1209         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
1210
1211         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
1212         be overridden. Currently, this is overridden to just return true.
1213
1214         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1215         (TestWebKitAPI::TEST):
1216         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1217         (WTR::InjectedBundlePage::InjectedBundlePage):
1218
1219 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
1220
1221         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
1222         https://bugs.webkit.org/show_bug.cgi?id=173103
1223
1224         Reviewed by Xabier Rodriguez-Calvar.
1225
1226         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
1227         when building the WPE port through build-webkit.
1228
1229 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
1230
1231         [WPE] Enable MEDIA_SOURCE for build-webkit builds
1232         https://bugs.webkit.org/show_bug.cgi?id=173136
1233
1234         Reviewed by Xabier Rodriguez-Calvar.
1235
1236         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
1237
1238 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1239
1240         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
1241         https://bugs.webkit.org/show_bug.cgi?id=173098
1242
1243         Reviewed by Žan Doberšek.
1244
1245         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
1246         assuming that all tests containing forms define ids for the form elements like
1247         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
1248
1249         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1250         (formControlsAssociatedCallback):
1251
1252 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
1253
1254         webkitpy: Run sample/spindump on iOS devices
1255         https://bugs.webkit.org/show_bug.cgi?id=171881
1256         <rdar://problem/32084602>
1257
1258         Reviewed by Daniel Bates.
1259
1260         * Scripts/webkitpy/port/darwin.py:
1261         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
1262         requires sudo to run spindump.
1263         * Scripts/webkitpy/port/ios_device.py:
1264         (IOSDevicePort.look_for_new_samples): Deleted.
1265         (IOSDevicePort.sample_process): Deleted.
1266         * Scripts/webkitpy/port/ios_device_unittest.py:
1267         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
1268         (IOSDeviceTest.test_spindump):
1269         (IOSDeviceTest.test_sample_process):
1270         (IOSDeviceTest.test_sample_process_exception):
1271         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1272         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
1273
1274 2017-06-08  Keith Miller  <keith_miller@apple.com>
1275
1276         WebAssembly: We should only create wrappers for functions that can be exported
1277         https://bugs.webkit.org/show_bug.cgi?id=173088
1278
1279         Reviewed by Saam Barati.
1280
1281         Add quick mode for wasm tests.
1282
1283         * Scripts/run-jsc-stress-tests:
1284
1285 2017-06-08  Darin Adler  <darin@apple.com>
1286
1287         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
1288         https://bugs.webkit.org/show_bug.cgi?id=173106
1289
1290         Reviewed by Sam Weinig.
1291
1292         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
1293         destroyed last.
1294         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
1295         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
1296
1297 2017-06-07  Dan Bernstein  <mitz@apple.com>
1298
1299         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
1300         https://bugs.webkit.org/show_bug.cgi?id=173086
1301
1302         Reviewed by Andy Estes.
1303
1304         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
1305         (TEST):
1306
1307 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
1308
1309         Add High Sierra support to WebKit tools
1310         https://bugs.webkit.org/show_bug.cgi?id=173080
1311
1312         Rubber-stamped by Daniel Bates.
1313
1314         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
1315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
1316         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1317         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1318         Added dashboard support.
1319
1320         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1321         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1322         Trigger the right build queues on check-in.
1323
1324         * Scripts/webkitpy/common/system/platforminfo.py:
1325         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1326         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1327         * Scripts/webkitpy/port/mac.py:
1328         * Scripts/webkitpy/port/mac_unittest.py:
1329         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1330         Added cases for Sierra, and updated tests for new baseline search paths.
1331
1332 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
1333
1334         Unreviewed, rolling out r217902.
1335
1336         This change appears to have caused imported/w3c/web-platform-
1337         tests/fetch/api/cors tests to fail on El Capitan.
1338
1339         Reverted changeset:
1340
1341         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
1342         https://bugs.webkit.org/show_bug.cgi?id=172930
1343         http://trac.webkit.org/changeset/217902
1344
1345 2017-06-07  Daniel Bates  <dabates@apple.com>
1346
1347         Teach run-webkit-tests how to run HTTPS Web Platform Tests
1348         https://bugs.webkit.org/show_bug.cgi?id=172930
1349         <rdar://problem/32570201>
1350
1351         Reviewed by Youenn Fablet.
1352
1353         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
1354         that is conditioned on the page being delivered over a secure protocol. One example of such
1355         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
1356
1357         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
1358         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
1359         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
1360
1361         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1362         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
1363         to the Web Platform Tests HTTPS server.
1364         * Scripts/webkitpy/port/base.py:
1365         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
1366         * Scripts/webkitpy/port/driver.py:
1367         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
1368         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
1369         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
1370         indicate that they should be considered private instance variables.
1371         (Driver.is_web_platform_test): Update code for renamed instance variables.
1372         (Driver):
1373         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
1374         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
1375         determine the base URL to use to access the test.
1376         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
1377         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
1378
1379 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
1380
1381         Support removal of authentication data through the Website data store API.
1382         https://bugs.webkit.org/show_bug.cgi?id=171217
1383
1384         Reviewed by Brady Eidson.
1385
1386         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1387         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1388         (WTR::InjectedBundle::didReceiveMessageToPage):
1389         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1390         (WTR::TestRunner::removeAllSessionCredentials):
1391         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
1392         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1393         * WebKitTestRunner/TestController.h:
1394         * WebKitTestRunner/TestInvocation.cpp:
1395         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1396         (WTR::TestInvocation::didRemoveAllSessionCredentials):
1397         * WebKitTestRunner/TestInvocation.h:
1398         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1399         (WTR::TestController::removeAllSessionCredentials):
1400
1401 2017-06-07  Charlie Turner  <cturner@igalia.com>
1402
1403         Add Charlie Turner as contributor
1404         https://bugs.webkit.org/show_bug.cgi?id=173055
1405
1406         Reviewed by Carlos Alberto Lopez Perez.
1407
1408         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
1409         of webkit-patch upload, which reordered some fields and removed a newline.
1410
1411         * Scripts/webkitpy/common/config/contributors.json:
1412
1413 2017-06-06  Chris Dumez  <cdumez@apple.com>
1414
1415         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
1416         https://bugs.webkit.org/show_bug.cgi?id=173033
1417         <rdar://problem/32591099>
1418
1419         Reviewed by Simon Fraser.
1420
1421         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
1422         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
1423
1424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1425         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
1426         (TestWebKitAPI::didFinishLoadForFrame):
1427         (TestWebKitAPI::setPageLoaderClient):
1428         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
1429         (TestWebKitAPI::TEST):
1430
1431 2017-06-06  Andy Estes  <aestes@apple.com>
1432
1433         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
1434         https://bugs.webkit.org/show_bug.cgi?id=172849
1435         <rdar://problem/32567454>
1436
1437         Reviewed by Darin Adler.
1438
1439         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1440         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
1441         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1442         (TestWebKitAPI::TEST):
1443
1444 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
1445
1446         [preload] Conditional support for media preloading and align media `as` values.
1447         https://bugs.webkit.org/show_bug.cgi?id=172501
1448
1449         Reviewed by Dean Jackson.
1450
1451         Turn on media preloading preference for tests.
1452
1453         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
1454         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
1455         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
1456
1457 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
1458
1459         webkitpy: Return correct process names from SimulatorProcess
1460         https://bugs.webkit.org/show_bug.cgi?id=172940
1461
1462         Reviewed by Aakash Jain.
1463
1464         * Scripts/webkitpy/port/darwin.py:
1465         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
1466         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
1467         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
1468         * Scripts/webkitpy/port/driver.py:
1469         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
1470         _server_process.name() will not return the correct process name for iOS.
1471         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
1472         (Driver._read_block): Ditto.
1473         * Scripts/webkitpy/port/driver_unittest.py:
1474         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
1475         process_name() instead of name().
1476         * Scripts/webkitpy/port/server_process.py:
1477         (ServerProcess._start): Use process_name() instead of name().
1478         (ServerProcess.stop): Ditto.
1479         (ServerProcess.name): Deleted.
1480         * Scripts/webkitpy/port/simulator_process.py:
1481         (SimulatorProcess.process_name): Check the provided bundle for the process name.
1482
1483 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
1484
1485         test-webkitpy: stop forking unsafely from within a spawned process
1486         https://bugs.webkit.org/show_bug.cgi?id=172774
1487
1488         Reviewed by Darin Adler.
1489
1490         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1491         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
1492         it's going to be used.
1493         (Builder.force_build):
1494
1495 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
1496
1497         webkitpy: Process crash-logs for iOS devices
1498         https://bugs.webkit.org/show_bug.cgi?id=171976
1499         <rdar://problem/32134551>
1500
1501         Reviewed by David Kilzer.
1502
1503         When running layout tests on an iOS device, crash logs should be processed.
1504         Implement crash log searching and parsing for iOS devices.
1505
1506         * Scripts/webkitpy/common/system/crashlogs.py:
1507         (CrashLogs): Moved process regular expression for Darwin to class variable.
1508         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
1509         (CrashLogs.find_newest_log): Add iOS as a potential platform.
1510         (CrashLogs.find_all_logs): Ditto.
1511         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
1512         Do not assume that a Darwin crash log starts with the process.
1513         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
1514         shared code for parsing Darwin crash logs.
1515         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
1516         object so that crash logs already on the system before testing are not parsed.
1517         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
1518         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
1519         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
1520         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1521         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
1522         * Scripts/webkitpy/common/system/systemhost.py:
1523         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
1524         systems is just the crashlog, use this behavior by default.
1525         * Scripts/webkitpy/common/system/systemhost_mock.py:
1526         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
1527         systems is just the crashlog, use this behavior by default.
1528         * Scripts/webkitpy/port/apple.py:
1529         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
1530         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
1531         the system before testing begins
1532         * Scripts/webkitpy/port/base.py:
1533         (Port._get_crash_log): Pass optional target host when getting crash logs.
1534         * Scripts/webkitpy/port/darwin.py:
1535         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
1536         CrashLogs object.
1537         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
1538         logs to be skipped to CrashLogs object.
1539         * Scripts/webkitpy/port/darwin_testcase.py:
1540         (DarwinTest.test_get_crash_log): Removed unused local function.
1541         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
1542         * Scripts/webkitpy/port/device.py:
1543         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
1544         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
1545         * Scripts/webkitpy/port/driver.py:
1546         (Driver._get_crash_log): Pass optional target host when getting crash logs.
1547         * Scripts/webkitpy/port/gtk.py:
1548         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
1549         * Scripts/webkitpy/port/ios.py: Ditto.
1550         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
1551         to be skipped for each host.
1552         * Scripts/webkitpy/port/ios_device.py:
1553         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
1554         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
1555         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
1556         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
1557         host is specified. Else, search all connected devices for the specified crash-log.
1558         (IOSDevicePort.look_for_new_crash_logs): Deleted.
1559         * Scripts/webkitpy/port/ios_device_unittest.py:
1560         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
1561         (IOSDeviceTest.test_get_crash_log): Ditto.
1562         * Scripts/webkitpy/port/simulator_process.py:
1563         (SimulatorProcess.process_name): Check the provided bundle for the process name.
1564         * Scripts/webkitpy/port/win.py:
1565         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
1566         logs to be skipped to CrashLogs object.
1567         * Scripts/webkitpy/port/wpe.py:
1568         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
1569
1570 2017-06-06  David Kilzer  <ddkilzer@apple.com>
1571
1572         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
1573         <https://webkit.org/b/172804>
1574
1575         Reviewed by Darin Adler.
1576
1577         WTF_ATTRIBUTE_PRINTF() only works outside the current
1578         compilation unit if it's on the declaration, not the
1579         implementation, of a function or class method.
1580
1581         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1582         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1583         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1584         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1585         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
1586         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1587         - Remove redundant CRASH() macro definition.  Use the one from
1588           <wtf/Assertions.h> instead.
1589
1590 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
1591
1592         Move Resource Timing / User Timing from experimental features into main preferences
1593         https://bugs.webkit.org/show_bug.cgi?id=172950
1594
1595         Reviewed by Darin Adler.
1596
1597         * DumpRenderTree/mac/DumpRenderTree.mm:
1598         (enableExperimentalFeatures):
1599         (resetWebPreferencesToConsistentValues):
1600         * DumpRenderTree/win/DumpRenderTree.cpp:
1601         (enableExperimentalFeatures):
1602         (resetWebPreferencesToConsistentValues):
1603         * WebKitTestRunner/TestController.cpp:
1604         (WTR::TestController::resetPreferencesToConsistentValues):
1605         Move out no longer experimental features to the main list.
1606
1607 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1608
1609         [WPE] Add an install-dependencies script
1610         https://bugs.webkit.org/show_bug.cgi?id=172948
1611
1612         Reviewed by Žan Doberšek.
1613
1614         It is based on the gtk/install-dependencies script.
1615         Includes support for Debian based distrubutions, Fedora and Arch.
1616         It has been tested on a minimal Debian 9 chroot.
1617
1618         * wpe/install-dependencies: Added.
1619
1620 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1621
1622         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
1623         https://bugs.webkit.org/show_bug.cgi?id=172891
1624         <rdar://problem/32204540>
1625
1626         Reviewed by Darin Adler.
1627
1628         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
1629         contenteditable. See WebCore ChangeLog for more details.
1630
1631         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1632         (TestWebKitAPI::TEST):
1633
1634 2017-06-05  Daniel Bates  <dabates@apple.com>
1635
1636         webkitpy: Abstract Executive class
1637         https://bugs.webkit.org/show_bug.cgi?id=172928
1638         <rdar://problem/32569531>
1639
1640         Reviewed by Ryosuke Niwa.
1641
1642         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
1643         This will make it straightforward to create additional derived classes that
1644         adhere to the same interface, say for iOS on-device testing.
1645
1646         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
1647         (AbstractExecutive):
1648         (AbstractExecutive.run_and_throw_if_fail):
1649         (AbstractExecutive.cpu_count):
1650         (AbstractExecutive.interpreter_for_script):
1651         (AbstractExecutive.shell_command_for_script):
1652         (AbstractExecutive.kill_process):
1653         (AbstractExecutive.check_running_pid):
1654         (AbstractExecutive.running_pids):
1655         (AbstractExecutive.wait_newest):
1656         (AbstractExecutive.wait_limited):
1657         (AbstractExecutive.interrupt):
1658         (AbstractExecutive.default_error_handler):
1659         (AbstractExecutive.ignore_error):
1660         (AbstractExecutive._stringify_args):
1661         (AbstractExecutive.command_for_printing):
1662         (AbstractExecutive.run_command):
1663         (AbstractExecutive.popen):
1664         (AbstractExecutive.run_in_parallel):
1665         * Scripts/webkitpy/common/system/executive.py:
1666         (Executive):
1667         (Executive.cpu_count):
1668         (Executive.running_pids):
1669         (Executive.kill_all):
1670         (Executive._compute_stdin):
1671         (Executive.interpreter_for_script): Deleted.
1672         (Executive.shell_command_for_script): Deleted.
1673         (Executive.wait_newest): Deleted.
1674         (Executive.wait_limited): Deleted.
1675         (Executive.default_error_handler): Deleted.
1676         (Executive.ignore_error): Deleted.
1677         (Executive.command_for_printing): Deleted.
1678
1679 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
1680
1681         webkitpy: Add iOS to platform
1682         https://bugs.webkit.org/show_bug.cgi?id=172931
1683
1684         Reviewed by Daniel Bates.
1685
1686         * Scripts/webkitpy/common/system/platforminfo.py:
1687         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
1688         (PlatformInfo.is_ios): Added.
1689         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
1690         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1691         (MockPlatformInfo.is_ios): Added.
1692
1693 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1694
1695         [WPE][JHBuild] Switch github repository from git:// to https://
1696         https://bugs.webkit.org/show_bug.cgi?id=172921
1697
1698         Reviewed by Alex Christensen.
1699
1700         * wpe/jhbuild.modules:
1701
1702 2017-06-05  Tim Horton  <timothy_horton@apple.com>
1703
1704         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
1705         https://bugs.webkit.org/show_bug.cgi?id=172887
1706         <rdar://problem/32546061>
1707
1708         Reviewed by Sam Weinig.
1709
1710         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1711         (WTR::UIScriptController::applyAutocorrection):
1712         applyAutocorrection can call its completion handler synchronously,
1713         which makes UIScriptController unhappy (see bug 172884).
1714
1715 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
1716
1717         webkitpy: Add contextmanager to disable logging for a block
1718         https://bugs.webkit.org/show_bug.cgi?id=172876
1719
1720         Reviewed by Daniel Bates.
1721
1722         Add a context manager which will use an OutputCapture object to capture logging
1723         in a block and hold it in a variable.
1724
1725         * Scripts/webkitpy/common/system/outputcapture.py:
1726         (OutputCaptureScope):
1727         (OutputCaptureScope.__init__): Construct with OutputCapture object.
1728         (OutputCaptureScope.__enter__): Begin capturing output. 
1729         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
1730         output and retain the resulting log.
1731         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
1732         (OutputCaptureTest.test_output_capture_scope): Added.
1733
1734 2017-06-02  Zalan Bujtas  <zalan@apple.com>
1735
1736         Cleanup FrameView::autoSizeIfEnabled.
1737         https://bugs.webkit.org/show_bug.cgi?id=172889
1738         <rdar://problem/32550783>
1739
1740         Reviewed by Tim Horton.
1741
1742         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1743         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
1744         (TEST):
1745
1746 2017-06-02  Chris Dumez  <cdumez@apple.com>
1747
1748         ResourceLoadStatistics are not using unique paths during test runs
1749         https://bugs.webkit.org/show_bug.cgi?id=172861
1750         <rdar://problem/32442251>
1751
1752         Reviewed by Darin Adler.
1753
1754         Make sure WebKitTestRunner sets a temporary path for saving resource
1755         load statistics.
1756
1757         * WebKitTestRunner/TestController.cpp:
1758         (WTR::TestController::generateContextConfiguration):
1759
1760 2017-06-02  Brady Eidson  <beidson@apple.com>
1761
1762         Prevent scheme handlers from handling all built-in URL schemes.
1763         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
1764
1765         Reviewed by Andy Estes.
1766
1767         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1768
1769 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
1770
1771         [JSCOnly] Build static jsc.exe on Windows
1772         https://bugs.webkit.org/show_bug.cgi?id=172833
1773
1774         Reviewed by Konstantin Tokarev.
1775
1776         * CMakeLists.txt:
1777         * Scripts/build-jsc:
1778
1779 2017-06-02  Zalan Bujtas  <zalan@apple.com>
1780
1781         Disable ViewportSizeForViewportUnits tests on iOS.
1782         https://bugs.webkit.org/show_bug.cgi?id=172872
1783
1784         Reviewed by Tim Horton.
1785
1786         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
1787
1788 2017-06-02  Zalan Bujtas  <zalan@apple.com>
1789
1790         Allow clients to override viewport size for CSS viewport units.
1791         https://bugs.webkit.org/show_bug.cgi?id=172838
1792         <rdar://problem/32523441>
1793
1794         Reviewed by Tim Horton.
1795
1796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1797         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
1798         (TEST):
1799
1800 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
1801
1802         Get <chrono> out of StdLibExtras.h
1803         https://bugs.webkit.org/show_bug.cgi?id=172744
1804
1805         Reviewed by Zalan Bujtas.
1806
1807         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1808
1809 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
1810
1811         [WPE] Enable SUBTLE_CRYPTO
1812         https://bugs.webkit.org/show_bug.cgi?id=172756
1813
1814         Reviewed by Michael Catanzaro.
1815
1816         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
1817         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
1818         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
1819         exhausting entropy when running the crypto layout tests.
1820
1821 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1822
1823         [GTK] Bump GTK+ and its dependencies in jhbuild
1824         https://bugs.webkit.org/show_bug.cgi?id=171918
1825
1826         Reviewed by Carlos Alberto Lopez Perez.
1827
1828         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1829         (WTR::initializeGtkSettings):
1830         * gtk/jhbuild.modules:
1831         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
1832         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
1833
1834 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1835
1836         [GTK] Bump wayland and weston in jhbuild
1837         https://bugs.webkit.org/show_bug.cgi?id=171921
1838
1839         Reviewed by Carlos Alberto Lopez Perez.
1840
1841         * gtk/jhbuild.modules:
1842         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
1843
1844 2017-06-01  Andy Estes  <aestes@apple.com>
1845
1846         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
1847         https://bugs.webkit.org/show_bug.cgi?id=172828
1848
1849         Reviewed by Beth Dakin.
1850
1851         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1852
1853 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
1854
1855         webkitpy: Remove unneeded simulator teardown
1856         https://bugs.webkit.org/show_bug.cgi?id=171891
1857
1858         Reviewed by Aakash Jain.
1859
1860         * Scripts/webkitpy/port/ios_simulator.py:
1861         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
1862         for communication between Python and WebKitTestRunner/DumpRenderTree.
1863
1864 2017-06-01  Keith Miller  <keith_miller@apple.com>
1865
1866         Undo rollout in r217638 with bug fix
1867         https://bugs.webkit.org/show_bug.cgi?id=172824
1868
1869         Unreviewed, reland patch with unused set_state code removed.
1870
1871         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1872         (runThreadMessageTest):
1873         (TEST):
1874
1875 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
1876
1877         webkitpy: Do not send 0 or -1 as a pid to kill_process
1878         https://bugs.webkit.org/show_bug.cgi?id=172818
1879
1880         Reviewed by Darin Adler.
1881
1882         Sending a signal to process 0 will result in all processes in the group receiving 
1883         the signal. Sending a signal to process -1 will result in all non-system processes
1884         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
1885         should consider these cases
1886
1887         * Scripts/webkitpy/common/system/executive.py:
1888         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
1889         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
1890         never be running, although os.kill may succeed.
1891         * Scripts/webkitpy/port/simulator_process.py:
1892         (SimulatorProcess.stop): Do not kill process if it is undefined.
1893
1894 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
1895
1896         JSC EWS bot does not run on WTF only patches
1897         https://bugs.webkit.org/show_bug.cgi?id=172777
1898         rdar://problem/32495975
1899
1900         Reviewed by Aakash Jain.
1901
1902         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1903         (CheckPatchRelevance): Add a missing comma.
1904
1905 2017-05-31  Commit Queue  <commit-queue@webkit.org>
1906
1907         Unreviewed, rolling out r217611 and r217631.
1908         https://bugs.webkit.org/show_bug.cgi?id=172785
1909
1910         "caused wasm-hashset-many.html to become flaky." (Requested by
1911         keith_miller on #webkit).
1912
1913         Reverted changesets:
1914
1915         "Reland r216808, underlying lldb bug has been fixed."
1916         https://bugs.webkit.org/show_bug.cgi?id=172759
1917         http://trac.webkit.org/changeset/217611
1918
1919         "Use dispatch queues for mach exceptions"
1920         https://bugs.webkit.org/show_bug.cgi?id=172775
1921         http://trac.webkit.org/changeset/217631
1922
1923 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
1924
1925         EWS bots should reboot themselves more frequently
1926         https://bugs.webkit.org/show_bug.cgi?id=172402
1927
1928         Reviewed by Alexey Proskuryakov.
1929
1930         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
1931
1932         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
1933
1934 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
1935
1936         Reallocate hardware for iOS bots.
1937         https://bugs.webkit.org/show_bug.cgi?id=172657
1938
1939         Reviewed by Alexey Proskuryakov.
1940
1941         * BuildSlaveSupport/build.webkit.org-config/config.json:
1942
1943 2017-05-31  Andy Estes  <aestes@apple.com>
1944
1945         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
1946         https://bugs.webkit.org/show_bug.cgi?id=172366
1947
1948         Reviewed by Daniel Bates.
1949
1950         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1951
1952 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
1953
1954         Unreviewed, add Jiewen Tan as a reviewer
1955
1956         * Scripts/webkitpy/common/config/contributors.json:
1957
1958 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
1959
1960         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
1961         https://bugs.webkit.org/show_bug.cgi?id=172770
1962
1963         Reviewed by Michael Catanzaro.
1964
1965         * MiniBrowser/gtk/BrowserWindow.c:
1966         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
1967         which caused the body of the if-clause to be accidentally empty.
1968
1969 2017-05-31  Keith Miller  <keith_miller@apple.com>
1970
1971         Reland r216808, underlying lldb bug has been fixed.
1972         https://bugs.webkit.org/show_bug.cgi?id=172759
1973
1974         Unreviewed, relanding old patch. See: rdar://problem/31183352
1975
1976         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1977         (runThreadMessageTest):
1978         (TEST):
1979
1980 2017-05-31  Matt Lewis  <jlewis3@apple.com>
1981
1982         Unreviewed, rolling out r217603.
1983
1984         This patch broke the internal builds.
1985
1986         Reverted changeset:
1987
1988         "Get <chrono> out of StdLibExtras.h"
1989         https://bugs.webkit.org/show_bug.cgi?id=172744
1990         http://trac.webkit.org/changeset/217603
1991
1992 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
1993
1994         Make ResourceLoadStatistics testing more reliable
1995         https://bugs.webkit.org/show_bug.cgi?id=172730
1996         <rdar://problem/32028373>
1997
1998         Reviewed by Andy Estes.
1999
2000         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
2001         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
2002
2003         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2004         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2005
2006 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2007
2008         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
2009         https://bugs.webkit.org/show_bug.cgi?id=172757
2010
2011         Reviewed by Xabier Rodriguez-Calvar.
2012
2013         When needed, add the jhbuild wrapper at the beginning of the array
2014         that will be invoked to execute the run-jsc-stress-test or testapi
2015         commands.
2016
2017         * Scripts/run-javascriptcore-tests:
2018         (runJSCStressTests):
2019         * Scripts/webkitdirs.pm:
2020         (shouldUseJhbuild):
2021
2022 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
2023
2024         Get <chrono> out of StdLibExtras.h
2025         https://bugs.webkit.org/show_bug.cgi?id=172744
2026
2027         Reviewed by Saam Barati.
2028
2029         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2030
2031 2017-05-30  Tim Horton  <timothy_horton@apple.com>
2032
2033         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
2034         https://bugs.webkit.org/show_bug.cgi?id=172735
2035         <rdar://problem/32015977>
2036
2037         Reviewed by Enrica Casucci.
2038
2039         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2040         (WTR::UIScriptController::applyAutocorrection):
2041         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2042         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2043         (WTR::UIScriptController::applyAutocorrection):
2044         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2045         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2046         (WTR::UIScriptController::applyAutocorrection):
2047         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
2048         because I don't know how to tap the button in the autocorrection bar from a test.
2049
2050 2017-05-30  Daniel Bates  <dabates@apple.com>
2051
2052         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
2053         https://bugs.webkit.org/show_bug.cgi?id=172671
2054
2055         Reviewed by Alex Christensen.
2056
2057         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
2058         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
2059
2060         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
2061         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
2062         to trigger a navigation to test it.
2063         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
2064         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
2065
2066 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
2067
2068         webkitpy: Start servers before setting-up for testing
2069         https://bugs.webkit.org/show_bug.cgi?id=172176
2070         <rdar://problem/32225538>
2071
2072         Reviewed by Alexey Proskuryakov.
2073
2074         On-device testing requires that servers are started before ports set-up their
2075         test environments.
2076
2077         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2078         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
2079         Servers are unconditionally stopped on exit.
2080         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
2081         Manager now stops servers.
2082         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
2083         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
2084         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2085         (Manager.__init__): Delay construction of the test runner until we can determine
2086         if servers need to be started.
2087         (Manager.run): Determine if servers need to be started and construct the test runner.
2088         Shut servers down when the test run is finished.
2089         (Manager._run_tests): Move the determination of servers to run into Manager.run.
2090         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2091         (is_wpt_server_running): Server is not running if no config is found.
2092         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2093         (PyWebSocket.is_running): Check if this WebSocket server is running.
2094         * Scripts/webkitpy/port/base.py:
2095         (Port.__init__): Define secure WebSocket server.
2096         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
2097
2098 2017-05-30  Daniel Bates  <dabates@apple.com>
2099
2100         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
2101         https://bugs.webkit.org/show_bug.cgi?id=172603
2102         <rdar://problem/32471306>
2103
2104         Reviewed by Brady Eidson.
2105
2106         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
2107         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
2108         unloading is initiated for a page that registered a onbeforeunload handler.
2109
2110         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
2111         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
2112         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
2113
2114         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
2115         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
2116         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
2117         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
2118
2119         * MiniBrowser/mac/WK2BrowserWindowController.m:
2120         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2121         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
2122         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
2123         (sawDialog):
2124         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2125         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2126         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2127
2128 2017-05-30  Alex Christensen  <achristensen@webkit.org>
2129
2130         Update libwebrtc configuration
2131         https://bugs.webkit.org/show_bug.cgi?id=172727
2132
2133         Reviewed by Geoffrey Garen.
2134
2135         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2136
2137 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2138
2139         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
2140         https://bugs.webkit.org/show_bug.cgi?id=172702
2141
2142         Reviewed by Alex Christensen.
2143
2144         EGL PlatformDisplay needs to be shut down before existing a
2145         program on Windows.
2146
2147         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
2148         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
2149         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2150         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
2151
2152 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
2153
2154         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
2155         https://bugs.webkit.org/show_bug.cgi?id=172709
2156
2157         Reviewed by Brent Fulgham.
2158
2159         Exit fullscreen mode after a fullscreen test.
2160
2161         * DumpRenderTree/win/DumpRenderTree.cpp:
2162         (resetWebViewToConsistentStateBeforeTesting):
2163
2164 2017-05-30  Antti Koivisto  <antti@apple.com>
2165
2166         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
2167         https://bugs.webkit.org/show_bug.cgi?id=172713
2168
2169         Reviewed by Zalan Bujtas.
2170
2171         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2172         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
2173
2174             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
2175             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
2176             because on Mac WK1 it may get invoked from middle of a layout.
2177
2178             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
2179
2180 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2181
2182         Add a WPE EWS queue
2183         https://bugs.webkit.org/show_bug.cgi?id=172693
2184
2185         Reviewed by Carlos Garcia Campos.
2186
2187         * QueueStatusServer/config/queues.py:
2188         * QueueStatusServer/model/queues.py: Capitalize the name of the
2189         port on the tooltip of the bubbles. Do the same for the GTK port.
2190         (Queue.display_name):
2191         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
2192         for the GTK+ EWS also. Set for both ports as watcher the alias
2193         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
2194         * Scripts/webkitpy/common/config/ports.py:
2195         (DeprecatedPort.port):
2196         (WpePort):
2197         (WpePort.build_webkit_command):
2198         (WpePort.run_webkit_tests_command):
2199         * Scripts/webkitpy/common/config/ports_unittest.py:
2200         (DeprecatedPortTest):
2201         (DeprecatedPortTest.test_wpe_port):
2202         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2203         (test_ews_name):
2204
2205 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
2206
2207         Unreviewed. Bumping the WPEBackend-mesa dependency version.
2208
2209         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
2210         priorities for IPC communication.
2211
2212 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
2213
2214         [JSC] Map and Set constructors should have fast path for cloning
2215         https://bugs.webkit.org/show_bug.cgi?id=172413
2216
2217         Reviewed by Saam Barati.
2218
2219         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2220         (TestWebKitAPI::TEST):
2221
2222 2017-05-27  Zalan Bujtas  <zalan@apple.com>
2223
2224         enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
2225         https://bugs.webkit.org/show_bug.cgi?id=172676
2226
2227         Reviewed by Simon Fraser.
2228
2229         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
2230         (TestWebKitAPI::TEST):
2231
2232 2017-05-26  Zalan Bujtas  <zalan@apple.com>
2233
2234         TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
2235         https://bugs.webkit.org/show_bug.cgi?id=172674
2236
2237         Reviewed by Simon Fraser.
2238
2239         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
2240         (TestWebKitAPI::TEST):
2241
2242 2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2243
2244         Add test resources back into TestWebKitAPI Copy Resources phase
2245
2246         Rubber-stamped by Beth Dakin.
2247
2248         Add two files back into the Copy Resources phase after they were unintentionally
2249         removed in r217447 and r217496.
2250
2251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2252
2253 2017-05-26  Beth Dakin  <bdakin@apple.com>
2254
2255         Media documents inside iframes should not get controls in the TouchBar unless the 
2256         video is playing
2257         https://bugs.webkit.org/show_bug.cgi?id=172620
2258         -and corresponding-
2259         rdar://problem/32165477
2260
2261         Reviewed by Jon Lee.
2262
2263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2264         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2265         (TestWebKitAPI::TEST):
2266         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
2267
2268 2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>
2269
2270         _WKUserStyleSheet and WKUserScript leak string data
2271         https://bugs.webkit.org/show_bug.cgi?id=172583
2272         <rdar://problem/32395209>
2273
2274         Reviewed by Sam Weinig.
2275
2276         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2277         We should not have been adopting an autoreleased object.
2278
2279 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
2280
2281         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
2282         https://bugs.webkit.org/show_bug.cgi?id=172554
2283         <rdar://problem/31247133>
2284
2285         Reviewed by Simon Fraser.
2286
2287         Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
2288         simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
2289         leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
2290         we should just tear down and rebuild the window whenever we need a layer-backed WebView.
2291         We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
2292         codepath.
2293
2294         * DumpRenderTree/TestOptions.h:
2295         * DumpRenderTree/TestOptions.mm:
2296         (TestOptions::TestOptions):
2297         (TestOptions::webViewIsCompatibleWithOptions):
2298         * DumpRenderTree/mac/DumpRenderTree.mm:
2299         (shouldIgnoreWebCoreNodeLeaks):
2300         (allowedFontFamilySet):
2301         (-[DRTMockScroller rectForPart:]):
2302         (-[DRTMockScroller drawKnob]):
2303         (-[DRTMockScroller drawRect:]):
2304         (createWebViewAndOffscreenWindow):
2305         (initializeGlobalsFromCommandLineOptions):
2306         (prepareConsistentTestingEnvironment):
2307         (dumpRenderTree):
2308         (dumpAudio):
2309         (dumpHistoryItem):
2310         (dumpBackForwardListForWebView):
2311         (resetWebViewToConsistentStateBeforeTesting):
2312         (WebThreadLockAfterDelegateCallbacksHaveCompleted):
2313         (runTest):
2314
2315 2017-05-25  Sam Weinig  <sam@webkit.org>
2316
2317         [WebIDL] Use the term 'operation' more consistently
2318         https://bugs.webkit.org/show_bug.cgi?id=172601
2319
2320         Reviewed by Chris Dumez.
2321
2322         We were using the term 'operation', a WebIDL term for function-like
2323         constructs, inconsistently in the code generator. Now, when we use
2324         'operation' when referring to the IDL concept (usually the object the
2325         parser produces) and 'function' when referring to code being generated.
2326
2327         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2328         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2329
2330 2017-05-25  Jer Noble  <jer.noble@apple.com>
2331
2332         Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.
2333
2334         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
2335
2336 2017-05-25  Jer Noble  <jer.noble@apple.com>
2337
2338         System sleeps while playing to wireless target, ending stream.
2339         https://bugs.webkit.org/show_bug.cgi?id=172541
2340
2341         Reviewed by Eric Carlson.
2342
2343         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2344         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
2345         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
2346         (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
2347         (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2348         (TestWebKitAPI::simulateKeyDown):
2349         (TestWebKitAPI::hasAssertionType):
2350         (TestWebKitAPI::TEST):
2351
2352 2017-05-25  Commit Queue  <commit-queue@webkit.org>
2353
2354         Unreviewed, rolling out r217423 and r217424.
2355         https://bugs.webkit.org/show_bug.cgi?id=172607
2356
2357         These caused an api failure on all testers. (Requested by
2358         mlewis13 on #webkit).
2359
2360         Reverted changesets:
2361
2362         "REGRESSION (r216977): 4 leaks introduced in new
2363         WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
2364         https://bugs.webkit.org/show_bug.cgi?id=172558
2365         http://trac.webkit.org/changeset/217423
2366
2367         "REGRESSION (r217423): Fix last-second typo in 'auto'"
2368         http://trac.webkit.org/changeset/217424
2369
2370 2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>
2371
2372         [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
2373         https://bugs.webkit.org/show_bug.cgi?id=172355
2374
2375         Reviewed by Chris Fleizach.
2376
2377         Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
2378         versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
2379         releases which support the new platform footnote accessibility role.
2380
2381         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2382         * gtk/jhbuild.modules:
2383
2384 2017-05-25  David Kilzer  <ddkilzer@apple.com>
2385
2386         REGRESSION (r217423): Fix last-second typo in 'auto'
2387
2388         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2389         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.
2390
2391 2017-05-24  David Kilzer  <ddkilzer@apple.com>
2392
2393         REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
2394         <https://webkit.org/b/172558>
2395
2396         Reviewed by Sam Weinig.
2397
2398         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2399         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.
2400
2401 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
2402
2403         [CMake] Consolidate CMake code related to Cairo
2404         https://bugs.webkit.org/show_bug.cgi?id=172568
2405
2406         Reviewed by Alex Christensen.
2407
2408         * DumpRenderTree/config.h:
2409         * TestWebKitAPI/config.h:
2410
2411 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2412
2413         Plumb additional image metadata to item providers when beginning data interaction on an image
2414         https://bugs.webkit.org/show_bug.cgi?id=172536
2415         <rdar://problem/32371300>
2416
2417         Reviewed by Beth Dakin.
2418
2419         Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
2420         source item providers.
2421
2422         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2423         (checkSuggestedNameAndEstimatedSize):
2424         (TestWebKitAPI::TEST):
2425
2426 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
2427
2428         [Win] Create unique network storage session for each DRT.
2429         https://bugs.webkit.org/show_bug.cgi?id=172540
2430
2431         Reviewed by Brent Fulgham.
2432
2433         During layout testing, each DRT instance should have its own network storage session.
2434
2435         * DumpRenderTree/win/DumpRenderTree.cpp:
2436         (prepareConsistentTestingEnvironment):
2437
2438 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2439
2440         Respect image UTIs when writing to item providers when beginning data interaction on an image
2441         https://bugs.webkit.org/show_bug.cgi?id=172436
2442         <rdar://problem/31786569>
2443
2444         Reviewed by Beth Dakin.
2445
2446         Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
2447         details.
2448
2449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2450         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
2451         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.
2452
2453         Create a new test page containing a GIF and a file input.
2454
2455         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2456         (checkTypeIdentifierIsRegisteredAtIndex):
2457         (TestWebKitAPI::TEST):
2458
2459 2017-05-23  Per Arne Vollan  <pvollan@apple.com>
2460
2461         [Win] Increase test timeout for slow tests.
2462         https://bugs.webkit.org/show_bug.cgi?id=172449
2463
2464         Reviewed by Alexey Proskuryakov.
2465
2466         Instead of using a fixed timeout of 30 seconds for all tests, we should use the
2467         timeout member in the TestRunner class.
2468
2469         * DumpRenderTree/win/TestRunnerWin.cpp:
2470         (TestRunner::setWaitToDump):
2471
2472 2017-05-15  Matt Rajca  <mrajca@apple.com>
2473
2474         Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
2475         https://bugs.webkit.org/show_bug.cgi?id=172138
2476
2477         Reviewed by Alex Christensen.
2478
2479         Added API tests.
2480
2481         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2482         * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
2483         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2484         (TEST):
2485         * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.
2486
2487 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
2488
2489         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
2490         https://bugs.webkit.org/show_bug.cgi?id=172522
2491         rdar://problem/31071812
2492
2493         Reviewed by Sam Weinig.
2494
2495         Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
2496         We set this in the .xib file now.
2497
2498         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2499
2500 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
2501
2502         Snapshotting via -renderInContext: should do synchronous image decodes
2503         https://bugs.webkit.org/show_bug.cgi?id=172485
2504         rdar://problem/32276146
2505
2506         Reviewed by Tim Horton.
2507
2508         New API test.
2509
2510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2511         * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.
2512         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
2513         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
2514         (TestWebKitAPI::getPixelIndex):
2515         (TestWebKitAPI::TEST):
2516
2517 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
2518
2519         Remove dead ENABLE(FONT_LOAD_EVENTS) code
2520         https://bugs.webkit.org/show_bug.cgi?id=172517
2521
2522         Rubber-stamped by Simon Fraser.
2523
2524         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2525
2526 2017-05-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2527
2528         Multiple links should be inserted separately when performing data interaction
2529         https://bugs.webkit.org/show_bug.cgi?id=172489
2530         <rdar://problem/31510832>
2531
2532         Reviewed by Dan Bernstein.
2533
2534         Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.
2535
2536         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2537         (TestWebKitAPI::TEST):
2538
2539 2017-05-23  Tim Horton  <timothy_horton@apple.com>
2540
2541         REGRESSION: API test WebKit2.WKObject is failing
2542         https://bugs.webkit.org/show_bug.cgi?id=172497
2543         <rdar://problem/31694641>
2544
2545         Reviewed by Geoff Garen.
2546
2547         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2548         (TestWebKitAPI::TEST):
2549         Add a test that ensures that we pretend to at least be *some* kind of
2550         NSString, which my first fix would not have passed.
2551
2552 2017-05-23  youenn fablet  <youenn@apple.com>
2553
2554         There should be an easy way to run HTTP/WPT served tests on a browser
2555         https://bugs.webkit.org/show_bug.cgi?id=172068
2556
2557         Reviewed by Sam Weinig.
2558
2559         Adding a new script open-layout-test to open a layout-test in a
2560         browser and making sure it is served as done through run-webkit-tests.
2561         In case tests should be run using a server, detecting whether the
2562         server are running. If not, calling run-webkit-httpd to run the
2563         servers and open the URL in a browser.
2564         Otherwise, open directly the URL.
2565
2566         Adding an option in run-webkit-httpd to open an URL after having
2567         started the servers.
2568
2569         Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
2570         This allows running run-webkit-httpd once and not having to restart
2571         servers everytime a test should be served.
2572
2573         Moving most of run-webkit-httpd logic in its own python file to reuse
2574         it in open-layout-test script.
2575
2576         Adding routines to check whether HTTP and WPT servers are running.
2577
2578         * Scripts/open-layout-test: Added.
2579         (parse_args):
2580         (main):
2581         * Scripts/run-webkit-httpd:
2582         (main):
2583         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2584         (LayoutTestFinder.find_tests):
2585         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2586         (LayoutTestRunner.run_tests):
2587         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2588         (parse_args):
2589         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2590         (HttpServerBase._is_server_running_on_all_ports):
2591         (HttpServerBase):
2592         (HttpServerBase._is_running_on_port):
2593         (HttpServerBase._check_that_all_ports_are_available):
2594         (is_http_server_running):
2595         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.
2596         (parse_args):
2597         (main):
2598         (run_server):
2599         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2600         (is_wpt_server_running):
2601         * Scripts/webkitpy/port/base.py:
2602         (Port.to.is_http_server_running):
2603         (Port.to):
2604         (Port.to.is_wpt_server_running):
2605         (Port.to.start_web_platform_test_server):
2606         * Scripts/webkitpy/port/driver.py:
2607         (DriverProxy.is_web_platform_test):
2608         (DriverProxy):
2609         (DriverProxy.is_webkit_specific_web_platform_test):
2610
2611 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
2612
2613         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
2614         https://bugs.webkit.org/show_bug.cgi?id=171984
2615
2616         Reviewed by Antti Koivisto.
2617
2618         * DumpRenderTree/mac/DumpRenderTree.mm:
2619         (enableExperimentalFeatures):
2620         * WebKitTestRunner/TestController.cpp:
2621         (WTR::TestController::resetPreferencesToConsistentValues):
2622
2623 2017-05-20  Alex Christensen  <achristensen@webkit.org>
2624
2625         REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
2626         https://bugs.webkit.org/show_bug.cgi?id=172406
2627         <rdar://32109532>
2628
2629         Reviewed by Brady Eidson.
2630
2631         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
2632         (TestWebKitAPI::checkBuffer):
2633         (TestWebKitAPI::TEST_F):
2634
2635 2017-05-22  Jason Marcell  <jmarcell@apple.com>
2636
2637         Do not enter Subversion-specific logic when parsing Git-based Trac data.
2638         https://bugs.webkit.org/show_bug.cgi?id=172433
2639         <rdar://problem/32234188>
2640
2641         Reviewed by Alexey Proskuryakov.
2642
2643         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2644         (Trac.prototype._convertCommitInfoElementToObject):
2645
2646 2017-05-22  Tim Horton  <timothy_horton@apple.com>
2647
2648         ExplicitSnapshotsChangeUponNavigation API test often fails
2649         https://bugs.webkit.org/show_bug.cgi?id=172475
2650         <rdar://problem/31688322>
2651
2652         Reviewed by Simon Fraser.
2653
2654         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2655         (-[TestWKWebView _setUpTestWindow:]):
2656         Make TestWKWebView's window layer-backed. This is now the default,
2657         and it's also easy to accidentally write a test that depends on it
2658         (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
2659         which becomes layer backed, just like the WKWebView, but with no
2660         common layer-backed ancestor).
2661
2662 2017-05-22  youenn fablet  <youenn@apple.com>
2663
2664         Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
2665         https://bugs.webkit.org/show_bug.cgi?id=172426
2666
2667         Reviewed by Chris Dumez.
2668
2669         * Scripts/webkitpy/w3c/test_importer.py:
2670         (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.
2671
2672 2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>
2673
2674         Unreviewed, change my status to reviewer and fill "expertise" field
2675
2676         * Scripts/webkitpy/common/config/contributors.json:
2677
2678 2017-05-22  Tomas Popela  <tpopela@redhat.com>
2679
2680         Remove some of the EFL port leftovers
2681         https://bugs.webkit.org/show_bug.cgi?id=172440
2682
2683         Reviewed by Carlos Garcia Campos.
2684
2685         * BuildSlaveSupport/built-product-archive:
2686         (archiveBuiltProduct):
2687         (extractBuiltProduct):
2688         * BuildSlaveSupport/test-result-archive:
2689         (archiveTestResults):
2690         * ImageDiff/PlatformEfl.cmake: Removed.
2691         * Scripts/run-efl-tests: Removed.
2692         * Scripts/webkit-build-directory:
2693         * Scripts/webkitpy/common/config/contributionareas.py:
2694         * Scripts/webkitpy/common/config/watchlist:
2695         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2696         (parse_args):
2697         (_set_up_derived_options):
2698         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2699         (PerfTestsRunner.__init__):
2700         * Scripts/webkitpy/style/checker.py:
2701         * Scripts/webkitpy/style/checker_unittest.py:
2702         (GlobalVariablesTest.test_path_rules_specifier):
2703         * gtk/manifest.txt.in:
2704         * jhbuild/jhbuild-wrapper:
2705
2706 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2707
2708         Unreviewed. Do not include WPE files in GTK+ tarballs.
2709
2710         * gtk/manifest.txt.in:
2711
2712 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2713
2714         [GTK] Add webkit_context_menu_item_new_from_gaction
2715         https://bugs.webkit.org/show_bug.cgi?id=159631
2716
2717         Reviewed by Michael Catanzaro.
2718
2719         Update context menu tests to check the new GAction API.
2720
2721         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2722         (testContextMenuPopulateMenu):
2723
2724 2017-05-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2725
2726         [GTK] Remove Firefox user agent quirk for Google domains
2727         https://bugs.webkit.org/show_bug.cgi?id=171941
2728
2729         Reviewed by Carlos Garcia Campos.
2730
2731         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2732         (TestWebKitAPI::TEST):
2733         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.
2734
2735 2017-05-20  Ting-Wei Lan  <lantw44@gmail.com>
2736
2737         [GTK] gtkdoc-fixxref needs --module argument to work
2738         https://bugs.webkit.org/show_bug.cgi?id=172415
2739
2740         Reviewed by Michael Catanzaro.
2741
2742         * gtk/gtkdoc.py:
2743         (GTKDoc._run_gtkdoc_fixxref):
2744
2745 2017-05-20  Alexey Proskuryakov  <ap@apple.com>
2746
2747         make-new-script-test should create tests that use js-test.js, not js-test-pre.js
2748         https://bugs.webkit.org/show_bug.cgi?id=172416
2749
2750         Reviewed by Daniel Bates.
2751
2752         * Scripts/make-new-script-test:
2753
2754 2017-05-19  Fujii Hironori  <Hironori.Fujii@sony.com>
2755
2756         [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
2757         https://bugs.webkit.org/show_bug.cgi?id=172267
2758
2759         Reviewed by Per Arne Vollan.
2760
2761         TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
2762         TestWebCoreLib should link only with WebCore. And, TestWebKitLib
2763         should link only with WebKit.
2764
2765         Unfortunately, there is a layer violation at the moment.
2766         WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
2767         in WebKit. This change contains a stub of loadResourceIntoBuffer
2768         in TestWebCoreLib for the workaround.
2769
2770         * TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
2771         TestWebCoreLib. Do not link WebCore to TestWebKitLib.
2772         * TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
2773         (loadResourceIntoBuffer): Added a stub.
2774
2775 2017-05-19  Simon Fraser  <simon.fraser@apple.com>
2776
2777         Fix dump-class-layout to handle different file architectures
2778         https://bugs.webkit.org/show_bug.cgi?id=172392
2779
2780         Reviewed by Zalan Bujtas.
2781
2782         Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
2783         and use the first architecture reported. Also add a "--architecture" argument
2784         to allow the user to specify an architecture.
2785
2786         * Scripts/dump-class-layout:
2787         (import_lldb):
2788         (verify_type_recursive):
2789         (get_first_file_architecture):
2790         (dump_class):
2791         (main):
2792         (find_build_directory): Deleted.
2793
2794 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
2795
2796         Unreviewed infrastructure fix.
2797
2798         * Scripts/webkitpy/port/ios_simulator.py:
2799         (IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
2800
2801 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
2802
2803         webkitpy: Use simctl boot to run multiple simulators at once
2804         https://bugs.webkit.org/show_bug.cgi?id=172374
2805
2806         Reviewed by Alexey Proskuryakov.
2807
2808         * Scripts/webkitpy/common/system/platforminfo.py:
2809         (PlatformInfo.xcode_version): Return the current version of Xcode.
2810         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2811         (MockPlatformInfo.xcode_version): Return version 8.0 for testing.
2812         * Scripts/webkitpy/port/ios_simulator.py:
2813         (IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
2814         run multiple Simulator.app instances.
2815         (IOSSimulatorPort._create_simulators): Only copy the simulator app for older
2816         versions of Xcode.
2817         (IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
2818         an older version of Xcode.
2819
2820 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2821
2822         Unreviewed, fix the build on the latest internal SDK.
2823
2824         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2825         (TestWebKitAPI::TEST):
2826
2827 2017-05-19  Filip Pizlo  <fpizlo@apple.com>
2828
2829         arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
2830         https://bugs.webkit.org/show_bug.cgi?id=172369
2831
2832         Reviewed by Mark Lam.
2833         
2834         Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
2835         would be a good idea to write this down.
2836
2837         * Scripts/run-jsc-stress-tests:
2838
2839 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
2840
2841         webkitpy: Layout tests which have no output will succeed
2842         https://bugs.webkit.org/show_bug.cgi?id=172322
2843         <rdar://problem/32258350>
2844
2845         Reviewed by David Kilzer.
2846
2847         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2848         (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.
2849         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2850         (determine_result_type): FailureNotTested means that the test could not be loaded. This
2851         is classified as a MISSING failure.
2852         (FailureNotTested): Added.
2853         (FailureNotTested.message):
2854
2855 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2856
2857         Add SixSpeed benchmark to PerformanceTests
2858         https://bugs.webkit.org/show_bug.cgi?id=172326
2859
2860         Reviewed by Sam Weinig.
2861
2862         * Scripts/run-jsc-benchmarks:
2863
2864 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2865
2866         [WK1] MiniBrowser should navigate when handling a dropped URL
2867         https://bugs.webkit.org/show_bug.cgi?id=172350
2868
2869         Reviewed by Tim Horton.
2870
2871         Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.
2872
2873         * MiniBrowser/mac/WK1BrowserWindowController.m:
2874         (-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
2875
2876 2017-05-18  Ryosuke Niwa  <rniwa@webkit.org>
2877
2878         REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
2879         https://bugs.webkit.org/show_bug.cgi?id=172077
2880
2881         Reviewed by Chris Dumez.
2882
2883         Fixed perftest.py by updating the lines to ignore in Speedometer.
2884
2885         Also start report the results as "Speedometer" instead of "DoYouEvenBench/Full.html" to perf.webkit.org.
2886
2887         * Scripts/webkitpy/performance_tests/perftest.py:
2888         (PerfTest._lines_to_ignore_in_parser_result): Updated for Speedometer 2.0.
2889         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2890         (PerfTestsRunner._collect_tests): Use "Speedometer" instead of "Speedometer/index.html" as the test name.
2891         (_generate_results_dict): Removed the workaround to keep reporting Speedometer as DoYouEvenBench.
2892         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2893         (MainTest.test_collect_tests_with_index_html_and_resources): Added.
2894
2895 2017-05-18  Andy Estes  <aestes@apple.com>
2896
2897         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
2898         https://bugs.webkit.org/show_bug.cgi?id=172305
2899
2900         Reviewed by Anders Carlsson.
2901
2902         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2903
2904 2017-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2905
2906         Selection around attachment elements should not persist when beginning a drag
2907         https://bugs.webkit.org/show_bug.cgi?id=172319
2908         <rdar://problem/32283008>
2909
2910         Reviewed by Tim Horton.
2911
2912         Tests that temporary selection around an attachment does not persist longer than it needs to.
2913
2914         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2915         (TestWebKitAPI::TEST):
2916
2917 2017-05-18  John Wilander  <wilander@apple.com>
2918
2919         Resource Load Statistics: Grandfather domains for existing data records
2920         https://bugs.webkit.org/show_bug.cgi?id=172155
2921         <rdar://problem/24913532>
2922
2923         Reviewed by Alex Christensen.
2924
2925         Adds test infrastructure needed for the added functionality.
2926
2927         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2928         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2929         (WTR::InjectedBundle::didReceiveMessageToPage):
2930         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2931         (WTR::TestRunner::setStatisticsGrandfathered):
2932         (WTR::TestRunner::isStatisticsGrandfathered):
2933         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2934         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
2935         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2936         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2937         * WebKitTestRunner/TestController.cpp:
2938         (WTR::TestController::setStatisticsGrandfathered):
2939         (WTR::TestController::isStatisticsGrandfathered):
2940         (WTR::TestController::setStatisticsGrandfatheringTime):
2941         * WebKitTestRunner/TestController.h:
2942         * WebKitTestRunner/TestInvocation.cpp:
2943         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2944
2945 2017-05-18  Saam Barati  <sbarati@apple.com>
2946
2947         WebAssembly: perform stack checks
2948         https://bugs.webkit.org/show_bug.cgi?id=165546
2949         <rdar://problem/29760307>
2950
2951         Reviewed by Filip Pizlo.
2952
2953         Add some new testing modes for using and not using fast TLS wasm contexts.
2954
2955         * Scripts/run-jsc-stress-tests:
2956
2957 2017-05-18  Daniel Bates  <dabates@apple.com>
2958
2959         REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
2960         window CSP when object-src 'none' is set
2961         https://bugs.webkit.org/show_bug.cgi?id=172038
2962         <rdar://problem/32258262>
2963
2964         Reviewed by Andy Estes.
2965
2966         Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
2967         When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().
2968
2969         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2970         (NPP_New):
2971
2972 2017-05-18  Per Arne Vollan  <pvollan@apple.com>
2973
2974         [Win] Many layout tests are failing.
2975         https://bugs.webkit.org/show_bug.cgi?id=172286
2976
2977         Reviewed by Brent Fulgham.
2978
2979         Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
2980  
2981         * DumpRenderTree/win/TestRunnerWin.cpp:
2982         (TestRunner::grantWebNotificationPermission):
2983         (TestRunner::denyWebNotificationPermission):
2984         (TestRunner::removeAllWebNotificationPermissions):
2985         (TestRunner::simulateWebNotificationClick):
2986
2987 2017-05-18  Don Olmstead  <don.olmstead@am.sony.com>
2988
2989         [Win] Remove usage of _snprintf
2990         https://bugs.webkit.org/show_bug.cgi?id=172251
2991
2992         Reviewed by Per Arne Vollan.
2993
2994         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2995         * MiniBrowser/win/PageLoadTestClient.cpp:
2996         (PageLoadTestClient::dumpRunStatistics):
2997
2998 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
2999
3000         Unreviewed, rolling out r217014.
3001
3002         This change caused mac-wk2 LayoutTests to exit early due to
3003         crashes.
3004
3005         Reverted changeset:
3006
3007         "Resource Load Statistics: Grandfather domains for existing
3008         data records"
3009         https://bugs.webkit.org/show_bug.cgi?id=172155
3010         http://trac.webkit.org/changeset/217014
3011
3012 2017-05-17  John Wilander  <wilander@apple.com>
3013
3014         Resource Load Statistics: Grandfather domains for existing data records
3015         https://bugs.webkit.org/show_bug.cgi?id=172155
3016         <rdar://problem/24913532>
3017
3018         Reviewed by Alex Christensen.
3019
3020         Adds test infrastructure needed for the added functionality.
3021
3022         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3023         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3024         (WTR::InjectedBundle::didReceiveMessageToPage):
3025         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3026         (WTR::TestRunner::setStatisticsGrandfathered):
3027         (WTR::TestRunner::isStatisticsGrandfathered):
3028         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
3029         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
3030         (WTR::TestRunner::setStatisticsGrandfatheringTime):
3031         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3032         * WebKitTestRunner/TestController.cpp:
3033         (WTR::TestController::setStatisticsGrandfathered):
3034         (WTR::TestController::isStatisticsGrandfathered):
3035         (WTR::TestController::setStatisticsGrandfatheringTime):
3036         * WebKitTestRunner/TestController.h:
3037         * WebKitTestRunner/TestInvocation.cpp:
3038         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3039
3040 2017-05-17  Alex Christensen  <achristensen@webkit.org>
3041
3042         Fix ios-simulator API test after r216977
3043         https://bugs.webkit.org/show_bug.cgi?id=171987
3044
3045         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3046         (TEST):
3047         <rdar://problem/32260156> covers the investigation of this, but fixing it is 
3048         not as urgent as having the rest of this working. Notably the ephemeral part of the
3049         test works, so something is just wrong with the persistent part.
3050
3051 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
3052
3053         Unreviewed, rolling out r216955.
3054
3055         This change caused strange behavior with web-platform-tests
3056         locally and on EWS.
3057
3058         Reverted changeset:
3059
3060         "webkitpy: Start servers before setting-up for testing"
3061         https://bugs.webkit.org/show_bug.cgi?id=172176
3062         http://trac.webkit.org/changeset/216955
3063
3064 2017-05-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3065
3066         A URL type is vended for a non-URL plain text string when starting data interaction
3067         https://bugs.webkit.org/show_bug.cgi?id=172228
3068         <rdar://problem/32166729>
3069
3070         Reviewed by Andy Estes.
3071
3072         Adds two new data interaction tests, SinglePlainTextWordTypeIdentifiers and SinglePlainTextURLTypeIdentifiers,
3073         to verify that a URL UTI is not vended when beginning a data interaction on a single word, but that a URL is
3074         still vended when beginning data interaction on something that resembles a link.
3075
3076         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3077
3078 2017-05-17  David Kilzer  <ddkilzer@apple.com>
3079
3080         BlobDataFileReference::generateReplacementFile() should use mkstemp()
3081         <https://webkit.org/b/172192>
3082
3083         Reviewed by Brent Fulgham.
3084
3085         * Scripts/webkitpy/style/checkers/cpp.py:
3086         (check_language): Add check for mktemp.
3087         (CppChecker): Add 'security/temp_file' category.
3088         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3089         (CppStyleTest.test_insecure_temp_file): Add test.
3090
3091 2017-05-17  Devin Rousso  <drousso@apple.com>
3092
3093         Unreviewed, change my email.
3094
3095         * Scripts/webkitpy/common/config/contributors.json:
3096
3097 2017-05-17  Matt Lewis  <jlewis3@apple.com>
3098
3099         Unreviewed, rolling out r216974.
3100
3101         Revision caused consistent timeouts on all platforms.
3102
3103         Reverted changeset:
3104
3105         "Add a RuntimeEnabledFeature for display: contents, defaulted
3106         to false."
3107         https://bugs.webkit.org/show_bug.cgi?id=171984
3108         http://trac.webkit.org/changeset/216974
3109
3110 2017-05-17  Alex Christensen  <achristensen@webkit.org>
3111
3112         Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
3113         https://bugs.webkit.org/show_bug.cgi?id=171987
3114
3115         Reviewed by Brady Eidson.
3116
3117         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3118         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3119         (TEST):
3120
3121 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
3122
3123         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
3124         https://bugs.webkit.org/show_bug.cgi?id=171984
3125
3126         Reviewed by Antti Koivisto.
3127
3128         * DumpRenderTree/mac/DumpRenderTree.mm:
3129         (enableExperimentalFeatures):
3130         * WebKitTestRunner/TestController.cpp:
3131         (WTR::TestController::resetPreferencesToConsistentValues):
3132
3133 2017-05-16  Timothy Horton  <timothy_horton@apple.com>
3134
3135         Fix the build
3136
3137         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3138         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3139
3140 2017-05-16  Tim Horton  <timothy_horton@apple.com>
3141
3142         PageVisibilityStateWithWindowChanges tests sometimes time out
3143         https://bugs.webkit.org/show_bug.cgi?id=172202
3144         <rdar://problem/29653266>
3145
3146         Reviewed by Dean Jackson.
3147
3148         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3149         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3150         Make sure the window is miniaturizable, otherwise, in some cases, miniaturize: will not work.
3151
3152 2017-05-16  Jonathan Bedard  <jbedard@apple.com>
3153
3154         webkitpy: Start servers before setting-up for testing
3155         https://bugs.webkit.org/show_bug.cgi?id=172176
3156         <rdar://problem/32225538>
3157
3158         Reviewed by Alexey Proskuryakov.
3159
3160         On-device testing requires that servers are started before ports set-up their
3161         test environments.
3162
3163         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3164         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
3165         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer.
3166         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3167         (Manager.__init__): Delay construction of the test runner until we can determine
3168         if servers need to be started.
3169         (Manager.run): Determine if servers need to be started and construct the test runner.
3170         (Manager._run_tests): Move the determination of servers to run into Manager.run.
3171
3172 2017-05-16  Adrian Perez de Castro  <aperez@igalia.com>
3173
3174         Unreviewed, adding myself to contributors.json
3175
3176         * Scripts/webkitpy/common/config/contributors.json:
3177
3178 2017-05-16  Claudio Saavedra  <csaavedra@igalia.com>
3179
3180         [GTK] Tests that always pass when run alone, but fail in the bots
3181         https://bugs.webkit.org/show_bug.cgi?id=168572
3182
3183         Reviewed by Michael Catanzaro.
3184
3185         PlatformWebView::viewSupportsOptions() is basically a comparison
3186         that checks that the passed options are the ones supported by the
3187         web view. There is no reason for them to be implemented for each
3188         platform differently. In fact doing so causes issues each time a
3189         new option is added, if the corresponding platform implementation
3190         is not updated accordingly.
3191
3192         A consequence of not updating the viewSupportOptions()
3193         implementations when new options are added is that tests that need
3194         these options might fail if they are executed after a test that
3195         didn't need the option, as the webview will be reused even if the
3196         option is not supported. This cannot be spotted when running the
3197         tests individually. See bug #165133 for other example of the same
3198         problem.
3199
3200         Remove the platform implementations and make the comparison a
3201         method of the TestOptions structure, so that the check is in one
3202         place. For the time being, only include in the comparison the
3203         options that were checked in the mac platform, which seem to be
3204         the only ones relevant this far (unless newer ones have also been
3205         forgotten).
3206
3207         * WebKitTestRunner/PlatformWebView.h:
3208         (WTR::PlatformWebView::viewSupportsOptions): Use the method
3209         defined below.
3210         * WebKitTestRunner/TestOptions.h:
3211         (WTR::TestOptions::hasSameInitializationOptions): Added.
3212         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3213         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3214         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3215         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3216         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3217         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3218         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
3219         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3220
3221 2017-05-15  Yusuke Suzuki  <utatane.tea@gmail.com>
3222
3223         [JSC] Build testapi in non Apple ports
3224         https://bugs.webkit.org/show_bug.cgi?id=172103
3225
3226         Reviewed by Filip Pizlo.
3227
3228         Now testapi is drived in JSCOnly, GTK and WPE ports too.
3229
3230         * Scripts/build-jsc:
3231         * Scripts/run-javascriptcore-tests:
3232
3233 2017-05-15  Youenn Fablet  <youenn@apple.com>
3234
3235         WPT test importer should not account for slow manual tests
3236         https://bugs.webkit.org/show_bug.cgi?id=172127
3237
3238         Reviewed by Ryosuke Niwa.
3239
3240         Making sure manual tests are not triggering updating tests-options.json file.
3241
3242         * Scripts/webkitpy/w3c/test_importer.py:
3243         (TestImporter.find_importable_tests):
3244         (TestImporter._already_identified_as_resource_file):
3245         (TestImporter.update_tests_options):
3246         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3247         (test_manual_slow_test):
3248
3249 2017-05-15  Jonathan Bedard  <jbedard@apple.com>
3250
3251         webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
3252         https://bugs.webkit.org/show_bug.cgi?id=172142
3253
3254         Reviewed by Tim Horton.
3255
3256         * Scripts/webkitpy/xcode/simulator.py:
3257         (Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
3258         around runtime identifiers.
3259         * Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.
3260
3261 2017-05-15  Ryosuke Niwa  <rniwa@webkit.org>
3262
3263         Update ARES-6 plan file to use the latest version
3264         https://bugs.webkit.org/show_bug.cgi?id=172139
3265
3266         Reviewed by Keith Miller.
3267
3268         Include r216538.
3269
3270         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
3271
3272 2017-05-15  Jeremy Jones  <jeremyj@apple.com>
3273
3274         Disable Picture In Picture API tests on unsupported platforms.
3275         https://bugs.webkit.org/show_bug.cgi?id=172125
3276         rdar://problem/32199477
3277
3278         Reviewed by Simon Fraser.
3279
3280         The callbacks and allowing picture-in-picture require new SPI.
3281
3282         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
3283
3284 2017-05-15  Brady Eidson  <beidson@apple.com>
3285
3286         [ios-simulator] API test WKWebView.ClearAppCache is failing.
3287         https://bugs.webkit.org/show_bug.cgi?id=172120
3288
3289         Unreviewed test gardening.
3290
3291         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3292         (TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.
3293           Restoring that code fixes this.
3294
3295 2017-05-15  Timothy Horton  <timothy_horton@apple.com>
3296
3297         Null deref under WebContentReader::readURL when interacting with a file URL
3298         https://bugs.webkit.org/show_bug.cgi?id=172045
3299         <rdar://problem/25880647>
3300
3301         Reviewed by Wenson Hsieh.
3302
3303         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3304         (TestWebKitAPI::TEST):
3305         The text of the file URL is pasted because a textual version of it gets
3306         onto the pasteboard. However, this test would have crashed before. Also
3307         tests that we don't make an <a>.
3308
3309 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
3310
3311         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
3312         https://bugs.webkit.org/show_bug.cgi?id=172071
3313
3314         Reviewed by Alexey Proskuryakov.
3315
3316         * DumpRenderTree/win/DumpRenderTree.cpp:
3317         (resetWebPreferencesToConsistentValues):
3318
3319 2017-05-14  Chris Dumez  <cdumez@apple.com>
3320
3321         Drop PassRefPtr class from WTF
3322         https://bugs.webkit.org/show_bug.cgi?id=172091
3323
3324         Reviewed by Alex Christensen.
3325
3326         Drop API test coverage.
3327
3328         * TestWebKitAPI/Tests/WTF/Ref.cpp:
3329         (TestWebKitAPI::TEST):
3330         (TestWebKitAPI::passWithPassRefPtr): Deleted.
3331
3332 2017-05-13  Eric Carlson  <eric.carlson@apple.com>
3333
3334         [MediaStream] deviceId constraint doesn't work with getUserMedia
3335         https://bugs.webkit.org/show_bug.cgi?id=171877
3336         <rdar://problem/31899730>
3337
3338         Reviewed by Jer Noble.
3339
3340         The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
3341         implement the "checkUserMediaPermission" callback.
3342         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3343         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
3344         (TestWebKitAPI::checkUserMediaPermissionCallback):
3345         (TestWebKitAPI::TEST):
3346
3347         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:
3348         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3349
3350 2017-05-13  Chris Dumez  <cdumez@apple.com>
3351
3352         Stop using RefPtr::release()
3353         https://bugs.webkit.org/show_bug.cgi?id=172074
3354
3355         Reviewed by Geoffrey Garen.
3356
3357         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3358         (TestWebKitAPI::TEST):
3359
3360 2017-05-13  Commit Queue  <commit-queue@webkit.org>
3361
3362         Unreviewed, rolling out r216808.
3363         https://bugs.webkit.org/show_bug.cgi?id=172075
3364
3365         caused lldb to hang when debugging (Requested by smfr on
3366         #webkit).
3367
3368         Reverted changeset:
3369
3370         "Use Mach exceptions instead of signals where possible"
3371         https://bugs.webkit.org/show_bug.cgi?id=171865
3372         http://trac.webkit.org/changeset/216808
3373
3374 2017-05-12  Alex Christensen  <achristensen@webkit.org>
3375
3376         Rename WKContentExtension to WKContentRuleList
3377         https://bugs.webkit.org/show_bug.cgi?id=172053
3378         <rdar://problem/32141005>
3379
3380         Reviewed by Geoffrey Garen.
3381
3382         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:
3383         (WKContentRuleListStoreTest::SetUp):
3384         (TEST_F):
3385         (-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3386         (WKContentExtensionStoreTest::SetUp): Deleted.
3387         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3388
3389 2017-05-12  Keith Miller  <keith_miller@apple.com>
3390
3391         Use Mach exceptions instead of signals where possible
3392         https://bugs.webkit.org/show_bug.cgi?id=171865
3393
3394         Reviewed by Mark Lam.
3395
3396         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3397         (runThreadMessageTest):
3398         (TEST):
3399
3400 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
3401
3402         Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
3403         https://bugs.webkit.org/show_bug.cgi?id=172048
3404         rdar://problem/32163054
3405
3406         Reviewed by Simon Fraser.
3407
3408         Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.
3409
3410         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
3411         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
3412         (hasVideoInPictureInPictureDidChange):
3413         (-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
3414         (-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
3415         (TestWebKitAPI::TEST):
3416
3417 2017-05-12  Brady Eidson  <beidson@apple.com>
3418
3419         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3420         https://bugs.webkit.org/show_bug.cgi?id=172030
3421
3422         Unreviewed - Test gardening
3423
3424         Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
3425         before the test starts.
3426
3427         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3428         (defaultWebsiteCacheDirectory):
3429         (defaultApplicationCacheDirectory):
3430         (TEST):
3431         (defaultWebsiteDataDirectory): Deleted.
3432
3433 2017-05-12  David Quesada  <david_quesada@apple.com>
3434
3435         Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
3436         https://bugs.webkit.org/show_bug.cgi?id=172000
3437         rdar://problem/32144756
3438
3439         Reviewed by Simon Fraser.
3440
3441         Added API tests to verify that WKWebView provides the expected value for
3442         _visibleContentRect in various configurations. (i.e. not inside a scrollview,
3443         inside a scrollview but not clipped, clipped by an ancestor scrollview,
3444         clipped by the webview's _enclosingViewForExposedRectComputation)
3445
3446         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3447         * TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.
3448         (-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
3449         (TestWebKitAPI::TEST):
3450
3451 2017-05-12  Brady Eidson  <beidson@apple.com>
3452
3453         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3454         https://bugs.webkit.org/show_bug.cgi?id=172030
3455
3456         Unreviewed - Test gardening, in effect...
3457
3458         More exploration as to why this continues to fail on the bots.
3459         
3460         This change should give us a smoking gun.
3461         
3462         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3463         (TEST):
3464
3465 2017-05-12  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3466
3467         [GTK] Fix compile warnings in PlatformImageCairo.cpp
3468         https://bugs.webkit.org/show_bug.cgi?id=171850
3469
3470         Reviewed by Michael Catanzaro.
3471
3472         * ImageDiff/cairo/PlatformImageCairo.cpp:
3473         (ImageDiff::PlatformImage::createFromStdin):
3474         (ImageDiff::PlatformImage::writeAsPNGToStdout):
3475
3476 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
3477
3478         Add UIClient callback for when picture-in-picture is activated.
3479         https://bugs.webkit.org/show_bug.cgi?id=172023
3480
3481         Reviewed by Simon Fraser.
3482
3483         Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.
3484
3485         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3486         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
3487         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.
3488         (onLoadedCompletedCallback):
3489         (waitUntilOnLoadIsCompleted):
3490         (didFinishLoadForFrame):
3491         (setHasVideoInPictureInPicture):
3492         (TestWebKitAPI::TEST):
3493
3494 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
3495
3496         Unreviewed follow-up to r216776.
3497
3498         * Scripts/webkitpy/port/base.py:
3499         (Port.path_to_crash_logs): Raise not implemented.
3500         * Scripts/webkitpy/port/test.py:
3501         (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
3502         * Scripts/webkitpy/port/win.py:
3503         (WinPort.path_to_crash_logs): Ditto.
3504
3505 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
3506
3507         Bot watcher's dashboard shows results links twice sometimes
3508         https://bugs.webkit.org/show_bug.cgi?id=172043
3509
3510         Reviewed by Tim Horton.
3511
3512         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3513         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
3514
3515 2017-05-12  Brady Eidson  <beidson@apple.com>
3516
3517         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
3518         https://bugs.webkit.org/show_bug.cgi?id=172030
3519
3520         Unreviewed - Test gardening, in effect...
3521
3522         This failure is only being seen by the bots.
3523         
3524         I believe this test is utterly broken in the first place; when it checks the .wal file's
3525         size that is not actually an indicator that the records were deleted.
3526         
3527         But that isn't what's coming up as failure on the bots.
3528         
3529         This patch is an attempt to:
3530         1 - More forcefully clear the Website data directory of leftovers before the test starts.
3531         2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.
3532
3533         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3534         (defaultWebsiteDataDirectory):
3535         (defaultApplicationCacheDirectory):
3536         (TEST):
3537
3538 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
3539
3540         webkitpy: Pass directory with crash logs into CrashLogs
3541         https://bugs.webkit.org/show_bug.cgi?id=172033
3542         <rdar://problem/32157616>
3543
3544         Reviewed by Daniel Bates.
3545
3546         Refactor CrashLogs and the callers of CrashLogs so that the port object owns
3547         the location of crash logs.
3548
3549         * Scripts/webkitpy/common/system/crashlogs.py:
3550         (CrashLogs.__init__): Pass mandatory crash_log_directory when constructing.
3551         (CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
3552         generating one.
3553         (CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
3554         self._results_directory.
3555         (CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
3556         generating one.
3557         (CrashLogs._log_directory_darwin): Moved to port.
3558         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path
3559         to the crash log is no longer owned by CrashLogs.
3560         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general
3561         directory for uploading crash logs. Note that crash logs are only supported on Mac
3562         and Windows.
3563         * Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
3564         * Scripts/webkitpy/port/base.py:
3565         (Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
3566         to be in the results directory.
3567         * Scripts/webkitpy/port/darwin.py:
3568         (DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
3569         (DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
3570         (DarwinPort._get_crash_log): Ditto.
3571         * Scripts/webkitpy/port/darwin_testcase.py:
3572         (DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
3573         the path to crash logs.
3574         * Scripts/webkitpy/port/ios_device.py:
3575         (IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.
3576         * Scripts/webkitpy/port/ios_device_unittest.py:
3577         (IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.
3578         * Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
3579         * Scripts/webkitpy/port/mac.py: Ditto.
3580         * Scripts/webkitpy/port/test.py:
3581         (TestDriver.run_test): Use port specific crash log path when retrieving crash logs.
3582         * Scripts/webkitpy/port/win.py:
3583         (WinPort._get_crash_log): Ditto.
3584         * Scripts/webkitpy/tool/commands/queries.py:
3585         (execute): Construct a port object since this is the object which owns the path to crash logs.
3586
3587 2017-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3588
3589         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.
3590
3591         In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
3592         URL parameter using the default value "about:blank" when not provided.
3593
3594         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3595         (testWebViewCreateNavigationData):
3596
3597 2017-05-11  Youenn Fablet  <youenn@apple.com>
3598
3599         Allow WPT server to serve specific WebKit test
3600         https://bugs.webkit.org/show_bug.cgi?id=171479
3601
3602         Reviewed by Ryosuke Niwa.
3603
3604         Adding a new mount point to WPT server.
3605         It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.
3606
3607         Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.
3608
3609         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3610         (Manager.__init__):
3611         (Manager._is_http_test):
3612         (Manager._needs_web_platform_test):
3613         (Manager._run_tests):
3614         (Manager._is_web_platform_test): Deleted.
3615         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3616         (build_routes):
3617         (main):
3618         * Scripts/webkitpy/port/driver.py:
3619         (Driver):
3620         (Driver.is_webkit_specific_web_platform_test):
3621         (Driver.test_to_uri):
3622         (Driver._command_from_driver_input):
3623
3624 2017-05-11  Brady Eidson  <beidson@apple.com>
3625
3626         [WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
3627         <rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994
3628
3629         Reviewed by Andy Estes.
3630         Informal review by Maureen Daum.
3631
3632         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3633         (TEST):
3634
3635 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
3636
3637         REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
3638         https://bugs.webkit.org/show_bug.cgi?id=171989
3639
3640         Reviewed by Brian Burg.
3641
3642         * lldb/lldb_webkit.py:
3643         (WTFStringImplProvider.get_data8):
3644         (WTFStringImplProvider.get_data16):
3645         m_data8 and m_data16 are now part of the superclass StringImplShape
3646         instead of directly in StringImpl. So first get the shape by getting
3647         index 0, and the data properties are the same offset within that.
3648
3649 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
3650
3651         Remove Vibration API
3652         https://bugs.webkit.org/show_bug.cgi?id=171766
3653
3654         Rubber-stamped by Alexey Proskuryakov.
3655
3656         * Scripts/webkitperl/FeatureList.pm:
3657
3658 2017-05-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3659
3660         Add WPE release bots
3661         https://bugs.webkit.org/show_bug.cgi?id=171973
3662
3663         Reviewed by Žan Doberšek.
3664
3665         This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
3666         It also adds a new WPE buildbot category.
3667
3668         * BuildSlaveSupport/build.webkit.org-config/config.json:
3669         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3670         (InstallWpeDependencies):
3671         (appendCustomBuildFlags):
3672         (Factory.__init__):
3673         (loadBuilderConfig):
3674         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3675         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3676
3677 2017-05-09  Sam Weinig  <sam@webkit.org>
3678
3679         Remove support for legacy Notifications
3680         https://bugs.webkit.org/show_bug.cgi?id=171487
3681
3682         Reviewed by Jon Lee.
3683
3684         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3685         (DRTDesktopNotificationPresenter::checkNotificationPermission):
3686         * Scripts/webkitperl/FeatureList.pm:
3687         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3688         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
3689
3690 2017-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3691
3692         Remove user agent quirk for Slack
3693         https://bugs.webkit.org/show_bug.cgi?id=171869
3694
3695         Reviewed by Carlos Garcia Campos.
3696
3697         Remove the corresponding test.
3698
3699         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3700         (TestWebKitAPI::TEST):
3701
3702 2017-05-10  Commit Queue  <commit-queue@webkit.org>
3703
3704         Unreviewed, rolling out r216578.
3705         https://bugs.webkit.org/show_bug.cgi?id=171920
3706
3707         Broke the GTK+ build with Wayland enabled (Requested by KaL on
3708         #webkit).
3709
3710         Reverted changeset:
3711
3712         "[GTK] Bump GTK+ and its dependencies in jhbuild"
3713         https://bugs.webkit.org/show_bug.cgi?id=171918
3714         http://trac.webkit.org/changeset/216578
3715
3716 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3717
3718         [GTK] Bump GTK+ and its dependencies in jhbuild
3719         https://bugs.webkit.org/show_bug.cgi?id=171918
3720
3721         Reviewed by Carlos Alberto Lopez Perez.
3722
3723         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3724         (WTR::initializeGtkSettings):
3725         * gtk/jhbuild.modules:
3726         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
3727         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
3728
3729 2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>
3730
3731         [Win] Set CMake args in build-webkit
3732         https://bugs.webkit.org/show_bug.cgi?id=171436
3733
3734         Reviewed by Per Arne Vollan.
3735
3736         * Scripts/build-webkit:
3737
3738 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3739
3740         ImageDiff: Add CG implementation for new ImageDiff
3741         https://bugs.webkit.org/show_bug.cgi?id=170608
3742
3743         Reviewed Alex Christensen.
3744
3745         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3746         * DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
3747         * DumpRenderTree/win/ImageDiffWin.cpp: Removed.
3748         * ImageDiff/CMakeLists.txt:
3749         * ImageDiff/Cairo.cmake:
3750         * ImageDiff/ImageDiff.cpp:
3751         (main):
3752         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3753         * ImageDiff/PlatformImage.cpp:
3754         * ImageDiff/PlatformImage.h:
3755         * ImageDiff/cairo/PlatformImageCairo.cpp:
3756         * ImageDiff/cg/ImageDiff.cpp: Removed.
3757         * ImageDiff/cg/PlatformImageCG.cpp: Added.
3758         (ImageDiff::PlatformImage::createFromStdin):
3759         (ImageDiff::PlatformImage::createFromDiffData):
3760         (ImageDiff::PlatformImage::PlatformImage):
3761         (ImageDiff::PlatformImage::~PlatformImage):
3762         (ImageDiff::PlatformImage::width):
3763         (ImageDiff::PlatformImage::height):
3764         (ImageDiff::PlatformImage::rowBytes):
3765         (ImageDiff::PlatformImage::hasAlpha):
3766         (ImageDiff::PlatformImage::pixels):
3767         (ImageDiff::PlatformImage::writeAsPNGToStdout):
3768
3769 2017-05-10  Zan Dobersek  <zdobersek@igalia.com>
3770
3771         Enable FTL JIT by default on AArch64
3772         https://bugs.webkit.org/show_bug.cgi?id=144039
3773
3774         Reviewed by Yusuke Suzuki.
3775
3776         * Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
3777         * Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
3778         as an unsupported FTL platform.
3779         * Scripts/webkitdirs.pm:
3780         (isARM64): Returns 1 if the determined architecture is 'arm64'.
3781         * Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
3782
3783 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
3784
3785         webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
3786         https://bugs.webkit.org/show_bug.cgi?id=170857
3787         <rdar://problem/31635373>
3788
3789         Reviewed by Aakash Jain.
3790
3791         Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
3792         code to search for crash logs.
3793
3794         * Scripts/webkitpy/port/darwin.py:
3795         (DarwinPort._get_crash_log): Moved from MacPort.
3796         * Scripts/webkitpy/port/darwin_testcase.py:
3797         (DarwinTest.test_get_crash_log): Moved from MacTest.
3798         * Scripts/webkitpy/port/ios_device.py:
3799         (IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
3800         devices must search for crash-logs remotely.
3801         * Scripts/webkitpy/port/ios_simulator.py:
3802         (IOSSimulatorPort._get_crash_log): Deleted.
3803         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3804         (IOSSimulatorTest.test_get_crash_log): Deleted.
3805         * Scripts/webkitpy/port/mac.py:
3806         (MacPort._get_crash_log): Moved to DarwinPort
3807         * Scripts/webkitpy/port/mac_unittest.py:
3808         (MacTest.test_get_crash_log): Moved to DarwinTest.
3809
3810 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
3811
3812         build ImageDiff with host SDK from Make
3813         https://bugs.webkit.org/show_bug.cgi?id=171835
3814
3815         Reviewed by Alexey Proskuryakov.
3816
3817         ImageDiff should be built for the default SDK and default architecture when
3818         the SDKROOT is set to either iOS device or iOS simulator. Check the
3819         DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.
3820
3821         * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
3822         * Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.
3823
3824 2017-05-09  Matt Lewis  <jlewis3@apple.com>
3825
3826         Unreviewed, adding myself to contributors.json
3827
3828         * Scripts/webkitpy/common/config/contributors.json:
3829
3830 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
3831
3832         REGRESSION: ImageDiff not building with make
3833         https://bugs.webkit.org/show_bug.cgi?id=171788
3834
3835         Reviewed by Alex Christensen.
3836
3837         * Makefile: Build ImageDiff for all platforms.
3838
3839 2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3840
3841         [Win] ImageDiff isn't built since Bug 168945
3842         https://bugs.webkit.org/show_bug.cgi?id=171847
3843
3844         Reviewed by Alex Christensen.
3845
3846         * CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
3847         * ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
3848         * ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.
3849
3850 2017-05-09  Zan Dobersek  <zdobersek@igalia.com>
3851
3852         Upstream the WPE port
3853         https://bugs.webkit.org/show_bug.cgi?id=171110
3854
3855         Reviewed by Alex Christensen.
3856
3857         webkit-dev thread:
3858         https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html
3859
3860         Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
3861         In-file changes removed from this ChangeLog entry for brevity.
3862
3863         * BuildSlaveSupport/built-product-archive:
3864         * BuildSlaveSupport/test-result-archive:
3865         * CMakeLists.txt:
3866         * ImageDiff/PlatformWPE.cmake: Added.
3867         * Scripts/build-dumprendertree:
3868         * Scripts/build-webkit:
3869         * Scripts/build-webkittestrunner:
3870         * Scripts/update-webkit-libs-jhbuild:
3871         * Scripts/update-webkitwpe-libs: Added.
3872         * Scripts/webkitdirs.pm:
3873         * Scripts/webkitperl/FeatureList.pm:
3874         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3875         * Scripts/webkitpy/port/factory.py:
3876         * Scripts/webkitpy/port/wpe.py: Added.
3877         * TestWebKitAPI/PlatformWPE.cmake: Added.
3878         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3879         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
3880         * TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3881         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3882         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3883         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3884         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3885         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3886         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3887         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
3888         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
3889         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
3890         * WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3891         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3892         * WebKitTestRunner/PlatformWPE.cmake: Added.
3893         * WebKitTestRunner/PlatformWebView.h:
3894         * WebKitTestRunner/TestController.cpp:
3895         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
3896         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
3897         * WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
3898         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
3899         * WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
3900         * WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
3901         * jhbuild/jhbuild-wrapper:
3902         * wpe/generate-inspector-gresource-manifest.py: Added.
3903         * wpe/jhbuild.modules: Added.
3904         * wpe/jhbuildrc: Added.
3905         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
3906         * wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
3907         * wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
3908         * wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
3909         * wpe/patches/glib-warning-fix.patch: Added.
3910         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
3911         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
3912         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3913         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3914         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.
3915
3916 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
3917
3918         Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
3919         https://bugs.webkit.org/show_bug.cgi?id=169421
3920         <rdar://problem/30950171>
3921
3922         Reviewed by Tim Horton.
3923
3924         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3925         (createBitmapContextFromWebView): Implement for IOSurface.
3926         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3927         (WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.
3928
3929 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
3930
3931         buildbot: Cleanup simulators after running tests
3932         https://bugs.webkit.org/show_bug.cgi?id=171679
3933
3934         Reviewed by Aakash Jain.
3935
3936         simctl is partitioned for each user. Since kill-old-processes
3937         is run as root, we need to specify the buildbot user when tearing
3938         down simulators between steps.
3939
3940         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3941         (KillOldProcesses): Pass buildbot user to kill-old-processes.
3942         * BuildSlaveSupport/kill-old-processes:
3943         (main): Specify the user for simctl if one has been provided.
3944
3945 2017-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3946
3947         REGRESSION(r216179): [GTK] Script install-dependencies misses liborc
3948         https://bugs.webkit.org/show_bug.cgi?id=171681
3949
3950         Reviewed by Carlos Garcia Campos.
3951
3952         * gtk/install-dependencies:
3953
3954 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3955
3956         Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.
3957
3958         Glib uses now Unicode quotes in error messages.
3959
3960         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
3961         (testWebKitConsoleMessageNetworkError):
3962
3963 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3964
3965         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404.
3966
3967         Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
3968         should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
3969         characters to the input. Also fix typo in the function name.
3970
3971         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3972         (testWebViewJavaScriptDialogs):
3973
3974 2017-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3975
3976         [GTK] Cannot sign in with new Google sign-in page
3977         https://bugs.webkit.org/show_bug.cgi?id=171770
3978
3979         Unreviewed. This just adds a test.
3980
3981         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3982         (TestWebKitAPI::TEST):
3983
3984 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
3985
3986         [iOS WK2] Make rotation tests more reliable
3987         https://bugs.webkit.org/show_bug.cgi?id=171778
3988
3989         Reviewed by Tim Horton.
3990
3991         Switching between "safari-style" rotation and normal rotation left state on the WKWebView
3992         that would cause later viewport-sensitive tests to fail. The WKWebView would be left
3993         with override layout parameters, and an override orientation, and these caused viewport
3994         size to leak into later tests, and WebCore orientation to not get reset correctly.
3995
3996         Also, WKWebView was unregistering for UIWindowDidRotateNotification notifications when
3997         an override orientation was set, and would never re-register, causing lost orientationchanged
3998         events.
3999
4000         Fix by exposing WKWebView SPI to clear the various bits of overide state. Also don't unregister
4001         from the UIWindowDidRotateNotification notification; it's already ignored anyway if it fires.
4002
4003         Also wait for a visible content rect update after resizing the WKWebVeiw between tests, to make sure
4004         the WebProcess is caught up before proceeding with the test.
4005
4006         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4007         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
4008         * WebKitTestRunner/ios/TestControllerIOS.mm:
4009         (WTR::TestController::platformResetStateToConsistentValues):
4010         (WTR::TestController::platformConfigureViewForTest):
4011
4012 2017-05-06  Csaba Osztrogonác  <ossy@webkit.org>
4013
4014         [Mac][cmake] Buildfix after r216047
4015         https://bugs.webkit.org/show_bug.cgi?id=171769
4016
4017         Unreviewed buildfix.
4018
4019         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4020
4021 2017-05-05  Brady Eidson  <beidson@apple.com>
4022
4023         API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
4024         <rdar://problem/31977294> and https://bugs.webkit.org/show_bug.cgi?id=171513
4025
4026         Reviewed by Andy Estes.
4027
4028         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
4029         (TEST):
4030
4031 2017-05-05  Brian Burg  <bburg@apple.com>
4032
4033         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
4034         https://bugs.webkit.org/show_bug.cgi?id=171748
4035         <rdar://problem/32027327>
4036
4037         Reviewed by Michael Catanzaro.
4038
4039         Remove temporary workaround now that the assertion failure is fixed.
4040
4041         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
4042         (TEST):
4043
4044 2017-05-05  Simon Fraser  <simon.fraser@apple.com>
4045
4046         Make it possible to test rotation in iOS WebKitTestRunner
4047         https://bugs.webkit.org/show_bug.cgi?id=171755
4048
4049         Reviewed by Tim Horton.
4050
4051         Add to UIScriptController:
4052             void simulateRotation(DeviceOrientation orientation, object callback);
4053             void simulateRotationLikeSafari(DeviceOrientation orientation, object callback);
4054
4055         The former just does a view resize, as a simple WKWebView app would do. The second does
4056         animation more like MobileSafari, using _begin/_endAnimatedResize. and associated override
4057         layout size and interface orientation. The two behaviors produce different resize and
4058         orientationchange events and sizes, and both need to be tested.
4059
4060         Rotation is initiated by a call on UIDevice, and responded to by the root view controller,
4061         which is now a custom subclass (PlatformWebViewController).
4062
4063         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4064         (WTR::UIScriptController::simulateRotation):
4065         (WTR::UIScriptController::simulateRotationLikeSafari):
4066         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4067         (WTR::UIScriptController::simulateRotation):
4068         (WTR::UIScriptController::simulateRotationLikeSafari):
4069         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4070         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4071         (WTR::toDeviceOrientation):
4072         (WTR::UIScriptController::simulateRotation):
4073         (WTR::UIScriptController::simulateRotationLikeSafari):
4074         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4075         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4076         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4077         (-[TestRunnerWKWebView dealloc]):
4078         (-[TestRunnerWKWebView _didEndRotation]):
4079         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4080         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
4081         (WTR::PlatformWebView::PlatformWebView):
4082         * WebKitTestRunner/ios/TestControllerIOS.mm:
4083         (WTR::TestController::platformResetStateToConsistentValues):
4084         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4085         (WTR::toUIDeviceOrientation):
4086         (WTR::UIScriptController::simulateRotation):
4087         (WTR::UIScriptController::simulateRotationLikeSafari):
4088         (WTR::UIScriptController::platformClearAllCallbacks):
4089         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4090         (WTR::UIScriptController::simulateRotation):
4091         (WTR::UIScriptController::simulateRotationLikeSafari):
4092
4093 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
4094
4095         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
4096         https://bugs.webkit.org/show_bug.cgi?id=168945
4097         <rdar://problem/30745695>
4098
4099         Reviewed by David Kilzer.
4100
4101         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
4102         target SDK. These two changes must happen simultaneously because some archives will
4103         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
4104
4105         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
4106         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
4107         tools directory still includes ImageDiff.
4108         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
4109         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
4110         * Scripts/webkitpy/port/darwin.py: 
4111         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
4112         locally or when running archives.
4113         * Scripts/webkitpy/port/image_diff.py:
4114         (IOSSimulatorImageDiffer): Deleted.
4115         * Scripts/webkitpy/port/ios_simulator.py:
4116         (IOSSimulatorPort.diff_image): Deleted.
4117
4118 2017-05-05  Brian Burg  <bburg@apple.com>
4119
4120         API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
4121         https://bugs.webkit.org/show_bug.cgi?id=171748
4122
4123         Unreviewed test gardening.
4124
4125         The assertion failure will be investigated separately in order to avoid rolling out
4126         the fix for "secure" cookies. This assertion fails even without r216258 applied.
4127
4128         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
4129         (TEST):
4130
4131 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
4132
4133         Unreviewed, rolling out r216260.
4134
4135         Breaks internal iOS testers
4136
4137         Reverted changeset:
4138
4139         "Use ImageDiff built by host SDK and remove ImageDiff from
4140         DumpRenderTree"
4141         https://bugs.webkit.org/show_bug.cgi?id=168945
4142         http://trac.webkit.org/changeset/216260
4143
4144 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
4145
4146         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
4147         https://bugs.webkit.org/show_bug.cgi?id=168945
4148         <rdar://problem/30745695>
4149
4150         Reviewed by David Kilzer.
4151
4152         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
4153         target SDK. These two changes must happen simultaneously because some archives will
4154         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
4155
4156         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
4157         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
4158         tools directory still includes ImageDiff.
4159         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
4160         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
4161         * Scripts/webkitpy/port/darwin.py: 
4162         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
4163         locally or when running archives.
4164         * Scripts/webkitpy/port/image_diff.py:
4165         (IOSSimulatorImageDiffer): Deleted.
4166         * Scripts/webkitpy/port/ios_simulator.py:
4167         (IOSSimulatorPort.diff_image): Deleted.
4168
4169 2017-05-05  Brian Burg  <bburg@apple.com>
4170
4171         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
4172         https://bugs.webkit.org/show_bug.cgi?id=171700
4173         <rdar://problem/32017975>
4174
4175         Reviewed by Brady Eidson.
4176
4177         Fix a mistake in the test that should have caught this bug.
4178
4179         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
4180         (TEST):
4181         The assertions that were meant to check round-tripping were actually checking
4182         the properties of the original cookie objects, not the round-tripped ones.
4183         This test now fails without the bugfix and passes when it is applied.
4184
4185 2017-05-05  Daniel Bates  <dabates@apple.com>
4186
4187         Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
4188         https://bugs.webkit.org/show_bug.cgi?id=171698
4189
4190         Reviewed by Darin Adler.
4191
4192         We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
4193         so that we get pretty diff output when the actual string differs from the expected
4194         string as opposed to seeing a boolean result. The former makes makes it straightforward
4195         to diagnose a regression without reading the code for the test or instrumenting it to
4196         determine the actual string that was compared.
4197
4198         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4199         (TestWebKitAPI::TEST):
4200         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
4201         (TestWebKitAPI::TEST_F):
4202         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
4203         (TestWebKitAPI::TEST_F):
4204
4205 2017-05-05  Chris Dumez  <cdumez@apple.com>
4206
4207         Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
4208         https://bugs.webkit.org/show_bug.cgi?id=171624
4209
4210         Reviewed by Dan Bernstein.
4211
4212         Extend API test coverage to cover crashes in addition to terminations requested by the client.
4213
4214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4215         * TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp.
4216         (TestWebKitAPI::webProcessWasTerminatedByClient):
4217         (TestWebKitAPI::webProcessCrashed):
4218         (TestWebKitAPI::TEST):
4219
4220 2017-05-04  Mark Lam  <mark.lam@apple.com>
4221
4222         DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
4223         https://bugs.webkit.org/show_bug.cgi?id=171716
4224         <rdar://problem/30878027>
4225
4226         Reviewed by Saam Barati.
4227
4228         setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
4229         does JS conversion and therefore, potentially JS allocations) and accessing
4230         methods of internal JS data structures (which may do JS invocation, etc).
4231
4232         * DumpRenderTree/TestRunner.cpp:
4233         (setAudioResultCallback):
4234
4235 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
4236
4237         buildbot: Cleanup simulators after running tests
4238         https://bugs.webkit.org/show_bug.cgi?id=171679
4239         <rdar://problem/31994361>
4240
4241         Reviewed by Aakash Jain.
4242
4243         We shutdown the simulator process between tests, but in some cases, this is not
4244         sufficient. Explicitly shutdown every booted simulator.
4245
4246         * BuildSlaveSupport/kill-old-processes:
4247         (main): Shutdown all booted simulators.
4248
4249 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
4250
4251         [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
4252         https://bugs.webkit.org/show_bug.cgi?id=171644
4253
4254         Reviewed by Michael Catanzaro.
4255
4256         Check that only one WebKitWebContext can have automation enabled.
4257
4258         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
4259         (testAutomationSessionRequestSession):
4260
4261 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
4262
4263         [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
4264         https://bugs.webkit.org/show_bug.cgi?id=171724
4265
4266         Reviewed by Michael Catanzaro.
4267
4268         It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
4269
4270         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4271         (WTR::timeoutSource):
4272
4273 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
4274
4275         Unreviewed. Fix wrong assert after r215176.
4276
4277         Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
4278         could also be RGB24 when created from a web view snapshot.
4279
4280         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
4281         (WTR::computeMD5HashStringForCairoSurface):
4282
4283 2017-05-04  Brian Burg  <bburg@apple.com>
4284
4285         lldb_webkit.py should provide a type summary for WebCore::URL
4286         https://bugs.webkit.org/show_bug.cgi?id=171670
4287
4288         Reviewed by Jer Noble.
4289
4290         Just print out the underlying string using the WTFString provider.
4291
4292         * lldb/lldb_webkit.py:
4293         (__lldb_init_module):
4294         (WebCoreURL_SummaryProvider):
4295         (WebCoreURLProvider):
4296         (WebCoreURLProvider.__init__):
4297         (WebCoreURLProvider.to_string):
4298
4299 2017-05-04  Commit Queue  <commit-queue@webkit.org>
4300
4301         Unreviewed, rolling out r216206.
4302 &nb