Tools/ChangeLog

   1 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
   2
   3         [BUILD] use detected python to run generate-gtkdoc
   4         https://bugs.webkit.org/show_bug.cgi?id=80695
   5
   6         Reviewed by Gustavo Noronha Silva.
   7
   8         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
   9
  10 2012-03-09  Nat Duca  <nduca@chromium.org>
  11
  12         Make check-webkit-style complain about "no new tests" lines in changelogs
  13         https://bugs.webkit.org/show_bug.cgi?id=80582
  14
  15         Reviewed by David Levin.
  16
  17         * Scripts/webkitpy/style/checkers/changelog.py:
  18         (ChangeLogChecker.check_entry):
  19         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
  20         (ChangeLogCheckerTest.test_no_new_tests):
  21
  22 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
  23
  24         Unreviewed, rolling out r110250.
  25         http://trac.webkit.org/changeset/110250
  26         https://bugs.webkit.org/show_bug.cgi?id=80682
  27
  28         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
  29         qt-linux at all. (Requested by Ossy on #webkit).
  30
  31         * Scripts/old-run-webkit-tests:
  32         * Scripts/webkitpy/layout_tests/port/qt.py:
  33         (QtPort):
  34         (QtPort.determine_full_port_name):
  35         (QtPort.baseline_search_path):
  36         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  37         (QtPortTest):
  38         (QtPortTest._assert_search_path):
  39         (QtPortTest.test_baseline_search_path):
  40
  41 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
  42
  43         [Qt] Use Qt's module system for install rules and depending on QtWebKit
  44
  45         Instead of rolling our own install rules we now use the same approach as
  46         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
  47
  48         This ensures that we follow the same semantics as the rest of Qt on
  49         what sort of config options are enabled by default (create_cmake eg.).
  50         It also allows us to use QT += webkit instead of the workaround we had
  51         with CONFIG += qtwebkit.
  52
  53         We do however force Qt to always treat our build as a non-developer build,
  54         so the libraries will end up in the WebKit lib directory instead of the
  55         qtbase directory (as with a normal developer-build). This allows us to
  56         keep the webkit-build self-contained. If Qt is a developer build we still
  57         copy the module file manually to Qt, so that you don't have to install
  58         WebKit to make it available.
  59
  60         For non-developer builds of Qt, it is still possible to use the built
  61         WebKit libraries without having to install them, by having the variable
  62         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
  63         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
  64
  65         https://bugs.webkit.org/show_bug.cgi?id=80590
  66
  67         Reviewed by Simon Hausmann.
  68
  69         * DumpRenderTree/qt/DumpRenderTree.pro:
  70         * MiniBrowser/qt/BrowserWindow.cpp:
  71         * MiniBrowser/qt/MiniBrowser.pro:
  72         * MiniBrowser/qt/MiniBrowserApplication.cpp:
  73         * MiniBrowser/qt/UrlLoader.cpp:
  74         * QtTestBrowser/QtTestBrowser.pro:
  75         * Tools.pro:
  76         * WebKitTestRunner/InjectedBundle/Target.pri:
  77         * WebKitTestRunner/Target.pri:
  78         * qmake/mkspecs/features/default_post.prf:
  79         * qmake/mkspecs/features/default_pre.prf:
  80         * qmake/mkspecs/features/functions.prf:
  81         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
  82         * qmake/mkspecs/features/qtwebkit.prf:
  83         * qmake/mkspecs/features/rpath.prf:
  84         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
  85         * qmake/qt_webkit.pri: Added.
  86
  87 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
  88
  89         Unreviewed. Update my email.
  90
  91         * Scripts/webkitpy/common/config/committers.py:
  92
  93 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
  94
  95         Recent changes to chromium.py etc. broke chromium_android.py
  96         https://bugs.webkit.org/show_bug.cgi?id=80623
  97
  98         Reviewed by Dirk Pranke.
  99
 100         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
 101         (ChromiumAndroidDriver.__init__):
 102         (ChromiumAndroidDriver._start):
 103
 104 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
 105
 106         [Chromium] Exception running reftest with --no-pixel-tests
 107         https://bugs.webkit.org/show_bug.cgi?id=80642
 108
 109         Reviewed by Dirk Pranke.
 110
 111         * Scripts/webkitpy/layout_tests/port/chromium.py:
 112         (ChromiumDriver.__init__):
 113         (ChromiumDriver._wrapper_options):
 114
 115 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
 116
 117         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
 118         https://bugs.webkit.org/show_bug.cgi?id=72489
 119
 120         Reviewed by Dirk Pranke.
 121
 122         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
 123         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
 124         --platform will override the platform name and then we'll use it.
 125
 126         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
 127         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
 128         override it in the end.
 129
 130         * Scripts/old-run-webkit-tests:
 131         * Scripts/webkitpy/layout_tests/port/qt.py:
 132         (QtPort):
 133         (QtPort.determine_full_port_name):
 134         (QtPort.baseline_search_path):
 135         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
 136         (QtPortTest):
 137         (QtPortTest._assert_search_path):
 138         (QtPortTest.test_baseline_search_path):
 139
 140 2012-03-08  Beth Dakin  <bdakin@apple.com>
 141
 142         https://bugs.webkit.org/show_bug.cgi?id=80463
 143         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
 144         -and corresponding-
 145         <rdar://problem/10970221>
 146
 147         Reviewed by Dan Bernstein.
 148
 149         New test!
 150         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 151         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
 152         (TestWebKitAPI):
 153         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
 154         (TestWebKitAPI::setPageLoaderClient):
 155         (TestWebKitAPI::TEST):
 156         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
 157         (TestWebKitAPI):
 158         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
 159         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
 160         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
 161         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
 162
 163 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 164
 165         [Qt] Prospective Windows build fix
 166
 167         Don't assume that windows-builds will always run inside a cmd.exe shell.
 168
 169         * qmake/mkspecs/features/default_pre.prf:
 170
 171 2012-03-08  Dan Bernstein  <mitz@apple.com>
 172
 173         <rdar://problem/10981173> Dashboard regions should not be in device space
 174
 175         Reviewed by John Sullivan.
 176
 177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 178         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
 179         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
 180         (TestWebKitAPI):
 181         (TestWebKitAPI::TEST):
 182
 183 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
 184
 185         webkit-patch works oddly on local Git branches
 186         https://bugs.webkit.org/show_bug.cgi?id=76958
 187
 188         Reviewed by Ojan Vafai.
 189
 190         This change makes the '-g' flag to webkit-patch behave a
 191         little more consistently with git. The 'HEAD..' syntax
 192         is changed to 'HEAD....' (four dots), so as to not
 193         collide with the underlying git syntax. We also generalize
 194         the syntax to support any refname, so 'foo....' means
 195         diff against foo and include working copy changes.
 196
 197         This change also adds the 'UPSTREAM' shortcut to identify
 198         whatever the current upstream/tracking branch is; this is
 199         useful if you have multiple local branches stacked up.
 200
 201         * Scripts/webkitpy/common/checkout/scm/git.py:
 202         (Git._branch_from_ref):
 203         (Git):
 204         (Git._current_branch):
 205         (Git._upstream_branch):
 206         (Git.merge_base):
 207         (Git._commit_on_branch):
 208         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 209         (GitSVNTest._second_local_commit):
 210         (GitSVNTest._two_local_commits):
 211         (GitSVNTest.test_commit_with_message_git_commit_range):
 212         (GitSVNTest.test_upstream_branch):
 213         (GitSVNTest.test_create_patch_working_copy_only):
 214         (GitSVNTest.test_changed_files_local_plus_working_copy):
 215         (GitSVNTest.test_changed_files_working_copy_only):
 216         (GitSVNTest.test_changed_files_upstream):
 217         * Scripts/webkitpy/tool/steps/options.py:
 218         (Options):
 219
 220 2012-03-08  John Sullivan  <sullivan@apple.com>
 221
 222         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
 223
 224         Reviewed by Eric Carlson.
 225
 226         * Scripts/extract-localizable-strings:
 227         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
 228         with NSLocalized. Also improved an error message to include the troublesome token.
 229
 230 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
 231
 232         Unreviewed, rolling out r110115.
 233         http://trac.webkit.org/changeset/110115
 234         https://bugs.webkit.org/show_bug.cgi?id=80581
 235
 236         broke test-webkitpy (Requested by philn-tp on #webkit).
 237
 238         * Scripts/old-run-webkit-tests:
 239         * Scripts/webkitpy/layout_tests/port/qt.py:
 240         (QtPort):
 241         (QtPort.determine_full_port_name):
 242         (QtPort.baseline_search_path):
 243
 244 2012-03-08  Kentaro Hara  <haraken@chromium.org>
 245
 246         Unreviewed. Added myself to watchlist.
 247
 248         * Scripts/webkitpy/common/config/watchlist:
 249
 250 2012-03-07  Jessie Berlin  <jberlin@apple.com>
 251
 252         Clean Windows build fails after r110033
 253         https://bugs.webkit.org/show_bug.cgi?id=80553
 254
 255         Rubber-stamped by Jon Honeycutt and Eric Seidel.
 256
 257         Add the new JavaScriptCore include directory to some more vsprops files.
 258
 259         * DumpRenderTree/win/ImageDiffCommon.vsprops:
 260         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
 261         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
 262
 263 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
 264
 265         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
 266         https://bugs.webkit.org/show_bug.cgi?id=72489
 267
 268         Reviewed by Dirk Pranke.
 269
 270         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
 271         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
 272         --platform will override the platform name and then we'll use it.
 273
 274         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
 275         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
 276         override it in the end.
 277
 278         * Scripts/old-run-webkit-tests:
 279         * Scripts/webkitpy/layout_tests/port/qt.py:
 280         (QtPort):
 281         (QtPort.determine_full_port_name):
 282         (QtPort.baseline_search_path):
 283
 284 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
 285
 286         [Qt][WK2] MiniBrowser on desktop does not react to click events
 287         https://bugs.webkit.org/show_bug.cgi?id=80314
 288
 289         Reviewed by Kenneth Rohde Christiansen.
 290
 291         Do not enable touch mocking on desktop mode.
 292
 293         * MiniBrowser/qt/MiniBrowserApplication.cpp:
 294         (MiniBrowserApplication::handleUserOptions):
 295
 296 2012-03-07  Ojan Vafai  <ojan@chromium.org>
 297
 298         Automatically move to the next test after rebaseline in the results view
 299         https://bugs.webkit.org/show_bug.cgi?id=80527
 300
 301         Reviewed by Dimitri Glazkov.
 302
 303         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
 304         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
 305
 306 2012-03-07  Ojan Vafai  <ojan@chromium.org>
 307
 308         garden-o-matic rebaseline is broken for ports that don't have a fallback port
 309         https://bugs.webkit.org/show_bug.cgi?id=80526
 310
 311         Reviewed by Adam Barth.
 312
 313         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
 314         since there is no "None" port.
 315
 316         * Scripts/webkitpy/tool/servers/gardeningserver.py:
 317         (GardeningHTTPRequestHandler.rebaseline):
 318         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
 319         (GardeningServerTest.test_rebaseline):
 320
 321 2012-03-07  James Robinson  <jamesr@chromium.org>
 322
 323         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
 324         https://bugs.webkit.org/show_bug.cgi?id=80521
 325
 326         Reviewed by Kenneth Russell.
 327
 328         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
 329         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
 330         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
 331
 332         Covered by platform/chromium/compositing/plugins/*
 333
 334         * DumpRenderTree/chromium/TestWebPlugin.cpp:
 335         (TestWebPlugin::TestWebPlugin):
 336         (TestWebPlugin::initialize):
 337         (TestWebPlugin::updateGeometry):
 338         (TestWebPlugin::initScene):
 339         (TestWebPlugin::destroyScene):
 340         * DumpRenderTree/chromium/TestWebPlugin.h:
 341         (TestWebPlugin):
 342         * DumpRenderTree/chromium/WebViewHost.cpp:
 343         (WebViewHost::createPlugin):
 344
 345 2012-03-07  Philippe Normand  <pnormand@igalia.com>
 346
 347         [GTK] remove webkitpy dependency in run-gtk-tests
 348         https://bugs.webkit.org/show_bug.cgi?id=80500
 349
 350         Reviewed by Martin Robinson.
 351
 352         Replace Executive calls with bare subprocess calls.
 353
 354         * Scripts/run-gtk-tests:
 355         (TestRunner):
 356         (TestRunner._lookup_atspi2_binary):
 357         (TestRunner.run):
 358         (TestRunner.run.run_for_real):
 359
 360 2012-03-07  Philippe Normand  <pnormand@igalia.com>
 361
 362         Unreviewed, GTK build fix after r110059.
 363
 364         * Scripts/run-gtk-tests:
 365         (TestRunner._check_if_tests_have_timed_out):
 366         (TestRunner.run.run_tests):
 367         (TestRunner):
 368
 369 2012-03-07  Philippe Normand  <pnormand@igalia.com>
 370
 371         [GTK] race condition in run-gtk-tests
 372         https://bugs.webkit.org/show_bug.cgi?id=80495
 373
 374         Reviewed by Martin Robinson.
 375
 376         Refactored the script to wait the a11y dbus service becomes
 377         available before starting the tests.
 378
 379         * Scripts/run-gtk-tests:
 380         (TestRunner._lookup_atspi2_binary):
 381         (TestRunner):
 382         (TestRunner._wait_dbus_service_and_run):
 383         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
 384         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
 385         (TestRunner.run):
 386         (TestRunner.run.bailout):
 387         (TestRunner.run.run_for_real):
 388
 389 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
 390
 391         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
 392         https://bugs.webkit.org/show_bug.cgi?id=80425
 393
 394         Reviewed by Simon Hausmann.
 395
 396         Set startScreenPos in mock touch point
 397
 398         * MiniBrowser/qt/MiniBrowserApplication.cpp:
 399         (MiniBrowserApplication::notify):
 400         * MiniBrowser/qt/MiniBrowserApplication.h:
 401         (MiniBrowserApplication):
 402
 403 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
 404
 405         [Qt] Windows build fix.
 406
 407         Reviewed by Tor Arne Vestbø.
 408
 409         Pass the -j parameter only to "make", not "nmake".
 410
 411         * Scripts/webkitdirs.pm:
 412         (buildQMakeProjects):
 413
 414 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
 415
 416         [Qt] Fix compilation without QtQuick1
 417         https://bugs.webkit.org/show_bug.cgi?id=80503
 418
 419         Reviewed by Tor Arne Vestbø.
 420
 421         Introduce HAVE_QQUICK1 as feature and added haveQtModule
 422         as convenience function.
 423
 424         * qmake/mkspecs/features/features.prf:
 425         * qmake/mkspecs/features/functions.prf:
 426
 427 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
 428
 429         [Qt] Add qmake config tests for JPEG and PNG library
 430         https://bugs.webkit.org/show_bug.cgi?id=80398
 431
 432         Add JPEG and PNG library tests to config.tests and
 433         add error() abort to WebCore.pri if tests don't work.
 434
 435         Reviewed by Tor Arne Vestbø.
 436
 437         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
 438         (main):
 439         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
 440         * qmake/config.tests/libpng/libpng.cpp: Added.
 441         (main):
 442         * qmake/config.tests/libpng/libpng.pro: Added.
 443         * qmake/sync.profile:
 444
 445 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
 446
 447         [EFL] Build warning: Fix warn_unused_result warnings.
 448         https://bugs.webkit.org/show_bug.cgi?id=79194
 449
 450         Reviewed by Filip Pizlo.
 451
 452         Fixed build warning which is getting generated when not using return
 453         value of a fuction, especially declared with warn_unused_result
 454         attribute.
 455
 456         * DumpRenderTree/efl/ImageDiff.cpp:
 457         (printImage):
 458
 459 2012-03-07  Kangil Han  <kangil.han@samsung.com>
 460
 461         [DRT] Remove PlainTextController implementations.
 462         https://bugs.webkit.org/show_bug.cgi?id=79959
 463
 464         Reviewed by Hajime Morita.
 465
 466         PlainTextController usages in existing tests have been
 467         replaced by internals API by bug 78570.
 468         So this patch will remove PlainTextController implementations
 469         to avoid further usage in new tests.
 470
 471         * DumpRenderTree/DumpRenderTree.gypi:
 472         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 473         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
 474         * DumpRenderTree/chromium/PlainTextController.h: Removed.
 475         * DumpRenderTree/chromium/TestShell.cpp:
 476         (TestShell::TestShell):
 477         (TestShell::bindJSObjectsToWindow):
 478         * DumpRenderTree/chromium/TestShell.h:
 479         (TestShell):
 480         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 481         (webViewWindowObjectCleared):
 482         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
 483         * DumpRenderTree/gtk/PlainTextController.h: Removed.
 484         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 485         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
 486         * DumpRenderTree/mac/PlainTextController.h: Removed.
 487         * DumpRenderTree/mac/PlainTextController.mm: Removed.
 488         * DumpRenderTree/qt/DumpRenderTree.pro:
 489         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 490         (WebCore::DumpRenderTree::DumpRenderTree):
 491         (WebCore::DumpRenderTree::initJSObjects):
 492         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 493         (DumpRenderTree):
 494         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
 495         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
 496         * GNUmakefile.am:
 497
 498 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
 499
 500         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
 501         https://bugs.webkit.org/show_bug.cgi?id=80137
 502
 503         Reviewed by Eric Seidel.
 504
 505         Adds implementation LayoutTestController's setPopupBlockingEnabled.
 506         To pass popup-blocking-click-in-iframe.html EventSender should not
 507         repeat click events in idler's function. EventSender allows to
 508         asynchronously send click event through ecore_idler_add.
 509         This event will be called repeatedly as long as it return true.
 510         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
 511
 512         * DumpRenderTree/efl/EventSender.cpp:
 513         (sendMouseEvent): Changed return value from bool to void because it always returns true.
 514         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
 515         (mouseDownCallback): Remove unnecessary checking of return value.
 516         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 517         (LayoutTestController::setPopupBlockingEnabled):
 518
 519 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
 520
 521         rebaseline_chromium_webkit_tests is obsolete and should be removed
 522         https://bugs.webkit.org/show_bug.cgi?id=80347
 523
 524         Reviewed by Tony Chang.
 525
 526         * Scripts/rebaseline-chromium-webkit-tests: Removed.
 527         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
 528         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
 529
 530 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
 531
 532         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
 533         https://bugs.webkit.org/show_bug.cgi?id=80468
 534
 535         Unreviewed, build fix.
 536
 537         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
 538
 539         * Scripts/webkitpy/layout_tests/servers/http_server.py:
 540         (Lighttpd._prepare_config):
 541
 542 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
 543
 544         remove chromium_gpu ports
 545         https://bugs.webkit.org/show_bug.cgi?id=80345
 546
 547         Reviewed by Ojan Vafai.
 548
 549         This change leaves in the 'graphics_type' distinction in the
 550         test_expectations; removing that will require more updates and a
 551         pass over test_expectations.txt, so I'm separating that out.
 552
 553         * Scripts/webkitpy/layout_tests/port/builders.py:
 554         * Scripts/webkitpy/layout_tests/port/chromium.py:
 555         (ChromiumPort):
 556         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
 557         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
 558         * Scripts/webkitpy/layout_tests/port/factory.py:
 559         (PortFactory):
 560         (PortFactory.get):
 561         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
 562         (FactoryTest.test_qt):
 563         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 564         (TestRebaseline.test_rebaseline_expectations):
 565
 566 2012-03-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
 567
 568         undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
 569         https://bugs.webkit.org/show_bug.cgi?id=80282
 570
 571         Reviewed by Antonio Gomes.
 572
 573         Remove transitive library dependencies; they are especially
 574         dangerous when one ends up linking against WTF, JSC and then WTF
 575         again, since some symbols will not be defined.
 576
 577         Passing --no-copy-dt-needed-entries and --as-needed to the linker
 578         (which some recent Linux distros do by default) makes the issue
 579         even more evident.
 580
 581         * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
 582         as the other libraries have the needed symbols. Explicitly link
 583         against fontconfig.
 584
 585 2012-03-06  Dean Jackson  <dino@apple.com>
 586
 587         filter-build-webkit needs more filters
 588         https://bugs.webkit.org/show_bug.cgi?id=80440
 589
 590         Reviewed by Joseph Pecoraro.
 591
 592         Added as many missing filters as I could find for Apple
 593         builds. Plus a few minor style updates.
 594
 595         * Scripts/filter-build-webkit:
 596         (printLine):
 597
 598 2012-03-06  Ojan Vafai  <ojan@chromium.org>
 599
 600         Copying old baselines throws an error if the new directory doesn't exist
 601         https://bugs.webkit.org/show_bug.cgi?id=80443
 602
 603         Reviewed by Adam Barth.
 604
 605         Existing tests cover the new code with the fix to filesystem_mock.
 606
 607         * Scripts/webkitpy/common/system/filesystem_mock.py:
 608         (MockFileSystem.copyfile):
 609         Fix the mock to better match python's copyfile semantics.
 610
 611         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
 612         (Rebaseliner._create_html_baseline_files):
 613         * Scripts/webkitpy/tool/commands/rebaseline.py:
 614         (RebaselineTest._copy_existing_baseline):
 615
 616 2012-03-05  Ojan Vafai  <ojan@chromium.org>
 617
 618         Add a mechanism to rebaseline new ports
 619         https://bugs.webkit.org/show_bug.cgi?id=80355
 620
 621         Reviewed by Adam Barth.
 622
 623         For a test that's only failing on a new port, we want
 624         to first copy the existing result into the location for the
 625         port it's replacing in order to not break that port.
 626
 627         For example, bringing up the chromium-lion port, if we just
 628         stick the results in the chromium-mac directory, the snow leopard
 629         will start failing. Instead, we first copy the existing result
 630         to the chromium-mac-snowleopard directory.
 631
 632         * Scripts/webkitpy/layout_tests/port/builders.py:
 633         (builder_path_for_port_name):
 634         (fallback_port_name_for_new_port):
 635         * Scripts/webkitpy/tool/commands/rebaseline.py:
 636         (RebaselineTest):
 637         (RebaselineTest._copy_existing_baseline):
 638         (RebaselineTest._rebaseline_test):
 639         (RebaselineTest.execute):
 640         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 641         (TestRebaseline.test_rebaseline_test):
 642         (TestRebaseline):
 643         (TestRebaseline.test_rebaseline_and_copy_test):
 644         (test_rebaseline_and_copy_test_no_existing_result):
 645         (test_rebaseline_and_copy_test_with_lion_result):
 646         (test_rebaseline_and_copy_no_overwrite_test):
 647         * Scripts/webkitpy/tool/servers/gardeningserver.py:
 648         (GardeningHTTPRequestHandler.rebaseline):
 649         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
 650         (GardeningServerTest.test_rebaseline):
 651         (GardeningServerTest):
 652         (GardeningServerTest.test_rebaseline_new_port):
 653
 654 2012-03-06  Beth Dakin  <bdakin@apple.com>
 655
 656         https://bugs.webkit.org/show_bug.cgi?id=80351
 657         InlineTextBox is using the wrong origin when calling
 658         addRelevantRepaintedObject
 659         -and corresponding-
 660         <rdar://problem/10970221>
 661
 662         Reviewed by Sam Weinig.
 663
 664         This test has actually been broken since revision 109273. This change makes
 665         the test pass again, and it makes it specifically exercise the fix for this
 666         bug.
 667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 668         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
 669         (TestWebKitAPI::TEST):
 670
 671         Adjust comments in the other tests to reflect the API changes from 109273.
 672         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
 673         (TestWebKitAPI::TEST):
 674         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
 675         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
 676         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
 677         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
 678         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
 679         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
 680         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
 681
 682 2012-03-06  Hans Wennborg  <hans@chromium.org>
 683
 684         Speech JavaScript API: add SpeechRecognitionError
 685         https://bugs.webkit.org/show_bug.cgi?id=80410
 686
 687         Chromium: enable the runtime flag for scripted speech so we can run
 688         the layout tests for it.
 689
 690         Reviewed by Adam Barth.
 691
 692         * DumpRenderTree/chromium/TestShell.cpp:
 693         (TestShell::TestShell):
 694
 695 2012-03-06  Sami Kyostila  <skyostil@chromium.org>
 696
 697         Enable universal newlines in chromium android layout test runner
 698         https://bugs.webkit.org/show_bug.cgi?id=80418
 699
 700         Reviewed by Adam Barth.
 701
 702         The Chromium Android layout test runner uses the 'adb' program to
 703         communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
 704         output lines from the test runner, while the test expectation files are
 705         written with LF ('\n') delimiters. This causes the results to have
 706         spurious whitespace differences, making them more difficult to
 707         interpret.
 708
 709         The fix is to enable universal newlines for the DumpRenderTree pipe,
 710         causing the output to only contain LF newlines like on other platforms.
 711
 712         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
 713         (ChromiumAndroidDriver._start):
 714
 715 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 716
 717         [Qt] Revert r109900, it was completly busted
 718
 719         HAVE_FOO does _not_ have a WTF_ prefix, go figure.
 720
 721         We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
 722         of manual define checks.
 723
 724         Reviewed by Ossy.
 725
 726         * DumpRenderTree/qt/DumpRenderTree.pro:
 727         * QtTestBrowser/QtTestBrowser.pro:
 728         * WebKitTestRunner/InjectedBundle/Target.pri:
 729         * qmake/mkspecs/features/features.prf:
 730
 731 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 732
 733         [Qt] Use config test to determine if the compiler supports -MD
 734
 735         We used to assume that unix systems building against Qt5 would have
 736         a compiler that supported -MD. Although this was usually the case,
 737         we failed to take into account broken tools for distributed builds
 738         (e.g. teambuilder or icecream) which would end up producing .d files
 739         in the root of the build dir instead of along-side the object file.
 740
 741         Now that we use a config-test to determine the support, we'll capture
 742         those cases, unless distributed builds are enabled after the initial
 743         build-webkit run.
 744
 745         Reviewed by Csaba Osztrogonác.
 746
 747         * Tools.pro:
 748         * qmake/config.tests/gccdepends/empty.cpp: Added.
 749         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
 750         * qmake/mkspecs/features/default_pre.prf:
 751         * qmake/mkspecs/features/features.prf:
 752         * qmake/mkspecs/features/unix/default_pre.prf:
 753         * qmake/sync.profile:
 754
 755 2012-03-06  Csaba Osztrogonác  <ossy@webkit.org>
 756
 757         REGRESSION(r109294): It broke the unittest of master.cfg
 758         https://bugs.webkit.org/show_bug.cgi?id=80253
 759
 760         Reviewed by Tor Arne Vestbø.
 761
 762         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
 763         (BuildBotConfigLoader._create_mock_passwords_dict):
 764         (BuildBotConfigLoader._mock_open):
 765         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
 766         (BuildBotConfigLoader.load_config):
 767
 768 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
 769
 770         Qt API test buildstep throws exception after buildmaster update
 771         https://bugs.webkit.org/show_bug.cgi?id=80249
 772
 773         This patch based on Peter Gal's work.
 774
 775         Reviewed by Csaba Osztrogonác.
 776
 777         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 778         (RunQtAPITests):
 779         (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
 780
 781 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 782
 783         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
 784
 785         Reviewed by Simon Hausmann.
 786         Reviewed by Ossy.
 787
 788         * DumpRenderTree/qt/DumpRenderTree.pro:
 789         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
 790         (WebKit::initializeTestFonts):
 791         * QtTestBrowser/QtTestBrowser.pro:
 792         * WebKitTestRunner/InjectedBundle/Target.pri:
 793         * qmake/mkspecs/features/features.prf:
 794
 795 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 796
 797         [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
 798
 799         Reviewed by Ossy.
 800
 801         * qmake/mkspecs/features/default_post.prf:
 802
 803 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 804
 805         [Qt] Make sure clean builds are followed by make qmake && make if needed
 806
 807         On non-GNUmake systems we have to run make qmake so that the generated
 808         sources are generated before we run qmake on the target pro files. This
 809         is achieved by using the 'incremental' target.
 810
 811         Reviewed by Ossy.
 812
 813         * Scripts/webkitdirs.pm:
 814         (buildQMakeProjects):
 815
 816 2012-03-06  Filip Pizlo  <fpizlo@apple.com>
 817
 818         DumpRenderTree should support preciseTime()
 819         https://bugs.webkit.org/show_bug.cgi?id=80397
 820
 821         Reviewed by Gavin Barraclough.
 822
 823         * DumpRenderTree/LayoutTestController.cpp:
 824         (preciseTimeCallback):
 825         (LayoutTestController::staticFunctions):
 826
 827 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
 828
 829         Unreviewed, rolling out r109887.
 830         http://trac.webkit.org/changeset/109887
 831         https://bugs.webkit.org/show_bug.cgi?id=80402
 832
 833         It broke the build (Requested by Ossy on #webkit).
 834
 835         * DumpRenderTree/qt/DumpRenderTree.pro:
 836         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
 837         (WebKit::initializeTestFonts):
 838         * QtTestBrowser/QtTestBrowser.pro:
 839         * WebKitTestRunner/InjectedBundle/Target.pri:
 840         * qmake/mkspecs/features/features.prf:
 841
 842 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
 843
 844         Unreviewed, rolling out r109837.
 845         http://trac.webkit.org/changeset/109837
 846         https://bugs.webkit.org/show_bug.cgi?id=80399
 847
 848         breaks Mac Productions builds, too late to try and fix it
 849         tonight (Requested by eseidel on #webkit).
 850
 851         * Scripts/build-webkit:
 852
 853 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 854
 855         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
 856
 857         Reviewed by Simon Hausmann.
 858
 859         * DumpRenderTree/qt/DumpRenderTree.pro:
 860         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
 861         (WebKit::initializeTestFonts):
 862         * QtTestBrowser/QtTestBrowser.pro:
 863         * WebKitTestRunner/InjectedBundle/Target.pri:
 864         * qmake/mkspecs/features/features.prf:
 865
 866 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
 867
 868         [Qt] Create EWS to build WebKit2
 869         https://bugs.webkit.org/show_bug.cgi?id=80277
 870
 871         Reviewed by Csaba Osztrogonác.
 872
 873         * QueueStatusServer/model/queues.py:
 874         (Queue):
 875         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 876         (QtWK2EWS):
 877         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 878         (EarlyWarningSytemTest.test_builder_ewses):
 879
 880 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
 881
 882         Unreviewed, rolling out r109733.
 883         http://trac.webkit.org/changeset/109733
 884         https://bugs.webkit.org/show_bug.cgi?id=80378
 885
 886         It broke Qt5 build system (Requested by Ossy on #webkit).
 887
 888         * Tools.pro:
 889         * qmake/config.tests/gccdepends/empty.cpp: Removed.
 890         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
 891         * qmake/mkspecs/features/default_pre.prf:
 892         * qmake/mkspecs/features/features.prf:
 893         * qmake/mkspecs/features/unix/default_pre.prf:
 894         * qmake/sync.profile:
 895
 896 2012-03-05  Eric Seidel  <eric@webkit.org>
 897
 898         Update JavaScriptCore files to use fully-qualified WTF include path
 899         https://bugs.webkit.org/show_bug.cgi?id=79960
 900
 901         Reviewed by Adam Barth.
 902
 903         Build WTF/WTF.xcodeproj by default on Mac.
 904
 905         * Scripts/build-webkit:
 906
 907 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
 908
 909         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
 910         https://bugs.webkit.org/show_bug.cgi?id=69590
 911
 912         Reviewed by Ryosuke Niwa.
 913
 914         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
 915         to skip the 'optimize-expectations' step.
 916
 917         * Scripts/webkitpy/tool/commands/rebaseline.py:
 918         (RebaselineExpectations.__init__):
 919         (RebaselineExpectations.execute):
 920         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 921
 922 2012-03-05  Kent Tamura  <tkent@chromium.org>
 923
 924         [Chromium] Add new popup type: PagePopup
 925         https://bugs.webkit.org/show_bug.cgi?id=80106
 926
 927         Reviewed by Darin Fisher.
 928
 929         * DumpRenderTree/chromium/WebViewHost.cpp:
 930         (WebViewHost::createPopupMenu):
 931
 932 2012-03-05  Jessie Berlin  <jberlin@apple.com>
 933
 934         Add myself as a reviewer.
 935
 936         * Scripts/webkitpy/common/config/committers.py:
 937         Also, add my IRC nick so it is easier to find and yell at me.
 938
 939 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
 940
 941         Correctly compute the positions of GestureScroll* events on
 942         Chromium.
 943         https://bugs.webkit.org/show_bug.cgi?id=80075
 944
 945         Reviewed by Adam Barth.
 946
 947         * DumpRenderTree/chromium/EventSender.cpp:
 948         (EventSender::reset):
 949         (EventSender::gestureEvent):
 950         * DumpRenderTree/chromium/EventSender.h:
 951         (EventSender):
 952
 953 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
 954
 955         flakiness dashboard doesn't display baselines for virtual tests correctly
 956         https://bugs.webkit.org/show_bug.cgi?id=80341
 957
 958         Reviewed by Ojan Vafai.
 959
 960         If the test is part of a virtual test suite, we need to look for
 961         baselines in the underlying fallback path for the actual test
 962         being run, as well as baselines for the virtual version.
 963
 964         This patch adds code to handle both branches and also pulls the
 965         mapping of the test suites up into a constant.
 966
 967         * TestResultServer/static-dashboards/flakiness_dashboard.html:
 968         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
 969         (testLookupVirtualTestSuite):
 970         (testBaseTest):
 971
 972 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
 973
 974         Unreviewed, rolling out r109760.
 975         http://trac.webkit.org/changeset/109760
 976         https://bugs.webkit.org/show_bug.cgi?id=80320
 977
 978         Caused many GTK+ tests to crash (Requested by mrobinson on
 979         #webkit).
 980
 981         * gtk/jhbuild.modules:
 982
 983 2012-03-05  Charlie Reis  <creis@chromium.org>
 984
 985         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
 986         https://bugs.webkit.org/show_bug.cgi?id=80057
 987
 988         Reviewed by Darin Fisher.
 989
 990         * DumpRenderTree/chromium/WebViewHost.cpp:
 991         (WebViewHost::createView):
 992         * DumpRenderTree/chromium/WebViewHost.h:
 993         (WebViewHost):
 994
 995 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
 996
 997         [soup] Crash while loading http://www.jusco.cn
 998         https://bugs.webkit.org/show_bug.cgi?id=68238
 999
1000         Reviewed by Philippe Normand.
1001
1002         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
1003         in the jhbuild file.
1004
1005 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1006
1007         Unreviewed, rolling out r109748.
1008         http://trac.webkit.org/changeset/109748
1009         https://bugs.webkit.org/show_bug.cgi?id=80296
1010
1011         Made some tests crash, will fix and recommit (Requested by
1012         noamr on #webkit).
1013
1014         * MiniBrowser/qt/main.cpp:
1015         (main):
1016
1017 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
1018
1019         [GTK] plugins/netscape-plugin-page-cache-works.html fails
1020         https://bugs.webkit.org/show_bug.cgi?id=74409
1021
1022         Reviewed by Martin Robinson.
1023
1024         Add support for overriding the page-cache-for-plugins preference
1025         through DumpRenderTreeSupport.
1026
1027         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1028         (booleanFromValue): A helper function to convert a string to boolean.
1029         (LayoutTestController::overridePreference):
1030
1031 2012-03-05  Rob Buis  <rbuis@rim.com>
1032
1033         [BlackBerry] Update Tools/DumpRenderTree
1034         https://bugs.webkit.org/show_bug.cgi?id=80287
1035
1036         Reviewed by Antonio Gomes.
1037
1038         Update so we are sure we can build our implementation of DRT.
1039
1040         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
1041         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
1042         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
1043         (AccessibilityController::addNotificationListener): add missing hook.
1044         (AccessibilityController::removeNotificationListener): add missing hook.
1045         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1046         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
1047         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1048         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
1049         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
1050
1051 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
1052
1053         [Qt] [WK2] Support threaded renderer in WK2
1054         https://bugs.webkit.org/show_bug.cgi?id=76661
1055
1056         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
1057
1058         Reviewed by Kenneth Rohde Christiansen.
1059
1060         * MiniBrowser/qt/main.cpp:
1061         (main):
1062
1063 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
1064
1065         Unreviewed. Add myself to committer list.
1066
1067         * Scripts/webkitpy/common/config/committers.py:
1068
1069 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1070
1071         [Qt] Use config test to determine if the compiler supports -MD
1072
1073         We used to assume that unix systems building against Qt5 would have
1074         a compiler that supported -MD. Although this was usually the case,
1075         we failed to take into account broken tools for distributed builds
1076         (e.g. teambuilder or icecream) which would end up producing .d files
1077         in the root of the build dir instead of along-side the object file.
1078
1079         Now that we use a config-test to determine the support, we'll capture
1080         those cases, unless distributed builds are enabled after the initial
1081         build-webkit run.
1082
1083         Reviewed by Csaba Osztrogonác.
1084
1085         * Tools.pro:
1086         * qmake/config.tests/gccdepends/empty.cpp: Added.
1087         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
1088         * qmake/mkspecs/features/default_pre.prf:
1089         * qmake/mkspecs/features/features.prf:
1090         * qmake/mkspecs/features/unix/default_pre.prf:
1091         * qmake/sync.profile:
1092
1093 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
1094
1095         Qt API test buildstep throws exception after buildmaster update
1096         https://bugs.webkit.org/show_bug.cgi?id=80249
1097
1098         Reviewed by Zoltan Herczeg.
1099
1100         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
1101         (BuildAndTestFactory.__init__):
1102
1103 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1104
1105         [GTK] Unit tests are noisy when run under jhbuild
1106         https://bugs.webkit.org/show_bug.cgi?id=80241
1107
1108         Reviewed by Philippe Normand.
1109
1110         Force the 'memory' backend in GSettings so that each unit
1111         test doesn't produce a warning when it's forced to fall back
1112         to the 'memory' backend.
1113
1114         * Scripts/run-gtk-tests:
1115         (TestRunner.run): Force the 'memory' backend.
1116
1117 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1118
1119         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
1120         https://bugs.webkit.org/show_bug.cgi?id=80235
1121
1122         Reviewed by Philippe Normand.
1123
1124         * Scripts/run-gtk-tests:
1125         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
1126         inspector resources path determination is shared by all tests.
1127
1128 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
1129
1130         [GTK] REGRESSION: r108278 broke some tests that expect focus
1131         https://bugs.webkit.org/show_bug.cgi?id=79084
1132
1133         Reviewed by Philippe Normand.
1134
1135         Grab focus when dumping test results and also when sending
1136         events. During the course of testing, the WebView may lose
1137         focus and this seems to snap it back when tests demand it.
1138
1139         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1140         (dump): Grab focus.
1141         * DumpRenderTree/gtk/EventSender.cpp:
1142         (dispatchEvent): Ditto.
1143
1144 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
1145
1146         Unreviewed, Add myself to committer list.
1147         https://bugs.webkit.org/show_bug.cgi?id=80232
1148
1149         * Scripts/webkitpy/common/config/committers.py:
1150
1151 2012-03-04  Anders Carlsson  <andersca@apple.com>
1152
1153         Newer versions of clang fail to compile WebKit.
1154
1155         Fix build.
1156
1157         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1158         (descriptionOfValue):
1159         (AccessibilityUIElement::rowIndexRange):
1160         (AccessibilityUIElement::columnIndexRange):
1161         (AccessibilityUIElement::selectedTextRange):
1162         * DumpRenderTree/mac/EditingDelegate.mm:
1163         (-[DOMRange dump]):
1164         * DumpRenderTree/mac/PolicyDelegate.mm:
1165         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
1166         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1167         (-[NSError _drt_descriptionSuitableForTestResult]):
1168         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1169         (WTR::descriptionOfValue):
1170         (WTR::AccessibilityUIElement::rowIndexRange):
1171         (WTR::AccessibilityUIElement::columnIndexRange):
1172         (WTR::AccessibilityUIElement::selectedTextRange):
1173
1174 2012-03-03  Simon Hausmann  <simon.hausmann@nokia.com>
1175
1176         [Qt] Fix static_libs_as_shared build
1177         https://bugs.webkit.org/show_bug.cgi?id=80214
1178
1179         Reviewed by Tor Arne Vestbø.
1180
1181         * WebKitTestRunner/qt/main.cpp:
1182         (main): Set the correct environment variable for choosing the theme in the
1183         web process.
1184
1185 2012-03-03  Hans Wennborg  <hans@chromium.org>
1186
1187         Implement Speech JavaScript API
1188         https://bugs.webkit.org/show_bug.cgi?id=80019
1189
1190         Reviewed by Adam Barth.
1191
1192         Add ENABLE_SCRIPTED_SPEECH.
1193
1194         * Scripts/build-webkit:
1195         * qmake/mkspecs/features/features.prf:
1196
1197 2012-03-02  Alexey Proskuryakov  <ap@apple.com>
1198
1199         Fix commit queue, remove duplicate entry.
1200
1201         * Scripts/webkitpy/common/config/committers.py:
1202
1203 2012-03-02  Stephen Chenney  <schenney@chromium.org>
1204
1205         Unreviewed, add myself as a committer
1206
1207         * Scripts/webkitpy/common/config/committers.py:
1208
1209 2012-03-02  Ojan Vafai  <ojan@chromium.org>
1210
1211         Add the Chromium Lion canary bot to the flakiness dashboard.
1212         * TestResultServer/static-dashboards/builders.js:
1213
1214 2012-03-02  Dirk Pranke  <dpranke@chromium.org>
1215
1216         links for virtual tests are broken in the flakiness dashboard
1217         https://bugs.webkit.org/show_bug.cgi?id=80180
1218
1219         Reviewed by Ojan Vafai.
1220
1221         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1222         (linkHTMLToOpenWindow):
1223         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1224         (testLinkHTMLToOpenWindow): added.
1225
1226 2012-03-02  Philippe Normand  <pnormand@igalia.com>
1227
1228         [GTK] security/block-test.html baselines differ from mac
1229         https://bugs.webkit.org/show_bug.cgi?id=78343
1230
1231         Reviewed by Martin Robinson.
1232
1233         Improved the FrameLoader error heuristics to match mac behavior a
1234         bit more.
1235
1236         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1237         (pathFromSoupURI): Handle ftp urls the same as http urls.
1238         (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
1239
1240 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
1241
1242         [Qt][WK2] Fix typo in patch committed in r109575
1243
1244         Unreviewed typo fix.
1245
1246         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1247         (MiniBrowserApplication::notify): Cache the position
1248         in floating point coordinates.
1249
1250 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
1251
1252         [Qt][WK2] Infinite loop on history navigation, when panning
1253         https://bugs.webkit.org/show_bug.cgi?id=79119
1254
1255         Reviewed by Simon Hausmann.
1256
1257         Make the touch mocking more robust by creating touch events
1258         directly and sending them synchronously to the browser window.
1259         If the sent touch event was not accepted we propagate the
1260         original mouse event to its target.
1261         This way we make sure we only send either a touch or a mouse
1262         event and do not end up in an infinite loop between our mocking
1263         code and the Qt5 automatic mouse event synthesizing.
1264
1265         * MiniBrowser/qt/BrowserWindow.cpp:
1266         (BrowserWindow::updateVisualMockTouchPoints):
1267         * MiniBrowser/qt/BrowserWindow.h:
1268         (BrowserWindow):
1269         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1270         (touchRectForPosition):
1271         (MiniBrowserApplication::notify):
1272         (MiniBrowserApplication::sendTouchEvent):
1273         * MiniBrowser/qt/MiniBrowserApplication.h:
1274         (MiniBrowserApplication):
1275
1276 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1277
1278         [Qt] Use 'all' as default target when debug_and_release is in effect
1279
1280         When debug_and_release is enabled, in combination with build_all,
1281         qmake will generate an aggregate makefile that calls make on both
1282         the debug and the release makefiles, but with the 'all' target.
1283
1284         In this case we can't use 'first' as the default target, as the
1285         extra targets would then not be run, so we append extra targets
1286         to 'all' instead.
1287
1288         Reviewed by Simon Hausmann.
1289
1290         * qmake/mkspecs/features/default_post.prf:
1291
1292 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1293
1294         [Qt] Make sure activeBuildConfig() returns the right config
1295
1296         Using isActiveConfig fails, as that only checks if the given
1297         argument is in CONFIG, not the order.
1298
1299         Reviewed by Simon Hausmann.
1300
1301         * qmake/mkspecs/features/functions.prf:
1302
1303 2012-03-02  Simon Hausmann  <simon.hausmann@nokia.com>
1304
1305         [Qt] Fix tests run with WTR not using QStyle theme
1306         https://bugs.webkit.org/show_bug.cgi?id=80147
1307
1308         Reviewed by Csaba Osztrogonác.
1309
1310         * WebKitTestRunner/qt/main.cpp:
1311         (main): Set environment variable for web process to use QStyle theme.
1312
1313 2012-03-02  Philippe Normand  <pnormand@igalia.com>
1314
1315         Unreviewed, remove debug print call.
1316
1317         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1318         (descriptionSuitableForTestResult):
1319
1320 2012-03-02  Robert Kroeger  <rjkroege@chromium.org>
1321
1322         Updated EventSender to send complete gesture events.
1323         https://bugs.webkit.org/show_bug.cgi?id=80075
1324
1325         Reviewed by Adam Barth.
1326
1327         * DumpRenderTree/chromium/EventSender.cpp:
1328         (EventSender::gestureEvent): set additional parameters in sent events.
1329
1330 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
1331
1332         WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
1333         https://bugs.webkit.org/show_bug.cgi?id=80033
1334
1335         Reviewed by Gustavo Noronha Silva.
1336
1337         GCC 4.7 no longer includes unistd.h from most of the standard C++
1338         header files, so we need to explicitly include it for getcwd().
1339
1340         * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
1341         not only on Mac, but on all Unix platforms.
1342
1343 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1344
1345         Actually look at the args in driver_input :(.
1346
1347         Unreviewed, build fix.
1348
1349         * Scripts/webkitpy/layout_tests/port/chromium.py:
1350         (ChromiumDriver.run_test):
1351
1352 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1353
1354         Fix typo in flag used to run gpu virtual suites.
1355
1356         Unreviewed, build fix.
1357
1358         * Scripts/webkitpy/layout_tests/port/chromium.py:
1359         (ChromiumPort.virtual_test_suites):
1360
1361 2012-03-01  Adam Barth  <abarth@webkit.org>
1362
1363         Unreviewed, rolling out r109317.
1364         http://trac.webkit.org/changeset/109317
1365
1366         Let's try watchlists again now that we're using a pure git
1367         working copy
1368
1369         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1370         (StyleQueueTask.run):
1371         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1372
1373 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1374
1375         webkitpy: test_run_test_pause_before_testing is failing after r109482
1376         https://bugs.webkit.org/show_bug.cgi?id=80084
1377
1378         Unreviewed, build fix.
1379
1380         Fixes the test string compare to ignore the time spent running
1381         the tests.
1382
1383         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1384         (test_run_test_pause_before_testing):
1385
1386 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1387
1388         nrwt: virtual tests aren't being run
1389         https://bugs.webkit.org/show_bug.cgi?id=80083
1390
1391         Reviewed by Eric Seidel.
1392
1393         If we tried to run all of the tests by default (and
1394         didn't specify any paths), the virtual tests weren't
1395         picked up.
1396
1397         * Scripts/webkitpy/layout_tests/port/base.py:
1398         (Port._virtual_tests):
1399         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1400         (PortTest.test_tests):
1401         * Scripts/webkitpy/layout_tests/port/test.py:
1402         (TestPort.virtual_test_suites):
1403
1404 2012-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1405
1406         run-perf-tests should report the test runtime
1407         https://bugs.webkit.org/show_bug.cgi?id=80078
1408
1409         Reviewed by Hajime Morita.
1410
1411         Record and output the aggreated test run time.
1412
1413         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1414         (PerfTestsRunner._run_single_test):
1415
1416 2012-03-01  Michael Nordman  <michaeln@google.com>
1417
1418         [chromium] Use webkit_support to create session storage namespaces in DRT.
1419         https://bugs.webkit.org/show_bug.cgi?id=79933
1420
1421         Reviewed by Tony Chang.
1422
1423         * DumpRenderTree/chromium/WebViewHost.cpp:
1424         (WebViewHost::createSessionStorageNamespace):
1425
1426 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1427
1428         nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
1429         https://bugs.webkit.org/show_bug.cgi?id=80048
1430
1431         Reviewed by Adam Barth.
1432
1433         * Scripts/webkitpy/layout_tests/port/base.py:
1434         (Port.test_isfile):
1435         (Port.test_isdir):
1436         (Port):
1437         (Port.test_exists):
1438         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1439         (PortTest.test_test_exists):
1440         (PortTest):
1441         (PortTest.test_test_isfile):
1442         (PortTest.test_test_isdir):
1443         * Scripts/webkitpy/layout_tests/port/test.py:
1444         (TestPort.virtual_test_suites):
1445         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1446         (MainTest.test_virtual):
1447
1448 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
1449
1450         [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
1451         https://bugs.webkit.org/show_bug.cgi?id=80031
1452
1453         Reviewed by Gustavo Noronha Silva.
1454
1455         Only build the libTestRunnerInjectedBundle.la convenience library when
1456         ENABLE_WEBKIT2 is defined.
1457
1458         * WebKitTestRunner/GNUmakefile.am:
1459
1460 2012-03-01  Philippe Normand  <pnormand@igalia.com>
1461
1462         Unreviewed, second attempt to fix GTK NRWT after r109242.
1463
1464         * Scripts/webkitpy/layout_tests/port/gtk.py:
1465         (GtkDriver._start):
1466
1467 2012-03-01  Philippe Normand  <pnormand@igalia.com>
1468
1469         Unreviewed, GTK NRWT build fix attempt after r109242.
1470
1471         * Scripts/webkitpy/layout_tests/port/gtk.py:
1472         (GtkDriver._start):
1473
1474 2012-03-01  Kentaro Hara  <haraken@chromium.org>
1475
1476         REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
1477         https://bugs.webkit.org/show_bug.cgi?id=80008
1478
1479         Reviewed by Adam Barth.
1480
1481         In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
1482         to "preprocess-idls.pl". This patch renames it.
1483
1484         Test: Confirm that run-bindings-tests runs.
1485
1486         * Scripts/webkitpy/bindings/main.py:
1487         (BindingsTests.generate_supplemental_dependency):
1488
1489 2012-02-29  Simon Hausmann  <simon.hausmann@nokia.com>
1490
1491         [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
1492         https://bugs.webkit.org/show_bug.cgi?id=78047
1493
1494         Reviewed by Kenneth Rohde Christiansen.
1495
1496         Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
1497         sending to the item requires the QObject::event re-implementation to dispatch to the correct
1498         event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
1499         the event handlers directly, and with the removal of our own dispatching we need to go through
1500         that code path.
1501
1502         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1503         (WTR::PlatformWebView::sendEvent):
1504         (WTR::PlatformWebView::postEvent):
1505
1506 2012-02-29  Adam Barth  <abarth@webkit.org>
1507
1508         Disable watchlist.  It's been spamming CCs.
1509
1510         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1511         (StyleQueueTask.run):
1512         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1513
1514 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1515
1516         need to clone the gpu baselines and expectations into the new "virtual" dir
1517         https://bugs.webkit.org/show_bug.cgi?id=79956
1518
1519         Reviewed by Adam Barth.
1520
1521         * Scripts/webkitpy/layout_tests/port/chromium.py:
1522         (ChromiumPort.virtual_test_suites):
1523
1524 2012-02-29  Mark Rowe  <mrowe@apple.com>
1525
1526         Switch to using json rather than simplejson now that the master is using Python 2.7.
1527
1528         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1529         (loadBuilderConfig):
1530
1531 2012-02-29  David Levin  <levin@chromium.org>
1532
1533         [chromium] Add the ability to turn off autoresize.
1534         https://bugs.webkit.org/show_bug.cgi?id=77452
1535
1536         Reviewed by Darin Fisher.
1537
1538         * DumpRenderTree/chromium/LayoutTestController.cpp:
1539         (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
1540         (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
1541         (LayoutTestController::disableAutoResizeMode):  Ditto.
1542         * DumpRenderTree/chromium/LayoutTestController.h: Ditto.
1543
1544 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1545
1546         nrwt: make --print trace work with virtual tests
1547         https://bugs.webkit.org/show_bug.cgi?id=79952
1548
1549         Reviewed by Adam Barth.
1550
1551         * Scripts/webkitpy/layout_tests/views/printing.py:
1552         (Printer._print_test_trace):
1553         (Printer._print_baseline):
1554
1555 2012-02-28  Brian Weinstein  <bweinstein@apple.com>
1556
1557         WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
1558         https://bugs.webkit.org/show_bug.cgi?id=79849
1559
1560         Reviewed by Beth Dakin.
1561
1562         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1563         (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
1564
1565 2012-02-29  Lucas Forschler  <lforschler@apple.com>
1566
1567         Removed unused Apple buildslaves from the master configuration
1568         https://bugs.webkit.org/show_bug.cgi?id=79925
1569
1570         Reviewed by Stephanie Lewis.
1571
1572         * BuildSlaveSupport/build.webkit.org-config/config.json:
1573
1574 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1575
1576         nrwt: implement simple 'virtual test suite' support
1577         https://bugs.webkit.org/show_bug.cgi?id=79737
1578
1579         Reviewed by Adam Barth.
1580
1581         Add very basic support for 'virtual test suites' to NRWT:
1582         a virtual suite is a directory that may contain new baselines,
1583         contains a pointer to a "base" directory of tests, and an
1584         optional list of command line arguments to pass to DRT;
1585         it gives us a way to run all of the tests in a given directory
1586         multiple times with multiple (potentially differing) sets of
1587         results and baselines.
1588
1589         This patch implements the support needed for this feature, and
1590         some basic tests, but no actual port will use the feature yet.
1591
1592         This is probably the simplest implementation possible - the
1593         list of virtual suites will be hard-coded into the port's
1594         implementation. One can imagine a more data-driven approach
1595         where the suite instructions are stored in a manifest file
1596         either in LayoutTests (all suites in one file), or per-port,
1597         or per-directory. If this feature ends up being useful we
1598         should probably add something like that so people don't have
1599         to hunt around in the code to add suites.
1600
1601         * Scripts/webkitpy/layout_tests/port/base.py:
1602         (Port.__init__):
1603         (Port.expected_filename):
1604         (Port.tests):
1605         (Port):
1606         (Port._real_tests):
1607         (Port._driver_class):
1608         (Port.virtual_test_suites):
1609         (Port.virtual_suite):
1610         (Port.virtual_suite.VirtualTestSuite):
1611         (Port.virtual_suite.VirtualTestSuite.__init__):
1612         (Port.virtual_suite.VirtualTestSuite.__repr__):
1613         (Port.populated_virtual_test_suites):
1614         (Port._virtual_tests):
1615         (Port.lookup_virtual_test_base):
1616         (Port.lookup_virtual_test_args):
1617         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1618         (PortTest.test_find_with_skipped_directories):
1619         * Scripts/webkitpy/layout_tests/port/driver.py:
1620         (DriverInput.__init__):
1621         (DriverProxy.run_test):
1622         * Scripts/webkitpy/layout_tests/port/test.py:
1623         (TestPort.virtual_test_suites):
1624         (TestDriver.run_test):
1625         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1626         (MainTest.test_all):
1627         (MainTest.test_virtual):
1628
1629 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1630
1631         nrwt: support more than two drivers in DriverProxy
1632         https://bugs.webkit.org/show_bug.cgi?id=79736
1633
1634         Reviewed by Adam Barth.
1635
1636         Now that we can support per-test command lines for
1637         Drivers, modify DriverProxy to keep a map of running
1638         drivers for each needed command-line; this will allow
1639         us to transparently maintain a pool of appropriately
1640         configured DRTs without having to constantly start and stop
1641         them.
1642
1643         Note that this potentially raises a garbage collection
1644         problem - the number of running DRTs will grow with the
1645         number of different sets of command line args. For now
1646         this is no worse than the current code - if you're running
1647         with pixel tests, you will only need one DRT per worker,
1648         and if you aren't, you'll need two (one for text-only tests,
1649         and one for reftests).
1650
1651         An alternative would be to only ever have one running driver,
1652         and restart the driver as the command line changes, but this
1653         might (?) slow down execution in the text-only case - we
1654         should benchmark this because it would be simpler and possibly
1655         allow us to eliminate DriverProxy altogether.
1656
1657         * Scripts/webkitpy/layout_tests/port/driver.py:
1658         (DriverProxy.__init__):
1659         (DriverProxy):
1660         (DriverProxy._make_driver):
1661         (DriverProxy.run_test):
1662         (DriverProxy.has_crashed):
1663         (DriverProxy.stop):
1664         (DriverProxy.cmd_line):
1665         (DriverProxy._cmd_line_as_key):
1666
1667 2012-02-29  Adrienne Walker  <enne@google.com>
1668
1669         Unreviewed, add myself as a reviewer
1670
1671         * Scripts/webkitpy/common/config/committers.py:
1672
1673 2012-02-29  Greg Billock  <gbillock@google.com>
1674
1675         Add more tests for web intents
1676         https://bugs.webkit.org/show_bug.cgi?id=79527
1677
1678         Reviewed by Adam Barth.
1679
1680         * DumpRenderTree/chromium/LayoutTestController.cpp:
1681         (LayoutTestController::LayoutTestController):
1682         (LayoutTestController::sendWebIntentResponse):
1683         * DumpRenderTree/chromium/LayoutTestController.h:
1684         (LayoutTestController):
1685         * DumpRenderTree/chromium/WebViewHost.h:
1686         (WebViewHost):
1687         (WebViewHost::currentIntentRequest):
1688
1689 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1690
1691         nrwt: port/Driver needs to support per-test command line args
1692         https://bugs.webkit.org/show_bug.cgi?id=79733
1693
1694         Reviewed by Adam Barth.
1695
1696         As part of removing the 'gpu' configurations and adding support
1697         for 'virtual test suites', the Driver classes need to support
1698         per-test command lines (since different tests will need to be
1699         run with different command line options).
1700
1701         The per-test args are not yet used, so this change should have
1702         no visible effects and need no additional testing.
1703
1704         * Scripts/webkitpy/layout_tests/port/base.py:
1705         (Port.driver_cmd_line):
1706         * Scripts/webkitpy/layout_tests/port/chromium.py:
1707         (ChromiumDriver.cmd_line):
1708         (ChromiumDriver._start):
1709         (ChromiumDriver.start):
1710         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1711         (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
1712         (ChromiumDriverTest):
1713         (ChromiumDriverTest.test_two_drivers):
1714         * Scripts/webkitpy/layout_tests/port/driver.py:
1715         (Driver.cmd_line):
1716         (DriverProxy.__init__):
1717         (DriverProxy.start):
1718         (DriverProxy.cmd_line):
1719         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1720         (DriverTest.test_virtual_driver_methods):
1721         * Scripts/webkitpy/layout_tests/port/gtk.py:
1722         (GtkDriver.cmd_line):
1723         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1724         * Scripts/webkitpy/layout_tests/port/test.py:
1725         (TestPort._path_to_driver):
1726         (TestDriver.cmd_line):
1727         (TestDriver.start):
1728         * Scripts/webkitpy/layout_tests/port/webkit.py:
1729         (WebKitDriver.cmd_line):
1730         (WebKitDriver._start):
1731         (WebKitDriver.run_test):
1732         (WebKitDriver.start):
1733         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1734         (WebKitDriverTest.test_no_timeout):
1735         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1736         (PerfTestsRunner._run_tests_set):
1737         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1738         (test_run_test_pause_before_testing):
1739
1740 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1741
1742         perftestsrunner can call printer.write() after printer.cleanup()
1743         https://bugs.webkit.org/show_bug.cgi?id=79872
1744
1745         Reviewed by Ryosuke Niwa.
1746
1747         This patch fixes a unittest that was incorrectly calling
1748         PerfTestsRunner.run() twice (which led to a weird state in the
1749         printer object).
1750
1751         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1752         (MainTest.test_run_with_upload_json):
1753
1754 2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
1755
1756         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
1757         https://bugs.webkit.org/show_bug.cgi?id=76546
1758
1759         Reviewed by Simon Hausmann.
1760
1761         Revert the workaround introduced in r107868 and reintroduce
1762         the qml binding so we can test the code path that we are more
1763         interested in. The reason that it did not work before is that
1764         we don't have an active platform window which we now workaround
1765         by propagating the resize through QWindowSystemInterface.
1766
1767         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1768         (WTR::WrapperWindow::handleStatusChanged):
1769         (WTR::PlatformWebView::resizeTo):
1770
1771 2012-02-29  Gabor Rapcsanyi  <rgabor@webkit.org>
1772
1773         [GTK] Small fix for cross compilation to not generate gtkdoc.
1774
1775         Rubber-stamped by Csaba Osztrogonác.
1776
1777         * Scripts/webkitdirs.pm:
1778         (isCrossCompilation):
1779
1780 2012-02-28  Lucas Forschler  <lforschler@apple.com>
1781
1782         Fix a typo in config.json
1783         linx -> linux
1784
1785         * BuildSlaveSupport/build.webkit.org-config/config.json:
1786
1787 2012-02-28  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1788
1789         [Qt] Allow read/write to the WebView.url property
1790         https://bugs.webkit.org/show_bug.cgi?id=77554
1791
1792         Reviewed by Tor Arne Vestbø.
1793
1794         Fix MiniBrowser to use WebView.url property and remove WebView.load usage.
1795
1796         * MiniBrowser/qt/qml/BrowserWindow.qml:
1797
1798 2012-02-28  Dan Winship  <danw@gnome.org>
1799
1800         [GTK] make tests explicitly request GSettingsBackendMemory
1801         https://bugs.webkit.org/show_bug.cgi?id=79788
1802
1803         Reviewed by Martin Robinson.
1804
1805         Explicitly request the fallback memory-based GSettings backend; if
1806         other backends are available then we don't want to use them,
1807         because they would make tests depend on the user's preferences.
1808         And if other backends aren't available, we don't need glib to
1809         print a warning about that fact.
1810
1811         * Scripts/webkitpy/layout_tests/port/gtk.py:
1812         (GtkPort.setup_environ_for_server):
1813
1814 2012-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1815
1816         Unreviewed, rolling out r109110.
1817         http://trac.webkit.org/changeset/109110
1818         https://bugs.webkit.org/show_bug.cgi?id=79806
1819
1820         webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
1821         (Requested by aroben on #webkit).
1822
1823         * Scripts/webkitpy/common/checkout/changelog.py:
1824         (parse_bug_id):
1825         (parse_bug_id_from_changelog):
1826         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1827         * Scripts/webkitpy/common/config/urls.py:
1828
1829 2012-02-28  Adam Roben  <aroben@webkit.org>
1830
1831         Add my new email address
1832
1833         Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect
1834
1835         Reviewed by Anders Carlsson.
1836
1837         * Scripts/webkitpy/common/config/committers.py:
1838
1839 2012-02-28  Adam Roben  <aroben@apple.com>
1840
1841         Teach webkitpy about wkb.ug URLs
1842
1843         Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
1844         use wkb.ug URLs
1845
1846         Reviewed by Anders Carlsson.
1847
1848         * Scripts/webkitpy/common/checkout/changelog.py:
1849         (parse_bug_id):
1850         (parse_bug_id_from_changelog):
1851         Fall back to the tiny URL format if neither the short nor long URL formats work.
1852
1853         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1854         (ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.
1855
1856         * Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match
1857         wkb.ug URLs.
1858
1859 2012-02-28  János Badics  <dicska@gmail.com>
1860
1861         [Qt] build-webkit does not detect the number of CPUs
1862         https://bugs.webkit.org/show_bug.cgi?id=76445
1863
1864         Based on Seo Sanghyeon's work (modification:
1865         Automatically determine the number of CPUs for make
1866         only if -j make argument haven't already been specified.)
1867
1868         Reviewed by Csaba Osztrogonác.
1869
1870         * Scripts/webkitdirs.pm:
1871         (buildQMakeProjects):
1872
1873 2012-02-28  Kent Tamura  <tkent@chromium.org>
1874
1875         Update a pattern for forms files of watchlist
1876         https://bugs.webkit.org/show_bug.cgi?id=79767
1877
1878         Reviewed by Kentaro Hara.
1879
1880         * Scripts/webkitpy/common/config/watchlist:
1881         Catches the following files with the "Forms" pattern.
1882         - HTMLDatListElement.*
1883         - HTMLKeygenElement.*
1884         - HTMLLegendElement.*
1885         - HTMLOutputElement.*
1886         - FormAssociatedElement.*
1887         - SliderThumbElement.*
1888         - TextControlInnerElements.*
1889         - RenderFileUploadControl.*
1890
1891 2012-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1892
1893         Unreviewed, rolling out r109041.
1894         http://trac.webkit.org/changeset/109041
1895         https://bugs.webkit.org/show_bug.cgi?id=79741
1896
1897         Broke Chromium Win build (Requested by bashi on #webkit).
1898
1899         * DumpRenderTree/chromium/LayoutTestController.cpp:
1900         (LayoutTestController::LayoutTestController):
1901         * DumpRenderTree/chromium/LayoutTestController.h:
1902         (LayoutTestController):
1903         * DumpRenderTree/chromium/WebViewHost.h:
1904
1905 2012-02-27  James Robinson  <jamesr@chromium.org>
1906
1907         [chromium] Remove media tests from ChromiumGpu configurations
1908         https://bugs.webkit.org/show_bug.cgi?id=79720
1909
1910         Reviewed by Adam Barth.
1911
1912         We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
1913         composited playback path via tests in the compositing/ directory.
1914
1915         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1916         (_default_tests_paths):
1917         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1918         (ChromiumGpuTest.test_default_tests_paths):
1919         (ChromiumGpuTest.test_test_files):
1920
1921 2012-02-27  Dirk Pranke  <dpranke@chromium.org>
1922
1923         nrwt: log multiline stderr/crash output properly
1924         https://bugs.webkit.org/show_bug.cgi?id=79722
1925
1926         Reviewed by Adam Barth.
1927
1928         This cleans up some nits in the log output to make things
1929         slightly easier to read (every line gets timestamped, etc.).
1930
1931         Also tweaks the log message for pixel hash mismatches.
1932
1933         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1934         (SingleTestRunner._handle_error):
1935         (SingleTestRunner._compare_image):
1936
1937 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1938
1939         Touch the master.cfg to force a reconfig.
1940
1941         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1942         (BuildAndTestLeaksFactory):
1943         (NewBuildAndTestFactory):
1944
1945 2012-02-27  Jacky Jiang  <zhajiang@rim.com>
1946
1947         [BlackBerry] Upstream BlackBerry API web page related files
1948         https://bugs.webkit.org/show_bug.cgi?id=74380
1949
1950         Reviewed by Antonio Gomes.
1951
1952         Adapt to the removing of WebPage::mainFrame(), use
1953         DumpRenderTreeSupport::corePage() and its mainFrame() instead.
1954
1955         No new tests as this patch doesn't change behavior.
1956
1957         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1958         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1959         (BlackBerry::WebKit::DumpRenderTree::runTests):
1960
1961 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1962
1963         Add Windows and Linux Chromium perf bots
1964         https://bugs.webkit.org/show_bug.cgi?id=79418
1965
1966         Reviewed by Tony Chang.
1967
1968         Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
1969         the dedicated perf bot slave (uses the same hardware).
1970
1971         * BuildSlaveSupport/build.webkit.org-config/config.json:
1972
1973 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
1974
1975         Undefined variable 'current' when running chromium_android.py
1976         https://bugs.webkit.org/show_bug.cgi?id=79696
1977
1978         Reviewed by Adam Barth.
1979
1980         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1981         (ChromiumAndroidDriver._read_prompt):
1982
1983 2012-02-27  Greg Billock  <gbillock@google.com>
1984
1985         Add more tests for web intents
1986         https://bugs.webkit.org/show_bug.cgi?id=79527
1987
1988         Reviewed by Adam Barth.
1989
1990         * DumpRenderTree/chromium/LayoutTestController.cpp:
1991         (LayoutTestController::LayoutTestController):
1992         (LayoutTestController::sendWebIntentResponse):
1993         * DumpRenderTree/chromium/LayoutTestController.h:
1994         (LayoutTestController):
1995         * DumpRenderTree/chromium/WebViewHost.h:
1996         (WebViewHost):
1997         (WebViewHost::currentIntentRequest):
1998
1999 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
2000
2001         Chromium-Android layout test script: the adb shell prompt is not always '# '
2002         https://bugs.webkit.org/show_bug.cgi?id=79506
2003
2004         Reviewed by Adam Barth.
2005
2006         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2007         (ChromiumAndroidDriver._start):
2008         (ChromiumAndroidDriver._read_prompt):
2009
2010 2012-02-27  Dan Bernstein  <mitz@apple.com>
2011
2012         Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
2013         https://bugs.webkit.org/show_bug.cgi?id=79607
2014
2015         Reviewed by Adele Peterson.
2016
2017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2018         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
2019         (TestWebKitAPI::AcceptsFirstMouse::url):
2020         (TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
2021         (TestWebKitAPI::AcceptsFirstMouse::runTest):
2022         (TestWebKitAPI::TEST_F):
2023         * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
2024
2025 2012-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2026
2027         Unreviewed. Fix make distcheck.
2028
2029         * GNUmakefile.am: Fix typo.
2030
2031 2012-02-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2032
2033         [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
2034
2035         Reviewed by Kenneth Rohde Christiansen..
2036
2037         * qmake/mkspecs/features/features.prf:
2038
2039 2012-02-27  Hao Zheng  <zhenghao@chromium.org>
2040
2041         Add a ChromiumGpuAndroid port.
2042         https://bugs.webkit.org/show_bug.cgi?id=79628
2043
2044         Reviewed by Adam Barth.
2045
2046         Android does have a gpu port, so revert r107697.
2047
2048         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2049         (ChromiumAndroidPort.__init__):
2050         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2051         (ChromiumGpuAndroidPort):
2052         (ChromiumGpuAndroidPort.__init__):
2053         (ChromiumGpuAndroidPort.baseline_search_path):
2054         (ChromiumGpuAndroidPort.default_child_processes):
2055         (ChromiumGpuAndroidPort.tests):
2056         * Scripts/webkitpy/layout_tests/port/factory.py:
2057         (PortFactory):
2058
2059 2012-02-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2060
2061         Change Build bot with BuildAndTest bot for EFL port.
2062         https://bugs.webkit.org/show_bug.cgi?id=77518
2063
2064         Reviewed by Ryosuke Niwa.
2065
2066         EFL build bot starts to support layout test.
2067
2068         * BuildSlaveSupport/build.webkit.org-config/config.json:
2069         * BuildSlaveSupport/built-product-archive:
2070         (archiveBuiltProduct):
2071         (extractBuiltProduct):
2072         * BuildSlaveSupport/test-result-archive:
2073         (archiveTestResults):
2074         * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
2075         (generateBuildSystemFromCMakeProject):
2076
2077 2012-02-24  Darin Fisher  <darin@chromium.org>
2078
2079         Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
2080
2081         Reviewed by James Robinson.
2082
2083         * Scripts/webkitpy/common/config/watchlist:
2084
2085 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2086
2087         webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
2088         https://bugs.webkit.org/show_bug.cgi?id=79258
2089
2090         Reviewed by Ryosuke Niwa.
2091
2092         Split the fuzzy matching into separate functions so that they
2093         can be sharded and run in parallel.
2094
2095         Also, fix a bug in the svn_blame_regexp that was causing us
2096         to require ChangeLog lines to have at least one space after the
2097         author, making the code require trailing whitespace in the
2098         changelog in some places (this was making my life harder because
2099         I have my text editor set to strip trailing whitespace in python
2100         files, and that was causing test_parse_log_entries_from_changelog() to fail
2101         when the whitespace on line 275 was removed).
2102
2103         * Scripts/webkitpy/common/checkout/changelog.py:
2104         (ChangeLog):
2105         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2106         (test_fuzzy_reviewer_match__none):
2107         (test_fuzzy_reviewer_match_adam_barth):
2108         (test_fuzzy_reviewer_match_darin_adler_et_al):
2109         (test_fuzzy_reviewer_match_dimitri_glazkov):
2110         (test_fuzzy_reviewer_match_george_staikos):
2111         (test_fuzzy_reviewer_match_mark_rowe):
2112
2113 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2114
2115         webkitpy: committers_unittest fuzzy matching is really slow
2116         https://bugs.webkit.org/show_bug.cgi?id=79179
2117
2118         Reviewed by Ryosuke Niwa.
2119
2120         Break the fuzzy matching tests into individual routines for
2121         each contributor so that the intent is a little clearer, so
2122         that it's easier to test individual names (and identify
2123         duplicate tests), and so that we can eventually run
2124         them in parallel.
2125
2126         Also, mark most of them as 'integration' tests so that they
2127         can be skipped if we want to go fast (we leave a few as
2128         regular tests for functional coverage).
2129
2130         * Scripts/webkitpy/common/config/committers_unittest.py:
2131         (CommittersTest):
2132         (CommittersTest.test_contributors_by_fuzzy_match):
2133         (CommittersTest.integration_test_contributors__none):
2134         (CommittersTest.integration_test_contributors__none_2):
2135         (CommittersTest.integration_test_contributors__none_3):
2136         (CommittersTest.integration_test_contributors_ada_chan):
2137         (CommittersTest.integration_test_contributors_adele_peterson):
2138         (CommittersTest.integration_test_contributors_alexey_proskuryakov):
2139         (CommittersTest.integration_test_contributors_alice_liu):
2140         (CommittersTest.integration_test_contributors_alp_toker):
2141         (CommittersTest.integration_test_contributors_anders_carlsson):
2142         (CommittersTest.integration_test_contributors_antti_koivisto):
2143         (CommittersTest.integration_test_contributors_beth_dakin):
2144         (CommittersTest.integration_test_contributors_brady_eidson):
2145         (CommittersTest.integration_test_contributors_cameron_zwarich):
2146         (CommittersTest.integration_test_contributors_chris_blumenberg):
2147         (CommittersTest.integration_test_contributors_dan_bernstein):
2148         (CommittersTest.integration_test_contributors_dan_bernstein_2):
2149         (CommittersTest.integration_test_contributors_darin_adler):
2150         (CommittersTest.integration_test_contributors_david_harrison):
2151         (CommittersTest.integration_test_contributors_david_harrison_2):
2152         (CommittersTest.integration_test_contributors_david_hyatt):
2153         (CommittersTest.integration_test_contributors_david_kilzer):
2154         (CommittersTest.integration_test_contributors_don_melton):
2155         (CommittersTest.integration_test_contributors_eric_seidel):
2156         (CommittersTest.integration_test_contributors_geoffrey_garen):
2157         (CommittersTest.integration_test_contributors_greg_bolsinga):
2158         (CommittersTest.integration_test_contributors_holger_freyther):
2159         (CommittersTest.integration_test_contributors_jon_sullivan):
2160         (CommittersTest.integration_test_contributors_jon_honeycutt):
2161         (CommittersTest.integration_test_contributors_joseph_pecoraro):
2162         (CommittersTest.integration_test_contributors_ken_kocienda):
2163         (CommittersTest.integration_test_contributors_kenneth_russell):
2164         (CommittersTest.integration_test_contributors_kevin_decker):
2165         (CommittersTest.integration_test_contributors_kevin_mccullough):
2166         (CommittersTest.integration_test_contributors_lars_knoll):
2167         (CommittersTest.integration_test_contributors_lars_weintraub):
2168         (CommittersTest.integration_test_contributors_maciej_stachowiak):
2169         (CommittersTest.integration_test_contributors_mark_rowe):
2170         (CommittersTest.integration_test_contributors_nikolas_zimmermann):
2171         (CommittersTest.integration_test_contributors_oliver_hunt):
2172         (CommittersTest.integration_test_contributors_rniwa):
2173         (CommittersTest.disabled_integration_test_contributors_simon_fraser):
2174         (CommittersTest.integration_test_contributors_steve_falkenburg):
2175         (CommittersTest.integration_test_contributors_sam_weinig):
2176         (CommittersTest.integration_test_contributors_tim_omernick):
2177         (CommittersTest.integration_test_contributors_timothy_hatcher):
2178         (CommittersTest.integration_test_contributors_tor_arne_vestbo):
2179         (CommittersTest.integration_test_contributors_vicki_murley):
2180         (CommittersTest.integration_test_contributors_zack_rusin):
2181
2182 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2183
2184         webkitpy: should autoinstall coverage
2185         https://bugs.webkit.org/show_bug.cgi?id=79535
2186
2187         Reviewed by Eric Seidel.
2188
2189         We should automatically print the coverage report after the run, too.
2190
2191         * Scripts/webkitpy/test/main.py:
2192         (Tester._run_tests):
2193         * Scripts/webkitpy/thirdparty/__init__.py:
2194         (AutoinstallImportHook.find_module):
2195         (AutoinstallImportHook._install_coverage):
2196
2197 2012-02-24  Pablo Flouret  <pablof@motorola.com>
2198
2199         Fix copypasta in build-webkit's --vibration option description
2200         https://bugs.webkit.org/show_bug.cgi?id=79528
2201
2202         Reviewed by Andreas Kling.
2203
2204         * Scripts/build-webkit:
2205
2206 2012-02-24  Antonio Gomes  <agomes@rim.com>
2207
2208         Adding myself to ScrollingCoordinator watchlist
2209         https://bugs.webkit.org/show_bug.cgi?id=79525
2210
2211         Reviewed by Rob Buis.
2212
2213         * Scripts/webkitpy/common/config/watchlist:
2214
2215 2012-02-24  Darin Fisher  <darin@chromium.org>
2216
2217         Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
2218
2219         Reviewed by Adam Barth.
2220
2221         * Scripts/webkitpy/common/config/watchlist:
2222
2223 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
2224
2225         webkitpy: config_unittest is sensitive to other tests that might've already run
2226         https://bugs.webkit.org/show_bug.cgi?id=79382
2227
2228         Reviewed by Adam Barth.
2229
2230         If another test runs prior to config_unittest and pokes the
2231         cached configuration, the first test in config_unittest might
2232         fail; the tearDown() will then allow subsequent tests to pass.
2233         Clearing the configuration prior to each test makes things
2234         slightly slower but safer.
2235
2236         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2237         (ConfigTest.setUp):
2238
2239 2012-02-24  David Kilzer  <ddkilzer@apple.com>
2240
2241         Use xcrun to find compiler paths for Generate Derived Sources build phase script
2242         <http://webkit.org/b/79512>
2243
2244         Reviewed by Dan Bernstein.
2245
2246         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2247         (Generate Derived Sources): Use xcrun to find the path to the
2248         compiler since that works on both iOS and OS X.
2249
2250 2012-02-24  James Robinson  <jamesr@chromium.org>
2251
2252         Create a watchlist for ScrollingCoordinator changes
2253         https://bugs.webkit.org/show_bug.cgi?id=79511
2254
2255         Reviewed by Anders Carlsson.
2256
2257         * Scripts/webkitpy/common/config/watchlist:
2258
2259 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2260
2261         [EFL][DRT] Implement setValueForUser and setAutofilled.
2262         https://bugs.webkit.org/show_bug.cgi?id=79237
2263
2264         Reviewed by Andreas Kling.
2265
2266         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
2267         Those implementations are related with input fields and allow to pass following tests:
2268         fast/forms/onchange-setvalueforuser.html
2269         fast/forms/input-autofilled.html
2270         fast/forms/reset-autofilled.html
2271
2272         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2273         (LayoutTestController::setValueForUser):
2274         (LayoutTestController::setAutofilled):
2275
2276 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
2277
2278         [Qt] Allow to use WebCore imagedecoders
2279         https://bugs.webkit.org/show_bug.cgi?id=32410
2280
2281         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
2282
2283         Reviewed by Simon Hausmann.
2284
2285         * qmake/mkspecs/features/features.prf:
2286
2287 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
2288
2289         [Qt] Add Qt5 way to force 96 DPI for tests
2290         https://bugs.webkit.org/show_bug.cgi?id=79364
2291
2292         Reviewed by Simon Hausmann.
2293
2294         * DumpRenderTree/qt/main.cpp:
2295         (main):
2296         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2297         (WTR::activateFonts):
2298
2299 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2300
2301         [GTK] MiniBrowser should reload the view then the reload button is clicked
2302         https://bugs.webkit.org/show_bug.cgi?id=79472
2303
2304         Reviewed by Philippe Normand.
2305
2306         * MiniBrowser/gtk/BrowserWindow.c:
2307         (reloadCallback): Call webkit_web_view_reload().
2308         (browser_window_init): Connect reload item clicked even to
2309         reloadCallback instead of activateUriEntryCallback.
2310
2311 2012-02-24  Kentaro Hara  <haraken@chromium.org>
2312
2313         Add performance tests for DOM attribute getters and setters
2314         https://bugs.webkit.org/show_bug.cgi?id=79208
2315
2316         Reviewed by Ryosuke Niwa.
2317
2318         We want to allow perf tests to output info messages
2319         that do not affect the test results. To accomplish this,
2320         this patch modifies perftestsrunner.py so that it ignores
2321         a line that starts from "Info:".
2322
2323         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2324         (PerfTestsRunner):
2325
2326 2012-02-24  Andrew Lo  <anlo@rim.com>
2327
2328         [BlackBerry] Enable requestAnimationFrame
2329         https://bugs.webkit.org/show_bug.cgi?id=79408
2330
2331         Enable requestAnimationFrame for BlackBerry.
2332
2333         Reviewed by Rob Buis.
2334
2335         * Scripts/build-webkit:
2336
2337 2012-02-24  Adam Barth  <abarth@webkit.org>
2338
2339         style-queue tries to apply the patch twice
2340         https://bugs.webkit.org/show_bug.cgi?id=79459
2341
2342         Reviewed by Eric Seidel.
2343
2344         Previously, we applied the patch using both apply-patch and
2345         check-style.  This patch introduces a check-style-local to mirror the
2346         apply-watchlist-local, which operates on the current working diff.
2347
2348         This patch also cleans up some other bugs I found by running the queue
2349         locally for a while.  The queue still prints out a slightly
2350         less-than-ideal message on the bugs when it find an error, but it's ok
2351         for now.  We'll need to iterate a bit.
2352
2353         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2354         (StyleQueueTask.validate):
2355         (StyleQueueTask._check_style):
2356         * Scripts/webkitpy/tool/commands/download.py:
2357         (CheckStyleLocal):
2358         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2359         (EarlyWarningSytemTest._default_expected_stderr):
2360         (EarlyWarningSytemTest._test_testing_ews):
2361         * Scripts/webkitpy/tool/commands/queues.py:
2362         (AbstractReviewQueue.handle_script_error):
2363         (StyleQueue.review_patch):
2364         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2365         * Scripts/webkitpy/tool/commands/queuestest.py:
2366         (QueuesTest.assert_queue_outputs):
2367
2368 2012-02-23  Adam Barth  <abarth@webkit.org>
2369
2370         should_proceed_with_work_item is unused and can be removed
2371         https://bugs.webkit.org/show_bug.cgi?id=79416
2372
2373         Reviewed by Eric Seidel.
2374
2375         We used to use this function to check whether the tree is red.  Now, we
2376         don't use external measures of whether to proceed with work items.
2377         Instead, we analyze them with the idea in mind that the tree might be
2378         red.
2379
2380         * Scripts/webkitpy/tool/bot/queueengine.py:
2381         (QueueEngineDelegate.next_work_item):
2382         (QueueEngine.run):
2383         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2384         (LoggingDelegate):
2385         (LoggingDelegate.next_work_item):
2386         (RaisingDelegate.process_work_item):
2387         (QueueEngineTest.test_terminating_error):
2388         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2389         (AbstractEarlyWarningSystem.__init__):
2390         * Scripts/webkitpy/tool/commands/queues.py:
2391         (AbstractQueue.next_work_item):
2392         (FeederQueue.next_work_item):
2393         (CommitQueue.next_work_item):
2394         (AbstractReviewQueue.next_work_item):
2395         (StyleQueue.__init__):
2396         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2397         (FeederQueueTest.test_feeder_queue):
2398         (CommitQueueTest.test_commit_queue):
2399         (test_commit_queue_failure):
2400         (test_commit_queue_failure_with_failing_tests):
2401         (test_rollout):
2402         (test_rollout_lands):
2403         (StyleQueueTest.test_style_queue_with_style_exception):
2404         (test_style_queue_with_watch_list_exception):
2405         * Scripts/webkitpy/tool/commands/queuestest.py:
2406         (QueuesTest.assert_queue_outputs):
2407         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2408         (SheriffBot.next_work_item):
2409
2410 2012-02-23  Adrienne Walker  <enne@google.com>
2411
2412         Unreviewed, add Stephen Chenney to committers.py as a contributor.
2413
2414         * Scripts/webkitpy/common/config/committers.py:
2415
2416 2012-02-23  Adam Barth  <abarth@webkit.org>
2417
2418         style-queue logs bogus messages to the QueueStatusServer
2419         https://bugs.webkit.org/show_bug.cgi?id=79424
2420
2421         Reviewed by Eric Seidel.
2422
2423         Copy/paste error.
2424
2425         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2426         (StyleQueueTask._check_style):
2427         (StyleQueueTask._apply_watch_list):
2428         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2429
2430 2012-02-23  Eric Seidel  <eric@webkit.org>
2431
2432         Use self._filesystem in more places in the SCM classes
2433         https://bugs.webkit.org/show_bug.cgi?id=79415
2434
2435         Reviewed by Adam Barth.
2436
2437         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2438         (SCMDetectorTest.test_detect_scm_system):
2439         * Scripts/webkitpy/common/checkout/scm/git.py:
2440         (Git.find_checkout_root):
2441         (Git.to_object_name):
2442         * Scripts/webkitpy/common/checkout/scm/scm.py:
2443         (SCM.__init__):
2444         (SCM.in_working_directory):
2445         * Scripts/webkitpy/common/checkout/scm/svn.py:
2446         (SVN.find_uuid):
2447         (SVN.find_checkout_root):
2448
2449 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2450
2451         Unreviewed, rolling out r108685.
2452         http://trac.webkit.org/changeset/108685
2453         https://bugs.webkit.org/show_bug.cgi?id=79414
2454
2455         Broke Chromium builds (Requested by enne on #webkit).
2456
2457         * qmake/mkspecs/features/features.prf:
2458
2459 2012-02-23  Adam Barth  <abarth@webkit.org>
2460
2461         style-queue shouldn't spam bugs if it fails to update its working copy
2462         https://bugs.webkit.org/show_bug.cgi?id=79412
2463
2464         Reviewed by Eric Seidel.
2465
2466         This patch moves style-queue over to the new PatchAnalysisTask
2467         infrastructure, which is smarter about retrying patches when update
2468         fails.
2469
2470         * Scripts/webkitpy/common/system/executive_mock.py:
2471         (MockExecutive.run_and_throw_if_fail):
2472         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2473         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2474         (UnableToApplyPatch):
2475         (UnableToApplyPatch.__init__):
2476         (PatchAnalysisTask.__init__):
2477         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
2478         (StyleQueueTaskDelegate):
2479         (StyleQueueTaskDelegate.parent_command):
2480         (StyleQueueTask):
2481         (StyleQueueTask.validate):
2482         (StyleQueueTask._check_style):
2483         (StyleQueueTask._apply_watch_list):
2484         (StyleQueueTask.run):
2485         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2486         * Scripts/webkitpy/tool/commands/queues.py:
2487         (StyleQueue):
2488         (StyleQueue.should_proceed_with_work_item):
2489         (StyleQueue.review_patch):
2490         (StyleQueue.run_command):
2491         (StyleQueue.command_passed):
2492         (StyleQueue.command_failed):
2493         (StyleQueue.expected_failures):
2494         (StyleQueue.refetch_patch):
2495         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2496         (StyleQueueTest.test_style_queue_with_style_exception):
2497         (test_style_queue_with_watch_list_exception):
2498
2499 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
2500
2501         [Qt] Allow to use WebCore imagedecoders
2502         https://bugs.webkit.org/show_bug.cgi?id=32410
2503
2504         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
2505
2506         Reviewed by Simon Hausmann.
2507
2508         * qmake/mkspecs/features/features.prf:
2509
2510 2012-02-23  Eric Seidel  <eric@webkit.org>
2511
2512         Remove old broken find_checkout_root tests now that find_checkout_root is gone
2513         https://bugs.webkit.org/show_bug.cgi?id=79405
2514
2515         Reviewed by Adam Barth.
2516
2517         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
2518         (SCMDetectorTest):
2519         (SCMDetectorTest.test_find_checkout_root):
2520         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2521         (SVNTestRepository.tear_down):
2522
2523 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
2524
2525         [Qt][WK2] Implement proxy authentication dialog.
2526         https://bugs.webkit.org/show_bug.cgi?id=79350
2527
2528         Reviewed by Simon Hausmann.
2529
2530         * MiniBrowser/qt/MiniBrowser.qrc:
2531         * MiniBrowser/qt/qml/BrowserWindow.qml:
2532         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
2533
2534 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
2535
2536         [wx] Build fix, add recently added source dirs.
2537
2538         * waf/build/settings.py:
2539
2540 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
2541
2542         [Qt] Add support for touch cancellation
2543         https://bugs.webkit.org/show_bug.cgi?id=79348
2544
2545         Reviewed by Kenneth Rohde Christiansen.
2546
2547         Added straight-forward touch cancellation event sending to Qt WK1 DRT
2548         and WK2 WTR.
2549
2550         * DumpRenderTree/qt/EventSenderQt.cpp:
2551         (EventSender::touchCancel):
2552         (EventSender::cancelTouchPoint):
2553         * DumpRenderTree/qt/EventSenderQt.h:
2554         (EventSender):
2555         * WebKitTestRunner/EventSenderProxy.h:
2556         (EventSenderProxy):
2557         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2558         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2559         (WTR::EventSendingController::touchCancel):
2560         (WTR):
2561         (WTR::EventSendingController::cancelTouchPoint):
2562         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2563         (EventSendingController):
2564         * WebKitTestRunner/TestController.cpp:
2565         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2566         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2567         (WTR::EventSenderProxy::touchCancel):
2568         (WTR):
2569         (WTR::EventSenderProxy::cancelTouchPoint):
2570
2571 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2572
2573         Unreviewed, rolling out r108626.
2574         http://trac.webkit.org/changeset/108626
2575         https://bugs.webkit.org/show_bug.cgi?id=79370
2576
2577         broke qt-wk2 bot, somehow the workaround does not work on the
2578         bot (Requested by Ossy on #webkit).
2579
2580         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2581         (WTR::WrapperWindow::handleStatusChanged):
2582         (WTR::PlatformWebView::resizeTo):
2583
2584 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
2585
2586         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
2587         https://bugs.webkit.org/show_bug.cgi?id=78481
2588
2589         Reviewed by Gustavo Noronha Silva.
2590
2591         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
2592         to create gdk press key event.
2593         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
2594         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
2595
2596         * DumpRenderTree/gtk/EventSender.cpp:
2597         (scheduleAsynchronousClickCallback):
2598         (createKeyPressEvent):
2599         (sendKeyDown):
2600         (keyDownCallback):
2601         (sendAsynchronousKeyDown):
2602         (scheduleAsynchronousKeyDownCallback):
2603
2604 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
2605
2606         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
2607         https://bugs.webkit.org/show_bug.cgi?id=76546
2608
2609         Reviewed by Simon Hausmann.
2610
2611         Co-authored with Simon Hausmann.
2612
2613         Revert the workaround introduced in r107868 and reintroduce
2614         the qml binding so we can test the code path that we are more
2615         interested in. The reason that it did not work before is that
2616         we don't have an active platform window which we now workaround
2617         by propagating the resize through QWindowSystemInterface.
2618
2619         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2620         (WTR::WrapperWindow::handleStatusChanged):
2621         (WTR::PlatformWebView::resizeTo):
2622
2623 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2624
2625         Unreviewed, rolling out r108577.
2626         http://trac.webkit.org/changeset/108577
2627         https://bugs.webkit.org/show_bug.cgi?id=79359
2628
2629         It doesn't work as expected (Requested by Ossy on #webkit).
2630
2631         * DumpRenderTree/qt/EventSenderQt.cpp:
2632         (EventSender::postEvent):
2633         * DumpRenderTree/qt/EventSenderQt.h:
2634         (EventSender):
2635
2636 2012-02-23  Philippe Normand  <pnormand@igalia.com>
2637
2638         [GTK] FullScreen signals
2639         https://bugs.webkit.org/show_bug.cgi?id=76181
2640
2641         Reviewed by Martin Robinson.
2642
2643         Use the two new entering/leaving fullscreen signals to hide/show
2644         the tool bar, the status bar and ask the user's permission before
2645         entering fullscreen.
2646
2647         * GtkLauncher/main.c:
2648         (webViewFullscreenMessageWindowClose):
2649         (webViewWindowStateEvent):
2650         (hide_widget):
2651         (show_widget):
2652         (webViewEnteringFullScreen):
2653         (webViewLeavingFullScreen):
2654         (createBrowser):
2655         (createWindow):
2656
2657 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
2658
2659         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
2660         https://bugs.webkit.org/show_bug.cgi?id=79076
2661
2662         Reviewed by Andreas Kling.
2663
2664         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
2665         (builtDylibPathForName):
2666
2667 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2668
2669         [Qt] Add eventSender.gestureTap
2670         https://bugs.webkit.org/show_bug.cgi?id=66173
2671
2672         Reviewed by Kenneth Rohde Christiansen.
2673
2674         * DumpRenderTree/qt/EventSenderQt.cpp:
2675         (EventSender::gestureTap):
2676         * DumpRenderTree/qt/EventSenderQt.h:
2677
2678 2012-02-22  Brady Eidson  <beidson@apple.com>
2679
2680         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
2681         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
2682
2683         Reviewed by Anders Carlsson.
2684
2685         Update our tools to the new form of the PageLoadClient.
2686
2687         * MiniBrowser/mac/BrowserWindowController.m:
2688         (-[BrowserWindowController awakeFromNib]):
2689
2690         * WebKitTestRunner/TestController.cpp:
2691         (WTR::TestController::initialize):
2692
2693 2012-02-22  Daniel Bates  <dbates@webkit.org>
2694
2695         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
2696         https://bugs.webkit.org/show_bug.cgi?id=79277
2697
2698         Reviewed by Adam Barth.
2699
2700         Pass command line argument no-saved-state to run-safari to disable Safari
2701         state restoration for the session on OS 10.7.
2702
2703         * Scripts/webkitpy/layout_tests/port/mac.py:
2704         (MacPort.show_results_html_file):
2705         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2706         (test_show_results_html_file):
2707
2708 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
2709
2710         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
2711         https://bugs.webkit.org/show_bug.cgi?id=77759
2712
2713         Reviewed by Tony Chang.
2714
2715         Fixes build with gcc 4.7.
2716
2717         r100432 added the include only for ANDROID; this changes the ifdef to
2718         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
2719         longer implicitly includes unistd.h from standard headers and other
2720         unix platforms are likely to get gcc 4.7 as well in the future.
2721
2722         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2723
2724 2012-02-22  Philippe Normand  <pnormand@igalia.com>
2725
2726         Unreviewed, rolling out r108522.
2727         http://trac.webkit.org/changeset/108522
2728         https://bugs.webkit.org/show_bug.cgi?id=76181
2729
2730         Broke 4 fullscreen tests on GTK.
2731
2732         * GtkLauncher/main.c:
2733         (createBrowser):
2734         (createWindow):
2735
2736 2012-02-20  Philippe Normand  <pnormand@igalia.com>
2737
2738         [GTK] FullScreen signals
2739         https://bugs.webkit.org/show_bug.cgi?id=76181
2740
2741         Reviewed by Martin Robinson.
2742
2743         Use the two new entering/leaving fullscreen signals to hide/show
2744         the tool bar, the status bar and ask the user's permission before
2745         entering fullscreen.
2746
2747         * GtkLauncher/main.c:
2748         (webViewFullscreenMessageWindowClose):
2749         (webViewWindowStateEvent):
2750         (hide_widget):
2751         (show_widget):
2752         (webViewEnteringFullScreen):
2753         (webViewLeavingFullScreen):
2754         (createBrowser):
2755         (createWindow):
2756
2757 2012-02-22  Rob Flack  <flackr@chromium.org>
2758
2759         Update Linux ChromiumOS builders in flakiness dashboard.
2760         https://bugs.webkit.org/show_bug.cgi?id=79238
2761
2762         Reviewed by Ojan Vafai.
2763
2764         * TestResultServer/static-dashboards/builders.js:
2765
2766 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
2767
2768         webkitpy: test_function_length_check_definition_huge_lines is slow
2769         https://bugs.webkit.org/show_bug.cgi?id=79185
2770
2771         Reviewed by Adam Barth.
2772
2773         This test takes ~3 seconds to run, apparently because we're
2774         running a test on a 10,000 line function :). Dropping the
2775         function length to 640 still exercises the code path and
2776         provides a 10x speedup.
2777
2778         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2779         (CppStyleTest):
2780         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
2781
2782 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
2783
2784         webkitpy: speed up FileLockTest.test_lock_lifecycle
2785         https://bugs.webkit.org/show_bug.cgi?id=79189
2786
2787         Reviewed by Adam Barth.
2788
2789         The unit test had a second lock trying to acquire a
2790         lock already held, and a hard-coded timeout of one second.
2791         I have changed the timeouts to a tenth of a second (which
2792         is probably still fine) and changed the hard-spin on
2793         the lock to a slow-spin every hundredth of a second.
2794
2795         * Scripts/webkitpy/common/system/file_lock.py:
2796         (FileLock.acquire_lock):
2797         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
2798         (FileLockTest.setUp):
2799         (FileLockTest.test_stuck_lock):
2800
2801 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
2802
2803         build-webkit should use environment variable at number of CPU
2804         detection on all platform
2805         https://bugs.webkit.org/show_bug.cgi?id=79227
2806
2807         Reviewed by Martin Robinson.
2808
2809         * Scripts/webkitdirs.pm:
2810         (determineNumberOfCPUs):
2811
2812 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
2813
2814         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
2815         https://bugs.webkit.org/show_bug.cgi?id=78960
2816
2817         Reviewed by Csaba Osztrogonác.
2818
2819         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2820         (LayoutTestController::overridePreference):
2821
2822 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
2823
2824         [chromium] Build WebKit with MEDIA_STREAM disabled.
2825         https://bugs.webkit.org/show_bug.cgi?id=79214
2826
2827         Reviewed by Kent Tamura.
2828
2829         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
2830         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
2831         * DumpRenderTree/chromium/WebViewHost.cpp:
2832         (WebViewHost::createMediaPlayer):
2833         * DumpRenderTree/chromium/WebViewHost.h:
2834         (WebViewHost):
2835
2836 2012-02-22  Zeno Albisser  <zeno@webkit.org>
2837
2838         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
2839         https://bugs.webkit.org/show_bug.cgi?id=79124
2840
2841         WebKitTestRunnerPrefix.h should also be included
2842         when building with clang.
2843
2844         Reviewed by Kenneth Rohde Christiansen.
2845
2846         * WebKitTestRunner/Target.pri:
2847
2848 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
2849
2850         <style scoped>: Add runtime-flag
2851         https://bugs.webkit.org/show_bug.cgi?id=79074
2852
2853         Enable the runtime-flag for DRT.
2854
2855         Reviewed by Dimitri Glazkov.
2856
2857         * DumpRenderTree/chromium/TestShell.cpp:
2858         (TestShell::TestShell):
2859
2860 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2861
2862         Unreviewed, rolling out r107351.
2863         http://trac.webkit.org/changeset/107351
2864         https://bugs.webkit.org/show_bug.cgi?id=53600
2865
2866         Several issues introduced in WebKitGTK+ API
2867
2868         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2869         (createWebView):
2870         * GtkLauncher/main.c:
2871         (createWebViewCb):
2872         (createBrowser):
2873         (createWindow):
2874         (main):
2875
2876 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
2877
2878         JSC should be a triple-tier VM
2879         https://bugs.webkit.org/show_bug.cgi?id=75812
2880         <rdar://problem/10079694>
2881
2882         Reviewed by Gavin Barraclough.
2883
2884         Changed EFL's build system to include a new directory in JavaScriptCore.
2885
2886         * DumpRenderTree/efl/CMakeLists.txt:
2887
2888 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
2889
2890         [chromium] Fix image drag out on Chromium
2891         https://bugs.webkit.org/show_bug.cgi?id=79158
2892
2893         Reviewed by Tony Chang.
2894
2895         * DumpRenderTree/chromium/EventSender.cpp:
2896         (EventSender::dumpFilenameBeingDragged):
2897         (EventSender::beginDragWithFiles):
2898         * DumpRenderTree/chromium/WebViewHost.cpp:
2899         (addDRTFakeFileToDataObject):
2900
2901 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2902
2903         webkitpy: speed up hot filesystem_mock functions
2904         https://bugs.webkit.org/show_bug.cgi?id=79159
2905
2906         Reviewed by Adam Barth.
2907
2908         Profiling run_webkit_tests_integrationtest.py revealed that
2909         isdir(), normpath(), and join() are called a lot and were very
2910         slow.This patch speeds them up substantially, shaving 20 seconds
2911         off of the execution time.
2912
2913         * Scripts/webkitpy/common/system/filesystem_mock.py:
2914         (MockFileSystem.isdir):
2915         (MockFileSystem._slow_but_correct_join):
2916         (MockFileSystem.join):
2917         (MockFileSystem.listdir):
2918         (MockFileSystem._slow_but_correct_normpath):
2919         (MockFileSystem.normpath):
2920         (MockFileSystem.write_binary_file):
2921         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2922         (MockFileSystemTest.quick_check):
2923         (MockFileSystemTest):
2924         (MockFileSystemTest.test_join):
2925         (MockFileSystemTest.test_normpath):
2926         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2927         (get_test_config): Call write_binary_file() instead of updating
2928           filesystem.files directly, so that we create directories as
2929           needed.
2930
2931 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2932
2933         nrwt: make the delay between starting workers configurable per-port
2934         https://bugs.webkit.org/show_bug.cgi?id=79148
2935
2936         Reviewed by Eric Seidel.
2937
2938         Because of bug 79147, we have to sleep a bit in between starting
2939         DRTs; however, doing so across the board slows down the Test
2940         port. Making this configurable shaves 10 seconds off of
2941         run_webkit_tests_integrationtest.py
2942
2943         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2944         (Manager._run_tests):
2945         * Scripts/webkitpy/layout_tests/port/base.py:
2946         (Port.worker_startup_delay_secs):
2947         * Scripts/webkitpy/layout_tests/port/test.py:
2948         (TestPort.worker_startup_delay_secs):
2949
2950 2012-02-21  Jon Lee  <jonlee@apple.com>
2951
2952         Bring notifications support to WK1 mac
2953         https://bugs.webkit.org/show_bug.cgi?id=78783
2954         <rdar://problem/10610578>
2955
2956         Reviewed by Anders Carlsson.
2957
2958         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
2959         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2960         (-[UIDelegate timerFired]):
2961
2962 2012-02-21  Kentaro Hara  <haraken@chromium.org>
2963
2964         Enable the IDL attribute checker in run-bindings-tests
2965         https://bugs.webkit.org/show_bug.cgi?id=79091
2966
2967         Reviewed by Adam Barth.
2968
2969         We have enabled the IDL attribute checker in Chromium in r108322.
2970         This patch enables the IDL attribute checker in run-bindings-tests.
2971
2972         No tests. I manually checked that [Custommm], [CallWith=],
2973         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
2974         run-bindings-tests failures.
2975
2976         * Scripts/webkitpy/bindings/main.py:
2977         (BindingsTests.generate_supplemental_dependency):
2978
2979 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
2980
2981         Add rafaelw as a committer.
2982
2983         Unreviewed.
2984
2985         * Scripts/webkitpy/common/config/committers.py:
2986
2987 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2988
2989         webkitpy: update names after deleting message_broker
2990         https://bugs.webkit.org/show_bug.cgi?id=79000
2991
2992         Reviewed by Eric Seidel.
2993
2994         Part 3 of 3 in deleting message_broker.py; this change just
2995         adjusts the names for the newly merged symbols so that they are
2996         private as appropriate.
2997
2998         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2999         (get):
3000         (_Broker):
3001         (_BrokerConnection):
3002         (_BrokerConnection.__init__):
3003         (AbstractWorker.__init__):
3004         (_ManagerConnection):
3005         (_ManagerConnection.__init__):
3006         (_WorkerConnection):
3007         (_WorkerConnection.__init__):
3008
3009 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3010
3011         webkitpy: merge message_broker.py into manager_worker_broker.py
3012         https://bugs.webkit.org/show_bug.cgi?id=78999
3013
3014         Reviewed by Tony Chang.
3015
3016         This is pretty much a straight cut-and-paste of one file into
3017         another (broken up so that docstrings and imports are in the
3018         right place).
3019
3020         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3021         (BrokerClient):
3022         (BrokerClient.is_done):
3023         (BrokerClient.name):
3024         (Broker):
3025         (Broker.__init__):
3026         (Broker.add_topic):
3027         (Broker._get_queue_for_topic):
3028         (Broker.post_message):
3029         (Broker.run_message_loop):
3030         (Broker.run_all_pending):
3031         (Broker._run_loop):
3032         (Broker._dispatch_message):
3033         (_Message):
3034         (_Message.loads):
3035         (_Message.__init__):
3036         (_Message.dumps):
3037         (_Message.__repr__):
3038         (BrokerConnection):
3039         (BrokerConnection.__init__):
3040         (BrokerConnection.run_message_loop):
3041         (BrokerConnection.post_message):
3042         (BrokerConnection.raise_exception):
3043         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
3044
3045 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
3046
3047         webkitpy: prepare to delete message_broker.py
3048         https://bugs.webkit.org/show_bug.cgi?id=78997
3049
3050         Reviewed by Eric Seidel.
3051
3052         This is part 1 of 3 changes to fix bug 78187. This change
3053         prepares the code for merging message_broker.py into
3054         manager_worker_broker.py; the tests in message_broker_unittest
3055         are merged into manager_worker_broker_unittest, the symbols
3056         needed by the tests are exported from manager_worker_broker.py,
3057         and manager_worker_broker itself is updated to refer to the
3058         symbols directly (without the module prefix).
3059
3060         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3061         (get):
3062         (AbstractWorker):
3063         (AbstractWorker.__init__):
3064         (_ManagerConnection):
3065         (_ManagerConnection.__init__):
3066         (_WorkerConnection):
3067         (_WorkerConnection.__init__):
3068         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3069         (InterfaceTest.test_brokerclient_is_abstract):
3070         (InterfaceTest.test_brokerclient_is_abstract.methods):
3071         (MessageTest):
3072         (MessageTest.test__no_body):
3073         (MessageTest.test__body):
3074         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
3075
3076 2012-02-21  Sam Weinig  <sam@webkit.org>
3077
3078         Attempt to fix the Snow Leopard build.
3079
3080         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3081         * MiniBrowser/Configurations/Base.xcconfig:
3082         * TestWebKitAPI/Configurations/Base.xcconfig:
3083         * WebKitTestRunner/Configurations/Base.xcconfig:
3084
3085 2012-02-21  Sam Weinig  <sam@webkit.org>
3086
3087         Use libc++ when building with Clang on Mac
3088         https://bugs.webkit.org/show_bug.cgi?id=78981
3089
3090         Reviewed by Dan Bernstein.
3091
3092         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3093         * MiniBrowser/Configurations/Base.xcconfig:
3094         * TestWebKitAPI/Configurations/Base.xcconfig:
3095         * WebKitTestRunner/Configurations/Base.xcconfig:
3096
3097 2012-02-21  Adam Roben  <aroben@apple.com>
3098
3099         Roll out r108309, r108323, and r108326
3100
3101         They broke the 32-bit Lion build.
3102
3103         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
3104
3105         * DumpRenderTree/efl/CMakeLists.txt:
3106
3107 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
3108
3109         [Qt][WK2] Get rid of the dependency to QtWidgets
3110         https://bugs.webkit.org/show_bug.cgi?id=76276
3111
3112         Reviewed by Simon Hausmann.
3113
3114         * MiniBrowser/qt/MiniBrowser.pro:
3115         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3116         (MiniBrowserApplication::MiniBrowserApplication):
3117         (MiniBrowserApplication::notify):
3118         (MiniBrowserApplication::sendTouchEvent):
3119         * MiniBrowser/qt/MiniBrowserApplication.h:
3120         (MiniBrowserApplication):
3121         * QtTestBrowser/locationedit.h:
3122         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3123         (WTR::activateFonts):
3124         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3125
3126 2012-02-20  Adam Barth  <abarth@webkit.org>
3127
3128         mastercfg_unittest.py fails without simplejson
3129         https://bugs.webkit.org/show_bug.cgi?id=79070
3130
3131         Reviewed by Csaba Osztrogonác.
3132
3133         Now that we require Python 2.6 (and higher) we can import json rather
3134         than simplejson.  We still need to use the simplejson name because
3135         that's what the master.cfg script expects.
3136
3137         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3138         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
3139
3140 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
3141
3142         JSC should be a triple-tier VM
3143         https://bugs.webkit.org/show_bug.cgi?id=75812
3144         <rdar://problem/10079694>
3145
3146         Reviewed by Gavin Barraclough.
3147
3148         Changed EFL's build system to include a new directory in JavaScriptCore.
3149
3150         * DumpRenderTree/efl/CMakeLists.txt:
3151
3152 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
3153
3154         Update pywebsocket to 0.7.2
3155         https://bugs.webkit.org/show_bug.cgi?id=79066
3156
3157         This version includes vendor-prefixed deflate-frame extension support.
3158
3159         Reviewed by Kent Tamura.
3160
3161         * Scripts/webkitpy/thirdparty/__init__.py:
3162         (AutoinstallImportHook._install_pywebsocket):
3163
3164 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3165
3166         [UNIX] Plugin information fields are not interpreted as UTF-8
3167         https://bugs.webkit.org/show_bug.cgi?id=78635
3168
3169         Reviewed by Gustavo Noronha Silva.
3170
3171         Interpret plugin metadata as UTF8 aways. This matches the behavior
3172         of Chromium and the Totem plugin.
3173
3174         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3175         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
3176
3177 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3178
3179         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
3180         https://bugs.webkit.org/show_bug.cgi?id=78935
3181
3182         Reviewed by Gustavo Noronha Silva.
3183
3184         Move the TestNetscapePlugin headers to a more appropriate directory and update
3185         the build files to match.
3186
3187         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
3188         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
3189         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
3190         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
3191         * GNUmakefile.am: Ditto.
3192
3193 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
3194
3195         Add a new API for the Vibration API(W3C).
3196         https://bugs.webkit.org/show_bug.cgi?id=72010
3197
3198         Reviewed by Hajime Morita.
3199
3200         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
3201
3202 2012-02-20  János Badics  <dicska@gmail.com>
3203
3204         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
3205         https://bugs.webkit.org/show_bug.cgi?id=71816
3206
3207         RunQtAPITests will notify if a timeout occurs during testing.
3208         Added unittest to the master.cfg
3209
3210         Reviewed by Csaba Osztrogonác.
3211
3212         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3213         (RunQtAPITests.evaluateCommand):
3214         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3215         (RunQtAPITestsTest):
3216         (RunQtAPITestsTest.assertResults):
3217         (RunQtAPITestsTest.test_timeout):
3218         (test_success):
3219         (test_failure):
3220         (test_timeout_and_failure):
3221
3222 2012-02-20  Andy Wingo  <wingo@igalia.com>
3223
3224         Add wingo as a committer.
3225
3226         Unreviewed.
3227
3228         * Scripts/webkitpy/common/config/committers.py: Add myself to the
3229         committers list.
3230
3231 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
3232
3233         [chromium] check that we're not running multiple modal dialogs at the same time
3234         https://bugs.webkit.org/show_bug.cgi?id=78486
3235
3236         Reviewed by Kent Tamura.
3237
3238         * DumpRenderTree/chromium/TestShell.cpp:
3239         (TestShell::TestShell):
3240         * DumpRenderTree/chromium/TestShell.h:
3241         (TestShell::setIsDisplayingModalDialog):
3242         (TestShell::isDisplayingModalDialog):
3243         (TestShell):
3244         * DumpRenderTree/chromium/WebViewHost.cpp:
3245         (WebViewHost::runModal):
3246
3247 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3248
3249         Fix WebKit2GTK+ for 'make distcheck'.
3250
3251         Instead of conditionally including WebKit2 GNUmakefiles, always
3252         include them and conditionally activate the final targets.
3253
3254         * MiniBrowser/gtk/GNUmakefile.am:
3255         * WebKitTestRunner/GNUmakefile.am:
3256
3257 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3258
3259         Enable video option for EFL port in build-webkit.
3260         https://bugs.webkit.org/show_bug.cgi?id=79006
3261
3262         Reviewed by Daniel Bates.
3263
3264         * Scripts/build-webkit:
3265
3266 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
3267
3268         [EFL] Use modifier keys to execute pre-rendering.
3269         https://bugs.webkit.org/show_bug.cgi?id=77933
3270
3271         Reviewed by Chang Shu.
3272
3273         Use modifier key to execute pre-rendering instead of using reserved function keys.
3274
3275         * EWebLauncher/main.c:
3276         (on_key_down):
3277
3278 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3279
3280         Fix one more dangling reference to worker_connection.name, delete unused code.
3281
3282         Unreviewed, build fix.
3283
3284         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3285         (Manager.update):
3286         (_WorkerState.__init__):
3287
3288 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3289
3290         Add a change that should've been in r108005.
3291
3292         Unreviewed, build fix.
3293
3294         In the refactoring/cleanup in r108005 I should've changed the
3295         implementation of WorkerConnection to make it match BrokerClient
3296         (and everything else) so that objects had a name() method
3297         instead of a name property.
3298
3299         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3300         (Manager._run_tests):
3301         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3302         (_WorkerConnection.__init__):
3303         (_WorkerConnection.name):
3304         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3305         (_TestWorker.__init__):
3306         (_TestsMixin.name):
3307         (_TestsMixin.test_name):
3308         (_TestsMixin.test_cancel):
3309         (_TestsMixin.test_unknown_message):
3310
3311 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3312
3313         webkitpy: remove webkitpy.common.array_stream
3314         https://bugs.webkit.org/show_bug.cgi?id=78952
3315
3316         Reviewed by Eric Seidel.
3317
3318         Turns out array_stream didn't really do anything that StringIO
3319         didn't do (at least as of Python 2.6). This change removes it
3320         and updates all of the callers. Where possible, I changed the
3321         test assertions in order to capture the intent more clearly,
3322         e.g., instead of calling self.assertTrue('foo' in stream.get()),
3323         we have self.assertContainsLine(stream, 'foo'), and instead of
3324         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
3325         the latter isn't that much more readable, but StringIO doesn't
3326         export an empty() method.
3327
3328         * Scripts/webkitpy/common/array_stream.py: Removed.
3329         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
3330         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3331         (passing_run):
3332         (run_and_capture):
3333         (StreamTestingMixin):
3334         (StreamTestingMixin.assertContains):
3335         (StreamTestingMixin.assertContainsLine):
3336         (StreamTestingMixin.assertEmpty):
3337         (StreamTestingMixin.assertNotEmpty):
3338         (LintTest):
3339         (LintTest.test_lint_test_files):
3340         (LintTest.test_lint_test_files__errors):
3341         (MainTest):
3342         (MainTest.test_child_process_1):
3343         (MainTest.test_child_processes_2):
3344         (MainTest.test_child_processes_min):
3345         (MainTest.test_help_printing):
3346         (MainTest.test_hung_thread):
3347         (MainTest.test_no_tests_found):
3348         (MainTest.test_no_tests_found_2):
3349         (MainTest.test_repeat_each_iterations_num_tests):
3350         (MainTest.test_test_list):
3351         (MainTest.test_unexpected_failures):
3352         (MainTest.test_worker_model__inline_with_child_processes):
3353         (MainTest.test_additional_platform_directory):
3354         (RebaselineTest):
3355         (RebaselineTest.assertBaselines):
3356         (RebaselineTest.test_reset_results):
3357         (RebaselineTest.test_missing_results):
3358         (RebaselineTest.test_new_baseline):
3359         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3360         (MeteredStream.update):
3361         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3362         (TestMeteredStream.test_regular):
3363         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3364         (TestUtilityFunctions.assertEmpty):
3365         (TestUtilityFunctions):
3366         (TestUtilityFunctions.assertNotEmpty):
3367         (TestUtilityFunctions.assertWritten):
3368         (TestUtilityFunctions.test_configure_logging):
3369         (Testprinter.assertEmpty):
3370         (Testprinter):
3371         (Testprinter.assertNotEmpty):
3372         (Testprinter.assertWritten):
3373         (Testprinter.reset):
3374         (Testprinter.get_printer):
3375         (Testprinter.test_help_printer):
3376         (Testprinter.do_switch_tests.do_helper):
3377         (Testprinter.test_print_one_line_summary):
3378         (Testprinter.test_print_test_result):
3379         (Testprinter.test_print_progress):
3380         (Testprinter.test_write_nothing):
3381         (Testprinter.test_write_misc):
3382         (Testprinter.test_write_everything):
3383         (Testprinter.test_write_verbose):
3384         (Testprinter.test_print_unexpected_results):
3385         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3386         (MainTest.assertWritten):
3387         (create_runner):
3388         (test_run_test_set):
3389         (test_run_test_set_kills_drt_per_run):
3390         (test_run_test_set_for_parser_tests):
3391         (test_run_test_set_with_json_output):
3392         (test_run_test_set_with_json_source):
3393         (test_run_test_set_with_multiple_repositories):
3394         (test_upload_json):
3395
3396 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
3397
3398         [wx] Add the WebCore/page/scrolling directory to the build dirs.
3399
3400         * waf/build/settings.py:
3401
3402 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
3403
3404         [wx] Unreviewed build fix. Don't error out or hang if we have
3405         downloaded dependencies but server update check fails.
3406
3407         * waf/build/build_utils.py:
3408         (download_if_newer):
3409
3410 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3411
3412         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
3413         https://bugs.webkit.org/show_bug.cgi?id=69444
3414
3415         Reviewed by Tony Chang.
3416
3417         Currently if a test's image checksum doesn't match the checksum
3418         in the baseline, but the images themselves match according to
3419         ImageDiff, new-run-webkit-tests ignores the problem. This is
3420         probably bad, but it's not yet clear what the right thing to do
3421         is. This patch will log a warning to stderr, at least (but the
3422         test will still pass).
3423
3424         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3425         (SingleTestRunner._compare_image):
3426         (SingleTestRunner._run_reftest):
3427         * Scripts/webkitpy/layout_tests/port/test.py:
3428         (unit_test_list):
3429         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3430
3431 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3432
3433         NRWT does not report failure for a skipped test
3434         https://bugs.webkit.org/show_bug.cgi?id=78750
3435
3436         Reviewed by Eric Seidel.
3437
3438         If a test is listed in a Skipped file and you run it anyway
3439         with --force, and the test fails, currently NRWT will print
3440         "test ran as expected"; this is confusing, because you probably
3441         expect the test to fail and yet this might lead you to think the
3442         test passed. This patch changes the expected behavior to "PASS",
3443         so tests that fail will be reported.
3444
3445         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3446         (result_was_expected):
3447         (TestExpectationParser):
3448         (TestExpectationParser.expectation_for_skipped_test):
3449         (TestExpectations):
3450         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3451         (test_add_skipped_tests):
3452         * Scripts/webkitpy/layout_tests/port/test.py:
3453         (unit_test_list): Add some tests that are expected to be in a Skipped file.
3454         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
3455
3456 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3457
3458         webkitpy: fix test code after bug 78181
3459         https://bugs.webkit.org/show_bug.cgi?id=78870
3460
3461         Reviewed by Adam Barth.
3462
3463         I forgot to update the test code as per Tony's suggestion in
3464         bug 78181 (r108005). This change does that, and in doing so
3465         it revealed a subtle bug in _InlineWorkerConnection.run() that
3466         I am fixing as part of this (_alive would not be cleared if an
3467         exception was thrown).
3468
3469         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3470         (_InlineWorkerConnection.run):
3471         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3472         (_TestWorker.__init__):
3473         (_TestWorker.handle_stop):
3474         (_TestWorker.handle_test):
3475         (_TestWorker.run):
3476         (_TestsMixin.handle_exception):
3477         (_TestsMixin.test_unknown_message):
3478
3479 2012-02-17  Adam Roben  <aroben@apple.com>
3480
3481         Mac build fix after r108119
3482
3483         * DumpRenderTree/mac/DumpRenderTree.mm:
3484         (runThread):
3485         (runPthread):
3486         (testThreadIdentifierMap):
3487         Updated to match current WTF threading APIs.
3488
3489 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3490
3491         revert r107147 - breaks webkit-patch on Mac SL
3492         https://bugs.webkit.org/show_bug.cgi?id=78866
3493
3494         Reviewed by Adam Barth.
3495
3496         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
3497         which is the version that ships on Mac SL. Reverting this
3498         change until we no longer have to worry about that version.
3499
3500         * Scripts/webkitpy/common/system/autoinstall.py:
3501         (AutoInstaller):
3502         (AutoInstaller._extract_all): Added a comment about SL.
3503         (AutoInstaller._unzip):
3504
3505 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
3506
3507         CSS regions enabled by default
3508         https://bugs.webkit.org/show_bug.cgi?id=78525
3509
3510         Reviewed by David Hyatt.
3511
3512         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
3513         CSSRegions are still enabled by default.
3514         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
3515
3516         * DumpRenderTree/chromium/LayoutTestController.cpp:
3517         (LayoutTestController::overridePreference):
3518         * DumpRenderTree/chromium/WebPreferences.cpp:
3519         (WebPreferences::reset):
3520         (WebPreferences::applyTo):
3521         * DumpRenderTree/chromium/WebPreferences.h:
3522         (WebPreferences):
3523         * DumpRenderTree/mac/DumpRenderTree.mm:
3524         (resetDefaultsToConsistentValues):
3525
3526 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
3527
3528         Some API tests erroneously use = instead of == (causing build failures)
3529         https://bugs.webkit.org/show_bug.cgi?id=78915
3530
3531         Reviewed by Sam Weinig.
3532
3533         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3534         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
3535         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
3536
3537 2012-02-17  Peter Beverloo  <peter@chromium.org>
3538
3539         [Chromium] Include TestShellLinux.cpp in the build for Android
3540         https://bugs.webkit.org/show_bug.cgi?id=78865
3541
3542         Reviewed by Eric Seidel.
3543
3544         Android will be re-using the TestShellLinux.cpp file. I already
3545         added this r104033, but it seems to have gotten lost in the
3546         recent refactorings.
3547
3548         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3549
3550 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3551
3552         Unreviewed, disable video build on EFL until it can be
3553         supported by EFL build bot.
3554
3555         * Scripts/build-webkit:
3556
3557 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3558
3559         [GTK] Implement zoom in/out in MiniBrowser
3560         https://bugs.webkit.org/show_bug.cgi?id=75253
3561
3562         Reviewed by Gustavo Noronha Silva.
3563
3564         * MiniBrowser/gtk/BrowserWindow.c:
3565         (browserWindowCanZoomIn):
3566         (browserWindowCanZoomOut):
3567         (browserWindowUpdateZoomActions):
3568         (webViewZoomLevelChanged):
3569         (zoomInCallback):
3570         (zoomOutCallback):
3571         (browser_window_init):
3572         (browserWindowConstructed):
3573
3574 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
3575
3576         layoutTestController.display() is flaky for SVG tests
3577         https://bugs.webkit.org/show_bug.cgi?id=78021
3578
3579         Reviewed by Adam Roben.
3580
3581         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
3582         Size the web view before running the test, not when dumping.
3583         All platforms handle this correctly now.
3584
3585         * DumpRenderTree/win/DumpRenderTree.cpp:
3586         (dump):
3587         (sizeWebViewForCurrentTest):
3588         (runTest):
3589
3590 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3591
3592         [GTK] Make install is broken when building without --enable-gtk-doc
3593         https://bugs.webkit.org/show_bug.cgi?id=78828
3594
3595         Reviewed by Martin Robinson.
3596
3597         * gtk/generate-gtkdoc:
3598         (rebase_installed_docs): Check documentation has been generated
3599         before trying to rebase it.
3600
3601 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
3602
3603         nrwt: simplify worker interface
3604         https://bugs.webkit.org/show_bug.cgi?id=78181
3605
3606         Reviewed by Tony Chang.
3607
3608         This change moves code in name(), is_done(), run(), and cancel()
3609         from Worker to AbstractWorker, since the logic is pretty much
3610         boilerplate code that any implementation would want to use.
3611
3612         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3613         (get.should):
3614         (AbstractWorker.__init__):
3615         (AbstractWorker):
3616         (AbstractWorker.name):
3617         (AbstractWorker.stop_handling_messages):
3618         (AbstractWorker.run):
3619         (AbstractWorker.is_done):
3620         (AbstractWorker.cancel):
3621         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3622         (Worker.__init__):
3623         (Worker.run):
3624         (Worker.handle_stop):
3625
3626 2012-02-16  Michael Saboff  <msaboff@apple.com>
3627
3628         ENH: Add ability to run subset of JavaScript layout tests with JSC
3629         https://bugs.webkit.org/show_bug.cgi?id=78764
3630
3631         Reviewed by Gavin Barraclough.
3632
3633         New simple test drive shell script that runs a defined
3634         list of javascript tests using jsc and the standalone-{pre,post}.js
3635         wrappers.
3636
3637         * Scripts/run-fast-jsc: Added.
3638
3639 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
3640
3641         Add new Qt performance tester bot to build.webkit.org
3642         https://bugs.webkit.org/show_bug.cgi?id=78795
3643
3644         Reviewed by Adam Roben.
3645
3646         * BuildSlaveSupport/build.webkit.org-config/config.json:
3647
3648 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
3649
3650         Disable inspector on WinCE.
3651
3652         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
3653
3654         * Scripts/build-webkit:
3655
3656 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
3657
3658         WinCE build fix after r107656.
3659
3660         Disable FTPDIR on WinCE, since it does not compile there.
3661
3662         * Scripts/build-webkit:
3663
3664 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
3665
3666         Build fix after r107863.
3667
3668         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3669
3670 2012-02-15  Tony Chang  <tony@chromium.org>
3671
3672         [chromium] add linux dbg back to garden-o-matic
3673         https://bugs.webkit.org/show_bug.cgi?id=78752
3674
3675         Reviewed by Adam Barth.
3676
3677         This reflects the current linux debug bot name (there's only one bot).
3678         I'm also remove the mac clang builder since it doesn't exist (mac
3679         always uses clang now).
3680
3681         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3682         * Scripts/webkitpy/layout_tests/port/builders.py:
3683
3684 2012-02-15  Sam Weinig  <sam@webkit.org>
3685
3686         Add style check for ctype functions that are generally frowned upon in WebKit
3687         https://bugs.webkit.org/show_bug.cgi?id=78748
3688
3689         Reviewed by Anders Carlsson.
3690
3691         Not every platform has DisallowCType.h to check for uses of the ctype.h
3692         functions, so add a style check for them as well.
3693
3694         * Scripts/webkitpy/style/checkers/cpp.py:
3695         (check_ctype_functions):
3696         (check_style):
3697         (CppChecker):
3698         Add check.
3699
3700         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3701         (WebKitStyleTest.test_ctype_fucntion):
3702         Add checker.
3703
3704 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
3705
3706         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
3707         https://bugs.webkit.org/show_bug.cgi?id=76546
3708
3709         Reviewed by Simon Hausmann.
3710
3711         Resize the web view programatically because the declarative property binding
3712         does not work. Seems like our qml environment is not initialized fully but it
3713         needs more investigation.
3714
3715         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3716         (WTR::WrapperWindow::handleStatusChanged):
3717         (WTR::PlatformWebView::resizeTo):
3718
3719 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
3720
3721         webkitpy: add a worker_args concept to start_worker()
3722         https://bugs.webkit.org/show_bug.cgi?id=78572
3723
3724         Reviewed by Tony Chang.
3725
3726         This change replaces the three NRWT-specific arguments passed
3727         through the broker to the worker with a generic WorkerArguments
3728         wrapper class and a separate set_inline_arguments() call that can
3729         be used to pass additional data to the worker when it is running
3730         in the same process as the manager (this is needed for testing).
3731         With the addition of set_inline_arguments() we also no longer
3732         need to pass an optional argument to the worker.run() call.
3733
3734         Note that this method is *only* implemented on inline workers,
3735         so calling this on a regular (child process) worker will result
3736         in a runtime error.
3737
3738         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3739         (Manager._run_tests):
3740         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3741         (AbstractWorker.__init__):
3742         (AbstractWorker.run):
3743         (_ManagerConnection.start_worker):
3744         (_InlineManager.start_worker):
3745         (_InlineManager.set_inline_arguments):
3746         (_InlineManager.run_message_loop):
3747         (_MultiProcessManager.start_worker): Reworked signature.
3748         (_WorkerConnection.__init__):
3749         (_InlineWorkerConnection.__init__):
3750         (_InlineWorkerConnection.set_inline_arguments): New method.
3751         (_InlineWorkerConnection):
3752         (_InlineWorkerConnection.run):
3753         (_Process.run):
3754         (_MultiProcessWorkerConnection.__init__):
3755         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3756         (_TestWorker.__init__):
3757         (_TestWorker.set_inline_arguments):
3758         (_TestWorker.handle_test):
3759         (_TestWorker.run):
3760         (_TestsMixin.test_cancel):
3761         (_TestsMixin.test_done):
3762         (_TestsMixin.test_unknown_message):
3763         (InlineBrokerTests): New class for more testing.
3764         (InlineBrokerTests.setUp):
3765         (InlineBrokerTests.test_inline_arguments): New test.
3766         (InterfaceTest.test_managerconnection_is_abstract):
3767         (InterfaceTest.test_workerconnection_is_abstract):
3768         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3769         (WorkerArguments):
3770         (WorkerArguments.__init__):
3771         (Worker.__init__):
3772         (Worker.set_inline_arguments):
3773         (Worker):
3774         (Worker.run):
3775         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
3776         (WorkerTest.test_default_platform_in_worker):
3777
3778 2012-02-15  Adam Klein  <adamk@chromium.org>
3779
3780         Unreviewed, rolling out r107704.
3781         http://trac.webkit.org/changeset/107704
3782         https://bugs.webkit.org/show_bug.cgi?id=78486
3783
3784         Caused layout test crashes in debug builds.
3785
3786         Specific crashing tests:
3787
3788         fast/events/show-modal-dialog-onblur-onfocus.html
3789         fast/harness/show-modal-dialog.html
3790         inspector/console/console-long-eval-crash.html
3791
3792         * DumpRenderTree/chromium/TestShell.cpp:
3793         (TestShell::TestShell):
3794         * DumpRenderTree/chromium/TestShell.h:
3795         (TestShell):
3796         * DumpRenderTree/chromium/WebViewHost.cpp:
3797         (WebViewHost::runModal):
3798
3799 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
3800
3801         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
3802         https://bugs.webkit.org/show_bug.cgi?id=76347
3803
3804         Reviewed by Kenneth Rohde Christiansen.
3805
3806         * MiniBrowser/qt/MiniBrowser.qrc:
3807         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added.
3808         * MiniBrowser/qt/qml/BrowserWindow.qml:
3809         * MiniBrowser/qt/qml/DialogLineInput.qml:
3810
3811 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
3812
3813         [Qt] Fix WebGL in QtTestBrowser
3814
3815         Reviewed by Tor Arne Vestbø.
3816
3817         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
3818         the options for enabling GL we also pass them on properly.
3819
3820 2012-02-14  Sam Weinig  <sam@webkit.org>
3821
3822         Add #include of unistd.h on the mac for getcwd.
3823
3824         Reviewed by Anders Carlsson.
3825
3826         This is necessary when building with libc++.
3827
3828         * WebKitTestRunner/TestInvocation.cpp:
3829
3830 2012-02-14  Sam Weinig  <sam@webkit.org>
3831
3832         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
3833         https://bugs.webkit.org/show_bug.cgi?id=78663
3834
3835         Reviewed by Anders Carlsson.
3836
3837         * DumpRenderTree/DumpRenderTreePrefix.h:
3838         * DumpRenderTree/cg/ImageDiffCG.cpp:
3839
3840 2012-02-14  Adam Barth  <abarth@webkit.org>
3841
3842         Implement an adb-based driver for the ChromiumAndroidPort
3843         https://bugs.webkit.org/show_bug.cgi?id=78627
3844
3845         Reviewed by Eric Seidel.
3846
3847         This driver mostly just wires up the ChromiumDriver through adb.  In
3848         some cases, it translates protocol elements, such as URIs, so that the
3849         rest of webkitpy is insulated from the "remoteness" of the target device.
3850
3851         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3852         (ChromiumAndroidPort.start_helper):
3853         (ChromiumAndroidPort._driver_class):
3854         (ChromiumAndroidPort._update_version):
3855         (ChromiumAndroidPort._get_stderr):
3856         (ChromiumAndroidPort):
3857         (ChromiumAndroidPort._get_last_stacktrace):
3858         (ChromiumAndroidPort._teardown_performance):
3859         (ChromiumAndroidDriver):
3860         (ChromiumAndroidDriver.__init__):
3861         (ChromiumAndroidDriver._start):
3862         (ChromiumAndroidDriver.run_test):
3863         (ChromiumAndroidDriver.stop):
3864         (ChromiumAndroidDriver._test_shell_command):
3865         (ChromiumAndroidDriver._write_command_and_read_line):
3866         (ChromiumAndroidDriver._output_image):
3867         (ChromiumAndroidDriver._has_crash_hint):
3868
3869 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3870
3871         webkitpy: the real_name() method in the Port class is no longer needed
3872         https://bugs.webkit.org/show_bug.cgi?id=78651
3873
3874         Reviewed by Eric Seidel.
3875
3876         The change in bug 78565 / r107718 made it no longer necessary
3877         (we can use options.platform instead).
3878
3879         * Scripts/webkitpy/layout_tests/port/base.py:
3880         (Port.name):
3881         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3882         (MockDRTPort.__init__):
3883
3884 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3885
3886         webkitpy: clean up options, port handling in manager_worker_broker
3887         https://bugs.webkit.org/show_bug.cgi?id=78568
3888
3889         Reviewed by Tony Chang.
3890
3891         manager_worker_broker no longer needs options or port objects
3892         directly, so we make them only be passed in start_worker().
3893
3894         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3895         (Manager._run_tests):
3896         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3897         (get):
3898         (_ManagerConnection.__init__):
3899         (_ManagerConnection.start_worker):
3900         (_InlineManager.__init__):
3901         (_InlineManager.start_worker):
3902         (_InlineManager.run_message_loop):
3903         (_MultiProcessManager.__init__):
3904         (_MultiProcessManager):
3905         (_MultiProcessManager.start_worker):
3906         (_InlineWorkerConnection.__init__):
3907         (_InlineWorkerConnection.run):
3908         (_Process.__init__):
3909         (_MultiProcessWorkerConnection.__init__):
3910         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3911         (make_broker):
3912         (_TestWorker.run):
3913         (_TestsMixin.test_cancel):
3914         (_TestsMixin.test_done):
3915         (_TestsMixin.test_unknown_message):
3916         (MultiProcessBrokerTests.setUp):
3917         (InterfaceTest.test_managerconnection_is_abstract):
3918         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
3919         (Broker.__init__):
3920
3921 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3922
3923         nrwt: add a unit test for regression introduced in bug 78565
3924         https://bugs.webkit.org/show_bug.cgi?id=78646
3925
3926         Reviewed by Tony Chang.
3927
3928         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
3929         (FakeConnection):
3930         (FakeConnection.run_message_loop):
3931         (FakeConnection.post_message):
3932         (WorkerTest):
3933         (WorkerTest.test_default_platform_in_worker):
3934
3935 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3936
3937         NRWT is broken for the default port
3938         https://bugs.webkit.org/show_bug.cgi?id=78640
3939
3940         Reviewed by Tony Chang.
3941
3942         The change in r107718 (bug 78565) broke NRWT if you didn't
3943         specify any sort of --platform flag or equivalent. I didn't
3944         catch this because it's a full integration test (which we don't
3945         have an automated test for) and I missed this command line
3946         variant when testing interactively.
3947
3948         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3949         (Worker.run):
3950
3951 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
3952
3953         Last character display for passwords in Android.
3954         https://bugs.webkit.org/show_bug.cgi?id=78532
3955
3956         Reviewed by Adam Barth.
3957
3958         * DumpRenderTree/chromium/WebPreferences.cpp:
3959         (WebPreferences::applyTo):
3960
3961 2012-02-14  Adam Barth  <abarth@webkit.org>
3962
3963         Finish implementing start_helper for ChromiumAndroidPort
3964         https://bugs.webkit.org/show_bug.cgi?id=78582
3965
3966         Reviewed by Eric Seidel.
3967
3968         This patch contains the remaining odds and ends for the start_helper function.
3969
3970         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3971         (ChromiumAndroidPort.start_helper):
3972         (ChromiumAndroidPort._synchronize_datetime):
3973         (ChromiumAndroidPort):
3974         (ChromiumAndroidPort._check_version):
3975         (ChromiumAndroidPort._run_adb_command):
3976         (ChromiumAndroidPort._copy_device_file):
3977
3978 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3979
3980         webkitpy: create ports in Workers, not in manager_worker_broker
3981         https://bugs.webkit.org/show_bug.cgi?id=78565
3982
3983         Reviewed by Tony Chang.
3984
3985         We will now create the Port object (if necessary) in the Worker
3986         directly, so that the manager_worker_broker module doesn't need
3987         all of this layout_test-specific logic. Part of the fixes for
3988         bug 78171.
3989
3990         These changes are all well-tested by the existing tests in
3991         run_webkit_tests_integrationtest.py.
3992
3993         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3994         (_Process.run):
3995         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3996         (Worker.__init__):
3997         (Worker.safe_init):
3998         (Worker.run):
3999         (Worker.cleanup):
4000         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4001         (parse_args):
4002         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
4003
4004 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
4005
4006         [chromium] check that we're not running multiple modal dialogs at the same time
4007         https://bugs.webkit.org/show_bug.cgi?id=78486
4008
4009         Reviewed by Kent Tamura.
4010
4011         * DumpRenderTree/chromium/TestShell.cpp:
4012         (TestShell::TestShell):
4013         * DumpRenderTree/chromium/TestShell.h:
4014         (TestShell::setIsDisplayingModalDialog):
4015         (TestShell::isDisplayingModalDialog):
4016         (TestShell):
4017         * DumpRenderTree/chromium/WebViewHost.cpp:
4018         (WebViewHost::runModal):
4019
4020 2012-02-14  Adam Barth  <abarth@webkit.org>
4021
4022         Enable the GPU codepath in the chromium-android port
4023         https://bugs.webkit.org/show_bug.cgi?id=78580
4024
4025         Reviewed by James Robinson.
4026
4027         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
4028         Android always uses the GPU codepath, so we set the GPU flags on the
4029         main chromium-android port instead.
4030
4031         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4032         (ChromiumAndroidPort.__init__):
4033
4034 2012-02-14  Adam Barth  <abarth@webkit.org>
4035
4036         NRWT should expose --adb-args flag for Android
4037         https://bugs.webkit.org/show_bug.cgi?id=78579
4038
4039         Reviewed by Eric Seidel.
4040
4041         This flag is already wired up to the ChromiumAndroidPort.
4042
4043         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4044         (parse_args):
4045
4046 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
4047
4048         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
4049         https://bugs.webkit.org/show_bug.cgi?id=78541
4050         <rdar://problem/10036695>
4051
4052         Reviewed by Kent Tamura.
4053
4054         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
4055         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
4056         After each test, reset to using new protocol.
4057
4058 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
4059
4060         Convert svg/animations to use SMIL methods for driving the timeline
4061         https://bugs.webkit.org/show_bug.cgi?id=78422
4062
4063         Reviewed by Dirk Schulze.
4064
4065         Remove no longer needed SVG specific animation sampling functionality from DRT.
4066         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
4067
4068         * DumpRenderTree/LayoutTestController.cpp:
4069         (LayoutTestController::staticFunctions):
4070         * DumpRenderTree/LayoutTestController.h:
4071         (LayoutTestController):
4072         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
4073         * DumpRenderTree/chromium/LayoutTestController.cpp:
4074         (LayoutTestController::LayoutTestController):
4075         * DumpRenderTree/chromium/LayoutTestController.h:
4076         (LayoutTestController):
4077         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4078         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4079         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4080         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4081         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4082         (LayoutTestController):
4083         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4084         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4085
4086 2012-02-13  Rob Flack  <flackr@chromium.org>
4087
4088         Add Linux ChromiumOS test results to flakiness dashboard.
4089         https://bugs.webkit.org/show_bug.cgi?id=78495
4090
4091         Reviewed by Ojan Vafai.
4092
4093         * TestResultServer/static-dashboards/builders.js:
4094         * TestResultServer/static-dashboards/dashboard_base.js:
4095
4096 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
4097
4098         [GTK] Mutation Observers build is broken
4099         https://bugs.webkit.org/show_bug.cgi?id=78433
4100
4101         Reviewed by Martin Robinson.
4102
4103         Enabled mutation observers as a default feature for GTK port, too.
4104
4105         * Scripts/build-webkit:
4106
4107 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
4108
4109         Allow to configure ENABLE_FTPDIR in build-webkit
4110         https://bugs.webkit.org/show_bug.cgi?id=65098
4111
4112         Reviewed by Eric Seidel.
4113
4114         Allow to disable ENABLE_FTPDIR by command line.
4115         Remove ENABLE_FTPDIR from --minimal build
4116
4117         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
4118         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
4119         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
4120
4121 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
4122
4123         Add shinyak as committer.
4124
4125         Unreviewed.
4126
4127         * Scripts/webkitpy/common/config/committers.py:
4128
4129 2012-02-13  Adam Barth  <abarth@webkit.org>
4130
4131         Implement start/stop_helper for ChromiumAndroidPort
4132         https://bugs.webkit.org/show_bug.cgi?id=78558
4133
4134         Reviewed by Dirk Pranke.
4135
4136         These functions (and their dependencies) set up the Android device for
4137         testing.
4138
4139         This patch also includes a few tweaks on the previous patch recommended
4140         by dpranke.
4141
4142         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4143         (ChromiumAndroidPort.__init__):
4144         (ChromiumAndroidPort.start_helper):
4145         (ChromiumAndroidPort.stop_helper):
4146         (ChromiumAndroidPort._shut_down_http_server):
4147         (ChromiumAndroidPort):
4148         (ChromiumAndroidPort._push_executable):
4149         (ChromiumAndroidPort._push_fonts):
4150         (ChromiumAndroidPort._restore_system_font):
4151         (ChromiumAndroidPort._push_test_resources):
4152         (ChromiumAndroidPort._push_to_device):
4153         (ChromiumAndroidPort._pull_from_device):
4154         (ChromiumAndroidPort._kill_device_process):
4155         (ChromiumAndroidPort._setup_performance):
4156         (ChromiumAndroidPort._teardown_performance):
4157         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
4158         (ChromiumAndroidPortTest):
4159         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4160         (PortTestCase):
4161         (PortTestCase.make_port):
4162         (PortTestCase.test_default_worker_model):
4163
4164 2012-02-13  Adam Barth  <abarth@webkit.org>
4165
4166         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
4167         https://bugs.webkit.org/show_bug.cgi?id=78550
4168
4169         Reviewed by Eric Seidel.
4170
4171         Much of this code just forwards to the "host" port, which seems like a
4172         reasonable thing to do.
4173
4174         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4175         (ChromiumAndroidPort.__init__):
4176         (ChromiumAndroidPort.stop_helper):
4177         (ChromiumAndroidPort):
4178         (ChromiumAndroidPort._build_path):
4179         (ChromiumAndroidPort._path_to_apache):
4180         (ChromiumAndroidPort._path_to_apache_config_file):
4181         (ChromiumAndroidPort._path_to_driver):
4182         (ChromiumAndroidPort._path_to_helper):
4183         (ChromiumAndroidPort._path_to_image_diff):
4184         (ChromiumAndroidPort._path_to_lighttpd):
4185         (ChromiumAndroidPort._path_to_lighttpd_modules):
4186         (ChromiumAndroidPort._path_to_lighttpd_php):
4187         (ChromiumAndroidPort._path_to_wdiff):
4188         (ChromiumAndroidPort._shut_down_http_server):
4189         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
4190         (ChromiumAndroidPortTest):
4191         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4192         (PortTestCase):
4193         (PortTestCase.make_port):
4194         (PortTestCase.test_default_worker_model):
4195
4196 2012-02-13  Adam Barth  <abarth@webkit.org>
4197
4198         chromium_android.py should implement "virtual" methods from ChromiumPort
4199         https://bugs.webkit.org/show_bug.cgi?id=78545
4200
4201         Reviewed by Dirk Pranke.
4202
4203         This patch adds basic implementations that specialize a bunch of
4204         functions from ChromiumPort.
4205
4206         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4207         (ChromiumAndroidPort):
4208         (ChromiumAndroidPort.__init__):
4209         (ChromiumAndroidPort.default_child_processes):
4210         (ChromiumAndroidPort.baseline_search_path):
4211         (ChromiumAndroidPort.check_build):
4212         (ChromiumAndroidPort.check_sys_deps):
4213         (ChromiumAndroidPort.default_worker_model):
4214         (ChromiumAndroidPort.test_expectations):
4215         (ChromiumAndroidPort.start_http_server):
4216         (ChromiumAndroidPort.stop_http_server):
4217         (ChromiumAndroidPort.start_helper):
4218         (ChromiumAndroidPort.stop_helper):
4219
4220 2012-02-13  Adam Barth  <abarth@webkit.org>
4221
4222         Add a skeleton ChromiumAndroid port to webkitpy
4223         https://bugs.webkit.org/show_bug.cgi?id=78543
4224
4225         Reviewed by Eric Seidel.
4226
4227         This patch just adds an empty ChromiumAndroid port object to webkitpy
4228         and wires it up to the factory objects.  An actual implementation will
4229         follow.
4230
4231         * Scripts/webkitpy/layout_tests/port/chromium.py:
4232         (ChromiumPort):
4233         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
4234         (ChromiumAndroidPort):
4235         (ChromiumAndroidPort.__init__):
4236         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4237         (ChromiumPortTest.test_all_test_configurations):
4238         * Scripts/webkitpy/layout_tests/port/factory.py:
4239         (PortFactory):
4240
4241 2012-02-13  Adam Barth  <abarth@webkit.org>
4242
4243         NRWT's HTTP servers should support additional directories for resources
4244         https://bugs.webkit.org/show_bug.cgi?id=78528
4245
4246         Reviewed by Eric Seidel.
4247
4248         This functionality will be used by the Chromium-Android port.
4249
4250         * Scripts/webkitpy/layout_tests/port/base.py:
4251         (Port.to.start_http_server):
4252         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
4253         (LayoutTestApacheHttpd.__init__):
4254         * Scripts/webkitpy/layout_tests/servers/http_server.py:
4255         (Lighttpd.__init__):
4256         (Lighttpd._prepare_config):
4257
4258 2012-02-13  Ami Fischman  <fischman@chromium.org>
4259
4260         Add fischman as committer.
4261
4262         Unreviewed
4263
4264         * Scripts/webkitpy/common/config/committers.py:
4265
4266 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
4267
4268         [EFL] Drop support for the Curl network backend.
4269         https://bugs.webkit.org/show_bug.cgi?id=77874
4270
4271         Reviewed by Eric Seidel.
4272
4273         Nobody seems to be maintaining the Curl backend in WebCore, the
4274         EFL port developers all seem to be using the Soup backend and the
4275         port itself has many features which are only implemented for the
4276         latter.
4277
4278         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
4279         and always add the required include directories.
4280         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
4281         include directories and link to them.
4282
4283 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
4284
4285         [WebSocket] Update pywebsocket to 0.7.1
4286         https://bugs.webkit.org/show_bug.cgi?id=78484
4287
4288         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
4289
4290         Reviewed by Kent Tamura.
4291
4292         * Scripts/webkitpy/thirdparty/__init__.py:
4293         (AutoinstallImportHook._install_pywebsocket):
4294
4295 2012-02-12  Kangil Han  <kangil.han@samsung.com>
4296
4297         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
4298         https://bugs.webkit.org/show_bug.cgi?id=78091
4299
4300         Reviewed by Hajime Morita.
4301
4302         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
4303         This patch will activate around 1,900 test cases from skipped list in EFL port.
4304
4305         * DumpRenderTree/efl/EventSender.cpp:
4306         (textZoom):
4307         (pageZoom):
4308         (textZoomInCallback):
4309         (textZoomOutCallback):
4310         (zoomPageInCallback):
4311         (zoomPageOutCallback):
4312
4313 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
4314
4315         KeywordLookupGenerator.py script fails in some cases
4316         https://bugs.webkit.org/show_bug.cgi?id=77886
4317
4318         Reviewed by Benjamin Poulain.
4319
4320         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
4321         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
4322         (GlobalVariablesTest.test_path_rules_specifier):
4323
4324 2012-02-12  Joe Thomas  <joethomas@motorola.com>
4325
4326         Add toText and isTextNode helpers in Text class.
4327         https://bugs.webkit.org/show_bug.cgi?id=78140
4328
4329         Unit test case for the new style checker introduced.
4330
4331         Reviewed by Adam Barth.
4332
4333         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4334         (CppStyleTest):
4335         (CppStyleTest.test_static_cast_readability): Added a unit test case.
4336
4337 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4338
4339         Enable features supported by EFL port in build-webkit.
4340         https://bugs.webkit.org/show_bug.cgi?id=78348
4341
4342         Reviewed by Ryosuke Niwa.
4343
4344         Sync build-webkit with OptionEfl.cmake, as some features enabled in
4345         OptionEfl.cmake are not enabled in build-webkit.
4346
4347         * Scripts/build-webkit:
4348
4349 2012-02-12  Joe Thomas  <joethomas@motorola.com>
4350
4351         Add toText and isTextNode helpers in Text class.
4352         https://bugs.webkit.org/show_bug.cgi?id=78140
4353
4354         Added a style checker to use toText rather than static_cast<Text*>.
4355
4356         Reviewed by Adam Barth.
4357
4358         * Scripts/webkitpy/style/checkers/cpp.py:
4359         (check_language): Style checker for static_cast<Text*>.
4360
4361 2012-02-12  Philippe Normand  <pnormand@igalia.com>
4362
4363         Unreviewed, disable Mutation observers build on GTK until it can
4364         actually build.
4365
4366         * Scripts/build-webkit:
4367
4368 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
4369
4370         Add back WTFURL to WebKit
4371         https://bugs.webkit.org/show_bug.cgi?id=77291
4372
4373         Reviewed by Adam Barth.
4374
4375         Add a flag to build-webkit to easily build WebKit with WTFURL.
4376
4377         * Scripts/build-webkit:
4378
4379 2012-02-10  Adam Klein  <adamk@chromium.org>
4380
4381         Enable MUTATION_OBSERVERS by default on all platforms
4382         https://bugs.webkit.org/show_bug.cgi?id=78196
4383
4384         Reviewed by Ojan Vafai.
4385
4386         * Scripts/build-webkit:
4387
4388 2012-02-10  Adam Barth  <abarth@webkit.org>
4389
4390         Move garden-o-matic's All Failures out of experimental
4391         https://bugs.webkit.org/show_bug.cgi?id=78395
4392
4393         Reviewed by Dimitri Glazkov.
4394
4395         Several folks have tried this feature and found it useful.
4396
4397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
4398
4399 2012-02-10  Tim Horton  <timothy_horton@apple.com>
4400
4401         NRWT should categorize options in --help
4402         https://bugs.webkit.org/show_bug.cgi?id=76221
4403
4404         Reviewed by Eric Seidel.
4405
4406         Use optparse's OptionGroup mechanism to logically group NRWT's options,
4407         providing a better experience when scanning all the options.
4408
4409         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4410         (parse_args):
4411
4412 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
4413
4414         [Qt][WK2] Refactor on Qt5 Layout tests' structure
4415         https://bugs.webkit.org/show_bug.cgi?id=77450
4416
4417         Reviewed by Csaba Osztrogonác.
4418
4419         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
4420         to qt-5.0-wk2 and qt-5.0-wk1.
4421
4422         * Scripts/old-run-webkit-tests:
4423         (buildPlatformResultHierarchy):
4424         (readSkippedFiles):
4425         * Scripts/webkitpy/layout_tests/port/qt.py:
4426         (QtPort._wk2_port_name):
4427         (QtPort._skipped_file_search_paths):