[GTK] accessibility/editable-webarea-context-menu-point.html is failing
[WebKit-https.git] / Tools / ChangeLog
1 2012-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
2
3         [GTK] accessibility/editable-webarea-context-menu-point.html is failing
4         https://bugs.webkit.org/show_bug.cgi?id=98364
5
6         Reviewed by Chris Fleizach.
7
8         The test is failing because the clickPoint values remain unchanged. The
9         values remain unchanged because ATK lacks a means to keep track of this
10         information.
11
12         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
13         (AccessibilityUIElement::clickPointX): Added comment that ATK doesn't have clickPoint details
14         (AccessibilityUIElement::clickPointY): Added comment that ATK doesn't have clickPoint details
15
16 2012-12-09  Alejandro Piñeiro  <apinheiro@igalia.com>
17
18         [GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and AccessibilityUIElementGtk::isMultiSelectable
19         https://bugs.webkit.org/show_bug.cgi?id=104481
20
21         Reviewed by Martin Robinson.
22
23         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
24         (AccessibilityUIElement::isSelectable): Implement this by checking
25         the current state of the AtkObject.
26         (AccessibilityUIElement::isMultiSelectable): Implement this by
27         checking the current state of the AtkObject.
28
29 2012-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
30
31         [GTK] accessibility/placeholder.html is failing
32         https://bugs.webkit.org/show_bug.cgi?id=98373
33
34         Reviewed by Martin Robinson.
35
36         The test was failing because the placeholder text was not supported and
37         AccessibilityUIElement::stringAttributeValue() was not implemented.
38
39         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
40         (coreAttributeToAtkAttribute): New convenience method to convert WebCore attribute
41         names into AtkObject attribute names
42         (AccessibilityUIElement::stringAttributeValue): implemented
43
44 2012-12-09  Dan Winship  <danw@gnome.org>
45
46         [GTK] Bump libxml2 requirement in jhbuild.modules
47         https://bugs.webkit.org/show_bug.cgi?id=104477
48
49         Reviewed by Martin Robinson.
50
51         Fedora 18's Apache depends on symbols in libxml2 2.9.0, so the
52         tests won't run if we only have libxml2 2.8.0 installed in the
53         jhbuild root.
54
55         * gtk/jhbuild.modules:
56
57 2012-12-09  Zan Dobersek  <zandobersek@gmail.com>
58
59         Remove testRunner.disableImageLoading()
60         https://bugs.webkit.org/show_bug.cgi?id=98083
61
62         Reviewed by Gustavo Noronha Silva.
63
64         Remove the disableImageLoading methods and callback.
65         No tests use the method anymore and all ports except Wx
66         now support this behavior through overriding the
67         WebKitDisplayImagesKey preference.
68
69         * DumpRenderTree/TestRunner.cpp:
70         (TestRunner::staticFunctions):
71         * DumpRenderTree/TestRunner.h:
72         (TestRunner):
73         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
74         (TestRunner::overridePreference): Add support for overriding the
75         WebKitDisplayImagesKey preference which is now the preferred way
76         of disabling image loading.
77         * DumpRenderTree/efl/TestRunnerEfl.cpp:
78         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
79         * DumpRenderTree/mac/TestRunnerMac.mm:
80         * DumpRenderTree/qt/TestRunnerQt.cpp:
81         * DumpRenderTree/qt/TestRunnerQt.h:
82         (TestRunner):
83         * DumpRenderTree/win/TestRunnerWin.cpp:
84         * DumpRenderTree/wx/TestRunnerWx.cpp:
85
86 2012-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
87
88         [GTK] accessibility/label-for-control-hittest.html is failing
89         https://bugs.webkit.org/show_bug.cgi?id=98368
90
91         Reviewed by Martin Robinson.
92
93         The test was failing because AccessibilityUIElement::elementAtPoint was
94         not implemented.
95
96         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
97         (AccessibilityUIElement::elementAtPoint): implemented
98
99 2012-12-09  Jon Lee  <jonlee@apple.com>
100
101         [WK2] Move button image to injected bundle
102         https://bugs.webkit.org/show_bug.cgi?id=104107
103         <rdar://problem/12813842>
104
105         Reviewed by Simon Fraser.
106
107         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
108         (WTR::InjectedBundlePage::InjectedBundlePage): Update the bundle page UI client.
109
110 2012-12-08  Halton Huo  <halton.huo@intel.com>
111
112         [CMake] Add CMake style checker
113         https://bugs.webkit.org/show_bug.cgi?id=104240
114
115         Reviewed by Eric Seidel.
116
117         The CMake style checker is followed by existing style checkers like cpp, python.
118         Unit test is added as well.
119
120         * Scripts/webkitpy/style/checker.py: Use CMakeChecker CMAKE type files(.cmake or CMakeLists.txt)
121         (FileType):
122         (CheckerDispatcher._file_type):
123         (CheckerDispatcher._create_checker):
124         * Scripts/webkitpy/style/checkers/cmake.py: Added.
125         (CMakeChecker):
126         (CMakeChecker.__init__): 
127         (CMakeChecker.check):
128         (CMakeChecker._process_line):
129         (CMakeChecker._check_trailing_whitespace):
130         (CMakeChecker._check_no_space_cmds):
131         (CMakeChecker._check_one_space_cmds):
132         (CMakeChecker._check_non_lowercase_cmd):
133         (CMakeChecker._check_indent):
134         * Scripts/webkitpy/style/checkers/cmake_unittest.py: Added.
135         (CMakeCheckerTest):
136         (CMakeCheckerTest.test_init):
137         (CMakeCheckerTest.test_init._mock_handle_style_error):
138         (CMakeCheckerTest.test_check):
139         (CMakeCheckerTest.test_check._mock_handle_style_error):
140
141 2012-12-08  Kondapally Kalyan  <kalyan.kondapally@intel.com>
142
143         [EFL] Enable WebGL by default.
144         https://bugs.webkit.org/show_bug.cgi?id=102991.
145
146         Reviewed by Kenneth Rohde Christiansen.
147
148         Enable WebGL by default.
149
150         * Scripts/webkitperl/FeatureList.pm:
151
152 2012-12-07  Scott Violet  <sky@chromium.org>
153
154         [chromium] Remove linux theme related files and switch to default
155         https://bugs.webkit.org/show_bug.cgi?id=103897
156
157         Reviewed by Dimitri Glazkov.
158
159         * Scripts/webkitpy/common/config/build_unittest.py:
160         (ShouldBuildTest): linux->default
161
162 2012-12-07  Mike Lattanzio  <mlattanzio@rim.com>
163
164         [BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
165         https://bugs.webkit.org/show_bug.cgi?id=104121
166
167         Reviewed by Rob Buis.
168
169         Update createBuffer call to reflect new BufferType enum.
170         Internal PR 254649
171         Internal Review: Jakob Petsovits
172
173         DRT is always backed for maximum compatibility.
174
175         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
176         (createBitmapContextFromWebView):
177
178 2012-12-07  Jochen Eisinger  <jochen@chromium.org>
179
180         Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers
181         https://bugs.webkit.org/show_bug.cgi?id=104355
182
183         Reviewed by Dirk Pranke.
184
185         This enables chromium's content_shell driver to run with the full SUID
186         sandbox.
187
188         * Scripts/webkitpy/layout_tests/port/base.py:
189         (Port.to.setup_environ_for_server):
190
191 2012-12-07  KyungTae Kim  <ktf.kim@samsung.com>
192
193         [EFL] Fix tools for WebKit2-only builds
194         https://bugs.webkit.org/show_bug.cgi?id=103904
195
196         Reviewed by Laszlo Gombos.
197
198         The libewebkit2.so should be used for library path for EFL WebKit2.
199
200         * Scripts/webkitdirs.pm:
201         (builtDylibPathForName):
202
203 2012-12-07  Xiaobo Wang  <xbwang@torchmobile.com.cn>
204
205         [BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
206         https://bugs.webkit.org/show_bug.cgi?id=104243
207
208         RIM PR 259337
209
210         Reviewed by Rob Buis.
211
212         1. Implement calculation of navigation originating in
213         didDecidePolicyForNavigationAction().
214         2. Implement policy delegate for resource response.
215         3. Enable customPolicyDelegate if waitForPolicyDelegate() is called.
216         4. Minor optional updates in dump() and dumpFrameLoadCallbacks().
217
218         The patch fixed the following tests:
219         - http/tests/download
220         - fast/forms/mailto/formenctype-attribute-button-html.html
221         - fast/forms/mailto/formenctype-attribute-input-html.html
222         - fast/encoding/mailto-always-utf-8.html
223
224         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
225         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
226         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
227         (BlackBerry::WebKit::DumpRenderTree::dump):
228         (BlackBerry::WebKit::DumpRenderTree::didFinishLoadForFrame):
229         (BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForNavigationAction):
230         (BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForResponse):
231         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate):
232         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
233         (DumpRenderTree):
234         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
235         (TestRunner::setCustomPolicyDelegate):
236         (TestRunner::waitForPolicyDelegate):
237         (TestRunner::overridePreference):
238
239 2012-12-07  Gwang Yoon Hwang  <ryumiel@company100.net>
240
241         [Qt] Adjust library name in layout_tests/port/qt.py after Qt5-r40
242         https://bugs.webkit.org/show_bug.cgi?id=104348
243
244         Reviewed by Csaba Osztrogonác.
245
246         After Qt-5.0.0-r40, the library was renamed from QtWebKitWidgets to
247         Qt5WebKitWidgets. run-webkit-tests were still looking for QtWebKitWidgets
248
249         * Scripts/webkitpy/layout_tests/port/qt.py:
250         (QtPort._path_to_webcore_library):
251
252 2012-12-07  Csaba Osztrogonác  <ossy@webkit.org>
253
254         Unreviewed fix, unbreak run-launcher after library renaming.
255
256         * Scripts/webkitdirs.pm:
257         (builtDylibPathForName):
258
259 2012-12-06  Csaba Osztrogonác  <ossy@webkit.org>
260
261         Unreviewed fix after r136896, unbreak --debug-rwt to make bots result verbose again.
262         https://bugs.webkit.org/show_bug.cgi?id=104296
263
264         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
265         (main):
266
267 2012-12-06  Rick Byers  <rbyers@chromium.org>
268
269         CSS cursor property should support webkit-image-set
270         https://bugs.webkit.org/show_bug.cgi?id=99493
271
272         Reviewed by Beth Dakin.
273
274         Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default
275
276         * Scripts/webkitperl/FeatureList.pm:
277         * qmake/mkspecs/features/features.pri:
278
279 2012-12-06  Vivek Galatage  <vivek.vg@samsung.com>
280
281         Unreviewed. Fixing the email address order to work correctly with bugzilla.
282
283         * Scripts/webkitpy/common/config/committers.py:
284
285 2012-12-06  Jochen Eisinger  <jochen@chromium.org>
286
287         [chromium] when forwarding events through the WebPluginContainer, create a UserGestureIndicator if processing a user gesture
288         https://bugs.webkit.org/show_bug.cgi?id=104306
289
290         Reviewed by Dimitri Glazkov.
291
292         * DumpRenderTree/chromium/TestWebPlugin.cpp:
293         (TestWebPlugin::TestWebPlugin):
294         (TestWebPlugin::handleInputEvent): add support for printing the user gesture status
295         * DumpRenderTree/chromium/TestWebPlugin.h:
296         (TestWebPlugin):
297
298 2012-12-06  Dirk Pranke  <dpranke@chromium.org>
299
300         new-run-webkit-tests --lint-test-files seems to be broken
301         https://bugs.webkit.org/show_bug.cgi?id=104296
302
303         Unreviewed, build fix.
304
305         My recent refactoring caused me to not initialize the printer
306         before calling lint(); this patch restructures the code to make
307         the lint routine self-contained and do all the work necessary.
308         This will also make it easier to move this code out into a standalone
309         file.
310
311         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
312         (lint):
313         (main):
314         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
315         (LintTest.test_all_configurations):
316         (LintTest.test_lint_test_files):
317         (LintTest.test_lint_test_files__errors):
318
319 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
320
321         DFG profiler should be helpful about gem installation
322         https://bugs.webkit.org/show_bug.cgi?id=104217
323
324         Reviewed by Oliver Hunt.
325         
326         'json' and 'highline' are not installed by default on the ruby distributions with
327         which I am familiar, and the default error messages don't make me happy. This makes
328         display-profiler-output print a helpful message if those gems are not found.
329
330         * Scripts/display-profiler-output:
331
332 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
333
334         Profiler should print a helpful message if you pass the wrong arguments
335         https://bugs.webkit.org/show_bug.cgi?id=104222
336
337         Reviewed by Oliver Hunt.
338
339         * Scripts/display-profiler-output:
340
341 2012-12-06  Ojan Vafai  <ojan@chromium.org>
342
343         Allow for CCing a secondary email address from watchlists
344         https://bugs.webkit.org/show_bug.cgi?id=104286
345
346         Reviewed by Dirk Pranke.
347
348         Change my watchlist CC address so I can filter these separately from
349         when people explicitly CC me and update the watchlist parser to allow that.
350
351         * Scripts/webkitpy/common/config/committers.py:
352         * Scripts/webkitpy/common/config/watchlist:
353         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
354         (WatchListParser._validate):
355         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
356         (WatchListParserTest.test_cc_rule_with_invalid_email):
357         (WatchListParserTest.test_cc_rule_with_secondary_email):
358
359 2012-12-06  Max Vujovic  <mvujovic@adobe.com>
360
361         Unreviewed. Add myself to committers.py.
362
363         * Scripts/webkitpy/common/config/committers.py:
364
365 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
366
367         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
368         https://bugs.webkit.org/show_bug.cgi?id=104139
369
370         Reviewed by Kenneth Rohde Christiansen.
371
372         Resize the window back to 800x600 between tests.
373         This should be a no-op if the test did not resize the window.
374
375         * WebKitTestRunner/TestController.cpp:
376         (WTR::TestController::resetStateToConsistentValues):
377
378 2012-12-06  Tommy Widenflycht  <tommyw@google.com>
379
380         Speech Recognition API: Change the error code to a string on SpeechRecognitionError
381         https://bugs.webkit.org/show_bug.cgi?id=104254
382
383         Reviewed by Adam Barth.
384
385         Changes the mock error function to take a string instead of an int.
386
387         * DumpRenderTree/chromium/DRTTestRunner.cpp:
388         (DRTTestRunner::setMockSpeechRecognitionError):
389         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
390         (WebTestRunner::ErrorTask::ErrorTask):
391         (MockWebSpeechRecognizer::setError):
392         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
393         (MockWebSpeechRecognizer):
394
395 2012-12-06  Andras Becsi  <andras.becsi@digia.com>
396
397         [Qt][Mac] Fix libxslt and libxml2 config tests
398         https://bugs.webkit.org/show_bug.cgi?id=104164
399
400         Reviewed by Simon Hausmann.
401
402         We should not use pkg-config on Mac instead use direct include
403         paths and add needed libraries to the linker options to detect
404         libxslt and libxml2 provided by the system.
405         Previously we would always fall back to qtxmlpatterns.
406
407         * qmake/config.tests/libxml2/libxml2.pro:
408         * qmake/config.tests/libxslt/libxslt.pro:
409
410 2012-12-06  Csaba Osztrogonác  <ossy@webkit.org>
411
412         [Qt] Fix the build if the path contains "+" character
413         https://bugs.webkit.org/show_bug.cgi?id=104120
414
415         Reviewed by Tor Arne Vestbø.
416
417         The second parameter of qmake's replace() is regular expression, so
418         we have to escape special characters in paths passed to replace().
419
420         * qmake/mkspecs/features/default_post.prf:
421         * qmake/mkspecs/features/default_pre.prf:
422         * qmake/mkspecs/features/functions.prf:
423
424 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
425
426         Unreviewed, rolling out r136825.
427         http://trac.webkit.org/changeset/136825
428         https://bugs.webkit.org/show_bug.cgi?id=104251
429
430         It made 100+ test fail on Qt-WK2 pixel bot, and 1800+ test
431         flakey on Qt-WK2 non-pixel bot (Requested by Ossy on #webkit).
432
433         * WebKitTestRunner/TestController.cpp:
434         (WTR::TestController::resetStateToConsistentValues):
435
436 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
437
438         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
439         https://bugs.webkit.org/show_bug.cgi?id=104139
440
441         Reviewed by Kenneth Rohde Christiansen.
442
443         Resize the window back to 800x600 between tests.
444         This should be a no-op if the test did not resize the window.
445
446         * WebKitTestRunner/TestController.cpp:
447         (WTR::TestController::resetStateToConsistentValues):
448
449 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
450
451         Unreviewed, rolling out r136784 and r136802.
452         http://trac.webkit.org/changeset/136784
453         http://trac.webkit.org/changeset/136802
454         https://bugs.webkit.org/show_bug.cgi?id=104231
455
456         breaks chromium canary (Requested by morrita on #webkit).
457
458         * Scripts/webkitpy/common/config/build_unittest.py:
459         (ShouldBuildTest):
460
461 2012-12-05  Ryosuke Niwa  <rniwa@webkit.org>
462
463         Add myself to watch changes in PerformanceTests/*.
464
465         * Scripts/webkitpy/common/config/watchlist:
466
467 2012-12-05  Shinya Kawanaka  <shinyak@chromium.org>
468
469         [Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
470         https://bugs.webkit.org/show_bug.cgi?id=102459
471
472         Reviewed by Dimitri Glazkov.
473
474         Since WebThemeControlDRTWin::markState does not consider indeterminate state, DRT caused a crash.
475
476         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
477         (WebThemeControlDRTWin::markState):
478
479 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
480
481         DFG profiler should be able to display where a code block was inlined into, and what it inlined
482         https://bugs.webkit.org/show_bug.cgi?id=104216
483
484         Reviewed by Oliver Hunt.
485
486         Added an "inlines" command that shows the inline stacks that a code block participated
487         in. Also cleaned up some of the ways we print compilation units.
488
489         * Scripts/display-profiler-output:
490
491 2012-12-05  Halton Huo  <halton.huo@intel.com>
492
493         [CMake] Unify coding style for CMake files
494         https://bugs.webkit.org/show_bug.cgi?id=103605
495
496         Reviewed by Laszlo Gombos.
497
498         Update cmake files(.cmake, CMakeLists.txt) with following style rules:
499         1. Indentation
500         1.1 Use spaces, not tabs.
501         1.2 Four spaces as indent.
502         2. Spacing
503         2.1 Place one space between control statements and their parentheses.
504             For eg, if (), else (), elseif (), endif (), foreach (),
505             endforeach (), while (), endwhile (), break ().
506         2.2 Do not place spaces between function and macro statements and
507             their parentheses. For eg, macro(), endmacro(), function(),
508             endfunction().
509         2.3 Do not place spaces between a command or function or macro and its
510             parentheses, or between a parenthesis and its content. For eg,
511             message("testing") not message( "testing") or message ("testing" )
512         2.4 No space at line ending.
513         3. Lowercase when call commands macros and functions. For eg,
514            add_executable() not ADD_EXECUTABLE(), set() not SET().
515
516         * CMakeLists.txt:
517         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
518         * DumpRenderTree/efl/CMakeLists.txt:
519         * EWebLauncher/CMakeLists.txt:
520         * EWebLauncher/ControlTheme/CMakeLists.txt:
521         * MiniBrowser/efl/CMakeLists.txt:
522         * TestWebKitAPI/CMakeLists.txt:
523         * TestWebKitAPI/PlatformEfl.cmake:
524         * WebKitTestRunner/CMakeLists.txt:
525         * WebKitTestRunner/PlatformEfl.cmake:
526         * WinCELauncher/CMakeLists.txt:
527         * clang/ReportMemoryUsagePlugin/CMakeLists.txt:
528
529 2012-12-05  Scott Violet  <sky@chromium.org>
530
531         [chromium] Remove linux theme related files and switch to default
532         https://bugs.webkit.org/show_bug.cgi?id=103897
533
534         Reviewed by Tony Chang.
535
536         * Scripts/webkitpy/common/config/build_unittest.py:
537         (ShouldBuildTest): linux->default
538
539 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
540
541         nrwt: run_webkit_tests_integrationtest.py depends on being able to share a port w/ between master and worker
542         https://bugs.webkit.org/show_bug.cgi?id=78168
543
544         Reviewed by Ojan Vafai.
545
546         This patch adds a single ordered list to ResultSummary that contains
547         the results of every test run in order of result received, and
548         modifies the TestResults class to contain the list of references used
549         for each test as well as the pid of the driver; this allows us to stop
550         having to override the test drivers to record the tests, and makes the
551         integration tests that test rdering, retries, restarts, etc. black-box
552         tests.
553
554         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
555         (SingleTestRunner._run_rebaseline):
556         (SingleTestRunner._compare_output):
557         (SingleTestRunner._run_reftest):
558         (SingleTestRunner._compare_output_with_reference):
559         * Scripts/webkitpy/layout_tests/models/result_summary.py:
560         (ResultSummary.__init__):
561         (ResultSummary.add):
562         * Scripts/webkitpy/layout_tests/models/test_results.py:
563         (TestResult.__init__):
564         * Scripts/webkitpy/layout_tests/port/driver.py:
565         (DriverOutput.__init__):
566         (Driver.run_test):
567         * Scripts/webkitpy/layout_tests/port/test.py:
568         (TestDriver):
569         (TestDriver.__init__):
570         (TestDriver.run_test):
571         (TestDriver.stop):
572         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
573         (get_tests_run):
574         (get_test_batches):
575         (get_test_results):
576         (MainTest.test_batch_size):
577         (MainTest.test_dryrun):
578         (MainTest.test_natural_order):
579         (MainTest.test_natural_order_test_specified_multiple_times):
580         (MainTest.test_random_order):
581         (MainTest.test_random_order_test_specified_multiple_times):
582         (MainTest.test_no_order):
583         (MainTest.test_no_order_test_specified_multiple_times):
584         (MainTest.test_no_order_with_directory_entries_in_natural_order):
585         (MainTest.test_repeat_each):
586         (MainTest.test_ignore_flag):
587         (MainTest.test_skipped_flag):
588         (MainTest.test_iterations):
589         (MainTest.test_run_chunk):
590         (MainTest.test_run_part):
591         (MainTest.test_run_singly):
592         (MainTest.test_skip_failing_tests):
593         (MainTest.test_single_file):
594         (MainTest.test_single_file_with_prefix):
595         (MainTest.test_single_skipped_file):
596         (MainTest.test_test_list):
597         (MainTest.test_test_list_with_prefix):
598         (MainTest.test_exit_after_n_failures):
599         (MainTest.test_exit_after_n_crashes):
600         (MainTest.test_run_order__inline):
601         (MainTest.test_reftest_run):
602         (MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
603         (MainTest.test_reftest_skip_reftests_if_no_ref_tests):
604         (MainTest.test_reftest_expected_html_should_be_ignored):
605         (MainTest.test_reftest_driver_should_run_expected_html):
606         (MainTest.test_reftest_driver_should_run_expected_mismatch_html):
607         (MainTest.test_no_http_tests):
608         (MainTest.test_platform_tests_are_found):
609
610 2012-12-05  Dana Jansens  <danakj@chromium.org>
611
612         [chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
613         https://bugs.webkit.org/show_bug.cgi?id=103967
614
615         Reviewed by James Robinson.
616
617         Use the WebCompositorSupport methods to create an OutputSurface. If they
618         fail, then fall back to the WebViewHost methods.
619
620         Once the chromium side lands, the WebCompositorSupport methods will stop
621         failing, and will replace the WebViewHost ones.
622
623         * DumpRenderTree/chromium/WebViewHost.cpp:
624         (WebViewHost::createOutputSurface):
625
626 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
627
628         nrwt: split all of the buildbot-specific output into its own file
629         https://bugs.webkit.org/show_bug.cgi?id=104165
630
631         Reviewed by Ojan Vafai.
632
633         Now that we have the RunDetails object we can move all of the
634         buildbot-specific knowledge out of the core test-running code
635         and into the outermost run_webkit_tests layer.
636
637         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
638         (run):
639         (main):
640         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
641         (passing_run):
642         (logging_run):
643         (run_and_capture):
644         (MainTest.test_all):
645         (MainTest.test_max_locked_shards):
646         (MainTest.test_child_processes_2):
647         (MainTest.test_child_processes_min):
648         (MainTest.test_full_results_html):
649         (MainTest.test_hung_thread):
650         (MainTest.test_keyboard_interrupt):
651         (MainTest.test_no_tests_found):
652         (MainTest.test_no_tests_found_2):
653         (MainTest.test_repeat_each_iterations_num_tests):
654         (MainTest.test_run_singly_actually_runs_tests):
655         (MainTest.test_test_list):
656         (MainTest.test_unexpected_failures):
657         (MainTest.test_missing_and_unexpected_results):
658         (MainTest.test_pixel_test_directories):
659         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
660         (MainTest.test_crash_with_stderr):
661         (MainTest.test_no_image_failure_with_image_diff):
662         (MainTest.test_crash_log):
663         (MainTest.test_web_process_crash_log):
664         (MainTest.test_exit_after_n_failures_upload):
665         (MainTest.test_results_directory_absolute):
666         (MainTest.test_results_directory_default):
667         (MainTest.test_results_directory_relative):
668         (MainTest.test_retrying_and_flaky_tests):
669         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
670         (MainTest.test_output_diffs):
671         (MainTest.test_unsupported_platform):
672         (MainTest.test_verbose_in_child_processes):
673         (EndToEndTest.test_end_to_end):
674         (EndToEndTest.test_reftest_with_two_notrefs):
675         (RebaselineTest.test_reset_results):
676         (RebaselineTest.test_missing_results):
677         (RebaselineTest.test_new_baseline):
678         * Scripts/webkitpy/layout_tests/views/buildbot_results.py: Added.
679         (BuildBotPrinter):
680         (BuildBotPrinter.__init__):
681         (BuildBotPrinter.print_results):
682         (BuildBotPrinter._print):
683         (BuildBotPrinter.print_result_summary):
684         (BuildBotPrinter._print_result_summary_entry):
685         (BuildBotPrinter.print_unexpected_results):
686         (BuildBotPrinter.print_unexpected_results.add_to_dict_of_lists):
687         (BuildBotPrinter.print_unexpected_results.add_result):
688         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py: Added.
689         (BuildBotPrinterTests):
690         (BuildBotPrinterTests.assertEmpty):
691         (BuildBotPrinterTests.assertNotEmpty):
692         (BuildBotPrinterTests.get_printer):
693         (BuildBotPrinterTests.get_result):
694         (BuildBotPrinterTests.get_result_summary):
695         (BuildBotPrinterTests.test_print_unexpected_results):
696         (BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
697         * Scripts/webkitpy/layout_tests/views/printing.py:
698         (Printer):
699         (Printer.__init__):
700         (Printer.print_results):
701         (Printer._print_statistics_for_test_timings):
702         (Printer._print_baseline):
703         (Printer._print_debug):
704         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
705         (Testprinter.get_printer):
706         (Testprinter.get_result):
707         (Testprinter.test_configure_and_cleanup):
708         (Testprinter.test_print_config):
709         (Testprinter.test_print_one_line_summary):
710         (Testprinter.test_test_status_line):
711         (Testprinter.test_details):
712
713 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
714
715         nrwt: collect all of the information about a run into a new RunDetails class
716         https://bugs.webkit.org/show_bug.cgi?id=104158
717
718         Reviewed by Ojan Vafai.
719
720         This patch collects the information from both test passes (the
721         main one and the retries) as well as the summarized results and
722         the exit code into a RunDetails class, so that the integration
723         tests can more easily tell what happened.
724
725         Also, change the way the --lint-test-files works slightly so that
726         we don't need to create a printer object (and hence we need to
727         rework the tests that are testing logging).
728
729         * Scripts/webkitpy/layout_tests/controllers/manager.py:
730         (RunDetails):
731         (RunDetails.__init__):
732         (Manager.run):
733         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
734         (run):
735         (main):
736         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
737         (passing_run):
738         (run_and_capture):
739         (LintTest.test_lint_test_files):
740         (LintTest.test_lint_test_files__errors):
741         (MainTest.test_verbose_in_child_processes):
742
743 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
744
745         nrwt: remove --no-record-results
746         https://bugs.webkit.org/show_bug.cgi?id=104072
747
748         Reviewed by Ojan Vafai.
749
750         The command line flag was only being used in the unit tests and
751         wasn't really needed once we started using a mock filesystem.
752
753         Also, reformat a bunch of long lines ...
754
755         * Scripts/webkitpy/layout_tests/controllers/manager.py:
756         (Manager.run):
757         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
758         (parse_args):
759         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
760         (parse_args):
761         (passing_run):
762         (logging_run):
763         (MainTest.test_repeat_each_iterations_num_tests):
764         (MainTest.test_test_list):
765         (MainTest.test_missing_and_unexpected_results):
766         (MainTest.test_pixel_test_directories):
767         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
768         (MainTest.test_crash_with_stderr):
769         (MainTest.test_no_image_failure_with_image_diff):
770         (MainTest.test_crash_log):
771         (MainTest.test_web_process_crash_log):
772         (MainTest.test_exit_after_n_failures_upload):
773         (MainTest.test_results_directory_absolute):
774         (MainTest.test_results_directory_relative):
775         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
776         (MainTest.test_additional_expectations):
777         (MainTest.test_output_diffs):
778         (EndToEndTest.test_end_to_end):
779         (EndToEndTest.test_reftest_with_two_notrefs):
780         (RebaselineTest.test_reset_results):
781         (RebaselineTest.test_missing_results):
782         (RebaselineTest.test_new_baseline):
783
784 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
785
786         nrwt: only summarize the results one way
787         https://bugs.webkit.org/show_bug.cgi?id=104064
788
789         Reviewed by Ojan Vafai.
790
791         Change manager.summarize_results so that we always (and only)
792         include both expected and unexpected results. Previously we
793         would summarize the results twice, once with expected results
794         and once without. This made the code much more confusing than
795         it needed to be.
796
797         * Scripts/webkitpy/layout_tests/controllers/manager.py:
798         (summarize_results):
799         (Manager.run):
800         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
801         (ResultSummaryTest.summarized_results):
802         (ResultSummaryTest.test_no_svn_revision):
803         (ResultSummaryTest.test_svn_revision):
804         (ResultSummaryTest.test_summarized_results_wontfix):
805         * Scripts/webkitpy/layout_tests/views/printing.py:
806         (Printer.print_results):
807         (Printer._print_unexpected_results):
808         (Printer._print_unexpected_results.add_result):
809         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
810         (Testprinter.test_print_unexpected_results.get_unexpected_results):
811         (Testprinter):
812
813 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
814
815         DFG profiler should display more information
816         https://bugs.webkit.org/show_bug.cgi?id=104163
817
818         Reviewed by Gavin Barraclough.
819
820         Added the following:
821         
822         - Distinguish between source counts and bytecode counts.
823         
824         - Add a "full" summary view that shows both kinds of counts, plus inline counts.
825         
826         - Add a "source" command to see the source.
827         
828         - Add a "bytecode" command to see the bytecode and counts.
829
830         * Scripts/display-profiler-output:
831
832 2012-12-05  Yong Li  <yoli@rim.com>
833
834         [BlackBerry] Build with libjpegturbo
835         https://bugs.webkit.org/show_bug.cgi?id=104152
836
837         Reviewed by Rob Buis.
838
839         RIM PR# 196975.
840         Make sure the right include path for libjpeg is included.
841
842         * Scripts/webkitdirs.pm:
843         (blackberryCMakeArguments):
844
845 2012-12-05  Joseph Pecoraro  <pecoraro@apple.com>
846
847         Remove stale check in check-for-webkit-framework-include-consistency
848         https://bugs.webkit.org/show_bug.cgi?id=103775
849
850         Reviewed by David Kilzer.
851
852         The underlying issue was fixed in r81173.
853
854         * Scripts/check-for-webkit-framework-include-consistency:
855
856 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
857
858         nrwt: simplify the finding of tests to retry
859         https://bugs.webkit.org/show_bug.cgi?id=104067
860
861         Reviewed by Ryosuke Niwa.
862
863         I think this makes the code a little clearer; note that
864         we were no longer using the include_missing flag.
865
866         * Scripts/webkitpy/layout_tests/controllers/manager.py:
867         (Manager.run):
868         (Manager._failed_test_names):
869
870 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
871
872         nrwt: remove two unused parameters from a function
873         https://bugs.webkit.org/show_bug.cgi?id=104059
874
875         Reviewed by Ryosuke Niwa.
876
877         Also remove an old, stale FIXME.
878
879         * Scripts/webkitpy/layout_tests/controllers/manager.py:
880         (interpret_test_failures):
881         (summarize_results):
882         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
883         (ResultSummaryTest.test_interpret_test_failures):
884
885 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
886
887         nrwt: return result_summaries from LayoutTestRunner.run_tests()
888         https://bugs.webkit.org/show_bug.cgi?id=104051
889
890         Reviewed by Ojan Vafai.
891
892         This patch completes the refactoring that makes the result summary      
893         an object returned from the layout test runner, rather than having      
894         it passed in and modified. This makes the split of duties between       
895         the manager and runner clearer and makes the data flow more             
896         functionally.                                                           
897
898         Also clean up some minor lint issues.
899
900         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
901         (LayoutTestRunner.__init__):
902         (LayoutTestRunner.run_tests):
903         (LayoutTestRunner._mark_interrupted_tests_as_skipped):
904         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
905         (FakePrinter.print_expected):
906         (LockCheckingRunner.__init__):
907         (LayoutTestRunnerTests._runner):
908         (LayoutTestRunnerTests._run_tests):
909         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
910         * Scripts/webkitpy/layout_tests/controllers/manager.py:
911         (Manager.__init__):
912         (Manager.run):
913         (Manager._run_tests):
914
915 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
916
917         nrwt: move creation of the resultsummary objects into Manager._run_tests()
918         https://bugs.webkit.org/show_bug.cgi?id=104048
919
920         Reviewed by Ojan Vafai.
921
922         This is a preparatory step to making the resultsummary just get
923         returned from the layout_test_runner; this does most of manager-side
924         changes.
925
926         * Scripts/webkitpy/layout_tests/controllers/manager.py:
927         (Manager._prepare_lists):
928         (Manager.run):
929         (Manager._run_tests):
930
931 2012-12-05  Leo Yang  <leoyang@rim.com>
932
933         [BlackBerry] Enable CSS_IMAGE_RESOLUTION
934         https://bugs.webkit.org/show_bug.cgi?id=104132
935
936         Reviewed by Yong Li.
937
938         * Scripts/webkitperl/FeatureList.pm:
939
940 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
941
942         JSC profiler should not count executions of op_call_put_result because doing so changes DFG codegen
943         https://bugs.webkit.org/show_bug.cgi?id=104102
944
945         Reviewed by Oliver Hunt.
946
947         Modify the profiler to not output counts for op_call_put_result, since there
948         won't be any. Also fix a few weird bugs, like providing better error reporting
949         when you type something incorrectly and not reporting counts for slow paths
950         in the old JIT since those counts are actually not what you think they are
951         (we don't actually count slow path executions separately).
952
953         * Scripts/display-profiler-output:
954
955 2012-12-05  Andras Becsi  <andras.becsi@digia.com>
956
957         Fix compilation for Qt5.0.0 stable branch.
958         https://bugs.webkit.org/show_bug.cgi?id=103870
959
960         Reviewed by Simon Hausmann.
961
962         Fix the use of renamed QWindow functions.
963         Patch by Andras Becsi <andras.becsi@digia.com>
964
965         * MiniBrowser/qt/BrowserWindow.cpp:
966         (BrowserWindow::BrowserWindow):
967         (BrowserWindow::onTitleChanged):
968         * MiniBrowser/qt/raw/View.cpp:
969         (View::View):
970
971 2012-12-05  Jussi Kukkonen  <jussi.kukkonen@intel.com>
972
973         [WK2] InjectedBundle should check Intent url for null
974         https://bugs.webkit.org/show_bug.cgi?id=104117
975
976         Reviewed by Kenneth Rohde Christiansen.
977
978         WKIntentServiceInfoCopyHref() can return null, we need to check
979         for that in InjectedBundlePage::registerIntentServiceForFrame()
980         to avoid crashing.
981
982         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
983         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
984
985 2012-12-04  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
986
987         Change email address of Jonathan Dong
988         https://bugs.webkit.org/show_bug.cgi?id=103976
989
990         Unreviewed, change my email address from jonathan.dong@torchmobile.com.cn
991         to jonathan.dong.webkit@gmail.com in committers list.
992
993         * Scripts/webkitpy/common/config/committers.py:
994
995 2012-12-04  Xiaobo Wang  <xbwang@torchmobile.com.cn>
996
997         [BlackBerry] DRT - Tests under "dumpAsText" directory should be dumped as text
998         https://bugs.webkit.org/show_bug.cgi?id=103986
999
1000         Reviewed by Rob Buis.
1001
1002         Also move declaration of webSettingTransaction to before any WebSettings
1003         ::setXXX() calls so that it works as expected (commit only once in the
1004         function scope).
1005
1006         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1007         (shouldDumpAsText):
1008         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1009
1010 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
1011
1012         display-profiler-output should be able to show source code
1013         https://bugs.webkit.org/show_bug.cgi?id=104073
1014
1015         Reviewed by Oliver Hunt.
1016
1017         Display source code in the summary, using a one-line shortening.
1018
1019         * Scripts/display-profiler-output:
1020
1021 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
1022
1023         display-profiler-output should not use reflective infocation to resolve command names
1024
1025         Rubber stamped by Mark Hahnenberg.
1026
1027         Reflection is amazing, but here it was just kind of a bit much.
1028
1029         * Scripts/display-profiler-output:
1030
1031 2012-12-02  Filip Pizlo  <fpizlo@apple.com>
1032
1033         JSC should be able to report profiling data associated with the IR dumps and disassembly
1034         https://bugs.webkit.org/show_bug.cgi?id=102999
1035
1036         Reviewed by Gavin Barraclough.
1037
1038         Added a tool that allows you to grok the output from JSC's new profiler. Currently,
1039         this still gets confused a bit about the execution counts of a method running
1040         standalone versus a method running inlined, but other than that, it's pretty cool.
1041         See the attached "sampling profiling session" attached to the bug to see it in
1042         action.
1043         
1044         Also had to feed EFL's build system.
1045
1046         * DumpRenderTree/efl/CMakeLists.txt:
1047         * Scripts/display-profiler-output: Added.
1048
1049 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1050
1051         nrwt: fix total number of tests computed in the result summary
1052         https://bugs.webkit.org/show_bug.cgi?id=104061
1053
1054         Unreviewed, build fix.
1055
1056         One of the recent changes to the resultsummary refactoring caused
1057         us to not include the number of skipped tests in the total number
1058         of tests, throwing off the totals printed in print_one_line_summary().
1059
1060         Unfortunately, given the current state of the code it is difficult
1061         to construct an accurate unit test for this. I have verified the
1062         fix by hand, and will write a test once the remaining refactoring
1063         patches land, at which point it will be trivial to test it.
1064
1065         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1066         (Manager._prepare_lists):
1067
1068 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1069
1070         nrwt is not returning the exit status properly
1071         https://bugs.webkit.org/show_bug.cgi?id=103830
1072
1073         Unreviewed, build fix.
1074
1075         The fix in r136474 wasn't quite right either, and would return
1076         the correct exceptional status, but not the correct failing status.
1077
1078         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1079
1080 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1081
1082         nrwt: make paths and test_names passed arguments in Manager._prepare_lists et al
1083         https://bugs.webkit.org/show_bug.cgi?id=104047
1084
1085         Reviewed by Eric Seidel.
1086
1087         The code becomes cleaner if we are just passing values around rather
1088         than hanging them off the manager object, helps move _prepare_lists()
1089         to a pure function, and is needed to eventually make the
1090         result_summary object something returned from runner.run_tests()
1091         (note that two more patches are needed for that to happen).
1092
1093         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1094         (Manager.__init__):
1095         (Manager._http_tests):
1096         (Manager._prepare_lists):
1097         (Manager.needs_servers):
1098         (Manager._set_up_run):
1099         (Manager.run):
1100         (Manager._run_tests):
1101         (Manager._upload_json_files):
1102         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1103         (ManagerTest.test_needs_servers.get_manager):
1104         (ManagerTest.test_needs_servers):
1105         (ManagerTest.integration_test_needs_servers.get_manager):
1106         (ManagerTest.integration_test_needs_servers):
1107         (ManagerTest.test_look_for_new_crash_logs.get_manager):
1108         (ManagerTest):
1109         (ManagerTest.test_look_for_new_crash_logs):
1110         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1111         (JSONLayoutResultsGenerator.__init__):
1112         (JSONLayoutResultsGenerator._get_modifier_char):
1113
1114 2012-12-04  Adam Barth  <abarth@webkit.org>
1115
1116         commit-queue can get stuck with a local commit
1117         https://bugs.webkit.org/show_bug.cgi?id=104032
1118
1119         Reviewed by Dirk Pranke.
1120
1121         Previously the commit-queue would only clean down to HEAD. If the
1122         commit-queue gets interrupted in the middle of a commit (e.g., after
1123         the local commit but before the dcommit), then it can end up with a
1124         patch locally committed. That patch will then prevent the commit-queue
1125         from functioning.
1126
1127         This patch teaches the commit-queue to clean down to the merge base,
1128         which will remove any local commits.
1129
1130         * Scripts/webkitpy/common/checkout/scm/git.py:
1131         (Git.working_directory_is_clean):
1132         (Git.clean_working_directory):
1133         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1134         * Scripts/webkitpy/tool/steps/commit.py:
1135         (Commit._commit_warning):
1136         (Commit.run):
1137
1138 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1139
1140         nrwt: store only the total number of tests in the result summary
1141         https://bugs.webkit.org/show_bug.cgi?id=103963
1142
1143         Reviewed by Ryosuke Niwa.
1144
1145         The result summary only needs the total number of tests that will
1146         be run (including repetitions) in order to provide the correct stats;
1147         it doesn't actually need to know how many unique tests there are, or
1148         or how many repetitions there are.
1149
1150         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1151         (LayoutTestRunnerTests._result_summary):
1152         (LayoutTestRunnerTests.test_update_summary_with_result):
1153         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1154         (Manager._prepare_lists):
1155         (Manager.run):
1156         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1157         (ManagerTest.test_look_for_new_crash_logs):
1158         (ResultSummaryTest.get_result_summary):
1159         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1160         (ResultSummary.__init__):
1161         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1162         (Testprinter.get_result_summary):
1163
1164 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1165
1166         nrwt: do less work when ctrl-c'ed
1167         https://bugs.webkit.org/show_bug.cgi?id=103961
1168
1169         Reviewed by Ryosuke Niwa.
1170
1171         Do less work when we are ctrl-c'ed, because the statistics aren't
1172         that useful anyway. While we're at it, modify summarize_results
1173         to be aware that we don't always retry results (instead of pretending
1174         that the retry produced the same results the initial run did).
1175
1176         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1177         (summarize_results):
1178         (Manager.run):
1179
1180 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1181
1182         nrwt: result summaries should not require a list of tests to skip
1183         https://bugs.webkit.org/show_bug.cgi?id=103951
1184
1185         Reviewed by Ryosuke Niwa.
1186
1187         We shouldn't really be passing a list of tests to skip to the
1188         ResultSummary objects; they should be handled like any other
1189         test result as much as possible.
1190
1191         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1192         (LayoutTestRunnerTests._result_summary):
1193         (LayoutTestRunnerTests.test_update_summary_with_result):
1194         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1195         (Manager._prepare_lists):
1196         (Manager.run):
1197         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1198         (ManagerTest.test_look_for_new_crash_logs):
1199         (ResultSummaryTest.get_result_summary):
1200         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1201         (ResultSummary.__init__):
1202         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1203         (TestExpectations):
1204         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1205         (Testprinter.get_result_summary):
1206
1207 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1208
1209         nrwt: derive per-thread, per-worker stats from result summaries
1210         https://bugs.webkit.org/show_bug.cgi?id=103943
1211
1212         Reviewed by Ojan Vafai.
1213
1214         This patch changes the manager and printing code to pull more           
1215         information from the ResultSummary object rather than tracking          
1216         additional statistics on the side. This allows us to consolidate        
1217         a bunch of logic and remove a bunch of free-floating lists and dicts of 
1218         of values. We add the shard_name and worker_name to each TestResult,    
1219         and then modify print_timing_statistics() and upload_json_files()       
1220         to just need the result summaries.                                      
1221
1222         Note that this patch also changes the timing statistics slightly
1223         so that the individual test times are the times to run just the
1224         tests themselves (TestResult.test_run_time) and do not include the
1225         times taken to run the ref tests, compute diffs, etc. The aggregated
1226         per-worker and per-shard statistics still use the total time to
1227         process each test (TestResult.total_run_time).
1228
1229         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1230         (LayoutTestRunner.__init__):
1231         (LayoutTestRunner.run_tests):
1232         (LayoutTestRunner._handle_finished_test_list):
1233         (LayoutTestRunner._handle_finished_test):
1234         (Worker.handle):
1235         (Worker._run_test):
1236         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1237         (summarize_results):
1238         (Manager.run):
1239         (Manager._upload_json_files):
1240         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1241         (ResultSummaryTest.summarized_results):
1242         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1243         (JSONLayoutResultsGenerator.__init__):
1244         (JSONLayoutResultsGenerator._get_test_timing):
1245         * Scripts/webkitpy/layout_tests/models/test_results.py:
1246         (TestResult.__init__):
1247         * Scripts/webkitpy/layout_tests/views/printing.py:
1248         (Printer.print_results):
1249         (Printer._print_timing_statistics):
1250         (Printer):
1251         (Printer._print_worker_statistics):
1252         (Printer._print_aggregate_test_statistics):
1253         (Printer._print_individual_test_times):
1254         (Printer._print_directory_timings):
1255         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1256         (Testprinter.test_print_unexpected_results.get_unexpected_results):
1257         (Testprinter):
1258
1259 2012-12-04  Adam Barth  <abarth@webkit.org>
1260
1261         Remove obsolete code from webkitpy
1262         https://bugs.webkit.org/show_bug.cgi?id=104029
1263
1264         Reviewed by Eric Seidel.
1265
1266         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1267         (CommitQueueTask.run):
1268         * Scripts/webkitpy/tool/steps/commit.py:
1269         (Commit.options):
1270         * Scripts/webkitpy/tool/steps/options.py:
1271         (Options):
1272
1273 2012-12-04  Jochen Eisinger  <jochen@chromium.org>
1274
1275         [chromium] move WebPreferences and methods for modifying them to the TestRunner library
1276         https://bugs.webkit.org/show_bug.cgi?id=103841
1277
1278         Reviewed by Darin Fisher.
1279
1280         * DumpRenderTree/DumpRenderTree.gypi:
1281         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1282         (DRTTestRunner::DRTTestRunner):
1283         (DRTTestRunner::reset):
1284         * DumpRenderTree/chromium/DRTTestRunner.h:
1285         (DRTTestRunner):
1286         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.h.
1287         (WebKit):
1288         (WebTestRunner):
1289         (WebPreferences):
1290         (WebTestRunner::WebPreferences::WebPreferences):
1291         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1292         (WebTestRunner):
1293         (WebTestDelegate):
1294         (WebTestRunner::WebTestDelegate::localFileToDataURL):
1295         (WebTestRunner::WebTestDelegate::rewriteLayoutTestsURL):
1296         (WebTestRunner::WebTestDelegate::preferences):
1297         (WebTestRunner::WebTestDelegate::applyPreferences):
1298         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1299         (WebTestRunner::TestRunner::TestRunner):
1300         (WebTestRunner::TestRunner::reset):
1301         (WebTestRunner::TestRunner::setUserStyleSheetEnabled):
1302         (WebTestRunner):
1303         (WebTestRunner::TestRunner::setUserStyleSheetLocation):
1304         (WebTestRunner::TestRunner::setAuthorAndUserStylesEnabled):
1305         (WebTestRunner::TestRunner::setPopupBlockingEnabled):
1306         (WebTestRunner::TestRunner::setJavaScriptCanAccessClipboard):
1307         (WebTestRunner::TestRunner::setXSSAuditorEnabled):
1308         (WebTestRunner::TestRunner::setAllowUniversalAccessFromFileURLs):
1309         (WebTestRunner::TestRunner::setAllowFileAccessFromFileURLs):
1310         (WebTestRunner::TestRunner::overridePreference):
1311         (WebTestRunner::TestRunner::setPluginsEnabled):
1312         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1313         (TestRunner):
1314         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.cpp.
1315         (WebTestRunner::WebPreferences::reset):
1316         (WebTestRunner):
1317         (WebTestRunner::WebPreferences::applyTo):
1318         * DumpRenderTree/chromium/TestShell.h:
1319         (TestShell::preferences):
1320         (TestShell):
1321         * DumpRenderTree/chromium/WebViewHost.cpp:
1322         (WebViewHost::localFileToDataURL):
1323         (WebViewHost::rewriteLayoutTestsURL):
1324         (WebViewHost::preferences):
1325         (WebViewHost::applyPreferences):
1326         * DumpRenderTree/chromium/WebViewHost.h:
1327         (WebViewHost):
1328
1329 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1330
1331         Many webkitpy unit tests can be run standalone, are executable
1332         https://bugs.webkit.org/show_bug.cgi?id=103900
1333
1334         Reviewed by Eric Seidel.
1335
1336         There's no need anymore to run unit tests in standalone mode as they
1337         are now handled by test-webkitpy in a formidable fashion. This makes
1338         it possible for this patch to remove the following unnecessary bits:
1339         - remove shebang lines from unit test files,
1340         - remove calls to unittest.main(),
1341         - make unit test files non-executable.
1342
1343         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1344         (DiffParserTest.test_git_mnemonicprefix):
1345         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1346         (GitTestWithMock.test_push_local_commits_to_server_without_username_and_with_password):
1347         * Scripts/webkitpy/common/config/build_unittest.py:
1348         (ShouldBuildTest.test_should_build):
1349         * Scripts/webkitpy/common/config/ports_unittest.py:
1350         (DeprecatedPortTest.test_chromium_xvfb_port):
1351         * Scripts/webkitpy/common/find_files_unittest.py:
1352         (TestWinNormalize.test_win):
1353         * Scripts/webkitpy/common/lru_cache_unittest.py:
1354         (LRUCacheTest.test_set_again):
1355         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1356         (test_results_zip_url):
1357         * Scripts/webkitpy/common/net/credentials_unittest.py:
1358         (test_keyring_without_git_repo_nor_keychain):
1359         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
1360         (OmahaProxyTest.test_get_revisions):
1361         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
1362         * Scripts/webkitpy/common/newstringio_unittest.py:
1363         (NewStringIOTest.test_with):
1364         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
1365         (ReadChecksumFromPngTest.test_read_checksum):
1366         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
1367         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1368         (MockFileSystemTest.test_normpath):
1369         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1370         (RealFileSystemTest.test_sep):
1371         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1372         (TestPlatformInfo.test_total_bytes_memory):
1373         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1374         (ZipFileSetTest.test_namelist):
1375         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1376         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1377         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1378         (TestResultWriterTest.test_reftest_diff_image):
1379         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1380         (JSONGeneratorTest.test_test_timings_trie):
1381         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1382         (TestExpectationSerializationTests.test_string_whitespace_stripping):
1383         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1384         (KeyCompareTest.test_test_key):
1385         * Scripts/webkitpy/layout_tests/port/builders_unittest.py:
1386         (BuildersTest.test_path_from_name):
1387         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1388         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
1389         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1390         (ChromiumLinuxPortTest.test_path_to_image_diff):
1391         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1392         (ChromiumMacPortTest.test_path_to_image_diff):
1393         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1394         (ChromiumPortLoggingTest.test_check_sys_deps):
1395         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1396         (ChromiumPortLoggingTest.test_check_sys_deps):
1397         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1398         (ConfigTest.test_default_configuration__scripterror):
1399         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1400         (DriverTest.test_start_actually_starts):
1401         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1402         (FactoryTest.test_get_from_builder_name):
1403         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
1404         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
1405         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1406         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:
1407         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1408         (PortTest.disabled_test_mac_lion):
1409         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1410         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1411         (VerboseTest.test_log_args):
1412         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1413         (test_details):
1414         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1415         (TestPerfTestFactory.test_inspector_test):
1416         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1417         (test_parse_args):
1418         * Scripts/webkitpy/style/checker_unittest.py:
1419         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1420         (ChangeLogCheckerTest.test_no_error):
1421         * Scripts/webkitpy/style/checkers/common_unittest.py:
1422         (TabCheckerTest.test_tab):
1423         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1424         (CppCheckerTest.test_ne):
1425         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
1426         * Scripts/webkitpy/style/checkers/png_unittest.py:
1427         (PNGCheckerTest.test_check):
1428         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1429         * Scripts/webkitpy/style/checkers/text_unittest.py:
1430         (TextCheckerTest.test_init):
1431         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
1432         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
1433         (XcodeProjectFileCheckerTest.test_detect_development_region):
1434         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1435         (XMLCheckerTest.test_no_error):
1436         * Scripts/webkitpy/style/patchreader_unittest.py:
1437         * Scripts/webkitpy/test/finder_unittest.py:
1438         (FinderTest.test_paths):
1439         * Scripts/webkitpy/test/runner_unittest.py:
1440         (RunnerTest.test_run):
1441         * Scripts/webkitpy/test/skip_unittest.py:
1442         (SkipTest.test_skip_if_true):
1443         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1444         (ThirdpartyTest.test_imports):
1445         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1446         (TestTranslation.test_include_rewriting):
1447         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1448         (QueueEngineTest.tearDown):
1449         * Scripts/webkitpy/tool/grammar_unittest.py:
1450         (GrammarTest.test_join_with_separators):
1451         * Scripts/webkitpy/tool/mocktool_unittest.py:
1452         (MockOptionsTest.test_kwarg__set):
1453         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1454         (test_command_help):
1455
1456 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1457
1458         Many webkitpy module files are executable, have shebang line
1459         https://bugs.webkit.org/show_bug.cgi?id=103985
1460
1461         Reviewed by Dirk Pranke.
1462
1463         Remove the executable bit from webkitpy module files that are
1464         unnecessarily executable. Remove the shebang line from webkitpy
1465         module files, they are of no use. Only non-third-party files are
1466         changed.
1467
1468         * Scripts/webkitpy/bindings/main.py:
1469         * Scripts/webkitpy/common/config/watchlist:
1470         * Scripts/webkitpy/common/find_files.py:
1471         * Scripts/webkitpy/common/lru_cache.py:
1472         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1473         * Scripts/webkitpy/common/net/file_uploader.py:
1474         * Scripts/webkitpy/common/newstringio.py:
1475         * Scripts/webkitpy/common/read_checksum_from_png.py:
1476         * Scripts/webkitpy/common/system/autoinstall.py:
1477         * Scripts/webkitpy/common/system/file_lock.py:
1478         * Scripts/webkitpy/common/system/file_lock_mock.py:
1479         * Scripts/webkitpy/common/version_check.py:
1480         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1481         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1482         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1483         * Scripts/webkitpy/layout_tests/models/test_input.py:
1484         * Scripts/webkitpy/layout_tests/port/__init__.py:
1485         * Scripts/webkitpy/layout_tests/port/base.py:
1486         * Scripts/webkitpy/layout_tests/port/builders.py:
1487         * Scripts/webkitpy/layout_tests/port/chromium.py:
1488         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1489         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1490         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1491         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1492         * Scripts/webkitpy/layout_tests/port/config.py:
1493         * Scripts/webkitpy/layout_tests/port/factory.py:
1494         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1495         * Scripts/webkitpy/layout_tests/port/image_diff.py:
1496         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1497         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1498         * Scripts/webkitpy/layout_tests/port/server_process.py:
1499         * Scripts/webkitpy/layout_tests/port/test.py:
1500         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1501         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1502         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1503         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1504         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1505         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1506         * Scripts/webkitpy/layout_tests/views/printing.py:
1507         * Scripts/webkitpy/performance_tests/perftest.py:
1508         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1509         * Scripts/webkitpy/style/checkers/changelog.py:
1510         * Scripts/webkitpy/style/checkers/cpp.py:
1511         * Scripts/webkitpy/style/checkers/xcodeproj.py:
1512         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1513         (main): There's no need to run this module in standalone because
1514         it's wrapped by the Tools/Scripts/update-webgl-conformance-tests script.
1515         * Scripts/webkitpy/tool/commands/upload.py:
1516         * Scripts/webkitpy/tool/comments.py:
1517         * Scripts/webkitpy/tool/main.py:
1518
1519 2012-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1520
1521         Add a Chromium Android Release (Perf) to the list of perf. bots.
1522
1523         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1524
1525 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1526
1527         [GTK] Insert the jhbuild wrapper command at the beginning of the command list
1528         https://bugs.webkit.org/show_bug.cgi?id=103991
1529
1530         Reviewed by Martin Robinson.
1531
1532         Insert the Tools/gtk/run-with-jhbuild wrapper at the beginning of the
1533         command that's being formed in multiprocessing bootstrap. The wrapper is
1534         an executable Python script while the command being wrapped perhaps isn't
1535         and therefore requires the Python interpreter to be listed at the beginning
1536         of the command sublist that is then executed by the wrapper.
1537
1538         Specifically, the webkitpy/layout_tests/run_webkit_tests.py module file
1539         is about to lose the executable bit and the Python-signaling shebang line.
1540         The Jhbuild wrapper simply executes the command that's passed, but that errs
1541         in this case unless the Python executable is executed and the module file
1542         is passed to it as an argument.
1543
1544         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1545         (run):
1546
1547 2012-12-04  Peter Beverloo  <peter@chromium.org>
1548
1549         Add the Chromium Android Release (Perf) bot
1550         https://bugs.webkit.org/show_bug.cgi?id=103891
1551
1552         Reviewed by Eric Seidel.
1553
1554         Add configuration for the bot itself. It will be triggered by the Chromium
1555         Android Release builder. When running for Android, the DownloadAndPerfTest
1556         factory will also add the OutputAndroidDeviceStatus step.
1557
1558         * BuildSlaveSupport/build.webkit.org-config/config.json:
1559         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1560         (DownloadAndPerfTestFactory.__init__):
1561
1562 2012-12-04  Peter Beverloo  <peter@chromium.org>
1563
1564         [Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
1565         https://bugs.webkit.org/show_bug.cgi?id=103758
1566
1567         Reviewed by Eric Seidel.
1568
1569         Lazily initialize the adb command parameters rather than initializing it in the
1570         constructor now that there is an assert if adb is not available on the system and
1571         we're not in a Chromium Android checkout.
1572
1573         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1574         (ChromiumAndroidDriver.__init__):
1575         (ChromiumAndroidDriver._push_file_if_needed):
1576         (ChromiumAndroidDriver._run_adb_command):
1577         (ChromiumAndroidDriver.cmd_line):
1578         (ChromiumAndroidDriver._start_once):
1579         (ChromiumAndroidDriver._read_prompt):
1580         (ChromiumAndroidDriver):
1581         (ChromiumAndroidDriver._adb_command):
1582
1583 2012-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1584
1585         Dromaeo should report individual test result
1586         https://bugs.webkit.org/show_bug.cgi?id=99800
1587
1588         Reviewed by Eric Seidel.
1589
1590         Ignore subtest results spit out by Dromaeo tests.
1591
1592         * Scripts/webkitpy/performance_tests/perftest.py:
1593         (PerfTest): Added a line to ignore.
1594         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1595         (MainTest.test_parse_output_with_subtests): Added.
1596
1597 2012-12-03  Zan Dobersek  <zandobersek@gmail.com>
1598
1599         Unreviewed, functionality fix after r136437.
1600
1601         Calling sys.exit actually raises a SystemExit exception that
1602         is then handled in the second block and causes the script to
1603         return an 'exceptional' exit code rather than the code presenting
1604         the number of failed tests.
1605
1606         This is just a temporary fix to get the faultless bots green while
1607         they are unnecessarily red at the moment. The problem and a proper
1608         fix will be properly addressed.
1609
1610         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1611
1612 2012-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1613
1614         Unreviewed, rolling out r136460.
1615         http://trac.webkit.org/changeset/136460
1616         https://bugs.webkit.org/show_bug.cgi?id=103958
1617
1618         This patch caused compile error when building DumpRenderTree
1619         (Requested by tasak on #webkit).
1620
1621         * Scripts/webkitpy/common/config/build_unittest.py:
1622         (ShouldBuildTest):
1623
1624 2012-12-03  Scott Violet  <sky@chromium.org>
1625
1626         [chromium] Remove linux theme related files and switch to default
1627         https://bugs.webkit.org/show_bug.cgi?id=103897
1628
1629         Reviewed by Darin Fisher.
1630
1631         * Scripts/webkitpy/common/config/build_unittest.py:
1632         (ShouldBuildTest): linux->default
1633
1634 2012-12-03  Roger Fong  <roger_fong@apple.com>
1635
1636         Disable WebKit2 API tests on Apple Windows port.
1637         https://bugs.webkit.org/show_bug.cgi?id=103929.
1638
1639         Reviewed by Timothy Horton.
1640
1641         * Scripts/run-api-tests:
1642         (runTestsBySuite):
1643
1644 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1645
1646         webkitpy's run_webkit_tests should initialize the printer earlier on
1647         https://bugs.webkit.org/show_bug.cgi?id=103661
1648
1649         Reviewed by Eric Seidel.
1650
1651         Initialize the printer before computing the derived options
1652         from the command line arguments, so that we can safely log from
1653         port methods.
1654
1655         Also clean up a few miscellaneous lint warnings.
1656
1657         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1658         (ChromiumAndroidPort.path_to_adb):
1659         * Scripts/webkitpy/layout_tests/port/mac.py:
1660         (MacPort.default_child_processes):
1661         (MacPort.sample_process):
1662         (MacPort.start_helper):
1663         (MacPort.stop_helper):
1664         (MacPort.nm_command):
1665         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1666         (test_default_child_processes):
1667         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1668         (run):
1669         (_set_up_derived_options):
1670
1671 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1672
1673         webkitpy: autoinstaller is failing on windows
1674         https://bugs.webkit.org/show_bug.cgi?id=103699
1675
1676         Reviewed by Tony Chang.
1677
1678         Attempt to fix the python autoinstaller to work for pylint on win32
1679         again ... it turns out one of the dependent packages contains
1680         a write-protected test file and windows will choke when it tries to move
1681         it into place. Fortunately we can just delete the file prior to
1682         installing it in the final location, but we have to jump through
1683         a couple of hoops to do so.
1684
1685         Also, make sure that we're flattening nested module names like
1686         "logilab/common" into either safe basenames (logilab_common) or
1687         host-specific subdirs (logilab\common) as needed.
1688
1689         * Scripts/webkitpy/common/system/autoinstall.py:
1690         (AutoInstaller._url_downloaded_path):
1691         (AutoInstaller._install):
1692         (AutoInstaller.install):
1693         * Scripts/webkitpy/thirdparty/__init__.py:
1694         (AutoinstallImportHook._install_pylint):
1695
1696 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1697
1698         nrwt: clean up exception propagation / handling for interrupts and early exits
1699         https://bugs.webkit.org/show_bug.cgi?id=103830
1700
1701         Reviewed by Ojan Vafai.
1702
1703         The code for propagating early exits out of the test run was
1704         convoluted and hard to follow. By adjusting the WorkerException to
1705         derive from BaseException rather than Exception (which is a fair
1706         way of representing an error that was really unexpected/unrecoverable
1707         anyway) and pushing the TestRunInterruptedException into the
1708         ResultSummary (which is also fair since it was more of a result
1709         than an exception) this allows us to consolidate and clean up
1710         a bunch of the try/catch logic and pass fewer state flags around.
1711
1712         There are no real functional changes to this patch; there's an
1713         API change in that we stop exporting TestRunInterruptedException
1714         and WorkerException out of the Manager, and the existence of the
1715         MessagePool is now completely hidden.
1716
1717         * Scripts/webkitpy/common/message_pool.py:
1718         (WorkerException):
1719         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1720         (LayoutTestRunner.run_tests):
1721         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1722         (summarize_results):
1723         (Manager.run):
1724         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1725         (ResultSummaryTest.summarized_results):
1726         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1727         (ResultSummary.__init__):
1728         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1729         (run):
1730         (main):
1731         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1732         (MainTest.test_exception_raised.of):
1733         (MainTest.test_exception_raised):
1734         (MainTest.test_run_force):
1735         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1736         (Testprinter.test_print_unexpected_results.get_unexpected_results):
1737         (Testprinter):
1738
1739 2012-12-03  Julien BRIANCEAU   <jbrianceau@nds.com>
1740
1741         Add Qt/SH4 build slave to build.webkit.org
1742         https://bugs.webkit.org/show_bug.cgi?id=103384
1743
1744         Reviewed by Csaba Osztrogonác.
1745
1746         * BuildSlaveSupport/build.webkit.org-config/config.json:
1747
1748 2012-12-03  Alexis Menard  <alexis@webkit.org>
1749
1750         Enable CSS3 background-position offset by default
1751         https://bugs.webkit.org/show_bug.cgi?id=103917
1752
1753         Reviewed by Benjamin Poulain.
1754
1755         Even though each port may enable or not the feature we still need
1756         to pass it at configure time otherwise it will be disabled.
1757
1758         * Scripts/webkitperl/FeatureList.pm:
1759
1760 2012-12-03  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1761
1762         Unreviewed. Adding myself to committers.py.
1763
1764         * Scripts/webkitpy/common/config/committers.py:
1765
1766 2012-12-03  Laszlo Gombos  <l.gombos@samsung.com>
1767
1768         [CMake] Enable building WebKit2-only build for the EFL port
1769         https://bugs.webkit.org/show_bug.cgi?id=103820
1770
1771         Reviewed by Gyuyoung Kim.
1772
1773         Set ENABLE_WEBKIT2 to OFF if build-webkit was run with --no-webkit2.
1774         Never set ENABLE_WEBKIT in build-webkit. This will simplyfy invoking
1775         cmake directly. Initialize $cmakeArgs to avoid potential
1776         warnings when running the script.
1777
1778         * Scripts/build-webkit:
1779
1780 2012-12-03  Tommy Widenflycht  <tommyw@google.com>
1781
1782         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
1783         https://bugs.webkit.org/show_bug.cgi?id=103407
1784
1785         Reviewed by Kentaro Hara.
1786
1787         Changing the mock to use the new results delivery API.
1788
1789         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1790
1791 2012-12-03  Alexis Menard  <alexis@webkit.org>
1792
1793         [Qt] Enable CSS3 background-position offsets by default.
1794         https://bugs.webkit.org/show_bug.cgi?id=103877
1795
1796         Reviewed by Tor Arne Vestbø.
1797
1798         Enable by default CSS3 background-position offsets.
1799
1800         * qmake/mkspecs/features/features.pri:
1801
1802 2012-12-03  KyungTae Kim  <ktf.kim@samsung.com>
1803
1804         [EFL][WK2] Use float variable for zoom levels for MiniBrowser
1805         https://bugs.webkit.org/show_bug.cgi?id=103863
1806
1807         Reviewed by Gyuyoung Kim.
1808
1809         Use float instead of int for zoomLevels variables for a clearer expression
1810
1811         * MiniBrowser/efl/main.c:
1812         (on_key_down):
1813
1814 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
1815
1816         [EFL][WK2] Add support for a zoom level setting to MiniBrowser
1817         https://bugs.webkit.org/show_bug.cgi?id=99285
1818
1819         Reviewed by Gyuyoung Kim.
1820
1821          Add support for a zoom level setting to MiniBrowser.
1822          Shortcuts for setting operations are same as common browsers:
1823          Ctrl + '+' to zoom in, Ctrl + '-' to zoom out and Ctrl + '0' to zoom to default.
1824
1825         * MiniBrowser/efl/main.c:
1826         (on_key_down):
1827
1828 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
1829
1830         [EFL][WK2] ECORE_GETOPT_VALUE_BOOL need to be used for Eina_Bool
1831         https://bugs.webkit.org/show_bug.cgi?id=103835
1832
1833         Reviewed by Kentaro Hara.
1834
1835         Because legacy_behavior_enabled is Eina_Bool, ECORE_GETOPT_VALUE_BOOL need to be used
1836
1837         * MiniBrowser/efl/main.c:
1838         (elm_main):
1839
1840 2012-12-02  Mike West  <mkwst@chromium.org>
1841
1842         Garden-o-matic shouldn't die when blank JSON results are received.
1843         https://bugs.webkit.org/show_bug.cgi?id=103838
1844
1845         Reviewed by Adam Barth.
1846
1847         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1848             If the JSONP string doesn't contain '(' or ')', return an empty object.
1849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1850             Check that this behavior stays in place.
1851
1852 2012-12-02  Eric Seidel  <eric@webkit.org>
1853
1854         run-perf-tests --profile should use iprofiler instead of instruments on Mac
1855         https://bugs.webkit.org/show_bug.cgi?id=103765
1856
1857         Unreviewed.  Updating the unittests after my previous change.
1858
1859         * Scripts/webkitpy/common/system/profiler_unittest.py:
1860         (ProfilerFactoryTest.test_basic):
1861
1862 2012-12-02  Julie Parent  <jparent@chromium.org>
1863
1864         Remove dead code in flakiness dashboard for obsolete buildDir option
1865         https://bugs.webkit.org/show_bug.cgi?id=103792
1866
1867         Reviewed by Dirk Pranke.
1868
1869         * TestResultServer/static-dashboards/dashboard_base.js:
1870         (initBuilders):
1871
1872 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
1873
1874         nrwt: clean up logic for retrying failed tests a bit
1875         https://bugs.webkit.org/show_bug.cgi?id=103829
1876
1877         Reviewed by Ojan Vafai.
1878
1879         The code for determining when to retry test failures and
1880         show the results.html file was awkward and could stand some
1881         cleaning up. This patch should have no functional changes.
1882
1883         The routine called _get_failures() returned a dict of test names
1884         to failure types, but we only ever used the names, so I've converted
1885         it to return a list (and renamed it); also, the show_results_html()
1886         file was calling that routine to figure out if anything failed, when
1887         the information was already in the result_summary (as either
1888         unexpected_results or total_failures), so we were doing unnecessary work.
1889
1890         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1891         (Manager.__init__):
1892         (Manager.run):
1893         (Manager._run_tests):
1894         (Manager._failed_test_names):
1895         (Manager._copy_results_html_file):
1896
1897 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
1898
1899         nrwt: remove unused methods in manager.py
1900         https://bugs.webkit.org/show_bug.cgi?id=103828
1901
1902         Reviewed by Eric Seidel.
1903
1904         These two methods weren't being called by anything and were no
1905         longer needed.
1906
1907         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1908         (Manager._get_failures):
1909         (Manager._upload_json_files):
1910
1911 2012-12-02  Laszlo Gombos  <l.gombos@samsung.com>
1912
1913         Correct the spelling of the cmakeargs argument
1914         https://bugs.webkit.org/show_bug.cgi?id=103814
1915
1916         Reviewed by Darin Adler.
1917
1918         The script expects cmakeargs (plural), so lets get the
1919         documentation of the script report the same.
1920
1921         * Scripts/build-webkit:
1922
1923 2012-12-02  Mike West  <mkwst@chromium.org>
1924
1925         [gtk] Enable the CSP_NEXT runtime flag.
1926         https://bugs.webkit.org/show_bug.cgi?id=103810
1927
1928         Reviewed by Adam Barth.
1929
1930         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1931         (resetDefaultsToConsistentValues):
1932             Turn on the CSP_NEXT runtime flag when running tests under GTK.
1933
1934 2012-12-02  Eric Seidel  <eric@webkit.org>
1935
1936         run-perf-tests --profile should use iprofiler instead of instruments on Mac
1937         https://bugs.webkit.org/show_bug.cgi?id=103765
1938
1939         Reviewed by Ryosuke Niwa.
1940
1941         Stephanie pointed out that iprofiler is the newer command-line interface
1942         to replace /usr/bin/instruments in Instruments 4 (which according to the
1943         interblags is supported on everything since 10.6.6), so I've moved --profile
1944         to use iprofiler on Mac.
1945
1946         I also made the IProfiler class wait for iprofiler to complete so that
1947         iprofiler won't continue running after run-perf-tests is complete (and
1948         spam over the top of your shell output).
1949
1950         There are a couple of "got-chas" to this approach:
1951         1.  iprofiler will ask for your password the first time you run it, which may
1952             cause your first test to fail.  /usr/bin/instruments doesn't seem to do that.
1953         2.  iprofiler has nice (but kinda awkward for our purposes) support for separate
1954             directory and basename arguments, making IProfiler a somewhat awkward
1955             baseclass of SingleFileOutputProfiler
1956
1957         I suspect we'll iterate from here.  It does seem slightly faster than
1958         /usr/bin/instruments was.
1959
1960         * Scripts/webkitpy/common/system/profiler.py:
1961         (ProfilerFactory.create_profiler):
1962         (IProfiler):
1963         (IProfiler.__init__):
1964         (IProfiler.attach_to_pid):
1965
1966 2012-12-02  Yongjun Zhang  <yongjun_zhang@apple.com>
1967
1968         Need a method to close all idle localstorage databases immediately.
1969         https://bugs.webkit.org/show_bug.cgi?id=103469
1970
1971         Reviewed by David Kilzer.
1972
1973         Add an JS method to TestRunner, to enable testing closing idle local storage databases in
1974         DumpRenderTree layout tests.
1975
1976         * DumpRenderTree/TestRunner.cpp:
1977         (closeIdleLocalStorageDatabasesCallback):
1978         (TestRunner::staticFunctions):
1979         * DumpRenderTree/TestRunner.h:
1980         (TestRunner):
1981         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1982         (TestRunner::closeIdleLocalStorageDatabases):
1983         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1984         (TestRunner::closeIdleLocalStorageDatabases):
1985         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1986         (TestRunner::closeIdleLocalStorageDatabases):
1987         * DumpRenderTree/mac/TestRunnerMac.mm:
1988         (TestRunner::closeIdleLocalStorageDatabases):
1989         * DumpRenderTree/win/TestRunnerWin.cpp:
1990         (TestRunner::closeIdleLocalStorageDatabases):
1991         * DumpRenderTree/wx/TestRunnerWx.cpp:
1992         (TestRunner::closeIdleLocalStorageDatabases):
1993
1994 2012-12-02  Yael Aharon  <yael.aharon@intel.com>
1995
1996         [EFL][WK2] MiniBrowser should have a legacy mode
1997         https://bugs.webkit.org/show_bug.cgi?id=103679
1998
1999         Reviewed by Kenneth Rohde Christiansen.
2000
2001         Add an option to start MiniBrowser in legacy mode.
2002
2003         * MiniBrowser/efl/main.c:
2004         (window_create):
2005         (elm_main):
2006
2007 2012-12-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2008
2009         Unreviewed, rolling out r136236.
2010         http://trac.webkit.org/changeset/136236
2011         https://bugs.webkit.org/show_bug.cgi?id=103833
2012
2013         [chromium] Flakey crashes in SpeechRecognitionEvent::emma
2014         during GC. (Requested by mkwst on #webkit).
2015
2016         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2017
2018 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
2019
2020         [XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
2021         https://bugs.webkit.org/show_bug.cgi?id=103806
2022
2023         Reviewed by Dirk Pranke.
2024
2025         There are occasional mishaps on builders where XvfbDriver doesn't properly
2026         clean up the Xvfb instance it was managing so the related guard lock files
2027         are still existing when the webkitpy unit tests are run. This can cause failures
2028         in XvfbDriverTest.test_next_free_display as the test tries to acquire displays
2029         with a specific number but is unable to due to the stale locks.
2030
2031         The solution to this is to use MockFileLock when inside unit test. This is achievable
2032         by creating a file lock through the SystemHost instance connected to the Port object,
2033         the latter available to the Driver.
2034
2035         * Scripts/webkitpy/common/system/file_lock_mock.py:
2036         (MockFileLock.acquire_lock): Return True to signal lock acquiring succeeded.
2037         (MockFileLock.release_lock): Return True to signal lock releasing succeeded.
2038         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2039         (XvfbDriver._next_free_display): Create the file lock through a mockable way.
2040         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
2041         (XvfbDriverTest.test_next_free_display): Enable back the unit test.
2042
2043 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
2044
2045         [GTK] A11y tests in WK2 report badly-formatted AX roles
2046         https://bugs.webkit.org/show_bug.cgi?id=102947
2047
2048         Reviewed by Xan Lopez.
2049
2050         As in DRT, convert the ATK accessibility roles to corresponding AXRoles.
2051         These are expected in both tests and their baselines.
2052
2053         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2054         (WTR::roleToString):
2055         (WTR):
2056         (WTR::AccessibilityUIElement::role):
2057
2058 2012-11-30  Mike West  <mkwst@chromium.org>
2059
2060         CSP 1.1: Make the CSP_NEXT flag runtime enabled.
2061         https://bugs.webkit.org/show_bug.cgi?id=103652
2062
2063         Reviewed by Adam Barth.
2064
2065         Ensures that the new SecurityPolicy runtime flag is enabled for Chromium's tests.
2066
2067         * DumpRenderTree/chromium/TestShell.cpp:
2068         (TestShell::TestShell):
2069
2070 2012-11-30  Roger Fong  <roger_fong@apple.com>
2071
2072         Unreviewed. Removed temporary debugging change from DRT (r136300).
2073
2074         * DumpRenderTree/win/DumpRenderTree.cpp:
2075         (dump):
2076
2077 2012-11-30  Roger Fong  <roger_fong@apple.com>
2078
2079         Unreviewed. Temporary change to DRT for debugging purposes.
2080
2081         * DumpRenderTree/win/DumpRenderTree.cpp:
2082         (dump):
2083
2084 2012-11-29  Tommy Widenflycht  <tommyw@google.com>
2085
2086         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
2087         https://bugs.webkit.org/show_bug.cgi?id=103407
2088
2089         Reviewed by Adam Barth.
2090
2091         Changing the mock to use the new results delivery API.
2092
2093         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2094
2095 2012-11-30  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi  <pierre.rossi@digia.com>
2096
2097         [Qt] Separate Qt WebKit into Qt WebKit and Qt WebKit Widgets
2098         https://bugs.webkit.org/show_bug.cgi?id=99314
2099
2100         Reviewed by Tor Arne Vestbø.
2101
2102         This big change separates QtWebKit into QtWebKit and QtWebKitWidgets as
2103         shared libraries.
2104
2105         It's a big refactoring that mostly involves moving WebCore dependent
2106         code into QtWebKit and accessing it through exported QWebFrameAdapter
2107         and QWebPageAdapter classes.
2108
2109         * DumpRenderTree/qt/DumpRenderTree.pro:
2110         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2111         (WebCore::DumpRenderTree::dump): Adapt to internal API changes.
2112         * MiniBrowser/qt/MiniBrowser.pro:
2113         * Scripts/webkitpy/style/checker.py: Adapt Qt exceptions to new paths.
2114         * Scripts/webkitpy/style/checker_unittest.py:
2115         (GlobalVariablesTest.test_path_rules_specifier):
2116         * WebKitTestRunner/InjectedBundle/Target.pri:
2117         * qmake/mkspecs/features/default_post.prf:
2118         * qmake/mkspecs/features/webkit_modules.prf:
2119         * qmake/mkspecs/modules/webkitwidgets.prf: Removed.
2120
2121 2012-11-30  Csaba Osztrogonác  <ossy@webkit.org>
2122
2123         [Qt] Unreviewed trivial fix.
2124
2125         Add empty.cpp back, it was removed accidentally by r129092.
2126
2127         * qmake/config.tests/gccdepends/empty.cpp: Added.
2128
2129 2012-11-30  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2130
2131         [Qt] Add support for prepare_docs and generate_docs
2132
2133         Follow-up to changes in Qt in how documentation is built.
2134
2135         Reviewed by Simon Hausmann.
2136
2137         * qmake/mkspecs/features/default_post.prf:
2138
2139 2012-11-30  Zan Dobersek  <zandobersek@gmail.com>
2140
2141         Finally remove webkitpy.common.system.deprecated_logging
2142         https://bugs.webkit.org/show_bug.cgi?id=103624
2143
2144         Reviewed by Adam Barth.
2145
2146         Remove the deprecated logging module and its unit tests now that such logging is not
2147         used anymore in webkitpy.
2148
2149         The tee and OutputTee classes are moved into a new module, webkitpy.common.system.outputtee.
2150         The tee class is renamed to Tee to conform with the usual guidelines.
2151
2152         Only unit test for the Tee class is currently provided as the OutputTee is not currently
2153         using the webkitpy Filesystem abstraction that would make its functionality testable.
2154
2155         * Scripts/webkitpy/common/system/executive.py: tee (now Tee) is now in a new module.
2156         (Executive.run_and_throw_if_fail):
2157         * Scripts/webkitpy/common/system/outputtee.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging.py.
2158         (Tee):
2159         (Tee.__init__):
2160         (Tee.write):
2161         (OutputTee):
2162         (OutputTee.__init__):
2163         (OutputTee.add_log):
2164         (OutputTee.remove_log):
2165         (OutputTee._open_log_file):
2166         (OutputTee._tee_outputs_to_files):
2167         * Scripts/webkitpy/common/system/outputtee_unittest.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging_unittest.py.
2168         (SimpleTeeTest):
2169         (SimpleTeeTest.test_simple_tee):
2170         * Scripts/webkitpy/tool/bot/queueengine.py: OutputTee is now in a new module.
2171         * Scripts/webkitpy/webkitpy.pyproj: Remove the deprecated_logging module and related unit test file.
2172
2173 2012-11-30  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2174
2175         [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
2176         https://bugs.webkit.org/show_bug.cgi?id=103634
2177
2178         Reviewed by Gyuyoung Kim.
2179
2180         Add support for PlatformWebView::simulateRightClick() and enable
2181         WebKit2 API test HitTestResultNodeHandle.
2182
2183         * TestWebKitAPI/PlatformEfl.cmake:
2184         * TestWebKitAPI/efl/PlatformWebView.cpp:
2185         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2186         (TestWebKitAPI):
2187
2188 2012-11-30  Mihai Maerean  <mmaerean@adobe.com>
2189
2190         [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
2191         https://bugs.webkit.org/show_bug.cgi?id=101192
2192
2193         Reviewed by Hajime Morita.
2194
2195         Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
2196
2197         Tests: No new tests because there is no functional change.
2198
2199         * DumpRenderTree/chromium/WebPreferences.cpp:
2200         (WebPreferences::applyTo):
2201
2202 2012-11-29  Rafael Weinstein  <rafaelw@chromium.org>
2203
2204         [HTMLTemplateElement] Add feature flag
2205         https://bugs.webkit.org/show_bug.cgi?id=103694
2206
2207         Reviewed by Adam Barth.
2208
2209         This flag will guard the implementation of the HTMLTemplateElement.
2210         http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html
2211
2212         * Scripts/webkitperl/FeatureList.pm:
2213
2214 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2215
2216         Ignore errors when removing directories on win32 during autoinstall
2217         https://bugs.webkit.org/show_bug.cgi?id=103699
2218
2219         Unreviewed, build fix.
2220
2221         I think this will work on win32; if not, I'll have to actually
2222         reproduce this :). The problem is that the logilab files
2223         appear to contain a write-protected file, and deleting those
2224         is problematic on windows.
2225
2226         * Scripts/webkitpy/common/system/autoinstall.py:
2227         (AutoInstaller._install):
2228         (AutoInstaller.install):
2229
2230 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2231
2232         webkitpy: autoinstaller is failing on windows
2233         https://bugs.webkit.org/show_bug.cgi?id=103699
2234
2235         Unreviewed, build fix.
2236
2237         We're attempting to create directories with forward slashes in them;
2238         this is a no-no on windows.
2239
2240         * Scripts/webkitpy/common/system/autoinstall.py:
2241         (AutoInstaller._create_scratch_directory_inner):
2242
2243 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2244
2245         Fix python unit tests after r136158 (android port tests failing)
2246         https://bugs.webkit.org/show_bug.cgi?id=103581
2247
2248         Unreviewed, build fix.
2249
2250         The unit tests apparently weren't ran for this patch; we failed
2251         to update the mock executive calls out to adb to determine various
2252         aspects of the environment, and were failing to create drivers.
2253
2254         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2255         (MockRunCommand.mock_run_command_fn):
2256
2257 2012-11-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2258
2259         Unreviewed, rolling out r136175 and r136177.
2260         http://trac.webkit.org/changeset/136175
2261         http://trac.webkit.org/changeset/136177
2262         https://bugs.webkit.org/show_bug.cgi?id=103683
2263
2264         Changes did not correct Windows build. (Requested by bfulgham
2265         on #webkit).
2266
2267         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2268
2269 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
2270
2271         [Windows, WinCairo] Unreviewed build correction. Correct debug
2272         build case on build machine.
2273
2274         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2275
2276 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
2277
2278         [Windows, WinCairo] Unreviewed build correction. Hide the
2279         unexported 'notSolidColor' symbol when testing against
2280         the BitmapImage class to avoid having to deal with a
2281         debug-only symbol in the Windows export definition file.
2282
2283         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: 
2284
2285 2012-11-29  Peter Beverloo  <peter@chromium.org>
2286
2287         run-perf-tests --chromium-android should not require adb in my path
2288         https://bugs.webkit.org/show_bug.cgi?id=103581
2289
2290         Reviewed by Eric Seidel.
2291
2292         Remove the need to have "adb" available in the path for Layout and Performance
2293         tests. We'll determine the versions of the "adb" version in path (if any) and
2294         the one provided in the Chromium Android checkout. Unless the "adb" available
2295         in the path is newer, the provided version will be used.
2296
2297         Some other minor nits addressed:
2298         - The path_to_forwarder/path_to_md5sum should not be in the "private overrides"
2299           section, as they're not overriding anything and are used by the driver.
2300         - Make _restart_adb_as_root slightly more robust by waiting for the device
2301           to come back online regardless of the output.
2302
2303         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2304         (ChromiumAndroidPort.__init__):
2305         (ChromiumAndroidPort.check_build):
2306         (ChromiumAndroidPort.path_to_adb):
2307         (ChromiumAndroidPort):
2308         (ChromiumAndroidPort.path_to_forwarder):
2309         (ChromiumAndroidPort.path_to_md5sum):
2310         (ChromiumAndroidPort._path_to_helper):
2311         (ChromiumAndroidPort._determine_adb_version):
2312         (ChromiumAndroidPort._get_devices):
2313         (ChromiumAndroidDriver.__init__):
2314         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
2315         (ChromiumAndroidDriver._push_executable):
2316         (ChromiumAndroidDriver._restart_adb_as_root):
2317
2318 2012-11-29  Martin Robinson  <mrobinson@igalia.com>
2319
2320         [GTK] [WebKit2] Embed the HTTP authentication dialog into the WebView
2321         https://bugs.webkit.org/show_bug.cgi?id=103277
2322
2323         Reviewed by Carlos Garcia Campos.
2324
2325         Skip the new WebKit2GtkAuthenticationDialog files so that they are not processed
2326         during gtkdoc generation.
2327
2328         * gtk/generate-gtkdoc:
2329         (get_webkit2_options):
2330
2331 2012-11-29  Eric Seidel  <eric@webkit.org>
2332
2333         run-perf-tests --chromium-android fails due to Skia INFO logging
2334         https://bugs.webkit.org/show_bug.cgi?id=103585
2335
2336         Reviewed by Adam Barth.
2337
2338         Ignore all INFO logging from Chromium code.
2339         Also added some basic testing of the ignored-stderr lines code.
2340
2341         * Scripts/webkitpy/performance_tests/perftest.py:
2342         (PerfTest):
2343         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2344         (MainTest.test_ignored_stderr_lines):
2345
2346 2012-11-29  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2347
2348         [EFL][WK2] Add support for PlatformWebView::simulateMouseMove() in TestWebKitAPI
2349         https://bugs.webkit.org/show_bug.cgi?id=103252
2350
2351         Reviewed by Kenneth Rohde Christiansen.
2352
2353         Add support for PlatformWebView::simulateMouseMove() and enable
2354         WebKit2 API test MouseMoveAfterCrash.
2355
2356         * TestWebKitAPI/PlatformEfl.cmake: Enable MouseMoveAfterCrash API
2357         test.
2358         * TestWebKitAPI/efl/PlatformWebView.cpp:
2359         (TestWebKitAPI::onWebProcessCrashed): Handle 'webprocess,crashed' signal
2360         to prevent loading an error page since the test case is reloading actual
2361         page after web process has terminated and recovered.
2362         (TestWebKitAPI):
2363         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2364         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Implemented.
2365
2366 2012-11-29  Andras Becsi  <andras.becsi@digia.com>
2367
2368         [Qt] Fix installation of QtWebProcess binary
2369         https://bugs.webkit.org/show_bug.cgi?id=101735
2370
2371         Reviewed by Simon Hausmann.
2372
2373         Add config test to detect the availability of support
2374         for "program executables" in Qt (libexec).
2375
2376         This test can be removed after the Qt5 release.
2377
2378         * Tools.pro:
2379         * qmake/mkspecs/features/features.prf:
2380         * qmake/config.tests/libexecdir/libexecdir.cpp:
2381         * qmake/config.tests/libexecdir/libexecdir.pro:
2382
2383 2012-11-29  Eric Seidel  <eric@webkit.org>
2384
2385         run-perf-tests does not work when the layout test directory does not exist
2386         https://bugs.webkit.org/show_bug.cgi?id=103572
2387
2388         Reviewed by Ryosuke Niwa.
2389
2390         Make sure that Profiler() calls maybe_make_directory for the output_dir
2391         before ever using it.  It's a little awkward to create the directory
2392         from the constructor, but its simplest that way as the various subclasses
2393         all use the directory at different times.
2394
2395         Since this required having a filesystem in Profiler (and I didn't want
2396         to grab inside Workspace to get one), I just made Profiler expect a
2397         SystemHost instead of a separate filesystem, executive and workspace.
2398
2399         * Scripts/webkitpy/common/system/profiler.py:
2400         (ProfilerFactory.create_profiler):
2401         (Profiler.__init__):
2402         (SingleFileOutputProfiler.__init__):
2403         (GooglePProf.__init__):
2404         (GooglePProf.profile_after_exit):
2405         (Instruments.__init__):
2406         (Instruments.attach_to_pid):
2407         * Scripts/webkitpy/common/system/profiler_unittest.py:
2408         (ProfilerFactoryTest.test_basic):
2409
2410 2012-11-28  Vivek Galatage  <vivek.vg@samsung.com>
2411
2412         Adding secondary email id
2413         https://bugs.webkit.org/show_bug.cgi?id=103594
2414
2415         Unreviewed. Adding secondary email.
2416
2417         * Scripts/webkitpy/common/config/committers.py:
2418
2419 2012-11-28  Kent Tamura  <tkent@chromium.org>
2420
2421         garden-o-matic: Use indeterminate <progress> in the status area
2422         https://bugs.webkit.org/show_bug.cgi?id=103494
2423
2424         Reviewed by Adam Barth.
2425
2426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2427         Wrap the "Processing..." message with an indeterminate progress bar.
2428         We keep the message as a fallback content.
2429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2430         Follow the above change.
2431
2432 2012-11-28  Nima Ghanavatian  <nghanavatian@rim.com>
2433
2434         Adding Nima Ghanavatian to committers.py
2435         https://bugs.webkit.org/show_bug.cgi?id=103533
2436
2437         Reviewed by Rob Buis.
2438
2439         Adding myself to committers.py as a Committer.
2440
2441         * Scripts/webkitpy/common/config/committers.py:
2442
2443 2012-11-28  peavo@outlook.com  <peavo@outlook.com>
2444
2445         [WinCairo] Crash when requesting favicon.
2446         https://bugs.webkit.org/show_bug.cgi?id=102689
2447
2448         Reviewed by Brent Fulgham.
2449
2450         * TestWebKitAPI/Tests/WebCore/win: Added.
2451         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: Added.
2452         (TestWebKitAPI::BitmapImageTest::BitmapImageTest): Allocate frame in constructor.
2453         (TestWebKitAPI::BitmapImageTest::frameCount): Override frameCount() method.
2454         (TestWebKitAPI::TEST): Added new test.
2455         * TestWebKitAPI/config.h: Make sure defines are correct for WinCairo.
2456        * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
2457
2458 2012-11-28  Eric Seidel  <eric@webkit.org>
2459
2460         run-perf-tests should have a --profile option for easy profiling
2461         https://bugs.webkit.org/show_bug.cgi?id=99517
2462
2463         Reviewed by Adam Barth.
2464
2465         This is a very basic implementation which works on Mac and Linux
2466         and makes it trivial for anyone to profile a PerformanceTest.
2467
2468         Currently it's not "hard" to profile a PerformanceTest
2469         but lowering the barriers to entry here allows all of us to focus
2470         less on the tools and more on the code.
2471
2472         This also paves the way for adding easy mobile-profiling (e.g. chromium-android)
2473         which is actually "hard", and this option will make much easier.
2474
2475         * Scripts/webkitpy/common/system/profiler.py: Added.
2476         (ProfilerFactory):
2477         (ProfilerFactory.create_profiler):
2478         (Profiler):
2479         (Profiler.__init__):
2480         (Profiler.adjusted_environment):
2481         (Profiler.attach_to_pid):
2482         (Profiler.did_stop):
2483         (SingleFileOutputProfiler):
2484         (SingleFileOutputProfiler.__init__):
2485         (GooglePProf):
2486         (GooglePProf.__init__):
2487         (GooglePProf.adjusted_environment):
2488         (GooglePProf.did_stop):
2489         (Instruments):
2490         (Instruments.__init__):
2491         (Instruments.attach_to_pid):
2492         * Scripts/webkitpy/common/system/profiler_unittest.py: Added.
2493         (ProfilerFactoryTest):
2494         (ProfilerFactoryTest.test_basic):
2495         * Scripts/webkitpy/layout_tests/port/driver.py:
2496         (Driver.__init__):
2497         (Driver._start):
2498         (Driver.stop):
2499         (Driver.cmd_line):
2500         * Scripts/webkitpy/performance_tests/perftest.py:
2501         (PerfTest.parse_output):
2502         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2503         (MainTest.test_parse_output):
2504         (MainTest.test_parse_output_with_failing_line):
2505         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2506         (PerfTestsRunner._parse_args):
2507         (PerfTestsRunner.run):
2508
2509 2012-11-28  Zan Dobersek  <zandobersek@gmail.com>
2510
2511         Remove deprecated logging usage from QueueEngine
2512         https://bugs.webkit.org/show_bug.cgi?id=103532
2513
2514         Reviewed by Dirk Pranke.
2515
2516         Replace usage of deprecated logging in webkitpy.tool.bot.queueengine with
2517         logging through the Logger object. The unit test is modified to reflect
2518         these changes.
2519
2520         After these changes the deprecated logging (i.e. logging to stderr) is not
2521         used anymore through webkitpy and can be removed.
2522
2523         * Scripts/webkitpy/tool/bot/queueengine.py:
2524         (QueueEngine.exit_after_handled_error):
2525         (QueueEngine.run):
2526         (QueueEngine._stopping):
2527         (QueueEngine._sleep):
2528         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2529         (QueueEngineTest._run_engine):
2530
2531 2012-11-28  Nate Chapin  <japhet@chromium.org>
2532
2533         Move empty loading to DocumentLoader, simplify FrameLoader::init()
2534         https://bugs.webkit.org/show_bug.cgi?id=101512
2535
2536         Reviewed by Adam Barth.
2537
2538         * DumpRenderTree/chromium/WebViewHost.cpp:
2539         (WebViewHost::updateForCommittedLoad): This function doesn't play nicely with empty urls and incorrectly
2540             interprets them as a non-empty load. This change is required for
2541              http/tests/navigation/new-window-redirect-history.html to continue to pass in chromium.
2542         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: This test relies on a callback that no longer
2543              is sent for about:blank loads.  Hook into didFinishLoadForFrame() instead.
2544         (TestWebKitAPI::didFinishLoadForFrame):
2545         (TestWebKitAPI::TEST):
2546
2547 2012-11-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2548
2549         [chromium] Allow plugins to opt-in to receive synthetic mouse events out of touch events.
2550         https://bugs.webkit.org/show_bug.cgi?id=103092
2551
2552         Reviewed by Tony Chang.
2553
2554         Update the test web-plugin to be able to opt-in to receive synthesized mouse events created
2555         from touch events.
2556
2557         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2558         (parseTouchEventRequestType):
2559         (TestWebPlugin::TestWebPlugin):
2560         (TestWebPlugin::initialize):
2561         * DumpRenderTree/chromium/TestWebPlugin.h:
2562         (TestWebPlugin):
2563
2564 2012-11-28  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2565
2566         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
2567         https://bugs.webkit.org/show_bug.cgi?id=103123
2568
2569         Reviewed by Laszlo Gombos.
2570
2571         Add support for PlatformWebView::simulateSpacebarKeyPress().
2572         This functionality is needed by WebKit2 API test MouseMoveAfterCrash
2573         which is going to be unskipped in bug #103252.
2574
2575         * TestWebKitAPI/efl/PlatformUtilities.cpp:
2576         (TestWebKitAPI::Util::sleep):
2577         * TestWebKitAPI/efl/PlatformWebView.cpp: Use usleep() instead of
2578         sleep().
2579         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2580         (TestWebKitAPI):
2581
2582 2012-11-28  Yael Aharon  <yael.aharon@intel.com>
2583
2584         Minor cleanup in TestInvocation
2585         https://bugs.webkit.org/show_bug.cgi?id=103512
2586
2587         Reviewed by Kenneth Rohde Christiansen.
2588
2589         Remove a function declaration that is not defined and not used.
2590         Fix spelling error in m_webProcessIsUnresponsive.
2591
2592         * WebKitTestRunner/TestInvocation.cpp:
2593         (WTR::TestInvocation::TestInvocation):
2594         (WTR::TestInvocation::invoke):
2595         * WebKitTestRunner/TestInvocation.h:
2596         (TestInvocation):
2597         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2598         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2599         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2600         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2601
2602 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2603
2604         Unreviewed. Use my personal email as bugzilla email.
2605
2606         * Scripts/webkitpy/common/config/committers.py:
2607
2608 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2609
2610         Unreviewed. Adding myself to committers.py.
2611
2612         * Scripts/webkitpy/common/config/committers.py:
2613
2614 2012-11-26  Andrey Adaikin  <aandrey@chromium.org>
2615
2616         Unreviewed. Adding myself to committers.py.
2617
2618         * Scripts/webkitpy/common/config/committers.py:
2619
2620 2012-11-28  Tommy Widenflycht  <tommyw@google.com>
2621
2622         Add basic implementation for MediaStreamAudioDestinationNode
2623         https://bugs.webkit.org/show_bug.cgi?id=101815
2624
2625         Reviewed by Chris Rogers.
2626
2627         Adds a bit of code that exercises the WebKit API.
2628
2629         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2630         (MockWebMediaStreamSourceConsumer):
2631         (MockWebMediaStreamSourceConsumer::~MockWebMediaStreamSourceConsumer):
2632         (MockWebMediaStreamCenter::didCreateMediaStream):
2633
2634 2012-11-28  Matt Falkenhagen  <falken@chromium.org>
2635
2636         Unreviewed. Adding myself to committers list.
2637
2638         * Scripts/webkitpy/common/config/committers.py:
2639
2640 2012-11-27  Li Yin  <li.yin@intel.com>
2641
2642         Unreviewed. Adding myself to committers list.
2643
2644         * Scripts/webkitpy/common/config/committers.py:
2645
2646 2012-11-27  Christophe Dumez  <christophe.dumez@intel.com>
2647
2648         Unreviewed. Adding myself to committers.py.
2649
2650         * Scripts/webkitpy/common/config/committers.py:
2651
2652 2012-11-27  Vivek Galatage  <vivek.vg@samsung.com>
2653
2654         Unreviewd. Adding myself to committers list.
2655
2656         * Scripts/webkitpy/common/config/committers.py:
2657
2658 2012-11-27  Tony Chang  <tony@chromium.org>
2659
2660         Bring back partytime!
2661         https://bugs.webkit.org/show_bug.cgi?id=103466
2662
2663         Reviewed by Adam Barth.
2664
2665         "code 404, message Unknown function images/partytime_gif" since we didn't
2666         allow .gif or .png files to be served.
2667
2668         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2669         (GardeningHTTPRequestHandler):
2670
2671 2012-11-27  Adam Barth  <abarth@webkit.org>
2672
2673         run-perf-tests fails on Android because of stderr output
2674         https://bugs.webkit.org/show_bug.cgi?id=103462
2675
2676         Reviewed by Ryosuke Niwa.
2677
2678         The chromium-android port produces some stderr output that causes
2679         run-perf-tests to get sad and not record the results of the performance
2680         test. This patch teaches run-perf-test to ignore this output much in
2681         the same way that it currently ignores some stdout messages.
2682
2683         * Scripts/webkitpy/performance_tests/perftest.py:
2684         (PerfTest.run):
2685         (PerfTest._should_ignore_line):
2686         (PerfTest):
2687         (PerfTest._should_ignore_line_in_stderr):
2688         (PerfTest._filter_stderr):
2689         (PerfTest._should_ignore_line_in_parser_test_result):
2690
2691 2012-11-27  Tony Chang  <tony@chromium.org>
2692
2693         Fix garden-o-matic for non-chromium ports
2694         https://bugs.webkit.org/show_bug.cgi?id=103458
2695
2696         Reviewed by Adam Barth.
2697
2698         I was getting a 403 error when trying to select any non-chromium port.
2699
2700         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2701         (ReflectionHandler._handle_request): Use the path without query params.
2702
2703 2012-11-27  Yael Aharon  <yael.aharon@intel.com>
2704
2705         [EFL][WK2] 3D pixel tests are failing
2706         https://bugs.webkit.org/show_bug.cgi?id=102833
2707
2708         Reviewed by Kenneth Rohde Christiansen.
2709
2710         Generate a snapshot of the view in the UI process instead of the web process.
2711         We have to use Texture Mapper in order to correctly paint 3D transforms etc.
2712
2713         * WebKitTestRunner/TestInvocation.h:
2714         (TestInvocation):
2715         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2716         (WTR::writeFunction):
2717         (WTR::paintRepaintRectOverlay):
2718         (WTR):
2719         (WTR::TestInvocation::forceRepaintDoneCallback):
2720         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2721         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2722         (WTR::PlatformWebView::windowSnapshotImage):
2723
2724 2012-11-27  Adam Barth  <abarth@webkit.org>
2725
2726         Make it possible to run performance tests on Chromium Android
2727         https://bugs.webkit.org/show_bug.cgi?id=103268
2728
2729         Reviewed by Ryosuke Niwa.
2730
2731         Based on a patch by Peter Beverloo.
2732
2733         This patch (almost) makes it possible to run WebKit performance tests
2734         on the Chromium port for Android. There are a few things I had to do
2735         in order to make this happen:
2736
2737         1) The worker number when creating a driver for a port is zero-based
2738            for layout tests and elsewhere. Android uses this to determine
2739            which device it has to run on, so make it zero based for performance
2740            tests as well.
2741
2742         2) Tests aren't available on the Android device, so we start an HTTP
2743            server that serves the tests to the device or emulator.
2744
2745         The one shortcoming of this patch is that chromium-android produces
2746         some stderr output that confuses run-perf-tests. I'll address that
2747         issue in a subsequent CL. This patch also depends on
2748         https://codereview.chromium.org/11416182 in order to work.
2749
2750         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2751         (ChromiumAndroidPort.start_http_server):
2752         (ChromiumAndroidDriver._command_from_driver_input):
2753         * Scripts/webkitpy/performance_tests/perftest.py:
2754         (ReplayPerfTest.prepare):
2755         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2756         (PerfTestsRunner.__init__):
2757         (PerfTestsRunner._parse_args):
2758         (PerfTestsRunner._start_servers):
2759         (PerfTestsRunner):
2760         (PerfTestsRunner._stop_servers):
2761         (PerfTestsRunner.run):
2762         (PerfTestsRunner._run_tests_set):
2763
2764 2012-11-27  Zan Dobersek  <zandobersek@gmail.com>
2765
2766         Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
2767         https://bugs.webkit.org/show_bug.cgi?id=103408
2768
2769         Reviewed by Dirk Pranke.
2770
2771         Remove the use of the deprecated log and error methods by replacing them with
2772         logging through Python's logging.Logger objects.
2773
2774         This patch covers such changes in webkitpy.common and webkitpy.layout_tests and also
2775         updates any affected unit test.
2776
2777         * Scripts/webkitpy/common/checkout/changelog.py:
2778         (ChangeLogEntry._parse_entry):
2779         * Scripts/webkitpy/common/checkout/checkout.py:
2780         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2781         (CheckoutTest.test_apply_patch):
2782         * Scripts/webkitpy/common/checkout/deps_mock.py:
2783         (MockDEPS.write_variable):
2784         * Scripts/webkitpy/common/checkout/scm/detection.py:
2785         (SCMDetector.default_scm):
2786         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2787         (SCMDetectorTest.test_detect_scm_system):
2788         * Scripts/webkitpy/common/checkout/scm/git.py:
2789         (Git._check_git_architecture):
2790         (Git._commit_on_branch):
2791         * Scripts/webkitpy/common/checkout/scm/scm.py:
2792         (SCM.ensure_clean_working_directory):
2793         (SCM.ensure_no_local_commits):
2794         (SCM.will.commit_locally_with_message):
2795         * Scripts/webkitpy/common/checkout/scm/svn.py:
2796         (SVN.apply_reverse_diff):
2797         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
2798         (Attachment._validate_flag_value):
2799         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2800         (Bugzilla._fetch_bug_page):
2801         (Bugzilla.bug_id_for_attachment_id):
2802         (Bugzilla.authenticate):
2803         (Bugzilla._commit_queue_flag):
2804         (Bugzilla.add_attachment_to_bug):
2805         (Bugzilla.add_patch_to_bug):
2806         (Bugzilla.create_bug):
2807         (Bugzilla.clear_attachment_flags):
2808         (Bugzilla.set_flag_on_attachment):
2809         (Bugzilla.obsolete_attachment):
2810         (Bugzilla.add_cc_to_bug):
2811         (Bugzilla.post_comment_to_bug):
2812         (Bugzilla.close_bug_as_fixed):
2813         (Bugzilla.reassign_bug):
2814         (reopen_bug):
2815         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2816         (MockBugzilla.create_bug):
2817         (MockBugzilla.reassign_bug):
2818         (MockBugzilla.set_flag_on_attachment):
2819         (MockBugzilla.post_comment_to_bug):
2820         (MockBugzilla.add_attachment_to_bug):
2821         (MockBugzilla.add_patch_to_bug):
2822         (MockBugzilla.reopen_bug):
2823         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2824         (test_add_cc_to_bug):
2825         (_assert_reopen):
2826         (test_reopen_bug):
2827         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2828         (MockBuilder.force_build):
2829         * Scripts/webkitpy/common/net/credentials.py:
2830         (Credentials._run_security_tool):
2831         * Scripts/webkitpy/common/net/credentials_unittest.py:
2832         (_assert_security_call):
2833         * Scripts/webkitpy/common/net/irc/irc_mock.py:
2834         (MockIRC.post):
2835         (MockIRC.disconnect):
2836         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2837         (IRCProxy.__init__):
2838         (IRCProxy.disconnect):
2839         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
2840         (IRCProxyTest.test_trivial):
2841         * Scripts/webkitpy/common/net/layouttestresults.py:
2842         (ORWTResultsHTMLParser._failures_from_fail_row):
2843         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2844         (test_failures_from_fail_row):
2845         * Scripts/webkitpy/common/net/networktransaction.py:
2846         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2847         (JSONTestResult._tokenize):
2848         (JSONTestResult._failure_types_from_actual_result):
2849         * Scripts/webkitpy/common/net/statusserver.py:
2850         (StatusServer.update_status):
2851         (StatusServer.update_svn_revision):
2852         * Scripts/webkitpy/common/net/statusserver_mock.py:
2853         (MockStatusServer.release_work_item):
2854         (MockStatusServer.update_work_items):
2855         (MockStatusServer.submit_to_ews):
2856         (MockStatusServer.update_status):
2857         * Scripts/webkitpy/common/net/unittestresults.py:
2858         (UnitTestResults.results_from_string):
2859         * Scripts/webkitpy/common/system/executive_mock.py:
2860         (MockExecutive.running_pids):
2861         (MockExecutive.run_and_throw_if_fail):
2862         (MockExecutive.run_command):
2863         (MockExecutive.popen):
2864         * Scripts/webkitpy/common/system/user_mock.py:
2865         (MockUser.confirm):
2866         (MockUser.open_url):
2867         * Scripts/webkitpy/common/system/workspace_unittest.py:
2868         (WorkspaceTest.test_create_zip):
2869         (WorkspaceTest.test_create_zip_exception):
2870         * Scripts/webkitpy/common/watchlist/watchlist_mock.py:
2871         (MockWatchList.determine_cc_and_messages):
2872         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2873         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
2874         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2875         (EflPortTest.test_show_results_html_file):
2876         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2877         (GtkPortTest.test_show_results_html_file):
2878         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2879         (test_show_results_html_file):
2880         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2881         (test_build_driver):
2882         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2883         (QtPortTest.test_show_results_html_file):
2884         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2885         (WinPortTest.test_show_results_html_file):
2886         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
2887         (XvfbDriverTest.assertDriverStartSuccessful):
2888         (XvfbDriverTest.test_start_no_pixel_tests):
2889         (XvfbDriverTest.test_start_pixel_tests):
2890         (XvfbDriverTest.test_start_arbitrary_worker_number):
2891         (XvfbDriverTest.test_start_next_worker):
2892         (XvfbDriverTest.test_stop):
2893         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2894         (TestLayoutTestApacheHttpd.test_start_cmd):
2895         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2896         (test_run_test_pause_before_testing):
2897         (test_run_memory_test):
2898         (_test_run_with_json_output):
2899         (test_run_respects_no_results):
2900         (test_run_generates_and_show_results_page):
2901         (test_run_respects_no_show_results):
2902         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2903         (FeedersTest.test_commit_queue_feeder):
2904         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2905         (FlakyTestReporterTest.test_create_bug_for_flaky_test):
2906         (test_report_flaky_tests_creating_bug):
2907         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2908         (IRCCommandTest.test_rollout_updates_working_copy):
2909         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2910         (IRCBotTest.test_exception_during_command):
2911         (IRCBotTest.test_hi):
2912         (IRCBotTest.test_help):
2913         (IRCBotTest.test_restart):
2914         (IRCBotTest.test_rollout):
2915         (IRCBotTest.test_revert):
2916         (IRCBotTest.test_roll_chromium_deps):
2917         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
2918         (IRCBotTest.test_multi_rollout):
2919         (IRCBotTest.test_rollout_with_r_in_svn_revision):
2920         (IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
2921         (IRCBotTest.test_rollout_bananas):
2922         (IRCBotTest.test_rollout_invalidate_revision):
2923         (IRCBotTest.test_rollout_invalidate_reason):
2924         (test_multi_rollout_invalidate_reason):
2925         (test_rollout_no_reason):
2926         (test_multi_rollout_no_reason):
2927         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2928         (SheriffTest.test_post_blame_comment_on_bug):
2929         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
2930         (ApplyWatchListLocalTest.test_args_parsing):
2931         (test_args_parsing_with_bug):
2932         * Scripts/webkitpy/tool/commands/download_unittest.py:
2933         (test_land_cowboy):
2934         (test_check_style):
2935         (test_create_rollout):
2936         (test_create_rollout_resolved):
2937         (test_rollout):
2938         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2939         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2940         (EarlyWarningSytemTest._default_expected_logs):
2941         (EarlyWarningSytemTest._test_builder_ews):
2942         (EarlyWarningSytemTest._test_testing_ews):
2943         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
2944         (OpenBugsTest.test_args_parsing):
2945         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2946         (QueryCommandsTest.test_bugs_to_commit):
2947         (QueryCommandsTest.test_patches_in_commit_queue):
2948         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2949         (FeederQueueTest.test_feeder_queue):
2950         (AbstractPatchQueueTest.test_next_patch):
2951         (AbstractPatchQueueTest.test_upload_results_archive_for_patch):
2952         (CommitQueueTest.test_commit_queue):
2953         (test_commit_queue_failure):
2954         (test_commit_queue_failure_with_failing_tests):
2955         (test_rollout):
2956         (test_rollout_lands):
2957         (test_auto_retry):
2958         (test_manual_reject_during_processing):
2959         (test_report_flaky_tests):
2960         (StyleQueueTest.test_style_queue_with_style_exception):
2961         (test_style_queue_with_watch_list_exception):
2962         * Scripts/webkitpy/tool/commands/queuestest.py:
2963         (QueuesTest._default_begin_work_queue_logs):
2964         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2965         (RollCommandsTest.test_update_chromium_deps):
2966         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2967         (UploadCommandsTest.test_assign_to_committer):
2968         (test_post):
2969         (test_attach_to_bug):
2970         (test_attach_to_bug_no_description_or_comment):
2971         (test_land_safely):
2972         (test_prepare):
2973         (test_upload):
2974         (test_mark_bug_fixed):
2975         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
2976         (ApplyWatchListTest.test_apply_watch_list_local):
2977         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2978         (CommitTest._test_check_test_expectations):
2979         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2980         (RunTestsTest.test_webkit_run_unit_tests):
2981         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2982         (StepsTest._assert_step_output_with_bug):
2983         (StepsTest._assert_post_diff_output_for_bug):
2984         (StepsTest.test_post_diff):
2985         (StepsTest.test_post_diff_for_commit):
2986         (StepsTest.test_ensure_bug_is_open_and_assigned):
2987         (StepsTest.test_runtests_args):
2988         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
2989         (SuggestReviewersTest.test_basic):
2990         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2991         (ValidateChangeLogsTest._assert_start_line_produces_output):
2992
2993 2012-11-27  Pratik Solanki  <psolanki@apple.com>
2994
2995         objc/objc-runtime.h does not exist on all PLATFORM(MAC)
2996         https://bugs.webkit.org/show_bug.cgi?id=101780
2997
2998         Reviewed by Brent Fulgham.
2999
3000         Clean up header includes so we don't include objc/objc-runtime.h.
3001
3002         * DumpRenderTree/mac/DumpRenderTree.mm:
3003         * DumpRenderTree/mac/ObjCPlugin.m:
3004         * TestWebKitAPI/mac/InstanceMethodSwizzler.h:
3005         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3006
3007 2012-11-27  Marja Hölttä  <marja@chromium.org>
3008
3009         Add callbacks to the FrameLoaderClient when a resource is requested
3010         https://bugs.webkit.org/show_bug.cgi?id=92761
3011
3012         Reviewed by Adam Barth.
3013
3014         In Chromium, when an extension script cancels a network
3015         request (which happens out of process), we'd like to
3016         notify content scripts running on the current page about
3017         which elements failed to load because the requests were
3018         cancelled (as opposed to e.g. the network request just
3019         didn't work). Since the resource request itself does not
3020         carry any information what DOM element is was made for,
3021         currently a content script has to search the DOM tree and
3022         guess which requests will be cancelled by its counter
3023         part. By adding these callbacks, the embedder can make
3024         this connection explictly.
3025
3026         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3027         (DRTTestRunner::DRTTestRunner):
3028         (DRTTestRunner::dumpResourceRequestCallbacks):
3029         (DRTTestRunner::reset):
3030         * DumpRenderTree/chromium/DRTTestRunner.h:
3031         (DRTTestRunner):
3032         (DRTTestRunner::setShouldDumpResourceRequestCallbacks):
3033         (DRTTestRunner::shouldDumpResourceRequestCallbacks):
3034         * DumpRenderTree/chromium/TestShell.h:
3035         (TestShell::shouldDumpResourceRequestCallbacks):
3036         * DumpRenderTree/chromium/WebViewHost.cpp:
3037         (WebViewHost::willRequestResource):
3038         * DumpRenderTree/chromium/WebViewHost.h:
3039         (WebViewHost):
3040
3041 2012-11-27  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3042
3043         [GStreamer] Verify if GStreamer was previously initialized
3044         https://bugs.webkit.org/show_bug.cgi?id=103151
3045
3046         Reviewed by Philippe Normand.
3047
3048         This patch adds the gst_init() in GtkLauncher, so we can add the
3049         GStreamer options in the command line through
3050         gst_init_get_option_group().
3051
3052         This approach is not valid for MiniBrowser because it uses WebKit2,
3053         where the GStreamer backend lives in the web process, which is
3054         different from the UI process.
3055
3056         * GNUmakefile.am:
3057         * GtkLauncher/main.c:
3058         (main):
3059
3060 2012-11-27  Andras Becsi  <andras.becsi@digia.com>
3061
3062         [Qt] Fix the build with new Qt5 hash
3063         https://bugs.webkit.org/show_bug.cgi?id=103406
3064
3065         Reviewed by Csaba Osztrogonác.
3066
3067         Remove references to deprecated QApplication::GuiServer which
3068         has been removed, and use QStyleFactory::create instead of
3069         instantiating a QWindowsStyle directly since it is about to
3070         become an internal class.
3071
3072         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3073         (main):
3074         * QtTestBrowser/qttestbrowser.cpp:
3075         (LauncherApplication::LauncherApplication):
3076         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3077         (WTR::InjectedBundle::platformInitialize):
3078
3079 2012-11-27  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3080
3081         [style] Add a style-check for enum-member names
3082         https://bugs.webkit.org/show_bug.cgi?id=103157
3083
3084         Reviewed by Daniel Bates.
3085
3086         * Scripts/webkitpy/style/checkers/cpp.py:
3087         (_EnumState):
3088         (_EnumState.__init__):
3089         (_EnumState.process_clean_line):
3090         (check_enum_casing):
3091         (check_style):
3092         (process_line):
3093         (_process_lines):
3094         (CppChecker):
3095         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3096         (NoNonVirtualDestructorsTest.test_enum_casing):
3097         (NoNonVirtualDestructorsTest.test_internal_braces.Foo):
3098
3099 2012-11-26  Ryuan Choi  <ryuan.choi@gmail.com>
3100
3101         [EFL][jhbuild] Disable unnecessary options of elementary module
3102         https://bugs.webkit.org/show_bug.cgi?id=103360
3103
3104         Reviewed by Gyuyoung Kim.
3105
3106         When jhbuild configures elementary, unnecessary options may be enabled by
3107         user installed modules and it causes build break.
3108
3109         * efl/jhbuild.modules:
3110         Added --disable-emap --disable-ethumb --disable-eweather to elementary.
3111
3112 2012-11-26  Varun Jain  <varunjain@chromium.org>
3113
3114         LongPress and LongTap gestures should start drag/drop and open context menu respectively.
3115         https://bugs.webkit.org/show_bug.cgi?id=101545
3116
3117         Reviewed by Antonio Gomes.
3118
3119         For LongPress, we simulate drag by sending a mouse down and mouse drag
3120         events. If a drag is not started (because maybe there is no draggable
3121         element), then we show context menu instead (which is the current
3122         behavior for LongPress). For LongTap, we use the existing functions that
3123         LongPress uses to summon the context menu. LongPress initiated drag and
3124         drop can be enabled/disabled by the platform using the Setting
3125         touchDragDropEnabled which is disabled by default.
3126
3127         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3128         (WebTestRunner):
3129         (WebTestRunner::EventSender::EventSender):
3130         (WebTestRunner::EventSender::gestureLongTap):
3131         (WebTestRunner::EventSender::gestureEvent):
3132         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
3133         (EventSender):
3134         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3135         (WebTestRunner::TestRunner::TestRunner):
3136         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
3137         (WebTestRunner):
3138         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3139         (TestRunner):
3140
3141 2012-11-26  Christophe Dumez  <christophe.dumez@intel.com>
3142
3143         [EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
3144         https://bugs.webkit.org/show_bug.cgi?id=103224
3145
3146         Reviewed by Laszlo Gombos.
3147
3148         Add --local-storage command line argument to MiniBrowser to
3149         explicitely disable HTML5 local storage functionality. This
3150         is useful for testing purposes.
3151
3152         * MiniBrowser/efl/main.c:
3153         (window_create):
3154         (elm_main):
3155
3156 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
3157
3158         Remove use of deprecated logging from most of webkitpy.tool
3159         https://bugs.webkit.org/show_bug.cgi?id=103180
3160
3161         Reviewed by Dirk Pranke.
3162
3163         Remove calls to log and error methods of the deprecated_logging module, replacing them
3164         by using Python's Logger objects. This patch covers the switch in all of webkitpy.tool
3165         except the QueueEngine.
3166
3167         Unit tests are adjusted for these changes, moving output from expected stderr to expected logs.
3168
3169         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3170         (MockCommitQueue.run_command):
3171         (MockCommitQueue.command_passed):
3172         (MockCommitQueue.command_failed):
3173         (MockCommitQueue.report_flaky_tests):
3174         (MockCommitQueue.archive_last_test_results):
3175         (CommitQueueTaskTest._run_through_task):
3176         (CommitQueueTaskTest.test_success_case):
3177         (test_fast_success_case):
3178         (test_clean_failure):
3179         (test_update_failure):
3180         (test_apply_failure):
3181         (test_validate_changelog_failure):
3182         (test_build_failure):
3183         (test_red_build_failure):
3184         (test_flaky_test_failure):
3185         (test_failed_archive):
3186         (test_double_flaky_test_failure):
3187         (test_test_failure):
3188         (test_red_test_failure):
3189         (test_very_red_tree_retry):
3190         (test_red_tree_patch_rejection):
3191         (test_land_failure):
3192         * Scripts/webkitpy/tool/bot/feeders.py:
3193         (CommitQueueFeeder._update_work_items):
3194         (EWSFeeder.feed):
3195         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3196         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3197         (LayoutTestResultsReader.archive):
3198         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3199         (test_archive_last_layout_test_results):
3200         * Scripts/webkitpy/tool/bot/sheriff.py:
3201         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3202         (AbstractSequencedCommand.execute):
3203         * Scripts/webkitpy/tool/commands/commandtest.py:
3204         (CommandsTest.assert_execute_outputs):
3205         * Scripts/webkitpy/tool/commands/download.py:
3206         (AbstractPatchProcessingCommand._process_patch.execute):
3207         (ProcessBugsMixin._fetch_list_of_patches_to_process):
3208         (ProcessURLsMixin._fetch_list_of_patches_to_process):
3209         (AbstractRolloutPrepCommand._commit_info):
3210         * Scripts/webkitpy/tool/commands/download_unittest.py:
3211         (AbstractRolloutPrepCommandTest.test_commit_info):
3212         (DownloadCommandsTest.test_build):
3213         (DownloadCommandsTest.test_build_and_test):
3214         (test_apply_attachment):
3215         (test_apply_from_bug):
3216         (test_apply_watch_list):
3217         (test_land):
3218         (test_land_red_builders):
3219         (test_check_style):
3220         (test_build_attachment):
3221         (test_land_attachment):
3222         (test_land_from_bug):
3223         (test_land_from_url):
3224         (test_prepare_rollout):
3225         (test_create_rollout):
3226         (test_create_rollout_resolved):
3227         (test_rollout):
3228         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3229         (AbstractEarlyWarningSystem.handle_script_error.does):
3230         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3231         (EarlyWarningSytemTest._default_expected_stderr):
3232         (EarlyWarningSytemTest._default_expected_logs):
3233         (EarlyWarningSytemTest._test_testing_ews):
3234         * Scripts/webkitpy/tool/commands/openbugs.py:
3235         (OpenBugs.execute):
3236         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3237         (OpenBugsTest.test_args_parsing):
3238         * Scripts/webkitpy/tool/commands/perfalizer.py:
3239         (Perfalizer.handle_unexpected_error):
3240         * Scripts/webkitpy/tool/commands/queries.py:
3241         (PatchesInCommitQueue.execute):
3242         (PatchesToCommitQueue._needs_commit_queue):
3243         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3244         (QueryCommandsTest.test_bugs_to_commit):
3245         (QueryCommandsTest.test_patches_in_commit_queue):
3246         (QueryCommandsTest.test_patches_to_commit_queue):
3247         * Scripts/webkitpy/tool/commands/queues.py:
3248         (AbstractQueue._cc_watchers):
3249         (AbstractQueue.begin_work_queue):
3250         (FeederQueue.handle_unexpected_error):
3251         (CommitQueue.handle_script_error):
3252         (AbstractReviewQueue.handle_unexpected_error):
3253         (AbstractReviewQueue.handle_script_error):
3254         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3255         (test_auto_retry):
3256         * Scripts/webkitpy/tool/commands/queuestest.py:
3257         (QueuesTest.assert_outputs):
3258         (QueuesTest._default_begin_work_queue_stderr):
3259         (QueuesTest):
3260         (QueuesTest._default_begin_work_queue_logs):
3261         (QueuesTest.assert_queue_outputs):
3262         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3263         (RollCommandsTest.test_update_chromium_deps):
3264         (test_update_chromium_deps_older_revision):
3265         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3266         (SheriffBot.handle_unexpected_error):
3267         * Scripts/webkitpy/tool/commands/stepsequence.py:
3268         (StepSequence.run_and_handle_errors):
3269         * Scripts/webkitpy/tool/commands/upload.py:
3270         (AssignToCommitter._assign_bug_to_last_patch_attacher):
3271         (AbstractPatchUploadingCommand._prepare_state):
3272         (PostCommits.execute):
3273         (MarkBugFixed._determine_bug_id_and_svn_revision):
3274         (MarkBugFixed.execute):
3275         (CreateBug.create_bug_from_commit):
3276         (CreateBug.execute):
3277         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3278         (test_obsolete_attachments):
3279         (test_land_safely):
3280         (test_mark_bug_fixed):
3281         * Scripts/webkitpy/tool/multicommandtool.py:
3282         (Command.check_arguments_and_execute):
3283         (MultiCommandTool.main):
3284         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
3285         (CommandTest.test_required_arguments):
3286         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:
3287         (AddSvnMimetypeForPng.run):
3288         * Scripts/webkitpy/tool/steps/applypatch.py:
3289         (ApplyPatch.run):
3290         * Scripts/webkitpy/tool/steps/build.py:
3291         (Build.run):
3292         * Scripts/webkitpy/tool/steps/checkstyle.py:
3293         * Scripts/webkitpy/tool/steps/closebug.py:
3294         (CloseBug.run):
3295         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
3296         (CloseBugForLandDiff.run):
3297         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3298         (CloseBugForLandDiffTest.test_empty_state):
3299         * Scripts/webkitpy/tool/steps/commit.py:
3300         (Commit.run):
3301         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3302         (CommitTest._test_check_test_expectations):
3303         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
3304         (EnsureLocalCommitIfNeeded.run):
3305         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
3306         (ObsoletePatches.run):
3307         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3308         (PrepareChangeLog.run):
3309         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3310         (ReopenBugAfterRollout.run):
3311         * Scripts/webkitpy/tool/steps/runtests.py:
3312         (RunTests.run):
3313         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3314         (RunTestsTest.test_webkit_run_unit_tests):
3315         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3316         (StepsTest.test_update_step):
3317         (StepsTest.test_runtests_args):
3318         * Scripts/webkitpy/tool/steps/update.py:
3319         (Update.run):
3320         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3321         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
3322         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_multipatch_bug):
3323         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3324         (UpdateChangeLogsWithReviewer._guess_reviewer_from_bug):
3325         (UpdateChangeLogsWithReviewer.run):
3326         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
3327         (UpdateChromiumDEPS._validate_revisions):
3328         (UpdateChromiumDEPS.run):
3329         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3330         (ValidateChangeLogs._check_changelog_diff):
3331         (ValidateChangeLogs.run):
3332         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3333         (ValidateChangeLogsTest._assert_start_line_produces_output):
3334         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3335         (ValidateReviewer.run):
3336
3337 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
3338
3339         Coverage testing in webkitpy should omit some paths
3340         https://bugs.webkit.org/show_bug.cgi?id=103267
3341
3342         Reviewed by Dirk Pranke.
3343
3344         Omit testing coverage of any file under /usr directory and any file
3345         that is of third party origin and was autoinstalled.
3346
3347         * Scripts/webkitpy/test/main.py:
3348         (Tester._run_tests):
3349
3350 2012-11-26  Jaehun Lim  <ljaehun.lim@samsung.com>
3351
3352         Text Autosizing: Add Text Autosizing APIs for WK2
3353         https://bugs.webkit.org/show_bug.cgi?id=100633
3354
3355         Reviewed by Sam Weinig.
3356
3357         Add test cases for Text Autosizing in WKPreferences.
3358
3359         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3360         (TestWebKitAPI::TEST):
3361
3362 2012-11-26  Pierre Rossi  <pierre.rossi@gmail.com>
3363
3364         [Qt] REGRESSION(r135575): It made all tests assert
3365         https://bugs.webkit.org/show_bug.cgi?id=103169
3366
3367         Reviewed by Simon Hausmann.
3368
3369         This fixes another regression introduced in r135515:
3370         initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
3371         since it can be called from WebKit2 to initialize QStyle for testing.
3372         This would then lead to things such as PlatformStrategies being
3373         initialized twice.
3374
3375         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Also propagate the change to DRT this time.
3376         (WebCore::DumpRenderTree::DumpRenderTree):
3377
3378 2012-11-24  Zan Dobersek  <zandobersek@gmail.com>
3379
3380         Add the --order option to NRWT
3381         https://bugs.webkit.org/show_bug.cgi?id=102229
3382
3383         Reviewed by Dirk Pranke.
3384
3385         The --order option controls in what order the gathered tests will be run.
3386         There are 3 options:
3387         - natural, the tests are sorted in natural order,
3388         - random, the tests are sorted in random order,
3389         - none, the tests are kept in the order in which they were specified through
3390         arguments or the test list.
3391
3392         The natural option is the default one and maintains the current behavior.
3393
3394         The none option is primarily intended to be used with the --test-list option,
3395         with the test list file expected to list specific test names.
3396         When a directory is specified as one of the paths from under which tests should
3397         be gathered and the none option is used, that path will expand to all the tests
3398         under it, with these tests sorted in the natural order.
3399
3400         Using --order=random duplicated the behavior of the --randomize-order option, so
3401         the latter is removed.
3402
3403         This patch also incorporates the change with which makes it is possible to specify
3404         a test via arguments or the test list multiple tests and then have the test run
3405         that many times.
3406
3407         * Scripts/webkitpy/common/find_files.py:
3408         (find): Accept an optional sorting key that is used to sort files found in the directories
3409         that the given paths specify.
3410         (_normalized_find): Both paths that are then searched for the tests and the tests that
3411         were found are now kept in lists. This makes it possible to run a test multiple times
3412         by specifying it multiple times through arguments or the test list file.
3413         (_normalized_find.sort_by_directory_key):
3414         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3415         (LayoutTestFinder.find_tests): Keep the paths where we should search for tests in a list.
3416         (LayoutTestFinder.skip_tests): Subtracting from a set of paths is necessary.
3417         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3418         (LayoutTestRunner.__init__): The Sharder class no longer needs a test path separator.
3419         (Sharder.__init__): Ditto.
3420         (Sharder._resize_shards):
3421         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3422         (SharderTests.get_shards): Modify the Shader initializing as required.
3423         (SharderTests.test_multiple_locked_shards): The natural sorting and test name key unit tests
3424         are now moved to the base Port unit tests.
3425         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3426         (Manager._prepare_lists): Keep the test names in a list. Order that list as specified by
3427         the new --order option.
3428         * Scripts/webkitpy/layout_tests/port/base.py:
3429         (Port.tests): This method should now return a list of all the tests found in the specified
3430         paths.
3431         (Port._real_tests): A list is required, so no conversion to a set is made.
3432         (Port):
3433         (Port.test_key): Place this method here for now, but it should really move into a separate
3434         module.
3435         (Port._natural_sort_key): Ditto.
3436         (Port._natural_sort_key.tryint):
3437         (Port._virtual_tests): A list is required, so the function now operates on that rather than
3438         on a set.
3439         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3440         (PortTest.test_find_with_skipped_directories_2): Adjust the test case to check for an empty
3441         list rather than an empty set.
3442         (PortTest.test_dont_require_http_server):
3443         (NaturalCompareTest): The natural sorting unit tests are placed here for now.
3444         (NaturalCompareTest.assert_cmp):
3445         (NaturalCompareTest.test_natural_compare):
3446         (KeyCompareTest): The test name key unit tests are placed here for now.
3447         (KeyCompareTest.assert_cmp):
3448         (KeyCompareTest.test_test_key):
3449         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3450         (parse_args): Remove the --randomize-order option, it's now possible to replicate its behavior
3451         by using --order=random.
3452         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Add unit tests covering
3453         various aspects of this change.
3454         (MainTest.test_natural_order):
3455         (MainTest):
3456         (MainTest.test_natural_order_test_specified_multiple_times):
3457         (MainTest.test_random_order):
3458         (MainTest.test_random_order_test_specified_multiple_times):
3459         (MainTest.test_no_order):
3460         (MainTest.test_no_order_test_specified_multiple_times):
3461         (MainTest.test_no_order_with_directory_entries_in_natural_order):
3462         * Scripts/webkitpy/tool/commands/queries.py:
3463         (PrintExpectations.execute): Operate on a set of tests when printing out expectations.
3464
3465 2012-11-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3466
3467         Unreviewed, rolling out r135600.
3468         http://trac.webkit.org/changeset/135600
3469         https://bugs.webkit.org/show_bug.cgi?id=103173
3470
3471         It made EFL API test is failed (Requested by gyuyoung_mbp on
3472         #webkit).
3473
3474         * TestWebKitAPI/PlatformEfl.cmake:
3475         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3476         (TestWebKitAPI::Util::sleep):
3477         * TestWebKitAPI/efl/PlatformWebView.cpp:
3478
3479 2012-11-23  Alexis Menard  <alexis@webkit.org>
3480
3481         [CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
3482         https://bugs.webkit.org/show_bug.cgi?id=102104
3483
3484         Reviewed by Julien Chaffraix.
3485
3486         Protect the new feature behind a feature flag.
3487
3488         * Scripts/webkitperl/FeatureList.pm:
3489         * qmake/mkspecs/features/features.pri:
3490
3491 2012-11-23  Mario Sanchez Prada  <mario@webkit.org>
3492
3493         Unreviewed. Update my e-mail address.
3494
3495         * Scripts/webkitpy/common/config/committers.py:
3496
3497 2012-11-23  Mateusz Leszko  <m.leszko@samsung.com>
3498
3499         [EFL][GTK] Adapt accessibility feature to WebKitTestRunner.
3500         https://bugs.webkit.org/show_bug.cgi?id=100757
3501
3502         Reviewed by Laszlo Gombos.
3503
3504         Allow to build accessibility feature in WebkitTestRunner for EFL Platform.
3505         Updating CMake files due to changes from Bug 99011.
3506
3507         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3508         (WTR::AccessibilityController::AccessibilityController):
3509         (WTR):
3510         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3511         (AccessibilityController):
3512         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3513         (WTR):
3514         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3515         (AccessibilityUIElement):
3516         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: - Removed gtk/gtk.h dependency.
3517         * WebKitTestRunner/PlatformEfl.cmake: - Adding atk includes.
3518
3519 2012-11-16  Yury Semikhatsky  <yurys@chromium.org>
3520
3521         Memory instrumentation: extract MemoryObjectInfo declaration into a separate file
3522         https://bugs.webkit.org/show_bug.cgi?id=102510
3523
3524         Reviewed by Pavel Feldman.
3525
3526         Added missing includes.
3527
3528         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3529
3530 2012-11-23  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3531
3532         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
3533         https://bugs.webkit.org/show_bug.cgi?id=103123
3534
3535         Reviewed by Kenneth Rohde Christiansen.
3536
3537         Add support for PlatformWebView::simulateSpacebarKeyPress() and enable
3538         WebKit2 API test ResponsivenessTimerDoesntFireEarly.
3539
3540         * TestWebKitAPI/PlatformEfl.cmake: Enable ResponsivenessTimerDoesntFireEarly
3541         test.
3542         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3543         (TestWebKitAPI::Util::sleep): Use usleep() instead of sleep since the
3544         test case is passing 0.5 seconds to sleep.
3545         * TestWebKitAPI/efl/PlatformWebView.cpp:
3546         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Implemented.
3547         (TestWebKitAPI):
3548
3549 2012-11-23  Wojciech Bielawski  <w.bielawski@samsung.com>
3550
3551         [WK2][WKTR] WebKitTestRunner needs eventSender.contextClick()
3552         https://bugs.webkit.org/show_bug.cgi?id=86881
3553
3554         Reviewed by Kenneth Rohde Christiansen.
3555
3556         eventSender object extended with contextClick() method in WebKitTestRunner.
3557         contextClick() method returns an array of menu items objects with field 'title' containing title of single
3558         context menu entry. According to some tests menu items objects shall also support 'click()' method, but it's not
3559         delivered in this patch.
3560
3561         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3562         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3563         (WTR::EventSendingController::contextClick):
3564         (WTR):
3565         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3566         (EventSendingController):
3567
3568 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
3569
3570         [Qt] Compiling against QtWebkit API requires QT_DLL to be defined
3571         https://bugs.webkit.org/show_bug.cgi?id=102942
3572
3573         Reviewed by Tor Arne Vestbø.
3574
3575         Remove the requirement of having QT_DLL defined in order for the QWEBKIT_EXPORT
3576         macro to be defined as Q_DECL_IMPORT. Instead unify the export macro definition
3577         to follow the same rules as other Qt 5 modules, with the exception that instead of
3578         QT_BUILD_WEBKIT_LIB we continue to use BUILDING_WEBKIT, because that's used also
3579         in other cross-platform header files to determine the correct meaning of export
3580         macros.
3581
3582         * qmake/mkspecs/features/default_post.prf:
3583         * qmake/mkspecs/features/win32/default_post.prf:
3584
3585 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
3586
3587         [Qt] QWebPage::shouldInterruptJavaScript should be virtual in Qt 5
3588         https://bugs.webkit.org/show_bug.cgi?id=103111
3589
3590         Reviewed by Kenneth Rohde Christiansen.
3591
3592         This function was added as a slot during Qt 4.x times because adding
3593         virtual functions breaks binary compatibility. This constraint is gone
3594         with the initial release of WebKit with Qt 5, and therefore we can
3595         make it virtual now.
3596
3597         The change is fully source compatible as existing "re-implementations"
3598         as slots will now be called through it being a virtual function. They
3599         become unused slots.
3600
3601         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3602         (WebCore::WebPage::shouldInterruptJavaScript):
3603         (WebPage):
3604         * QtTestBrowser/webpage.h:
3605         (WebPage):
3606
3607 2012-11-22  Peter Beverloo  <peter@chromium.org>
3608
3609         [Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
3610         https://bugs.webkit.org/show_bug.cgi?id=103065
3611
3612         Reviewed by Dirk Pranke.
3613
3614         This addresses two further reliability issues in the Android test running
3615         scripts. Firstly, the run_tests.py script needs to have the --exit_code
3616         argument passed in order to return non-zero codes, which we need for the
3617         build master to distinguish failures from successful runs.
3618
3619         Secondly, it modifies the layout test runner to briefly wait (through
3620         the wait-for-device command) after requesting a device to switch to root
3621         mode. Without this waiting period, commands might get lost and thereby
3622         unexpectedly fail.
3623
3624         * Scripts/run-api-tests: