1 2014-09-23 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
3 Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
4 https://bugs.webkit.org/show_bug.cgi?id=137026
6 Reviewed by Csaba Osztrogonác.
8 * BuildSlaveSupport/wait-for-SVN-server.py:
9 (getLatestSVNRevision):
12 2014-09-23 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
14 Remove unlinkZeroFiles from build-webkit
15 https://bugs.webkit.org/show_bug.cgi?id=137018
17 Reviewed by Csaba Osztrogonác.
19 * Scripts/build-webkit:
20 (unlinkZeroFiles): Deleted.
22 2014-09-23 Rohit Kumar <kumar.rohit@samsung.com>
24 [GTK] Minibrowser : Add keyboard support for stop page load
25 https://bugs.webkit.org/show_bug.cgi?id=136857
27 Reviewed by Philippe Normand.
29 Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
31 * MiniBrowser/gtk/BrowserWindow.c:
32 (stopPageLoad): Callback to stop page load.
33 (browser_window_init):
35 2014-09-22 Rohit Kumar <kumar.rohit@samsung.com>
37 [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
38 https://bugs.webkit.org/show_bug.cgi?id=136813
40 Reviewed by Gyuyoung Kim.
42 Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
44 * MiniBrowser/efl/main.c:
47 2014-09-22 Daniel Bates <dabates@apple.com>
49 [Cocoa] Add UI delegate callback when window.close() is called
50 https://bugs.webkit.org/show_bug.cgi?id=137008
51 <rdar://problem/17801001>
53 Reviewed by Anders Carlsson.
55 Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
56 for window opened via JavaScript (i.e. window.open()).
58 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
59 * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
60 * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
62 2014-09-22 Youenn Fablet <youennf@gmail.com>
64 W3C importer should import html files within resources folders
65 https://bugs.webkit.org/show_bug.cgi?id=127548
67 Reviewed by Ryosuke Niwa.
69 Import HTML files in any folder named "resources" even if file is not detected as a HTML test file
71 * Scripts/webkitpy/w3c/test_importer.py:
72 (TestImporter.find_importable_tests):
74 2014-09-22 Carlos Garcia Campos <cgarcia@igalia.com>
76 [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
77 https://bugs.webkit.org/show_bug.cgi?id=136998
79 Reviewed by Philippe Normand.
81 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
82 (testWebViewCanShowMIMEType): Remove the check of PDF as
83 unsupported MIME type.
85 2014-09-22 Carlos Garcia Campos <cgarcia@igalia.com>
87 Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
89 In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
90 to Source/WebCore/platform/gtk/po/ but the rule was not updated.
92 * Scripts/webkitpy/common/config/watchlist: Use
93 Source/WebCore/platform/gtk/po/ as directory to watch for
94 WebKitGTKTranslations rule and add berto and myself to the list of
97 2014-09-22 Ryuan Choi <ryuan.choi@gmail.com>
99 Fix syntaxError in watchlist since r173594
100 https://bugs.webkit.org/show_bug.cgi?id=136996
102 Reviewed by Philippe Normand.
104 * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
106 2014-09-20 Sam Weinig <sam@webkit.org>
108 Make possible HashSet<std::unique_ptr<>>
109 https://bugs.webkit.org/show_bug.cgi?id=136166
111 Reviewed by Darin Adler.
113 * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
114 * TestWebKitAPI/Counters.cpp: Added.
115 * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
116 Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
117 helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
120 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
123 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
124 Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
126 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
127 Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
129 2014-09-21 Youenn Fablet <youenn.fablet@crf.canon.fr>
131 run-webkit-tests should count tests submitted as absolute paths once
132 https://bugs.webkit.org/show_bug.cgi?id=136848
134 Reviewed by Darin Adler.
136 * Scripts/webkitpy/port/base.py:
137 (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
139 2014-09-19 Joseph Pecoraro <pecoraro@apple.com>
141 JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
142 https://bugs.webkit.org/show_bug.cgi?id=136974
144 Reviewed by Chris Fleizach.
146 * DumpRenderTree/AccessibilityUIElement.cpp:
147 (selectTextWithCriteriaCallback):
148 Be sure to release the string if it was allocated.
150 2014-09-19 Alexey Proskuryakov <ap@apple.com>
152 build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
153 https://bugs.webkit.org/show_bug.cgi?id=136966
155 Reviewed by Daniel Bates.
157 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
158 (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
160 2014-09-19 Gyuyoung Kim <gyuyoung.kim@samsung.com>
162 [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
163 https://bugs.webkit.org/show_bug.cgi?id=136917
165 Reviewed by Darin Adler.
167 Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
169 * TestWebKitAPI/PlatformEfl.cmake:
170 * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
171 (TestWebKitAPI::didFinishLoadForFrame):
172 (TestWebKitAPI::TEST):
173 * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
175 2014-09-19 Daniel Bates <dabates@apple.com>
177 Always assume internal SDK when building configuration Production
178 https://bugs.webkit.org/show_bug.cgi?id=136925
179 <rdar://problem/18362399>
181 Reviewed by Dan Bernstein.
183 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
184 * MiniBrowser/Configurations/DebugRelease.xcconfig:
185 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
186 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
188 2014-09-19 Youenn Fablet <youenn.fablet@crf.canon.fr>
190 WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
191 https://bugs.webkit.org/show_bug.cgi?id=136847
193 Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
195 Reviewed by Alexey Proskuryakov.
197 * WebKitTestRunner/TestController.cpp:
198 (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
200 2014-09-19 Carlos Garcia Campos <cgarcia@igalia.com>
202 [GTK] Missing inspector files in the tarball
203 https://bugs.webkit.org/show_bug.cgi?id=136952
205 Reviewed by Gustavo Noronha Silva.
207 * gtk/manifest.txt: Add
208 Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
211 2014-09-19 Carlos Garcia Campos <cgarcia@igalia.com>
213 Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
214 https://bugs.webkit.org/show_bug.cgi?id=136632
216 Reviewed by Gustavo Noronha Silva.
218 * gtk/generate-inspector-gresource-manifest.py: Use an alias for
220 * gtk/manifest.txt: Only include the free icons in the tarball.
222 2014-09-19 Carlos Garcia Campos <cgarcia@igalia.com>
224 [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
225 https://bugs.webkit.org/show_bug.cgi?id=136943
227 Reviewed by Philippe Normand.
229 Update the script to receive the list of files from the command
230 line instead of scanning the given directories.
232 * gtk/generate-inspector-gresource-manifest.py:
233 (get_filenames): Convert filenames to use relative paths.
234 (find_all_files_in_directory): Deleted.
235 (find_all_files_in_directory.select_file): Deleted.
237 2014-09-18 Tanay C <tanay.c@samsung.com>
239 [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
240 https://bugs.webkit.org/show_bug.cgi?id=136739
242 Reviewed by Gyuyoung Kim.
244 * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
245 (on_mouse_wheel): Modified.
247 2014-09-18 Carlos Garcia Campos <cgarcia@igalia.com>
249 [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
250 https://bugs.webkit.org/show_bug.cgi?id=136923
252 Reviewed by Gustavo Noronha Silva.
254 * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
255 (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
258 2014-09-18 Csaba Osztrogonác <ossy@webkit.org>
260 Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
261 https://bugs.webkit.org/show_bug.cgi?id=136856
263 Reviewed by Darin Adler.
265 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
266 (RunLLINTCLoopTests.countFailures):
267 (Run32bitJSCTests.countFailures):
268 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
269 (RunLLINTCLoopTestsTest.test_failures):
270 (RunLLINTCLoopTestsTest.test_failure):
271 (RunLLINTCLoopTestsTest.test_no_failure):
272 (Run32bitJSCTestsTest.test_failures):
273 (Run32bitJSCTestsTest.test_failure):
274 (Run32bitJSCTestsTest.test_no_failure):
276 2014-09-18 Zan Dobersek <zdobersek@igalia.com>
278 GMainLoopSource is exposed to race conditions
279 https://bugs.webkit.org/show_bug.cgi?id=135800
281 Reviewed by Carlos Garcia Campos.
283 Add unit tests for GMainLoopSource.
285 The tests check correct behavior of GMainLoopSource in various conditions --
286 from the most simple rescheduling to rescheduling during dispatch, cancelling
287 or destroying the GMainLoopSource during dispatch, proper destroy callback
290 Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
291 State of the GMainLoopSource object (either ready, sheduled or active) is
292 thoroughly tested throughout the lifetime of that object.
294 Still missing are tests for socket callbacks, which are a bit trickier because
295 they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
296 are also not tested thoroughly, simply because it is at the moment impossible
297 to test that the objects are actually destroyed when the corresponding source
300 * TestWebKitAPI/PlatformGTK.cmake:
301 * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
302 (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
303 (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
304 (TestWebKitAPI::GMainLoopSourceTest::runLoop):
305 (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
306 (TestWebKitAPI::GMainLoopSourceTest::finish):
307 (TestWebKitAPI::GMainLoopSourceTest::source):
308 (TestWebKitAPI::TEST):
310 2014-09-17 Ryuan Choi <ryuan.choi@gmail.com>
312 Unreviewed, Update my email in contributors.json
314 * Scripts/webkitpy/common/config/contributors.json:
316 2014-09-17 Daniel Bates <dabates@apple.com>
318 Unreviewed, rolling out r173695.
320 Broke building third-party Legacy WebKit apps; will
325 "[iOS] Make WebCore build with public iOS SDK"
326 https://bugs.webkit.org/show_bug.cgi?id=136487
327 http://trac.webkit.org/changeset/173695
329 2014-09-17 Daniel Bates <dabates@apple.com>
331 [iOS] Make WebCore build with public iOS SDK
332 https://bugs.webkit.org/show_bug.cgi?id=136487
334 Reviewed by David Kilzer.
336 Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
338 * DumpRenderTree/mac/CheckedMalloc.cpp:
340 2014-09-17 Carlos Garcia Campos <cgarcia@igalia.com>
342 [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
343 https://bugs.webkit.org/show_bug.cgi?id=136889
345 Reviewed by Gustavo Noronha Silva.
347 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
348 (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
349 event was added to the events vector.
350 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
351 (loadFailedCallback): Do not assume the web view URI is the
352 failing URI when the load fails before the committed state.
353 (loadFailedWithTLSErrorsCallback): Handle the case of load failure
354 because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
355 (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
356 (LoadTrackingTest::loadFailedWithTLSErrors): Add
357 LoadFailedWithTLSErrors event to the events vector.
358 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
360 2014-09-17 Renato Nagy <rnagy@inf.u-szeged.hu>
362 [EFL][GTK] Remove WebKit1 related codes
363 https://bugs.webkit.org/show_bug.cgi?id=136853
365 Reviewed by Csaba Osztrogonác.
367 Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
370 * BuildSlaveSupport/build.webkit.org-config/config.json:
371 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
373 (BuildAndTestWebKit2Factory):
374 (CompileWebKit1Only): Deleted.
375 (CompileWebKit2Only): Deleted.
376 (BuildAndTestWebKit1OnlyFactory): Deleted.
377 (BuildAndTestWebKit2OnlyFactory): Deleted.
378 * Scripts/build-webkit:
379 * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
380 * Scripts/webkitpy/common/config/ports.py:
381 (GtkWK2Port.build_webkit_command):
382 (EflWK2Port.build_webkit_command):
383 * Scripts/webkitpy/common/config/ports_unittest.py:
384 (DeprecatedPortTest.test_gtk_wk2_port):
385 * Scripts/webkitpy/port/efl.py:
386 (EflPort.build_webkit_command):
387 * Scripts/webkitpy/port/gtk.py:
388 (GtkPort._built_libraries_path):
389 (GtkPort._search_paths):
390 (GtkPort.test_expectations_file_position):
391 (GtkPort.build_webkit_command):
392 (GtkPort.run_webkit_tests_command):
393 (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
395 2014-09-16 Daniel Bates <dabates@apple.com>
397 [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
398 https://bugs.webkit.org/show_bug.cgi?id=136862
400 Reviewed by David Kilzer.
402 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
403 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
404 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
405 IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
407 2014-09-12 Ryosuke Niwa <rniwa@webkit.org>
409 Mac queue slaves should reboot every so often
410 https://bugs.webkit.org/show_bug.cgi?id=136791
412 Reviewed by Alexey Proskuryakov.
414 Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
416 * EWSTools/start-queue-mac.sh:
418 2014-09-16 Csaba Osztrogonác <ossy@webkit.org>
420 Unreviewed gardening, skip one more tests on Windows.
422 * Scripts/run-javascriptcore-tests:
424 2014-09-16 Csaba Osztrogonác <ossy@webkit.org>
427 https://bugs.webkit.org/show_bug.cgi?id=136823
429 Reviewed by Geoffrey Garen.
431 * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
433 2014-09-16 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
435 Remove shouldAbortEarly cruft from master.cfg
436 https://bugs.webkit.org/show_bug.cgi?id=136779
438 Reviewed by Csaba Osztrogonác.
440 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
441 (ConfigureBuild.start):
442 (RunWebKitTests.start):
443 (RunWebKit2Tests.start): Deleted.
445 2014-09-15 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
447 Remove ORWT related crufts from webkitdirs.pm
448 https://bugs.webkit.org/show_bug.cgi?id=136821
450 Reviewed by Alexey Proskuryakov.
452 * Scripts/webkitdirs.pm:
453 (isPerianInstalled): Deleted.
454 (determineIPhoneSimulatorVersion): Deleted.
455 (iPhoneSimulatorVersion): Deleted.
456 (isSnowLeopard): Deleted.
458 (quitIOSSimulator): Deleted.
460 2014-09-15 Roger Fong <roger_fong@apple.com>
462 Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
463 https://bugs.webkit.org/show_bug.cgi?id=25160
465 * Scripts/run-javascriptcore-tests:
467 2014-09-15 Lucas Forschler <lforschler@apple.com>
469 Add another Apple build slave to the Mountain Lion Debug WK1 queue
471 Rubber stamped by Matt Hanson.
473 * BuildSlaveSupport/build.webkit.org-config/config.json:
475 2014-09-15 Grzegorz Czajkowski <g.czajkowski@samsung.com>
477 [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
478 https://bugs.webkit.org/show_bug.cgi?id=136822
480 Reviewed by Gyuyoung Kim.
482 In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
483 initialized as we already does it in PlatformWebView::PlatformWebView
484 calling ewk_init(). The reason for that was to ensure testing for example,
485 WTF where creating the view is not mandatory.
487 Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
488 in order to properly initalize and release EWebKit.
490 * TestWebKitAPI/PlatformEfl.cmake:
491 * TestWebKitAPI/efl/PlatformWebView.cpp:
492 (TestWebKitAPI::PlatformWebView::PlatformWebView):
493 (TestWebKitAPI::PlatformWebView::~PlatformWebView):
494 * TestWebKitAPI/efl/main.cpp:
497 2014-09-15 peavo@outlook.com <peavo@outlook.com>
499 [WinCairo] Make it easier to enable/disable GStreamer.
500 https://bugs.webkit.org/show_bug.cgi?id=135766
502 Reviewed by Brent Fulgham.
504 Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
506 * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
508 2014-09-12 Brian J. Burg <burg@cs.washington.edu>
510 Web Inspector: remind about rebaselining generator test results
511 https://bugs.webkit.org/show_bug.cgi?id=136759
513 Reviewed by Joseph Pecoraro.
515 For now, we can implement this as a watchlist message. Add watchlist
516 groups and messages for the inspector and web replay generators.
518 * Scripts/webkitpy/common/config/watchlist:
520 2014-09-12 Alexey Proskuryakov <ap@apple.com>
522 build.webkit.org/dashboard: Overlapping text when status is long
523 https://bugs.webkit.org/show_bug.cgi?id=136794
525 Reviewed by Timothy Hatcher.
527 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
528 (.status-line): Replaces height with min-height.
530 2014-09-12 Timothy Hatcher <timothy@apple.com>
532 Make Brian Burg a WebKit reviewer.
534 * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
536 2014-09-12 Alexey Proskuryakov <ap@apple.com>
538 Multiple EWS or commit bots can pick up processing of the same patch
539 https://bugs.webkit.org/show_bug.cgi?id=136793
541 Reviewed by Ryosuke Niwa.
543 Change timeout from one hour to two hours. This will let bots finish, and in the
544 unlikely event of a bot being frozen, will only delay patch processing restart by
547 * QueueStatusServer/app.yaml:
548 * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
550 2014-09-11 Andy Estes <aestes@apple.com>
552 [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
553 https://bugs.webkit.org/show_bug.cgi?id=136768
555 Reviewed by Tim Horton.
557 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
558 * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
559 (TestWebKitAPI::TEST):
561 2014-09-12 Carlos Garcia Campos <cgarcia@igalia.com>
563 REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
564 https://bugs.webkit.org/show_bug.cgi?id=136669
566 Reviewed by Antti Koivisto.
568 * Scripts/run-gtk-tests:
569 (TestRunner): Unskip SSL test.
571 2014-09-12 Eric Carlson <eric.carlson@apple.com>
573 Strip extraneous AVFoundation and CoreMedia logging
574 https://bugs.webkit.org/show_bug.cgi?id=136747
576 Reviewed by Jer Noble.
578 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
579 (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
581 * Scripts/webkitpy/port/base.py:
582 (Port.stderr_patterns_to_strip): Base class, empty list
584 * Scripts/webkitpy/port/driver.py:
585 (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
587 * Scripts/webkitpy/port/ios.py:
588 (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
590 * Scripts/webkitpy/port/mac.py:
591 (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
594 2014-09-11 Michael Saboff <msaboff@apple.com>
596 lldb_webkit.py:btjs doesn't work with release builds
597 https://bugs.webkit.org/show_bug.cgi?id=136760
599 Reviewed by Jer Noble.
601 If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
602 mangled name _ZN3JSC9ExecState13describeFrameEv. Also cleaned up the handling if
603 we can't get a valid result from trying either call. In that case, we fallback to
604 just showing the PC. Also added check for both entry points. If neither is found,
605 we issue a warning and output the stack trace without JavaScript annotations.
607 * lldb/lldb_webkit.py:
610 2014-09-11 Rebecca Hauck <rhauck@adobe.com>
612 webkitpy test failures from import-w3c-tests
613 https://bugs.webkit.org/show_bug.cgi?id=136752
615 Reviewed by Bem Jones-Bey.
617 This patch fixes a bug in import-w3c-tests where we were appending
618 the wrong set of files to the copy_list. This also updates the tests
619 to clear the failures introduced in the patch for bug 135929.
621 * Scripts/webkitpy/w3c/test_converter_unittest.py:
622 (W3CTestConverterTest.test_read_prefixed_property_list):
623 * Scripts/webkitpy/w3c/test_parser.py:
624 (TestParser.analyze_test):
625 (TestParser.support_files):
626 * Scripts/webkitpy/w3c/test_parser_unittest.py:
628 2014-09-10 Brent Fulgham <bfulgham@apple.com>
630 Blink merge: Speculative fix for windows run-webkit-tests hangs
631 https://bugs.webkit.org/show_bug.cgi?id=136727
633 Reviewed by Csaba Osztrogonác.
635 Merged from Blink (patch by Dirk Pranke):
636 <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
638 * Scripts/webkitpy/common/system/executive.py:
639 (Executive.kill_process):
641 2014-09-11 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
643 Added myself as a committer.
647 * Scripts/webkitpy/common/config/contributors.json:
649 2014-09-11 László Langó <llango.u-szeged@partner.samsung.com>
651 [JavaScriptCore] Fix FTL on platform EFL.
652 https://bugs.webkit.org/show_bug.cgi?id=133571
654 Reviewed by Filip Pizlo.
656 * efl/install-dependencies: Revert r169181.
657 * efl/jhbuild.modules: Clone and build a custom branch.
658 This branch contains some fix for FTL of platform EFL.
659 The branch is a fork of llvm r206311.
661 2014-09-10 Tanay C <tanay.c@samsung.com>
663 [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
664 https://bugs.webkit.org/show_bug.cgi?id=136698
666 Reviewed by Gyuyoung Kim.
668 * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
669 (on_mouse_wheel): Added.
673 2014-09-10 Rohit Kumar <kumar.rohit@samsung.com>
675 [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
676 https://bugs.webkit.org/show_bug.cgi?id=136284
678 Reviewed by Gyuyoung Kim.
680 * MiniBrowser/efl/main.c:
683 2014-09-10 Rebecca Hauck <rhauck@adobe.com>
685 import-w3c-tests doesn't handle relative paths to support files in ref files correctly
686 https://bugs.webkit.org/show_bug.cgi?id=135929
688 Reviewed by Bem Jones-Bey.
690 The recent refactor of the W3C test repo falsified a bunch of assmumptions that
691 were made when this script was originally written with respect to relative paths
692 in ref files. This patch updates import-w3c-tests to update paths in ref files if
693 they move relative to the test file.
696 * Scripts/webkitpy/w3c/test_converter.py:
697 (convert_for_webkit):
698 (_W3CTestConverter.__init__):
699 (_W3CTestConverter.convert_reference_relpaths):
700 (_W3CTestConverter.convert_style_data):
701 (_W3CTestConverter.convert_attributes_if_needed):
702 * Scripts/webkitpy/w3c/test_importer.py:
703 (TestImporter.find_importable_tests):
704 (TestImporter.import_tests):
705 * Scripts/webkitpy/w3c/test_parser.py:
706 (TestParser.load_file):
707 (TestParser.analyze_test):
708 (TestParser.support_files):
710 2014-09-10 Michael Catanzaro <mcatanzaro@igalia.com>
712 [GTK] allow overwriting destination of download
713 https://bugs.webkit.org/show_bug.cgi?id=136372
715 Reviewed by Carlos Garcia Campos.
717 * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
718 (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
719 (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
720 (createFileAtDestination): Added
721 (testDownloadOverwriteDestinationAllowed): Added
722 (testDownloadOverwriteDestinationDisallowed): Added
723 (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
724 (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
725 (beforeAll): New tests
727 2014-08-05 David Farler <dfarler@apple.com>
729 iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
730 https://bugs.webkit.org/show_bug.cgi?id=135551
732 Reviewed by Daniel Bates.
734 Prevent printing invalid Unicode strings going to stderr.
735 Also, make filesystem.py more tolerant about receiving
736 Unicode (encoded as UTF-8) when writing to files, in the
737 rare case that an NSError description will make it to
738 stderr, such as -[LTRelayController createUniqueApp].
740 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
741 (-[LTRelayController launchSimulator]): Removed.
742 (-[LTRelayController createUniqueApp]):
743 Don't explicitly try to uninstall the app. It is automatically handled
744 when installing an app with the same bundle identifier.
745 (-[LTRelayController start]):
746 (-[LTRelayController bootDevice]): Removed.
747 The device already boots as a part of starting the simulator. Attempting
748 to boot a second time may cause spurious stderr output.
749 * Scripts/webkitpy/port/driver.py:
750 (IOSSimulatorDriver._setup_environ_for_driver):
751 Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
752 Open the iOS Simulator once instead of the LayoutTestRelay trying
754 * Scripts/webkitpy/port/ios.py:
755 (IOSSimulatorPort._get_crash_log):
756 Make sure stderr is at least an empty string.
758 (IOSSimulatorPort.developer_dir):
759 New property for setting up DEVELOPER_DIR in the driver environment.
761 2014-09-09 Dan Bernstein <mitz@apple.com>
763 Clean up the MiniBrowser Xcode project
764 https://bugs.webkit.org/show_bug.cgi?id=136684
766 Reviewed by Tim Horton.
768 * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
769 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
770 WebKit2.framework. Upgraded project file version.
772 2014-09-09 Daniel Bates <dbates@webkit.org>
774 svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
775 https://bugs.webkit.org/show_bug.cgi?id=136379
777 Reviewed by David Kilzer.
779 Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
780 a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
781 and sets a property on F (say, the executable bit).
784 (patch): Only add file if the diff has text chunks.
785 * Scripts/svn-unapply:
786 (patch): Only delete added file if the diff has text chunks.
788 2014-09-09 Carlos Alberto Lopez Perez <clopez@igalia.com>
790 [GTK] Unreviewed GTK gardening.
792 * Scripts/run-gtk-tests:
793 (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
795 2014-09-09 Christophe Dumez <cdumez@apple.com>
797 Update my email in contributors.json
798 https://bugs.webkit.org/show_bug.cgi?id=136671
800 Reviewed by Andreas Kling.
802 * Scripts/webkitpy/common/config/contributors.json:
804 2014-09-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
806 [EFL] Enable fixed layout by default
807 https://bugs.webkit.org/show_bug.cgi?id=136607
809 Reviewed by Csaba Osztrogonác.
811 Fixed layout is being used by Tizen platform by default. However, the feature
812 has still many defects now. So, we need to enable it by default, then should fix
815 * MiniBrowser/efl/main.c:
817 2014-09-08 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
820 https://bugs.webkit.org/show_bug.cgi?id=136571
822 Reviewed by Darin Adler.
824 * Scripts/webkitperl/FeatureList.pm:
826 2014-09-08 Alexey Proskuryakov <ap@apple.com>
828 Dashboard metrics should ignore commits that didn't trigger builds
829 https://bugs.webkit.org/show_bug.cgi?id=136618
831 Reviewed by Darin Adler.
833 Commits that didn't trigger builds are ones like ChangeLog updates, patches for
834 other platforms etc. It does not make sense to count wait time for these, as it
835 can be arbitrarily long.
837 The new algorithm is much slower asymptotically, but it's OK, computers are fast.
839 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
840 (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
842 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
843 We used to walk the timeline to see which revisions are fully tested, but that's not
844 correct. A revision that's only tested by a subset of queues finishes independently
845 of another that's tested by another subset. Now, we just search for the answer for
846 each revision individually.
848 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
849 (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
850 the analyzer now reports. Removed best time, which is more confusing than meaningful.
852 2014-09-08 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
854 Remove EWebLauncher from webkitdirs.pm
855 https://bugs.webkit.org/show_bug.cgi?id=136622
857 Reviewed by Gyuyoung Kim.
859 * Scripts/webkitdirs.pm:
862 2014-09-06 Sam Weinig <sam@webkit.org>
864 XPCPtr should be converted into an all purpose smart pointer for os_objects
865 https://bugs.webkit.org/show_bug.cgi?id=136602
867 Reviewed by Darin Adler.
869 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
870 * TestWebKitAPI/Tests/WTF/darwin: Added.
871 * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
872 Add basic unit tests for OSObjectPtr.
874 2014-09-06 Saam Barati <saambarati1@gmail.com>
876 Unreviewed. Add myself as a committer.
878 * Scripts/webkitpy/common/config/contributors.json:
880 2014-09-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
882 Unreviewed, EFL build fix when SHARED_CORE is on.
884 * TestWebKitAPI/PlatformEfl.cmake:
886 2014-09-05 Lucas Forschler <lforschler@apple.com>
888 <https://webkit.org/b/136586> Add bots to Apple build/test queues
890 Reviewed by Daniel Bates.
892 * BuildSlaveSupport/build.webkit.org-config/config.json:
894 2014-09-05 Alexey Proskuryakov <ap@apple.com>
896 Buildbot metrics page gives wrong results after a new bot gets added
897 https://bugs.webkit.org/show_bug.cgi?id=136516
899 Reviewed by Tim Horton.
901 Part 2: Fix elapsed times.
903 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
904 (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
905 until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
907 2014-09-05 Carlos Alberto Lopez Perez <clopez@igalia.com>
909 [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
910 https://bugs.webkit.org/show_bug.cgi?id=136562
912 Reviewed by Martin Robinson.
914 * Scripts/run-gtk-tests:
915 (TestRunner): Remove failure expectations for tests that now pass.
917 2014-09-04 Alexey Proskuryakov <ap@apple.com>
919 Dashboard metrics page wastes a lot of time sorting iterations
920 https://bugs.webkit.org/show_bug.cgi?id=136559
922 Reviewed by Tim Horton.
924 Also fixes comments here and there, and adds a missing "var".
926 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
927 (BuildbotIteration.prototype._parseData):
928 (BuildbotIteration.prototype._updateWithData):
929 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
930 (BuildbotQueue.prototype.loadAll):
931 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
932 (Analyzer.prototype._countTimes):
934 2014-09-05 Carlos Alberto Lopez Perez <clopez@igalia.com>
936 [GTK] Unreviewed GTK gardening.
938 * Scripts/run-gtk-tests:
939 (TestRunner): Skip tests failing since r173272.
941 2014-09-04 Simon Fraser <simon.fraser@apple.com>
943 Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
944 https://bugs.webkit.org/show_bug.cgi?id=136561
946 Reviewed by Tim Horton.
948 Log for calloc() and CGBitmapContextCreate() failures.
950 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
951 (createBitmapContext):
952 (createBitmapContextFromWebView):
954 2014-09-04 Andy Estes <aestes@apple.com>
956 Fix the Mac Production build after r173283.
958 * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
960 2014-09-04 Brent Fulgham <bfulgham@apple.com>
962 [Win] webkitpy test suite frequently fails to complete
963 https://bugs.webkit.org/show_bug.cgi?id=136546
965 Reviewed by Daniel Bates.
967 Properly convert the ASCII crash log produced by ntsd into
968 a unicode string as early as possible so that we handle it
969 properly when generating our logs and other test support output.
971 We were mixing ASCII/unicode strings under Windows, which was
972 causing test system failures when we processed some crash logs.
974 Also do a better job of handling garbage pid entries in the
977 * Scripts/webkitpy/common/system/crashlogs.py:
978 (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
979 creates an ASCII file. Decode it as ASCII, not 'utf-8', and
980 handle the strings as unicode from that point on.
981 * Scripts/webkitpy/port/http_lock.py:
982 (HttpLock._current_lock_pid): Add logging and handle case of
983 the current_pid failing to cleanly convert to 'int'.
984 * Scripts/webkitpy/port/win.py:
985 (WinPort): Add 64-bit architecture as a known target for the
988 2014-09-04 Andy Estes <aestes@apple.com>
990 Address additional review feedback after landing r173283.
992 Reviewed by Daniel Bates.
994 * DumpRenderTree/config.h: Removed redundant includes.
995 * TestWebKitAPI/config.h: Ditto.
996 * WebKitTestRunner/config.h: Ditto.
998 2014-09-03 Andy Estes <aestes@apple.com>
1000 [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
1001 https://bugs.webkit.org/show_bug.cgi?id=136521
1003 Reviewed by Anders Carlsson.
1005 * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
1006 * TestWebKitAPI/config.h: Ditto.
1007 * WebKitTestRunner/config.h: Ditto.
1009 2014-09-04 Alexey Proskuryakov <ap@apple.com>
1011 REGRESSION: Dashboard metrics page aggregation counts performance bots
1012 https://bugs.webkit.org/show_bug.cgi?id=136539
1014 Reviewed by Tim Horton.
1016 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1018 2014-09-04 Brent Fulgham <bfulgham@apple.com>
1020 [Win] Perl test fix.
1022 * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
1023 VersionStamp.exe tool, not just the driver script.
1025 2014-09-04 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1027 Remove CSS_FILTERS flag
1028 https://bugs.webkit.org/show_bug.cgi?id=136529
1030 Reviewed by Dirk Schulze.
1032 * Scripts/webkitperl/FeatureList.pm:
1034 2014-09-04 Commit Queue <commit-queue@webkit.org>
1036 Unreviewed, rolling out r173201.
1037 https://bugs.webkit.org/show_bug.cgi?id=136538
1039 Improves the situation but also introduces additional crashes.
1040 (Requested by zdobersek on #webkit).
1044 "GMainLoopSource is exposed to race conditions"
1045 https://bugs.webkit.org/show_bug.cgi?id=135800
1046 http://trac.webkit.org/changeset/173201
1048 2014-09-03 Alexey Proskuryakov <ap@apple.com>
1050 Buildbot metrics page gives wrong results after a new bot gets added
1051 https://bugs.webkit.org/show_bug.cgi?id=136516
1053 Part 1: Fix red/green counters. Dashboard is considered green at a given time
1054 if all the bots that ever had results before this time are green.
1056 This doesn't (and cannot) address situations where the bot gets removed and then
1057 re-added. It also gives wrong results after a bot gets removed, because it doesn't
1058 know that it was ever displayed on the dashboard.
1060 Reviewed by Darin Adler.
1062 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1063 (Analyzer.prototype._dashboardIsAllGreen):
1064 (Analyzer.prototype._updateStretchOfRedCounters):
1065 (Analyzer.prototype._countPercentageOfGreen):
1066 (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
1068 2014-09-03 Brent Fulgham <bfulgham@apple.com>
1070 [Win] Unreviewed test fix.
1072 * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
1073 test if user doesn't have the VersionStamp.exe program.
1075 2014-09-03 Dana Burkart <dburkart@apple.com>
1077 Unreviewed. Add myself as a committer.
1079 * Scripts/webkitpy/common/config/contributors.json:
1081 2014-09-03 Alexey Proskuryakov <ap@apple.com>
1083 build.webkit.org/dashboard performance popover is unstyled
1084 https://bugs.webkit.org/show_bug.cgi?id=136499
1086 Reviewed by Tim Horton.
1088 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1089 (.performance-popover):
1090 (.performance-popover .dashboard-link):
1092 2014-09-03 Saam Barati <saambarati1@gmail.com>
1094 Create tests for type profiling
1095 https://bugs.webkit.org/show_bug.cgi?id=136161
1097 Reviewed by Geoffrey Garen.
1099 Have run-javascriptcore-tests run the newly created
1100 tests for the type profiler.
1102 * Scripts/run-javascriptcore-tests:
1103 * Scripts/run-jsc-stress-tests:
1105 2014-09-03 Brent Fulgham <bfulgham@apple.com>
1107 [Win] Revise test environment for Windows build.
1108 https://bugs.webkit.org/show_bug.cgi?id=136486
1110 Reviewed by David Kilzer.
1112 The various calls to get the Safari path really only have
1113 meaning on the Mac. Other ports get access to the build
1114 and test environment separately, so remove the various
1115 checks in the Safari-specific code to simplify things.
1117 Remove some 64-bit hacks used on Windows now that the
1118 various tools know how to find the 64-bit runtime environment.
1120 * Scripts/run-javascriptcore-tests:
1121 * Scripts/webkitdirs.pm:
1122 (safariPathFromSafariBundle): Revise to expect Mac.
1123 (installedSafariPath): Ditto.
1124 (safariPath): Ditto.
1125 (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
1126 (setPathForRunningWebKitApp): Get rid of unused SafariPath
1127 argument for Windows runs.
1129 2014-09-03 Dana Burkart <dburkart@apple.com>
1131 Dashboard should show performance bots.
1132 https://bugs.webkit.org/show_bug.cgi?id=136386
1134 Reviewed by Alexey Proskuryakov.
1136 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1137 (BuildbotIteration.prototype._parseData.collectPerfTestResults):
1138 (BuildbotIteration.prototype._parseData):
1139 Support possible performance failures.
1141 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
1142 New QueueView to manage the way we present performance data.
1144 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1146 Support new 'performance' and 'performanceTestName' keys.
1149 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1150 Add performance column to the main page.
1152 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1154 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1156 Make sure everything fits on 13 inch screens.
1158 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1160 2014-09-03 Zan Dobersek <zdobersek@igalia.com>
1162 GMainLoopSource is exposed to race conditions
1163 https://bugs.webkit.org/show_bug.cgi?id=135800
1165 Reviewed by Carlos Garcia Campos.
1167 Add a unit test for GMainLoopSource that tests different
1168 types of rescheduling tasks on already-active sources.
1170 * TestWebKitAPI/PlatformGTK.cmake:
1171 * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
1172 (GMainLoopSourceTest::GMainLoopSourceTest):
1173 (GMainLoopSourceTest::~GMainLoopSourceTest):
1174 (GMainLoopSourceTest::runLoop):
1175 (GMainLoopSourceTest::finish):
1176 (GMainLoopSourceTest::source):
1177 (testGMainLoopSourceBasicRescheduling):
1178 (testGMainLoopSourceReentrantRescheduling):
1179 (testGMainLoopSourceDifferentThreadRescheduling):
1182 (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1183 (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1184 (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1185 (TestWebKitAPI::GMainLoopSourceTest::finish):
1186 (TestWebKitAPI::GMainLoopSourceTest::source):
1187 (TestWebKitAPI::TEST):
1189 2014-09-02 Simon Fraser <simon.fraser@apple.com>
1191 Make sure WK1 prefs are initialized in MiniBrowser
1192 https://bugs.webkit.org/show_bug.cgi?id=136465
1194 Reviewed by Tim Horton.
1196 Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
1197 for WK2 windows, to make sure that WebPreferences are updated (to get
1198 layer borders to work consistently).
1200 * MiniBrowser/mac/WK1BrowserWindowController.m:
1201 (-[WK1BrowserWindowController awakeFromNib]):
1203 2014-09-02 Renato Nagy <rnagy@inf.u-szeged.hu>
1205 check-webkit-style should complain about C++ comments in Platform.h
1206 https://bugs.webkit.org/show_bug.cgi?id=133802
1208 Reviewed by Csaba Osztrogonác.
1210 * Scripts/webkitpy/style/checkers/cpp.py:
1211 (check_platformh_comments):
1214 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1215 (CppStyleTest.test_platformh_comment):
1217 2014-09-02 Brendan Long <self@brendanlong.com>
1219 [Gtk] Make install-dependencies work on Arch Linux
1220 https://bugs.webkit.org/show_bug.cgi?id=136374
1222 Reviewed by Philippe Normand.
1224 * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
1226 2014-09-01 Brian J. Burg <burg@cs.washington.edu>
1228 Provide column numbers to DTrace willExecute/didExecute probes
1229 https://bugs.webkit.org/show_bug.cgi?id=136434
1231 Reviewed by Antti Koivisto.
1233 Create a directory for DTrace scripts. Add an example script that
1234 shows how to use static probes provided by JavaScriptCore's profiler.
1236 * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
1238 2014-09-01 Carlos Alberto Lopez Perez <clopez@igalia.com>
1240 [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
1241 https://bugs.webkit.org/show_bug.cgi?id=136431
1243 Reviewed by Martin Robinson.
1245 * gtk/jhbuild.modules: Disable cairo SVG testsuite.
1246 Add missing dependencies for librsvg (glib and cairo).
1248 2014-09-01 Carlos Alberto Lopez Perez <clopez@igalia.com>
1250 [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
1251 https://bugs.webkit.org/show_bug.cgi?id=136425
1253 Reviewed by Martin Robinson.
1255 * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
1257 2014-09-01 Ryuan Choi <ryuan.choi@samsung.com>
1259 Update my list of email addresses in contributors.json
1260 https://bugs.webkit.org/show_bug.cgi?id=136424
1262 Reviewed by Gyuyoung Kim.
1264 * Scripts/webkitpy/common/config/contributors.json:
1266 2014-08-30 Filip Pizlo <fpizlo@apple.com>
1268 [RJST] eager-no-cjit should really mean eager
1269 https://bugs.webkit.org/show_bug.cgi?id=136407
1271 Reviewed by Mark Hahnenberg.
1273 At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
1274 and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
1275 after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
1276 all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
1277 threshold setting that NO_CJIT_OPTIONS was currently setting
1278 (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
1279 NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
1281 Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
1283 * Scripts/run-jsc-stress-tests:
1285 2014-08-29 Daniel Bates <dabates@apple.com>
1287 [iOS] Configure Xcode to build a command line tool for the iOS Simulator
1288 https://bugs.webkit.org/show_bug.cgi?id=136388
1290 Reviewed by David Kilzer.
1292 Add a script, called configure-xcode-for-ios-development, to configure Xcode to
1293 support building a command line tool for the iOS Simulator. You must run this
1296 The script uses the xcspec files in the OS X SDK to create xcspec files in the
1297 iOS Simulator SDK with the product- and package- type definitions to build a
1298 command line tool, if applicable.
1300 * Scripts/configure-xcode-for-ios-development: Added.
1302 2014-08-29 Tim Horton <timothy_horton@apple.com>
1304 Remove Windows WebKit2 code from TestWebKitAPI
1305 https://bugs.webkit.org/show_bug.cgi?id=136385
1307 Reviewed by Alexey Proskuryakov.
1309 * TestWebKitAPI/PlatformUtilities.h:
1310 * TestWebKitAPI/PlatformWebView.h:
1311 (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
1312 * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1313 (TestWebKitAPI::TEST): Deleted.
1314 * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1315 (TestWebKitAPI::TEST):
1316 * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1317 (TestWebKitAPI::TEST):
1318 * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
1319 * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
1320 * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
1321 * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
1322 * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
1323 * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
1324 * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
1326 2014-08-29 Carlos Alberto Lopez Perez <clopez@igalia.com>
1328 [JSC] Some JSC tests are dependent on the machine time zone.
1329 https://bugs.webkit.org/show_bug.cgi?id=136363
1331 Reviewed by Filip Pizlo.
1333 * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
1334 Unskip the tests that were skipped on r99580.
1336 2014-08-29 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
1338 [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
1339 https://bugs.webkit.org/show_bug.cgi?id=135560
1341 Reviewed by Gyuyoung Kim.
1343 * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
1345 2014-08-28 Daniel Bates <dabates@apple.com>
1347 [Win] update-webkit should update auxiliary libs by default
1349 Reviewed by Dan Bernstein.
1351 The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
1352 from updating the Windows auxiliary libs by default. We should make update-webkit update the
1353 Windows auxiliary libs by default. This will make its behavior match its usage text.
1355 * Scripts/update-webkit:
1357 2014-08-28 Brian J. Burg <burg@cs.washington.edu>
1359 build-webkit --inspector-frontend tries to copy files from old inspector path
1360 https://bugs.webkit.org/show_bug.cgi?id=136346
1362 Reviewed by Timothy Hatcher.
1364 Remove the old code path for copying inspector resources. It doesn't work.
1365 Complain if this option is passed to CMake-based builds.
1367 * Scripts/build-webkit:
1368 * Scripts/webkitdirs.pm:
1369 (copyInspectorFrontendFiles): Deleted.
1371 2014-08-28 Alexey Proskuryakov <ap@apple.com>
1373 Dashboard metrics page could show longest stretch of red
1374 https://bugs.webkit.org/show_bug.cgi?id=136334
1376 Reviewed by Sam Weinig.
1378 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1379 (Analyzer.prototype._updateStretchOfRedCounters):
1380 (Analyzer.prototype._countPercentageOfGreen):
1381 When counting percentage of green, also keep track of how long the page was red.
1383 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
1384 (MetricsView.prototype._update.addDivider):
1385 (MetricsView.prototype._update.appendQueueResults):
1386 Show it in aggregate queues (can't think of a reason to have it in individual ones).
1388 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
1389 Changed to use an explicit divider element between green time and performance groups,
1390 as there are too many combinations to easily express in CSS.
1392 2014-08-28 Carlos Garcia Campos <cgarcia@igalia.com>
1394 [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
1395 https://bugs.webkit.org/show_bug.cgi?id=136248
1397 Reviewed by Gustavo Noronha Silva.
1399 Add new test case for webkit_uri_response_get_http_headers().
1401 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1402 (testURIResponseHTTPHeaders):
1406 2014-08-27 Alexey Proskuryakov <ap@apple.com>
1408 EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
1409 https://bugs.webkit.org/show_bug.cgi?id=131668
1411 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1412 (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
1414 2014-08-27 Zalan Bujtas <zalan@apple.com>
1416 Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
1417 https://bugs.webkit.org/show_bug.cgi?id=136264
1419 Reviewed by Simon Fraser.
1421 1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
1422 functions. ->snappedIntSize()/snapSizeToDevicePixel().
1423 2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
1425 Covered by existing tests.
1427 * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1428 (TestWebKitAPI::TEST): Deleted.
1430 2014-08-27 Alexey Proskuryakov <ap@apple.com>
1432 EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
1433 https://bugs.webkit.org/show_bug.cgi?id=131668
1435 Reviewed by Daniel Bates.
1437 We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
1438 to not just hardcode.
1440 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1441 (EWS.prototype.queueStatusURL): Added.
1443 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1444 (EWSQueue.prototype.get statusPageURL): Use the above function.
1445 (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
1447 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1448 (EWSQueueView.prototype.update): While at it, made a popover show up even if there
1449 are no patches in the queue. The popover has other useful information, such as charts
1450 link and bot status.
1452 2014-08-27 Alexey Proskuryakov <ap@apple.com>
1454 https://bugs.webkit.org/show_bug.cgi?id=136317
1455 Dashboard metrics page sometimes shows 0 for best time
1457 Reviewed by Tim Horton.
1459 This also affects regular dashboard display in a good way - iterations that failed
1460 due to infrastructure misbehavior will more reliably show up as yellow and not red.
1462 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1463 (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
1464 updated if we rename steps.
1465 (BuildbotIteration.prototype.get productive): Now that computation is more involved,
1467 (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
1468 that failed e.g. at downloading built archive step are not productive.
1470 2014-08-27 Brent Fulgham <bfulgham@apple.com>
1472 [Win] Unreviewed gardening.
1474 * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
1475 of logs assembled into the final build output.
1477 2014-08-27 Alexey Proskuryakov <ap@apple.com>
1479 build.webkit.org/dashboard: Add a metrics page with overall bot performance results
1480 https://bugs.webkit.org/show_bug.cgi?id=136196
1482 Reviewed by Timothy Hatcher.
1484 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
1485 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
1486 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
1487 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
1488 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
1489 A date range picker control with dependencies.
1490 There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
1491 - Fixed a bug where selected dates were not at midnight the first time a range was chosen
1492 (it didn't happen again upon re-opening the picker).
1493 - Made made style tweaks to match Dashboard UI.
1495 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1496 Don't create objects that are not needed by the given app, and thus are not loaded at all.
1498 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
1499 Math to count all the things. Only supports open source tree and trunk at the moment,
1500 but written with internal tree and branches in mind.
1502 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
1503 Like dashboard Main.js, draws the UI and creates all necessary objects.
1505 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
1506 A view for table cells.
1508 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1509 (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
1510 Metrics page has individual platforms initially scrolled away form the view, so
1511 it needs to scroll down to reveal what's being configured.
1513 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1514 Added Array.prototype.average and Array.prototype.median.
1516 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1517 Made gear icon fixed instead of absolute, so that it's visible on metrics page when
1520 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
1521 Additional style rules.
1523 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
1526 2014-08-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1528 Remove networkinfo watch category in watchlist
1529 https://bugs.webkit.org/show_bug.cgi?id=136279
1531 Reviewed by Alexey Proskuryakov.
1533 Network info was removed. So, it is not needed anymore.
1535 * Scripts/webkitpy/common/config/watchlist:
1537 2014-08-26 Alexey Proskuryakov <ap@apple.com>
1539 build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
1540 https://bugs.webkit.org/show_bug.cgi?id=136281
1542 Reviewed by Tim Horton.
1544 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1545 Track and expose whether the itertion is being loaded. Made update() a no-op if
1546 the iteration is already being loaded.
1548 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1549 (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
1550 loading everything at once, ask the queue to load a little more. We can always repeat
1551 if we still don't have enough data.
1553 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1554 (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
1555 10 more iterations intelligently.
1557 2014-08-26 Alexey Proskuryakov <ap@apple.com>
1559 build.webkit.org/dashboard raises an exception when Trac RSS fails to load
1560 https://bugs.webkit.org/show_bug.cgi?id=136283
1562 Reviewed by Tim Horton.
1564 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1567 2014-08-26 Alexey Proskuryakov <ap@apple.com>
1569 build.webkit.org/dashboard raises an exception after a hidden platform is removed
1570 https://bugs.webkit.org/show_bug.cgi?id=136282
1572 Reviewed by Tim Horton.
1574 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1575 (updateHiddenPlatforms): Check that the platform is still valid.
1577 2014-08-26 Matt Lilek <mrl@apple.com>
1579 Add WebKit SPI to control the navigator.standalone property
1580 https://bugs.webkit.org/show_bug.cgi?id=136189
1582 Reviewed by Andy Estes.
1584 Add API test for WKPreferences
1586 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1587 * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
1590 2014-08-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1592 Remove ENABLE_DRT environment variable to enable SHARED_CORE
1593 https://bugs.webkit.org/show_bug.cgi?id=136205
1595 Reviewed by Andrei Bucur.
1597 EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
1598 use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
1600 * Scripts/webkitdirs.pm:
1601 (generateBuildSystemFromCMakeProject):
1603 2014-08-26 Brent Fulgham <bfulgham@apple.com>
1605 [Win] Version stamp should include package-level version
1606 https://bugs.webkit.org/show_bug.cgi?id=136266
1607 <rdar://problem/18134138>
1609 Reviewed by David Kilzer.
1611 * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
1612 tests for the full 3+ digit version.
1613 * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1614 Confirm that the final output DLL uses the 3+ digit version.
1616 2014-08-26 Brent Fulgham <bfulgham@apple.com>
1618 [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
1619 https://bugs.webkit.org/show_bug.cgi?id=136258
1620 <rdar://problem/18134138>
1622 Reviewed by Tim Horton.
1624 Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
1625 values from passing through the 32-bit OLE_HANDLE data type.
1627 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1628 (AccessibilityController::rootElement):
1629 * DumpRenderTree/win/DumpRenderTree.cpp:
1630 (resetWebViewToConsistentStateBeforeTesting):
1632 (createWebViewAndOffscreenWindow):
1633 * DumpRenderTree/win/FrameLoadDelegate.h:
1634 (FrameLoadDelegate::didReceiveIcon):
1635 * DumpRenderTree/win/TestRunnerWin.cpp:
1636 (TestRunner::setWindowIsKey):
1637 * DumpRenderTree/win/UIDelegate.cpp:
1638 (UIDelegate::trackCustomPopupMenu):
1639 (UIDelegate::drawHeaderInRect):
1640 (UIDelegate::drawFooterInRect):
1641 (UIDelegate::webViewClose):
1642 (UIDelegate::webViewFocus):
1643 (UIDelegate::webViewSetCursor):
1644 (UIDelegate::drawBackground):
1645 * DumpRenderTree/win/UIDelegate.h:
1646 (UIDelegate::webViewFirstResponder):
1647 (UIDelegate::makeFirstResponder):
1648 (UIDelegate::contextMenuItemsForElement):
1649 (UIDelegate::addCustomMenuDrawingData):
1650 (UIDelegate::cleanUpCustomMenuDrawingData):
1651 (UIDelegate::webViewLostFocus):
1652 * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1653 (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
1654 * WinLauncher/PrintWebUIDelegate.cpp:
1655 (PrintWebUIDelegate::drawHeaderInRect):
1656 (PrintWebUIDelegate::drawFooterInRect):
1657 * WinLauncher/PrintWebUIDelegate.h:
1658 (PrintWebUIDelegate::webViewFirstResponder):
1659 (PrintWebUIDelegate::makeFirstResponder):
1660 (PrintWebUIDelegate::contextMenuItemsForElement):
1661 (PrintWebUIDelegate::trackCustomPopupMenu):
1662 (PrintWebUIDelegate::addCustomMenuDrawingData):
1663 (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
1664 * WinLauncher/WinLauncher.cpp:
1665 (WinLauncher::prepareViews):
1666 * WinLauncher/WinLauncherWebHost.h:
1667 (WinLauncherWebHost::didReceiveIcon):
1669 2014-08-26 Daniel Bates <dabates@apple.com>
1671 Only define WEBCORE_EXPORT when building DumpRenderTree for Windows and iOS
1673 Rubber-stamped by Tim Horton.
1675 The Windows and iOS ports are the only ports that make use of WebCore headers
1678 * DumpRenderTree/config.h:
1680 2014-08-26 Dan Bernstein <mitz@apple.com>
1682 runSvnUpdateAndResolveChangeLogs() doesn’t work when invoked from a script outside Tools/Scripts
1683 https://bugs.webkit.org/show_bug.cgi?id=136254
1685 Reviewed by Tim Horton.
1687 * Scripts/webkitdirs.pm:
1688 (runSvnUpdateAndResolveChangeLogs): Locate resolve-ChangeLogs relative to the source tree,
1689 not the invoking script.
1691 2014-08-26 Krzysztof Czech <k.czech@samsung.com>
1693 [EFL] Utilize espeak as a synthesizer back-end for WebSpeech
1694 https://bugs.webkit.org/show_bug.cgi?id=136127
1696 Reviewed by Gyuyoung Kim.
1698 Add espeak dependency.
1700 * efl/install-dependencies:
1702 2014-08-25 Alexey Proskuryakov <ap@apple.com>
1704 Remove a little more accidentally landed code from r172891.
1706 iteration.branch also wasn't meant to be landed.
1708 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1709 (BuildbotIteration.prototype._parseData):
1711 2014-08-25 Alexey Proskuryakov <ap@apple.com>
1713 REGRESSION (r172891): Internal dashboard is broken.
1715 Removing some accidentally landed code - I needed "changes" for another patch, but
1716 not here, and then I decided to not use it anyway.
1718 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1719 (BuildbotIteration.prototype._parseData):
1721 2014-08-25 Daniel Bates <dabates@apple.com>
1723 Fix the iOS DumpRenderTree build after <http://trac.webkit.org/changeset/172814/>
1724 (https://bugs.webkit.org/show_bug.cgi?id=136108)
1726 Use a similar approach as in TestWebKitAPI/config.h and define a stub for the macro define WEBCORE_EXPORT
1727 so that we can compile DumpRenderTree for iOS.
1729 * DumpRenderTree/config.h:
1731 2014-08-25 Alexey Proskuryakov <ap@apple.com>
1733 Make build.webkit.org/dashboard work with changeset_show_files=location
1734 https://bugs.webkit.org/show_bug.cgi?id=136237
1736 Reviewed by Tim Horton.
1738 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1739 (Trac.prototype._convertCommitInfoElementToObject): Remove location information
1740 from description before getting title, and also actually parse the location into
1741 result object when available.
1743 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1744 (String.prototype.startsWith): Added.
1746 2014-08-25 Tanay C <tanay.c@samsung.com>
1748 [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
1749 https://bugs.webkit.org/show_bug.cgi?id=135795
1751 Reviewed by Gyuyoung Kim.
1753 * MiniBrowser/efl/main.c: Adding functionality for long press history list navigation
1754 (history_list_hide): Hiding and dereferencing the history list and items
1757 (on_back_button_clicked): Early return for longpress
1758 (on_forward_button_clicked): Early return for longpress
1759 (list_item_label_get): Populate item labels
1760 (on_list_item_select): Navigates on selection from history list
1761 (navigation_button_longpress_process): Populates the history list and displays it
1762 (on_forward_button_longpress):
1763 (on_back_button_longpress):
1764 (window_create): Add the widget for history list
1766 2014-08-25 Carlos Alberto Lopez Perez <clopez@igalia.com>
1768 [GTK] JHBuild module gst-plugins-base fails to build on x86 with GCC 4.9
1769 https://bugs.webkit.org/show_bug.cgi?id=136152
1771 Reviewed by Philippe Normand.
1773 * gtk/jhbuild.modules: Apply gst-plugins-base-fix-build-gcc-4.9-x86.patch.
1774 * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Added.
1775 Cherry pick upstream patches daa194 and 4e3d101.
1777 2014-08-24 Zan Dobersek <zdobersek@igalia.com>
1779 GenericHashTraits::peek() is producing copies of passed-in temporary values
1780 https://bugs.webkit.org/show_bug.cgi?id=131461
1782 Reviewed by Darin Adler.
1784 Add a test case that checks the number of copies and moves of the mapped objects
1785 when calling HashMap::get(). Exactly one copy of the mapped value should be
1786 performed when there exists a value that is mapped to the specified key, and
1787 exactly one move and no copies of the empty value should be performed when there
1788 isn't any mapped value for the specified key.
1790 * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Added.
1791 (CopyMoveCounter::TestingScope::TestingScope):
1792 (CopyMoveCounter::CopyMoveCounter):
1793 (CopyMoveCounter::operator=):
1794 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1795 (TestWebKitAPI::TEST):
1797 2014-08-24 Ryuan Choi <ryuan.choi@samsung.com>
1799 [EFL] Introduce DEVELOPER_MODE
1800 https://bugs.webkit.org/show_bug.cgi?id=135884
1802 Reviewed by Gyuyoung Kim.
1804 * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
1805 (generateBuildSystemFromCMakeProject):
1807 2014-08-24 Alexey Proskuryakov <ap@apple.com>
1809 build.webkit.org/dashboard unnecessarily loads results of hidden queues
1810 https://bugs.webkit.org/show_bug.cgi?id=136195
1812 Reviewed by Tim Horton.
1814 This patch also makes it possible to avoid any automatic loading, as needed for metrics view.
1816 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1817 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1818 Don't start an update just because a queue object was created. Periodic updates
1819 are triggered by views, so it only makes sense to do the same for the initial update.
1821 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1822 Now that Trac object doesn't auto-load, start loading here.
1824 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1825 (QueueView): Calling _updateHiddenState right away was wrong, because it accesses
1826 a data member added by subclasses later. With this.platform being undefined, it
1827 always looked like this queue was not hidden.
1828 (QueueView.prototype._updateHiddenState): Start an immediate update, too.
1830 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1831 (Trac): Don't load anything here, the client may choose to load a custom date range.
1832 (Trac.prototype.startPeriodicUpdates): Added a function to start automatic loading.
1834 2014-08-23 Alexey Proskuryakov <ap@apple.com>
1836 build.webkit.org/dashboard: Further improve Trac loading
1837 https://bugs.webkit.org/show_bug.cgi?id=136174
1839 Reviewed by Timothy Hatcher.
1841 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1842 (Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
1843 error, the oldest commit within the range wasn't returned. The correct argument for
1845 (Trac.prototype.load): Added a function to load a specific time range.
1846 (Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
1847 positioned with regards to ones that were already known.
1849 2014-08-23 Alexey Proskuryakov <ap@apple.com>
1851 build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
1852 https://bugs.webkit.org/show_bug.cgi?id=136182
1854 Reviewed by Timothy Hatcher.
1856 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1857 Make it possible to create a complete BuildbotIteration object with JSON, not only by
1858 loading data from the network.
1860 An iteration has three states:
1861 1. Just created, it only knows the revision, and whether it's already finished.
1862 BuildbotIteration constructor used to create these.
1863 2. A complete JSON report loaded from buildbot. The new constructor form creates these.
1864 3. Data about tests is fetched.
1866 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1867 Make it possible to pull all data from a buildbot queue. This needs to be better
1868 optimized eventually, as it's somewhat slow.
1870 2014-08-22 Renato Nagy <nagy.renato@stud.u-szeged.hu>
1873 https://bugs.webkit.org/show_bug.cgi?id=136170
1875 Reviewed by Gyuyoung Kim.
1877 * Scripts/webkitpy/common/config/watchlist:
1878 * Scripts/webkitpy/style/checker.py:
1880 2014-08-22 Carlos Alberto Lopez Perez <clopez@igalia.com>
1882 [GTK] install-dependencies don't installs Xvfb that is needed for the tests.
1883 https://bugs.webkit.org/show_bug.cgi?id=136153
1885 Reviewed by Martin Robinson.
1887 * gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
1889 2014-08-21 Alex Christensen <achristensen@webkit.org>
1891 [Win] Another unreviewed build fix.
1893 * DumpRenderTree/config.h:
1894 Defined WEBCORE_EXPORT on Windows.
1896 2014-08-21 Rohit Kumar <kumar.rohit@samsung.com>
1898 [EFL][WK2] Minibrowser : Add stop button to abort page load
1899 https://bugs.webkit.org/show_bug.cgi?id=136122
1901 Reviewed by Gyuyoung Kim.
1903 * MiniBrowser/efl/main.c:
1905 (on_stop_button_clicked): Callback for stop button press.
1908 2014-08-21 Carlos Alberto Lopez Perez <clopez@igalia.com>
1910 [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
1911 https://bugs.webkit.org/show_bug.cgi?id=134070
1913 Reviewed by Martin Robinson.
1915 * Scripts/webkitpy/port/base.py:
1916 (Port.__init__): Set default _jhbuild_wrapper variable.
1917 (Port._should_use_jhbuild): Implement generic check.
1918 * Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable
1919 to make it consistent with the other ports.
1920 * Scripts/webkitpy/port/gtk.py:
1921 (GtkPort.__init__): Use the new _should_use_jhbuild() method.
1922 (GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
1923 querying the jhbuild with printenv. Also check that the path contains
1924 the libraries we expect. Preload this path only for XvfbDriver.
1925 * Scripts/webkitpy/port/xvfbdriver.py:
1926 (XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
1927 (XvfbDriver._start): The environment for llvmpipe_libgl_path is now
1928 configured at setup_environ_for_server()
1929 * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1930 (XvfbDriverTest.make_driver): Get the port default environment.
1931 (XvfbDriverTest.test_start_no_pixel_tests): The expected log now
1932 should include the environment that is passed when running Xvfb.
1933 (XvfbDriverTest.test_start_pixel_tests): Ditto.
1934 (XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
1935 (XvfbDriverTest.test_start_next_worker): Ditto.
1936 * gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to
1937 prevent future problems when the version is raised. Add also a
1938 comment with a warning.
1939 * gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one
1940 that has the llvm optimized Gallium libGL libraries.
1942 2014-08-21 Renato Nagy <nagy.renato@stud.u-szeged.hu>
1944 Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
1945 https://bugs.webkit.org/show_bug.cgi?id=136125
1947 Reviewed by Csaba Osztrogonác.
1949 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1950 (RunLLINTCLoopTests.countFailures):
1951 (Run32bitJSCTests.countFailures):
1952 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1953 (RunLLINTCLoopTestsTest):
1954 (RunLLINTCLoopTestsTest.assertResults):
1955 (RunLLINTCLoopTestsTest.test_failures):
1956 (RunLLINTCLoopTestsTest.test_failure):
1957 (RunLLINTCLoopTestsTest.test_no_failure):
1958 (Run32bitJSCTestsTest):
1959 (Run32bitJSCTestsTest.assertResults):
1960 (Run32bitJSCTestsTest.test_failures):
1961 (Run32bitJSCTestsTest.test_failure):
1962 (Run32bitJSCTestsTest.test_no_failure):
1964 2014-08-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1966 Unreviewed, EFL build fix since r172814.
1968 * WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
1970 2014-08-20 Alex Christensen <achristensen@webkit.org>
1972 Introducing WEBCORE_EXPORT macro.
1973 https://bugs.webkit.org/show_bug.cgi?id=136108
1975 Reviewed by Antti Koivisto.
1977 * TestWebKitAPI/config.h:
1978 Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.
1980 2014-08-20 Rebecca Hauck <rhauck@adobe.com>
1982 import-w3c-tests doesn't import .svg support files
1983 https://bugs.webkit.org/show_bug.cgi?id=135928
1985 Reviewed by Bem Jones-Bey.
1987 This patch fixes the W3C import script to not treat all
1988 files with an xml mimetype as convertible tests, which
1989 was causing SVG support files to not be imported.
1991 * Scripts/webkitpy/w3c/test_importer.py:
1992 (TestImporter.find_importable_tests):
1994 2014-08-19 Dan Bernstein <mitz@apple.com>
1996 update-webkit should not check for the presence of Apple’s Internal directory
1997 Last part of https://bugs.webkit.org/show_bug.cgi?id=135815
1999 Reviewed by Tim Horton.
2001 * Scripts/update-webkit:
2003 2014-08-19 Zalan Bujtas <zalan@apple.com>
2005 Remove ENABLE(SUBPIXEL_LAYOUT).
2006 https://bugs.webkit.org/show_bug.cgi?id=136077
2008 Reviewed by Simon Fraser.
2010 Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
2012 * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2014 2014-08-19 Akos Kiss <akiss@inf.u-szeged.hu>
2016 Let the caller define JSC_timeout for run-javascriptcore-tests
2017 https://bugs.webkit.org/show_bug.cgi?id=136068
2019 Reviewed by Csaba Osztrogonác.
2021 Keep the 60 second timeout for jsc tests as the default setting but
2022 don't override the value of JSC_timeout if already set.
2024 * Scripts/run-javascriptcore-tests:
2026 2014-08-19 Renato Nagy <nagy.renato@stud.u-szeged.hu>
2028 Remove obsolete run-javascriptcore-tests result parsing from master.cfg
2029 https://bugs.webkit.org/show_bug.cgi?id=136039
2031 Reviewed by Csaba Osztrogonác.
2033 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2034 (RunJavaScriptCoreTests.commandComplete):
2035 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2036 (RunJavaScriptCoreTestsTest.test_no_failure_new_output):
2037 (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
2038 (RunJavaScriptCoreTestsTest):
2039 (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
2040 (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): Deleted.
2041 (test_layout_failure_new_output): Deleted.
2042 (test_layout_crash_new_output): Deleted.
2043 (test_mozilla_and_layout_failure_new_output): Deleted.
2044 (test_jsc_stress_failure_new_output): Deleted.
2045 (test_js_crashes_and_jsc_stress_failures_new_output): Deleted.
2047 2014-08-19 Alexey Proskuryakov <ap@apple.com>
2049 build.webkit.org/dashboard should not request 50 revisions from trac each time
2050 https://bugs.webkit.org/show_bug.cgi?id=127130
2052 build.webkit.org/dashboard sometimes fetches a Trac revision in an intermediate state, and never updates later
2053 https://bugs.webkit.org/show_bug.cgi?id=127131
2055 Reviewed by Timothy Hatcher.
2057 Turns out that requesting 50 builds is much slower than requesting by date - even
2058 if the request ends up returning more than 50 results. There is no way to only
2059 request updates, but this change brings request time from 6-8 seconds down to
2062 This patch generalizes date handling for later use in metrics code. As part of the
2063 rewrite, I made newly fetched data update author e-mail in previously fetched
2064 revisions, as it changes after commit queue first lands.
2066 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2067 Updated for event rename. I changed the trac event to not contain the list of new
2068 commits, as we now sometimes update old commits, and that couldn't be expressed
2069 in event data. We never used the list anywhere in the first place.
2071 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2072 (Trac.prototype._xmlTimelineURL): Made this function take arbitrary dates. When called
2073 without arguments, return commits for today and yesterday.
2074 (Trac.prototype._loaded):
2075 (Trac.prototype.update): Moved the function for processing loaded results out of
2076 here for clarity, and also because I'm going to have a separate loading code path
2079 2014-08-18 Dan Bernstein <mitz@apple.com>
2081 Added an update-webkit option to override the ../Internal check.
2082 Part of https://bugs.webkit.org/show_bug.cgi?id=135815
2084 Reviewed by Tim Horton.
2086 * Scripts/update-webkit:
2087 Added an explicit --internal option to control updating ../Internal, defaulting to whether
2089 (runSvnUpdate): Moved to webkitdirs.pm.
2090 (runGitUpdate): Ditto.
2091 * Scripts/webkitdirs.pm:
2092 (runSvnUpdateAndResolveChangeLogs): Moved runSvnUpdate from update-webkit and renamed to this.
2093 (runGitUpdate): Moved from update-webkit.
2095 2014-08-18 Pratik Solanki <psolanki@apple.com>
2097 Make update-webkit more lenient for pure git svn repositories
2098 https://bugs.webkit.org/show_bug.cgi?id=135805
2100 Reviewed by Oliver Hunt.
2102 Make the call to git fetch be non fatal. If you have a pure git svn repository, then the
2103 call to git fetch will fail and update-webkit will abort. The purpose of r72966 was to
2104 provide an optimization when you have a git repository setup. We should not fail if the
2105 git setup does not have svn-remote.svn.fetch set.
2107 * Scripts/update-webkit:
2110 2014-08-18 Simon Fraser <simon.fraser@apple.com>
2112 Enable Web Inspector in MiniBrowser WK2 windows
2113 https://bugs.webkit.org/show_bug.cgi?id=136045
2115 Reviewed by Tim Horton.
2117 Set the pref to enable developer extras for all WK2 windows.
2119 * MiniBrowser/mac/WK2BrowserWindowController.m:
2120 (-[WK2BrowserWindowController awakeFromNib]):
2122 2014-08-18 Renato Nagy <nagy.renato@stud.u-szeged.hu>
2124 master.cfg should handle special return codes of run-perf-tests
2125 https://bugs.webkit.org/show_bug.cgi?id=135974
2127 Reviewed by Ryosuke Niwa.
2129 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2130 (RunAndUploadPerfTests.getText2):
2131 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2132 (RunAndUploadPerfTestsTest):
2133 (RunAndUploadPerfTestsTest.assertResults):
2134 (RunAndUploadPerfTestsTest.test_tests_failed):
2135 (RunAndUploadPerfTestsTest.test_build_bad_build):
2136 (RunAndUploadPerfTestsTest.test_build_bad_source_json):
2137 (RunAndUploadPerfTestsTest.test_build_bad_marge):
2138 (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading):
2139 (RunAndUploadPerfTestsTest.test_build_bad_preparation):
2141 2014-08-17 Brent Fulgham <bfulgham@apple.com>
2143 [Win] Unreviewed change to force rebuild
2144 (plus drive-by add an accessor I wanted for
2145 some future tooling).
2147 * WinLauncher/WinLauncher.h:
2148 (WinLauncher::webView): Added.
2150 2014-08-16 Mark Hahnenberg <mhahnenb@gmail.com>
2152 Update contributors.json for my new email
2153 https://bugs.webkit.org/show_bug.cgi?id=136021
2155 Reviewed by Filip Pizlo.
2157 * Scripts/webkitpy/common/config/contributors.json:
2159 2014-08-15 Alexey Proskuryakov <ap@apple.com>
2161 REGRESSION (r172660): WebKit2.TerminateTwice asserts
2162 https://bugs.webkit.org/show_bug.cgi?id=136012
2164 * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Skipped the test in debug mode.
2166 2014-08-15 Ryuan Choi <ryuan.choi@samsung.com>
2168 Unreviewed build fix attempt on the CMake based pots since r172665
2170 * TestWebKitAPI/CMakeLists.txt: Added JavaScriptCore/interpreter to the include list.
2172 2014-08-15 Brian J. Burg <burg@cs.washington.edu>
2174 Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
2175 https://bugs.webkit.org/show_bug.cgi?id=131596
2177 Reviewed by Joseph Pecoraro.
2179 * Scripts/run-inspector-generator-tests: Added.
2181 * Scripts/webkitpy/inspector/__init__.py: Added.
2182 * Scripts/webkitpy/inspector/main.py: Added.
2183 (InspectorGeneratorTests):
2184 (InspectorGeneratorTests.__init__):
2185 (InspectorGeneratorTests.generate_from_json):
2186 (InspectorGeneratorTests.write_error_file):
2187 (InspectorGeneratorTests.detect_changes):
2188 (InspectorGeneratorTests.run_tests):
2189 (InspectorGeneratorTests.main):
2191 2014-08-15 Rebecca Hauck <rhauck@adobe.com>
2193 run-webkit-tests should skip 'support' directories
2194 https://bugs.webkit.org/show_bug.cgi?id=135910
2196 Reviewed by Bem Jones-Bey.
2198 This patch adds the 'support' directory to the list
2199 of dirs to skip when looking for runnable tests.
2200 the W3C uses this name for support files, so tests
2201 imported from the W3C will not work without this change
2202 or without many edits.
2204 * Scripts/webkitpy/port/base.py:
2207 2014-08-14 Brent Fulgham <bfulgham@apple.com>
2209 [Win] Extend auto-version and version-stamp for RC_ProjectBuildVersion
2210 https://bugs.webkit.org/show_bug.cgi?id=135948
2211 <rdar://problem/18022221>
2213 Reviewed by David Kilzer.
2215 * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add tests
2216 for RC_ProjectBuildVersion.
2218 2014-08-05 David Farler <dfarler@apple.com>
2220 [iOS] run-webkit-tests runs webkit-build-directory on every test
2221 https://bugs.webkit.org/show_bug.cgi?id=135409
2223 Reviewed by Daniel Bates.
2225 * Scripts/webkitpy/port/ios.py:
2226 (IOSSimulatorPort.__init__): Cache Mac build directory.
2227 (IOSSimulatorPort.relay_path): Use cached build directory.
2228 (IOSSimulatorPort._path_to_image_diff): Use cached build directory.
2230 2014-08-14 Zan Dobersek <zdobersek@igalia.com>
2232 Initialize a separate variable (TestWTF_SOURCES) with the list of files
2233 that are built into the TestWTF executable and move it above the platform-specific
2234 config file inclusion. This makes it possible to add platform-specific files to that
2235 list (e.g. GUniquePtr.cpp for the GTK port).
2237 Rubber-stamped by Carlos Garcia Campos.
2239 * TestWebKitAPI/CMakeLists.txt:
2240 * TestWebKitAPI/PlatformGTK.cmake:
2242 2014-08-13 Akos Kiss <akiss@inf.u-szeged.hu>
2244 [EFL] Bump up and patch dependencies to allow building for aarch64
2245 https://bugs.webkit.org/show_bug.cgi?id=135885
2247 Reviewed by Gyuyoung Kim.
2249 The currently used versions of pixman, libffi, glib, glib-networking,
2250 and fontconfig fail to configure for aarch64, so they are bumped up to
2251 the latest stable version.
2253 Gstreamer-plugins-base configures for aarch64 but incorrectly recogizes
2254 ARM NEON assembly support, so it is patched with a change that has been
2255 accepted by upstream.
2257 * efl/jhbuild.modules:
2258 * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Added.
2260 2014-08-13 Mark Rowe <mrowe@apple.com>
2262 <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
2264 Reviewed by Darin Adler.
2266 * DumpRenderTree/mac/TextInputController.m: Don't use extern "C" in a non-C++ file.
2268 2014-08-13 Alex Christensen <achristensen@webkit.org>
2270 Progress towards CMake on Mac.
2271 https://bugs.webkit.org/show_bug.cgi?id=135819
2273 Reviewed by Laszlo Gombos.
2275 * WebKitTestRunner/CMakeLists.txt:
2276 Added new cpp parameter for the extension of the generated files.
2278 2014-08-13 Renato Nagy <nagy.renato@stud.u-szeged.hu>
2280 Make check-webkit-style run sort-export-file
2281 https://bugs.webkit.org/show_bug.cgi?id=135877
2283 Reviewed by Csaba Osztrogonác.
2285 * Scripts/webkitpy/style/checker.py:
2288 (CheckerDispatcher._file_type):
2289 (CheckerDispatcher._create_checker):
2290 * Scripts/webkitpy/style/checkers/exportfile.py: Added.
2291 (ExportFileChecker):
2292 (ExportFileChecker.__init__):
2293 (ExportFileChecker.check):
2294 * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Added.
2295 (handle_style_error):
2297 (MockErrorHandler.__init__):
2298 (MockErrorHandler.turn_off_line_filtering):
2299 (MockErrorHandler.__call__):
2301 (ExportFileTest.setUp):
2302 (ExportFileTest.tearDown):
2303 (ExportFileTest.test_sorted):
2304 (ExportFileTest.test_non_sorted):
2305 (ExportFileTest.test_parse_error):
2307 2014-08-13 Jinwoo Song <jinwoo7.song@samsung.com>
2309 [EFL] Sets the persistent storage for cookies in MiniBrowser
2310 https://bugs.webkit.org/show_bug.cgi?id=135875
2312 Reviewed by Gyuyoung Kim.
2314 In case of EWK_COOKIE_ACCEPT_POLICY_ALWAYS, sets the persistent storage
2315 for non-session cookies can be stored persistently.
2317 * MiniBrowser/efl/main.c:
2320 2014-08-12 Daniel Bates <dabates@apple.com>
2322 [iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions
2323 https://bugs.webkit.org/show_bug.cgi?id=135845
2325 Reviewed by Andy Estes.
2327 Towards building the iOS WebKit port using the public SDK, remove the logic
2328 added to build-webkit to build projects WebKitSystemInterface and
2329 WebKitAdditions when building the iOS WebKit port.
2331 * Scripts/build-webkit:
2333 2014-08-12 Yusuke Suzuki <utatane.tea@gmail.com>
2335 [GTK] Adds dependency for GnuTLS 3.0+ explicitly in gtk/install-dependencies
2336 https://bugs.webkit.org/show_bug.cgi?id=135850
2338 Reviewed by Philippe Normand.
2340 After r172433, GTK port requires GnuTLS 3.0+. In this time, libgnutls-dev is 2.x in
2341 Ubuntu(trusty) and Debian(sid). So added libgnutls28-dev explicitly.
2343 * gtk/install-dependencies:
2345 2014-08-12 Eduardo Lima Mitev <elima@igalia.com>
2347 [GTK] Subtle-crypto feature off by default and add a new configure flag to enable it
2348 https://bugs.webkit.org/show_bug.cgi?id=135798
2350 Reviewed by Philippe Normand.
2352 * Scripts/webkitperl/FeatureList.pm: Adds new flag --subtle-crypto to
2353 toggle SUBTLE_CRYPTO feature.
2355 2014-08-12 Ryuan Choi <ryuan.choi@samsung.com>
2357 [EFL] Disable ecore logs about bad fd
2358 https://bugs.webkit.org/show_bug.cgi?id=135831
2360 Reviewed by Gyuyoung Kim.
2362 ecore checks EBADF and prints the warnings.
2363 But, it looks noise in layout test because it's not webkit issue.
2364 This patch disables it until we found right solution.
2366 * efl/jhbuild.modules:
2367 * efl/patches/ecore_remove_warnings.patch: Added.
2369 2014-08-12 Shivakumar JM <shiva.jm@samsung.com>
2371 [EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
2372 https://bugs.webkit.org/show_bug.cgi?id=135791
2374 Reviewed by Gyuyoung Kim.
2376 Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
2379 * MiniBrowser/efl/main.c:
2380 (on_download_request):
2382 2014-08-11 Grzegorz Czajkowski <g.czajkowski@samsung.com>
2384 [EFL] Prevent the client from creating ewk_view when EWebkit is not initialized
2385 https://bugs.webkit.org/show_bug.cgi?id=135606
2387 Reviewed by Gyuyoung Kim.
2389 TestWebKitAPI does not initialize EWebkit using ewk_init()
2390 which is not recommended.
2392 * TestWebKitAPI/efl/PlatformWebView.cpp:
2393 (TestWebKitAPI::createEcoreEvas):
2394 Renamed from initEcoreEvas() since it doesn't not initialize
2397 (TestWebKitAPI::PlatformWebView::PlatformWebView):
2398 Call ewk_init() that initalizes all EFL modules needed by EWebKit
2399 instead of ecore_evas_init() only.
2401 (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2402 Call ewk_shutdown() to finalize EWebkit.
2403 (TestWebKitAPI::initEcoreEvas): Deleted.
2405 2014-08-11 Dan Bernstein <mitz@apple.com>
2407 Added an update-webkit option to update the auxiliary libraries or not.
2408 Part of https://bugs.webkit.org/show_bug.cgi?id=135815
2410 Reviewed by Tim Horton.
2412 * Scripts/update-webkit: Added --[no-]auxiliary-libs option, which defaults to yes unless
2413 an Internal directory exists alongside the WebKit root directory.
2415 2014-08-11 Bem Jones-Bey <bjonesbe@adobe.com>
2417 Remove hg changeset from w3c-import.log
2418 https://bugs.webkit.org/show_bug.cgi?id=135735
2420 Reviewed by Ryosuke Niwa.
2422 Since the csswg's test suite is now accessible via github and it is
2423 possible to push changes by creating github pull requests, the hg
2424 changeset makes less sense, as many people will just use a clone of
2425 the git repo. There isn't an obvious thing to replace it with, so
2426 might as well remove it for now instead of having it just be set to
2429 This also adds a pointer to the github repo in the generated comments
2430 in the w3c-import.log.
2432 * Scripts/webkitpy/w3c/test_importer.py:
2433 (TestImporter.__init__): Remove changeset handling.
2434 (TestImporter.do_import): Ditto.
2435 (TestImporter.write_import_log): Ditto.
2436 (TestImporter.load_changeset): Deleted.
2438 2014-08-11 Carlos Garcia Campos <cgarcia@igalia.com>
2440 Unreviewed. Fix GTK+ make distcheck.
2442 * gtk/manifest.txt: Remove Source/WebCore/Resources/inputSpeech.png.
2444 2014-08-08 Simon Fraser <simon.fraser@apple.com>
2446 Unbreak webkitpy unit tests by checking for the existence of the image diff template
2447 file before trying to open it (as the tests do for results.html).
2449 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2450 (TestResultWriter.write_image_diff_files):
2452 2014-08-08 Simon Fraser <simon.fraser@apple.com>
2454 Load the layout test result image diff HTML from a file, rather than having it inline in webkitpy
2455 https://bugs.webkit.org/show_bug.cgi?id=135780
2457 Reviewed by Dan Bates.
2459 Pull the HTML for the image diff file into a separate file, for easier hackability.
2461 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2462 (TestResultWriter.write_image_diff_files):
2464 2014-08-08 Mark Lam <mark.lam@apple.com>
2466 Gardening: fix Windows build after r172259.
2470 * DumpRenderTree/win/TestRunnerWin.cpp:
2471 (TestRunner::addMockSpeechInputResult): Deleted.
2472 (TestRunner::setMockSpeechInputDumpRect): Deleted.
2473 (TestRunner::startSpeechInput): Deleted.
2475 2014-08-08 Joseph Pecoraro <pecoraro@apple.com>
2477 make clean does not work in OpenSource, fails in WebKitLibraries
2478 https://bugs.webkit.org/show_bug.cgi?id=135734
2480 Reviewed by David Kilzer.
2482 * Scripts/copy-webkitlibraries-to-product-directory:
2483 Add a --clean switch that removes possible WebKitSystemInterface
2484 and LLVM libraries and headers that may have been copied to the
2487 2014-08-08 Joseph Pecoraro <pecoraro@apple.com>
2489 commit-log-message has extra blank line at the top of pre-populated message
2490 https://bugs.webkit.org/show_bug.cgi?id=135744
2492 Reviewed by Csaba Osztrogonác.
2494 Do not add a blank leading line in single ChangeLog commit messages.
2496 * Scripts/commit-log-editor:
2497 (createCommitMessage):
2498 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2499 (test_commit_message_for_one_reviewed_changelog):
2500 (test_commit_message_for_one_rollout_changelog):
2502 2014-08-07 Brent Fulgham <bfulgham@apple.com>
2504 [Win] Unreviewed gardening.
2506 Have 'Assemble Build Logs' step work properly for DebugSuffix target
2507 (both 32-bit and 64-bit).
2509 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2511 2014-08-07 Benjamin Poulain <bpoulain@apple.com>
2513 Get rid of INPUT_SPEECH
2514 https://bugs.webkit.org/show_bug.cgi?id=135672
2516 Reviewed by Andreas Kling.
2518 * DumpRenderTree/TestRunner.cpp:
2519 (TestRunner::staticFunctions):
2520 (addMockSpeechInputResultCallback): Deleted.
2521 (setMockSpeechInputDumpRectCallback): Deleted.
2522 * DumpRenderTree/TestRunner.h:
2523 * DumpRenderTree/mac/TestRunnerMac.mm:
2524 (TestRunner::addMockSpeechInputResult): Deleted.
2525 (TestRunner::setMockSpeechInputDumpRect): Deleted.
2526 (TestRunner::startSpeechInput): Deleted.
2528 2014-08-07 Bem Jones-Bey <bjonesbe@adobe.com>
2530 The support directory shouldn't be skipped unconditionally in test import
2531 https://bugs.webkit.org/show_bug.cgi?id=135660
2533 Reviewed by Ryosuke Niwa.
2535 The 'DIRS_TO_SKIP' should only be skipped when in the root directory
2536 of the test repo, as that's the only time they are special. In
2537 addition, instead of hardcoding .hg and .git as special, skip all
2538 directories that begin with '.', just like with files that begin with '.'.
2540 In order to make this work, the root directory must always be
2541 passed in, so the interface to the script has been changed to take the
2542 root directory, and if one wants to only import a subset of the tests,
2543 a new -t option can be used to limit the tests imported.
2545 * Scripts/webkitpy/w3c/test_importer.py:
2546 (main): Remove repo_dir command line argument.
2547 (parse_args): Add -t option and set expected non-option args to 1.
2548 (TestImporter.__init__): Remove repo_dir.
2549 (TestImporter.do_import): Handle the varying number of import
2551 (TestImporter.should_keep_subdir): Helper for find_importable_tests to
2552 determine if a subdirectory should be skipped.
2553 (TestImporter.find_importable_tests): Filter directories using new
2555 (TestImporter.import_tests): Remove use of repo_dir.
2556 (TestImporter.setup_destination_directory): Unused, Deleted.
2557 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2558 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Update for
2560 (TestImporterTest.test_import_dir_with_no_tests): Ditto.
2562 2014-08-07 Carlos Garcia Campos <cgarcia@igalia.com>
2564 [GTK] Use WebKitNavigationAction also for WebKitNavigationPolicyDecision
2565 https://bugs.webkit.org/show_bug.cgi?id=135695
2567 Reviewed by Gustavo Noronha Silva.
2569 Use WebKitNavigationAction API.
2571 * MiniBrowser/gtk/BrowserWindow.c:
2572 (webViewDecidePolicy):
2573 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
2574 (testNavigationPolicy):
2576 2014-08-07 Carlos Garcia Campos <cgarcia@igalia.com>
2578 [GTK] Test /webkit2/WebKitUserContentManager/injected-script fails
2579 https://bugs.webkit.org/show_bug.cgi?id=135696
2581 Reviewed by Sergio Villar Senin.
2583 Don't assume the JavaScript result is always a valid pointer. In case of JavaScript
2584 exception (that happens when testing the script hasn't been injected) the JavaScript
2587 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2588 (isScriptInjectedForURLAtPath):
2590 2014-08-07 Csaba Osztrogonác <ossy@webkit.org>
2592 [GTK] Disable IndexedDB
2593 https://bugs.webkit.org/show_bug.cgi?id=135692
2595 Reviewed by Carlos Garcia Campos.
2597 * Scripts/webkitperl/FeatureList.pm:
2599 2014-08-06 Dean Jackson <dino@apple.com>
2601 ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
2602 https://bugs.webkit.org/show_bug.cgi?id=135675
2604 Reviewed by Sam Weinig.
2606 * Scripts/webkitperl/FeatureList.pm:
2608 2014-08-06 David Farler <dfarler@apple.com>
2610 Set DSYMUTIL_NUM_THREADS to the number of logical cores
2611 https://bugs.webkit.org/show_bug.cgi?id=135655
2613 Reviewed by Mark Rowe.
2615 * Scripts/webkitdirs.pm:
2616 (buildXCodeProject): Set before calling xcodebuild.
2618 2014-08-06 Adrian Perez de Castro <aperez@igalia.com>
2620 [GTK] Add support for user scripts to WebKitUserContentManager
2621 https://bugs.webkit.org/show_bug.cgi?id=134738
2623 Reviewed by Carlos Garcia Campos.
2625 Add support for user scripts, to complement the user style sheet
2626 support already present in WebKitUserContentManager. Most of the
2627 moving parts are already present, so this just adds a boxed type
2628 for user scripts (WebKitUserScript) and the corresponding methods
2629 to add and remove scripts from the WebKitUserContentManager.
2631 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2632 Add test case for injected user scripts.
2633 (isScriptInjectedForURLAtPath):
2634 (removeOldInjectedContentAndResetLists):
2635 (testUserContentManagerInjectedStyleSheet):
2636 (testUserContentManagerInjectedScript):
2638 (removeOldInjectedStyleSheetsAndResetLists): Deleted.
2640 2014-08-06 Philippe Normand <pnormand@igalia.com>
2642 [GTK] run-launcher --gtk still fails
2643 https://bugs.webkit.org/show_bug.cgi?id=135642
2645 Reviewed by Carlos Garcia Campos.
2647 The perl interpreter is confused by the combination of string
2648 concatenation and a ternary in the same line. Using a separate
2649 variable to determine the library file extension fixes this issue.
2651 * Scripts/webkitdirs.pm:
2652 (builtDylibPathForName): Use an intermediate variable, it's more
2653 readable and unambiguous.
2655 2014-07-29 Filip Pizlo <fpizlo@apple.com>
2657 Merge r170564, r170571, r170604, r170628, r170672, r170680, r170724, r170728, r170729, r170819, r170821, r170836, r170855, r170860, r170890, r170907, r170929, r171052, r171106, r171152, r171153, r171214 from ftlopt.
2659 2014-06-25 Filip Pizlo <fpizlo@apple.com>
2661 [ftlopt] If a CodeBlock is jettisoned due to a watchpoint then it should be possible to figure out something about that watchpoint
2662 https://bugs.webkit.org/show_bug.cgi?id=134333
2664 Reviewed by Geoffrey Garen.
2666 * Scripts/display-profiler-output:
2668 2014-08-05 David Farler <dfarler@apple.com>
2670 [iOS] Run ImageDiff in the sim bootstrap
2671 https://bugs.webkit.org/show_bug.cgi?id=135624
2673 Reviewed by David Kilzer.
2675 * Scripts/webkitpy/port/image_diff.py:
2677 (IOSSimulatorImageDiffer):
2678 (IOSSimulatorImageDiffer._start):
2679 * Scripts/webkitpy/port/ios.py:
2680 (IOSSimulatorPort.diff_image):
2682 2014-08-05 David Farler <dfarler@apple.com>
2684 [iOS] run-webkit-tests: defaults for --runtime and --device-type flags
2685 https://bugs.webkit.org/show_bug.cgi?id=135441
2687 Reviewed by Tim Horton.
2689 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2691 (_set_up_derived_options):
2692 If using the ios-simulator platform and runtime or device-type
2693 aren't defined, get the latest runtime from the active Xcode.app
2694 and pick a default device type based on the desired architecture:
2695 iPhone 5 for i386 and iPhone 5s for x86_64.
2696 * Scripts/webkitpy/xcode/__init__.py: Added.
2697 * Scripts/webkitpy/xcode/simulator.py: Added.
2699 2014-08-05 David Farler <dfarler@apple.com>
2701 [iOS] simctl can hang if run quickly after shutting down CoreSimulator services
2702 https://bugs.webkit.org/show_bug.cgi?id=135626
2704 Reviewed by Dan Bernstein.
2706 * Scripts/webkitpy/port/ios.py:
2707 (IOSSimulatorPort.setup_test_run):
2708 Remove call to simctl shutdown <device> - telling the simulator app to quit
2709 will shut down all booted devices.
2711 2014-08-05 Alexey Proskuryakov <ap@apple.com>
2713 Remove an unused argument from BuildbotQueue.update()
2714 https://bugs.webkit.org/show_bug.cgi?id=135623
2716 Reviewed by Timothy Hatcher.
2718 Also remaned a constant to better match what it means.
2720 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2722 2014-08-05 Vivek Galatage <vivek.vg@samsung.com>
2724 [gtk] Include llvm-dev(el) package to satisfy mesa build configuration
2725 https://bugs.webkit.org/show_bug.cgi?id=135555
2727 Reviewed by Philippe Normand.
2729 Initial setup of gtk on linux requires this package to be installed.
2730 This is required during the build configuration of mesa through jhbuild.
2732 * gtk/install-dependencies:
2734 2014-08-05 Eva Balazsfalvi <evab.u-szeged@partner.samsung.com>
2736 Fix the commit-log-editor after r167243 and add more unit tests
2737 https://bugs.webkit.org/show_bug.cgi?id=131727
2739 Reviewed by Csaba Osztrogonác.
2741 * Scripts/commit-log-editor:
2742 (createCommitMessage):
2743 (removeLongestCommonPrefixEndingInNewline):
2744 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2745 (CommitMessageForThisCommitTest):
2746 (CommitMessageForThisCommitTest.mock_changelog):
2747 (CommitMessageForThisCommitTest.mock_checkout_for_test):
2748 (CommitMessageForThisCommitTest.test_commit_message_for_unreviewed_changelogs_with_different_messages):
2749 (test_commit_message_for_one_reviewed_changelog):
2750 (test_commit_message_for_changelogs_with_same_messages):
2751 (test_commit_message_for_changelogs_with_different_messages):
2752 (test_commit_message_for_one_rollout_changelog):
2753 (test_commit_message_for_rollout_changelogs_with_different_directories):
2755 (test_commit_message_for_this_commit): Deleted.
2757 2014-08-04 Michael Catanzaro <mcatanzaro@igalia.com>
2759 [GTK] run-launcher --gtk is broken
2760 https://bugs.webkit.org/show_bug.cgi?id=135571
2762 Reviewed by Martin Robinson.
2764 * Scripts/webkitdirs.pm:
2765 (builtDylibPathForName): Search for libwebkit2gtk-4.0
2767 2014-08-04 Matt Baker <mattbaker@apple.com>
2769 lldb_webkit.py throws exception when generating summary of null StringImpl
2770 https://bugs.webkit.org/show_bug.cgi?id=129448
2772 Reviewed by Jer Noble.
2774 Added checks for null StringImpl and 0 byte ReadMemory calls.
2776 * lldb/lldb_webkit.py:
2777 (WTFStringImpl_SummaryProvider):
2778 (ustring_to_string):
2779 (lstring_to_string):
2780 (WTFStringImplProvider.to_string):
2781 (WTFStringImplProvider.is_initialized):
2783 2014-08-03 Carlos Garcia Campos <cgarcia@igalia.com>
2785 [GTK] Do not include JavaScriptCore stress tests in release tarballs
2786 https://bugs.webkit.org/show_bug.cgi?id=135503
2788 Reviewed by Martin Robinson.
2790 * gtk/manifest.txt: Exclude Source/JavaScriptCore/tests dir.
2792 2014-07-30 David Farler <dfarler@apple.com>
2794 build-webkittestrunner doesn't build the app target for iOS SDKs
2795 https://bugs.webkit.org/show_bug.cgi?id=135433
2797 Reviewed by Dan Bernstein.
2799 * Scripts/build-dumprendertree: Build the app target on iOS.
2800 * Scripts/build-webkittestrunner: Build the app target on iOS.
2801 * Scripts/webkitdirs.pm: Add -sdk flags when building for iOS.
2802 (buildXCodeProject):
2803 * Scripts/webkitpy/port/ios.py: Use --sdk flags instead of SDKROOT.
2804 (IOSSimulatorPort._build_driver_flags):
2806 2014-07-30 David Farler <dfarler@apple.com>
2808 Remove iOS Perl DumpRenderTree support target
2809 https://bugs.webkit.org/show_bug.cgi?id=135271
2811 Reviewed by Dan Bernstein.
2813 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
2814 * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Removed.
2815 * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
2816 * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
2817 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Removed.
2818 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Removed.
2819 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Removed.
2820 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Removed.
2821 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Removed.
2822 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Removed.
2823 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Removed.
2824 * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Removed.
2825 * DumpRenderTree/ios/PerlSupport/Makefile: Removed.
2827 2014-07-30 David Farler <dfarler@apple.com>
2829 Remove old-run-webkit-tests
2830 https://bugs.webkit.org/show_bug.cgi?id=135374
2832 Reviewed by Csaba Osztrogonác.
2834 * Scripts/old-run-webkit-tests: Removed.
2836 2014-08-02 Dan Bernstein <mitz@apple.com>
2838 prepare-ChangeLog --no-write shouldn’t require ChangeLog to exist
2839 https://bugs.webkit.org/show_bug.cgi?id=135542
2841 Reviewed by Tim Horton.
2843 * Scripts/prepare-ChangeLog:
2844 (main): Pass $writeChangeLogs for the new requireChangeLogToExist parameter of
2846 (findChangeLogs): Don’t require a ChangeLog file to exist if unless the
2847 requireChangeLogToExist argument is true.
2849 2014-08-01 Dan Bernstein <mitz@apple.com>
2851 commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes
2852 https://bugs.webkit.org/show_bug.cgi?id=135527
2854 Reviewed by Tim Horton.
2856 * Scripts/commit-log-editor:
2857 In the case of a git repository when there are no changed ChangeLog files, changed to pass
2858 the --delimiters option to prepare-ChangeLog, then process each entry in the output using
2859 commitMessageFromChangeLogEntry.
2860 (commitMessageFromChangeLogEntry): Factored out from createCommitMessage.
2861 (sortKey): Factored out from createCommitMessage.
2862 (createCommitMessage): Changed to use new sortKey and commitMessageFromChangeLogEntry
2865 * Scripts/prepare-ChangeLog:
2866 (main): Parse new --delimiters option.
2867 (generateNewChangeLogs): When --no-write and --delimiters are both specified, always print
2868 the label before each change log entry, and a "~" delimiter on a new line after each entry.
2870 2014-08-01 Bear Travis <betravis@adobe.com>
2872 [Feature Queries] Enable Feature Queries on EFL/GTK
2873 https://bugs.webkit.org/show_bug.cgi?id=134902
2875 Reviewed by Benjamin Poulain.
2877 Turn the feature on by default for the build script.
2879 * Scripts/webkitperl/FeatureList.pm:
2881 2014-08-01 Timothy Horton <timothy_horton@apple.com>
2883 Build fix for 32-bit after r171926.
2885 * MiniBrowser/mac/SettingsController.h:
2886 * MiniBrowser/mac/SettingsController.m:
2888 2014-08-01 Tim Horton <timothy_horton@apple.com>
2890 Confusing build fix after r171926.
2892 * MiniBrowser/mac/AppDelegate.h:
2893 * MiniBrowser/mac/AppDelegate.m:
2894 * MiniBrowser/mac/SettingsController.m:
2896 2014-08-01 Tim Horton <timothy_horton@apple.com>
2898 Make it easer to add switches to MiniBrowser
2899 https://bugs.webkit.org/show_bug.cgi?id=135499
2901 Reviewed by Simon Fraser.
2903 Add a single class to manage a set of persistent, global settings for MiniBrowser.
2904 Add a new menu that contains items to toggle the aforementioned settings (moving them out of the Debug menu).
2906 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2907 Add SettingsController.{m, h}.
2909 * MiniBrowser/mac/AppDelegate.h:
2910 Move _browserWindowControllers to the implementation.
2911 Get rid of toggleUseWebKit2ByDefault, because SettingsController now takes care
2912 of that; instead, we'll receive didChangeSettings.
2914 * MiniBrowser/mac/AppDelegate.m:
2915 Move the default URL, default URL preference key, and use-WebKit2-by-default
2916 preference key into SettingsController.
2918 (-[BrowserAppDelegate awakeFromNib]):
2919 Add the dynamically-generated SettingsController menu just to the left of the Debug menu.
2921 (-[BrowserAppDelegate newWindow:]):
2922 Ask SettingsController if we should use WebKit2 by default, and what the initial URL to load is.
2924 (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2925 SettingsController now takes care of reading the default URL preference.
2926 WK1BrowserWindowController now takes care of enabling the developer extras, via WebPreferences.
2928 (-[BrowserAppDelegate didChangeSettings]):
2929 When settings change, update the key equivalents for the new-window menu items, as they
2930 might have changed (as use-WebKit2-by-default is one of the settings).
2932 Dispatch settings change notifications to all live BrowserControllers.
2934 (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2935 (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]): Deleted.
2936 (-[BrowserAppDelegate _useWebKit2ByDefault]): Deleted.
2937 (-[BrowserAppDelegate validateMenuItem:]): Deleted.
2938 All menu item validation for settings is moved into SettingsController.
2940 * MiniBrowser/mac/BrowserWindowController.h:
2941 Simplify the BrowserWindowController interface; "toggling" settings will happen inside SettingsController,
2942 the BrowserWindowController subclasses will be able to a) know when any setting changes, b) query the current setting state.
2944 * MiniBrowser/mac/MainMenu.xib:
2945 Remove the settings menu items from the "Debug" menu.
2947 * MiniBrowser/mac/SettingsController.h: Added.
2948 * MiniBrowser/mac/SettingsController.m: Added.
2949 (+[SettingsController shared]):
2950 (-[SettingsController menu]):
2952 (-[SettingsController _addItemWithTitle:action:indented:]):
2953 (-[SettingsController _addHeaderWithTitle:]):
2954 NSMenuItem-creating helpers.
2956 (-[SettingsController _populateMenu]):
2957 Build the menu. Ideally this and the validation step would eventually be made more dynamic.
2959 (-[SettingsController validateMenuItem:]):
2960 Validate menu items; since they can be used to toggle the default state of a setting,
2961 we'll always return YES. However, we will use this opportunity to set the 'checked' state
2965 (-[SettingsController _toggleBooleanDefault:]):
2966 Toggle the given boolean default, and notify BrowserAppDelegate that something changed.
2968 (-[SettingsController toggleUseWebKit2ByDefault:]):
2969 (-[SettingsController useWebKit2ByDefault]):
2970 (-[SettingsController toggleUseTransparentWindows:]):
2971 (-[SettingsController useTransparentWindows]):
2972 (-[SettingsController toggleUsePaginatedMode:]):
2973 (-[SettingsController usePaginatedMode]):
2974 (-[SettingsController toggleUseUISideCompositing:]):
2975 (-[SettingsController useUISideCompositing]):
2976 (-[SettingsController toggleShowLayerBorders:]):
2977 (-[SettingsController layerBordersVisible]):
2978 (-[SettingsController toggleShowTiledScrollingIndicator:]):
2979 (-[SettingsController tiledScrollingIndicatorVisible]):
2980 (-[SettingsController toggleEnableSubPixelCSSOMMetrics:]):
2981 (-[SettingsController subPixelCSSOMMetricsEnabled]):
2982 (-[SettingsController defaultURL]):
2983 Toggle or return the current state of each preference.
2985 * MiniBrowser/mac/WK1BrowserWindowController.m:
2986 (-[WK1BrowserWindowController awakeFromNib]):
2987 (-[WK1BrowserWindowController validateMenuItem:]):
2988 (-[WK1BrowserWindowController windowWillClose:]):
2989 (-[WK1BrowserWindowController find:]):
2990 (-[WK1BrowserWindowController dumpSourceToConsole:]):
2991 (-[WK1BrowserWindowController didChangeSettings]):
2992 (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
2993 (-[WK1BrowserWindowController isPaginated]): Deleted.
2994 (-[WK1BrowserWindowController togglePaginationMode:]): Deleted.
2995 (-[WK1BrowserWindowController toggleTransparentWindow:]): Deleted.
2996 (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
2997 (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
2998 (-[WK1BrowserWindowController layerBordersVisible]): Deleted.
2999 (-[WK1BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
3000 * MiniBrowser/mac/WK2BrowserWindowController.m:
3001 (-[WK2BrowserWindowController awakeFromNib]):
3002 (-[WK2BrowserWindowController validateMenuItem:]):
3003 (-[WK2BrowserWindowController forceRepaint:]):
3004 (-[WK2BrowserWindowController windowWillClose:]):
3005 (-[WK2BrowserWindowController didChangeSettings]):
3006 (-[WK2BrowserWindowController isPaginated]): Deleted.
3007 (-[WK2BrowserWindowController togglePaginationMode:]): Deleted.
3008 (-[WK2BrowserWindowController toggleTransparentWindow:]): Deleted.
3009 (-[WK2BrowserWindowController isUISideCompositingEnabled]): Deleted.
3010 (-[WK2BrowserWindowController toggleUISideCompositing:]): Deleted.
3011 (-[WK2BrowserWindowController layerBordersVisible]): Deleted.
3012 (-[WK2BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
3013 (-[WK2BrowserWindowController tiledScrollingIndicatorVisible]): Deleted.
3014 (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]): Deleted.
3016 2014-08-01 Tim Horton <timothy_horton@apple.com>
3018 MiniBrowser doesn't support data URLs
3019 https://bugs.webkit.org/show_bug.cgi?id=135492
3021 Reviewed by Simon Fraser.
3023 * MiniBrowser/mac/BrowserWindowController.m:
3024 (-[BrowserWindowController addProtocolIfNecessary:]):
3025 Don't add http:// to data: URLs.
3027 * MiniBrowser/mac/WK2BrowserWindowController.m:
3028 (-[WK2BrowserWindowController fetch:]):
3029 (-[WK2BrowserWindowController updateTextFieldFromURL:]):
3030 Percent-escape the contents of the address field before trying to make a URL.
3031 Percent-unescape the URL when displaying it in the address field.
3032 This is not great, but trivial and good-enough-for-Minibrowser.
3034 2014-07-31 Ryuan Choi <ryuan.choi@samsung.com>
3036 [EFL][WK2] MiniBrower comes to crash when combo box is pressed
3037 https://bugs.webkit.org/show_bug.cgi?id=135378
3039 Reviewed by Gyuyoung Kim.
3041 "clicked" signal of elm_menu is emitted after EwkView calls popup_menu_hide
3042 and removes Ewk_Popup_Menu instance.
3044 * MiniBrowser/efl/main.c:
3045 (on_popup_menu_show):
3046 (on_popup_menu_discarded): Deleted.
3048 2014-07-31 Brent Fulgham <bfulgham@apple.com>
3050 [Win] Use RC_PROJECTBUILDVERSION as build portion of version
3051 https://bugs.webkit.org/show_bug.cgi?id=135478
3053 Reviewed by David Kilzer.
3055 Add new test suite for the version-stamp program.
3057 * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Added.
3059 2014-07-31 Dan Bernstein <mitz@apple.com>
3061 Reverted r171893, because it broke http/tests/appcache/different-https-origin-resource-main.html,
3062 which loads HTTPS content without calling the delegate.
3064 Rubber-stamped by Alexey Proskuryakov.
3066 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3067 (WTR::InjectedBundle::platformInitialize):
3068 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3069 (WTR::InjectedBundle::platformInitialize):
3071 2014-07-31 Brent Fulgham <bfulgham@apple.com>
3073 Unreviewed typo correction (and build fix).
3075 * MiniBrowser/mac/WK2BrowserWindowController.m:
3076 (-[WK2BrowserWindowController awakeFromNib]): Use correct
3077 property name (_fullScreenIsEnabled -> _fullScreenEnabled)
3079 2014-07-31 Brent Fulgham <bfulgham@apple.com>
3081 MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
3082 https://bugs.webkit.org/show_bug.cgi?id=135482
3084 Reviewed by Simon Fraser.
3086 * MiniBrowser/mac/WK2BrowserWindowController.m:
3087 (-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
3090 2014-07-31 Alexey Proskuryakov <ap@apple.com>
3092 [Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
3093 https://bugs.webkit.org/show_bug.cgi?id=135472
3095 Reviewed by Dan Bernstein.
3097 We now handle server trust challenges, and don't need such hacks.
3099 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3100 (WTR::InjectedBundle::platformInitialize):
3101 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3102 (WTR::InjectedBundle::platformInitialize):
3104 2014-07-31 Alexey Proskuryakov <ap@apple.com>
3106 media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
3107 on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
3108 https://bugs.webkit.org/show_bug.cgi?id=135418
3110 Reviewed by Anders Carlsson.
3112 This was only happening in shared web process mode, because WKBundlePostMessage
3113 has different behavior then. When there is no process, the message is dropped on
3114 the floor in multiple process mode, but it's stored to be delivered after launch
3115 in shared process mode.
3117 So, calling resetStateToConsistentValues() resulted in storing a Reset bundle message
3118 that was delivered immediately after launch, when there was nothing to reset.
3120 We don't actually need to reset anything at this point, as the previous call has
3121 already reset everything UI process side, and web process is brand new. All we need
3122 is to reattach the page to a process, as invoke() expects one to exist.
3124 * WebKitTestRunner/TestController.cpp: (WTR::TestController::reattachPageToWebProcess):
3125 * WebKitTestRunner/TestController.h:
3126 * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
3128 2014-07-31 Dan Bernstein <mitz@apple.com>
3130 [WK2] Regression tests can't load HTTPS pages with NetworkProcess due to self-signed certificate
3131 https://bugs.webkit.org/show_bug.cgi?id=115282
3133 Reviewed by Sam Weinig.
3135 * WebKitTestRunner/TestController.cpp:
3136 (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true for any
3137 local host server trust protection space.
3138 (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Respond with a non-empty
3139 credential to server trust challenges.
3141 2014-07-31 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>
3143 [webkitpy] Make diff_text generate correct diff if there is no newline at the end of file
3144 https://bugs.webkit.org/show_bug.cgi?id=135381
3146 Reviewed by Csaba Osztrogonác.
3148 * Scripts/webkitpy/port/base.py:
3150 * Scripts/webkitpy/port/base_unittest.py:
3151 (PortTest.test_diff_text):
3153 2014-07-31 Carlos Garcia Campos <cgarcia@igalia.com>
3155 Unreviewed. Fix GTK+ make distcheck.
3158 (ensure_version_if_possible): Use 4.0 instead of 3.0 as binary
3159 version to find the pkg-config file.
3160 * gtk/manifest.txt: Add missing resource to the tarball.
3162 2014-07-31 Carlos Garcia Campos <cgarcia@igalia.com>
3164 [GTK] make distcheck is building from sources dir instead of dist dir
3165 https://bugs.webkit.org/show_bug.cgi?id=135457
3167 Reviewed by Philippe Normand.
3170 (Distcheck.configure): Use dist_dir as source dir.
3171 (Distcheck.check): Pass dist_dir to configure().
3173 2014-07-31 Carlos Garcia Campos <cgarcia@igalia.com>
3175 [GTK] Do not include files that are not in git in the tarball
3176 https://bugs.webkit.org/show_bug.cgi?id=134804
3178 Reviewed by Philippe Normand.
3180 Skip all files in the source tree that are not under version control
3181 except for files added from the build dir like the documentation.
3184 (Directory.__init__): Initialize the list of files under control version.
3185 (Directory.list_cms_files): Helper function to list all files
3186 under the control version for the current source root.
3187 (Directory.should_skip_file): Return True for files that are not
3188 under control version only when the source root is also under
3190 (Directory.get_files): Filter the files also using should_skip_file().
3192 2014-07-29 David Farler <dfarler@apple.com>
3194 iOS Simulator LayoutTestRelay
3195 https://bugs.webkit.org/show_bug.cgi?id=135269
3197 Reviewed by David Kilzer.
3199 * LayoutTestRelay/Configurations/Base.xcconfig: Added.
3200 * LayoutTestRelay/Configurations/DebugRelease.xcconfig: Added.
3201 * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: Added.
3202 * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.h: Added.
3203 * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.m: Added.
3204 (-[LTPipeRelay inPipePath]):
3205 (-[LTPipeRelay outPipePath]):
3206 (-[LTPipeRelay errorPipePath]):
3207 (-[LTPipeRelay outputStream]):
3208 (-[LTPipeRelay initWithPrefix:]):
3209 (-[LTPipeRelay setup]):
3210 (-[LTPipeRelay tearDown]):
3211 (-[LTPipeRelay connect]):
3212 (-[LTPipeRelay disconnect]):
3213 (-[LTPipeRelay createFIFOs]):
3214 (-[LTPipeRelay destroyFIFOs]):
3215 (-[LTPipeRelay relayStream:]):
3216 (-[LTPipeRelay stream:handleEvent:]):
3217 * LayoutTestRelay/LayoutTestRelay/LTRelay.h: Added.
3218 * LayoutTestRelay/LayoutTestRelay/LTRelayController.h: Added.
3219 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: Added.
3220 (-[LTRelayController uniqueAppPath]):
3221 (-[LTRelayController uniqueAppURL]):
3222 (-[LTRelayController uniqueAppIdentifier]):
3223 (-[LTRelayController processName]):
3224 (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
3225 (-[LTRelayController readFileHandle:]):
3226 (-[LTRelayController receivedStandardOutputData:]):
3227 (-[LTRelayController receivedStandardErrorData:]):
3228 (-[LTRelayController disconnected]):
3229 (-[LTRelayController connected]):
3230 (-[LTRelayController crashWithMessage:]):
3231 (-[LTRelayController launchSimulator]):
3232 (-[LTRelayController bootDevice]):
3233 (-[LTRelayController createUniqueApp]):
3234 (-[LTRelayController killApp]):
3235 (-[LTRelayController launchApp]):
3236 (-[LTRelayController start]):
3237 * LayoutTestRelay/LayoutTestRelay/main.m: Added.
3239 (getTestingSimDevice):
3240 (getRequiredStringArgument):
3241 (getRemainderArguments):
3243 * LayoutTestRelay/Makefile: Added.
3244 * Tools/Scripts/build-layouttestrelay: Added.
3246 2014-07-29 Brent Fulgham <bfulgham@apple.com>
3248 [Win] Modify version numbering scheme to support 5-tuple versions
3249 https://bugs.webkit.org/show_bug.cgi?id=135400
3250 <rdar://problem/17849033>
3252 Reviewed by David Kilzer.
3254 Update test cases to recognize that we can only support Major
3255 values from 0-65535, Minor values from 0-64, Tiny values from 0-999,
3256 Micro values from 0-64, and Nano values from 0-999.
3258 * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Update
3259 test expectations for physical limits.
3261 2014-07-30 Carlos Garcia Campos <cgarcia@igalia.com>
3263 [GTK] GLib tests fail with recent GTK+ due to runtime warning about deprecated properties
3264 https://bugs.webkit.org/show_bug.cgi?id=135411
3266 Reviewed by Sergio Villar Senin.
3268 Recent versions of GTK+ now warn at runtime when a deprecated
3269 property or signal is used. A diagnostic mode was added that is
3270 enabled by default, but that can be disabled by setting
3271 G_ENABLE_DIAGNOSTIC=0. Runtime warnings are considered test
3272 failures by gtester, so we need to run the tests with the
3273 diganostic mode disabled.
3275 * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
3278 2014-07-29 Carlos Garcia Campos <cgarcia@igalia.com>
3280 [GTK] Remove WebKitCertificateInfo from WebKit2GTK+ API
3281 https://bugs.webkit.org/show_bug.cgi?id=134830
3283 Reviewed by Gustavo Noronha Silva.
3285 Update the SSL test for the API changes.
3287 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3288 (testLoadFailedWithTLSErrors):
3290 2014-07-24 David Farler <dfarler@apple.com>
3292 Add knowledge of the iOS Simulator to webkitpy
3293 http://bugs.webkit.org/show_bug.cgi?id=133963
3295 Reviewed by Simon Fraser.
3297 * Scripts/webkitdirs.pm:
3298 (argumentsForConfiguration): Add --ios-sim*
3299 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3300 --runtime and --device-type args added.
3301 * Scripts/webkitpy/port/base.py:
3302 * Scripts/webkitpy/port/driver.py: Add simulator driver.
3303 (IOSSimulatorDriver): Added.
3304 * Scripts/webkitpy/port/factory.py: Add simulator platform.
3305 * Scripts/webkitpy/port/ios.py: Added.
3307 2014-07-29 Alexey Proskuryakov <ap@apple.com>
3309 fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
3310 https://bugs.webkit.org/show_bug.cgi?id=135398
3312 Reviewed by Zalan Bujtas.
3314 * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
3315 "hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.
3317 * DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
3318 For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
3321 2014-07-29 Alexey Proskuryakov <ap@apple.com>
3323 PPT: run-webkit-tests doesn't upload crash logs to bots
3324 https://bugs.webkit.org/show_bug.cgi?id=135391
3326 Reviewed by Joseph Pecoraro.
3328 * WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):
3329 Not a fix to be proud of, but better than not having it work at all.
3331 2014-07-29 Adrian Perez de Castro <aperez@igalia.com>
3333 [GTK] Remove WebKitWebViewGroup from WebKit2 GTK+ API
3334 https://bugs.webkit.org/show_bug.cgi?id=133729
3336 Reviewed by Carlos Garcia Campos.
3338 Removes WebKitWebViewGroup, effectively reverting the changes
3339 introduced by r149117. The motivation for WebKitWebViewGroup
3340 was using the user style sheet injection API, which has been
3341 moved into WebKitUserContentManager, rendering it unneeded.
3343 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Remove tests
3344 for WebKitWebViewGroup.
3345 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3346 (testWebViewSettings):
3347 Restore the assertions that check that settings objects are
3348 released. Add test for webkit_web_view_new_with_settings().
3349 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Removed.
3351 2014-07-29 Carlos Garcia Campos <cgarcia@igalia.com>
3353 Implement webkit_web_view_load_string() in WebKit2
3354 https://bugs.webkit.org/show_bug.cgi?id=134735
3356 Reviewed by Sergio Villar Senin.
3358 Add /webkit2/WebKitWebView/load-bytes test case and simplify
3359 TestDOMXPathNSResolver by using webkit_web_view_load_bytes()
3360 instead of a soup server just to sent the Content-type header.
3362 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
3363 (testWebKitDOMXPathNSResolverNative):
3364 (testWebKitDOMXPathNSResolverCustom):
3367 (serverCallback): Deleted.
3368 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3371 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3372 (LoadTrackingTest::loadBytes):
3373 * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
3374 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3375 (WebViewTest::loadBytes):
3376 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3378 2014-07-28 Daniel Bates <dabates@apple.com>
3380 Add support for running the Clang static analyzer when building WebKit and JSC
3381 https://bugs.webkit.org/show_bug.cgi?id=134955
3383 Reviewed by Brent Fulgham.
3385 * Scripts/build-jsc: Added command line options -[no]-analyze (disabled by default).
3386 * Scripts/build-webkit: Add --analyze command line option to build-webkit to enable
3387 running the Clang static analyzer.
3388 * Scripts/webkitdirs.pm:
3389 (XcodeStaticAnalyzerOption): Added.
3391 2014-07-24 David Farler <dfarler@apple.com>
3393 Allow for multiple DumpRenderTree and WebKitTestRunner instances in the iOS Simulator
3394 https://bugs.webkit.org/show_bug.cgi?id=135272
3396 Reviewed by Simon Fraser.
3398 * DumpRenderTree/mac/DumpRenderTree.mm:
3399 (dumpRenderTree): Remove hard-coding of FIFO paths.
3400 (-[DumpRenderTree applicationDidEnterBackground:]): Create background task.
3401 (DumpRenderTreeMain): Set DumpRenderTree as UIApplication delegate.
3402 * DumpRenderTree/mac/DumpRenderTreeMac.h: bgTask ivar.
3403 * Scripts/old-run-webkit-tests: Update FIFO paths for ORWT.
3404 * WebKitTestRunner/TestController.cpp: Remove hard-coding of FIFO paths.
3405 * WebKitTestRunner/ios/TestControllerIOS.mm: Move dup2 calls to platformInitialize
3406 * WebKitTestRunner/ios/mainIOS.mm: bgTask ivar.
3407 (-[WebKitTestRunnerApp applicationDidEnterBackground:]): Create background task.
3408 (main): Set WebKitTestRunnerApp as UIApplication delegate.
3410 2014-07-24 David Farler <dfarler@apple.com>
3412 ImageDiff builds for the simulator when running iOS layout tests
3413 https://bugs.webkit.org/show_bug.cgi?id=135270
3415 Reviewed by Simon Fraser.
3417 * Scripts/build-imagediff: Added.
3419 2014-07-28 Renato Nagy <nagy.renato@stud.u-szeged.hu>
3421 Followup fix after r171594
3422 https://bugs.webkit.org/show_bug.cgi?id=135048
3424 Reviewed by Csaba Osztrogonác.
3426 * Scripts/sort-export-file: Removed extra newlines from help.
3428 2014-07-25 Anders Carlsson <andersca@apple.com>
3430 WKNavigation's properties are either always nil or don't behave as documented
3431 https://bugs.webkit.org/show_bug.cgi?id=135267
3432 <rdar://problem/17730536>
3434 Reviewed by Andreas Kling.
3436 * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3437 (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
3439 (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
3440 (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3442 2014-07-25 Michael Catanzaro <mcatanzaro@igalia.com>
3444 [GTK] install-dependencies needs to install perl-CGI on Fedora
3445 https://bugs.webkit.org/show_bug.cgi?id=135302
3447 Reviewed by Martin Robinson.
3449 * gtk/install-dependencies:
3450 Add perl-CGI to yum dependencies needed for tests
3452 2014-07-25 Renato Nagy <nagy.renato@stud.u-szeged.hu>
3454 Add --dry-run option to sort-export-file
3455 https://bugs.webkit.org/show_bug.cgi?id=135048
3457 Reviewed by Csaba Osztrogonác.
3459 Added --dry-run option to sort-export-file. Running the script with --dry-run
3460 option does not sort the export files but creates a list of the files that
3463 * Scripts/sort-export-file:
3466 2014-07-24 Michael Catanzaro <mcatanzaro@igalia.com>
3468 GTK jhbuild modules needs to build xserver with --disable-local-transport
3469 https://bugs.webkit.org/show_bug.cgi?id=135262
3471 Reviewed by Martin Robinson.
3473 * gtk/jhbuild.modules:
3474 Build X server with --disable-local-transport, since local transport
3475 is only supported on Solaris, SCO, and System V. Fixes build on
3478 2014-07-24 Michael Catanzaro <mcatanzaro@igalia.com>
3480 [GTK] build-webkit script fails under jhbuild if ACLOCAL_FLAGS is unset
3481 https://bugs.webkit.org/show_bug.cgi?id=135065
3483 Reviewed by Martin Robinson.
3485 * jhbuild/jhbuild-wrapper:
3486 (ensure_jhbuild): do not assume jhbuild sets ACLOCAL_FLAGS
3488 2014-07-23 Joseph Pecoraro <pecoraro@apple.com>
3490 Unreviewed iOS build fix after r171355.
3492 * TestWebKitAPI/Configurations/Base.xcconfig:
3493 Since all the Tests/WebKit2Cocoa tests are already explicitly skipped on iOS,
3494 simplify to skipping all the tests in the directory. PlatformUtilities are not
3495 building on iOS, which means we are missing necessary Util functions.
3497 2014-07-23 Michał Pakuła vel Rutka <m.pakula@samsung.com>
3499 [EFL] Fix build after r171454
3500 https://bugs.webkit.org/show_bug.cgi?id=135191
3502 Reviewed by Csaba Osztrogonác.
3504 * MiniBrowser/efl/CMakeLists.txt: Add path to new EWebKit2.h location .
3506 2014-07-23 Ryuan Choi <ryuan.choi@samsung.com>
3508 [EFL] Do not generate forwarding header for ewk headers
3509 https://bugs.webkit.org/show_bug.cgi?id=135147
3511 Reviewed by Gyuyoung Kim.
3513 * WebKitTestRunner/EventSenderProxy.h:
3515 2014-07-21 Sam Weinig <sam@webkit.org>
3517 [Cocoa] WKScriptMessageHandlers don't seem to function properly after navigating
3518 https://bugs.webkit.org/show_bug.cgi?id=135148
3520 Reviewed by Geoffrey Garen.
3522 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3523 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Added.
3524 (-[SimpleNavigationDelegate webView:didFinishNavigation:]):
3525 (-[ScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3527 2014-07-22 Brent Fulgham <bfulgham@apple.com>
3529 Correct handling of __VERSION_TEXT__ for 4+-tuple versions
3530 https://bugs.webkit.org/show_bug.cgi?id=135161
3531 <rdar://problem/17763546>
3533 Reviewed by David Kilzer.
3535 * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
3536 Add additional test cases to catch errors in multiple-tuple
3537 version string handling.
3539 2014-07-18 Filip Pizlo <fpizlo@apple.com>
3541 Extend exception fuzzing to the LLInt
3542 https://bugs.webkit.org/show_bug.cgi?id=135076
3544 Reviewed by Oliver Hunt.
3546 * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3548 2014-07-22 Jochen Eisinger <jochen@chromium.org>
3550 Fix my email address in contributors.json
3551 https://bugs.webkit.org/show_bug.cgi?id=135156
3553 Reviewed by Gyuyoung Kim.
3555 * Scripts/webkitpy/common/config/contributors.json:
3557 2014-07-21 Brent Fulgham <bfulgham@apple.com>
3559 Unreviewed test fix.
3561 * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Revert
3562 to older Perl 5.8 syntax for iterating over hashes to allow tests to
3563 run on Mountain Lion bots.
3565 2014-07-21 Alexey Proskuryakov <ap@apple.com>
3567 https://bugs.webkit.org/show_bug.cgi?id=135137
3568 build.webkit.org/dashboard: webkitperl failures show up as yellow, not red
3570 Reviewed by Darin Adler.
3572 webkitperl results are binary, handle them the same way we handle bindings test results.
3574 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3575 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3576 (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
3578 2014-07-21 Brent Fulgham <bfulgham@apple.com>
3580 [Win] Follow-up for r171324.
3582 * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Cygwin
3583 perl reports itself as 'cygwin'; native Windows Perl reports as
3584 'MSWin32'. We need to handle both cases.
3586 2014-07-21 Brent Fulgham <bfulgham@apple.com>
3588 Unreviewed build fix after r171319.
3590 * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: This test should
3591 only execute on Windows. It will fail on other platforms, so give it a way to
3594 2014-07-21 Brent Fulgham <bfulgham@apple.com>
3596 [Win] Extend auto-version.pl to support 5-tuple versions
3597 https://bugs.webkit.org/show_bug.cgi?id=135124
3598 <rdar://problem/17750334>
3600 Reviewed by David Kilzer.
3602 Add test cases for auto-version.pl.
3604 * Scripts/webkitperl/auto-version_unittest: Added.
3605 * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Added.
3607 2014-07-21 Dean Jackson <dino@apple.com>
3609 Allow MiniBrowser WK1 to do element fullscreen
3610 https://bugs.webkit.org/show_bug.cgi?id=135125
3612 Reviewed by Simon Fraser.
3614 Allow WK1 windows to go fullscreen using the DOM API.
3616 * MiniBrowser/mac/WK1BrowserWindowController.m:
3617 (-[WK1BrowserWindowController awakeFromNib]): Enable the preference for
3620 2014-07-21 Carlos Garcia Campos <cgarcia@igalia.com>
3622 [GTK] Documentation files are added twice to the tarball
3623 https://bugs.webkit.org/show_bug.cgi?id=135115
3625 Reviewed by Sergio Villar Senin.
3627 * gtk/manifest.txt: Remove duplicated rules.
3629 2014-07-21 Carlos Garcia Campos <cgarcia@igalia.com>
3631 [GTK] Simplify make-dist command line arguments
3632 https://bugs.webkit.org/show_bug.cgi?id=134832
3634 Reviewed by Martin Robinson.
3636 Remove --tarball-root and -o command line options and add
3637 --version, since the version can be used to build both, the
3638 tarball root and the output filename. When the version it's not
3639 provided, the pkg-config file is used to get the version. Also
3640 change the default value of build-dir to the current directory,
3641 since it's very common to call make-dist.py from the build dir.
3644 (get_tarball_root_and_output_filename_from_arguments):
3646 2014-07-21 Carlos Garcia Campos <cgarcia@igalia.com>
3648 [GTK] Reduce the size of the tarball generated by distcheck
3649 https://bugs.webkit.org/show_bug.cgi?id=134802
3651 Reviewed by Martin Robinson.
3653 Add more rules to the manifest to decide what files to add:
3655 - Do not include platform specific directories of other ports.
3656 - Do not include port specific cmake files.
3657 - Do not include Objective-C sources.
3658 - Do not include .orig and .rej files.
3659 - Do not include mac specific sandbox files.
3660 - Only include the resources we actually build.
3664 2014-07-20 KwangHyuk Kim <hyuki.kim@samsung.com>
3666 [EFL] Enable mpg123 feature for gst-plugin-bad.