Unreviewed chromium windows rebaseline for r119456.
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Python test fix attempt for Chromium Windows.
4
5         * Scripts/webkitpy/layout_tests/port/driver.py:
6         (Driver.uri_to_test):
7
8 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
9
10         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
11         https://bugs.webkit.org/show_bug.cgi?id=88243
12
13         Reviewed by Adam Barth.
14
15         * qmake/mkspecs/features/features.prf:
16
17 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
18
19         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
20         https://bugs.webkit.org/show_bug.cgi?id=88280
21
22         Unreviewed, build fix.
23
24         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
25         (TestServerProcess.test_basic):
26
27 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
28
29         test-webkitpy is hanging under cygwin
30         https://bugs.webkit.org/show_bug.cgi?id=88269
31
32         Reviewed by Ryosuke Niwa.
33
34         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
35         so we need to skip any tests that use it.
36
37         * Scripts/webkitpy/common/system/executive.py:
38         (Executive.run_in_parallel):
39         * Scripts/webkitpy/common/system/executive_unittest.py:
40         (ExecutiveTest.test_run_in_parallel):
41
42 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
43
44         test-webkitpy is failing on win32 after r115054
45         https://bugs.webkit.org/show_bug.cgi?id=88264
46
47         Reviewed by Ryosuke Niwa.
48
49         The failing http_server test was improperly suppressed (the
50         tuple was missing a comma, and so wasn't a tuple at all, just a
51         string) and so we were skipping *all* tests on win32. The right
52         way to skip a single test is to disable it inside the test
53         itself.
54
55         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
56         (TestHttpServer.test_start_cmd):
57         * Scripts/webkitpy/test/test_finder.py:
58         (TestFinder._default_names):
59         * Scripts/webkitpy/test/main.py:
60         (Tester.run): Add error message if we don't find any tests to run.
61         * Scripts/webkitpy/test/main_unittest.py:
62             
63
64 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
65
66         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
67         https://bugs.webkit.org/show_bug.cgi?id=88215
68
69         Reviewed by Martin Robinson.
70
71         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
72         for newly allocated strings.
73
74         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
75         (attributeSetToString):
76         (AccessibilityUIElement::allAttributes):
77
78 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
79
80         [GTK] Memory leaks in DumpRenderTree.cpp
81         https://bugs.webkit.org/show_bug.cgi?id=88213
82
83         Reviewed by Martin Robinson.
84
85         Fixed memory leaks in DumpRenderTree.
86
87         * DumpRenderTree/gtk/DumpRenderTree.cpp:
88         (appendString): Accepts const gchar* as the second argument.
89         (dumpFramesAsText): Free the string returned by g_strdup_printf().
90         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
91
92 2012-06-04  David Dorwin  <ddorwin@chromium.org>
93
94         Enable Chromium media player to instantiate a plugin
95         https://bugs.webkit.org/show_bug.cgi?id=87399
96
97         Reviewed by Kent Tamura.
98
99         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
100
101         * DumpRenderTree/chromium/WebViewHost.cpp:
102         (WebViewHost::createPopupMenu):
103
104 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
105
106         [GTK][WK2] Implement geolocation provider for the GTK port
107         https://bugs.webkit.org/show_bug.cgi?id=83877
108
109         Reviewed by Carlos Garcia Campos.
110
111         * gtk/generate-gtkdoc:
112         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
113
114 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
115
116         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
117         https://bugs.webkit.org/show_bug.cgi?id=87668
118
119         Reviewed by Ryosuke Niwa.
120
121         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
122         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
123         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
124
125         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
126         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
127
128 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
129
130         [EFL] Refactor ewk_view_context_paint code.
131         https://bugs.webkit.org/show_bug.cgi?id=85588
132
133         Reviewed by Hajime Morita.
134
135         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
136
137 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
138
139         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
140         https://bugs.webkit.org/show_bug.cgi?id=87869
141
142         Reviewed by Andreas Kling.
143
144         Replace %lld by PRId64 macro to print an int64_t value and silent a
145         compilation warning on 64-Bit.
146
147         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
148         (onExceededApplicationCacheQuota):
149
150 2012-06-03  Varun Jain  <varunjain@google.com>
151
152         [chromium] Add new gesture type (two finger tap) that triggers context menu.
153         https://bugs.webkit.org/show_bug.cgi?id=88173
154
155         Reviewed by Adam Barth.
156
157         * DumpRenderTree/chromium/EventSender.cpp:
158         (EventSender::EventSender):
159         (EventSender::gestureTwoFingerTap):
160         (EventSender::gestureEvent):
161         * DumpRenderTree/chromium/EventSender.h:
162         (EventSender):
163
164 2012-06-02  Zeno Albisser  <zeno@webkit.org>
165
166         Fix and enable WebGL for WebKit2 on Qt.
167         https://bugs.webkit.org/show_bug.cgi?id=86214
168
169         Enable WebGL by default for Qt MiniBrowser.
170
171         Reviewed by Noam Rosenthal.
172
173         * MiniBrowser/qt/qml/BrowserWindow.qml:
174
175 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
176
177         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
178         https://bugs.webkit.org/show_bug.cgi?id=88164
179
180         Reviewed by Kentaro Hara.
181
182         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
183         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
184
185         * Scripts/VCSUtils.pm:
186         (adjustPathForRecentRenamings):
187         (fixChangeLogPatch):
188
189 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
190
191         Rename test_expectations.txt to TestExpectations
192         https://bugs.webkit.org/show_bug.cgi?id=86690
193
194         Reviewed by Dirk Pranke.
195
196         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
197         We can the code to read test_expectations.txt once we've successfully transitioned.
198
199         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
200         (TestExpectationParser._check_path_does_not_exist):
201         (TestExpectationParser._tokenize):
202         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
203         * Scripts/webkitpy/layout_tests/port/base.py:
204         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
205         test_expectations.txt if one exists and the path to TestExpectations otherwise.
206         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
207         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
208         virtual.
209         * Scripts/webkitpy/layout_tests/port/chromium.py:
210         (ChromiumPort.path_from_chromium_base):
211         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
212         (ChromiumAndroidPort.test_expectations):
213         * Scripts/webkitpy/layout_tests/port/test.py:
214         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
215         (TestPort.__init__):
216         * Scripts/webkitpy/layout_tests/port/webkit.py:
217         (WebKitPort.baseline_search_path):
218         (WebKitPort.test_expectations):
219         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
220         tests to base as a follow up.
221         (WebKitPortTest.test_path_to_test_expectations_file):
222         (test_test_expectations):
223         (test_legacy_test_expectations):
224         * Scripts/webkitpy/style/checker.py:
225         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
226         with one for TestExpectations.
227         * Scripts/webkitpy/style/checkers/test_expectations.py:
228         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
229         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
230         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
231         test_expectations.txt.
232         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
233         (TestExpectationsTestCase.assert_lines_lint):
234         * Scripts/webkitpy/tool/commands/queries.py:
235         (PrintExpectations.__init__):
236         * Scripts/webkitpy/tool/commands/rebaseline.py:
237         (RebaselineExpectations):
238         * Scripts/webkitpy/tool/steps/commit.py:
239         (Commit._check_test_expectations):
240         * Scripts/webkitpy/tool/steps/commit_unittest.py:
241         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
242         (CommitTest.test_check_test_expectations): For TestExpectations.
243         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
244         * TestResultServer/static-dashboards/dashboard_base.js:
245         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
246         Error only when neither exists.
247         * TestResultServer/static-dashboards/flakiness_dashboard.js:
248         (processMissingAndExtraExpectations):
249         (htmlForTestsWithExpectationsButNoFailures):
250         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
251
252 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
253
254         Remove dependency from ImageDiff to WTF
255         https://bugs.webkit.org/show_bug.cgi?id=88147
256
257         Reviewed by Adam Barth.
258
259         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
260
261 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
262
263         NRWT seems to leak (more?) temp dirs
264         https://bugs.webkit.org/show_bug.cgi?id=88126
265
266         Re-land r119297 with chromium fix (weren't calling the
267         super() method if not in --test-shell mode in start().
268         Add unit tests to chromium_unittest as well to check.
269
270         * Scripts/webkitpy/layout_tests/port/chromium.py:
271         (ChromiumDriver.start):
272         * Scripts/webkitpy/layout_tests/port/webkit.py:
273         (WebKitDriver.__del__):
274         (WebKitDriver._start):
275         (WebKitDriver.run_test):
276         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
277         (WebKitDriverTest.test_check_for_driver_crash):
278         (WebKitDriverTest.test_stop_cleans_up_properly):
279         (WebKitDriverTest):
280         (WebKitDriverTest.test_two_starts_cleans_up_properly):
281         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
282         (ChromiumDriverTest.test_stop_cleans_up_properly):
283         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
284
285 2012-06-01  Tim Horton  <timothy_horton@apple.com>
286
287         Lots of "failed download-built-product" on Apple bots
288         https://bugs.webkit.org/show_bug.cgi?id=88158
289
290         Reviewed by Jessie Berlin.
291         
292         Disable mergeRequests on all Apple builders. This is a speculative fix.
293
294         * BuildSlaveSupport/build.webkit.org-config/config.json:
295
296 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
297
298         Unreviewed, rolling out r119297.
299         http://trac.webkit.org/changeset/119297
300         https://bugs.webkit.org/show_bug.cgi?id=88156
301
302         May have broken Chromium bots (Requested by rniwa on #webkit).
303
304         * Scripts/webkitpy/layout_tests/port/webkit.py:
305         (WebKitDriver.__del__):
306         (WebKitDriver.run_test):
307         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
308         (WebKitDriverTest.test_check_for_driver_crash):
309         (WebKitDriverTest.test_stop_cleans_up_properly):
310
311 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
312
313         nrwt seems to leak tmpdirs
314         https://bugs.webkit.org/show_bug.cgi?id=88126
315
316         Reviewed by Ojan Vafai.
317
318         Fix leak possibly introduced in r118979 - we now will
319         make sure we clean up any stale temp directories during the
320         start routine and attempt to clean up again in __del__. It
321         turns out that asserting in __del__ logs a message but is
322         caught by the runtime, so it's mostly useless.
323
324         * Scripts/webkitpy/layout_tests/port/webkit.py:
325         (WebKitDriver.__del__):
326         (WebKitDriver._start):
327         (WebKitDriver.run_test):
328         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
329         (WebKitDriverTest.test_check_for_driver_crash):
330         (WebKitDriverTest.test_stop_cleans_up_properly):
331         (WebKitDriverTest):
332         (WebKitDriverTest.test_two_starts_cleans_up_properly):
333
334 2012-06-01  Michael Saboff  <msaboff@apple.com>
335
336         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
337         https://bugs.webkit.org/show_bug.cgi?id=88109
338
339         Reviewed by Geoffrey Garen.
340
341         Additional test case.
342
343         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
344         (TestWebKitAPI::TEST):
345
346 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
347
348         [Qt] Use -Werror only in developer builds
349
350         Rubber-stamped by Tor Arne Vestbø.
351
352         In production builds -Werror with custom toolchains and wierd system
353         headers, -Werror is of no use and just creates confusion. So use it
354         only if Qt is configured with -developer-build.
355
356         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
357         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
358         only if qt_developer_build is set.
359
360 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
361
362         [watchlist] Add myself to loader and v8 bindings changes
363         https://bugs.webkit.org/show_bug.cgi?id=88112
364
365         Reviewed by Adam Barth.
366
367         * Scripts/webkitpy/common/config/watchlist:
368
369 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
370
371         Adding Jacky Jiang to committers.py
372         https://bugs.webkit.org/show_bug.cgi?id=88122
373
374         Reviewed by Rob Buis.
375
376         Adding myself to committers.py as a Committer.
377
378         * Scripts/webkitpy/common/config/committers.py:
379
380 2012-06-01  Jessie Berlin  <jberlin@apple.com>
381
382         Fix Windows build.
383
384         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
385
386 2012-06-01  Jessie Berlin  <jberlin@apple.com>
387
388         Windows WK2 MouseMoveAfterCrash API test failing
389         https://bugs.webkit.org/show_bug.cgi?id=69982
390
391         Disable the test on Windows to get the bots greener.
392
393         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
394         (TestWebKitAPI::TEST):
395
396 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
397
398         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
399         https://bugs.webkit.org/show_bug.cgi?id=86866
400
401         Reviewed by Adam Barth.
402
403         Catch new "intent,service,register" signal on the frame and print out
404         information about the Web Intent service in EFL's DumpRenderTree.
405
406         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
407         (DumpRenderTreeChrome::createView):
408         (DumpRenderTreeChrome::onFrameCreated):
409         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
410         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
411         (DumpRenderTreeChrome):
412
413 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
414
415         The ChangeLog parser cannot handle reviewers with initials in their name
416         https://bugs.webkit.org/show_bug.cgi?id=87864
417
418         Reviewed by Ryosuke Niwa.
419
420         Add support in the ChangeLog parser for reviewer names that have
421         initials in them.
422
423         * Scripts/webkitpy/common/checkout/changelog.py:
424         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
425         in the replacement string. This allows for matching the word characters before a
426         period, without totally throwing them away.
427         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
428         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
429         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
430
431 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
432
433         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
434         https://bugs.webkit.org/show_bug.cgi?id=86865
435
436         Reviewed by Adam Barth.
437
438         Add deliverWebIntent method to LayoutTestController and provide
439         implementation for EFL port.
440
441         * DumpRenderTree/LayoutTestController.cpp:
442         (deliverWebIntentCallback):
443         (LayoutTestController::staticFunctions):
444         * DumpRenderTree/LayoutTestController.h:
445         (LayoutTestController):
446         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
447         (LayoutTestController::deliverWebIntent):
448         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
449         (LayoutTestController::deliverWebIntent):
450         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
451         (LayoutTestController::deliverWebIntent):
452         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
453         (LayoutTestController::deliverWebIntent):
454         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
455         (LayoutTestController::deliverWebIntent):
456         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
457         (LayoutTestController::deliverWebIntent):
458
459 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
460
461         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
462
463         Reviewed by Simon Hausmann.
464
465         * Tools.pro:
466
467 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
468
469         Add public page loading performance tests using web-page-replay
470         https://bugs.webkit.org/show_bug.cgi?id=84008
471
472         Reviewed by Dirk Pranke.
473
474         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
475         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
476         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
477
478         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
479         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
480         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
481         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
482
483         * Scripts/webkitpy/layout_tests/port/driver.py:
484         (Driver.is_external_http_test): Added.
485         * Scripts/webkitpy/layout_tests/port/webkit.py:
486         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
487         * Scripts/webkitpy/performance_tests/perftest.py:
488         (PerfTest.__init__): Takes port.
489         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
490         (PerfTest):
491         (PerfTest.run): Calls run_single.
492         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
493         (ChromiumStylePerfTest.__init__):
494         (PageLoadingPerfTest.__init__):
495         (PageLoadingPerfTest.run):
496         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
497         (ReplayServer.__init__):
498         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
499         but it caused a dead lock on some web pages.
500         (ReplayServer.stop):
501         (ReplayServer.__del__):
502         (ReplayPerfTest):
503         (ReplayPerfTest.__init__):
504         (ReplayPerfTest._start_replay_server):
505         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
506         The subsequent runs of the same test will just use test.wpr.
507         (ReplayPerfTest.run_single):
508         (PerfTestFactory):
509         (PerfTestFactory.create_perf_test):
510         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
511         (MainTest.test_parse_output):
512         (MainTest.test_parse_output_with_failing_line):
513         (TestPageLoadingPerfTest.test_run):
514         (TestPageLoadingPerfTest.test_run_with_bad_output):
515         (TestReplayPerfTest):
516         (TestReplayPerfTest.ReplayTestPort):
517         (TestReplayPerfTest.ReplayTestPort.__init__):
518         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
519         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
520         (TestReplayPerfTest.ReplayTestPort._driver_class):
521         (TestReplayPerfTest.MockReplayServer):
522         (TestReplayPerfTest.MockReplayServer.__init__):
523         (TestReplayPerfTest.MockReplayServer.stop):
524         (TestReplayPerfTest._add_file):
525         (TestReplayPerfTest._setup_test):
526         (TestReplayPerfTest.test_run_single):
527         (TestReplayPerfTest.test_run_single.run_test):
528         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
529         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
530         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
531         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
532         (TestReplayPerfTest.test_prepare):
533         (TestReplayPerfTest.test_prepare.run_test):
534         (TestReplayPerfTest.test_prepare_calls_run_single):
535         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
536         (TestPerfTestFactory.test_regular_test):
537         (TestPerfTestFactory.test_inspector_test):
538         (TestPerfTestFactory.test_page_loading_test):
539         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
540         (PerfTestsRunner):
541         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
542         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
543         (PerfTestsRunner._collect_tests._is_test_file):
544         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
545         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
546         (create_runner):
547         (run_test):
548         (_tests_for_runner):
549         (test_run_test_set):
550         (test_run_test_set_kills_drt_per_run):
551         (test_run_test_pause_before_testing):
552         (test_run_test_set_for_parser_tests):
553         (test_run_test_set_with_json_output):
554         (test_run_test_set_with_json_source):
555         (test_run_test_set_with_multiple_repositories):
556         (test_run_with_upload_json):
557         (test_upload_json):
558         (test_upload_json.MockFileUploader.upload_single_text_file):
559         (_add_file):
560         (test_collect_tests):
561         (test_collect_tests_with_multile_files):
562         (test_collect_tests_with_multile_files.add_file):
563         (test_collect_tests_with_skipped_list):
564         (test_collect_tests_with_page_load_svg):
565         (test_collect_tests_should_ignore_replay_tests_by_default):
566         (test_collect_tests_with_replay_tests):
567         (test_parse_args):
568         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
569         (AutoinstallImportHook.find_module):
570         (AutoinstallImportHook._install_webpagereplay):
571
572 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
573
574         Support building the Android port of chromium with Ninja
575         https://bugs.webkit.org/show_bug.cgi?id=87545
576
577         Reviewed by Adam Barth.
578
579         Ensures that shared libraries are looked up in a generator-agnostic
580         way and that output is placed in the correct directory.
581
582         Depends on http://codereview.chromium.org/10386188/
583
584         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
585
586 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
587
588         [Chromium] Chromium DRT should be able to load external resources
589         https://bugs.webkit.org/show_bug.cgi?id=87893
590
591         Reviewed by Dirk Pranke.
592
593         Allow external resources to be loaded when the main frame's URL is also an external resource.
594         This change is analogous to r118231 for Mac port.
595
596         * DumpRenderTree/chromium/WebViewHost.cpp:
597         (blockRequest):
598         (isLocalhost):
599         (hostIsUsedBySomeTestsToGenerateError):
600         (WebViewHost::willSendRequest):
601
602 2012-05-31  Anders Carlsson  <andersca@apple.com>
603
604         Build fixes.
605
606         Disable the C++11 extensions warning.
607
608         * DumpRenderTree/mac/Configurations/Base.xcconfig:
609         * TestWebKitAPI/Configurations/Base.xcconfig:
610         * WebKitTestRunner/Configurations/Base.xcconfig:
611
612 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
613
614         [WK2] window.internals settings are not reset between tests
615         https://bugs.webkit.org/show_bug.cgi?id=87783
616
617         Reviewed by Mihai Parparita.
618
619         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
620         (WTR::InjectedBundle::done): Call resetAfterTest().
621
622         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
623         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
624         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
625         This needs to be done after a tets, because the code assumes that there is an object
626         with this name in global scope.
627
628         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
629
630 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
631
632         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
633         https://bugs.webkit.org/show_bug.cgi?id=85006
634
635         Reviewed by Tor Arne Vestbø.
636
637         Added navigation_policy_decision implementation for DumpRenderTreeView.
638         Added LayoutTestController::setCustomPolicyDelegate implementation.
639         Modified LayoutTestController::waitForPolicyDelegate.
640
641         * DumpRenderTree/efl/DumpRenderTree.cpp:
642         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
643         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
644         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
645         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
646         (navigationTypeToString): aux function
647         (onNavigationPolicyDecision): navigation_policy_decision implementation
648         (drtViewAdd):
649         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
650         (LayoutTestController::setCustomPolicyDelegate):
651         (LayoutTestController::waitForPolicyDelegate):
652
653 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
654
655         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
656         https://bugs.webkit.org/show_bug.cgi?id=86195
657
658         Reviewed by Gustavo Noronha Silva.
659
660         Implement clearApplicationCacheForOrigin in EFL
661         LayoutTestController.
662
663         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
664         (LayoutTestController::clearApplicationCacheForOrigin):
665
666 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
667
668         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
669         https://bugs.webkit.org/show_bug.cgi?id=87955
670
671         Reviewed by Simon Hausmann.
672
673         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
674         * DumpRenderTree/qt/EventSenderQt.cpp:
675         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
676         * DumpRenderTree/qt/main.cpp:
677         * QtTestBrowser/cookiejar.cpp:
678         * QtTestBrowser/launcherwindow.cpp:
679         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
680         * qmake/mkspecs/features/default_post.prf:
681
682 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
683
684         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
685
686         Rubber-stamped by Kenneth Rohde Christiansen.
687
688         * qmake/config.tests/libpng/libpng.pro:
689
690 2012-05-30  Peter Beverloo  <peter@chromium.org>
691
692         [Chromium] Automatically install 64-bit linker for Android
693         https://bugs.webkit.org/show_bug.cgi?id=79780
694
695         Reviewed by Adam Barth.
696
697         Change the update-webkit-chromium script to check whether the 64-bit
698         linker needs to be installed as part of the update process. The actual
699         code for doing these checks and "installing" it has been added to the
700         webkitdirs.pm script.
701
702         The linker itself is part of the third_party/aosp repository, which
703         will be pulled in through the DEPS change.
704
705         * Scripts/update-webkit-chromium:
706         * Scripts/webkitdirs.pm:
707         (chromiumInstall64BitAndroidLinkerIfNeeded):
708         (chromiumReplaceAndroidLinkerIfNeeded):
709
710 2012-05-30  Stephanie Lewis  <slewis@apple.com>
711
712         https://bugs.webkit.org/show_bug.cgi?id=87803
713         Layout tests often fail trying to stat nonexistent logs 
714
715         Reviewed by Dirk Pranke.
716
717         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
718         try/catch block around accessing the logs as a precaution.
719
720         * Scripts/webkitpy/common/system/crashlogs.py:
721         (CrashLogs._find_newest_log_darwin):
722
723 2012-05-30  Gavin Peters  <gavinp@chromium.org>
724
725         Add a LayoutTest for prerender remove after stop.
726         https://bugs.webkit.org/show_bug.cgi?id=87860
727
728         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
729         can be tested by LayoutTests now.
730
731         Reviewed by Adam Barth.
732
733         * DumpRenderTree/DumpRenderTree.gypi:
734         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
735         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
736         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
737         (MockWebPrerenderingSupport::add):
738         (MockWebPrerenderingSupport::cancel):
739         (MockWebPrerenderingSupport::abandon):
740         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
741         (MockWebPrerenderingSupport):
742         * DumpRenderTree/chromium/TestShell.cpp:
743         (TestShell::initialize):
744         * DumpRenderTree/chromium/TestShell.h:
745         (TestShell):
746         * DumpRenderTree/chromium/WebViewHost.cpp:
747         (WebViewHost::willAddPrerender):
748         (WebViewHost::setWebWidget):
749         * DumpRenderTree/chromium/WebViewHost.h:
750         (WebViewHost):
751
752 2012-05-30  Stephanie Lewis  <slewis@apple.com>
753
754         https://bugs.webkit.org/show_bug.cgi?id=87717
755         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
756
757         Reviewed by Dirk Pranke.
758
759         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
760         If there isn't a crash log found for the process add a message saying
761         the process was unresponsive.
762
763         * Scripts/webkitpy/layout_tests/port/webkit.py:
764         (WebKitDriver.__init__):
765         (WebKitDriver._check_for_driver_crash):
766         (WebKitDriver.run_test):
767         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
768         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
769         (WebKitDriverTest):
770         (WebKitDriverTest.test_check_for_driver_crash):
771         * WebKitTestRunner/TestController.cpp:
772         (WTR):
773         (WTR::TestController::runTest):
774
775 2012-05-30  Stephanie Lewis  <slewis@apple.com>
776
777         https://bugs.webkit.org/show_bug.cgi?id=87714
778         Mac crash logs can take a really long time to be written out.
779
780         Reviewed by Dirk Pranke.
781
782         Make a second pass looking for crash logs after the tests have completed running.
783
784         * Scripts/webkitpy/layout_tests/controllers/manager.py:
785         (use_trac_links_in_results_html):
786         (Manager.run):
787         * Scripts/webkitpy/layout_tests/port/base.py:
788         (Port.repository_paths):
789         (Port.look_for_new_crash_logs):
790         * Scripts/webkitpy/layout_tests/port/mac.py:
791         (MacPort.look_for_new_crash_logs):
792         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
793         (test_get_crash_log):
794         (test_look_for_new_crash_logs):
795         (test_look_for_new_crash_logs.fake_time_cb):
796
797 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
798
799         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
800
801         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
802         (LayoutWebViewEventHandler::OnAlertEvent):
803         (LayoutWebViewEventHandler::OnConfirmEvent):
804         (LayoutWebViewEventHandler):
805         (LayoutWebViewEventHandler::OnPromptEvent):
806         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
807         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
808
809 2012-05-30  Ojan Vafai  <ojan@chromium.org>
810
811         Only give lint errors for -expected.png png files that lack a checksum
812         https://bugs.webkit.org/show_bug.cgi?id=87875
813
814         Reviewed by Tony Chang.
815
816         We have other pngs in the tree, e.g. for the inspector, that legitimately
817         lack a checksum.
818
819         * Scripts/webkitpy/style/checkers/png.py:
820         (PNGChecker.check):
821         * Scripts/webkitpy/style/checkers/png_unittest.py:
822         (PNGCheckerTest.test_check):
823
824 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
825
826         nrwt: seems to leak temp dirs
827         https://bugs.webkit.org/show_bug.cgi?id=87795
828
829         Reviewed by Ojan Vafai.
830
831         There appears to be a bug where the chromium bots are creating
832         temporary directories and not cleaning them up that started
833         after the switch to WebKitDriver. It's possible that __del__
834         wasn't getting called in a timely manner (or at all), and it's
835         generally bad style to rely on __del__ being called, so this
836         code changes things so that we create a temp dir in
837         driver.start() and remove it in driver.stop(). We could be
838         paranoid and leave the __del__ code in, but there doesn't seem
839         to be much advantage to it. If there are bugs that result in
840         drivers being started but not stopped, we have other problems.
841
842         * Scripts/webkitpy/common/system/filesystem_mock.py:
843         (MockFileSystem.__init__):
844         (MockFileSystem._mktemp):
845         (MockFileSystem.mkdtemp):
846         * Scripts/webkitpy/layout_tests/port/webkit.py:
847         (WebKitDriver.__init__):
848         (WebKitDriver._start):
849         (WebKitDriver.stop):
850         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
851         (WebKitDriverTest.test_check_for_driver_crash):
852         (WebKitDriverTest):
853         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
854         (WebKitDriverTest.test_stop_cleans_up_properly):
855
856 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
857
858         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
859         https://bugs.webkit.org/show_bug.cgi?id=86841
860
861         Reviewed by Adam Barth.
862
863         Print the number of MessagePorts for each new intent in EFL's DRT.
864         This output is expected by several Web Intents test cases.
865
866         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
867         (DumpRenderTreeChrome::onFrameIntentNew):
868
869 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
870
871         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
872
873         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
874
875 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
876
877         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
878         https://bugs.webkit.org/show_bug.cgi?id=87829
879
880         Reviewed by Adam Barth.
881
882         EFL's LayoutTestController now makes uses of the new helper method in
883         DumpRenderTreeSupportEfl in order to send the intent response. This is
884         now needed because the Ewk_Intent_Request postResult / postFailure
885         methods were made private.
886
887         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
888         (LayoutTestController::sendWebIntentResponse):
889
890 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
891
892         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
893         https://bugs.webkit.org/show_bug.cgi?id=86296
894
895         Reviewed by Tony Chang.
896
897         * DumpRenderTree/win/DRTDataObject.cpp: Added.
898         (cfHDropFormat):
899         (cfFileNameWFormat):
900         (cfUrlWFormat):
901         (WCEnumFormatEtc):
902         (WCEnumFormatEtc::WCEnumFormatEtc):
903         (WCEnumFormatEtc::QueryInterface):
904         (WCEnumFormatEtc::AddRef):
905         (WCEnumFormatEtc::Release):
906         (WCEnumFormatEtc::Next):
907         (WCEnumFormatEtc::Skip):
908         (WCEnumFormatEtc::Reset):
909         (WCEnumFormatEtc::Clone):
910         (DRTDataObject::createInstance):
911         (DRTDataObject::DRTDataObject):
912         (DRTDataObject::~DRTDataObject):
913         (DRTDataObject::QueryInterface):
914         (DRTDataObject::AddRef):
915         (DRTDataObject::Release):
916         (DRTDataObject::GetData):
917         (DRTDataObject::GetDataHere):
918         (DRTDataObject::QueryGetData):
919         (DRTDataObject::GetCanonicalFormatEtc):
920         (DRTDataObject::SetData):
921         (DRTDataObject::CopyMedium):
922         (DRTDataObject::EnumFormatEtc):
923         (DRTDataObject::DAdvise):
924         (DRTDataObject::DUnadvise):
925         (DRTDataObject::EnumDAdvise):
926         (DRTDataObject::clearData):
927         * DumpRenderTree/win/DRTDataObject.h: Added.
928         (DRTDataObject):
929         * DumpRenderTree/win/DRTDropSource.cpp: Added.
930         (DRTDropSource::DRTDropSource):
931         (DRTDropSource::~DRTDropSource):
932         (DRTDropSource::QueryInterface):
933         (DRTDropSource::AddRef):
934         (DRTDropSource::Release):
935         (DRTDropSource::createInstance):
936         (DRTDropSource::QueryContinueDrag):
937         (DRTDropSource::GiveFeedback):
938         * DumpRenderTree/win/DRTDropSource.h: Added.
939         (DRTDropSource):
940         * DumpRenderTree/win/DumpRenderTree.vcproj:
941         * DumpRenderTree/win/EventSender.cpp:
942         (beginDragWithFilesCallback):
943
944 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
945
946         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
947         https://bugs.webkit.org/show_bug.cgi?id=58593
948
949         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
950         to WebKitTestRunner's LayoutTestController. The flag is modified via the
951         public C API of the WebProcess.
952
953         Reviewed by Darin Adler.
954
955         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
956         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
957         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
958         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
959         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
960
961 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
962
963         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
964         https://bugs.webkit.org/show_bug.cgi?id=87848
965
966         Reviewed by Csaba Osztrogonác.
967
968         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
969         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
970         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
971
972         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
973         (DumpRenderTreeChrome::extraViews):
974         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
975         (DumpRenderTreeChrome):
976
977 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
978
979         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
980         https://bugs.webkit.org/show_bug.cgi?id=87833
981
982         Reviewed by Tor Arne Vestbø.
983
984         Print "postProgressFinishedNotification" message if frame load finished 
985         to unskip http/tests/loading/progress-finished-callback.html.
986
987         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
988         (DumpRenderTreeChrome::onFrameLoadFinished):
989
990 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
991
992         [EFL][WK2] Fix WebKit2-EFL build
993         https://bugs.webkit.org/show_bug.cgi?id=83693
994
995         Reviewed by Carlos Garcia Campos.
996
997         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
998
999 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
1000
1001         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
1002         (They only used to check for Skipped in platform/qt-5.0-wk1)
1003         https://bugs.webkit.org/show_bug.cgi?id=87376
1004
1005         Reviewed by Csaba Osztrogonác.
1006
1007         * Scripts/old-run-webkit-tests:
1008         (buildPlatformResultHierarchy):
1009         * Scripts/webkitpy/layout_tests/port/qt.py:
1010         (QtPort.baseline_search_path):
1011
1012 2012-05-29  Ojan Vafai  <ojan@chromium.org>
1013
1014         Add a linter error for pngs that lack an embedded checksum
1015         https://bugs.webkit.org/show_bug.cgi?id=87793
1016
1017         Reviewed by Dirk Pranke.
1018
1019         * Scripts/read-checksum-from-png:
1020         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
1021         (read_checksum):
1022         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
1023         (ReadChecksumFromPngTest):
1024         (ReadChecksumFromPngTest.test_read_checksum):
1025         * Scripts/webkitpy/layout_tests/port/base.py:
1026         * Scripts/webkitpy/style/checkers/png.py:
1027         (PNGChecker.check):
1028         * Scripts/webkitpy/style/checkers/png_unittest.py:
1029         (PNGCheckerTest.test_check):
1030
1031 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1032
1033         https://bugs.webkit.org/show_bug.cgi?id=87720
1034         WebProcess is often killed due to being unresponsive on the bots
1035
1036         Reviewed by Alexey Proskuryakov.
1037
1038         Blind attempt to improve flakiness on the bots by reducing the number
1039         of crashes due to an unresponsive process.  This helped on my personal machine
1040         under stress conditions.  I don't have enough cores to hit the problem
1041         under normal conditions.
1042
1043         * WebKitTestRunner/TestController.cpp:
1044         (WTR):
1045
1046 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1047
1048         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
1049         https://bugs.webkit.org/show_bug.cgi?id=87779
1050
1051         Reviewed by Eric Seidel.
1052
1053         Update output to match the names in scm.py as per
1054         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
1055
1056         * Scripts/webkitpy/tool/commands/rebaseline.py:
1057         (RebaselineTest.execute):
1058         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1059         (test_rebaseline_test_and_print_scm_changes):
1060         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1061         (GardeningServerTest.test_rebaselineall):
1062
1063 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1064
1065         https://bugs.webkit.org/show_bug.cgi?id=87711
1066
1067         Reviewed by Jessie Berlin.
1068
1069         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
1070         are better maintained.
1071
1072         * BuildSlaveSupport/build.webkit.org-config/config.json:
1073
1074 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1075
1076         webkit-patch optimize-baselines should add/delete files in batches from the vcs
1077         https://bugs.webkit.org/show_bug.cgi?id=87538
1078
1079         Reviewed by Ojan Vafai.
1080
1081         Invoking git and svn on one file at a time is kinda slow. We
1082         should batch the add and rm operations together.
1083
1084         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1085         (BaselineOptimizer._move_baselines):
1086
1087 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1088
1089         garden-o-matic should rebaseline baselines in parallel
1090         https://bugs.webkit.org/show_bug.cgi?id=87451
1091
1092         Reviewed by Ojan Vafai.
1093                                                                                
1094         This modifies garden-o-matic so that we will fetch all                  
1095         of the baselines in parallel from the bots, and then                    
1096         optimize the baselines serially (since that should be fairly            
1097         quick and we get into trouble if we optimize in parallel due            
1098         to concurrent access to the source control system).                     
1099
1100         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
1101         so that the files that need to be modified in the SCM are returned to 
1102         garden-o-matic rather than actually added or removed. This is done so that
1103         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
1104         concurrently). In order to safely return the files (as a JSON dict) I
1105         needed to shift all of the logging in rebaseline-test to use the logging
1106         module (and hence log to stderr).
1107
1108         I also had to stub out a line in chromium.py that would get confused if
1109         the skia overrides file didn't exist in a mock checkout.
1110
1111         * Scripts/webkitpy/common/system/executive.py:
1112         (Executive.popen):
1113         (Executive):
1114         (Executive.run_in_parallel):
1115         (_run_command_thunk):
1116         * Scripts/webkitpy/common/system/executive_mock.py:
1117         (MockExecutive.run_in_parallel):
1118         * Scripts/webkitpy/common/system/executive_unittest.py:
1119         (ExecutiveTest.test_run_in_parallel):
1120         * Scripts/webkitpy/layout_tests/port/chromium.py:
1121         (ChromiumPort._expectations_file_contents):
1122         * Scripts/webkitpy/tool/commands/rebaseline.py:
1123         (AbstractRebaseliningCommand.__init__):
1124         (RebaselineTest.__init__):
1125         (RebaselineTest._copy_existing_baseline):
1126         (RebaselineTest._save_baseline):
1127         (RebaselineTest):
1128         (RebaselineTest._add_to_scm):
1129         (RebaselineTest._rebaseline_test):
1130         (RebaselineTest.execute):
1131         (RebaselineExpectations._rebaseline_port):
1132         (RebaselineExpectations.execute):
1133         (Rebaseline._builder_to_pull_from):
1134         (Rebaseline.execute):
1135         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1136         (test_rebaseline_updates_expectations_file):
1137         (test_rebaseline_test):
1138         (test_rebaseline_test_and_print_scm_changes):
1139         (test_rebaseline_and_copy_test):
1140         (test_rebaseline_and_copy_test_no_existing_result):
1141         (test_rebaseline_and_copy_test_with_lion_result):
1142         (test_rebaseline_and_copy_no_overwrite_test):
1143         (test_rebaseline_expectations):
1144         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1145         (GardeningHTTPRequestHandler._rebaseline_commands):
1146         (GardeningHTTPRequestHandler):
1147         (GardeningHTTPRequestHandler._files_to_add):
1148         (GardeningHTTPRequestHandler._optimize_baselines):
1149         (GardeningHTTPRequestHandler.rebaselineall):
1150         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1151         (GardeningServerTest._post_to_path):
1152         (GardeningServerTest.test_rebaselineall):
1153         (GardeningServerTest.test_rebaselineall.run_command):
1154
1155 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
1156
1157         Fix the type of dispatch_time() offset
1158
1159         Rubber-stamped by Joseph Pecoraro.
1160
1161         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
1162
1163         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1164         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1165
1166 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1167
1168         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1169
1170         [BlackBerry] OpenGL content is not rendered on simulator
1171         https://bugs.webkit.org/show_bug.cgi?id=87721
1172
1173         Reviewed by George Staikos.
1174
1175         Fixed by enabling GLES2 support in simulator builds.
1176
1177         To experiment with building without OpenGL support, you can set the
1178         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
1179
1180         PR #150695
1181
1182         * Scripts/webkitdirs.pm:
1183         (blackberryCMakeArguments):
1184
1185 2012-05-29  David Barr  <davidbarr@chromium.org>
1186
1187         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
1188         https://bugs.webkit.org/show_bug.cgi?id=87685
1189
1190         Reviewed by Eric Seidel.
1191
1192         Add a configuration option for CSS image-resolution support, disabling it by default.
1193
1194         * Scripts/webkitperl/FeatureList.pm:
1195         * qmake/mkspecs/features/features.pri:
1196
1197 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1198
1199         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
1200
1201         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
1202             valid for C++/ObjC++ but not for C [enabled by default]"
1203
1204         Reviewed by Simon Hausmann.
1205
1206         * qmake/mkspecs/features/unix/default_post.prf:
1207
1208 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1209
1210         [Qt] Sync up favicon-implementation with WebView url changes in r118158
1211
1212         https://bugs.webkit.org/show_bug.cgi?id=87133
1213
1214         We now base64-encode the page url in the image-provider url, so that any
1215         normalization done by QUrl will not mess up the page-url. The logic of
1216         creating and parsing the provider-url has been moved into the image
1217         provider, to keep it in one place.
1218
1219         We were also releasing icons (even ones we hadn't retained), which we can't
1220         do since we don't know when the icon url is no longer in use.
1221
1222         Reviewed-by Simon Hausmann.
1223
1224         * MiniBrowser/qt/icons/favicon.png:
1225         * MiniBrowser/qt/qml/BrowserWindow.qml:
1226
1227 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1228
1229         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
1230         https://bugs.webkit.org/show_bug.cgi?id=87654
1231
1232         Reviewed by Csaba Osztrogonác.
1233
1234         Event sender provides strings for all the key events.
1235         Also KeyEventInfo constructor parameters order was changed to simplify the case when
1236         a key event has empty string.
1237
1238         * DumpRenderTree/efl/EventSender.cpp:
1239         (KeyEventInfo::KeyEventInfo):
1240         (keyPadNameFromJSValue):
1241         (keyNameFromJSValue):
1242
1243 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1244
1245         [Qt] Cancel potential url-edit when going back/forward
1246
1247         Reviewed by Kenneth Rohde Christiansen.
1248
1249         * MiniBrowser/qt/qml/BrowserWindow.qml:
1250
1251 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
1252
1253         [EFL] Compilation warning in DumpRenderTreeView.cpp
1254         https://bugs.webkit.org/show_bug.cgi?id=87636
1255
1256         Reviewed by Filip Pizlo.
1257
1258         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
1259         specifier in printf. Also fix the return type for
1260         onExceededApplicationCacheQuota callback.
1261
1262         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1263         (onExceededApplicationCacheQuota):
1264
1265 2012-05-29  Hironori Bono  <hbono@chromium.org>
1266
1267         Adding Hironori Bono to committers.py.
1268         https://bugs.webkit.org/show_bug.cgi?id=87697
1269
1270         * Scripts/webkitpy/common/config/committers.py:
1271
1272 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1273
1274         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
1275         https://bugs.webkit.org/show_bug.cgi?id=80135
1276
1277         Reviewed by Rob Buis.
1278
1279         Implemented interface function didReceiveAuthenticationChallenge in class
1280         DumpRenderTree.
1281
1282         Resubmit the patch reverted by r115104 after the digest infinite loop
1283         issue for BlackBerry porting get identified and fixed.
1284
1285         Internally reviewed by Joe Mason <jmason@rim.com>
1286
1287         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1288         (drtCredentialDescription):
1289         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
1290         (WebKit):
1291         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1292         (WebCore):
1293         (DumpRenderTree):
1294
1295 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1296
1297         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
1298         https://bugs.webkit.org/show_bug.cgi?id=42328
1299
1300         Reviewed by Eric Seidel.
1301
1302         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
1303         move to windows.internals.settings.
1304
1305         * DumpRenderTree/LayoutTestController.cpp:
1306         (LayoutTestController::staticFunctions):
1307         * DumpRenderTree/LayoutTestController.h:
1308         (LayoutTestController):
1309         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1310         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1311         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1312         (DRTDevToolsAgent):
1313         * DumpRenderTree/chromium/LayoutTestController.cpp:
1314         (LayoutTestController::LayoutTestController):
1315         * DumpRenderTree/chromium/LayoutTestController.h:
1316         (LayoutTestController):
1317         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1318         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1319         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1320         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1321         * DumpRenderTree/mac/DumpRenderTree.mm:
1322         (resetWebViewToConsistentStateBeforeTesting):
1323         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1324         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1325         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1326         (LayoutTestController):
1327         * DumpRenderTree/win/DumpRenderTree.cpp:
1328         (resetWebViewToConsistentStateBeforeTesting):
1329         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1330         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1331         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1332         (LayoutTestController):
1333
1334 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1335
1336         Move allowRoundingHacks to Internals interface
1337         https://bugs.webkit.org/show_bug.cgi?id=87328
1338
1339         Reviewed by Hajime Morita.
1340
1341         Remove allowRoundingHacks functions, because it is able to work in the
1342         cross-port way through the Internals interface.
1343
1344         * DumpRenderTree/LayoutTestController.cpp:
1345         (LayoutTestController::staticFunctions):
1346         * DumpRenderTree/LayoutTestController.h:
1347         (LayoutTestController):
1348         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1349         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1350         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1351         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1352         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1353         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1354
1355 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
1356
1357         Fix mac build with older XCode by defining NSEC_PER_MSEC.
1358         https://bugs.webkit.org/show_bug.cgi?id=87616
1359
1360         Reviewed by Hajime Morita.
1361
1362         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
1363         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
1364         Patch just adds a #ifndef / #define check.
1365
1366         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1367         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1368
1369 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1370
1371         [EFL] Enable blob support for the EFL port
1372         https://bugs.webkit.org/show_bug.cgi?id=85363
1373
1374         Reviewed by Hajime Morita.
1375
1376         Enable Blob support by default for the EFL port.
1377
1378         * Scripts/webkitperl/FeatureList.pm:
1379
1380 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
1381
1382         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
1383         https://bugs.webkit.org/show_bug.cgi?id=87582
1384
1385         Reviewed by Darin Adler.
1386
1387         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
1388         possible to test pages in a similar way as they are loaded in Browsers.
1389
1390         * DumpRenderTree/LayoutTestController.cpp:
1391         (LayoutTestController::LayoutTestController):
1392         (setUseDeferredFrameLoadingCallback):
1393         (LayoutTestController::staticFunctions):
1394         * DumpRenderTree/LayoutTestController.h:
1395         (LayoutTestController::useDeferredFrameLoading):
1396         (LayoutTestController::setUseDeferredFrameLoading):
1397         (LayoutTestController):
1398         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1399         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1400
1401 2012-05-27  David Barton  <dbarton@mathscribe.com>
1402
1403         [watchlist] Improve MathML rule
1404         https://bugs.webkit.org/show_bug.cgi?id=87592
1405
1406         Reviewed by Adam Barth.
1407
1408         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
1409         but if this changed the rule would be slow. We protect against this, clarify the rule,
1410         and make it more similar to existing rules.
1411
1412         * Scripts/webkitpy/common/config/watchlist:
1413
1414 2012-05-27  David Barton  <dbarton@mathscribe.com>
1415
1416         [watchlist] Add myself & a rule for MathML
1417         https://bugs.webkit.org/show_bug.cgi?id=87586
1418
1419         Reviewed by Adam Barth.
1420
1421         * Scripts/webkitpy/common/config/watchlist:
1422
1423 2012-05-26  David Kilzer  <ddkilzer@apple.com>
1424
1425         Use xcrun to find path to nm for Mac port
1426         <http://webkit.org/b/87588>
1427
1428         Reviewed by Dan Bernstein.
1429
1430         * Scripts/webkitpy/layout_tests/port/mac.py:
1431         (MacPort.nm_command): Add. Tries to find a path for the nm
1432         command using xcrun.  Falls back to returning 'nm'.
1433         * Scripts/webkitpy/layout_tests/port/webkit.py:
1434         (WebKitPort.nm_command): Add. Returns 'nm'.
1435         (WebKitPort._webcore_symbols_string): Call self.nm_command().
1436
1437 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
1438
1439         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
1440
1441         Reviewed by Eric Seidel.
1442
1443         * DumpRenderTree/win/DumpRenderTree.vcproj:
1444         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1445         (FrameLoadDelegate::FrameLoadDelegate):
1446         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1447         * DumpRenderTree/win/FrameLoadDelegate.h:
1448         (FrameLoadDelegate):
1449         * DumpRenderTree/win/TextInputController.cpp: Added.
1450         (setMarkedTextCallback):
1451         (hasMarkedTextCallback):
1452         (unmarkTextCallback):
1453         (markedRangeCallback):
1454         (insertTextCallback):
1455         (firstRectForCharacterRangeCallback):
1456         (selectedRangeCallback):
1457         (TextInputController::makeWindowObject):
1458         (TextInputController::getJSClass):
1459         (TextInputController::staticValues):
1460         (TextInputController::staticFunctions):
1461         * DumpRenderTree/win/TextInputController.h: Added.
1462         (TextInputController):
1463         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
1464         (TextInputController::setMarkedText):
1465         (TextInputController::hasMarkedText):
1466         (TextInputController::unmarkText):
1467         (TextInputController::markedRange):
1468         (TextInputController::insertText):
1469         (TextInputController::firstRectForCharacterRange):
1470         (TextInputController::selectedRange):
1471
1472 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
1473
1474         webkitpy: change scm.add(), scm.delete() to accept multiple paths
1475         https://bugs.webkit.org/show_bug.cgi?id=87528
1476
1477         Reviewed by Ojan Vafai.
1478
1479         launching git or svn for individual files can be slow; this
1480         change will hand multiple paths at once to git and svn so they
1481         can be added in a batch.
1482
1483         * Scripts/webkitpy/common/checkout/scm/git.py:
1484         (Git.add_list):
1485         (Git.delete_list):
1486         * Scripts/webkitpy/common/checkout/scm/scm.py:
1487         (SCM.add):
1488         (SCM):
1489         (SCM.add_list):
1490         (SCM.delete):
1491         (SCM.delete_list):
1492         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1493         (MockSCM.add):
1494         (MockSCM):
1495         (MockSCM.add_list):
1496         (MockSCM.delete):
1497         (MockSCM.delete_list):
1498         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1499         (_shared_test_exists):
1500         (_shared_test_added_files):
1501         (_test_delete_list):
1502         * Scripts/webkitpy/common/checkout/scm/svn.py:
1503         (SVN.add_list):
1504         (SVN.delete_list):
1505
1506 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1507
1508         [NRWT] Add unit testing for perf tests on locked shards
1509         https://bugs.webkit.org/show_bug.cgi?id=87489
1510
1511         Reviewed by Dirk Pranke.
1512
1513         Adding utests that makes sure that perf tests are running in locked
1514         shards and by passing --no-http won't break NRWT (r118421).
1515
1516         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1517         (ShardingTests):
1518         (ShardingTests.test_shard_by_dir):
1519         (ShardingTests.test_shard_every_file):
1520         (ShardingTests.test_shard_in_two):
1521         (ShardingTests.test_multiple_locked_shards):
1522         (LockCheckingManager):
1523         (LockCheckingManager.__init__):
1524         (LockCheckingManager.handle_finished_list):
1525         (ManagerTest.test_http_locking):
1526         (ManagerTest):
1527         (ManagerTest.test_perf_locking):
1528         * Scripts/webkitpy/layout_tests/port/test.py:
1529
1530 2012-05-25  Jessie Berlin  <jberlin@apple.com>
1531
1532         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
1533         https://bugs.webkit.org/show_bug.cgi?id=87511
1534
1535         Reviewed by Alexey Proskuryakov.
1536
1537         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
1538
1539         * DumpRenderTree/win/EventSender.cpp:
1540         (keyDownCallback):
1541
1542 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
1543
1544         Adding Ken Buchanan to committers.py
1545         https://bugs.webkit.org/show_bug.cgi?id=87443
1546
1547         Unreviewed.
1548
1549         Adding self to committers.py as a Committer.
1550
1551         * Scripts/webkitpy/common/config/committers.py:
1552
1553 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
1554
1555         [Qt] Buildfix for newer Qt5
1556         https://bugs.webkit.org/show_bug.cgi?id=87257
1557
1558         Reviewed by Simon Hausmann.
1559
1560         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
1561
1562 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
1563
1564         [Qt] Unreviewed fix after r118484.
1565
1566         Enable CSS_EXCLUSIONS and CSS_REGIONS.
1567         They were enabled uncoditinally before r118484.
1568
1569         * qmake/mkspecs/features/features.pri:
1570
1571 2012-05-24  Tim Horton  <timothy_horton@apple.com>
1572
1573         Add feature defines for web-facing parts of CSS Regions and Exclusions
1574         https://bugs.webkit.org/show_bug.cgi?id=87442
1575         <rdar://problem/10887709>
1576
1577         Reviewed by Dan Bernstein.
1578
1579         * Scripts/webkitperl/FeatureList.pm:
1580
1581 2012-05-24  Hironori Bono  <hbono@chromium.org>
1582
1583         Enable grammar checking on Chromium when we paste text (Take 2)
1584         https://bugs.webkit.org/show_bug.cgi?id=74393
1585
1586         Reviewed by Ryosuke Niwa.
1587
1588         This change enables grammar checking on Chromium and implements a mock grammar
1589         checker to fix a failing test.
1590
1591         * DumpRenderTree/DumpRenderTree.gypi:
1592         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
1593         (MockGrammarCheck::checkGrammarOfString):
1594         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
1595         (WebKit):
1596         (MockGrammarCheck):
1597         * DumpRenderTree/chromium/WebViewHost.cpp:
1598         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
1599
1600 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1601
1602         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
1603         https://bugs.webkit.org/show_bug.cgi?id=86842
1604
1605         Reviewed by Antonio Gomes.
1606
1607         Add support for overriding the application cache support preference
1608         through EFL's LayoutTestController.
1609
1610         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1611         (LayoutTestController::overridePreference):
1612
1613 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1614
1615         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
1616         https://bugs.webkit.org/show_bug.cgi?id=85209
1617
1618         Reviewed by Antonio Gomes.
1619
1620         Set developer extras setting called twice on the test startup. Hence, removing
1621         an unnecessary extra call which set wrong value. 
1622
1623         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1624         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1625
1626 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
1627
1628         garden-o-matic should not fetch from debug bots if it also knows about the release bots
1629         https://bugs.webkit.org/show_bug.cgi?id=86916
1630
1631         Reviewed by Adam Barth.
1632
1633         Note that if release and debug are failing differently, debug
1634         will be ignored ...
1635
1636         Note: also change the use of a fake port name from
1637         "mock-port-name" to "test-mac-leopard" to make it more friendly
1638         to the port factory ("mock" actually is a real port).
1639
1640         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1641         (GardeningHTTPRequestHandler._builders_to_fetch_from):
1642         (GardeningHTTPRequestHandler.rebaselineall):
1643         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1644         (GardeningServerTest.test_rebaselineall):
1645         (GardeningServerTest.test_rebaseline_new_port):
1646
1647 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
1648
1649         nrwt: fix baseline search path for official chrome builders
1650         https://bugs.webkit.org/show_bug.cgi?id=87432
1651
1652         Reviewed by Tony Chang.
1653
1654         The official chrome builders need to use the win7 and SL
1655         baseline paths, not the XP and Leopard paths. Linux is correct.
1656
1657         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1658         (GoogleChromeMacPort.determine_full_port_name):
1659         (GoogleChromeWinPort.determine_full_port_name):
1660         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1661         (TestGoogleChromePort._verify_baseline_search_path_startswith):
1662         (TestGoogleChromePort.test_get_google_chrome_port):
1663
1664 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1665
1666         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
1667         https://bugs.webkit.org/show_bug.cgi?id=86800
1668
1669         Reviewed by Dirk Pranke.
1670
1671         Don't launch a HTTP server with lock based only on the existence of
1672         locked shards since we now run perf on locked shards too.
1673
1674         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1675         (Manager._run_tests):
1676
1677 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
1678
1679         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
1680         https://bugs.webkit.org/show_bug.cgi?id=87128
1681
1682         Reviewed by Dirk Pranke.
1683
1684         * Scripts/webkitpy/layout_tests/port/base.py:
1685         (Port.driver_name):
1686         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1687         (ChromiumLinuxPort._path_to_driver):
1688         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1689         (ChromiumPortTest.test_driver_name_option):
1690         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1691         (ChromiumWinPort._path_to_driver):
1692         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1693         (parse_args):
1694
1695 2012-05-24  John Mellor  <johnme@chromium.org>
1696
1697         Font Boosting: Add compile flag and runtime setting
1698         https://bugs.webkit.org/show_bug.cgi?id=87394
1699
1700         Reviewed by Adam Barth.
1701
1702         Add ENABLE_FONT_BOOSTING.
1703
1704         * Scripts/webkitperl/FeatureList.pm:
1705         * qmake/mkspecs/features/features.pri:
1706
1707 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1708
1709         [EFL] [DRT] keyboard-related tests do not pass
1710         https://bugs.webkit.org/show_bug.cgi?id=85369
1711
1712         Reviewed by Gustavo Noronha Silva.
1713
1714         Add SHIFT modifier for capital letters as VK_ 
1715         codes do not distinguish between lows and caps and also to be consistent
1716         with other ports which send caps as lowercase letters with the shift key down.
1717
1718         * DumpRenderTree/efl/EventSender.cpp:
1719         (keyNameFromJSValue): 
1720
1721 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
1722
1723         [WK2] Let the client give local files universal access on a case by case basis
1724         https://bugs.webkit.org/show_bug.cgi?id=87174
1725         <rdar://problem/11024330>
1726
1727         Reviewed by Maciej Stachowiak.
1728
1729         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
1730         Added initialization of a new structure member to prevent build failure.
1731
1732 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
1733
1734         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
1735         https://bugs.webkit.org/show_bug.cgi?id=87203
1736
1737         Reviewed by Andreas Kling.
1738
1739         Add the required changes to make
1740         fast/events/keydown-leftright-keys.html pass after r118001.
1741
1742         * DumpRenderTree/efl/EventSender.cpp:
1743         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
1744         into the proper X11 keysym definitions.
1745
1746 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1747
1748         Unreviewed, rolling out r118352.
1749         http://trac.webkit.org/changeset/118352
1750         https://bugs.webkit.org/show_bug.cgi?id=87390
1751
1752         Caused 6 editing/spelling tests crash/fail on chromium in
1753         debug. (Requested by vsevik on #webkit).
1754
1755         * DumpRenderTree/DumpRenderTree.gypi:
1756         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
1757         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
1758         * DumpRenderTree/chromium/WebViewHost.cpp:
1759         (WebViewHost::finishLastTextCheck):
1760
1761 2012-05-24  Peter Beverloo  <peter@chromium.org>
1762
1763         Add John Mellor as a contributor
1764         https://bugs.webkit.org/show_bug.cgi?id=87389
1765
1766         Reviewed by Kenneth Rohde Christiansen.
1767
1768         John will be working on Font Boosting and is very involved with various
1769         web-facing subjects of Chrome for Android, such as viewport.
1770
1771         * Scripts/webkitpy/common/config/committers.py:
1772
1773 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1774
1775         [EFL][DRT] LayoutTestController's setCacheModel() implementation
1776         https://bugs.webkit.org/show_bug.cgi?id=86840
1777
1778         Reviewed by Csaba Osztrogonác.
1779
1780         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1781         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
1782         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1783         (LayoutTestController::setCacheModel): Implementation added.
1784
1785 2012-05-24  Hironori Bono  <hbono@chromium.org>
1786
1787         Enable grammar checking on Chromium when we paste text.
1788         https://bugs.webkit.org/show_bug.cgi?id=74393
1789
1790         Reviewed by Hajime Morita.
1791
1792         This change enables grammar checking on Chromium and implements a mock grammar
1793         checker to fix a failing test.
1794
1795         * DumpRenderTree/DumpRenderTree.gypi:
1796         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
1797         (MockGrammarCheck::checkGrammarOfString):
1798         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
1799         (WebKit):
1800         (MockGrammarCheck):
1801         * DumpRenderTree/chromium/WebViewHost.cpp:
1802         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
1803
1804 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
1805
1806         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
1807
1808         * qmake/mkspecs/features/features.pri:
1809
1810 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
1811
1812         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
1813         https://bugs.webkit.org/show_bug.cgi?id=86867
1814
1815         Reviewed by Adam Barth.
1816
1817         Add implementation for sendWebIntentResponse() in EFL's
1818         LayoutTestController and add empty implementation for other ports.
1819
1820         * DumpRenderTree/LayoutTestController.cpp:
1821         (sendWebIntentResponseCallback):
1822         (LayoutTestController::staticFunctions):
1823         * DumpRenderTree/LayoutTestController.h:
1824         (LayoutTestController):
1825         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1826         (LayoutTestController::sendWebIntentResponse):
1827         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1828         (DumpRenderTreeChrome::currentIntentRequest):
1829         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1830         (DumpRenderTreeChrome::onFrameIntentNew):
1831         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1832         (DumpRenderTreeChrome):
1833         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1834         (LayoutTestController::sendWebIntentResponse):
1835         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1836         (LayoutTestController::sendWebIntentResponse):
1837         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1838         (LayoutTestController::sendWebIntentResponse):
1839         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1840         (LayoutTestController::sendWebIntentResponse):
1841         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1842         (LayoutTestController::sendWebIntentResponse):
1843
1844 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
1845
1846         [EFL] The EFL port has no support for title directionality
1847         https://bugs.webkit.org/show_bug.cgi?id=86462
1848
1849         Reviewed by Gustavo Noronha Silva.
1850
1851         Update "title,changed" signal handlers in DRT and EWebLauncher to
1852         reflect the change from const char* to Ewk_Text_With_Direction* type
1853         for the title.
1854
1855         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1856         (DumpRenderTreeChrome::onTitleChanged):
1857         * EWebLauncher/main.c:
1858         (title_set):
1859         (on_title_changed):
1860         (on_key_down):
1861
1862 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1863
1864         Change EFL debug build name with more detail one
1865         https://bugs.webkit.org/show_bug.cgi?id=87254
1866
1867         Reviewed by Ryosuke Niwa.
1868
1869         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
1870         In addition, remove efl-linux-debug triggerable since nobody uses it.
1871
1872         * BuildSlaveSupport/build.webkit.org-config/config.json:
1873
1874 2012-05-23  Kangil Han  <kangil.han@samsung.com>
1875
1876         [EFL][DRT] Fix WebCore library path and rebaseline result
1877         https://bugs.webkit.org/show_bug.cgi?id=86355
1878
1879         Reviewed by Dirk Pranke.
1880
1881         Currently EFL DRT uses wrong WebCore library path when running DRT.
1882         Therefore, this patch adjusted the path correctly.
1883
1884         * Scripts/webkitpy/layout_tests/port/efl.py:
1885         (EflPort._path_to_webcore_library):
1886
1887 2012-05-23  Ojan Vafai  <ojan@chromium.org>
1888
1889         add back the ability to disable flexbox
1890         https://bugs.webkit.org/show_bug.cgi?id=87147
1891
1892         Reviewed by Tony Chang.
1893
1894         * Scripts/webkitperl/FeatureList.pm:
1895
1896 2012-05-23  Tony Chang  <tony@chromium.org>
1897
1898         Remove the Chromium Grid Layout bot from the waterfall
1899         https://bugs.webkit.org/show_bug.cgi?id=87311
1900
1901         Reviewed by Ryosuke Niwa.
1902
1903         I removed the compiler define in r117613, so we don't need a separate
1904         bot to compile/test this code.
1905
1906         * BuildSlaveSupport/build.webkit.org-config/config.json:
1907
1908 2012-05-23  Ian Vollick  <vollick@chromium.org>
1909
1910         Add vollick to list of contributors.
1911         https://bugs.webkit.org/show_bug.cgi?id=87305
1912
1913         Reviewed by Adam Barth.
1914
1915         * Scripts/webkitpy/common/config/committers.py:
1916
1917 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
1918
1919         [Chromium-Android] Fix chromium_android_unittest
1920         https://bugs.webkit.org/show_bug.cgi?id=87196
1921
1922         Reviewed by Tony Chang.
1923
1924         Update unit tests after ChromiumAndroidPort supported apk based
1925         DumpRenderTree.
1926
1927         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1928         (ChromiumAndroidPortTest):
1929         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
1930         (ChromiumAndroidPortTest.test_get_last_stacktrace):
1931         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
1932         (ChromiumAndroidDriverTest):
1933         (ChromiumAndroidDriverTest.setUp):
1934         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
1935         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
1936
1937 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1938
1939         [watchlist] Add myself and create a watch rule to catch Attribute related patches
1940         https://bugs.webkit.org/show_bug.cgi?id=87303
1941
1942         Reviewed by Alexis Menard.
1943
1944         * Scripts/webkitpy/common/config/watchlist:
1945
1946 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
1947
1948         garden-o-matic should not fetch from debug bots if it also knows about the release bots
1949         https://bugs.webkit.org/show_bug.cgi?id=86916
1950
1951         Reviewed by Adam Barth.
1952
1953         This change pushes all of the logic for rebaselining a cluster
1954         of failures (a list of tests failing a list of suffixes on a
1955         list of bots) onto the server, so there is a single call from
1956         the web page; we will then be able to optimize the performance
1957         of the rebaselining better.
1958
1959         Also remove the 'optimizebaseline' entry point on garden-o-matic
1960         (and the client-side call) since we don't need it any more.
1961
1962         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1963         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1964         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1965         (GardeningHTTPRequestHandler.rebaselineall):
1966         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1967
1968 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1969
1970         Mac DRT should be able to load external URLs for replay performance tests
1971         https://bugs.webkit.org/show_bug.cgi?id=86191
1972
1973         Reviewed by Alexey Proskuryakov.
1974
1975         Let external URL requests go through if the test file is not a local file or hosted at localhost.
1976         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
1977         "DumpRenderTree http://localhost:8000/".
1978
1979         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1980         (isLocalhost):
1981         (hostIsUsedBySomeTestsToGenerateError):
1982         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1983
1984 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
1985
1986         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
1987         debug symbols for easier debugging.
1988         https://bugs.webkit.org/show_bug.cgi?id=87151
1989
1990         Reviewed by Kevin Ollivier.
1991
1992         * waf/build/settings.py:
1993         (common_configure):
1994
1995 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1996
1997         Unreviewed. Move myself to reviewers.
1998
1999         * Scripts/webkitpy/common/config/committers.py:
2000
2001 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
2002
2003         [EFL] Implements the registerProtocolHandler method and option.
2004         https://bugs.webkit.org/show_bug.cgi?id=73638
2005
2006         Reviewed by Andreas Kling.
2007
2008         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
2009
2010 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
2011
2012         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
2013         https://bugs.webkit.org/show_bug.cgi?id=87221
2014
2015         Reviewed by Martin Robinson.
2016
2017         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
2018         rightShift key names into proper GDK key symbols.
2019
2020         * DumpRenderTree/gtk/EventSender.cpp:
2021         (createKeyPressEvent):
2022
2023 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2024
2025         [Qt] Make the web view's url property follow the active url
2026
2027         https://bugs.webkit.org/show_bug.cgi?id=77554
2028
2029         Update  the location bar in the minibrowser to behave
2030         a bit more like normal browsers in terms of when the url will change
2031         and how active focus is handled.
2032
2033         Reviewed by Simon Hausmann.
2034
2035         * MiniBrowser/qt/qml/BrowserWindow.qml:
2036
2037 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2038
2039         [Qt] Remove references to $$QT_SOURCE_TREE
2040
2041         With a modularized Qt, it's ambigious. What we really want is qtbase,
2042         which qtcore is a proxy for (we assume it will always live in qtbase).
2043
2044         Reviewed by Tor Arne Vestbø.
2045
2046         * DumpRenderTree/qt/DumpRenderTree.pro:
2047
2048 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2049
2050         [Qt] Fix qmake conditional for c++-11 compat warnings
2051
2052         Reviewed by Tor Arne Vestbø.
2053
2054         * qmake/mkspecs/features/unix/default_post.prf:
2055
2056 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2057
2058         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
2059         https://bugs.webkit.org/show_bug.cgi?id=85956
2060
2061         Reviewed by Gustavo Noronha Silva.
2062
2063         Catch new "load,provisional,failed" signal and print
2064         didFailProvisionalLoadWithError messages when LayoutTestController's
2065         dumpFrameLoadCallbacks() returns true. Also make sure the
2066         didFailLoadWithError message is not printed in case of provisional
2067         load failure.
2068
2069         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2070         (DumpRenderTreeChrome::createView):
2071         (DumpRenderTreeChrome::onFrameCreated):
2072         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
2073         (DumpRenderTreeChrome::onFrameLoadError):
2074         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2075         (DumpRenderTreeChrome):
2076
2077 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2078
2079         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
2080         https://bugs.webkit.org/show_bug.cgi?id=86366
2081
2082         Reviewed by Antonio Gomes.
2083
2084         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
2085
2086         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2087         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2088
2089 2012-05-22  Darin Adler  <darin@apple.com>
2090
2091         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
2092         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
2093
2094 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2095
2096         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
2097         https://bugs.webkit.org/show_bug.cgi?id=86922
2098
2099         Because we have new platformInit() in TestShellAndroid.cpp, and
2100         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
2101         is split into TestShellPosix.cpp and TestShellX11.cpp.
2102
2103         Reviewed by Kent Tamura.
2104
2105         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2106         * DumpRenderTree/DumpRenderTree.gypi:
2107         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
2108         (platformInit):
2109         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
2110         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
2111         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
2112         (AlarmHandler):
2113         (TestShell::waitTestFinished):
2114         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
2115         (openStartupDialog): from TestShellGtk.cpp
2116         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
2117         (setupFontconfig):
2118         (platformInit):
2119
2120 2012-05-22  Kangil Han  <kangil.han@samsung.com>
2121
2122         [EFL][DRT] Implement touch event
2123         https://bugs.webkit.org/show_bug.cgi?id=86720
2124
2125         Reviewed by Hajime Morita.
2126
2127         Currently EFL DRT doesn't support touch event.
2128         Therefore, this patch enabled it and implemented some eventSender function callbacks.
2129
2130         * DumpRenderTree/efl/EventSender.cpp:
2131         (TouchEventInfo::TouchEventInfo):
2132         (TouchEventInfo):
2133         (touchPointList):
2134         (sendTouchEvent):
2135         (addTouchPointCallback):
2136         (touchStartCallback):
2137         (updateTouchPointCallback):
2138         (touchMoveCallback):
2139         (cancelTouchPointCallback):
2140         (touchCancelCallback):
2141         (releaseTouchPointCallback):
2142         (touchEndCallback):
2143         (clearTouchPointsCallback):
2144         (setTouchModifierCallback):
2145         * Scripts/webkitperl/FeatureList.pm:
2146
2147 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2148
2149         [Chromium-Android] Fix chromium_android_unittest
2150         https://bugs.webkit.org/show_bug.cgi?id=87196
2151
2152         Not reviewed.
2153         Temporarily disable chromium_android_unittest.
2154
2155         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2156         (ChromiumAndroidPortTest):
2157         (ChromiumAndroidDriverTest):
2158
2159 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2160
2161         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
2162         https://bugs.webkit.org/show_bug.cgi?id=64313
2163
2164         Reviewed by Jon Honeycutt.
2165
2166         Add it.
2167
2168         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2169         Make sure to generate the binding.
2170
2171         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2172         (WTR::LayoutTestController::setDefersLoading):
2173         Call WKBundlePageSetDefersLoading.
2174         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2175
2176 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2177
2178         [Chromium-Android] Run DumpRenderTree as an apk (python part)
2179         https://bugs.webkit.org/show_bug.cgi?id=86923
2180
2181         chromium_android.py is modified to support running DumpRenderTree as
2182         an apk, so that we can run the tests (e.g. video) requiring features
2183         implemented in Java on Android.
2184
2185         Reviewed by Adam Barth.
2186
2187         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2188         (ChromiumAndroidPort.__init__):
2189         (ChromiumAndroidPort.default_child_processes):
2190         (ChromiumAndroidPort.check_wdiff):
2191         (ChromiumAndroidPort.check_build):
2192         (ChromiumAndroidPort.start_helper):
2193         (ChromiumAndroidPort.skipped_layout_tests):
2194         (ChromiumAndroidPort):
2195         (ChromiumAndroidPort._path_to_driver):
2196         (ChromiumAndroidPort._get_crash_log):
2197         (ChromiumAndroidPort._push_executable):
2198         (ChromiumAndroidPort._run_adb_command):
2199         (ChromiumAndroidPort._get_last_stacktrace):
2200         (ChromiumAndroidPort._get_logcat):
2201         (ChromiumAndroidPort._setup_performance):
2202         (ChromiumAndroidDriver):
2203         (ChromiumAndroidDriver.__init__):
2204         (ChromiumAndroidDriver._command_wrapper):
2205         (ChromiumAndroidDriver.cmd_line):
2206         (ChromiumAndroidDriver._file_exists_on_device):
2207         (ChromiumAndroidDriver._deadlock_detector):
2208         (ChromiumAndroidDriver._start):
2209         (ChromiumAndroidDriver.run_test):
2210         (ChromiumAndroidDriver.stop):
2211         (ChromiumAndroidDriver._write_command_and_read_line):
2212         (ChromiumAndroidDriver._output_image):
2213         (ChromiumAndroidDriver._get_stderr):
2214
2215 2012-05-22  Joshua Bell  <jsbell@chromium.org>
2216
2217         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
2218
2219         Unreviewed gardening.
2220
2221         * Scripts/webkitpy/layout_tests/port/base.py:
2222         (Port.driver_name):
2223         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2224         (ChromiumLinuxPort._path_to_driver):
2225         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2226         (ChromiumPortTest.test_overrides_and_builder_names):
2227         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2228         (ChromiumWinPort._path_to_driver):
2229         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2230         (parse_args):
2231
2232 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2233
2234         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
2235         https://bugs.webkit.org/show_bug.cgi?id=87176
2236
2237         Reviewed by Tony Chang.
2238
2239         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2240         * DumpRenderTree/DumpRenderTree.gypi:
2241
2242 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
2243
2244         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2245         https://bugs.webkit.org/show_bug.cgi?id=87128
2246
2247         Reviewed by Dirk Pranke.
2248
2249         * Scripts/webkitpy/layout_tests/port/base.py:
2250         (Port.driver_name):
2251         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2252         (ChromiumLinuxPort._path_to_driver):
2253         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2254         (ChromiumPortTest.test_driver_name_option):
2255         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2256         (ChromiumWinPort._path_to_driver):
2257         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2258         (parse_args):
2259
2260 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2261
2262         WTR fix after r118001.
2263
2264         Rubber-stamped by Alexey Proskuryakov.
2265
2266         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
2267
2268         * WebKitTestRunner/mac/EventSenderProxy.mm:
2269         (WTR::EventSenderProxy::keyDown):
2270
2271 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
2272
2273         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
2274         https://bugs.webkit.org/show_bug.cgi?id=86684
2275
2276         Reviewed by Darin Fisher.
2277
2278         * DumpRenderTree/chromium/LayoutTestController.cpp:
2279         (LayoutTestController::numberOfPages):
2280         * DumpRenderTree/chromium/WebViewHost.cpp:
2281         (WebViewHost::printPage):
2282
2283 == Rolled over to ChangeLog-2012-05-22 ==