Prettify the output of the override-feature-defines script
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
2
3         Prettify the output of the override-feature-defines script
4         https://bugs.webkit.org/show_bug.cgi?id=106542
5
6         Reviewed by Martin Robinson.
7
8         The output now clearly lists the feature defines being overridden
9         along with the default and overriding values for each feature define.
10
11         * gtk/override-feature-defines:
12         (adjust_feature_defines_makefile):
13         (adjust_feature_defines_makefile.override_feature_define):
14
15 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
16
17         Remove uses of deprecated unittest.TestCase aliases
18         https://bugs.webkit.org/show_bug.cgi?id=102252
19
20         Reviewed by Adam Barth.
21
22         Replace the deprecated assertEquals method of the TestCase interface
23         used in some webkitpy unittests with the assertEqual method.
24
25         * Scripts/webkitpy/common/system/profiler_unittest.py:
26         (ProfilerFactoryTest._assert_default_profiler_name):
27         (ProfilerFactoryTest.test_default_profiler_output):
28         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
29         (GtkPortTest.test_expectations_files):
30         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
31         (TestHttpServer.test_win32_start_and_stop):
32
33 2013-01-22  Jer Noble  <jer.noble@apple.com>
34
35         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
36         https://bugs.webkit.org/show_bug.cgi?id=107562
37
38         Rubber-stamped by Alexy Proskuryakov.
39
40         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
41
42         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
43         (WTR::PlatformWebView::PlatformWebView):
44         (WTR::PlatformWebView::viewSupportsOptions):
45
46 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
47
48         One is not allowed to use commit-queue to make oneself a committer.
49
50         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
51
52 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
53
54         Add myself to commiters.py
55         https://bugs.webkit.org/show_bug.cgi?id=107546
56
57         Reviewed by Kentaro Hara.
58
59         * Scripts/webkitpy/common/config/committers.py:
60
61 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
62
63         [GTK] Implement TestRunner::setTextDirection
64         https://bugs.webkit.org/show_bug.cgi?id=107131
65
66         Reviewed by Philippe Normand.
67
68         * DumpRenderTree/gtk/DumpRenderTree.cpp:
69         (resetDefaultsToConsistentValues): Reset direction to default value.
70         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
71         (TestRunner::setTextDirection): Implement method using
72         gtk_widget_set_direction.
73
74 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
75
76         [chromium] move spell checking mocks to TestRunner library
77         https://bugs.webkit.org/show_bug.cgi?id=107455
78
79         Reviewed by Kent Tamura.
80
81         The content module doesn't provide its own WebSpellCheckClient.
82
83         * DumpRenderTree/DumpRenderTree.gypi:
84         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
85         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
86         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
87         (WebKit):
88         (WebTestRunner):
89         (WebTestProxyBase):
90         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
91         (WebTestRunner):
92         (WebTestRunner::makeMenuItemStringsFor):
93         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
94         (MockGrammarCheck::checkGrammarOfString):
95         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
96         (WebKit):
97         (MockGrammarCheck):
98         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
99         (MockSpellCheck::MockSpellCheck):
100         (MockSpellCheck::~MockSpellCheck):
101         (isNotASCIIAlpha):
102         (MockSpellCheck::spellCheckWord):
103         (MockSpellCheck::fillSuggestionList):
104         (MockSpellCheck::initializeIfNeeded):
105         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
106         (MockSpellCheck):
107         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
108         (WebTestRunner::SpellCheckClient::SpellCheckClient):
109         (WebTestRunner):
110         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
111         (WebTestRunner::SpellCheckClient::setDelegate):
112         (WebTestRunner::SpellCheckClient::spellCheck):
113         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
114         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
115         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
116         (WebTestRunner::SpellCheckClient::autoCorrectWord):
117         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
118         (WebTestRunner):
119         (SpellCheckClient):
120         (WebTestRunner::SpellCheckClient::taskList):
121         (WebTestRunner::SpellCheckClient::mockSpellCheck):
122         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
123         (TestDelegate):
124         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
125         (WebTestInterfaces::Internal):
126         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
127         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
128         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
129         (WebTestRunner::WebTestProxyBase::setDelegate):
130         (WebTestRunner::WebTestProxyBase::spellCheckClient):
131         (WebTestRunner):
132         * DumpRenderTree/chromium/WebViewHost.cpp:
133         (WebViewHost::WebViewHost):
134         (WebViewHost::setWebWidget):
135         * DumpRenderTree/chromium/WebViewHost.h:
136         (WebViewHost):
137
138 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
139
140         [EFL] Adds Accessibility support to wk1
141         https://bugs.webkit.org/show_bug.cgi?id=107440
142
143         Reviewed by Gyuyoung Kim.
144
145         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
146
147 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
148
149         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
150         https://bugs.webkit.org/show_bug.cgi?id=107506
151
152         Reviewed by Dan Bernstein.
153
154         * MiniBrowser/mac/WK1BrowserWindowController.m:
155         (-[WK1BrowserWindowController dealloc]):
156
157 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
158
159         Add build flag for Canvas's Path object (disabled by default)
160         https://bugs.webkit.org/show_bug.cgi?id=107473
161
162         Reviewed by Dean Jackson.
163
164         Add CANVAS_PATH build flag to build systems.
165
166         * Scripts/webkitperl/FeatureList.pm:
167
168 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
169
170         [EFL][WK2] Add APIs to set/get view source mode
171         https://bugs.webkit.org/show_bug.cgi?id=106633
172
173         Reviewed by Gyuyoung Kim.
174
175         Added a shotcut 'F8' in Minibrowser to display a source code
176         of the web page in a new window.
177
178        * MiniBrowser/efl/main.c:
179         (on_key_down):
180         (on_window_create):
181         (window_create):
182         (elm_main):
183
184 2013-01-21  Nico Weber  <thakis@chromium.org>
185
186         [chromium] Don't archive generated source files.
187         https://bugs.webkit.org/show_bug.cgi?id=106736
188
189         Reviewed by Eric Seidel.
190
191         They shouldn't be needed to run tests. They don't need a lot of space,
192         but add many lines to the "extracting" stdout. This attempts to reduce
193         that noise a bit.
194
195         * BuildSlaveSupport/built-product-archive:
196         (archiveBuiltProduct):
197
198 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
199
200         Mac DumpRenderTree's installSignalHandlers() is unreachable code
201         https://bugs.webkit.org/show_bug.cgi?id=107383
202
203         Reviewed by Sam Weinig.
204
205         The CrashHandler of DumpRenderTree were originally used for restoring
206         the color profile of the main display even if DRT crashes.
207
208         That feature was later limited to pixel tests only in r29999.
209
210         In r104351, the DRT was changed to use device color space. Making the crash
211         handlers useless, but they were left in the code since the error reporting
212         code was still reachable.
213
214         Later, r124581 refactored the code and dumpPixelsForCurrentTest
215         is being used before being assigned its value.
216         This did cause any regression because the code had become useless with the previous change.
217
218         * DumpRenderTree/mac/DumpRenderTree.mm:
219         Remove crashHandler() and installSignalHandlers() as they have become useless and
220         have been unreachable code for 6 months.
221         (dumpRenderTree):
222         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
223         at those points.
224
225 2013-01-21  Nico Weber  <thakis@chromium.org>
226
227         Make ninja the default build system for build-webkit --chromium on mac
228         https://bugs.webkit.org/show_bug.cgi?id=106737
229
230         Reviewed by Eric Seidel.
231
232         * Scripts/update-webkit-chromium:
233
234 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
235
236         Regression(r140262): Causes a lot of flakiness
237         https://bugs.webkit.org/show_bug.cgi?id=107454
238
239         Reviewed by Alexey Proskuryakov.
240
241         r140262 introduced a lot of flakiness due to fixed layout mode
242         not getting disabled on the view after being enabled for
243         specific test cases. This patch makes sure fixed layout mode
244         properly gets reset in WebKitTestRunner to avoid flakiness.
245
246         * WebKitTestRunner/TestInvocation.cpp:
247         (WTR::updateLayoutType):
248
249 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
250
251         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
252         https://bugs.webkit.org/show_bug.cgi?id=107421
253
254         Unreviewed build fix.
255
256         * Scripts/run-gtk-tests:
257         (TestRunner): skip Resource tests.
258
259 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
260
261         [EFL][WKTR] platformRunUntil() should keep the main loop running
262         https://bugs.webkit.org/show_bug.cgi?id=107442
263
264         Reviewed by Noam Rosenthal.
265
266         EFL's implementation of platformRunUntil() should keep the main loop
267         running and avoid calling sleep() between calls to
268         ecore_main_loop_iterate(). This call to sleep seems to be a source
269         of deadlocks (see Bug 106884).
270
271         * WebKitTestRunner/efl/TestControllerEfl.cpp:
272         (WTR::TestController::platformRunUntil):
273
274 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
275
276         QtTestBrowser should provide way to clear selected elements
277         https://bugs.webkit.org/show_bug.cgi?id=107437
278
279         Reviewed by Simon Hausmann.
280
281         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
282         Invoke the clearSelection prior to highlighting new elements.
283
284         * QtTestBrowser/launcherwindow.cpp:
285         (ElementHighlight):
286         (LauncherWindow::createChrome):
287         (LauncherWindow::selectElements):
288         (LauncherWindow::clearSelection):
289         * QtTestBrowser/launcherwindow.h:
290         (LauncherWindow):
291
292 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
293
294         [chromium] move methods interacting with willSendRequest to TestRunner
295         https://bugs.webkit.org/show_bug.cgi?id=107270
296
297         Reviewed by Kent Tamura.
298
299         * DumpRenderTree/chromium/DRTTestRunner.cpp:
300         (DRTTestRunner::DRTTestRunner):
301         (DRTTestRunner::waitForPolicyDelegate):
302         * DumpRenderTree/chromium/DRTTestRunner.h:
303         (DRTTestRunner):
304         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
305         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
306         (WebTestRunner::WebTestRunner::httpHeadersToClear):
307         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
308         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
309         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
310         (WebTestRunner::TestRunner::TestRunner):
311         (WebTestRunner::TestRunner::reset):
312         (WebTestRunner::TestRunner::httpHeadersToClear):
313         (WebTestRunner):
314         (WebTestRunner::TestRunner::shouldBlockRedirects):
315         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
316         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
317         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
318         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
319         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
320         (TestRunner):
321         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
322         (WebTestRunner::WebTestProxyBase::willSendRequest):
323         * DumpRenderTree/chromium/WebViewHost.cpp:
324         (WebViewHost::willSendRequest):
325         (WebViewHost::reset):
326         * DumpRenderTree/chromium/WebViewHost.h:
327         (WebViewHost):
328
329 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
330
331         [GTK] Stop building WebKit2 on GTK EWSs
332         https://bugs.webkit.org/show_bug.cgi?id=107435
333
334         Reviewed by Philippe Normand.
335
336         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
337         so stop building it on GTK EWSs.
338
339         * Scripts/webkitpy/common/config/ports.py:
340         (GtkPort.build_webkit_command):
341         * Scripts/webkitpy/common/config/ports_unittest.py:
342         (DeprecatedPortTest.test_gtk_port):
343
344 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
345
346         MediaStream API: Update the RTCPeerConnection states to match the latest specification
347         https://bugs.webkit.org/show_bug.cgi?id=107120
348
349         Reviewed by Adam Barth.
350
351         Updating mock to use the new states.
352
353         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
354         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
355         (MockWebRTCPeerConnectionHandler::initialize):
356         (MockWebRTCPeerConnectionHandler::updateICE):
357
358 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
359
360         Extend diff_parser to support the --full-index output.
361         https://bugs.webkit.org/show_bug.cgi?id=107408
362
363         Reviewed by Maciej Stachowiak.
364
365         * Scripts/webkitpy/common/checkout/diff_parser.py:
366         (git_diff_to_svn_diff):
367         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
368         (DiffParserTest):
369         (DiffParserTest.test_git_diff_to_svn_diff):
370         (git_diff_to_svn_diff):
371
372 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
373
374         Dragging over an element with scrollbars should scroll the element when dragging near edges
375         https://bugs.webkit.org/show_bug.cgi?id=39725
376
377         Reviewed by Hajime Morita.
378
379         This patch introduces canceling drag-and-drop by escape key for testing
380         behavior after cancellation drag-and-drop.
381
382         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
383         (WebTestRunner):
384         (WebTestRunner::EventSender::doMouseUp):
385         (WebTestRunner::EventSender::finishDragAndDrop):
386         (WebTestRunner::EventSender::keyDown):
387         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
388         (EventSender):
389         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
390
391 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
392
393         [chromium] move frame generation related methods to TestRunner
394         https://bugs.webkit.org/show_bug.cgi?id=107268
395
396         Reviewed by Adam Barth.
397
398         * DumpRenderTree/chromium/DRTTestRunner.cpp:
399         (DRTTestRunner::DRTTestRunner):
400         (DRTTestRunner::setWillSendRequestReturnsNull):
401         * DumpRenderTree/chromium/DRTTestRunner.h:
402         (DRTTestRunner):
403         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
404         (WebTestRunner::WebTestDelegate::display):
405         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
406         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
407         (WebTestRunner::TestRunner::TestRunner):
408         (WebTestRunner::TestRunner::display):
409         (WebTestRunner):
410         (WebTestRunner::TestRunner::displayInvalidatedRegion):
411         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
412         (TestRunner):
413         * DumpRenderTree/chromium/WebViewHost.cpp:
414         (WebViewHost::display):
415         (WebViewHost::displayInvalidatedRegion):
416         * DumpRenderTree/chromium/WebViewHost.h:
417
418 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
419
420         [chromium] move speech related methods to TestRunner library
421         https://bugs.webkit.org/show_bug.cgi?id=107266
422
423         Reviewed by Adam Barth.
424
425         * DumpRenderTree/chromium/DRTTestRunner.cpp:
426         (DRTTestRunner::DRTTestRunner):
427         (DRTTestRunner::displayInvalidatedRegion):
428         * DumpRenderTree/chromium/DRTTestRunner.h:
429         (DRTTestRunner):
430         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
431         (WebTestDelegate):
432         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
433         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
434         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
435         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
436         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
437         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
438         (WebTestRunner::TestRunner::TestRunner):
439         (WebTestRunner):
440         (WebTestRunner::TestRunner::addMockSpeechInputResult):
441         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
442         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
443         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
444         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
445         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
446         (TestRunner):
447         * DumpRenderTree/chromium/WebViewHost.cpp:
448         (WebViewHost::addMockSpeechInputResult):
449         (WebViewHost::setMockSpeechInputDumpRect):
450         (WebViewHost::addMockSpeechRecognitionResult):
451         (WebViewHost::setMockSpeechRecognitionError):
452         (WebViewHost::wasMockSpeechRecognitionAborted):
453         * DumpRenderTree/chromium/WebViewHost.h:
454
455 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
456
457         [chromium] move notification related methods to TestRunner
458         https://bugs.webkit.org/show_bug.cgi?id=107269
459
460         Reviewed by Adam Barth.
461
462         * DumpRenderTree/chromium/DRTTestRunner.cpp:
463         (DRTTestRunner::DRTTestRunner):
464         * DumpRenderTree/chromium/DRTTestRunner.h:
465         (DRTTestRunner):
466         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
467         (WebTestDelegate):
468         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
469         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
470         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
471         (WebTestRunner::TestRunner::TestRunner):
472         (WebTestRunner):
473         (WebTestRunner::TestRunner::grantWebNotificationPermission):
474         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
475         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
476         (TestRunner):
477         * DumpRenderTree/chromium/WebViewHost.cpp:
478         (WebViewHost::grantWebNotificationPermission):
479         (WebViewHost::simulateLegacyWebNotificationClick):
480         * DumpRenderTree/chromium/WebViewHost.h:
481
482 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
483
484         [chromium] move geolocation related methods to TestRunner
485         https://bugs.webkit.org/show_bug.cgi?id=107267
486
487         Reviewed by Adam Barth.
488
489         * DumpRenderTree/chromium/DRTTestRunner.cpp:
490         (DRTTestRunner::DRTTestRunner):
491         * DumpRenderTree/chromium/DRTTestRunner.h:
492         (DRTTestRunner):
493         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
494         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
495         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
496         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
497         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
498         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
499         (WebTestRunner::TestRunner::TestRunner):
500         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
501         (WebTestRunner):
502         (WebTestRunner::TestRunner::setGeolocationPermission):
503         (WebTestRunner::TestRunner::setMockGeolocationPosition):
504         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
505         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
506         (TestRunner):
507         * DumpRenderTree/chromium/WebViewHost.cpp:
508         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
509         (WebViewHost::setGeolocationPermission):
510         (WebViewHost::setMockGeolocationPosition):
511         (WebViewHost::setMockGeolocationPositionUnavailableError):
512         * DumpRenderTree/chromium/WebViewHost.h:
513
514 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
515
516         Unreviewed build fix for Qt WK2 after r140258.
517         Use the size_t type instead of unsigned for the variable
518         which holds the position of the first null character in the
519         console message.
520
521         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
522         (WTR::InjectedBundlePage::willAddMessageToConsole):
523
524 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
525
526         Unreviewed, rolling out r140260.
527         http://trac.webkit.org/changeset/140260
528         https://bugs.webkit.org/show_bug.cgi?id=107387
529
530         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
531         nothing else) (Requested by thakis__ on #webkit).
532
533         * Scripts/update-webkit-chromium:
534
535 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
536
537         Delegated scrolling: Assertion on attempt to show a CSS sticky element
538         https://bugs.webkit.org/show_bug.cgi?id=106890
539
540         Reviewed by Kenneth Rohde Christiansen.
541
542         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
543
544         * WebKitTestRunner/TestInvocation.cpp:
545         (WTR::shouldUseFixedLayout):
546         (WTR):
547         (WTR::updateLayoutType):
548
549 2013-01-19  Nico Weber  <thakis@chromium.org>
550
551         Make ninja the default build system for build-webkit --chromium on mac
552         https://bugs.webkit.org/show_bug.cgi?id=106737
553
554         Reviewed by Eric Seidel.
555
556         * Scripts/update-webkit-chromium:
557
558 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
559
560         [WK2] svg/dom/fuzz-path-parser.html is failing
561         https://bugs.webkit.org/show_bug.cgi?id=107133
562
563         Reviewed by Alexey Proskuryakov.
564
565         Console messages can contain null characters before the end of string.
566         Appending such message to the StringBuilder as a WTFString appends the
567         complete string, including the null character. This later cuts off everything
568         after the null character when the string is being printed out to the test
569         output.
570
571         To avoid this, truncate the string up to the first null character. This
572         preserves the newline character appended immediately after this and
573         stops giving incorrect output.
574
575         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
576         (WTR::InjectedBundlePage::willAddMessageToConsole):
577
578 2013-01-19  Eric Seidel  <eric@webkit.org>
579
580         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
581         https://bugs.webkit.org/show_bug.cgi?id=107367
582
583         Reviewed by Ryosuke Niwa.
584
585         Using srcdoc instead of document.write changes the error output
586         ever so slightly.  Clearly we were already trying to ignore these
587         messages, just not succeeding.  This change makes this new test "pass" correctly.
588
589         * Scripts/webkitpy/performance_tests/perftest.py:
590         (PerfTest):
591
592 2013-01-18  Dan Winship  <danw@gnome.org>
593
594         REGRESSION (r139071): run-webkit-httpd complains at launch
595         https://bugs.webkit.org/show_bug.cgi?id=107310
596
597         Reviewed by Alexey Proskuryakov.
598
599         * Scripts/webkitperl/httpd.pm:
600         (getApacheVersion): use preferred perl syntax
601
602 2013-01-18  Julie Parent  <jparent@chromium.org>
603
604         Add back 'group' as a default cross dashboard parameter, but with null as its value.
605         https://bugs.webkit.org/show_bug.cgi?id=107336
606
607         We need to have 'group' listed as a parameter, else we never parse it,
608         as we only parse parameters with defaults.
609         
610         Reviewed by Ojan Vafai.
611
612         * TestResultServer/static-dashboards/dashboard_base.js:
613
614 2013-01-18  Emil A Eklund  <eae@chromium.org>
615
616         Update LayoutUnit rounding unit test
617         https://bugs.webkit.org/show_bug.cgi?id=107322
618
619         Reviewed by Levi Weintraub.
620         
621         Update the LayoutUnitRounding test to use fromFloatRound for
622         values that cannot accurately be represented as a LayoutUnit
623         (the default behavior is to floor the value to the nearest
624         LayoutUnit).
625
626         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
627         (TestWebKitAPI::TEST):
628
629 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
630
631         VCSUtils.pm: Stop calling git repo-config.
632         https://bugs.webkit.org/show_bug.cgi?id=107294
633
634         Reviewed by Dirk Pranke.
635
636         The `repo-config' git command has been deprecated since early
637         2008, and recent versions have started warning it is deprecated.
638
639         Basically revert r27870 and use the `config' command all the time.
640
641         * Scripts/VCSUtils.pm:
642         (gitConfig):
643
644 2013-01-18  Levi Weintraub  <leviw@chromium.org>
645
646         LayoutUnit should round half consistently, not away from zero
647         https://bugs.webkit.org/show_bug.cgi?id=107208
648
649         Reviewed by Eric Seidel.
650
651         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
652         cover this change in rounding behavior.
653
654 2013-01-18  Tim Horton  <timothy_horton@apple.com>
655
656         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
657         https://bugs.webkit.org/show_bug.cgi?id=107234
658
659         Reviewed by Simon Fraser.
660
661         * DumpRenderTree/mac/DumpRenderTree.mm:
662         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
663         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
664         (WTR::PlatformWebView::PlatformWebView): Ditto.
665
666 2013-01-18  Tim Horton  <timothy_horton@apple.com>
667
668         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
669         https://bugs.webkit.org/show_bug.cgi?id=107251
670
671         Reviewed by Simon Fraser.
672
673         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
674
675         * DumpRenderTree/mac/DumpRenderTree.mm:
676         (dumpRenderTree):
677         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
678         (WTR::InjectedBundle::platformInitialize):
679
680 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
681
682         [GTK] Enable indexed database for development builds
683         https://bugs.webkit.org/show_bug.cgi?id=107299
684
685         Reviewed by Gustavo Noronha Silva.
686
687         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
688         for GTK+ development builds.
689
690 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
691
692         AX: Improve table-guessing heuristics
693         https://bugs.webkit.org/show_bug.cgi?id=107042
694
695         Reviewed by Chris Fleizach.
696
697         Implement parentElementCallback on Chromium to make testing easier.
698
699         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
700         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
701
702 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
703
704         [GTK] Add property for IndexedDB database path to WebKitGTK+
705         https://bugs.webkit.org/show_bug.cgi?id=106136
706
707         Reviewed by Gustavo Noronha Silva.
708
709         During testing, set the web database directory to DUMPRENDERTREE_TEMP
710         before falling back to the old default. This is necessary because
711         indexed database tests require that each DRT shard is using a different
712         IDB database location.
713
714         * DumpRenderTree/gtk/DumpRenderTree.cpp:
715         (temporaryDatabaseDirectory): Added this helper for getting the
716         database directory.
717         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
718
719 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
720
721         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
722         https://bugs.webkit.org/show_bug.cgi?id=107264
723
724         Reviewed by Laszlo Gombos.
725
726         Enable API test InjectedBundleFrameHitTest for hit-testing,
727         since it is now passing on both Debug and Release builds.
728
729         * TestWebKitAPI/CMakeLists.txt:
730         * TestWebKitAPI/PlatformEfl.cmake:
731
732 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
733
734         [GTK] Implement TestRunner::addUserScript
735         https://bugs.webkit.org/show_bug.cgi?id=107275
736
737         Reviewed by Philippe Normand.
738
739         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
740         (TestRunner::addUserScript): Implement method using
741         DumpRenderTreeSupportGtk::addUserScript.
742
743 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
744
745         Unreviewed, add my secondary email address to the list.
746
747         * Scripts/webkitpy/common/config/committers.py:
748
749 2013-01-18  Dan Carney  <dcarney@google.com>
750
751         [chromium] move pointerlock functions to TestRunner library
752         https://bugs.webkit.org/show_bug.cgi?id=107241
753
754         Reviewed by Jochen Eisinger.
755
756         * DumpRenderTree/chromium/DRTTestRunner.cpp:
757         (DRTTestRunner::DRTTestRunner):
758         * DumpRenderTree/chromium/DRTTestRunner.h:
759         (DRTTestRunner):
760         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
761         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
762         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
763         (WebTestRunner::WebTestDelegate::didLosePointerLock):
764         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
765         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
766         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
767         (WebTestRunner::TestRunner::TestRunner):
768         (WebTestRunner):
769         (WebTestRunner::TestRunner::didAcquirePointerLock):
770         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
771         (WebTestRunner::TestRunner::didLosePointerLock):
772         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
773         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
774         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
775         (TestRunner):
776         * DumpRenderTree/chromium/WebViewHost.h:
777         (WebViewHost):
778
779 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
780
781         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
782         https://bugs.webkit.org/show_bug.cgi?id=106774
783
784         Reviewed by Martin Robinson.
785
786         In order to fix a long standing linespacing/font ascent & descent issue
787         we found that FreeType commit b0962ac34e660 solves that problem.
788         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
789         maintainer recommending several security updates after that said commit.
790
791         Also, in order to avoid extra rebaselining, let's activate subpixel
792         layout at the same time.
793
794         * efl/jhbuild.modules: New freetype 2.4.11
795
796 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
797
798         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
799         https://bugs.webkit.org/show_bug.cgi?id=107107
800         PR 282192
801
802         Reviewed by Rob Buis.
803
804         The DRT application will convert relative/absolute file path to
805         file://<real-file-path> format, so we only check for http/file prefix.
806
807         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
808         (BlackBerry::WebKit::isFullUrl):
809         (WebKit):
810         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
811
812 2013-01-17  Frank Farzan  <frankf@chromium.org>
813
814         Flakiness dashboard: Add ChromiumFYI master
815         https://bugs.webkit.org/show_bug.cgi?id=107180
816
817         Reviewed by Ojan Vafai.
818
819         This is needed to enable Chrome Android bots
820         to upload results for instrumentation tests.
821
822         * TestResultServer/generate_builders_json.py:
823         (main):
824         * TestResultServer/static-dashboards/builders.jsonp:
825
826 2013-01-17  Frank Farzan  <frankf@chromium.org>
827
828         Add Chrome on Android instrumentation test types to flakiness dashboard
829         https://bugs.webkit.org/show_bug.cgi?id=106964
830
831         Reviewed by Ojan Vafai.
832
833         Specifically, add these test types:
834         
835          androidwebview_instrumentation_tests
836          chromiumtestshell_instrumentation_tests
837          contentshell_instrumentation_tests
838         
839         Also, add ChromiumFYI to the list of masters.
840
841         * TestResultServer/static-dashboards/builders.js:
842         (loadBuildersList):
843         * TestResultServer/static-dashboards/dashboard_base.js:
844         (currentBuilderGroupCategory):
845
846 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
847
848         Fixing webkitpy's SCM unit tests.
849         https://bugs.webkit.org/show_bug.cgi?id=106429
850
851         Reviewed by Eric Seidel.
852
853         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
854         (SCMDetectorTest.test_detect_scm_system):
855         * Scripts/webkitpy/common/checkout/scm/git.py:
856         (Git.in_working_directory):
857         (Git.read_git_config):
858         (Git._assert_can_squash):
859         (Git.remote_branch_ref):
860         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
861         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
862         (GitTestWithMock):
863         (GitTestWithMock.make_scm):
864         (GitTestWithMock.test_create_patch):
865         * Scripts/webkitpy/common/system/outputcapture.py:
866         (OutputCapture.assert_outputs):
867         (OutputCaptureTestCaseBase):
868         * Scripts/webkitpy/test/printer.py:
869         (Printer.configure):
870
871 2013-01-17  Julie Parent  <jparent@chromium.org>
872
873         Flakiness dashboard assumes there must be ToT tests
874         https://bugs.webkit.org/show_bug.cgi?id=107155
875
876         Remove group as a default parameter, since we can't actually know
877         the name of a group initially.  Instead, introduces 
878         currentBuilderGroupName which returns the current builder group
879         if it has been explicitly set, or picks the first one available
880         as a default. Allows us to remove some extra code tracking this
881         stuff as well.
882         
883         Reviewed by Ojan Vafai.
884
885         * TestResultServer/static-dashboards/dashboard_base.js:
886         (parseCrossDashboardParameters):
887         (currentBuilderGroupName):
888         (currentBuilderGroup):
889         * TestResultServer/static-dashboards/flakiness_dashboard.js:
890         (platformAndBuildType):
891         * TestResultServer/static-dashboards/loader.js:
892         (.):
893
894 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
895
896         Remove NodeListsNodeData when it's no longer needed
897         https://bugs.webkit.org/show_bug.cgi?id=107074
898
899         Reviewed by Darin Adler.
900
901         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
902
903         * Scripts/webkitpy/performance_tests/perftest.py:
904         (PerfTest):
905
906 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
907
908         Ref test images are upside-down in WebKit2
909         https://bugs.webkit.org/show_bug.cgi?id=105457
910
911         Reviewed by Sam "Speedy" Weinig.
912         
913         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
914         from the window snapshot contained a flipped copy of the image, causing all ref
915         and pixel images to be upside-down.
916
917         * WebKitTestRunner/cg/TestInvocationCG.cpp:
918         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
919
920 2013-01-17  Timothy Loh  <timloh@google.com>
921
922         Replaced specifiers variable with is_debug in builders.py
923         https://bugs.webkit.org/show_bug.cgi?id=107057
924
925         Reviewed by Dirk Pranke.
926
927         Replaced specifiers variable with is_debug in builders.py to simplify
928         Bug 106259. The other specifiers are not used elsewhere in the code.
929         Fixed builder_name_for_port_name to return a debug builder if we don't
930         have a release builder.
931
932         * Scripts/webkitpy/layout_tests/port/builders.py:
933         (all_port_names):
934         (builder_name_for_port_name):
935         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
936         (TestRebaselineExpectations.test_rebaseline_expectations):
937
938 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
939
940         [GTK] Build with LevelDB when IndexedDB is enabled
941         https://bugs.webkit.org/show_bug.cgi?id=103220
942
943         Reviewed by Gustavo Noronha Silva.
944
945         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
946         as it does not conform to WebKit style.
947
948 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
949
950         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
951         https://bugs.webkit.org/show_bug.cgi?id=107119
952
953         Reviewed by Laszlo Gombos.
954
955         Do not use ASSERT on ecore_evas_init(), since the expression inside
956         the macro compiles out of release builds.
957
958         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
959         * TestWebKitAPI/efl/PlatformWebView.cpp:
960         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
961
962 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
963
964         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
965         https://bugs.webkit.org/show_bug.cgi?id=104545
966
967         Reviewed by Yury Semikhatsky.
968
969         Adopt signature changes.
970
971         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
972         (ProfilerAgent.getCPUProfile): Renamed.
973         (ProfilerAgent.getHeapSnapshot): Added.
974
975 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
976
977         [GTK][EFL] NWRT should check that Xvfb is installed
978         https://bugs.webkit.org/show_bug.cgi?id=71767
979
980         Reviewed by Dirk Pranke.
981
982         EFL and GTK ports now check that Xvfb is installed before running
983         layout tests. The command line used to check whether Xvfb is present
984         is a simple `which Xvfb` that should return 0 as the exit code upon
985         success.
986
987         * Scripts/webkitpy/layout_tests/port/efl.py:
988         (EflPort.show_results_html_file):
989         (EflPort):
990         (EflPort.check_sys_deps):
991         * Scripts/webkitpy/layout_tests/port/gtk.py:
992         (GtkPort.check_sys_deps):
993         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
994         (XvfbDriver):
995         (XvfbDriver.check_xvfb):
996
997 2013-01-16  Alan Cutter  <alancutter@chromium.org>
998
999         sheriffbot can't tell me who "kov" is
1000         https://bugs.webkit.org/show_bug.cgi?id=106184
1001
1002         Reviewed by Eric Seidel.
1003
1004         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
1005
1006         * Scripts/webkitpy/common/config/committers.py:
1007         (Account.matches_glob):
1008         (CommitterList.contributors_by_search_string):
1009         * Scripts/webkitpy/common/config/committers_unittest.py:
1010         (CommittersTest.test_committer_lookup):
1011         * Scripts/webkitpy/tool/bot/irc_command.py:
1012         (Whois):
1013
1014 2013-01-16  David Kilzer  <ddkilzer@apple.com>
1015
1016         Use xcrun to find path to make for Mac port
1017         <http://webkit.org/b/107091>
1018
1019         Reviewed by Dan Bernstein.
1020
1021         * Scripts/webkitpy/layout_tests/port/mac.py:
1022         (MacPort._build_java_test_support): Call self.make_command().
1023         (MacPort.make_command): Add.  Call xcrun_find().
1024         (MacPort.nm_command): Use self.xcrun_find().
1025         (MacPort.xcrun_find): Add.  Extract from nm_command().
1026
1027 2013-01-16  Sam Weinig  <sam@webkit.org>
1028
1029         Make debug-safari --target-web-process work again
1030         https://bugs.webkit.org/show_bug.cgi?id=107088
1031
1032         Reviewed by Anders Carlsson.
1033
1034         * Scripts/webkitdirs.pm:
1035         (execMacWebKitAppForDebugging):
1036         The shim is now called SecItemShim.
1037
1038 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1039
1040         GCE build scripts don't take working directory into account when calling findzone.sh
1041         https://bugs.webkit.org/show_bug.cgi?id=106962
1042
1043         Reviewed by Adam Barth.
1044
1045         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1046         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1047         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1048
1049 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1050
1051         start-queue.sh does not pass remaining parameters correctly
1052         https://bugs.webkit.org/show_bug.cgi?id=107054
1053
1054         Reviewed by Adam Barth.
1055
1056         start-queue.sh now passes all remaining params to the webkit-patch command.
1057         Previously only one additional queue parameter could be sent.
1058
1059         * EWSTools/start-queue.sh:
1060
1061 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
1062
1063         check-webkit-style script cannot running in Chinese windows.
1064         https://bugs.webkit.org/show_bug.cgi?id=87548
1065
1066         Reviewed by Darin Adler.
1067
1068         * Scripts/webkitpy/common/system/platforminfo.py:
1069         (PlatformInfo._win_version_tuple_from_cmd):
1070
1071 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
1072
1073         Delete an extraneous print statement.
1074         https://bugs.webkit.org/show_bug.cgi?id=106562
1075
1076         Delete the extraneous print statement introduced in r139841.
1077
1078         * Scripts/webkitpy/layout_tests/views/printing.py:
1079         (Printer.print_found):
1080
1081 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
1082
1083         Please reinstate --pixel
1084         https://bugs.webkit.org/show_bug.cgi?id=101995
1085
1086         Reviewed by Dirk Pranke.
1087
1088         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
1089         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
1090         Some developers are still used to these options that were available in the ORWT.
1091
1092         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1093         (parse_args):
1094
1095 2013-01-16  Eric Seidel  <eric@webkit.org>
1096
1097         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
1098         https://bugs.webkit.org/show_bug.cgi?id=99512
1099
1100         Reviewed by Darin Adler.
1101
1102         * Scripts/run-sunspider:
1103
1104 2013-01-16  Eric Seidel  <eric@webkit.org>
1105
1106         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
1107         https://bugs.webkit.org/show_bug.cgi?id=106036
1108
1109         Reviewed by Darin Adler.
1110
1111         * Scripts/webkitpy/webkitpy.pyproj: Removed.
1112         * Scripts/webkitpy/webkitpy.sln: Removed.
1113
1114 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
1115
1116         [Chromium] Remove hardcoded chromium_*.jar in gyp files
1117         https://bugs.webkit.org/show_bug.cgi?id=104049
1118
1119         Reviewed by Eric Seidel.
1120
1121         Targets with dependencies (direct/indirect) on a java target receive
1122         the chromium_*.jar paths in the variable input_jars_paths. Targets
1123         should use that rather than hardcoding where they think the jar will
1124         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
1125         than as --jars to generate_native_test.py.
1126
1127         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1128         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1129
1130 2013-01-16  Dan Carney  <dcarney@google.com>
1131
1132         [chromium] move setMockDeviceOrientation to TestRunner library
1133         https://bugs.webkit.org/show_bug.cgi?id=106895
1134
1135         Reviewed by Jochen Eisinger.
1136
1137         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1138         (DRTTestRunner::DRTTestRunner):
1139         * DumpRenderTree/chromium/DRTTestRunner.h:
1140         (DRTTestRunner):
1141         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1142         (WebKit):
1143         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
1144         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1145         (WebTestRunner::TestRunner::TestRunner):
1146         (WebTestRunner::TestRunner::setMockDeviceOrientation):
1147         (WebTestRunner):
1148         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1149         (TestRunner):
1150         * DumpRenderTree/chromium/WebViewHost.cpp:
1151         (WebViewHost::setDeviceOrientation):
1152         * DumpRenderTree/chromium/WebViewHost.h:
1153         (WebViewHost):
1154
1155 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1156
1157         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1158         https://bugs.webkit.org/show_bug.cgi?id=106904
1159
1160         Reviewed by Adam Barth.
1161
1162         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1163         (DRTTestRunner::DRTTestRunner):
1164         (DRTTestRunner::notifyDone):
1165         (DRTTestRunner::reset):
1166         * DumpRenderTree/chromium/DRTTestRunner.h:
1167         (DRTTestRunner):
1168         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1169         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1170         (WebTestRunner::WebTestDelegate::setFocus):
1171         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1172         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1173         (WebTestRunner::WebTestDelegate::setLocale):
1174         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1175         (WebTestRunner::TestRunner::TestRunner):
1176         (WebTestRunner::TestRunner::reset):
1177         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1178         (WebTestRunner):
1179         (WebTestRunner::TestRunner::setWindowIsKey):
1180         (WebTestRunner::TestRunner::pathToLocalResource):
1181         (WebTestRunner::TestRunner::setBackingScaleFactor):
1182         (WebTestRunner::TestRunner::setPOSIXLocale):
1183         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1184         (WebTestRunner::TestRunner::taskList):
1185         (TestRunner):
1186         * DumpRenderTree/chromium/WebViewHost.cpp:
1187         (WebViewHost::setDeviceScaleFactor):
1188         (WebViewHost::setFocus):
1189         (WebViewHost::setAcceptAllCookies):
1190         (WebViewHost::pathToLocalResource):
1191         (WebViewHost::setLocale):
1192         * DumpRenderTree/chromium/WebViewHost.h:
1193         (WebViewHost):
1194
1195 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
1196
1197         [GTK] build-webkit fails if the jhbuild wrapper is not used
1198         https://bugs.webkit.org/show_bug.cgi?id=106769
1199
1200         Reviewed by Martin Robinson.
1201
1202         Return an empty array instead of "" in
1203         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
1204         will not be recognized as a valid command when the returned array
1205         is directly passed to perl's system() call.
1206
1207         * Scripts/webkitdirs.pm:
1208         (jhbuildWrapperPrefixIfNeeded):
1209
1210 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1211
1212         [chromium] add title text direction attribute to TestRunner
1213         https://bugs.webkit.org/show_bug.cgi?id=106907
1214
1215         Reviewed by Adam Barth.
1216
1217         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1218         (DRTTestRunner::DRTTestRunner):
1219         (DRTTestRunner::reset):
1220         * DumpRenderTree/chromium/DRTTestRunner.h:
1221         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1222         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1223         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1224         (WebTestRunner::TestRunner::TestRunner):
1225         (WebTestRunner::TestRunner::reset):
1226         (WebTestRunner::TestRunner::setTitleTextDirection):
1227         (WebTestRunner):
1228         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1229         (TestRunner):
1230         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1231         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1232         * DumpRenderTree/chromium/WebViewHost.cpp:
1233         (WebViewHost::didReceiveTitle):
1234
1235 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1236
1237         NRWT still confused about test count with --repeat-each and --iterations
1238         https://bugs.webkit.org/show_bug.cgi?id=106562
1239
1240         Reviewed by Dirk Pranke.
1241
1242         Fix the printed unique test count and skipped count. This
1243         seems to have broken in r127688 ("NRWT lies about the number
1244         of tests that it's skipping when used with --repeat-each").
1245
1246         Also add a test for print_found()
1247
1248         * Scripts/webkitpy/layout_tests/views/printing.py:
1249         (Printer.print_found):
1250         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1251         (Testprinter.test_details):
1252         (Testprinter):
1253         (Testprinter.test_found):
1254
1255 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1256
1257         Unreviewed follow-up to r139769.
1258
1259         Note that omitting the WebKit1 code from the build now
1260         works for GTK as well.
1261
1262         * Scripts/build-webkit:
1263
1264 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1265
1266         test-webkitpy: truncate output to the terminal width when necessary
1267         https://bugs.webkit.org/show_bug.cgi?id=106973
1268
1269         Reviewed by Ojan Vafai.
1270
1271         this implements the same logic for test-webkitpy that we have
1272         for run-webkit-tests (and ninja).
1273
1274         No tests written as this is exercised by running test-webkitpy itself.
1275
1276         * Scripts/webkitpy/test/printer.py:
1277         (Printer.configure):
1278         (Printer._test_line):
1279
1280 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1281
1282         remove extraneous output in test-webkitpy
1283         https://bugs.webkit.org/show_bug.cgi?id=106971
1284
1285         Reviewed by Ojan Vafai.
1286
1287         We weren't ignoring or capturing the echoed output from
1288         these two tests, and getting noise in the logs as a result.
1289
1290         * Scripts/webkitpy/common/system/executive_unittest.py:
1291         (ExecutiveTest.test_auto_stringify_args):
1292         (ExecutiveTest.test_popen_args):
1293
1294 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1295
1296         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
1297         https://bugs.webkit.org/show_bug.cgi?id=106974
1298
1299         Reviewed by Ryosuke Niwa.
1300
1301         I forgot to stub out the call to check to ensure that the ports were
1302         available, so this test could fail if something was listening on 8000 or
1303         8443 on the machine.
1304
1305         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1306         (TestHttpServer.test_win32_start_and_stop):
1307
1308 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1309
1310         Unreviewed, rolling out r139792.
1311         http://trac.webkit.org/changeset/139792
1312         https://bugs.webkit.org/show_bug.cgi?id=106970
1313
1314         Broke the windows build.
1315
1316         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1317         (DRTTestRunner::DRTTestRunner):
1318         (DRTTestRunner::notifyDone):
1319         (DRTTestRunner::reset):
1320         (DRTTestRunner::setAlwaysAcceptCookies):
1321         (DRTTestRunner::setWindowIsKey):
1322         (DRTTestRunner::pathToLocalResource):
1323         (DRTTestRunner::setPOSIXLocale):
1324         (InvokeCallbackTask):
1325         (InvokeCallbackTask::InvokeCallbackTask):
1326         (InvokeCallbackTask::runIfValid):
1327         (DRTTestRunner::setBackingScaleFactor):
1328         * DumpRenderTree/chromium/DRTTestRunner.h:
1329         (DRTTestRunner):
1330         (DRTTestRunner::taskList):
1331         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1332         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
1333         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1334         (WebTestRunner::TestRunner::TestRunner):
1335         (WebTestRunner::TestRunner::reset):
1336         (WebTestRunner::TestRunner::setDatabaseQuota):
1337         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1338         (TestRunner):
1339         * DumpRenderTree/chromium/WebViewHost.cpp:
1340         (WebViewHost::setPendingExtraData):
1341         (WebViewHost::setDeviceScaleFactor):
1342         * DumpRenderTree/chromium/WebViewHost.h:
1343         (WebViewHost):
1344
1345 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
1346
1347         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
1348
1349         * Scripts/webkitpy/common/config/ports.py:
1350         (MacWK2Port):
1351
1352 2013-01-15  Alan Cutter  <alancutter@chromium.org>
1353
1354         Extend sheriffbot's "help" command to be able to get help on individual commands
1355         https://bugs.webkit.org/show_bug.cgi?id=106629
1356
1357         Reviewed by Eric Seidel.
1358
1359         Added a help command to sheriffbot.
1360         Fixed some style issues and ordered the commands alphabetically.
1361
1362         * Scripts/webkitpy/tool/bot/irc_command.py:
1363         (IRCCommand):
1364         (IRCCommand.execute):
1365         (IRCCommand.usage):
1366         (IRCCommand.help):
1367         (CreateBug):
1368         (CreateBug.execute):
1369         (Help):
1370         (Help.execute):
1371         (Help._post_command_help):
1372         (Hi):
1373         (Hi.execute):
1374         (Restart):
1375         (RollChromiumDEPS):
1376         (RollChromiumDEPS._parse_args):
1377         (RollChromiumDEPS._expand_irc_nickname):
1378         (RollChromiumDEPS.execute):
1379         (Rollout):
1380         (Rollout._extract_revisions):
1381         (Rollout.execute):
1382         (Sheriffs):
1383         (Sheriffs.execute):
1384         (Whois):
1385         (Whois.execute):
1386         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1387         (IRCBotTest.test_help):
1388
1389 2013-01-15  Enrica Casucci  <enrica@apple.com>
1390
1391         Add a new set of WebKit2 APIs for text search and
1392         search results management.
1393         https://bugs.webkit.org/show_bug.cgi?id=106834.
1394         <rdar://problem/12597159>
1395
1396         Added new test for the new WebKit2 API for
1397         text search.
1398         
1399         Reviewed by Simon Fraser.
1400
1401         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1402         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
1403
1404 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1405
1406         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1407         https://bugs.webkit.org/show_bug.cgi?id=106904
1408
1409         Reverting 139794. It broke the build. It appears that a header file,
1410         WebTextDirection.h, was left out.
1411
1412         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1413         (DRTTestRunner::DRTTestRunner):
1414         (DRTTestRunner::reset):
1415         * DumpRenderTree/chromium/DRTTestRunner.h:
1416         (DRTTestRunner::setTitleTextDirection):
1417         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1418         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1419         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1420         (WebTestRunner::TestRunner::TestRunner):
1421         (WebTestRunner::TestRunner::reset):
1422         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1423         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1424         (TestRunner):
1425         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1426         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1427         * DumpRenderTree/chromium/WebViewHost.cpp:
1428         (WebViewHost::didReceiveTitle):
1429
1430 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1431
1432         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1433         https://bugs.webkit.org/show_bug.cgi?id=106904
1434
1435         Reviewed by Adam Barth.
1436
1437         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1438         (DRTTestRunner::DRTTestRunner):
1439         (DRTTestRunner::notifyDone):
1440         (DRTTestRunner::reset):
1441         * DumpRenderTree/chromium/DRTTestRunner.h:
1442         (DRTTestRunner):
1443         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1444         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1445         (WebTestRunner::WebTestDelegate::setFocus):
1446         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1447         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1448         (WebTestRunner::WebTestDelegate::setLocale):
1449         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1450         (WebTestRunner::TestRunner::TestRunner):
1451         (WebTestRunner::TestRunner::reset):
1452         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1453         (WebTestRunner):
1454         (WebTestRunner::TestRunner::setWindowIsKey):
1455         (WebTestRunner::TestRunner::pathToLocalResource):
1456         (WebTestRunner::TestRunner::setBackingScaleFactor):
1457         (WebTestRunner::TestRunner::setPOSIXLocale):
1458         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1459         (WebTestRunner::TestRunner::taskList):
1460         (TestRunner):
1461         * DumpRenderTree/chromium/WebViewHost.cpp:
1462         (WebViewHost::setDeviceScaleFactor):
1463         (WebViewHost::setFocus):
1464         (WebViewHost::setAcceptAllCookies):
1465         (WebViewHost::pathToLocalResource):
1466         (WebViewHost::setLocale):
1467         * DumpRenderTree/chromium/WebViewHost.h:
1468         (WebViewHost):
1469
1470 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1471
1472         Tests with WontFix expectation are (indirectly) skipped
1473         https://bugs.webkit.org/show_bug.cgi?id=105860
1474
1475         Reviewed by Dirk Pranke.
1476
1477         Only skip the WontFix expectation if there are no other layout test
1478         expectations (like Failure, ImageOnlyFailure) listed for the test.
1479         This makes it possible to run an expected failure for which there
1480         is no reason or interest to fix. There are some ports that would like
1481         to exercise this behavior as well as specific test cases that should use
1482         such expectations.
1483
1484         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1485         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
1486         WONTFIX test if there are no expectations listed. The warning is adjusted
1487         to reflect the new behavior.
1488         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
1489         and adjust test cases for these changes.
1490         (ExpectationSyntaxTests.test_wontfix):
1491         (SemanticTests.test_skip_and_wontfix):
1492
1493 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1494
1495         [chromium] add title text direction attribute to TestRunner
1496         https://bugs.webkit.org/show_bug.cgi?id=106907
1497
1498         Reviewed by Adam Barth.
1499
1500         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1501         (DRTTestRunner::DRTTestRunner):
1502         (DRTTestRunner::reset):
1503         * DumpRenderTree/chromium/DRTTestRunner.h:
1504         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1505         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1506         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1507         (WebTestRunner::TestRunner::TestRunner):
1508         (WebTestRunner::TestRunner::reset):
1509         (WebTestRunner::TestRunner::setTitleTextDirection):
1510         (WebTestRunner):
1511         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1512         (TestRunner):
1513         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1514         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1515         * DumpRenderTree/chromium/WebViewHost.cpp:
1516         (WebViewHost::didReceiveTitle):
1517
1518 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1519
1520         nrwt: change the default # of locked shards on chromium_win to 1
1521         https://bugs.webkit.org/show_bug.cgi?id=106938
1522
1523         Reviewed by Eric Seidel.
1524
1525         It looks like LigHTTPd might be buggy or unstable if we are
1526         running multiple http tests in parallel; see
1527         http://code.google.com/p/chromium/issues/detail?id=169530 for more
1528         context as well. This change will stop running http tests in parallel
1529         and we can see if this fixes things.
1530
1531         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1532         (ChromiumWinPort.default_max_locked_shards):
1533         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1534         (ChromiumWinTest.test_path_to_image_diff):
1535         (ChromiumWinTest):
1536         (ChromiumWinTest.test_default_max_locked_shards):
1537
1538 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1539
1540         [chromium] move WebDatabase related methods to TestRunner library
1541         https://bugs.webkit.org/show_bug.cgi?id=106905
1542
1543         Reviewed by Adam Barth.
1544
1545         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1546         (DRTTestRunner::DRTTestRunner):
1547         (DRTTestRunner::reset):
1548         * DumpRenderTree/chromium/DRTTestRunner.h:
1549         (DRTTestRunner):
1550         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1551         (WebTestRunner::WebTestDelegate::clearAllDatabases):
1552         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
1553         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1554         (WebTestRunner::TestRunner::TestRunner):
1555         (WebTestRunner::TestRunner::reset):
1556         (WebTestRunner::TestRunner::clearAllDatabases):
1557         (WebTestRunner):
1558         (WebTestRunner::TestRunner::setDatabaseQuota):
1559         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1560         (TestRunner):
1561         * DumpRenderTree/chromium/WebViewHost.cpp:
1562         (WebViewHost::clearAllDatabases):
1563         (WebViewHost::setDatabaseQuota):
1564         * DumpRenderTree/chromium/WebViewHost.h:
1565         (WebViewHost):
1566
1567 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
1568
1569         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
1570         functionality match the name.
1571         https://bugs.webkit.org/show_bug.cgi?id=106870
1572
1573         Reviewed by Adam Barth.
1574
1575         * Scripts/webkitpy/tool/commands/download.py:
1576         (Clean):
1577         (Update):
1578         (Build):
1579         (BuildAndTest):
1580         (CheckStyle):
1581         (BuildAttachment):
1582         (BuildAndTestAttachment):
1583         (AbstractPatchApplyingCommand):
1584         (ApplyWatchList):
1585         (AbstractPatchLandingCommand):
1586         (CreateRollout):
1587         * Scripts/webkitpy/tool/steps/__init__.py:
1588         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1589         (CleanWorkingDirectory.options):
1590         (CleanWorkingDirectory.run):
1591         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1592         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1593         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
1594
1595 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1596
1597         [Autotools] Add support for WebKit2-only builds
1598         https://bugs.webkit.org/show_bug.cgi?id=106889
1599
1600         Reviewed by Gustavo Noronha Silva.
1601
1602         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
1603         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
1604         building the GTK port through build-webkit.
1605         * Scripts/webkitdirs.pm:
1606         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
1607         arguments when not building WebKit1.
1608         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
1609         through the Autotools build system.
1610
1611 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1612
1613         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
1614         https://bugs.webkit.org/show_bug.cgi?id=106197
1615
1616         Reviewed by Martin Robinson.
1617
1618         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
1619         features. Enable them on GTK, meaning they will be enabled in development builds
1620         (i.e. when building with build-webkit).
1621
1622 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1623
1624         [GTK] Enable CSS Image Resolution feature
1625         https://bugs.webkit.org/show_bug.cgi?id=99038
1626
1627         Reviewed by Gustavo Noronha Silva.
1628
1629         Enable the CSS Image Resolution feature for the development
1630         builds of the GTK port.
1631
1632         * Scripts/webkitperl/FeatureList.pm:
1633
1634 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1635
1636         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
1637         https://bugs.webkit.org/show_bug.cgi?id=106579
1638
1639         Reviewed by Gustavo Noronha Silva.
1640
1641         The --enable-unstable-features flag is not required to be passed anymore
1642         to the configure script as it was removed in r138252.
1643
1644         * Scripts/webkitdirs.pm:
1645         (buildAutotoolsProject):
1646
1647 2013-01-15  Tony Chang  <tony@chromium.org>
1648
1649         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
1650
1651         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1652         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
1653         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1654         (TestHttpServer.test_win32_start_and_stop):
1655
1656 2013-01-15  Joshua Bell  <jsbell@chromium.org>
1657
1658         Unreviewed. Adding Michael Pruett as contributor.
1659
1660         * Scripts/webkitpy/common/config/committers.py:
1661
1662 2013-01-15  Victor Carbune  <victor@rosedu.org>
1663
1664         Unreviewed. Update my email addresses.
1665
1666         * Scripts/webkitpy/common/config/committers.py:
1667
1668 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1669
1670         [GTK] Waiting on the gdb process will lead to deadlock
1671         https://bugs.webkit.org/show_bug.cgi?id=106906
1672
1673         Reviewed by Philippe Normand.
1674
1675         Use communicate() rather than wait() on the Popen object that's running the gdb
1676         command. This avoids the deadlock that occurs on the GTK builders.
1677
1678         * Scripts/webkitpy/layout_tests/port/gtk.py:
1679         (GtkPort._get_gdb_output):
1680
1681 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1682
1683         [GTK] Limit the number of frames printed out when backtracing with gdb
1684         https://bugs.webkit.org/show_bug.cgi?id=106901
1685
1686         Reviewed by Philippe Normand.
1687
1688         Printing an unlimited number of frames when dumping the gdb backtracing
1689         output can cause timeouts in the builders. This patch limits the number
1690         of frames that are printed out to 1024.
1691
1692         * Scripts/webkitpy/layout_tests/port/gtk.py:
1693         (GtkPort._get_gdb_output):
1694
1695 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
1696
1697         [Qt] Fix ImageDiff's image format conversion
1698         https://bugs.webkit.org/show_bug.cgi?id=106880
1699
1700         Reviewed by Csaba Osztrogonác.
1701
1702         Besides actually doing the conversion this also silences the suspicious warning:
1703         "ignoring return value of function declared with warn_unused_result attribute".
1704
1705         * ImageDiff/qt/ImageDiff.cpp:
1706         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
1707         copy of the image in the given format and does not alter the image itself.
1708
1709 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1710
1711         [chromium] move remaining methods that just set a boolean flag to TestRunner library
1712         https://bugs.webkit.org/show_bug.cgi?id=106823
1713
1714         Reviewed by Darin Fisher.
1715
1716         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1717         (DRTTestRunner::DRTTestRunner):
1718         (DRTTestRunner::reset):
1719         * DumpRenderTree/chromium/DRTTestRunner.h:
1720         (DRTTestRunner):
1721         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1722         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
1723         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
1724         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
1725         (WebTestRunner::WebTestRunner::testRepaint):
1726         (WebTestRunner::WebTestRunner::sweepHorizontally):
1727         (WebTestRunner::WebTestRunner::isPrinting):
1728         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1729         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1730         (WebTestRunner::TestRunner::TestRunner):
1731         (WebTestRunner::TestRunner::reset):
1732         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
1733         (WebTestRunner):
1734         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
1735         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
1736         (WebTestRunner::TestRunner::testRepaint):
1737         (WebTestRunner::TestRunner::sweepHorizontally):
1738         (WebTestRunner::TestRunner::isPrinting):
1739         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1740         (WebTestRunner::TestRunner::dumpBackForwardList):
1741         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
1742         (WebTestRunner::TestRunner::dumpSelectionRect):
1743         (WebTestRunner::TestRunner::repaintSweepHorizontally):
1744         (WebTestRunner::TestRunner::setPrinting):
1745         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
1746         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1747         (TestRunner):
1748
1749 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1750
1751         nrwt: stub out show_results_html for mock ports
1752         https://bugs.webkit.org/show_bug.cgi?id=106848
1753
1754         Reviewed by Ojan Vafai.
1755
1756         We were accidentally using the underlying ports'
1757         show_results_html_file() implementation, which would, unsurprisingly,
1758         fail in many cases (e.g., running mock-efl on the mac).
1759
1760         No test added since we don't generally add tests for the mock
1761         implementation.
1762
1763         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1764         (MockDRTPort.show_results_html_file):
1765
1766 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
1767
1768         Changing clean_working_directory/clean_local_commits and related
1769         functions to have consistent naming.
1770
1771         https://bugs.webkit.org/show_bug.cgi?id=104198
1772
1773         Reviewed by Adam Barth.
1774
1775         * Scripts/webkitpy/common/checkout/scm/git.py:
1776         * Scripts/webkitpy/common/checkout/scm/scm.py:
1777         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1778         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1779         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1780         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1781
1782 2013-01-14  Alan Cutter  <alancutter@chromium.org>
1783
1784         Fix EWS GCE build scripts to detect which zone is available
1785         https://bugs.webkit.org/show_bug.cgi?id=106524
1786
1787         Reviewed by Adam Barth.
1788
1789         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1790         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1791         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1792         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
1793
1794 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
1795
1796         Adding an error string to AmbiguousCommitError.
1797         https://bugs.webkit.org/show_bug.cgi?id=106846
1798
1799         Reviewed by Adam Barth.
1800
1801         * Scripts/webkitpy/common/checkout/scm/git.py:
1802         (AmbiguousCommitError.__init__):
1803
1804 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1805
1806         kill whole lighttpd process tree for chromium win
1807         https://bugs.webkit.org/show_bug.cgi?id=106838
1808
1809         Reviewed by Tony Chang.
1810
1811         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
1812         I think a test is causing a httpd server child process to wedge and
1813         killing the parent httpd server process isn't sufficient to ensure
1814         that the children are also killed.
1815
1816         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1817         (Lighttpd._check_and_kill):
1818         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1819         (TestHttpServer.test_start_cmd):
1820         (TestHttpServer):
1821         (TestHttpServer.test_win32_start_and_stop):
1822         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
1823         (TestHttpServer.test_win32_start_and_stop.mock_returns):
1824         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
1825
1826 2013-01-14  Nico Weber  <thakis@chromium.org>
1827
1828         [chromium] Enable `update-webkit --chromium --ninja` on windows
1829         https://bugs.webkit.org/show_bug.cgi?id=106836
1830
1831         Reviewed by Eric Seidel.
1832
1833         After running this, build-webkit --chromium will use ninja to build.
1834         Apparently there are some minor issues with that still, so it's
1835         not quite ready for use yet.
1836
1837         * Scripts/webkitdirs.pm:
1838         (determineIsChromiumNinja):
1839         (buildChromium):
1840
1841 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1842
1843         nrwt: use the same search path for baselines and TestExpectations on apple mac
1844         https://bugs.webkit.org/show_bug.cgi?id=105599
1845
1846         Reviewed by Ryosuke Niwa.
1847
1848         Bug 105583 revealed some confusion due to the fact that the Apple
1849         Mac port used a different list of directories to search for baselines
1850         and TestExpectations files (actually, pretty much every port does).
1851
1852         It seems like a good idea to use the same list for both by default, but
1853         making this happen will affect every port in slightly different ways, so
1854         we'll try this on the Apple Mac port first.
1855
1856         Note that the effective changes for this are that:
1857         1) The apple mac port will look in platform/wk2 for baselines where
1858         it didn't before (it will look after looking in mac-wk2 but before
1859         the non-wk2 dirs)
1860         2) The apple mac-snowleopard port will use the expectations in
1861         mac-lion as well as the expectations in mac-snowleopard, although
1862         I'm not even sure if mac-snowleopard is still supported ...
1863
1864         * Scripts/webkitpy/layout_tests/port/mac.py:
1865         (MacPort.default_baseline_search_path):
1866         (MacPort.expectations_files):
1867         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1868         (test_baseline_search_path):
1869
1870 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
1871
1872         AX: Need to implement ColorWellRole
1873         https://bugs.webkit.org/show_bug.cgi?id=106756
1874
1875         Reviewed by Chris Fleizach.
1876
1877         Returns a string representation of the value of a color
1878         when the role is Color Well, to make it easy to write layout
1879         tests for color controls.
1880
1881         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1882
1883 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
1884
1885         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
1886         https://bugs.webkit.org/show_bug.cgi?id=106682
1887
1888         Reviewed by Chris Fleizach.
1889
1890         Modify Chromium's DRT implementation of intValue to return a
1891         different value depending on the role.
1892
1893         There are actually platform-specific differences in what should
1894         be returned in the "value" of an object, so Chromium normally keeps
1895         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
1896         but this is a fine simplification to make cross-platform tests easier.
1897
1898         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1899         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
1900
1901 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
1902
1903         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
1904         https://bugs.webkit.org/show_bug.cgi?id=106785
1905
1906         Reviewed by Adam Barth.
1907
1908         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1909         (DRTTestRunner::DRTTestRunner):
1910         (DRTTestRunner::reset):
1911         * DumpRenderTree/chromium/DRTTestRunner.h:
1912         (DRTTestRunner):
1913         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1914         (WebTestProxyBase):
1915         (WebTestRunner::WebTestProxy::setStatusText):
1916         (WebTestRunner::WebTestProxy::didStopLoading):
1917         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1918         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
1919         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
1920         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1921         (WebTestRunner::TestRunner::TestRunner):
1922         (WebTestRunner::TestRunner::reset):
1923         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
1924         (WebTestRunner):
1925         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
1926         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
1927         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
1928         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1929         (TestRunner):
1930         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1931         (WebTestRunner::WebTestProxyBase::setStatusText):
1932         (WebTestRunner):
1933         (WebTestRunner::WebTestProxyBase::didStopLoading):
1934         * DumpRenderTree/chromium/WebViewHost.cpp:
1935         (WebViewHost::didStopLoading):
1936         * DumpRenderTree/chromium/WebViewHost.h:
1937         (WebViewHost):
1938
1939 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
1940
1941         Web Inspector: devtools front-end doesn't have focus in TestShell
1942         https://bugs.webkit.org/show_bug.cgi?id=106778
1943
1944         Reviewed by Pavel Feldman.
1945
1946         Focus devTools window after loadURL method.
1947
1948         * DumpRenderTree/chromium/TestShell.cpp:
1949         (TestShell::runFileTest):
1950
1951 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1952
1953         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
1954         https://bugs.webkit.org/show_bug.cgi?id=106573
1955
1956         Reviewed by Philippe Normand.
1957
1958         Similarly to what's been described in bug 106569, we're building
1959         from release tarballs, so there's no reason to regenerate the
1960         autoconf-related stuff with autogen.sh, especially since we might
1961         run into trouble with automake 1.13 and deprecated macros.
1962
1963         * efl/jhbuild.modules:
1964
1965 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1966
1967         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
1968         https://bugs.webkit.org/show_bug.cgi?id=104909
1969
1970         Reviewed by Simon Hausmann.
1971
1972         To be able to build redistribuable binary packages, Qt's configure switches
1973         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
1974         dynamically link to optional system libraries.
1975         QtWebKit is doing its own configure checks for those libraries, thus adding a
1976         runtime dependency that might not be fulfilled if the packager's machine had
1977         those libraries while the user's machine won't.
1978
1979         Since in most cases where WebKit will want to use those system libraries, Qt will
1980         also be using them, remove these configure tests from WebKit.
1981
1982         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
1983         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
1984         * qmake/config.tests/libpng/libpng.cpp: Removed.
1985         * qmake/config.tests/libpng/libpng.pro: Removed.
1986         * qmake/mkspecs/features/features.prf:
1987
1988 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1989
1990         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
1991         https://bugs.webkit.org/show_bug.cgi?id=106574
1992
1993         Reviewed by Laszlo Gombos.
1994
1995         Rely on a more recent stable release, which includes support for
1996         Lua 5.2 in Edje and other assorted minor fixes.
1997
1998         While here, also use the "configure" script to build the libraries
1999         instead of relying on autogen.sh, which is not really needed with
2000         a release tarball and may have problems with automake 1.13.
2001
2002         * efl/jhbuild.modules:
2003
2004 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2005
2006         Web Inspector: fix DRT to deliver simulated events to devtools front-end
2007         https://bugs.webkit.org/show_bug.cgi?id=106650
2008
2009         Reviewed by Pavel Feldman.
2010
2011         Add separated m_devToolsTestInterfaces object to testShell which is
2012         bind to devTools webview.
2013
2014         * DumpRenderTree/chromium/TestShell.cpp:
2015         (TestShell::initialize):
2016         (TestShell::createMainWindow):
2017         (TestShell::~TestShell):
2018         (TestShell::showDevTools):
2019         (TestShell::resetTestController):
2020         (TestShell::bindJSObjectsToWindow):
2021         (TestShell::createNewWindow):
2022         * DumpRenderTree/chromium/TestShell.h:
2023         (TestShell):
2024
2025 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2026
2027         Sheriffbot command aliases need test cases
2028         https://bugs.webkit.org/show_bug.cgi?id=106754
2029
2030         Reviewed by Eric Seidel.
2031
2032         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2033         (SheriffBotTest.test_command_aliases):
2034
2035 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2036
2037         Allow users to misspell the "sheriffs" command in sheriffbot
2038         https://bugs.webkit.org/show_bug.cgi?id=106628
2039
2040         Reviewed by Steve Block.
2041
2042         * Scripts/webkitpy/tool/bot/irc_command.py:
2043
2044 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2045
2046         Make "gardeners" an alias for "sheriffs" in sherrifbot
2047         https://bugs.webkit.org/show_bug.cgi?id=106627
2048
2049         Reviewed by Eric Seidel.
2050
2051         * Scripts/webkitpy/tool/bot/irc_command.py:
2052
2053 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
2054
2055         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
2056         https://bugs.webkit.org/show_bug.cgi?id=105380
2057
2058         Reviewed by Eric Seidel.
2059
2060         Fix a regression introduced in r137692 where we were double-encoding
2061         the arguments to popen(); this was only an issue on windows, where
2062         we would try to encode something to mbcs, then try to encode it
2063         to unicode as if the input as ascii.
2064
2065         * Scripts/webkitpy/common/system/executive.py:
2066         (Executive.run_command):
2067
2068 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2069
2070         State who told sheriffbot to roll the Chromium deps and to what revision
2071         https://bugs.webkit.org/show_bug.cgi?id=106626
2072
2073         Reviewed by Eric Seidel.
2074
2075         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
2076
2077         * Scripts/webkitpy/tool/bot/irc_command.py:
2078         (RollChromiumDEPS._expand_irc_nickname):
2079         (RollChromiumDEPS.execute):
2080         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2081         (IRCCommandTest.test_roll_chromium_deps):
2082         * Scripts/webkitpy/tool/bot/sheriff.py:
2083         (Sheriff.post_chromium_deps_roll):
2084         * Scripts/webkitpy/tool/commands/roll.py:
2085         (RollChromiumDEPS._prepare_state):
2086         (PostChromiumDEPSRoll):
2087         (PostChromiumDEPSRoll._prepare_state):
2088         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2089         (PostRollCommandsTest.test_prepare_state):
2090         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2091         (PrepareChangeLogForDEPSRoll.run):
2092
2093 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2094
2095         Add Alan Cutter as contributor
2096         https://bugs.webkit.org/show_bug.cgi?id=106747
2097
2098         Reviewed by Eric Seidel.
2099
2100         * Scripts/webkitpy/common/config/committers.py:
2101
2102 2013-01-13  Jonathan Liu  <net147@gmail.com>
2103
2104         Fix CONFIG missing link_pkgconfig on Windows
2105         https://bugs.webkit.org/show_bug.cgi?id=106647
2106
2107         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
2108         properly on Windows because they are added to PKGCONFIG but
2109         CONFIG does not contain link_pkgconfig.
2110
2111         This is because link_pkgconfig is added in unix/default_pre.prf
2112         which is only used for UNIX platforms. To fix this, move it to
2113         the general default_pre.prf.
2114
2115         Reviewed by Simon Hausmann.
2116
2117         * qmake/mkspecs/features/default_pre.prf:
2118         * qmake/mkspecs/features/unix/default_pre.prf:
2119
2120 2013-01-12  Nico Weber  <thakis@chromium.org>
2121
2122         nrwt/chromium: Don't prefer chromium over webkit build directories
2123         https://bugs.webkit.org/show_bug.cgi?id=105597
2124
2125         Reviewed by Dirk Pranke.
2126
2127         Rely on the new timestamp logic instead. Requested by dpranke in
2128         https://bugs.webkit.org/show_bug.cgi?id=105498
2129
2130         * Scripts/webkitpy/layout_tests/port/chromium.py:
2131         (ChromiumPort._static_build_path):
2132         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2133         (ChromiumLinuxPortTest.test_build_path):
2134         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2135         (ChromiumMacPortTest.test_build_path):
2136         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2137         (ChromiumWinTest.test_build_path):
2138
2139 2013-01-12  Nico Weber  <thakis@chromium.org>
2140
2141         Use ninja by default on Linux for build-webkit --chromium, bot edition
2142         https://bugs.webkit.org/show_bug.cgi?id=104434
2143
2144         Reviewed by Eric Seidel.
2145
2146         r139557 changed update-webkit to pick ninja by default on linux, but
2147         the bots run update-webkit-chromium directly so they didn't see this.
2148         Move the default for ninja into update-webkit-chromium so that it's
2149         picked up by the bots, and let update-webkit forward non-default
2150         options to there.
2151
2152         This way, the default is in one place only and both developers (who
2153         usually use update-webkit which then shells out to
2154         updat-webkit-chromium) and bots (which use update-webkit-chromium
2155         directly) see the same behavior.
2156
2157         * Scripts/update-webkit:
2158         * Scripts/update-webkit-chromium:
2159
2160 2013-01-12  Nico Weber  <thakis@chromium.org>
2161
2162         Make ninja the default build system on Linux for build-webkit --chromium
2163         https://bugs.webkit.org/show_bug.cgi?id=104434
2164
2165         Reviewed by Eric Seidel.
2166
2167         * Scripts/update-webkit:
2168
2169 2013-01-12  Alan Cutter  <alancutter@chromium.org>
2170
2171         Migrate the remaining bots in EC2 to Google Compute Engine
2172         https://bugs.webkit.org/show_bug.cgi?id=106005
2173
2174         Reviewed by Eric Seidel.
2175
2176         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
2177
2178         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
2179         * EWSTools/boot.sh:
2180         * EWSTools/build-repo.sh:
2181         * EWSTools/start-queue.sh:
2182
2183 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
2184
2185         [chromium] move inspector related methods to TestRunner library
2186         https://bugs.webkit.org/show_bug.cgi?id=106654
2187
2188         Reviewed by Adam Barth.
2189
2190         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2191         (DRTTestRunner::DRTTestRunner):
2192         * DumpRenderTree/chromium/DRTTestRunner.h:
2193         (DRTTestRunner):
2194         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2195         (WebTestRunner::WebTestDelegate::showDevTools):
2196         (WebTestRunner::WebTestDelegate::closeDevTools):
2197         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
2198         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2199         (WebTestRunner::TestRunner::TestRunner):
2200         (WebTestRunner::TestRunner::showWebInspector):
2201         (WebTestRunner):
2202         (WebTestRunner::TestRunner::closeWebInspector):
2203         (WebTestRunner::TestRunner::evaluateInWebInspector):
2204         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2205         (TestRunner):
2206         * DumpRenderTree/chromium/WebViewHost.cpp:
2207         (WebViewHost::showDevTools):
2208         (WebViewHost::closeDevTools):
2209         (WebViewHost::evaluateInWebInspector):
2210         * DumpRenderTree/chromium/WebViewHost.h:
2211         (WebViewHost):
2212
2213 2013-01-11  Julie Parent  <jparent@chromium.org>
2214
2215         Builder should not be a valid parameter for stats dashboard
2216         https://bugs.webkit.org/show_bug.cgi?id=106698
2217
2218         Reviewed by Dirk Pranke.
2219         
2220         Since builder is a dashboard specific parameter, dashboard_base
2221         should not be handling it in handleValidHashParameterWrapper, rather,
2222         each specific dashboard should in its handleValidHashParameter function.
2223     
2224         Note that the FIXME in dashboard_base about this was actually wrong -
2225         we don't want to move it to g_crossDashboardState, because it isn't
2226         actually cross dashboard state.
2227         
2228         In fact, flakiness and treemap have the code in 
2229         handleValidHashParameter, but it is currently dead code because 
2230         dashboard_base gets to it first.
2231         
2232         Added the proper handling to timeline_explorer, since builder is
2233         valid there.
2234
2235         * TestResultServer/static-dashboards/dashboard_base.js:
2236         * TestResultServer/static-dashboards/timeline_explorer.html:
2237
2238 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2239
2240         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
2241         https://bugs.webkit.org/show_bug.cgi?id=106688
2242
2243         Reviewed by Eric Seidel.
2244
2245         Update the regular expression used to strip the garbage at the beginning.
2246
2247         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2248         (RunWebKitTests.nrwt_log_message_regexp):
2249
2250 2013-01-11  Pratik Solanki  <psolanki@apple.com>
2251
2252         TestRunner leaks when running tests
2253         https://bugs.webkit.org/show_bug.cgi?id=106683
2254
2255         Reviewed by Simon Fraser.
2256
2257         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
2258         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
2259         tests.
2260
2261         * DumpRenderTree/TestRunner.cpp:
2262         (TestRunner::makeWindowObject):
2263
2264 2013-01-11  Julie Parent  <jparent@chromium.org>
2265
2266         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
2267         https://bugs.webkit.org/show_bug.cgi?id=106247
2268
2269         Old code nulled out the loader instance when it completed loading and
2270         then later used the fact that it was null to determine if it had loaded
2271         or not.  This is not only unintuitive, but it also prevents using the
2272         loader object later on.
2273         
2274         Added new method, used it, added unit test for it.
2275         
2276         Reviewed by Dirk Pranke.
2277
2278         * TestResultServer/static-dashboards/dashboard_base.js:
2279         (resourceLoadingComplete):
2280         (handleLocationChange):
2281         * TestResultServer/static-dashboards/loader.js:
2282         (.):
2283         * TestResultServer/static-dashboards/loader_unittests.js:
2284
2285 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2286
2287         Try CRLF to LF change in r139407 again.
2288
2289         * BuildSlaveSupport/delete-stale-build-files:
2290         (main):
2291         (webkitBuildDirectory):
2292         * BuildSlaveSupport/kill-old-processes:
2293         (main):
2294
2295 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2296
2297         [GTK] Disable the unit tests timeout when running from make check
2298         https://bugs.webkit.org/show_bug.cgi?id=106670
2299
2300         Reviewed by Philippe Normand.
2301
2302         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
2303
2304 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2305
2306         Yet another unreviewed fix after r139431.
2307
2308         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
2309         the correct order.
2310
2311 2013-01-11  Dan Carney  <dcarney@google.com>
2312
2313         [chromium] move some whitespace and resize related methods to TestRunner library
2314         https://bugs.webkit.org/show_bug.cgi?id=106655
2315
2316         Reviewed by Jochen Eisinger.
2317
2318         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2319         (DRTTestRunner::DRTTestRunner):
2320         * DumpRenderTree/chromium/DRTTestRunner.h:
2321         (DRTTestRunner):
2322         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2323         (WebKit):
2324         (WebTestRunner::WebTestDelegate::setClientWindowRect):
2325         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
2326         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
2327         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2328         (WebTestRunner::TestRunner::TestRunner):
2329         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
2330         (WebTestRunner):
2331         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
2332         (WebTestRunner::TestRunner::enableAutoResizeMode):
2333         (WebTestRunner::TestRunner::disableAutoResizeMode):
2334         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2335         (TestRunner):
2336         * DumpRenderTree/chromium/WebViewHost.cpp:
2337         (WebViewHost::setClientWindowRect):
2338         * DumpRenderTree/chromium/WebViewHost.h:
2339         (WebViewHost):
2340
2341 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
2342
2343         Unreviewed. Update my e-mail addresses.
2344
2345         * Scripts/webkitpy/common/config/committers.py:
2346
2347 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2348
2349         Another unreviewed fix after r139431.
2350
2351         In a way, this is also a generic bug fix, since previously isEfl()
2352         would fail when called from run-efl-tests and we thus did not use
2353         jhbuild to run our tests. This now resulted in us calling
2354         "jhbuild-wrapper run" without specifying a platform.
2355
2356         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
2357         to work.
2358
2359 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2360
2361         [Qt][WK1] Web Audio support
2362         https://bugs.webkit.org/show_bug.cgi?id=106651
2363
2364         Reviewed by Jocelyn Turcotte.
2365
2366         Implements support for dumping audio data in DumpRenderTree.
2367
2368         Adds WebAudio to toggleable features in QtTestBrowser.
2369
2370         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
2371         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
2372
2373         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2374         (WebCore::DumpRenderTree::dump):
2375         * DumpRenderTree/qt/TestRunnerQt.cpp:
2376         (TestRunner::reset):
2377         (TestRunner::overridePreference):
2378         (TestRunner::setAudioData):
2379         * DumpRenderTree/qt/TestRunnerQt.h:
2380         (TestRunner::shouldDumpAsAudio):
2381         (TestRunner::audioData):
2382         (TestRunner):
2383         * QtTestBrowser/launcherwindow.cpp:
2384         (LauncherWindow::applyPrefs):
2385         (LauncherWindow::createChrome):
2386         (LauncherWindow::toggleWebAudio):
2387         * QtTestBrowser/launcherwindow.h:
2388         (WindowOptions::WindowOptions):
2389         (WindowOptions):
2390         (LauncherWindow):
2391         * qmake/mkspecs/features/features.prf:
2392         * qmake/mkspecs/features/features.pri:
2393
2394 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2395
2396         Unreviewed jhbuild-related fix after r139431.
2397
2398         * Scripts/webkitpy/layout_tests/port/efl.py:
2399         (EflPort.__init__): Pass a string to set_option_default(), since
2400         shlex.split() will be called on it later.
2401
2402 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
2403
2404         Unreviewed typo fixes after r139431.
2405
2406         * Scripts/run-javascriptcore-tests:
2407
2408 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2409
2410         [jhbuild] Remove the "run-with-jhbuild" scripts.
2411         https://bugs.webkit.org/show_bug.cgi?id=106572
2412
2413         Reviewed by Martin Robinson.
2414
2415         Both ports which use jhbuild were mostly duplicating the
2416         `run-with-jhbuild' script in their own directories for no clear reason.
2417
2418         The script itself was just a thin wrapper around the `jhbuild-wrapper',
2419         so just start using that directly and get rid of a useless middle man.
2420
2421         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
2422         instead.
2423
2424         * Scripts/run-javascriptcore-tests:
2425         * Scripts/run-launcher:
2426         * Scripts/webkitdirs.pm:
2427         (runAutogenForAutotoolsProjectIfNecessary):
2428         (buildAutotoolsProject):
2429         (jhbuildWrapperPrefixIfNeeded):
2430         (generateBuildSystemFromCMakeProject):
2431         (buildCMakeGeneratedProject):
2432         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
2433         (run):
2434         * Scripts/webkitpy/layout_tests/port/efl.py:
2435         (EflPort.__init__):
2436         (EflPort._image_diff_command):
2437         * efl/run-with-jhbuild: Removed.
2438         * gtk/run-with-jhbuild: Removed.
2439
2440 2013-01-11  Alan Cutter  <alancutter@chromium.org>
2441
2442         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
2443         https://bugs.webkit.org/show_bug.cgi?id=106636
2444
2445         Reviewed by Adam Barth.
2446
2447         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
2448
2449         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2450         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2451         * EWSTools/screen-config:
2452         * EWSTools/start-queue.sh:
2453
2454 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2455
2456         kill-old-processes and delete-stale-build-files use CRLF linebreaks
2457         https://bugs.webkit.org/show_bug.cgi?id=106622
2458
2459         Reviewed by Simon Fraser.
2460
2461         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
2462         Also escape clang\+\+ correctly in kill-old-processes.
2463
2464         * BuildSlaveSupport/delete-stale-build-files:
2465         * BuildSlaveSupport/kill-old-processes:
2466
2467 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2468
2469         Build fix after r139357. It was missing a comma.
2470
2471         * QueueStatusServer/model/queues.py:
2472         (Queue):
2473
2474 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2475
2476         Fixing AuthenticationError when running test-webkitpy as a non-committer.
2477         https://bugs.webkit.org/show_bug.cgi?id=106420
2478
2479         Reviewed by Eric Seidel.
2480
2481         * Scripts/webkitpy/common/checkout/scm/git.py:
2482         (Git.push_local_commits_to_server):
2483         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2484         * Scripts/webkitpy/common/checkout/scm/svn.py:
2485         (SVNRepository):
2486         (SVNRepository.has_authorization_for_realm):
2487
2488 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
2489
2490         [EFL][jhbuild] Use tarballs for gstreamer instead of git
2491         https://bugs.webkit.org/show_bug.cgi?id=106552
2492
2493         Reviewed by Laszlo Gombos.
2494
2495         Use tarballs for gstreamer instead of git in EFL's jhbuild
2496         to work around intermittent network issues on our build
2497         bots. Tarballs are fully cached and require no network
2498         operation if their checksum matches.
2499
2500         * efl/jhbuild.modules:
2501
2502 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2503
2504         Add Mac WK2 EWS bots
2505         https://bugs.webkit.org/show_bug.cgi?id=106590
2506
2507         Reviewed by Adam Barth.
2508
2509         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
2510         Also add a deprecated MacWK2Port class.
2511
2512         * QueueStatusServer/model/queues.py:
2513         (Queue):
2514         * Scripts/webkitpy/common/config/ports.py:
2515         (DeprecatedPort.port):
2516         (MacWK2Port):
2517         (MacWK2Port.run_webkit_tests_command):
2518         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2519         (MacEWS):
2520         (MacWK2EWS):
2521         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2522         (_test_ewses):
2523
2524 2013-01-10  Dan Carney  <dcarney@google.com>
2525
2526         [chromium] move webpermissionclient related methods to TestRunner library
2527         https://bugs.webkit.org/show_bug.cgi?id=106548
2528
2529         Reviewed by Jochen Eisinger.
2530
2531         * DumpRenderTree/DumpRenderTree.gypi:
2532         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2533         (DRTTestRunner::DRTTestRunner):
2534         (DRTTestRunner::reset):
2535         * DumpRenderTree/chromium/DRTTestRunner.h:
2536         (DRTTestRunner):
2537         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2538         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
2539         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2540         (WebKit):
2541         (WebTestRunner::WebTestRunner::webPermissions):
2542         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2543         (WebTestRunner::TestRunner::TestRunner):
2544         (WebTestRunner::TestRunner::setDelegate):
2545         (WebTestRunner):
2546         (WebTestRunner::TestRunner::reset):
2547         (WebTestRunner::TestRunner::webPermissions):
2548         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
2549         (WebTestRunner::TestRunner::setImagesAllowed):
2550         (WebTestRunner::TestRunner::setScriptsAllowed):
2551         (WebTestRunner::TestRunner::setStorageAllowed):
2552         (WebTestRunner::TestRunner::setPluginsAllowed):
2553         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
2554         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
2555         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2556         (WebTestRunner):
2557         (TestRunner):
2558         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
2559         (WebTestRunner):
2560         (WebTestRunner::WebPermissions::WebPermissions):
2561         (WebTestRunner::WebPermissions::~WebPermissions):
2562         (WebTestRunner::WebPermissions::allowImage):
2563         (WebTestRunner::WebPermissions::allowScriptFromSource):
2564         (WebTestRunner::WebPermissions::allowStorage):
2565         (WebTestRunner::WebPermissions::allowPlugins):
2566         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
2567         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
2568         (WebTestRunner::WebPermissions::setImagesAllowed):
2569         (WebTestRunner::WebPermissions::setScriptsAllowed):
2570         (WebTestRunner::WebPermissions::setStorageAllowed):
2571         (WebTestRunner::WebPermissions::setPluginsAllowed):
2572         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
2573         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
2574         (WebTestRunner::WebPermissions::setDelegate):
2575         (WebTestRunner::WebPermissions::setDumpCallbacks):
2576         (WebTestRunner::WebPermissions::reset):
2577         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
2578         (WebTestRunner):
2579         (WebPermissions):
2580         * DumpRenderTree/chromium/TestShell.cpp:
2581         (TestShell::initialize):
2582         (TestShell::resetTestController):
2583         (TestShell::createNewWindow):
2584         * DumpRenderTree/chromium/TestShell.h:
2585         (TestShell):
2586         * DumpRenderTree/chromium/WebViewHost.cpp:
2587         (WebViewHost::normalizeLayoutTestURL):
2588         * DumpRenderTree/chromium/WebViewHost.h:
2589         (WebViewHost):
2590
2591 2013-01-10  Alan Cutter  <alancutter@chromium.org>
2592
2593         Split EWS tool cold-boot.sh into modular components
2594         https://bugs.webkit.org/show_bug.cgi?id=106527
2595
2596         Reviewed by Adam Barth.
2597
2598         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
2599         Updated GCE bot build scripts to match.
2600         Unable to test scripts directly as they depend on being in the repository to work!
2601
2602         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2603         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2604         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
2605         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
2606         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
2607
2608 2013-01-10  Julie Parent  <jparent@chromium.org>
2609
2610         Dashboard Cleanup: Do not generate the page if we are about to reload.
2611         https://bugs.webkit.org/show_bug.cgi?id=106584
2612
2613         Reviewed by Dirk Pranke.
2614
2615         Move the logic to determine if we should generate the page into
2616         parseParameters() since that is where we have the knowledge to
2617         determine it, and return that value to handleLocationChange, 
2618         rather than passing the changed parameters back to handleLocationChange
2619         and having it make the decision.
2620         
2621         This is logically equivalent, save one case: when we are about to do
2622         a reload, we know that there is no reason to generate the page.  Old
2623         code was causing an extra page generation in this case.
2624         
2625         * TestResultServer/static-dashboards/dashboard_base.js:
2626         (parseParameters):
2627         (handleLocationChange):
2628
2629 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2630
2631         [jhbuild] Use the "configure" script to build glib
2632         https://bugs.webkit.org/show_bug.cgi?id=106569
2633
2634         Reviewed by Martin Robinson.
2635
2636         So far both EFL and GTK have been using autogen.sh to build glib.
2637         While that does work most of the time, it's not really needed since
2638         we are downloading and building stable releases from tarballs.
2639         Additionally, autogen.sh fails to work with automake 1.13 due to the
2640         usage of some macros that have been removed (this has already been
2641         fixed in glib master).
2642
2643         * efl/jhbuild.modules:
2644         * gtk/jhbuild.modules:
2645
2646 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2647
2648         Changing tests to be consistent and use self.scm rather then recreating the scm object.
2649         (Missed a couple)
2650         https://bugs.webkit.org/show_bug.cgi?id=106536
2651
2652         Reviewed by Eric Seidel.
2653
2654         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2655
2656 2013-01-10  Tony Chang  <tony@chromium.org>
2657
2658         Speed up supplemental dependency computation
2659         https://bugs.webkit.org/show_bug.cgi?id=106503
2660
2661         Reviewed by Adam Barth.
2662
2663         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
2664
2665         * WebKitTestRunner/CMakeLists.txt:
2666
2667 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
2668
2669         Remove the ENABLE_ANIMATION_API feature define occurences
2670         https://bugs.webkit.org/show_bug.cgi?id=106544
2671
2672         Reviewed by Simon Fraser.
2673
2674         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
2675         feature define handling still lingers in various build systems and configurations
2676         but is of no use, so it should be removed.
2677
2678         * Scripts/webkitperl/FeatureList.pm:
2679         * qmake/mkspecs/features/features.pri:
2680
2681 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2682
2683         [GTK] Add support for loading web process extensions
2684         https://bugs.webkit.org/show_bug.cgi?id=105631
2685
2686         Reviewed by Gustavo Noronha Silva.
2687
2688         * MiniBrowser/gtk/GNUmakefile.am:
2689         * MiniBrowser/gtk/main.c:
2690         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
2691         bundle lib from build dir.
2692         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
2693         located in WebProcess/InjectedBundle/API/gtk.
2694         * gtk/generate-gtkdoc:
2695         (get_webkit2_options): Scan also files in
2696         WebProcess/InjectedBundle/API/gtk to generate API docs.
2697         (get_webkit2_options.injected_bundle_src_path): Helper function to
2698         build paths in WebProcess/InjectedBundle/API/gtk.
2699
2700 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2701
2702         [EFL][WK2] Writing immediately to created windows (open) fails
2703         https://bugs.webkit.org/show_bug.cgi?id=105276
2704
2705         Reviewed by Kenneth Rohde Christiansen.
2706
2707         Do not reset 'about:blank' url for the new pages in mini browser.
2708
2709         * MiniBrowser/efl/main.c:
2710         (window_create):
2711
2712 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2713
2714         Changing tests to be consistent and use self.scm rather then recreating the scm object.
2715         https://bugs.webkit.org/show_bug.cgi?id=106536
2716
2717         Reviewed by Eric Seidel.
2718
2719         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2720
2721 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2722
2723         Converting to unittest2 so we can use assertItemsEqual, making tests
2724         not dependent on order of items.
2725         https://bugs.webkit.org/show_bug.cgi?id=106532
2726
2727         Before:
2728         Ran 1733 tests in 38.385s
2729         FAILED (failures=1, errors=22)
2730
2731         After:
2732         Ran 1733 tests in 32.298s
2733         FAILED (failures=0, errors=22)
2734
2735         Reviewed by Eric Seidel.
2736
2737         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2738         * Scripts/webkitpy/thirdparty/__init__.py:
2739         (AutoinstallImportHook._install_unittest2):
2740
2741 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
2742
2743         [EFL] Add gstreamer 1.0.5 to jhbuild
2744         https://bugs.webkit.org/show_bug.cgi?id=106178
2745
2746         Reviewed by Laszlo Gombos.
2747
2748         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
2749
2750         * efl/jhbuild.modules:
2751
2752 2013-01-09  Alan Cutter  <alancutter@chromium.org>
2753
2754         Updated parameters in GCE build scripts so they now work.
2755         https://bugs.webkit.org/show_bug.cgi?id=106523
2756
2757         Reviewed by Adam Barth.
2758
2759         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2760         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2761         * EWSTools/cold-boot.sh:
2762
2763 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
2764
2765         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
2766         https://bugs.webkit.org/show_bug.cgi?id=106520
2767
2768         Reviewed by James Robinson.
2769
2770         Part of a larger refactoring series. See tracking bug 82948.
2771
2772         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2773         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2774
2775 2013-01-09  Julie Parent  <jparent@chromium.org>
2776
2777         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
2778         https://bugs.webkit.org/show_bug.cgi?id=106514
2779
2780         This is old code, as these can no longer get out of sync.
2781         permmaLinkURLHash is generated from currentState, which is set only
2782         from the location.  The commment about how these can get out of sync
2783         refers to a function that no longer exists.
2784         
2785         Reviewed by Dirk Pranke.
2786
2787         * TestResultServer/static-dashboards/dashboard_base.js:
2788         (handleLocationChange):
2789
2790 2013-01-09  Julie Parent  <jparent@chromium.org>
2791
2792         Dashboard Cleanup: Reload the page as soon as we know we need to.
2793         https://bugs.webkit.org/show_bug.cgi?id=106515
2794
2795         No need to continue parsing all of the data once we know that
2796         we need to do a reload.
2797         
2798         Reviewed by Dirk Pranke.
2799
2800         * TestResultServer/static-dashboards/dashboard_base.js:
2801         (parseParameters):
2802
2803 2013-01-09  Eric Seidel  <eric@webkit.org>
2804
2805         run-perf-tests --chromium-android --profile should show symbols for the kernel
2806         https://bugs.webkit.org/show_bug.cgi?id=106498
2807
2808         Reviewed by Adam Barth.
2809
2810         Turns out this was easy, once I finally read the output from "perf report".
2811         It appears there may be a bug in "perf record" on android, as it complains
2812         about not being able to read from /proc/kallsyms even when
2813         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
2814         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
2815         but rather just flip it to 0 long enough to grab the /proc/kallsyms
2816         and then flip it back to whatever the device had.
2817
2818         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
2819         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
2820         to symbol names.  Its world-readable, but will return all 0s if you
2821         don't have permission to see the kernel symbols.  kptr_restrict
2822         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
2823         1 is only a specific group, and 2 is "no one, not even root".
2824         By default kptr_restrict is 2 on Android it seems.
2825         More kptr_restrict docs: http://lwn.net/Articles/420403/
2826
2827         I also took this opportunity to clean up how the perf record command
2828         was built for use/display in AndroidPerf.profile_after_exit and
2829         change to always using long-form names for the arguments (to hopefully help readability).
2830
2831         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2832         (AndroidPerf.__init__):
2833         (profile_after_exit):
2834         (ChromiumAndroidDriver.__init__):
2835         (ChromiumAndroidDriver._update_kallsyms_cache):
2836         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2837
2838 2013-01-09  Julie Parent  <jparent@chromium.org>
2839
2840         Dashboard cleanup: remove dead code.
2841         https://bugs.webkit.org/show_bug.cgi?id=106509
2842
2843         Reviewed by Dirk Pranke.
2844
2845         * TestResultServer/static-dashboards/dashboard_base.js:
2846         (parseParameters):
2847
2848 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
2849
2850         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
2851         https://bugs.webkit.org/show_bug.cgi?id=105638
2852
2853         Reviewed by Martin Robinson.
2854
2855         The test was failing for two reasons:
2856         - AccessibilityRenderObject::correspondingLabelForControlElement() was
2857           not ignoring the ARIA labelled-by property
2858         - AccessibilityController::accessibleElementById() was not implemented
2859
2860         Because getting an element by ID cannot be done in the UIProcess, the
2861         decision was made to expose the element's ID as an accessible attribute
2862         of the object.
2863
2864         In addition, fixing the bug in AccessibilityRenderObject made it possible
2865         to eliminate the Gtk platform-specific expectations for another test.
2866
2867         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2868         (childElementById): Added. Walks the tree looking for the AtkObject
2869         Attribute which exposes the HTML element's ID.
2870         (AccessibilityController::accessibleElementById): Implemented.
2871         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2872         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
2873         when there is no title, as is done with the Mac port.
2874         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2875         (WTR):
2876         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2877         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
2878         Attribute which exposes the HTML element's ID.
2879         (WTR):
2880         (WTR::AccessibilityController::accessibleElementById): Implemented.
2881         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2882         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
2883         even when there is no title, as is done with the Mac port.
2884
2885 2013-01-09  Gregg Tavares  <gman@google.com>
2886
2887         Add Gregg Tavares as a committer
2888         https://bugs.webkit.org/show_bug.cgi?id=106492
2889
2890         Unreviewed.
2891
2892         * Scripts/webkitpy/common/config/committers.py:
2893
2894 2013-01-09  Roger Fong  <roger_fong@apple.com>
2895
2896         Enable seamless iFrames for Windows DRT.
2897         https://bugs.webkit.org/show_bug.cgi?id=106468.
2898
2899         Rubberstamped by Timothy Horton.
2900
2901         * DumpRenderTree/win/DumpRenderTree.cpp:
2902         (resetDefaultsToConsistentValues):
2903
2904 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
2905
2906         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
2907         https://bugs.webkit.org/show_bug.cgi?id=93979
2908
2909         Reviewed by Benjamin Poulain.
2910
2911         Implement eventSender.scheduleAsynchronousKeyDown() in
2912         WebKitTestRunner.
2913
2914         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2915         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2916         (WTR::createKeyDownMessageBody):
2917         (WTR::EventSendingController::keyDown):
2918         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2919         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2920         (EventSendingController):
2921         * WebKitTestRunner/TestController.cpp:
2922         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2923         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2924         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2925         * WebKitTestRunner/TestController.h:
2926         (TestController):
2927
2928 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
2929
2930         [chromium] move resource load callback dumping to TestRunner library
2931         https://bugs.webkit.org/show_bug.cgi?id=106449
2932
2933         Reviewed by Adam Barth.
2934
2935         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2936         (DRTTestRunner::DRTTestRunner):
2937         (DRTTestRunner::reset):
2938         * DumpRenderTree/chromium/DRTTestRunner.h:
2939         (DRTTestRunner):
2940         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2941         (WebKit):
2942         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
2943         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2944         (WebKit):
2945         (WebTestProxyBase):
2946         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
2947         (WebTestRunner::WebTestProxy::willRequestResource):
2948         (WebTestRunner::WebTestProxy::willSendRequest):
2949         (WebTestRunner::WebTestProxy::didReceiveResponse):
2950         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
2951         (WebTestRunner::WebTestProxy::didFailResourceLoad):
2952         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2953         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
2954         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
2955         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
2956         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2957         (WebTestRunner::TestRunner::TestRunner):
2958         (WebTestRunner::TestRunner::reset):
2959         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
2960         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
2961         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
2962         (WebTestRunner):
2963         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
2964         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
2965         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
2966         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2967         (TestRunner):
2968         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2969         (WebTestRunner::WebTestProxyBase::reset):
2970         (WebTestRunner):
2971         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
2972         (WebTestRunner::WebTestProxyBase::willRequestResource):
2973         (WebTestRunner::WebTestProxyBase::willSendRequest):
2974         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
2975         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
2976         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
2977         * DumpRenderTree/chromium/WebViewHost.cpp:
2978         (WebViewHost::willSendRequest):
2979         (WebViewHost::makeURLErrorDescription):
2980         (WebViewHost::reset):
2981         * DumpRenderTree/chromium/WebViewHost.h:
2982         (WebViewHost):
2983
2984 2013-01-09  Dan Carney  <dcarney@google.com>
2985
2986         [chromium] move dumpcreateview methods to testrunner library
2987         https://bugs.webkit.org/show_bug.cgi?id=106434
2988
2989         Reviewed by Adam Barth.
2990
2991         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2992         (DRTTestRunner::DRTTestRunner):
2993         (DRTTestRunner::reset):
2994         * DumpRenderTree/chromium/DRTTestRunner.h:
2995         (DRTTestRunner):
2996         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2997         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
2998         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2999         (WebTestRunner::TestRunner::TestRunner):
3000         (WebTestRunner::TestRunner::reset):
3001         (WebTestRunner::TestRunner::shouldDumpCreateView):
3002         (WebTestRunner):
3003         (WebTestRunner::TestRunner::dumpCreateView):
3004         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3005         (TestRunner):
3006
3007 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
3008
3009         webkitpy cleanup: Merge additional_comment_text into comment_text
3010         https://bugs.webkit.org/show_bug.cgi?id=106421
3011
3012         Reviewed by Adam Barth.
3013
3014         * Scripts/webkitpy/common/config/committervalidator.py:
3015         (CommitterValidator.reject_patch_from_commit_queue):
3016         (CommitterValidator.reject_patch_from_review_queue):
3017         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3018         (Bugzilla.set_flag_on_attachment):
3019         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3020         (MockBugzilla.set_flag_on_attachment):
3021         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3022         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3023         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
3024         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3025
3026 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3027
3028         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
3029         https://bugs.webkit.org/show_bug.cgi?id=106464
3030
3031         Reviewed by Martin Robinson.
3032
3033         Current version in jhbuild.modules (2.26.0) is giving trouble to
3034         when trying to build WebKitGTK from scratch, due to a segmentation
3035         fault error in gdk-pixbuf-query-loader during the 'make'
3036         phase. Raising the version to 2.26.5 fixes this issue.
3037
3038         * gtk/jhbuild.modules: Version raised, checksums updated.
3039
3040 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
3041
3042         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
3043         https://bugs.webkit.org/show_bug.cgi?id=90968.
3044
3045         Reviewed by Csaba Osztrogonác.
3046
3047         Added functionality in DRT and WTR to use any timeout value while running
3048         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
3049         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
3050         to indicate whether the current port supports setting timeout value
3051         per test (it's False by default; I enabled it only on Qt).
3052         Also corrected a typo in driver.py
3053
3054         * DumpRenderTree/DumpRenderTree.h:
3055         (TestCommand::TestCommand):
3056         (TestCommand):
3057         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3058         (parseInputLine):
3059         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3060         (WebCore::DumpRenderTree::processLine):
3061         * Scripts/webkitpy/layout_tests/port/base.py:
3062         (Port.supports_per_test_timeout):
3063         * Scripts/webkitpy/layout_tests/port/driver.py:
3064         (Driver.run_test):
3065         (Driver._command_from_driver_input):
3066         * Scripts/webkitpy/layout_tests/port/qt.py:
3067         (QtPort.supports_per_test_timeout):
3068         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3069         (WTR::InjectedBundle::InjectedBundle):
3070         (WTR::InjectedBundle::didReceiveMessage):
3071         (WTR::InjectedBundle::beginTesting):
3072         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3073         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3074         (WTR::TestRunner::setCustomTimeout):
3075         (WTR):
3076         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3077         (TestRunner):
3078         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
3079         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3080         * WebKitTestRunner/TestController.cpp:
3081         (WTR::TestController::TestController):
3082         (WTR::TestController::getCustomTimeout):
3083         (WTR):
3084         (WTR::TestCommand::TestCommand):
3085         (TestCommand):
3086         (WTR::parseInputLine):
3087         (WTR::TestController::runTest):
3088         (WTR::TestController::runUntil):
3089         * WebKitTestRunner/TestController.h:
3090         (TestController):
3091         * WebKitTestRunner/TestInvocation.cpp:
3092         (WTR::TestInvocation::TestInvocation):
3093         (WTR::TestInvocation::setCustomTimeout):
3094         (WTR):
3095         (WTR::TestInvocation::invoke):
3096         * WebKitTestRunner/TestInvocation.h:
3097         (TestInvocation):
3098
3099 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3100
3101         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
3102         https://bugs.webkit.org/show_bug.cgi?id=106290
3103
3104         Reviewed by Martin Robinson.
3105
3106         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
3107         the macro isn't enabled.
3108
3109         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3110
3111 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
3112
3113         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
3114         https://bugs.webkit.org/show_bug.cgi?id=103653
3115
3116         Reviewed by Anders Carlsson.
3117
3118         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
3119         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
3120         client callback.
3121
3122         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
3123         methods to the JavaScript API.
3124         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3125         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
3126         (WTR::TestRunner::setAuthenticationUsername): Ditto.
3127         (WTR::TestRunner::setAuthenticationPassword): Ditto.
3128         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3129         (TestRunner): Added new declarations for the above.
3130         * WebKitTestRunner/TestController.cpp:
3131         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
3132         callback.
3133         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
3134         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
3135         the authentication information passed from the InjectedBundle.
3136         * WebKitTestRunner/TestController.h:
3137         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
3138         to communicate with the TestController.
3139         (WTR::TestController::setAuthenticationUsername): Ditto.
3140         (WTR::TestController::setAuthenticationPassword): Ditto.
3141         (TestController):
3142         * WebKitTestRunner/TestInvocation.cpp:
3143         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
3144         information from the InjectedBundle.
3145         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
3146         text to the TestInvocation text output.
3147         * WebKitTestRunner/TestInvocation.h:
3148         (TestInvocation): Added declaration for new method.
3149
3150 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
3151
3152         Add myself as a watcher for Web Geolocation
3153
3154         Unreviewed.
3155
3156         * Scripts/webkitpy/common/config/watchlist:
3157
3158 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3159
3160         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
3161         https://bugs.webkit.org/show_bug.cgi?id=106364
3162
3163         Reviewed by Eric Seidel.
3164
3165         When the setup_test_run method is called on the subclasses of the base Port
3166         interface, the parent method should also be called via super(), despite the
3167         parent method not doing anything at the moment.
3168
3169         The according calls to super() are required in the ChromiumPort, EflPort
3170         and GtkPort implementations.
3171
3172         * Scripts/webkitpy/layout_tests/port/chromium.py:
3173         (ChromiumPort.setup_test_run):
3174         * Scripts/webkitpy/layout_tests/port/efl.py:
3175         (EflPort.setup_test_run):
3176         * Scripts/webkitpy/layout_tests/port/gtk.py:
3177         (GtkPort.setup_test_run):
3178
3179 2013-01-08  Julie Parent  <jparent@chromium.org>
3180
3181         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
3182         https://bugs.webkit.org/show_bug.cgi?id=106356
3183
3184         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
3185         dashboard_base, assigned by Loader, and used only by dashboard_base to
3186         create error messages.  Moved the variables to be privates on the Loader
3187         object, moved error message creation to _getLoadingErrorMessages on the
3188         Loader object, and now pass the errors back to dashboard base via the
3189         resourceLoadingComplete callback.
3190         
3191         Also removed the now unused clearError function, it was only being used
3192         by unit tests to clean up global state.
3193         
3194         Reviewed by Dirk Pranke.
3195
3196         * TestResultServer/static-dashboards/dashboard_base.js:
3197         (resourceLoadingComplete):
3198         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3199         * TestResultServer/static-dashboards/loader.js:
3200         (.):
3201         * TestResultServer/static-dashboards/loader_unittests.js:
3202
3203 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3204
3205         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
3206         https://bugs.webkit.org/show_bug.cgi?id=106354
3207
3208         Reviewed by Eric Seidel.
3209
3210         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
3211         instead of those two inheriting from it. Also add a mock object of the
3212         sanitizer that's used in unit tests.
3213
3214         * Scripts/webkitpy/layout_tests/port/efl.py:
3215         (EflPort):
3216         (EflPort.__init__):
3217         (EflPort.setup_test_run):
3218         (EflPort.clean_up_test_run):
3219         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
3220         importing order.
3221         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
3222         * Scripts/webkitpy/layout_tests/port/gtk.py:
3223         (GtkPort):
3224         (GtkPort.__init__):
3225         (GtkPort.setup_test_run):
3226         (GtkPort.clean_up_test_run):
3227         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
3228         importing order.
3229         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
3230         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
3231         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
3232         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
3233         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
3234         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
3235         (PulseAudioSanitizerMock.unload_pulseaudio_module):
3236         (PulseAudioSanitizerMock.restore_pulseaudio_module):
3237
3238 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
3239
3240         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
3241         https://bugs.webkit.org/show_bug.cgi?id=106324
3242
3243         Reviewed by Adam Barth.
3244
3245         Since the frame load callbacks are part of the WebFrameClient, the
3246         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
3247         methods.
3248
3249         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3250         (DRTTestRunner::DRTTestRunner):
3251         (DRTTestRunner::reset):
3252         * DumpRenderTree/chromium/DRTTestRunner.h:
3253         (DRTTestRunner):
3254         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3255         (WebTestInterfaces):
3256         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3257         (WebKit):
3258         (WebTestProxyBase):
3259         (WebTestRunner):
3260         (WebTestRunner::WebTestProxy::WebTestProxy):
3261         (WebTestProxy):
3262         (WebTestRunner::WebTestProxy::didInvalidateRect):
3263         (WebTestRunner::WebTestProxy::didScrollRect):
3264         (WebTestRunner::WebTestProxy::scheduleComposite):
3265         (WebTestRunner::WebTestProxy::scheduleAnimation):
3266         (WebTestRunner::WebTestProxy::setWindowRect):
3267         (WebTestRunner::WebTestProxy::show):
3268         (WebTestRunner::WebTestProxy::didAutoResize):
3269         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
3270         (WebTestRunner::WebTestProxy::startDragging):
3271         (WebTestRunner::WebTestProxy::shouldBeginEditing):
3272         (WebTestRunner::WebTestProxy::shouldEndEditing):
3273         (WebTestRunner::WebTestProxy::shouldInsertNode):
3274         (WebTestRunner::WebTestProxy::shouldInsertText):
3275         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3276         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3277         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3278         (WebTestRunner::WebTestProxy::didBeginEditing):
3279         (WebTestRunner::WebTestProxy::didChangeSelection):
3280         (WebTestRunner::WebTestProxy::didChangeContents):
3281         (WebTestRunner::WebTestProxy::didEndEditing):
3282         (WebTestRunner::WebTestProxy::registerIntentService):
3283         (WebTestRunner::WebTestProxy::dispatchIntent):
3284         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
3285         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
3286         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
3287         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
3288         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
3289         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
3290         (WebTestRunner::WebTestProxy::didReceiveTitle):
3291         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
3292         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
3293         (WebTestRunner::WebTestProxy::didFailLoad):
3294         (WebTestRunner::WebTestProxy::didFinishLoad):
3295         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
3296         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
3297         (WebTestRunner::WebTestProxy::didRunInsecureContent):
3298         (WebTestRunner::WebTestProxy::didDetectXSS):
3299         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3300         (WebTestRunner::WebTestRunner::setTestIsRunning):
3301         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
3302         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
3303         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
3304         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
3305         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
3306         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3307         (WebTestRunner::TestRunner::TestRunner):
3308         (WebTestRunner::TestRunner::reset):
3309         (WebTestRunner::TestRunner::setTestIsRunning):
3310         (WebTestRunner):
3311         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
3312         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
3313         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
3314         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
3315         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
3316         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
3317         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
3318         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
3319         (WebTestRunner::TestRunner::dumpTitleChanges):
3320         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3321         (TestRunner):
3322         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3323         (WebTestInterfaces::Internal):
3324         (WebTestRunner::WebTestInterfaces::Internal::webView):
3325         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3326         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
3327         (WebTestRunner):
3328         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
3329         (WebTestRunner::WebTestInterfaces::setWebView):
3330         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
3331         (WebTestRunner::WebTestInterfaces::webView):
3332         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3333         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
3334         (WebTestRunner):
3335         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
3336         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
3337         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
3338         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
3339         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
3340         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3341         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
3342         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
3343         (WebTestRunner::WebTestProxyBase::didFailLoad):
3344         (WebTestRunner::WebTestProxyBase::didFinishLoad):
3345         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
3346         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
3347         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
3348         (WebTestRunner::WebTestProxyBase::didDetectXSS):
3349         * DumpRenderTree/chromium/TestShell.cpp:
3350         (TestShell::runFileTest):
3351         (TestShell::testFinished):
3352         * DumpRenderTree/chromium/TestShell.h:
3353         (TestShell):
3354         * DumpRenderTree/chromium/WebViewHost.cpp:
3355         (WebViewHost::didStartProvisionalLoad):
3356         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
3357         (WebViewHost::didFailProvisionalLoad):
3358         (WebViewHost::didCommitProvisionalLoad):
3359         (WebViewHost::didReceiveTitle):
3360         (WebViewHost::didFailLoad):
3361         (WebViewHost::didFinishLoad):
3362         * DumpRenderTree/chromium/WebViewHost.h:
3363         (WebViewHost):
3364
3365 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3366
3367         [GTK] Lower the default timeout value for WebKitTestRunner
3368         https://bugs.webkit.org/show_bug.cgi?id=106353
3369
3370         Reviewed by Dirk Pranke.
3371
3372         The default timeout value for WebKitTestRunner should be lowered.
3373         The current value (80 seconds) is irrational and just leads to producing
3374         text failures for layout tests that genuinely time out. This just leads
3375         to more deviation from the GTK WK1 port in terms of test expectations.
3376
3377         The value used is the same as when running the DumpRenderTree, that's
3378         6 seconds in release builds and 12 seconds in debug builds.
3379
3380         * Scripts/webkitpy/layout_tests/port/gtk.py:
3381         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3382         (GtkPortTest.test_default_timeout_ms):
3383
3384 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3385
3386         test-webkitpy shows failure output on my linux box
3387         https://bugs.webkit.org/show_bug.cgi?id=101261
3388
3389         Reviewed by Eric Seidel.
3390
3391         Mock out the PulseAudioSanitizer methods when creating testing instances
3392         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
3393         PulseAudio output when the sanitizer was trying to unload modules which
3394         were already unloaded by another unit test that was being run in parallel.
3395
3396         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3397         (EflPortTest):
3398         (EflPortTest.make_port):
3399         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3400         (GtkPortTest):
3401         (GtkPortTest.make_port):
3402
3403 2013-01-08  Julie Parent  <jparent@chromium.org>
3404
3405         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
3406         https://bugs.webkit.org/show_bug.cgi?id=106254
3407
3408         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
3409         only to figure out if we should call addBuilderLoadErrors during
3410         handleLocationChange, which was called when the loader completed and on
3411         any hash change, but we only ever wanted to call addBuilderLoadErrors
3412         on the initial loader load.  Moved the call of addBuilderLoadErrors to
3413         resourceLoadingComplete rather than handleLocationChange, so now we
3414         only call it when we want to, and the check can go away completely.
3415
3416         Reviewed by Dirk Pranke.
3417
3418         * TestResultServer/static-dashboards/dashboard_base.js:
3419         (addBuilderLoadErrors):
3420         (resourceLoadingComplete):
3421         (handleLocationChange):
3422         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3423
3424 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
3425
3426         Add aboxhall@chromium.org to accessibility watchlist.
3427
3428         Unreviewed.
3429
3430         * Scripts/webkitpy/common/config/watchlist:
3431
3432 2013-01-08  Dan Winship  <danw@gnome.org>
3433
3434         Add Apache 2.4 support for Fedora 18
3435         https://bugs.webkit.org/show_bug.cgi?id=104478
3436
3437         Reviewed by Martin Robinson.
3438
3439         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
3440         need a separate config.
3441
3442         * Scripts/webkitpy/layout_tests/port/base.py:
3443         (Port._apache_version):
3444         (Port._apache_config_file_name_for_platform):
3445         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3446         * Scripts/run-webkit-httpd:
3447         * Scripts/webkitperl/httpd.pm:
3448         (getApacheVersion):
3449         (getDefaultConfigForTestDirectory):
3450         (getHTTPDConfigPathForTestDirectory):
3451
3452 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3453
3454         Make the override-feature-defines script compatible with Python v3
3455         https://bugs.webkit.org/show_bug.cgi?id=105742
3456
3457         Reviewed by Martin Robinson.
3458
3459         Instead of printing output through a statement, use the print function and format
3460         the output using the str.format method. This makes the script runnable with Python v3.
3461
3462         * gtk/override-feature-defines:
3463         (adjust_feature_defines_makefile):
3464
3465 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
3466
3467         [Qt] Fix libxml2 config test
3468         https://bugs.webkit.org/show_bug.cgi?id=106317
3469
3470         Reviewed by Simon Hausmann.
3471
3472         Don't assume standard include/libxml2, libxml-2.0.pc should know
3473         where it's headers are.
3474
3475         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
3476
3477 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3478
3479         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
3480         https://bugs.webkit.org/show_bug.cgi?id=106195
3481
3482         Reviewed by Philippe Normand.
3483
3484         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
3485         to make the Python code compatible with Python 3. This includes modifying
3486         print statements, exception handling, dictionary iteration and
3487         byte-sequence-to-string conversion.
3488
3489         * gtk/common.py:
3490         (get_build_path):
3491         (pkg_config_file_variable):
3492         (gtk_version_of_pkg_config_file):
3493         * gtk/generate-gtkdoc:
3494         (print_missing_api):
3495         * gtk/gtkdoc.py:
3496         (GTKDoc.__init__):
3497         (GTKDoc._run_command):
3498
3499 2013-01-02  Steve Block  <steveblock@chromium.org>
3500
3501         Add chromium.org email address for Steve Block.
3502
3503         Unreviewed.
3504
3505         * Scripts/webkitpy/common/config/committers.py:
3506
3507 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
3508
3509         Rationalize closure call heuristics and profiling
3510         https://bugs.webkit.org/show_bug.cgi?id=106270
3511
3512         Reviewed by Oliver Hunt.
3513         
3514         Add ability to use display-profiler-output via a pipe, and add the ability to dump
3515         all generated code ('display *' or 'd *').
3516
3517         * Scripts/display-profiler-output:
3518
3519 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
3520
3521         Sorted more xcodeproj files.
3522
3523         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3524         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3525         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3526
3527 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
3528
3529         Sorted xcodeproj files.
3530
3531         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3532         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3533
3534 2013-01-07  Dan Bernstein  <mitz@apple.com>
3535
3536         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
3537         https://bugs.webkit.org/show_bug.cgi?id=106261
3538
3539         Reviewed by Simon Fraser.
3540
3541         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
3542
3543         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3544         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
3545         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
3546         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
3547         (TestWebKitAPI):
3548         (TestWebKitAPI::TEST):
3549
3550 2013-01-07  Ojan Vafai  <ojan@chromium.org>
3551
3552         Add the Apple MountainLion bots to garden-o-matic.
3553         Eventually, we really should move away from hardcoding
3554         the list of bots.
3555
3556         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3557
3558 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
3559
3560         [chromium] move web audio related methods to testrunner library
3561         https://bugs.webkit.org/show_bug.cgi?id=106211
3562
3563         Reviewed by Adam Barth.
3564
3565         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3566         (DRTTestRunner::DRTTestRunner):
3567         (DRTTestRunner::reset):
3568         * DumpRenderTree/chromium/DRTTestRunner.h:
3569         (DRTTestRunner):
3570         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3571         (WebKit):
3572         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
3573         (WebTestRunner::WebTestRunner::audioData):
3574         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3575         (WebTestRunner::TestRunner::TestRunner):
3576         (WebTestRunner::TestRunner::reset):
3577         (WebTestRunner::TestRunner::shouldDumpAsAudio):
3578         (WebTestRunner):
3579         (WebTestRunner::TestRunner::audioData):
3580         (WebTestRunner::TestRunner::setAudioData):
3581         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3582         (TestRunner):
3583         * DumpRenderTree/chromium/TestShell.cpp:
3584         (TestShell::dump):
3585
3586 2013-01-07  Mike West  <mkwst@chromium.org>
3587
3588         Make the IFRAME_SEAMLESS flag runtime-enabled.
3589         https://bugs.webkit.org/show_bug.cgi?id=106213
3590
3591         Reviewed by Ojan Vafai.
3592
3593         * DumpRenderTree/chromium/TestShell.cpp:
3594         (TestShell::TestShell):
3595         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3596         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3597         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3598         (resetDefaultsToConsistentValues):
3599         * DumpRenderTree/mac/DumpRenderTree.mm:
3600         (resetDefaultsToConsistentValues):
3601         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3602         (WebCore::WebPage::resetSettings):
3603         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3604         (WTR::InjectedBundle::beginTesting):
3605             Ensure that seamless IFrames are enabled for layout tests in each of
3606             the ports that support seamless IFrames.
3607
3608 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
3609
3610         [chromium] move dumpAsText and friends to the TestRunner library
3611         https://bugs.webkit.org/show_bug.cgi?id=106222
3612
3613         Reviewed by Adam Barth.
3614
3615         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
3616
3617         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3618         (DRTTestRunner::DRTTestRunner):
3619         (DRTTestRunner::reset):
3620         * DumpRenderTree/chromium/DRTTestRunner.h:
3621         (DRTTestRunner):
3622         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3623         (WebTestRunner::WebTestRunner::shouldDumpAsText):
3624         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
3625         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
3626         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
3627         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
3628         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
3629         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3630         (WebTestRunner::TestRunner::TestRunner):
3631         (WebTestRunner::TestRunner::reset):
3632         (WebTestRunner::TestRunner::shouldDumpAsText):
3633         (WebTestRunner):
3634         (WebTestRunner::TestRunner::setShouldDumpAsText):
3635         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
3636         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
3637         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
3638         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
3639         (WebTestRunner::TestRunner::dumpAsText):
3640         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
3641         (WebTestRunner::TestRunner::dumpChildFramesAsText):
3642         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3643         (TestRunner):
3644
3645 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
3646
3647         Build fix attempt after r138810.
3648
3649         Apparently python 2.6 is really bad at floating point computation.
3650
3651         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3652         (MainTest.test_run_memory_test):
3653
3654 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
3655
3656         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
3657         https://bugs.webkit.org/show_bug.cgi?id=106172
3658
3659         Reviewed by Tony Chang.
3660
3661         Extracted PerfTestMetric, which represents a test result and knows how&