1 2013-05-25 Ryosuke Niwa <rniwa@webkit.org>
3 Teach webkitbot and WKR how to respond to yt?
4 https://bugs.webkit.org/show_bug.cgi?id=116775
6 Reviewed by Andreas Kling.
8 * Scripts/webkitpy/tool/bot/irc_command.py:
9 (Hi): Fixed the usage string.
10 (Hi.execute): Made it more generic so that it works in WKR.
12 (YouThere.execute): Added.
13 * Scripts/webkitpy/tool/commands/newcommitbot.py:
15 2013-05-25 Simon Fraser <simon.fraser@apple.com>
17 Try to fix the EFL build.
19 * DumpRenderTree/efl/TestRunnerEfl.cpp:
20 (TestRunner::setPageVisibility):
22 2013-05-25 Simon Fraser <simon.fraser@apple.com>
24 Unprefix Page Visibility API
25 https://bugs.webkit.org/show_bug.cgi?id=102340
27 Reviewed by Tim Horton.
29 Rename "preview" state to "unloaded" state, and adjust the tests
32 * DumpRenderTree/mac/TestRunnerMac.mm:
33 (TestRunner::setPageVisibility):
34 * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
35 (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
36 (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
37 (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
38 (TestWebKitAPI::didRunStep4InStateUnloaded):
39 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
40 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
41 (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
42 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
43 (WTR::TestRunner::setPageVisibility):
45 2013-05-24 Brent Fulgham <bfulgham@apple.com>
47 Unreviewed build fix. Don't use new NRWT logic needed
48 by Windows yet. Activate (and fix test) when we cut over.
50 * Scripts/webkitpy/port/driver.py:
51 (Driver._setup_environ_for_driver):
54 2013-05-24 Brent Fulgham <bfulgham@apple.com>
56 [Windows] Expose database storage and cache locations via preferences.
57 https://bugs.webkit.org/show_bug.cgi?id=116729
59 Reviewed by Tim Horton.
61 Update DumpRenderTree to use CFPreferences to control where WebKit
62 stores its local databases, URL caches, etc.
64 * DumpRenderTree/win/DumpRenderTree.cpp:
65 (libraryPathForDumpRenderTree): Added.
66 (dllLauncherEntryPoint): Set up DRT-specific cache locations.
67 * Scripts/webkitpy/port/base.py:
68 (Port._driver_tempdir): Added (to allow port-specific overload).
69 (Port._driver_tempdir_for_environment): Ditto
70 * Scripts/webkitpy/port/driver.py:
71 (Driver._setup_environ_for_driver): Use new overload to set
73 (Driver._start): Use new overload for temp directory location.
74 * Scripts/webkitpy/port/win.py:
75 (WinPort._driver_tempdir_for_environment): New overload to supply
76 Windows path to DumpRenderTree environment (while still using
77 cygwin paths for internal operations.
79 2013-05-24 Christophe Dumez <ch.dumez@sisa.samsung.com>
81 Remove custom code for webkitAudioContext global constructor getter
82 https://bugs.webkit.org/show_bug.cgi?id=116530
84 Reviewed by Geoffrey Garen.
86 Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
87 WebAudio feature instead of public ewk_view API since that API was
90 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
91 (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
92 * DumpRenderTree/efl/TestRunnerEfl.cpp:
93 (TestRunner::overridePreference):
95 2013-05-24 Bem Jones-Bey <bjonesbe@adobe.com>
97 Make team.html have each contributor's area of expertise
98 https://bugs.webkit.org/show_bug.cgi?id=116737
100 Reviewed by Benjamin Poulain.
102 * Scripts/webkitpy/common/config/contributors.json:
103 Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
105 Changed formatting of the file because the lines are getting way to
106 long, and I generated this, so it's easier if the formatting of the
109 2013-05-24 Simon Pena <simon.pena@samsung.com>
111 Update WTF::Vector pretty printers
112 https://bugs.webkit.org/show_bug.cgi?id=116719
114 Reviewed by Anders Carlsson.
116 After r148891, WTF::Vector pretty printers were left outdated, as
117 the WTF::Vector was made to extend a VectorBuffer, instead of keeping
118 one as a member. This patch updates the pretty printers so they work
122 (WTFVectorPrinter.children):
123 (WTFVectorPrinter.to_string):
125 2013-05-24 Steve Falkenburg <sfalken@apple.com>
127 Update prepareConsistentTestingEnvironment to use a non-deprecated API.
128 https://bugs.webkit.org/show_bug.cgi?id=116710
130 Reviewed by Mark Rowe.
132 * DumpRenderTree/mac/DumpRenderTree.mm:
133 (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
135 2013-05-23 Lauro Neto <lauro.neto@openbossa.org>
137 Add missing dependencies to deps script.
139 [GTK] Missing packages in install-dependencies script.
140 https://bugs.webkit.org/show_bug.cgi?id=116632
142 Reviewed by Martin Robinson.
144 * gtk/install-dependencies:
146 2013-05-23 Brent Fulgham <bfulgham@apple.com>
148 [Windows] Unreviewed change for NRWT support.
150 * Scripts/webkitpy/port/win.py:
151 (WinPort.default_child_processes): Added a default implementation
152 that limits NRWT to a single instance.
154 2013-05-23 Brent Fulgham <bfulgham@apple.com>
156 Remove meaningless "test_uses_apache" from Python test cases.
157 https://bugs.webkit.org/show_bug.cgi?id=38756
159 Reviewed by Ryosuke Niwa.
161 * Scripts/webkitpy/port/port_testcase.py:
162 (PortTestCase.test_driver_cmd_line): Remove the meaningless
163 "test_uses_apache" test case from the Python test infrastructure.
164 It was hard-coded to true, even though not all ports use
167 2013-05-23 Brent Fulgham <bfulgham@webkit.org>
169 [Windows] Update new-run-webkit-tests for Windows port.
170 https://bugs.webkit.org/show_bug.cgi?id=38756
172 Reviewed by Ryosuke Niwa.
174 * Scripts/new-run-webkit-httpd:
175 (run): Switch from 'chromium' to 'win'
176 * Scripts/webkitpy/port/win.py:
177 (WinPort): Add support methods for lighttpd server.
178 (WinPort._uses_apache):
179 (WinPort._path_to_lighttpd):
180 (WinPort._path_to_lighttpd_modules):
181 (WinPort._path_to_lighttpd_php):
183 2013-05-23 Patrick Gansterer <paroga@webkit.org>
185 Make default bug links in buildbot clickable
186 https://bugs.webkit.org/show_bug.cgi?id=116673
188 Reviewed by Ryosuke Niwa.
190 Use changecommentlink of html.WebStatus to make the links clickable.
192 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
194 2013-05-22 Ryosuke Niwa <rniwa@webkit.org>
196 REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
197 https://bugs.webkit.org/show_bug.cgi?id=116595
199 Temporarily skip this test.
201 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
202 (TestWebKitAPI::TEST):
204 2013-05-22 Alex Christensen <achristensen@apple.com>
206 Unreviewed. Added myself to contributors.json.
208 * Scripts/webkitpy/common/config/contributors.json:
211 2013-05-22 Michał Pakuła vel Rutka <m.pakula@samsung.com>
213 [EFL][WK2] Add sub menus to MiniBrowser
214 https://bugs.webkit.org/show_bug.cgi?id=114728
216 Reviewed by Christophe Dumez.
218 Elementary Ctxpopup widget API does not provide support for submenu item.
219 To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
220 Elementary Menu widget.
222 * MiniBrowser/efl/main.c:
226 (context_menu_item_selected_cb):
227 (context_menu_populate):
228 (on_context_menu_show):
229 (on_context_menu_hide):
232 2013-05-22 Andrzej Badowski <a.badowski@samsung.com>
234 [EFL] Add command line option to MiniBrowser to set cookies policy.
235 https://bugs.webkit.org/show_bug.cgi?id=115028
237 Reviewed by Christophe Dumez.
239 Add command line option to MiniBrowser EFL to set cookies policy:
240 -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
241 EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
243 * MiniBrowser/efl/main.c:
246 2013-05-21 Ryosuke Niwa <rniwa@webkit.org>
248 REGRESSION(r150369): WebKit2WillLoadTest tests are failing
249 https://bugs.webkit.org/show_bug.cgi?id=116585
251 Reviewed by Alexey Proskuryakov.
253 willLoadURLRequest and willLoadDataRequest require the API version 6.
255 * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
257 2013-05-21 Ryosuke Niwa <rniwa@webkit.org>
259 REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
260 https://bugs.webkit.org/show_bug.cgi?id=116516
262 Reviewed by Alexey Proskuryakov.
264 Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
266 * DumpRenderTree/mac/DumpRenderTree.mm:
267 (createWebViewAndOffscreenWindow): Match the ordering.
268 (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
270 2013-05-21 Alexey Proskuryakov <ap@apple.com>
272 <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
273 https://bugs.webkit.org/show_bug.cgi?id=116568
275 Reviewed by Anders Carlsson.
277 * WebKitTestRunner/WebNotificationProvider.cpp:
278 (WTR::WebNotificationProvider::~WebNotificationProvider):
279 * WebKitTestRunner/WebNotificationProvider.h:
280 When the provider is destroyed, it should no longer be registered with the manager.
282 * WebKitTestRunner/GeolocationProviderMock.cpp:
283 (WTR::GeolocationProviderMock::~GeolocationProviderMock):
284 * WebKitTestRunner/GeolocationProviderMock.h:
285 I wasn't seeing a crash here, but this code has the same issue as notification
286 provider, so applying the same fix.
288 * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
289 Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
290 destructor having fixed the above.
292 2013-05-21 Commit Queue <commit-queue@webkit.org>
294 Unreviewed, rolling out r150386 and r150397.
295 http://trac.webkit.org/changeset/150386
296 http://trac.webkit.org/changeset/150397
297 https://bugs.webkit.org/show_bug.cgi?id=116572
299 Broke a test; Alex is going to try again later. (Requested by
302 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
303 (WTR::pathSuitableForTestResult):
304 (WTR::dumpRequestDescriptionSuitableForTestResult):
305 (WTR::dumpResponseDescriptionSuitableForTestResult):
306 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
307 (WTR::InjectedBundlePage::didInitiateLoadForResource):
308 (WTR::InjectedBundlePage::willSendRequestForFrame):
309 (WTR::InjectedBundlePage::didReceiveResponseForResource):
310 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
311 (InjectedBundlePage):
313 2013-05-21 Ryosuke Niwa <rniwa@webkit.org>
315 Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
317 * Scripts/webkitpy/tool/commands/suggestnominations.py:
318 (AbstractCommitLogCommand._recent_commit_messages):
320 2013-05-21 Martin Robinson <mrobinson@igalia.com>
322 [GTK] [CMake] Add support for building WebKit2
323 https://bugs.webkit.org/show_bug.cgi?id=116372
325 Reviewed by Gustavo Noronha Silva.
327 * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
328 * MiniBrowser/gtk/CMakeLists.txt: Added.
330 2013-05-21 Jessie Berlin <jberlin@apple.com>
332 Revert r149635, it was too optimistic.
334 Rubber-stamped by Andreas Kling.
336 We are not at the point where we can always use more descriptive macros instead of PLATFORM()
337 #ifdefs in WebCore code outside of WebCore/platform.
339 * Scripts/webkitpy/style/checkers/cpp.py:
340 (check_invalid_increment):
343 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
344 (CppStyleTest.test_plain_integral_bitfields):
346 2013-05-21 Jer Noble <jer.noble@apple.com>
348 Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
350 * lldb/lldb_webkit.py:
351 (WTFVectorProvider.num_children):
352 (WTFVectorProvider.get_child_index):
353 (WTFVectorProvider.get_child_at_index):
354 (WTFVectorProvider.update):
356 2013-05-21 Jessie Berlin <jberlin@apple.com>
358 Expose a way to know when forms are added to a page or when form controls are added to a form
359 in the injected bundle
360 https://bugs.webkit.org/show_bug.cgi?id=116334
362 Reviewed by Alexey Proskuryakov.
364 Add tests for the new callbacks.
366 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
367 Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
369 * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
370 (TestWebKitAPI::nullJavaScriptCallback):
371 A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
372 being passed in for the callback.
373 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
374 After receiving the message that didAssociateFormControls callback was invoked from adding
375 the form in the onload handler, tell the page to add a password field to the form, which
376 should also invoke didAssociateFormControls callback.
377 (TestWebKitAPI::setInjectedBundleClient):
378 Register to receive messages.
379 (TestWebKitAPI::TEST):
380 Load associate-form-controls.html and wait until the didAssociateFormControls callback has
381 been invoked for both adding the form and for adding a password field to the form.
383 * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
384 (TestWebKitAPI::shouldNotifyOnFormChanges):
385 Return true so the didAssociateFormControls callback is invoked.
386 (TestWebKitAPI::didAssociateFormControls):
388 (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
389 (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
390 Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
392 * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
393 Add a form in response to the onload event. Add a button that will add the password field
396 2013-05-21 Krzysztof Czech <k.czech@samsung.com>
398 [GTK][WK2] accessibility/label-for-control-hittest.html is failing
399 https://bugs.webkit.org/show_bug.cgi?id=106341
401 Reviewed by Martin Robinson.
403 Adds support for retrieving accessibility element at exact point.
405 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
406 (WTR::AccessibilityUIElement::elementAtPoint):
408 2013-05-21 Krzysztof Czech <k.czech@samsung.com>
410 [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
411 https://bugs.webkit.org/show_bug.cgi?id=112913
413 Reviewed by Martin Robinson.
415 AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
416 AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
419 * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
421 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
422 * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
423 (WTR::AccessibilityController::rootElement):
425 (WTR::AccessibilityController::focusedElement):
426 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
427 (WTR::checkElementState):
428 (WTR::indexRangeInTable):
429 (WTR::alterCurrentValue):
430 (WTR::AccessibilityUIElement::getChildren):
431 (WTR::AccessibilityUIElement::getChildrenWithRange):
432 (WTR::AccessibilityUIElement::childrenCount):
433 (WTR::AccessibilityUIElement::indexOfChild):
434 (WTR::AccessibilityUIElement::titleUIElement):
435 (WTR::AccessibilityUIElement::parentElement):
436 (WTR::AccessibilityUIElement::allAttributes):
437 (WTR::AccessibilityUIElement::role):
438 (WTR::AccessibilityUIElement::title):
439 (WTR::AccessibilityUIElement::description):
440 (WTR::AccessibilityUIElement::orientation):
441 (WTR::AccessibilityUIElement::stringValue):
442 (WTR::AccessibilityUIElement::language):
443 (WTR::AccessibilityUIElement::x):
444 (WTR::AccessibilityUIElement::y):
445 (WTR::AccessibilityUIElement::width):
446 (WTR::AccessibilityUIElement::height):
447 (WTR::AccessibilityUIElement::intValue):
448 (WTR::AccessibilityUIElement::minValue):
449 (WTR::AccessibilityUIElement::maxValue):
450 (WTR::AccessibilityUIElement::isEnabled):
451 (WTR::AccessibilityUIElement::isFocused):
452 (WTR::AccessibilityUIElement::isSelected):
453 (WTR::AccessibilityUIElement::isExpanded):
454 (WTR::AccessibilityUIElement::isChecked):
455 (WTR::AccessibilityUIElement::rowCount):
456 (WTR::AccessibilityUIElement::columnCount):
457 (WTR::AccessibilityUIElement::rowIndexRange):
458 (WTR::AccessibilityUIElement::columnIndexRange):
459 (WTR::AccessibilityUIElement::cellForColumnAndRow):
460 (WTR::AccessibilityUIElement::increment):
461 (WTR::AccessibilityUIElement::decrement):
462 (WTR::AccessibilityUIElement::press):
463 (WTR::AccessibilityUIElement::documentEncoding):
464 (WTR::AccessibilityUIElement::documentURI):
465 (WTR::AccessibilityUIElement::isFocusable):
466 (WTR::AccessibilityUIElement::isSelectable):
467 (WTR::AccessibilityUIElement::isMultiSelectable):
468 (WTR::AccessibilityUIElement::isVisible):
470 2013-05-20 Lucas Forschler <lforschler@apple.com>
474 2013-05-20 Zan Dobersek <zdobersek@igalia.com>
476 [GTK] Fix concatenations of string literals that are not C++11-compliant
477 https://bugs.webkit.org/show_bug.cgi?id=116449
479 Reviewed by Martin Robinson.
481 Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
482 is simply a matter of separating the string and the string literal that are being concatenated with a space.
484 * ImageDiff/gtk/ImageDiff.cpp:
487 2013-05-20 Zan Dobersek <zdobersek@igalia.com>
489 [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
490 https://bugs.webkit.org/show_bug.cgi?id=116450
492 Reviewed by Martin Robinson.
494 The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
495 programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
496 default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
497 TestWebKitAPI programs when compiling them.
499 * TestWebKitAPI/GNUmakefile.am:
501 2013-05-20 Ryosuke Niwa <rniwa@webkit.org>
503 Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
504 https://bugs.webkit.org/show_bug.cgi?id=116492
506 Reviewed by Dirk Pranke.
508 Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
510 The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
511 so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
512 starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
513 and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
514 the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
515 to memory pressure on the machine.
517 This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
518 we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
519 for a subsequent patch just to make things easier to follow.
521 * Scripts/webkitpy/port/driver.py:
522 (DriverProxy.__init__):
523 (DriverProxy.run_test):
524 (DriverProxy.has_crashed):
527 2013-05-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
529 Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
530 https://bugs.webkit.org/show_bug.cgi?id=116423
532 Reviewed by Ryosuke Niwa.
534 EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
536 * BuildSlaveSupport/build.webkit.org-config/config.json:
538 2013-05-20 Seokju Kwon <seokju.kwon@gmail.com>
540 Remove remaining link-prerender code
541 https://bugs.webkit.org/show_bug.cgi?id=116429
543 Reviewed by Darin Adler.
545 Link prerendering code was removed in r150356.
547 * Scripts/webkitperl/FeatureList.pm:
548 * qmake/mkspecs/features/features.pri:
550 2013-05-20 Ryosuke Niwa <rniwa@webkit.org>
552 commit-queue should check for oops in changelog entries
553 https://bugs.webkit.org/show_bug.cgi?id=116395
555 Reviewed by Martin Robinson.
557 Make changelog validation fail when it contains oops!.
559 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
560 (CommitQueueTask._validate_changelog):
561 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
562 (CommitQueueTaskTest._run_through_task):
563 * Scripts/webkitpy/tool/commands/queues_unittest.py:
564 * Scripts/webkitpy/tool/steps/validatechangelogs.py:
565 (ValidateChangeLogs.options):
566 (ValidateChangeLogs._check_changelog_diff):
567 (ValidateChangeLogs._changelog_contains_oops):
568 (ValidateChangeLogs.run):
569 * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
570 (ValidateChangeLogsTest._assert_start_line_produces_output):
571 (ValidateChangeLogsTest.test_check_changelog_diff):
572 (ValidateChangeLogsTest):
573 (ValidateChangeLogsTest.test_changelog_contains_oops):
575 2013-05-20 Jessie Berlin <jberlin@apple.com>
577 Expose a way to know when forms are added to a page or when form controls are added to a form
578 in the injected bundle
579 https://bugs.webkit.org/show_bug.cgi?id=116334
581 Reviewed by Alexey Proskuryakov.
583 Add tests for the new callbacks.
585 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
586 Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
588 * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
589 (TestWebKitAPI::nullJavaScriptCallback):
590 A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
591 being passed in for the callback.
592 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
593 After receiving the message that didAssociateFormControls callback was invoked from adding
594 the form in the onload handler, tell the page to add a password field to the form, which
595 should also invoke didAssociateFormControls callback.
596 (TestWebKitAPI::setInjectedBundleClient):
597 Register to receive messages.
598 (TestWebKitAPI::TEST):
599 Load associate-form-controls.html and wait until the didAssociateFormControls callback has
600 been invoked for both adding the form and for adding a password field to the form.
602 * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
603 (TestWebKitAPI::shouldNotifyOnFormChanges):
604 Return true so the didAssociateFormControls callback is invoked.
605 (TestWebKitAPI::didAssociateFormControls):
607 (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
608 (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
609 Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
611 * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
612 Add a form in response to the onload event. Add a button that will add the password field
615 2013-05-20 Christophe Dumez <ch.dumez@sisa.samsung.com>
617 [EFL][JHBUILD] Make sure eet is built before evas
618 https://bugs.webkit.org/show_bug.cgi?id=116440
620 Reviewed by Gyuyoung Kim.
622 Mark eet as a dependency of evas since evas requires eet to enable some of its
625 * efl/jhbuild.modules:
627 2013-05-20 Alex Christensen <achristensen@apple.com>
629 WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
630 https://bugs.webkit.org/show_bug.cgi?id=116125
632 Reviewed by Tim Horton.
634 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
635 (WTR::pathSuitableForTestResult):
636 Changed string operations to match _drt_descriptionSuitableForTestResult.
637 (WTR::dumpRequestDescriptionSuitableForTestResult):
638 (WTR::dumpResponseDescriptionSuitableForTestResult):
639 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
640 (WTR::InjectedBundlePage::didInitiateLoadForResource):
641 (WTR::InjectedBundlePage::willSendRequestForFrame):
642 (WTR::InjectedBundlePage::didReceiveResponseForResource):
643 Pass the main frame's URL to pathSuitableForTestResult.
644 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
645 Added WKBundlePageRef to willPerformClientRedirectForFrame.
647 2013-05-20 Dirk Pranke <dpranke@chromium.org>
649 fix w3c test importer unit tests after r150324
650 https://bugs.webkit.org/show_bug.cgi?id=116459
652 Reviewed by Ryosuke Niwa.
654 This patch fixes the unit tests to not actually call out to
655 'hg' (by using a mock executive) and also changes the real
656 directory we crawl from Source/WebCore/css to
657 Tools/Scripts/webkitpy/w3c to run much more quickly. We should
658 still change this to a mock filesystem, but that's a separate change.
660 * Scripts/webkitpy/w3c/test_importer.py:
662 (TestImporter.__init__):
663 (TestImporter.load_changeset):
664 * Scripts/webkitpy/w3c/test_importer_unittest.py:
665 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
666 (TestImporterTest.test_import_dir_with_no_tests):
668 2013-05-20 Christophe Dumez <ch.dumez@sisa.samsung.com>
670 Unreviewed EFL build fix.
672 Fix linking errors due to undefined symbols on Ubuntu 13.04.
674 * DumpRenderTree/efl/CMakeLists.txt:
675 * EWebLauncher/CMakeLists.txt:
676 * MiniBrowser/efl/CMakeLists.txt:
678 2013-05-20 Christophe Dumez <ch.dumez@sisa.samsung.com>
680 [EFL] Reenabled INDEXED_DATABASE after r150344
681 https://bugs.webkit.org/show_bug.cgi?id=116430
683 Reviewed by Gyuyoung Kim.
685 Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
686 build was fixed in r150344.
688 * Scripts/webkitperl/FeatureList.pm:
690 2013-05-19 Ryuan Choi <ryuan.choi@samsung.com>
692 [EFL] init/shutdown should be paired in EWebLauncher
693 https://bugs.webkit.org/show_bug.cgi?id=116427
695 Reviewed by Christophe Dumez.
697 Added ecore_file_shutdown() for cleanup of ecore_file.
698 Removed edje_init and ecore_evas_init because it was in ewk_init().
700 * EWebLauncher/main.c:
703 2013-05-19 Jinwoo Song <jinwoo7.song@samsung.com>
705 [EFL] Add command line option to MiniBrowser to set user agent
706 https://bugs.webkit.org/show_bug.cgi?id=116387
708 Reviewed by Christophe Dumez.
710 We need this option to compare the rendering differences according to different user agents.
712 * MiniBrowser/efl/main.c:
716 2013-05-19 Zan Dobersek <zdobersek@igalia.com>
718 Unreviewed, addressing test-webkitpy failures after r150317.
720 * Scripts/webkitpy/w3c/test_converter.py:
721 (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
723 2013-05-18 Patrick Gansterer <paroga@webkit.org>
725 [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
726 https://bugs.webkit.org/show_bug.cgi?id=114554
728 Reviewed by Gyuyoung Kim.
730 Using variables as target names is very uncommon in CMake.
731 The usual way to specify the name of the resulting binary
732 is to set the OUTPUT_NAME target property.
734 * DumpRenderTree/efl/CMakeLists.txt:
735 * EWebLauncher/CMakeLists.txt:
736 * ImageDiff/CMakeLists.txt:
737 * MiniBrowser/efl/CMakeLists.txt:
738 * TestWebKitAPI/CMakeLists.txt:
739 * WebKitTestRunner/CMakeLists.txt:
740 * WebKitTestRunner/PlatformEfl.cmake:
741 * WinCELauncher/CMakeLists.txt:
743 2013-05-18 Christophe Dumez <ch.dumez@sisa.samsung.com>
745 Unreviewed EFL build fix.
747 Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
748 WK2 build after r150305.
750 * Scripts/webkitperl/FeatureList.pm:
752 2013-05-18 Alberto Garcia <agarcia@igalia.com>
754 [GTK] Parallel build fails if gtk-doc is enabled
755 https://bugs.webkit.org/show_bug.cgi?id=116227
757 Reviewed by Martin Robinson.
760 Don't use the 'all' target to generate the documentation.
761 The prerequisites of this target must be files that need to be
762 built _before_ the actual compilation of WebKit starts. Since the
763 documentation depends on WebKit being built first, this means in
764 practice that the code will be built in parallel with the
765 generation of its dependencies, potentially making the build fail.
767 2013-05-17 Ryosuke Niwa <rniwa@webkit.org>
771 * Scripts/webkitpy/w3c/test_importer_unittest.py:
774 2013-05-17 Dirk Pranke <dpranke@chromium.org>
776 Create a script to import W3C tests
777 https://bugs.webkit.org/show_bug.cgi?id=111513
779 Reviewed by Ryosuke Niwa.
781 This patch attempts to re-land the 'import-w3c-tests'
782 script and accompanying modules. The tests and code have
783 been cleaned up so that we do not log anything to stdout/stderr
784 while running the tests (thanks to outputcapture) and do not
785 write into the source tree while running the tests, and much
786 but not all of the code has been converted over to using the webkitpy
788 * Scripts/import-w3c-tests: Added.
789 * Scripts/webkitpy/w3c/__init__.py: Added.
790 * Scripts/webkitpy/w3c/test_converter.py: Added.
792 (W3CTestConverter.__init__):
793 (W3CTestConverter.path_from_webkit_root):
794 (W3CTestConverter.read_webkit_prefixed_css_property_list):
795 (W3CTestConverter.convert_for_webkit):
796 (W3CTestConverter.convert_css):
797 (W3CTestConverter.convert_html):
798 (W3CTestConverter.convert_testharness_paths):
799 (W3CTestConverter.convert_prefixed_properties):
800 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
801 (W3CTestConverter.replace_tag):
802 * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
803 (W3CTestConverterTest):
804 (W3CTestConverterTest.fake_dir_path):
805 (W3CTestConverterTest.test_read_prefixed_property_list):
806 (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
807 (test_convert_for_webkit_harness_only):
808 (test_convert_for_webkit_properties_only):
809 (test_convert_for_webkit_harness_and_properties):
810 (test_convert_test_harness_paths):
811 (test_convert_prefixed_properties):
812 (verify_conversion_happened):
813 (verify_no_conversion_happened):
814 (verify_test_harness_paths):
815 (verify_prefixed_properties):
816 (generate_test_content):
817 * Scripts/webkitpy/w3c/test_importer.py: Added.
820 (validate_import_directory):
822 (TestImporter.__init__):
823 (TestImporter.path_from_webkit_root):
824 (TestImporter.do_import):
825 (TestImporter.load_changeset):
826 (TestImporter.find_importable_tests):
827 (TestImporter.import_tests):
828 (TestImporter.setup_destination_directory):
829 (TestImporter.update_test_status):
830 (TestImporter.remove_deleted_files):
831 (TestImporter.write_import_log):
832 * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
834 (TestImporterTest.test_import_dir_with_no_tests):
835 * Scripts/webkitpy/w3c/test_parser.py: Added.
837 (TestParser.__init__):
838 (TestParser.load_file):
839 (TestParser.analyze_test):
840 (TestParser.reference_links_of_type):
841 (TestParser.is_jstest):
842 (TestParser.support_files):
843 * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
845 (TestParserTest.test_analyze_test_reftest_one_match):
846 (test_analyze_test_reftest_multiple_matches):
847 (test_analyze_test_reftest_match_and_mismatch):
848 (test_analyze_test_reftest_with_ref_support_Files):
849 (test_analyze_jstest):
850 (test_analyze_pixel_test_all_true):
851 (test_analyze_pixel_test_all_false):
852 (test_analyze_non_html_file):
854 2013-05-17 Ryosuke Niwa <rniwa@webkit.org>
856 Leaks builders exit early frequently
857 https://bugs.webkit.org/show_bug.cgi?id=116355
859 Reviewed by Stephanie Lewis.
861 Throttle the number of processes to use, and also bump up the number of crashes/timeouts
862 we tolerate from 20 to 50.
864 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
865 (RunWebKitTests.start):
866 * Scripts/webkitpy/port/mac.py:
867 (MacPort.default_child_processes):
869 2013-05-17 Peter Gal <galpeter@inf.u-szeged.hu>
871 Remove chrome-channels command from the webkit-patch
872 https://bugs.webkit.org/show_bug.cgi?id=116303
874 Reviewed by Ryosuke Niwa.
876 * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
877 * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
878 * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
879 * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
880 * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
881 * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
883 2013-05-17 David Kilzer <ddkilzer@apple.com>
885 filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
886 Part 3 of 3: <http://webkit.org/b/116247>
888 Reviewed by Benjamin Poulain.
890 * Scripts/filter-build-webkit: Change while() loop to for() loop
891 to track $previousLine, then pass $previousLine into
893 (shouldIgnoreLine): Add $previousLine argument. Do not skip a
894 line that begins with four spaces if the previous line is a
895 linker error message.
896 * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
897 - Add "Ignored: " to test descriptions to document expected
899 - Add comment blocks for various groups of tests.
900 - Expand "Build settings" tests since we're changing the code in
901 shouldIgnoreLine() that ignores those lines.
902 - Add tests for undefined symbols error message.
903 (description): Add. Extract from global code.
905 2013-05-17 David Kilzer <ddkilzer@apple.com>
907 Add tests for shouldIgnoreLine() in filter-build-webkit
908 Part 2 of 3: <http://webkit.org/b/116247>
910 Reviewed by Benjamin Poulain.
912 * Scripts/filter-build-webkit:
913 (shouldIgnoreLine): Add. Extract code from global scope into
914 subroutine to make it testable.
915 * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
916 Tests shouldIgnoreLine() using output from a real build
919 2013-05-17 Ryosuke Niwa <rniwa@webkit.org>
921 Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
922 https://bugs.webkit.org/show_bug.cgi?id=116341
924 Reviewed by Brady Eidson.
926 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
928 2013-05-17 Brent Fulgham <bfulgham@apple.com>
930 [Windows] Don't use pdevenv when building with VS2010.
931 https://bugs.webkit.org/show_bug.cgi?id=116338.
933 Reviewed by Adam Roben.
935 * Scripts/webkitdirs.pm:
936 (setupCygwinEnv): Check if we are using VS2005, and only use
937 the 'pdevenv' hack if we are. Otherwise, just build with
938 our standard project since it uses VS2010+'s native
939 parallel building features.
941 2013-05-17 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
943 Unreviewed. Disable accelerated compositing until we figure out why it does not work
944 properly in the 64 bits release bot.
946 * DumpRenderTree/gtk/DumpRenderTree.cpp:
947 (resetDefaultsToConsistentValues):
949 2013-05-17 David Kilzer <ddkilzer@apple.com>
951 Make filter-build-webkit testable using LoadAsModule
952 Part 1 of 3: <http://webkit.org/b/116247>
954 Reviewed by Benjamin Poulain.
956 * Scripts/filter-build-webkit: Change global variables that are
957 used in subroutines from 'my' to 'our' to make it possible to
958 evaluate the script in a package context in LoadAsModule.pm.
960 2013-05-14 Sam Weinig <sam@webkit.org>
962 Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
963 https://bugs.webkit.org/show_bug.cgi?id=116132
965 Reviewed by Anders Carlsson.
967 Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
968 willLoadURLRequest and willLoadDataRequest to let the bundle access them.
970 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
971 * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
972 * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
973 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
975 2013-05-16 Seokju Kwon <seokju.kwon@gmail.com>
977 [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
978 https://bugs.webkit.org/show_bug.cgi?id=114781
980 Reviewed by Christophe Dumez.
982 Add run_before_unload_confirm and
983 Print the log message with "CONFIRM NAVIGATION: " in console.
985 * DumpRenderTree/efl/DumpRenderTreeView.cpp:
986 (onBeforeUnloadConfirm):
989 2013-05-16 Peter Gal <galpeter@inf.u-szeged.hu>
991 Fix Analyze ChangeLog's entry processing
992 https://bugs.webkit.org/show_bug.cgi?id=116219
994 Reviewed by Ryosuke Niwa.
996 * Scripts/webkitpy/tool/commands/analyzechangelog.py:
997 (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
999 2013-05-16 Hyungchan Kim <hyungchan2.kim@lge.com>
1001 [Qt] UrlLoader::loadNext is broken in MiniBrowser
1002 https://bugs.webkit.org/show_bug.cgi?id=116099
1004 Reviewed by Jocelyn Turcotte.
1006 QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
1007 are not available any more. So, UrlLoader::loadNext was broken
1008 because it failed to connect to those signals.
1010 * MiniBrowser/qt/UrlLoader.cpp:
1011 (UrlLoader::UrlLoader):
1012 (UrlLoader::loadingChanged):
1013 * MiniBrowser/qt/UrlLoader.h:
1016 2013-05-16 Lamarque V. Souza <Lamarque.Souza@basyskom.com>
1018 [WebSocket] Update pywebsocket to r760
1019 https://bugs.webkit.org/show_bug.cgi?id=115863
1021 Reviewed by Alexey Proskuryakov.
1023 Version r760 supports a newer draft of message compression.
1024 We need this update to finish the permessage compression patch in
1025 bug 98840. This patch also fixes failing unit tests after the update.
1027 * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
1029 (StreamBase._read.of):
1030 (StreamBase._write):
1031 (StreamBase.receive_bytes):
1032 (StreamBase._read_until):
1033 * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
1035 (StreamOptions.__init__):
1037 (Stream._receive_frame_as_frame_object):
1038 (Stream._get_message_from_frame):
1039 (Stream._process_close_message):
1040 (Stream.close_connection):
1041 (Stream.get_last_received_opcode):
1042 * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
1043 * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
1044 (Dispatcher.do_extra_handshake):
1045 (Dispatcher.transfer_data):
1046 * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
1047 (ExtensionProcessorInterface.__init__):
1048 (ExtensionProcessorInterface.request):
1049 (ExtensionProcessorInterface):
1050 (ExtensionProcessorInterface.name):
1051 (ExtensionProcessorInterface.check_consistency_with_other_processors):
1052 (ExtensionProcessorInterface.set_active):
1053 (ExtensionProcessorInterface.is_active):
1054 (ExtensionProcessorInterface._get_extension_response_internal):
1055 (ExtensionProcessorInterface.get_extension_response):
1056 (ExtensionProcessorInterface._setup_stream_options_internal):
1057 (ExtensionProcessorInterface.setup_stream_options):
1058 (_log_outgoing_compression_ratio):
1059 (_log_incoming_compression_ratio):
1060 (_parse_window_bits):
1061 (_AverageRatioCalculator):
1062 (_AverageRatioCalculator.__init__):
1063 (_AverageRatioCalculator.add_original_bytes):
1064 (_AverageRatioCalculator.add_result_bytes):
1065 (_AverageRatioCalculator.get_average_ratio):
1066 (DeflateFrameExtensionProcessor):
1067 (DeflateFrameExtensionProcessor.__init__):
1068 (DeflateFrameExtensionProcessor._get_extension_response_internal):
1069 (DeflateFrameExtensionProcessor._setup_stream_options_internal):
1070 (DeflateFrameExtensionProcessor._outgoing_filter):
1071 (DeflateFrameExtensionProcessor._incoming_filter):
1072 (CompressionExtensionProcessorBase.for):
1073 (CompressionExtensionProcessorBase.__init__):
1074 (CompressionExtensionProcessorBase._get_extension_response_internal):
1075 (CompressionExtensionProcessorBase._setup_stream_options_internal):
1076 (PerFrameCompressExtensionProcessor):
1077 (PerMessageDeflateExtensionProcessor):
1078 (PerMessageDeflateExtensionProcessor.__init__):
1079 (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
1080 (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
1081 (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
1082 (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
1083 (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
1084 (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
1085 (PerMessageDeflateExtensionProcessor.set_bfinal):
1086 (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
1087 (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
1088 (_PerMessageDeflateFramer):
1089 (_PerMessageDeflateFramer.__init__):
1090 (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
1091 (_PerMessageDeflateFramer._process_incoming_message):
1092 (_PerMessageDeflateFramer._process_outgoing_message):
1093 (_PerMessageDeflateFramer.setup_stream_options):
1094 (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
1095 (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
1096 (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
1097 (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
1098 (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
1099 (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
1100 (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
1101 (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
1102 (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
1103 (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
1104 (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
1105 (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
1106 (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
1107 (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
1108 (PerMessageCompressExtensionProcessor):
1109 (PerMessageCompressExtensionProcessor._lookup_compression_processor):
1110 (MuxExtensionProcessor.__init__):
1111 (MuxExtensionProcessor.check_consistency_with_other_processors):
1112 (MuxExtensionProcessor):
1113 (MuxExtensionProcessor._get_extension_response_internal):
1114 (MuxExtensionProcessor._setup_stream_options_internal):
1115 (MuxExtensionProcessor.set_quota):
1116 (MuxExtensionProcessor.quota):
1117 (MuxExtensionProcessor.set_extensions):
1118 (MuxExtensionProcessor.extensions):
1119 (is_compression_extension):
1120 * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
1121 (validate_subprotocol):
1122 (parse_host_header):
1124 (check_request_line):
1125 * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
1126 (Handshaker.do_handshake):
1127 (Handshaker._create_handshake_response):
1128 * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
1129 (_validate_subprotocol):
1130 (_check_header_lines):
1132 (Handshaker.do_handshake):
1133 (Handshaker._set_subprotocol):
1134 (Handshaker._set_location):
1135 * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
1136 (_create_dispatcher):
1137 (headerparserhandler):
1138 * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
1139 (_create_add_channel_response):
1140 (_create_drop_channel):
1141 (_create_flow_control):
1142 (_create_new_channel_slot):
1143 (_create_fallback_new_channel_slot):
1144 (_MuxFramePayloadParser._read_number):
1145 (_MuxFramePayloadParser._read_size_and_contents):
1146 (_MuxFramePayloadParser._read_flow_control):
1147 (_MuxFramePayloadParser._read_new_channel_slot):
1148 (_LogicalConnection.__init__):
1149 (_LogicalConnection.write):
1150 (_LogicalConnection.on_write_data_done):
1151 (_LogicalConnection):
1152 (_LogicalConnection.on_writer_done):
1154 (_InnerMessage.__init__):
1155 (_InnerMessageBuilder):
1156 (_InnerMessageBuilder.that):
1157 (_InnerMessageBuilder.__init__):
1158 (_InnerMessageBuilder._handle_first):
1159 (_InnerMessageBuilder._process_first_fragmented_control):
1160 (_InnerMessageBuilder._process_first_fragmented_message):
1161 (_InnerMessageBuilder._handle_fragmented_control):
1162 (_InnerMessageBuilder._reassemble_fragmented_control):
1163 (_InnerMessageBuilder._handle_fragmented_message):
1164 (_InnerMessageBuilder._reassemble_fragmented_message):
1165 (_InnerMessageBuilder.build):
1166 (_LogicalStream.__init__):
1167 (_LogicalStream._create_inner_frame):
1168 (_LogicalStream._write_inner_frame):
1169 (_LogicalStream.replenish_send_quota):
1170 (_LogicalStream.send_message):
1171 (_LogicalStream._receive_frame):
1172 (_LogicalStream._get_message_from_frame):
1173 (_LogicalStream.stop_sending):
1174 (_PhysicalConnectionWriter.__init__):
1175 (_PhysicalConnectionWriter._write_data):
1176 (_PhysicalConnectionWriter.run):
1177 (_PhysicalConnectionWriter.stop):
1179 (_MuxHandshaker.__init__):
1180 (_MuxHandshaker._create_stream):
1181 (_MuxHandshaker._create_handshake_response):
1182 (_HandshakeDeltaBase.create_headers):
1183 (_MuxHandler.start):
1184 (_MuxHandler.wait_until_done):
1185 (_MuxHandler.notify_write_data_done):
1186 (_MuxHandler._process_drop_channel):
1187 (_MuxHandler._process_logical_frame):
1188 (_MuxHandler.notify_reader_done):
1190 (_MuxHandler.notify_writer_done):
1191 (_MuxHandler.fail_physical_connection):
1192 (_MuxHandler.fail_logical_channel):
1194 * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
1195 (_StandaloneRequest.get_uri):
1196 (_StandaloneRequest.get_unparsed_uri):
1197 (_StandaloneRequest):
1198 (_StandaloneRequest.is_https):
1200 (_import_pyopenssl):
1201 (_StandaloneSSLConnection.for):
1202 (_StandaloneSSLConnection):
1203 (_StandaloneSSLConnection.__getattribute__):
1204 (_StandaloneSSLConnection.__setattr__):
1205 (_StandaloneSSLConnection.makefile):
1206 (_StandaloneSSLConnection.shutdown):
1207 (_StandaloneSSLConnection.recv):
1208 (WebSocketServer.__init__):
1209 (WebSocketServer._create_sockets):
1210 (WebSocketServer.handle_error):
1211 (WebSocketServer.get_request):
1212 (WebSocketServer.get_request.default_callback):
1213 (WebSocketRequestHandler.parse_request):
1214 (_build_option_parser):
1217 * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
1218 (RepeatedXorMasker.__init__):
1219 (RepeatedXorMasker._mask_using_swig):
1220 (RepeatedXorMasker):
1221 (RepeatedXorMasker._mask_using_array):
1222 (_Deflater.compress_and_finish):
1223 (_RFC1979Deflater.filter):
1224 (DeflateSocket.send):
1226 2013-05-16 Jonathan Liu <net147@gmail.com>
1228 Fix testing if program exists in PATH
1229 https://bugs.webkit.org/show_bug.cgi?id=116216
1231 Reviewed by Jocelyn Turcotte.
1233 functions.prf incorrectly uses win_cmd_shell to test whether to
1234 add .exe to the executable name when checking if it exists in
1235 the PATH environment variable. This works correctly when
1236 building using Windows Command Prompt but not under MSYS shell.
1238 To resolve this, check the win32 platform scope instead of
1239 win_cmd_shell so that it correctly adds .exe to the executable
1240 name on Windows regardless of the shell used when testing if
1243 * qmake/mkspecs/features/functions.prf:
1245 2013-05-16 Ryosuke Niwa <rniwa@webkit.org>
1247 Fix the hard-coded names of EWS bots that run tests.
1249 * Scripts/webkitpy/tool/commands/queues.py:
1250 (CommitQueue.did_pass_testing_ews):
1252 2013-05-16 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
1254 [GTK] Build Xvfb with jhbuild
1255 https://bugs.webkit.org/show_bug.cgi?id=115907
1257 Reviewed by Martin Robinson.
1259 Build our own Xvfb so that we can avoid problems with the system Xvfb
1260 relying on symbols not present in our jhbuilt libraries such as pixman,
1261 and also to ensure we have the fix for a GLX module crasher.
1263 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1264 (resetDefaultsToConsistentValues): enable accelerated compositing.
1265 * gtk/install-dependencies: list packages required for building Xvfb.
1266 * gtk/jhbuild.modules: add xserver as a jhbuild module.
1267 * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
1268 * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
1269 initializing the GLX module for Xvfb.
1271 2013-05-16 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
1273 [jhbuild] Should remove the sources directory as well when cleaning
1274 https://bugs.webkit.org/show_bug.cgi?id=116229
1276 Reviewed by Martin Robinson.
1278 * Scripts/update-webkit-libs-jhbuild:
1279 (cleanJhbuild): remove the Source directory as well when cleaning.
1281 2013-05-15 Dominik Röttsches <dominik.rottsches@intel.com>
1283 [EFL] Remove Intel Wk2 Buildbots from Master
1284 https://bugs.webkit.org/show_bug.cgi?id=116149
1286 Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
1287 since Gyuyoung Kim from Samsung plans to take over and maintain it.
1289 Reviewed by Benjamin Poulain.
1291 * BuildSlaveSupport/build.webkit.org-config/config.json:
1293 2013-05-15 Brent Fulgham <bfulgham@apple.com>
1295 [Windows] Update various build tools to understand VS2010 environment.
1296 https://bugs.webkit.org/show_bug.cgi?id=116169.
1298 Reviewed by Anders Carlsson.
1300 * Scripts/build-api-tests: Identify VS2010 environment.
1301 * Scripts/build-dumprendertree: Ditto.
1302 * Scripts/build-webkit: Ditto.
1303 * Scripts/webkitdirs.pm:
1304 (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
1305 range of acceptable SDK's.
1307 2013-05-15 Peter Gal <galpeter@inf.u-szeged.hu>
1309 Allow http tests on Arch Linux
1310 https://bugs.webkit.org/show_bug.cgi?id=116155
1312 Reviewed by Ryosuke Niwa.
1314 * Scripts/webkitpy/port/base.py:
1315 (Port._is_arch_based): Added check for /etc/arch-release file.
1316 (Port._apache_config_file_name_for_platform): Call the check.
1317 * Scripts/webkitpy/port/port_testcase.py:
1318 (test_linux_distro_detection): Testcase added.
1320 2013-05-15 Peter Gal <galpeter@inf.u-szeged.hu>
1322 Remove a leftover v8 file from the watchlist
1323 https://bugs.webkit.org/show_bug.cgi?id=116158
1325 Reviewed by Csaba Osztrogonác.
1327 * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
1329 2013-05-15 Alberto Garcia <agarcia@igalia.com>
1331 [GTK] Fails to build while generating gtkdoc
1332 https://bugs.webkit.org/show_bug.cgi?id=115612
1334 Reviewed by Philippe Normand.
1336 Fix typo in the prerequisites of docs-build.stamp.
1340 2013-05-15 Zan Dobersek <zdobersek@igalia.com>
1342 Unreviewed, fixing the current test-webkitpy failure.
1344 * Scripts/webkitpy/port/mac_unittest.py:
1345 (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
1346 in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
1348 2013-05-14 Jaehun Lim <ljaehun.lim@samsung.com>
1350 Fix build after r150090.
1351 https://bugs.webkit.org/show_bug.cgi?id=116129
1353 Unreviewed build fix after r150090.
1355 * WebKitTestRunner/TestInvocation.cpp:
1356 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1358 2013-05-14 Brent Fulgham <bfulgham@apple.com>
1360 [Windows, others] Unreviewed build fix after r150090.
1362 * DumpRenderTree/TestRunner.cpp:
1363 (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
1364 doesn't exist on other platforms.
1366 2013-05-14 Brent Fulgham <bfulgham@webkit.org>
1368 [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
1369 https://bugs.webkit.org/show_bug.cgi?id=115889
1371 Reviewed by Benjamin Poulain.
1373 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1374 * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1376 2013-05-14 Brent Fulgham <bfulgham@apple.com>
1378 [Windows] Identify proper run environment for scripts.
1379 https://bugs.webkit.org/show_bug.cgi?id=116114
1381 Reviewed by David Kilzer.
1383 Determine (based on Visual Studio version) which path to use for
1384 executables (bin versus bin32).
1386 * Scripts/webkitdirs.pm:
1387 (determineVisualStudioInstallDir): Added.
1388 (determineVisualStudioVersion): Added.
1389 (determineConfigurationProductDir): Modified to choose proper bin
1391 (visualStudioVersion): Added
1392 (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
1394 2013-05-14 Alexey Proskuryakov <ap@apple.com>
1396 [Mac] Add tests for secure event input
1397 https://bugs.webkit.org/show_bug.cgi?id=116121
1399 Reviewed by Mark Rowe.
1401 * DumpRenderTree/TestRunner.cpp:
1402 (getSecureEventInputIsEnabledCallback):
1403 (TestRunner::staticValues):
1404 Expose an accessor for current secure event input state.
1406 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1407 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1408 (WTR::TestRunner::secureEventInputIsEnabled):
1409 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1410 * WebKitTestRunner/TestInvocation.cpp:
1411 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1412 Expose an accessor for current secure event input state. This has to be done in
1413 UI process, as this is where it's changed by WebKit.
1415 2013-05-14 Alexey Proskuryakov <ap@apple.com>
1417 [Mac] Add a testing shim for secure event input functions
1418 https://bugs.webkit.org/show_bug.cgi?id=116122
1420 Reviewed by Mark Rowe.
1422 * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
1423 Inject WebCore testing shim library to override system framework functions.
1425 2013-05-14 Brent Fulgham <bfulgham@apple.com>
1427 [Windows] Switch to embedded manifest commands for launcher executables.
1428 https://bugs.webkit.org/show_bug.cgi?id=116109
1430 Reviewed by Darin Adler.
1432 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
1433 now-unused WinLauncher.exe.manifest file.
1434 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1435 * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
1436 when building with VS2010 or newer.
1438 2013-05-14 Brent Fulgham <bfulgham@apple.com>
1440 [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
1441 https://bugs.webkit.org/show_bug.cgi?id=116079
1443 Reviewed by David Kilzer.
1445 * Scripts/old-run-webkit-tests:
1446 (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
1448 2013-05-14 Zan Dobersek <zdobersek@igalia.com>
1450 [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
1451 https://bugs.webkit.org/show_bug.cgi?id=115921
1453 Reviewed by Gustavo Noronha Silva.
1455 * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
1456 * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
1458 2013-05-13 Alex Christensen <achristensen@apple.com>
1460 Added testRunner.setPrinting.
1461 https://bugs.webkit.org/show_bug.cgi?id=42693
1462 rdar://problem/8213845
1464 Reviewed by Darin Adler.
1466 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1467 Added setPrinting JavaScript function.
1468 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1469 (WTR::InjectedBundlePage::dump):
1470 Dump the external representation for printing if setPrinting has been called.
1471 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1472 (WTR::TestRunner::isPrinting): Added.
1473 (WTR::TestRunner::setPrinting): Added.
1474 Added and initialized m_isPrinting member boolean.
1476 2013-05-13 Csaba Osztrogonác <ossy@webkit.org>
1478 [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
1479 https://bugs.webkit.org/show_bug.cgi?id=116016
1481 Reviewed by Dirk Pranke.
1483 Same fix as in the upstream style checker, but without hg support.
1484 ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
1486 * Scripts/webkitpy/style/checkers/cpp.py:
1487 (FileInfo.repository_name):
1489 2013-05-13 Zan Dobersek <zdobersek@igalia.com>
1491 [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
1492 https://bugs.webkit.org/show_bug.cgi?id=115918
1494 Reviewed by Gustavo Noronha Silva.
1496 Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
1497 the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
1498 This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
1499 due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
1500 when linking, simplifying the code and suppressing all the layering violations so they do not cause build
1503 First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
1504 These are then used as dependencies for the archive creation rule as well as the list from which the archive
1505 file paths are constructed and then used to dump the member files from these archives. The member files are
1506 then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
1509 * TestWebKitAPI/GNUmakefile.am:
1511 2013-05-13 Anders Carlsson <andersca@apple.com>
1513 Remove UnusedParam.h
1514 https://bugs.webkit.org/show_bug.cgi?id=116029
1516 Reviewed by Andreas Kling.
1518 Stop including UnusedParam.h.
1520 * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1521 * WebKitTestRunner/qt/TestInvocationQt.cpp:
1523 2013-05-12 Commit Queue <commit-queue@webkit.org>
1525 Unreviewed, rolling out r149955.
1526 http://trac.webkit.org/changeset/149955
1527 https://bugs.webkit.org/show_bug.cgi?id=115990
1529 Broke lots of tests (Requested by smfr on #webkit).
1531 * Scripts/webkitpy/port/mac.py:
1533 2013-05-12 Carlos Garcia Campos <cgarcia@igalia.com>
1535 [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
1536 https://bugs.webkit.org/show_bug.cgi?id=115914
1538 Reviewed by Martin Robinson.
1540 * GtkLauncher/main.c:
1542 * MiniBrowser/gtk/BrowserWindow.c:
1544 (browserWindowSetStatusText):
1545 (fullScreenMessageTimeoutCallback):
1546 (webViewEnterFullScreen):
1547 (webViewLeaveFullScreen):
1548 (browserWindowFinalize):
1549 (browserWindowConstructed):
1550 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1551 (WTR::EventSenderProxy::mouseScrollBy):
1552 (WTR::EventSenderProxy::continuousMouseScrollBy):
1554 2013-05-11 Anders Carlsson <andersca@apple.com>
1556 Crash when terminating a process that has not been fully launched
1557 https://bugs.webkit.org/show_bug.cgi?id=115962
1558 <rdar://problem/13660916>
1560 Reviewed by Andreas Kling.
1562 Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
1563 before the process has had a chance to be fully launched.
1565 * TestWebKitAPI/GNUmakefile.am:
1566 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1567 * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
1569 (TestWebKitAPI::didFinishLoadForFrame):
1570 (TestWebKitAPI::TEST):
1571 * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1573 2013-05-10 Laszlo Gombos <l.gombos@samsung.com>
1575 Remove Mac OS X Leopard (10.5) support
1576 https://bugs.webkit.org/show_bug.cgi?id=107964
1578 Reviewed by Ryosuke Niwa.
1580 Removed the code for 10.5 and removed if-def for 10.6.
1582 * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1584 (createXMLStringFromWebArchiveData):
1585 * DumpRenderTree/mac/TestRunnerMac.mm:
1586 (TestRunner::authenticateSession):
1587 (TestRunner::setTextDirection):
1588 * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1590 (createXMLStringFromWebArchiveData):
1592 2013-05-10 Brent Fulgham <bfulgham@apple.com>
1594 [Windows] Allow VS2010 Build to use VS2005 Support Libraries
1595 https://bugs.webkit.org/show_bug.cgi?id=115935
1597 Reviewed by Jer Noble.
1599 * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
1600 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
1601 to the new manifest file.
1602 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
1604 2013-05-10 Jacky Jiang <zhajiang@blackberry.com>
1606 Fix some compiler warnings (miscellaneous)
1607 https://bugs.webkit.org/show_bug.cgi?id=80790
1609 Reviewed by Rob Buis.
1611 Fix the following warnings for BlackBerry:
1612 DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
1613 used as truth value [-Wparentheses].
1615 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1616 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1618 2013-05-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
1620 [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
1621 https://bugs.webkit.org/show_bug.cgi?id=115928
1623 Reviewed by Kenneth Rohde Christiansen.
1625 WKViewSetThemePath was moved to WKViewEfl.h.
1627 * TestWebKitAPI/efl/PlatformWebView.cpp:
1629 2013-05-10 Andreas Kling <akling@apple.com>
1631 I accidentally the Java testing.
1633 * Scripts/webkitpy/port/mac.py:
1635 2013-05-10 Brian Holt <brian.holt@samsung.com>
1637 [GTK] Module Cairo fails to build under jhbuild
1638 https://bugs.webkit.org/show_bug.cgi?id=115854
1640 Reviewed by Martin Robinson.
1642 Make cairo depend on glib in jhbuild.modules.
1644 * gtk/jhbuild.modules:
1646 2013-05-10 Carlos Garcia Campos <cgarcia@igalia.com>
1648 [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
1649 https://bugs.webkit.org/show_bug.cgi?id=115904
1651 Reviewed by Martin Robinson.
1653 * ImageDiff/gtk/ImageDiff.cpp:
1656 2013-05-10 Balazs Kelemen <kbalazs@webkit.org>
1658 Add my new address to contributors.json. (Unreviewed)
1660 * Scripts/webkitpy/common/config/contributors.json:
1662 2013-05-10 Christophe Dumez <ch.dumez@sisa.samsung.com>
1664 Unreviewed. Move myself to the reviewers list.
1666 * Scripts/webkitpy/common/config/contributors.json:
1668 2013-05-10 Christophe Dumez <ch.dumez@sisa.samsung.com>
1670 Unreviewed. Add my email to a few watchlists.
1672 * Scripts/webkitpy/common/config/watchlist:
1674 2013-05-10 Simon Pena <simon.pena@samsung.com>
1676 Unicode support missing from string representation of Contributors in committers.py
1677 https://bugs.webkit.org/show_bug.cgi?id=115859
1679 Reviewed by Darin Adler.
1681 Contributors, in committers.py, provided a string representation in __str__ which
1682 didn't support unicode characters, so printing a contributor would fail in that case.
1683 This patch implements __unicode__ and makes __str__ use it to represent a contributor.
1684 The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
1686 * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
1687 to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
1689 (Contributor.__str__):
1691 (Contributor.__unicode__):
1692 * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
1693 a contributor with unicode characters can be represented as a string.
1695 (CommittersTest.test_contributor_encoding):
1697 2013-05-09 Patrick Gansterer <paroga@webkit.org>
1699 [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
1700 https://bugs.webkit.org/show_bug.cgi?id=92371
1702 Reviewed by Brent Fulgham.
1704 Use JavaScriptThreading.cpp where the same functionality is
1705 implemented too. This reduces the dependency on the pthread
1706 library. Also replace assert() with WebKit ASSERT().
1708 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1709 * DumpRenderTree/win/DumpRenderTree.cpp:
1711 (dumpBackForwardList):
1712 * DumpRenderTree/win/DumpRenderTree.vcproj:
1714 2013-05-09 Patrick Gansterer <paroga@webkit.org>
1716 [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
1717 https://bugs.webkit.org/show_bug.cgi?id=92505
1719 Reviewed by Brent Fulgham.
1721 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1722 * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
1723 (javaScriptThreadsMutex):
1724 (javaScriptThreads):
1725 (runJavaScriptThread):
1726 (startJavaScriptThreads):
1727 (stopJavaScriptThreads):
1728 * DumpRenderTree/pthreads: Removed.
1729 * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
1731 2013-05-09 Mario Sanchez Prada <mario.prada@samsung.com>
1733 Unreviewed. Update Simon Pena email on his behalf.
1735 * Scripts/webkitpy/common/config/contributors.json:
1737 2013-05-09 Christophe Dumez <ch.dumez@sisa.samsung.com>
1739 Add support for [NoInterfaceObject] Web IDL extended attribute
1740 https://bugs.webkit.org/show_bug.cgi?id=115714
1742 Reviewed by Kentaro Hara.
1744 Update BindingsTests.generate_supplemental_dependency() to pass an
1745 additional windowConstructorsFile argument to preprocess-idls.pl.
1747 * Scripts/webkitpy/bindings/main.py:
1748 (BindingsTests.generate_supplemental_dependency):
1749 (BindingsTests.main):
1751 2013-05-09 ChangSeok Oh <changseok.oh@collabora.com>
1753 [GTK][AC] Buildfix after r149694
1754 https://bugs.webkit.org/show_bug.cgi?id=115797
1756 Reviewed by Gustavo Noronha Silva.
1758 Add CLUTTER_LIBS for linking TestWebCore.
1760 * TestWebKitAPI/GNUmakefile.am:
1762 2013-05-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1764 [EFL] Remove unnecessary pkgs in EFL jhbuild
1765 https://bugs.webkit.org/show_bug.cgi?id=114908
1767 Reviewed by Laszlo Gombos.
1769 p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
1770 handle them using jhbuild. We can reduce build time when using --update-efl.
1772 * efl/jhbuild.modules:
1774 2013-05-08 Seokju Kwon <seokju.kwon@gmail.com>
1776 [EFL] Disable SHADOW DOM feature in FeatureList.pm
1777 https://bugs.webkit.org/show_bug.cgi?id=115834
1779 Reviewed by Gyuyoung Kim.
1781 * Scripts/webkitperl/FeatureList.pm:
1783 2013-05-08 Lucas Forschler <lforschler@apple.com>
1785 Add Scheduler for Mac MtnLion 32bit Release builder.
1789 * BuildSlaveSupport/build.webkit.org-config/config.json:
1791 2013-05-08 Denis Nomiyama <d.nomiyama@samsung.com>
1793 Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
1794 https://bugs.webkit.org/show_bug.cgi?id=115808
1796 Reviewed by Darin Adler.
1798 The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
1799 was left outdated after r127191, when the m_string member was changed
1800 from UString to String. This patch calls the right pretty printer for it.
1803 (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
1804 WTFImplPrettyPrinter.
1806 2013-05-08 Andy Estes <aestes@apple.com>
1808 [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
1809 https://bugs.webkit.org/show_bug.cgi?id=115790
1811 Reviewed by Alexey Proskuryakov.
1813 Added two API tests:
1815 1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
1816 2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
1818 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1819 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
1821 (TestWebKitAPI::TEST):
1822 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
1824 (TestWebKitAPI::decidePolicyForNavigationAction):
1825 (CustomProtocolInvalidSchemeTest):
1826 (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
1828 2013-05-08 Lucas Forschler <lforschler@apple.com>
1830 Teach buildbot how to compile 32-bit on Mac.
1832 Reviewed by Ryosuke Niwa.
1834 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1835 (CompileWebKit.start):
1836 (ExtractTestResultsAndLeaks):
1838 2013-05-08 Eli Fidler <efidler@blackberry.com>
1840 [BlackBerry] Fix usage of BlackBerry::Platform::String
1841 https://bugs.webkit.org/show_bug.cgi?id=115781
1843 Reviewed by Rob Buis.
1845 BlackBerry PRs 304193 and 327181
1846 Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
1848 We currently have a problem where we're passing UTF-8 encoded data into
1849 the char* constructors of BlackBerry::Platform::String. This means the string
1850 thinks its data is not UTF-8.
1852 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1853 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1854 (BlackBerry::WebKit::dumpHistoryItem):
1855 * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1856 (TestRunner::setUserStyleSheetLocation):
1857 * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1858 (LoadHTMLStringItem::invoke):
1860 2013-05-08 Alberto Garcia <agarcia@igalia.com>
1862 Tools: add new BlackBerry include dirs.
1863 https://bugs.webkit.org/show_bug.cgi?id=115514
1865 Reviewed by Rob Buis.
1867 iType include dirs are missing, and HarfBuzz needs to be fixed.
1869 * Scripts/webkitdirs.pm:
1870 (blackberryCMakeArguments):
1872 2013-05-08 José Dapena Paz <jdapena@igalia.com> and Zan Dobersek <zdobersek@igalia.com>
1874 [GTK] Plumb the Automake build system for the Battery Status API feature
1875 https://bugs.webkit.org/show_bug.cgi?id=115718
1877 Reviewed by Martin Robinson.
1879 * Scripts/webkitdirs.pm:
1880 (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
1881 through the --(enable|disable)-battery-status flag passed to configure.
1883 2013-05-08 Ryosuke Niwa <rniwa@webkit.org>
1885 new-run-webkit-websocketserver doesn't work after Chromium removal
1886 https://bugs.webkit.org/show_bug.cgi?id=115816
1888 Reviewed by Joseph Pecoraro.
1890 Fix the bug by instantiating the correct port object.
1892 * Scripts/new-run-webkit-websocketserver:
1895 2013-05-07 Lucas Forschler <lforschler@apple.com>
1897 Configure buildbot for 32bit builder.
1898 https://bugs.webkit.org/show_bug.cgi?id=115769
1900 Reviewed by Ryosuke Niwa.
1902 * BuildSlaveSupport/build.webkit.org-config/config.json:
1904 2013-05-08 Brent Fulgham <bfulgham@webkit.org>
1906 Unreviewed. Update to show my apple.com address.
1908 * Scripts/webkitpy/common/config/contributors.json: Added
1909 my apple.com e-mail address.
1911 2013-05-08 David Kilzer <ddkilzer@apple.com>
1913 BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
1915 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1916 (concatenateAttributeAndValue): Switch to appendVector().
1918 2013-05-08 Andras Becsi <andras.becsi@digia.com>
1920 [Qt][WTR] Fix the build on Mac after r149692
1922 Unreviewed build fix.
1924 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1925 (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1927 2013-05-08 Mario Sanchez Prada <mario.prada@samsung.com>
1929 Unreviewed. Added Anton Obzhirov to the list of contributors and myself
1930 to the watchlist for Accessibility.
1932 * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
1933 * Scripts/webkitpy/common/config/watchlist: Added myself.
1935 2013-05-08 Andras Becsi <andras.becsi@digia.com>
1937 [Qt] Build fails with clang
1938 https://bugs.webkit.org/show_bug.cgi?id=115741
1940 Reviewed by Benjamin Poulain.
1942 Since r149112 std::move is used in AtomicString for compilers that
1943 support rvalue references and this requires a standard library
1944 implementing c++11 move semantics.
1945 We only explicitely require c++11 for WebKit2, but since clang supports
1946 rvalue references the build of subtargets using AtomicString fails because
1947 of missing std::move.
1948 It is safe to add CONFIG += c++11 for the whole project when using clang
1949 since we explicitely disable c++11 for ANGLE that had probems with libc++.
1951 * qmake/mkspecs/features/unix/default_pre.prf:
1953 2013-05-08 Darin Adler <darin@apple.com>
1955 Fix one more place that needed to use adoptCF/NS
1956 https://bugs.webkit.org/show_bug.cgi?id=115778
1958 Reviewed by Benjamin Poulain.
1960 Not sure why I missed this code last time, but found a bit more code that needs
1961 to switch to the newer style adoptCF/NS.
1963 * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
1964 (convertWebResourceDataToString): Use adoptCF.
1965 (convertWebResourceResponseToDictionary): Ditto.
1966 (createXMLStringFromWebArchiveData): Ditto.
1967 * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
1968 (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
1970 2013-05-08 Commit Queue <commit-queue@webkit.org>
1972 Unreviewed, rolling out r149271.
1973 http://trac.webkit.org/changeset/149271
1974 https://bugs.webkit.org/show_bug.cgi?id=115780
1976 The mangled symbols are now enforced through LDFLAGS
1977 (Requested by zdobersek on #webkit).
1979 * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1981 2013-05-08 Zan Dobersek <zdobersek@igalia.com>
1983 [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
1984 https://bugs.webkit.org/show_bug.cgi?id=115636
1986 Reviewed by Ryosuke Niwa.
1988 * TestResultServer/static-dashboards/flakiness_dashboard.js:
1989 (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
1990 through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
1991 while Chromium-specific, can't be removed just yet as there's more code that uses it.
1993 2013-05-06 Darin Adler <darin@apple.com>
1995 Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
1996 https://bugs.webkit.org/show_bug.cgi?id=115657
1998 Reviewed by Sam Weinig.
2000 This is similar to my last set of changes, but covers code that I missed with
2001 global replace using the Safari Xcode workspace.
2003 * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2004 (convertWebResourceDataToString):
2005 (convertWebResourceResponseToDictionary):
2006 (createXMLStringFromWebArchiveData):
2007 * DumpRenderTree/cg/ImageDiffCG.cpp:
2008 (createImageFromStdin):
2009 (createDifferenceImage):
2011 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2014 * DumpRenderTree/cg/PixelDumpSupportCG.h:
2015 (BitmapContext::BitmapContext):
2016 * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2017 (-[MockWebNotificationProvider init]):
2018 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2019 (createBitmapContext):
2020 * DumpRenderTree/mac/TestRunnerMac.mm:
2021 (TestRunner::addDisallowedURL):
2022 (TestRunner::applicationCacheDiskUsageForOrigin):
2023 (TestRunner::localStorageDiskUsageForOrigin):
2024 (TestRunner::clearApplicationCacheForOrigin):
2025 (TestRunner::deleteLocalStorageForOrigin):
2026 (TestRunner::copyDecodedHostName):
2027 (TestRunner::copyEncodedHostName):
2028 (TestRunner::queueLoad):
2029 (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2030 (TestRunner::setMockGeolocationPositionUnavailableError):
2031 (TestRunner::setUserStyleSheetLocation):
2032 (TestRunner::setValueForUser):
2033 (TestRunner::overridePreference):
2034 (TestRunner::setPersistentUserStyleSheetLocation):
2035 (TestRunner::execCommand):
2036 (TestRunner::findString):
2037 (TestRunner::isCommandEnabled):
2038 (TestRunner::addOriginAccessWhitelistEntry):
2039 (TestRunner::removeOriginAccessWhitelistEntry):
2040 (TestRunner::addUserScript):
2041 (TestRunner::addUserStyleSheet):
2042 (TestRunner::evaluateInWebInspector):
2043 (TestRunner::evaluateScriptInIsolatedWorld):
2044 (TestRunner::apiTestNewWindowDataLoadBaseURL):
2045 (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
2046 (TestRunner::authenticateSession):
2047 (TestRunner::grantWebNotificationPermission):
2048 (TestRunner::denyWebNotificationPermission):
2049 * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2050 (createCFURLResponseFromResponseData):
2051 * DumpRenderTree/mac/WorkQueueItemMac.mm:
2053 (LoadHTMLStringItem::invoke):
2054 (ScriptItem::invoke):
2055 * DumpRenderTree/win/DumpRenderTree.cpp:
2056 (substringFromIndex):
2057 (urlSuitableForTestResult):
2058 (lastPathComponent):
2060 * DumpRenderTree/win/ImageDiffCairo.cpp:
2061 (createImageFromStdin):
2063 * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2064 (createBitmapContextFromWebView):
2065 * DumpRenderTree/win/TestRunnerWin.cpp:
2066 (TestRunner::setUserStyleSheetLocation):
2067 (TestRunner::setPersistentUserStyleSheetLocation):
2068 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2069 (TestWebKitAPI::TEST):
2070 * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2071 (TestWebKitAPI::TEST):
2072 * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2073 (TestWebKitAPI::TEST):
2074 * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2075 (TestWebKitAPI::TEST):
2076 * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2077 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2078 * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
2079 (TestWebKitAPI::createWindow):
2080 (TestWebKitAPI::TEST):
2081 * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2082 (TestWebKitAPI::TEST):
2083 * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
2084 (TestWebKitAPI::AcceptsFirstMouse::runTest):
2085 * TestWebKitAPI/Tests/mac/AttributedString.mm:
2086 (TestWebKitAPI::TEST):
2087 * TestWebKitAPI/Tests/mac/BackForwardList.mm:
2088 (TestWebKitAPI::TEST):
2089 * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
2090 (TestWebKitAPI::TEST):
2091 * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2092 (TestWebKitAPI::TEST):
2093 * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
2094 (TestWebKitAPI::TEST):
2095 * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2096 (TestWebKitAPI::TEST):
2097 * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
2098 (TestWebKitAPI::TEST):
2099 * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2100 (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
2101 * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2102 (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
2103 * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
2104 (TestWebKitAPI::TEST):
2105 * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
2106 (TestWebKitAPI::TEST):
2107 * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2108 (TestWebKitAPI::TEST):
2109 * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
2110 (TestWebKitAPI::TEST):
2111 * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
2112 (TestWebKitAPI::TEST):
2113 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2114 (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2115 * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2116 (TestWebKitAPI::TEST):
2117 * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2118 (TestWebKitAPI::TEST):
2119 * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
2120 (TestWebKitAPI::TEST):
2121 * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2122 (TestWebKitAPI::TEST):
2123 * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
2124 (TestWebKitAPI::TEST):
2125 * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
2126 (TestWebKitAPI::TEST):
2127 * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
2128 (TestWebKitAPI::TEST):
2129 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2130 (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2131 * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2132 (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
2133 (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2134 * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
2135 (WTR::testPathFromURL):
2136 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2137 (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2138 * WebKitTestRunner/cg/TestInvocationCG.cpp:
2139 (WTR::createCGContextFromImage):
2141 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2142 * WebKitTestRunner/mac/EventSenderProxy.mm:
2143 (WTR::EventSenderProxy::mouseScrollBy):
2144 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2145 (WTR::PlatformWebView::windowSnapshotImage):
2146 * WebKitTestRunner/win/TestControllerWin.cpp:
2147 (WTR::TestController::initializeTestPluginDirectory):
2148 Use adoptCF and adoptNS.
2150 2013-05-07 Alex Christensen <achristensen@apple.com>
2152 Fix a memory leak introduced in r149692
2153 https://bugs.webkit.org/show_bug.cgi?id=115766
2155 Reviewed by Mark Rowe.
2157 In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any
2158 matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
2160 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2161 (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2162 Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
2164 2013-05-07 Darin Adler <darin@apple.com>
2166 [Win] Fix storage leak in Windows DumpRenderTree
2167 https://bugs.webkit.org/show_bug.cgi?id=115651
2169 Reviewed by Sam Weinig.
2171 * DumpRenderTree/win/DumpRenderTree.cpp:
2172 (lastPathComponent): Added a missing call to adoptCF.
2174 2013-05-07 Alex Christensen <achristensen@apple.com>
2176 fixed a memory leak introduced by bug 42324 by using a RetainPtr
2177 https://bugs.webkit.org/show_bug.cgi?id=115760
2179 Reviewed by Tim Horton.
2181 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2182 (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2183 fixed memory leak, added UNUSED_PARAM macros
2185 2013-05-07 Alex Christensen <achristensen@apple.com>
2187 WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
2188 https://bugs.webkit.org/show_bug.cgi?id=42324
2189 <rdar://problem/8193633>
2191 Reviewed by Tim Horton.
2193 * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2194 Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
2195 * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2196 (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2197 Added dumpDOMAsWebArchive code that is called when dumping.
2198 (WTR::InjectedBundlePage::dump):
2199 Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
2200 * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2201 (InjectedBundlePage):
2202 Added dumpDOMAsWebArchive declaration.
2203 * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
2204 (WTR::TestRunner::dumpDOMAsWebArchive):
2205 Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
2206 * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2207 Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
2208 * Tools/WebKitTestRunner/cf: Added.
2209 * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
2210 Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
2212 (convertWebResourceDataToString):
2213 (normalizeHTTPResponseHeaderFields):
2214 (normalizeWebResourceURL):
2215 (convertWebResourceResponseToDictionary):
2216 (compareResourceURLs):
2217 (createXMLStringFromWebArchiveData):
2218 * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
2219 Copied from Tools/DumpRenderTree/cf for used symbol declarations.
2220 * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
2221 Copied from Tools/DumpRenderTree/mac for used functions.
2222 (createCFURLResponseFromResponseData):
2223 (supportedNonImageMIMETypes):
2225 2013-05-07 Alex Christensen <achristensen@apple.com>
2227 Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
2228 https://bugs.webkit.org/show_bug.cgi?id=115745
2230 Reviewed by Tim Horton.
2232 * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2233 (compareResourceURLs):
2236 2013-05-06 Ryosuke Niwa <rniwa@webkit.org>
2238 Add an 'isReadOnly' member to IDL parse tree structure
2239 https://bugs.webkit.org/show_bug.cgi?id=115704
2241 Reviewed by Kentaro Hara.
2243 Use newly added isReadOnly attribute.
2245 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2246 (_generateHeaderFile):
2247 (_generateImplementationFile):
2248 (_staticValuesGetterImplementation):
2250 2013-05-07 Anders Carlsson <andersca@apple.com>
2252 Remove AlwaysInline.h from WTF
2253 https://bugs.webkit.org/show_bug.cgi?id=115727
2255 Reviewed by Brent Fulgham.
2257 The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
2258 to keep AlwaysInline.h around anymore.
2260 * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2261 * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2263 2013-05-07 Andras Becsi <andras.becsi@digia.com>
2265 [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
2266 https://bugs.webkit.org/show_bug.cgi?id=114808
2268 Reviewed by Jocelyn Turcotte.
2270 QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
2271 (https://codereview.qt-project.org/#change,54234)
2273 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2274 (WTR::WrapperWindow::handleStatusChanged):
2276 2013-05-06 Christophe Dumez <ch.dumez@sisa.samsung.com>
2278 Unreviewed. Add my email to EFL and BindingsScripts watchlists.
2280 * Scripts/webkitpy/common/config/watchlist:
2282 2013-05-06 Kangil Han <kangil.han@samsung.com>
2284 [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
2285 https://bugs.webkit.org/show_bug.cgi?id=115645
2287 Reviewed by Gyuyoung Kim.
2289 To run performance tests in wk1, we need --no-timeout option implementation.
2290 So adopt it from gtk+ port.
2292 * DumpRenderTree/efl/DumpRenderTree.cpp:
2293 (shouldSetWaitToDumpWatchdog):
2294 (parseCommandLineOptions):
2295 * DumpRenderTree/efl/DumpRenderTreeEfl.h:
2296 * DumpRenderTree/efl/TestRunnerEfl.cpp:
2297 (TestRunner::setWaitToDump):
2299 2013-05-06 Commit Queue <commit-queue@webkit.org>
2301 Unreviewed, rolling out r149547.
2302 http://trac.webkit.org/changeset/149547
2303 https://bugs.webkit.org/show_bug.cgi?id=115682
2305 Added unittests that fail on bots and spits out text into
2306 stdout (Requested by rniwa on #webkit).
2308 * Scripts/import-w3c-tests: Removed.
2309 * Scripts/webkitpy/w3c/__init__.py: Removed.
2310 * Scripts/webkitpy/w3c/test_converter.py: Removed.
2311 * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
2312 * Scripts/webkitpy/w3c/test_importer.py: Removed.
2313 * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
2314 * Scripts/webkitpy/w3c/test_parser.py: Removed.
2315 * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
2317 2013-05-03 Gustavo Noronha Silva <gns@gnome.org>
2319 [jhbuild] bump jhbuild version to take advantage of new improvements
2320 https://bugs.webkit.org/show_bug.cgi?id=115558
2322 Reviewed by Martin Robinson.
2324 One of the important improvements is jhbuild no longer fetches git
2325 repositories if they are already at the expected revision, which should
2326 make the EWS bots more robust to git servers unavailability.
2328 * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
2330 2013-05-06 Manuel Rego Casasnovas <rego@igalia.com>
2332 [GTK] Add webkit_uri_scheme_request_finish_error
2333 https://bugs.webkit.org/show_bug.cgi?id=94316
2335 Reviewed by Anders Carlsson.
2337 * MiniBrowser/gtk/main.c:
2338 (miniBrowserErrorQuark): Add function to create a global quark for
2340 (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
2341 function webkit_uri_scheme_request_finish_error().
2343 2013-05-06 Mike Lattanzio <mlattanzio@blackberry.com>
2345 [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
2346 https://bugs.webkit.org/show_bug.cgi?id=113808
2348 Reviewed by Rob Buis.
2350 Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
2351 to true for BlackBerry.
2353 * Scripts/webkitperl/FeatureList.pm:
2355 2013-05-06 Jessie Berlin <jberlin@apple.com>
2357 check-webkit-style should complain about a layering violation if platform-specific guards are
2358 used in WebCore outside of the platform directory
2359 https://bugs.webkit.org/show_bug.cgi?id=115567
2361 Reviewed by Benjamin Poulain.
2363 * Scripts/webkitpy/style/checkers/cpp.py:
2364 (check_for_webcore_platform_layering_violation):
2365 If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
2367 Add the check_for_webcore_platform_layering_violation.
2371 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2372 (CppStyleTest.test_webcore_platform_layering_violation):
2375 2013-05-06 David Kilzer <ddkilzer@apple.com>
2377 webkit-patch: fix 'upload' command with Bugzilla 4.2.5
2378 <http://webkit.org/b/115667>
2380 Reviewed by Dirk Pranke.
2382 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2383 (Bugzilla._check_create_bug_response): Update regex to work with
2384 Bugzilla 3.2.3 and 4.2.5.
2385 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2386 (test__check_create_bug_response): Add new test that covers both
2387 old and new <title> variations.
2389 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
2391 [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
2392 https://bugs.webkit.org/show_bug.cgi?id=115661
2394 Reviewed by Ryosuke Niwa.
2396 The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
2397 builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
2398 and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
2400 * TestResultServer/static-dashboards/flakiness_dashboard.js:
2401 * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2403 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
2405 [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
2406 https://bugs.webkit.org/show_bug.cgi?id=114603
2408 Reviewed by Ryosuke Niwa.
2410 * TestResultServer/generate_builders_json.py:
2411 (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
2412 to represent these to be 'layout-test', for backwards compatibility.
2413 (main): Remove all the build.chromium.org masters.
2414 * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
2415 (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2416 (GenerateBuildersJsonTest):
2417 (GenerateBuildersJsonTest.test_generate_json_data):
2418 * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
2419 test-running builders from the webkit.org master.
2421 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
2423 [Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
2424 https://bugs.webkit.org/show_bug.cgi?id=114988
2426 Reviewed by Ryosuke Niwa.
2428 * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
2429 and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
2430 * TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
2431 mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
2432 once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
2434 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
2436 [Flakiness Dashboard] Remove the remaining traces of platform modifier unions
2437 https://bugs.webkit.org/show_bug.cgi?id=114954
2439 Reviewed by Ryosuke Niwa.
2441 * TestResultServer/static-dashboards/flakiness_dashboard.js:
2442 (processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
2443 modifier unions in the list of modifiers.
2444 (generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
2445 * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
2447 2013-05-06 Zan Dobersek <zdobersek@igalia.com>
2449 [Flakiness Dashboard] Simplify builder-name-based platform recognition
2450 https://bugs.webkit.org/show_bug.cgi?id=114957
2452 Reviewed by Ryosuke Niwa.
2454 * TestResultServer/static-dashboards/flakiness_dashboard.js:
2455 (determineBuilderPlatform): Renamed from nonChromiumPlatform.
2456 (chromiumPlatform): Removed, unnecessary.
2457 (platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
2458 to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
2459 the builder operates with debug builds, no webkit.org builders are named this way.
2460 * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2461 (platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
2463 2013-05-06 Andy Estes <aestes@apple.com>
2465 Added two files I neglected to commit in r149589.
2467 * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2468 * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2470 2013-05-04 Andy Estes <aestes@apple.com>
2472 REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
2473 https://bugs.webkit.org/show_bug.cgi?id=115609
2475 Reviewed by Oliver Hunt.
2479 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2480 * TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
2481 (+[TestDelegate shared]):
2482 (-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2483 (-[TestDelegate webView:createWebViewWithRequest:]):
2485 (TestWebKitAPI::TEST):
2486 * TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2488 2013-05-06 Antoine Quint <graouts@apple.com>
2490 Manage the presentation of the snapshotted plug-in using JavaScript
2491 https://bugs.webkit.org/show_bug.cgi?id=115548
2493 Reviewed by Dean Jackson.
2495 Take into account the new plugInExtraScript method added to support
2496 the injection of a JS file from the chrome client to customize the
2497 rendering of a snapshotted plug-in's shadow tree.
2499 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2500 (WTR::InjectedBundlePage::InjectedBundlePage):
2502 2013-05-05 Anders Carlsson <andersca@apple.com>
2504 Remove the Vector::append overload that takes a Vector
2505 https://bugs.webkit.org/show_bug.cgi?id=115535
2507 Reviewed by Andreas Kling.
2509 Use Vector::appendVector instead.
2511 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2512 (concatenateAttributeAndValue):
2513 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2514 (WTR::concatenateAttributeAndValue):
2516 2013-05-04 Sam Weinig <sam@webkit.org>
2518 REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
2519 <rdar://problem/13702008>
2520 https://bugs.webkit.org/show_bug.cgi?id=115607
2522 Reviewed by Benjamin Poulain.
2524 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2525 * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
2526 (TestWebKitAPI::didFinishLoadForFrame):
2527 (TestWebKitAPI::TEST):
2528 Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
2530 2013-05-04 Zan Dobersek <zdobersek@igalia.com>
2534 * Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
2536 2013-05-04 Mihnea Ovidenie <mihnea@adobe.com>
2538 Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
2540 * Scripts/webkitpy/common/config/contributors.json:
2542 2013-05-04 Zan Dobersek <zdobersek@igalia.com>
2544 [GTK] Catch select.error exceptions in parse_output_lines
2545 https://bugs.webkit.org/show_bug.cgi?id=115253
2547 Reviewed by Gustavo Noronha Silva.
2549 Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
2550 output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
2551 builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
2552 error code and the error message) and the loop is re-entered.
2555 (parse_output_lines):
2557 2013-05-04 Zan Dobersek <zdobersek@igalia.com>
2559 [GTK] Set up the TestWebCore in TestWebKitAPI
2560 https://bugs.webkit.org/show_bug.cgi?id=115237
2562 Reviewed by Gustavo Noronha Silva.
2564 Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2565 Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2566 a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2567 either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2568 shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2570 * TestWebKitAPI/GNUmakefile.am:
2572 2013-05-03 Rebecca Hauck <rhauck@adobe.com>
2574 Create a script to import W3C tests
2575 https://bugs.webkit.org/show_bug.cgi?id=111513
2577 Reviewed by Dirk Pranke.
2579 Script to automate the import of W3C tests into WebKit.
2580 For the full description of how it works, see the comments
2581 at the top of test_importer.py.
2583 * Scripts/import-w3c-tests: Added.
2584 * Scripts/webkitpy/w3c/__init__.py: Added.
2585 * Scripts/webkitpy/w3c/test_converter.py: Added.
2587 (TestConverter.__init__):
2588 (TestConverter.load_prefixed_prop_list):
2589 (TestConverter.load_file):
2590 (TestConverter.convert_for_webkit):
2591 (TestConverter.convert_testharness_paths):
2592 (TestConverter.convert_prefixed_properties):
2593 (TestConverter.scrub_unprefixed_props):
2594 (TestConverter.replace_tag):
2595 * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2596 (TestConverterTest):
2597 (TestConverterTest.testLoadPrefixedPropList):
2598 (TestConverterTest.test_convertForWebkitNothingToConvert):
2599 (test_convertForWebkitHarnessOnly):
2600 (test_convertForWebkitPropsOnly):
2601 (test_convertForWebkitHarnessAndProps):
2602 (test_convertTestHarnessPaths):
2603 (test_convertPrefixedProperties):
2604 (verifyTestHarnessPaths):
2605 (verifyPrefixedProperties):
2606 (generateTestContent):
2607 * Scripts/webkitpy/w3c/test_importer.py: Added.
2610 (validate_import_directory):
2612 (TestImporter.__init__):
2613 (TestImporter.do_import):
2614 (TestImporter.get_changeset):
2615 (TestImporter.scan_source_directory):
2616 (TestImporter.import_tests):
2617 (TestImporter.setup_destination_directory):
2618 (TestImporter.get_test_status):
2619 (TestImporter.remove_deleted_files):
2620 (TestImporter.write_import_log):
2621 * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2623 (TestImporterTest.test_ImportDirWithNoTests):
2624 * Scripts/webkitpy/w3c/test_parser.py: Added.
2626 (TestParser.__init__):
2627 (TestParser.load_file):
2628 (TestParser.analyze_test):
2629 (TestParser.get_reftests):
2630 (TestParser.is_jstest):
2631 (TestParser.get_support_files):
2632 * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2634 (TestParserTest.test_analyzeTestReftestOneMatch):
2635 (test_analyzeTestReftestMultipleMatches):
2636 (test_analyzeTestReftestMatchAndMismatch):
2637 (test_analyzeTestReftestWithRefSupportFiles):
2638 (test_analyzeJSTest):
2639 (test_analyzePixelTestAllTrue):
2640 (test_analyzePixelTestAllFalse):
2641 (test_analyzeNonHTMLFile):
2643 2013-05-03 Christophe Dumez <ch.dumez@sisa.samsung.com>
2645 Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
2647 * Scripts/webkitpy/common/config/contributors.json:
2649 2013-05-02 Nico Weber <thakis@chromium.org>
2651 Remove a stale script file.
2652 https://bugs.webkit.org/show_bug.cgi?id=115521
2654 Reviewed by Anders Carlsson.
2656 This script was added in
2657 https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
2658 Bakefile system that was removed in
2659 https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
2660 script just asserts when it's run and is useless.
2662 * Scripts/update-sources-list.py: Removed.
2664 2013-05-01 Glenn Adams <glenn@skynav.com>
2666 [webkitpy] Need abstract base class for commands that analyze commit logs
2667 https://bugs.webkit.org/show_bug.cgi?id=115391
2669 Reviewed by Benjamin Poulain.
2671 Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
2672 in preparation for adding two new commands that will reuse this functionality along with
2673 suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
2674 https://bugs.webkit.org/show_bug.cgi?id=115388.
2676 No new tests as this patch does not change existing functionality or behavior.
2678 * Scripts/webkitpy/tool/commands/suggestnominations.py:
2679 (AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
2680 (AbstractCommitLogCommand.__init__):
2681 (AbstractCommitLogCommand._init_options):
2682 (AbstractCommitLogCommand._parse_commit_message):
2683 (SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
2684 (SuggestNominations.__init__):
2685 (SuggestNominations._init_options):
2687 2013-05-01 Seokju Kwon <seokju.kwon@gmail.com>
2689 Web Inspector: Fix check-inspector-strings script and fix localized strings
2690 https://bugs.webkit.org/show_bug.cgi?id=115495
2692 Reviewed by Joseph Pecoraro.
2694 * Scripts/check-inspector-strings:
2696 2013-05-01 Zan Dobersek <zdobersek@igalia.com>
2698 [TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
2699 https://bugs.webkit.org/show_bug.cgi?id=115470
2701 Reviewed by Martin Robinson.
2703 In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
2704 not building either of the IOS, Windows or GTK-WK1 platforms.
2706 Up until now the header was included for everything but the IOS and Windows platforms due to
2707 an incorrectly stated condition regarding the GTK platform.
2709 * TestWebKitAPI/config.h:
2711 2013-05-01 Zan Dobersek <zdobersek@igalia.com>
2713 [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
2714 https://bugs.webkit.org/show_bug.cgi?id=115469
2716 Reviewed by Martin Robinson.
2718 Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
2719 for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
2720 for the WebKit2 tests and the injected bundle required by them.
2722 This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
2723 tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
2724 under the WebKit2 code).
2726 The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
2727 while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
2728 TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
2730 * TestWebKitAPI/GNUmakefile.am:
2732 2013-04-30 Glenn Adams <glenn@skynav.com>
2734 Unreviewed. Add myself to watchlist entries.
2736 * Scripts/webkitpy/common/config/watchlist:
2738 2013-04-30 Glenn Adams <glenn@skynav.com>
2740 [webkitpy] suggest-nominations doesn't count all qualified patches
2741 https://bugs.webkit.org/show_bug.cgi?id=115285
2743 Reviewed by Benjamin Poulain.
2745 Fix commit analysis so that patches made by an existing committer are counted towards reviewer
2746 nomination. Improve commit log parsing.
2748 * Scripts/webkitpy/tool/commands/suggestnominations.py:
2750 (CommitLogError.__init__):
2751 (CommitLogMissingReviewer):
2752 (CommitLogMissingReviewer.__init__):
2753 (SuggestNominations):
2754 (SuggestNominations.__init__):
2755 (SuggestNominations._recent_commit_messages):
2756 (SuggestNominations._author_name_from_email):
2757 (SuggestNominations._contributor_from_email):
2758 (SuggestNominations._parse_commit_message):
2759 (SuggestNominations._count_commit):
2760 (SuggestNominations._count_recent_patches):
2761 (SuggestNominations._collect_nominations):
2762 (SuggestNominations._print_nominations):
2763 (SuggestNominations.execute):
2764 * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2766 (test_recent_commit_messages):
2769 2013-04-30 Commit Queue <rniwa@webkit.org>
2771 Unreviewed, rolling out r149309.
2772 http://trac.webkit.org/changeset/149309
2773 https://bugs.webkit.org/show_bug.cgi?id=115430
2775 The patch does not build on WK1-only builds of the GTK port
2776 (Requested by zdobersek on #webkit).
2778 * TestWebKitAPI/GNUmakefile.am:
2780 2013-04-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
2782 Stop using "in" keyword in IDL files
2783 https://bugs.webkit.org/show_bug.cgi?id=115418
2785 Reviewed by Kentaro Hara.
2787 Remove "in" keyword from IDL files as this is no longer part of the Web
2790 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2791 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
2792 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
2793 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2794 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2795 * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
2796 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2797 * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2799 2013-04-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
2801 [EFL] Enable scaled cursors
2802 https://bugs.webkit.org/show_bug.cgi?id=106242
2804 Reviewed by Gyuyoung Kim.
2806 Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
2808 * Scripts/webkitperl/FeatureList.pm:
2810 2013-04-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
2812 Replace "Optional" extended attribute by proper Web IDL "optional" keyword
2813 https://bugs.webkit.org/show_bug.cgi?id=115380
2815 Reviewed by Kentaro Hara.
2817 Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
2820 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2821 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2823 2013-04-30 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
2825 Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
2826 https://bugs.webkit.org/show_bug.cgi?id=114684
2828 Reviewed by Simon Hausmann.
2830 Remove the ANGLE requirement for USE(3D_GRAPHICS).
2831 This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
2833 * qmake/mkspecs/features/features.prf:
2835 2013-04-29 Zan Dobersek <zdobersek@igalia.com>
2837 [GTK] Disable Shadow DOM feature
2838 https://bugs.webkit.org/show_bug.cgi?id=115374
2840 Reviewed by Martin Robinson.
2842 Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
2844 * Scripts/webkitperl/FeatureList.pm:
2846 2013-04-29 Glenn Adams <glenn@skynav.com>
2848 [webkitpy] Add missing contributor email addresses
2849 https://bugs.webkit.org/show_bug.cgi?id=115394
2851 Reviewed by Ryosuke Niwa.
2853 * Scripts/webkitpy/common/config/contributors.json:
2855 2013-04-29 Alberto Garcia <agarcia@igalia.com>
2857 Remove all remaining Skia code
2858 https://bugs.webkit.org/show_bug.cgi?id=115263
2860 Reviewed by Benjamin Poulain.
2862 Remove all remaining references to Skia.
2864 * Scripts/webkitdirs.pm:
2865 (blackberryCMakeArguments):
2866 * Scripts/webkitpy/common/config/contributionareas.py:
2867 * Scripts/webkitpy/common/config/watchlist:
2869 2013-04-29 Seokju Kwon <seokju.kwon@gmail.com>
2871 Get rid of unused options in Tools/Scripts/webkit-build-directory
2872 https://bugs.webkit.org/show_bug.cgi?id=115383
2874 Reviewed by Darin Adler.
2876 * Scripts/webkit-build-directory:
2878 2013-04-29 Alexey Proskuryakov <ap@apple.com>
2880 [WK2][Mac] Test with NetworkProcess enabled.
2882 Fix the build for non-Mac.
2884 * WebKitTestRunner/TestController.cpp:
2885 (WTR::TestController::initialize):
2887 2013-04-29 Alexey Proskuryakov <ap@apple.com>
2889 [WK2][Mac] Test with NetworkProcess enabled.
2891 Reviewed by Sam Weinig.
2893 * WebKitTestRunner/TestController.cpp:
2894 (WTR::TestController::initialize):
2896 2013-04-29 Zan Dobersek <zdobersek@igalia.com>
2898 [GTK] Set up the TestWebCore in TestWebKitAPI
2899 https://bugs.webkit.org/show_bug.cgi?id=115237
2901 Reviewed by Gustavo Noronha Silva.
2903 Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
2904 Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
2905 a workaround for the layer violations and circular dependencies between various static libraries. Linking against
2906 either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
2907 shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
2909 * TestWebKitAPI/GNUmakefile.am:
2911 2013-04-29 Zan Dobersek <zdobersek@igalia.com>
2913 [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
2914 https://bugs.webkit.org/show_bug.cgi?id=115236
2916 Reviewed by Gustavo Noronha Silva.
2918 Set up the TestJavaScriptCore unit test program, consisting of the unit tests
2919 under the TestWebKitAPI/Tests/JavaScriptCore directory.
2921 * TestWebKitAPI/GNUmakefile.am:
2923 2013-04-29 Zan Dobersek <zdobersek@igalia.com>
2925 [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
2926 https://bugs.webkit.org/show_bug.cgi?id=115323
2928 Reviewed by Philippe Normand.
2930 Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
2931 Its presence enforces linkers to output mangled symbols when reporting linking failures
2932 due to unresolved references. People trying to fix the build can then simply copy
2933 the printed mangled symbol into the symbols.filter file instead of doing a manual build
2934 or connecting to the builders to discover the mangled version of the missing symbol.
2936 * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2938 2013-04-28 Zan Dobersek <zdobersek@igalia.com>
2940 Remove Chromium code from Tools/BuildSlaveSupport
2941 https://bugs.webkit.org/show_bug.cgi?id=115325
2943 Reviewed by Benjamin Poulain.
2945 Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
2946 covering archiving test results and built products.
2948 * BuildSlaveSupport/built-product-archive:
2949 (archiveBuiltProduct):
2950 (extractBuiltProduct):
2951 * BuildSlaveSupport/chromium/output-android-device-status: Removed.
2952 * BuildSlaveSupport/chromium/remove-crash-logs: Removed.
2953 * BuildSlaveSupport/test-result-archive:
2954 (archiveTestResults):
2956 2013-04-28 Seokju Kwon <seokju.kwon@gmail.com>
2958 Remove support for Chromium from webkitdirs.pm
2959 https://bugs.webkit.org/show_bug.cgi?id=115338
2961 Reviewed by Darin Adler.
2963 * Scripts/webkitdirs.pm:
2964 (determineBaseProductDir):
2965 (argumentsForConfiguration):
2966 (builtDylibPathForName):
2970 2013-04-28 Zan Dobersek <zdobersek@igalia.com>
2972 Rename TestRunner's setAudioData to setAudioResult
2973 https://bugs.webkit.org/show_bug.cgi?id=115326
2975 Reviewed by Darin Adler.
2977 Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
2978 than the previous one. The change is a simple rename, there's no change in the method's functionality. The
2979 affected tests are adjusted accordingly.
2981 * DumpRenderTree/qt/TestRunnerQt.cpp:
2982 (TestRunnerQt::setAudioResult):
2983 * DumpRenderTree/qt/TestRunnerQt.h:
2985 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2986 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2987 (WTR::TestRunner::setAudioResult):
2988 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2991 2013-04-28 Zan Dobersek <zdobersek@igalia.com>
2993 [WKTR] Tests dumping audio data shouldn't dump pixels
2994 https://bugs.webkit.org/show_bug.cgi?id=115270
2996 Reviewed by Benjamin Poulain.
2998 Prevent dumping the pixel output when Web Audio tests are dumping output data
2999 as the testing output. Pixel output in these tests has no real meaning and is
3000 as such unnecessary.
3002 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3003 (WTR::TestRunner::setAudioData):
3005 2013-04-27 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
3007 [EFL] Unreviewed Intel bots fix after r149231.
3009 * efl/jhbuild.modules: Disable the libxml Python bindings since the
3010 bots don't have Python's development files installed. libxml should
3011 detect this kind of thing better.
3013 2013-04-26 Ryuan Choi <ryuan.choi@samsung.com>
3015 [EFL] Build break using jhbuild on ubuntu 13.04
3016 https://bugs.webkit.org/show_bug.cgi?id=115225
3018 Reviewed by Gyuyoung Kim.
3020 libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
3021 libxml 2.9.0 has a bug to make regression which r138422 mentioned.
3022 So this patch bumped libxml version to 2.9.1.
3024 * efl/jhbuild.modules:
3026 2013-04-26 Jeffrey Pfau <jpfau@apple.com>
3028 delete-stale-build-files does not clear .d files
3029 http://bugs.webkit.org/show_bug.cgi?id=115293
3031 Reviewed by Ryosuke Niwa.
3033 * BuildSlaveSupport/delete-stale-build-files:
3034 (main): Add .d to the file type list
3036 2013-04-26 Roger Fong <roger_fong@apple.com>
3038 Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
3039 Make the DebugSuffix configuration use _debug dependencies.
3041 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3042 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
3043 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
3044 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
3045 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3046 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3047 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
3048 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
3049 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
3050 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3051 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
3052 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
3053 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3054 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3055 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3056 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
3057 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
3058 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
3059 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3060 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
3061 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
3062 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
3063 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3064 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
3065 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3066 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
3067 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
3068 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3069 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
3070 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
3071 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
3072 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
3073 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3074 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
3075 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3076 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3077 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3078 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
3079 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3080 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
3081 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3082 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3083 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3084 * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
3085 * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
3086 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3087 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
3088 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
3089 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
3090 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3091 * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
3092 * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3093 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3094 * win/AssembleBuildLogs/AssembleLogs.cmd:
3095 * win/record-memory/record-memory.vcxproj:
3096 * win/record-memory/record-memoryDebug.props:
3097 * win/record-memory/record-memoryDebugWinCairo.props:
3098 * win/record-memory/record-memoryProduction.props:
3099 * win/record-memory/record-memoryRelease.props:
3100 * win/record-memory/record-memoryReleaseWinCairo.props:
3102 2013-04-26 Zan Dobersek <zdobersek@igalia.com>
3104 [GTK] Clean up the TestWebKitAPI GNUmakefile.am
3105 https://bugs.webkit.org/show_bug.cgi?id=115233
3107 Reviewed by Martin Robinson.
3109 Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
3110 WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
3111 Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
3112 Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
3113 be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
3115 * TestWebKitAPI/GNUmakefile.am:
3117 2013-04-25 Andy Estes <aestes@apple.com>
3119 [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
3120 https://bugs.webkit.org/show_bug.cgi?id=115223
3122 Reviewed by Darin Adler.
3126 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
3127 * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
3128 (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
3129 when it loads a request with a custom protocol.
3130 * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
3131 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
3132 NSURLProtocol subclass to TestProtocol.{h, mm} and did some
3133 miscellaneous cleanup.
3134 * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
3135 * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
3136 (+[TestProtocol canInitWithRequest:]):
3137 (+[TestProtocol canonicalRequestForRequest:]):
3138 (+[TestProtocol requestIsCacheEquivalent:toRequest:]):
3139 (+[TestProtocol scheme]):
3140 (-[TestProtocol startLoading]):
3141 (-[TestProtocol stopLoading]):
3143 2013-04-26 Martin Robinson <mrobinson@igalia.com>
3145 Remove the remaining Skia #ifdefs
3146 https://bugs.webkit.org/show_bug.cgi?id=114886
3148 Reviewed by Benjamin Poulain.
3150 * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3151 (createBitmapContextFromWebView): Remove Skia #ifdef references.
3153 2013-04-26 Mary Wu <mary.wu@torchmobile.com.cn>
3155 [BlackBerry] Clean up load interface in WebPage
3156 https://bugs.webkit.org/show_bug.cgi?id=113267
3158 Reviewed by Rob Buis.
3160 Update DumpRenderTree with change of load() interface in WebPage.
3161 RIM Bug# 315535, internally reviewed by Joe Mason.
3163 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3164 (BlackBerry::WebKit::DumpRenderTree::runTest):
3166 2013-04-26 Zan Dobersek <zdobersek@igalia.com>
3168 Remove the HeapGraphSerializer unit test
3169 https://bugs.webkit.org/show_bug.cgi?id=115231
3171 Reviewed by Andreas Kling.
3173 Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
3174 specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
3176 * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
3178 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
3180 Remove support for Chromium from build/update scripts
3181 https://bugs.webkit.org/show_bug.cgi?id=115218
3183 Reviewed by Darin Adler.
3185 * Scripts/build-webkit:
3187 * Scripts/update-webkit:
3189 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
3191 Remove support for Chromium from api-test
3192 https://bugs.webkit.org/show_bug.cgi?id=115211
3194 Reviewed by Dirk Pranke.
3196 * Scripts/build-api-tests:
3197 * Scripts/run-api-tests:
3198 (isSupportedPlatform):
3200 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
3202 Get rid of Chromium in build-dumprendertree
3203 https://bugs.webkit.org/show_bug.cgi?id=115212
3205 Reviewed by Dirk Pranke.
3207 * Scripts/build-dumprendertree:
3209 2013-04-25 Alexey Proskuryakov <ap@apple.com>
3211 Pass relatedPage when creating a page in WebKitTestRunner
3212 https://bugs.webkit.org/show_bug.cgi?id=115206
3214 Reviewed by Geoffrey Garen.
3216 To make sure that window.open() opens in the same process even when using multiple processes.
3218 * WebKitTestRunner/PlatformWebView.h:
3219 * WebKitTestRunner/TestController.cpp:
3220 (WTR::TestController::createOtherPage):
3221 (WTR::TestController::createWebViewWithOptions):
3222 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3223 (WTR::PlatformWebView::PlatformWebView):
3224 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3225 (WTR::PlatformWebView::PlatformWebView):
3226 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3227 (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
3228 (WTR::PlatformWebView::PlatformWebView):
3229 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3230 (WTR::PlatformWebView::PlatformWebView):
3231 * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3232 (WTR::PlatformWebView::PlatformWebView):
3234 2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
3236 Fix autocompletion for Benjamin. The Bugzilla email address must come first.
3238 * Scripts/webkitpy/common/config/contributors.json:
3240 2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
3242 Build fix. Forgot to merge args.
3244 * Scripts/webkitpy/tool/bot/irc_command.py:
3247 2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
3249 webkitbot should recognize its own nickname in greetings.
3250 https://bugs.webkit.org/show_bug.cgi?id=115196
3252 Reviewed by Andreas Kling.
3254 Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
3256 * Scripts/webkitpy/tool/bot/irc_command.py:
3259 2013-04-25 Xavier Castano <xcastanho@igalia.com>
3261 [GTK] Tools/gtk/install-dependencies added ragel dependency
3262 https://bugs.webkit.org/show_bug.cgi?id=115163
3264 Reviewed by Xan Lopez.
3266 The install-dependencies script was missing a dependency on ragel
3267 which is expected when building HarfBuzz.
3269 * gtk/install-dependencies: Added a dependency on ragel for both
3272 2013-04-25 Eduardo Lima Mitev <elima@igalia.com>
3274 [GTK] Remove pango from optional jhbuild dependencies
3275 https://bugs.webkit.org/show_bug.cgi?id=115162
3277 Reviewed by Martin Robinson.
3279 Pango is not needed since revision r148293 that lowers the pango
3280 dependency to 1.30, which is available in most distributions.
3282 * gtk/jhbuild-optional.modules: Removes description of pango module.
3284 2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
3286 Remove Chromium-specific cases from FeatureList.pm
3287 https://bugs.webkit.org/show_bug.cgi?id=115169
3289 Reviewed by Andreas Kling.
3291 * Scripts/webkitperl/FeatureList.pm:
3293 2013-04-24 Seokju Kwon <seokju.kwon@gmail.com>
3295 Remove checking chromium from run-webkit-tests
3296 https://bugs.webkit.org/show_bug.cgi?id=115139
3298 Reviewed by Benjamin Poulain.
3300 * Scripts/run-webkit-tests:
3301 (useNewRunWebKitTests):
3303 2013-04-24 Simon Fraser <simon.fraser@apple.com>
3305 Pixel tests in SVG are all broken in WK2
3306 https://bugs.webkit.org/show_bug.cgi?id=114218
3308 Reviewed by Darin Adler.
3310 Window snapshots in WebKitTestRunner on Mac are window-sized
3311 (800x600), which is wrong for the W3C SVG tests that require a
3314 Fix by resizing the window, as well as the web view in
3315 PlatformWebView::resizeTo() so that window snapshots are correctly
3318 Also do some drive-by cleanup of the window size constants in both
3319 DRT and WTR to remove magic numbers, and make the code more similar.
3321 * DumpRenderTree/TestRunner.cpp:
3322 (TestRunner::setShouldPaintBrokenImage):
3323 * DumpRenderTree/TestRunner.h:
3324 * DumpRenderTree/efl/DumpRenderTree.cpp:
3325 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3326 (webInspectorShowWindow):
3327 * DumpRenderTree/mac/DumpRenderTree.mm:
3328 (createWebViewAndOffscreenWindow):
3329 (sizeWebViewForCurrentTest):
3330 * DumpRenderTree/mac/DumpRenderTreeMac.h:
3331 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3332 (createPagedBitmapContext):
3333 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3334 (DumpRenderTree::DumpRenderTree):
3335 (DumpRenderTree::open):
3336 * DumpRenderTree/qt/TestRunnerQt.cpp:
3337 * DumpRenderTree/qt/TestRunnerQt.h:
3338 * DumpRenderTree/win/DumpRenderTree.cpp:
3339 (sizeWebViewForCurrentTest):
3340 * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3341 * WebKitTestRunner/TestController.cpp:
3342 (WTR::TestController::resetStateToConsistentValues):
3343 * WebKitTestRunner/TestController.h:
3344 * WebKitTestRunner/TestInvocation.cpp:
3345 (WTR::sizeWebViewForCurrentTest):
3346 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3347 (WTR::PlatformWebView::PlatformWebView):
3348 (WTR::PlatformWebView::resizeTo):
3350 2013-04-24 Byungwoo Lee <bw80.lee@samsung.com>
3352 [EFL] Fix build error after r148963.
3353 https://bugs.webkit.org/show_bug.cgi?id=115126
3355 Reviewed by Laszlo Gombos.
3357 Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
3359 * TestWebKitAPI/PlatformEfl.cmake:
3361 2013-04-24 Carlos Garcia Campos <cgarcia@igalia.com>
3363 [GTK] Use stamp files for generate-forwarding-headers makefile rules
3364 https://bugs.webkit.org/show_bug.cgi?id=115118
3366 Reviewed by Martin Robinson.
3368 Use a stamp file for the TestWebKitAPI and WebKitTestRunner
3369 forwarding generator rules and don't call it for soup since there
3370 aren't soup directories in TestWebKitAPI and WebKitTestRunner.
3372 * TestWebKitAPI/GNUmakefile.am:
3373 * WebKitTestRunner/GNUmakefile.am:
3375 2013-04-24 Simon Pena <simon.pena@samsung.com>
3377 [GTK] Update build dependencies
3378 https://bugs.webkit.org/show_bug.cgi?id=115111
3380 Reviewed by Martin Robinson.
3382 The install-dependencies script was missing a dependency on EGL,
3383 which is expected when building Cairo.
3385 * gtk/install-dependencies: Added a dependency on libegl1-mesa
3386 for both apt and yum.
3388 2013-04-24 Seokju Kwon <seokju.kwon@gmail.com>
3390 Remove the Chromium-specific helper from run_webkit_tests.py
3391 https://bugs.webkit.org/show_bug.cgi?id=114996
3393 Reviewed by Dirk Pranke.
3395 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3398 2013-04-24 Sergio Correia <sergio.correia@openbossa.org>
3400 [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
3401 https://bugs.webkit.org/show_bug.cgi?id=114850
3403 Reviewed by Andreas Kling.
3405 Revision r148312 fixed WebPageProxy cleanup and also changed the process
3406 termination semantics when requested by the user so that a client is not
3407 notified of a crash anymore, since there was no crash anyway.
3409 That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
3410 relied on being notified of a crash after calling WKPageTerminate(). As
3411 a result of not being notified of such non-existent crash, the test would
3412 timeout right after making the terminate call.
3414 This patch adds an InjectedBundle to be used for simulating a crash, by
3415 calling abort() upon receiving a "Crash" message, and thus we are able to
3416 keep testing the crash callback.
3418 This patch also re-enables the WKViewClientWebProcessCallbacks test, which
3419 had been disabled in revisions r148858 and r148855, since it was failing.
3421 * TestWebKitAPI/PlatformEfl.cmake:
3422 * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3423 (TestWebKitAPI::TEST):
3424 * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
3426 (WKViewClientWebProcessCallbacksTest):
3427 (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
3428 (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
3430 2013-04-24 Christophe Dumez <ch.dumez@sisa.samsung.com>
3432 [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
3433 https://bugs.webkit.org/show_bug.cgi?id=115095
3435 Reviewed by Antonio Gomes.
3437 Use different subfolders under DumpRenderTree Temp folder for every
3438 functionality (icon database, cache, localstorage, ...). This makes
3439 sure there is no conflict between the functionalities.
3441 In EFL's case, libsoup cache was causing problems for the icon
3442 database if sharing the same folder.
3444 * WebKitTestRunner/TestController.cpp:
3445 (WTR::TestController::initialize):
3447 == Rolled over to ChangeLog-2013-04-24 ==