1f0ea379bf14674cbca0e9750c6b3b7447200f0b
[WebKit-https.git] / Tools / ChangeLog
1 2015-02-16  Antti Koivisto  <antti@apple.com>
2
3         Develop/Disable Caches does not properly disable disk cache
4         https://bugs.webkit.org/show_bug.cgi?id=141636
5
6         Reviewed by Anders Carlsson.
7
8         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
9         the network process too.
10
11         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
12
13         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
14         (WTR::InjectedBundle::beginTesting):
15         (WTR::InjectedBundle::setCacheModel):
16         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
17         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
18
19             Forward to TestController.
20
21         (WTR::TestRunner::setCacheModel):
22         * WebKitTestRunner/TestInvocation.cpp:
23         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
24
25 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
26
27         Unreviewed. Add myself as a committer.
28
29         * Scripts/webkitpy/common/config/contributors.json:
30
31 2015-02-15  David Kilzer  <ddkilzer@apple.com>
32
33         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
34         <http://webkit.org/b/141607>
35
36         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
37         externals in Source/WebCore/Configurations/WebCore.unexp when
38         building with Xcode 5.x.
39         (readXcode5SymbolsToIgnore): Add.
40
41 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
42
43         [EFL] fix Evas GL engine error.
44         https://bugs.webkit.org/show_bug.cgi?id=141621
45
46         Reviewed by Gyuyoung Kim.
47
48         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
49
50         * MiniBrowser/efl/main.c:
51         (elm_main):
52
53 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
54
55         [buildbot] Enable run-api-tests on release Mac bots
56         https://bugs.webkit.org/show_bug.cgi?id=141518
57
58         Reviewed by Darin Adler.
59
60         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
61         (RunUnitTests):
62         (BuildFactory.__init__):
63         (TestFactory.__init__):
64         (BuildAndTestFactory.__init__):
65         (RunUnitTests.start): Deleted.
66         (unitTestsSupported): Deleted.
67
68 2015-02-13  Anders Carlsson  <andersca@apple.com>
69
70         Add a move constructor and move assignment operator to Deque
71         https://bugs.webkit.org/show_bug.cgi?id=141571
72
73         Reviewed by Andreas Kling.
74
75         * TestWebKitAPI/Tests/WTF/Deque.cpp:
76         (TestWebKitAPI::TEST):
77
78 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
79
80         run-jsc-stress-tests --remote should skip profiler tests
81         https://bugs.webkit.org/show_bug.cgi?id=141470
82
83         Reviewed by Filip Pizlo.
84
85         * Scripts/run-jsc-stress-tests:
86
87 2015-02-13  Anders Carlsson  <andersca@apple.com>
88
89         Add an initializer list constructor to Deque
90         https://bugs.webkit.org/show_bug.cgi?id=141565
91
92         Reviewed by Andreas Kling.
93
94         * TestWebKitAPI/Tests/WTF/Deque.cpp:
95         (TestWebKitAPI::TEST):
96
97 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
98
99         [buildbot] Remove buildJSCTool cruft from master.cfg
100         https://bugs.webkit.org/show_bug.cgi?id=141513
101
102         Reviewed by Alexey Proskuryakov.
103
104         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
105         (RunJavaScriptCoreTests):
106         (RunJavaScriptCoreTests.start):
107         (RunWebKitTests):
108         (RunWebKitTests.start):
109         (TestFactory.__init__):
110         (TestLeaksFactory.__init__):
111         (RunJavaScriptCoreTests.__init__): Deleted.
112         (RunWebKitTests.__init__): Deleted.
113
114 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
115
116         Unreviewed, remove empty directories.
117
118         * DumpRenderTree/gtk: Removed.
119         * DumpRenderTree/gtk/fonts: Removed.
120         * DumpRenderTree/unix: Removed.
121         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
122         * GtkLauncher: Removed.
123         * TestWebKitAPI/Tests/WebKitGtk: Removed.
124         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
125         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
126         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
127
128 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
129
130         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
131         https://bugs.webkit.org/show_bug.cgi?id=141519
132
133         Reviewed by Alexey Proskuryakov.
134
135         * Scripts/build-webkittestrunner:
136
137 2015-02-12  Alex Christensen  <achristensen@webkit.org>
138
139         Removed empty directory.
140
141         * WinCELauncher: Removed.
142
143 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
144
145         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
146         https://bugs.webkit.org/show_bug.cgi?id=141202
147
148         Reviewed by Darin Adler.
149
150         * Scripts/run-jsc-stress-tests:
151
152 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
153
154         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
155         https://bugs.webkit.org/show_bug.cgi?id=141517
156
157         Reviewed by Anders Carlsson.
158
159         We do not need to locate or use the DLL's that came with Safari, so stop
160         failing when we cannot find them. Also remove some old Qt cruft from this
161         script.
162
163         * BuildSlaveSupport/built-product-archive:
164         (archiveBuiltProduct): 
165         (extractBuiltProduct):
166
167 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
168
169         [Win] [64-bit] Work around MSVC2013 Runtime Bug
170         https://bugs.webkit.org/show_bug.cgi?id=141498
171         <rdar://problem/19803642>
172
173         Reviewed by Anders Carlsson.
174
175         Disable FMA3 instruction use in the MSVC math library to
176         work around a VS2013 runtime crash. We can remove this
177         workaround when we switch to VS2015.
178
179         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
180         disable FMA3 support.
181         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
182         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
183         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
184         * Scripts/webkitperl/httpd.pm: Ditto.
185         * TestWebKitAPI/win/main.cpp: Ditto.
186         * WinLauncher/Common.cpp: Ditto.
187         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
188
189 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
190
191         run-jsc-stress-tests should accept remote host config from JSON file
192         https://bugs.webkit.org/show_bug.cgi?id=141509
193
194         Reviewed by Michael Saboff.
195
196         * Scripts/run-javascriptcore-tests:
197         (runJSCStressTests):
198         * Scripts/run-jsc-stress-tests:
199
200 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
201
202         [GTK] Add API to allow overriding the default color chooser implementation
203         https://bugs.webkit.org/show_bug.cgi?id=98935
204
205         Reviewed by Gustavo Noronha Silva.
206
207         Add a color chooser implementation for MiniBrowser using
208         GtkPopover when the GTK+ version is recent enough.
209         And a test case to check the new color chooser API.
210
211         * MiniBrowser/gtk/BrowserWindow.c:
212         (colorChooserRGBAChanged):
213         (popoverColorClosed):
214         (colorChooserRequestFinished):
215         (runColorChooserCallback):
216         (browserWindowConstructed):
217         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
218         (testWebViewColorChooserRequest):
219         (beforeAll):
220
221 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
222
223         Make run-jsc-stress-tests --remote work with make-based runner
224         https://bugs.webkit.org/show_bug.cgi?id=141079
225
226         Reviewed by Darin Adler.
227
228         * Scripts/run-javascriptcore-tests:
229         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
230         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
231         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
232         to avoid code duplication.
233
234 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
235
236         run-jsc-stress tests should detect the number of processors on the remote machine too
237         https://bugs.webkit.org/show_bug.cgi?id=141196
238
239         Reviewed by Darin Adler.
240
241         * Scripts/run-javascriptcore-tests:
242         (runJSCStressTests): Pass through the --child-processes argument.
243         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
244         to detect the number of local and remote processors with the same algorithm.
245         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
246         same as $numProcessors.
247
248 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
249
250         run-jsc-stress-tests should pass JSC_timeout to remote hosts
251         https://bugs.webkit.org/show_bug.cgi?id=141164
252
253         Reviewed by Darin Adler.
254
255         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
256
257         * Scripts/run-jsc-stress-tests:
258
259 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
260
261         [GTK] Add default color chooser implementation using GtkColorChooserDialog
262         https://bugs.webkit.org/show_bug.cgi?id=141392
263
264         Reviewed by Gustavo Noronha Silva.
265
266         Enable INPUT_TYPE_COLOR by default for GTK+ port.
267
268         * Scripts/webkitperl/FeatureList.pm:
269
270 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
271
272         run-jsc-stress-tests shell test runner should run tests in fixed order
273         https://bugs.webkit.org/show_bug.cgi?id=141383
274
275         Reviewed by Darin Adler.
276
277         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
278
279 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
280
281         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
282         https://bugs.webkit.org/show_bug.cgi?id=140485
283
284         Reviewed by Anders Carlsson.
285
286         Implement takeFocus() as a way to set focus through accessibility wrappers.
287
288         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
289         (AccessibilityUIElement::takeFocus):
290         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
291         (WTR::AccessibilityUIElement::takeFocus):
292
293 2015-02-08  Darin Adler  <darin@apple.com>
294
295         Remove the SVG instance tree
296         https://bugs.webkit.org/show_bug.cgi?id=140602
297
298         Reviewed by Dean Jackson.
299
300         * Scripts/check-for-global-initializers: Removed special case for
301         SVGElementInstance.o.
302
303 2015-02-07  David Kilzer  <ddkilzer@apple.com>
304
305         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
306         <http://webkit.org/b/141365>
307
308         Reviewed by Daniel Bates.
309
310         * Scripts/webkitpy/xcode/simulator.py:
311         (Simulator): Add unavailable_version_re precompiled regex.
312         (Simulator._parse_devices): Check for unavailable versions and
313         ignore them if found when parsing the output of
314         `xcrun simctl list`.
315         * Scripts/webkitpy/xcode/simulator_unittest.py:
316         (test_unavailable_devices): Add test with output from
317         `xcrun simctl list` with unavailable runtimes that fails before
318         the fix.
319
320 2015-02-07  Chris Dumez  <cdumez@apple.com>
321
322         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
323         https://bugs.webkit.org/show_bug.cgi?id=141321
324
325         Reviewed by Darin Adler.
326
327         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
328
329 2015-02-07  David Kilzer  <ddkilzer@apple.com>
330
331         [iOS] Make Simulator class testable
332         <http://webkit.org/b/141358>
333
334         Rubber-stamped by Darin Adler.
335
336         * Scripts/webkitpy/common/system/platforminfo.py:
337         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
338         command to here from Simulator.refresh() in xcode/simulator.py
339         so that the output of the command can be mocked.
340
341         * Scripts/webkitpy/common/system/platforminfo_mock.py:
342         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
343         to None.
344         (MockPlatformInfo.xcode_simctl_list): Add method that returns
345         self.expected_xcode_simctl_list expectation.
346
347         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
348         and license header.
349         (Simulator.__init__): Add optional 'host' parameter to make it
350         possible to pass in a mock object for testing.  Set self._host
351         to 'host' parameter or create Host() object.
352         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
353         method.
354
355         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
356         for current code.
357         (SimulatorTest):
358         (SimulatorTest.setUp):
359         (SimulatorTest._set_expected_xcrun_simctl_list):
360         (SimulatorTest.test_simulator_device_types):
361         (test_invalid_device_types_header):
362         (test_invalid_runtimes_header):
363         (test_invalid_devices_header):
364
365 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
366
367         run-jsc-stress-tests --remote should use the default ssh port
368         https://bugs.webkit.org/show_bug.cgi?id=141287
369
370         Reviewed by Darin Adler.
371
372         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
373
374 2015-02-06  Dana Burkart  <dburkart@apple.com>
375
376         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
377         https://bugs.webkit.org/show_bug.cgi?id=141349
378
379         Reviewed by Alexey Proskuryakov.
380
381         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
382         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
383         (BuildbotTesterQueueView.prototype.update):
384
385 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
386
387         Report network process crashes during layout tests
388         https://bugs.webkit.org/show_bug.cgi?id=139646
389
390         Reviewed by Anders Carlsson.
391
392         * WebKitTestRunner/TestController.cpp:
393         (WTR::TestController::initialize):
394         (WTR::TestController::networkProcessName):
395         (WTR::TestController::networkProcessDidCrash):
396         * WebKitTestRunner/TestController.h:
397
398 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
399
400         run-jsc-stress-tests --remote should create remote directory before copying the bundle
401         https://bugs.webkit.org/show_bug.cgi?id=141329
402
403         Reviewed by Michael Saboff.
404
405         * Scripts/run-jsc-stress-tests:
406
407 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
408
409         [GTK] Remove WebKitWebView::close-notification signal
410         https://bugs.webkit.org/show_bug.cgi?id=141330
411
412         Reviewed by Gustavo Noronha Silva.
413
414         Update notifications unit tests according to the API changes, and
415         add a test case to check that onclose event is fired when a
416         notification is closed by the user.
417
418         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
419         (testWebViewNotification):
420
421 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
422
423         Dashboard doesn't consider building ASan a productive step
424         https://bugs.webkit.org/show_bug.cgi?id=141312
425
426         Reviewed by Simon Fraser.
427
428         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
429
430 2015-02-05  Daniel Bates  <dabates@apple.com>
431
432         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
433         https://bugs.webkit.org/show_bug.cgi?id=141306
434
435         Reviewed by Alexey Proskuryakov.
436
437         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
438         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
439         existent runtime.
440
441         * Scripts/webkitpy/xcode/simulator.py:
442         (Runtime.from_identifier):
443
444 2015-02-05  Daniel Bates  <dabates@apple.com>
445
446         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
447         https://bugs.webkit.org/show_bug.cgi?id=139746
448         <rdar://problem/19283658>
449
450         Reviewed by Alexey Proskuryakov.
451
452         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
453         if the simulator device is not in state Booted.
454
455         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
456         launching/relaunching the iOS Simulator app and a simulator app can only be installed
457         on a device that is in the Booted state. LayoutTestRelay may run before the
458         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
459         We should defer executing LayoutTestRelay until the simulator device booted by
460         iOS Simulator is in the Booted state.
461
462         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
463         Simulator methods with the module name, simulator.
464         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
465         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
466         before launching iOS Simulator to boot it.
467         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
468         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
469         * Scripts/webkitpy/xcode/simulator.py:
470         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
471         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
472         interested in the state of the device are more likely interested in the current state of the device as
473         opposed to the state of the device when the Device object was created.
474         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
475         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
476         from both this function and Simulator.device_state().
477         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
478         (Simulator.DeviceState): Added; class of constants.
479         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
480         device is in the specified state.
481         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
482         (Simulator.device_directory): Added.
483         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
484
485 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
486
487         Disable retries on Mac debug testers
488         https://bugs.webkit.org/show_bug.cgi?id=141296
489
490         Reviewed by Simon Fraser.
491
492         * BuildSlaveSupport/build.webkit.org-config/config.json:
493
494 2015-02-05  Dan Bernstein  <mitz@apple.com>
495
496         Need a way to force $xcodeSDK in webkitdirs.pm
497         https://bugs.webkit.org/show_bug.cgi?id=141291
498
499         Reviewed by Anders Carlsson.
500
501         * Scripts/webkitdirs.pm:
502         (setXcodeSDK): Added.
503
504 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
505
506         [Streams API] Implement a barebone ReadableStream interface
507         https://bugs.webkit.org/show_bug.cgi?id=141045
508
509         Reviewed by Benjamin Poulain.
510
511         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
512
513 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
514
515         filter-build-webkit: reduce more unfiltered output
516         https://bugs.webkit.org/show_bug.cgi?id=141282
517
518         Reviewed by Daniel Bates.
519
520         * Scripts/filter-build-webkit:
521         Report CompileDTraceScript and Preprocess lines as successful.
522
523 2015-02-04  Dana Burkart  <dburkart@apple.com>
524
525         Botwatcher's Dashboard is cramped
526         https://bugs.webkit.org/show_bug.cgi?id=140273
527
528         Reviewed by Alexey Proskuryakov.
529
530         Add a heading key which will allow for arbitrary headings in builder queues.
531
532         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
533         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
534         (BuildbotBuilderQueueView.prototype.update):
535         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
536         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
537         (BuildbotIteration.prototype._parseData):
538         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
539         (BuildbotLeaksQueueView.prototype.update):
540         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
541         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
542         (BuildbotPerformanceQueueView.prototype.update):
543         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
544         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
545         (BuildbotQueue):
546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
547         (BuildbotQueueView.prototype._unauthorizedAccess):
548         (BuildbotQueueView.prototype._appendBuild):
549         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
550         (BuildbotTestResults):
551         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
552         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
553         (BuildbotTesterQueueView.prototype.update):
554         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
555
556 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
557
558         WKTR should not use -mainScreen to pick a color profile
559         https://bugs.webkit.org/show_bug.cgi?id=141265
560
561         Reviewed by Tim Horton.
562         
563         -[NSScreen mainScreen] depends on the active window, so use the first screen
564         (which is the one we put the window on anyway).
565         
566         Do some cleanup in DRT that makes the code look similar.
567
568         * DumpRenderTree/mac/DumpRenderTree.mm:
569         (createWebViewAndOffscreenWindow):
570         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
571         (WTR::PlatformWebView::PlatformWebView):
572
573 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
574
575         LayoutTestHelper should set the color profile of all displays
576         https://bugs.webkit.org/show_bug.cgi?id=141260
577
578         Reviewed by Tim Horton.
579         
580         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
581         which is the screen with the active window. Make things more robust by changing
582         the colorspace of all displays, not just the main screen, when running layout tests.
583
584         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
585         * DumpRenderTree/mac/LayoutTestHelper.m: 
586         (originalColorProfileURLs):
587         (colorProfileURLForDisplay):
588         (displayUUIDStrings):
589         (saveDisplayColorProfiles):
590         (setDisplayColorProfile):
591         (restoreDisplayColorProfiles):
592         (installLayoutTestColorProfile):
593         (restoreUserColorProfile):
594         (main):        
595         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
596         toll-free bridged, sadly). Use the map to restore all profiles on exit.
597         Convert to use more Obj-C types.
598
599 2015-02-04  Daniel Bates  <dabates@apple.com>
600
601         test-webkitpy fails on Mac without iphoneos SDK
602         https://bugs.webkit.org/show_bug.cgi?id=141255
603         <rdar://problem/19619691>
604
605         I inadvertently committed the wrong exception message. Fix up the exception message
606         to instruct a person to install the iOS SDK when it cannot be found.
607
608         * Scripts/webkitpy/port/ios.py:
609         (IOSPort.determine_full_port_name):
610
611 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
612
613         W3C test importer should sort the list of files when generating the w3c-import.log
614         https://bugs.webkit.org/show_bug.cgi?id=141156
615
616         Reviewed by Bem Jones-Bey.
617
618         Sort explicitly the list of imported files written in the w3c-import.log.
619         Removed logging of the import date.
620
621         * Scripts/webkitpy/w3c/test_importer.py:
622         (TestImporter.write_import_log):
623
624 2015-02-04  Daniel Bates  <dabates@apple.com>
625
626         test-webkitpy fails on Mac without iphoneos SDK
627         https://bugs.webkit.org/show_bug.cgi?id=141255
628         <rdar://problem/19619691>
629
630         Reviewed by David Kilzer and Alexey Proskuryakov.
631
632         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
633         should not require the iphoneos SDK to be installed to run the webkitpy tests.
634
635         * Scripts/webkitpy/common/system/platforminfo.py:
636         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
637         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
638         to standard output if the SDK is installed to return the empty string if the SDK is
639         not installed.
640         * Scripts/webkitpy/common/system/platforminfo_mock.py:
641         (MockPlatformInfo.xcode_sdk_version): Added.
642         * Scripts/webkitpy/port/ios.py:
643         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
644         to get the version of the iphoneos SDK, if installed.
645
646 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
647
648         run-webkit-tests doesn't always capture ASan violation reports
649         https://bugs.webkit.org/show_bug.cgi?id=141231
650
651         Reviewed by Darin Adler.
652
653         * Scripts/webkitpy/port/driver.py:
654         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
655         by the driver already (as is the case with ASan violations, which are printed to
656         stderr).
657         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
658         report.
659         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
660         a separate variable for reporting.
661
662 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
663
664         [webkitpy] Add platform specific Skipped file mechanism for performance tests
665         https://bugs.webkit.org/show_bug.cgi?id=141152
666
667         Reviewed by Csaba Osztrogonác.
668
669         Support a test-expectation-like syntax in performance tests' skipped files.
670         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
671
672         * Scripts/webkitpy/port/base.py:
673         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
674
675         * Scripts/webkitpy/port/base_unittest.py:
676         (PortTest.test_skipped_perf_tests): Test the new syntax.
677
678 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
679
680         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
681         https://bugs.webkit.org/show_bug.cgi?id=141236
682
683         Reviewed by Sam Weinig.
684
685         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
686         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
687
688 2015-02-04  Chris Dumez  <cdumez@apple.com>
689
690         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
691         https://bugs.webkit.org/show_bug.cgi?id=141192
692
693         Reviewed by Benjamin Poulain.
694
695         Add API tests for Vector::removeFirst(value) and
696         Vector::removeAll(value).
697
698         * TestWebKitAPI/Tests/WTF/Vector.cpp:
699         (TestWebKitAPI::TEST):
700
701 2015-02-03  Tim Horton  <timothy_horton@apple.com>
702
703         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
704         https://bugs.webkit.org/show_bug.cgi?id=141217
705
706         Reviewed by Sam Weinig.
707
708         * WebKitTestRunner/TestController.cpp:
709         (WTR::copyWebCryptoMasterKey):
710         (WTR::TestController::createOtherPage):
711         (WTR::TestController::createWebViewWithOptions):
712         (WTR::TestController::ensureViewSupportsOptions):
713         (WTR::TestController::didCommitNavigation):
714         (WTR::TestController::didFinishNavigation):
715         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
716         (WTR::TestController::didReceiveAuthenticationChallenge):
717         (WTR::TestController::decidePolicyForPluginLoad):
718         (WTR::TestController::decidePolicyForNavigationAction):
719         (WTR::TestController::decidePolicyForNavigationResponse):
720         (WTR::TestController::didCommitLoadForFrame): Deleted.
721         (WTR::TestController::didFinishLoadForFrame): Deleted.
722         * WebKitTestRunner/TestController.h:
723         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
724
725 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
726
727         Unreviewed. Add myself as a committer.
728
729         * Scripts/webkitpy/common/config/contributors.json:
730
731 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
732
733         [Win] Unreviewed test fix.
734
735         * DumpRenderTree/win/PolicyDelegate.cpp:
736         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
737         so was not matching expected output.
738
739 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
740
741         Unreviewed. Moving myself to the committer section at last.
742
743         * Scripts/webkitpy/common/config/contributors.json:
744
745 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
746
747         [Win] Tests fail because DRT reports '(null)' instead of an empty string
748         https://bugs.webkit.org/show_bug.cgi?id=141205
749
750         Reviewed by Anders Carlsson.
751
752         * DumpRenderTree/win/HistoryDelegate.cpp:
753         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
754         properly so that we match expected DumpRenderTree output.
755
756 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
757
758         [GTK] TestWebKitAccessibility is not skipped
759         https://bugs.webkit.org/show_bug.cgi?id=141179
760
761         Reviewed by Carlos Garcia Campos.
762
763         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
764         skipped, and it apparently works reliably on the bots.
765
766         * Scripts/run-gtk-tests:
767         (TestRunner):
768
769 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
770
771         run-perf-tests: allow to specify a wrapper command.
772         https://bugs.webkit.org/show_bug.cgi?id=141172
773
774         Reviewed by Ryosuke Niwa.
775
776         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
777         (parse_args): Update text to indicate is also valid for WTR.
778         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
779         (PerfTestsRunner._parse_args): Add wrapper command.
780
781 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
782
783         [Win] Correct version parsing warning in update-webkit
784         https://bugs.webkit.org/show_bug.cgi?id=141200
785
786         Reviewed by Anders Carlsson.
787
788         * Scripts/webkitdirs.pm:
789         (setupAppleWinEnv): Strip out any specific version build level
790         from the Cygwin version information.
791   
792
793 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
794
795         [Win] Attempt to improve the reliability of HTTP service
796         https://bugs.webkit.org/show_bug.cgi?id=141191
797
798         Reviewed by Darin Adler.
799
800         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
801         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
802         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
803         when stopping the service doesn't do so on its own (for Windows runs).
804
805 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
806
807         Web platform test server should not need to create __init__.py files
808         https://bugs.webkit.org/show_bug.cgi?id=141030
809
810         Reviewed by Ryosuke Niwa.
811
812         W3C TestImporter ensures that copied __init__.py files are not empty.
813         If needed, a comment is inserted in __init__.py files.
814         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
815
816         * Scripts/webkitpy/common/system/filesystem.py:
817         (FileSystem.getsize):
818         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
819         (TestWebPlatformTestServer.test_start_cmd):
820         (TestWebPlatformTestServer):
821         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
822         * Scripts/webkitpy/w3c/test_importer.py:
823         (TestImporter.import_tests):
824
825 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
826
827         Unreviewed. Moving myself to the committer section.
828
829         * Scripts/webkitpy/common/config/contributors.json:
830
831 2015-02-02  Saam Barati  <saambarati1@gmail.com>
832
833         Create tests for JSC's Control Flow Profiler
834         https://bugs.webkit.org/show_bug.cgi?id=141123
835
836         Reviewed by Filip Pizlo.
837
838         * Scripts/run-javascriptcore-tests:
839         (runJSCStressTests):
840         * Scripts/run-jsc-stress-tests:
841
842 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
843
844         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
845         https://bugs.webkit.org/show_bug.cgi?id=141158
846
847         Reviewed by Darin Adler.
848
849         * Scripts/run-jsc-stress-tests:
850
851 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
852
853         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
854         https://bugs.webkit.org/show_bug.cgi?id=141142
855
856         Reviewed by Carlos Garcia Campos.
857
858         * MiniBrowser/gtk/BrowserWindow.c:
859         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
860
861 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
862
863         Web platform test server is not always launching properly on Mac EWS bots
864         https://bugs.webkit.org/show_bug.cgi?id=141141
865
866         Unreviewed.
867
868         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
869         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
870
871 2015-01-31  Sam Weinig  <sam@webkit.org>
872
873         Remove even more Mountain Lion support
874         https://bugs.webkit.org/show_bug.cgi?id=141124
875
876         Reviewed by Alexey Proskuryakov.
877
878         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
879         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
880         * DumpRenderTree/mac/Configurations/Base.xcconfig:
881         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
882         * DumpRenderTree/mac/DumpRenderTree.mm:
883         (activateTestingFonts):
884         (prepareConsistentTestingEnvironment):
885         * DumpRenderTree/mac/EventSendingController.mm:
886         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
887         (-[EventSendingController contextClick]):
888         * DumpRenderTree/mac/TextInputController.m:
889         * LayoutTestRelay/Configurations/Base.xcconfig:
890         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
891         * MiniBrowser/Configurations/Base.xcconfig:
892         * MiniBrowser/Configurations/DebugRelease.xcconfig:
893         * MiniBrowser/mac/WK2BrowserWindowController.m:
894         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
895         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
896         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
897         * TestWebKitAPI/Configurations/Base.xcconfig:
898         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
899         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
900         (-[DownloadDelegate _downloadDidFinish:]):
901         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
902         (TestWebKitAPI::TEST):
903         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
904         (TestWebKitAPI::InjectedBundleController::platformInitialize):
905         * WebKitLauncher/Configurations/Base.xcconfig:
906         * WebKitTestRunner/Configurations/Base.xcconfig:
907         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
908         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
909         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
910         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
911         (WTR::activateFonts):
912         * WebKitTestRunner/TestController.cpp:
913         (WTR::TestController::initialize):
914         (WTR::TestController::webProcessName):
915         * WebKitTestRunner/mac/EventSenderProxy.mm:
916         * asan/asan.xcconfig:
917
918 2015-01-31  Commit Queue  <commit-queue@webkit.org>
919
920         Unreviewed, rolling out r179408.
921         https://bugs.webkit.org/show_bug.cgi?id=141117
922
923         This didn't fully fix the issue (Requested by anttik on
924         #webkit).
925
926         Reverted changeset:
927
928         "OSObjectPtr does not work with dispatch_data_t on Maverics"
929         https://bugs.webkit.org/show_bug.cgi?id=141081
930         http://trac.webkit.org/changeset/179408
931
932 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
933
934         https://trac.webkit.org/changeset/179439 breaks a python test
935         https://bugs.webkit.org/show_bug.cgi?id=141114
936
937         Unreviewed.
938
939         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
940         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
941
942 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
943
944         Import W3C web platform tests infrastructure
945         https://bugs.webkit.org/show_bug.cgi?id=140934
946
947         Reviewed by Ryosuke Niwa.
948
949         Loading necessary web platform tests modules before launching server.
950         Ensuring that some empty __init__.py files are present and create them if necessary. 
951
952         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
953         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
954
955 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
956
957         [Win] Another unreviewed test fix.
958
959         Correct copy/paste error in buildbot handling.
960
961         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
962         (LayoutTestApacheHttpd.__init__):
963         (LayoutTestApacheHttpd._get_apache_config_file_path):
964
965 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
966
967         [Win] Unreviewed test fix.
968
969         Correct path handling based on failures on test bots to get things running again.
970
971         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
972         (LayoutTestApacheHttpd.__init__):
973         (LayoutTestApacheHttpd._get_apache_config_file_path):
974
975 2015-01-30  Chris Dumez  <cdumez@apple.com>
976
977         Unreviewed. Fix Windows build after r179409.
978
979         * DumpRenderTree/win/TestRunnerWin.cpp:
980         (TestRunner::notifyDone):
981         (TestRunner::queueLoad):
982
983 2015-01-30  Chris Dumez  <cdumez@apple.com>
984
985         Rename shared() static member functions to singleton() for singleton classes.
986         https://bugs.webkit.org/show_bug.cgi?id=141088
987
988         Reviewed by Ryosuke Niwa and Benjamin Poulain.
989
990         Rename shared() static member functions to singleton() for singleton
991         classes as per the recent coding style change.
992
993 2015-01-30  Antti Koivisto  <antti@apple.com>
994
995         OSObjectPtr does not work with dispatch_data_t on Maverics
996         https://bugs.webkit.org/show_bug.cgi?id=141081
997
998         Reviewed by Pratik Solanki.
999
1000         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
1001         (TestWebKitAPI::TEST):
1002
1003 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
1004
1005         [Win] Switch to Apache on Windows
1006         https://bugs.webkit.org/show_bug.cgi?id=141060
1007
1008         Reviewed by Alexey Proskuryakov.
1009
1010         Update our scripts under Windows (and Cygwin) to locate and use
1011         the XAMPP installation of Apache for running tests.
1012
1013         * Scripts/run-webkit-httpd:
1014         * Scripts/webkitperl/httpd.pm:
1015         (getHTTPDPath):
1016         (getDefaultConfigForTestDirectory):
1017         (getHTTPDConfigPathForTestDirectory):
1018         * Scripts/webkitpy/common/system/executive_unittest.py:
1019         (ExecutiveTest.serial_test_kill_process):
1020         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1021         (LayoutTestApacheHttpd.__init__):
1022         (LayoutTestApacheHttpd._get_apache_config_file_path):
1023         (LayoutTestApacheHttpd._stop_running_server):
1024         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1025         (HttpServerBase._is_server_running_on_all_ports):
1026         * Scripts/webkitpy/port/base.py:
1027         (Port._apache_config_file_name_for_platform):
1028         * Scripts/webkitpy/port/port_testcase.py:
1029         (test_apache_config_file_name_for_platform):
1030         * Scripts/webkitpy/port/win.py:
1031         (WinPort.show_results_html_file):
1032         (WinPort._uses_apache):
1033         (WinPort):
1034         (WinPort._path_to_apache):
1035
1036 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
1037
1038         Built result takes too long to be compressed on bots
1039         https://bugs.webkit.org/show_bug.cgi?id=141056
1040
1041         Reviewed by Daniel Bates.
1042
1043         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
1044
1045         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
1046
1047 2015-01-29  Sam Weinig  <sam@webkit.org>
1048
1049         Remove support for screen font substitution
1050         https://bugs.webkit.org/show_bug.cgi?id=141038
1051
1052         Reviewed by Tim Horton.
1053
1054         * DumpRenderTree/win/DumpRenderTree.cpp:
1055         (resetWebPreferencesToConsistentValues):
1056         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
1057
1058 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1059
1060         Make run-jsc-stress-tests --remote work on Linux too
1061         https://bugs.webkit.org/show_bug.cgi?id=141000
1062
1063         Reviewed by Darin Adler.
1064
1065         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
1066         use bash/dash compatible signal names, use Linux/Mac compatible find options,
1067         use bash/dash compatible functions.
1068         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
1069
1070 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1071
1072         [buildbot] Simplify jscore-test buildstep
1073         https://bugs.webkit.org/show_bug.cgi?id=140821
1074
1075         Reviewed by Alexey Proskuryakov.
1076
1077         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1078         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
1079         (RunJavaScriptCoreTests.countFailures): Added.
1080         (RunJavaScriptCoreTests.commandComplete): Deleted.
1081         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
1082         (RunJavaScriptCoreTests.getText): Deleted.
1083         (RunJavaScriptCoreTests.getText2): Deleted.
1084         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
1085         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
1086         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
1087         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
1088         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
1089
1090 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
1091
1092         Unreviewed, revert r179337, we don't need this dependency.
1093
1094         * efl/install-dependencies:
1095         * gtk/install-dependencies:
1096
1097 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
1098
1099         Unreviewed. Moving myself to the committer section.
1100
1101         * Scripts/webkitpy/common/config/contributors.json:
1102
1103 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
1104
1105         URTBF after r179326, added uuid-dev package as new dependency.
1106
1107         * efl/install-dependencies:
1108         * gtk/install-dependencies:
1109
1110 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
1111
1112         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
1113         https://bugs.webkit.org/show_bug.cgi?id=140673
1114
1115         Reviewed by Sam Weinig.
1116
1117         * Scripts/dtrace/trace-webkit2-messages.d: Added.
1118         Add a DTrace script that outputs a small blob of JSON per message.
1119
1120 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
1121
1122         Removed fastMallocForbid / fastMallocAllow
1123         https://bugs.webkit.org/show_bug.cgi?id=141012
1124
1125         Reviewed by Mark Hahnenberg.
1126
1127         Fixed a test bug I noticed while testing.
1128
1129         * DumpRenderTree/JavaScriptThreading.cpp:
1130         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
1131         accessing javaScriptThreads -- otherwise, you'll ASSERT.
1132
1133 2015-01-28  Dana Burkart  <dburkart@apple.com>
1134
1135         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
1136         https://bugs.webkit.org/show_bug.cgi?id=141015
1137
1138         Reviewed by Alexey Proskuryakov.
1139
1140         * asan/asan.xcconfig:
1141
1142 2015-01-28  Sam Weinig  <sam@webkit.org>
1143
1144         Fix the build.
1145
1146         * Scripts/copy-webkitlibraries-to-product-directory:
1147
1148 2015-01-28  Lucas Forschler  <lforschler@apple.com>
1149
1150         Increase the FileUpload block size in an attempt to improve network performance.
1151         
1152         Reviewed by Alexey Proskuryakov.
1153         
1154         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1155         (UploadBuiltProduct.__init__):
1156
1157 2015-01-28  Dana Burkart  <dburkart@apple.com>
1158
1159         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
1160         https://bugs.webkit.org/show_bug.cgi?id=136765
1161
1162         Reviewed by Alexey Proskuryakov.
1163
1164         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1165         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1166         * LayoutTestRelay/Configurations/Base.xcconfig:
1167         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1168         * MiniBrowser/Configurations/Base.xcconfig:
1169         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1170         * TestWebKitAPI/Configurations/Base.xcconfig:
1171         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1172         * WebKitLauncher/Configurations/Base.xcconfig:
1173         * WebKitTestRunner/Configurations/Base.xcconfig:
1174         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1175
1176 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
1177
1178         AX: [ATK] Implement support for new AtkRole types for MathML
1179         https://bugs.webkit.org/show_bug.cgi?id=140916
1180
1181         Reviewed by Chris Fleizach.
1182
1183         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
1184         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
1185
1186 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1187
1188         [GTK] Stop removing color marks from unit tests output
1189         https://bugs.webkit.org/show_bug.cgi?id=140996
1190
1191         Reviewed by Philippe Normand.
1192
1193         Since r178236 google tests use a custom simplified output without
1194         any colors, so we don't need to handle the case of non ttys to
1195         remove the color marks.
1196
1197         * Scripts/run-gtk-tests:
1198         (TestRunner.__init__):
1199         (TestRunner._run_test_command.parse_line):
1200
1201 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1202
1203         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
1204         https://bugs.webkit.org/show_bug.cgi?id=131731
1205
1206         Reviewed by Žan Doberšek.
1207
1208         A web page loaded offscreen is in prerender state not hidden.
1209
1210         * Scripts/run-gtk-tests:
1211         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
1212         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1213         (testWebViewPageVisibility):
1214
1215 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1216
1217         Partially revert r178802.
1218
1219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
1220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
1221
1222 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1223
1224         build.webkit.org/dashboard asserts on some commits
1225         https://bugs.webkit.org/show_bug.cgi?id=140926
1226
1227         Reviewed by Tim Horton.
1228
1229         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1230         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
1231
1232 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1233
1234         Make flakiness dashboard OS list actually match test_expectations.py
1235         https://bugs.webkit.org/show_bug.cgi?id=140969
1236
1237         Reviewed by Ryosuke Niwa.
1238
1239         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1240
1241 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
1242
1243         [Win] WinLauncher crashes on eleventh site visited
1244         https://bugs.webkit.org/show_bug.cgi?id=140960
1245
1246         Reviewed by Anders Carlsson.
1247
1248         * WinLauncher/WinLauncher.cpp:
1249         (WinLauncher::showLastVisitedSites): Don't access off the end of
1250         the history array.
1251
1252 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1253
1254         [Mac] Disable building Java applets by default
1255         https://bugs.webkit.org/show_bug.cgi?id=140957
1256         rdar://problem/19619529
1257
1258         Reviewed by Anders Carlsson.
1259
1260         It was actually already disabled unconditionally, by accident.
1261
1262         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
1263         * Scripts/webkitpy/port/mac.py:
1264         (MacPort._check_port_build):
1265         (MacPort._build_java_test_support):
1266
1267 2015-01-27  Daniel Bates  <dabates@apple.com>
1268
1269         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
1270         https://bugs.webkit.org/show_bug.cgi?id=140949
1271
1272         Reviewed by Alexey Proskuryakov.
1273
1274         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
1275         builders so that run-webkit-tests can lint the appropriate TestExpectation
1276         files.
1277
1278         * Scripts/webkitpy/port/builders.py:
1279         * Scripts/webkitpy/port/ios.py:
1280         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
1281         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
1282         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
1283         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
1284         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
1285         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
1286         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
1287
1288
1289 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
1290
1291         Update bots on the flakiness dashboard
1292         https://bugs.webkit.org/show_bug.cgi?id=140956
1293
1294         Reviewed by Ryosuke Niwa.
1295
1296         * TestResultServer/static-dashboards/builders.jsonp:
1297         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1298
1299 2015-01-27  Daniel Bates  <dabates@apple.com>
1300
1301         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
1302         https://bugs.webkit.org/show_bug.cgi?id=140942
1303
1304         Reviewed by Alexey Proskuryakov.
1305
1306         The directory LayoutTests/platform/wk2 contains test expectations and test results that
1307         are applicable to all WebKit2 ports. We should make use of this information when
1308         running layout tests using iOS WebKit2.
1309
1310         Additionally, make use of the convenience function Port._wk2_port_name() for the name
1311         of the WebKit2 port instead of directly using string concatenation.
1312
1313         * Scripts/webkitpy/port/ios.py:
1314         (IOSSimulatorPort.default_baseline_search_path):
1315
1316 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
1317
1318         [Win] Disable FTL stress tests
1319         https://bugs.webkit.org/show_bug.cgi?id=140932
1320
1321         Reviewed by Brent Fulgham.
1322
1323         * Scripts/run-javascriptcore-tests:
1324
1325 2015-01-27  Daniel Bates  <dabates@apple.com>
1326
1327         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
1328         https://bugs.webkit.org/show_bug.cgi?id=140939
1329
1330         Reviewed by Eric Carlson.
1331
1332         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
1333
1334         * Scripts/webkitdirs.pm:
1335         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
1336         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
1337         and define a function called wanted.
1338
1339 2015-01-27  Daniel Bates  <dabates@apple.com>
1340
1341         Teach run-webkit-app --simulator how to install custom built app
1342         https://bugs.webkit.org/show_bug.cgi?id=140691
1343
1344         Fix inadvertent omission of directory test flag in expression to check for the
1345         existence of the iOS simulator device-specific directory for user installed apps.
1346
1347         * Scripts/webkitdirs.pm:
1348         (hasUserInstalledAppInSimulatorDevice):
1349
1350 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
1351
1352         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
1353         https://bugs.webkit.org/show_bug.cgi?id=87426
1354         <rdar://problem/11527899>
1355
1356         Reviewed by Darin Adler.
1357
1358         Revise COMPtr to work better with our HashMap implementation. Use
1359         modern loop syntax.
1360
1361         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1362         (AccessibilityController::~AccessibilityController):
1363         (AccessibilityController::winNotificationReceived):
1364         * DumpRenderTree/win/DumpRenderTree.cpp:
1365         (dumpBackForwardListForAllWindows):
1366
1367 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1368
1369         [Win] Enable JSC stress tests by default
1370         https://bugs.webkit.org/show_bug.cgi?id=128307
1371
1372         Reviewed by Brent Fulgham.
1373
1374         * Scripts/run-javascriptcore-tests:
1375
1376 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1377
1378         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
1379         arguments for build and test scripts
1380         https://bugs.webkit.org/show_bug.cgi?id=139748
1381
1382         Reviewed by Daniel Bates.
1383
1384         There was much confusion resulting from the multitude of aliases used to build/test for
1385         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
1386         tests directory.
1387
1388         This fixes an issue where run-api-tests and some other scripts failed when run with
1389         --simulator.
1390
1391         * Scripts/build-webkit:
1392         * Scripts/package-root:
1393         (usage):
1394         * Scripts/webkitdirs.pm:
1395         (argumentsForConfiguration):
1396         (determineXcodeSDK):
1397         * Scripts/webkitpy/port/factory.py:
1398         (platform_options):
1399
1400 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
1401
1402         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
1403         https://bugs.webkit.org/show_bug.cgi?id=140203
1404         rdar://problem/19198492
1405
1406         Reviewed by Sam Weinig.
1407
1408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1409         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
1410         (TEST):
1411
1412 2015-01-26  David Kilzer  <ddkilzer@apple.com>
1413
1414         Add iOS EWS to build.webkit.org/dashboard
1415         <http://webkit.org/b/140627>
1416
1417         Reviewed by Alexey Proskuryakov.
1418
1419         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
1420         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
1421         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1422         (BubbleQueueServer): Add ios-ews queue info.
1423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1424         Add iOS8Device platform.
1425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1426         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
1427         iOS device logo.
1428
1429 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
1430
1431         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
1432         https://bugs.webkit.org/show_bug.cgi?id=140896
1433
1434         Reviewed by Michael Saboff.
1435         
1436         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
1437         makes our script do this.
1438         
1439         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
1440         this would be harder given llvm's autoconf setup.
1441
1442         * Scripts/copy-webkitlibraries-to-product-directory:
1443
1444 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1445
1446         Update bot assignments.
1447
1448         * BuildSlaveSupport/build.webkit.org-config/config.json:
1449
1450 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1451
1452         Integrate WP python server into WebKit test framework
1453         https://bugs.webkit.org/show_bug.cgi?id=127094
1454
1455         Reviewed by Ryosuke Niwa.
1456
1457         This patch adds W3C web server (wptserver) as a new HTTP server.
1458         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
1459         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
1460
1461         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
1462         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
1463         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
1464
1465         * Scripts/webkitpy/common/system/executive_mock.py:
1466         (MockProcess.communicate):
1467         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
1468         (LayoutTestRunner.__init__):
1469         (LayoutTestRunner.run_tests):
1470         (LayoutTestRunner.start_servers):
1471         (LayoutTestRunner.stop_servers):
1472         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
1473         (LayoutTestRunnerTests._run_tests):
1474         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
1475         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
1476         (LayoutTestRunnerTests):
1477         (LayoutTestRunnerTests.test_servers_started):
1478         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
1479         (Manager.__init__):
1480         (Manager._is_http_test):
1481         (Manager._is_web_platform_test):
1482         (Manager._run_tests):
1483         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1484         (ManagerTest.test_needs_servers.get_wpt_doc_root):
1485         (ManagerTest.test_needs_servers.get_manager):
1486         (ManagerTest.test_needs_servers):
1487         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
1488         (parse_args):
1489         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
1490         (main):
1491         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
1492         (doc_root):
1493         (base_url):
1494         (WebPlatformTestServer):
1495         (WebPlatformTestServer.__init__):
1496         (WebPlatformTestServer._set_start_cmd):
1497         (WebPlatformTestServer._copy_webkit_test_files):
1498         (WebPlatformTestServer._clean_webkit_test_files):
1499         (WebPlatformTestServer._prepare_config):
1500         (WebPlatformTestServer._spawn_process):
1501         (WebPlatformTestServer._stop_running_server):
1502         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
1503         (TestWebPlatformTestServer):
1504         (TestWebPlatformTestServer.test_start_cmd):
1505         * Scripts/webkitpy/port/base.py:
1506         (Port.__init__):
1507         (Port.to.start_web_platform_test_server):
1508         (Port.to):
1509         (Port.to.web_platform_test_server_doc_root):
1510         (Port.to.web_platform_test_server_base_url):
1511         (Port.to.stop_web_platform_test_server):
1512         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
1513         (Driver.__init__):
1514         (Driver.is_web_platform_test):
1515         (Driver.test_to_uri):
1516         (Driver.uri_to_test):
1517         (Driver._command_from_driver_input):
1518         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
1519         (DriverTest.test_test_to_uri):
1520         (DriverTest.test_uri_to_test):
1521
1522 2015-01-26  Daniel Bates  <dabates@apple.com>
1523
1524         Teach run-webkit-app --simulator how to install custom built app
1525         https://bugs.webkit.org/show_bug.cgi?id=140691
1526
1527         Reviewed by David Kilzer.
1528
1529         We should teach run-webkit-app --simulator how to install a custom built app.
1530
1531         Currently run-webkit-app --simulator can only run a system app or an app that
1532         was installed using the simctl command line tool. For convenience we should
1533         teach run-webkit-app --simulator how to install a custom built app.
1534
1535         As a side effect of this change run-safari --simulator will install and run
1536         a custom built of MobileSafari (if it exists).
1537
1538         * Scripts/webkitdirs.pm:
1539         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
1540         Perl from the structure of the device.plist file.
1541         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
1542         file system check to determine the plist path for a Mac app bundle.
1543         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
1544         it will complain that it cannot find the file: "Domain ... does not exist".
1545         (appDisplayNameFromBundle): Ditto.
1546         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
1547         until a simulator device is the specified state.
1548         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
1549         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
1550         the specified device.
1551         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
1552         As implied by its name, this function will not return until the specified simulator
1553         device UDID is in the shutdown state.
1554         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
1555         device with the specified UDID.
1556         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
1557         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
1558         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
1559         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
1560         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
1561         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
1562         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
1563         (hasUserInstalledAppInSimulatorDevice): Added.
1564         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
1565         "Booted" state.
1566         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
1567         switching between a system installed app and a custom built version of the same app (e.g.
1568         custom build of MobileSafari) will erase all contents and settings in the simulator device.
1569         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
1570         as that was the only caller of this function.
1571         (bootedIOSSimulatorDevice): Deleted.
1572         (openIOSSimulator): Deleted.
1573
1574 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1575
1576         Update bot assignments.
1577
1578         * BuildSlaveSupport/build.webkit.org-config/config.json:
1579
1580 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
1581
1582         Leaks bot shouldn't run JSC tests
1583         https://bugs.webkit.org/show_bug.cgi?id=140877
1584
1585         Reviewed by Darin Adler.
1586
1587         Shaves off 48 minutes of time.
1588
1589         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1590         (TestLeaksFactory): Slim down the leaks queue.
1591
1592         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1593         * Scripts/webkitpy/port/ios.py:
1594         (IOSSimulatorPort.print_leaks_summary):
1595         * Scripts/webkitpy/port/mac.py:
1596         (MacPort.print_leaks_summary):
1597         Don't yell when leaks are detected.
1598
1599 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1600
1601         Refactor run-javascriptcore-tests
1602         https://bugs.webkit.org/show_bug.cgi?id=140824
1603
1604         Reviewed by Darin Adler.
1605
1606         Separated mozilla, stress test code paths and
1607         determining skipped mozilla tests into subroutines.
1608
1609         * Scripts/run-javascriptcore-tests:
1610         (runMozillaTests):
1611         (runJSCStressTests):
1612         (defaultJsDriverArgsForMozillaTests):
1613
1614 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1615
1616         [buildbot] Fix grammar of TestWithFailureCount
1617         https://bugs.webkit.org/show_bug.cgi?id=140884
1618
1619         Reviewed by Alexey Proskuryakov.
1620
1621         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1622         (TestWithFailureCount):
1623         (TestWithFailureCount.commandComplete):
1624         (TestWithFailureCount.getText2):
1625         (RunUnitTests):
1626         (RunPythonTests):
1627         (RunPerlTests):
1628         (RunLLINTCLoopTests):
1629         (Run32bitJSCTests):
1630         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1631         (RunLLINTCLoopTestsTest.test_failure):
1632         (Run32bitJSCTestsTest.test_failure):
1633         (RunUnitTestsTest.assertFailures):
1634
1635 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1636
1637         Unreviewed. Moving myself to the committer section.
1638
1639         * Scripts/webkitpy/common/config/contributors.json:
1640
1641 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
1642
1643         [GTK] gtkdoc does not appear in DevHelp
1644         https://bugs.webkit.org/show_bug.cgi?id=139369
1645
1646         Reviewed by Philippe Normand.
1647
1648         * gtk/generate-gtkdoc: Create the generators in the main function
1649         and use them to get the local cross renference dependencies. Also
1650         pass the generator module name to webkitdom.write_doc_files().
1651         (get_gtkdoc_module_paths): Receive a list of local cross reference
1652         dependencies.
1653         (get_generator_for_config): Set the main_sgml_file property of the
1654         GtkDoc object from the configuration file.
1655         (generate_documentation): Generate the documentation for the given
1656         generator.
1657         (generate_documentation_for_config): Deleted.
1658         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
1659         * gtk/webkitdom.py:
1660         (write_doc_files): Receive the module name used to build the
1661         -sections.txt filename.
1662
1663 2015-01-26  Commit Queue  <commit-queue@webkit.org>
1664
1665         Unreviewed, rolling out r179107.
1666         https://bugs.webkit.org/show_bug.cgi?id=140880
1667
1668         The GCC in the bots doesn't support the AsyncTask
1669         implementation (Requested by KaL on #webkit).
1670
1671         Reverted changeset:
1672
1673         "[GTK] Enable IndexedDB"
1674         https://bugs.webkit.org/show_bug.cgi?id=98932
1675         http://trac.webkit.org/changeset/179107
1676
1677 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1678
1679         [EFL] Bump libseccomp version to 2.1.1
1680         https://bugs.webkit.org/show_bug.cgi?id=140357
1681
1682         Reviewed by Gyuyoung Kim.
1683
1684         * efl/jhbuild.modules:
1685
1686 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1687
1688         [GTK] Enable IndexedDB
1689         https://bugs.webkit.org/show_bug.cgi?id=98932
1690
1691         Reviewed by Žan Doberšek.
1692
1693         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
1694
1695 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
1696
1697         Would like leaks bot results at build.webkit.org/dashboard
1698         https://bugs.webkit.org/show_bug.cgi?id=122657
1699
1700         Reviewed by Darin Adler.
1701
1702         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1703         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
1704         than necessary, could use the ones from buildbot in more places.
1705
1706         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1707         (BuildbotQueue): Reflect configuration option for leaks queues.
1708
1709         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1710         Add leaks queues to performance column. First, leaks are about performance indeed,
1711         and second, this is where we have some space to spare.
1712
1713         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1714         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
1715         least a year.
1716
1717         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1718         (table.queue-grid td): Moved height from queue-view - we can now have more than one
1719         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
1720         results - once the results are loaded, all rows are currently higher than that.
1721
1722         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1723         (.leaks-popover): Added.
1724
1725         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
1726         Added.
1727
1728         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1729         Load BuildbotLeaksQueueView.js.
1730
1731 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
1732
1733         [Win] Add WebKit message loop interface.
1734         https://bugs.webkit.org/show_bug.cgi?id=140857
1735
1736         Reviewed by Brent Fulgham.
1737
1738         Added message loop interface which will run the message loop,
1739         and perform required tasks (like calling CFRunLoopRunInMode)
1740         on each iteration of the loop.
1741
1742         * WinLauncher/WinMain.cpp:
1743         (wWinMain): Use new message loop interface.
1744
1745 2015-01-24  Dan Bernstein  <mitz@apple.com>
1746
1747         update-webkit’s --internal option is unused
1748         https://bugs.webkit.org/show_bug.cgi?id=140861
1749
1750         Reviewed by Anders Carlsson.
1751
1752         * Scripts/update-webkit: Removed the option.
1753
1754 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
1755
1756         DumpRenderTree needs to run with Windows native controls on Windows
1757         https://bugs.webkit.org/show_bug.cgi?id=25592
1758
1759         Reviewed by Anders Carlsson.
1760
1761         * DumpRenderTree/win/DumpRenderTree.cpp:
1762         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
1763         (prepareConsistentTestingEnvironment): Ditto.
1764
1765 2015-01-23  David Kilzer  <ddkilzer@apple.com>
1766
1767         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
1768         <http://webkit.org/b/140787>
1769
1770         Reviewed by Daniel Bates.
1771
1772         * Scripts/webkitpy/port/ios.py:
1773         (IOSPort.determine_full_port_name): Instead of checking the type
1774         of the current host, test if /usr/bin/xcrun exists before trying
1775         to use it.
1776
1777 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
1778
1779         Fix the false positive build failures on the Windows buildbots
1780         https://bugs.webkit.org/show_bug.cgi?id=140819
1781
1782         Reviewed by Brent Fulgham.
1783
1784         Increase the build timeout (without producing output) to 2 hours for Windows bots,
1785         the default 20 minutes is enough for others since they produce output during the build.
1786
1787         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1788         (BuildFactory.__init__):
1789
1790 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
1791
1792         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
1793         https://bugs.webkit.org/show_bug.cgi?id=140839
1794
1795         Reviewed by Dean Jackson.
1796
1797         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1798         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
1799         from the IA2Locale structure and pass it to DRT.
1800
1801 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
1802
1803         [Win] Update DRT Accessibility implementation to better match Mac.
1804         https://bugs.webkit.org/show_bug.cgi?id=140830
1805
1806         Reviewed by Dean Jackson.
1807
1808         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1809         (AccessibilityUIElement::titleUIElement):
1810         (AccessibilityUIElement::parentElement):
1811         (convertToDRTLabel):
1812         (AccessibilityUIElement::role):
1813         (AccessibilityUIElement::title):
1814         (AccessibilityUIElement::description):
1815         (AccessibilityUIElement::stringValue):
1816         (AccessibilityUIElement::helpText):
1817         (AccessibilityUIElement::isFocused):
1818
1819 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
1820
1821         REGRESSION: run-perf-tests --profiler= seems to have broken
1822         https://bugs.webkit.org/show_bug.cgi?id=113528
1823
1824         Reviewed by Daniel Bates.
1825
1826         The problem is that "perf --record" (or the equivalent call for
1827         other profilers) is never called whenever there is a wrapper
1828         option in the port. We should inject the profiler call first
1829         (should it exists) and then use the port wrapper.
1830
1831         * Scripts/webkitpy/port/driver.py:
1832         (Driver._command_wrapper):
1833         * Scripts/webkitpy/port/driver_unittest.py:
1834         (DriverTest.test_profiler_and_wrapper): New unit test.
1835
1836 2015-01-22  David Kilzer  <ddkilzer@apple.com>
1837
1838         configure-xcode-for-ios-development needs to import webkitdirs.pm
1839         <http://webkit.org/b/140704>
1840
1841         Fixes the following runtime error:
1842
1843             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
1844
1845         * Scripts/configure-xcode-for-ios-development: Add back code to
1846         import webkitdirs.pm for the exitStatus() method.  Not sure why
1847         I removed it before patch review.
1848
1849 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
1850
1851         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
1852         https://bugs.webkit.org/show_bug.cgi?id=140795
1853
1854         Reviewed by Jon Honeycutt.
1855
1856         * BuildSlaveSupport/build.webkit.org-config/config.json:
1857         r178847 accidentally remove the scheduler for this bot. Re-add it to the
1858         Yosemite scheduler.
1859
1860 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
1861
1862         [Win] Expose missing editing features through WebView interface
1863         https://bugs.webkit.org/show_bug.cgi?id=140773
1864         <rdar://problem/19565421>
1865
1866         Reviewed by Dean Jackson.
1867
1868         Connect the various WebView editing delegate methods to our
1869         test infrastructure. Also prefer _bstr_t to raw BSTR types
1870         to simplify life cycle management.
1871
1872         * DumpRenderTree/win/DumpRenderTree.cpp:
1873         (resetWebViewToConsistentStateBeforeTesting):
1874         * DumpRenderTree/win/EditingDelegate.cpp:
1875         (EditingDelegate::QueryInterface):
1876         (dumpPath):
1877         (dump):
1878         (EditingDelegate::shouldBeginEditingInDOMRange):
1879         (EditingDelegate::shouldEndEditingInDOMRange):
1880         (EditingDelegate::shouldInsertNode):
1881         (EditingDelegate::shouldInsertText):
1882         (EditingDelegate::shouldDeleteDOMRange):
1883         (EditingDelegate::shouldChangeSelectedDOMRange):
1884         (EditingDelegate::shouldApplyStyle):
1885         (EditingDelegate::shouldChangeTypingStyle):
1886         (EditingDelegate::doPlatformCommand):
1887         (EditingDelegate::webViewDidBeginEditing):
1888         (EditingDelegate::webViewDidChange):
1889         (EditingDelegate::webViewDidEndEditing):
1890         (EditingDelegate::webViewDidChangeTypingStyle):
1891         (EditingDelegate::webViewDidChangeSelection):
1892         (EditingDelegate::checkSpellingOfString):
1893         (EditingDelegate::onNotify):
1894         * DumpRenderTree/win/EditingDelegate.h:
1895
1896 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1897
1898         Add a build flag for ES6 class syntax
1899         https://bugs.webkit.org/show_bug.cgi?id=140760
1900
1901         Reviewed by Michael Saboff.
1902
1903         * Scripts/webkitperl/FeatureList.pm:
1904
1905 2015-01-22  Daniel Bates  <dabates@apple.com>
1906
1907         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
1908         runtime in simctl output
1909         https://bugs.webkit.org/show_bug.cgi?id=140751
1910
1911         Reviewed by David Kilzer.
1912
1913         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
1914         with an error because it does not know how to parse the output of the simctl tool
1915         to identify an Apple Internal runtime.
1916
1917         * Scripts/webkitpy/xcode/simulator.py:
1918         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
1919         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
1920         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
1921         the runtime is an internal runtime.
1922         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
1923         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
1924         appropriate value.
1925         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
1926         it updates the appropriate Runtime object.
1927         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
1928         looking up a Runtime object for an internal runtime.
1929
1930 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
1931
1932         LeaksViewer doesn't show recent builds if there are less than 10
1933         https://bugs.webkit.org/show_bug.cgi?id=140716
1934
1935         Reviewed by Tim Horton.
1936
1937         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1938
1939 2015-01-22  Lucas Forschler  <lforschler@apple.com>
1940
1941         Add Apple build slaves.
1942         Fixed text alignment for slave list.
1943         
1944         Unreviewed.
1945         
1946         * BuildSlaveSupport/build.webkit.org-config/config.json:
1947
1948 2015-01-21  Lucas Forschler  <lforschler@apple.com>
1949
1950         Teach build.webkit.org about bot308 and bot309.
1951         
1952         Unreviewed.
1953         
1954         * BuildSlaveSupport/build.webkit.org-config/config.json:
1955
1956 2015-01-21  Lucas Forschler  <lforschler@apple.com>
1957
1958         Add two Apple Mavericks slaves.
1959         
1960         Unreviewed.
1961         
1962         * BuildSlaveSupport/build.webkit.org-config/config.json:
1963
1964 2015-01-21  Daniel Bates  <dabates@apple.com>
1965
1966         Add iOS WebKit1 TestExpectation file
1967         https://bugs.webkit.org/show_bug.cgi?id=140739
1968
1969         Reviewed by David Kilzer.
1970
1971         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
1972         expectations in directory LayoutTests/platform/ios-simulator-wk1.
1973
1974         * Scripts/webkitpy/port/ios.py:
1975         (IOSSimulatorPort.default_baseline_search_path):
1976
1977 2015-01-21  David Kilzer  <ddkilzer@apple.com>
1978
1979         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
1980         <http://webkit.org/b/140704>
1981
1982         Reviewed by Daniel Bates.
1983
1984         * Scripts/configure-xcode-for-ios-development:
1985         - Update copyright.
1986         - Remove FIXME addressed by r178709.
1987         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
1988         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
1989         missing headers from iphonesimulator SDK to iphoneos SDK.
1990         (sdkDirectory): Add method that returns SDK directory.
1991         (sdkPlatformDirectory): Extract method from
1992         xcodeSDKSpecificationsPath() that returns SDK platform
1993         directory.
1994         (xcodeSDKSpecificationsPath): Update to use
1995         sdkPlatformDirectory().
1996
1997 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
1998
1999         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
2000         https://bugs.webkit.org/show_bug.cgi?id=140731
2001
2002         Reviewed by Tim Horton.
2003
2004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2005         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
2006
2007 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
2008
2009         [Win] eventSender does not support scalePageBy
2010         https://bugs.webkit.org/show_bug.cgi?id=140726
2011         <rdar://problem/19549865>
2012
2013         Reviewed by Dean Jackson.
2014
2015         * DumpRenderTree/win/EventSender.cpp:
2016         (scalePageByCallback): Provide implementation using new WebView method.
2017
2018 2015-01-21  Lucas Forschler  <lforschler@apple.com>
2019
2020         Remove Apple Mountain Lion Build & Test slaves.
2021         
2022         Unreviewed.
2023
2024         * BuildSlaveSupport/build.webkit.org-config/config.json:
2025
2026 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
2027
2028         Remove ENABLE(INSPECTOR) ifdef guards
2029         https://bugs.webkit.org/show_bug.cgi?id=140668
2030
2031         Reviewed by Darin Adler.
2032
2033         * DumpRenderTree/mac/TestRunnerMac.mm:
2034         (TestRunner::showWebInspector):
2035         (TestRunner::closeWebInspector):
2036         (TestRunner::evaluateInWebInspector):
2037         * Scripts/webkitperl/FeatureList.pm:
2038         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2039         (WTR::TestRunner::showWebInspector):
2040         (WTR::TestRunner::closeWebInspector):
2041         (WTR::TestRunner::evaluateInWebInspector):
2042         * WebKitTestRunner/TestInvocation.cpp:
2043         (WTR::TestInvocation::invoke):
2044
2045 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
2046
2047         Update build.webkit.org/dashboard to match current Mac queues.
2048
2049         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
2050         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
2051         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
2052         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
2053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2054         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2055         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2056         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
2057         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
2058
2059 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2060
2061         Update Apple MountainLion Leaks slave to Yosemite
2062         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
2063         
2064         Unreviewed.
2065
2066         * BuildSlaveSupport/build.webkit.org-config/config.json:
2067
2068 2015-01-20  Lucas Forschler  <lforschler@apple.com>
2069
2070         Update LeaksViewer from MountainLion to Yosemite
2071         
2072         Reviewed by Alexey Proskuryakov.
2073
2074         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2075         (LeaksViewer._displayURLPrompt):
2076
2077 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
2078
2079         Fix EWS python unit tests and address code comments as per 140476
2080         https://bugs.webkit.org/show_bug.cgi?id=140637
2081
2082         Reviewed by David Kilzer.
2083
2084         * Scripts/webkitpy/port/base.py:
2085         (Port):
2086         (Port.__init__):
2087         Adds DEFAULT_ARCHITECTURE member.
2088         (Port.architecture):
2089         Removes architecture member and instead uses
2090         self.get_option('architecture'). Also removes redundant architecture
2091         method.
2092         (Port.set_architecture):
2093         Adds a setter for the architecture variable to be able to set a flag
2094         upon modification.
2095         (Port.test_configuration):
2096         Uses self.architecture() instead of self._architecture.
2097         * Scripts/webkitpy/port/ios.py:
2098         Overrides DEFAULT_ARCHITECTURE.
2099         (IOSPort):
2100         (IOSPort.determine_full_port_name):
2101         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
2102         strip. Fixes regex to not match arbitrary characters after the
2103         relevent digits are matched.
2104         (IOSPort.__init__):
2105         Removes old _architecture defaulting strategy.
2106         (IOSPort._build_driver_flags):
2107         Uses self.architecture() instead of self._architecture.
2108         (IOSSimulatorPort):
2109         Overrides DEFAULT_ARCHITECTURE.
2110         (IOSSimulatorPort.__init__):
2111         Removes old _architecture defaulting strategy.
2112         * Scripts/webkitpy/port/mac.py:
2113         (MacPort):
2114         Overrides DEFAULT_ARCHITECTURE.
2115         (MacPort.__init__):
2116         Removes old _architecture defaulting strategy.
2117         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2118         (AbstractEarlyWarningSystem.run_command):
2119         Checks the did_override_architecture flag to determine whether to add
2120         the --architecture option.
2121         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2122         Uses ews.architecture rather than trying to discern the correct
2123         architecture using a port object.
2124         (EarlyWarningSystemTest._default_expected_logs):
2125         * Scripts/webkitpy/tool/commands/queues.py:
2126         Removes use of optparse, and removes the import statement.
2127         (AbstractQueue.__init__):
2128         (PatchProcessingQueue.begin_work_queue):
2129
2130 2015-01-20  Sam Weinig  <sam@webkit.org>
2131
2132         Attempt to fix Mountain Lion and EFL tests.
2133
2134         * WebKitTestRunner/TestController.cpp:
2135         (WTR::TestController::initialize):
2136         Disable Process-per-tab and network process on Mountain Lion and EFL.
2137
2138 2015-01-20  Darin Adler  <darin@apple.com>
2139
2140         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
2141         https://bugs.webkit.org/show_bug.cgi?id=140679
2142
2143         Reviewed by Anders Carlsson.
2144
2145         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2146         Removed a reference to SVGElementInstanceList.
2147
2148 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2149
2150         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
2151         https://bugs.webkit.org/show_bug.cgi?id=140028
2152
2153         Reviewed by Carlos Garcia Campos.
2154
2155         This won't work as expected, since this function is called before the
2156         WebViewTest constructor completes.
2157
2158         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2159
2160 2015-01-20  David Kilzer  <ddkilzer@apple.com>
2161
2162         configure-xcode-for-ios-development needs to update iPhoneOS SDK
2163         <http://webkit.org/b/140661>
2164
2165         Reviewed by Daniel Bates.
2166
2167         * Scripts/configure-xcode-for-ios-development: Add for() loop to
2168         run createXcodeSpecificationFilesForSDKIfNeeded() for both
2169         "iphoneos" and "iphonesimulator" SDKs.
2170         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
2171         the main body of the script.
2172
2173 2015-01-20  Tomas Popela  <tpopela@redhat.com>
2174
2175         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
2176         https://bugs.webkit.org/show_bug.cgi?id=139443
2177
2178         Reviewed by Carlos Garcia Campos.
2179
2180         Create the new test cases for setting the editable property on the web
2181         view and on the contenteditable enabled document. Also rework the
2182         current tests that are expecting that the web view is editable.
2183
2184         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2185         (loadTestHtml):
2186         (testWebViewEditorCutCopyPasteNonEditable):
2187         (testWebViewEditorCutCopyPasteEditable):
2188         (testWebViewEditorSelectAllNonEditable):
2189         (testWebViewEditorSelectAllEditable):
2190         (runEditorEditableCutTests):
2191         (testWebViewEditorEditableOnNonEditable):
2192         (testWebViewEditorEditableOnContentEditable):
2193         (testWebViewEditorNonEditable):
2194         (beforeAll):
2195         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2196         (WebViewTest::isEditable):
2197         (WebViewTest::setEditable):
2198
2199 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2200
2201         [GTK] Add an option to create WebKitWebView snapshots with transparent background
2202         https://bugs.webkit.org/show_bug.cgi?id=140617
2203
2204         Reviewed by Gustavo Noronha Silva.
2205
2206         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2207         (testWebViewSnapshot): Check that the same snapshot with
2208         transparent background is different than the default one filled
2209         with white.
2210
2211 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2212
2213         [GTK] Add API to change the WebKitWebView background color
2214         https://bugs.webkit.org/show_bug.cgi?id=140610
2215
2216         Reviewed by Gustavo Noronha Silva.
2217
2218         Add --bg-color command line option to MiniBrowser to be able to
2219         manually test the API passing any RGBA color to MiniBrowser.
2220         Also add a simple unit test to check that getting and setting
2221         colors from the API point of view.
2222
2223         * MiniBrowser/gtk/BrowserWindow.c:
2224         (browser_window_set_background_color):
2225         * MiniBrowser/gtk/BrowserWindow.h:
2226         * MiniBrowser/gtk/main.c:
2227         (createBrowserWindow):
2228         (parseBackgroundColor):
2229         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2230         (testWebViewBackgroundColor):
2231         (beforeAll):
2232
2233 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2234
2235         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
2236         https://bugs.webkit.org/show_bug.cgi?id=140665
2237
2238         Reviewed by Brian Burg.
2239
2240         * DumpRenderTree/win/UIDelegate.cpp:
2241         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
2242         match expected test output.
2243
2244 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
2245
2246         Remove the support for custom suffixes on ChangeLog
2247         https://bugs.webkit.org/show_bug.cgi?id=140648
2248
2249         Reviewed by David Kilzer.
2250
2251         Custom suffixes were used for the iOS branch of WebKit.
2252         Now that everything is opensource, there is no need for it.
2253
2254         * Scripts/VCSUtils.pm:
2255         (changeLogSuffix): Deleted.
2256         (changeLogFileName): Deleted.
2257         * Scripts/commit-log-editor:
2258         * Scripts/prepare-ChangeLog:
2259         (getLatestChangeLogs):
2260         (generateNewChangeLogs):
2261         (generateFileList):
2262         * Scripts/resolve-ChangeLogs:
2263         (findChangeLog):
2264
2265 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
2266
2267         Adjust naming of action menu SPI
2268         https://bugs.webkit.org/show_bug.cgi?id=140644
2269         <rdar://problem/19448129>
2270
2271         Reviewed by Brian Weinstein.
2272
2273         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2274         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2275         (TestWebKitAPI::TEST):
2276
2277 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2278
2279         [GTK] Generate the make dist manifest from a CMake template file
2280         https://bugs.webkit.org/show_bug.cgi?id=139387
2281
2282         Reviewed by Martin Robinson.
2283
2284         Remove the code that performs variable substitution on manifest.txt.
2285         Replace the custom variables used in that file with CMake variables.
2286
2287         * gtk/make-dist.py:
2288         (Manifest.add_directory):
2289         (Manifest.get_full_source_path):
2290         (Manifest.process_line):
2291         (Manifest.resolve_variables): Deleted.
2292         (Manifest.get_full_tarball_path): Deleted.
2293         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
2294
2295 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2296
2297         [Win] Correct merge error in last commit.
2298
2299         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2300         (findAccessibleObjectById): Undo accidental paste made during landing.
2301
2302 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
2303
2304         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
2305         https://bugs.webkit.org/show_bug.cgi?id=139906
2306
2307         Reviewed by Dean Jackson.
2308
2309         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
2310         to use them. This patch fixes that.
2311
2312         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2313         (findAccessibleObjectById):
2314         (AccessibilityController::focusedElement):
2315         (logEventProc):
2316         (notificationListenerProc):
2317         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2318         (AccessibilityUIElement::getChildAtIndex):
2319         (AccessibilityUIElement::titleUIElement):
2320         (self):
2321         (AccessibilityUIElement::role):
2322         (AccessibilityUIElement::valueDescription):
2323         (accessibilityState):
2324         (AccessibilityUIElement::isChecked):
2325         * DumpRenderTree/win/DumpRenderTree.cpp:
2326         (dumpFrameScrollPosition):
2327         (dumpFramesAsText):
2328         * DumpRenderTree/win/PolicyDelegate.cpp:
2329         (PolicyDelegate::decidePolicyForNavigationAction):
2330         * DumpRenderTree/win/UIDelegate.cpp:
2331         (UIDelegate::exceededDatabaseQuota):
2332         * WinLauncher/Common.cpp:
2333         (setWindowText):
2334
2335 2015-01-19  Dean Jackson  <dino@apple.com>
2336
2337         Add "override" to fix the build with newer clangs.
2338
2339         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2340         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
2341
2342 2015-01-19  David Kilzer  <ddkilzer@apple.com>
2343
2344         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
2345         <http://webkit.org/b/140623>
2346
2347         Reviewed by Daniel Bates.
2348
2349         * Scripts/build-webkit: Update help for --device switch.
2350         * Scripts/webkitdirs.pm:
2351         (determineXcodeSDK): When passing --device, prefer the internal
2352         iOS SDK if it exists, else fall back to the external iOS SDK.
2353         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
2354         xcodebuild instead of trying to sanitize values.
2355
2356 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
2357
2358         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
2359         https://bugs.webkit.org/show_bug.cgi?id=140606
2360
2361         Reviewed by Csaba Osztrogonác.
2362
2363         * Scripts/webkitpy/bindings/main.py:
2364         (BindingsTests.generate_supplemental_dependency):
2365         (BindingsTests.main):
2366
2367 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2368
2369         [GTK] [WK2] TestWebKitWebView snapshot fails
2370         https://bugs.webkit.org/show_bug.cgi?id=120404
2371
2372         Reviewed by Žan Doberšek.
2373
2374         Rework the test to make sure the snapshot is always created at the
2375         desired size.
2376
2377         * Scripts/run-gtk-tests:
2378         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
2379         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2380         (testWebViewSnapshot): Use a fixed size for the document, and
2381         disable scrollbars to make sure the visible area is always the
2382         WebView size.
2383         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2384         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
2385         and height parameters to create the window with a given size.
2386         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2387
2388 2015-01-18  David Kilzer  <ddkilzer@apple.com>
2389
2390         iOS EWS queue name should be consistent
2391         <http://webkit.org/b/140585>
2392
2393         Reviewed by Daniel Bates.
2394
2395         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
2396         to 'ios'.
2397         * Scripts/webkitpy/common/config/ports.py: Ditto.
2398         (DeprecatedPort.port):
2399         (IOSPort):
2400         * Scripts/webkitpy/port/ios.py: Ditto.
2401         (IOSPort):
2402
2403         * Scripts/webkitpy/port/factory.py:
2404         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
2405         appears before ios.IOSPort.  If this is not done,
2406         `run-webkit-tests --ios-simulator` will get the wrong Port class
2407         (IOSPort instead of IOSSimulatorPort) due to the way that
2408         PortFactory.get() uses prefix matching of <Port>.port_name to
2409         find the correct class to use.
2410
2411 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
2412
2413         build.webkit.org/dashboard: OS X EWS is now on Mavericks
2414         https://bugs.webkit.org/show_bug.cgi?id=140595
2415
2416         Reviewed by Csaba Osztrogonác.
2417
2418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2419         (BubbleQueueServer):
2420
2421 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2422
2423         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
2424
2425         * Scripts/webkitpy/port/ios.py:
2426         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
2427         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
2428         the Mountain Lion and Mavericks bots.
2429
2430 2015-01-17  David Kilzer  <ddkilzer@apple.com>
2431
2432         Attempt to fix webkitpy tests on GTK Linux ports
2433
2434         * Scripts/webkitpy/port/ios.py:
2435         (IOSPort.determine_full_port_name): Set a sensible default if
2436         not running on a Mac platform or if no iOS SDK is installed.
2437
2438 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
2439
2440         Create iOS-EWS client queue
2441         https://bugs.webkit.org/show_bug.cgi?id=140476
2442
2443         Reviewed by Alexey Proskuryakov.
2444
2445         * EWSTools/start-queue-mac.sh:
2446         Adds call to configure-xcode-for-ios-development for iOS EWS.
2447         * Scripts/webkitpy/common/config/ews.json:
2448         Adds the iOS EWS config entry.
2449         * Scripts/webkitpy/common/config/ports.py:
2450         (DeprecatedPort.port):
2451         Adds IOSPort to the port map.
2452         (IOSPort):
2453         (IOSPort.build_webkit_command):
2454         Adds --sdk=iphoneos to the webkit build command.
2455         * Scripts/webkitpy/port/base.py:
2456         (Port.architecture):
2457         Adds an accessor for the architecture member variable.
2458         * Scripts/webkitpy/port/factory.py:
2459         (PortFactory):
2460         Adds IOSPort to the port class list.
2461         * Scripts/webkitpy/port/ios.py:
2462         Adds the IOSPort to encapsulate iOS-specific things.
2463         (IOSPort):
2464         (IOSPort.determine_full_port_name):
2465         (IOSPort.__init__):
2466         (IOSPort._build_driver_flags):
2467         (IOSPort.operating_system):
2468         * Scripts/webkitpy/tool/commands/download_unittest.py:
2469         Adds the archetecture option to the mock options.
2470         (DownloadCommandsTest._default_options):
2471         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2472         Appends the archetecture option into calls to webkit-patch.
2473         (AbstractEarlyWarningSystem.review_patch):
2474         (AbstractEarlyWarningSystem.run_command):
2475         (AbstractEarlyWarningSystem.load_ews_classes):
2476         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2477         Adds logic to soothe the unittest now that --architecture is being
2478         thrown around everywhere.
2479         (EarlyWarningSystemTest._default_expected_logs):
2480         * Scripts/webkitpy/tool/commands/queues.py:
2481         Adds glue code to ferry the --architecture option around.
2482         (AbstractQueue.__init__):
2483         (PatchProcessingQueue.begin_work_queue):
2484         * Scripts/webkitpy/tool/steps/abstractstep.py:
2485         Adds the archetecture option to all AbstractSteps so that
2486         EarlyWarningSystem doesn't start shoving --architecture into
2487         unsuspecting commands.
2488         (AbstractStep.options):
2489         * Scripts/webkitpy/tool/steps/build.py:
2490         Translates the --architecture option into an ARCHS= format to pass to
2491         build-webkit.
2492         (Build.build):
2493         * Scripts/webkitpy/tool/steps/options.py:
2494         Adds a definition for the --architecture option.
2495         (Options):
2496
2497 2015-01-16  Sam Weinig  <sam@webkit.org>
2498
2499         Add a basic configuration object for WKView
2500         https://bugs.webkit.org/show_bug.cgi?id=140559
2501
2502         Reviewed by Anders Carlsson.
2503
2504         Add tests for WKPageConfigurationRef.
2505
2506         * TestWebKitAPI/PlatformWebView.h:
2507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2508         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
2509         (TestWebKitAPI::TEST):
2510         (TestWebKitAPI::didFinishLoadForFrame):
2511         (TestWebKitAPI::setPageLoaderClient):
2512         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2513         (TestWebKitAPI::PlatformWebView::initialize):
2514         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2515
2516 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
2517
2518         WeakPtr functions crash when created with default constructor
2519         https://bugs.webkit.org/show_bug.cgi?id=140479
2520
2521         Reviewed by Andreas Kling.
2522
2523         Add WeakPtr API tests.
2524
2525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2526         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
2527         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
2528
2529 2015-01-16  Chris Dumez  <cdumez@apple.com>
2530
2531         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
2532         https://bugs.webkit.org/show_bug.cgi?id=140568
2533
2534         Reviewed by Alexey Proskuryakov.
2535
2536         Fix the script parsing CSSPropertyNames.in to stop splitting lines
2537         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
2538         e.g. "Longhands=background-position-x|background-position-y".
2539         This would confuse the script and treat this as a CSS property:
2540         "background-position-x|background-position-y".
2541
2542         We now split on white space and treat the first string on the line
2543         to be the property name (this is the syntax in this file).
2544
2545         * Scripts/webkitpy/w3c/test_converter.py:
2546         (_W3CTestConverter.__init__):
2547         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2548
2549 2015-01-16  Daniel Bates  <dabates@apple.com>
2550
2551         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
2552         https://bugs.webkit.org/show_bug.cgi?id=135589
2553
2554         Reviewed by David Kilzer.
2555
2556         Derived from a patch by David Farler.
2557
2558         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
2559         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
2560         in terms of the simctl command line utility.
2561
2562         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
2563         (eraseIOSSimulatorDevice): Added.
2564         (bootedIOSSimulatorDevice): Added.
2565         (iosSimulatorApplicationsPath): Added.
2566         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
2567         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
2568         (quitIOSSimulator): Added.
2569         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
2570         the specified name and currently selected iOS runtime.
2571         (isIOSSimulatorSystemInstalledApp): Added.
2572         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
2573         (deleteiOSSimulatorDevice): Deleted.
2574         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
2575         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
2576
2577 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
2578
2579         Resurrect the WinCairo bot.
2580         https://bugs.webkit.org/show_bug.cgi?id=139908
2581
2582         Reviewed by Csaba Osztrogonác.
2583
2584         * BuildSlaveSupport/build.webkit.org-config/config.json:
2585         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2586         (appendCustomBuildFlags):
2587         * BuildSlaveSupport/test-result-archive:
2588         (archiveTestResults):
2589         Add WinCairo buildbot.
2590
2591 2015-01-16  Chris Dumez  <cdumez@apple.com>
2592
2593         webkit-patch should auto-install the keyring python module
2594         https://bugs.webkit.org/show_bug.cgi?id=140547
2595
2596         Reviewed by David Kilzer.
2597
2598         Auto-install the keyring python module. This is the module that
2599         webkit-patch uses for cross-platform access to the keyring
2600         service.
2601
2602         Without this module, if the password if not in the keychain,
2603         webkit-patch will keep asking for your username / password and
2604         never remember them.
2605
2606         * Scripts/webkitpy/common/net/credentials.py:
2607         * Scripts/webkitpy/thirdparty/__init__.py:
2608         (AutoinstallImportHook.find_module):
2609         (AutoinstallImportHook._install_keyring):
2610
2611 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
2612
2613         Remove ENABLE(SQL_DATABASE) guards
2614         https://bugs.webkit.org/show_bug.cgi?id=140434
2615
2616         Reviewed by Darin Adler.
2617
2618         * Scripts/webkitperl/FeatureList.pm:
2619
2620 2015-01-15  Daniel Bates  <dabates@apple.com>
2621
2622         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
2623         https://bugs.webkit.org/show_bug.cgi?id=139685
2624         <rdar://problem/19281317>
2625
2626         Reviewed by Simon Fraser.
2627
2628         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
2629         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
2630
2631         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
2632         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
2633         before DRT dumps the output of a test. In particular, the WebThread may start a new page
2634         load (say, as a result of continued JavaScript execution), which will ultimately lead to
2635         dumping the test result again. Instead we want DRT to dump the test result synchronously
2636         such that we capture the state of the web page either when the page is loaded or when
2637         window.testRunner.notifyDone() is called.
2638
2639         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2640         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
2641         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
2642         flush CA transactions to the window.
2643         * DumpRenderTree/mac/DumpRenderTree.mm:
2644         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
2645         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
2646         (dump): Renamed; formerly named dumpTestResults().
2647         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
2648         enabling repaint support on iOS.
2649         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
2650         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
2651         (dumpTestResults): Deleted.
2652
2653 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
2654
2655         [Win] Miscellaneous DRT fixes
2656         https://bugs.webkit.org/show_bug.cgi?id=116562
2657
2658         Reviewed by Tim Horton.
2659
2660         While investigating the cause of several Windows crashes, I found:
2661         (1) Messy conversions to and from BSTR types
2662         (2) Weird mixes of wide-string and narrow string conversions
2663         (3) Passing nullptr to some CoreFoundation routines that do not
2664             permit null arguments.
2665         (4) Commands to link the executable to the VS2005 runtime.
2666
2667         This patch cleans up these issues to improve DRT reliability on
2668         Windows.
2669
2670         * DumpRenderTree/cg/ImageDiffCG.cpp:
2671         (main): Get rid of VS2005 runtime linking.
2672         * DumpRenderTree/win/DumpRenderTree.cpp:
2673         (urlSuitableForTestResult): Protect against being asked
2674         to process an empty URL.
2675         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
2676         than converting to/from wchar_t buffers.
2677         (runTest): Simplify string and BSTR handling.
2678         (createWebViewAndOffscreenWindow): Ditto.
2679         (main): Get rid of VS2005 runtime linking.
2680         * DumpRenderTree/win/TestRunnerWin.cpp:
2681         (jsStringRefToWString): Simplify code.
2682         (TestRunner::pathToLocalResource):
2683         (TestRunner::setUserStyleSheetLocation):
2684         * TestWebKitAPI/win/main.cpp: Get rid of
2685         VS2005 runtime linking.
2686         * win/DLLLauncher/DLLLauncherMain.cpp:
2687         (wWinMain): Ditto.
2688
2689 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
2690
2691         Stop hardcoding mac-mountainlion in commit queue
2692         https://bugs.webkit.org/show_bug.cgi?id=140492
2693
2694         Reviewed by Anders Carlsson.
2695
2696         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
2697         there should be no change in behavior, because:
2698         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
2699         using it to create a port object.
2700         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
2701         is actually correct to use "mac" for the name there. We only used to get the expected
2702         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
2703         for unknown deprecated port names.
2704
2705         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
2706
2707 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
2708
2709         Create iOS-EWS server queue
2710         https://bugs.webkit.org/show_bug.cgi?id=140473
2711
2712         Reviewed by Benjamin Poulain.
2713
2714         * QueueStatusServer/app.yaml: Updates the SVN version number.
2715         * QueueStatusServer/config/queues.py: Add ios-ews queue.
2716         * QueueStatusServer/model/queues.py:         
2717         (Queue.display_name): Makes sure the display name is pretty!
2718
2719 2015-01-14  Daniel Bates  <dabates@apple.com>
2720
2721         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
2722         https://bugs.webkit.org/show_bug.cgi?id=140301
2723         <rdar://problem/19389266>
2724
2725         Reviewed by Jon Honeycutt.
2726
2727         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
2728         with an unavailable runtime.
2729
2730         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2731         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
2732         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
2733         specified runtime cannot be used because it is unavailable.
2734         * Scripts/webkitpy/port/ios.py:
2735         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
2736         which was formerly named testing_device.
2737         * Scripts/webkitpy/xcode/simulator.py:
2738         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
2739         more robust than looking up the simulator device by name and runtime. This approach also
2740         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
2741         unavailable runtimes under the same iOS heading it would use to show it as available).
2742         (Simulator.find_device_by_udid): Added.
2743         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
2744         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
2745         (Simulator.available_runtimes): Added.
2746         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
2747         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
2748         first element of the sorted list is the runtime with the highest version number.
2749         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
2750
2751 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
2752
2753         Remove WK2 Windows cruft
2754         https://bugs.webkit.org/show_bug.cgi?id=140440
2755
2756         Reviewed by Anders Carlsson.
2757
2758         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
2759         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
2760         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
2761
2762 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
2763
2764         Fix TestWTF failed in TestWebKitAPI
2765         https://bugs.webkit.org/show_bug.cgi?id=140333
2766
2767         Reviewed by Sam Weinig.
2768
2769         Clear the std::ostringstream before starting test.
2770
2771         * TestWebKitAPI/Tests/WTF/RefLogger.h:
2772         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
2773
2774 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2775
2776         TestWebKitWebContext depends on British English spellcheck dictionary
2777         https://bugs.webkit.org/show_bug.cgi?id=140403
2778
2779         Reviewed by Martin Robinson.
2780
2781         Install all English hunspell dictionaries on Fedora and Arch.
2782
2783         * gtk/install-dependencies:
2784
2785 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2786
2787         [GTK] install-dependencies should grok dnf
2788         https://bugs.webkit.org/show_bug.cgi?id=140396
2789
2790         Reviewed by Martin Robinson.
2791
2792         Fedora: install dependencies with dnf if yum is not installed.
2793
2794         * gtk/install-dependencies:
2795
2796 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
2797
2798         [EFL][GTK] Fix build after r178309  
2799         https://bugs.webkit.org/show_bug.cgi?id=140381
2800
2801         Reviewed by Gyuyoung Kim.
2802
2803         * TestWebKitAPI/CMakeLists.txt: Added the API directory
2804
2805 2015-01-11  Sam Weinig  <sam@webkit.org>
2806
2807         Remove support for SharedWorkers
2808         https://bugs.webkit.org/show_bug.cgi?id=140344
2809
2810         Reviewed by Anders Carlsson.
2811
2812         * Scripts/webkitperl/FeatureList.pm:
2813
2814 2015-01-12  Anders Carlsson  <andersca@apple.com>
2815
2816         Make delegates conform to formal delegate protocols
2817         https://bugs.webkit.org/show_bug.cgi?id=140370
2818
2819         Reviewed by Dan Bernstein.
2820
2821         * DumpRenderTree/mac/TestRunnerMac.mm:
2822         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2823         (TestRunner::setGeolocationPermission):
2824
2825 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2826
2827         build-webkit: silence output of 'which'
2828         https://bugs.webkit.org/show_bug.cgi?id=140278
2829
2830         Reviewed by Daniel Bates.
2831
2832         Use a more elegent test for the existance of ninja and eclipse.
2833
2834         * Scripts/webkitdirs.pm:
2835         (commandExists): Don't assume the command supports --version
2836         (canUseNinja): Use commandExists()
2837         (canUseEclipse): Use commandExists()
2838
2839 2015-01-09  Sam Weinig  <sam@webkit.org>
2840
2841         Update the output format for run-api-tests
2842         https://bugs.webkit.org/show_bug.cgi?id=140332
2843
2844         Reviewed by Dan Bernstein.
2845
2846         Changes the output format for run-api-tests be a bit simpler (no longer 
2847         indented based on suite, as we were not really using suite very well) but
2848         also include details in the case of failure.
2849
2850         Changes verbose mode to no longer spew out the gtest default printer output,
2851         as the custom printer now includes the failure information.
2852
2853         * Scripts/run-api-tests:
2854         (runTestsBySuite):
2855         (runTest):
2856         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
2857         with colorized variants and strip out leaks spew (the leaks can be added back using
2858         the new --show-leaks argument).
2859
2860         * TestWebKitAPI/TestsController.cpp:
2861         (TestWebKitAPI::Printer::OnTestPartResult):
2862         (TestWebKitAPI::Printer::OnTestEnd):
2863         (TestWebKitAPI::TestsController::run):
2864         Implement a custom result printer that just prints out the information we want.
2865
2866 2015-01-09  Sam Weinig  <sam@webkit.org>
2867
2868         TestWebKitAPI should print out the lists that fail at the end
2869         https://bugs.webkit.org/show_bug.cgi?id=140329
2870
2871         Reviewed by Tim Horton.
2872
2873         * Scripts/run-api-tests:
2874         (runTestsBySuite):
2875         Print out failures and timeouts in all modes, not just verbose.
2876
2877 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
2878
2879         Make bmalloc work with ASan
2880         https://bugs.webkit.org/show_bug.cgi?id=140194
2881
2882         Reviewed by Mark Lam.
2883
2884         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
2885         ASan automatically (by forwarding to system malloc at runtime).
2886
2887 2015-01-09  Daniel Bates  <dabates@apple.com>
2888
2889         [iOS] Make DumpRenderTree build with public SDK
2890         https://bugs.webkit.org/show_bug.cgi?id=140311
2891
2892         Reviewed by Sam Weinig.
2893
2894         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
2895         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
2896         Additionally, remove unused header CoreGraphics/CGFontDB.h.
2897
2898         * DumpRenderTree/mac/DumpRenderTree.mm:
2899         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
2900
2901 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
2902
2903         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
2904         https://bugs.webkit.org/show_bug.cgi?id=140300
2905
2906         Reviewed by Simon Fraser.
2907
2908         * WebKitTestRunner/TestController.cpp:
2909         (WTR::TestController::createOtherPage):
2910         (WTR::TestController::updateWindowScaleForTest):
2911         (WTR::TestController::configureViewForTest):
2912         * WebKitTestRunner/TestController.h:
2913
2914 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2915
2916         Unreviewed. Moving myself to the committer section.
2917
2918         * Scripts/webkitpy/common/config/contributors.json:
2919
2920 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2921
2922         Add a script to check for platform layering violations
2923         https://bugs.webkit.org/show_bug.cgi?id=140248
2924
2925         Reviewed by Darin Adler.
2926
2927         It prints all the cases where files inside platform include
2928         headers that are not in platform directory.
2929
2930         * Scripts/check-for-platform-layering-violations: Added.
2931         (get_platform_headers):
2932         (check_source_file):
2933
2934 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2935
2936         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
2937         https://bugs.webkit.org/show_bug.cgi?id=139884
2938
2939         Reviewed by Tim Horton.
2940
2941         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
2942         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
2943         what the "nominal resolution" is, but this appears to work in practice.
2944
2945 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
2946
2947         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
2948         https://bugs.webkit.org/show_bug.cgi?id=140256
2949
2950         Reviewed by Anders Carlsson.
2951
2952         * DumpRenderTree/win/DumpRenderTree.cpp:
2953         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
2954         running with heap validation checks.
2955         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
2956         the "svg\\W3C-SVG-1.1" test directory.
2957         (removeFontFallbackIfPresent): Use nullptr instead of 0.
2958         * DumpRenderTree/win/TestRunnerWin.cpp:
2959         (TestRunner::clearPersistentUserStyleSheet): Ditto.
2960
2961 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2962
2963         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
2964         https://bugs.webkit.org/show_bug.cgi?id=140218
2965
2966         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
2967         Undone an accidental change - check for self.has_crashed() again. This code path
2968         is for ports that don't have a signal handler printing #CRASHED when main process
2969         crashes.
2970
2971         * Scripts/webkitpy/port/driver_unittest.py:
2972         (DriverTest.test_check_for_driver_crash.assert_crash):
2973         (DriverTest.test_check_for_driver_crash):
2974         Updated the tests, all changes are expected.
2975
2976 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
2977
2978         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
2979         https://bugs.webkit.org/show_bug.cgi?id=140218
2980
2981         Reviewed by Darin Adler.
2982
2983         * Scripts/webkitpy/port/driver.py:
2984         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
2985         "process crashed" condition. These don't make sense together - it's either a crash
2986         or a timeout, and we should detect those properly at a much lower level.
2987         (Driver.run_test): Ditto.
2988         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
2989         cases.
2990
2991         * WebKitTestRunner/TestController.h:
2992         * WebKitTestRunner/TestController.cpp:
2993         (WTR::TestController::webProcessName): 
2994         (WTR::TestController::processDidCrash):
2995         Factored out hardcoded child process names, as we now use these in two places.
2996
2997         * WebKitTestRunner/TestInvocation.cpp:
2998         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
2999         process name, so that it can be sampled (fixes sampling on Mavericks and above).
3000
3001 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
3002
3003         Reorder my list of email addresses, keeping the Bugzilla address at the
3004         top since Bugzilla and other webkitpy scripts rely on that ordering.
3005
3006         * Scripts/webkitpy/common/config/contributors.json:
3007
3008 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
3009
3010         Moving myself to the reviewers section and updating
3011         the list of my email addresses.
3012
3013         * Scripts/webkitpy/common/config/contributors.json:
3014
3015 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3016
3017         [GTK] Build gtk-doc without gtkdoc-mktmpl
3018         https://bugs.webkit.org/show_bug.cgi?id=140225
3019
3020         Reviewed by Darin Adler.
3021
3022         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
3023         don't modify the tmpl files that it generates, it's not doing anything
3024         for us.
3025
3026         * gtk/gtkdoc.py:
3027         (GTKDoc.generate):
3028         (GTKDoc._run_gtkdoc_scangobj):
3029         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
3030
3031 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
3032
3033         [GTK][ThreadedCompositor] Add support for threaded compositor.
3034         https://bugs.webkit.org/show_bug.cgi?id=118265
3035
3036         Reviewed by Martin Robinson.
3037
3038         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
3039         autotools build systems. The feature is disabled by default.
3040         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
3041         from the feature flags.
3042
3043         * Scripts/webkitperl/FeatureList.pm:
3044
3045 2015-01-07  Daniel Bates  <dabates@apple.com>
3046
3047         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3048         https://bugs.webkit.org/show_bug.cgi?id=137371
3049
3050         Reviewed by David Kilzer.
3051
3052         Use SPI wrapper headers instead of directly referencing private SPI headers.
3053
3054         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3055         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3056         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3057         to the list of iOS header search directories so that we can include header UIKitSPI.h.
3058         * DumpRenderTree/mac/DumpRenderTree.mm:
3059         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3060         * DumpRenderTree/mac/EventSendingController.mm:
3061         * DumpRenderTree/mac/TestRunnerMac.mm:
3062
3063 2015-01-07  Commit Queue  <commit-queue@webkit.org>
3064
3065         Unreviewed, rolling out r178068.
3066         https://bugs.webkit.org/show_bug.cgi?id=140235
3067
3068         Breaks the iOS build (Requested by enrica on #webkit).
3069
3070         Reverted changeset:
3071
3072         "[iOS] Make WebKit2 build with public iOS SDK and more build
3073         fixes for DRT"
3074         https://bugs.webkit.org/show_bug.cgi?id=137371
3075         http://trac.webkit.org/changeset/178068
3076
3077 2015-01-07  Daniel Bates  <dabates@apple.com>
3078
3079         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
3080         https://bugs.webkit.org/show_bug.cgi?id=137371
3081
3082         Reviewed by David Kilzer.
3083
3084         Use SPI wrapper headers instead of directly referencing private SPI headers.
3085
3086         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
3087         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3088         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
3089         to the list of header search directories so that we can include header UIKitSPI.h.
3090         * DumpRenderTree/mac/DumpRenderTree.mm:
3091         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3092         * DumpRenderTree/mac/EventSendingController.mm:
3093         * DumpRenderTree/mac/TestRunnerMac.mm:
3094
3095 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
3096
3097         [Win] Unreviewed test change to improve run reproducibility
3098
3099         * Scripts/webkitpy/port/win.py:
3100         (WinPort.default_child_processes): Run a single DRT instance to help
3101         identify failures caused by earlier test runs.
3102
3103 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3104
3105         Myles C. Maxfield is a reviewer now
3106         https://bugs.webkit.org/show_bug.cgi?id=140196
3107
3108         Reviewed by Dean Jackson.
3109
3110         * Scripts/webkitpy/common/config/contributors.json:
3111
3112 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
3113
3114         Make webkit-patch try harder to find keychain credentials
3115         https://bugs.webkit.org/show_bug.cgi?id=140170
3116
3117         Reviewed by Ryosuke Niwa.
3118
3119         When the user manually enters a password into webkit-patch, we hand that off to the
3120         Keyring Python module. However, that module creates a generic password entry instead
3121         of an internet password entry. We should look for both kinds.
3122
3123         * Scripts/webkitpy/common/net/credentials.py:
3124         (Credentials._run_security_tool):
3125         (Credentials._credentials_from_keychain):
3126         * Scripts/webkitpy/common/net/credentials_unittest.py:
3127         (test_security_output_parse_entry_not_found):
3128         (_assert_security_call):
3129
3130 2015-01-06  Anders Carlsson  <andersca@apple.com>
3131
3132         Try to fix the Mountain Lion build.
3133
3134         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3135         (TestWebKitAPI::didGetImageForMatchResult):
3136
3137 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
3138
3139         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
3140         https://bugs.webkit.org/show_bug.cgi?id=140095
3141
3142         Reviewed by Anders Carlsson.
3143
3144         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
3145         builds, but not in debug ones.
3146
3147 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
3148
3149         [Win] Extend WinLauncher with support for Page Zoom
3150         https://bugs.webkit.org/show_bug.cgi?id=140152
3151
3152         Reviewed by Anders Carlsson.
3153
3154         * WinLauncher/Common.cpp:
3155         (WndProc):
3156         * WinLauncher/WinLauncher.cpp:
3157         (WinLauncher::resetZoom):
3158         (WinLauncher::zoomIn):
3159         (WinLauncher::zoomOut):
3160         * WinLauncher/WinLauncher.h:
3161         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
3162         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
3163         * win/DLLLauncher/DLLLauncherMain.cpp:
3164         (wWinMain):
3165
3166 2015-01-06  Anders Carlsson  <andersca@apple.com>
3167
3168         Fix API tests that are broken under HiDPI
3169         https://bugs.webkit.org/show_bug.cgi?id=140146
3170
3171         Reviewed by Tim Horton.
3172
3173         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3174         (TestWebKitAPI::didGetImageForMatchResult):
3175         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
3176
3177         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3178         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
3179         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
3180         out in a window that has a backing scale factor of 1.
3181  
3182         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3183         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
3184         Ditto.
3185
3186 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
3187
3188         ADDRESS_SANITIZER macro is overloaded
3189         https://bugs.webkit.org/show_bug.cgi?id=140130
3190
3191         Reviewed by Anders Carlsson.
3192
3193         * WebKitTestRunner/TestController.cpp: Use the new macro.
3194
3195 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
3196
3197         Remove some stale class names in check-for-inappropriate-objc-class-names
3198         https://bugs.webkit.org/show_bug.cgi?id=140104
3199
3200         Reviewed by Darin Adler.
3201
3202         * Scripts/check-for-inappropriate-objc-class-names:
3203         These UIWK* classes no longer exist.
3204
3205 2015-01-05  Anders Carlsson  <andersca@apple.com>
3206
3207         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
3208         https://bugs.webkit.org/show_bug.cgi?id=140096
3209         rdar://problem/19368938
3210
3211         Reviewed by Alexey Proskuryakov.
3212
3213         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
3214         since clientInfo points to a web view, not the test controller.
3215
3216         * WebKitTestRunner/TestController.cpp:
3217         (WTR::TestController::createOtherPage):
3218
3219 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
3220
3221         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
3222         https://bugs.webkit.org/show_bug.cgi?id=140077
3223
3224         Reviewed by Csaba Osztrogonác.
3225
3226         WebKit C SPI is available on EFL,GTK.
3227         Changed the define order to pass the API test.
3228
3229         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3230         (TestWebKitAPI::TEST):
3231
3232 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
3233
3234         Simplify WebKitTestRunner timeout tracking
3235         https://bugs.webkit.org/show_bug.cgi?id=140036
3236
3237         Reviewed by Darin Adler.
3238
3239         The code for configuring timeouts was mostly dead, because run-webkit-tests never
3240         passes the --timeout option to WebKitTestRunner.
3241
3242         * WebKitTestRunner/Options.h:
3243         * WebKitTestRunner/Options.cpp:
3244         (WTR::Options::Options):
3245         (WTR::OptionsHandler::OptionsHandler):
3246         (WTR::handleOptionTimeout): Deleted.
3247         Removed support for --timeout. Timeouts are passed for each test individually,
3248         and defaults are good enough for the rare cases where WebKitTestRunner is run
3249         manually without run-webkit-tests.
3250
3251         * WebKitTestRunner/TestController.cpp:
3252         (WTR::TestController::TestController):
3253         (WTR::TestController::initialize):
3254         (WTR::TestController::resetStateToConsistentValues):
3255         (WTR::TestController::reattachPageToWebProcess):
3256         (WTR::TestController::runUntil):
3257         * WebKitTestRunner/TestController.h:
3258         Simplified runUntil by passing the actual timeout, not an enum.
3259         Increased short timeout for ASan enabled builds, as WebProcess launching takes
3260         quite a while.
3261
3262         * WebKitTestRunner/TestInvocation.cpp:
3263         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
3264
3265         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3266         (WTR::TestController::platformRunUntil):
3267         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3268         (WTR::TestController::platformRunUntil):
3269         Build fixes.
3270
3271 2015-01-02  Anders Carlsson  <andersca@apple.com>
3272
3273         Remove now unused storage tracker glue from DumpRenderTree
3274         https://bugs.webkit.org/show_bug.cgi?id=140045
3275
3276         Reviewed by Darin Adler.
3277
3278         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3279         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
3280         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
3281         * DumpRenderTree/TestRunner.cpp:
3282         (TestRunner::staticFunctions):
3283         (syncLocalStorageCallback): Deleted.
3284         (observeStorageTrackerNotificationsCallback): Deleted.
3285         (deleteAllLocalStorageCallback): Deleted.
3286         (deleteLocalStorageForOriginCallback): Deleted.
3287         (localStorageDiskUsageForOriginCallback): Deleted.
3288         (originsWithLocalStorageCallback): Deleted.
3289         * DumpRenderTree/TestRunner.h:
3290         * DumpRenderTree/mac/DumpRenderTree.mm:
3291         (allocateGlobalControllers):
3292         (releaseGlobalControllers):
3293         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3294         * DumpRenderTree/mac/TestRunnerMac.mm:
3295         (TestRunner::syncLocalStorage): Deleted.
3296         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
3297         (TestRunner::observeStorageTrackerNotifications): Deleted.
3298         (TestRunner::deleteAllLocalStorage): Deleted.
3299         (TestRunner::originsWithLocalStorage): Deleted.
3300         (TestRunner::deleteLocalStorageForOrigin): Deleted.
3301         * DumpRenderTree/win/TestRunnerWin.cpp:
3302         (TestRunner::syncLocalStorage): Deleted.
3303         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
3304         (TestRunner::observeStorageTrackerNotifications): Deleted.
3305         (TestRunner::deleteAllLocalStorage): Deleted.
3306         (TestRunner::originsWithLocalStorage): Deleted.
3307         (TestRunner::deleteLocalStorageForOrigin): Deleted.
3308
3309 2015-01-01  Darin Adler  <darin@apple.com>
3310
3311         We often misspell identifier as "identifer"
3312         https://bugs.webkit.org/show_bug.cgi?id=140025
3313
3314         Reviewed by Michael Saboff.
3315
3316         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3317         * Scripts/webkitdirs.pm:
3318         (appIdentifierFromBundle):
3319         (installAndLaunchIOSWebKitAppInSimulator):
3320         Fix misspellings
3321
3322 2015-01-01  Zalan Bujtas  <zalan@apple.com>
3323
3324         Saturated arithmetics: Incorrect float/double clamping.
3325         https://bugs.webkit.org/show_bug.cgi?id=139888
3326         rdar://problem/19330885
3327
3328         Reviewed by Simon Fraser.
3329
3330         Clamp float and double values correctly when applying saturated arithmetics.
3331
3332         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3333         (TestWebKitAPI::TEST):
3334
3335 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
3336
3337         [EFL] Bump version of ATK used by jhbuild to 2.15.2
3338         https://bugs.webkit.org/show_bug.cgi?id=139816
3339
3340         Reviewed by Gyuyoung Kim.
3341
3342         Bump version of ATK used by jhbuild to 2.15.2
3343
3344         * efl/jhbuild.modules:
3345
3346 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
3347
3348         [jhBuild] cairo build error (-flto)
3349         https://bugs.webkit.org/show_bug.cgi?id=139056
3350
3351         Reviewed by Philippe Normand.
3352
3353         cairo fails to link  with gcc 4.9 due to lto
3354         related issue. This problem has been partially
3355         addressed by cairo:
3356         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
3357         use the cairo --disable-lto option and remove jhbuild
3358         makeargs fixes the issue.
3359
3360         * gtk/jhbuild.modules:
3361         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
3362
3363 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
3364         [Mac] Enable kerning, ligatures, and printer fonts 
3365         https://bugs.webkit.org/show_bug.cgi?id=139970
3366
3367         Rubber stamped by Simon Fraser.
3368
3369         Flip the switch.
3370
3371         * DumpRenderTree/mac/DumpRenderTree.mm:
3372         * WebKitTestRunner/TestController.cpp:
3373         * WebKitTestRunner/mac/main.mm:
3374
3375 2014-12-26  Dan Bernstein  <mitz@apple.com>
3376
3377         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
3378         https://bugs.webkit.org/show_bug.cgi?id=139950
3379
3380         Reviewed by David Kilzer.
3381
3382         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
3383         in a manner that works with Xcode 5.1.1.
3384
3385 2014-12-24  Dan Bernstein  <mitz@apple.com>
3386
3387         Engineering builds of MiniBrowser ignore deprecated declaration warnings
3388         https://bugs.webkit.org/show_bug.cgi?id=139941
3389
3390         Reviewed by Darin Adler.
3391
3392         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
3393         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
3394         to YES.
3395         * MiniBrowser/mac/AppDelegate.m:
3396         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
3397         deprecated NSOKButton.
3398
3399 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3400
3401         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
3402         https://bugs.webkit.org/show_bug.cgi?id=134763
3403
3404         Reviewed by Ryosuke Niwa.
3405
3406         Adding an option to disable test harness link conversion.
3407
3408         * Scripts/webkitpy/w3c/test_converter.py:
3409         (convert_for_webkit):
3410         (_W3CTestConverter.__init__):
3411         (_W3CTestConverter.convert_attributes_if_needed):
3412         * Scripts/webkitpy/w3c/test_importer.py:
3413         (parse_args):
3414         (TestImporter.import_tests):
3415
3416 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3417
3418         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
3419         https://bugs.webkit.org/show_bug.cgi?id=139933
3420
3421         Reviewed by Daniel Bates.
3422
3423         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
3424         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
3425         until ReportCrash lets it go.
3426
3427         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
3428         even get the actual crash log eventually - even when it times out waiting for the log, it
3429         makes a second lookup at the very end, after all tests finish. There may be further
3430         improvements needed here, but this small fix addresses most cases that happen in practice.
3431
3432         * DumpRenderTree/mac/DumpRenderTree.mm:
3433         (writeCrashedMessageOnFatalError):
3434         (dumpRenderTree):
3435         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
3436
3437         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
3438         unhelpful comment.
3439
3440 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3441
3442         Don't force -O1 for debug ASan builds
3443         https://bugs.webkit.org/show_bug.cgi?id=139926
3444
3445         Reviewed by Darin Adler.
3446
3447         * asan/asan.xcconfig:
3448
3449 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3450
3451         Simplify building with ASan
3452         https://bugs.webkit.org/show_bug.cgi?id=139916
3453
3454         Reviewed by Mark Rowe.
3455
3456         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
3457         We could also update Configuration file format, but that's a little scary because
3458         of how many places in code read it.
3459
3460         * Scripts/webkitdirs.pm:
3461         (determineASanIsEnabled): Read it from ASan configuration file.
3462         (argumentsForConfiguration): Added a FIXME.
3463         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
3464         (XcodeOptions): Pass the options needed for ASan.
3465
3466         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
3467         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
3468         that automatically.
3469
3470 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
3471
3472         TestWebKitAPI build is broken when ASan is enabled
3473         https://bugs.webkit.org/show_bug.cgi?id=139902
3474
3475         Reviewed by Darin Adler.
3476
3477         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3478         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
3479         Inherit linker flags from DebugRelease, which respects ASAN.
3480
3481 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
3482
3483         Sort the Xcode project file.
3484
3485         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3486
3487 2014-12-22  Lucas Forschler  <lforschler@apple.com>
3488
3489         Update apple-mac-114 to bot629.
3490         
3491         Unreviewed.
3492         
3493         * BuildSlaveSupport/build.webkit.org-config/config.json:
3494
3495 2014-12-22  Lucas Forschler  <lforschler@apple.com>
3496
3497         Replace Apple bot104 with bot124.
3498         
3499         Unreviewed.
3500         
3501         * BuildSlaveSupport/build.webkit.org-config/config.json:
3502
3503 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
3504
3505         URTBF after r177639.
3506
3507         * TestWebKitAPI/CMakeLists.txt:
3508
3509 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3510
3511         [EFL] MiniBrowser steals web view's focus
3512         https://bugs.webkit.org/show_bug.cgi?id=139482
3513
3514         Reviewed by Gyuyoung Kim.
3515
3516         Although we set focus on ewk_view while MiniBrowser initialization
3517         Ecore steals it in a favor of main window. As a result
3518         focused element on web page is unable to receive events.
3519
3520         * MiniBrowser/efl/main.c:
3521         (window_create):
3522         Prevent window from stealing web view's focus on start up.
3523
3524 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
3525
3526         [Win] Revise DRT logic to match Mac.
3527
3528         Rubberstamped by Anders Carlsson.
3529
3530         Update the Windows logic to perform initialization of preferences and WebKit
3531         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
3532         the same circumstances as the Mac version.
3533
3534         * DumpRenderTree/win/DumpRenderTree.cpp:
3535         (dump):
3536         (resetWebPreferencesToConsistentValues):
3537         (setDefaultsToConsistentValuesForTesting):
3538         (resetWebViewToConsistentStateBeforeTesting):
3539         (sizeWebViewForCurrentTest):
3540         (runTest):
3541         (createWebViewAndOffscreenWindow):
3542         (allocateGlobalControllers):
3543         (prepareConsistentTestingEnvironment):
3544         (main):
3545         (resetDefaultsToConsistentValues): Deleted.
3546
3547 2014-12-19  Roger Fong  <roger_fong@apple.com>
3548
3549         Unreviewed. Rollout r177605.
3550
3551         * EWSTools/start-queue-win.sh:
3552
3553 2014-12-19  Roger Fong  <roger_fong@apple.com>
3554
3555         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
3556
3557         * EWSTools/start-queue-win.sh:
3558
3559 2014-12-19  Daniel Bates  <dabates@apple.com>
3560
3561         [iOS] Add WebKitSystemInterface for iOS 8.1
3562         https://bugs.webkit.org/show_bug.cgi?id=139831
3563
3564         Reviewed by Alexey Proskuryakov.
3565
3566         Implement support in copy-webkitlibraries-to-product-directory to copy
3567         WebKitSystemInterface for iOS to the product directory and have build-webkit
3568         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
3569
3570         * Scripts/build-webkit:
3571         * Scripts/copy-webkitlibraries-to-product-directory:
3572
3573 2014-12-19  Daniel Bates  <dabates@apple.com>
3574
3575         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
3576         https://bugs.webkit.org/show_bug.cgi?id=139829
3577
3578         Reviewed by Alexey Proskuryakov.
3579
3580         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
3581         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
3582         expects the Xcode SDK to be specified using the --sdk-name command line argument.
3583
3584         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
3585         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
3586         logic to both avoid duplicating effort and make the command line options for
3587         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
3588         with the approach used in other WebKit tools.
3589
3590         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
3591         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
3592         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
3593
3594         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
3595         improve the readability of the code.
3596         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
3597         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
3598         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
3599         be included in a library.
3600         (unpackIfNecessary): Modified to call executeRanlib().
3601
3602 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
3603
3604         REGRESSION (177368): Some tests started to immediately time out
3605         https://bugs.webkit.org/show_bug.cgi?id=139826
3606
3607         Reviewed by Daniel Bates.
3608
3609         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
3610         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
3611         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
3612         ends in a load failure, we don't dump, so we used to leak the timer.
3613         
3614         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
3615         Added a comment.
3616
3617 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
3618
3619         [Win] Add accessor for serializing HTTP loads
3620         https://bugs.webkit.org/show_bug.cgi?id=139817
3621
3622         Reviewed by Mark Lam.
3623
3624         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
3625         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
3626         remove some redundant code from the destructor.
3627
3628 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
3629
3630         Clean up a fix for performance test bot failing to build
3631         https://bugs.webkit.org/show_bug.cgi?id=139818
3632
3633         Reviewed by Csaba Osztrogonác.
3634
3635         The "_1" in step name was annoying.
3636
3637         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3638         (CleanBuildIfScheduled.start):
3639         (RunAndUploadPerfTests):
3640         (DownloadAndPerfTestFactory.__init__):
3641         (DownloadAndPerfTestWebKit2Factory.__init__):
3642         (CleanBuildUnconditionally): Deleted.
3643         (CleanBuildUnconditionally.start): Deleted.
3644
3645 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
3646
3647         REGRESSION(r177535): It broke the GTK performance bot
3648         https://bugs.webkit.org/show_bug.cgi?id=139811
3649
3650         Reviewed by Carlos Garcia Campos.
3651
3652         Trigger clean build only on mac platform.
3653
3654         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3655         (DownloadAndPerfTestFactory.__init__):
3656         (DownloadAndPerfTestWebKit2Factory.__init__):
3657
3658 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
3659
3660         Unreviewed, moved myself to the list of committers.
3661
3662         * Scripts/webkitpy/common/config/contributors.json:
3663
3664 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
3665