prepare-ChangeLog: Look for a text editor in a few more variables.
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
2
3         prepare-ChangeLog: Look for a text editor in a few more variables.
4         https://bugs.webkit.org/show_bug.cgi?id=76289
5
6         Reviewed by Ryosuke Niwa.
7
8         A text editor was looked for only in the CHANGE_LOG_EDITOR and
9         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
10         to the OS X-specific open(1) command.
11
12         As there does not seem to be a common way of looking for a text editor
13         among the scripts in Tools/Scripts right now, just look at $VISUAL and
14         $EDITOR (set much more often than the other variables in Unix systems)
15         before falling back to open(1).
16
17         * Scripts/prepare-ChangeLog:
18         (openChangeLogs):
19
20 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
21
22         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
23         https://bugs.webkit.org/show_bug.cgi?id=76269
24
25         Reviewed by Martin Robinson.
26
27         * gtk/gtkdoc.py:
28         (GTKDoc._run_gtkdoc_scangobj):
29
30 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
31
32         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
33         https://bugs.webkit.org/show_bug.cgi?id=76247
34
35         Reviewed by Kenneth Rohde Christiansen.
36
37         * WebKitTestRunner/TestController.cpp:
38         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
39
40 2012-01-13  Hajime Morrita  <morrita@chromium.org>
41
42         [Mac][DRT] Should support --no-timeout
43         https://bugs.webkit.org/show_bug.cgi?id=76242
44
45         Reviewed by Darin Adler.
46
47         * DumpRenderTree/mac/DumpRenderTree.mm:
48         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
49         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
50         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
51         * DumpRenderTree/mac/DumpRenderTreeMac.h:
52         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
53         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
54
55 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
56
57         Mitigate scrollbar differences when running pixel tests
58         https://bugs.webkit.org/show_bug.cgi?id=67217
59
60         Reviewed by Dan Bernstein.
61         
62         Enable mock scrollbars by default for tests.
63
64         * DumpRenderTree/mac/DumpRenderTree.mm:
65         (resetDefaultsToConsistentValues):
66         * WebKitTestRunner/TestController.cpp:
67         (WTR::TestController::resetStateToConsistentValues):
68
69 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
70
71         Need a script to run tests in PerformanceTests
72         https://bugs.webkit.org/show_bug.cgi?id=76132
73
74         Reviewed by Adam Barth.
75
76         Add run-perf-tests to run performance tests using parser/resources/runner.js.
77         Unfortunately, there isn't an easy way of telling which test uses which format
78         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
79
80         All test outputs are re-formatted to match Chromium perf-bot style.
81
82         * Scripts/run-inspector-perf-tests.py:
83         * Scripts/run-perf-tests: Added.
84         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
85         (PerfTestsRunner):
86         (PerfTestsRunner.__init__):
87         (PerfTestsRunner._collect_tests):
88         (PerfTestsRunner.run):
89         (PerfTestsRunner._print_status):
90         (PerfTestsRunner._run_tests_set):
91         (PerfTestsRunner._process_chromium_style_test_result):
92         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
93         (PerfTestsRunner._process_parser_test_result):
94         (PerfTestsRunner._run_single_test):
95         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
96         (MainTest.TestDriver.run_test):
97         (create_runner):
98         (run_test):
99         (test_run_test_set):
100         (test_run_test_set_for_parser_tests):
101         (test_collect_tests):
102
103 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
104
105         webkitpy: clean up port unit tests in preparation for making port_name mandatory
106         https://bugs.webkit.org/show_bug.cgi?id=76123
107
108         Reviewed by Adam Barth.
109
110         This change updates the unit tests to be more consistent in how
111         ports are created, in preparation for making port_name a
112         mandatory parameter to the constructor and removing any version
113         interpretation from it.
114
115         There should be no functional changes in this patch, but some
116         tests that are no longer relevant have been removed or reworked.
117
118         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
119         (PortTest.test_get_option__default):
120         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
121         (ChromiumLinuxPortTest):
122         (ChromiumLinuxPortTest.assert_architecture):
123         (ChromiumLinuxPortTest.test_determine_architecture_fails):
124         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
125         (ChromiumMacPortTest):
126         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
127         (ChromiumPortTest):
128         (ChromiumPortTest.test_all_test_configurations):
129         (ChromiumPortTest.TestMacPort.__init__):
130         (ChromiumPortTest.TestLinuxPort.__init__):
131         (ChromiumPortTest.TestWinPort.__init__):
132         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
133         (ChromiumWinTest):
134         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
135         (EflPortTest):
136         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
137         (GtkPortTest):
138         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
139         (MacTest):
140         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
141         (MockDRTPortTest):
142         (MockDRTPortTest.make_port):
143         * Scripts/webkitpy/layout_tests/port/qt.py:
144         (QtPort._port_flag_for_scripts):
145         (QtPort.__init__):
146         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
147         (QtPortTest):
148         (QtPortTest._assert_search_path):
149         (QtPortTest.test_baseline_search_path):
150         (QtPortTest.test_operating_system):
151         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
152         (WebKitPortTest):
153         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
154         (WinPortTest):
155         (WinPortTest._assert_search_path):
156         (WinPortTest.test_baseline_search_path):
157         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
158         (get_test_config.TestMacPort.__init__):
159
160 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
161
162         test-webkitpy: clean up logging and provide a real --help message
163         https://bugs.webkit.org/show_bug.cgi?id=76142
164
165         Reviewed by Adam Barth.
166
167         This test is mostly more refactoring - it calls objects in
168         unittest directly instead of routing through unittest.main() --
169         in order to gain more control over the logging and to provide a
170         correct --help message. This will also give us a better
171         foundation for adding more feautures down the road.
172
173         This patch adds different levels of logging controlled by the
174         '-s', '-q', and '-v' options (see --help for details), and
175         removes the --verbose-logging option.
176
177         * Scripts/test-webkitpy:
178         * Scripts/webkitpy/test/main.py:
179         (Tester):
180         (Tester.clean_packages):
181         (Tester.__init__):
182         (Tester.parse_args):
183         (Tester.configure):
184         (Tester._configure_logging):
185         (Tester.find_modules):
186         (Tester._exclude):
187         (Tester._modules_from_paths):
188         (Tester.run_tests):
189
190 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
191
192         Make the new WTF module build on Qt
193         https://bugs.webkit.org/show_bug.cgi?id=76163
194
195         Reviewed by Tor Arne Vestbø.
196
197         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
198
199 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
200
201         Unreviewed, mac DumpRenderTree fix.
202
203         * DumpRenderTree/mac/UIDelegate.mm:
204         (-[UIDelegate webView:addMessageToConsole:withSource:]):
205
206 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
207
208         WebKitTestRunner should not print console message line number when it is equal to zero.
209         https://bugs.webkit.org/show_bug.cgi?id=76167
210
211         Reviewed by Csaba Osztrogonác.
212
213         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
214         (WTR::InjectedBundlePage::willAddMessageToConsole):
215
216 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
217
218         Make default console messages line numbers consistent.
219         https://bugs.webkit.org/show_bug.cgi?id=74075
220
221         Reviewed by Pavel Feldman.
222
223         Unset line numbers are not printed to console now.
224         Added Source/WebCore/inspector to efl DumpRenderTree include path.
225
226         * DumpRenderTree/chromium/WebViewHost.cpp:
227         (WebViewHost::didAddMessageToConsole):
228         * DumpRenderTree/efl/CMakeLists.txt:
229         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
230         (onConsoleMessage):
231         * DumpRenderTree/gtk/DumpRenderTree.cpp:
232         (webViewConsoleMessage):
233         * DumpRenderTree/mac/UIDelegate.mm:
234         (-[UIDelegate webView:addMessageToConsole:withSource:]):
235         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
236         (WebCore::WebPage::javaScriptConsoleMessage):
237         * DumpRenderTree/win/UIDelegate.cpp:
238         (UIDelegate::webViewAddMessageToConsole):
239         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
240         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
241
242 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
243
244         test-webkitpy: push more logic into webkitpy.test.main, clean up code
245         https://bugs.webkit.org/show_bug.cgi?id=76021
246
247         Reviewed by Eric Seidel.
248
249         I plan to add more functionality to test-webkitpy, but it is
250         difficult to hack on now; this patch is the first of two that
251         brings test-webkitpy more inline with current coding style by
252         pushing more logic into the webkitpy.test.main.Tester class (so
253         that it will be testable itself).
254         
255         There should be no functional changes in this patch.
256
257         * Scripts/test-webkitpy:
258         (_path_from_webkit_root):
259         * Scripts/webkitpy/test/main.py:
260         (Tester):
261         (Tester.init):
262         (Tester.configure_logging):
263         (Tester.configure_logging.filter):
264         (Tester.clean_packages):
265         (Tester.run_tests):
266
267 2012-01-11  Wei Jia  <wjia@chromium.org>
268
269         implement layout tests for <video> with media stream
270         https://bugs.webkit.org/show_bug.cgi?id=74882
271
272         Reviewed by Kent Tamura.
273
274         * DumpRenderTree/DumpRenderTree.gypi:
275         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
276         (WebKit::WebUserMediaClientMock::create):
277         (WebKit::WebUserMediaClientMock::IsMockStream):
278         (WebKit::WebUserMediaClientMock::requestUserMedia):
279         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
280         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
281         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
282         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
283         * DumpRenderTree/chromium/WebViewHost.cpp:
284         (WebViewHost::userMediaClient):
285         (WebViewHost::userMediaClientMock):
286         (WebViewHost::createMediaPlayer):
287         (WebViewHost::mediaStreamUtil):
288         (WebViewHost::testMediaStreamClient):
289         * DumpRenderTree/chromium/WebViewHost.h:
290
291 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
292
293         Unreviewed, build fix.
294
295         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
296
297         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
298         (ChromiumWinPort.__init__):
299
300 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
301
302         Sheriffbot build fix. Don't emit empty lines on IRC.
303
304         * Scripts/webkitpy/tool/bot/irc_command.py:
305         (LastGreenRevision.execute):
306
307 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
308
309         last-green-revision should report the revision that succeeded on all bots
310         https://bugs.webkit.org/show_bug.cgi?id=76109
311
312         Reviewed by Adam Barth.
313
314         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
315         considered green by this algorithm, all matching builders must have a successful run at the revision
316         or two consecutive successful runs before and after the revision.
317
318         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
319         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
320
321         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
322         (BuildBot._revisions_for_builder):
323         (BuildBot):
324         (BuildBot._find_green_revision):
325         (BuildBot.last_green_revision):
326         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
327         (MockBuildBot.last_green_revision):
328         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
329         (test_revisions_for_builder):
330         (test_find_green_revision):
331         (test_last_green_revision):
332         * Scripts/webkitpy/tool/bot/irc_command.py:
333         (LastGreenRevision.execute):
334         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
335         (SheriffIRCBotTest.test_lgr):
336         * Scripts/webkitpy/tool/commands/queries.py:
337         (LastGreenRevision):
338
339 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
340
341         Unreviewed, fix build bustage on win32 introduced by r104725.
342
343         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
344         (MockDRTPortTest.make_port):
345         (MockChromiumDRTTest.test_pixeltest__fails):
346
347 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
348
349         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
350         https://bugs.webkit.org/show_bug.cgi?id=75618
351
352         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
353
354         Reviewed by Tony Chang.
355
356         * DumpRenderTree/chromium/LayoutTestHelper.mm:
357         (installLayoutTestColorProfile):
358         (restoreUserColorProfile):
359         (main):
360
361 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
362
363         test-webkitpy: fix -v and eliminate some spurious warnings
364         https://bugs.webkit.org/show_bug.cgi?id=76099
365
366         Reviewed by Adam Barth.
367
368         when we added support for --xml output, we broke the -v flag.
369
370         Also, fix the code to swallow a harmless warning from
371         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
372
373         test-webkitpy is now silent again except for the one known
374         logging issue.
375
376         * Scripts/webkitpy/common/checkout/checkout.py:
377         (Checkout.commit_message_for_this_commit):
378         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
379         (test_commit_message_for_this_commit):
380         * Scripts/webkitpy/style/checkers/jsonchecker.py:
381         (JSONChecker.check):
382         (JSONChecker.line_number_from_json_exception):
383         * Scripts/webkitpy/test/main.py:
384         (Tester.run_tests):
385
386 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
387
388         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
389         https://bugs.webkit.org/show_bug.cgi?id=76084
390
391         Reviewed by Adam Barth.
392
393         This will help make it easier to catch layering violations. This
394         change just refactors test code; there are no changes to
395         production code.
396
397         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
398         (PortTest.make_port):
399         (PortTest.test_find_no_paths_specified):
400         (PortTest.test_find_one_test):
401         (PortTest.test_find_glob):
402         (PortTest.test_find_with_skipped_directories):
403         (PortTest.test_find_with_skipped_directories_2):
404         (PortTest.test_parse_reftest_list):
405         (PortTest.test_httpd_returns_error_code):
406         (PortTest.test_virtual_methods):
407         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
408         (ChromiumGpuTest.assert_port_works):
409         (ChromiumGpuTest._assert_baseline_path):
410         (ChromiumGpuTest.test_graphics_type):
411         (ChromiumGpuTest.test_default_tests_paths.test_paths):
412         (ChromiumGpuTest.test_test_files):
413         (ChromiumGpuTest.test_test_files.test_paths):
414         (ChromiumGpuTest):
415         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
416         (ChromiumLinuxPortTest.assert_architecture):
417         (ChromiumLinuxPortTest.test_check_illegal_port_names):
418         (ChromiumLinuxPortTest.test_determine_architecture_fails):
419         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
420         (DriverTest.make_port):
421         (DriverTest):
422         (DriverTest.assertVirtual):
423         (DriverTest._assert_wrapper):
424         (DriverTest.test_virtual_driver_methods):
425         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
426         (MockDRTPortTest.make_port):
427         (MockDRTPortTest.test_port_name_in_constructor):
428         (MockDRTTest.assertTest):
429         (MockDRTTest.test_main):
430         (MockChromiumDRTTest.test_pixeltest__fails):
431         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
432         (QtPortTest._assert_search_path):
433         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
434         (TestWebKitPort.__init__):
435         (WebKitPortUnitTests.test_default_options):
436         (test_runtime_feature_list):
437         (test_test_expectations):
438
439 2012-01-11  Ojan Vafai  <ojan@chromium.org>
440
441         Style skipped tests in the flakiness dashboard
442         https://bugs.webkit.org/show_bug.cgi?id=76091
443
444         Reviewed by Tony Chang.
445
446         * TestResultServer/static-dashboards/dashboard_base.js:
447         Removed "FLAKY" from this list since we don't ever mark individual runs
448         as flaky. Also deleted an outdated line.
449         * TestResultServer/static-dashboards/flakiness_dashboard.html:
450
451 2012-01-11  Ojan Vafai  <ojan@chromium.org>
452
453         Remove gtest normalization code from the test results server
454         https://bugs.webkit.org/show_bug.cgi?id=76089
455
456         Reviewed by Tony Chang.
457
458         The normalization now happens on the gtest side.
459
460         * TestResultServer/model/jsonresults.py:
461         (JsonResults.merge):
462         * TestResultServer/model/jsonresults_unittest.py:
463         (JsonResultsTest.test_gtest):
464
465 2012-01-11  Ojan Vafai  <ojan@chromium.org>
466
467         Be more aggressive about deleting unnecessary results from the test-results-server json files
468         https://bugs.webkit.org/show_bug.cgi?id=76086
469
470         Reviewed by Tony Chang.
471
472         Remove any tests that only contain skip/pass/nodata values whose runtime
473         is less than 5 seconds.
474
475         * TestResultServer/model/jsonresults.py:
476         (JsonResults._normalize_results_json):
477         * TestResultServer/model/jsonresults_unittest.py:
478         (JsonResultsTest.test_merge_remove_test):
479         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
480
481 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
482
483         last-green-revision should give us per-bot information
484         https://bugs.webkit.org/show_bug.cgi?id=76011
485
486         Reviewed by Adam Barth.
487
488         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
489         we report the latest green run on each bot from the last 100 runs.
490
491         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
492         (BuildBot._fetch_builder_page):
493         (BuildBot):
494         (BuildBot._green_revision_for_builder):
495         (BuildBot.last_green_revision):
496         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
497         (test_green_revision_for_builder):
498         (test_last_green_revision):
499         * Scripts/webkitpy/tool/bot/irc_command.py:
500         (LastGreenRevision.execute):
501         * Scripts/webkitpy/tool/commands/queries.py:
502         (LastGreenRevision.execute):
503
504 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
505
506         webkitpy: clean up version detection in webkitpy.layout_tests.port
507         https://bugs.webkit.org/show_bug.cgi?id=76016
508
509         Reviewed by Adam Barth.
510
511         This change updates the code in webkitpy.layout_tests.port to
512         use the new os_name and os_version fields on host.platform. This
513         gets layout_tests.port out of the version parsing business. Most
514         of the diffs are just cleaning up test code to accomodate the
515         changes.
516
517         * Scripts/webkitpy/common/system/executive_mock.py:
518         (MockExecutive):
519         (MockExecutive.ignore_error):
520         (MockExecutive2):
521         (MockExecutive2.ignore_error):
522         * Scripts/webkitpy/common/system/platforminfo_mock.py:
523         (MockPlatformInfo.is_mac):
524         (MockPlatformInfo.is_linux):
525         (MockPlatformInfo.is_win):
526         * Scripts/webkitpy/common/system/systemhost_mock.py:
527         (MockSystemHost.__init__):
528         * Scripts/webkitpy/layout_tests/port/apple.py:
529         (ApplePort.__init__):
530         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
531         (ChromiumMacPort.__init__):
532         (ChromiumMacPort.check_wdiff):
533         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
534         (ChromiumMacPortTest):
535         (ChromiumMacPortTest.assert_name):
536         (ChromiumMacPortTest.test_versions):
537         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
538         (ChromiumPortTest.test_all_test_configurations):
539         (ChromiumPortTest.TestMacPort.__init__):
540         (ChromiumPortTest.TestLinuxPort.__init__):
541         (ChromiumPortTest.TestWinPort.__init__):
542         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
543         (ChromiumWinPort.__init__):
544         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
545         (ChromiumWinTest):
546         (ChromiumWinTest.assert_name):
547         (ChromiumWinTest.test_versions):
548         (ChromiumWinTest.test_baseline_path):
549         (ChromiumWinTest.test_build_path):
550         * Scripts/webkitpy/layout_tests/port/factory.py:
551         (PortFactory._port_name_from_arguments_and_options):
552         (PortFactory.get):
553         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
554         (FactoryTest):
555         (FactoryTest.setUp):
556         (FactoryTest.assert_port):
557         (FactoryTest.test_mac):
558         (FactoryTest.test_win):
559         (FactoryTest.test_google_chrome):
560         (FactoryTest.test_gtk):
561         (FactoryTest.test_qt):
562         (FactoryTest.test_chromium_gpu):
563         (FactoryTest.test_chromium_gpu_linux):
564         (FactoryTest.test_chromium_gpu_mac):
565         (FactoryTest.test_chromium_gpu_win):
566         (FactoryTest.test_chromium_mac):
567         (FactoryTest.test_chromium_linux):
568         (FactoryTest.test_chromium_win):
569         (FactoryTest.test_unknown_specified):
570         (FactoryTest.test_unknown_default):
571         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
572         (TestGoogleChromePort):
573         (TestGoogleChromePort._verify_baseline_path):
574         (TestGoogleChromePort._verify_expectations_overrides):
575         (TestGoogleChromePort.test_get_google_chrome_port):
576         * Scripts/webkitpy/layout_tests/port/mac.py:
577         (MacPort):
578         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
579         (MacTest):
580         (assert_name):
581         (test_tests_for_other_platforms):
582         (test_version):
583         (test_versions):
584         (test_is_version_methods):
585         (test_setup_environ_for_server):
586         (_assert_search_path):
587         (test_show_results_html_file):
588         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
589         (PortTestCase):
590         (PortTestCase.make_port):
591         * Scripts/webkitpy/layout_tests/port/win.py:
592         (WinPort):
593         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
594         (WinPortTest):
595         (WinPortTest.test_show_results_html_file):
596         (WinPortTest._assert_search_path):
597         (WinPortTest._assert_version):
598
599 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
600
601         [Qt][WK2] Remove workaround introduced into bug 75470
602         https://bugs.webkit.org/show_bug.cgi?id=75889
603
604         Reviewed by Tor Arne Vestbø.
605
606         * MiniBrowser/qt/qml/BrowserWindow.qml:
607
608 2012-01-10  Dmitry Lomov  <dslomov@google.com>
609
610         [Chromium] Remove obsolete references to WebWorker class.
611         https://bugs.webkit.org/show_bug.cgi?id=76020
612
613         Reviewed by David Levin.
614
615         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
616         * DumpRenderTree/chromium/WebViewHost.cpp:
617         * DumpRenderTree/chromium/WebViewHost.h:
618
619 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
620
621         [Qt] Some css3 filter tests are failing after r104698
622         https://bugs.webkit.org/show_bug.cgi?id=76055
623
624         Reviewed by Simon Hausmann.
625
626         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
627         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
628
629 2012-01-11  Tony Chang  <tony@chromium.org>
630
631         Don't remove 0 byte files when running build-webkit --chromium
632         https://bugs.webkit.org/show_bug.cgi?id=75997
633
634         Reviewed by Csaba Osztrogonác.
635
636         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
637
638         * Scripts/webkitdirs.pm:
639         (determineIsQt):
640
641 2012-01-10  David Kilzer  <ddkilzer@apple.com>
642
643         Add TestWebKitAPI tests for KURL
644         <http://webkit.org/b/75774>
645
646         Reviewed by Adam Barth.
647
648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
649         WebCore folder and KURL.cpp source file to the project.
650         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
651         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
652         during setup since this test doesn't go through WebKit or
653         WebKit2.
654         (TestWebKitAPI::TEST_F): Add two basic tests.
655
656 2012-01-10  David Kilzer  <ddkilzer@apple.com>
657
658         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
659
660         Reviewed by Adam Barth.
661
662         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
663
664         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
665         WTFStringUtilities.h to the project.
666         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
667         WTFStringUtilities.h.
668         * TestWebKitAPI/WTFStringUtilities.h: Added.
669         (WTF::operator<<):
670
671 2012-01-10  Vincent Scheib  <scheib@chromium.org>
672
673         Clarify run-webkit-tests options reset-results and new-baseline
674         https://bugs.webkit.org/show_bug.cgi?id=75993
675
676         Reviewed by Dirk Pranke.
677
678         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
679         (parse_args):
680
681 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
682
683         Disabled mock scrollbars should draw differently
684         https://bugs.webkit.org/show_bug.cgi?id=75995
685
686         Reviewed by James Robinson.
687
688         When the scrollbar is disabled, paint the entire track of
689         mock scrollbars with a lighter gray, and hide the thumb.
690
691         * DumpRenderTree/mac/DumpRenderTree.mm:
692         (-[DRTMockScroller drawKnob]):
693         (-[DRTMockScroller drawRect:]):
694
695 2012-01-10  James Robinson  <jamesr@chromium.org>
696
697         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
698         https://bugs.webkit.org/show_bug.cgi?id=75988
699
700         Reviewed by Adam Barth.
701
702         * Scripts/webkitpy/common/config/ports.py:
703         (WebKitPort.run_webkit_unit_tests_command):
704         (WebKitPort):
705         (ChromiumPort.run_webkit_unit_tests_command):
706         (ChromiumPort):
707         * Scripts/webkitpy/common/config/ports_mock.py:
708         (MockPort.run_webkit_unit_tests_command):
709         * Scripts/webkitpy/tool/commands/download_unittest.py:
710         (DownloadCommandsTest.test_build_and_test):
711         (test_land):
712         (test_land_red_builders):
713         * Scripts/webkitpy/tool/steps/runtests.py:
714         (RunTests.run):
715         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
716
717 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
718
719         webkitpy: add os_name, os_version to platforminfo
720         https://bugs.webkit.org/show_bug.cgi?id=75931
721
722         Reviewed by Eric Siedel.
723
724         As a first step in cleaning up the version parsing logic in
725         webkitpy.layout_tests.port, this adds common routines for
726         getting the os_name and os_version fields to the PlatformInfo
727         class. Nothing uses them yet but I've added FIXME's to some of
728         the code that needs to be deleted in the port files.
729
730         * Scripts/webkitpy/common/system/platforminfo.py:
731         (PlatformInfo.__init__):
732         (PlatformInfo):
733         (PlatformInfo._determine_os_name):
734         (PlatformInfo._determine_mac_version):
735         (PlatformInfo._determine_linux_version):
736         (PlatformInfo._determine_win_version):
737         (PlatformInfo.display_name):
738         (PlatformInfo.total_bytes_memory):
739         (PlatformInfo._compute_bytes_from_vm_stat_output):
740         (PlatformInfo.free_bytes_memory):
741         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
742         (TestPlatformInfo):
743         (TestPlatformInfo.make_info):
744         (TestPlatformInfo.make_info.mock_run_command):
745         (TestPlatformInfo.setUp):
746         (TestPlatformInfo.tearDown):
747         (TestPlatformInfo.test_basic):
748         (TestPlatformInfo.integration_test_basic):
749         (TestPlatformInfo.test_display_name_mac):
750         (TestPlatformInfo.test_display_name_win32):
751         (TestPlatformInfo.test_memory_mac):
752         (TestPlatformInfo.test_memory_win32):
753         (TestPlatformInfo.test_determine_os_name):
754         (TestPlatformInfo.test_determine_mac_version):
755         (TestPlatformInfo.test_determine_linux_version):
756         (TestPlatformInfo.test_determine_win_version_from_tuple):
757         (TestPlatformInfo.test_determine_win_version_from_cmd):
758         * Scripts/webkitpy/layout_tests/port/apple.py:
759         (ApplePort.__init__):
760         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
761         (ChromiumMacPort.__init__):
762         * Scripts/webkitpy/layout_tests/port/mac.py:
763         (MacPort):
764         * Scripts/webkitpy/layout_tests/port/win.py:
765         (WinPort):
766
767 2012-01-10  Adam Roben  <aroben@apple.com>
768
769         Make it possible to type data: URLs into MiniBrowser on Windows
770
771         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
772         MiniBrowser on Windows
773
774         Reviewed by Darin Adler.
775
776         * MiniBrowser/win/BrowserWindow.cpp:
777         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
778         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
779         does, we assume it already has a scheme and don't modify it.
780
781 2012-01-10  Adam Roben  <aroben@apple.com>
782
783         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
784
785         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
786         MiniBrowser on Windows
787
788         Reviewed by Darin Adler.
789
790         * MiniBrowser/win/BrowserView.cpp:
791         (BrowserView::goToURL): Pass the typed string through
792         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
793
794 2012-01-10  Ben Wells  <benwells@chromium.org>
795
796         Adding myself (benwells) to committers.py
797         https://bugs.webkit.org/show_bug.cgi?id=75971
798
799         Reviewed by Ojan Vafai.
800
801         * Scripts/webkitpy/common/config/committers.py:
802
803 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
804
805         AX: support helpText() in DumpRenderTree
806         https://bugs.webkit.org/show_bug.cgi?id=40193
807
808         Reviewed by Chris Fleizach.
809
810         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
811         (AccessibilityUIElement::helpText): Implemented.
812
813 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
814
815         Unreviewed, rolling out r104572.
816         http://trac.webkit.org/changeset/104572
817         https://bugs.webkit.org/show_bug.cgi?id=75967
818
819         It broke zillion tests (Requested by Ossy on #webkit).
820
821         * DumpRenderTree/qt/EventSenderQt.cpp:
822         (EventSender::EventSender):
823         (EventSender::sendOrQueueEvent):
824         (EventSender::replaySavedEvents):
825         (EventSender::eventFilter):
826         * DumpRenderTree/qt/EventSenderQt.h:
827
828 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
829
830         [Qt] fast/events/dont-loose-last-event test fails on WK1
831         https://bugs.webkit.org/show_bug.cgi?id=73894
832
833         Reviewed by Simon Hausmann.
834
835         Empty the entire event queue when requested besides using
836         sendEvent instead of postEvent to make sure all events were
837         delivered.
838         This commit also removes not working DRT code to handle drag and drop,
839         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
840
841         * DumpRenderTree/qt/EventSenderQt.cpp:
842         (EventSender::EventSender):
843         (EventSender::sendOrQueueEvent):
844         (EventSender::replaySavedEvents):
845         * DumpRenderTree/qt/EventSenderQt.h:
846
847 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
848
849         [Qt] Enable CSS_FILTERS in Qt build
850         https://bugs.webkit.org/show_bug.cgi?id=75777
851
852         Add the CSS_FILTERS feature flag to Qt.
853
854         Reviewed by Kenneth Rohde Christiansen.
855
856         * qmake/mkspecs/features/features.prf:
857
858 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
859
860         [Qt] Unreviewed -Werror build fix.
861
862         * MiniBrowser/qt/MiniBrowserApplication.cpp:
863         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
864         declaration.
865
866 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
867
868         [Qt] Remove dependency to uitools
869         https://bugs.webkit.org/show_bug.cgi?id=75952
870
871         Reviewed by Tor Arne Vestbø.
872
873         QUiLoader is used for creating QLabel/QProgressBar widgets for
874         a layout test, to verify some widget embedding feature. Unfortunately
875         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
876         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
877         let's break the circular dependency.
878
879         * DumpRenderTree/qt/DumpRenderTree.pro:
880         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
881         (WebCore::WebPage::createPlugin):
882         * QtTestBrowser/QtTestBrowser.pro:
883         * QtTestBrowser/launcherwindow.h:
884         * QtTestBrowser/webpage.cpp:
885         (WebPage::createPlugin):
886         * qmake/mkspecs/features/minimal_qt.prf:
887         * qmake/mkspecs/features/uitools.prf: Removed.
888
889 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
890
891         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
892         https://bugs.webkit.org/show_bug.cgi?id=75894
893
894         Reviewed by Tor Arne Vestbø.
895
896         * MiniBrowser/qt/MiniBrowserApplication.h:
897         (MiniBrowserApplication::windowOptions):
898         * MiniBrowser/qt/main.cpp:
899         (main):
900
901 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
902
903         [Qt] DRT crashes with Qt 5
904         https://bugs.webkit.org/show_bug.cgi?id=75951
905
906         Reviewed by Ossy.
907
908         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
909         Qt relies on font-config to define the default font family.
910
911 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
912
913         [Qt] REGRESSION(r100130): Clean build feature is broken.
914         https://bugs.webkit.org/show_bug.cgi?id=75863
915
916         Reviewed by Tor Arne Vestbø.
917
918         * Scripts/webkitdirs.pm:
919         (buildQMakeProject):
920
921 2012-01-10  Zeno Albisser  <zeno@webkit.org>
922
923         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
924         https://bugs.webkit.org/show_bug.cgi?id=75885
925
926         In QML events are propagated through parents. But since the
927         WebView may consume key events, a shortcut might never reach
928         the top QtQuickItem.
929         Therefore an application wide event handling function in C++
930         needs to take care of shortcuts for MiniBrowser.
931
932         Reviewed by Kenneth Rohde Christiansen.
933
934         * MiniBrowser/qt/BrowserWindow.cpp:
935         (BrowserWindow::reload):
936         (BrowserWindow::focusAddressBar):
937         * MiniBrowser/qt/BrowserWindow.h:
938         * MiniBrowser/qt/MiniBrowserApplication.cpp:
939         (MiniBrowserApplication::notify):
940         * MiniBrowser/qt/qml/BrowserWindow.qml:
941
942 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
943
944         Add --efl alias for --platform=efl to run-webkit-test
945         https://bugs.webkit.org/show_bug.cgi?id=75937
946
947         Reviewed by Andreas Kling.
948         
949         * Scripts/run-webkit-tests: Add --efl alias.
950         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
951         (parse_args):
952
953 2012-01-09  Dan Bernstein  <mitz@apple.com>
954
955         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
956         https://bugs.webkit.org/show_bug.cgi?id=75920
957
958         Reviewed by Darin Adler.
959
960         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
961         (TestWebKitAPI::TEST): Added a test for a range in a
962         -webkit-user-select: none; block.
963
964 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
965
966         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
967         https://bugs.webkit.org/show_bug.cgi?id=75884
968
969         Reviewed by Ryosuke Niwa.
970
971         Fix regression introduced (revealed?) in r104340. Chromium file         
972         url syntax is different on win32 and the test results weren't           
973         expecting that.                                                         
974
975         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
976         (TestExpectations._report_errors):
977         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
978         (test_parse_error_nonfatal):
979         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
980         (MockDRTTest.input_line):
981         (MockChromiumDRTTest.test_pixeltest__fails):
982         * Scripts/webkitpy/layout_tests/port/test.py:
983         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
984         (TestRebaseliner.make_rebaseliner):
985         (TestRebaseliner.test_one_platform):
986         (TestRebaseliner.test_all_platforms):
987         (TestRebaseliner.test_png_file_with_comment):
988         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
989         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
990         (TestRealMain.test_all_platforms):
991
992 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
993
994         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
995
996         Unreviewed, build fix.
997
998         test-webkitpy had a built-in self-test routine to verify that
999         deleting the .pyc files worked correctly. When I removed the
1000         python24 directory in r104482, I broke the self-test.
1001
1002         I have deleted the self-test for now. Since I am reworking
1003         test-webkitpy I will make sure the new version is adequately
1004         tested.
1005
1006         * Scripts/test-webkitpy:
1007         (configure_logging):
1008         (_clean_pyc_files):
1009         (_clean_packages):
1010         (init):
1011
1012 2012-01-09  Justin Novosad  <junov@chromium.org>
1013
1014         [Chromium] remove all references to the legacy accelerated 2d Canvas
1015         implementation
1016         https://bugs.webkit.org/show_bug.cgi?id=75108
1017
1018         Purging an old settings flag that is no longer referenced
1019
1020         Reviewed by Darin Fisher.
1021
1022         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1023         (main):
1024         * DumpRenderTree/chromium/TestShell.cpp:
1025         (TestShell::TestShell):
1026         (TestShell::resetWebSettings):
1027         * DumpRenderTree/chromium/TestShell.h:
1028         (TestShell::setAccelerated2dCanvasEnabled):
1029         * DumpRenderTree/chromium/WebPreferences.cpp:
1030         (WebPreferences::reset):
1031         (WebPreferences::applyTo):
1032         * DumpRenderTree/chromium/WebPreferences.h:
1033
1034 2012-01-09  Adam Roben  <aroben@apple.com>
1035
1036         Convert Cygwin paths to Windows paths before passing them to DRT
1037
1038         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
1039         NRWT
1040
1041         I couldn't find a way to test this because I couldn't figure out how to override the
1042         cygpath function as it is used by WebKitDriver.
1043
1044         Reviewed by Dirk Pranke.
1045
1046         * Scripts/webkitpy/layout_tests/port/webkit.py:
1047         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
1048         Windows-style path before passing it to DRT.
1049
1050 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
1051
1052         webkitpy: revamp version checking
1053         https://bugs.webkit.org/show_bug.cgi?id=75765
1054
1055         Reviewed by Adam Barth.
1056
1057         The version-checking code in webkitpy/python24/versioning seems really
1058         awkward and overdesigned, especially since we don't support python 2.4
1059         any more.
1060
1061         In addition, I am tired of getting warnings about Python 2.6 being "a
1062         newer release than what is supported" :).
1063
1064         I'm taking a page from the depot_tools python code and just creating a
1065         new webkitpy.common.version_check module that will print a message on
1066         stderr and call sys.exit() if we're running an unsupported version.
1067
1068         * Scripts/check-webkit-style:
1069         * Scripts/new-run-webkit-httpd:
1070         * Scripts/new-run-webkit-tests:
1071         * Scripts/rebaseline-chromium-webkit-tests:
1072         * Scripts/test-webkitpy:
1073         (configure_logging):
1074         (init):
1075         * Scripts/webkit-patch:
1076         (main):
1077         * Scripts/webkitpy/common/system/executive.py:
1078         (Executive._child_process_encoding):
1079         (Executive._should_encode_child_process_arguments):
1080         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
1081         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1082         * Scripts/webkitpy/python24/__init__.py: Removed.
1083         * Scripts/webkitpy/python24/versioning.py: Removed.
1084         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
1085
1086 2012-01-09  Adam Barth  <abarth@webkit.org>
1087
1088         Remove Chromium Mac CG from the flakiness dashboard
1089         https://bugs.webkit.org/show_bug.cgi?id=75873
1090
1091         Reviewed by Ojan Vafai.
1092
1093         This configuration no longer exists.
1094
1095         * TestResultServer/static-dashboards/builders.js:
1096         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1097         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1098         (testOverrideJustBuildType):
1099         (testPlatformAndBuildType):
1100
1101 2012-01-06  Adam Roben  <aroben@apple.com>
1102
1103         Print an error message when NRWT can't run Apache
1104
1105         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
1106
1107         Reviewed by Dirk Pranke.
1108
1109         * Scripts/webkitpy/layout_tests/port/base.py:
1110         (Port.check_httpd): Print an error message when Apache returns an error code instead of
1111         failing silently.
1112
1113         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1114         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
1115         run Apache.
1116         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
1117         fails.
1118
1119 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
1120
1121         [Gtk][ARM] Cross compiler buildbot is failing after r103040
1122         https://bugs.webkit.org/show_bug.cgi?id=75846
1123
1124         Reviewed by Philippe Normand.
1125
1126         * Scripts/webkitdirs.pm:
1127         (runAutogenForAutotoolsProjectIfNecessary):
1128
1129 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
1130
1131         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
1132         https://bugs.webkit.org/show_bug.cgi?id=75807
1133
1134         This patch adds a new icon to navigationbar of the Qt MiniBrowser
1135         which allows you to dynamically toggle whether touch mocking is
1136         enabled or disabled.
1137
1138         Reviewed by Tor Arne Vestbø.
1139
1140         * MiniBrowser/qt/MiniBrowser.qrc:
1141         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1142         (MiniBrowserApplication::notify):
1143         * MiniBrowser/qt/MiniBrowserApplication.h:
1144         (WindowOptions::WindowOptions):
1145         (WindowOptions::touchMockingEnabled):
1146         (WindowOptions::setTouchMockingEnabled):
1147         * MiniBrowser/qt/icons/touch.png: Added.
1148         * MiniBrowser/qt/qml/BrowserWindow.qml:
1149
1150 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1151
1152         Unreviewed. Fix make distcheck issues.
1153
1154         * MiniBrowser/gtk/GNUmakefile.am:
1155
1156 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1157
1158         Unreviewed, rolling out r104421.
1159         http://trac.webkit.org/changeset/104421
1160         https://bugs.webkit.org/show_bug.cgi?id=75816
1161
1162         Need to rebaseline some tests on Linux (Requested by noamr on
1163         #webkit).
1164
1165         * qmake/mkspecs/features/features.prf:
1166
1167 2012-01-08  Adam Barth  <abarth@webkit.org>
1168
1169         Remove support for Chromium Mac CG from garden-o-matic
1170         https://bugs.webkit.org/show_bug.cgi?id=75814
1171
1172         Reviewed by Eric Seidel.
1173
1174         This configuration no longer exists.  This patch is mostly a matter of
1175         updating config.js and removing the examples from the unit tests.
1176
1177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1180         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1181         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1182
1183 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
1184
1185         [Qt] Enable CSS_FILTERS in Qt build
1186         https://bugs.webkit.org/show_bug.cgi?id=75777
1187
1188         Add the CSS_FILTERS feature flag to Qt.
1189
1190         Reviewed by Kenneth Rohde Christiansen.
1191
1192         * qmake/mkspecs/features/features.prf:
1193
1194 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1195
1196         Categorize bots by ports instead of core/non-core separation
1197         https://bugs.webkit.org/show_bug.cgi?id=75766
1198
1199         Reviewed by Eric Seidel.
1200
1201         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
1202         (Chromium still comes before GTK and Qt).
1203
1204         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1205         (loadBuilderConfig):
1206         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1207
1208 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1209
1210         Remove the concept of core builders from webkitpy
1211         https://bugs.webkit.org/show_bug.cgi?id=75809
1212
1213         Reviewed by Ryosuke Niwa.
1214
1215         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
1216         and remove the relevant code.
1217
1218         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1219         (BuildBot.__init__):
1220         (BuildBot._matches_regexps):
1221         (BuildBot._builder_statuses_with_names_matching_regexps):
1222         (BuildBot.builder_statuses):
1223         (BuildBot.failure_map):
1224         (BuildBot._latest_builds_from_builders):
1225         (BuildBot.last_green_revision):
1226         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1227         (MockBuildBot.builder_statuses):
1228         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1229         (test_status_parsing):
1230         (test_last_green_revision):
1231         (test_last_green_revision.mock_builds_from_builders):
1232
1233 2012-01-08  Adam Barth  <abarth@webkit.org>
1234
1235         Remove Chromium Mac CG concept from webkitpy
1236         https://bugs.webkit.org/show_bug.cgi?id=75810
1237
1238         Reviewed by Ryosuke Niwa.
1239
1240         This configuration no longer exists.  We can remove all the supporting
1241         code from webkitpy.
1242
1243         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1244         (BaselineOptimizerTest.test_move_baselines):
1245         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
1246         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
1247         (BaselineOptimizerTest.test_common_directory_includes_root):
1248         (BaselineOptimizerTest.test_complex_shadowing):
1249         * Scripts/webkitpy/common/config/build.py:
1250         (_should_file_trigger_build):
1251         * Scripts/webkitpy/common/config/build_unittest.py:
1252         (ShouldBuildTest):
1253         * Scripts/webkitpy/layout_tests/port/builders.py:
1254         * Scripts/webkitpy/layout_tests/port/chromium.py:
1255         (ChromiumPort):
1256         (ChromiumPort._generate_all_test_configurations):
1257         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1258         (_default_tests_paths):
1259         (ChromiumGpuLinuxPort.tests):
1260         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1261         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
1262         (ChromiumGpuTest.assert_port_works):
1263         (ChromiumGpuTest.test_baseline_paths):
1264         (ChromiumGpuTest.test_graphics_type):
1265         (ChromiumGpuTest.test_default_tests_paths):
1266         (ChromiumGpuTest.test_test_files):
1267         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1268         (ChromiumMacPort):
1269         (ChromiumMacPort.__init__):
1270         (ChromiumMacPort.baseline_search_path):
1271         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1272         (ChromiumMacPortTest.test_graphics_type):
1273         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1274         (ChromiumPortTest.test_all_test_configurations):
1275         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1276         * Scripts/webkitpy/layout_tests/port/factory.py:
1277         (PortFactory._port_name_from_arguments_and_options):
1278         (PortFactory.get):
1279         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1280         (FactoryTest.test_chromium_gpu_mac):
1281         (FactoryTest.test_chromium_mac):
1282         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1283         (GetGoogleChromePortTest._verify_expectations_overrides):
1284         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1285         (MockChromiumDRTTest.test_chromium_parse_options):
1286         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1287         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1288         (test_url_fetcher):
1289         (test_zip_factory):
1290         (test_archive):
1291         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1292         (TestRebaseline.test_rebaseline_expectations):
1293
1294 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1295
1296         Categorize bots by ports instead of core/non-core separation
1297         https://bugs.webkit.org/show_bug.cgi?id=75766
1298
1299         Reviewed by Adam Barth.
1300
1301         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
1302
1303         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1304         (loadBuilderConfig):
1305         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1306
1307 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1308
1309         Unreviewed, rolling out r104403.
1310         http://trac.webkit.org/changeset/104403
1311         https://bugs.webkit.org/show_bug.cgi?id=75803
1312
1313         It broke all tests on Qt5 (Requested by Ossy_weekend on
1314         #webkit).
1315
1316         * qmake/mkspecs/features/features.prf:
1317
1318 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
1319
1320         [Qt] Enable CSS_FILTERS in Qt build
1321         https://bugs.webkit.org/show_bug.cgi?id=75777
1322
1323         Add the CSS_FILTERS feature flag to Qt.
1324
1325         Reviewed by Kenneth Rohde Christiansen.
1326
1327         * qmake/mkspecs/features/features.prf:
1328
1329 2012-01-04  Kentaro Hara  <haraken@chromium.org>
1330
1331         Rewrite the CSS parser of prepare-ChangeLog with unittests.
1332         https://bugs.webkit.org/show_bug.cgi?id=75202
1333
1334         Reviewed by David Kilzer.
1335
1336         The current CSS parser can just parse simple CSSes like
1337
1338             foo bar baz {
1339                 property1: value;
1340                 property2: value;
1341             }
1342
1343         , and cannot parse comments nor a CSS in which a selector and {
1344         appears in different lines. This patch rewrites the CSS parser
1345         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
1346         shown in css_unittests.css.
1347
1348         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
1349
1350         * Scripts/prepare-ChangeLog:
1351         (get_selector_line_ranges_for_css):
1352         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1353         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
1354         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
1355         (element1):
1356         (element2):
1357         (element3):
1358         (element4.p):
1359         (element5.p.q.r.s):
1360         (element6#p):
1361         (element7 element8):
1362         (element9.p element10.q):
1363         (element11#p element12#q):
1364         (element13, element14):
1365         (.p):
1366         (#p):
1367         (.p element15 #q element16.r element17#s):
1368         (element18:target):
1369         (element19):
1370         (element20):
1371         (element21):
1372         (element22):
1373
1374 2012-01-04  Kentaro Hara  <haraken@chromium.org>
1375
1376         The Perl parser of prepare-ChangeLog can parse here-documents
1377         https://bugs.webkit.org/show_bug.cgi?id=73208
1378
1379         Reviewed by David Kilzer.
1380
1381         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
1382         which results in wrong subroutine names in ChangeLogs.
1383         With this patch, prepare-ChangeLog can judge whether the line of "}"
1384         is the end of a subroutine or a line inside a here-document.
1385
1386         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
1387
1388         * Scripts/prepare-ChangeLog:
1389         (get_function_line_ranges_for_perl):
1390         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1391         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1392         Added test cases for here-documents.
1393         (func7):
1394         (func8):
1395         (func9):
1396         (func10):
1397         (func11):
1398         (func12):
1399         (func13):
1400         (func14):
1401         (func15):
1402         (func16):
1403
1404 2012-01-08  Kentaro Hara  <haraken@chromium.org>
1405
1406         Add unittests for the JavaScript parser of prepare-ChangeLog
1407         https://bugs.webkit.org/show_bug.cgi?id=75201
1408
1409         Reviewed by David Kilzer.
1410
1411         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
1412         of prepare-ChangeLog.
1413
1414         * Scripts/prepare-ChangeLog:
1415         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
1416         omitted from parsing. Thus,
1417
1418             str = "foo"
1419             function func() {
1420             }
1421
1422         was recognized as equivalent to
1423
1424             str = function func() {
1425             }
1426
1427         This patch replaces a string with a dummy identifier 'string_appeared_here'
1428         to tell the parser that a string appeared there.
1429
1430         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1431         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
1432         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
1433         (func1):
1434         (func2):
1435         (func3):
1436         (func4):
1437         (func5):
1438         (func6):
1439         (func7):
1440         (func8):
1441         (func9):
1442         (func10):
1443         (func11):
1444         (func12):
1445         (funcOverloaded):
1446         (Func1.prototype.get x1):
1447         (Func1.prototype.get x2):
1448         (Func1.prototype.set x1):
1449         (Func1.prototype.set x3):
1450         (Func2.prototype.func13):
1451         (Func2.prototype.func14):
1452         (Func2.prototype.func15):
1453         (func16.func17):
1454         (func16.func18):
1455         (func16.func19):
1456         (func16):
1457
1458 2012-01-08  David Levin  <levin@chromium.org>
1459
1460         [chromium] Add layout test support for autosize code in FrameView.
1461         https://bugs.webkit.org/show_bug.cgi?id=73631
1462
1463         Reviewed by Dmitry Titov.
1464
1465         * DumpRenderTree/chromium/LayoutTestController.cpp:
1466         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
1467         (LayoutTestController::reset): Set the autoresize mode back to false.
1468         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
1469         * DumpRenderTree/chromium/LayoutTestController.h:
1470         * DumpRenderTree/chromium/WebViewHost.cpp:
1471         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
1472         * DumpRenderTree/chromium/WebViewHost.h:
1473
1474 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
1475
1476         [WK2][GTK] Each test takes roughly half a second to load
1477         https://bugs.webkit.org/show_bug.cgi?id=70699
1478
1479         Reviewed by Martin Robinson.
1480
1481         Set the XDG_CACHE_HOME environment variable when testing with
1482         WebKitTestRunner. This way the testing is started with a non-existing
1483         application cache. If the cache exists and is not empty, the emptying
1484         and vacuuming that is performed before every test can consume a lot of
1485         time.
1486
1487         This is just a temporary workaround until it becomes possible to set
1488         a desired directory to be used as the application cache location through
1489         WebKitWebContext.
1490
1491         * Scripts/webkitpy/layout_tests/port/gtk.py:
1492         (GtkPort.setup_environ_for_server):
1493
1494 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
1495
1496         [GTK] Enable requestAnimationFrame in build-webkit
1497         https://bugs.webkit.org/show_bug.cgi?id=75773
1498
1499         Reviewed by Martin Robinson.
1500
1501         Enable requestAnimationFrame for the Gtk port.
1502
1503         * Scripts/build-webkit:
1504
1505 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
1506
1507         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
1508
1509         * Scripts/webkitdirs.pm:
1510         (buildChromium):
1511         Missing parentheses.
1512
1513 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1514
1515         Fix DRT build on case-sensitive file systems.
1516
1517         Fix case of include of WebDynamicScrollBarsView.h
1518         
1519         * DumpRenderTree/mac/DumpRenderTree.mm:
1520
1521 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1522
1523         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
1524         https://bugs.webkit.org/show_bug.cgi?id=75662
1525
1526         Reviewed by Dan Bernstein.
1527         
1528         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
1529         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
1530         test window uses the main display's color space, so that the pixel values in the bitmap
1531         that gets checksummed are identical to the CSS colors.
1532         
1533         Removed the code that switches the display profile in DRT, since that is no longer required.
1534
1535         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
1536         * DumpRenderTree/mac/DumpRenderTree.mm:
1537         (crashHandler): Remove code that switches display profiles.
1538         (prepareConsistentTestingEnvironment): Ditto.
1539         (dumpRenderTree): Ditto.
1540         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
1541         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
1542         (createBitmapContextFromWebView): Add comment about the colorspace handling.
1543         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1544         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
1545         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
1546         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1547         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
1548         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
1549
1550 2012-01-06  David Kilzer  <ddkilzer@apple.com>
1551
1552         run-api-tests: specify individual suites and tests on the command-line
1553
1554         Reviewed by Adam Roben.
1555
1556         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
1557
1558         The run-api-tests script will now accept a list of arguments on
1559         the command-line that are used as prefix filters.  To run all
1560         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
1561         use:
1562
1563             $ run-api-tests WTF
1564
1565         To run only the tests in the "WTF" suite, not the "WTF_Vector"
1566         suite, use:
1567
1568             $ run-api-tests WTF.
1569
1570         * Scripts/run-api-tests: Filter tests if any prefix arguments
1571         are passed on the command-line.
1572
1573 2012-01-06  David Kilzer  <ddkilzer@apple.com>
1574
1575         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
1576
1577         Reviewed by Adam Roben.
1578
1579         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
1580
1581         * Scripts/run-api-tests:
1582         (dumpTestsBySuite): Update to accept array of tests instead of
1583         hash data structure.
1584         (runTestsBySuite): Ditto.
1585         (listAllTests): Rename from populateTests().  Update to return
1586         an array of tests instad of the hash data structure.
1587
1588 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1589
1590         webkitpy: clean up test/uri conversion routines
1591         https://bugs.webkit.org/show_bug.cgi?id=75648
1592
1593         Reviewed by Eric Seidel.
1594
1595         This change moves test_to_uri and uri_to_test from the Port
1596         class to the Driver class (the routines were only being
1597         called by the drivers), and removes a bunch of stale and/or
1598         busted logic.
1599
1600         * Scripts/webkitpy/layout_tests/port/base.py:
1601         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1602         * Scripts/webkitpy/layout_tests/port/chromium.py:
1603         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1604         * Scripts/webkitpy/layout_tests/port/driver.py:
1605         (is_http_test):
1606         (test_to_uri):
1607         (uri_to_test):
1608         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1609         (run_one_test):
1610         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1611         (MockDRTTest.input_line):
1612         (input_line):
1613         (expected_output):
1614         * Scripts/webkitpy/layout_tests/port/test.py:
1615         * Scripts/webkitpy/layout_tests/port/webkit.py:
1616         (_command_from_driver_input):
1617
1618 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1619
1620         Mitigate scrollbar differences when running pixel tests
1621         https://bugs.webkit.org/show_bug.cgi?id=67217
1622
1623         Reviewed by Dan Bernstein.
1624         
1625         Add an NSScroller subclass that draws mock scrollbars identically
1626         to the WebCore mock scrollbar theme, and register it with the
1627         WebDynamicScrollbarsView.
1628
1629         * DumpRenderTree/mac/DumpRenderTree.mm:
1630         (-[DRTMockScroller rectForPart:]):
1631         (-[DRTMockScroller drawKnob]):
1632         (-[DRTMockScroller drawRect:]):
1633         (registerMockScrollbars):
1634         (prepareConsistentTestingEnvironment):
1635
1636 2012-01-05  Jon Lee  <jonlee@apple.com>
1637
1638         Update DRT on Mac to draw resize handles on text areas.
1639
1640         Reviewed by John Sullivan.
1641
1642         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
1643         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
1644
1645         * DumpRenderTree/mac/DumpRenderTree.mm:
1646         (resetDefaultsToConsistentValues):
1647
1648 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1649
1650         [Qt] Move listing of include paths and libs to pri files in sources
1651
1652         Includepaths are sometimes modified by non-Qt contributors so keeping
1653         them in files inside Sources makes it more likely that they are updated
1654         along with project files for the other ports.
1655
1656         Using pri files instead of prf files for this also has the benefit that
1657         the include() from the main target file can be parsed and followed by
1658         Qt Creator -- something that does not work with load().
1659
1660         Dependency from a target to a library through the WEBKIT variable are
1661         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
1662         set the source root of the module and include the right pri file.
1663
1664         Ideally we'd use the variant of include() that takes an optional
1665         namespace to read the variables into, or the fromfile() function,
1666         but both of these add an overhead of about 40% on the total qmake
1667         runtime, due to making a deep copy of all the variables in the
1668         project or re-reading all the prf files from scratch.
1669
1670         Reviewed by Simon Hausmann.
1671         Reviewed by Ossy.
1672
1673         * qmake/mkspecs/features/default_post.prf:
1674         * qmake/mkspecs/modules/javascriptcore.prf: Added.
1675         * qmake/mkspecs/modules/webcore.prf: Added.
1676         * qmake/mkspecs/modules/webkit2.prf: Added.
1677         * qmake/mkspecs/modules/wtf.prf: Added.
1678
1679 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
1680
1681         [EFL] Add pre-render handling code in EWebLauncher.
1682         https://bugs.webkit.org/show_bug.cgi?id=73430
1683
1684         Reviewed by Zoltan Herczeg.
1685
1686         Add pre-render handling code by pressing Insert key.
1687
1688         * EWebLauncher/main.c:
1689         (on_key_down):
1690
1691 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
1692
1693         NRWT should use test_expectation.txt on wk2 platforms
1694         https://bugs.webkit.org/show_bug.cgi?id=75417
1695
1696         Reviewed by Dirk Pranke.
1697
1698         * Scripts/webkitpy/layout_tests/port/webkit.py:
1699         (path_to_test_expectations_file):
1700         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1701         (test_path_to_test_expectations_file):
1702
1703 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
1704
1705         Don't hardcode expected file URIs in as they depend on the platform
1706         https://bugs.webkit.org/show_bug.cgi?id=75666
1707
1708         Reviewed by Dirk Pranke.
1709
1710         * Scripts/webkitpy/layout_tests/port/win.py:
1711         (WinPort.show_results_html_file):
1712         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1713         (MainTest.test_unexpected_failures):
1714         (MainTest.test_results_directory_default):
1715         (MainTest.test_results_directory_relative):
1716
1717 2012-01-05  Anders Carlsson  <andersca@apple.com>
1718
1719         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
1720         https://bugs.webkit.org/show_bug.cgi?id=75667
1721         <rdar://problem/10389454>
1722
1723         Reviewed by Kevin Decker.
1724
1725         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
1726
1727         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1728         (PluginTest::executeScript):
1729         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1730         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
1731         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
1732         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
1733         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
1734
1735 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1736
1737         webkitpy: clean up port factory methods
1738         https://bugs.webkit.org/show_bug.cgi?id=75590
1739
1740         Reviewed by Eric Seidel.
1741
1742         This change consolidates much of the "factory method" logic
1743         of determining which port objects to create for a given set
1744         of configurations by merging the separate factory methods in
1745         chromium_gpu and google_chrome into PortFactory so that at least
1746         all of the logic is in one place.
1747
1748         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1749         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1750         * Scripts/webkitpy/layout_tests/port/factory.py:
1751         (_port_name_from_arguments_and_options):
1752         (get):
1753         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1754         (test_google_chrome):
1755         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1756         (GoogleChromeLinux32Port):
1757         (GoogleChromeLinux32Port.baseline_search_path):
1758         (test_expectations_overrides):
1759         (architecture):
1760         (GoogleChromeLinux64Port):
1761         (GoogleChromeLinux64Port.baseline_search_path):
1762         (GoogleChromeMacPort):
1763         (GoogleChromeMacPort.baseline_search_path):
1764         (GoogleChromeWinPort):
1765         (GoogleChromeWinPort.baseline_search_path):
1766         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1767         (_verify_baseline_path):
1768
1769 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
1770
1771         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
1772         https://bugs.webkit.org/show_bug.cgi?id=75617
1773
1774         Reviewed by Dirk Pranke.
1775
1776         * Scripts/webkitpy/common/system/filesystem.py:
1777         (FileSystem.exists):
1778         * Scripts/webkitpy/common/system/filesystem_mock.py:
1779         (MockFileSystem.exists):
1780         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1781         (GenericFileSystemTests.teardown_generic_test_dir):
1782         * Scripts/webkitpy/layout_tests/port/base.py:
1783         (Port.to.show_results_html_file):
1784         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1785         (MainTest.test_results_directory_absolute):
1786
1787 2012-01-05  Adam Roben  <aroben@apple.com>
1788
1789         Remove some unnecessary code from old-run-webkit-tests
1790
1791         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
1792         WebKitTestRunner.
1793
1794         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
1795         Windows
1796
1797         Reviewed by Eric Seidel.
1798
1799         * Scripts/old-run-webkit-tests:
1800         (top level):
1801         (openDumpTool):
1802         Removed calls to setPathForRunningWebKitApp.
1803
1804 2012-01-05  Adam Roben  <aroben@apple.com>
1805
1806         Teach NRWT to use run-safari to open results.html on Apple's Windows port
1807
1808         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
1809         better, since we always want to open results.html using the user's build of WebKit, not
1810         whatever their default browser is.
1811
1812         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
1813         for Apple's Windows port
1814
1815         Reviewed by Eric Seidel.
1816
1817         * Scripts/webkitpy/layout_tests/port/win.py:
1818         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
1819         an obsolete comment.
1820
1821         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1822         (WinPortTest.test_show_results_html_file): Updated expected results.
1823
1824 2012-01-05  Adam Roben  <aroben@apple.com>
1825
1826         Prepend Safari.exe's path to the command-line passed to CreateProcess
1827
1828         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
1829         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
1830         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
1831         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
1832         first argument that WebKitLauncherWin was trying to pass to it.
1833
1834         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
1835
1836         Reviewed by Steve Falkenburg.
1837
1838         * WebKitLauncherWin/WebKitLauncherWin.cpp:
1839         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
1840         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
1841
1842 2012-01-05  Adam Roben  <aroben@apple.com>
1843
1844         Stop using explicit memory management in WebKitLauncherWin
1845
1846         We now use stack-allocated STL objects instead.
1847
1848         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
1849         Safari
1850
1851         Reviewed by Steve Falkenburg.
1852
1853         * WebKitLauncherWin/WebKitLauncherWin.cpp:
1854         (getStringValue):
1855         (applePathFromRegistry):
1856         (safariInstallDir):
1857         (safariBrowserExe):
1858         (_tWinMain):
1859         Changed to use stack-allocated STL objects instead of malloc/free.
1860
1861 2012-01-05  Adam Roben  <aroben@apple.com>
1862
1863         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
1864
1865         This allows us to add the Safari and Apple Application Support directories to PATH before
1866         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
1867
1868         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
1869         Windows port of DumpRenderTree/WebKitTestRunner
1870
1871         Reviewed by Steve Falkenburg.
1872
1873         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
1874         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
1875
1876         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1877         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1878         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
1879
1880         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
1881         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
1882         the stub launcher.
1883
1884         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
1885         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
1886         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
1887         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
1888         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
1889         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
1890         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
1891
1892         * WebKitTestRunner/win/main.cpp:
1893         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
1894
1895 2012-01-05  Adam Roben  <aroben@apple.com>
1896
1897         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
1898
1899         This allows us to add the Safari and Apple Application Support directories to PATH before
1900         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
1901
1902         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
1903         Windows port of DumpRenderTree/WebKitTestRunner
1904
1905         Reviewed by Steve Falkenburg.
1906
1907         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
1908         which I forgot to add to this .sln when that project was created.
1909
1910         * DumpRenderTree/win/DumpRenderTree.cpp:
1911         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
1912
1913         * DumpRenderTree/win/DumpRenderTree.vcproj:
1914         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1915         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
1916
1917         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
1918         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
1919         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
1920         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
1921         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
1922         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
1923         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
1924         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
1925
1926         * win/DLLLauncher/DLLLauncherMain.cpp:
1927         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
1928         Safari's directory to PATH so that SafariTheme.dll can be found.
1929
1930         (main):
1931         (wWinMain):
1932         Changed to use the new modifyPath function.
1933
1934 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
1935
1936         [Qt] Never enable FontConfig on Mac OS X
1937         https://bugs.webkit.org/show_bug.cgi?id=75616
1938
1939         Reviewed by Tor Arne Vestbø.
1940
1941         * qmake/mkspecs/features/features.prf:
1942
1943 2012-01-05  Alpha Lam  <hclam@chromium.org>
1944
1945         Unreviewed, rolling out r104159.
1946         http://trac.webkit.org/changeset/104159
1947         https://bugs.webkit.org/show_bug.cgi?id=75590
1948
1949         Chromium port GPU tests cannot be executed.
1950
1951         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1952         (get):
1953         (_default_tests_paths):
1954         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1955         (ChromiumGpuTest.assert_port_works):
1956         * Scripts/webkitpy/layout_tests/port/factory.py:
1957         (PortFactory._port_name_from_arguments_and_options):
1958         (PortFactory):
1959         (PortFactory._get_kwargs):
1960         (PortFactory.get):
1961         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1962         (FactoryTest.test_google_chrome.names):
1963         (FactoryTest.test_google_chrome):
1964         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1965         (GetGoogleChromePort):
1966         (GetGoogleChromePort.GoogleChromeLinux32Port):
1967         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
1968         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
1969         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
1970         (GetGoogleChromePort.GoogleChromeLinux64Port):
1971         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
1972         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
1973         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
1974         (GetGoogleChromePort.GoogleChromeMacPort):
1975         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
1976         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
1977         (GetGoogleChromePort.GoogleChromeWinPort):
1978         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
1979         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
1980         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1981         (GetGoogleChromePortTest._verify_baseline_path):
1982         (GetGoogleChromePortTest._verify_expectations_overrides):
1983
1984 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1985
1986         webkitpy: clean up port factory methods
1987         https://bugs.webkit.org/show_bug.cgi?id=75590
1988
1989         Reviewed by Eric Seidel.
1990
1991         This change consolidates much of the "factory method" logic
1992         of determining which port objects to create for a given set
1993         of configurations by merging the separate factory methods in
1994         chromium_gpu and google_chrome into PortFactory so that at least
1995         all of the logic is in one place.
1996
1997         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1998         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1999         * Scripts/webkitpy/layout_tests/port/factory.py:
2000         (_port_name_from_arguments_and_options):
2001         (get):
2002         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2003         (test_google_chrome):
2004         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2005         (GoogleChromeLinux32Port):
2006         (GoogleChromeLinux32Port.baseline_search_path):
2007         (test_expectations_overrides):
2008         (architecture):
2009         (GoogleChromeLinux64Port):
2010         (GoogleChromeLinux64Port.baseline_search_path):
2011         (GoogleChromeMacPort):
2012         (GoogleChromeMacPort.baseline_search_path):
2013         (GoogleChromeWinPort):
2014         (GoogleChromeWinPort.baseline_search_path):
2015         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2016         (_verify_baseline_path):
2017
2018 2012-01-04  Adam Roben  <aroben@apple.com>
2019
2020         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
2021
2022         This allows us to add the Apple Application Support directory to PATH before trying to load
2023         WebKit so that CoreGraphics.dll and friends can be found.
2024
2025         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
2026
2027         Reviewed by Anders Carlsson.
2028
2029         * DumpRenderTree/win/ImageDiff.vcproj:
2030         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2031         Changed to build ImageDiff.dll instead of ImageDiff.exe.
2032
2033         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
2034         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
2035
2036         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
2037         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
2038         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
2039         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
2040         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
2041         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
2042         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
2043
2044         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
2045         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
2046         to main.
2047
2048         * win/DLLLauncher/DLLLauncherMain.cpp:
2049         (main):
2050         (wWinMain):
2051         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
2052         stub launcher acts as a console program and calls a console version of
2053         dllLauncherEntryPoint.
2054
2055 2012-01-04  Adam Roben  <aroben@apple.com>
2056
2057         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
2058
2059         This allows us to add the Apple Application Support directory to PATH before trying to load
2060         WebKit so that CoreGraphics.dll and friends can be found.
2061
2062         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
2063         double-clicked
2064
2065         Reviewed by Anders Carlsson.
2066
2067         * MiniBrowser/MiniBrowser.vcproj:
2068         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2069         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
2070
2071         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
2072         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
2073         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
2074         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
2075         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
2076         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
2077         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
2078
2079         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
2080         but changed to build the stub launcher.
2081
2082         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
2083         it needs to be compiled into the .exe instead of the .dll.
2084         (DllMain): Added. We use this to store the DLL's HINSTANCE.
2085         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
2086         DLLLauncherMain code.
2087
2088         * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
2089         to here.
2090
2091 2012-01-04  Adam Roben  <aroben@apple.com>
2092
2093         Make WinLauncher's window frame respond to clicks/drags again
2094
2095         Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
2096         bar when Aero is disabled
2097
2098         Reviewed by Brent Fulgham.
2099
2100         * WinLauncher/WinLauncher.cpp:
2101         (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
2102         Also removed an unnecessary "break" keyword.
2103
2104 2012-01-04  Adam Roben  <aroben@apple.com>
2105
2106         Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
2107
2108         This allows us to add the Apple Application Support directory to PATH before trying to load
2109         WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
2110         should use this mechanism.
2111
2112         Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
2113         double-clicked
2114
2115         Reviewed by Anders Carlsson.
2116
2117         * WinLauncher/WinLauncher.cpp: Removed InitInstance.
2118         (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
2119         done by the now-removed InitInstance function.
2120         (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
2121         calls. Merged code from InitInstance into this function, and change to use the global hInst
2122         variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
2123         function, which corresponds to WinLauncher.exe.
2124
2125         * WinLauncher/WinLauncher.vcproj:
2126         * WinLauncher/WinLauncherCommon.vsprops:
2127         Changed to build WinLauncher.dll instead of WinLauncher.exe.
2128
2129         * WinLauncher/WinLauncherLauncher.rc: Added.
2130         * WinLauncher/WinLauncherLauncherResource.h: Added.
2131         This just references the WinLauncher.ico file to set the application icon (though it looks
2132         like that's a default icon).
2133
2134         * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
2135         but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
2136
2137         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
2138         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
2139         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
2140         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
2141         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
2142         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
2143         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
2144
2145         * win/DLLLauncher/DLLLauncherMain.cpp: Added.
2146         (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
2147         program if it detects heap corruption.
2148         (getStringValue): Helper function to read a string value from the registry.
2149         (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
2150         application from the registry.
2151         (appleApplicationSupportDirectory): Helper function to return the path to the Apple
2152         Application Support directory.
2153         (copyEnvironmentVariable): Helper function to copy an environment variable's value.
2154         (prependPath): Helper function to prepend a directory to the PATH.
2155         (fatalError): Helper function to display an error to the user.
2156         (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
2157         dllLauncherEntryPoint function.
2158
2159 2012-01-05  Kentaro Hara  <haraken@chromium.org>
2160
2161         prepare-ChangeLog cannot parse python code that nests classes and defs
2162         https://bugs.webkit.org/show_bug.cgi?id=75524
2163
2164         Reviewed by Ryosuke Niwa.
2165
2166         This patch fixes the python parser of prepare-ChangeLog so that it can parse
2167         python code that nests classes and defs, like this:
2168
2169         class C:
2170             pass
2171             def f():
2172                 pass
2173             pass
2174
2175         Also, this patch fixes the python parser so that it inserts a dummy line
2176         at the end of the file to pop out all popped scopes.
2177
2178         * Scripts/prepare-ChangeLog:
2179         (get_function_line_ranges_for_python):
2180
2181         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
2182         Added test cases that nest classes and defs.
2183         (func7):
2184         (func7.func8):
2185         (func7.func8.func9):
2186         (Class2):
2187         (Class2.Class3):
2188         (Class2.Class3.Class4):
2189         (Class5):
2190         (Class5.func10):
2191         (Class5.func11):
2192         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
2193
2194 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2195
2196         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
2197         https://bugs.webkit.org/show_bug.cgi?id=75433
2198
2199         Reviewed by Martin Robinson.
2200
2201         * MiniBrowser/gtk/BrowserWindow.c:
2202         (webViewLoadFailed): Reset the progress bar when load fails.
2203         (browserWindowConstructed): Connect to load-failed signal.
2204
2205 2012-01-04  Dan Bernstein  <mitz@apple.com>
2206
2207         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
2208         start WebProcess under gdb and WebProcess will then run the client executable.
2209
2210         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
2211
2212         Reviewed by Anders Carlsson.
2213
2214         * Scripts/webkitdirs.pm:
2215         (shouldTargetWebProcess): Added.
2216         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
2217         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
2218         app using the -client-executable option if targeting the web process.
2219
2220 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2221
2222         Adding myself to committers list.
2223
2224         Unreviewed.
2225
2226         * Scripts/webkitpy/common/config/committers.py:
2227
2228 2012-01-04  David Kilzer  <ddkilzer@apple.com>
2229
2230         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
2231
2232         This reverts commit r103546.
2233
2234         * TestWebKitAPI/TestsController.cpp:
2235         (TestWebKitAPI::TestsController::TestsController):
2236
2237 2012-01-04  James Robinson  <jamesr@chromium.org>
2238
2239         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
2240         https://bugs.webkit.org/show_bug.cgi?id=74583
2241
2242         Reviewed by Darin Fisher.
2243
2244         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
2245
2246         * Scripts/webkitpy/style/checkers/cpp.py:
2247         (check_function_definition):
2248
2249 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2250
2251         [Qt] Fix link order of static libraries and unbreak QtWin32
2252
2253         We were keeping the correct static link order between the intermediate
2254         WebKit libraries, but not the internal dependencies for each of those
2255         libraries. The load() will in some instances mess with LIBS, so we need
2256         to ensure that the dependent libraries are added after the library we
2257         are linking against.
2258
2259         Reviewed by Simon Hausmann.
2260
2261         * qmake/mkspecs/features/default_post.prf:
2262
2263 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2264
2265         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
2266
2267         The custom qmake variable 'WEBKIT' is used for signaling that a
2268         target depends in some way on other subproject of the WebKit
2269         project. For now this is limited to the set of intermediate
2270         libraries: wtf, javascriptcore, webcore, and webkit2.
2271
2272         This replaces the previous convension of using load(foo) for
2273         just include paths, and CONFIG += foo to also link against foo.
2274
2275         Adding a dependency results in additional include paths being
2276         available, and potentially linking to the library. This is
2277         decided by the build system based on conditions such as what
2278         kind of target is being built and the general build config.
2279
2280         An advantage to his approach is that it simplifies the individual
2281         foo.prf files, for example by allowing us to use INCLUDEPATH +=
2282         and LIBS += as normal instead of prepending.
2283
2284         Reviewed by Simon Hausmann.
2285
2286         * DumpRenderTree/qt/DumpRenderTree.pro:
2287         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2288         * QtTestBrowser/QtTestBrowser.pro:
2289         * WebKitTestRunner/InjectedBundle/Target.pri:
2290         * WebKitTestRunner/Target.pri:
2291         * qmake/README:
2292         * qmake/mkspecs/features/default_post.prf:
2293         * qmake/mkspecs/features/functions.prf:
2294         * qmake/mkspecs/features/javascriptcore.prf:
2295         * qmake/mkspecs/features/qtwebkit.prf:
2296         * qmake/mkspecs/features/webcore.prf:
2297         * qmake/mkspecs/features/webkit2.prf:
2298         * qmake/mkspecs/features/wtf.prf:
2299
2300 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
2301
2302         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
2303         https://bugs.webkit.org/show_bug.cgi?id=75488
2304
2305         Reviewed by Tor Arne Vestbø.
2306
2307         * MiniBrowser/qt/MiniBrowser.qrc:
2308         * MiniBrowser/qt/qml/BrowserWindow.qml:
2309         * MiniBrowser/qt/qml/Dialog.qml:
2310         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
2311         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
2312
2313 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2314
2315         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
2316
2317         It wasn't really a problem at runtime since the right QtWebKit was
2318         already loaded as a dependency of the web process, but the ldd output
2319         would still be busted.
2320
2321         Reviewed by Simon Hausmann.
2322
2323         * WebKitTestRunner/InjectedBundle/Target.pri:
2324
2325 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2326
2327         [Qt] Move use of $$qtLibraryTarget() to a single place
2328
2329         Reviewed by Kenneth Rohde Christiansen.
2330
2331         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2332         * WebKitTestRunner/InjectedBundle/Target.pri:
2333         * qmake/mkspecs/features/default_post.prf:
2334         * qmake/mkspecs/features/webcore.prf:
2335
2336 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
2337
2338         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
2339         https://bugs.webkit.org/show_bug.cgi?id=75238
2340
2341         Reviewed by Antonio Gomes.
2342
2343         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
2344         it could initiate download directly if it has the download attribute in the link 
2345         and doesn't need to open new blank page for the target="_blank". Enabling this 
2346         feature in the BlackBerry porting also prepares for later blob feature implementation.
2347
2348         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
2349         for the BlackBerry porting.
2350
2351 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2352
2353         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
2354         https://bugs.webkit.org/show_bug.cgi?id=75475
2355
2356         Reviewed by Martin Robinson.
2357
2358         The problem is that the property blurb contains <a ping> and tree
2359         view uses gtk_tooltip_set_markup() internally, so we need to
2360         escape the text.
2361
2362         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2363         (browserSettingsDialogConstructed): Escape property blurb before
2364         storing it in the GtkTreeModel.
2365
2366 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
2367
2368         When showing results.html pass a correct URL to webbrowser.open
2369         https://bugs.webkit.org/show_bug.cgi?id=75438
2370
2371         Reviewed by Adam Barth.
2372
2373         * Scripts/webkitpy/common/system/filesystem.py:
2374         (file_path_as_url):
2375         * Scripts/webkitpy/common/system/filesystem_mock.py:
2376         (file_path_as_url):
2377         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2378         (test_file_path_as_url):
2379         * Scripts/webkitpy/layout_tests/port/base.py:
2380         (show_results_html_file):
2381         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2382         (test_show_results_html_file):
2383         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2384         (test_results_directory_relative):
2385
2386 2012-01-03  Ojan Vafai  <ojan@chromium.org>
2387
2388         shrink the header on the flakiness dashboard
2389         https://bugs.webkit.org/show_bug.cgi?id=65153
2390
2391         Reviewed by Adam Roben.
2392
2393         Move some of the "show" links to be to the right of the header
2394         instead of below the header when they content they're showing
2395         is hidden. That way we don't waste vertical space on them.
2396
2397         No new tests. This code is covered by existing tests.
2398
2399         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2400
2401 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2402
2403         Add a tool to analyze change logs
2404         https://bugs.webkit.org/show_bug.cgi?id=72243
2405
2406         Reviewed by Eric Seidel.
2407
2408         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
2409         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
2410         for visualizing json files.
2411
2412         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
2413         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
2414         generates json files, and N is the number of changelogs to parse.
2415
2416         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
2417         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
2418         * Scripts/webkitpy/tool/commands/__init__.py:
2419         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
2420         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
2421         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
2422         * Scripts/webkitpy/tool/steps/options.py:
2423
2424 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2425
2426         Add a tool to analyze change logs
2427         https://bugs.webkit.org/show_bug.cgi?id=72243
2428
2429         Reviewed by Eric Seidel.
2430
2431         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
2432         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
2433         for visualizing json files.
2434
2435         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
2436         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
2437         generates json files, and N is the number of changelogs to parse.
2438
2439         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
2440         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
2441         * Scripts/webkitpy/tool/commands/__init__.py:
2442         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
2443         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
2444         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
2445         * Scripts/webkitpy/tool/steps/options.py:
2446
2447 2012-01-03  Adam Roben  <aroben@apple.com>
2448
2449         Make Port subclasses override the operating_system method rather than setting an attribute
2450
2451         Without this patch, any use of Port.operating_system() within a port's __init__ method would
2452         return the default value ("mac"). This was confusing the version-checking logic inside
2453         ApplePort.__init__ on Windows.
2454
2455         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
2456         crashes on launch on Windows 7 SP1
2457
2458         Reviewed by Eric Seidel.
2459
2460         * Scripts/webkitpy/layout_tests/port/apple.py:
2461         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
2462
2463         * Scripts/webkitpy/layout_tests/port/base.py:
2464         (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
2465         should now override the operating_system method instead.
2466         (Port.operating_system): Changed to always return "mac". Subclasses should override to
2467         return something else.
2468
2469         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2470         (ChromiumLinuxPort.__init__):
2471         (ChromiumLinuxPort.operating_system):
2472         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2473         (ChromiumMacPort.__init__):
2474         (ChromiumMacPort.operating_system):
2475         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2476         (ChromiumWinPort.__init__):
2477         (ChromiumWinPort.operating_system):
2478         * Scripts/webkitpy/layout_tests/port/mac.py:
2479         (MacPort.__init__):
2480         (MacPort.operating_system):
2481         * Scripts/webkitpy/layout_tests/port/win.py:
2482         (WinPort.__init__):
2483         (WinPort.operating_system):
2484         Changed to override the operating_system method rather than setting the _operating_system
2485         attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
2486
2487         * Scripts/webkitpy/layout_tests/port/qt.py:
2488         (QtPort.__init__):
2489         (QtPort._path_to_webcore_library):
2490         Changed to use self.operating_system() instead of self._operating_system, for consistency
2491         with other Port-related code.
2492
2493         (QtPort.operating_system): Added this override of Port.operating_system that returns the
2494         value we determined in our __init__ method.
2495
2496         * Scripts/webkitpy/layout_tests/port/test.py:
2497         (TestPort.operating_system): Added this override of Port.operating_system that returns the
2498         value we determined in our __init__ method.
2499
2500         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2501         (PortTest.test_operating_system):
2502         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2503         (ChromiumLinuxPortTest.test_operating_system):
2504         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2505         (ChromiumMacPortTest.test_operating_system):
2506         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2507         (ChromiumWinPortTest.test_operating_system):
2508         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2509         (MacPortTest.test_operating_system):
2510         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2511         (QtPortTest.test_operating_system):
2512         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2513         (WinPortTest.test_operating_system):
2514         Test that all ports return the expected operating system string.
2515
2516 2012-01-03  Mario Sanchez Prada  <msanchez@igalia.com>
2517
2518         [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
2519         https://bugs.webkit.org/show_bug.cgi?id=75474
2520
2521         Reviewed by Philippe Normand.
2522
2523         * Scripts/run-gtk-tests: Ignore files whose name does not start
2524         with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
2525
2526 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
2527
2528         [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
2529         https://bugs.webkit.org/show_bug.cgi?id=75472
2530
2531         Reviewed by Tor Arne Vestbø.
2532
2533         * MiniBrowser/qt/MiniBrowser.pro:
2534         * MiniBrowser/qt/MiniBrowser.qrc:
2535         * MiniBrowser/qt/qml/BrowserWindow.qml:
2536         * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
2537
2538 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
2539
2540         [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
2541         https://bugs.webkit.org/show_bug.cgi?id=75471
2542
2543         Reviewed by Tor Arne Vestbø.
2544
2545         Add simple UI for JavaScript Alert dialogs. This patch also adds a
2546         simple DialogButton QML type and a Dialog QML type which will be
2547         reusable for other JavaScript dialogs.
2548
2549         * MiniBrowser/qt/MiniBrowser.qrc:
2550         * MiniBrowser/qt/qml/AlertDialog.qml: Added.
2551         * MiniBrowser/qt/qml/BrowserWindow.qml:
2552         * MiniBrowser/qt/qml/Dialog.qml: Added.
2553         * MiniBrowser/qt/qml/DialogButton.qml: Added.
2554
2555 2012-01-03  Rafael Brandao  <rafael.lobo@openbossa.org>
2556
2557         [Qt][WK2] MiniBrowser doesn't show url bar
2558         https://bugs.webkit.org/show_bug.cgi?id=75470
2559
2560         Reviewed by Tor Arne Vestbø.
2561
2562         * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
2563         on QtDeclarative (QTBUG-23422).
2564
2565 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2566
2567         [GTK] Simplify loader client WebKit2 GTK+ API
2568         https://bugs.webkit.org/show_bug.cgi?id=74605
2569
2570         Reviewed by Gustavo Noronha Silva.
2571
2572         * gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now
2573         private API.
2574
2575 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2576
2577         [Qt] Clean up detection of fontconfig
2578
2579         We decide in features.prf whether or not fontconfig is available, and
2580         set the HAVE_FONTCONFIG define accordingly. All leaf project files
2581         should use this define to decide whether or not to link against
2582         fontconfig, not do their own detection.
2583
2584         We don't need to add link_pkgconfig to CONFIG in each project file,
2585         as we selectivly enable that configuration in defaults_post when
2586         needed.
2587
2588         Reviewed by Ossy.
2589
2590         * DumpRenderTree/qt/DumpRenderTree.pro:
2591         * QtTestBrowser/QtTestBrowser.pro:
2592         * WebKitTestRunner/InjectedBundle/Target.pri:
2593         * qmake/mkspecs/features/unix/default_post.prf:
2594         * qmake/mkspecs/features/unix/default_pre.prf:
2595
2596 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2597
2598         [Qt] Introduce qmake replace function for the active build config
2599
2600         Reviewed by Ossy.
2601
2602         * qmake/mkspecs/features/default_post.prf:
2603         * qmake/mkspecs/features/functions.prf:
2604
2605 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2606
2607         [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()
2608         https://bugs.webkit.org/show_bug.cgi?id=75435
2609
2610         Reviewed by Martin Robinson.
2611
2612         * GNUmakefile.am: Make sure DRT links to X11.
2613         * WebKitTestRunner/GNUmakefile.am: Make sure WTR links to X11.
2614
2615 2011-12-04  Philippe Normand  <pnormand@igalia.com>
2616
2617         [WK2][GTK] WebSettings support in MiniBrowser
2618         https://bugs.webkit.org/show_bug.cgi?id=73773
2619
2620         Reviewed by Martin Robinson.
2621
2622         Patch heavily inspired from the WebKit GtkLauncher to support
2623         command-line WebSettings. Example: --enable-fullscreen=TRUE.
2624         The full list of options can be consulted with --help-websettings.
2625
2626         * MiniBrowser/gtk/main.c:
2627         (loadURI):
2628         (parseOptionEntryCallback):
2629         (isValidParameterType):
2630         (getOptionEntriesFromWebKitSettings):
2631         (addSettingsGroupToContext):
2632         (main):
2633
2634 2012-01-02  Philippe Normand  <pnormand@igalia.com>
2635
2636         [GTK] GtkLauncher settings improvements
2637         https://bugs.webkit.org/show_bug.cgi?id=75439
2638
2639         Reviewed by Martin Robinson.
2640
2641         * GtkLauncher/main.c:
2642         (filenameToURL): We can use NULL in C.
2643         (isValidParameterType): Utility function to filter GParamTypes
2644         that can be edited.
2645         (getOptionEntriesFromWebKitWebSettings): Avoid handling
2646         construct-only properties and use the isValidParameterType
2647         function. Makes the code a bit cleaner.
2648
2649 2012-01-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2650
2651         [EFL] Remove whitespace/declaration style exception
2652         https://bugs.webkit.org/show_bug.cgi?id=75424
2653
2654         Reviewed by David Levin.
2655
2656         Remove *whitespace/eclaration* style rule. However, EWebLauncher and MiniBrowser are EFL simple
2657         application. So, they still need to use EFL coding style.
2658
2659         * Scripts/webkitpy/style/checker.py:
2660
2661 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2662
2663         [GTK] Add a way to change web view settings in MiniBrowser
2664         https://bugs.webkit.org/show_bug.cgi?id=71568
2665
2666         Reviewed by Philippe Normand.
2667
2668         Add a preferences button to the toolbar that shows a dialog to
2669         change settings of the current web view. It uses a GtkTreeView
2670         with a custom cell renderer to support multiple types of values.
2671
2672         * MiniBrowser/gtk/BrowserCellRendererVariant.c: Added.
2673         (browserCellRendererVariantFinalize):
2674         (browserCellRendererVariantGetProperty):
2675         (browserCellRendererVariantSetModeForValue):
2676         (browserCellRendererVariantSetProperty):
2677         (browserCellRendererVariantGetRendererForValue):
2678         (browserCellRendererVariantCellRendererTextEdited):
2679         (browserCellRendererVariantCellRendererSpinEdited):
2680         (browserCellRendererVariantCellRendererActivate):
2681         (browserCellRendererVariantCellRendererRender):
2682         (browserCellRendererVariantCellRendererStartEditing):
2683         (browserCellRendererVariantCellRendererGetPreferredWidth):
2684         (browserCellRendererVariantCellRendererGetPreferredHeight):
2685         (browserCellRendererVariantCellRendererGetPreferredWidthForHeight):
2686         (browserCellRendererVariantCellRendererGetPreferredHeightForWidth):
2687         (browserCellRendererVariantCellRendererGetAlignedArea):
2688         (browser_cell_renderer_variant_init):
2689         (browser_cell_renderer_variant_class_init):
2690         (browser_cell_renderer_variant_new):
2691         * MiniBrowser/gtk/BrowserCellRendererVariant.h: Added.
2692         * MiniBrowser/gtk/BrowserSettingsDialog.c: Added.
2693         (cellRendererChanged):
2694         (browserSettingsDialogSetProperty):
2695         (browser_settings_dialog_init):
2696         (browserSettingsDialogConstructed):
2697         (browser_settings_dialog_class_init):
2698         (browser_settings_dialog_new):
2699         * MiniBrowser/gtk/BrowserSettingsDialog.h: Added.
2700         * MiniBrowser/gtk/BrowserWindow.c:
2701         (settingsCallback):
2702         (browser_window_init):
2703         * MiniBrowser/gtk/GNUmakefile.am:
2704         * MiniBrowser/gtk/browser-marshal.list: Added.
2705
2706 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2707
2708         [GTK] Implement create/ready-to-show/close signals in MiniBrowser
2709         https://bugs.webkit.org/show_bug.cgi?id=74711
2710
2711         Reviewed by Philippe Normand.
2712
2713         * MiniBrowser/gtk/BrowserWindow.c:
2714         (webViewClose): Destroy the window.
2715         (webViewReadyToShow): Use WindowProperties of the new view to
2716         setup and show the window.
2717         (webViewCreate): Create a new view and add it to a browser window.
2718         (browser_window_init):
2719         (browserWindowConstructed): Connect to WebKitWebView::create signal.
2720
2721 2011-12-31  Dan Bernstein  <mitz@apple.com>
2722
2723         MiniBrowser sets the WKView’s frame incorrectly
2724         https://bugs.webkit.org/show_bug.cgi?id=75393
2725
2726         Reviewed by Anders Carlsson.
2727
2728         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed Make Launchable build phase,
2729         which is not needed since the binray is linked with the frameworks search path set to the
2730         built products directory.
2731         * MiniBrowser/mac/BrowserWindowController.m:
2732         (-[BrowserWindowController awakeFromNib]): Changed to set the WKView’s frame to its
2733         container’s bounds rather than its frame.
2734         * MiniBrowser/mac/make-launchable.sh: Removed.
2735
2736 2011-12-29  Dan Bernstein  <mitz@apple.com>
2737
2738         debug-safari --no-saved-state fails to start the debugger
2739         https://bugs.webkit.org/show_bug.cgi?id=75374
2740
2741         Reviewed by Sam Weinig.
2742
2743         * Scripts/webkitdirs.pm:
2744         (execMacWebKitAppForDebugging): Pass the --args option to gdb so that it passes arguments to
2745         the executable being debugged.
2746
2747 2011-12-29  Sam Weinig  <sam@webkit.org>
2748
2749         It should be easier to iterate a Vector backwards
2750         https://bugs.webkit.org/show_bug.cgi?id=75359
2751
2752         Reviewed by Anders Carlsson.
2753
2754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2755         * TestWebKitAPI/TestWebKitAPI.gypi:
2756         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2757         Add new Vector test.
2758
2759         * TestWebKitAPI/Tests/Vector.cpp: Added.
2760         (TestWebKitAPI::TEST):
2761         Test Vector iterators, reverse_iterators and new reversed proxy.
2762
2763 2011-12-28  Dmitry Lomov  <dslomov@google.com>
2764
2765         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2766         https://bugs.webkit.org/show_bug.cgi?id=66509
2767         Just renames, merges and removal of dead code. Here are the list of renames:
2768           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2769           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2770           - WebWorkerBase merged into WebSharedWorkerImpl
2771           - NewWebWorkerBase renamed into WebWorkerBase
2772  
2773         Reviewed by David Levin.
2774
2775         * DumpRenderTree/chromium/TestWebWorker.h:
2776         (TestWebWorker::createWorker):
2777         * DumpRenderTree/chromium/WebViewHost.cpp:
2778         (WebViewHost::createWorker):
2779         * DumpRenderTree/chromium/WebViewHost.h:
2780
2781 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2782
2783         Unreviewed, rolling out r103785.
2784         http://trac.webkit.org/changeset/103785
2785         https://bugs.webkit.org/show_bug.cgi?id=75332
2786
2787         Broke builders; looks like clobbering didnt help (Requested by
2788         dslomov on #webkit).
2789
2790         * DumpRenderTree/chromium/TestWebWorker.h:
2791         (TestWebWorker::createWorker):
2792         * DumpRenderTree/chromium/WebViewHost.cpp:
2793         (WebViewHost::createWorker):
2794         * DumpRenderTree/chromium/WebViewHost.h:
2795
2796 2011-12-28  Dmitry Lomov  <dslomov@google.com>
2797
2798
2799         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2800         https://bugs.webkit.org/show_bug.cgi?id=66509
2801         Just renames, merges and removal of dead code. Here are the list of renames:
2802           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2803           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2804           - WebWorkerBase merged into WebSharedWorkerImpl
2805           - NewWebWorkerBase renamed into WebWorkerBase
2806  
2807         Reviewed by David Levin.
2808
2809         * DumpRenderTree/chromium/TestWebWorker.h:
2810         (TestWebWorker::createWorker):
2811         * DumpRenderTree/chromium/WebViewHost.cpp:
2812         (WebViewHost::createWorker):
2813         * DumpRenderTree/chromium/WebViewHost.h:
2814
2815 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2816
2817         Unreviewed, rolling out r103620.
2818         http://trac.webkit.org/changeset/103620
2819         https://bugs.webkit.org/show_bug.cgi?id=75316
2820
2821         Causes many crashes (Requested by abarth on #webkit).
2822
2823         * DumpRenderTree/chromium/LayoutTestController.cpp:
2824         (LayoutTestController::LayoutTestController):
2825         (LayoutTestController::reset):
2826         * DumpRenderTree/chromium/LayoutTestController.h:
2827         * DumpRenderTree/chromium/WebViewHost.cpp:
2828         * DumpRenderTree/chromium/WebViewHost.h:
2829
2830 2011-12-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2831
2832         Unreviewed, rolling out r103734.
2833         http://trac.webkit.org/changeset/103734
2834         https://bugs.webkit.org/show_bug.cgi?id=75278
2835
2836         Broke cr-mac (Requested by dslomov on #webkit).
2837
2838         * DumpRenderTree/chromium/TestWebWorker.h:
2839         (TestWebWorker::createWorker):
2840         * DumpRenderTree/chromium/WebViewHost.cpp:
2841         (WebViewHost::createWorker):
2842         * DumpRenderTree/chromium/WebViewHost.h:
2843
2844 2011-12-27  Dmitry Lomov  <dslomov@google.com>
2845
2846
2847         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2848         https://bugs.webkit.org/show_bug.cgi?id=66509
2849         Just renames, merges and removal of dead code. Here are the list of renames:
2850           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2851           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2852           - WebWorkerBase merged into WebSharedWorkerImpl
2853           - NewWebWorkerBase renamed into WebWorkerBase
2854  
2855         Reviewed by David Levin.
2856
2857         * DumpRenderTree/chromium/TestWebWorker.h:
2858         (TestWebWorker::createWorker):
2859         * DumpRenderTree/chromium/WebViewHost.cpp:
2860         (WebViewHost::createWorker):
2861         * DumpRenderTree/chromium/WebViewHost.h:
2862
2863 2011-12-27  Anders Carlsson  <andersca@apple.com>
2864
2865         Function should handle wrapping/unwrapping RefPtr and PassRefPtr
2866         https://bugs.webkit.org/show_bug.cgi?id=75266
2867
2868         Reviewed by Sam Weinig.
2869
2870         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2871         (TestWebKitAPI::Number::create):
2872         (TestWebKitAPI::Number::~Number):
2873         (TestWebKitAPI::Number::value):
2874         (TestWebKitAPI::Number::Number):
2875         (TestWebKitAPI::multiplyNumberByTwo):
2876         (TestWebKitAPI::TEST):
2877
2878 2011-12-24  Kentaro Hara  <haraken@chromium.org>
2879
2880         Add unittests for the C++ parser of prepare-ChangeLog
2881         https://bugs.webkit.org/show_bug.cgi?id=75191
2882
2883         Reviewed by Ryosuke Niwa.
2884
2885         cpp_unittests.cpp is the unittests for get_function_line_ranges_for_cpp()
2886         of prepare-ChangeLog.
2887
2888         * Scripts/prepare-ChangeLog:
2889         (get_function_line_ranges): Renames get_function_line_ranges_for_c()
2890         to get_function_line_ranges_for_cpp().
2891         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2892         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Added.
2893         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added.
2894         (func1):
2895         (func2):
2896         (func3):
2897         (func4):
2898         (func5):
2899         (func6):
2900         (func7):
2901         (func8):
2902         (func9):
2903         (func10):
2904         (func11):
2905         (func12):
2906         (func13):
2907         (func14):
2908         (func15):
2909         (funcOverloaded):
2910         (Class::func16):
2911         (Class1::Class2::func17):
2912         (Class2::func18):
2913         (Class2::func19):
2914         (Class2::func20):
2915         (Class2::func21):
2916         (Class2::func22):
2917         (func23):
2918         (func24):
2919         (Class2::func25):
2920         (Class1::func26):
2921         (Class2::func27):
2922         (Class3::func28):
2923         (Class7::operator+):
2924         (Class100::Class100):
2925         (Class101::~Class101):
2926         (Class102::Class102):
2927         (Class103::Class103):
2928         (Struct1::func29):
2929         (Struct2::func30):
2930         (NameSpace1::func30):
2931         (NameSpace1::NameSpace2::func31):
2932
2933 2011-12-24  Kentaro Hara  <haraken@chromium.org>
2934
2935         Add unittests for the Java parser of prepare-ChangeLog
2936         https://bugs.webkit.org/show_bug.cgi?id=75195
2937
2938         Reviewed by Ryosuke Niwa.
2939
2940         java_unittests.java is unittest cases for get_function_line_ranges_for_java()
2941         of prepare-ChangeLog.
2942
2943         * Scripts/prepare-ChangeLog:
2944         (get_function_line_ranges_for_java): Fixed a parser bug.
2945
2946             interface I
2947             {
2948                 void f()
2949                 {
2950                 }
2951             }
2952
2953         should be recognized as "I.f", and
2954
2955             class C interface I
2956             {
2957                 void f()
2958                 {
2959                 }
2960             }
2961
2962         should be recognized as "C.f".
2963         Without this patch, both are recognized as "I.f".
2964
2965         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2966         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Added.
2967         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests.java: Added.
2968         (Simple):
2969         (Simple.func1):
2970         (Simple.func2):
2971         (Simple.func3):
2972         (Simple.func4):
2973         (Simple.func5):
2974         (Simple.func6):
2975         (Simple.func7):
2976         (Simple.func8):
2977         (Simple.func9):
2978         (Simple.func10):
2979         (Simple.funcOverloaded):
2980         (Simple.func11):
2981         (Simple.func12):
2982         (Simple.func13):
2983         (Simple.func14):
2984         (Simple.func15):
2985         (Simple.func16):
2986         (Simple.func17):
2987         (Simple.func18):
2988         (Simple.func19):
2989         (Simple.func20):
2990         (Simple.func21):
2991         (Derived1):
2992         (Derived1.Derived1):
2993         (Derived1.func22):
2994         (Interface1):
2995         (Interface2):
2996         (Interface2.func23):
2997         (Derived2):
2998         (Derived2.Derived2):
2999         (Derived2.func23):
3000
3001 2011-12-24  Kentaro Hara  <haraken@chromium.org>
3002
3003         Add unittests for the Python parser of prepare-ChangeLog
3004         https://bugs.webkit.org/show_bug.cgi?id=75197
3005
3006         Reviewed by Ryosuke Niwa.
3007
3008         python_unittests.py is the unittest for get_function_line_ranges_for_python()
3009         of prepare-ChangeLog. The unittest just contains classes and defs that are not nested.
3010         This is because the current python parser is wrong, and it cannot correctly parse nested
3011         classes and defs (even one def in a class), nor class inheritance.
3012         We will fix it in another patch.
3013
3014         * Scripts/prepare-ChangeLog:
3015         (get_function_line_ranges_for_python): Ignores comment lines that starts from #.
3016         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3017         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Added.
3018         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py: Added.
3019         (func1):
3020         (func2):
3021         (func3):
3022         (funcInsideComment):
3023         (func4):
3024         (func5):
3025         (func6):
3026         (funcOverloaded):
3027         (Class1):
3028
3029 2011-12-24  Dan Bernstein  <mitz@apple.com>
3030
3031         Set SHARED_PRECOMPS_DIR when Xcode is set to use a custom build product path.
3032
3033         Reviewed by Anders Carlsson.
3034
3035         * Scripts/webkitdirs.pm:
3036         (determineBaseProductDir):
3037
3038 2011-12-24  Dan Bernstein  <mitz@apple.com>
3039
3040         Make build-webkit aware of additional Xcode build location defaults.
3041
3042         Reviewed by Anders Carlsson.
3043
3044         * Scripts/webkitdirs.pm:
3045         (determineXcodeVersion): Added. This was previously in determineBaseProductDir().
3046         (readXcodeUserDefault): Added. Factored out from determineBaseProductDir().
3047         (determineBaseProductDir): Changed to check for a custom build location
3048         style specified as an absolute location.
3049
3050 2011-12-24  Ryosuke Niwa  <rniwa@webkit.org>
3051
3052         Unreviewed, rolling out r103619.
3053         http://trac.webkit.org/changeset/103619
3054         https://bugs.webkit.org/show_bug.cgi?id=66509
3055
3056         Broke chromium clang build
3057
3058         * DumpRenderTree/chromium/TestWebWorker.h:
3059         (TestWebWorker::createWorker):
3060         * DumpRenderTree/chromium/WebViewHost.cpp:
3061         (WebViewHost::createWorker):
3062         * DumpRenderTree/chromium/WebViewHost.h:
3063
3064 2011-12-23  Daniel Bates  <dbates@webkit.org>
3065
3066         Provide option to disable Mac OS 10.7 application resume when using
3067         {debug, run}-{safari, minibrowser, test-runner, test-webkit-api}, and run-webkit-app
3068         https://bugs.webkit.org/show_bug.cgi?id=66902
3069
3070         Reviewed by David Kilzer.
3071
3072         Add an optional command line argument --no-saved-state to disable
3073         application resume (state restoration) for the session on Mac OS 10.7.
3074
3075         For instance, when debugging an issue in Safari it is useful to be able
3076         to temporarily disable application resume. Currently you can disable
3077         application resume when launching Safari from within Xcode. We should
3078         expose a similar option in our command line tools.
3079
3080         * Scripts/debug-minibrowser: Call printHelpAndExitForRunAndDebugWebKitAppIfNeeded()
3081         to print a help message and exit() if the command line argument --help was given.
3082         * Scripts/debug-safari: Ditto.
3083         * Scripts/debug-test-runner: Ditto.
3084         * Scripts/run-minibrowser: Ditto.
3085         * Scripts/run-safari: Ditto.
3086         * Scripts/run-test-runner: Ditto.
3087         * Scripts/run-test-webkit-api: Ditto.
3088         * Scripts/run-webkit-app: Ditto.
3089         * Scripts/webkitdirs.pm:
3090         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Added.
3091         (argumentsForRunAndDebugMacWebKitApp): Added.
3092         (runMacWebKitApp): If the --no-saved-state command line argument was given then
3093         disable application resume for the session.
3094         (execMacWebKitAppForDebugging): Ditto.
3095
3096 2011-12-23  Dmitry Lomov  <dslomov@google.com>
3097
3098         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
3099         https://bugs.webkit.org/show_bug.cgi?id=66509
3100         Just renames, merges and removal of dead code. Here are the list of renames:
3101           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
3102           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
3103           - WebWorkerBase merged into WebSharedWorkerImpl
3104           - NewWebWorkerBase renamed into WebWorkerBase
3105  
3106         Reviewed by David Levin.
3107
3108         * DumpRenderTree/chromium/TestWebWorker.h:
3109         (TestWebWorker::createWorker):
3110         * DumpRenderTree/chromium/WebViewHost.cpp:
3111         (WebViewHost::createWorker):
3112         * DumpRenderTree/chromium/WebViewHost.h:
3113
3114 2011-12-23  Kentaro Hara  <haraken@chromium.org>
3115
3116         Let parser_unittests.pl call different language parsers
3117         https://bugs.webkit.org/show_bug.cgi?id=75081
3118
3119         Reviewed by David Kilzer.
3120
3121         We introduced parser_unittests.pl in bug 74994 , but it is implemented
3122         to always call get_function_line_ranges_for_perl(). In order to enable unittests
3123         for other languages, this patch lets parser_unittests.pl call different language
3124         parsers depending on the languages.
3125
3126         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
3127
3128         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3129
3130 2011-12-22  Adam Roben  <aroben@apple.com>
3131
3132         Snow Leopard test fix
3133
3134         * Scripts/webkitpy/test/main.py:
3135         (Tester.run_tests): Python 2.6.1 doesn't seem to like specifying testRunner=None to
3136         unittest.main, even though that's the default. So now we explicitly specify a
3137         TextTestRunner.
3138
3139 2011-12-22  Chris Fleizach  <cfleizach@apple.com>
3140
3141         AX: attributed strings do not include AXHeading information when a link is contained within the heading
3142         https://bugs.webkit.org/show_bug.cgi?id=75059
3143
3144         Reviewed by Darin Adler.
3145
3146         Support the ability to check if an arbitrary attribute is present within an
3147         attributed string that can be retrieved through an AccessibilityTextMarkerRange.
3148
3149         * DumpRenderTree/AccessibilityUIElement.cpp:
3150         (attributedStringForTextMarkerRangeContainsAttributeCallback):
3151         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3152         (AccessibilityUIElement::getJSClass):
3153         * DumpRenderTree/AccessibilityUIElement.h:
3154         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3155         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3156         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3157         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3158         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3159         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3160         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3161         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3162
3163 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3164
3165         run-api-tests: runAllTests() and runTest() should not use global variables
3166
3167         Reviewed by Adam Roben.
3168
3169         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3170
3171         * Scripts/run-api-tests:
3172         (runTestsBySuite): Rename from runAllTests().  Add arguments for
3173         list of tests and $verbose.
3174         (runTest): Add $verbose argument.
3175
3176 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3177
3178         run-api-tests: inline runAllTestsInSuite() into runAllTests()
3179
3180         Reviewed by Adam Roben.
3181
3182         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3183
3184         In order to make it easy to run one or more individual suites,
3185         or one more individual tests, it's easier to call a single
3186         method with different data structures than individual methods.
3187
3188         * Scripts/run-api-tests:
3189         (runAllTests): Inline runAllTestsInSuite().
3190
3191 2011-12-22  Adam Roben  <aroben@apple.com>
3192
3193         Add a --xml flag to test-webkitpy
3194
3195         test-webkitpy --xml will, in addition to providing the standard text output on stdout, write
3196         JUnit-style XML files to a test-webkitpy-xml-reports subdirectory in the working directory.
3197         This is useful for working with tools that consume JUnit-style XML files.
3198
3199         Fixes <http://webkit.org/b/75090> Would like a way to generate JUnit-style XML files when
3200         running test-webkitpy
3201
3202         Reviewed by Darin Adler.
3203
3204         * Scripts/webkitpy/test/main.py:
3205         (Tester.run_tests): If the --xml flag is passed, create an XMLTestRunner and pass it to
3206         unittest.main(). Otherwise pass no test runner so that unittest will choose its own default.
3207
3208         * Scripts/webkitpy/thirdparty/__init__.py:
3209         (AutoinstallImportHook.find_module):
3210         (AutoinstallImportHook._install_xmlrunner):
3211         Added code to install unittest-xml-reporting as webkitpy.thirdparty.autoinstalled.xmlrunner.
3212         This change is untested because it's basically impossible to get a test to pass when --xml
3213         is passed to test-webkitpy (because xmlrunner will already have been imported by the time
3214         the test runs).
3215
3216 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3217
3218         TestWebKitAPI: initialize the main thread before running tests
3219         <http://webkit.org/b/75064>
3220
3221         Reviewed by Adam Roben.
3222
3223         * TestWebKitAPI/TestsController.cpp:
3224         (TestWebKitAPI::TestsController::TestsController): Call
3225         WTF::initializeMainThread() to prevent assertions in Debug
3226         builds.
3227
3228 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3229
3230         run-api-tests: dumpAllTests() should not use global variables
3231
3232         Reviewed by Adam Roben.
3233
3234         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3235
3236         * Scripts/run-api-tests: Renamed $dump to $dumpTests.
3237         (dumpTestsBySuite): Rename from dumpAllTests() and pass in
3238         global data as an argument.  Sort suite names and test names
3239         alphabetically to match output when running tests.
3240
3241 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
3242
3243         [BlackBerry] Enable blob for the BlackBerry porting
3244         https://bugs.webkit.org/show_bug.cgi?id=75074
3245
3246         Reviewed by George Staikos.
3247
3248         * Scripts/build-webkit:
3249
3250 2011-12-22  Kentaro Hara  <haraken@chromium.org>
3251
3252         Add unittests for the Perl parser of prepare-ChangeLog
3253         https://bugs.webkit.org/show_bug.cgi?id=74994
3254
3255         Reviewed by David Kilzer.
3256
3257         This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
3258
3259         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
3260
3261         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
3262         Runs unittests specified in @testFiles.
3263         You can reset expected results by specifying a --reset-results option.
3264         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
3265         Contains simple methods.
3266         (func1):
3267         (func2):
3268         (func3):
3269         (func4):
3270         (func5):
3271         (func6):
3272         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
3273         This test result is generated by the --reset-results option.
3274
3275 2011-12-21  Eric Seidel  <eric@webkit.org>
3276
3277         Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
3278         so that they appear in the bugzilla autocomplete CC list.
3279         I also removed the "radar" irc nick (which I believe does not exist)
3280         and removed the uneeded [] around the radar bugzilla email.
3281
3282         Unreviewed.
3283
3284         * Scripts/webkitpy/common/config/committers.py:
3285
3286 2011-12-21  Daniel Bates  <dbates@rim.com>
3287
3288         Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
3289         https://bugs.webkit.org/show_bug.cgi?id=74985
3290
3291         Reviewed by Eric Seidel.
3292
3293         * Scripts/build-jsc:
3294         * Scripts/webkitdirs.pm:
3295         (cmakeBasedPortName): Added.
3296
3297 2011-12-21  Daniel Bates  <dbates@rim.com>
3298
3299         Extract BlackBerry CMake arguments from build-webkit into separate function
3300         https://bugs.webkit.org/show_bug.cgi?id=74981
3301
3302         Reviewed by Rob Buis.
3303
3304         Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
3305         the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
3306         and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
3307         This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
3308         that we can pass them to the CMake build system when building JavaScriptCore.
3309
3310         * Scripts/build-webkit: Move construction of CMake argument list from here to
3311         webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
3312         since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
3313         call it from build-webkit.
3314         * Scripts/webkitdirs.pm:
3315         (blackberryCMakeArguments): Added.
3316         (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
3317         BlackBerry port.
3318
3319 2011-12-21  Daniel Bates  <dbates@webkit.org>
3320
3321         Extract WinCE CMake arguments from build-webkit into separate function
3322         https://bugs.webkit.org/show_bug.cgi?id=74983
3323
3324         Reviewed by Rob Buis.
3325
3326         Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
3327         WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
3328         This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
3329         that we can pass it to the CMake build system when building JavaScriptCore.
3330
3331         * Scripts/build-webkit:
3332         * Scripts/webkitdirs.pm:
3333         (cmakeBasedPortArguments): Added.
3334
3335 2011-12-21  Kentaro Hara  <haraken@chromium.org>
3336
3337         In prepare-ChangeLog, replace constant global variables with "use constant"
3338         https://bugs.webkit.org/show_bug.cgi?id=74992
3339
3340         Reviewed by Ryosuke Niwa.
3341
3342         This patch replaces the following constant global variables with "use constant"s.
3343             - $changeLogTimeZone
3344             - $SVN
3345             - $GIT
3346             - %supportedTestExtensions
3347
3348         * Scripts/prepare-ChangeLog:
3349         (changeLogNameFromArgs):
3350         (changeLogEmailAddressFromArgs):
3351         (resolveConflictedChangeLogs):
3352         (generateNewChangeLogs):
3353         (diffCommand):
3354         (statusCommand):
3355         (createPatchCommand):
3356         (findOriginalFileFromSvn):
3357         (determinePropertyChanges):
3358         (generateFileList):
3359         (reviewerAndDescriptionForGitCommit):
3360
3361 2011-12-20  Dirk Pranke  <dpranke@chromium.org>
3362
3363         nrwt: rename field references from _fs to _filesystem
3364         https://bugs.webkit.org/show_bug.cgi?id=74898
3365
3366         Reviewed by Adam Barth.
3367
3368         This is a simple cleanup; most of the code uses
3369         self._filesystem, but some used self._fs; this change renames
3370         the latter to the former to be more consistent.
3371
3372         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3373         (Manager.__init__):
3374         (Manager.collect_tests):
3375         (Manager._strip_test_dir_prefix):
3376         (Manager._split_into_chunks_if_necessary):
3377         (Manager.results_directory):
3378         (Manager._clobber_old_results):
3379         (Manager._upload_json_files):
3380         (Manager.print_config):
3381         (Manager._copy_results_html_file):
3382         (Manager._show_results_html_file):
3383         (Manager._log_worker_stack):
3384         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3385         (JSONLayoutResultsGenerator._normalize_results_json):
3386         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3387         (JSONResultsGeneratorBase.__init__):
3388         (JSONResultsGeneratorBase.generate_json_output):
3389         (JSONResultsGeneratorBase.generate_times_ms_file):
3390         (JSONResultsGeneratorBase.upload_json_files):
3391         (JSONResultsGeneratorBase._get_svn_revision):
3392         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3393         (Base.__init__):
3394
3395 2011-12-20  Kentaro Hara  <haraken@chromium.org>
3396
3397         Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
3398         https://bugs.webkit.org/show_bug.cgi?id=74836
3399
3400         Reviewed by David Kilzer.
3401
3402         webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
3403         This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
3404         for unit-testing of other Perl scripts. We are planning to use it for unit-testing
3405         of prepare-ChangeLog.
3406
3407         Using LoadAsModule.pm, you can load a Perl script as follows.
3408         The first argument is the arbitrary package name you want to use, and the second argument
3409         is the name of the Perl script you want to load.
3410
3411             use LoadAsModule qw(RunLeaks run-leaks);
3412             RunLeaks::someFunctionDefinedInRunLeaks(...);
3413
3414         Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
3415                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
3416                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
3417
3418         * Scripts/webkitperl/LoadAsModule.pm: Added.
3419         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
3420         (import):
3421         (readFile):
3422         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
3423         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
3424         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
3425
3426 2011-12-20  Balazs Kelemen  <kbalazs@webkit.org>
3427
3428         [Qt] WK2 Debugging quirks need some improvement
3429         https://bugs.webkit.org/show_bug.cgi?id=74859
3430
3431         Reviewed by Simon Hausmann.
3432
3433         Improvements added to make debugging WebKit2 more
3434         confortable and efficient:
3435         1. Unify debugging quirks. From now all of them are controlled
3436         by the QT_WEBKIT2_DEBUG environment variable.
3437         2. Disable crash handlers for WebKitTestRunner if debugging quirks
3438         are used to make it possible to use postmortem debugging via core dumps
3439         which is extremely useful for debugging bugs triggered by layout tests.
3440         3. Disable test timeout for WebKitTestRunner if debugging quirks
3441         are used because that makes debugging impossible.
3442
3443         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3444         (WTR::InjectedBundle::platformInitialize):
3445         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3446         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3447         * WebKitTestRunner/qt/TestControllerQt.cpp:
3448         (WTR::TestController::platformRunUntil):
3449
3450 2011-12-20  Rafael Brandao  <rafael.lobo@openbossa.org>
3451
3452         [Qt][WK2] Implement favicon support
3453         https://bugs.webkit.org/show_bug.cgi?id=71082
3454
3455         Reviewed by Simon Hausmann.
3456
3457         A favorite icon was added on MiniBrowser's url bar as example.
3458         We display a default icon when the page doesn't have an icon ready.
3459
3460         * MiniBrowser/qt/MiniBrowser.qrc:
3461         * MiniBrowser/qt/icons/favicon.png: Added.
3462         * MiniBrowser/qt/qml/BrowserWindow.qml:
3463
3464 2011-12-19  Sam Weinig  <sam@webkit.org>
3465
3466         Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
3467         https://bugs.webkit.org/show_bug.cgi?id=74907
3468
3469         Reviewed by Dan Bernstein.
3470
3471         Add ScrollByLineCommands API test.
3472
3473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3474         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
3475         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
3476
3477 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3478
3479         webkitpy: remove port.executive, port.filesystem, port.user properties
3480         https://bugs.webkit.org/show_bug.cgi?id=74896
3481
3482         Reviewed by Eric Seidel.
3483
3484         Following on the refactoring of the port and host objects, this
3485         removes the public executive, filesystem, and user properties
3486         from the Port interface (protected versions of executive and
3487         filesystem still exist). There is still some more clean up to
3488         make the code more consistent and rearrange some other files to
3489         talk to Hosts directly instead of getting them off of the Port
3490         class.
3491
3492         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3493         (Manager.__init__):
3494         (Manager.results_directory):
3495         (Manager._log_worker_stack):
3496         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3497         (ManagerTest.test_fallback_path_in_config):
3498         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3499         (_InlineManager.start_worker):
3500         (_InlineWorkerConnection.__init__):
3501         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3502         (Worker.safe_init):
3503         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3504         (TestConfiguration.from_port):
3505         * Scripts/webkitpy/layout_tests/port/base.py:
3506         (Port.__init__):
3507         (Port.tests):
3508         (Port.show_results_html_file):
3509         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3510         (PortTest.test_layout_tests_skipping):
3511         (PortTest.test_test_dirs):
3512         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3513         (_set_up_derived_options):
3514         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3515         (PerfTestsRunner.__init__):
3516         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3517         (HtmlGenerator.__init__):
3518         (HtmlGenerator.show_html):
3519         (real_main):
3520         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3521         (TestHtmlGenerator.make_generator):
3522
3523 2011-12-19  Daniel Bates  <dbates@webkit.org>
3524
3525         Pass command line arguments to GDB when debugging a Mac WebKit application
3526         https://bugs.webkit.org/show_bug.cgi?id=72829
3527
3528         Reviewed by David Kilzer.
3529
3530         Pass through any command line arguments given to debug-{safari, minibrowser}
3531         to GDB so that they may influence the application instance launched by GDB.
3532
3533         * Scripts/webkitdirs.pm:
3534         (execMacWebKitAppForDebugging):
3535
3536 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3537
3538         webkitpy: remove executive,filesystem,user parameters from Port constructor
3539         https://bugs.webkit.org/show_bug.cgi?id=74878
3540
3541         Reviewed by Eric Seidel.
3542
3543         This change concludes the refactoring that makes Host a required
3544         parameter for Port and ensures that all access to filesystem,
3545         executives, etc. is going through the Host.
3546
3547         * Scripts/webkitpy/layout_tests/port/base.py:
3548         (Port.__init__):
3549
3550 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3551
3552         webkitpy: finish refactoring port classes to make a host mandatory
3553         https://bugs.webkit.org/show_bug.cgi?id=74566
3554
3555         Reviewed by Eric Seidel.
3556
3557         This change makes all Port objects take a required (System)Host
3558         parameter, and updates the TestPort object to no longer create a
3559         mock filesystem or add files to the existing filesystem by
3560         default.
3561
3562         * Scripts/webkitpy/layout_tests/port/base.py:
3563         (Port.__init__):
3564         * Scripts/webkitpy/layout_tests/port/factory.py:
3565         (PortFactory.__init__):
3566         (PortFactory._get_kwargs):
3567         * Scripts/webkitpy/layout_tests/port/test.py:
3568         (TestInstance.__init__):
3569         (TestPort.__init__):
3570         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3571         (passing_run):
3572         (logging_run):
3573         (get_tests_run):
3574         (MainTest.test_single_file):
3575         (MainTest.test_stderr_is_saved):
3576         (MainTest.test_test_list):
3577         (MainTest.test_test_list_with_prefix):
3578         (MainTest.test_missing_and_unexpected_results):
3579         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
3580         (MainTest.test_crash_with_stderr):
3581         (MainTest.test_no_image_failure_with_image_diff):
3582         (MainTest.test_crash_log):
3583         (MainTest.test_web_process_crash_log):
3584         (MainTest.test_exit_after_n_failures_upload):
3585         (MainTest.test_results_directory_absolute):
3586         (MainTest.test_results_directory_relative):
3587         (MainTest.test_retries_directory):
3588         (MainTest.test_tolerance.get_port_for_run):
3589         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
3590         (EndToEndTest.test_end_to_end):
3591         (EndToEndTest.test_reftest_with_two_notrefs):
3592         (RebaselineTest.test_reset_results):
3593         (RebaselineTest.test_missing_results):
3594         (RebaselineTest.test_new_baseline):
3595         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3596         (Rebaseliner.__init__):
3597         (main):
3598         (real_main):
3599         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3600         (test_host_port_and_filesystem):
3601         (TestRebaseliner.make_rebaseliner):
3602         (TestRealMain.test_all_platforms):
3603         (TestHtmlGenerator.make_generator):
3604
3605 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3606
3607         webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
3608         https://bugs.webkit.org/show_bug.cgi?id=74562
3609
3610         Reviewed by Eric Seidel.
3611
3612         Apart from a minor change to style/checkers/test_expectations.py
3613         to take a host as a parameter to a TestExpectationsChecker(),
3614         there are only refactoring changes to unit tests here.
3615
3616         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3617         (TestResultWriterTest.test_reftest_diff_image):
3618         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3619         (JSONGeneratorTest._test_json_generation):
3620         (JSONGeneratorTest.test_test_timings_trie):
3621         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3622         (Base.__init__):
3623         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3624         (PortTest.make_port):
3625         (PortTest.test_layout_tests_skipping):
3626         (PortTest.test_test_dirs):
3627         (PortTest.test_additional_platform_directory):
3628         (PortTest.test_uses_test_expectations_file):
3629         (PortTest.test_find_no_paths_specified):
3630         (PortTest.test_find_one_test):
3631         (PortTest.test_find_glob):